Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
421
Archived fixes / Re: Topic merging not working anymore
« on January 26th, 2015, 01:19 PM »
On dirait que la ligne 563 devrait être plus haut dans le code... Je ferai sous peu un blame pour déterminer pourquoi ça se trouve là.
422
Archived fixes / Re: Topic merging not working anymore
« on January 26th, 2015, 01:15 PM »
Merci, je vais jeter un œil !
423
Features / Re: Language revs
« on January 25th, 2015, 09:32 PM »
[Commit revision 028ff62]
Author: Pandos (Signed-off)
Date: Sun, 25 Jan 2015 19:42:33 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 0f48366]
Author: Nao
Date: Sun, 25 Jan 2015 21:32:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Sun, 25 Jan 2015 19:42:33 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Fix for fixit :)
[Commit revision 0f48366]
Date: Sun, 25 Jan 2015 21:32:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Merge pull request #27 from Pandos/fixit
- Fix for fixit :)
424
Features / Re: Language revs
« on January 25th, 2015, 05:20 PM »
[Commit revision 5f79987]
Author: Nao
Date: Sun, 25 Jan 2015 17:20:10 +0100
Stats: 3 files changed; +4 (insertions), -4 (deletions)
Date: Sun, 25 Jan 2015 17:20:10 +0100
Stats: 3 files changed; +4 (insertions), -4 (deletions)
- Attempting to fix the link to the installer deletion process. Dunno if it'll work, honestly... But I'm hoping so? (Install.*.php)
425
Archived fixes / Re: install.php, no more. :P
« on January 23rd, 2015, 05:13 PM »
Now I'm just wondering what Pandos committed the other day... :^^;:
426
Archived fixes / Re: install.php, no more. :P
« on January 23rd, 2015, 10:20 AM »
Actually, that's exactly what the installer does... It deletes the install.php and install.sql files, and only those.
I didn't test whether I could 'simply' try to unlink the install folder itself, but it didn't matter much... Especially since the install process is now streamlined in a way that makes sure (1) install.php is never called independently ("hacking attempt"), (2) it's never called again after something is installed.
I did find a bug in the test for obgz though, it links to install.php instead of index.php so it'll probably fail all attempts... I could link to install/install.php instead and add the obgz test before the hacking attempt test, but I don't think it's worth it... I'll commit an updated version, hopefully it'll work.
As for the rest, I don't know if it's worth changing...
I didn't test whether I could 'simply' try to unlink the install folder itself, but it didn't matter much... Especially since the install process is now streamlined in a way that makes sure (1) install.php is never called independently ("hacking attempt"), (2) it's never called again after something is installed.
I did find a bug in the test for obgz though, it links to install.php instead of index.php so it'll probably fail all attempts... I could link to install/install.php instead and add the obgz test before the hacking attempt test, but I don't think it's worth it... I'll commit an updated version, hopefully it'll work.
As for the rest, I don't know if it's worth changing...
427
Features / Re: New revs
« on January 22nd, 2015, 06:46 PM »
[Commit revision 0f3cd29]
Author: Nao
Date: Thu, 22 Jan 2015 18:42:24 +0100
Stats: 1 file changed; +5 (insertions), -13 (deletions)
[Commit revision 7a94d2f]
Author: Nao
Date: Thu, 22 Jan 2015 18:46:25 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Thu, 22 Jan 2015 18:42:24 +0100
Stats: 1 file changed; +5 (insertions), -13 (deletions)
- Fixed an annoying bug causing select boxes with optgroup tags to fail selecting items properly. (sbox.js)
- If you want me to get technical, well, I spent an entire day on this annoying bug, as I was convinced it came from something else... Until I decided to try with the penultimate committed version. Uh. It's a VERY good thing that I had a comment in my source code indicating a list of slower alternative solutions for a specific test in the sbox code... Because the new version of the test was broken long ago when I added support for custom scrollbars. The bug wasn't very visible, because that line is only for some cosmetic improvement, but it was still there, just made obvious by my fix from last week or so. Don't ask. So I'm taking the fastest remaining solution, which shouldn't be too slow for regular use anyway. Unless you have a LOT of items in your select box... And the biggest one I can think of (timezone selector) is still lightning fast for me. If you're having any problems, please tell me, and I'll just remove the test altogether.
[Commit revision 7a94d2f]
Date: Thu, 22 Jan 2015 18:46:25 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Minor tweak to Wine sidebar position. (Wine/extra.css)
428
Features / Re: New revs
« on January 21st, 2015, 11:50 PM »
[Commit revision 4e7563c]
Author: Nao
Date: Wed, 21 Jan 2015 23:50:02 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Wed, 21 Jan 2015 23:50:02 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Give priority to popup clicks as opposed to the Zoomedia click catcher, which has a z-index of 12. (index.css)
429
Features / Re: New revs
« on January 21st, 2015, 09:00 PM »
[Commit revision cadbe86]
Author: Nao
Date: Wed, 21 Jan 2015 20:59:55 +0100
Stats: 1 file changed; +4 (insertions), -2 (deletions)
Date: Wed, 21 Jan 2015 20:59:55 +0100
Stats: 1 file changed; +4 (insertions), -2 (deletions)
- AeMe doesn't seem to properly update its settings cache when changing them. Seriously, how has this been working for the last 5 years and I'm only noticing something now..?! (Subs-Media.php)
430
Features / Re: New revs
« on January 21st, 2015, 08:41 PM »
[Commit revision 2878033]
Author: Nao
Date: Wed, 21 Jan 2015 20:13:15 +0100
Stats: 2 files changed; +66 (insertions), -76 (deletions)
[Commit revision da84ae5]
Author: Nao
Date: Wed, 21 Jan 2015 20:41:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Wed, 21 Jan 2015 20:13:15 +0100
Stats: 2 files changed; +66 (insertions), -76 (deletions)
- Modified media pages to use ask() popups instead of Zoomedia. Works much, much better (everything had been broken for years!), although some items still don't seem to work properly. (Aeva-Gallery.php, Media.template.php)
- Note: the HTML type can't be removed from Zoomedia, because it's still used to show AeMe embeds as gallery items.
[Commit revision da84ae5]
Date: Wed, 21 Jan 2015 20:41:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Woops! That's why alerts weren't working today... (script.js)
431
Features / Re: New revs
« on January 21st, 2015, 06:51 PM »
[Commit revision 915e2fa]
Author: Nao
Date: Wed, 21 Jan 2015 18:51:31 +0100
Stats: 1 file changed; +8 (insertions), -16 (deletions)
Date: Wed, 21 Jan 2015 18:51:31 +0100
Stats: 1 file changed; +8 (insertions), -16 (deletions)
- The help popup is now literally just ONE line! Could even generate it from Help.php, rather than the template... Hmm. (GenericPopup.template.php)
432
Features / Re: New revs
« on January 21st, 2015, 06:50 PM »
[Commit revision efa980e]
Author: Nao
Date: Wed, 21 Jan 2015 10:08:55 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 35c89bc]
Author: Nao
Date: Wed, 21 Jan 2015 10:18:48 +0100
Stats: 1 file changed; +4 (insertions), -3 (deletions)
[Commit revision 7b5a702]
Author: Nao
Date: Wed, 21 Jan 2015 15:14:43 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision fe4d11c]
Author: Nao
Date: Wed, 21 Jan 2015 15:16:17 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)
[Commit revision d686f19]
Author: Nao
Date: Wed, 21 Jan 2015 15:28:59 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision d555ceb]
Author: Nao
Date: Wed, 21 Jan 2015 18:50:06 +0100
Stats: 1 file changed; +54 (insertions), -45 (deletions)
Date: Wed, 21 Jan 2015 10:08:55 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- say() doesn't need to be a modal dialog, it's just a regular information box requiring no user choice... (script.js)
[Commit revision 35c89bc]
Date: Wed, 21 Jan 2015 10:18:48 +0100
Stats: 1 file changed; +4 (insertions), -3 (deletions)
- Fixed some rare situations where popups didn't have proper dimensions. (script.js)
- Just for the record... This bit was written years ago (seriously), but I always postponed its commit because I wasn't sure it worked. Well, since I'm doing most of my tests on 'clean' copies, I'd never get to test it anyway, so I'm committing, and I can always revert it later.
[Commit revision 7b5a702]
Date: Wed, 21 Jan 2015 15:14:43 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Strictness is cool. No, it isn't. (Aeva-Gallery2.php)
[Commit revision fe4d11c]
Date: Wed, 21 Jan 2015 15:16:17 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)
- Got bored with a visual tweak... Suggestions welcome. (Wilde/extra.css)
[Commit revision d686f19]
Date: Wed, 21 Jan 2015 15:28:59 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Apparently, Firefox 37 doesn't like buttons with reduced paddings and overrides the font color with white (?!) after animations. Seriously, what's with that? (index.css)
[Commit revision d555ceb]
Date: Wed, 21 Jan 2015 18:50:06 +0100
Stats: 1 file changed; +54 (insertions), -45 (deletions)
- And now for a severe rewrite of the reqWin() function. (script.js)
- > is_modal replaces modal_type, and is easier to understand.
- > existing button labels are kept, instead of replaced with we_cancel/we_ok values.
- > the function now accepts any type of contents, ultimately it will always show a draggable header, then a section containing the main data, then a footer with at least one button. If necessary, it will create them on the fly.
- In need of more work: (1) testing form submissions from within a popup (does the location trick interfere with them?), (2) ensuring other events don't interfere with the popup's, such as Zoomedia's.
433
Features / Re: Language revs
« on January 20th, 2015, 11:36 AM »
[Commit revision cb716a4]
Author: Pandos (Signed-off)
Date: Tue, 20 Jan 2015 11:29:28 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 7aea4d5]
Author: Nao
Date: Tue, 20 Jan 2015 11:35:57 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Tue, 20 Jan 2015 11:29:28 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Update wording to match the right values, mentioned by emanuele
[Commit revision 7aea4d5]
Date: Tue, 20 Jan 2015 11:35:57 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Merge pull request #25 from Pandos/fixit
- Update wording to match the right values, mentioned by emanuele
434
Features / Re: New revs
« on January 17th, 2015, 04:24 PM »
[Commit revision 2391679]
Author: Nao
Date: Sat, 17 Jan 2015 16:24:14 +0100
Stats: 1 file changed; +9 (insertions), -2 (deletions)
Date: Sat, 17 Jan 2015 16:24:14 +0100
Stats: 1 file changed; +9 (insertions), -2 (deletions)
- reqWin now allows loading existing HTML into a popup, rather than just an HTML string. (script.js)
435
Features / Re: New revs
« on January 17th, 2015, 01:43 AM »
[Commit revision b7892c8]
Author: Nao
Date: Sat, 17 Jan 2015 01:43:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Sat, 17 Jan 2015 01:43:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Fixed a possible (unique?) case of select boxes not drawing correctly due to an incorrect selection object. (sbox.js)
- I'm pretty sure "!a === b" wasn't what I mean to type, rather "a !== b"... Although, of course, my 'fix' may break something that was working before. (sbox.js)