Wedge

I don't know, but IE10 is bound to get a fair market share in the future, so we might as well ensure we do something about it...

So, what about your upload issue..?

Who wouldn't... :P She's just as witty as River Song, with the extra 'girl next door' touch. :P
Well, I guess I could fall in love with Mr Moffat, if all it took was the clever lines :lol:

Anyway, I don't know what else to say... I'm only surprised that I actually thought of her saying 'it's smaller on the outside' just a second before she said it... It just felt so logical to me that she would say the exact opposite of what the Doctor expected ;)

Also an A+ for the Sherlock impersonation (the music is a nice touch!), as well as the 'originals', whom I already liked from A Good Man Goes to War, but who are much more detailed in here, especially the very funny Strax. I'm glad to know he'll be seen in more épisodes!

I loved it. Nuff said ;)

I don't know what you're talking about, Pete... I removed the protected static and moved it to the getInstance function. As a static, again. It's protected since it's only accessible from that function. Anyway... Merry Christmas -_-

rev 1810
(12 files +1, 19kb)

+ Added browser version limiter on CSS filenames, to avoid having too many files for just a couple of guests. Opera v10 and earlier are less than 5% of Opera's share, so I set the minimum version to 11. Minimum versions for Chrome: 20, Safari: 4, IE: 6, and Firefox is a special case because v3-4 are still a bit popular, so I'm keeping v3.x, v4.x and v16 and above. (Class-System.php, Class-CSS.php)

* Various changes to the user object. Some functions are now protected. (Class-System.php)

* we::is('mobile') being a bit slower and being often called on pages, I'm changing that to we::$user['is_mobile']. Feel free to use we::is('mobile') in plugins or whatever, of course. (Load.php)

* Translation. Hmm... There's plenty of other files to clean up... I should have done that first, and re-used the original translations... Whatever. Also fixed English version typo. (ManageBans)

- Removed PREG_PATTERN_ORDER optional param from a few loose preg_match_all calls. (Class-Editor.php, Class-Packer.php, ManageMemberOptions.php, PersonalMessage.php, Profile-Modify.php, Search2.php, Subs-BBC.php, Subs-Template.php)

@ Woohoo, yet another commit conflict... I'm telling you Pete, I was far from done with the we object! Oh, and sorry for the install.php/sql bugs. And I fully agree for the editor :P

Merry Christmas everyone :)

But that's the point... Isn't it? I'm trying to have consistent (i.e. harmonized all throughout) code.
Anyway, I don't know what you want exactly... When you say that you're not touching wetem because you're not sure it's ready, but you touch we immediately after my first couple of commits, I'm not sure whether you actually had something in mind or it's just something you thought of when reading my code and you tried to justify yourself after that by giving a (wrong) example....

Fact is, you don't have to justify yourself, you're human as I am, we have our little idiosyncracies, what matters is to accept them and/or have others accept them. (It feels like watching every other episode of Friends or HIMYM...)
This is where we're wasting our time. As I said earlier, we're unlikely to budge much on this particular issue, so we have to determine, not who's right, but who's the more annoyed by the other's preference. If it kills you not to see a 'public' keyword, I'll gladly change my habit. If it only slightly bothers you, then maybe you'll gladly accept my own preference.

There's really no need to fight over this.

And it never bothered me...
See, a web dev is more likely to use JS and PHP exclusively in their daily work. I don't see it as a problem that visibility is no concern to them...
Heck, even the system object has static variables but doesn't explicitly describe them as public... I'm surprised you didn't change them or something :PSorry, but that doesn't touch me... I'm no genius coder, but I know one thing for sure -- as long as my code is readable, it doesn't matter what logic is behind it. One logic is enough, mine doesn't encompass 'separation' or 'behavior'. :-/Just look at wetem, once again... About half of the methods are private. I clearly separated private methods from methods that I want to expose. I 'got' the logic as you define it. I just didn't see any reason to add a 'public' keyword when not needed. And you didn't bother to add it, either, AFAIK... ;)

I'm just... Well I'm just sayin', I like consistency in our code. I'm okay with our 'areas of interest' using two slightly different ways of coding (yours and mine), I'm less okay with the 'no man's land' being less tightly maintained, and even less okay with having my areas of interest adopt different rules (e.g. public vs no keyword) under my own rule ;)
It's not a matter of whether or not it's "my" code, it's just that when it's code I tend to modify a lot, there are things I like to do my way, and having public keywords just isn't something that I usually do.