Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
3946
Archived fixes / Re: Remove drafts
« on January 7th, 2013, 11:42 PM »
That's a possible alternative... Realistic one, if I can't find the source of the issue.
I'll look into it further tomorrow. Probably by doing some code simplification, like always returning 'true' for ask() and seeing if it works, etc... (You can do it too if you like, it's probably morning for you over there in far away UK :P)
I'll look into it further tomorrow. Probably by doing some code simplification, like always returning 'true' for ask() and seeing if it works, etc... (You can do it too if you like, it's probably morning for you over there in far away UK :P)
3947
Archived fixes / Re: Remove drafts
« on January 7th, 2013, 11:30 PM »
I have no idea why this isn't working. I traced line by line, including inside jQuery itself, and nothing came up. It just doesn't trigger... Tested with Opera, though, but IIRC it's the same in Chrome.
I'm thinking... Can anyone find the same bug on another <a> tag with an onclick? Maybe the code is fundamentally flawed for anchors and only works on buttons, in which case I'm very, very screwed...
Gotta go for tonight. :(
I'm thinking... Can anyone find the same bug on another <a> tag with an onclick? Maybe the code is fundamentally flawed for anchors and only works on buttons, in which case I'm very, very screwed...
Gotta go for tonight. :(
3948
Features / Re: New revs - Public comments
« on January 7th, 2013, 11:29 PM »
That's the idea. :eheh:
3949
Features / Re: New revs - Public comments
« on January 7th, 2013, 08:34 PM »
Yup.
Oh, and it's a bit scary to have Wedge define eves = {} at some point in the HTML code and have script.js rely on this without testing, but that's the beauty of DCL... :lol:
Oh, and it's a bit scary to have Wedge define eves = {} at some point in the HTML code and have script.js rely on this without testing, but that's the beauty of DCL... :lol:
3950
Features / Re: New revs - Public comments
« on January 7th, 2013, 08:30 PM »
Okay good ;)
As for whether it works or not -- I guess we'll have to wait until we get some user feedback on these... (?)
I'm at least hoping it'll help fix an issue in the Android stock browser I got with select boxes. Dunno.
Oh, and I forgot to ask whether it was okay to get rid of bindEvents' parameter, since it was only used in one function and I don't see many situations where we would need to create new HTML elements on the fly with events attached to them, and without actually directly using .bind() or similar functions to attach these events. (Which is faster, considering that bindEvents() eventually calls .bind() for all events it can find...)
As for whether it works or not -- I guess we'll have to wait until we get some user feedback on these... (?)
I'm at least hoping it'll help fix an issue in the Android stock browser I got with select boxes. Dunno.
Oh, and I forgot to ask whether it was okay to get rid of bindEvents' parameter, since it was only used in one function and I don't see many situations where we would need to create new HTML elements on the fly with events attached to them, and without actually directly using .bind() or similar functions to attach these events. (Which is faster, considering that bindEvents() eventually calls .bind() for all events it can find...)
3951
Features / Re: New revs - Public comments
« on January 7th, 2013, 08:03 PM »- Used bindEvents at one point, instead of reproducing the function. I just modified bindEvents to allow passing specific DOM elements to it.
I tried removing it from both, replacing the admin one with a copy of the original bindEvents (it's not THAT long, and it's on only one page... admin one, on top of that), and instead of calling it at the end of the index template, I'm now doing a DOMContentLoaded call for it, which works just the same because basically these events are executed once the HTML is loaded, and after the script.js file is loaded anyway (so we already have everything under the hand at that point).
As a result, I'm saving about 10 gzipped bytes in script.js by moving the call to my DOMContentLoaded function[1], as well as about 6-7 gzipped bytes in all HTML pages.
I also moved $('select').sb() to that function, for the same reasons. This saves another few bytes in both sbox.js (part of script.js) and all HTML pages (because the call was also hardcoded in there, except when creating a new session under a browser other than IE 6-8, IIRC.)
So, all in all, I saved over 20 gzipped bytes from script.js and about 10-20 (hard to count) from all HTML pages.
Pretty happy with that, but there are two remaining issues:
- is it okay, or at least acceptable, to place that DCL function within an unrelated function...?
- can anyone think of any situation where powering up the menus, or the select boxes, or building the event list would better be placed where they used to be, rather than in a DCL function...?
Really dunno about all of this...
| 1. | Which, I'm afraid, and it's the only thing that bugs me a bug, is executed from within the menu building function... It's totally out of place, but this allows me to avoid building a $.fn.wmenu plugin to begin with. I don't know if I'll keep it that way... |
3952
Archived fixes / Re: Remove drafts
« on January 7th, 2013, 06:58 PM »
Hmm is that a bug in ask() or something? Not on my pc right now...
3953
Archived fixes / Re: Admin Centre item goes to wrong place?
« on January 7th, 2013, 06:55 PM »
What about smartphones browsing in wifi like mine?
I don't want a different theme, then ;)
We support alternate themes for mobile phones so it's doable but I dunno if it's worth providing one in core.
I don't want a different theme, then ;)
We support alternate themes for mobile phones so it's doable but I dunno if it's worth providing one in core.
3954
Features: Theming / Re: Permanent sidebar
« on January 6th, 2013, 08:09 PM »
Like Pete said.
There are liquid layouts and fixed layouts. Both have their advantages. Most forums use liquid layouts, but the smarter solution is to use a liquid layout with a fixed maximum width. This is what Wedge does. In addition to that, we add a sidebar to make more use of the available space -- but if there isn't enough space, we moved the sidebar to the bottom. I worked very, VERY hard on making the sidebar as useful and unintrusive as possible. No one can possibly say that the sidebar on wedge.org is bothersome or whatever. So it stays where it is.
I don't get people who complain that something is done one way and they can't disable it, but they won't even consider doing something very simple like creating a sidebar-less skin for their forum. (Which is probably when they realize they don't really need it.)
There are liquid layouts and fixed layouts. Both have their advantages. Most forums use liquid layouts, but the smarter solution is to use a liquid layout with a fixed maximum width. This is what Wedge does. In addition to that, we add a sidebar to make more use of the available space -- but if there isn't enough space, we moved the sidebar to the bottom. I worked very, VERY hard on making the sidebar as useful and unintrusive as possible. No one can possibly say that the sidebar on wedge.org is bothersome or whatever. So it stays where it is.
I don't get people who complain that something is done one way and they can't disable it, but they won't even consider doing something very simple like creating a sidebar-less skin for their forum. (Which is probably when they realize they don't really need it.)
3955
Features: Theming / Re: Permanent sidebar
« on January 6th, 2013, 12:47 PM »We have a lot of older members who want the width of their display, so sidebar is a nogo. Also, it makes no sense to have a sidebar if you have a few items because it's empty when you scroll down.
yes, I know it's free.
Nowadays, new monitors tend to be 23'' or more, with full HD resolutions or better. Early websites were built with a 800x600 resolution in mind, and for many, many years, webmasters would keep it readable in 800x600 even with higher resolutions around. Then mobile browsing was born, and with it the need to be even more readable in very low resolutions (e.g. even if your mobile phone has a HD resolution like mine, on a non-optimized page text is really not readable without zooming, so you need to take care of that).
Thus, the solution I chose for Wedge:
- Ensuring that at very wide resolutions, we don't get a totally different experience, and yet make use of the extra space. This is accomplished by adding a sidebar.
- Ensuring that very narrow resolutions look good, This is done by dynamically moving the sidebar to the bottom of the screen when the 'declared' resolution is below 1024x768 (or including it, I'm not sure anymore).
Do you see many people complaining that Facebook has TWO sidebars...? I've never seen anyone ask for them to remove even one...!
Just because other forums don't have a sidebar by default doesn't mean we should do the same. I'm the one who pushed for Wedge's sidebar to be not only default, but also non-removable (i.e. at best it's moved to the bottom and reflowed.)
I guess someone could write a plugin to get rid of the sidebar. But what's the point. You just lose information.
You're free to whip up a quick custom skin that moves sidebars to the bottom permanently. It's really easy to do. It's just not recommended.
@godboko, I don't understand your problem with Wireless...? That skin is pretty much the same as Weaving, the only different is that it enables Mobile mode, i.e. sets a meta viewport to tell the browser the ideal starting dimensions.
3956
Features / Re: New revs
« on January 6th, 2013, 12:19 PM »
rev 1827
(12 files, 14kb)
+ Added add_jquery_ui() generic function. It will automatically load jQuery UI (only once per page), from your server or your CDN of choice, and it follows your jQuery Origin admin setting. (Subs-Cache.php, ManageMembergroups.php)
* Rewrote JavaScript code's is_* browser variables to avoid using $.browser, to ease transition into jQuery 1.9 once we do the jump. In the process, I saved a total of 2 gzipped bytes. Yes I did spend half an hour doing permutations just to see what was the shortest. Yes I did spend another half hour agonizing over the fact that I'm executing .toLowerCase() at least 6 times more than needed and wasting about a microsecond of your computer's CPU, just to save a total of 4 more bytes. But at least I got the little sucker and made it shorter than it was before. Don't look at me like that. Why are you looking at me. Get off my lawn. (script.js)
- The days of IE spoofing are over. In Opera's case, it stopped doing it by default at least 8 years ago. It's time to remove these odd hacks... (Class-System.php, script.js)
* Casenazi. Microsoft's CDN URLs are case-insensitive, so might as well use the lowercase version for better HTML gzipping... Ah ah. (Load.php)
* Spacinazi. I tend to like having a space after PHP flow control instructions, like if () or foreach (). catch () looks like a flow control instruction to me. But don't get me started on other instructions I might have overlooked... (Subs-Plugins.php)
* Minor system object reference simplifications. (Class-System.php, Load.php, Security.php, Subs-Login.php)
* Since the system object is now loaded (not initialized though) before all other file includes, it's always defined. (Errors.php, Security.php)
* Added 3 missing files to the file list for XML purposes. Not that we're ever gonna use that... (xml/detailed-version.php)
! Another bastardization that needed to be made. I feel for you, Pete. (Help.english.php)
! Fixed ISO to UTF8 in latest French file. (ManageBans.french.php)
(12 files, 14kb)
+ Added add_jquery_ui() generic function. It will automatically load jQuery UI (only once per page), from your server or your CDN of choice, and it follows your jQuery Origin admin setting. (Subs-Cache.php, ManageMembergroups.php)
* Rewrote JavaScript code's is_* browser variables to avoid using $.browser, to ease transition into jQuery 1.9 once we do the jump. In the process, I saved a total of 2 gzipped bytes. Yes I did spend half an hour doing permutations just to see what was the shortest. Yes I did spend another half hour agonizing over the fact that I'm executing .toLowerCase() at least 6 times more than needed and wasting about a microsecond of your computer's CPU, just to save a total of 4 more bytes. But at least I got the little sucker and made it shorter than it was before. Don't look at me like that. Why are you looking at me. Get off my lawn. (script.js)
- The days of IE spoofing are over. In Opera's case, it stopped doing it by default at least 8 years ago. It's time to remove these odd hacks... (Class-System.php, script.js)
* Casenazi. Microsoft's CDN URLs are case-insensitive, so might as well use the lowercase version for better HTML gzipping... Ah ah. (Load.php)
* Spacinazi. I tend to like having a space after PHP flow control instructions, like if () or foreach (). catch () looks like a flow control instruction to me. But don't get me started on other instructions I might have overlooked... (Subs-Plugins.php)
* Minor system object reference simplifications. (Class-System.php, Load.php, Security.php, Subs-Login.php)
* Since the system object is now loaded (not initialized though) before all other file includes, it's always defined. (Errors.php, Security.php)
* Added 3 missing files to the file list for XML purposes. Not that we're ever gonna use that... (xml/detailed-version.php)
! Another bastardization that needed to be made. I feel for you, Pete. (Help.english.php)
! Fixed ISO to UTF8 in latest French file. (ManageBans.french.php)
3957
Features: Theming / Re: Permanent sidebar
« on January 6th, 2013, 09:52 AM »
Lulz. You realize it's free software right?
The only problem with sidebars is when you reduce the window width.
Try it with Wedge. It just works.
The only problem with sidebars is when you reduce the window width.
Try it with Wedge. It just works.
3958
Bug reports / Re: Cannot read the CSS - Alpha 2
« on January 6th, 2013, 09:14 AM »
For starters there is an admin setting to disable gzipping for cached files.
If you can't take the heat... :eheh:
If you can't take the heat... :eheh:
3959
Plugins / Re: Extending the moderation filter actions when posting
« on January 5th, 2013, 06:50 PM »
Keep me posted.
3960
Plugins / Re: Extending the moderation filter actions when posting
« on January 5th, 2013, 05:05 PM »
That's what I've been telling you for ages just the same :lol:
It doesn't work as intended, thus I thought you'd be eager to fix it. Or at least have a look at the code ;)
(I'd fix it myself, but I've never really looked into that particular page's source code and would rather give you dibbs.) ('Giving dibbs', does that work in English?)
It doesn't work as intended, thus I thought you'd be eager to fix it. Or at least have a look at the code ;)
(I'd fix it myself, but I've never really looked into that particular page's source code and would rather give you dibbs.) ('Giving dibbs', does that work in English?)