Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
3586
Bug reports / Re: Mini-menu implementation
« on February 23rd, 2013, 12:36 AM »
Oh fuck.
Sbox doesn't work anymore in chrome for android either...
Open the board changer, and try to scroll through it... sent to page top. Eh?!
3587
Bug reports / Re: Mini-menu implementation
« on February 23rd, 2013, 12:32 AM »
Actually only fails when logged off.
Strange. I thought it'd at least show the In Context link....

(My fever is bearable. more than my inability to work on my PC, really.)
3588
Bug reports / Re: Mini-menu implementation
« on February 23rd, 2013, 12:29 AM »
Probably due to this.

bugs.jquery.com/ticket/13282

They mention qtwebkit but I have the same error except for nodelist instead of object. In iOS 5.
I already saw that the got version had reverted so it should work in 2.0 final.
Posted: February 23rd, 2013, 12:19 AM

Also seems to fail in Chrome Beta for android... bugger.
3589
Bug reports / Re: Mini-menu implementation
« on February 22nd, 2013, 10:14 AM »
'Fixed' by replacing 'left, top: 0' with just 'top: 0' in the CSS for the arrow stuff...
Don't ask me why. It didn't make sense yesterday. It doesn't make any more sense today.
3590
Features / Re: New revs - Public comments
« on February 22nd, 2013, 10:13 AM »
Oh... So, the removal of fulltext is what was pre-required to switch bodies to mediumtext...?
So, one bird with two stones? :)
3591
The Pub / Re: Infinite Scroll
« on February 22nd, 2013, 09:27 AM »
Want me to get started on this, guys .?
3592
Archived fixes / Re: Serious error - current theme
« on February 21st, 2013, 11:29 PM »
Quote from Arantor on February 21st, 2013, 11:21 PM
You wouldn't have done, I only caused it with my caching changes, and I fixed it the same night. ;)
Oh, all right...

Okay, bed time for me. I see you just made another commit that changes language files... I'm a bit wary of language files these days... :^^;:
3593
Features / Re: New revs - Public comments
« on February 21st, 2013, 11:28 PM »
Woohoo, long post above... Forgot to reply blah blah... :(

Will try to do tomorrow.

In the meantime -- just looking at a commit... Did we discuss the changing of message bodies to mediumtext?
It's not that I mind -- I'm all for dropping the 64KB text size limit and all, but... It adds at least a byte to every single post, maybe two, whatever, and it probably has a (small) impact on performance as well...

Does it only need to be discussed..?
3594
Archived fixes / Re: Serious error - current theme
« on February 21st, 2013, 11:18 PM »
I never even noticed that bug..?!
3595
Features / Re: Quote to PM
« on February 21st, 2013, 11:17 PM »
Quote from Arantor on February 21st, 2013, 06:57 PM
I did wonder whether it should be a plugin, but it could be a useful core feature too :)
Either would be fine, we simply need to ensure that the menu entry is posted in the correct mini-menu (post or user? I'd be tempted to say post...), and that icon/text blend in with the rest.
3596
Bug reports / Re: Mini-menu implementation
« on February 21st, 2013, 11:15 PM »
Quote from Arantor on February 20th, 2013, 08:13 PM
But surely if you empty the cache you're forcing everything to be rebuilt from whatever the current 'master' is?
Hmm...
Emptying cache: Subs-Cache will renew it.
Building cache = getting the file list, loading all files, generating filename. Filename = built from the most recent last modified date of the filelist.
If you empty the JS/CSS file caches, the regenerated cache files will have the same date number (in the filename) as the earlier cache versions. The only way to change it is to reupload one of the files from the file list. And you don't need to empty the cache... ;)
Quote
How about I look through Fugue and see if I can find some suitable replacements?
Hmm, I dunno, I kinda like the existing icons, just not ALL of them... Ideally, we should make variations but it's a bit weak.
Quote
Also, the issue I'm referring to is there should be a space either side of the : in the ternary and there isn't ;)
Ah, sorry, I missed that one... Poetic justice? ;)
Fixed locally...
Quote
I'd argue that the Quote/Modify buttons serve a higher purpose than merely being available if there's no JS - they also exist to be prominent and easily accessible being the most common actions you're going to perform.
Yes, they're prominent, but if you'll browse with iOS, you'll see that Wireless doesn't show them either... It only shows the action menu. I haven't seen anyone complain about that, BTW...

We can either provide the same HTML as now, in which case Quote/Modify will always be shown and the rest will depend on the available room. We can provide a fully JS version, in which case (unless JS is disabled...) Quote/Modify *will* show up, as well as all of the other options because, well, there IS enough room in a regular skin for all elements... Or we can provide all buttons in HTML, without mini-menu shorthands, so that everything's available with JS disabled and still moved to mini-menus if not enough room. Of course, that one is expensive in terms of HTML size...
Posted: February 20th, 2013, 10:56 PM
Quote from Nao on February 20th, 2013, 08:09 PM
Currently, I have the 'All thoughts' page showing it, as well as Likes. It doesn't show the Like/Unlike button in the menu though (just the likes count outside the menu.) Also, it's still buggy, so I can't actually edit or post answers.

I was a bit torn between copying the Homepage code to the other functions, but then I decided to instead try to merge both into one... So the homepage now includes the Thought source, but it's kinda annoying, the homepage code has some really custom stuff that the other pages don't, and vice-versa... Though job. Is taking longer than I'd like...
Will eventually complete it, though.
- I merged the Home function with the latestThoughts one... It worked... But it had the unforeseen effect of taking 16 seconds (!!!) for the main query in latestThoughts mode. This was because I was doing a single query for everything, just like on the homepage, when latestThoughts is optimized "à la SMF" to get the thought ID list first, and then the contents (it's really, really much better to execute two fast queries than one long one... Something I didn't know about MySQL until last year, I'm afraid.)
- So, I reverted, and did it in two functions... The only change is the HTML generated by latestThoughts, which is closer in spirit to the Home one.
- Homepage works. All Thoughts works, except for "Reply" button (Modify works), because of a HTML problem. I'll look into that tomorrow... (Bed time.)
- Profile thoughts are untested.
- In Context thoughts still have no support for mini-menu.
- All in all, what a mess... :^^;:
Posted: February 20th, 2013, 11:00 PM

Oh, BTW, something else that's funny... Half an hour ago, I launched phpMyAdmin to analyze more thoroughly the query that took 16 seconds. I had a very narrow browser window at that point to test different thought widths. And I noticed the menu had a "More..." link. Then I expanded the window... And the menu items were made primary.

So, not only did I *not* have a very original idea since it was already implemented in phpMyAdmin (which is not particularly well known for its modernity and boldness!), but it's actually a better implementation that I envisioned myself because it does the refitting at $(window).resize() time, while I was only looking into doing it at $.ready() time..... :^^;:
Posted: February 20th, 2013, 11:04 PM

This thing has been driving me crazy...
I know there aren't any CSS wizards out there, but I'll still try my luck.

Attached is a zip file containing two h264-encoded videos. (They're very short, so the file is, too!)
arrow 1.avi = the original mini-menu animation
arrow 2.avi = the current animation

The only difference is that #2's arrow is horizontally static, it's already in place and not moving except vertically (barely noticeable).
That's okay, it was as intended, but to be more specific, when I did my CSS/JS changes, the arrow started moving the other way (from right to left), rather than what video 1 shows (left to right).
I absolutely loved the left to right animation, and I actually have a copy of Firefox running with the 'old' code in cache, and can reproduce this, and Firebug allows me to set a border on the arrow's div (which is at .right.mimenu li:first or something like that)... And the div enlarges from left to right, i.e. it doesn't fill the width of the menu completely at the beginning of the animation, it's actually narrower and left-aligned. By the time the animation finishes, the div is now filling the entire menu, and thus the 66% horizontally positioned arrow is at the correct position, going from left to right.
But I just can't reproduce the fact that the container div starts out narrower and left-aligned... I don't get it. The CSS is really the same between the two versions, but they don't behave the same...
It's probably a JS problem, but same here: same starting and ending positions in JS on both versions...

Drives me crazy, really.

So, in a future commit I'll be considering reverting to the 'right to left' animation (setting a 80% position on the background arrow), which I think looks better, with the only issue being that the arrow isn't positioned the same depending on the menu width.
I could try and implement a CSS3 animation from within the CSS file... It might actually work... But I think it's doomed in advance.

Any ideas then..? For those with SVN access, feel free to revert to an older rev (before today) and analyze the CSS and JS for the animation... Because right now, I'm stuck. And I wrote it! (And, I'm ashamed to admit, the original left-to-right animation wasn't my doing... It was a glitch that occurred during development, and I liked it so much that I made sure to keep it that way. But I obviously broke it during my rewrite and forgot about it. Only realized today that the broken behavior is broken.)

Ah, well, anyway...
3597
Archived fixes / Re: Minor Quick Edit Bug
« on February 21st, 2013, 06:53 PM »
What? Never got fixed..?
I thought I'd touched something like that not so long ago...
3598
Bug reports / Re: SMF bug 3009 (duplicate meta information)
« on February 21st, 2013, 06:51 PM »
160 bytes is usually a bit short for a regular conversation (you don't always 'think' of compressing details into the beginning of a post, unlike Twitter...), so OTOH I'd rather not waste too many bytes on a feature that's SEO-only. (Heck, it it were me, I'd just dismiss the meta description tag entirely... :^^;:)
So, a good compromise I suppose..?

BTW, is it worth putting the … stuff in the string? It looks a bit odd, when looking at the HTML...
3599
Features / Re: Quote to PM
« on February 21st, 2013, 06:48 PM »
Very good idea... I'm surprised it never slipped through my mind. It would be very helpful to encourage going to PM in some flooded/troller topics.
3600
Features / Re: Micro feature: escliteral type
« on February 21st, 2013, 06:44 PM »
I like the idea. I've had on occasion been forced to do 'stuff' => 'stuff' indeed, and this would make it neater.

Just two remarks:
- escliteral isn't an exciting name ;) I could go with 'literal', though. Or 'escape', or whatever...
- we might get people complaining that there's a bug here or there because "a variable is missing its value"... Although I doubt it -- coders usually are smart enough to figure things out without checking the source :P