Wedge

Kill! Kill! Kill!

Oh, they're not mentioning whether perv video games are good for the libido... :lol:

Yeah, but did you learn French at school? For 8 years..? I'd say this doesn't compare :lol:I never worry about it...[1] Only in professional situations!

Phew, I just spent an hour writing my latest changelog... 95% of which was on the lyrics thing, ah ah... Well, problem is I discovered Sugizo had made a new album so I had to get it, and it crashed my browser so it lost all my text, and I forgot about drafts (I just checked, I had one!), so I rewrote everything, plus the browser insisted on being updated when it restarted, so I did that, and now the tab bar is just narrow enough that I get the sidebar in wedge.org, how fun... :^^;:

Where was I, already..?

1.	I only worry about my accent. I can make a video of myself if you'd like -- just to see how horrible it is!! :lol:

Well, you have to remember I learned most of my English on the Interwebs, and there isn't a UK/US flag next to English text, so I caught some typically US expressions/spellings, and some typically UK ones. I don't mind if I show my weaknesses on this board or whatever -- I just need to ensure I don't mix them up in Wedge itself... Which would look unprofessional ;)

Oh, now I know... I think EmailTemplates was ISO earlier, because it didn't have any accents in it. I added accents when I translated your 'desc' strings... :^^;:

Also...

- Although I'm not enchanted with the idea (when it comes to updating website files via FTP, it's two or three extra folders to check out), I guess it'd make sense to put all languages into their own folders, for simplicity. If you don't want that, then good; if you do, then I won't oppose it.Well, there are many settings we never hesitated to remove to make room for others or just breathing space... ^^Speaking of which. Isn't it feasible (ah, finally got the spelling right!) to just keep the editor out of topic pages, and when clicking 'Full editor', load it through Ajax instead...? I'm not afraid of these Ajax calls anymore. :P And it would save quite many bytes to topic page.Speaking of spellcheck, I'd like to point out, the buttons/spell.png file is still in SVN... Shouldn't we remove it? It's not used anywhere right now...In SMF, definitely. Nearly 4900 bytes of crap! Wedge reduces the (uncompressed) code to about 2300. It's still useless, but at least it's the size it should be!

Regarding JS, I have more issues on my side with the reqWin rewrite. Well, just one really. Before committing it, I'd like to ask: is it really worth having a flexible first parameter..? 99% of all calls are "reqWin(this)". This then takes the href param in the owner anchor. Then there are, IIRC, four other calls:
- say/ask both pass an empty string as the first parameter, because they don't want to provide a title anyway; doing $('') shouldn't cause any trouble, so no need for the extra test;
- there's an occurrence in Active Topics (from John) and one in one of your plugins (I think it's WedgeDesk, I'm not sure though), where it sends reqWin('url string'). I've fixed Active Topics to do it the 'proper' way, i.e. put the URL into the href (so that it actually gets prettified and optimized by Wedge... I think??!!), and do reqWin(this) instead.
- I didn't fix yours, because it's more complicated... It's in your attachment code, have a look, in WedgeDesk-Display.php. Do you think it's fixable, if anything..?

The only thing I can say is, while it's a good thing to say "reqWin can open a custom URL if you provide it in the first parameter", I don't know if it's worth the extra 3 bytes of code to account for this when it's actually used nowhere at all in Wedge...?

(And please, please please say "yes it's worth it, now bugger off with your three petty bytes".. I'll feel better about it!)Now that's pretty crazy... ;)
I still prefer for // comments at the end of a line of code to be either very short (a few words at most), or moved to their own line (or move, if needed). That's pretty much a 'SMF/Wedge coding guideline' to me... Do you think you could do that in the future..?

I'm all for having a UK language file in there, of course! British are cool. (Matt Smith voice.)
Hell, it's long overdue. And I knew you planned to have one anyway. And it'd be easy to maintain -- just keep the lines that change, once the English fallback is restored...
Or you could have a 'patch' system that tells Wedge to change this or that word on the fly. But I can hardly see that one as working for anything else than British English... Brazilian, maybe..? Don't remember... And local variations, of course. Well, maybe it's not that bad an idea.
Oh, I used that page to do the final conversions:
http://www.lukemastin.com/testing/spelling/cgi-bin/database.cgi?action=rules
I knew most of the rules, but not all. Also, not all US '-ise' words are listed, but I trusted my instincts whenever I wasn't sure. I also converted -ising and -ised.

Okay... Fixed :eheh:

Wasn't due to the first line, but the second. (Chrome led me into thinking it was the first.)
i.e., $(from).text(). I optimized that line to that size specifically because jQuery was ignoring URLs fed to it, so $('http://...') would just be ignored. Now it seems (in 1.9+) to generate an error. More specifically, the ':' is the one that causes the crash.

So, I just added the same test before it, and it works. It adds an exact 3 bytes to the code.
Then I removed a hack that was just a few lines below, which I'd forgotten to do -- I'd added a 'note to self' to remove it once we'd go for jQuery 1.8. Saves 9 bytes. And finally, I removed another hack for something that caused problems last week, but seems to be working now, probably the result of another fix I added in the meantime... I don't know. I don't care.

All in all, the script.js bytesize is now 7 bytes shorter, and works better. Thanks, Pete! ;)

Woohoo above ^

rev 2008 - Yeahhhh, shall I cut you down... Yes 'twould be a last physical communion, I'll be gentle! I'll be gentle! I'll be gentle! I'll be gentle![1] / Komonangayo Bandeko Makila Mabe Oyo...[2] / Sublime... Pour moi, c'était sublime.[3] / Tududum, tududum.[4]
(33 files, 7kb)

* I don't know why I was putting up with regex replacements in Wess's comma protection, when I could have just gone for a str_replace... (Class-CSS.php)

* Changed all files to americanize British endings (optimise, sanitise, colour, etc.) I'm not touching WedgeDesk though, as it's 100% Pete's thing, and maybe he wants to wave the British flag with pride on it. Or something ;) An important change is that I renamed wedit::legalise_bbc to legalize_bbc, and I couldn't be certain that the word 'legalise' isn't commonly used in the US. (30 files -- do they need listing..?)

! Missing $settings global in $language rewrite. (Are there other..? I only fixed the one I found in my error log.) (Subs.php)

* Commenazi. (index.php)

1.	Comus, 'Drip Drip', 1972. I missed that year but they performed it live in 2008 and it was recorded on an album so I'm using the opportunity, eh eh. As for the lyrics, they're a parody, don't be scared, I just happen to love the way the guy sings it! :lol: http://fox.noisen.com/4841/comus/
2.	These lyrics are totally my guess, I don't speak a word of Congolese and lyrics can't be found online... It's from Shadow by Papa Wemba, in Peter Gabriel's "Big Blue Ball", my favorite album of his since one of my two all-time favorite soundtracks, "The Last Temptation of Christ", in 1988. Which I, oddly, forgot to mention back in rev 1988. My other favorite soundtrack, even more oddly, is Shinku no Shônen Densetsu, a Saint Seiya movie, which was... my choice for rev 1988. That was a pretty good year for instrumental music...!
3.	Christophe[1], 'It must be a sign', in his beautiful "Aimer ce que nous sommes" album. I must also mention that it was his last album until yesterday, when he released a new one. I must get it!  1.  Whom you may know from a song in Kill Bill... I guess not! It was only an instrumental.
4.	Well, have nothing better to offer for The Dark Knight!

Busy right now. Will look into it tonight.