Wedge

All fixed. :)

No need for a screenshot -- as I said in my thoughts, I broke the site™™™™.
I don't know why avatars are invisible, but it's certainly due to loadMemberAvatar(). I'll look into it.

Notifs... Meh!! This is mostly due to the fact that I had to 'backtrack' my CSS code because I was starting to tear everything apart to load as little HTML as possible, and I wasn't sure where exactly I should stop backtracking... I guess I stopped at the wrong place! :^^;:

So may I leave everything to you on this..? It was quite a large patch, so I know it's not going to be fun...

Hmm, a bug with the auto splitter... Sometimes it inserts two blank lines after opening the quote again. Uh.Yup, yup, you probably did. I'm talking about the original commit.Nope. It's the mission of Custom.template.php, where you can declare template_whatever_override() to replace a function.
We discussed it at length back in the day. Having template files inside skin folders is very doable, but it's not 'clean'. I'm always torn between the two sides of the problem, eh...And parse_bbc() has this near the beginning:


Meaning what it means... ;)
(And you noticed that too, now that I'm reading the rest of your post.)I remember looking at it when you committed it. I think I asked a few questions about it, even... But at the time, I don't think it was even possible to change an entry. It had these 'master' things, but that's all... I think.I didn't. I just noticed that adding line breaks manually in the string would add more physical line breaks to the thing. So I checked the code, and noticed the parse_bbc call. Which is why I decided to go for a 100% BBCode version. (Not that there's ANY BBCode in these strings, but... I mean the line breaks...)I don't know either, I'll have to say.
Maybe we could simply remove that line (and fix anything it breaks), remove the parse_bbc call from agreements, and use HTML to break lines. (And still keep line breaks to make the strings breathe. i.e.,

$txt['...'] = 'Hello,
<br><br>
World.';

Would work for me...Yeah but that's no reason to throw a hadōken at me in your previous post, buddy... :lol:Considering the amount of work we still have to finish, I don't see this happen in a realistic time frame. I'd rather we focus on more urgent matters -- translators can work on existing language files, if they're in such a hurry to have it done ;)Perhaps it is. But it's a stock file. It's what I'm doing by default. I'm saying, "now that your Wedge copy is installed, download this separate file, Home.php and its related files, copy them to their respective folders, and point the homepage to Home, so you can have the Wedge.org homepage code on your site. Now you can modify it all you want (if you want!), because a Wedge upgrade will never overwrite it.There's always room to improve all of that, yeah. But it's not something I'm willing to do for now... There are many complex features I want to add to Wedge, and by now I think that it's more reasonable to postpone them to a 1.1 or 2.0 version. v1.0 is only the beginning... Hopefully..?!And working on these tools will deprive Wedge of other features that could be added to it, and that could be used by more people... :-/

Oh yes, while I'm at it...

rev 79
(19 files, 12kb)

* Spacinazi and other minor Naoisms. (calendar/Calendar.php, calendar/CalendarPost.php, calendar/css/dateinput.css, calendar/ManageCalendar.php, recaptcha/recaptchalib.php, wedgedesk/css/helpdesk.css, wedgedesk/install-xml/install-attachments.xml, wedgedesk/lang/WedgeDesk.english.php, wedgedesk/src/WedgeDesk-Admin.php, wedgedesk/src/WedgeDesk-AdminMaint.php, wedgedesk/src/WedgeDesk-AdminPermissions.php, wedgedesk/src/WedgeDesk-AjaxHandler.php, wedgedesk/src/WedgeDesk-Post.php, wedgedesk/src/WedgeDesk-Profile.php, wedgedesk/src/WedgeDesk-SSI.php, wedgedesk/src/WedgeDesk-TicketTopicMove.php, wedgedesk/tpl/WedgeDesk-AdminPermissions.template.php, wedgedesk/tpl/WedgeDesk-Profile.template.php, wedgedesk/tpl/WedgeDesk.template.php)

Your removal of simple permissions seems to have been done, to a point, on auto-pilot. Just look at the line above, with a test repeated twice...
At some point you renamed 'simple' and 'classic' to 'name', at other points to 'group'. I suspect the one above should say 'group' instead of 'name', but I'm not sure, I haven't tested anything. I'm just trying to update all the plugins to use the new permissions, and I'm stuck with that.True enough. Although not always done... (e.g. notification action.)(It is so tempting for me to remove themes as a feature entirely, because skins can do so much more... The only thing they have for themselves, is the ability to replace a template file. But it should be possible to simply put these files into our skin files... Why not?! I'm so familiar with my skin code, and so unsure about theme code... Heck, I've never tried to install an additional theme in Wedge. Everything can be done with skins so...)By shortcuts, I mean keyboard shortcuts themselves, not the text that mentions the list of keyboard shortcuts.
Thanks to shortcuts (which are dealt by a cached JavaScript file, and thus always available), even in Wysiwyg mode you can easily bold a text by pressing Ctrl+B, if you're used to Word or Wordpad or Write or whatever... Of course, the browser has to cooperate, too -- there are some that use this shortcut for a bookmark popup, like Sleipnir (my current default) or IE IIRC. Still. I don't see a need for buttons in most cases.Yes, absolutely, but in this case it'd be more consistent because it'd be enabled everywhere.
I'll tell you my preference -- the way it's done right now. But the sane and consistent choice? Probably the other way around, I guess...Ah, yes indeed!
And it was unneeded. No need to waste HTML for 'this.href' when we can pass 'this' and then get the href in the cached JavaScript.
Apparently, the SMF team thought it was still too short though, so they renamed the whole thing to reqOverlayDiv(this.href) :lol:

To think that I've always considered renaming reqWin() to just popup()... :^^;: (I don't know why I'm not doing it.)So, I take it it's untested, right..?Hmm...

- load default index.english.php
- load language (English UK, French...) index
- do nothing.
- cache results.

Then, later:
- load default specificfile.english.php
- if $txt['lang_parent'] != 'english', load specificfile.$txt['lang_parent'].php, if not there, ERROR.
- attempt to load specificfile.language.php -- if not there, if empty($txt['lang_parent']) ERROR (because we ARE supposed to have a full file in this case), else ignore.
- cache results.

And that's the worst case scenario, to me...?I don't know, Pete.
All I know is that SMF has this:


And you have a similar one, except you're using $txt instead of file_get_contents.
The rest is the same, i.e. you parse_bbc it. If you didn't want it to be parsable, you should remove the parse_bbc call and revert the $txt strings to use HTML instead.Well, exactly... I was talking about translators, in this case.
In which case, having a long line of text will be annoying to translate for them, unless they enable wrap mode, but not everybody thinks of that. (Heck, I pretty much never enable wrap mode, except when I have to read a TXT file that was built that way...)What do you mean, Pete? They get the Welcome template by default. Which is geared towards a 'starting' forum. Heck, I can't bother to write the UI for the default homepage target, allowing for users to choose whether they want to target a specific page, or action, or board list, or specific board (or even topic, why not...)

The purpose of the differentiation between Home and Welcome is that in the case of Home, I could distribute it separately from the package, but the entire package itself is suppose to be comprised only of files that should NOT be modified. Well, Welcome is here to say, "create your own homepage now... And name it differently!", it doesn't do that yet, but that's the idea.
I know that as a forum admin hobbyist, back in the day, I wanted to change the homepage but was wary of having my changes overwritten by new forum updates. In the end, I had to create patches and other horrible things.

One of my goals with Wedge (and yours, see plugin system!) is to allow users to update their forum files without any influence over their modifications (as long as they follow the guidelines to modify things.) First thing for that is to allow for the homepage (most often modified page) to be overridden and redirected to another page of yours.

Your post wasn't very... lively... Any problems..?

rev 2029
(4 files +1, 4kb)

+ All touch-enabled devices will now get automatic quote splitting for free. As they don't have a Shift or Ctrl key to use along with Enter, it only makes sense, especially given how hard it is to make quotes in mobile mode. Heck, this suddenly makes quoting messages possible in Android, iOS and whatever. Thanks Dragooon for the suggestion! (editor-func.js)

* Because the registration agreement is a special language string that's explicitly parse_bbc'd, I turned its HTML tags (double line-breaks) into actual line-breaks. This also makes them easier to use them as base for your own registration agreement. If you're never heard about text wrap mode, of course. (Agreement.language.php)

* Missing file. Note that Home files are not supposed to be in the final distro, and that I'm sure I'll forget all about it soon enough, but whatever... (Home.english-uk.php)

rev 2028 -- a selection of smaller fixes. Just because they're small doesn't mean they should be ignored. Especially the eye.
(5 files -1, 3kb)

! The language links were silly. They thought a language couldn't have dashes in it. English-uk just proved them wrong. They apologize for any inconvenience, as well as infinite ;language=...;language=... links. It was fun while it lasted. (index.template.php)

* Quotenazi. Will do more of these soon enough... (index.template.php)

* Spacinazi. Harmonized code to Wedge standards: we do "$ref =& $var", not "$ref = &$var", even though it's technically the same. Semantically, "=&" means to me "assign by reference", so it's more readable that way. Hence the standard. (Profile-Actions.php, Subs-Plugins.php)

* Typonazi. Or Commenazi. Whatever you like best. (Class-Notification.php)

* Optimized hidden.png file for size (saves nearly 200 bytes). I'm still not a big fan of this icon... I'm sure it's under my bed it's hiding. It watches me at night. With a grin. On its mouthless face. #MommyImScaredIDontWannaSleepAlone (hidden.png)

- Removed spell.png file... As far as I know, it's not in use anymore. Life is good. (Except when the hidden.png eye is watching, of course.) (spell.png)