Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
3301
Features / Re: New revs - Public comments
« on March 30th, 2013, 03:51 PM »
What software did you use to crop it..?
3302
Features / Re: Plugin revs
« on March 30th, 2013, 03:18 PM »
rev 83
(1 file +2-2, 4kb)
* [topic_solved] Replaced moderation buttons with lighter GIF versions of the right size (i.e. 12x12). Also changed their filenames to more descriptive ones... Hopefully? Finally, fixed CSS to match the latest Wedge revision. (TopicSolved-Display.php, cross-button.png, tick-button.png, solved.gif, unsolved.gif)
(1 file +2-2, 4kb)
* [topic_solved] Replaced moderation buttons with lighter GIF versions of the right size (i.e. 12x12). Also changed their filenames to more descriptive ones... Hopefully? Finally, fixed CSS to match the latest Wedge revision. (TopicSolved-Display.php, cross-button.png, tick-button.png, solved.gif, unsolved.gif)
3303
Features / Re: New revs
« on March 30th, 2013, 02:49 PM »
rev 2039 - a byte is a byte is a byte.
(9 files -2, 3kb)
* Optimized moderation button CSS declarations for bytesize and better positioning. Renamed moderationbuttons to modbuttons (everyone gets what it means, right..?), and got rid of this odd moderationbuttons_strip, which is just as easily accessed by '#modbuttons ul'... Also simplified template_button_strip to accept an $extra param instead of an array of options. I've double-checked all calls to TBS, and couldn't find a single use of these options except for the moderationbuttons_strip ID setting I was talking about. I could remove the $extra as well, but figured some plugins might find it helpful (you can still do $extra = 'id="my_id"'). (Display.template.php, index.template.php, topic.js, index.member.css, sections.css, Wine/extra.css, Wine/index.member.css, Wuthering/extra.css, Wuthering/index.member.css)
* Shortened small_move.gif from 305 bytes to 125. I'd actually brought it down to 100 bytes, but it didn't compress as well (took 3 more bytes than the 125-byte version). Go figure! I knew I had to compare... ;) Mind you, I also tried the same on small_delete, but Pete somehow managed to crush the competition here. What tool did you use for that one..?! (small_move.gif)
* Added '@if member' to our post liking function, as guests can't use it anyway. (topic.js)
(9 files -2, 3kb)
* Optimized moderation button CSS declarations for bytesize and better positioning. Renamed moderationbuttons to modbuttons (everyone gets what it means, right..?), and got rid of this odd moderationbuttons_strip, which is just as easily accessed by '#modbuttons ul'... Also simplified template_button_strip to accept an $extra param instead of an array of options. I've double-checked all calls to TBS, and couldn't find a single use of these options except for the moderationbuttons_strip ID setting I was talking about. I could remove the $extra as well, but figured some plugins might find it helpful (you can still do $extra = 'id="my_id"'). (Display.template.php, index.template.php, topic.js, index.member.css, sections.css, Wine/extra.css, Wine/index.member.css, Wuthering/extra.css, Wuthering/index.member.css)
* Shortened small_move.gif from 305 bytes to 125. I'd actually brought it down to 100 bytes, but it didn't compress as well (took 3 more bytes than the 125-byte version). Go figure! I knew I had to compare... ;) Mind you, I also tried the same on small_delete, but Pete somehow managed to crush the competition here. What tool did you use for that one..?! (small_move.gif)
* Added '@if member' to our post liking function, as guests can't use it anyway. (topic.js)
3304
Features / Re: New revs
« on March 30th, 2013, 02:28 PM »
rev 2038
(4 files, 3kb)
! Fixed smiley caching... AGAIN. I noticed that clean_cache was overzealous, and would delete all variations of a file because of the special css codebath. Wedge now bypasses this by letting the extension start with a dot. Ah ah. Used the opportunity to shorten the filenames to use a 3-digit ID instead of a full timestamp. (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)
- Debug code. Oops! That never happens to me... (Class-Skeleton.php)
(4 files, 3kb)
! Fixed smiley caching... AGAIN. I noticed that clean_cache was overzealous, and would delete all variations of a file because of the special css codebath. Wedge now bypasses this by letting the extension start with a dot. Ah ah. Used the opportunity to shorten the filenames to use a 3-digit ID instead of a full timestamp. (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)
- Debug code. Oops! That never happens to me... (Class-Skeleton.php)
3305
Features / Re: Message icons, some proposed changes
« on March 30th, 2013, 01:06 PM »Your screen looks better: people will see the message icons and think "Oh! I can pick an icon here!", whereas as it is people notice the dropdown less.
"Drop down takes less space." the space between the icons could be reduced so that they all fit onto the one line, and then paper clip wouldn't be there.
The icon dropdown is visible. You just choose not to see it. Which is natural. Topic icons aren't there for your amusement as much as smileys are. It's a feature that's also used in other situations, that *usually* you don't even have to deal with.
As such, I don't find it a problem that it doesn't jump to your eyes, and that you have to actually look at the screen to change your icon. Heck, I've never liked these forums where people arbitrarily choose a random icon on their topics. Message index looked ugly enough in SMF... :lol:
Posted: March 30th, 2013, 01:04 PM
There's not much about our old forum that I miss, but here's how they display post icons (sorry, this is the least-worst example I can find).
3306
Features / Re: New revs - Public comments
« on March 30th, 2013, 01:54 AM »
I was technically going to modify the language files, but I figured you'd forgotten to clean this up...
My bad ;)
So you're saying I couldn't catch it before the only actual use doesn't specify the error_ prefix, right..?
Time for bed!
My bad ;)
So you're saying I couldn't catch it before the only actual use doesn't specify the error_ prefix, right..?
Time for bed!
3307
Features / Re: New revs
« on March 30th, 2013, 01:47 AM »
rev 2036 -- woohoo, message index icon fixes :)
(10 files +1-4, 10kb)
* Rewrote the topic status icons in the message index (pinned, locked, poll, my).
- Fixed poll icon to (finally!) show up... (MessageIndex.php, quick_poll.gif)
- Now using a JS-generated span system to show them. Fixes positioning issues and allows for solo manipulation. (MessageIndex.template.php, topic.js)
- Removed composite icons. This saves over 1500 bytes in the main gzipped CSS! (quick_*_*.gif)
- Improved legend styling the sidebar. (MessageIndex.template.php, sections.css)
- Harmonized Unread Posts and Unread Replies styling with Message Index. Lots of things... (Recent.template.php, sections.css)
- Just want to point out that yes, the crap rules repeated in icon_* classes saves bytes, too. (sections.css)
* Naoisms. (Unread.php, UnreadReplies.php)
! Unread Replies feature didn't actually set the participation icon. YES, we know that it's always set, as the page name implies... But still, not showing it when there's a legend next to the change is awkward. (UnreadReplies.php)
! Fixed h6 tag styling. Was broken due to incorrect nesting. (index.css)
! Fixed 'move selection to...' board select box showing up even when not selected. This was due to the .hide class being too close to the beginning of the CSS file, giving it lower priority. Hmm... (index.css, sections.css)
@ Quick note: there are three files only in the images/topic folder. Technically, they should be moved to images/icons... I'm too tired to deal with that.
(10 files +1-4, 10kb)
* Rewrote the topic status icons in the message index (pinned, locked, poll, my).
- Fixed poll icon to (finally!) show up... (MessageIndex.php, quick_poll.gif)
- Now using a JS-generated span system to show them. Fixes positioning issues and allows for solo manipulation. (MessageIndex.template.php, topic.js)
- Removed composite icons. This saves over 1500 bytes in the main gzipped CSS! (quick_*_*.gif)
- Improved legend styling the sidebar. (MessageIndex.template.php, sections.css)
- Harmonized Unread Posts and Unread Replies styling with Message Index. Lots of things... (Recent.template.php, sections.css)
- Just want to point out that yes, the crap rules repeated in icon_* classes saves bytes, too. (sections.css)
* Naoisms. (Unread.php, UnreadReplies.php)
! Unread Replies feature didn't actually set the participation icon. YES, we know that it's always set, as the page name implies... But still, not showing it when there's a legend next to the change is awkward. (UnreadReplies.php)
! Fixed h6 tag styling. Was broken due to incorrect nesting. (index.css)
! Fixed 'move selection to...' board select box showing up even when not selected. This was due to the .hide class being too close to the beginning of the CSS file, giving it lower priority. Hmm... (index.css, sections.css)
@ Quick note: there are three files only in the images/topic folder. Technically, they should be moved to images/icons... I'm too tired to deal with that.
3308
Features / Re: New revs - Public comments
« on March 29th, 2013, 11:38 PM »
I meant $txt['error_new_replies'], not $context. And if you'll do a search on error_new_repl, only Post.php has it... Also WedgeDesk, but I'm not going to fix it, it's your 'game' ;)
Anyway, I double-checked before committing. Please revert if you find anything suspicious.
Anyway, I double-checked before committing. Please revert if you find anything suspicious.
3309
Bug reports / Re: Rewriting pretty URLs with respect to the moved topic notice
« on March 29th, 2013, 10:49 PM »
So... Can you give me a step-by-step guide to reproducing this error here, or on my local install...?
It's the kind of bug that takes an hour to reproduce, and 10 seconds to fix...
:edit: Test.
http://wedge.org/index.php?topic=8023.0
It's the kind of bug that takes an hour to reproduce, and 10 seconds to fix...
:edit: Test.
http://wedge.org/index.php?topic=8023.0
3310
Features / Re: Plugin revs
« on March 29th, 2013, 10:14 PM »
rev 82
(2 files, 2kb)
! [pie_polls] Fixed styling and indenting. It's all in a day's job for Code-Repair Man. (piepolls.css, PiePolls.php)
(2 files, 2kb)
! [pie_polls] Fixed styling and indenting. It's all in a day's job for Code-Repair Man. (piepolls.css, PiePolls.php)
3311
Archived fixes / Re: Notifications bar iinvalid markup
« on March 29th, 2013, 10:10 PM »
Put me out of my misery...
3312
Features / Re: New revs
« on March 29th, 2013, 09:56 PM »
rev 2035
(7 files -2, 11kb)
+ weSkeleton()->rename() was a layer-only function. From now on, it can also rename blocks. Don't abuse it! (Class-Skeleton.php)
! add_plugin_css_file() is a bit broken. Notably, its param list was always added to the filename, instead of the elements actually used in the file. Until we do something better, I'm removing most of the (relatively useless) suffixes, like 'mod' and board/category/member ID. (Subs-Cache.php)
* Topic icons were missing some padding in the message index. I don't think that was voluntary... (sections.css)
* Optimized a few images for size, saving several hundred bytes in the process, without losing image quality. (quick_lock.gif, quick_my.gif, quick_pin_my.gif)
- Removed a few unused images -- these were from the old quickmod system. (quick_move.gif, quick_remove.gif)
- Hmm... I think Pete forgot to remove a code block after rewriting $context['error_new_replies'] to use number_context(). At least, it generated an error for me, and the variable wasn't used anywhere... (Post.php)
(7 files -2, 11kb)
+ weSkeleton()->rename() was a layer-only function. From now on, it can also rename blocks. Don't abuse it! (Class-Skeleton.php)
! add_plugin_css_file() is a bit broken. Notably, its param list was always added to the filename, instead of the elements actually used in the file. Until we do something better, I'm removing most of the (relatively useless) suffixes, like 'mod' and board/category/member ID. (Subs-Cache.php)
* Topic icons were missing some padding in the message index. I don't think that was voluntary... (sections.css)
* Optimized a few images for size, saving several hundred bytes in the process, without losing image quality. (quick_lock.gif, quick_my.gif, quick_pin_my.gif)
- Removed a few unused images -- these were from the old quickmod system. (quick_move.gif, quick_remove.gif)
- Hmm... I think Pete forgot to remove a code block after rewriting $context['error_new_replies'] to use number_context(). At least, it generated an error for me, and the variable wasn't used anywhere... (Post.php)
3313
Archived fixes / Re: Notifications bar iinvalid markup
« on March 29th, 2013, 09:54 PM »
It's not Dragooon... It's just me.
Having a div inside a p was my quick solution to align the notifications area with the flags.
And yes, I know it doesn't validate. It bothered me for a second. Then I figured, okay it can wait until I figure out a better way...
PS: all browsers correctly parse the stuff, even though it's invalid.
Having a div inside a p was my quick solution to align the notifications area with the flags.
And yes, I know it doesn't validate. It bothered me for a second. Then I figured, okay it can wait until I figure out a better way...
PS: all browsers correctly parse the stuff, even though it's invalid.
3314
Features / Re: New revs - Public comments
« on March 29th, 2013, 09:41 PM »
Done. :)
It was almost too easy... The hardest part was actually finding block names to test the thing :P
It was almost too easy... The hardest part was actually finding block names to test the thing :P
3315
Bug reports / Re: add_plugin_css_file issues
« on March 29th, 2013, 09:26 PM »
Hmm, yeah... It's complicated.
As you know, I never looked much into add_plugin_css stuff, and was hoping for you to catch up, ah ah.
I've thought about it a bit, and decided that suffixes aren't needed in plugins, for the most part.
- local, global: there are no sub-skins in plugins... No need for that.
- admin, mod: I don't see much of a need for these...
- m1, again, it's mainly for testing...
Basically, I'm only keeping: guest/member, OS, browser, and language. These are entries that I'm always saving.
The workaround would be to either merge both functions and have a param to specify it's a plugin, or rewrite the function to match its sibling's functionality, or just drop file suffixes altogether, and rely only on @if stuff, and use the opportunity to rewrite both functions.
Regarding mixins: it's never worked... Neither did extends!
Remember, they're in a common.css file, and up till now you had to explicitly add it to your add_css_file list. The same went for plugin files... Since rev 2000 or so, add_css_file automatically loads common.css, so I guess add_plugin_css_file SHOULD do it as well... Again, it's a case of "I didn't even remember that function existed..."
As you know, I never looked much into add_plugin_css stuff, and was hoping for you to catch up, ah ah.
I've thought about it a bit, and decided that suffixes aren't needed in plugins, for the most part.
- local, global: there are no sub-skins in plugins... No need for that.
- admin, mod: I don't see much of a need for these...
- m1, again, it's mainly for testing...
Basically, I'm only keeping: guest/member, OS, browser, and language. These are entries that I'm always saving.
The workaround would be to either merge both functions and have a param to specify it's a plugin, or rewrite the function to match its sibling's functionality, or just drop file suffixes altogether, and rely only on @if stuff, and use the opportunity to rewrite both functions.
Regarding mixins: it's never worked... Neither did extends!
Remember, they're in a common.css file, and up till now you had to explicitly add it to your add_css_file list. The same went for plugin files... Since rev 2000 or so, add_css_file automatically loads common.css, so I guess add_plugin_css_file SHOULD do it as well... Again, it's a case of "I didn't even remember that function existed..."