Wedge

Seen this topic... (Trying to keep up with the notifications, now... BTW, updated to rev 2072, hope you like the new popup animation, not quite what I envisioned at first, but it's the only thing that I like that doesn't require 3KB of JS and CSS :lol:)

Will reply soon. Busy IRL, for now ;)

rev 2071
(18 files, 4kb)

* Reordered smiley file cache. Not a big deal of a code addition, for a less than thrilling result (a dozen bytes saved), but as it's a free saving, and it took only minutes to implement, and it doesn't take more time to run, I'd say it's a good use of a few minutes... (Subs-Cache.php)

* Remembered that grepWin has a replace function, so I did the rest of the we::$is_member conversions... And checked them all manually, of course. (Login.php, Logout.php, MoveTopic.php, Poll.php, Post2.php, Profile.php, Register.php, RemoveTopic.php, Search2.php, Subs-Auth.php, Subs-Menu.php, Subs-Template.php, ViewQuery.php, SSI.php, Home.template.php)

* Minor CSS fixes. One looks complicated, and its only point is to save a couple of bytes and a console warning in Opera, hmm... (sections.css)

! Fixed thought template in mobile mode. (Thoughts.template.php)

rev 2069 -- mostly maintenance.
(22 files, 23kb -- over half of it due to re-indenting in zoomedia.js)

+ Added a we::$is_member variable, which is simply the opposite of we::$is_guest... Not that it's going to be very useful, but I don't see the reason to force people to use !we::$is_guest when they could use the other. Also, Wess did an extra test for guests and members, when it should already be dealt with by we::is(), so I removed these... There are still dozens to fix, but we're in no hurry. It's just my usual pedantry... (index.php, Class-CSS.php, Class-System.php, Display.php, Feed.php, Load.php, Login2.php, Aeva-Gallery.php, Aeva-Gallery2.php, Subs-Media.php, MessageIndex.php, Security.php, Thoughts.php, Welcome.php, Subs.php, Subs-Post.php, index.template.php, Boards.template.php, Display.template.php, MessageIndex.template.php)

! Fixed Wedge insisting on calling you a 'guest' if you're not logged in, even if you're not in English mode. (Class-System.php, Load.php)

! Fixed broken image in sidebar when no avatar is set for oneself. (Class-System.php, Subs.php, index.template.php)

* Moved Zoomedia's language strings to the JS file. Commented most of them out, since they're not really used for now... Saves space, eh? (Aeva-Subs-Vital.php, zoomedia.js)

* draftXmlReturn wasn't using the return_xml() shortcut, sadly... (Subs-Post.php)

I'm an absolute Who lover... Well, the 'modern' Who anyway, as I never grew up with Who, and only discovered him at age 30.
I loved seasons 5, 6 and the first part of season 7. They all had fantastic episodes.
Still.
After a very nice reboot (Bells), the following episodes were all disappointing to me.

- The Scifi episode. Seems to be a staple: whenever the Doctor gets both a new companion AND a reboot, he ALWAYS takes them to the future first: Rose went to the end of the Earth, Amy went on Starship UK. The other two companions, Martha and Donna, not being part of an attempted reboot, had to wait for an extra episode to get to the future... I'm saying this, because in Doctor Who, 90% of the episodes are spent in the past, or the present time. Future episodes are very rare, in comparison... Possibly because of the higher budgets, I don't know. Anyway: I didn't find the episode extraordinary, I still liked the two 'singing' scenes very much, but I had a huge problem with the fact that the Doctor 'shared' his memories without losing them (or his life). What makes him so different, eh..?

- The U-Boat episode... Oh, my. It had David Warner in it, so I was excited, but he didn't have much to do in it, except exhibit a Walter Bishop-like personality (slightly mad, very smart, unable to do stunts, and very much in love with old music. Well, new music for him, obviously, as it's set in the 80's...) The rest, err... Well, seriously, did this episode have ANYTHING interesting going on..? No, I don't think so... It's just a boring remake of The Thing, or SomeThing Else. I've always noticed that Mark Gattis's episodes always lacked originality. None of his episodes I ever really liked. I guess, I much prefer him in Sherlock, either playing Mycroft, or writing The Hounds of Baskerville for instance... ;)

- The Ghost episode... It started out as really, really boring. Just like in Cold War, I spent most of my time browsing my S3 while keeping an eye on the TV. Well, it got a bit better when the Doctor started going through all eras, it was a fun moment, and his rescue was nice as well. Okay, I thought, not a bad episode this time... Phew. Except that for some reason, the writer decided it would be really, really smart to cram everything he could think of into the end of the episode, so we have: (1) a Tardis who speaks for the first time since The Doctor's Wife, but NOT to say anything remotely interesting, (2) a Tardis that refuses to go into the pocket universe (when was the last time she jumped into one of those..? Ah, yes, The Doctor's Wife...), but suddenly makes the jump without any issues, and then later in the episode does it AGAIN, long after the first time, even though she said the universe was going to disappear any moment now... (Don't tell me she went back to the past, it's a cop-out.) (3) a monster that, for no reason whatsoever, is separated from his wife, or girlfriend, or whatever, but nothing is explained about how it went into the pocket universe, or why the other monster is in a castle wing, or even why nobody noticed that before, except for the Doctor of course... (4) a time traveller who keeps doing uncomfortable smiles, and a doctor who never, ever points out that he's going to take her back to her time... Actually, does he even plan to do that..? Or does he intend to leave her be, with, err... Her ancestor..?! (5) That's all I can remember, but I know there were more, when I watched the episode...

So, overall, I find these to be the weakest three episodes in a row, since the early seasons. Very disappointed, as I said. Hopefully, next week's episode will be a bit better, at least, the subject is interesting, if anything...
But really, I'm waiting for the last two episodes mostly -- Neil Gaiman's episode, forever in love with your works man!, and Moffat's episode, especially because of the episode name...

I'm not interested in fighting with you, Pete... I don't even see a reason for you to be upset with me.Err... I'm not sure, why you would go through the agony of re-using SMF's mod system when you went to great length to rewrite it all, and I don't see either in what way it's a clue as to your situation... What does it mean? That you want to dump Wedge, and join the SMF dev team or something..? Would seem like a huge step backwards, wouldn't it..?We all do that from time to time... What matters is that it's caught, isn't it..? I was mainly thinking, that if it works it's only due to Wess being relatively cool with commas, but other than that I'm unsure whether you committed this as a last-minute change while documenting the changelog (like I often do -- and this is where most of my bugs come from, even though I've become increasingly tough with myself at these particular times...), or if you simply didn't catch it at dev time, and 'it worked', so you didn't have to bother...

Also, you know me better than that. 'Criticizing' is a bit of harsh to qualify my comments... No?That's for you to solve, not me...

The reason why Wedge's development has gone with very few hiccups in the last three years, is that quite early on we individually chose to focus on different things. You went for the long-term 'wow' factor that new big features represent (I, myself, feel that my work on Aeva Media is enough to justify my contribution to the feature department :P), while I went for the 'immediate' wow factor that is the design, layout, and bandwidth savings that contribute to making a website load faster, and being more efficient altogether.
BOTH of these areas are crucial to make Wedge a success, really... So, we need to both be at the top of our game. And when I'm touching an area in the admin section that I'm not too sure about, I always consult with you beforehand, because I don't want to add any difficulties for you. On my side, though, developing CSS and JS is something that's going to be done by external developers as well, so (1) Wess & co. need to be as flexible as possible (so I don't mind you doing things differently, as it helps me see how others might 'exploit' Wess in interesting ways), and (2) as the Wedge source code will be the primary source of inspiration to themers and plugin authors, we need it to be clean and tight, and a 'good example' of how to do things correctly, so with regards to (1), if I find anything in your CSS that can be improved upon, I will. And I'm absolutely expecting you to do the same with my code, really... Even CSS! If you feel like it's going to be better if I do something one way rather than the other, regardless of how many bytes it takes, fine by me; my only real concern, really, is to prevent Wedge from being bloated. That is why, whenever I add a new feature, I try to 'compensate' for it by optimizing elsewhere (or in the same place), like I did with thoughts today. (It saves bytes everywhere -- JS, CSS and HTML, cached or not.)

It does seem like a no-brainer to me... We both respect each other (at least I hope so, because that would be a huge waste of three years for one of us if it wasn't the case, right..?), and we work in different areas because we do what we're best at (and, for an unpaid job, what we enjoy the most really), and Wedge is a huge enough codebase to justify working on different areas, anyway... We can't do everything, or at least not everything right...Another difference of opinion between us...
I think you're an absolute genius at adding 'natural' features to a forum platform; taking things apart, and saying "this is how it should be done, not how it's been done the last 15 years everywhere else..." If I did the same, it would be potentially shocking because over the years, I've made  some pretty... 'interesting', and 'scary' designs for a default theme, but really I threw them all away because I'm trying to appeal to everyone, and those who are used to how SMF does things, should also be accounted for. Admin area is different, because it only concerns one person, the admin, and you've been working hard to make it fun for them to use, anyway.

The difference in opinions stems from the fact that I believe, as a couple of geeks who've been spending all our time on a crazy project for nearly three years, we're entitled to do *what we want*, rather than *what we think others want*. Sure, a large part of our work should be catered to doing things with other users in mind, but it's also an opportunity to just have fun with complex problems, and elegant solutions.
Plus, it makes for a happier Nao, and a happier Arantor. And when we're happy, we're likely to keep working on it.
Never put anyone else's comfort before yours. Unless they frigging pay you for it.Have you ever seen me revert a change of yours (perhaps a minor one at worst!), or rewrite something of yours significantly..?
No, because I don't tend to touch your code, I only double-check it when you commit it, and as we discussed before, I like adding my 'touch' on it, and you told me you didn't mind, so I just kept doing it, because I'll never change something significantly without consulting with you first. Really, I'm surprising you're saying that of me... :-/

Anyway, yes, feel free to commit your CSS and JS "unoptimized", and I'll do it for you. Because do you know one of the things I enjoy the most out of my code..? Yes, fucking saving fucking bytes. I just love it. That's why I count them. That's also why I don't mind when suddenly the filesize grows by a kilobyte or two (like it did when we merged Dragooon's notification system): because it's a new challenge for me, to make it even smaller...! I just love that. That, and making sure that it still works efficiently, and doesn't add any bloat anywhere. (For instance, in the last commit, I removed a couple of lines of CSS that were unneeded, as well as an equally unneeded wetem::load; and believe me, even though it took me far more minutes to check these than the savings deserved, it really made me happy, on the spot. And that's what matters. Keep a Nao happy, and you get your Wedge going.)It's not so premature, considering we're way closer to a public release than to the first days, eh..?
Once it's out in the public, I won't be able to do CSS and template changes in a, hmm... in a way that's so inconsequent, as I'll have to take plugins and skins into account, and whether or not I'm going to break something, and whether it's worth it.... So, yeah, I'm optimizing now, because I like it, and because I know it'll be harder to do it later on. So, it's "just-in-time optimizing", if you want ;)Perhaps I missed your post, simply...? I don't see in what way it's so hard to add menu icons, really..?

If you want to be able to add them from plugin CSS, then I can certainly move my button classes to common.css so that they benefit from them, but it's not that big a deal really, as they can simply re-use the same CSS, I'd say..? They can even do dynamic functions, at least that's what it was built to do...

(Oh, and speaking of dynamic functions, I spent a few minutes optimizing the smiley one, this morning... It saves a dozen bytes. It may not seem much, but considering I only changed the file loading order and nothing else, it's a nice improvement. I may even get more out of it by sorting the files by name, but I don't think it's worth the research, at least not today...)I don't remember that issue...Yes, you can blame me for expecting more of you in that respect than I'm doing myself. Why so..? Because to me, it seems like you're able to do so many different things at the same time, when I'm struggling to just keep up with balancing between real life, and Wedge life.
So, yes, I've skipped a lot of topics, and I kept doing so, because you told me it was okay, and that you'd tell me whenever you'd need my opinion (by PM or whatever). Recently, we added notifications for that, but I'm not 'done' with them yet, and I'm not even used to checking it constantly... But I've planned to them to be a life-changer for me, regarding how it influences my way to follow the forum, I'd say...

Also, while sometimes I'm bumping my posts and fishing for opinions, I'm not just asking for yours in particular... I also value very fondly the opinions of our consultants, but also those of anyone who has anything to say on a given subject, and takes time to do it. It's just that, sometimes, people seem to think that conversations are 'just' between you and me, and they can't intervene... Which, if you'll allow me, is a bit silly...24 pages of unread topics, yeah...But where did I criticize your work in a way that came to upset you that much...?
Heck, you know I'm just as insecure as you are... You know I admire your work, and you know that I don't know I could do a tenth of what you've been doing for Wedge. Just as I know that you consider me to be 'the best man' to work on JS/CSS/HTML, and keeping up with new technologies, and things like that... (Hopefully!!)
I'm not shocked whenever someone says they don't like this or that in my work... In fact, it usually means it can be done better: either by rewriting, or by actually explaining why it's better... Sometimes, people just need a little convincing! And if you have it in you, it's very easy, really, to convince them. Otherwise, maybe it really has a problem, so... Time well spent, either way!Which, of course, they aren't...If you're so uncomfortable with this, are you sure you ever want to go public..? :-/ You need to assert your capabilities. You did get your Zend certification, after all, something I'm not sure I'm even capable of getting (hence why I'm not even looking into trying), and your knowledge of programming is vast, but it's still tiny compared to how well you know what you do in general. You always have the last word, because you have things to bring to the table, and you know better. Some people hate you for that, but most love you for it. And I'm just surprised to see that, in contrast with your immensely wider knowledge than any of us in here, you're still uncomfortable with details that people are giving you in response to your commits. To give you an image -- it's as if you'd started painting the Mona Lisa, were close to finishing it, and then suddenly decided to throw it away because your pigment assistant said he would have chosen a dark grey over your light black to represent this tree in the shadows. Not even considering the fact that he may or may not be right about it, it's a tiny detail, and is due to the fact that he doesn't like praising his boss for nothing and make him think that it's just a way to keep his position... No. That assistant genuinely likes the work, and his specialty is pigments, so he's just giving his opinion on this minor thing because, well, it can still be changed, and if he managed to get one of his ideas into the painting, he would be proud to be associated with it...

That's the general idea, yes. While we're not working on the Mona Lisa of boards (but not far from it, though ;)), we're still very proud of our own work, and aware of our talent, and still fragile when it comes to criticism. But it doesn't mean we should engage in battles like the one you seemingly want to jump into. No, Pete, I won't fight with you. If you want me to apologize for hurting your feelings, even if I don't understand where or when I hurt them, then I'll apologize. But it still won't stop me from making further comments in the future about your work, not because I'm dissatisfied with it, but simply because I'm eager to add a stone to your church, that's all.We're unpaid, and we're hurting our health working like crazy on these things. There's definitely a small hint of pride in what we both do with our lives, I guess... ;)

No; he happened to post on the elk forums yesterday, so it would be surprising that for some reason, he couldn't make it to his own forum on the same day, I would say...
This isn't the first time he's done this. He'll come back. I'd just appreciate if he could tell me what's upset him, instead of leaving without a word... But I can't change people, can I? Can i..?

:edit: Fixed topic name...

rev 2067 -- everything I could find from sections.css, and some satellite files...
(13 files +4 -1, 24kb)

- Removed ability to ask for a topic notification from within places that do NOT show the entirety of the topic... It only makes sense to require someone to at least have a glance at a topic, before they can determine whether it's worth their attention at all... (Profile-View.php, Recent.php, Search2.php, Profile.template.php, Recent.template.php, Search.template.php)

* Push my button. Saved over 500 bytes from the final CSS filesize... Not bad, I guess..? (blank-button.png, warn.png, quickbuttons-32bit.png, approve.gif, restore.gif, actions.png, warn.gif, extra.rtl.css, sections.css)
  - Reworked the 'in context' button from a new blank-button I quickly cooked up, as well as warn.gif to make it more readable.
  - Removed notify.gif button, as it was only used in those places I removed.
  - Removed notify_sm.gif, I couldn't for the life of me find a place that uses it. Anyone else, maybe..?
  - Split approve and restore buttons out of the button sprite, as they're very, very unlikely to be ever seen, even by an admin...

! Better alignment for plugin icons in admin menu. (mana.css)

! Fixed top left margin in thought threads. (sections.css)

- Removed flex use from topic posts. You can still use @if can_flex in your CSS to provide a fallback for non-flex supporting browsers, but I'd advise against using nested flexboxes, as they're VERY, VERY buggy, and even browser authors recognize it... So, basically, doing rowspans and colspans in flex..? Not a very good idea of mine. The only ways to do that, are table tags, or the grid layout from IE10, which I'll try and implement, once it's available in Chrome, and perhaps in Firefox... But I wouldn't hold my breath. Sob. Also, upped the minimum versions of Chrome and Firefox to support flex, as earlier versions are even buggier... See the pattern, eh..? And finally, restored support for Opera 12.1+, as in the end, it's not buggier than other browsers, it just is... differently buggy, I guess... (Class-CSS.php, sections.css)