This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
3001
Bug reports / Re: Infraction bugs
« on May 12th, 2013, 04:13 PM »Oh, yes, that needs to be handled.
I'll let you handle it though, don't have time today, I was working on fixing a thought bug (commit coming later), and have run out of coding time... :^^;:
3002
Off-topic / Re: Doctor Who
« on May 12th, 2013, 03:52 PM »
Good then, eh eh...
Well, my disappointment over yesterday's episode was certainly due to my fanboyism. I know for a fact that I was very appreciative to have Warwick Davies in the episode, he's just so cool.
I liked having the Being Human baddie from season 2 in the episode, too, but he was far too under-developed... Really, his main scene *was* the Gaimanesque part of the episode. The rest felt like "the mandatory Cybermen story" to me.
It's not so often that I like the beginning of a Who episode better than the rest, but there it is.
Oh, I also inadvertently read a spoiler about the 50th anniversary special... If you're adamant NOT to be spoiled, then follow my advice: do not, ever, attempt to read a John Hurt interview, or any news article related to John Hurt in this episode. He gave a huge bit away without consideration for Moffat, and it was obviously not a good idea... (I don't mind spoilers too much, so I don't really mind this one either; I just think that some of you might be upset about it.)
Well, my disappointment over yesterday's episode was certainly due to my fanboyism. I know for a fact that I was very appreciative to have Warwick Davies in the episode, he's just so cool.
I liked having the Being Human baddie from season 2 in the episode, too, but he was far too under-developed... Really, his main scene *was* the Gaimanesque part of the episode. The rest felt like "the mandatory Cybermen story" to me.
It's not so often that I like the beginning of a Who episode better than the rest, but there it is.
Oh, I also inadvertently read a spoiler about the 50th anniversary special... If you're adamant NOT to be spoiled, then follow my advice: do not, ever, attempt to read a John Hurt interview, or any news article related to John Hurt in this episode. He gave a huge bit away without consideration for Moffat, and it was obviously not a good idea... (I don't mind spoilers too much, so I don't really mind this one either; I just think that some of you might be upset about it.)
3003
Bug reports / Re: Infraction bugs
« on May 12th, 2013, 03:47 PM »
Tried disemvowelling (sp?) posts from a test account locally.
One post just said "No idea."
As a result, the post was "N d."
Not very readable, actually...
I'd instead suggest scrambling all words, except for the first and last, as it was the subject of an amusing meme a few years ago, and I think it still keeps the whole thing readable...
Also, a bigger bug I'd say: if I go through /profile/test-account/, and click Show posts, there they are... All of his posts, untouched.
(I just noticed that 'disemvowel' was a play on 'disembowel', ah ah... Well, you can't blame me for my English :P But I did notice that it was strange to have an 'm' in it, considering the rule that it should only be before a 'b' or another 'm'... At least in French.)
So... This is my personal take on it: (in Subs-BBC)
Code: [Select]
Followed, at the end, by:
Code: [Select]
Feel free to re-use the code unmodified, or modified, or to just forget about my suggestion... ;)
One post just said "No idea."
As a result, the post was "N d."
Not very readable, actually...
I'd instead suggest scrambling all words, except for the first and last, as it was the subject of an amusing meme a few years ago, and I think it still keeps the whole thing readable...
Also, a bigger bug I'd say: if I go through /profile/test-account/, and click Show posts, there they are... All of his posts, untouched.
Posted: May 12th, 2013, 03:32 PM
(I just noticed that 'disemvowel' was a play on 'disembowel', ah ah... Well, you can't blame me for my English :P But I did notice that it was strange to have an 'm' in it, considering the rule that it should only be before a 'b' or another 'm'... At least in French.)
Posted: May 12th, 2013, 03:35 PM
So... This is my personal take on it: (in Subs-BBC)
$part = htmlspecialchars(preg_replace_callback('~(?<=\b[a-z])([a-z]{2,})(?=[a-z]\b)~i', 'wedge_callback_str_shuffle', $part), ENT_QUOTES, 'UTF-8');Followed, at the end, by:
function wedge_callback_str_shuffle($match)
{
return str_shuffle($match[0]);
}Feel free to re-use the code unmodified, or modified, or to just forget about my suggestion... ;)
3004
Features / Re: New revs
« on May 12th, 2013, 12:13 AM »
rev 2109 -- before jumping to bed...
(5 files, 2kb)
* More pedantic optimizations. Despite everything you'll hear, strpos($str, $substr) === 0 is slower than $str[0] === $substr. Deal with it. (Class-Package.php, ManageErrors.php, QueryString.php, Security.php)
* Commenazi. This one's for Pete... ;) (Subs.php)
(5 files, 2kb)
* More pedantic optimizations. Despite everything you'll hear, strpos($str, $substr) === 0 is slower than $str[0] === $substr. Deal with it. (Class-Package.php, ManageErrors.php, QueryString.php, Security.php)
* Commenazi. This one's for Pete... ;) (Subs.php)
3005
Off-topic / Re: Doctor Who
« on May 12th, 2013, 12:08 AM »
+1 with your post, obviously...
So, I watched Gaiman's episode... And was utterly disappointed.
Not on the same level as The Doctor's Wife... Not even as good as last week's episode.
I don't know what was the point of the episode... So, he wanted to write a Cyberman episode? Cool. He wanted to have some likeable characters come from out of nowhere, like in TDW? Cool... But did he really have to barely give them a minute of screen time before we switch again and again to the Doctor's boring shouts and Clara's so-fascinating impossible-girl mysteries?
I don't care that she's impossible... She's just NOT that special to me. Bring me back River Song -- any time. Especially next week.
I'm afraid this is the weakest streak of episodes since, hmm... Season 2 or something.
And I absolutely adore Neil Gaiman. I think he's a great guy, too. I'm just so disappointed he wrote an episode that didn't add anything to the Doctor's mythos. It seems like a waste of his time... :-/
So, I watched Gaiman's episode... And was utterly disappointed.
Not on the same level as The Doctor's Wife... Not even as good as last week's episode.
I don't know what was the point of the episode... So, he wanted to write a Cyberman episode? Cool. He wanted to have some likeable characters come from out of nowhere, like in TDW? Cool... But did he really have to barely give them a minute of screen time before we switch again and again to the Doctor's boring shouts and Clara's so-fascinating impossible-girl mysteries?
I don't care that she's impossible... She's just NOT that special to me. Bring me back River Song -- any time. Especially next week.
I'm afraid this is the weakest streak of episodes since, hmm... Season 2 or something.
And I absolutely adore Neil Gaiman. I think he's a great guy, too. I'm just so disappointed he wrote an episode that didn't add anything to the Doctor's mythos. It seems like a waste of his time... :-/
3006
Archived fixes / Re: 'Like' Disappears When Clicked
« on May 11th, 2013, 08:21 PM »
Oops missed that.
Shall I shorten the line then..?
Shall I shorten the line then..?
3007
Features / Re: New revs
« on May 11th, 2013, 06:36 PM »
rev 2108 -- okay, maybe not 'a few minutes' after all... More like a few seconds.
(5 files, 6kb)
+ Added a new return_* helper function, return_callback, which accepts a string representing a function name (usually a template), followed with an array of arguments (or nothing). This allows you to use the return_* system with a function that will echo its output, instead of returning it in a string. Replaced Like handling with this. (Like.php, Subs.php)
* Rewrote pm.js "my way", with Pete's blessing. This saves about 500 bytes, and 150 when gzipped. Not bad for something that does exactly the same... (pm.js)
! Minor auto-suggest bug. Item count shouldn't be increased if the hook called right after it decides to prevent adding an item... This wasn't found until now, because no hooks were called so far anyway... (suggest.js)
! And they wouldn't have worked anyway. Fixed a sorry bug where I was calling the hook with .call(function), instead of .call(this, function). And that was an old one..! (suggest.js)
! overflow-y: scroll always shows a scrollbar, even if you don't have many contacts. Fixed to overflow-y: auto. (index.member.css)
(5 files, 6kb)
+ Added a new return_* helper function, return_callback, which accepts a string representing a function name (usually a template), followed with an array of arguments (or nothing). This allows you to use the return_* system with a function that will echo its output, instead of returning it in a string. Replaced Like handling with this. (Like.php, Subs.php)
* Rewrote pm.js "my way", with Pete's blessing. This saves about 500 bytes, and 150 when gzipped. Not bad for something that does exactly the same... (pm.js)
! Minor auto-suggest bug. Item count shouldn't be increased if the hook called right after it decides to prevent adding an item... This wasn't found until now, because no hooks were called so far anyway... (suggest.js)
! And they wouldn't have worked anyway. Fixed a sorry bug where I was calling the hook with .call(function), instead of .call(this, function). And that was an old one..! (suggest.js)
! overflow-y: scroll always shows a scrollbar, even if you don't have many contacts. Fixed to overflow-y: auto. (index.member.css)
3008
Features / Re: New revs
« on May 11th, 2013, 06:35 PM »
rev 2107 -- with another one coming up in a few minutes.
(4 files, 2kb)
! Fixed a bug where URLs like /profile/?u=123 would ignore the u parameter (member ID), and instead redirect to your profile. (QueryString.php)
* No need to define that variable..? (ManageBans.php)
* Pedant optimizations. Really, I'm not even sure it saves time... But don't complain too much; I could have used a single-line call_user_func on that variable function, saving three lines but doubling execution time by, err... Half a micro-second per pretty URL filter. I told you, it's a pedant optimization. (Subs-Template.php)
* Commenazi. (PrettyUrls-Filters.php)
(4 files, 2kb)
! Fixed a bug where URLs like /profile/?u=123 would ignore the u parameter (member ID), and instead redirect to your profile. (QueryString.php)
* No need to define that variable..? (ManageBans.php)
* Pedant optimizations. Really, I'm not even sure it saves time... But don't complain too much; I could have used a single-line call_user_func on that variable function, saving three lines but doubling execution time by, err... Half a micro-second per pretty URL filter. I told you, it's a pedant optimization. (Subs-Template.php)
* Commenazi. (PrettyUrls-Filters.php)
3009
Archived fixes / Re: 'Like' Disappears When Clicked
« on May 11th, 2013, 04:27 PM »
This, then..?
Code: [Select]
Best I can do to make it... 'readable'.
echo ($ret = call_user_func_array($callback, $args)) ? $ret : '';Best I can do to make it... 'readable'.
3010
Archived fixes / Re: Failed logins
« on May 11th, 2013, 01:11 PM »
Dropping Opera? Sacrilège ! :P
3011
Archived fixes / Re: Multiple Same-Name Selection Box When Notifying
« on May 11th, 2013, 11:54 AM »
This is a bug that I noticed ever since the first introduction of mentions; I reported it a couple of times, and added it to my to-do list; however, I haven't had time to work on it, yet. It took me a while to get the dropdown to position right next to the cursor, so I was quick to leave everything else aside, ah ah...
Also, I was quite bummed when I realized that it you type quickly, like I do, you often end up typing the name more quickly than the mentions thing can show it to you. Thing is, in the auto-suggest, you HAVE TO select a name to keep going. In @mentions, you can just type the name, and keep typing the rest. It's nearly... Pointless, to have a dropdown, actually... :-/
Would probably be more useful to have some text show up below the textarea, saying something like, "Nao will receive a mention notification once you hit Submit."
Also, I was quite bummed when I realized that it you type quickly, like I do, you often end up typing the name more quickly than the mentions thing can show it to you. Thing is, in the auto-suggest, you HAVE TO select a name to keep going. In @mentions, you can just type the name, and keep typing the rest. It's nearly... Pointless, to have a dropdown, actually... :-/
Would probably be more useful to have some text show up below the textarea, saying something like, "Nao will receive a mention notification once you hit Submit."
3012
Archived fixes / Re: 'Like' Disappears When Clicked
« on May 11th, 2013, 11:51 AM »
I don't get why you're doing a var_dump when technically you should do an echo... :^^;:
And echo null, like echo false, returns an empty string...
And echo null, like echo false, returns an empty string...
3013
Archived fixes / Re: 'Like' Disappears When Clicked
« on May 10th, 2013, 11:47 PM »
I don't think testing is important, because it doesn't return null anyway, it returns false or whatever the function returns; and echo false will output nothing, so I think we're protected...
3014
Features / Re: Pruning old PMs
« on May 10th, 2013, 11:39 PM »
Okay, then it's more a matter of who will be pissed enough about it to start work on it... ;)
3015
Archived fixes / Re: 'Like' Disappears When Clicked
« on May 10th, 2013, 11:36 PM »Return by callback is cool.
Oh, thinking about it... I should probably add echo before that call_user_func_array, shouldn't I..? In case the callback function isn't a template at all... ;)
clean_output ensures ob_sessrewrite gets called too, so the URL rewriter gets called and everything's magic and wonderful.
return_raw() really should be called only for stuff that doesn't contain long text, especially URLs and such... I don't know what got through me. I know I went through several phases when I wrote the return_* functions, and return_raw was added last (it was originally a way for me to more easily output some XML without having to re-read the output buffer handling documentation every time... :lol:), and I changed it from return_text to return_raw, I think, and for no particular reason... :-/
Also, no, I didn't get multiple notifications but at the same time the original one was still unread...