Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
2971
Archived fixes / Re: cache errors
« on May 21st, 2013, 07:59 PM »
As mentioned in the thoughts...
I don't know what causes this. It's due to my rewrite of the CSS filename generator, but still -- I just can't reproduce (for now).
I'll add more fail-safes, dunno...
I don't know what causes this. It's due to my rewrite of the CSS filename generator, but still -- I just can't reproduce (for now).
I'll add more fail-safes, dunno...
2972
Features / Re: New revs
« on May 21st, 2013, 06:05 PM »
rev 2125 -- all of the rest...
(8 files, 5kb)
* Made the Chrome for Mobile fix more generic, by applying it to the universal selector. All elements need it really, even though 99% of the issues stem from table cells (which is also why 99% of all problematic websites in Chrome 25+ are forums... Eh.) (index.css)
+ Added ability to easily restyle mini-menu fonts. (index.css)
! Fixed PM contact list box breaking layout in smaller screens. (editor.css)
* Refactored CSS filename generation, to something more acceptable. To me, at least... It basically calls array_filter twice instead of once (to deal with 0's, see below), and avoids doing a useless preg_replace. Plus, the code is shorter this way. (Subs-Cache.php)
! Fixed the odd '0-guest' CSS filenames generated when serving content to a bot, or any client that doesn't provide an actual browser or OS name. (Subs-Cache.php)
! Fixed hardcoded text in the custom profile area. And other things. (ManageMemberOptions.php, Admin.template.php, ManageSettings.language.php)
* Translation. Changed "entrée" to "saisie" as translation for "input", as it suddenly sounded better to me... (ManageSettings.french.php)
* No biggie, but I think that an strpos() is faster than a substr_count()... (Subs-Template.php)
(8 files, 5kb)
* Made the Chrome for Mobile fix more generic, by applying it to the universal selector. All elements need it really, even though 99% of the issues stem from table cells (which is also why 99% of all problematic websites in Chrome 25+ are forums... Eh.) (index.css)
+ Added ability to easily restyle mini-menu fonts. (index.css)
! Fixed PM contact list box breaking layout in smaller screens. (editor.css)
* Refactored CSS filename generation, to something more acceptable. To me, at least... It basically calls array_filter twice instead of once (to deal with 0's, see below), and avoids doing a useless preg_replace. Plus, the code is shorter this way. (Subs-Cache.php)
! Fixed the odd '0-guest' CSS filenames generated when serving content to a bot, or any client that doesn't provide an actual browser or OS name. (Subs-Cache.php)
! Fixed hardcoded text in the custom profile area. And other things. (ManageMemberOptions.php, Admin.template.php, ManageSettings.language.php)
* Translation. Changed "entrée" to "saisie" as translation for "input", as it suddenly sounded better to me... (ManageSettings.french.php)
* No biggie, but I think that an strpos() is faster than a substr_count()... (Subs-Template.php)
2973
Features / Re: New revs
« on May 21st, 2013, 05:42 PM »
rev 2124 -- feel free to revert if not to your taste..? I just felt like doing that, and liked it enough to commit...
(11 files, 7kb)
* Refactored action array a bit more, inspired by Pete's work... Aligned all entries to make them more readable (well, if your tab size is 4 spaces, as should be...), converted all array('Function') to just 'Function' (it only takes an extra line to account for this, and is probably faster due to not having to create the array structures), shortened verificationcode action name to fit the tab rewrite, converted Boards and Logout actions to strings (they didn't need to be in an array in the first place), and renamed several functions to match their container file when it made sense. Phew... Saves nearly 500 bytes out of the total index file size, so it's all good. (index.php, Admin.php, Groups.php, Mailer.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, PostModeration.php, Subs-Editor.php, Themes.php, VerificationCode.php)
! Commenazi -- fixed a file containing a comment an accent encoded in ISO-8859-1. (ManageSettings.php)
(11 files, 7kb)
* Refactored action array a bit more, inspired by Pete's work... Aligned all entries to make them more readable (well, if your tab size is 4 spaces, as should be...), converted all array('Function') to just 'Function' (it only takes an extra line to account for this, and is probably faster due to not having to create the array structures), shortened verificationcode action name to fit the tab rewrite, converted Boards and Logout actions to strings (they didn't need to be in an array in the first place), and renamed several functions to match their container file when it made sense. Phew... Saves nearly 500 bytes out of the total index file size, so it's all good. (index.php, Admin.php, Groups.php, Mailer.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, PostModeration.php, Subs-Editor.php, Themes.php, VerificationCode.php)
! Commenazi -- fixed a file containing a comment an accent encoded in ISO-8859-1. (ManageSettings.php)
2974
Features / Re: Splitting a topic, keeping the origin
« on May 20th, 2013, 09:52 PM »
Good idea!
2975
Off-topic / Re: Doctor Who
« on May 19th, 2013, 03:49 PM »
I watched it, BTW, and wasn't fully thrilled... too much, too soon. Or too late. depends on what you were expecting.
(click to show/hide)
Maybe I've seen too many silly twists these last few weeks, with OuaT and Elementary... why can't they go soft, like Homeland and TWD did..?
Plus, I got spoiled with Hurt being the 9th, so, whatever...
Maybe I've seen too many silly twists these last few weeks, with OuaT and Elementary... why can't they go soft, like Homeland and TWD did..?
2976
Off-topic / Re: Doctor Who
« on May 19th, 2013, 11:13 AM »Are you talking about the first or second season of OUaT? I thought actually that the tying up of season one with Pinocchio was quite smoothly done actually.
Okay, that Doctor Who..? I started it, and it's looking VERY bad. Shall I continue..?!
2977
Features / Re: New revs
« on May 19th, 2013, 10:10 AM »
rev 2122 -- minor commit, sorry...
(6 files, 2kb)
! Non-topic edits gave an undefined index error. (Post.template.php)
* Tweaked editor CSS to prevent the contact list from breaking its layout too easily. Also moved #contactlist code to editor.css, along with a member test. Makes more sense. (editor.css, index.member.css)
* Spacinazi. (ManageMemberOptions.php, Security.php, Subs-BBC.php)
(6 files, 2kb)
! Non-topic edits gave an undefined index error. (Post.template.php)
* Tweaked editor CSS to prevent the contact list from breaking its layout too easily. Also moved #contactlist code to editor.css, along with a member test. Makes more sense. (editor.css, index.member.css)
* Spacinazi. (ManageMemberOptions.php, Security.php, Subs-BBC.php)
2978
Archived fixes / Re: Error Message Displayed When Replying
« on May 19th, 2013, 12:01 AM »
Oh, missed that topic...
I fixed that about half an hour after uploading. Also fixed locally. Will commit tomorrow, but it's just a matter of adding an extra test... ;)
I fixed that about half an hour after uploading. Also fixed locally. Will commit tomorrow, but it's just a matter of adding an extra test... ;)
2979
Features / Re: New revs - Public comments
« on May 18th, 2013, 10:20 PM »There are probably other array_intersect calls, sure.
As far as permissions, it's long been on my plan to adjust how permissions were loaded and tested (to use isset rather than in_array) but that was part of the permissions overhaul and until I figure out how to make the UI, I won't be touching that.
My only opinions (not suggestions) about the permission UI, would be that:
- I should be able to get a proper list of permissions, global and per board (and per album), for any given member, with a section in their profile area... (I've been stung with this in SMF; yesterday, I tried giving the same rights to two Noisen mods, and one of them is complaining that he doesn't have the same rights, which seems impossible according to his group list...)
- In the radio box list, I'd personally use dropdowns with an icon on each (green for enabled or enabled_own, red for disabled, another green or some blue for enabled_any). Sure, it's an extra click to change a permission, but then you can add deny permissions, right..? Unless you want to add deny for _own and _any separately, in which case, err... :-/
- I'd like to see the membergroups ajaxified... i.e. when clicking the link to modify their permissions, have it load under the permission name instead, so that you can even load multiple membergroups on one page, and then change them all in a row...
I haven't read the proper topic (yet), though.
2980
Features / Re: New revs - Public comments
« on May 18th, 2013, 05:23 PM »
Lulz.
BTW, it's quite tempting, re: rev 21+21, to go through the codebase and replace all array_intersect() calls with something that's faster...
To be specific, imagine that as a global moderator (but not an admin), you have dozens of permissions applied to you.
If I wanted to know whether you have permission can_do, in_array('can_do', $perms) is very fast. (Not as fast as an isset() test, but whatever.)
Now, if I want to test against can_do and can_eat, array_intersect(array('can_do', 'can_eat'), $perms) can become really, incredibly slow. The more permissions you add to the first or second array, the slower it gets, and exponentially. I've found that doing multiple in_array calls on can_do and can_eat can be much faster. Of course, we're talking minor speed increases, so it's not THAT important... I tested with a request of 3 permissions, all of which being wrong (it's 3 times faster if the first one is true, of course). The $perms array was arbitrarily filled with 110 entries, which is probably twice as many permissions you'll ever need to give someone... Still, array_intersect was approximately 150 times slower than three consecutive in_array tests. I'm not kidding you, guys... Call array_intersect 10.000 times, and we're talking multiple seconds to complete, while it executes in a few milliseconds with in_array().
So, maybe there are other array_intersect() calls to intercept elsewhere, what do you think..?
BTW, it's quite tempting, re: rev 21+21, to go through the codebase and replace all array_intersect() calls with something that's faster...
To be specific, imagine that as a global moderator (but not an admin), you have dozens of permissions applied to you.
If I wanted to know whether you have permission can_do, in_array('can_do', $perms) is very fast. (Not as fast as an isset() test, but whatever.)
Now, if I want to test against can_do and can_eat, array_intersect(array('can_do', 'can_eat'), $perms) can become really, incredibly slow. The more permissions you add to the first or second array, the slower it gets, and exponentially. I've found that doing multiple in_array calls on can_do and can_eat can be much faster. Of course, we're talking minor speed increases, so it's not THAT important... I tested with a request of 3 permissions, all of which being wrong (it's 3 times faster if the first one is true, of course). The $perms array was arbitrarily filled with 110 entries, which is probably twice as many permissions you'll ever need to give someone... Still, array_intersect was approximately 150 times slower than three consecutive in_array tests. I'm not kidding you, guys... Call array_intersect 10.000 times, and we're talking multiple seconds to complete, while it executes in a few milliseconds with in_array().
So, maybe there are other array_intersect() calls to intercept elsewhere, what do you think..?
2981
Features / Re: New revs
« on May 18th, 2013, 05:11 PM »
rev 21+21 = 42 -- am bored of not committing this old stuff... :P
(7 files, 6kb)
* A bit of allowedTo/isAllowedTo refactoring. Not much, really... Just wanted to make it clearer that isAllowedTo supports multiple permission requests; more importantly, rewrote allowedTo for multiple permissions, speeding it up by potentially hundreds of times... (Security.php)
* arraydefinitionazi. (Security.php)
+ Added a 'Privacy' title when applicable in Post page, and reworked layout to allow for the post title input to take all remaining width. Along with a media query for smaller widths... (Post.template.php, index.english.php, index.french.php, editor.css, extra.ie6.css, extra.rtl.css)
(7 files, 6kb)
* A bit of allowedTo/isAllowedTo refactoring. Not much, really... Just wanted to make it clearer that isAllowedTo supports multiple permission requests; more importantly, rewrote allowedTo for multiple permissions, speeding it up by potentially hundreds of times... (Security.php)
* arraydefinitionazi. (Security.php)
+ Added a 'Privacy' title when applicable in Post page, and reworked layout to allow for the post title input to take all remaining width. Along with a media query for smaller widths... (Post.template.php, index.english.php, index.french.php, editor.css, extra.ie6.css, extra.rtl.css)
2982
Features / Re: New revs
« on May 16th, 2013, 11:40 PM »
rev 2119 -- oops.
(3 files, 3kb)
! Forgot to commit the Thoughts.template.php file mentioned in the last rev... (Thoughts.template.php)
! This also fixes a bug in thought threads, where the master thought doesn't have an action button. (Thoughts.template.php)
* Also committing index language updates for the privacy select box... Heck, I forgot to hit F5 before compiling my list of files to commit. (index.english.php, index.french.php)
(3 files, 3kb)
! Forgot to commit the Thoughts.template.php file mentioned in the last rev... (Thoughts.template.php)
! This also fixes a bug in thought threads, where the master thought doesn't have an action button. (Thoughts.template.php)
* Also committing index language updates for the privacy select box... Heck, I forgot to hit F5 before compiling my list of files to commit. (index.english.php, index.french.php)
2983
Features / Re: New revs
« on May 16th, 2013, 11:37 PM »
A reasonably big update, with the introduction of the topic privacy UI and improvements on thought privacy. Hopefully everything works fine. I won't update the site to this today, because it's too late for me, and I don't want to break too many things. Notes to Pete:
- please, please double-check this update. As thoroughly as possible. I triple-checked my commit and made many changes, I'm *extremely* wary of the idea of having introduced any security issues. Topic privacy is a serious thing...!
- if you edit a topic here, you'll get an error in the log... No biggie, it's just something I forgot to update. It won't happen locally.
rev 2118
(11 files, 12kb)
+ Finally implemented the UI for topic privacy...! I spent months postponing this because I thought I had to do the query_see_topic implementation as well. Turned out that it was done in late February 2012, over 700 revisions ago... So, yes, it STILL needs a lot of testing. But it wasn't too hard to implement topic privacy at Noisen.com back in 2007, so I don't see why it should be much of an issue for me in 2012, damn it! (Post.php, Post2.php, Subs-Post.php, Post.template.php, index.member.css)
@ To-do: allow quick edits to change topic privacy, move privacy icons out of member CSS if it's possible for a guest to create a new topic... (Pete, what do you think..? I don't even remember if it's possible, but I think it is...)
+ Added proper support for contact lists in thought privacy, instead of that hacked version targeted for Wedge.org. (Class-System.php, Thoughts.php, Thoughts.template.php)
! A missing query_see_topic..? There are probably tons more. While accessing the topics table doesn't automatically guarantee adding a query_see_topic to it, there are still over 250 access to it, and only over 50 query_see_topic calls, but all of the 'natural' ones were already there. (JSModify.php)
- As inspired by Pete, removed unneeded $db_prefix and $scripturl globals. :D (Aeva-Gallery.php, SSI.php)
* Spacinazi, indenazi. (JSModify.php, Load.php)
- please, please double-check this update. As thoroughly as possible. I triple-checked my commit and made many changes, I'm *extremely* wary of the idea of having introduced any security issues. Topic privacy is a serious thing...!
- if you edit a topic here, you'll get an error in the log... No biggie, it's just something I forgot to update. It won't happen locally.
rev 2118
(11 files, 12kb)
+ Finally implemented the UI for topic privacy...! I spent months postponing this because I thought I had to do the query_see_topic implementation as well. Turned out that it was done in late February 2012, over 700 revisions ago... So, yes, it STILL needs a lot of testing. But it wasn't too hard to implement topic privacy at Noisen.com back in 2007, so I don't see why it should be much of an issue for me in 2012, damn it! (Post.php, Post2.php, Subs-Post.php, Post.template.php, index.member.css)
@ To-do: allow quick edits to change topic privacy, move privacy icons out of member CSS if it's possible for a guest to create a new topic... (Pete, what do you think..? I don't even remember if it's possible, but I think it is...)
+ Added proper support for contact lists in thought privacy, instead of that hacked version targeted for Wedge.org. (Class-System.php, Thoughts.php, Thoughts.template.php)
! A missing query_see_topic..? There are probably tons more. While accessing the topics table doesn't automatically guarantee adding a query_see_topic to it, there are still over 250 access to it, and only over 50 query_see_topic calls, but all of the 'natural' ones were already there. (JSModify.php)
- As inspired by Pete, removed unneeded $db_prefix and $scripturl globals. :D (Aeva-Gallery.php, SSI.php)
* Spacinazi, indenazi. (JSModify.php, Load.php)
2984
Off-topic / Re: Oh, I meant to share this a while ago
« on May 16th, 2013, 10:40 PM »
lol topic... :lol:
I think we should sell Wedge for $400. I'm sure a lot of vBulletin users will see it means it's twice better than vB5. And worst of all... They'll be right!! :^^;:
Ah ah, just saw that they're not supporting styles and plugins either... And they're selling the right to remove their copyright notice... At $169 per licence. In addition to the $249 of the software license in itself...
Yeah, they're definitely crazy.
I think we should sell Wedge for $400. I'm sure a lot of vBulletin users will see it means it's twice better than vB5. And worst of all... They'll be right!! :^^;:
Ah ah, just saw that they're not supporting styles and plugins either... And they're selling the right to remove their copyright notice... At $169 per licence. In addition to the $249 of the software license in itself...
Yeah, they're definitely crazy.
2985
Off-topic / Re: Forum Rules
« on May 16th, 2013, 10:50 AM »
I think that most of the time, you just want people to understand that they should be... "not evil", and "not stupid".
The rest is up to the moderator's taste, but that's what 'warnings' are for.
I'm afraid I left 95% of the forums I registered to, and while most of these 95% are for the simplest of reasons (lost interest), so many of them were due to being uncomfortable posting there... Either because I felt the rules were too harsh, or simply because I didn't feel welcomed (or no longer welcomed). And I know it's also the case in the forums I run... Many people left here because they felt threatened or ignored; on my French forum, I had a prominent member leave because some users complained that he was posting too much, and that most of his posts were like a RSS feed of other forums. I tended to agree with them, but once he left, we also lost a lot of discussion ideas...
So, what's best..? Nothing. Just ask your users not to be evil and stupid, and more importantly, don't be evil or stupid yourself. Because ultimately, your forum is also what you are...
The rest is up to the moderator's taste, but that's what 'warnings' are for.
I'm afraid I left 95% of the forums I registered to, and while most of these 95% are for the simplest of reasons (lost interest), so many of them were due to being uncomfortable posting there... Either because I felt the rules were too harsh, or simply because I didn't feel welcomed (or no longer welcomed). And I know it's also the case in the forums I run... Many people left here because they felt threatened or ignored; on my French forum, I had a prominent member leave because some users complained that he was posting too much, and that most of his posts were like a RSS feed of other forums. I tended to agree with them, but once he left, we also lost a lot of discussion ideas...
So, what's best..? Nothing. Just ask your users not to be evil and stupid, and more importantly, don't be evil or stupid yourself. Because ultimately, your forum is also what you are...