Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
2926
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 29th, 2013, 03:51 PM »
- Pete: if you have large videos, then it creates a scrollbar, but the other notifications will still be readable in the same pane -- they won't take the entire width, only the overflowing elements will actually overflow, so I thought it was fine, but would you rather I overflow:hidden the entire preview..?
- Shitiz:
- get_single_post is a single query, using a very obvious index key, so it's fast to execute... And, it's only executed once per Ajax query, so you shouldn't be worried about THAT query, more about the queries that are executed before get_single_post even gets to be executed, eh... ;)
- I'm still waiting for your updated code to store the notification issuer in a row, rather than in the data field... If you want to update it, of course... :^^;:
- I'm aware of this issue, and I actually wrote a fix for it, but I couldn't figure out whether it was "all right", or if I could do a better animation... I'll probably end up using this, as it's really short and sweet: just add .next('.n_prev').andSelf() right before the .hide() call in the mark read code path.
Quote from icari on May 28th, 2013, 11:54 PM Showing unparsed messages should never happen... It's okay if you're the author, of course, but the viewer (guest or whatever), should never see the cogs in the machine, it just doesn't make sense to make them wonder what they're reading.
- Shitiz:
- get_single_post is a single query, using a very obvious index key, so it's fast to execute... And, it's only executed once per Ajax query, so you shouldn't be worried about THAT query, more about the queries that are executed before get_single_post even gets to be executed, eh... ;)
- I'm still waiting for your updated code to store the notification issuer in a row, rather than in the data field... If you want to update it, of course... :^^;:
- I'm aware of this issue, and I actually wrote a fix for it, but I couldn't figure out whether it was "all right", or if I could do a better animation... I'll probably end up using this, as it's really short and sweet: just add .next('.n_prev').andSelf() right before the .hide() call in the mark read code path.
Posted: May 29th, 2013, 03:50 PM
i have not had to really see how the notification system works that well, but does that preview also parse bbc? it might be worth not parsing bbc especially if it only shows a small preview of a message
2927
Off-topic / Re: Doctor Who
« on May 29th, 2013, 12:04 PM »
At least, I was glad seeing her in a non-Pond episode again...
Here's hoping it wasn't her last episode. It has no reason to be, after all there are still a few events she referred to that we didn't see... AFAIK. And even then -- I'm still of the opinion that she can be saved back from the library. It must be so boring, being in that program like, forever...
Last week, French TV was showing an episode from the first half of season 7. While watching it (and it was by far my least favorite episode of that half, the Dinosaurs one), I couldn't help thinking that the show really only lost its appeal to me *after* the Christmas break. Or maybe I was simply too much in love with the Ponds, I don't know... Rory, I miss you so much. We need your character. Maybe he got duplicated, at some point, through a wizzly-timey-boo machine that we never heard about? Why not...
Thinking about it... Maybe the next episode, since it has both Rose and 10th, will actually star the human version of 10th..? Hmm, no, they probably wouldn't have done that thing with the "real 9th" otherwise, I guess.
Here's hoping it wasn't her last episode. It has no reason to be, after all there are still a few events she referred to that we didn't see... AFAIK. And even then -- I'm still of the opinion that she can be saved back from the library. It must be so boring, being in that program like, forever...
Last week, French TV was showing an episode from the first half of season 7. While watching it (and it was by far my least favorite episode of that half, the Dinosaurs one), I couldn't help thinking that the show really only lost its appeal to me *after* the Christmas break. Or maybe I was simply too much in love with the Ponds, I don't know... Rory, I miss you so much. We need your character. Maybe he got duplicated, at some point, through a wizzly-timey-boo machine that we never heard about? Why not...
Thinking about it... Maybe the next episode, since it has both Rose and 10th, will actually star the human version of 10th..? Hmm, no, they probably wouldn't have done that thing with the "real 9th" otherwise, I guess.
2928
Archived fixes / Re: action_list is called too late
« on May 29th, 2013, 11:10 AM »
Hmm, I'll let Pete deal with this one, cuz I'm not sure about it all... ;)
2929
Bug reports / Re: PM Quoting
« on May 29th, 2013, 11:04 AM »
Hmm yeah, that's true...
Well, I was thinking mostly about how to show the data, and then thought of doing a 'special' topic type internally (remember my floating topic concept, uh..? ;)), and then you came and reminded me it wasn't exactly possible... :P
Well, I was thinking mostly about how to show the data, and then thought of doing a 'special' topic type internally (remember my floating topic concept, uh..? ;)), and then you came and reminded me it wasn't exactly possible... :P
2930
Archived fixes / Re: Subject 0 is treated as empty
« on May 29th, 2013, 11:02 AM »
Fixed! Thanks..!
2931
Features / Re: New revs
« on May 29th, 2013, 11:02 AM »
rev 2138
(6 files, 3kb)
! Fixed subjects and messages sometimes not allowing a single content of '0' (thanks John). Although it's unlikely you'll want to use that, it still should be allowed... Otherwise, why allow for '1'? Also of note, I removed a safety from the draft code in PersonalMessage.php, I don't think it was needed at all. Pete might wanna have a look though... Just to be sure, since it's his code. (Display.php, PersonalMessage.php, Post.php, Post2.php, Profile-View.php, Search2.php)
(6 files, 3kb)
! Fixed subjects and messages sometimes not allowing a single content of '0' (thanks John). Although it's unlikely you'll want to use that, it still should be allowed... Otherwise, why allow for '1'? Also of note, I removed a safety from the draft code in PersonalMessage.php, I don't think it was needed at all. Pete might wanna have a look though... Just to be sure, since it's his code. (Display.php, PersonalMessage.php, Post.php, Post2.php, Profile-View.php, Search2.php)
2932
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 28th, 2013, 11:13 PM »
A cut? You mean, having to actually visit the topic to see the full post? Meh...
So, I've committed the update. Everyone happy with it..?
I'm a bit disappointed with the size savings (even after I saved an additional 10+ bytes with a small rewrite in notload(), *sigh*), but it's still better than nothing..! I'm just too much of a bytenazi, I guess...
Bed time!
So, I've committed the update. Everyone happy with it..?
I'm a bit disappointed with the size savings (even after I saved an additional 10+ bytes with a small rewrite in notload(), *sigh*), but it's still better than nothing..! I'm just too much of a bytenazi, I guess...
Bed time!
2933
Features / Re: New revs
« on May 28th, 2013, 11:09 PM »
rev 2137 -- last batch.
(4 files, 3kb)
* Rewrote notification popup's way of showing previews. Instead of showing a side panel for the currently hovered notification, Wedge now expects you to click the notification item and it will show the preview below the item, making it possible to view previews in smaller screens. Relatively easy to revert, in case it's needed. (Notifications.template.php, script.js, index.css)
! Fixed smileys on mobile. It seems that Chrome for Android made some recent change to the way they handle a line-height of zero, thus hiding smileys entirely. This new technique is also faster to render, says Jeffrey Zeldman. Also applied the same fix to BBC links. (index.css, sections.css)
* Also updated select boxes to be shown, while still off-screen, now a bit less further away, ahem, a thousand times closer in fact... It should still be enough, and I have no other solution right now that still preserves change/focus events set directly on the select box. So, a thousand times closer it will be. (index.css)
(4 files, 3kb)
* Rewrote notification popup's way of showing previews. Instead of showing a side panel for the currently hovered notification, Wedge now expects you to click the notification item and it will show the preview below the item, making it possible to view previews in smaller screens. Relatively easy to revert, in case it's needed. (Notifications.template.php, script.js, index.css)
! Fixed smileys on mobile. It seems that Chrome for Android made some recent change to the way they handle a line-height of zero, thus hiding smileys entirely. This new technique is also faster to render, says Jeffrey Zeldman. Also applied the same fix to BBC links. (index.css, sections.css)
* Also updated select boxes to be shown, while still off-screen, now a bit less further away, ahem, a thousand times closer in fact... It should still be enough, and I have no other solution right now that still preserves change/focus events set directly on the select box. So, a thousand times closer it will be. (index.css)
2934
Features / Re: New revs
« on May 28th, 2013, 10:56 PM »
rev 2136 -- first batch...
(5 files, 3kb)
! Fixed not being able to Like a thought when its privacy was set to 'Contacts'. And another similar bug in the Welcome area, but whatever. (Like.php, Welcome.php)
! Fixed JavaScript error in mobile devices when visiting forum in guest mode. I actually had to reinstall the Android SDK and do remote debugging to figure it out... Why doesn't Chrome have a friggin' error console..?! (Thoughts.template.php)
! Missing global. Probably broke thought threads in some situations; never experienced, though... (Thoughts.template.php)
! Fixed post options alignment on mobile... Blah blah. (editor.css)
! Fixed select boxes triggering the change() event even when on a disabled or hidden item, if by any chance you hit the Tab key -- for instance, click the quick access select box, then hit Tab... And there you go, a bug. (sbox.js)
(5 files, 3kb)
! Fixed not being able to Like a thought when its privacy was set to 'Contacts'. And another similar bug in the Welcome area, but whatever. (Like.php, Welcome.php)
! Fixed JavaScript error in mobile devices when visiting forum in guest mode. I actually had to reinstall the Android SDK and do remote debugging to figure it out... Why doesn't Chrome have a friggin' error console..?! (Thoughts.template.php)
! Missing global. Probably broke thought threads in some situations; never experienced, though... (Thoughts.template.php)
! Fixed post options alignment on mobile... Blah blah. (editor.css)
! Fixed select boxes triggering the change() event even when on a disabled or hidden item, if by any chance you hit the Tab key -- for instance, click the quick access select box, then hit Tab... And there you go, a bug. (sbox.js)
2935
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 28th, 2013, 07:16 PM »
Well, that's normal... Apparently, that's a very, very long post... :lol:
Anyway -- enabled the 'click to fold' effect. Adds 17 bytes, thought I could do it with less... Ah, well.
Also, has the show_ajax() stuff. I really need to rewrite this into a positioned (centered by default) animation... Like for Zoomedia, see..?
Anyway -- enabled the 'click to fold' effect. Adds 17 bytes, thought I could do it with less... Ah, well.
Also, has the show_ajax() stuff. I really need to rewrite this into a positioned (centered by default) animation... Like for Zoomedia, see..?
2936
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 28th, 2013, 07:01 PM »I prefer this one, this works on mobile and feels more natural.
However, I might be inclined to suggest we do some kind of cut on the preview text simply because it's kinda big in some cases. For example I got a like on one of my New Revs posts which was pretty lengthy and it only just fits on the screen vertically when wrapped into that width.
And as you can see, I rewrote the code to allow for the popup to extend to the window boundaries, and create a scrollbar if it goes beyond that. Actually, I don't know why I didn't do it like this in the first place...
PS: sorry for the bug with select box padding. I'll fix that soon. It's a debug thing...
2937
Bug reports / Re: PM Quoting
« on May 28th, 2013, 06:56 PM »
Ideally, the PM area should behave like a 'private' topic, I'd say...
We can have these now, with topic privacy. i.e. you start a topic, set it to Contacts, and only your contacts will be able to see it. Once I get around to finishing my buddy rewrite, you'll be able to put people into various groups, so you can choose to have topics only for your family, only for your friends, etc... (I don't know how I'm going to handle that yet, though... Ah ah.)
But, err... I lost my way. What I meant is, we should have only the 'convo' view available, and show messages using the same code, i.e. the Display template... Or maybe, just ditch the PM system and instead create a special board which will get the private topics, but then you risk losing access to a topic if you're suddenly removed from the contact list, hmm........ :-/
We can have these now, with topic privacy. i.e. you start a topic, set it to Contacts, and only your contacts will be able to see it. Once I get around to finishing my buddy rewrite, you'll be able to put people into various groups, so you can choose to have topics only for your family, only for your friends, etc... (I don't know how I'm going to handle that yet, though... Ah ah.)
But, err... I lost my way. What I meant is, we should have only the 'convo' view available, and show messages using the same code, i.e. the Display template... Or maybe, just ditch the PM system and instead create a special board which will get the private topics, but then you risk losing access to a topic if you're suddenly removed from the contact list, hmm........ :-/
2938
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 28th, 2013, 06:52 PM »
1/ As I said. And, well, if I settle on this, I'll really add some kind of visual hint...
2/ Yeah, I know, but I felt it wasn't that useful... If you noticed that too, then I guess I should add it. It's just a few bytes of JS...
3/ Hmm, yeah. But calling the Ajax loader might be overkill, I don't know..?
So, do you prefer this one or the previous..? You can always check from the repo to compare, if you need, or I can re-upload the SVN version. (It's just three changed files, really...)
2/ Yeah, I know, but I felt it wasn't that useful... If you noticed that too, then I guess I should add it. It's just a few bytes of JS...
3/ Hmm, yeah. But calling the Ajax loader might be overkill, I don't know..?
So, do you prefer this one or the previous..? You can always check from the repo to compare, if you need, or I can re-upload the SVN version. (It's just three changed files, really...)
2939
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 28th, 2013, 06:42 PM »
Nope, there's always this delay... Although if you'd start switching between notification items, once they're all loaded, it'd be quicker to load because they're all cached in memory.
Anyway-- I've uploaded the alternative version, which as I said, has the advantage of working just the same on mobile devices.
Click anywhere inside a notification to expand it. Err, just don't click on the links, though, obviously... ;)
Opinions, please..!
Anyway-- I've uploaded the alternative version, which as I said, has the advantage of working just the same on mobile devices.
Click anywhere inside a notification to expand it. Err, just don't click on the links, though, obviously... ;)
Opinions, please..!
2940
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 28th, 2013, 06:29 PM »
Actually, I added a 0.3s delay to avoid sending needless Ajax requests to the server... ;)