Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
2881
Off-topic / Re: A nice Wedge notice that I cannot duplicate
« on June 6th, 2013, 02:30 PM »
Quote from xrunner on June 6th, 2013, 02:15 PM
Well I just tried a test and I made a lot of quoting mistakes and made a big mess and I never could get the notice. When I got the notice yesterday I only forgot one quote ending tag. Oh well ...
Really, it only triggers if Wedge can't fix the tags by itself.
2882
Off-topic / Re: A nice Wedge notice that I cannot duplicate
« on June 6th, 2013, 12:08 PM »
See, Pete? I told you we DO have features that make people go HOLY SHIT... :P

Ah, yes, regarding reproducing the 'notice', you'll have to do more than what Wedge/SMF can fix, and small trivia for you: it also works in quick edit mode, although I think it doesn't tell you what tag is wrong IIRC, but it still kindly warns you of a problem ;)
2883
Archived fixes / Re: Updated CSS code is buggy
« on June 5th, 2013, 04:06 PM »
So you didn't notice the name inversion either..? ^^
Posted: June 5th, 2013, 04:05 PM

And how did you test, with two local accounts, maybe..?
2884
Off-topic / Re: My brother is in England
« on June 5th, 2013, 04:04 PM »
First pic at the bottom, I was thinking... "He's in Kensington isn't he?"... Well, apparently he is :P
2885
Off-topic / Re: In Addition to Post Count - Power Ranking?
« on June 5th, 2013, 03:53 PM »
A couple of weeks ago, I was looking into XF's trophy system, and tried to think of something for Wedge too, that would look a bit like it, but also be an indicator of someone's implication on a forum... So, I started devising (additive) points attributed by post (1), thought (0.5), per direct post/thought reply (since we have this in the database) (0.5), likes (depending on what it being liked, I couldn't make up my mind), topic (I think I settled on 0.2 per reply to it), but then I decided awarding points to replies might encourage trolling. Anyway, I couldn't settle on other things like points awarded for gallery albums and items, topic and profile views (minus bot visits), and more place-specific areas like uploading a plugin or theme here, or being marked as the one who successfully replied to a topic[1], so I just skipped to something else that needed my attention, so it's funny to see a discussion about something similar, but I don't really think it can be done, without at least giving the admin the ability to change the attributable points per item, and that's where it becomes complicated I guess. Ultimately, I wanted to see if we couldn't replace post-based groups with points-based groups, that is, awarding shy people for still being part of the community. But then, what prevents you from just Liking every single post in the forum..? A ban threat, maybe....? :lol:

Anyway, that's where I was at that point, and I couldn't decide, so I think I added it somewhere in my to-do list, and you know the story about my to-do list... It grows about 5 times faster than it shrinks, so it's never ending.
 1. That one is actually interesting; I forgot to mention that earlier, sorry. I mean, when I click "Mark as solved", it always says I marked it as solved, but I'd like to be able to mark someone else as the solver, so maybe we should have an "Accept answer" option per-post in solvable topics, so that we can properly 'thank' the one who actually solve your problem... Hey, why not..?
2886
Features / Re: New revs
« on June 5th, 2013, 01:26 PM »
rev 2154 -- getting rid of bad hosts, and fixing license files.
(5 files +3-3, 14kb)

* Ensured that PCRE_VERSION is at least 7.2, otherwise Wedge won't work. See, I'm a supporter of the \h alias in regex, and I'm certainly not going to forfeit it for crappy hosts™. We never got any problems before, because PCRE 7.2 is bundled by default with PHP 5.2.4 (which happens to be our minimum PHP version for now), but Pete managed to find one of those crappy hosts™ that has PCRE 6.6 along with a more recent PHP... When you purposedly keep a 7-year-old version of a library on your servers, you shouldn't be trusted with other people's data, really. (readme_install.html, install.php, Install.language.php)

* Tweaked contributors file: harmonized 3-clause BSD/BSD 3-clause to Modified BSD; changed line breaks to CRLF instead of LF (we need everyone to be able to read this kind of file, including users of notepad.exe); added a realist's note about JW Player (yes, I'm still planning to get rid of it someday, don't worry...); and, replaced the ASCII logo with one that keeps the correct dimensions. That ASCII generator, to say the least, doesn't care a bit about proportions. (contributors.txt)

* Moved some of the non-critical root files to the actual root folder. (changelog.txt, license.txt, license_smf.txt)

@ Note for Pete: the minimum/recommended requirement paragraphs are very different across readme_*.html files, so we might want to harmonize them... And quickly, I guess!
2887
Features / Re: New revs
« on June 5th, 2013, 01:24 PM »
rev 2153
(8 files, 7kb)

! Got rid of a long-standing bug where, with Pretty URLs enabled, a name would occasionally drop out of the who's online list... Well, technically it's impossible to fix without being to reproduce, so I just added a fail-safe, and for the rest... Does it really matter? It happened once every six months, or something -- bot visits included. (Who.php)

* Restored personal_text modification to the profile area. Originally, I removed it to use thoughts instead, but since I decided to make it opt-in through the 'Posterity' feature, I might as well allow you to change it. And I might as well change my mind later. But I think once I've got privacy boxes set on this, it'll suddenly turn out to be all right to use it along with usertitle. Or something. Still, I think we really need to add some description of Personal Text and Personal Title below the options, because it can be confusing. I know it was to me, back in 2005 or something... (Profile-Modify.php)

* Translation. (ManageSettings.french.php, Notifications.french.php)

! Typos, including one in a variable name... 'Tis the season. ;) (ManageSettings.english.php, Notifications.english.php)

! Commenazi -- mostly a typo on the word 'readability', poetic irony. (Class-Notification.php)

* Vanity restyling of the language area search box. Don't bother. (ManageLanguages.template.php)

@ Note for Pete: feel free to revert the Who fix, if you're in a mood to spend a day trying to reproduce it, or something...
2888
Archived fixes / Re: Updated CSS code is buggy
« on June 5th, 2013, 11:25 AM »
I don't know, since indeed it's bundled by default... (5.2.4 + 7.2, how lucky!)

My guess, is that they always install PHP with PCRE disabled by default, and they somehow installed PCRE at some point, but long ago, and never cared to update it...

And yes, that totally sucks. But things like that, should be eye-openers for people who use crappy free hosting, I guess..!
There are enough decent free hosts, really, that we don't need to waste time on these ones, so I decided to just give up on this kind of host, it'll save us time in the long run.
Posted: June 5th, 2013, 11:24 AM

Oh, regarding the id_from_member/id_member_from bug... I know why I didn't find it immediately!
As the bug was in __create(), the first thing I did was look for all Notification object instances... But, this particular one was called with 'self'! So, bam... Never noticed it! I should have been more careful, when incorporating the original patch, I guess.
2889
Off-topic / Re: Welcome to prehistoric times.
« on June 4th, 2013, 11:44 PM »
Also, Godboko, when you hit 'Like' on Pete's post above, it generated an error in the log. A few others triggered one too, but I wanted to ask if you could unlike, then like it again? (And possibly also like this post, just for my tests...)

I'm trying to determine if the error is due to the upgrade process hiccups from yesterday, or an actual bug in the current code base; thanks!
Posted: June 4th, 2013, 11:35 PM

Crap... Bug is still there. Icari just tried liking my post, and it triggered the error.
Anything in your page when you liked, Icari..?

Bed time for me, unfortunately...
2890
Off-topic / Re: Welcome to prehistoric times.
« on June 4th, 2013, 11:25 PM »
Rebooting fixed my font issue, as (slightly) expected. :)

NAS interest is not in speed or anything... It's really mostly when you need to share data with your LAN users; although, in my case, I don't, but I wanted a NAS to get a small setup of 3 disks + 1 backup. This is way better than, well, having an external drive to backup your stuff. Either you back everything up --> waste of space, because you don't really want to back up all of your data, or you back up selected files, in which case you'll mostly have to do it manually, and you risk forgetting about it...

For years, I backed up my disks with Cobian Backup, but it wasn't up to the task of maintaining my many drives, so I gave up.
Now I have 8TB for my storage, which is more than enough for the next, hmm, couple of months... :P

The only thing I'm wary of, is this: data safety is the most important thing in a NAS. It is supposed to give a LED warning if one of the drives is failing. However, NONE of the drives I lost in the past, gave me any S.M.A.R.T. signals before failing. Actually, I tried today with my broken drive, and it's giving me a health score of something like 90%... Even though it's deader than dead!!
I don't know if I can trust the NAS to really spot deficient drives, but, well... Errr... I guess in a few years time, I'll replace it progressively with an 8-drive bay.
2891
Features / Re: New revs
« on June 4th, 2013, 08:05 PM »
rev 2149
(2 files, 1kb)

! I actually swapped parameters when calling cache_prepare_key, which is the reason why admins were getting 'undefined s' errors in the log. A big oops. I take it that everyone trusts my code so much, they don't review it, right..? I should feel honored :P (Subs-Cache.php)

! Fixed typo from Dragooon's original notifications contribution, which made periodical e-mails fail entirely, as the DB table couldn't be found. (Notifications.php)
2892
Archived fixes / Re: Updated CSS code is buggy
« on June 4th, 2013, 05:10 PM »
Oh, sorry, I'd simply missed your PM.

Phew...

Took me a friggin' HOUR to figure out what was happening.
Turns out, Wedge won't install on this, because they're just incompetent.

From their phpinfo:

pcre

PCRE (Perl Compatible Regular Expressions) Support   enabled
PCRE Library Version   6.6 06-Feb-2006


Yeah, not updated in 7 years...!!!!
And because of that, it doesn't support \h, which was added in v7.2, i.e. a year later.
And Wedge relies on \h for many things.

It's obviously something that can be fixed by changing \h to [\t ], but I don't know if it's worth it...

PS: I didn't bother to do the conversion and try to finish the install process... Really, really couldn't bother. Do it if you're curious ;)
2893
Features / Re: New revs
« on June 3rd, 2013, 11:49 PM »
rev 2148 -- only a partial fix, as I have more errors to look into, but apparently limited to me, so I'm not in a hurry, ah ah...
(2 files, 1kb)

! Fixed a missing 'return' in the last patch, causing a cascade of errors in notifications. (Class-Notification.php)

! I also have my share of untested code, though: a missing $st variable in the latest Subs-Cache refactoring. Uh oh. Now that fix looks ugly... (Subs-Cache.php)
2894
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 3rd, 2013, 10:38 PM »
What do you mean, exactly..? :^^;:

I probably should mark items as read as soon as they're previewed, though.

Also, I did this query...

Code: [Select]
SELECT m.id_member, m.real_name, m.unread_notifications, (SELECT COUNT(id_notification) FROM notifications AS n WHERE n.id_member = m.id_member AND n.unread != 0) AS real_count FROM members AS m WHERE m.unread_notifications > 0

Pointed out that I was off by 2 notifications, and you by 1, so I reset both our notification counts, to the correct number. :)

I also prepared the website to receive the new commit, with this:

Code: [Select]
SELECT COUNT(id_notification) AS co, id_notification, id_member, notifier, id_object, SUBSTRING_INDEX(data, 's:2:"id";s:', -1) AS truc FROM notifications WHERE id_member_from=0 GROUP BY truc ORDER BY co DESC

This gave me an ordered list of all notification issuers, and then I simply needed to update the tables manually, with another query... Yay.
Only took 20 minutes, though! Thankfully, the feature isn't old enough to be impossible to manage... :lol:

Dunno what's the point in keeping the member ID in the data field, though...! ;)
2895
Features / Re: New revs
« on June 3rd, 2013, 10:07 PM »
rev 2147 -- all of my current committable work -- and Dragooon's.
(5 files, 3kb)

* Committing a few changes to the structure of the contact list tables. They still aren't in use, but I wanted to have them in, just so Pete can protest/revert the changes, in case he finds them to be ineffective. (I'm never too sure about my work on MySQL performance, he's my god when it comes to that.) The idea is that list IDs should be linked to the owner ID, so that they don't get a list URL like action=profile;sa=contacts;in=12345, or something like that, but a shorter number instead, yeah, that totally deserves 4 lines of description in this commit, eh..? (install.sql)

* Applied Dragooon's patch that promotes my avatar code hack to a more generic status, yay again. (Class-Notifier.php)

* Applied Dragooon's patch that promotes my member_from code hack to a more gen... "Hey, haven't I done you before?" (Wowbagger, Class-Notification.php, Notifications.php, install.sql)

@ Fixed patch's cache flushing code, to use null instead of array(), as per Pete's suggestion, and use the proper TTL (86400), as per my own non-suggestion, but whatyagonnado. (Class-Notification.php)

! Looks like it's possible for a message to be emptied entirely by parse_bbc, as evidenced by an error in my log some time ago, so I'm adding a fail-safe that should cost no extra cycle. (Subs-BBC.php)