Wedge

wontfix -> hope you don't mind..... :^^;:

rev 2161 -- To infinity... AND BEYOND!!!
(6 files, 8kb)

+ Added Infinite Scrolling feature to topics. Just keep rolling your mouse wheel until it starts loading the next page! There are still a few bugs, such as video embedding not always working in newly loaded posts, and quick moderation being broken. It's not enough to justify not committing this nice feature, I think. (QueryString.php, Subs-Template.php, index.template.php, script.js, topic.js)

* Defined a new constant, INFINITE, which is set if the page was loaded through infinite mode. I may remove it later, but for now, I think it could be helpful. (QueryString.php)

! In some rare situations (for instance, pages with embedded videos), Wedge could have empty script tags. Dealing with these. (Subs-Template.php)

* Grouping block calls from mini-skeletons in the debug log; seriously, this saves admins from having huge logs in topic pages, although it might be argued that it makes debugging (slightly) harder, but whatever. (Subs-Template.php)

* Translation. I'm late with the other files, I know... (ManageMail.french.php)

@ I can't believe I fully commented my JavaScript for infinite scrolling... What happened to me? ;)

:edit: Forgot to mention script.js (which was committed) -- it adds a check related to infinite scrolling, too.

Yeah, it just isn't so solid on the long term...
For instance, since I'm removing external script files, if you have on page 2 a video embed but not on page 1, the embedder will try to call swfobject, but generate an error because it failed to find it, since it wasn't declared to begin with, ah ah...

This is the kind of thing that can happen everywhere, to anyone, with whatever plugin you want... :-/

And, I'm still unable to find some kind of jQuery trick to 'limit' the scope of a DOM traversal to a certain item. Which is really upsetting, because they could do, say, some kind of function like $.proxy() but for $()... For instance, $.traverse(from_here); $('span').hide(); would be the equivalent of doing, $('span', from_here).hide()... Then call $.traverse() again to reset to the actual DOM. Seems like a good idea, and a perfect feature for jQuery... Hmm, I'm wondering, if I can't implement it as plugin, maybe..??

Oh, crap!

Good news: it exists! http://api.jquery.com/context/
Bad news: they just deprecated it in the latest release..!!! >_<

Well... At least, it means it's "doable"...

:edit: Talked too soon... It's a getter, not a setter. Well, still, apparently I could attempt to set $.context manually... I'll look into that.

Okay, so I think it's all fixed... Quick moderation is still buggy, though. Because apparently, newly inserted inputs don't get added to the overall form, when I submit the request to delete a post loaded from beyond, it just ignores it. Also, it reloads the original page, without the infinity items, which I'm not surprised about, but still not happy with...

Apart from that, it *seems* that the infinite scroll is now working fine, and may even be in committable state... (I can live with the quickmod bug for now.)
YAY!! :)

That's odd...
- Loading stops for me.
- Like button works. (I just did it on xrunner's post above, from an infinitely scrolled page.)
And even if it didn't work, it'd still fall back to the non-Ajax version, which reloads the page entirely.

Meaning, it's certainly a JavaScript error that's blocking your entire process.

You should check out your JavaScript error log (usually in the browser's 'console'), what is your browser?

Can't seem to predict anything.
For instance, 'eves' may not have the same values on the next page. Thus, it's best to add a hack to subs-template to increase the base eves number by 100 or more, so that we don't mix things incorrectly. Unfortunately, doing this... Breaks even more.Hmm, possibly...
Anyway, my current implementation (I rewrite everything every 10mn or so...), doesn't strip anything, it loads the entire page, which then prompts jQuery to run scripts, then I strip everything that isn't #forumposts. Unfortunately, it looks like the scripts are still executed in the global scope....... Meh. So, it means that functions will run twice, and that isn't too good. If I'm not mistaken, running script.js twice will break deletion confirms, while removing *.js files before their execution, will break quick edit and a few others.
Also, loading the entire page also adapts the layout internally (to make room for the sidebar, etc), and the action menu is then incorrectly positioned, at least once I remove the sidebar etc...

It's incredible, how random it all is... Definitely not for the weak-hearted.Hmm yeah, a possibility...

Do you like infinite scrolling enough to justify more work from both of us, though...? :PYeah, one I certainly won't ever do, eh.

I've got it working a bit better...

First, I determined where that $.each error was coming from; it was actually from the .acme loop, and was due to the fact that the loop executed on ALL .acme items on the page, i.e. also on items that had already been transformed. So, I simply (?) added a fail-safe to the mime plugin, which would search for a mime container and, if found, skip the item.

And that actually works, now...

After that, I modified the Display template to show the scripts inside the forumposts div, but then I managed to do it another way in pure JS, by filtering the script tags.
A a result, both mini-menus will show on new posts. :)

Of course, I wasn't finished... For instance, clicking Delete on a post would show the confirm box, but immediately delete the post, too.
I determined that if I removed the script src includes from the script list, it would no longer do that; at this point, though, I'm not exactly sure why the eves list of events is actually executing, or something, but whatever...

Another bug that remains, is that if I have the Quick Reply box opened, clicking Quote on a new post will lead me to the full post page, instead of multi-quoting it.

So, yeah, it's technically working, but (1) it's fairly unstable and hard to predict, (2) I still have no frigging idea how to integrate plugins into this, (3) I think that ideally, I should rewrite all post-related code (and things that are changed in ob_sessrewrite) to use $(source).find('...') instead of $('...'), with source being div.new_page:last when called from a new page, or simply the body when called from the main page. See what I mean...? Yeah, it's pretty much impossible to rewrite all of that...

Should I be happy with the, errr... Current drawbacks, and implement it this way...? :-/

PS: just pushed this version online, so that you can test it...

Oh, I can understand you'd feel upset that he did it behind your back. It's only natural...He felt like a nice person, at the beginning... But, I guess at some point, he considered your involvement in AAF a 'given'.