Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
2641
Off-topic / Re: Post count fever
« on August 4th, 2013, 05:43 PM »
Of course. Non-admins see their posts automatically hard-merged if they're sent less than 5 minutes after the previous one.
2642
Archived fixes / Re: Warm theme: Side bar floats to the top. The body of the page expands full width
« on August 4th, 2013, 03:48 PM »
I fixed it locally last week but couldn't commit because my Warm is too different. And I just can't bother... ;)
2643
Off-topic / Re : 3D'ing
« on August 4th, 2013, 11:28 AM »
What exactly are you using C# and Unity for, Pete..? A game project with Louis, I'm guessing?
Is this related to your pre-Wedge project (on the occasion of which, IIRC, you met him), or is something new?
Is it made out of a desire to have a side-project alongside Wedge, or to simply find a realistic source of revenue?
And why didn't you discuss it with me, like ever..? I have no problem with not being offered to join the project of course, but I'm an Hejlsberg follower myself, and I have experience with 3D programming, as I'm sure you remember by now... ;)
Is this related to your pre-Wedge project (on the occasion of which, IIRC, you met him), or is something new?
Is it made out of a desire to have a side-project alongside Wedge, or to simply find a realistic source of revenue?
And why didn't you discuss it with me, like ever..? I have no problem with not being offered to join the project of course, but I'm an Hejlsberg follower myself, and I have experience with 3D programming, as I'm sure you remember by now... ;)
2644
Archived fixes / Re: Flexbox, meet code
« on August 3rd, 2013, 11:04 PM »
Can't reproduce in Firefox Aurora 24.0 Alpha 2...
2645
Off-topic / Re : 3D'ing
« on August 3rd, 2013, 11:01 PM »
You still have glQuad() though, don't you..?
Ahhhh, glQuad... D3D 1-8 (dunno about later versions) forces you to use only triangles. I never cared for low-level stuff, and D3DX sucked bad (and didn't support quads either, IIRC.)
Ahhhh, glQuad... D3D 1-8 (dunno about later versions) forces you to use only triangles. I never cared for low-level stuff, and D3DX sucked bad (and didn't support quads either, IIRC.)
2646
Off-topic / Re : 3D'ing
« on August 3rd, 2013, 09:26 PM »
I remember that! Fucking cool. The tile mesh in Kyodai Mahjongg was made procedurally, too. I never found a satisfying tile mesh with rounded corners, and never got into modeling 3d objects. Hated that.
Be happy that you're not using D3D, as it is WAY less cool as OpenGL. I wish I'd never made the switch.... ahhhhh the memories, so far away...
Be happy that you're not using D3D, as it is WAY less cool as OpenGL. I wish I'd never made the switch.... ahhhhh the memories, so far away...
2647
Features / Re: New revs
« on August 3rd, 2013, 03:55 PM »
rev 2204 -- scrollbar and notification fixes
(5 files, 4kb)
! Fix for a Chrome bug where scrollbars are glitchy when contained in a flex box. Unfortunately, the bug still happens in some situations. A minority, thankfully. (topic.js)
- Removed $email_data parameter from getEmail and other notifier functions; this wasn't used at all, and I don't even get what it's about, so... Let's just rewrite it if needed, alright Dragooon? (Class-Notification.php, Class-Notifier.php)
* A couple of 'new Notification' calls were done, instead of just 'new self', in the Notification class. (Class-Notification.php)
! Fixed template_notification_email, and saved some memory in the scheduled function. Thanks John for the suggestions! (Notifications.php, Notifications.template.php)
(5 files, 4kb)
! Fix for a Chrome bug where scrollbars are glitchy when contained in a flex box. Unfortunately, the bug still happens in some situations. A minority, thankfully. (topic.js)
- Removed $email_data parameter from getEmail and other notifier functions; this wasn't used at all, and I don't even get what it's about, so... Let's just rewrite it if needed, alright Dragooon? (Class-Notification.php, Class-Notifier.php)
* A couple of 'new Notification' calls were done, instead of just 'new self', in the Notification class. (Class-Notification.php)
! Fixed template_notification_email, and saved some memory in the scheduled function. Thanks John for the suggestions! (Notifications.php, Notifications.template.php)
2648
Archived fixes / Re: Flexbox, meet code
« on August 3rd, 2013, 03:48 PM »
Eh..? Even though Firefox doesn't have the flex codepath to begin with...? :unsure:
2649
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 01:53 PM »
They're named similarly (e.g. getEmail is in Notifier, and getText in Notification), but I don't think they overlap..?
2650
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 01:39 PM »
I couldn't find any..?
2651
Archived fixes / Re: Flexbox, meet code
« on August 3rd, 2013, 01:36 PM »
I think I've finally fixed this bug...
I managed to understand what was wrong, when I noticed that John's latest post had two code blocks behaving differently: the first was okay, the second had the bug. The only difference I could see, is that the first one had a vertical scrollbar, and the second had a horizontal scrollbar. I tried adding a vertical scrollbar to the second post, and guess what, it worked...
As I said, it's a Chrome-only bug (more likely a WebKit bug, but I couldn't reproduce in Safari, so, until I'm told about it...), so I added a if (is_chrome) test in JS, and then modified all code blocks to force a vertical scrollbar (overflow-y: scroll), if a horizontal bar was present.
Really, REALLY... As simple as that. It fixes the scrollbar not being selectable, and the negative bottom margin on it.
Please test! e.g. Dragooon's post mentioned above, or John's post here: http://wedge.org/pub/bugs/8193/periodic-notifications-don-t-seem-to-work/msg290814/#msg290814
Please note that, very annoyingly, pressing Quick Edit on one of these posts and then Cancel, will restore the original bug. Well, I can't do much about that one, can I..?
I managed to understand what was wrong, when I noticed that John's latest post had two code blocks behaving differently: the first was okay, the second had the bug. The only difference I could see, is that the first one had a vertical scrollbar, and the second had a horizontal scrollbar. I tried adding a vertical scrollbar to the second post, and guess what, it worked...
As I said, it's a Chrome-only bug (more likely a WebKit bug, but I couldn't reproduce in Safari, so, until I'm told about it...), so I added a if (is_chrome) test in JS, and then modified all code blocks to force a vertical scrollbar (overflow-y: scroll), if a horizontal bar was present.
Really, REALLY... As simple as that. It fixes the scrollbar not being selectable, and the negative bottom margin on it.
Please test! e.g. Dragooon's post mentioned above, or John's post here: http://wedge.org/pub/bugs/8193/periodic-notifications-don-t-seem-to-work/msg290814/#msg290814
Posted: August 3rd, 2013, 01:30 PM
Please note that, very annoyingly, pressing Quick Edit on one of these posts and then Cancel, will restore the original bug. Well, I can't do much about that one, can I..?
2652
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 11:55 AM »
Okay, then I'm relieved to see I'm not the only one with problems... :P
Since I did extensive rewrites of the system, I guess I have a correct understanding of it, so to make everything clear, it all boils down to three structures:
- the Notification object, holds a single notification for a member, a certain type. It provides methods that give low-level access to the notification's ID, type, etc.
- the Notifier object, is a 'generic' notification type, which provides plenty of default higher-level methods for a notification plugin (getEmail, etc.)
- the plugin's notifier, inherited from Notifier, called through issue().
Basically, a Notification object always has an associated Notifier.
If you get that, you're already halfway through the system.
Which is, err... Pretty much where I am, lol.
Anyway, I've made a few changes to John's suggestion, and will commit these. Unfortunately, I'm not bothered enough to test my changes, so... Hopefully it works, ah ah.
Code: [Select]
(getEmail only has one parameter now, because I removed $email_data, which doesn't have any purpose, and thus 'gets in the way', IMHO...)
Since I did extensive rewrites of the system, I guess I have a correct understanding of it, so to make everything clear, it all boils down to three structures:
- the Notification object, holds a single notification for a member, a certain type. It provides methods that give low-level access to the notification's ID, type, etc.
- the Notifier object, is a 'generic' notification type, which provides plenty of default higher-level methods for a notification plugin (getEmail, etc.)
- the plugin's notifier, inherited from Notifier, called through issue().
Basically, a Notification object always has an associated Notifier.
If you get that, you're already halfway through the system.
Which is, err... Pretty much where I am, lol.
Anyway, I've made a few changes to John's suggestion, and will commit these. Unfortunately, I'm not bothered enough to test my changes, so... Hopefully it works, ah ah.
foreach ($notifications as $notifier_name => $notifs)
{
$notifier = weNotif::getNotifiers($notifier_name);
list ($title) = $notifier->getProfile($notifs);
$str .= "\n" . $title . "\n" . str_repeat('=', strlen($title)) . "\n";
foreach ($notifs as $n)
{
list (, $body) = $notifier->getEmail($n);
$str .= $body . "\n\n";
}
}(getEmail only has one parameter now, because I removed $email_data, which doesn't have any purpose, and thus 'gets in the way', IMHO...)
2653
Features / Re: Plugin revs
« on August 3rd, 2013, 11:35 AM »
rev 89
(7 files, 35kb)
* Committing my month-old rewrite of Mentions... Hmm, why do I keep forgetting about that. (mentions/plugin-info.xml, plugin.language.php, plugin.php)
! CRLF lines. (wedgedesk/css/helpdesk_admin.css, WedgeDeskProfile.english.php, WedgeDesk-Profile.template.php)
(7 files, 35kb)
* Committing my month-old rewrite of Mentions... Hmm, why do I keep forgetting about that. (mentions/plugin-info.xml, plugin.language.php, plugin.php)
! CRLF lines. (wedgedesk/css/helpdesk_admin.css, WedgeDeskProfile.english.php, WedgeDesk-Profile.template.php)
2655
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 12:27 AM »
Hmm, not particularly you, but, just in case you had a ready-made solution, I'd have gladly taken it... ;)