This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
2611
Features / Re: Soft merging of posts
« on August 18th, 2013, 07:39 PM »
I don't get it... I uploaded all of my WIP in here, and it still doesn't work, even though it's pretty much the same codebase...
2612
Features / Re: Soft merging of posts
« on August 18th, 2013, 07:31 PM »
Yup, as I said, I don't have this locally, so I'm going to try and commit my Msg changes, get ready for that... :-/
2613
Features / Re: Soft merging of posts
« on August 18th, 2013, 06:33 PM »
Position fixed has its issues.
Generally, any changes to the page layout will break it.
That's why it's not possible to do this kind of trick on a site with a lot of js like here.
Same with infinite scrolling: always happy to have done it, always thinking it's not realistic to keep it in.
Generally, any changes to the page layout will break it.
That's why it's not possible to do this kind of trick on a site with a lot of js like here.
Same with infinite scrolling: always happy to have done it, always thinking it's not realistic to keep it in.
2615
Features / Re: Soft merging of posts
« on August 18th, 2013, 03:28 PM »
Just for fun...
I uploaded the code here.
It doesn't work as well as on my local site, though... Far from it!
I probably forgot to update something.
Can't seem to find what causes this to happen, unfortunately.
Also, it's currently applied to mobile skins as well, which isn't the case locally -- because of my recent rewrite, which has yet to be applied here.
While I'm (in the long run) hoping to ready it for mobile skins as well, currently it's not possible, because I need to rewrite the mini-menu code to account for position: fixed parents, which isn't done right now.
I uploaded the code here.
It doesn't work as well as on my local site, though... Far from it!
I probably forgot to update something.
Posted: August 18th, 2013, 03:21 PM
Can't seem to find what causes this to happen, unfortunately.
Also, it's currently applied to mobile skins as well, which isn't the case locally -- because of my recent rewrite, which has yet to be applied here.
While I'm (in the long run) hoping to ready it for mobile skins as well, currently it's not possible, because I need to rewrite the mini-menu code to account for position: fixed parents, which isn't done right now.
2616
Features / Re: Soft merging of posts
« on August 18th, 2013, 03:17 PM »Hmm, would it be an idea to switch to 'position: fixed' when the scrollTop is within a given boundary? That way, the browser can handle the positioning directly in its render engine, so things should be much smoother.
It only gets a bit jerky when the userbox is is in process of being hidden from view (i.e. you're scrolling into the next post), because at this point, I have to reset the top position on every frame, obviously...
I think it's commit material at this point, but it's also very, very much something I think people will want to have a setting for, with said setting being OFF by default, dunno...
2617
Features / Re: Soft merging of posts
« on August 18th, 2013, 12:54 AM »
So... I've had a quick stab at doing like Aaron suggested, and managed to get a 'working' thingy, but it's still a bit buggy.
Overall, I'm not happy with it.
I can get the userbox to move along with the window scroll, but it gets very complicated when I reach the end of the post, because it tends to increase the userbox size regardless, and thus increase the size of the post, and make it impossible to reach the next message, etc...
So, I added a few failsafes to ensure the userbox size never increases beyond the original height, but even then...
It becomes *jerky*. A bit jerky when I'm scrolling with the keyboard or mouse wheel (like, 1 out of 10 times, you can see the avatar scroll up, then suddenly be restored), and a LOT jerky with the mouse, especially when scrolling through with the mouse, i.e. smoothly: probably because there are too many event triggers, it not only shows the jump effect too much, but it also fails to correctly *scroll the screen* (even though I don't manipulate this!) when transitioning between posts.
Additionally, I think that this animation, while fun at the beginning, will probably get tiresome quickly enough, unless it's replaced with just the user name instead of the entire user box, I don't know, but in this case, it means I'll have to do a position:fixed item... Hmm, well at least it'll solve the jerkiness issue, I guess..?!
If you want to test, I'll paste the code for you. I'd really, REALLY appreciate any feedback.
Open scripts/topic.js
On line 45, add this (or just add it anywhere inside the $(window).load() event):
Code: [Select]
I can probably upload it here too, but I'm wary of alienating users, ah ah...
:edit: Also, in Msg.template.php, find <div class="poster"> and immediately add <div class="column"> after it... Then find the </div> that matches it, and replace with two </div>.
Overall, I'm not happy with it.
I can get the userbox to move along with the window scroll, but it gets very complicated when I reach the end of the post, because it tends to increase the userbox size regardless, and thus increase the size of the post, and make it impossible to reach the next message, etc...
So, I added a few failsafes to ensure the userbox size never increases beyond the original height, but even then...
It becomes *jerky*. A bit jerky when I'm scrolling with the keyboard or mouse wheel (like, 1 out of 10 times, you can see the avatar scroll up, then suddenly be restored), and a LOT jerky with the mouse, especially when scrolling through with the mouse, i.e. smoothly: probably because there are too many event triggers, it not only shows the jump effect too much, but it also fails to correctly *scroll the screen* (even though I don't manipulate this!) when transitioning between posts.
Additionally, I think that this animation, while fun at the beginning, will probably get tiresome quickly enough, unless it's replaced with just the user name instead of the entire user box, I don't know, but in this case, it means I'll have to do a position:fixed item... Hmm, well at least it'll solve the jerkiness issue, I guess..?!
If you want to test, I'll paste the code for you. I'd really, REALLY appreciate any feedback.
Open scripts/topic.js
On line 45, add this (or just add it anywhere inside the $(window).load() event):
var poster_padding = parseInt($('.poster').first().css('padding-top'));
if (!isNaN(poster_padding))
{
$(window).scroll(function ()
{
var top = $(window).scrollTop(), $poster = null, poster_top, ex_poster_top, last = true;
$('.poster').each(function ()
{
if ($poster === null)
{
$poster = $(this);
poster_top = $poster.offset().top;
return;
}
ex_poster_top = poster_top;
poster_top = $(this).offset().top;
if (poster_top >= top)
return last = false;
$poster = $(this);
});
if (last)
{
var swap = ex_poster_top;
ex_poster_top = poster_top;
poster_top = swap + $poster.height();
}
$poster.css('padding-top', Math.min(Math.max(0, top - ex_poster_top) + poster_padding, poster_top - ex_poster_top - $poster.find('.column').height()));
$('.poster').not($post).css('padding-top', poster_padding);
});
}I can probably upload it here too, but I'm wary of alienating users, ah ah...
:edit: Also, in Msg.template.php, find <div class="poster"> and immediately add <div class="column"> after it... Then find the </div> that matches it, and replace with two </div>.
2618
Features / Re: New revs
« on August 17th, 2013, 11:17 PM »
rev 2218 -- various mobile/layout related fixes or improvements, yay. This one deserves a Like, right..?
(4 files, 4kb)
* Found a better technique to fix the code tag's flex bug. Instead of setting overflow-y to scroll, I'm simply setting flex to none, which technically doesn't make it sense at all, because it's the default at this point, but it looks like Chrome insists on silently applying some non-default flex value on all flex children, which is a very bad idea, if you ask me. (topic.js)
+ Added support for the Android 'simulator' in Chrome, i.e. recognize their custom user agent as an Android device, even though it doesn't have any Android-specific element in it, e.g. 'mobile'. (Class-System.php)
* Mobile skins shouldn't show the entire topic title, in some situations. It often breaks layout, so... Shortened the message titles to 20 characters, and did the same to previous/next topic titles, which works better, for me at least. (Display.php)
- Do not soft-merge posts in mobile skins. It's not that it's not doable... It's mainly down to the fact that it's pointless, because there's nothing to remove, apart from the avatar and user name, which are optimized not to take any further space, so... No need to waste CPU cycles on this, I'd say. (Subs-Template.php)
@ Regarding topic titles, I actually pondered whether to use we::is('mobile') or SKIN_MOBILE. The first applies to mobile devices only but in all skins, while the second applies to all devices, but in mobile skins only (e.g. Wireless). In the end, I decided that since non-mobile skins usually render badly on mobile devices, it's not worth doing on these skins anyway. I'm very, very open to changing my mind, though.
(4 files, 4kb)
* Found a better technique to fix the code tag's flex bug. Instead of setting overflow-y to scroll, I'm simply setting flex to none, which technically doesn't make it sense at all, because it's the default at this point, but it looks like Chrome insists on silently applying some non-default flex value on all flex children, which is a very bad idea, if you ask me. (topic.js)
+ Added support for the Android 'simulator' in Chrome, i.e. recognize their custom user agent as an Android device, even though it doesn't have any Android-specific element in it, e.g. 'mobile'. (Class-System.php)
* Mobile skins shouldn't show the entire topic title, in some situations. It often breaks layout, so... Shortened the message titles to 20 characters, and did the same to previous/next topic titles, which works better, for me at least. (Display.php)
- Do not soft-merge posts in mobile skins. It's not that it's not doable... It's mainly down to the fact that it's pointless, because there's nothing to remove, apart from the avatar and user name, which are optimized not to take any further space, so... No need to waste CPU cycles on this, I'd say. (Subs-Template.php)
@ Regarding topic titles, I actually pondered whether to use we::is('mobile') or SKIN_MOBILE. The first applies to mobile devices only but in all skins, while the second applies to all devices, but in mobile skins only (e.g. Wireless). In the end, I decided that since non-mobile skins usually render badly on mobile devices, it's not worth doing on these skins anyway. I'm very, very open to changing my mind, though.
2619
Other software / Re: Arguments about the credits
« on August 16th, 2013, 05:00 PM »
That's how Wedge does it; switch to French, go to Credits, and I'm there as the translator. Switch to British English, and there you go, Pete is credited. Switch to proper regular dumb US English, and no credits, because it's a collaborative work, right..? ;)
@runic, I was credited as Friend by your first commit (from my original Consulting Developer), but you fixed it, so I'm all good.
My idea is that, generally, software should have the complete list of developers over time, and then additionally, show the 'active' developers in a separate list. We don't have this problem at Wedge right now, because basically there's only Pete and I, and then our contributors (John, Shitiz) and occasional contributors (Aaron, TE...), and they're all credited as consultants, so it's fine for now...
@runic, I was credited as Friend by your first commit (from my original Consulting Developer), but you fixed it, so I'm all good.
My idea is that, generally, software should have the complete list of developers over time, and then additionally, show the 'active' developers in a separate list. We don't have this problem at Wedge right now, because basically there's only Pete and I, and then our contributors (John, Shitiz) and occasional contributors (Aaron, TE...), and they're all credited as consultants, so it's fine for now...
2620
Other software / Re: Arguments about the credits
« on August 16th, 2013, 07:42 AM »
Some people are credited multiple times.
And where's my developer credit? :P
And where's my developer credit? :P
2621
Features / Re: New revs
« on August 15th, 2013, 02:31 PM »
rev 2217 -- most online, buh-bye.
(4 files, 3kb)
* Now hiding 'most online' statistics for non-moderators, as per our discussion at wedge.org, where it was established that this kind of data is only of interest to forum owners, and might be discouraging if a forum's peak activity is long gone, yet still has loyal activity. Anyone ever been slashdotted..? (Stats.php, InfoCenter.template.php, Stats.template.php)
+ Added support for border-top-left-radius and other directions, more specifically, adding prefixes to them if the user is on a very, very old browser that's not IE. Silly, eh..? Well, might as well account for everything, I say. (Class-CSS.php)
@ I think I addressed all areas, but I didn't test thoroughly, so please make sure to apply the same treatment to anything else you can find, really..!
(4 files, 3kb)
* Now hiding 'most online' statistics for non-moderators, as per our discussion at wedge.org, where it was established that this kind of data is only of interest to forum owners, and might be discouraging if a forum's peak activity is long gone, yet still has loyal activity. Anyone ever been slashdotted..? (Stats.php, InfoCenter.template.php, Stats.template.php)
+ Added support for border-top-left-radius and other directions, more specifically, adding prefixes to them if the user is on a very, very old browser that's not IE. Silly, eh..? Well, might as well account for everything, I say. (Class-CSS.php)
@ I think I addressed all areas, but I didn't test thoroughly, so please make sure to apply the same treatment to anything else you can find, really..!
2622
Features / Re: New revs
« on August 15th, 2013, 01:55 PM »
rev 2216 -- crumbs.
(6 files, 3kb)
+ Added a .tinytext class that's even smaller than .smalltext (I used it in the last commit, but forgot to include it), and fixed some rules here and there. (PrintPage.template.php, extra.ios.css, index.css, report.css)
* Spacinazi. (Profile.template.php)
! Oh, and another file I forgot... Still last_th-related. (extra.rtl.css)
(6 files, 3kb)
+ Added a .tinytext class that's even smaller than .smalltext (I used it in the last commit, but forgot to include it), and fixed some rules here and there. (PrintPage.template.php, extra.ios.css, index.css, report.css)
* Spacinazi. (Profile.template.php)
! Oh, and another file I forgot... Still last_th-related. (extra.rtl.css)
2623
Features / Re: New revs
« on August 15th, 2013, 01:50 PM »
rev 2215 -- manage attachment area, reworked. This is frontend only, even though it's backend... It's complicated ;)
(5 files, 4kb)
! The (relatively old) alert/confirm rewrite broke the attachment manager, so after successfully rewriting the reqWin code to account for that, I realized that a single admin area wasn't worth the script's 100+ extra bytes, and removed the preview entirely. Instead, I'm showing a small thumbnail for all images, and it's much, much more usable now. Also removed the extra classes that made the attachment manager less sexy, in my opinion. (ManageAttachments.php)
* Added a 'nh' (no hit) parameter to attachment downloads, allowing to force the hit counter to keep quiet. This was needed for the thumbnails above, of course. (Dlattach.php, ManageAttachments.php)
! We need to determine whether windowbg or windowbg2 are the 'default' backgrounds when not alternating, really. (ManageAttachments.template.php)
! Typos and so on. (Admin.french.php)
! Forgot to commit a file in the last revision, oops. last_th stuff, if you'll remember. (Themes.template.php)
(5 files, 4kb)
! The (relatively old) alert/confirm rewrite broke the attachment manager, so after successfully rewriting the reqWin code to account for that, I realized that a single admin area wasn't worth the script's 100+ extra bytes, and removed the preview entirely. Instead, I'm showing a small thumbnail for all images, and it's much, much more usable now. Also removed the extra classes that made the attachment manager less sexy, in my opinion. (ManageAttachments.php)
* Added a 'nh' (no hit) parameter to attachment downloads, allowing to force the hit counter to keep quiet. This was needed for the thumbnails above, of course. (Dlattach.php, ManageAttachments.php)
! We need to determine whether windowbg or windowbg2 are the 'default' backgrounds when not alternating, really. (ManageAttachments.template.php)
! Typos and so on. (Admin.french.php)
! Forgot to commit a file in the last revision, oops. last_th stuff, if you'll remember. (Themes.template.php)
2624
Features / Re: New revs
« on August 13th, 2013, 08:52 PM »
rev 2214 -- removing some outdated HTML...
(24 files, 11kb)
- Got rid of all first_th/last_th classes, as they're forgotten remains of a time when :first-child was a web designer's dream. Seriously, since these are only used to do rounded borders, and IE 6 supports neither border-radius nor :first-child, the only reason we should care is that some layouts might not cause issues, so I tried to ensure rounded corners only show up in catbg and titlebg heads, but in any case, it's no big deal. Who cares about round borders in 2013, anyway? (Memberlist.php, Modlog.php, Profile-Modify.php, TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Paid / Permissions / Plugins, Merge, MessageIndex, Notifications, PersonalMessage, Profile, Recent, Who, index.css)
- Similarly, removed all scope="col" occurrences. I don't know where it originated from, but basically, in a table, all th tags automatically apply that scope if they're in the first row, so there's no need for these. (TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Plugins, Memberlist, Merge, MessageIndex, Notifications, Profile, Recent, Reports, Themes, Who)
* Anti-spam question tables were a bit too rigid, breaking easily in narrow widths. (Admin.template.php)
* Forced a vertical scrollbar on all pages, to avoid strange sidebar behavior on short pages. (index.css)
* Layout tweaks on ViewQuery MySQL queries. (ViewQuery.php)
(24 files, 11kb)
- Got rid of all first_th/last_th classes, as they're forgotten remains of a time when :first-child was a web designer's dream. Seriously, since these are only used to do rounded borders, and IE 6 supports neither border-radius nor :first-child, the only reason we should care is that some layouts might not cause issues, so I tried to ensure rounded corners only show up in catbg and titlebg heads, but in any case, it's no big deal. Who cares about round borders in 2013, anyway? (Memberlist.php, Modlog.php, Profile-Modify.php, TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Paid / Permissions / Plugins, Merge, MessageIndex, Notifications, PersonalMessage, Profile, Recent, Who, index.css)
- Similarly, removed all scope="col" occurrences. I don't know where it originated from, but basically, in a table, all th tags automatically apply that scope if they're in the first row, so there's no need for these. (TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Plugins, Memberlist, Merge, MessageIndex, Notifications, Profile, Recent, Reports, Themes, Who)
* Anti-spam question tables were a bit too rigid, breaking easily in narrow widths. (Admin.template.php)
* Forced a vertical scrollbar on all pages, to avoid strange sidebar behavior on short pages. (index.css)
* Layout tweaks on ViewQuery MySQL queries. (ViewQuery.php)
2625
Features / Re: New revs
« on August 13th, 2013, 01:53 PM »
rev 2213
(7 files, 3kb[1])
* Moved header_logo_url setting from Theme to Basic, as originally planned. I have yet to figure out how to rewrite this all... Maybe offer a 'header' select box with 3 possible pairs, forum name + logo / forum name + slogan / logo + slogan..? (Load.php, ManageSettings.php, Settings.template.php, LANGUAGES: ManageSettings, Themes)
(7 files, 3kb[1])
* Moved header_logo_url setting from Theme to Basic, as originally planned. I have yet to figure out how to rewrite this all... Maybe offer a 'header' select box with 3 possible pairs, forum name + logo / forum name + slogan / logo + slogan..? (Load.php, ManageSettings.php, Settings.template.php, LANGUAGES: ManageSettings, Themes)
| 1. | Aaahhhh... This is one of those rare cases, where it feels so much better to downgrade! |