Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
2581
Features / Re: New revs
« on August 23rd, 2013, 01:50 PM »
rev 2225 -- didn't have much to commit, but I have a feeling it's still helpful to split these into chunks.
(4 files, 2kb)
! Correct me if I'm wrong, but Wedge disables template evals by default, not the other way around. So, these language strings needed to be updated... (Help language files)
* Gave labels to profile page checkboxes. Accessibility FTW. (Profile.template.php)
(4 files, 2kb)
! Correct me if I'm wrong, but Wedge disables template evals by default, not the other way around. So, these language strings needed to be updated... (Help language files)
* Gave labels to profile page checkboxes. Accessibility FTW. (Profile.template.php)
2582
Features / Re: Getting rid of zebra classes
« on August 23rd, 2013, 12:16 AM »It's still in the source here... And actually... maybe you can.
As I understand it, and I might be wrong... parent > child:nth-of-type(even) would work and not match children or nesting or suchlike. I dunno. I'm not a CSS guru.
Heck, I managed to break notifications just by adding:to the CSS (and it actively broke everything related to notifications, though I would add there was a suitable element with that in it, it all looked right but the popup wouldn't pop up)Code: [Select] #pms extends #notifs
2583
Features / Re: New revs
« on August 23rd, 2013, 12:03 AM »
rev 2224 -- GFY, IE8!
(16 files, 4kb)
- Got rid of postbg classes, replaced with :nth-of-type zebra striping. This isn't supported in IE 6-8, and I couldn't care less. We're talking about alternating colors or something, not dinner with the Queen. This should make everything a bit faster. Also, renamed the .root class (which was JS-oriented) with a more generic .msg class, which should also compress a bit better, FWIW. (attic/scripts/Unused-softMerge.js, Subs-Template.php, Msg.template.php, PersonalMessage.template.php, Post.template.php, post.js, script.js, topic.js, common.css, extra.ie6.css, extra.ie7.css, index.css, sections.css, Wine/extra.css, Warm/extra.css)
- Removed 'alternate' entry in the message array, since we're no longer using it... Feel free to restore it, if you can find another reason to use it, I guess! (Display.php)
@ Note to self: need to remove all references to .keyinfo, too.
(16 files, 4kb)
- Got rid of postbg classes, replaced with :nth-of-type zebra striping. This isn't supported in IE 6-8, and I couldn't care less. We're talking about alternating colors or something, not dinner with the Queen. This should make everything a bit faster. Also, renamed the .root class (which was JS-oriented) with a more generic .msg class, which should also compress a bit better, FWIW. (attic/scripts/Unused-softMerge.js, Subs-Template.php, Msg.template.php, PersonalMessage.template.php, Post.template.php, post.js, script.js, topic.js, common.css, extra.ie6.css, extra.ie7.css, index.css, sections.css, Wine/extra.css, Warm/extra.css)
- Removed 'alternate' entry in the message array, since we're no longer using it... Feel free to restore it, if you can find another reason to use it, I guess! (Display.php)
@ Note to self: need to remove all references to .keyinfo, too.
2584
Features / Re: Getting rid of zebra classes
« on August 22nd, 2013, 11:50 PM »
I dropped postbg and postbg2 today... (?)
I replaced them with '.msg', which is what '.root' used to be (only, compresses better :P)
I don't think there's a way to 'maintain' the zebra counter when you're looping through a series of msg classes that are INSIDE another msg class... Can you?
I replaced them with '.msg', which is what '.root' used to be (only, compresses better :P)
I don't think there's a way to 'maintain' the zebra counter when you're looping through a series of msg classes that are INSIDE another msg class... Can you?
2585
Features / Re: Getting rid of zebra classes
« on August 22nd, 2013, 11:34 PM »
Oh... I forgot.
Since these are children of postheader, the zebra counter is reset on each soft-merged post, meaning we get inconsistencies within them. :-/
I guess it's one of those cases where there's no good solution...
Since these are children of postheader, the zebra counter is reset on each soft-merged post, meaning we get inconsistencies within them. :-/
I guess it's one of those cases where there's no good solution...
2586
Features / Re: Getting rid of zebra classes
« on August 22nd, 2013, 11:00 PM »
Nah, I could simply 'cancel' any styling on .postarea .root, probably simpler, too...
Sorry, looks like I forgot to attach the screenshot...!
Sorry, looks like I forgot to attach the screenshot...!
2587
Features / Re: New revs
« on August 22nd, 2013, 10:23 PM »
rev 2223 -- follow me!
(1 file, 5kb)
+ You wanted it, you have it! Here's the JS code to make user boxes follow you in topic pages. I've commented it thoroughly, in case you don't understand it on first sight. As with many other recent features in Wedge, it's something that could be plugin material, it's easy enough to insert a hook there and let the plugin do the job, so I'm committing this separately, to make it easier to spot the code and remove it, if needed. (topic.js)
(1 file, 5kb)
+ You wanted it, you have it! Here's the JS code to make user boxes follow you in topic pages. I've commented it thoroughly, in case you don't understand it on first sight. As with many other recent features in Wedge, it's something that could be plugin material, it's easy enough to insert a hook there and let the plugin do the job, so I'm committing this separately, to make it easier to spot the code and remove it, if needed. (topic.js)
2588
Features / Re: New revs
« on August 22nd, 2013, 10:14 PM »
rev 2222 -- hopefully, Wireless is stable enough for prime time!
(5 files, 2kb -- but it feels more like 10KB... :P)
* Rewrote Wireless to take advantage of the new Msg skeleton. I thought it deserved its own commit, yeah... So, basically, the user box is now correctly shown in the post header, and I'm giving you back the info that was removed earlier, such as the post name (and last edit time). I reckoned that it was still very much useful in mobile mode, because often the topic title won't show up there, so it can be helpful to have it in the post. Also, it's a proper link, so you can copy and paste a post's permalink from there. (Wireless/extra.css)
* Finally found the reason why all of these Android browsers gave me different font sizes... Turns out, some of them force a scale of 1 on page load, even if it's set to 0.7, like it was. I decided that it was best to just do "like the rest" and set it to 1 (I'm even thinking of disabling zooming entirely), and then work on font sizes later. For now, it's very satisfying. (index.template.php, Wireless/extra.css)
! Fixed an undefined constant. I still really, really need to figure out why it can be undefined, but for now... It's cleaner to just test for defined(), and let it go. I can't win every time. (Subs-Template.php)
- Removed an inline style from select boxes. (Themes.php, index.css)
(5 files, 2kb -- but it feels more like 10KB... :P)
* Rewrote Wireless to take advantage of the new Msg skeleton. I thought it deserved its own commit, yeah... So, basically, the user box is now correctly shown in the post header, and I'm giving you back the info that was removed earlier, such as the post name (and last edit time). I reckoned that it was still very much useful in mobile mode, because often the topic title won't show up there, so it can be helpful to have it in the post. Also, it's a proper link, so you can copy and paste a post's permalink from there. (Wireless/extra.css)
* Finally found the reason why all of these Android browsers gave me different font sizes... Turns out, some of them force a scale of 1 on page load, even if it's set to 0.7, like it was. I decided that it was best to just do "like the rest" and set it to 1 (I'm even thinking of disabling zooming entirely), and then work on font sizes later. For now, it's very satisfying. (index.template.php, Wireless/extra.css)
! Fixed an undefined constant. I still really, really need to figure out why it can be undefined, but for now... It's cleaner to just test for defined(), and let it go. I can't win every time. (Subs-Template.php)
- Removed an inline style from select boxes. (Themes.php, index.css)
2589
Features / Re: New revs
« on August 22nd, 2013, 10:02 PM »
rev 2221 -- lulz, it's really becoming a running joke: long time without a commit, and then we both do one within the same hour ;)
(5 files, 3kb)
* Overhauled Msg template, to make it rely less on the skin's mobile status, and leave it up to the skeleton to decide what to do -- effectively making it much more readable, hopefully. Post header spans are now a <time> tag, something I've wanted to do for so long. A new macro was added, msg_author_avatar, which allows changing the tag type for the avatar container (li or div). The jury is still out on whether the new extra div inside .poster should be called 'column', it's an SMF convention, but that's a lot of bytes for something that could be handled with just '.poster>div'... Don't you think so..? Actually, most column definitions would fit that description, so... (Msg.template.php, sections.css, macros.xml, skeleton.xml)
* French translation. (index.french.php)
(5 files, 3kb)
* Overhauled Msg template, to make it rely less on the skin's mobile status, and leave it up to the skeleton to decide what to do -- effectively making it much more readable, hopefully. Post header spans are now a <time> tag, something I've wanted to do for so long. A new macro was added, msg_author_avatar, which allows changing the tag type for the avatar container (li or div). The jury is still out on whether the new extra div inside .poster should be called 'column', it's an SMF convention, but that's a lot of bytes for something that could be handled with just '.poster>div'... Don't you think so..? Actually, most column definitions would fit that description, so... (Msg.template.php, sections.css, macros.xml, skeleton.xml)
* French translation. (index.french.php)
2590
Features / Re: On Mobile Theme...
« on August 22nd, 2013, 06:07 PM »
What matters, is that in a few years time, Opera Mini will be nowhere to be found.
As for having the title next to the user name -- what's the problem with that, exactly...? :huh:
As for having the title next to the user name -- what's the problem with that, exactly...? :huh:
2591
Features / Re: Getting rid of zebra classes
« on August 22nd, 2013, 06:05 PM »
Here's a screenshot from my local site...
Because I merged .postbg/.postbg2 into .root (you could argue it's not my best idea and I should keep a '.bg' class in addition to .root), Wedge no longer removes bg classes when soft-merging posts, and as a result, it leaves stripes inside posts themselves, like this...
Do you this it's best to remove the background (and thus restore a bg class somewhere), or it's okay like that..?
Because I merged .postbg/.postbg2 into .root (you could argue it's not my best idea and I should keep a '.bg' class in addition to .root), Wedge no longer removes bg classes when soft-merging posts, and as a result, it leaves stripes inside posts themselves, like this...
Do you this it's best to remove the background (and thus restore a bg class somewhere), or it's okay like that..?
2592
Features / Re: Getting rid of zebra classes
« on August 22nd, 2013, 05:54 PM »
Okay, so, I started work on this, and there's (already!) an interesting issue... Right from the start, really. (Although I did manage to get MessageIndex to behave... :))
Topic pages!
HTML is like this:
<post>
<separator>
<post>
<separator>
<...>
So, if I'm styling <post>'s background, it'll always respond to :nth-child(odd), because :nth-child(even) would hit the <separator>.
It strikes me as a bug or something, because .postbg:nth-child(even) should hit every other .postbg elemnt, and certainly NOT "every other element, provided it has the .postbg class on it"...
I'm just sayin'. Work in progress, everythin'.
Oh... Crap! Got it.
What we're looking for is not :nth-child(even), it's :nth-of-type(even)...
Found explanation here:
http://css-tricks.com/the-difference-between-nth-child-and-nth-of-type/
Silly me...
Topic pages!
HTML is like this:
<post>
<separator>
<post>
<separator>
<...>
So, if I'm styling <post>'s background, it'll always respond to :nth-child(odd), because :nth-child(even) would hit the <separator>.
It strikes me as a bug or something, because .postbg:nth-child(even) should hit every other .postbg elemnt, and certainly NOT "every other element, provided it has the .postbg class on it"...
I'm just sayin'. Work in progress, everythin'.
Posted: August 22nd, 2013, 05:49 PM
Oh... Crap! Got it.
What we're looking for is not :nth-child(even), it's :nth-of-type(even)...
Found explanation here:
http://css-tricks.com/the-difference-between-nth-child-and-nth-of-type/
Silly me...
2593
Features / Re: On Mobile Theme...
« on August 22nd, 2013, 01:48 PM »
@Pentaxian that's the idea, yeah... My recent rewrite tried to restore as much of the desktop skin as I could, because it's simply better to retain all functionality, and just cut off any strings whose length isn't under our immediate control, like the topic titles...
@Wanchope, yup, it's the Wireless skin I've been using locally for some time, but I only uploaded it a couple of days ago here, because I felt it was ready for further testing by the audience... :)
I'm not 100% happy with font sizes, but at least now in Firefox and Android Stock, it's not as horrible as it used to be, phew...
The Ajax bug.... Never happened to me, really.
Then again, Opera Mini is NOT part of my mobile toolset, and I have no plans to change this: Opera Mobile is so much better, and even then, it's not as good as Chrome Mobile, so if you have an Android device, I'd simply recommend using Chrome, which is here to stay, unlike Opera Mini, because I really, really don't trust Opera for keeping Presto around, and worse, getting it up to date with today's standards, as they've already shifted all their efforts to Blink...
@Wanchope, yup, it's the Wireless skin I've been using locally for some time, but I only uploaded it a couple of days ago here, because I felt it was ready for further testing by the audience... :)
I'm not 100% happy with font sizes, but at least now in Firefox and Android Stock, it's not as horrible as it used to be, phew...
The Ajax bug.... Never happened to me, really.
Then again, Opera Mini is NOT part of my mobile toolset, and I have no plans to change this: Opera Mobile is so much better, and even then, it's not as good as Chrome Mobile, so if you have an Android device, I'd simply recommend using Chrome, which is here to stay, unlike Opera Mini, because I really, really don't trust Opera for keeping Presto around, and worse, getting it up to date with today's standards, as they've already shifted all their efforts to Blink...
2594
Archived fixes / Re: Soft merge / ignored user
« on August 21st, 2013, 10:48 PM »
I believe so. Around August 10, I think I'd committed all of my changes, really.
My current uncommitted stuff, and reason why:
- A warning message in Subs-Template due to constant not defined; because I don't know if it's best to test with defined() (as is the case on w.org), or to figure out why it happens that the skin option system is bypassed at some point, hmm...
- Some small layout tweaks; nothing important enough to hurry about, really.
- A new (important) mobile responsive layout tweak; applied on w.org, waiting for feedback until I commit. (There's been one so far, good.)
- Flag popup; not in a committable state, obviously...
- A Msg template rewrite; used here right now, no problems after multiple rewrites, so will commit soon.
- A fix in reqWin window height; waiting for a particular bug to occur again, so I can test it properly, really.
- A <wbr> fix; said bug only happened once, in one situation, and I'm actually not sure it's worth fixing, so...
- Fixed user boxes; waiting for commit, maybe with a skin option, don't know yet.
- extensive Warm rewrite; still not ready for prime time, has been in the works for months, now... :-/
My current uncommitted stuff, and reason why:
- A warning message in Subs-Template due to constant not defined; because I don't know if it's best to test with defined() (as is the case on w.org), or to figure out why it happens that the skin option system is bypassed at some point, hmm...
- Some small layout tweaks; nothing important enough to hurry about, really.
- A new (important) mobile responsive layout tweak; applied on w.org, waiting for feedback until I commit. (There's been one so far, good.)
- Flag popup; not in a committable state, obviously...
- A Msg template rewrite; used here right now, no problems after multiple rewrites, so will commit soon.
- A fix in reqWin window height; waiting for a particular bug to occur again, so I can test it properly, really.
- A <wbr> fix; said bug only happened once, in one situation, and I'm actually not sure it's worth fixing, so...
- Fixed user boxes; waiting for commit, maybe with a skin option, don't know yet.
- extensive Warm rewrite; still not ready for prime time, has been in the works for months, now... :-/
2595
Features / Getting rid of zebra classes
« on August 21st, 2013, 06:00 PM »You don't need to get rid of windowbg everywhere.
I think we need to have a 'generic' class for areas that need to apply a background, whether striped or not, but I don't really know... Just 'bg', maybe, would be fine..? But form vs. function, etc... So, just 'window' or 'win'...? Well, 'windowbg' never really made sense, I mean, it was never about 'windows', more about simply areas with alternating colors, so... 'zebra'? No, we need to ensure that the class can also be used on non-alternating areas, hmmm...
One at a time - there's already postbg specifically for posts, target that first. Then one for the thoughts list, and so on and so on. Eventually yes, windowbg will go and that's a good thing. Ideally each major area should have its own set of classes so that it's easier to style at will - while it will take slightly more CSS, the per-page saving could be surprising - because you wouldn't necessarily need to leave in all the classes; I don't know what 'root' does but I see no reason why you couldn't flatten down 'root postbg(2)' to simply postbg,
There are precisely two XenForo sites I know of that don't look like XenForo. Every other installation just screams XenForo. Ditto for IPB. Anything that introduces behaviour that is dependent on rewriting layout markup is going to be fragile.