Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
2446
Features / Re: New revs
« on October 10th, 2013, 02:59 PM »
rev 2272
(58 files, 6kb)

- $keys and $disable_trans are params only used in non-MySQL situations, and as Wedge isn't coming back to PGSQL and SQLite any time soon, there's no reason to complicate insertion queries for nothing, uh? Also updated all 200+ inserts to reflect that. (Class-DB.php, and 57 other files.)
2447
Other software / Re: Arantor back on SMF Team!
« on October 10th, 2013, 12:31 PM »
Old news, it's been at least a week or two... :P

I would comment on this, but I've already done it elsewhere...
http://www.simplemachines.org/community/index.php?topic=511570.msg3617460#msg3617460

To be specific, this is also the topic where Arantor first came up with the 'idea' of rejoining the team.
You'll also notice that all of his ideas are to take Wedge features and put them into SMF.

Just a month ago, he did say that he'd never join the SMF team... Anything but them, eh? Now, these days, he's speaking FOR the SMF team.

So, basically, nothing new. Pete is unpredictable, and he'll be unpredictable in the SMF team just as well. He's just been, let's say... back-porting 1% of his Wedge additions into SMF, very thoughtfully trying to limit the impact that Wedge will have upon SMF users once it's out. Thus, putting even more pressure on me to (1) release Wedge to the public, (2) keep the license closed, so that Wedge has at least some edge over SMF. I'm not exactly sure what he wants... But, it's not very friendly to me, despite anything he'll say.

Ah well, who cares. Wedge is close to public alpha status, so, whatever.
2448
Features / Re: New revs
« on October 9th, 2013, 07:17 PM »
rev 2271 -- small, but nice.
(2 files, 2kb)

+ Added ability for all skin tags to run on a specific URL. Use url-* for that, with * being your target $_GET variable, of course. <css url-action="profile" url-area="forumprofile">, for instance, will print CSS only on the ?action=profile;area=forumprofile page. That's a very, very good addition for themers. (Subs-Cache.php)

! Fixed broken layout on ViewQuery pages. (ViewQuery.php)
2449
Features / Re: New revs
« on October 9th, 2013, 10:58 AM »
rev 2270 -- minor admin stuff. I usually don't set foot in there, but I have to now, don't I...?
(7 files, 3kb)

* Some tweaks to the admin search... Don't cut off item descriptions (really, any reason to do that in the first place..?!), better French text, and improve the layout a bit. (Admin.php, Admin.template.php, mana.css, Admin.french.php)

! Typo in the reattribute feature. Seems that Pete liked spelling 'cannon' instead of 'cannot' (same in Simple/WedgeDesk), there may be a hidden meaning behind that, but I don't know what. (ManageMaintenance.php)

* Added a few separators in the reattribute feature, because it wasn't made very clear that the last option was for merging members, rather than merging a member and a guest. It's very different, I'd say. (ManageMaintenance.template.php)
2450
Features / Re: New revs
« on October 8th, 2013, 03:02 PM »
rev 2269 -- back to some less headache-inducing commits, phew...
(3 files, 2kb)

+ Wess now allows for the use of wildcards instead of values in @remove operations. This can be useful, if you're not sure what the parent is doing at this point. (Class-CSS.php)

! Fixed error occurring on topics with no replies. (Display.php)

! Plugin language files should get their entities converted to UTF, just like regular language files. (Load.php)
2451
The Pub / Re: Infinite Scroll
« on October 7th, 2013, 02:33 PM »
An interesting bug... Don't know if I can, or will, fix it.

- Change to Wireless, go to a topic.
- Open new tab, change to Weaving in it.
- Go to previous tab, go to bottom, trigger infinite scrolling.
- ???
- Profit.

I'll let you see the bug for yourself, because it's sort-of funny... These are the limits of per-skin custom HTML, I guess... :lol:
2452
Archived fixes / Re: Header issues
« on October 6th, 2013, 10:16 PM »
Busy IRL. Had a 500km drive. I'm tired!
Posted: October 6th, 2013, 09:28 PM

There, there... Fixed now.
Going to bed early. Rough day really...!
2453
The Pub / Re: Infinite Scroll
« on October 5th, 2013, 04:42 PM »
So, err... I think I've got it mostly right, this time...!
I did a test on the New Revs topic, which is just a lot of text, and it loaded the first 10 pages pretty much instantly. After 10 pages, though, it started getting a bit slower.
After 32 pages loaded, the page was really slow to load. At least, it wasn't slow to process, but it finished internal execution *after* I'd reached the bottom, and since the event is now only called on 'scroll', I can't just scroll down to show the page, since the event doesn't trigger at all. I could alternatively 'install' a temporary mouse wheel event when the end of the page is reached, and remove it later, but that sounds a bit awkward, I don't know... The point of the 'scroll' event is that you can still trigger the page prefetch by simply hitting the 'Page End' key on your keyboard, but then you have to use Up and Down arrows once to actually show the content.
Still, I don't like the idea of automatically showing available content as it becomes ready, because I want people to still be able to easily access the footer, and most importantly, the page index list (of course, they can do it by going to the top of the page, but it's rather inconvenient.)

Basically, we're in user experience land, here, and I'm not what I can, but... I guess I need *user* feedback, eh... ;)

I think the method I used in rev 2268 is pretty fine for 10 pages, but beyond that, I should instead specifically target the new posts, e.g. with a div ID as context.
I'm not sure it's for the best, though... I mean, 10 pages is a lot to read through, and beyond that, you may get lost. I'm thinking, *maybe* I could forcibly stop the infinite scrolling process after 10 pages, and invite the user to just press the Next link, and then they'll be free to start another session of 10 pages. I don't know, what do you think..? Or is it better to give absolute freedom, like now?
2454
Features / Re: New revs
« on October 5th, 2013, 04:27 PM »
rev 2268 -- I'll get it right! I promise!!
(5 files, 3kb)

+ Doing the touch version of infinite scrolling. Well, it's just a try. The first one didn't work, so... Trying again. (topic.js)

* Trying to increase infinite scrolling performance.

  - Attempting to limit the number of events infinite scrolling is tied to to just one (scroll for desktop, touchmove for mobile.) (topic.js)
  - No need to load topic.js again; I'm in charge of that file, so I'm responsible for calling its functions manually as needed. (Display.template.php)
  * The Mime and Zoomedia plugins now add a 'processed' class, and refuse to handle further calls to items marked with that class. (script.js, zoomedia.js)
  * Same for InTopicModeration calls. (topic.js)

! The Mark read request on last pages was sent on each page scroll... Oops! (topic.js)

! Fixed wrong language entry. (Who.french.php)
2455
The Pub / Re: Infinite Scroll
« on October 5th, 2013, 01:15 PM »
So... What do you guys think about the rewrite..? Like if you do! :P

From what I can see, it works better than the previous version, but it has one definitive drawback: it executes the new page in the background before showing it, and it 'stops' my page from scrolling for a second or so. I don't know if it will happen in any browser, this is what I'm getting on this very topic in Wireless on my Windows 7 rig under Chrome 30.
2456
Features / Re: New revs
« on October 5th, 2013, 12:13 PM »
rev 2267 -- PHEW! And here it is... The infinite scrolling rewrite. Although, I think what's infinite here, is the rewrite, not the scrolling.
(6 files, 10kb)

* Changed the way 'Mark unread' works on topics. The original thinking was this (and it always confused the hell out of me): the unread position would be reset to what it was *before* the current topic page was loaded. Instead, I changed it to be reset to the page you're currently viewing. That is, if you've already read the topic, and you just want to sort of 'bookmark' a particular page, you can go to it, and press Mark unread. Next time you follow a 'new' link to the topic, you'll be taken to that page. I believe this is more natural. Another difference is with the last page. Previously, pressing Mark unread there would mark the entire topic as read. Now, doing it will simply mark this page as unread. If you need to mark the entire topic as unread, for some reason, you can just go back to page 1 and mark it unread there. (Display.php, Subs-Boards.php)

* Overhauled infinite scrolling to be closer to what one might except from it. Instead of requiring several mouse wheel rolls to load the next page and show it, Wedge will pre-fetch it in the background when you're getting close to the end of the page. It will then show it immediately as soon as you reach said end. The hardest part was to get 'mark read' to behave, and it should be good: an infinitely scrolled page is only marked as read when the next page is prefetched. On the last page, Wedge will not prefetch anything of course, but will send a Mark read request in the background if the page isn't already marked as read. (Display.php, subs-Boards, Display.template.php, index.css, topic.js)

* The Ajax version of topic pages (i.e. infinite scrolling) now return only what's needed, i.e. the posts themselves, and a new version of the page index. (Display.template.php, topic.js)

+ Added an 'edited' variable to topic post arrays. Basically, if set to true, it means "this post has been edited since the last time (last post) you read (in) this topic." Up till now, it wasn't possible to determine whether the first 'new' post in a topic was really an unread post, or a modified post. (Display.php, Msg.template.php, index.language.php)

* Side font size tweak. Needed wider testing, so I want it on wedge.org. (index.css)

@ The topic.js rewrite, despite all the additional improvements, saved about 300 bytes. Dunno how much when gzipped, though.

@ Note to self: need to support touch in infinite scrolling.
2457
Features / Re: New revs
« on October 5th, 2013, 12:05 PM »
rev 2266 -- turns out I had many more minor changes to be applied separately from the infinite scrolling rewrites; it's better for readability to do them separately, really...
(10 files, 13kb)

! Fixed AeMe embeds not always correctly working in infinitely loaded posts. Oh, yes, they'll still fail on most mobile browsers... No se preocupe. (Aeva-Embed.php, Aeva-Subs-Vital.php)

! The recent mass-conversion of files to use UTF-8 (rev 2252) broke aeva_getEncryptedFilename(), so I rewrote it to use hex-encoded values, instead of plain characters. This should work better (and it better do, I wrote the conversion manually!), but honestly, maybe I should just not bother either, because it's all about Linux filenames, and I'm sure they support UTF-8.. Right? (Aeva-Subs-Vital.php)

* Sped up the Go up/Go down features; an animation looks nice, but I never really wanted to spend one second flying over a topic page. (topic.js)

* Moved QuickInTopicModeration to QuickMod.php -- makes more sense, to me. (index.php, QuickMod.php, Display.php)

* Harmonized hr separators to always show at the end of a topic page, instead relying on CSS to hide the last one. This is better for infinite scrolling, basically. And John asked for it. (Msg.template.php, sections.css)

! While forced linebreaks are generally okay in a fixed layout, I should really stop enforcing these in responsive layouts. (index.language.php)

! Prevent quick_edit buttons from being duplicated when using infinite scrolling. (topic.js)

- Reverted the actionbar hack in quick edit. It's best to get as much real estate as possible for the textarea, even if it doesn't look as good. There are worse things to deal with, really. (topic.js)

- Removed a few unused styles. I'm sure there are more in there, I just need to find them, or someone else to find them for me... (sections.css)

@ Note: added an 'edited' string to language files, too... This will be used in the next commit.
2458
The Pub / Re: Infinite Scroll
« on October 5th, 2013, 08:46 AM »
Quote from Nao on October 3rd, 2013, 05:59 PM
It's not my local version, so I'm guessing you completely missed on this feature before, right..? ;)
Lol...
I re-read the early posts. Obviously I should have, before suggesting that... ;)
2459
The Pub / Re: Infinite Scroll
« on October 4th, 2013, 11:55 PM »
Would it be due to your upgrade to v7..?
Posted: October 4th, 2013, 10:13 PM

I'm sure it's the OS version. Definitely.
The difference is that iOS 7 Safari supports flexbox, so I enabled it by default for Safari 7, but... Well, if the result looks like this, their implementation is definitely buggy, I'd say...!

The one problem I have, is that I don't remember using flexbox in Wireless, but perhaps it's really, really fucked up.
Since flexbox works in IE 10, IE 11, Chrome and Firefox, I'm assuming I 'got it right', and iOS has to behave. If it doesn't, I'll have to disable flexbox on Safari, which I really wouldn't mind doing, since I have no interest in Safari at this point.

Anyway...

Anyone else with Safari 7 around..? I tried browserstacks and browsershots, but they only provide Safari 6 screenshots, argh...
2460
The Pub / Re: Infinite Scroll
« on October 4th, 2013, 07:52 PM »
On what device..?