Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
2251
Off-topic / Re: A short script to remove unused, useless globals in PHP.
« on November 18th, 2013, 11:15 PM »
Bump to try and determine if it's really worth making a repo out of this snippet. ;)
2252
Other software / Re: SMF reaction to 'unused, useless globals'
« on November 18th, 2013, 11:14 PM »
Quote from emanuele on November 18th, 2013, 10:58 PM
Until a while ago that board was open to friends as well, apparently now
It had been for years. I had access to it even for the whole time I was post-banned at sm.org... And until recently, was still the case. Basically, I think they removed access for Friends after I picked up a topic where Arantor was criticizing me, and thought he was safe in a 'private' area. After I debunked his lies (still in private!), I guess the SMF team figured that they didn't want to piss Arantor off, and decided to kick me (and all Friends) out of that board.

I haven't checked, but I don't see any other plausible explanation.

So, now Pete can safely lash out at me, when he used to always agree that if we were to lash out at someone, it should be *in a place where they could defend themselves*. Because neither he nor I appreciated being the object of criticism behind our backs.

I guess his 'morals' and 'intellectual honesty', of which he used to be so proud, are solvable in vinegar. ::)
Quote from emanuele on November 18th, 2013, 10:58 PM
the board has been closed down[1].
 1. I can just assume in order to avoid that a competitor would be able to read the development secrets...sorry guys, I may have spoiled you the fun... :(
Well, fact is, I don't read that board, so it doesn't change anything for me. Simply, as it was part of my 'readable boards', it would come up in search results when I did a search on recent posts mentioning 'wedge' or 'nao', as I do from time to time. (Now that I've made it clear what my search keywords were, I've also noticed Pete started to avoid using them, presumably to make it harder for me to find posts where he lashes out at me. Fine by me, that's less time to waste on futile flame wars.)
Posted: November 18th, 2013, 11:12 PM

Split into its own topic. It has little to do with optimizing code, at this point, more like optimizing relationships, or the lack thereof. ;)
2253
Archived fixes / Re: FF messing things up?
« on November 18th, 2013, 11:05 PM »
Hmm, I thought Firefox had the same problem as Chrome, but it turns out it's worse in Firefox, as it screws up the flexbox even when there's a vertical scrollbar on the code block.
I've modified the script accordingly. Still doesn't make sense to me -- and I can't believe that Chrome and Firefox (but not IE :wow:) would fail at such a 'simple' layout as <flexbox><tag with white-space: pre></flexbox>... It's really, really just as simple as that. They suck at flexbox.
2254
Archived fixes / Re: FF messing things up?
« on November 18th, 2013, 10:52 PM »
You forgot the usual OS/browser version, etc...

No such problem for me in Aurora Win 7.
Also works fine in regular Firefox in Ubuntu.
2255
Off-topic / Re: TV & movies
« on November 18th, 2013, 08:47 PM »
Quote from Bloc on November 18th, 2013, 08:13 PM
Haven't got around to seeing Homeland yet, so that I'll reservee for when I have - but its prob. great, as always. ;)
It definitely wasn't bad.

OUAT was good, too. Still as silly as ever, but the story actually progressed a lot, unlike earlier episodes.
The Walking Dead was one of those 'stand-alone' episodes, like 'Clear' in the previous season. Great stuff, albeit a bit slow and very, very dry. But I'm a sucker for David Morrissey, so that's fine.
Quote from Bloc on November 18th, 2013, 08:13 PM
I saw 2 movies this weekend, one was for the kids mainly(but a lot of fun for us grownups too) called "Flåklypa" - and the other one was Red2.
I read your review of 'Europa Report' recently, that one went under my radar, I've added it to my watch-list. ;) (Although I don't like found footage movies, I can sometimes make exceptions for them, as in Chronicles.)
Quote from Bloc on November 18th, 2013, 08:13 PM
I don't know if you ever saw the first Red - but I loved it. :)
Nope, never saw it. I lost interest in Bruce Willis after, hmm... his appearance in Friends, maybe? Really, he didn't do anything great after The Sixth Sense, I think. I love him, though, but not enough to watch a movie based on his name, unlike, say, Kevin Spacey. I'll watch any crap with Kevin Spacey in it. (Thankfully, he usually makes wise decisions.)
Quote from Bloc on November 18th, 2013, 08:13 PM
All those old-timers really got it going in the action parts, and the slapstick humour all through was just hilarious. Bruce Willis: awesome, Helen Mirren, more so. The others really just as good. The movie really didn't bring anything new in the genre..but it was just well executed and fun.
I'll take note of that.
Quote from Bloc on November 18th, 2013, 08:13 PM
(btw, speaking of TV/movie topics, I've spent a lot of time in Protendo on its "moviereview" section, and gonna add a "TV" section too. Its one of those things that are part blog, part discssion - with some social features added in. Thus perfect for me. :) )
Yeah, it's a feature you've worked a lot on; currently, the blog feature in Wedge is broken, I'm not sure why, I'll really have to add some UI to change the board type. It's so damn easy. And I'm so damn lazy about writing UI... Look at contact lists, I could just re-use code from Noisen for that, but no... I'm just not doing it. :lol:
2256
Other software / Re : SMF reaction to 'unused, useless globals'
« on November 18th, 2013, 08:11 PM »
Quote from TE on November 17th, 2013, 06:24 PM
yep, I found most via Netbeans but Spuds, Eman and I spend hundreds of hours for cleaning, documenting and improving the code.. It's not only Netbeans' benefit ;)
I so would love to have them (in addition to you :P) contribute to Wedge, if only for details like these; this is the kind of offer I could never refuse. ;)

Well, it's too bad that Wedge and Elk aren't directly interoperable; I mean, I can't exactly cherry-pick a commit from Elk, etc. Or even from SMF. As such, I really very rarely check out either changelog, and will usually miss any bugfixes.
BTW, I don't know if you read my Wedge changelogs, I suppose you do, but in case you don't, sometimes I'll document bugs that are also in Elk and SMF; or just in SMF, in which case it doesn't concern you. Just search new rev pages for 'smf', and it should narrow them down.
2257
Other software / Re : SMF reaction to 'unused, useless globals'
« on November 18th, 2013, 08:07 PM »
Quote from Aaron on November 18th, 2013, 02:27 PM
Well, at the time, the main rationale behind having all those unused globals was having them there for mod authors to use, so they wouldn't have to modify the global-line as well — which, in most cases, would cause conflicts.
Yes, I remember that; I was told about that by Norv, IIRC, when I did commits to the SMF base in 2010.
Quote from Aaron on November 18th, 2013, 02:27 PM
Now that we're all moving towards hook-based mods, it's certainly time to clean it all up, indeed.
Yup.
Although, again, it's not a BIG deal... Personally, I'm currently onto other more important issues, globals themselves can wait until I have nothing left to fix. ;)
2258
Other software / Re : SMF reaction to 'unused, useless globals'
« on November 18th, 2013, 08:06 PM »
I guess so.
2259
Off-topic / TV & movies
« on November 18th, 2013, 08:03 PM »
Just thought I should create a generic topic to discuss TV shows and movies as you like.
Because, well, there's already a Doctor Who topic for instance, but AFAIK it's on the Private area, and, well, it's only talk about the new episodes, so why bother with privacy...

Feel free to use this topic, or not, or just create other topics, I don't mind. Just thought it'd be nice to have a generic one. Maybe it'd be best to have a TV topic and a movie topic, I dunno.

I'll just pull a Shawn™ trick, and start with... "What did you think of yesterday's shows? Homeland/OUAT/The Walking Dead/etc."

PS: this is my 300th topic, apparently... :P
Well, that's one "Top poster" stat that I won't have for another few years, if not forever, because I usually prefer to re-use existing topics... ;)
2260
Features / Re: New revs
« on November 17th, 2013, 11:53 AM »
rev 2325
 10 files changed, 36 insertions(+), 50 deletions(-), 2.16 KiB

! Unneeded or malformed params. (Aeva-Embed.php, Aeva-Foxy.php, ManageMedia2.php, Thoughts.php)

! Nao bug: AeMe didn't correctly get the inserted ID on playlists. (Aeva-Foxy.php)

! SMF bug: non-existent variable $type. Note: fixed in Elk, but not SMF 2.1. Also some bracketnazi. (Reports.php)

! Pete bug: search settings were broken by a hasty rewrite. (ManageSearch.php)

! Pete bug: yet another parenthesis problem, this one was in his very first commit for draft saving. Interesting. Just hoping this fix doesn't actually break the feature; in which case, at least I'll know what I need to remove. Also saving a few function calls if the draft is going to fail. (Subs-Post.php)

! Pete bug: $row['issued_by'], not $issued_by. (And yes, if you want to take your infraction code elsewhere, of course you don't have to bother about this bug fix.) (ModerationCenter.php)

! Pete bug: a single use of $db_connection instead of self::$_db_con since his very first commit of that class. I think the most amusing here is the irony of that bug being inside the function called serious_error. (Class-DB.php)

@ As in a few of the last commits, this changeset is mostly sponsored by hhvm-wrapper. A real life-saver, even if it took hours to get it to work...
2261
Other software / Re : SMF reaction to 'unused, useless globals'
« on November 17th, 2013, 08:48 AM »
Bloc, I don't have access to that topic, even as a friend.

So, I'm guessing they are indeed talking about me in more private sections? Nice. And Arantor was complaining that I had made a fair topic about him in a board that he would still be able to acccess if he hadn't removed himself from it.
Sorry for the OT.
2262
The Pub / Re: git problems for non-gits.
« on November 16th, 2013, 11:26 PM »
Oh, yes I know, I could filter-branch to move all files to their 'final destinations', but I don't think I'll enjoy the process at all, so... Let's forget about that really, I have more hopes that the TortoiseGit will fix that one's issue in a timely manner ;)
Posted: November 16th, 2013, 11:06 PM

Another thing. I hate that when I stash files, when they pop back into existence, their file dates are all reset to right now. You can't possibly expect me to use a system that screws up my entire conception of a repo folder, i.e. the most commonly modified files are the first ones to show up (sorted by modified date.)
Meaning, I have to copy my stashable files to another folder, and then do the whole process of copying them back later, etc... Very, very annoying. I don't know if it's a TortoiseGit issue, but I doubt it's due to something else than git itself.
2263
Off-topic / Re: Doctor Who
« on November 16th, 2013, 11:23 PM »
Quote from Bloc on November 16th, 2013, 12:33 PM
I must admit the older series doesn't hold that fascination with me as the 2005 onwards episodes.
I suppose you'd have to be British, and have seen the show when you were a kid on a Saturday afternoon.
Just like I'm a diehard fan of Saint Seiya, which is a silly show, but I watched it as a kid, and there's no better soundtrack than this for me, and no better character-design, and no better nekketsu, and no better handling of Norse mythology (okay, it's pretty much alone in that area), etc. When watching old episodes now, I have to say I'd understand that newcomers would find the show to be boring or overdone or just plain ridiculous. But to me, it's just the perfect, ideal, forever-best anime I can think of.
Quote from Bloc on November 16th, 2013, 12:33 PM
Child of my age and all that lol, but the reboot did spur new life in the series for a reason. Still, fun occasionally of course.
I don't know, I never got around to watching an *entire* arc of the old show. I tried Genesis of the Daleks and it was boring as hell. I tried Pyramids of Mars and the costumes were too damn laughable. I tried really, really hard with City of Death (as it's set in Paris, is written by Douglas Adams and has a bit part with John Cleese), but as soon as the episode starts, you have to go through five minutes of a ridiculous alien in his spacecraft and cheap SFX. Come on.

Eye of the beholder, eh.
Quote
I want that new Bluray release with season 1-7 (2005-2012) in 720/1080p though,preferably for Christmas but we'll see.. :D . Having those seasons in HD will be awesome.
Really, they're releasing the first seasons in HD..? But they were all shot in 4/3 480p to begin with, weren't they..?
2264
Off-topic / Re: A short script to remove unused, useless globals in PHP.
« on November 16th, 2013, 11:16 PM »
Quote from TE on November 16th, 2013, 06:52 PM
yay. Thank you for that little helper.
You're welcome.
Quote
Found some real ones in Elk with it, but some are definetely false reports.. I'm currently down to a total of 21 for Elk :whistle: 8 from upgrade.php, but there's the eval for the parsed SQL code.
Impressive.
Quote
Make a github repo and push it, It's a nice litte tool :cool:
I don't know, do you think it'll be that helpful..? What can be added to it? Apart from trying to fix false positives (always a question mark on whether it's possible to do much) and adding support for nested functions (yes, this one's doable), I don't know what else to do... I tried changing the code to allow for the removal of strings, but considering there are several ways to start a string in PHP, it started getting complicated, and then I gave up on that one...

Anyway, I'm not adverse to the idea of making a repo out of it; it's just that I'm not into the habit of pushing a repo that's just one file, and a few dozen lines... ;)
Quote
checked with your updated version, 2 remaining and these are from an external library ::) Won't fix them but Elk is completely clean.
Well, I'm sure you already did 90% of the work through NetBeans, didn't you? ;)
I decided against using NetBeans for that generally, because of the many false positives, such as "undeclared variable" when doing preg_match_all($regex, $string, $my_new_variable)... Yeah, NetBeans, I'm not going to initialize a variable just because you can't fathom that PHP would actually initialize the variable this way, hmm...
Quote
Edit: I left those in install.php and upgrade.php, too..
I'm sure Elk isn't 'upgradeable' via upgrade.php just like Wedge isn't, so yeah, you can probably leave it out... ;)
As for install.php, it doesn't have many issues with global, IIRC.
2265
Off-topic / Re: A short script to remove unused, useless globals in PHP.
« on November 16th, 2013, 11:11 PM »
Quote from Bloc on November 16th, 2013, 12:49 PM
Ah, ok..still, its worthwhile setting the globals correctly, so I'll hunt down some of them. It may take a while before I reach all 2000 hah. It will be  more tidy code though, removing those unused, good when hunting down bugs too.
Yes, it's always good to have a clean codebase!
I can't believe SMF's has always been so 'dirty', in comparison... But I did spend many months fixing up all the code.
Quote from Bloc on November 16th, 2013, 12:49 PM
OOP yes, I've been reluctant to adopt to them, but see their use of course. Its that though, beginning to use them makes me think how the whole system may be better using it, and that implies a total rewrite - which is very time-consuming. I simply don't have the time for it, and fear my theme/feature ideas will wither away while doing it... :P :)
OOP can't live without at least a bit of procedural code here and there I'll say, because otherwise, might as well start using a framework like Laravel or something even newer and fancier, and then start rewriting everything on top of it, etc... (Like FluxBB is doing, for instance. Well, that version 2.0 has been in development hell for months now, so... Maybe not such a good idea.)
Quote from Bloc on November 16th, 2013, 12:49 PM
About table tags..this is what I put on Protendo, its a simpler code and it certainly need some error checking(its now up to the author to do it correctly, I have an idea of a popup where you just fill in items though, and its inserted with the right tags for you), but my goal was "simplify" foremost. Not everyone understands table/tr/td so well. :)
Very, very nice.
I could see you turning into a more familar tag family, though:
[table][th]Hello|World|!!![/th][tr]Catch|me if you|can[/tr][/table]
I'm sure we could even tweak the internal table decoding functions to support this alternative format, and then push for its use.