This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
211
Archived fixes / [CSS] Re: .postheader and previous/next post title looking bad
« on January 16th, 2017, 11:42 PM »
If you'll excuse me, the BEFORE picture looks like the RIGHT one to me... This CSS bit is intended to make the whole thing work on mobile contexts. Having the prev/next titles shown to the left and right makes no sense in that way. That's why I settled on moving them to the top & bottom. Actually, it's the ONLY reason I used this complicated setup at all... :^^;:
212
Features / Re: Language revs
« on January 10th, 2017, 11:51 AM »
[Commit revision 328bf5a]
Author: ramazansubasi
Date: Tue, 03 Jan 2017 09:07:05 +0100
Stats: 34 files changed; +7400 (insertions), -0 (deletion)
[Commit revision b7d544a]
Author: Nao
Date: Tue, 10 Jan 2017 11:51:47 +0100
Stats: 34 files changed; +7400 (insertions), -0 (deletion)
Date: Tue, 03 Jan 2017 09:07:05 +0100
Stats: 34 files changed; +7400 (insertions), -0 (deletion)
- Turkish Language Files
- Turkish elektronic forum www.elektronark.org, language files
[Commit revision b7d544a]
Date: Tue, 10 Jan 2017 11:51:47 +0100
Stats: 34 files changed; +7400 (insertions), -0 (deletion)
- Merge pull request #29 from ramazansubasi/master
- Turkish Language Files
213
Features / Re: Language revs
« on January 10th, 2017, 11:50 AM »
[Commit revision 0974044]
Author: C3realGuy
Date: Tue, 10 Jan 2017 10:04:00 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 0722254]
Author: Nao
Date: Tue, 10 Jan 2017 11:50:46 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Tue, 10 Jan 2017 10:04:00 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Fixed typo in index.german.php
- "Ale" should be "Alle"
[Commit revision 0722254]
Date: Tue, 10 Jan 2017 11:50:46 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Merge pull request #30 from C3realGuy/master
- Fixed typo in index.german.php
214
Features / Re: New revs
« on January 8th, 2017, 09:33 PM »
[Commit revision 4137fe0]
Author: Nao
Date: Sun, 08 Jan 2017 21:33:00 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Sun, 08 Jan 2017 21:33:00 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Deprecated warning at install time when using PHP 7. (install.php)
215
Features / Re: New revs
« on January 4th, 2017, 09:06 PM »
[Commit revision 3802cca]
Author: Nao
Date: Wed, 04 Jan 2017 21:06:42 +0100
Stats: 1 file changed; +7 (insertions), -4 (deletions)
Date: Wed, 04 Jan 2017 21:06:42 +0100
Stats: 1 file changed; +7 (insertions), -4 (deletions)
- In server admin pages, if settings_message was ever set (e.g. in cache management pages), it would overwrite the error message that should pop up if Settings.php's file rights are incorrectly set. Way to go... (ManageServer.php)
216
Archived fixes / Re: Error Subs-Template.php
« on December 30th, 2016, 11:07 AM »
Oh... Interesting. I had double-checked the pipeline to see if $context['page_title'] wasn't always set, and it seemed to me like it was so I removed the check I had in place. I get RSS is such an alternative path that doesn't go through templating but still goes through string replacement... Makes sense.
217
Features / Re: New revs
« on December 19th, 2016, 04:47 PM »
[Commit revision ff49935]
Author: Nao
Date: Mon, 19 Dec 2016 16:47:06 +0100
Stats: 2 files changed; +6 (insertions), -7 (deletions)
Date: Mon, 19 Dec 2016 16:47:06 +0100
Stats: 2 files changed; +6 (insertions), -7 (deletions)
- Tweaked page title code to allow $context['page_title'] to be set while the page is being output. (Subs-Template.php, index.template.php)
218
Features / Re: New revs
« on December 14th, 2016, 10:15 AM »
[Commit revision 17de122]
Author: Nao
Date: Wed, 14 Dec 2016 10:15:09 +0100
Stats: 2 files changed; +9 (insertions), -6 (deletions)
Date: Wed, 14 Dec 2016 10:15:09 +0100
Stats: 2 files changed; +9 (insertions), -6 (deletions)
- Tweaked the select box replacement to avoid shrinking the box too much, which can be bothersome if there's a long subtitle right below a short title. You don't get it? Don't worry, you don't need to. (sbox.js)
- Spacinazi. (Subs-Template.php)
219
The Pub / Re: How I miss the freedom of coding the easy way...
« on December 6th, 2016, 05:24 PM »
The we: would be pointless.
And the context string would only be there to differentiate a common string like 'time' by context.
And the context string would only be there to differentiate a common string like 'time' by context.
220
The Pub / Re: How I miss the freedom of coding the easy way...
« on November 25th, 2016, 01:40 PM »
Actually, unlike SMF, Wedge *does* fall back to English if a specific string (or an entire file) is missing from the translation.
One of the things that bother me is that SMF never put a clear wall between the admin & public areas. That is, it's MUCH easier to translate JUST the text visible to regular users, and leave the rest in English. It makes the idea of starting a translation from scratch much less scary.
Because, let's face it, if you DON'T speak English at all, you're better off NOT trying to administrate a forum, or even a website in general... I'm not saying you shouldn't, I'm saying perhaps you should consider leaving it to someone else. ;)
I don't know, regarding this txt() thing, what do you guys think..?
It couldn't be magically done with a mass replace though, because of the whole 'context' thing. Although I suppose we could just write a quick tool to go through all strings in all files, and print out the duplicate ones, and apply a context to each of them.
Time goes by and I still regret that Wedge never took off. If there was a large community behind it, it would be so encouraging. Then again it would also make it harder to do breaking changes like these... ;)
Gosh it's been so long, I'm getting lost in my own code changes. For instance, I don't remember how to override a template function from within a Custom.template.php file... At least I remember I can do that, lol. I'll need to find where I documented that...
One of the things that bother me is that SMF never put a clear wall between the admin & public areas. That is, it's MUCH easier to translate JUST the text visible to regular users, and leave the rest in English. It makes the idea of starting a translation from scratch much less scary.
Because, let's face it, if you DON'T speak English at all, you're better off NOT trying to administrate a forum, or even a website in general... I'm not saying you shouldn't, I'm saying perhaps you should consider leaving it to someone else. ;)
I don't know, regarding this txt() thing, what do you guys think..?
It couldn't be magically done with a mass replace though, because of the whole 'context' thing. Although I suppose we could just write a quick tool to go through all strings in all files, and print out the duplicate ones, and apply a context to each of them.
Time goes by and I still regret that Wedge never took off. If there was a large community behind it, it would be so encouraging. Then again it would also make it harder to do breaking changes like these... ;)
Gosh it's been so long, I'm getting lost in my own code changes. For instance, I don't remember how to override a template function from within a Custom.template.php file... At least I remember I can do that, lol. I'll need to find where I documented that...
221
The Pub / How I miss the freedom of coding the easy way...
« on November 17th, 2016, 05:44 PM »Added a generically generic template for the generic purpose of showing generic text in the usual generic place.
To hell with MVC! Anything that makes reading code is a plus of course, but if it makes WRITING code much more annoying, then it also kills spontaneity.
It's a bit like the language translation system... SMF does it with $txt['item_name'], when really they should do something like txt('Actual text'), and then call a function that checks if a translation is available for that particular string... Maybe a txt('Actual text', 'Context') allowing for multiple strings within different contexts, of course... Things like that. That would make it easier to just write plugins without having to bother about translations, and then anyone can translate any string that way (plus, they don't have to refer to a master file to get the original translation, and if the English version is modified, the translation will need to be updated otherwise the text will now show up in English -- in the current Wedge and SMF, a modified English string won't be updated at all in translated version).
Yes it's a bit slower at parsing time, but it's not a problem with Wedge, because all files are cached, and thus you can parse & run that function at cache time and not at runtime, and then save the cached file to something like 'Something.template.french.php', etc...
Of course, it's too late to do that now...
222
Features / Re: New revs
« on November 11th, 2016, 12:50 AM »
[Commit revision c8e81fa]
Author: Nao
Date: Fri, 11 Nov 2016 00:50:15 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Fri, 11 Nov 2016 00:50:15 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Grmmblbl, I'm always unhappy with details in my skins every time I switch browsers... (Wilde/extra.css)
223
Features / Re: New revs
« on November 11th, 2016, 12:45 AM »
[Commit revision 9e65369]
Author: Nao
Date: Fri, 11 Nov 2016 00:45:12 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
Date: Fri, 11 Nov 2016 00:45:12 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- Naughty mistake in the loadTemplate override! (Subs-Template.php)
224
Features / Re: New revs
« on November 10th, 2016, 05:12 PM »
[Commit revision a9ce176]
Author: Nao
Date: Thu, 10 Nov 2016 17:04:17 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
[Commit revision d7369ba]
Author: Nao
Date: Thu, 10 Nov 2016 17:11:37 +0100
Stats: 2 files changed; +25 (insertions), -1 (deletion)
Date: Thu, 10 Nov 2016 17:04:17 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
- Typonazi. (Profile-Actions.php)
- This database error message should be slightly more helpful. (Class-DB.php)
[Commit revision d7369ba]
Date: Thu, 10 Nov 2016 17:11:37 +0100
Stats: 2 files changed; +25 (insertions), -1 (deletion)
- Added a generically generic template for the generic purpose of showing generic text in the usual generic place. Basically, if you don't really adhere to the MVC principles of separating output from the rest of the code (yes, I'm one of those -- stop staring at me like that, at least I don't vote for fucked up lunatics!), you can do your math, then when you're ready to show it, just call loadTemplate(function () { put your echo's in there }), and voilà, you don't have to bother creating an extra template. If anyone has a cleaner solution to that problem, be my guest. I think that doing it in half a dozen lines of code is simple, safe and helpful. (Generic.template.php, Subs-Template.php)
225
Features / Re: New revs
« on October 24th, 2016, 09:32 AM »(2) parse_str() actually does an implicit urldecode() on the query string, so if $_GET was getting a value of '%2B', it would first be turned into '+' by the first urldecode(), then into a space by the second implicit one.
http://dev.simplemachines.org/mantis/view.php?id=2669
I actually made a commit in 2010 to the SMF codebase (that was later reverted in 2011) adding the urldecode(), so it was partly me ahah. But this was only to help Thorsten who apparently had webmail problems that were fixed with that. Basically: these webmails would turn semicolons into their url-encoded versions, so they wouldn't be spotted by SMF/Wedge at the time of analyzing the query string. So, the real culprits were:
- the original PHP authors, for putting an implicit (and illogical) urldecode() into parse_str()
- the PHP.net documentation writers, for not mentioning it...
- the original SMF writers, for not noticing it (I couldn't blame them for that!)
- German webmails (?) that didn't correctly apply encoding standards on URLs. (In my view, these are the worse offenders...)
- and SMF developers (mostly Thorsten, Norv and I, since we all looked into this), for relying on double-urldecoding to fix that, without ever considering that it could break strings that were urlencoded for a reason on the sender's side.
So yeah, it's a shared blame I guess. Due to this mess, SMF was broken for a while due to improperly decoded $_GET strings... And this probably had *many* consequences on the codebase for the years that came, e.g. creating bugs that weren't spotted in that place but 'hastily fixed' in another, and that hopefully this revert won't re-trigger. Just incredible.