Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
196
Features / Re: New revs
« on January 25th, 2017, 11:24 PM »
[Commit revision 3b7dbd4]
Author: Nao
Date: Wed, 25 Jan 2017 23:20:34 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Fixed another one of those annoying ONLY_FULL_GROUP_BY errors that show up in MySQL 5.7+ and tend to make it skedaddle. Again, I'm using the 'safe' solution (backwards compatible), although ANY_VALUE() would be best. Adding the related field to the GROUP BY clause is also a solution, but it makes it about 10% slower. Ideally, one should disable that directive entirely, and I have something in the works for that, because it's about 10% faster this time. (Thoughts.php)
197
Features / Re: New revs
« on January 24th, 2017, 11:58 PM »
[Commit revision f1bbb2a]
Author: Nao
Date: Sat, 21 Jan 2017 23:48:29 +0100
Stats: 2 files changed; +2 (insertions), -6 (deletions)
  • Fixed a couple of scandir calls to be more fault-tolerant. I think. (ManageAttachments.php, Post.php)
[Commit revision 7ae7331]
Author: Nao
Date: Tue, 24 Jan 2017 23:38:27 +0100
Stats: 1 file changed; +9 (insertions), -1 (deletion)
  • Closing a potential security hole when posting external links in a message. (Subs-BBC.php)
[Commit revision fa107a7]
Author: Nao
Date: Tue, 24 Jan 2017 23:42:23 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)
  • The '%3b' fix for URLs followed from e-mail clients (or even some weird spam bots following these links) was only applied in case semicolons are accepted by the server setup. It is also very much a problem for other setups, believe me I've gone through it, so I'm fixing it as well for them. (QueryString.php)
[Commit revision 7bd17c2]
Author: Nao
Date: Tue, 24 Jan 2017 23:45:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Preventing bots from seeing the skin selector page. As I mentioned in my previous commit, I've seen weird things where Baidu and another bot seem to develop romantic feelings towards any page with action=skin in its name. Maybe because of the name..? I don't know. You tell me. (Subs.php)
[Commit revision 933a87e]
Author: Nao
Date: Tue, 24 Jan 2017 23:50:31 +0100
Stats: 1 file changed; +8 (insertions), -3 (deletions)
  • Unix-based servers see similar folder names like 'Hello' and 'heLLo' as different names. This causes a problem when moving a folder from one server to another. Again, I LIVED THROUGH THAT HORROR. Media gallery folders will now be case insensitive, and simply go through adding a number to the folder name if it already exists, regardless of whether Linux etc. accepts it. Plus, you know I'm a sucker for writing cool geeky one-liners like this one. (Subs-Media.php)
[Commit revision ed2e23e]
Author: Nao
Date: Tue, 24 Jan 2017 23:51:42 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • PHP 7 doesn't like break commands outside of their natural habitat. Let's just assume the author of that library just meant to say 'return'. (getid3/getid3.lib.php)
[Commit revision 174ad41]
Author: Nao
Date: Tue, 24 Jan 2017 23:57:48 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Attempting to fix database errors that come up in MySQL 5.7+ because of strict mode being enabled by default. This is only the beginning, as thought pages also have the problem. (Aeva-Foxy.php)
  • Also a very, very minor bug fix when counting files. I'm not sure it even deserves its own description. You know, the line you're reading right now. Which, if you could just stop for a second and think about it, really says something about your priorities in life. You could be teaching kids how to make pasta, learning a new local language, reading up about agricultural politics in Thailand, and yet you chose to read a changelog about a minor bug in a library that no one uses because, let's be honest here, I'd probably make the world a better place by doing one of the aforementioned things. (Aeva-Subs-Vital.php)
198
The Pub / Re: Wedge&PHP 7
« on January 21st, 2017, 12:58 AM »
Well I've written some fixer code, which took about an hour, and then I looked into the bad queries and only found a couple, lol...
It's probably best to just fix them, yeah.
Only problem is that it'll make them slower!
It's really mostly in the media area (viewing an item), and the thought list. Two features that I wrote, lol :P
Updated queries: either I add an entry to GROUP BY (slower), or surround the SELECT version with ANY_VALUE() (slow, too, and not compatible with MySQL 5.6 and less), or surround with MIN(), which has unpredictable results and is even slower, but well, at least it'd work.
199
Features / Re: New revs
« on January 20th, 2017, 06:55 PM »
[Commit revision d0fe5c4]
Author: Nao
Date: Fri, 20 Jan 2017 18:55:04 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • scandir() returns a filename, not a fully qualified path, making the captcha code sketchy at best. Hey Pete, I miss you fixing your own bugs! ;) (Subs-Captcha.php)
200
The Pub / Re: Wedge&PHP 7
« on January 20th, 2017, 04:26 PM »
I'd just like to point out that the unfortunate server move for Wedge.org (in that it was planned long ago but not executed until the last minute and of course shit had to happen...), at least helped point out that Wedge isn't compatible with default installs of MySQL 5.7 and above, which set SQL mode to 'strict' by default.

I'm torn between fixing the faulty queries (which is looking like a headache to me) and just disabling strict mode for the current connection...
Only, it doesn't work for me. -_-

wesql::get('SELECT @@sql_mode') ==> returns NOTHING in Wedge... returns an actual string in phpMyAdmin. WUT?!
wesql::query('SET session sql_mode = "TRADITIONAL"', array('security_override' => true)); ==> does nothing. Strict mode still at work.

Anyone inspired by this..? Maybe it's a server problem.
The sad thing is, I just spent 2 hours on this crap, and I could have just used the time to fix the queries, because I know I'll do it eventually... -_-
201
Features / Re: New revs
« on January 19th, 2017, 11:57 AM »
[Commit revision c3dda12]
Author: C3realGuy
Date: Wed, 18 Jan 2017 21:41:25 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • check if ['page_title'] is set
[Commit revision 5522202]
Author: Nao
Date: Thu, 19 Jan 2017 11:57:20 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Merge pull request #52 from C3realGuy/fix_template_page_title
  • check if $context['page_title'] is set
202
The Pub / Re: Wedge&PHP 7
« on January 18th, 2017, 01:32 AM »
Quote from Freñiçh on December 31st, 2016, 09:45 AM
@Nao I know you almost on your one as developer,but what are the prospects for PHP 7 and Wedge sources
Not surprising, I did fix a few things I noticed were wrong when I switched to PHP 7 a few months ago. ;)
As for promises, I don't know what the competition is up to.
Quote
[1]
 1. B.t.w is there a way to donate some money...where's your donation button on the forum :hmm:
There's a donation system... I think in your profile, you can 'subscribe' to a donation thing.
Alternatively, you can simply send me money ;) (paypal at kyodai dot com).
203
Bug reports / Re: Not Open New Topic
« on January 17th, 2017, 09:56 PM »
Well then how did you open that topic...? :^^;:
204
Archived fixes / [CSS] Re: .postheader and previous/next post title looking bad
« on January 17th, 2017, 03:15 PM »
Very unlikely one would choose such a long name anyway...
205
Features / Re: New revs
« on January 16th, 2017, 11:55 PM »
[Commit revision f1557f9]
Author: Nao
Date: Mon, 16 Jan 2017 23:55:13 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Fixed PHP 7 incompatibility. Thank halojoy! (Class-DB.php)
[Commit revision 323986d]
Author: Nao
Date: Mon, 16 Jan 2017 23:55:31 +0100
Stats: 1 file changed; +13 (insertions), -6 (deletions)
206
Features / Re: New revs
« on January 16th, 2017, 11:51 PM »
[Commit revision 9b2ce98]
Author: C3realGuy
Date: Sat, 14 Jan 2017 12:36:08 +0100
Stats: 1 file changed; +13 (insertions), -6 (deletions)
  • Fixed possible sql injections in various functions in SSI.php.
  • Parameterized all limits.
[Commit revision 5c40f54]
Author: Nao
Date: Mon, 16 Jan 2017 23:51:45 +0100
Stats: 1 file changed; +13 (insertions), -6 (deletions)
  • Merge pull request #44 from C3realGuy/fix_ssi_sqlis
  • Tightened security in some SSI SQL queries.
207
Features / Re: New revs
« on January 16th, 2017, 11:48 PM »
[Commit revision fd22890]
Author: Nao
Date: Mon, 16 Jan 2017 23:48:14 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
  • Spacinazi! (index.css, sections.css)
208
Features / Re: New revs
« on January 16th, 2017, 11:46 PM »
[Commit revision f2f0a94]
Author: C3realGuy
Date: Sun, 15 Jan 2017 14:21:52 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)
  • quote bbc misbehaved when centered
[Commit revision f84a913]
Author: Nao
Date: Mon, 16 Jan 2017 23:46:27 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)
  • Merge pull request #47 from C3realGuy/fix_css_bbc_center_align
  • quote bbc misbehaved when centered
209
Features / Re: New revs
« on January 16th, 2017, 11:45 PM »
[Commit revision 3acb8b9]
Author: C3realGuy
Date: Mon, 16 Jan 2017 13:36:42 +0100
Stats: 1 file changed; +15 (insertions), -5 (deletions)
  • Login now looks better on small screens
  • Some .login rules got overwritten on screens
  •  smaller than 600px. Added !important flag to
  •  them.
  • Besides that the overflow rule looked
  •  bad.
  • And the password input missed the max-width
  •  rule.
  • On very small screens (<= 450px) we now
  •  break lines between dt and dd
[Commit revision 8a8596b]
Author: Nao
Date: Mon, 16 Jan 2017 23:45:31 +0100
Stats: 1 file changed; +15 (insertions), -5 (deletions)
  • Merge pull request #48 from C3realGuy/fix_css_login
  • Login looks bad on small screens
210
Archived fixes / [CSS] Re: Login looking bad on small screens
« on January 16th, 2017, 11:43 PM »
This looks sensible to me. I don't have time to test, but I'll try & merge it at the very least. ;)