Wedge

I'll be honest with you, this is one of those features that I *saw* Pete adding, and I thought "oh my God this is horrible..."
Because really, what happens is that it just makes everything harder if you want to add smileys & such, and modify code 'easily'. You now have to go through phpMyAdmin to do your thing. I tried it, I wasted hours over those things. The only 'good' thing is that you can quietly change your smiley code without having to care about not overwriting them by uploading a source file. Well, the thing is, I don't see anyone but the *developer* changing those. And I'm the dev. So it's just a bit odd overall.

If anything, I like the idea of reverting this. The reason Pete did that was for plugins to be able to easily add smileys. Err, really? I've never seen a plugin do that. At least not with Wedge's level of public awareness. And SMF does well without that. Considering that I added SMF-like mod support back into Wedge a couple years ago (and in a more elegant way!), it should be trivial to add smileys just using the regular old SMF way.

PS: I just have no time to look into this right now. I'm pretty busy with the new site. Plus I may be moving servers again in the future-- this one is so blazing fast, I love it, but there are so many configuration issues, it gives me nightmares... -_-

[Commit revision de8a0d3]
Author: C3realGuy
Date: Mon, 06 Feb 2017 22:47:59 +0100
Stats: 1 file changed; +4 (insertions), -2 (deletions)

• Prevent race condition in loadSource by writing to a temporary file

---

[Commit revision 57f28d6]
Author: Nao
Date: Tue, 07 Feb 2017 00:33:45 +0100
Stats: 1 file changed; +4 (insertions), -2 (deletions)

• Merge pull request #53 from C3realGuy/fix_rc_loadsource
• Prevent race conditions by flocking files on loadSource(). A likely fix to one of the oldest unimportant Wedge bugs ;)

[Commit revision 435c54a]
Author: Nao
Date: Sun, 05 Feb 2017 20:20:36 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

• Intrusion logger wouldn't check for request URI size before trying to insert it into a 255-char field... Usually this wouldn't be a problem, but MySQL exploits can hold entire scripts into the URL. Should probably increase size to 1024 chars or something, but it's already a huge table that never gets trimmed, so... No thanks. (Security.php)

---

[Commit revision 0e3578e]
Author: Nao
Date: Sun, 05 Feb 2017 20:22:13 +0100
Stats: 1 file changed; +3 (insertions), -5 (deletions)

• Slightly shorter default htaccess files, and a small fix for the expiry date. I don't remember why it was hardcoded. 20 years from install date should be enough... Although maybe it won't work. I don't really see any differences anyway. (OriginalFiles.php)

---

[Commit revision b1dd9cc]
Author: Nao
Date: Sun, 05 Feb 2017 20:23:36 +0100
Stats: 1 file changed; +2 (insertions), -4 (deletions)

• Logic error in a scheduled task query. I think I saw that in an older SMF fix that Pete didn't backport or maybe he had already left. I need some sleep. (ScheduledTasks.php)

---

[Commit revision e7c5413]
Author: Nao
Date: Sun, 05 Feb 2017 20:25:38 +0100
Stats: 3 files changed; +3 (insertions), -3 (deletions)

• Other minor fixes. I think they're also inspired by SMF fixes. Sorry, I didn't even notice I'd made these changes weeks ago. (Search2.php, Subs-Auth.php, Subs-Graphics.php)

---

[Commit revision 73538f9]
Author: Nao
Date: Sun, 05 Feb 2017 20:27:04 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)

• Oh, and that SMF fix too... (Subs-Post.php)
• And while I'm at it, a small improvement to an array length calculation. I know, it's petty, but it was hurting my eyes. (Aeva-Subs-Vital.php)

---

[Commit revision 143e827]
Author: Nao
Date: Sun, 05 Feb 2017 20:33:23 +0100
Stats: 3 files changed; +40 (insertions), -37 (deletions)

• Merged two functions related to PHP caching into cache_source_file(), which should be easier to understand. The fact that the function applies plugin mods and minifies the file is implied in its contents. Dunno about you, I find it cleaner. (Subs-CachePHP.php, Subs-Template.php, index.php)
• Also added some debug code to help catch the problem with the latest-news.js error. It's a very minor thing, but it's always better to redirect people to the homepage rather than just show them the page crash, anyway. Maybe remove the code later if I end up fixing the bug. (index.php)
• Note: don't forget to update your root folder's index.php file!

Hmmmmm... That might actually explain it! I was thinking of exclusive locks but couldn't figure out why this would only happen with ViewRemote.
I'll give it a look.

:edit: I don't know... The first thing that gets called is copy(). Meaning the file SHOULD exist, in its entirety, by the time a second AJAX request is triggered. Of course it could still be unsuccessfully copied or something.

From what I could gather, the error is partly reproduceable by just deleting the /gz/app/ViewRemote.php file. Wedge will then re-create it, and in the same second (but is that BEFORE or AFTER it was created..?!), you'll get the error.
I did that about half an hour ago...
And then tried again, and it worked just fine, lol.

Still a mystery.

I forgot about that. Just wanted to reply, 'nope'.
It only works if calling mysqli_query directly. Obviously when you JUST got the database connection, it's unlikely that query() actually has everything it needs to do a proper request. ;)

Good to know, I suppose!
Personally never got any problems. I don't even remember that Wedge uses SimpleXML... (??)
Not there any many plugins anyway, so I don't exactly spend my time in that section..!