Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
1621
Archived fixes / Re: Just emptied the boards table and got an error
« on February 4th, 2014, 11:13 AM »
To me, this looks like code that's only in the pseudo-board stuff, i.e. moderation quicklinks...
There's only one line to change, I just changed it because it's basically a free one, but... Well, at least it should fix your error at that line number.
It'll be in my next commit!
There's only one line to change, I just changed it because it's basically a free one, but... Well, at least it should fix your error at that line number.
It'll be in my next commit!
1622
Features / Re: Plugin revs
« on February 4th, 2014, 11:09 AM »
[Commit revision 4da8074]
Author: Nao (Signed-off)
Date: Tue, 04 Feb 2014 11:08:25 +0100
Stats: 2 files changed; +17 (insertions), -53 (deletions)
Author: Nao (Signed-off)Date: Tue, 04 Feb 2014 11:08:25 +0100
Stats: 2 files changed; +17 (insertions), -53 (deletions)
- Fixed We-Pinterest to, err... Actually work, I guess..? Honestly Pandos, I have no idea how the original plugin was supposed to work, but according to their API documentation, it looked like webmasters are supposed to add a Pinterest button manually for each of their images. Which wasn't done here. So I'm doing that Wedge-style, with jQuery goodies. I hope you don't mind. ;) (We-Pinterest-Main.template.php)
- Removed a dummy file... I guess! (We_Pinterest-Admin.php)
1623
Features / Re: What's the purpose of non-database sessions?
« on February 4th, 2014, 10:21 AM »
Let's not get ahead of ourselves... I want Wedge to work fine on LAMP and WAMP first, then we'll see about the rest... :P
1624
Importing into Wedge / Re: importer MySQL bug
« on February 4th, 2014, 10:19 AM »
It caught mine anyway ;)
SQL_ seems to have been removed somewhere before the release of v5.0 (since it can be seen in the 5.0 constant list in both spellings), and deprecated on 5.6... I guess.
So I should safely be able to commit the proposed fix. Once I'm done with breakfast, car duty, Himym, Brooklyn 99 and Uncle. In that order. :P
Fixed in the repo. Thanks for the report! I can confirm that it's a MySQL 5.6 change, and that MySQL 5.0 should be fine with this change -- I tracked down the rename to MySQL 4.0!!
SQL_ seems to have been removed somewhere before the release of v5.0 (since it can be seen in the 5.0 constant list in both spellings), and deprecated on 5.6... I guess.
So I should safely be able to commit the proposed fix. Once I'm done with breakfast, car duty, Himym, Brooklyn 99 and Uncle. In that order. :P
Posted: February 4th, 2014, 07:35 AM
Fixed in the repo. Thanks for the report! I can confirm that it's a MySQL 5.6 change, and that MySQL 5.0 should be fine with this change -- I tracked down the rename to MySQL 4.0!!
1625
Features / Re: What's the purpose of non-database sessions?
« on February 4th, 2014, 09:40 AM »
Oh, forgot to update on my case...
It actually worked again after I restarted Apache. (I forgot to do that.)
Was probably an issue with tmp permissions, then. It was read-only. I'm not sure why it managed to create session files but still bothered me with problems, but anyway... Solved.
It actually worked again after I restarted Apache. (I forgot to do that.)
Was probably an issue with tmp permissions, then. It was read-only. I'm not sure why it managed to create session files but still bothered me with problems, but anyway... Solved.
1626
Archived fixes / Re: accessing profile\forum profile causes 500 error
« on February 4th, 2014, 12:01 AM »
And I suppose your error log is empty...?
Anyway, it's midnight here, meaning I'm off duty! :P
Anyway, it's midnight here, meaning I'm off duty! :P
1627
Archived fixes / Re: Like and Reposts
« on February 3rd, 2014, 11:59 PM »
Done... I haven't tested (obviously), but I'm pretty sure that's the reason it didn't work. I can confirm I'd already had a similar problem on soft-merged posts, but that wasn't for likes, it was for something else. Anyway, that's how I had fixed it.
File uploaded here, so you can click the Like button on the post above, and see if it reproduces below it.
File uploaded here, so you can click the Like button on the post above, and see if it reproduces below it.
1628
Features / Re: New revs
« on February 3rd, 2014, 11:58 PM »
[Commit revision 13ce79c]
Author: Nao
Date: Mon, 03 Feb 2014 23:58:20 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Author: NaoDate: Mon, 03 Feb 2014 23:58:20 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- This should fix shadow Likes showing up on soft-merged posts when clicking Like on the first post in the list. (topic.js)
1629
Archived fixes / Re: Like and Reposts
« on February 3rd, 2014, 11:50 PM »
By repost you mean soft-merged posts..?
I believe Lorenzo mentioned this at some point, but we were unable to reproduce.
It's easy to try and reproduce on the New Revs topic, since it's 99% soft-merged from my posts, but I can't like my own posts, so I can't test.
I used to have a bug in that place, but I believe I fixed it (to be precise, it was a problem in JavaScript code), which is why I'm still unsure what the situation is. Does this systematically happen to you..?
I'll have a quick look again before I go to bed.
I believe Lorenzo mentioned this at some point, but we were unable to reproduce.
It's easy to try and reproduce on the New Revs topic, since it's 99% soft-merged from my posts, but I can't like my own posts, so I can't test.
I used to have a bug in that place, but I believe I fixed it (to be precise, it was a problem in JavaScript code), which is why I'm still unsure what the situation is. Does this systematically happen to you..?
I'll have a quick look again before I go to bed.
1630
The Pub / Re: Minimum PHP version?
« on February 3rd, 2014, 11:47 PM »
(Then it leaves us with only TE in the PHP < 5.3 list..? Thorsten, can you elaborate..?)
That's the thing with PHP: some (not all!) changes may be backwards-incompatible. For instance, SMF 2.0.7 is a (pretty underwhelming) patch to mostly improve PHP 5.5 support because the 'e' modifier in PCRE was deprecated, and SMF relied heavily on that. Wedge was patched to the same effect about six months ago (by the same person, I suspect :P). Without these patches, the software would still work, but you'd be getting warnings all over your page. Not cool.
Unfortunately, the reverse is also true... If you try using new PHP features, older versions will give you errors (which isn't a problem for Wedge, except *before* the install process begins, as I painfully noticed today.)
So, basically, whenever you're using software that hasn't been updated in a while (they don't always need to), you're better off staying on your current PHP. All hosts use different ways of allowing users to upgrade; some will force it on them (good luck for old software), and I'm fine with that but I understand it'd be upsetting for those. Some will provide a setting in their panel to choose your default PHP. And some will only enable it if you contact their support team.
So, no worries, it's all good.
That's the whole idea. Wedge forces users to upgrade their PHP to newer, safer versions. If you can update to PHP 5.5, then be my guest. I do all of my local testing on PHP 5.5 these days, so Wedge is fully compatible between PHP 5.3 and 5.5. (5.6 alpha was released recently, and it doesn't break any compatibility in Wedge, so you can add that to the list.)
That's the thing with PHP: some (not all!) changes may be backwards-incompatible. For instance, SMF 2.0.7 is a (pretty underwhelming) patch to mostly improve PHP 5.5 support because the 'e' modifier in PCRE was deprecated, and SMF relied heavily on that. Wedge was patched to the same effect about six months ago (by the same person, I suspect :P). Without these patches, the software would still work, but you'd be getting warnings all over your page. Not cool.
Unfortunately, the reverse is also true... If you try using new PHP features, older versions will give you errors (which isn't a problem for Wedge, except *before* the install process begins, as I painfully noticed today.)
So, basically, whenever you're using software that hasn't been updated in a while (they don't always need to), you're better off staying on your current PHP. All hosts use different ways of allowing users to upgrade; some will force it on them (good luck for old software), and I'm fine with that but I understand it'd be upsetting for those. Some will provide a setting in their panel to choose your default PHP. And some will only enable it if you contact their support team.
So, no worries, it's all good.
That's the whole idea. Wedge forces users to upgrade their PHP to newer, safer versions. If you can update to PHP 5.5, then be my guest. I do all of my local testing on PHP 5.5 these days, so Wedge is fully compatible between PHP 5.3 and 5.5. (5.6 alpha was released recently, and it doesn't break any compatibility in Wedge, so you can add that to the list.)
1631
Features / Re: New revs
« on February 3rd, 2014, 11:30 PM »
[Commit revision ef08042]
Author: Nao
Date: Mon, 03 Feb 2014 23:30:08 +0100
Stats: 7 files changed; +23 (insertions), -18 (deletions)
Author: NaoDate: Mon, 03 Feb 2014 23:30:08 +0100
Stats: 7 files changed; +23 (insertions), -18 (deletions)
- Finished patching with what I could find from 2.0.7 that made sense to backport. (Class-String.php, Login2.php, ManageMembergroups.php, Modlog.php, Subs-Members.php, Subs-Post.php)
- Cleaning up. (Subs-Auth.php)
- Putting thought into replacing tons of custom entity-replacement functions with generic ones, and then forgetting to remove the custom ones? Check. Adding comments about PHP 5.3 supporting the 'uses' keyword when it's actually 'use'? Check. Declaring and using a function with a neat typo in its name? Check. Providing a Themes.template.php~ file in all of their official download packages? Check. Definitely one of SMF's finest patches.
1632
Features / Language revs
« on February 3rd, 2014, 10:11 PM »
[Commit revision 32710a9]
Author: Nao (Signed-off)
Date: Mon, 03 Feb 2014 22:01:35 +0100
Stats: 7 files changed; +1 (insertion), -58 (deletions)
Author: Nao (Signed-off)Date: Mon, 03 Feb 2014 22:01:35 +0100
Stats: 7 files changed; +1 (insertion), -58 (deletions)
- Updated files with removal of maintenance. (Admin, ManageMaintenance, ManageSettings)
1633
Features / Re: On the desirability of automatic updates..?
« on February 3rd, 2014, 09:40 PM »
Well, the idea is to make it as simple as possible, otherwise I won't even be arsed to start work on it... :^^;:
1634
Features / Re: What's the purpose of non-database sessions?
« on February 3rd, 2014, 07:29 PM »
Still, bug there for me... :(
1635
Features / Re: New revs
« on February 3rd, 2014, 07:28 PM »
[Commit revision 35b0756]
Author: Nao
Date: Mon, 03 Feb 2014 19:23:14 +0100
Stats: 1 file changed; +40 (insertions), -46 (deletions)
Author: NaoDate: Mon, 03 Feb 2014 19:23:14 +0100
Stats: 1 file changed; +40 (insertions), -46 (deletions)
- A quick fix for PHP 5.2 (and less) users trying to install Wedge on their server. It will still refuse to install, but at least with this, they shouldn't be kicked out of the script with a syntax error. Lesson learned: never used the nowdoc format, even if it sounds cooler than heredoc and avoids having to escape single quotes. (OriginalFiles.php)