Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
1426
Features: Posts & Topics / Re: Auto-embedding
« on February 17th, 2014, 01:34 PM »
Didn't you say it was in item descriptions..? This one's a comment...
1427
Plugins / Re: Birthdays
« on February 17th, 2014, 01:33 PM »
At line 62, try replacing the array with:

Code: [Select]
$replacements = array(
'{REGARDS}' => $txt['regards_team'],
'{FORUMNAME}' => $mbname,
'{SCRIPTURL}' => SCRIPT,
);

Keep me posted!
Posted: February 17th, 2014, 11:55 AM

It probably won't work, I just looked an it's a strtr, so it won't replace stuff that has already been touched.
So, it'll probably have to be:

Code: [Select]
$replacements = array(
'{FORUMNAME}' => $mbname,
'{SCRIPTURL}' => SCRIPT,
'{REGARDS}' => str_replace('{FORUMNAME}', $mbname, $txt['regards_team']),
);

Still, if you could try the first one, that would be nice...
1428
Off-topic / Re: Video Encoding
« on February 16th, 2014, 11:48 PM »
I also use Handbrake. With MKV because then I can test the result while encoding, etc.
No interest in Vorbis stuff, personally. I respect it, but my media player won't play it, so it's useless for me... (I only re-encode files that I want to watch on my ageing, but otherwise still fantastic, PopCorn Hour player.)
1429
Archived fixes / Re: Pretty URLs causing 404s
« on February 16th, 2014, 11:47 PM »
I took the easy way out (i.e. the coward's way), by removing all traces of FallbackResource, but it really hurts... :lol:
Still, first impressions are more important than later optimizations.
1430
Off-topic / Re: Soundwave 2014
« on February 16th, 2014, 11:44 PM »
Quote from Bunstonious on February 16th, 2014, 01:33 PM
I tried Opera, but just couldn't get into it.

But it was quick that's for sure.
It was absolute heaven for customization geeks.
I could have it run exactly the way I wanted.

Also, I had over 1000 tabs in my Opera, on a machine with only 2GB of RAM, and it still worked fine.
Nowadays, well... After a hundred tabs, Opera starts crashing *my PC*. More precisely, my Aero interface gets destroyed and I have to quit Opera, then restart the window manager, then restart Opera. Sucks.
1431
Features: Posts & Topics / Re: Auto-embedding
« on February 16th, 2014, 11:42 PM »
I don't know.
I'm not even sure this bug still exists in Wedge, if anything.

You know, it's just a matter of calling, or not calling, a particular string transformation function, such as westr::safe, westr::htmlspecialchars, or something like nl2br...
Just need to reproduce, etc. I remember it happening before to me.

Maybe it's inconsistent for you because you're using a different browser..? Well, just a shot in the dark.
1432
Importing into Wedge / Re: Importer tool
« on February 16th, 2014, 11:36 PM »
[Commit revision b3807d4]
Author: Nao (Signed-off)
Date: Sun, 16 Feb 2014 23:36:24 +0100
Stats: 1 file changed; +4 (insertions), -6 (deletions)

  • Making it clearer that the importer isn't under the Wedge license, but rather the New BSD license. I could have forced it, but Thorsten wrote 95% of it, and I don't feel I'm entitled to choosing a license for something on which I only fixed bugs and didn't write anything of importance. (import.php)
1433
Features / Re: Plugin revs
« on February 16th, 2014, 11:28 PM »
[Commit revision ca1947f]
Author: Nao (Signed-off)
Date: Sun, 16 Feb 2014 22:45:39 +0100
Stats: 5 files changed; +5 (insertions), -5 (deletions)

  • birthday: Fixed incorrect link in language files. (Birthday-Admin.languages.php)
  • birthday: Fixed empty e-mails being sent... Defeating the whole point of that plugin, I guess..! (Birthday-Scheduled.php)
1434
Features / Re: Language revs
« on February 16th, 2014, 11:25 PM »
[Commit revision 1b60ac0]
Author: Nao (Signed-off)
Date: Sun, 16 Feb 2014 22:57:17 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Fixing an old URL in the German translation. I'm not sure what it's doing there, but... Whatever. (Help.german.php)
:edit: And I FINALLY understood why I was getting problems having some commits pulled... The API is very conservative when it comes to requests without a personal token. Apparently, just pushing to 3 repos at the same time was enough to turn it crazy. Or something... Anyway, I've re-created a new token and updated my settings with it, and it works again.
1435
Features / Re: Language revs
« on February 16th, 2014, 11:18 PM »
[Commit revision ef7dd0d]
Author: Nao (Signed-off)
Date: Sat, 08 Feb 2014 18:42:44 +0100
Stats: 9 files changed; +9 (insertions), -33 (deletions)

  • Feb 8 updates... (Admin, Errors, ManageMembers)
:edit: Re-pushed.
1436
Features / Re: New revs
« on February 16th, 2014, 11:09 PM »
[Commit revision 2f5c4ca]
Author: Nao
Date: Fri, 14 Feb 2014 16:48:48 +0100
Stats: 1 file changed; +18 (insertions), -0 (deletion)

  • Added helper functions query_all and query_rows to the wesql class; they'll just do the entire SQL communication process for you. If you have a quick query you want to do, sometimes it's not worth bothering with the free_result that comes after it, but I'm still a bit attached to that... (Class-DB.php)

[Commit revision a0abedc]
Author: Nao
Date: Fri, 14 Feb 2014 16:52:40 +0100
Stats: 1 file changed; +23 (insertions), -27 (deletions)

  • Simplified wedb's handling of default column values. Moved everything to a function, wedb::escape_default, that will also test whether the default is an integer. While it doesn't matter in most cases that you specify it as an int or a string, in the particular case of bit(1), it can actually break your query to have a '0' default, so... I had to do all this just to have a default 0 instead. (Class-DBHelper.php)

[Commit revision def73d3]
Author: Nao
Date: Fri, 14 Feb 2014 22:13:44 +0100
Stats: 1 file changed; +4 (insertions), -0 (deletion)

  • 'New' icons in topic pages didn't have enough margin on the left. (index.css)
  • Your gravatars were distorted in the sidebar, due to them having a fixed height, taking precedence over the CSS. Thanks to @Xarcell, @eurich and Bunstonious for the report! (index.css)
:edit: Another push that wasn't properly processed.
1437
Features / Re: New revs
« on February 16th, 2014, 11:07 PM »
[Commit revision c39fcc6]
Author: Nao
Date: Fri, 14 Feb 2014 16:37:50 +0100
Stats: 2 files changed; +30 (insertions), -33 (deletions)

  • In Subscription management pages, changing the day wouldn't update it in the select box (thanks to @live627 for the original PR). (ManagePaid.template.php)
  • In the same place, fixed day being reset to 1 if the last day was selected and the user switched to another month with the same number of days.
  • Also, a more generateDays() function.
  • Minor improvements to layout and bracket-nazi in ManagePaid pages. (ManagePaid.php, too.)
:edit: This is a re-submitted older push. GitHub now allows me to get a list of the pushes that failed to communicate with the GitHub plugin, so until I get a more solid version of the plugin out, this will have to do!
1438
Features / Re: New revs
« on February 16th, 2014, 11:01 PM »
[Commit revision 005ce99]
Author: Nao
Date: Sun, 16 Feb 2014 22:51:11 +0100
Stats: 6 files changed; +16 (insertions), -24 (deletions)

  • English typo. Also removing more file versions I forgot to commit. (ManageBans.english.php, Media.english.php, Security.english.php)
  • Saving milliseconds on scrolling in topic pages. I was hoping it would help make it possible to enable follow_me on mobile, but its performance still sucks on Android. I'm not sure why. (topic.js)
  • A more compact (and cleaner) version of the gravatar loading code. (Load.php)
  • Commenazi. (Subs.php)

[Commit revision 543289e]
Author: Nao
Date: Sun, 16 Feb 2014 22:56:21 +0100
Stats: 1 file changed; +5 (insertions), -23 (deletions)

  • As much as I love Apache 2.2.16+'s FallbackResource directive, it fails to work when your forum is installed in a sub-folder. If you want (slightly) better performance, you'll have to manually replace the Pretty URLs section of .htaccess with "FallbackResource /forum/index.php", where 'forum' is the name of your sub-folder, of course. Or just /index.php if it's not in a sub-folder. I'm not taking that chance again. (install/.htaccess)
  • Also, as a reminder... The .htaccess file really should be moved to your root folder. I don't want to move it to the root directly from the repo because you might want to edit the file for your own sake, so... Well, it's a complicated matter.
1439
Plugins / Re: Birthdays
« on February 16th, 2014, 10:42 PM »
That string has been in EmailTemplates for a long time, and certainly before Wedge went public, so it would be surprising that it's a problem with file versions...
Just make sure all language files are where they should be, really... ;)

Maybe a problem with the UK version, I don't know..? I know EmailTemplates is a 'special' language file, so...
1440
Plugins / Re: Birthdays
« on February 16th, 2014, 10:02 PM »
@Pandos, why is it that this link (which hasn't been in the Wedge English files for probably years) is also using the old action name..? (action=.xml, instead of action=feed, also renamed years ago.)

Again, I don't mind AT ALL if you took the original SMF and adapted them to Wedge. Seriously, it's how I would have done it, because it's such a huge amount of work for just one person. I spent 4 weeks retranslating SMF in French back in 2010, and even then I was just re-reading the existing translation and fixing errors here and there, and even now I still discover errors in the old translation. I don't know how you managed to do it.

@Farjo, this doesn't make sense to me... That string is in EmailTemplates.english.php, and the plugin DOES load that file (loadLanguage('EmailTemplates'), line 23)... Any ideas?