Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
136
Features / Re: New revs
« on March 18th, 2017, 11:44 AM »
[Commit revision 4b63508]
Author: C3realGuy
Date: Thu, 09 Feb 2017 12:46:03 +0100
Stats: 1 file changed; +857 (insertions), -63 (deletions)
[Commit revision 5c077e8]
Author: Nao
Date: Sat, 18 Mar 2017 11:44:36 +0100
Stats: 1 file changed; +857 (insertions), -63 (deletions)
Date: Thu, 09 Feb 2017 12:46:03 +0100
Stats: 1 file changed; +857 (insertions), -63 (deletions)
- BBCodes are now hardcoded in Subs-BBC again.
- Still loading bbcodes from plugins from database.
- Should increase performance.
[Commit revision 5c077e8]
Date: Sat, 18 Mar 2017 11:44:36 +0100
Stats: 1 file changed; +857 (insertions), -63 (deletions)
- Merge pull request #58 from C3realGuy/dev_bbc_move_only_bbc_to_disk
- BBCodes are now hardcoded in Subs-BBC again.
137
Features / Re: New revs
« on March 18th, 2017, 11:27 AM »Updated a date and position. ;)
Least I could do, really! I'd just forgotten about that file...
138
Bug reports / Couple things to look into...
« on March 18th, 2017, 11:25 AM »
I really, really don't have time these days, so can anyone (okay, CerealGuy) look into these potential issues?
- DoLogin() in Subs-Login accesses we::$user['ip'] (previously $user_info['ip']). I couldn't find any reference to we::$user being set during the login process, leading me to believe maybe we should use $user_settings everywhere across that short function. Can you find one reference to it..?
- On LT I've been marking topics as unread and noticed the number of unread counts was higher than before I reached said topic. I specifically rewrote the unread system to make sure it would keep track of it. Can you look into it and determine if I screwed up something..? :edit: Just tried on your last post on the BBC topic, and voilà, 9 unread posts... I definitely screwed something up then, because I'm positive that it used to work.
Thanks!
- DoLogin() in Subs-Login accesses we::$user['ip'] (previously $user_info['ip']). I couldn't find any reference to we::$user being set during the login process, leading me to believe maybe we should use $user_settings everywhere across that short function. Can you find one reference to it..?
- On LT I've been marking topics as unread and noticed the number of unread counts was higher than before I reached said topic. I specifically rewrote the unread system to make sure it would keep track of it. Can you look into it and determine if I screwed up something..? :edit: Just tried on your last post on the BBC topic, and voilà, 9 unread posts... I definitely screwed something up then, because I'm positive that it used to work.
Thanks!
139
Features / Re: New revs
« on March 13th, 2017, 10:41 PM »
[Commit revision 38d17d4]
Author: Nao
Date: Mon, 13 Mar 2017 22:40:48 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
Date: Mon, 13 Mar 2017 22:40:48 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- Updated a date and position. ;) (contributors.txt)
140
Bug reports / [Security] Re: BBCode in SQL Database
« on March 13th, 2017, 10:33 PM »
I'm currently very busy adding a large feature to Lestrade's (see over there, it's being discussed), so I really don't have the time for this I'm afraid.
Did you check that all your spaces are there, around dots? Like, 'Hello'.$world; should be 'Hello' . $world; for instance. (I'm only saying because that's the thing I noticed in your previous pull request.)
Wysiwyg: feel free to make a poll on wedge.org about overall use (not use by forum admins but by their communities...), for now I don't see much of a reason to remove it entirely, maybe add an option to disable it... I don't know.
The rest: okay, I still haven't read your mammoth post..... :sob:
Did you check that all your spaces are there, around dots? Like, 'Hello'.$world; should be 'Hello' . $world; for instance. (I'm only saying because that's the thing I noticed in your previous pull request.)
Wysiwyg: feel free to make a poll on wedge.org about overall use (not use by forum admins but by their communities...), for now I don't see much of a reason to remove it entirely, maybe add an option to disable it... I don't know.
The rest: okay, I still haven't read your mammoth post..... :sob:
141
Features / Re: Language revs
« on March 13th, 2017, 10:30 PM »
(Used 'squash' for the first time on github, looks like it's working fine... Your commit is directly in Wedge, without an extra merge commit. Hopefully it doesn't break your own repo...?)
142
Features / Re: Language revs
« on March 13th, 2017, 10:29 PM »
[Commit revision d920738]
Author: C3realGuy
Date: Mon, 13 Mar 2017 22:29:14 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)
Date: Mon, 13 Mar 2017 22:29:14 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)
- Update Notifications.german.php (#33)
143
Features / Re: New revs
« on March 13th, 2017, 10:27 PM »
[Commit revision 113d4e4]
Author: C3realGuy
Date: Sat, 11 Mar 2017 16:59:35 +0100
Stats: 6 files changed; +17 (insertions), -10 (deletions)
[Commit revision 2999165]
Author: C3realGuy
Date: Sun, 12 Mar 2017 17:04:11 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision dc72afe]
Author: Nao
Date: Mon, 13 Mar 2017 22:27:11 +0100
Stats: 6 files changed; +17 (insertions), -10 (deletions)
Date: Sat, 11 Mar 2017 16:59:35 +0100
Stats: 6 files changed; +17 (insertions), -10 (deletions)
- Allow setting the max length a subject should have.
- If subject is too long, yield an error.
- Introduced $settings['max_subjectLength'].
- Introduced $txt['error_subject_too_long'] in Errors.english.php
- Introduced $txt['max_subjectLength'] and $txt['max_subjectLength_zero']
- in ManagePosts.english.php
- Also using vsprintf for errors now to support more than one argument.
- Before the limit for subject size was inconsistent. For editor it was
- 80, for Post/Post2.php it was 100. We now use the same limit for all.
- (ManagePosts.php, Post.php, Post2.php, Post.template.php, Errors.english.php, ManagePosts.english.php)
[Commit revision 2999165]
Date: Sun, 12 Mar 2017 17:04:11 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Subject => subject
[Commit revision dc72afe]
Date: Mon, 13 Mar 2017 22:27:11 +0100
Stats: 6 files changed; +17 (insertions), -10 (deletions)
- Merge pull request #59 from C3realGuy/dev_max_subject_length
- Allow setting the max length a subject should have.
144
Features / Re: New revs
« on March 11th, 2017, 11:32 AM »
[Commit revision 1fcd685]
Author: Nao
Date: Sat, 11 Mar 2017 11:22:15 +0100
Stats: 2 files changed; +5 (insertions), -5 (deletions)
[Commit revision ded9e47]
Author: Nao
Date: Sat, 11 Mar 2017 11:32:23 +0100
Stats: 1 file changed; +14 (insertions), -0 (deletion)
Date: Sat, 11 Mar 2017 11:22:15 +0100
Stats: 2 files changed; +5 (insertions), -5 (deletions)
- Updated $can_filter to include Firefox 35+ and Android KitKat browser, and $can_sticky to include Chrome 56+ (AT LAST!) and remove the small hack in my 'follow me' implementation. (common.css, sections.css)
- I'm also considering removing the entire follow_me function from topic.js... Its main problem is that it makes it hard (if not impossible?) to change the layout of avatar boxes. The only browser that need it now are IE 8 and above. I wanna say I don't care about them... I don't know.
[Commit revision ded9e47]
Date: Sat, 11 Mar 2017 11:32:23 +0100
Stats: 1 file changed; +14 (insertions), -0 (deletion)
- Not sure this'll work 100% because I neither have opcache nor APC installed on my current test server, but apparently it's a good thing to invalidate stuff. Needs testing. (Subs-Cache.php)
145
Bug reports / Re: Looks in IE and Edge.
« on March 7th, 2017, 12:41 AM »
Edge has so many features that aren't implemented yet (https://developer.microsoft.com/en-us/microsoft-edge/platform/status/) that I don't consider them on the same level as Chrome or Firefox. In fact I'm pretty sure many people at Microsoft were considering switching IE to Webkit/Blink, but the W3C would really rather have as many different HTML rendering engines as possible (they were already quite pissed off that Opera gave up on Presto...)
Plus Edge doesn't really have the usage stats it's purported to have.
Opera Chromium + Sidewise extension are really the best for a power user.
PS: I don't remember having to use something else than Chromium to open a site in the last 3-4 years.
Plus Edge doesn't really have the usage stats it's purported to have.
Opera Chromium + Sidewise extension are really the best for a power user.
PS: I don't remember having to use something else than Chromium to open a site in the last 3-4 years.
146
Features / Re: New revs
« on March 6th, 2017, 10:40 PM »
[Commit revision 3c2eb2f]
Author: Nao
Date: Mon, 06 Mar 2017 22:40:06 +0100
Stats: 3 files changed; +7 (insertions), -7 (deletions)
Date: Mon, 06 Mar 2017 22:40:06 +0100
Stats: 3 files changed; +7 (insertions), -7 (deletions)
- I'm reverting an old commit from September 16, 2014 that 'fixed' IE11 not being able to load compressed CSS/JS. The problem seems to be linked to the server, I need to test it more. I may re-revert this later, I don't know yet. Needs some testing from other parties. (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)
147
Bug reports / Re: Looks in IE and Edge.
« on March 6th, 2017, 06:48 PM »
Fixed. Wasn't a problem with Wedge, but with a quick hack I wrote for Lestrade's and backported to Wedge.org (the website) by mistake.
The original problem was IE11 was unable to load compressed CSS/JS files on the new server I had. I managed to make it work in Lestrade's, but the actual solution was to remove gz extensions from the 'static' file list in the nginx configuration (it's a reverse-proxy server). Nginx used to catch gz files and directly serve them with their original MIME type, when it was supposed to pass them to Apache, which through the htaccess file was setting the MIME type to the correct one (i.e. text files).
I had the nginx config file fixed, so the fix was no longer needed. But I forgot to remove it, so IE11 kept serving these files uncompressed. And because of a final mixup between two fixes, I ended up serving uncompressed extensions with compressed content, so it broke the site when I updated it last night.
Phew.
BTW, IE still sucks hard. :P
I'm not even adding support for Edge... After all Microsoft themselves are marking it as Chrome-compatible. So, I'll just let them fix everything by themselves, to me, Edge is an older Chrome build and that's how I'm treating it. (And probably how they want others to treat it, because let's face it, anything is better than being treated as a "newer IE".)
PS: I just found out that my first IE11 fix for this was from late 2014, so it couldn't be linked to the new server. Uh. I'm at a loss here. I'll just revert that revision (c3c77a3b22223eedce97f18b7ad719437b3dc154), and hopefully it works everywhere.
The original problem was IE11 was unable to load compressed CSS/JS files on the new server I had. I managed to make it work in Lestrade's, but the actual solution was to remove gz extensions from the 'static' file list in the nginx configuration (it's a reverse-proxy server). Nginx used to catch gz files and directly serve them with their original MIME type, when it was supposed to pass them to Apache, which through the htaccess file was setting the MIME type to the correct one (i.e. text files).
I had the nginx config file fixed, so the fix was no longer needed. But I forgot to remove it, so IE11 kept serving these files uncompressed. And because of a final mixup between two fixes, I ended up serving uncompressed extensions with compressed content, so it broke the site when I updated it last night.
Phew.
BTW, IE still sucks hard. :P
I'm not even adding support for Edge... After all Microsoft themselves are marking it as Chrome-compatible. So, I'll just let them fix everything by themselves, to me, Edge is an older Chrome build and that's how I'm treating it. (And probably how they want others to treat it, because let's face it, anything is better than being treated as a "newer IE".)
PS: I just found out that my first IE11 fix for this was from late 2014, so it couldn't be linked to the new server. Uh. I'm at a loss here. I'll just revert that revision (c3c77a3b22223eedce97f18b7ad719437b3dc154), and hopefully it works everywhere.
148
Bug reports / Re: Looks in IE and Edge.
« on March 6th, 2017, 06:03 PM »
Weird. Looks like a problem with the user agent string. I'll look into it.
149
Features / Re: New revs
« on March 6th, 2017, 12:07 AM »
[Commit revision f978581]
Author: Nao
Date: Mon, 06 Mar 2017 00:07:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Mon, 06 Mar 2017 00:07:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- We don't really need to hide the 'Settings' text link from notification popups if there's no 'Mark read' link next to it. There's enough space, even on mobile. (Notifications.template.php)
150
Features / Re: Language revs
« on March 6th, 2017, 12:00 AM »
[Commit revision 26f4386]
Author: Nao
Date: Sun, 05 Mar 2017 23:56:18 +0100
Stats: 5 files changed; +7 (insertions), -5 (deletions)
Date: Sun, 05 Mar 2017 23:56:18 +0100
Stats: 5 files changed; +7 (insertions), -5 (deletions)
- Language updates from the last big Wedge commit. (Notifications, index)