Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
1321
Archived fixes / Re: PHP Fatal error
« on February 26th, 2014, 06:01 PM »
Safest way to do that:
Install git on your machine... (Or even GitHub for Windows, if you're not planning to do a lot of heavy modifications).
Clone/fork the Wedge repo(s) onto your hard drive.
When you see changes were made, just pull again from the remote repo.
Only the changed files will get their last modified date, err... Modified. I know, I'm repeating myself.
This is how I'm (manually) updating wedge.org, by the way. :P My FTP client has a shortcut to look for modified files, and only upload those.
Install git on your machine... (Or even GitHub for Windows, if you're not planning to do a lot of heavy modifications).
Clone/fork the Wedge repo(s) onto your hard drive.
When you see changes were made, just pull again from the remote repo.
Only the changed files will get their last modified date, err... Modified. I know, I'm repeating myself.
This is how I'm (manually) updating wedge.org, by the way. :P My FTP client has a shortcut to look for modified files, and only upload those.
1323
Features / Re: New revs
« on February 26th, 2014, 05:43 PM »
[Commit revision 6aa5451]
Author: Nao
Date: Wed, 26 Feb 2014 17:42:51 +0100
Stats: 2 files changed; +21 (insertions), -4 (deletions)
Author: NaoDate: Wed, 26 Feb 2014 17:42:51 +0100
Stats: 2 files changed; +21 (insertions), -4 (deletions)
- Some extra voodoo magic to make select boxes much more usable in long and/or wide lists, such as the infamous timezone selector, on which I did most of my testing. You'll never find a worse select box than this one, I promise. (sbox.js, index.css)
1324
Archived fixes / Re: List v1
« on February 25th, 2014, 10:07 PM »
Even after the merge, if your newest post is too old you'll have the same problem.
I would suggest opening a new topic and nobody posts to it so that you can merge easily.
Ideally though I should give you a pass through to edit any of your posts. I can make you a mod somewhere... like here ;) would it work for you?
I would suggest opening a new topic and nobody posts to it so that you can merge easily.
Ideally though I should give you a pass through to edit any of your posts. I can make you a mod somewhere... like here ;) would it work for you?
1325
Archived fixes / Re: My latest error...
« on February 25th, 2014, 10:03 PM »
Yes sorry forgot to post about it ;)
This only happened on some 404 errors, hence the time it took to notice it. Thanks!
This only happened on some 404 errors, hence the time it took to notice it. Thanks!
1326
Features / Re: New revs
« on February 25th, 2014, 07:47 PM »
[Commit revision 7e84d56]
Author: Nao
Date: Tue, 25 Feb 2014 19:47:36 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Author: NaoDate: Tue, 25 Feb 2014 19:47:36 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Guest error. (Class-System.php)
1327
Archived fixes / Re: Date format is incorrect
« on February 25th, 2014, 07:45 PM »
So... What do I do? Looks like the alternative isn't popular.
1328
Archived fixes / Re: List v1
« on February 25th, 2014, 07:44 PM »
But you can hard-merge two posts and then edit the first one out... I think ;)
1329
Features / Re: New revs
« on February 25th, 2014, 07:27 PM »
[Commit revision 9859c51]
Author: Nao
Date: Tue, 25 Feb 2014 18:41:46 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 523347b]
Author: Nao
Date: Tue, 25 Feb 2014 18:43:01 +0100
Stats: 1 file changed; +9 (insertions), -8 (deletions)
[Commit revision 3b958f2]
Author: Nao
Date: Tue, 25 Feb 2014 18:46:12 +0100
Stats: 1 file changed; +3 (insertions), -2 (deletions)
[Commit revision 323f8b0]
Author: Nao
Date: Tue, 25 Feb 2014 19:19:34 +0100
Stats: 2 files changed; +11 (insertions), -3 (deletions)
Author: NaoDate: Tue, 25 Feb 2014 18:41:46 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Undefined index on 404 errors. (QueryString.php)
[Commit revision 523347b]
Author: NaoDate: Tue, 25 Feb 2014 18:43:01 +0100
Stats: 1 file changed; +9 (insertions), -8 (deletions)
- There's a strong chance MID isn't defined at the time it's tested against in is_not_banned. Never generated an error for me, but better safe than sorry... (Security.php)
[Commit revision 3b958f2]
Author: NaoDate: Tue, 25 Feb 2014 18:46:12 +0100
Stats: 1 file changed; +3 (insertions), -2 (deletions)
- Made title classes a bit less horrible in Wine. I really need to rework this skin... (Wine/extra.css)
[Commit revision 323f8b0]
Author: NaoDate: Tue, 25 Feb 2014 19:19:34 +0100
Stats: 2 files changed; +11 (insertions), -3 (deletions)
- Ah, the serialize bug... I've worked hard on this. I reproduced the original conditions. I was completely unable to trigger it again. It looks like I'm the only one who got affected by it, so... I'll be praying that it doesn't happen again, and in the meantime, I'm adding a solution that seems to work if the bug happens again. I don't want to waste any more time on this when I have so much work left to do. (Class-System.php)
- Commenazi. (Upgrade.php)
1330
Features / Re: Plugin revs
« on February 25th, 2014, 11:15 AM »
[Commit revision 09cafcb]
Author: Nao (Signed-off)
Date: Tue, 25 Feb 2014 11:15:00 +0100
Stats: 1 file changed; +1 (insertion), -13 (deletions)
Author: Nao (Signed-off)Date: Tue, 25 Feb 2014 11:15:00 +0100
Stats: 1 file changed; +1 (insertion), -13 (deletions)
- Skin selector was broken for guests. New code is now also shorter for guests, which means less bandwidth use. Yayz. (skin_selector/SkinSelector.php)
1331
Features / Re: New revs
« on February 25th, 2014, 11:14 AM »
[Commit revision c690ad4]
Author: Nao
Date: Tue, 25 Feb 2014 11:13:54 +0100
Stats: 2 files changed; +20 (insertions), -0 (deletion)
Author: NaoDate: Tue, 25 Feb 2014 11:13:54 +0100
Stats: 2 files changed; +20 (insertions), -0 (deletion)
- The skin selector wasn't working for guests since I removed theme support. Used the opportunity to improve it by putting the skin setting into a cookie for guests, and removing the cookie when logging in. (Class-System.php, Themes.php)
1332
Archived fixes / Re: PHP Fatal error
« on February 25th, 2014, 12:30 AM »Edit: This was the last "reported" revision that I can see you posted - dated 19/2/14: http://wedge.org/pub/feats/6108/new-revs/msg294224/#msg294224
I'm assuming that testers don't want to bother with file versions and just overwrite everything every time they update.
If you want to update files one by one, you should rely on the commit list, rather than my manual changelogs, because I don't always list all files. I only list them for *my* own convenience when I want to find thematic groupings, but not as an exhaustive listing of all files you should update. For that, you can also just click the '6 files changed' link, and indeed see which files were modified.
As for the rest... See Farjo's last post!
1333
Features / Re: Stuck on a programming model...
« on February 25th, 2014, 12:18 AM »It's because MySQL's UTF-8 before 5.5 is "fake UTF-8"? It only supports 3 bytes per character max., so there is no way to directly store unicode characters plane in MySQL. :geek:
So we should lift up to 5.5?
My test strings just have regular accents that are encoded to 2 bytes in UTF8. 4-byte chars in UTF8 are, AFAIK, exclusively for CJK languages. (Especially Chinese Traditional & Simplified -- probably represents about 80.000 characters.)
This will bring the advantage of using "real UTF-8 support" (so you should not bother with serialize errors) and TEXT are also stored inline. :)
And from my personal point of view:
MySQL is almost at the level where InnoDB can perform fulltext search and MyISAM will be almost completely outdated and Wedge is the next generation forum software. So why .... ?
Okay, so I've done another test by turning my TEXT field into a BLOB and then into a VARCHAR(65535)... And, it didn't change anything. I'm still getting the same contents. Perhaps the problem is happening at store time, rather than retrieve time, I don't know.
I'm still at a loss about what I should do. Remain with all serialize() calls (because there are TONS of theme in the Wedge codebase, and they all work, just look at the number of serialized items stored in $settings!), or convert everything to json strings (shorter, a bit slower to load)..?
Posted: February 25th, 2014, 12:09 AM
Crappy crap...
Did another run of my original code, the one that caused the bug...
Guess what. It worked just fine this time. >_<
So... I've got to suppose, it's not related to the serializing process at all. Uh... Then why did it fail for Wedge.org..?
Oh, maybe it's working on my local install, but not on the Wedge.org MySQL database... I don't know. Maybe it's not set up as UTF, or something.
1334
Features / Re: Stuck on a programming model...
« on February 24th, 2014, 08:21 PM »
Okay, so... It would appear that unserialize(utf8_decode($user_settings['data'])) will actually fix the charset, and properly decode the string. *THEN*, I have to call utf8_encode on the array to make it work at showtime. Seriously, it's overkill. But it fixes the unserializing, so I've added it (temporarily at least) as a 'fallback' if the function fails.
I'm frankly a bit upset that I have to do this. I have no idea why it causes issues, when other fields don't seem to do the same... :-/
I'm frankly a bit upset that I have to do this. I have no idea why it causes issues, when other fields don't seem to do the same... :-/
1335
Features / Re: Stuck on a programming model...
« on February 24th, 2014, 07:55 PM »
Yes, but the data field is not always loaded. It can take a lot of space, so if you do a table scan on the members table, and data is inline, it'll be less efficient.