Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
1291
Archived fixes / Re: APC Cache Errors
« on February 28th, 2014, 12:37 PM »
Quote from Pandos on February 28th, 2014, 08:59 AM
It's a bug in APC. Latest version of APC resolved the problem.
Are you sure..?!
This sounds more like the cache_get_data bug that I added last month, and only recently fixed when I actually started to make use of the cache_put_data helper... (I'd inverted the last two parameters.)
1292
Features / Re: New revs
« on February 28th, 2014, 09:21 AM »
[Commit revision 11bf076]
Author: Nao
Date: Fri, 28 Feb 2014 09:20:28 +0100
Stats: 1 file changed; +5 (insertions), -2 (deletions)

  • If your FTP client is stupid enough to upload LF files to a Linux server in CRLF mode (apparently, some do this by default, or you may do it "by mistake"), the end result was that events were never delayed, and it caused trouble in many situations. Wedge will now account for this. Detecting this bug was like being Holmes for an hour or two. (Subs-Template.php)
1293
Off-topic / Re: Microsoft Surface RT
« on February 27th, 2014, 11:24 PM »
Ah, Microsoft... If it didn't exist, we'd have to invent them..... ;)
1294
Importing into Wedge / Re: SMF 2 to Wedge importer errors
« on February 27th, 2014, 11:17 PM »
Quote from TE on February 27th, 2014, 09:10 PM
message_labels is a field in SMF but is it still available in Wedge?
Nope...
Quote
If not there needs to be a
Code: [Select]
<preparsecode>
unset($row['message_labels']);
</preparsecode>
somewhere for that step.
And it's there. Along with all SMF fields that were moved to the data field... :-/
Quote
Sorry, I'm ultra-busy at the moment, my wife's pregnant and the baby is coming soon ^_^
Hey, congratulations!
When is she due?
1295
Off-topic / Re: Basic help with GitHub please
« on February 27th, 2014, 08:59 PM »
Quote from Pandos on February 27th, 2014, 08:33 PM
IMHO files edited directly are not signed-off?
Ah yes, that was the main reason...
Although language files are in a MIT repo, so it's not much of a problem, but I'd still rather have everyone sign off.
(Actually, I'm currently considering starting to sign-off my commits for the Wedge repo as well... Yeah, why not? It's just an extra click...)
1296
Off-topic / Re: Basic help with GitHub please
« on February 27th, 2014, 08:19 PM »
Quote from Farjo on February 27th, 2014, 08:01 PM
I've recommitted but I think it's worse - 4 commits instead of 2. It just doesn't do what I want it to!!

If it's not right I'll have a look tomorrow, I'm too fed up with it for tonight.

Given that language guys may not be that technical it may be a tall order to ask them to go through all that.
I agree, but I don't have any better alternatives to offer you for now.
The guys at Elk have another tool for translations, but I'm not a fan of separating language translations from code commits.

Anyway, yes, I guess you could still edit files directly at github.com, but it's not very practical in the long run. It's only good for small fixes...
(Why did we decide you shouldn't do that, already..?)
1297
Features / Re: New revs
« on February 27th, 2014, 06:17 PM »
[Commit revision 14d7adc]
Author: Nao
Date: Thu, 27 Feb 2014 18:17:29 +0100
Stats: 1 file changed; +3 (insertions), -6 (deletions)

  • Various fixes to the header CSS: notifications should be vertically aligned along with the rest (should only be noticeable in Wine), guest mode in Wilde should no longer break the #upper_section layout is no languages are selectable, and finally, the language select box had some leftover CSS from its pre-select box era. (index.css)
1298
Off-topic / Re: Basic help with GitHub please
« on February 27th, 2014, 06:12 PM »
Hey, I have no problems helping out on things that I myself had to learn the hard way... Sometimes, a tutorial is just what you need.
What I suck at, though, is turning my hints into proper documentation and tutorials... I believe, it's called the developer syndrome. :P

You can switch branches by using the 'Switch/Checkout' menu entry.
However, if you also have msysgit installed, it should have added a few other entries to your menu, so just right-click your repo's root folder, find 'Git Branch' (NOT in the TortoiseGit menu!), and then choose your desired branch!
1299
Archived fixes / Re: Invalid Argument Error
« on February 27th, 2014, 06:09 PM »
Yeah, I was working on fixing it, was hoping nobody would have noticed... :lol:

It was due to a specific CSS file that's requested on wedge.org but not on my local install, so I did my tests locally, everything worked, then I uploaded here, and went to play a Spider Solitaire game for relaxing... Then came back, and woops! Commit done in the process ;)

PS: edited your attachment out. Remember, please, no hard paths in text or images... I know it won't change a thing, but I'm a bit strict about that!
1300
Features / Re: New revs
« on February 27th, 2014, 06:07 PM »
[Commit revision 4b1f623]
Author: Nao
Date: Thu, 27 Feb 2014 18:07:21 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Typecasting oversight. (Subs-Cache.php)
1301
Features / Re: Plugin revs
« on February 27th, 2014, 05:56 PM »
[Commit revision a6b626c]
Author: Nao (Signed-off)
Date: Thu, 27 Feb 2014 17:56:38 +0100
Stats: 2 files changed; +7 (insertions), -1 (deletion)

  • This may not be too sexy, but this is how it works. I'm adding the Wedge.org plugin's CSS integration into the main CSS file, as a sample of what the latest Wedge commit can now do. It saves an extra HTTP request, and embeds the Facebook icon directly within the main CSS. It only adds 150 bytes or so, so don't you start complaining! ;) (wedge.org/WedgeDotOrg.php, wedge.org/wedge.org.css)
1302
Features / Re: New revs
« on February 27th, 2014, 05:53 PM »
[Commit revision 159f4bc]
Author: Nao
Date: Thu, 27 Feb 2014 17:53:06 +0100
Stats: 1 file changed; +21 (insertions), -2 (deletions)

  • Added ability to provide an absolute path to a CSS file for add_css_file, rather than just a prefix to look for in skin folders. The absolute path will be concatenated last, allowing for plugins to override existing CSS, whatever the skin you're currently using. (Subs-Cache.php)
  • Added two new CSS array variables: $plugins['plugin_name'] and $plugins_dir['plugin_name'] will both redirect to, respectively, plugin_name's URL and plugin_name's path. (Subs-Cache.php)
  • Yes, of course the goal is to (finally) allow plugins to add custom CSS to the main CSS file, avoiding an extra HTTP request or inline CSS when all you want is to add a couple of lines that should be run on all pages. Plus, I never liked that add_plugin_css_file function anyway. ;)
1303
Features / Re: Plugin revs
« on February 27th, 2014, 05:11 PM »
[Commit revision 37a53c5]
Author: Nao (Signed-off)
Date: Thu, 27 Feb 2014 17:10:52 +0100
Stats: 3 files changed; +2 (insertions), -2 (deletions)

  • After years of allowed use, Facebook removed their icon from the strange URL I had in the Wedge.org plugin, so I made my own to replace it. Also renamed the plugin to something more sensible. (wedge.org/*)
1304
Archived fixes / Re: Date format is incorrect
« on February 27th, 2014, 04:08 PM »
And we sure do! ;)
1305
Importing into Wedge / Re: SMF 2 to Wedge importer errors
« on February 27th, 2014, 03:59 PM »
Just what I feared!
But enabling them could also bring its lot of support requests...