Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
121
Features / Re: New revs
« on March 20th, 2017, 03:40 PM »
[Commit revision d9f6873]
Author: Nao
Date: Mon, 20 Mar 2017 15:40:19 +0100
Stats: 1 file changed; +12 (insertions), -19 (deletions)
Date: Mon, 20 Mar 2017 15:40:19 +0100
Stats: 1 file changed; +12 (insertions), -19 (deletions)
- Simplified 'test' strings in the BBCode list. Looks like when the strings were originally moved to the database, extra useless backslashes were added to them. (Subs-BBC.php)
122
Bug reports / Re: No referral to the secure connection https://wedge.org/
« on March 20th, 2017, 03:17 PM »
Thanks, your last bug report was addressed. ;)
123
Features / Re: New revs
« on March 20th, 2017, 12:28 AM »
[Commit revision e5868b1]
Author: Nao
Date: Mon, 20 Mar 2017 00:28:38 +0100
Stats: 1 file changed; +77 (insertions), -77 (deletions)
Date: Mon, 20 Mar 2017 00:28:38 +0100
Stats: 1 file changed; +77 (insertions), -77 (deletions)
- Fixed lightness value being treated is a 0-1 float instead of a 0-100% value. (Class-CSS.php)
- Changed all array()'s to [] while I was at it. Looks so cool. But, yeah, dream on, I won't do it across the entire project. Maybe just the commonly loaded files. This has no influence on performance, so it's just to a developer's benefit. (Class-CSS.php)
124
Bug reports / Re: No referral to the secure connection https://wedge.org/
« on March 19th, 2017, 02:16 PM »Well a secure connection between internet browsers and websites is not a luxury it's a must, allowing to transmit details,passwords or any personal information.Quote from Nao Any reason you'd want to have an exclusive https connection?
It should be enough that Wedge now fully supports https. ;) (It wasn't the case before.)
The only problem is with avatars, which sometimes use http links so you have to be smart about them.
So when an users on my Website which is secured with a SSL Certificate chooses to click on a link (on our credit page) it seems logical to me that this must be a secure connection.
125
Development blog / Re: The obligatory Christmas update.
« on March 19th, 2017, 12:40 PM »
I just realized this was my last post on the blog... :^^;:
Oh, and that comment system looks so cool.
I'm guessing I need to make a strong statement about Wedge still being alive.
Thanks to CerealGuy for never giving up and pestering me into coming back :)
Also thanks to Lestrades.com for giving me a good reason to get back to work!
Oh, and that comment system looks so cool.
I'm guessing I need to make a strong statement about Wedge still being alive.
Thanks to CerealGuy for never giving up and pestering me into coming back :)
Also thanks to Lestrades.com for giving me a good reason to get back to work!
126
Bug reports / Re: No referral to the secure connection https://wedge.org/
« on March 19th, 2017, 12:19 PM »
Well, IIRC I only added https support to wedge.org for testing. I'm only making use of it on lestrades.com, where sensitive (or more precisely, 'valuable') data can be shared. I keep asking my host to enable http/2 on nginx[1] but she won't budge. I had my websites hosted by someone else so I wouldn't have to deal with keeping a list of installed modules to update, but apparently I'm not the only one not willing to do that ahah.
Any reason you'd want to have an exclusive https connection? Because AFAIK it's a bit slower (5% at least?), and there is no sensitive data here-- everything is open source and passwords are encrypted before they're transmitted anyway.
Any reason you'd want to have an exclusive https connection? Because AFAIK it's a bit slower (5% at least?), and there is no sensitive data here-- everything is open source and passwords are encrypted before they're transmitted anyway.
| 1. | This would give me a good reason to move everything to https, by making everything load noticeably faster. |
127
Features / Re: New revs
« on March 19th, 2017, 11:48 AM »
[Commit revision 0d9d3e4]
Author: Nao
Date: Sun, 19 Mar 2017 11:47:30 +0100
Stats: 1 file changed; +9 (insertions), -29 (deletions)
Date: Sun, 19 Mar 2017 11:47:30 +0100
Stats: 1 file changed; +9 (insertions), -29 (deletions)
- Spacinazi. (Subs-BBC.php)
- Removed duplicate array declarations, and simplified one of them. (Subs-BBC.php)
128
Bug reports / Re: Couple things to look into...
« on March 19th, 2017, 11:41 AM »Also, looks like your subs-bbc commit is broken... At the very least, 'list' or 'cli' tags aren't working properly (see New Revs topic). Dunno if it's a problem during the rewrite for 'list', or a problem with external custom bbcode not loading at all.
This might be a problem if someone built a mod (rather than a plugin) that still added stuff to the database, but it's unlikely of course.
(This still isn't working yet, ahah.)
:edit: Was due to the fact that the list tag didn't have 'cli' in its allowed children.
129
Bug reports / Re: Couple things to look into...
« on March 19th, 2017, 12:29 AM »Will definetly look into the login thing, unread topics also but less priority.
Also, looks like your subs-bbc commit is broken... At the very least, 'list' or 'cli' tags aren't working properly (see New Revs topic). Dunno if it's a problem during the rewrite for 'list', or a problem with external custom bbcode not loading at all.
There are some things which bug me about login (besides sha256):
- no js counter for failed logins, i find myself quite often on the "you have to wait before you can try to login again" error page.
- after x failed logins this error page should first show up, for me it shows up after the first try
- no redirect of $_POST content, i often loose posts because my session timed out. Don't know if this should get solved on login or in editor. Have to think about that.
- notification on x failed logins for the user would be cool, maybe plugin stuff.
130
The Pub / Re: PHP 5.4?
« on March 19th, 2017, 12:26 AM »
Implemented.
Go crazy with [ ] now ;)
Also removed all magic quote shit. It felt good!
Go crazy with [ ] now ;)
Also removed all magic quote shit. It felt good!
131
Features / Re: New revs
« on March 19th, 2017, 12:22 AM »
[Commit revision f2ba207]
Author: Nao
Date: Sun, 19 Mar 2017 00:22:20 +0100
Stats: 13 files changed; +18 (insertions), -90 (deletions)
Date: Sun, 19 Mar 2017 00:22:20 +0100
Stats: 13 files changed; +18 (insertions), -90 (deletions)
- Removed support for PHP 5.3.x, which hasn't been patched in years. Going for 5.4 now, may even go higher if I ever find a reason to do so. Please, upgrade to PHP 7 if you're still on one of these slow 5.x versions. Faster PHP means happier visitors. (README.md, SSI.php, Class-DB.php, Class-SFTP.php, Errors.php, Memberlist.php, OriginalFiles.php, QueryString.php, Subs-Plugins.php, getid3.php, index.php, install.php, readme_install.html)
- Note: magic quote functions were removed in PHP 5.4, so Wedge no longer has to deal with these. :-D (Plenty of occurrences removed.)
- Note: there was also a typo in Memberlist.php (which, for once, was my own fault), causing an 'escape route' to be bypassed instead of executed on PHP 5.4+.
132
The Pub / Re: PHP 5.4?
« on March 18th, 2017, 10:50 PM »
I'd started doing something quick'n'dirty in just two lines of code, but then it started getting complicated, even with just two lines, so I give up for now. :P
I'd rather stick to the lowest 'acceptable' version that Wedge actually supports.
If I start asking for a higher version, I'll start using "??" as a replacement to "?:" (basically removes the need to do an isset() call), and then I'll start wondering if I shouldn't ask for PHP 7.1 support so that I can do [$foo, $bar] = func(); instead of list ($foo, $bar) = func(), but I'm NOT actually using list() much in Wedge, so who cares about that... :P
Well yeah, so I guess PHP 5.4 is doable, just hoping that no one currently using Wedge will be locked out of it. I'm surprised no one replied to the poll though. ^^
I'd rather stick to the lowest 'acceptable' version that Wedge actually supports.
If I start asking for a higher version, I'll start using "??" as a replacement to "?:" (basically removes the need to do an isset() call), and then I'll start wondering if I shouldn't ask for PHP 7.1 support so that I can do [$foo, $bar] = func(); instead of list ($foo, $bar) = func(), but I'm NOT actually using list() much in Wedge, so who cares about that... :P
Well yeah, so I guess PHP 5.4 is doable, just hoping that no one currently using Wedge will be locked out of it. I'm surprised no one replied to the poll though. ^^
133
Since Wedge is 5.3+, maybe it's safe to simply up the min reqs to 5.4..?
The main advantage is the ability is use [ ] instead of array( ) inside the code. It's really just that.
I could also modify Subs-CachePHP.php to automatically replace [ ] with array() as needed. I can't be arsed for now.
I just checked, and 5.3+ is supported by ~90% of the user base, and 5.4+ by ~70%... Hmm. Then again-- what we care about is the current userbase, as I've long given up on turning Wedge into a popular engine. It's just the cool engine that people in the know use.
Anyway, I'm likely to go for PHP 5.4 + some support for PHP 5.3, but I can't be arsed to code said support for now. ;)
The main advantage is the ability is use [ ] instead of array( ) inside the code. It's really just that.
I could also modify Subs-CachePHP.php to automatically replace [ ] with array() as needed. I can't be arsed for now.
I just checked, and 5.3+ is supported by ~90% of the user base, and 5.4+ by ~70%... Hmm. Then again-- what we care about is the current userbase, as I've long given up on turning Wedge into a popular engine. It's just the cool engine that people in the know use.
Anyway, I'm likely to go for PHP 5.4 + some support for PHP 5.3, but I can't be arsed to code said support for now. ;)
134
Features / Re: New revs
« on March 18th, 2017, 12:55 PM »IMPORTANT: this commit and the previous one only work on PHP 7+.
135
Features / Re: New revs
« on March 18th, 2017, 12:45 PM »
[Commit revision df6398f]
Author: Nao
Date: Sat, 18 Mar 2017 12:45:04 +0100
Stats: 1 file changed; +674 (insertions), -725 (deletions)
Date: Sat, 18 Mar 2017 12:45:04 +0100
Stats: 1 file changed; +674 (insertions), -725 (deletions)
- IMPORTANT: this commit and the previous one only work on PHP 7+. Don't update Subs-BBC.php if you're using an older version! This will be fixed later.
- Spacinazi. Big time. (Subs-BBC.php)
- Removed some useless things that were obviously leftovers of a bad print_r/var_dump, like arrays indexed from 0. Also, just as a quick note, array(1 => 'hello', 'world') will return an index of 2 for 'world'. It's a nice thing to know. See font size handling. (Subs-BBC.php)
- Started reintegrating a couple validation functions into the array. This needs testing, I'm pretty sure this will neither be faster nor slower, but it just looks better and is easier to debug. (Subs-BBC.php)
- Note: I removed an allowed tag mention in the spoiler tag, when it only had a single space instead of a list of tags. My guess is that Pete pressed space by mistake when filling in the database. Also noticed that 'len' was being used... strlen() would do the job fine. After all it's more about convenience than speed here (we're in an era of fast web hosting where... who cares about BBCode speed?!)
- Note: Another thing, I've seen spaces in 'li', 'media' and other tags that got removed. They don't seem to show up in rev d3a5a117eade320a3d8b89b46f667d9f0a7dfd17, where the original BBCode was moved to the database, but I'm also unable to find a version of install files from that day so I don't know if these were errors made at export time. I really think we should compare with the old code.