Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
10186
Features / Re: New revs
« on October 12th, 2010, 02:58 PM »
rev 205
! Fixing the settings_post_javascript fix. Today's the fixing game. (ManageSettings.php, Admin.template.php)

(Just to get this off my hands...)
10187
Features / Re: New revs
« on October 12th, 2010, 02:55 PM »
rev 204
+ Added :edit: smiley. (install_2-0.sql, Install.english.php, Class-Editor.php, Subs.php)
* htmlspecialchars leftover. (ManageSettings.php)

PS: reproduced footnote error in Wedge... Hmpf. This will never end... I'll take a break or something.
Quote from Arantor on October 12th, 2010, 02:36 PM
Get a better browser then; Chrome's had it built in for ages. :P
Yeah, I remember that... Damn you, Google fanboys! :ph34r:
I'll stay with my lousy browser. It just added Web Sockets support. Yeah, I know, you've had it for a year, blah blah blah... But your tab UI has sucked from day one :niark:
Quote
Well... UTF-8 is one form of Unicode. The whole concept is a total mess anyway -sigh-. Anyway, the idea is that it should always be valid UTF-8 (and by proxy valid Unicode) except that in some cases it isn't, but I have no idea why that might be. It's been there since 1.1, and it may not be relevant any more - doubly so since it never seemed to be called before.
Yeah... Which is why I reported the issue to the SMF devs. Maybe they'll figure it out... We have much work on our hands, too.
Quote
What was happening is that there was an extra output buffer existing that shouldn't have existed, which was causing content not to be flushed properly - and even if it did get flushed, the result would be corrupted because it would be gzipped content when the header implied otherwise. (I haven't checked the browser-specific stuff yet, that's next up)
Okay... ob_clean is supposed to empty the buffer without deleting the hooks. So I guess what happened is: originally, there was one less buffer called, and the dev added that remark. Then, someone added an extra buffer that should NOT be used in attachments, and forgot (or wisely decided) not to use it in the code we're talking about, so that their buffer wasn't re-created after ob_get_clean(). But forgot to delete the mention about ob_clean().
Quote
Quote
unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);
I wonder why SMF never did that.
They can probably explain that using isset() saves 0.07 microseconds off execution time.
Of course, the foreach with a custom array will definitely eat that...

Let's just say they didn't know unset() could be called with multiple parameters.
Or that unset() on an undefined variable didn't generate any warnings or errors (except on an undefinex index in an undefined array, in PHP4 only.)
Maybe the foreach() was there because they planned to add more vars to it later...
Just like in Subs-Members.php... I see no other reason to use THAT, and even the comment spells it out. 'Characters'. (Feel free to delete it.)

Code: [Select]
// Characters we just shouldn't allow, regardless.
foreach (array('*') as $char)
if (strpos($checkName, $char) !== false)
if ($fatal)
fatal_lang_error('username_reserved', 'password', array($char));
else
return true;

IIRC, I already fixed a similar code block long ago. Was probably in Aeva Media... Something Dragooon had copied from SMF, I'd venture.
Quote
It still breaks though, vomiting raw JS onto the page :/
Okay, I see what you mean... The var is modified after that. Uh. That's what happens when you're busy fixing 12 things at the same time.
Well, I'll fix that back...
Quote
Not only that but we've made some very large changes to the codebase, and it's unlikely we'd have totally caught every one first time simply because they are very large changes with lots of consequences.
Not only that, but you have no idea how fun it's going to be when I get to update to the latest SMF SVN...
Basically, I now have to do all of the templates manually because they always change stuff around a .catbg class (which no longer exists), now I'll have to edit source files manually every time they make a change around a UTF call... ;)
10188
Features / Re: New revs
« on October 12th, 2010, 02:27 PM »
Phew... Finally done reading through your changes. I can't believe you did all of that in a single night...! What are you on?

Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Quote from Arantor on October 12th, 2010, 01:16 PM
htmlspecialchars does one core job, converting key HTML items into entities, namely stuff like & to &. It also has options for handling quotes, ENT_COMPAT, ENT_NOQUOTES and ENT_QUOTES. ENT_COMPAT is the default, which converts " to ", ENT_NOQUOTES leaves both " and ' alone, and ENT_QUOTES does both " to " and ' to  according to php.net's page on it. (At least, it definitely turns ' into entities)
Oh... I see what you mean, very sorry. I didn't notice the separator. I was changing the data in the parameter list -- and that was a "default" parameter but it could be changed... I've never been very comfy with create_function.
I totally broke htmlspecialchars, ahah!
BTW, there were two remaining calls in ManageServer.php that specified UTF-8 at the end, I've modified them locally. Will be in the next commit.
Quote
(It is a good idea to simplify it down though, as I'm not entirely sure that it's needed outside the query parameterisation)
Oh well then that's a good thing I missed the point in the first place... 8-)
Quote
! Expand installer strtolower version to match main source (install.php)
+1
Quote
! Fix broken regexp for sanitising lists (Class-Editor.php)
-1 :niark:
Quote
! Fix caller for recursive Unicode validation (Subs.php)
BTW, makes me think... Is this Unicode or UTF? If it's Unicode, then I don't even know what the function is there for... SMF/Wedge never ever generate Unicode stuff, AFAIK...
Quote
! Fix broken attachments (reverting previous optimisation) (Download.php)
That was one of mine... Actually I just followed the comment's suggestion. ("Would use ob_clean but that's PHP 4.2") I figured okay it's PHP 5.0 now so let's use ob_clean...
Now, I'm not sure in what way it was broken? It's been a long time since I've played with output buffer manipulation. Especially in SMF, where there are plenty of buffers at a time...
Quote
This marks the start of breaking up the monolithic files in the core; there's really no need to have them like that, especially as it makes things slower in fact (Display being one of the most heavily used files, needs to be kept lighter!)
That's a good idea, indeed...
Quote from Arantor on October 12th, 2010, 02:17 PM
It didn't used to be complicated for a single unset, when it had two items in it... but in hindsight it was still complicated.
Well, yes it was complicated, even at the time... My problem is that I'm not auditing the codebase. Maybe I should. I only find such issues when checking commits and making changes to the code myself.

unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);

As you can see... It does two unsets, and it's still a single call ;)
Quote
Quote
* Spacinazi. (ManageSettings.php, Admin.template.php)
Won't that break the settings pages since $context['settings_post_javascript'] doesn't add its own <script> tag...?
Well, I added the script tag in ManageSettings, didn't I...?
I mainly did it because you unindented the code and it wasn't in line with the script tag. Also, SMF's implementation would automatically add a tab. I just deleted the hell out of those ugly lines and made it cleaner.
That's my job...[1]
Quote
Quote
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Yes, that was an oops moment, sorry...
 1. I'M NOT A WINDOW CLEANER!!!!![1]
 1. Okay, it only works if you've read my first post on runic's place[1].
 1. *And* you watched this year's IT Crowd...
Given these last few hectic hours, it's no surprise we're both making blunders here and there. That's why we proof-read each other's code. Glad to be of help :)

Hey, my footnotes got in the wrong place... I'll make sure I've applied my Wedge fix on them.

:edit: Argh, it seems that it's already applied... :-/ Will need to fix that, then.
10189
Features / Re: New revs
« on October 12th, 2010, 02:04 PM »
rev 202
- Removed unused globals from Xml functions. (Xml.template.php)
* Complicated code just for an unset... (index.php, SSI.php)
* Spacinazi. (ManageSettings.php, Admin.template.php)

rev 203
* Committed the last few conflicted files with content_section changes. (install.php, ssi_examples.php, upgrade.php, index.template.php)
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
10190
Features / Re: New revs
« on October 12th, 2010, 12:04 PM »
rev 199
- Karma leftovers. (upgrade_2-0.sql)
- getLanguage() utf8 leftovers. (ManageServer.php, Profile-Modify.php)
- char_set leftover. (ScheduledTasks.php)

I'll leave you the pleasure of submitting rev 200!
Quote from Arantor on October 12th, 2010, 10:49 AM
Never have that problem, even when it's out of sync. TortoiseSVN keeps all mine even if I hit cancel; above the changelog textbox there's a 'Recent Messages' button you can click... maybe you need a more recent version?
Yeah, maybe. I have a fairly recent version (several months.)
I'll be sure to have a look next time.
Quote
Quote
* Simplified htmlspecialchars(). (Load.php)
Interesting change... any particular reason? The one thing I'd note is that now every ' that comes in will be converted to an entity (which may have other consequences for the places where no override was given, where it will just use ENT_COMPAT, so only double quotes would be entitified before)
I... I'm not sure I understand. I was just read through the log, saw something that I would sum up as "$a = 'hello'; echo $a;" and turned it into "echo 'a';"... Did I make a mistake? Feel free to revert, of course.
10191
The Pub / Re: Logo Madness (Was: New revs)
« on October 12th, 2010, 10:38 AM »
Re: slogans: the original slogan I'd put into the wedge logo was, "SMF for real people" (i.e. we want to change it to make it more logical to use... even if it's not true :P)... Then I thought it was boring, and replaced it with "SMF for real men. And women. And dogs, too." Funny that Adonis had the same inspiration :lol:
Although in the end I shortened it because it was too long for my taste.

Anyway -- when it comes to the logo, I thought you could have tried new colors, instead... And try staying with a solid color inside, because it's really easier to reduce afterwards, while maintaining readability. Also, the one thing my logo would need is a very, very thing white line around the logo, to allow showing in on dark backgrounds. Things like that...
10192
Features / Re: New revs
« on October 12th, 2010, 10:27 AM »
I was going to post my 196 log ;)
Reason I did that small commit, is to save me some time when diff'ing the files. In the end it was pretty useless because several of the files needed to be updated first, so I didn't commit those... So it's a half-broken update, ah ah! Just don't bother about it. I'll commit the final 3 files when I'm done reviewing your tons of edits.
As for myself, I copy what I type into the changelog, directly before posting it, because if a file is out of sync, it friggin' erases the log and doesn't let me copy it for my next attempt! So, I use the opportunity to post the text here... Hence why it doesn't have your more verbose changelog formatting.

rev 198
* Simplified htmlspecialchars(). (Load.php)
- Removed smf_charset Javascript variable. (ssi_examples.php, upgrade.php, index.template.php, script.js)
- Removed any charsets other than UTF8 from php_to8bit(). That felt GOOD! (script.js)
10193
The Pub / Re: Logo Madness (Was: New revs)
« on October 11th, 2010, 06:21 PM »
Yes... It's the font I used for the current logo.
10194
The Pub / Logo Madness
« on October 11th, 2010, 07:27 AM »
(I'm wondering if Adonis or Bloc would be willing to give a shot at doing a Yanone Kaffe-based Wedge logo...)

:edit: This is an old topic from the private area that I'm moving to the public area to show off the various and interesting logos that were built over time. It might give you an idea of how we're all working together. (Basically: people do their best -- then I bitch and complain -- then I do it my own way and I take all the credit. 8-))
10195
Features / Re: New revs
« on October 10th, 2010, 11:18 PM »
rev 191
* Made main menu background a bit brighter. Subtility, crap like that... (index.css)
+ Made sure to hide the dropdown arrow if a top-level menu entry doesn't have any submenu. (index.css, index.template.php)
* Moved main menu icon definitions to index.css, and replaced spriting code with a simple 'padding' parameter to tell the menu code the actual width of the current icon. (Subs.php, index.css, index.template.php)
* Changed favicon MIME type to the official one. (index.template.php)
Quote from Arantor on October 10th, 2010, 07:51 PM
You can change it :P Just it was something to hand that was convenient.
We'll be keeping it for now, I guess...
Quote
Sure, but how often do site admins have a favicon already in place for a top level domain and have nothing else there when adding a forum to the top level of the domain?
Hmm... Well...
I don't know.
To me, that Wedge icon was pretty much the symbol for our website, rather than our software. See what I mean...?
Just like SMF has their own favicon at simplemachines.org, but they don't include it in the package.
Quote
Sure, but having it set up like this will mean they just copy theirs over the top of the provided one (we don't have to include it in upgrades).
Hmm... I guess. But if they don't know the first time around... And if they don't keep a copy somewhere... (Okay, then that's THEIR problem.)
Quote
No need to apologise; only reason I thought of it is because I've been doing a similarly styleable menu for my other project and one of the things was to make it as flexible as possible to style in pure CSS.
I was probably influenced a bit too much by my own Noisen code for adding icons in the main menu.
(And seriously -- I don't understand a bit why it was so incredibly easy to implement them in a tableless fashion in Wedge, when I broke my teeth for several days trying the same in Noisen... And finally settled on a table version.)
10196
Features / Re: New revs
« on October 10th, 2010, 07:20 PM »
Reasons why I didn't add a favicon myself:
- From the beginning, I was very happy with the favico I made for wedgeforum.com, but unhappy with the logo itself. Now, I'm very happy with my current Wedge logo, but unhappy with the (unused) favico I made from it...
- If admin has a favico for their site, they may erase it by thoughtlessly uploading the Wedge files to their website.
- If they're uploading to a subfolder, they may not like having a different favico than their main site, either.

This is basically why I didn't play with this...

Regarding the MIME type, why did you use "x-icon"?
The official type (as used on noisen and wedgeo) is "vdn/microsoft_crappy_files"
Cf. http://en.wikipedia.org/wiki/ICO_(file_format)
Posted: October 10th, 2010, 07:18 PM
Quote from Arantor on October 10th, 2010, 05:25 PM
The one thing about the icons is that they're hardcoded right now; would be hard for theme authors to set the icons themselves.
You mean, the sprited icons? Yes, that's always been the problem obviously...
Quote
While this would be somewhat ugly, would it not be preferable to define classes in CSS for each icon (like how the sprite icons work in the thread view normally) and control it all through CSS so theme authors can override/ignore it as they see fit?
Well, sure can do that, yes.
I'm sorry I didn't think of doing that from the beginning.
10197
Features / Re: New revs
« on October 10th, 2010, 02:25 PM »
rev 189 (This was all done yesterday but I'm having some computer issues and wasting time...)
+ Changed Calendar icon to a new, sprited one. Added sprited icon for Register. Fixed icon widths. (Subs.php)
* Updated to SMF rev 10150, with a lot of minor tweaks to layout and styling.
  * Missing icon in profile/ignore boards. Markup/css to allow large content above the linktree (Profile.template.php, index.template.php, index.css) (NB: was already done in Wedge anyway...)
  * Minor cleaning up in admin. Better highlighting of search results. Defined new_win class. Better description for post options (Admin.template.php, admin.css, index.css, Post.english.php)
  * Fixed post-breaking bug in IE6 and IE7. Removed $context['right_to_left'] from two templates. (ie6.css, ie7.css, index.css, rtl.css, Display.template.php, Memberlist.template.php)
  * Fixed board selection in profile and help. Cleaned up stats markup. (Profile.template.php, Help.template.php, Stats.template.php, index.css, rtl.css)
10198
Off-topic / Re: What is your favorite quote?
« on October 9th, 2010, 08:59 PM »
My favorite quotes are in French... Wouldn't be of much interest, ah ah.
10199
Off-topic / Re: Post count fever
« on October 9th, 2010, 08:58 PM »
I can confirm that...
People IRL usually tell me to shut up. Or when they're nicer, they ask me for my website URL and of course I never see them come by :P (Now, when I get such requests, I understand they're fed up with my endless rants.)
10200
Off-topic / Re: Post count fever
« on October 9th, 2010, 12:01 PM »
Quote from Arantor on October 9th, 2010, 11:08 AM
If you're only 10% behind, that would put you at 35k :P
Well, let's be honest, there's no way I could compete with you if you were ONLY posting here :whistle:
And when Wedgeo goes public, you'll be posting 3 times more than I do... At a minimum!