Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
10096
Features / Re: New revs
« on November 5th, 2010, 07:14 PM »
rev 241
! Don't show the Pretty URLs area if you're editing a board with Pretty URLs disabled... (ManageBoards.php, ManageBoards.template.php)
! Could possibly keep using Pretty URLs even if it was disabled in the admin. (QueryString.php)
PS: leave rev 242 to me, it's one of my lucky numbers :P
! Don't show the Pretty URLs area if you're editing a board with Pretty URLs disabled... (ManageBoards.php, ManageBoards.template.php)
! Could possibly keep using Pretty URLs even if it was disabled in the admin. (QueryString.php)
PS: leave rev 242 to me, it's one of my lucky numbers :P
10097
Features / Re: New revs
« on November 5th, 2010, 06:43 PM »
rev 240
! A misplaced "}" broke board identification if Pretty URLs were disabled. (QueryString.php)
! Couldn't disable Pretty URLs once enabled. (ManageSettings.php, Admin.template.php)
! A misplaced "}" broke board identification if Pretty URLs were disabled. (QueryString.php)
! Couldn't disable Pretty URLs once enabled. (ManageSettings.php, Admin.template.php)
10098
Features / Re: New revs
« on November 5th, 2010, 12:17 PM »
The more we do to fix sMF, the more we realize we have to do if we are to follow our instincts. <sigh>
10099
Features / Re: New revs
« on November 5th, 2010, 09:14 AM »
rev 239
@ The big "theme stylings" initial commit!
@ todo: remove support CSS variants to avoid confusion? Make sure caching is solid (has flush option, fixes folder rights, etc.) Maybe separate theme entries from styling entries with Javascript in ManageBoards. Allow choosing a styling for non-board pages, too! (via $modSettings)
+ Added support for stylings and added two sample stylings. (install.sql, Class-Editor.php, Load.php, ManageBoards.php, Subs.php, Subs-Boards.php, css/index.css, index.template.php, ManageBoards.template.php, css/cache, css/Green/*, css/Nix/*)
+ Added support for gzipped CSS files. (.htaccess)
+ Store current user agent in $context['browser']['agent'] for later use. (Load.php)
* More SMF svn fixes. This will be my last batch, since SMF no longer want us to be able to stick to their codebase. (Class-Editor.php, Load.php)
! Fixed undefined error. (ManageAttachments.php)
! Pretty URLs really need some fixin'... (QueryString.php, Subs-Boards.php)
* Merged mergeposts.gif button into quickbuttons.png sprite file. (css/index.css)
* Spacinazi. (Load.php, Subs.php, Themes.php)
PS: forgot to mention Subs.php being modified by the styling feature in the svn changelog. Adding it here...
@ The big "theme stylings" initial commit!
@ todo: remove support CSS variants to avoid confusion? Make sure caching is solid (has flush option, fixes folder rights, etc.) Maybe separate theme entries from styling entries with Javascript in ManageBoards. Allow choosing a styling for non-board pages, too! (via $modSettings)
+ Added support for stylings and added two sample stylings. (install.sql, Class-Editor.php, Load.php, ManageBoards.php, Subs.php, Subs-Boards.php, css/index.css, index.template.php, ManageBoards.template.php, css/cache, css/Green/*, css/Nix/*)
+ Added support for gzipped CSS files. (.htaccess)
+ Store current user agent in $context['browser']['agent'] for later use. (Load.php)
* More SMF svn fixes. This will be my last batch, since SMF no longer want us to be able to stick to their codebase. (Class-Editor.php, Load.php)
! Fixed undefined error. (ManageAttachments.php)
! Pretty URLs really need some fixin'... (QueryString.php, Subs-Boards.php)
* Merged mergeposts.gif button into quickbuttons.png sprite file. (css/index.css)
* Spacinazi. (Load.php, Subs.php, Themes.php)
PS: forgot to mention Subs.php being modified by the styling feature in the svn changelog. Adding it here...
10100
Features / Re: New revs
« on November 2nd, 2010, 01:13 PM »
I figured I should commit whatever I have that isn't related to CSS variants... It'll be easier for me in the longer term because I don't know when I'll be ready to commit.
rev 238
* Renamed install and upgrade scripts to drop the version number, as Wedge is 1.0, not 2.0. (install.php, install.sql, upgrade.php, upgrade.sql)
- Removed most of the credits. Technically, these names have nothing to do with our project... (Who.php, Who.template.php)
* Updated to SMF svn 10260. There are still a couple of revs to catch up with...
! Last minute: boards incorrectly retrieved (Subs-Boards.php, Load.php) (NB: Load.php not done yet.)
! Last minute: an incorrect warning (Profile-Actions.php)
! Last minute: adding SMF favicon. (favicon.ico)
* Validation errors due to a typo in themes list (Themes template) [Bug 4505]
! On some versions of Opera the cursor wasn't displayed in WYSIWYG editor (thanks TE) [Bug 4521]
! Clean the entire cache on the disk, if any, during scheduled maintenance (ScheduledTasks.php)
! Small addition to clean_cache() documentation (Subs.php)
! Manage Posts area should only check for admin_forum permission. (ManagePosts.php) [Bug 4520]
* Undefined index in Subs.php for Core theme (Display template)
rev 238
* Renamed install and upgrade scripts to drop the version number, as Wedge is 1.0, not 2.0. (install.php, install.sql, upgrade.php, upgrade.sql)
- Removed most of the credits. Technically, these names have nothing to do with our project... (Who.php, Who.template.php)
* Updated to SMF svn 10260. There are still a couple of revs to catch up with...
! Last minute: boards incorrectly retrieved (Subs-Boards.php, Load.php) (NB: Load.php not done yet.)
! Last minute: an incorrect warning (Profile-Actions.php)
! Last minute: adding SMF favicon. (favicon.ico)
* Validation errors due to a typo in themes list (Themes template) [Bug 4505]
! On some versions of Opera the cursor wasn't displayed in WYSIWYG editor (thanks TE) [Bug 4521]
! Clean the entire cache on the disk, if any, during scheduled maintenance (ScheduledTasks.php)
! Small addition to clean_cache() documentation (Subs.php)
! Manage Posts area should only check for admin_forum permission. (ManagePosts.php) [Bug 4520]
* Undefined index in Subs.php for Core theme (Display template)
10101
Features / Re: New revs
« on October 27th, 2010, 12:07 AM »
rev 237
- Deleted db_fatal_error(), as it was no longer used. (index.php, Errors.php, Load.php, Subs-Database.php)
I double-checked, and there was no such "or db_fatal_error()" occurrences in the code, even though that's mentioned in the SMF source files...
- Deleted db_fatal_error(), as it was no longer used. (index.php, Errors.php, Load.php, Subs-Database.php)
I double-checked, and there was no such "or db_fatal_error()" occurrences in the code, even though that's mentioned in the SMF source files...
10102
Features / Re: New revs
« on October 26th, 2010, 10:09 PM »
rev 236
* Updated to SMF rev 10247.
! A safer handling of the database last error and generally writing Settings.php [Bug 4222]
--> Mainly it moves db_show_error to Errors.php... I updated the docs, hopefully it's okay.
Now db_fatal_error() is 100% an alias. Norv forgot to remove the $sourcedir global, I finished that.
There's a @todo in there. Yeah, the function could be removed, but... mods, maybe?
* Updated to SMF rev 10247.
! A safer handling of the database last error and generally writing Settings.php [Bug 4222]
--> Mainly it moves db_show_error to Errors.php... I updated the docs, hopefully it's okay.
Now db_fatal_error() is 100% an alias. Norv forgot to remove the $sourcedir global, I finished that.
There's a @todo in there. Yeah, the function could be removed, but... mods, maybe?
10103
Features / Re: New revs
« on October 26th, 2010, 09:36 PM »
Yeah, I was wondering the same... Maybe the report will clear this up.
rev 235
! Fixed htaccess by making sure mod_headers is enabled before we try to rewrite headers. (.htaccess)
! Forgot to apply group_type to membergroups table at install time. (install_2-0.sql)
+ Added support for the following pretty URLs: /topic_id/topic_name/page_number/, /year/month/day/, /cat/category_name/, /tag/tag_name/, and /board_page/ (QueryString.php)
rev 235
! Fixed htaccess by making sure mod_headers is enabled before we try to rewrite headers. (.htaccess)
! Forgot to apply group_type to membergroups table at install time. (install_2-0.sql)
+ Added support for the following pretty URLs: /topic_id/topic_name/page_number/, /year/month/day/, /cat/category_name/, /tag/tag_name/, and /board_page/ (QueryString.php)
10104
Features / Re: New revs
« on October 26th, 2010, 08:31 PM »
All righty, in Admin.php:
Code: [Select]
So, apparently one needs to have admin_forum to access all of these tabs...
Which means ManagePosts is buggy in that respect.
:edit:
http://dev.simplemachines.org/mantis/view.php?id=4520
'postsettings' => array(
'label' => $txt['manageposts'],
'file' => 'ManagePosts.php',
'function' => 'ManagePostSettings',
'permission' => array('admin_forum'),
'icon' => 'posts.gif',
'subsections' => array(
'posts' => array($txt['manageposts_settings']),
'bbc' => array($txt['manageposts_bbc_settings']),
'censor' => array($txt['admin_censored_words']),
'topics' => array($txt['manageposts_topic_settings']),
'merge' => array($txt['manageposts_merge']),
),
),So, apparently one needs to have admin_forum to access all of these tabs...
Which means ManagePosts is buggy in that respect.
:edit:
http://dev.simplemachines.org/mantis/view.php?id=4520
10105
Features / Re: New revs
« on October 26th, 2010, 07:17 PM »
ManagePosts... The code that redirects to the respective tabs at the beginning.
10106
Features / Re: New revs
« on October 26th, 2010, 06:10 PM » 'posts' => array('ModifyPostSettings', 'admin_forum'),
'bbc' => array('ModifyBBCSettings', 'admin_forum'),
'censor' => array('SetCensor', 'moderate_forum'),
'topics' => array('ModifyTopicSettings', 'admin_forum'),This has been in both Wedge and SMF for at least the last month... I really don't see any changes in SMF RC4 in that respect!
10107
Off-topic / Re: Truest xkcd yet
« on October 26th, 2010, 05:43 PM »
No, that was me disabling "Show link titles" in opera:config long ago because I didn't want to have titles instead of links... But sometimes it's useful I guess.
10108
The Pub / Re: Logo Madness (Was: New revs)
« on October 26th, 2010, 02:43 PM »
Bump for opinions on the logos so far...?
10109
Features / Re: New revs
« on October 26th, 2010, 12:29 PM »
rev 234
* resize-handle.gif is a horribly wrong version... Seriously, 800+ bytes for that? Also reworked the 'picture' to suggest enlargement. (resize-handle.gif)
* Repositioned sprites so that the empty space is at the bottom right. (bbc/sprite.png)
+ Did I actually forget to commit edit.gif in the smiley list...? Maybe this should be a BBC button instead, though... (edit.gif)
! Fixed wrong resizer bar width on IE browsers. (editor_ie.css)
* resize-handle.gif is a horribly wrong version... Seriously, 800+ bytes for that? Also reworked the 'picture' to suggest enlargement. (resize-handle.gif)
* Repositioned sprites so that the empty space is at the bottom right. (bbc/sprite.png)
+ Did I actually forget to commit edit.gif in the smiley list...? Maybe this should be a BBC button instead, though... (edit.gif)
! Fixed wrong resizer bar width on IE browsers. (editor_ie.css)
10110
Features / Re: New revs
« on October 26th, 2010, 10:09 AM »
rev 233
! Fixed undefined error in merge admin. (ManagePosts.php)
* Optimized index.css for size. "0.5em" becomes ".5em", "padding: 1px 3px 2px 3px" becomes "padding: 1px 3px 2px", things like that... Inspired by a CSS minifier. (index.css)
* Reverted hover color on main menu's top-level entries, to match the admin menu color. Too many different colors can be confusing... (index.css)
* Updated to SMF rev 10246.
! Fix for windows check (ManageServer.php)
@ Also in latest SMF revs: RC4 version updates, and smfinfo.php was updated to a new version... It doesn't work very well, though, failing notably at showing the current version, uh. Should probably remove that file from the svn entirely...Quote from Arantor on October 25th, 2010, 08:03 PM I don't know, it adds plenty of code and it's slightly obscure... Well, at least on first look.
Sinan asked for beta testers to look into the addition. I'm afraid I can't bother...Quote I don't know... I couldn't even find the word 'censor' in the diff patch (?!), and the changelog doesn't specify which file was changed... (Good job!)Quote clean_cache('data') might be worth mentioning, though...
But maybe we'll add more cache types later. CSS? Hmm...
! Fixed undefined error in merge admin. (ManagePosts.php)
* Optimized index.css for size. "0.5em" becomes ".5em", "padding: 1px 3px 2px 3px" becomes "padding: 1px 3px 2px", things like that... Inspired by a CSS minifier. (index.css)
* Reverted hover color on main menu's top-level entries, to match the admin menu color. Too many different colors can be confusing... (index.css)
* Updated to SMF rev 10246.
! Fix for windows check (ManageServer.php)
@ Also in latest SMF revs: RC4 version updates, and smfinfo.php was updated to a new version... It doesn't work very well, though, failing notably at showing the current version, uh. Should probably remove that file from the svn entirely...
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.
Sinan asked for beta testers to look into the addition. I'm afraid I can't bother...
Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.
Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
But maybe we'll add more cache types later. CSS? Hmm...