Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
1006
Features / [Poll] Re: Board status icons: what's the point?
« on March 28th, 2014, 10:18 AM »
I don't *want* to have it fixed... I tried to, but I don't see the point in spending two days on fixing something that's hard to fix (session variables, YAY!), and that I don't even see the point of. Even back in the SMF days, when I was a die-hard fanatic of the software and didn't consider forking it for a second (well, that wasn't possible anyway), I thought these 'topicseen' links were UGLY and had no point. I never used the feature. I mean, I see these icons, some of which are differently styled, etc, but it's just... There. "Okay. Fine. What else? Let's look at Unread Topics now..."
So, basically, I really think that some competitor added that feature at some point in the early 2000's, let's say it was vBulletin or something else, and the SMF guys got requests from a few people about adding the same thing to SMF. For the life of me, I can't see why you'd want to visit a board BECAUSE it has unread posts. You'd want to view the Unread Topics page. DONE.
(Y'know, you can remove a vote after you cast it, as long as the poll allows it... This one does ;))
So, basically, I really think that some competitor added that feature at some point in the early 2000's, let's say it was vBulletin or something else, and the SMF guys got requests from a few people about adding the same thing to SMF. For the life of me, I can't see why you'd want to visit a board BECAUSE it has unread posts. You'd want to view the Unread Topics page. DONE.
(Y'know, you can remove a vote after you cast it, as long as the poll allows it... This one does ;))
1007
Features / Re: Plugin revs
« on March 28th, 2014, 10:02 AM »
[Commit revision 5e2eca6]
Author: Nao (Signed-off)
Date: Thu, 27 Mar 2014 22:47:33 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
Date: Thu, 27 Mar 2014 22:47:33 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- recent_items was using the old topicseen. (recent_items/Recent-Main.php)
1008
Features / Re: New revs
« on March 28th, 2014, 09:59 AM »
[Commit revision f609e91]
Author: Nao
Date: Fri, 28 Mar 2014 09:55:16 +0100
Stats: 7 files changed; +17 (insertions), -3 (deletions)
Date: Fri, 28 Mar 2014 09:55:16 +0100
Stats: 7 files changed; +17 (insertions), -3 (deletions)
- Added bypass_edit_disable permission, which allows specific users to bypass, as its name implies, the edit_disable_time setting, and effectively be able to edit their posts anytime after the grace period has expired. (Class-System.php, ManagePermissions.php, ManagePosts.php, Security.php, Help.english.php, ManagePermissions.english.php)
- Improving readability for reply_number. (index.english.php)
- Note, bypass_edit_disable is basically untested. I haven't found anyone willing to test it (!), so I'll just consider it does.
- This is a global permission, meaning it's applied on all boards, instead of per-board per-profile per-group. I just think it's better that way. And, less complicated.
1009
Features / Re: Language revs
« on March 28th, 2014, 09:59 AM »
[Commit revision 2f5fc9d]
Author: Nao (Signed-off)
Date: Thu, 27 Mar 2014 22:10:28 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
[Commit revision db8afaa]
Author: Nao (Signed-off)
Date: Fri, 28 Mar 2014 09:55:09 +0100
Stats: 5 files changed; +8 (insertions), -2 (deletions)
Date: Thu, 27 Mar 2014 22:10:28 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
- Added separators to reply_number, to help readability, like in the French version. (index.english.php, index.german.php)
[Commit revision db8afaa]
Date: Fri, 28 Mar 2014 09:55:09 +0100
Stats: 5 files changed; +8 (insertions), -2 (deletions)
- bypass_edit_disable permission strings. (Help, ManagePermissions)
- Missing strings in French version. How could it happen..?! (ManagePosts.french.php)
1010
Features / Re: Board icons: what's the point?
« on March 28th, 2014, 09:49 AM »
I'm currently doing a fair compare of SMF 2.0 vs Wedge's codebase, looking for topicseen in the first and [';]seen in the second...
Interestingly, no code seems to have been changed, apart from renaming topicseen to seen.
I also did a thorough compare within Display.php, MessageIndex.php and Subs-Post.php, and couldn't find any single difference, really.
So, my guess is that I didn't create a bug... It's just a flawed system. If you want a proper 'unread' status on boards, you'll *have* to do better than store stuff into a (volatile) session variable.
If anyone is willing to help fix this, then feel free to offer your services. Otherwise, I'll eventually remove boardseen and seen variables altogether.
Interestingly, no code seems to have been changed, apart from renaming topicseen to seen.
I also did a thorough compare within Display.php, MessageIndex.php and Subs-Post.php, and couldn't find any single difference, really.
So, my guess is that I didn't create a bug... It's just a flawed system. If you want a proper 'unread' status on boards, you'll *have* to do better than store stuff into a (volatile) session variable.
If anyone is willing to help fix this, then feel free to offer your services. Otherwise, I'll eventually remove boardseen and seen variables altogether.
1011
Features / Re: Board icons: what's the point?
« on March 28th, 2014, 09:29 AM »
Don't bother, I just don't like other tools for bitmap editing... Not even recent versions of PSP. This one's something like 10 years old, maybe more, but I just like it better.
I could have used a vector arrow for my screenshot, PSP7 has these, I've used them before, but it would have taken a couple of minutes to get it right, and my goal was to just point at the icons. What's the problem with my funny arrows..?
Anyway. Poll is tied for now... I'm a bit concerned, because I don't know where the bug started, so saying 'fix' is easier said than done. Pandos, if you want me to fix... Can you help? :P
I could have used a vector arrow for my screenshot, PSP7 has these, I've used them before, but it would have taken a couple of minutes to get it right, and my goal was to just point at the icons. What's the problem with my funny arrows..?
Anyway. Poll is tied for now... I'm a bit concerned, because I don't know where the bug started, so saying 'fix' is easier said than done. Pandos, if you want me to fix... Can you help? :P
1012
Features / Re: Board icons: what's the point?
« on March 28th, 2014, 07:30 AM »
Nope, PSP 7. My tool of choice for the last 10 years.
Maxx, transparency? Don't get it.
Fishing for more votes!
Maxx, transparency? Don't get it.
Fishing for more votes!
1013
Features / Re: Board icons: what's the point?
« on March 28th, 2014, 12:08 AM »TBH... the icons on the menu look a bit old fashion to me.
Menu icons are mostly taken from a single icon set, to keep a semblance of harmony, but it's hard to get it right. In fact, my concern would be mostly with the notification numbers next to Admin and Media, which I find too 'visible, even though it was exactly the point.
the one for media could just give the count to right side, all other icons should remain. on the boards except like you say the new or just a number or a green dot.
This is what I'm talking about ;)
1014
Features / Re: Board icons: what's the point?
« on March 27th, 2014, 11:05 PM »
Everyone, please note that there's a poll above... Just in case ;)
1015
Bug reports / Re: Confirmed issue list
« on March 27th, 2014, 11:02 PM »
This has yet to be determined... ;)
1016
Bug reports / Re: Posting pictures on posts generates 8 errors
« on March 27th, 2014, 11:01 PM »
txcas, are you still getting the Errors.php error..? Because that one, I never got to see.
If yes, then please add, before line 39 in that file, something like:
Code: [Select]
Or this one (it's going to give a long array of esoteric data):
Code: [Select]
Then check your error log, and repost your findings somewhere, either here or by PM... Thanks!
Note: I'm more interesting in the first version, but if $error_message is an empty array or something, then the second version will be the only one that gets me a proper way to debug.
If yes, then please add, before line 39 in that file, something like:
if (is_array($error_message)) { log_error(print_r($error_message, true); }Or this one (it's going to give a long array of esoteric data):
if (is_array($error_message)) { log_error(print_r(debug_backtrace(), true); }Then check your error log, and repost your findings somewhere, either here or by PM... Thanks!
Note: I'm more interesting in the first version, but if $error_message is an empty array or something, then the second version will be the only one that gets me a proper way to debug.
1017
Bug reports / Re: Posting pictures on posts generates 8 errors
« on March 27th, 2014, 10:56 PM »
My problem is not in hiding this error (heck it's easy as hell...), but in understanding why it happens in the first place.
I actually made a log_error debug process here and went through uploading pics, and didn't get any errors... OF COURSE.
Perhaps it works fine for admins, and not for others.
I have a feeling that this piece of code is executed twice, and that the problem occurs on phase 2. Other than that... I dunno.
Of course, I can simply just ignore the bug, and proceed with hiding the error. That'd give me more time to work on other things...
I actually made a log_error debug process here and went through uploading pics, and didn't get any errors... OF COURSE.
Perhaps it works fine for admins, and not for others.
I have a feeling that this piece of code is executed twice, and that the problem occurs on phase 2. Other than that... I dunno.
Of course, I can simply just ignore the bug, and proceed with hiding the error. That'd give me more time to work on other things...
1018
Plugins / [Plugin] Re: HideMod
« on March 27th, 2014, 10:51 PM »That would require adding a 'bypass grace period' permission, I guess.
I need to test it, though...
Anyone wants to have permission to edit their own posts forever? :P
Gave permission to CerealGuy, in case he wants to confirm it works!
1019
The Pub / Re: Why are the plugins in single Git repository?
« on March 27th, 2014, 08:46 PM »
They're in a single repo because they're sanctioned by the boss. That would be me.
Anyone's free to build their own plugins in their own repos, of course. If you want, I can 'link' to your plugins, either by adding a readme in the root and putting links to plugins, or by adding a submodule.
I've never used subtrees, and wouldn't know where to start. Apparently -- it's complicated.
As for the license, the January 20th version of it specifically adds a waiver for github forks!
Anyone's free to build their own plugins in their own repos, of course. If you want, I can 'link' to your plugins, either by adding a readme in the root and putting links to plugins, or by adding a submodule.
I've never used subtrees, and wouldn't know where to start. Apparently -- it's complicated.
As for the license, the January 20th version of it specifically adds a waiver for github forks!
1020
Bug reports / Re: add_plugin_css_file issues
« on March 27th, 2014, 08:44 PM »
Hmm, apparently the pokes weren't enough. :^^;:
Guess I can leave this unfixed for now.
Guess I can leave this unfixed for now.