« Uninitialized string offset
[Fixed] Displaying incorrect topic views
[Fixed] PM gets multiplied »

agent47

  • We-Gen
  • Well that's the thing, yesterday was my first experience with the notification feature thus have a total of one notification so far. :D
  • Posts: 79
[Fixed] Displaying incorrect topic views
« on March 19th, 2012, 10:44 AM » Last edited on March 19th, 2012, 12:43 PM by Nao
So I was going through the "The Pub" board and I noticed the first two topics that were stickied had 1 view which seems to be impossible because the topic itself had 17 replies. Just thought I'd report this. :)




:edit: Arantor: Updated title.
:edit: Nao: Fixed img link.

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,605
[Bug] Re: Displaying incorrect topic views
« Reply #1 on March 19th, 2012, 10:46 AM »
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,605
[Bug] Re: Displaying incorrect topic views
« Reply #2 on March 19th, 2012, 10:58 AM »
OK, I've fixed this locally and will push it into the repository on my next commit (since I want to fix a few other things first)
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

agent47

  • We-Gen
  • Well that's the thing, yesterday was my first experience with the notification feature thus have a total of one notification so far. :D
  • Posts: 79
[Bug] Re: Displaying incorrect topic views
« Reply #3 on March 19th, 2012, 11:00 AM »
Quote from Arantor on March 19th, 2012, 10:46 AM
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
I'm glad I could be of some assistance.

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,605
[Bug] Re: Displaying incorrect topic views
« Reply #4 on March 19th, 2012, 11:20 AM »
:)

This should be applied when the next rollout of patches occurs, as it's applied as rev 1484.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,899
[Fixed] Re: Displaying incorrect topic views
« Reply #5 on March 19th, 2012, 12:49 PM »
How can comma_format() fix that, BTW...?
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,605
[Fixed] Re: Displaying incorrect topic views
« Reply #6 on March 19th, 2012, 12:52 PM »
Or, more accurately, the removal of comma_format.

In the template it goes through number_context, to get the right string. What was happening is that it was seeing 1 500 or whatever, recasting it to int and getting 1 out of it. Though, curiously, it was getting the _n string. Anyhow, number_context does its own comma formatting anyway.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,899
[Fixed] Re: Displaying incorrect topic views
« Reply #7 on March 19th, 2012, 12:55 PM »
Oh... Right!! I looked the other way around, lol. That makes more sense now.
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,605
[Fixed] Re: Displaying incorrect topic views
« Reply #8 on March 19th, 2012, 12:56 PM »
Yeah, took me a minute of staring at it thinking "WTF is wrong with you?" but it does make sense in the end :)
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

« Uninitialized string offset
[Fixed] PM gets multiplied »