« Uninitialized string offset
[Fixed] Displaying incorrect topic views
[Fixed] PM gets multiplied »

agent47

  • Now I see the changes you're talking about.
  • Messages: 115
[Fixed] Displaying incorrect topic views
« le 19 Mars 2012 à 10:44 »Modifié le 19 Mars 2012 à 12:43 par Nao
So I was going through the "The Pub" board and I noticed the first two topics that were stickied had 1 view which seems to be impossible because the topic itself had 17 replies. Just thought I'd report this. :)




:edit: Arantor: Updated title.
:edit: Nao: Fixed img link.

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
[Bug] Re: Displaying incorrect topic views
« Réponse #1, le 19 Mars 2012 à 10:46 »
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
[Bug] Re: Displaying incorrect topic views
« Réponse #2, le 19 Mars 2012 à 10:58 »
OK, I've fixed this locally and will push it into the repository on my next commit (since I want to fix a few other things first)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

agent47

  • Now I see the changes you're talking about.
  • Messages: 115
[Bug] Re: Displaying incorrect topic views
« Réponse #3, le 19 Mars 2012 à 11:00 »
Citation de Arantor le 19 Mars 2012 à 10:46
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
I'm glad I could be of some assistance.

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
[Bug] Re: Displaying incorrect topic views
« Réponse #4, le 19 Mars 2012 à 11:20 »
:)

This should be applied when the next rollout of patches occurs, as it's applied as rev 1484.

Nao

  • Dadman with a boy
  • Messages: 16 082

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
[Fixed] Re: Displaying incorrect topic views
« Réponse #6, le 19 Mars 2012 à 12:52 »
Or, more accurately, the removal of comma_format.

In the template it goes through number_context, to get the right string. What was happening is that it was seeing 1 500 or whatever, recasting it to int and getting 1 out of it. Though, curiously, it was getting the _n string. Anyhow, number_context does its own comma formatting anyway.

Nao

  • Dadman with a boy
  • Messages: 16 082

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
[Fixed] Re: Displaying incorrect topic views
« Réponse #8, le 19 Mars 2012 à 12:56 »
Yeah, took me a minute of staring at it thinking "WTF is wrong with you?" but it does make sense in the end :)
« Uninitialized string offset
[Fixed] PM gets multiplied »