Wedge

Public area => Bug reports => The Pub => Archived fixes => Discussion démarrée par: agent47 le 19 Mars 2012 à 10:44

Titre: [Fixed] Displaying incorrect topic views
Posté par: agent47 le 19 Mars 2012 à 10:44
So I was going through the "The Pub" board and I noticed the first two topics that were stickied had 1 view which seems to be impossible because the topic itself had 17 replies. Just thought I'd report this. :)

(http://dl.dropbox.com/u/915297/views-bug.jpg)


:edit: Arantor: Updated title.
:edit: Nao: Fixed img link.
Titre: Re: [Bug] Displaying incorrect topic views
Posté par: Arantor le 19 Mars 2012 à 10:46
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
Titre: Re: [Bug] Displaying incorrect topic views
Posté par: Arantor le 19 Mars 2012 à 10:58
OK, I've fixed this locally and will push it into the repository on my next commit (since I want to fix a few other things first)
Titre: Re: [Bug] Displaying incorrect topic views
Posté par: agent47 le 19 Mars 2012 à 11:00
Citation de Arantor le 19 Mars 2012 à 10:46
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
I'm glad I could be of some assistance.
Titre: Re: [Bug] Displaying incorrect topic views
Posté par: Arantor le 19 Mars 2012 à 11:20
:)

This should be applied when the next rollout of patches occurs, as it's applied as rev 1484.
Titre: Re: [Fixed] Displaying incorrect topic views
Posté par: Nao le 19 Mars 2012 à 12:49
How can comma_format() fix that, BTW...?
Titre: Re: [Fixed] Displaying incorrect topic views
Posté par: Arantor le 19 Mars 2012 à 12:52
Or, more accurately, the removal of comma_format.

In the template it goes through number_context, to get the right string. What was happening is that it was seeing 1 500 or whatever, recasting it to int and getting 1 out of it. Though, curiously, it was getting the _n string. Anyhow, number_context does its own comma formatting anyway.
Titre: Re: [Fixed] Displaying incorrect topic views
Posté par: Nao le 19 Mars 2012 à 12:55
Oh... Right!! I looked the other way around, lol. That makes more sense now.
Titre: Re: [Fixed] Displaying incorrect topic views
Posté par: Arantor le 19 Mars 2012 à 12:56
Yeah, took me a minute of staring at it thinking "WTF is wrong with you?" but it does make sense in the end :)