« Plugin revs
New revs - Public comments
Simpleportal or equivalent Portal system »

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Messages: 1 670
Re: New revs - Public comments
« Réponse #420, le 14 Juillet 2012 à 09:08 »
HP 2511 Series Wide LCD Monitor. I wanted a 4/3 but I couldn't find any that were large. :( I even looked for 16:10 but the ones I liked weren't on sale  for under $200. So it's too short for my liking (1080... only good for watching movies. But or net is so slow I cam only stream 480p... barely).

Ideally I'd want 1920 x 1440. But I haven't checked on the monitor market for over a year. Maybe I should try  Samsung. I wonder how  they compare to HP. Whatever. I'm stuck with this puppy.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
Re: New revs - Public comments
« Réponse #421, le 14 Juillet 2012 à 18:16 »
Hmm, I need to try it with both my IPS screen on my MacBook and perhaps the Samsung SyncMaster 193 I have (it runs to 1280x1024 though it's still basically 5:4 as a screen)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Messages: 16 082
Re: New revs - Public comments
« Réponse #422, le 4 Septembre 2012 à 23:44 »
Sorry about the media_unseen error... It was a failed copy & paste operation, I'm afraid.

Okay, I'm nearly done with the @media query conversion process. The one thing that bothers me is that IE6/7 still don't support these, actually they do (thanks to a plugin I added on top of them), but it doesn't have any point because these browsers use a table layout for the sidebar, and thus I can't manipulate the sidebar into getting floated to the bottom. All I can do is (1) remove the padding around the window, (2) hide the sidebar entirely.
I'm not sure people would like solution 2, so I'll just stick to 1 for now.

(Uh, I could have posted this on the right topic, but it has too many unread posts right now... I try not to focus on answering posts when I'm busy with a backlog of code...)
Re: New revs - Public comments
« Réponse #423, le 24 Septembre 2012 à 09:37 »
Duplicate removal in language files: awesome :) Something I couldn't be arsed to start doing...

I think it's a good idea to turn pseudo-buttons into proper buttons, I think the point of pseudo-buttons is that people can open them in new windows or something, but really it's not that interesting and it's best to have a coherent interface.

If you look for this string in the Sources and Themes folder, you'll find more buttons that can (should?) be converted: "[<a "

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
Re: New revs - Public comments
« Réponse #424, le 24 Septembre 2012 à 12:12 »
Oh, I already did that. But there's a technical reason it's been done that way in the past - the point of pseudo buttons isn't really about new windows, but the fact that there's already a submit button inside the form that's involved, typically a delete button. Often that submit button belongs to a form that does processing, but where the link would go is a separate piece of code, which means far larger changes than just the HTML.

Nao

  • Dadman with a boy
  • Messages: 16 082
Re: New revs - Public comments
« Réponse #425, le 24 Septembre 2012 à 12:14 »
Oh, yes I see... So just forget about what I said :) I just did a quick search in case you'd forgotten something etc, like I enjoy doing... It's like a morning walk you know. Getting back into the game with checking out your commits, things like that, ain't done this in a few months, a pleasure to do :eheh:

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278

Nao

  • Dadman with a boy
  • Messages: 16 082
Re: New revs - Public comments
« Réponse #427, le 24 Septembre 2012 à 14:43 »
It feels overwhelming, which is way better than feeling bored :P

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Messages: 1 670
Re: New revs - Public comments
« Réponse #428, le 26 Septembre 2012 à 02:16 »
Citation
The main reason I haven't tested it is because while I have an account that is PayPal capable, I can't pay for a subscription myself with my own account and I refuse to expect others to pay to test it on a site of mine, if that makes sense.
They have a sandbox. I would test it out if I could remember my sandbox login...

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
Re: New revs - Public comments
« Réponse #429, le 26 Septembre 2012 à 03:32 »
Yeah, I knew about that, but I wasn't sure if I could actually pay myself even in the sandbox. Since there's no harm in trying... I might as well try it!

It will also let me try out a few other things that need to be experimented with, namely looking into the bug that apparently exists with failed subscription transactions that happen for no apparent reason.
Posté : 26 Septembre 2012 à 02:27

Also, the installation is currently completed broken. Moving that if() test around in Settings.php breaks the installer, because the installer now repeatedly and consistently removes the if() and the opening { of that test.

I'll fix it sometime, but I'm deep into other stuff first.
Posté : 26 Septembre 2012 à 02:50

And on a fresh install, it always seems to me that jQuery can't be loaded from Google. This has never once worked for me on any test install I've ever made, including localhost.
Posté : 26 Septembre 2012 à 02:54

Also, I have no idea how the sandbox works, especially since it doesn't seem to handle subscription payments. It seems to be geared for much larger and more complex stuff that we're trying to do.
Posté : 26 Septembre 2012 à 03:03

After struggling along with the banality of the Sandbox, it's broken. It just tells me the address for entering PayPal was wrong, but it also flags the code before my change as wrong, which suggests sandbox mode is actually broken anyway.
Re: New revs - Public comments
« Réponse #430, le 26 Septembre 2012 à 04:10 »
OK, so after yet more digging, I find interesting things.

Recurring payments seems to be broken in SMF too.

There's still broken behaviour, but it's only partly Wedge's fault these days :P Basically, Wedge is broken right now because it always sets up the PayPal cmd as _xclick-subscriptions even when it isn't a recurring payment, so right now it will always fail. It needs to be _xclick for non-recurring and _xclick-subscriptions for recurring.

But... I just tried it on the only site I have live where I can mess about with such things, which is SMF RC3 site, and *that* fails if cmd is set to _xclick-subscriptions as well, so it's not a new issue.

I'll fix the issues I can fix my side (the template being the main one) but a more thorough debugging of PayPal is going to have to wait for another day.

Nao

  • Dadman with a boy
  • Messages: 16 082
Re: New revs - Public comments
« Réponse #431, le 26 Septembre 2012 à 15:57 »
Citation de Arantor le 26 Septembre 2012 à 03:32
Yeah, I knew about that, but I wasn't sure if I could actually pay myself even in the sandbox.
That's the whole point of the sandbox, actually... :)
Citation
Also, the installation is currently completed broken. Moving that if() test around in Settings.php breaks the installer, because the installer now repeatedly and consistently removes the if() and the opening { of that test.
Hmm, it's odd, did it work earlier...? Because it looks like those lines were already broken before I did my Settings.php change.. Anyway, line 1836, replace with:

Code: [Sélectionner]
// Remove the redirect (5 lines of code)...
if (trim($settingsArray[$i]) == 'if (file_exists(dirname(__FILE__) . \'/install.php\'))' && trim($settingsArray[$i + 1]) == '{' && trim($settingsArray[$i + 4]) == '}')
{
for ($j = $i + 5; $i < $j;)
$settingsArray[$i++] = '';
continue;
}

This is untested but it should work... (I'll be cooking up an even better version later today, that doesn't care about the length.)
Citation
And on a fresh install, it always seems to me that jQuery can't be loaded from Google. This has never once worked for me on any test install I've ever made, including localhost.
I've never had such any problem...?!
What's in your HTML head?
Citation
Also, I have no idea how the sandbox works, especially since it doesn't seem to handle subscription payments. It seems to be geared for much larger and more complex stuff that we're trying to do.
Ah, sorry, can't help... :(
Posté : 26 Septembre 2012 à 15:47

What about this one btw..?

Code: [Sélectionner]
// Remove the redirect (normally 5 lines of code)...
if (strpos($settingsArray[$i], 'file_exists') !== false && trim($settingsArray[$i]) == 'if (file_exists(dirname(__FILE__) . \'/install.php\'))')
{
$settingsArray[$i++] = '';
$tab = substr($settingsArray[$i], 0, strpos($settingsArray[$i], '{')); // It should normally be empty.
while ($i < $n - 1 && rtrim($settingsArray[$i]) != $tab . '}')
$settingsArray[$i++] = '';
$settingsArray[$i] = '';
continue;
}

--> basically, it just records the level of the first curly (so that we can find its closer easily), then it removes everything before the closer. (Also, the last $i call should ensure it doesn't increase it again because it's done through the for() loop... Oops.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
Re: New revs - Public comments
« Réponse #432, le 26 Septembre 2012 à 18:03 »
Citation
I've never had such any problem...?!
What's in your HTML head?
Well, it's a fresh install, but I'll take a proper look later.
Citation
What about this one btw..?
I'm not honestly that bothered what it replaces, provided that from a fresh install it installs without having to manually hack the Settings file...

Nao

  • Dadman with a boy
  • Messages: 16 082
Re: New revs - Public comments
« Réponse #433, le 26 Septembre 2012 à 19:59 »
I tested my code through a file() call, and it seems to work just fine... (Phew.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Messages: 14 278
Re: New revs - Public comments
« Réponse #434, le 26 Septembre 2012 à 20:05 »
Well, I'll do a fresh install and see what happens (which will check both issues at once)
« Plugin revs
Simpleportal or equivalent Portal system »