[Plugin] Notifications system (1.0)

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
The way it's meant to be

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #106, on April 10th, 2013, 10:52 PM »
Yes, I gave it permission. I may be many things but not that naive (I hope :P)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,062
[Plugin] Re: Notifications system (1.0)
« Reply #107, on April 13th, 2013, 01:55 PM »
Honestly... To me, it's a given, I will (or someone else will) add support for Chrome notifications in the future... It doesn't seem to be that hard to add, and it solves a lot of problems (including providing a mutex for each notification, allowing for multiple tabs with the same code). I, for one, would be delighted to get these notifications every time someone posts on Wedge or whatever... ;)
[Plugin] Re: Notifications system (1.0)
« Reply #108, on April 13th, 2013, 01:58 PM »
Quote from Arantor on April 10th, 2013, 10:52 PM
Yes, I gave it permission. I may be many things but not that naive (I hope :P)
So, was that sarcasm..? (I'm having a Sheldon moment here.)
Because I don't see any reason to be paranoid about this? Notifications only show up when you have a tab open with that website in it...

MultiformeIngegno

  • Posts: 1,337

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #110, on April 13th, 2013, 04:25 PM »
Quote
So, was that sarcasm..? (I'm having a Sheldon moment here.)
No, it wasn't. The question was: did I give the page permission to use notifications. Yes, I did. While many users might be like 'wut, permission? derp derp', I was aware I would need to give it permission, which I did and I told it to use my own Twitter account for testing, and as such I added a tweet and it didn't show - and yes, I left the tab open for a while.

I'm not opposed to it, but I don't really like the idea of a Webkit only feature in the core right now.

Nao

  • Dadman with a boy
  • Posts: 16,062
[Plugin] Re: Notifications system (1.0)
« Reply #111, on April 14th, 2013, 04:48 PM »
It'll soon be WebKit AND Blink only... :P
That is, enough to warrant standardization. Which, BTW, is underway... :)

Anyway.

A few issues I'm having with notification emails...

- I noticed that Notifications.php calls sendmail() with $send_html set to true. So, it does intend to transmit links, but unfortunately all I'm receiving is raw HTML, i.e. tags show up in the mail... (That's with gmail, I should add.)

- Even if we managed to have e-mails sent through HTML, there's the tiny problem of membergroups... Ever since rev 2031, member colors are no longer stored, rather groups, which is fine by me, be in an e-mail, you don't have access to the website's CSS, so these class names just return nothing. Is it worth including a link to our CSS files in the e-mails...? Hmm... I dunno...

spoogs

  • Posts: 417
[Plugin] Re: Notifications system (1.0)
« Reply #112, on May 10th, 2013, 11:25 PM »
So I just recently got my first few notifications and I actually really like how it works,

I pretty much never check my email so I did not use the previous method of being notified by email of replies, PM's, etc. Needless to say that many things have gone missed by me because eventually I forget that i wanted to keep up with a particular topic, had I been notified via email it would have yielded the same result anyway.

Once the notification system was in use here I looked at the settings and chose to not be notified via email so that was great for me, no need to get emails I'll not see for months after they've stopped being relevant right. I have surprisingly been caught up on all the topics so no particular topic struck me as need to be notified so I sat jealously and patiently by reading how nice the system was and would ya know it @Arantor liked a post of mine and boom now I can see this thing in action from a true use case perspective without having being notified just for the hell of it. Then @Nao mentions me and I got that notification as well.

I gotta say great work here @Dragooon and guys. This is how I would love to have always received notifications on forums I visit.
Stick a fork in it SMF

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: Notifications system (1.0)
« Reply #113, on May 16th, 2013, 09:52 AM »
@spoogs: Well, thank you! It's far from finished though, I have a lot of WIP stuff that still needs to be merged into SVN. Hopefully I'll get more free time by end of May.

I just had an idea though, I got a Facebook plugin that works, I can make it so that it pushes any notification on Wedge to your Facebook's notification stream. Moar notifications!

Nao

  • Dadman with a boy
  • Posts: 16,062
[Plugin] Re: Notifications system (1.0)
« Reply #114, on May 16th, 2013, 10:45 AM »
Quote from Dragooon on May 16th, 2013, 09:52 AM
@spoogs: Well, thank you! It's far from finished though, I have a lot of WIP stuff that still needs to be merged into SVN. Hopefully I'll get more free time by end of May.
And I rewrote so much of your code, it feels like Aeva Media all over again, don't you think..? I hope you're not upset by that. The fact that your code both times managed to draw my attention long enough to make it me work weeks on it (even years, in the case of SMG), should be enough, eh eh. I mean, I suck at 'starting new features', but you're good at that, and I rock when it comes to making them shine :P

Still, there's at least one of your WIPs that we need to determine whether it makes it into the main code: properly saving the avatar and member ID... Currently, Wedge uses a modified version of the original code, that dates the member data and loads it 'manually', but it would definitely benefit from taking the member ID from a dedicated field in the notifications table, which your WIP had, and Wedge doesn't (for now). I've always wondered whether I should take your patch and try to put it into the Wedge codebase, or if I should wait for you to take the Wedge codebase (which hopefully on your side has the very code we're looking for), and trim the elements that are no longer necessary once your code is taken into account...
What do you think..?

Since we're planning to release a public alpha this spring (yeah, one can always hope :P), it would be nice to have the notification code 100% complete before we do that, so that people can start writing notif plugins if they want ;)
Quote
I just had an idea though, I got a Facebook plugin that works, I can make it so that it pushes any notification on Wedge to your Facebook's notification stream. Moar notifications!
I don't use Facebook (much), so I wouldn't want it core, and generally anything that interfaces deeply with another third party is a no-no for core, but as a plugin it'd be cool, yeah!

Just like I still have that 100-year old to-do entry, "allow reposting thoughts to my Facebook/Twitter feed"... :lol:

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: Notifications system (1.0)
« Reply #115, on May 16th, 2013, 05:36 PM »
No I don't really mind, plus you've mostly worked on the UI, an area I didn't really spend time on and an area I'm not too good at so its all good and appreciated. You probably managed to make it better than I could've, so thanks for that :).

I haven't looked into the avatar stuff but I'll probably go with making it global so that its not notifier dependent with the ability for a notifier to override the default avatar as an icon. I got an idea for this just need some time to actually implement.

The Facebook part was definitely plugin stuff.

Nao

  • Dadman with a boy
  • Posts: 16,062
[Plugin] Re: Notifications system (1.0)
« Reply #116, on May 28th, 2013, 02:07 PM »
So, as I mentioned in my thoughts, I've been working on an alternative way of showing notif previews, which would work on mobile...
I'm pretty much finished with it, and it works great on mobile. It's also about 100 bytes smaller in the js.gz, and also does without the extra #notprev styling I added recently.

I'm planning to upload it here to have you guys review it and tell me what you prefer.
The main issue is, I like the current one better... :-/
The difference is, the new one doesn't work on hover but on click, meaning it's less taxing on the server, but also requires more attention to get the preview. Probably needs a visual hint that you have to click, etc...
I also modified the popup to ensure it can extend to the full window height, so I can easily add previews BELOW the notifications without making it too hard to navigate.

So... Please everyone try the current version a bit, then tell me you're ready for the new version, or something... I'll upload it, and you can start comparing ;)

MultiformeIngegno

  • Posts: 1,337
[Plugin] Re: Notifications system (1.0)
« Reply #117, on May 28th, 2013, 06:19 PM »
Uhm.. I don't know.. I think I like this version too. Maybe the only note is that it takes almost 1 second the first time to load the animation...

Nao

  • Dadman with a boy
  • Posts: 16,062
[Plugin] Re: Notifications system (1.0)
« Reply #118, on May 28th, 2013, 06:29 PM »
Actually, I added a 0.3s delay to avoid sending needless Ajax requests to the server... ;)

MultiformeIngegno

  • Posts: 1,337
[Plugin] Re: Notifications system (1.0)
« Reply #119, on May 28th, 2013, 06:34 PM »
Quote from Nao on May 28th, 2013, 06:29 PM
Actually, I added a 0.3s delay to avoid sending needless Ajax requests to the server... ;)
But only the first time, right? After the first click it's instantaneous. The delay makes it seem sluggish.. :P