[Plugin] Notifications system (1.0)

Nao

  • Dadman with a boy
  • Posts: 16,061
[Plugin] Re: Notifications system (1.0)
« Reply #120, on May 28th, 2013, 06:42 PM »
Nope, there's always this delay... Although if you'd start switching between notification items, once they're all loaded, it'd be quicker to load because they're all cached in memory.

Anyway-- I've uploaded the alternative version, which as I said, has the advantage of working just the same on mobile devices.
Click anywhere inside a notification to expand it. Err, just don't click on the links, though, obviously... ;)

Opinions, please..!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #121, on May 28th, 2013, 06:45 PM »
I like it :) Gut reaction is that 1) it's not clear that we need to click on it, 2) no ability to collapse them again, 3) it does feel a little sluggish clicking on it without some kind of visual feedback that it's loading.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,061
[Plugin] Re: Notifications system (1.0)
« Reply #122, on May 28th, 2013, 06:52 PM »
1/ As I said. And, well, if I settle on this, I'll really add some kind of visual hint...
2/ Yeah, I know, but I felt it wasn't that useful... If you noticed that too, then I guess I should add it. It's just a few bytes of JS...
3/ Hmm, yeah. But calling the Ajax loader might be overkill, I don't know..?

So, do you prefer this one or the previous..? You can always check from the repo to compare, if you need, or I can re-upload the SVN version. (It's just three changed files, really...)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #123, on May 28th, 2013, 06:54 PM »
I prefer this one, this works on mobile and feels more natural. However, I might be inclined to suggest we do some kind of cut on the preview text simply because it's kinda big in some cases. For example I got a like on one of my New Revs posts which was pretty lengthy and it only just fits on the screen vertically when wrapped into that width.

Nao

  • Dadman with a boy
  • Posts: 16,061
[Plugin] Re: Notifications system (1.0)
« Reply #124, on May 28th, 2013, 07:01 PM »
Quote from Arantor on May 28th, 2013, 06:54 PM
I prefer this one, this works on mobile and feels more natural.
I could possibly have both -- and determine which to show depending on the device, but it would probably be wiser to keep it simple.
Quote from Arantor on May 28th, 2013, 06:54 PM
However, I might be inclined to suggest we do some kind of cut on the preview text simply because it's kinda big in some cases. For example I got a like on one of my New Revs posts which was pretty lengthy and it only just fits on the screen vertically when wrapped into that width.
It should be creating a scrollbar, then..?

And as you can see, I rewrote the code to allow for the popup to extend to the window boundaries, and create a scrollbar if it goes beyond that. Actually, I don't know why I didn't do it like this in the first place...

PS: sorry for the bug with select box padding. I'll fix that soon. It's a debug thing...

godboko71

  • Fence accomplished!
  • Hello
  • Posts: 361
Thank you,
Boko

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,061
[Plugin] Re: Notifications system (1.0)
« Reply #127, on May 28th, 2013, 07:16 PM »
Well, that's normal... Apparently, that's a very, very long post... :lol:

Anyway -- enabled the 'click to fold' effect. Adds 17 bytes, thought I could do it with less... Ah, well.

Also, has the show_ajax() stuff. I really need to rewrite this into a positioned (centered by default) animation... Like for Zoomedia, see..?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #128, on May 28th, 2013, 07:23 PM »
See, that's why I suggested a cut on the string ;) Since if it's a shorter string, it won't be a huge thing like this...

Nao

  • Dadman with a boy
  • Posts: 16,061
[Plugin] Re: Notifications system (1.0)
« Reply #129, on May 28th, 2013, 11:13 PM »
A cut? You mean, having to actually visit the topic to see the full post? Meh...

So, I've committed the update. Everyone happy with it..?
I'm a bit disappointed with the size savings (even after I saved an additional 10+ bytes with a small rewrite in notload(), *sigh*), but it's still better than nothing..! I'm just too much of a bytenazi, I guess...

Bed time!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #130, on May 28th, 2013, 11:49 PM »
Supposing the post has, I dunno, a couple of YouTube videos in it? Suppose it's a dirty great long post... there are plenty of posts of mine on this forum that, when shrunken into that width, certainly wouldn't fit on the page... it's supposed to be a preview, not an alternative thread view.

icari

  • Posts: 88
[Plugin] Re: Notifications system (1.0)
« Reply #131, on May 28th, 2013, 11:54 PM »
i have not had to really see how the notification system works that well, but does that preview also parse bbc? it might be worth not parsing bbc especially if it only shows a small preview of a message

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

icari

  • Posts: 88
[Plugin] Re: Notifications system (1.0)
« Reply #133, on May 29th, 2013, 01:49 AM »
it did not include the text of the message, interesting. also with the delay on loading the popup i thought it was not going to come up at all or i had clicked in the "wrong" spot.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #134, on May 29th, 2013, 02:02 AM »
You have to click on the bit that isn't the wording for it to show up... it won't just include the full message of the text straight off...