Recent Posts
1
Features / Re: New revs
« on April 22nd, 02:31 PM by Nao »
[Commit revision ef31bf6]
Author: Nao
Date: Sat, 22 Apr 2017 14:31:26 +0200
Stats: 2 files changed; +3 (insertions), -1 (deletion)

  • Search members by IP was broken (presumably due to Pete upgrading the IP system to support IPv6.) (ManageMembers.php)
  • Removing an error suppressor that I suspect should be unneeded now. (Subs-Cache.php)
2
Features / Re: New revs
« on April 21st, 07:37 PM by Nao »
[Commit revision 26be97f]
Author: Nao
Date: Tue, 18 Apr 2017 17:57:01 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Updated Gravatar URLs to cooperate with https mode. (Subs.php)

[Commit revision 132545d]
Author: Nao
Date: Fri, 21 Apr 2017 19:36:30 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Some stuff I don't know about. Don't ask me, I never touched that place. It's full of cobwebs. (ManageMail.template.php)

[Commit revision 7c269a1]
Author: Nao
Date: Fri, 21 Apr 2017 19:37:43 +0200
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Dropdowns would fail to open in case they had the 'multiple' attribute and no pre-selected entry. (sbox.js)
3
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 20th, 01:48 AM by Suki »
I pop up every once in a while and since I'm dealing with the same thing myself I chime in.


I wouldn't use bcrypt on the client side, too much of an issue and as far as I know it wasn't designed to do hashing but to encrypt.  Besides, everyone is going towards https so client hashing will become less of an issue.

So, use bycrypt yes but on server side only.
4
Features / Re: Language revs
« on April 19th, 12:04 AM by Nao »
I also merged your topic-solved commits.
Quote from Freñiçh on April 18th, 07:40 PM
Well i am sorry it was not my intention to cause you so much trouble,but i can't upload files directly into language/Dutch because file uploads require push access to your repository.
Well, obviously that's the pull request system. (?)
Quote
So i compare base fork with the head fork,and drag the remaining files into my repository.(Github is what concerns to me a struggle but i am trying to understand the logic behind it )
Yeah, it's quite a bit painful, I had to go through that too, but multiply by 1000 because I also had to rebase stuff, rewrite tons of commits through the command line... It took me weeks of work, just to get it to what it is now. :^^;:
5
Features / Re: Language revs
« on April 18th, 11:59 PM by Nao »
[Commit revision db90bfd]
Author: Nao
Date: Tue, 18 Apr 2017 23:59:26 +0200
Stats: 2 files changed; +0 (insertion), -179 (deletions)

  • Nearly there! ;) (ManageScheduledtasks.dutch.php, dutch/license.txt)
6
Features / Re: Language revs
« on April 18th, 11:57 PM by Nao »
[Commit revision cf3ba32]
Author: French77
Date: Tue, 18 Apr 2017 23:57:28 +0200
Stats: 22 files changed; +3417 (insertions), -0 (deletion)

  • remaining dutch language files (#75)
  • ManageScheduledtasks.dutch.php
  • Upload remaining files
  • Dutch language
7
Features / Re: Language revs
« on April 18th, 07:40 PM by Freñiçh »
Quote from Nao on April 17th, 05:21 PM
I'm absolutely for any new translations.

All I want is a clean repo with just a single commit for all of your files. That's all... Just create a new repo locally from Github, move your new files to the dutch folder, right-click them all, "Add", then commit, and send a single pull request (you can do that one from the Github website as long as it knows your repo is forked from mine, IIRC). It's really easy... It just takes a couple of minutes. Not the couple of hours it took you to upload everything manually...
Well i am sorry it was not my intention to cause you so much trouble,but i can't upload files directly into language/Dutch because file uploads require push access to your repository.

So i compare base fork with the head fork,and drag the remaining files into my repository.(Github is what concerns to me a struggle but i am trying to understand the logic behind it )

Create a new branch for this commit and start a pull request named remaining dutch language files.
4 commits are still open (just don't now how to deleted the first 3 commits),but the last one ¨Upload remaining files¨ remains all the not yet added dutch language files.
8
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 18th, 01:46 PM by Nao »
Hi Suki/Marceline! Hadn't seen you here in 3 years ;)

So, you guys think I should use something like that..?
https://github.com/dcodeIO/bcrypt.js/blob/master/dist/bcrypt.js

I'd suggest using the bcrypt parameter explicitly so that if Wedge is ever abandoned, it doesn't break completely.

(Unless I really don't understand the problem...)
9
Features / Re: New revs
« on April 18th, 01:42 PM by Nao »
[Commit revision 5973dac]
Author: Nao
Date: Tue, 18 Apr 2017 13:42:43 +0200
Stats: 1 file changed; +12 (insertions), -9 (deletions)

  • Don't bother with backslashes inside comments, PHP ignores them anyway. (Subs-CachePHP.php)
  • PHP single-line comments can be 'stopped' by a ?> sign, this should fix it. However I haven't seen multi-line comments behave the same, so I'm leaving those aside for now. Would appreciate some feedback, but it's no big deal since ?> is barely used in Wedge. (Subs-CachePHP.php)
  • This actually fixes a bug (and only one) in Wedge-- that occurred when sending non-HTML posts in French. It was broken for the last 3 years, and I never understood why. Now I know. Someone at SMF used a backslash at the end of a comment. The fools.
10
Features / Re: Language revs
« on April 18th, 01:28 AM by Nao »
I'm not trying to frustrate anyone. Just trying to frustrate *me* as little as possible. :P