Recent Posts
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 18th, 2017, 01:46 PM by Nao »
Hi Suki/Marceline! Hadn't seen you here in 3 years ;)

So, you guys think I should use something like that..?

I'd suggest using the bcrypt parameter explicitly so that if Wedge is ever abandoned, it doesn't break completely.

(Unless I really don't understand the problem...)
Features / Re: New revs
« on April 18th, 2017, 01:42 PM by Nao »
[Commit revision 5973dac]
Author: Nao
Date: Tue, 18 Apr 2017 13:42:43 +0200
Stats: 1 file changed; +12 (insertions), -9 (deletions)

  • Don't bother with backslashes inside comments, PHP ignores them anyway. (Subs-CachePHP.php)
  • PHP single-line comments can be 'stopped' by a ?> sign, this should fix it. However I haven't seen multi-line comments behave the same, so I'm leaving those aside for now. Would appreciate some feedback, but it's no big deal since ?> is barely used in Wedge. (Subs-CachePHP.php)
  • This actually fixes a bug (and only one) in Wedge-- that occurred when sending non-HTML posts in French. It was broken for the last 3 years, and I never understood why. Now I know. Someone at SMF used a backslash at the end of a comment. The fools.
Features / Re: Language revs
« on April 18th, 2017, 01:28 AM by Nao »
I'm not trying to frustrate anyone. Just trying to frustrate *me* as little as possible. :P
Features / Re: New revs
« on April 18th, 2017, 01:27 AM by Nao »
[Commit revision e80acb5]
Author: Nao
Date: Tue, 18 Apr 2017 01:27:11 +0200
Stats: 1 file changed; +12 (insertions), -20 (deletions)

  • Two new techniques for the key-value file cache, to combat possible race conditions. First of all, Wedge will no longer attempt to delete an expired file when it sees it expired. It's the script's responsibility to regenerate the cache (and thus the file) when it gets an invalid result (also, this saves more bytes, and I like saving bytes). Secondly, files are now created under a random name (like in Subs-CachePHP.php), and then renamed if everything works. This should help in a LOT of situations. And I'm serious. Just like I fixed race condition issues with the PHP minifier, I'm hoping this will also be the case here, although it happens much less often-- in fact the only reason I fought this is because Opera Chromium is bloody running two queries on my site at the exact same millisecond, even if I didn't ask for that. For once, it's Opera's fault. (Subs-Cache.php)
  • Seriously, someone should report that to them... Opera is actually loading Atom feeds even though I never added them to my feed list.
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 18th, 2017, 01:09 AM by Suki »
If there are any changes, it will be known pretty early, any change in the default algo will be made in the next full release after a proposed algo was included. Plenty of time IMO.

And you will always know what thing was changed and to what. Theres a similar problem if you chose an user defined algo, sooner or later you will have to upgrade your script to get rid of obsolete ones.
Features / Re: Language revs
« on April 17th, 2017, 09:25 PM by CerealGuy »
@Freñiçh  If you need help with git, feel free to ask. Git has a steep learning curve but is absolutly worth learning it.
Features / Re: Language revs
« on April 17th, 2017, 05:21 PM by Nao »
I'm absolutely for any new translations.

What I'm against, however, is wasting time. So, if you want your translations to be in the main languages repo, you should learn how to handle Github and pull requests. That's all.
Yesterday you sent empty pull requests. Today you sent one pull request *per* file, meaning I got an e-mail notification for each of those. When I started accepting the pull requests, I then realized the files were all committed to the root folder (which is NOT for anything other than English files, this isn't SMF, this is Wedge, where files are carefully sorted in language folders!) So I had to do another commit to put them all into place. You also committed a junk file in the lot. It's a real mess. So I said, I'll stop merging your PRs, yet you kept sending them so at the end I just canceled them all.

All I want is a clean repo with just a single commit for all of your files. That's all... Just create a new repo locally from Github, move your new files to the dutch folder, right-click them all, "Add", then commit, and send a single pull request (you can do that one from the Github website as long as it knows your repo is forked from mine, IIRC). It's really easy... It just takes a couple of minutes. Not the couple of hours it took you to upload everything manually...
The Pub / Re: Question about SHA1/256 (github issue #60)
« on April 17th, 2017, 05:20 PM by CerealGuy »
Quote from Nao on April 16th, 2017, 04:13 PM
If I do password_hash() with PASSWORD_DEFAULT, then it means I can't be sure what algorithm will be used to hash the password, right..?

So, how exactly can I hash the password on the client side if I don't know which kind of crypt system PHP will use to compare it with my own hash...?
As long as you always hash it with the same algorithm on client side, it wouldn't matter, because you always hash it again on server side. The problem i see is that the unclear nature of password_hash() would result in inconsistencies across different php versions. So you couldn't use a backup from a newer php version on one with a server with an older php version.
Features / Re: Language revs
« on April 17th, 2017, 02:40 PM by Freñiçh »
Quote from Nao on April 17th, 2017, 02:19 PM
@Freñch, please stop committing individual files and sending pull requests for those!
Also, move them to the proper folder!
What do you mean it looks like you don't want the dutch translations (first you don't react on pull request and then you ask for zip files) i create new files again and send them with pull request.

 :edit: Also committing language files plugins topic_solved
Features / Re: Language revs
« on April 17th, 2017, 02:22 PM by Nao »
[Commit revision 5a0dc43]
Author: French77
Date: Mon, 17 Apr 2017 14:06:39 +0200
Stats: 1 file changed; +658 (insertions), -0 (deletion)

  • Create index.dutch.php (#41)