Plugin revs

Nao

  • Dadman with a boy
  • Posts: 15,969
Plugin revs
« on June 16th, 2012, 04:15 PM »
I thought that it's best to centralize revisions for the plugin depository as well... (Didn't do it until now because, well, I wasn't even sure there was a plugin depo... :P)

rev 37
(7 files, 3kb)

! [users_online_today] Harmonized visible/hidden numbers for both moderators and regular members. (OnlineToday.php)
! [pm_flash] Fixed JavaScript to use the newest DOM. (PersonalMessageFlash.php)
! [theme_selector] Fixed wedge_show_skins to use newest version without level param. (ThemeSelector.php)
* [theme_selector] Adapted skin selector to sidebar code standards, added a language string in case we want to offer positioning. (ThemeSelector.php)
* [theme_selector] Simplified JS code. A lot. Tested to work, but who knows... (ThemeSelector.php)
Re: Plugin revs
« Reply #1, on June 16th, 2012, 04:38 PM »
Just so you know -- the topic isn't locked for now. As long as the rev number doesn't equate the number of posts, it doesn't matter anyway. After that, we'll see :P It's not as important as for New Revs...

rev 38
(5 files, 4kb)

! [theme_selector] Last minute bug, and even more JS code reduction... Now it's pretty much what it should have been looking like, I think. (ThemeSelector.php)

* [flitter] Updated Flitter to latest developments (and added French, frontend only for now). Although, as of now, it still refuses to show up. This seems to demonstrate a bug in wetem, I'll have to look into it when I have more time. (Flitter-Main.php, Flitter-Main.template.php)
Re: Plugin revs
« Reply #2, on June 16th, 2012, 04:50 PM »
rev 39
(16 files, 6kb)

* Spacinazi. Extra tabs and spaces removed. CRLF files converted to LF. Ätsch! (16 files, not going to list them -- dunno if some are 'surprise' unannounced plugins coming up...)

PS: I hate it when we include an external file that's horribly written... In that respect, the recaptcha lib may suck even more than the feature it implements...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Plugin revs
« Reply #3, on June 16th, 2012, 04:57 PM »
ReCAPTCHA sucks anyway, but there you go.

I do have some half-done plugins on my PC, but I think I announced every plugin in the repo as it currently stands.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 15,969
Re: Plugin revs
« Reply #4, on June 16th, 2012, 10:33 PM »
All right.

Flitter is a PITA. It showed me that I had a BIG bug in wetem -- it took me a while to spot it, but it was due to how I was setting up $has_layer. I did all of my tests with an array with a block in it. In this case, it will work. However, doing wetem::add('someday_my_prince', array('will_come' => array())) will not work because COUNT_RECURSIVE will count empty arrays as zero item, thus failing the test. I did it differently and now it works, phew. (Of course I could also have changed the call to a simpler wetem::layer(), but I want all of my functions to be generic as much as possible.)

Now I'm having trouble showing the above/below functions for the new layer... Dunno why, it's just not showing (probably something that fails to register in plugin mode.)
I'm taking a break and leaving the option enabled so you can play with the Like buttons if you'd like. I'll resume work on this later tonight or tomorrow. And hopefully commit everything...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Plugin revs
« Reply #5, on June 16th, 2012, 10:57 PM »
Well, that's interesting. I'm sat here on OS X, with Chrome and like always I have the window narrow enough to have the sidebar at the foot of the page rather than the side.

The consequence of all this is that the Like / +1 buttons cause an interesting misalignment. Quick Access is then floated to the right, crossing between the first two columns, and the latest posts feed block is aligned to that.

Then the skin selector is below that. I'd do a screenshot but not sure how best to achieve it in OS X yet...

Nao

  • Dadman with a boy
  • Posts: 15,969
Re: Plugin revs
« Reply #6, on June 17th, 2012, 01:09 AM »
Quote from Arantor on June 16th, 2012, 10:57 PM
Well, that's interesting. I'm sat here on OS X, with Chrome and like always I have the window narrow enough to have the sidebar at the foot of the page rather than the side.
Same here. I think we already talked about it eheh. I'm in 1280x1024 and always have my tab bar in a vertical pane on the left, leaving me with about 100px in width and I prefer to have my sidebar out of the way. It looks good in any case.
I really need to change Wine and children to move it to the bottom as well, instead of that cool-looking but not very accessible popup...
Quote
The consequence of all this is that the Like / +1 buttons cause an interesting misalignment. Quick Access is then floated to the right, crossing between the first two columns, and the latest posts feed block is aligned to that.
Yeah, that's because of the missing layer functions...
But I found out what was wrong. It was simply using the 'old' style, i.e. _above and _below, while I'd argued that it could be misleading regarding special layouts, and renamed them to _before and _after instead.

Now it's all working... :)
I'd just like to vertically align both divs now...
Quote
Then the skin selector is below that. I'd do a screenshot but not sure how best to achieve it in OS X yet...
They don't have a Print Screen key? :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Plugin revs
« Reply #7, on June 17th, 2012, 01:12 AM »
Um, I don't have a Prt Sc key on this keyboard because it's the MacBook Pro keyboard, so there's no numeric keypad either... Prt Sc on Windows is carried out with Shift-Fn-F11 but I don't think it works on OS X and I can't remember how to do screenshots otherwise, heh.

Aaron

  • Posts: 356
Re: Plugin revs
« Reply #8, on June 17th, 2012, 01:36 AM »
Quote from Arantor on June 17th, 2012, 01:12 AM
Um, I don't have a Prt Sc key on this keyboard because it's the MacBook Pro keyboard, so there's no numeric keypad either... Prt Sc on Windows is carried out with Shift-Fn-F11 but I don't think it works on OS X and I can't remember how to do screenshots otherwise, heh.
You can make a screenshot with Cmd+Shift+{3,4}, where 3 will take one of the entire screen and 4 allows you to select a region or a window -- the latter requiring you to press space before clicking a window (the cursor changes, too).
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Plugin revs
« Reply #9, on June 17th, 2012, 02:54 AM »
Awesome, thanks :)

* Arantor is still a bit new to OS X and tends to spend his time on Windows where all his better games are :P

Nao

  • Dadman with a boy
  • Posts: 15,969
Re: Plugin revs
« Reply #10, on June 17th, 2012, 12:38 PM »
Got some stuff to commit in Skin selector & Flitter... As you can see they're mostly fixed in here. But it also forces me to commit fixes to Wedge itself, and there are enough to warrant a small wait time until I can devote myself to the process. I'm always busy on Sundays... :(
Re: Plugin revs
« Reply #11, on June 17th, 2012, 06:02 PM »
rev 40
(3 files, 5kb)

! [flitter] Updated Flitter to the new code: proper layer creation, _before and _after instead of _above and _below, vertical alignment, add_js(), etc... (Flitter-Main.php, Flitter-Main.template.php)

! [theme_selector] Fixed duplicate 'selected' options, and some incorrect HTML5. (My bad.) (ThemeSelector.php)
Re: Plugin revs
« Reply #12, on June 19th, 2012, 06:19 PM »
rev 41
(1 file +1, 3kb)

! [edit_history] Fixed to use the new mini-menu system. (History-Topic.php)
+ [edit_history] Added French version. (EditHistory.french.php)
Re: Plugin revs
« Reply #13, on July 12th, 2012, 03:35 PM »
rev 42 (oh yeah...)
(1 file, 1kb)

! [theme_selector] Disable the skin selector if we're in a board that forces an override. (ThemeSelector.php)
Re: Plugin revs
« Reply #14, on August 1st, 2012, 01:07 PM »
rev 43
(1 file, 1kb)

! [theme_selector] Fixed plugin with the recent weUrl() rewrite. (ThemeSelector.php)