Recent Posts
21
#Who.english.php <->Website credits page
No referral to the secure connection (SSL server certificate) wedge.org and this also applies to the license and authors reference

$txt['credits_wedge'] = 'Wedge is copyright © %5$s by %1$s, all rights reserved. It is distributed under the Wedge license.';

When for example change the link into:
$txt['credits_wedge'] = '<a href="https://wedge.org/"target="_blank">Wedge is copyright © %5$s by %1$s,all rights reserved. It is distributed under the Wedge license.';

Referral to the secure connection https://wedge.org/ is then oké.

 :edit: Also includes almost all links in Homepage Wedge.org
22
Bug reports / Re: Couple things to look into...
« on March 19th, 12:29 AM by Nao »
Quote from CerealGuy on March 18th, 08:20 PM
Will definetly look into the login thing, unread topics also but less priority.
Thanks!

Also, looks like your subs-bbc commit is broken... At the very least, 'list' or 'cli' tags aren't working properly (see New Revs topic). Dunno if it's a problem during the rewrite for 'list', or a problem with external custom bbcode not loading at all.
Quote
There are some things which bug me about login (besides sha256):
- no js counter for failed logins, i find myself quite often on the "you have to wait before you can try to login again" error page.
I don't know, TBH with LT I only use Steam Connect (i.e. OpenID) to handle users, so no one has to enter passwords on the site. So I don't really have a reason to look into this ahah.
Quote
- after x failed logins this error page should first show up, for me it shows up after the first try
Ah, really?
Quote
- no redirect of $_POST content, i often loose posts because my session timed out. Don't know if this should get solved on login or in editor. Have to think about that.
I thought $_POST got kept, actually...?
Quote
- notification on x failed logins for the user would be cool, maybe plugin stuff.
Yeah, more likely.
23
The Pub / Re: PHP 5.4?
« on March 19th, 12:26 AM by Nao »
Implemented.
Go crazy with [ ] now ;)
Also removed all magic quote shit. It felt good!
24
Features / Re: New revs
« on March 19th, 12:22 AM by Nao »
[Commit revision f2ba207]
Author: Nao
Date: Sun, 19 Mar 2017 00:22:20 +0100
Stats: 13 files changed; +18 (insertions), -90 (deletions)

  • Removed support for PHP 5.3.x, which hasn't been patched in years. Going for 5.4 now, may even go higher if I ever find a reason to do so. Please, upgrade to PHP 7 if you're still on one of these slow 5.x versions. Faster PHP means happier visitors. (README.md, SSI.php, Class-DB.php, Class-SFTP.php, Errors.php, Memberlist.php, OriginalFiles.php, QueryString.php, Subs-Plugins.php, getid3.php, index.php, install.php, readme_install.html)
  • Note: magic quote functions were removed in PHP 5.4, so Wedge no longer has to deal with these. :-D (Plenty of occurrences removed.)
  • Note: there was also a typo in Memberlist.php (which, for once, was my own fault), causing an 'escape route' to be bypassed instead of executed on PHP 5.4+.
25
The Pub / Re: PHP 5.4?
« on March 18th, 10:50 PM by Nao »
I'd started doing something quick'n'dirty in just two lines of code, but then it started getting complicated, even with just two lines, so I give up for now. :P

I'd rather stick to the lowest 'acceptable' version that Wedge actually supports.
If I start asking for a higher version, I'll start using "??" as a replacement to "?:" (basically removes the need to do an isset() call), and then I'll start wondering if I shouldn't ask for PHP 7.1 support so that I can do [$foo, $bar] = func(); instead of list ($foo, $bar) = func(), but I'm NOT actually using list() much in Wedge, so who cares about that... :P

Well yeah, so I guess PHP 5.4 is doable, just hoping that no one currently using Wedge will be locked out of it. I'm surprised no one replied to the poll though. ^^
26
The Pub / Re: PHP 5.4?
« on March 18th, 09:14 PM by Johnny54 »
http://php.net/supported-versions.php
Everything older then 5.6 is EOL and no longer supported. Not even security updates so I would drop them.

The past half year I bombarded my cheap hosting provider to finally dump 5.5 and install at least 5.6x
He did and I can now choice between 5.6x and 7.x :eheh:
27
Bug reports / Re: Couple things to look into...
« on March 18th, 08:20 PM by CerealGuy »
Will definetly look into the login thing, unread topics also but less priority.
There are some things which bug me about login (besides sha256):
- no js counter for failed logins, i find myself quite often on the "you have to wait before you can try to login again" error page.
- after x failed logins this error page should first show up, for me it shows up after the first try
- no redirect of $_POST content, i often loose posts because my session timed out. Don't know if this should get solved on login or in editor. Have to think about that.
- notification on x failed logins for the user would be cool, maybe plugin stuff.
28
The Pub / Re: PHP 5.4?
« on March 18th, 08:06 PM by CerealGuy »
I guess we can safely increase it to 5.6 even if we should recommend php7 just because it's noticeable faster. Sure, the thing with php versions is always the slow upgrade of webspace providers but do we have to care about them? Do we have the manpower to support old/outdated php versions? Does it even make sense?
29
The Pub / Re: PHP 5.4?
« on March 18th, 02:30 PM by Freñiçh »
Quote from Nao
Since Wedge is 5.3+, maybe it's safe to simply up the min reqs to 5.4..?
Well PHP 5.3 is by far the slowest PHP version,PHP 5.4 and PHP 5.5 are slightly faster,(all approaching end of life and upgrading is advisable),PHP 5.6 however is the old stable version,so i would say minimum recommended PHP 5.6
30
The Pub / PHP 5.4?
« on March 18th, 01:02 PM by Nao »
Since Wedge is 5.3+, maybe it's safe to simply up the min reqs to 5.4..?

The main advantage is the ability is use [ ] instead of array( ) inside the code. It's really just that.
I could also modify Subs-CachePHP.php to automatically replace [ ] with array() as needed. I can't be arsed for now.

I just checked, and 5.3+ is supported by ~90% of the user base, and 5.4+ by ~70%... Hmm. Then again-- what we care about is the current userbase, as I've long given up on turning Wedge into a popular engine. It's just the cool engine that people in the know use.

Anyway, I'm likely to go for PHP 5.4 + some support for PHP 5.3, but I can't be arsed to code said support for now. ;)