Wedge

[Commit revision bbfbddb]
Author: Nao
Date: Fri, 14 Mar 2014 00:30:55 +0100
Stats: 12 files changed; +103 (insertions), -116 (deletions)

• Dear human beings; this is a major overhaul of the banner area in all of my skins. (index.template.php, script.js, index.css, sections.css, Warm/extra.css, Wilde/extra.css, Wine/extra.css, Wuthering/extra.css, extra.ie6.css, install.css, install.php, readme_install.html)
•  Renamed #upper_section to #banner. Makes sense.
•  Using different margins per skin was a bad idea, and not very responsive, so I'd wanted to change that for a long time. The default is now just two barely styled h1/#slogan elements, and they use different techniques to achieve different positioning across all skins. It makes for an interesting study for those who are into CSS, I suppose.
•  Banners are now elastic vertically in Weaving, Wilde and associated mobile versions. The reason it's not in Wine and its children Warm and Wuthering, is because Wine is using a static background of a fixed height (100px), so I'm sticking to a static height for it.
•  The h1 tag is now styled alone, without any preceding classes or IDs. This is because it's only used in one place (forum title); even though HTML5 allows for multiple h1 tags, I prefer not to bother.
•  Wine now uses CSS's multiple backgrounds feature. Well, what then?
•  Also updated install scripts, although they were unrelated to begin with.
• Needs more testing. I did a LOT of that over the weeks I spent on this rewrite, but I have a feeling something's gonna fail sooner than later.

[Commit revision ba2f5d8]
Author: Nao
Date: Fri, 14 Mar 2014 11:01:03 +0100
Stats: 1 file changed; +0 (insertion), -8 (deletions)

• Some remaining outdated banner CSS. (extra.rtl.css)

---

[Commit revision 7b5aeca]
Author: Nao
Date: Fri, 14 Mar 2014 11:02:18 +0100
Stats: 1 file changed; +3 (insertions), -4 (deletions)

• A file was still using the old copyright layout. (Subs-PrettyUrls.php)

---

[Commit revision c421731]
Author: Nao
Date: Fri, 14 Mar 2014 11:12:30 +0100
Stats: 1 file changed; +5 (insertions), -0 (deletion)

• Added a mixin that enables hardware acceleration on any selector. Usage: selector mixes .hardware -- simple enough. I'm open to suggestions on how to improve it. The backface-visibility thing doesn't help performance on my Android device, but it probably does on older OSes. (common.css)

---

[Commit revision e79d0b1]
Author: Nao
Date: Fri, 14 Mar 2014 15:19:46 +0100
Stats: 6 files changed; +7 (insertions), -12 (deletions)

• Removed a few outdated CSS classes (.css and .hove). (Warm/extra.css, Wilde/extra.css, Wilde/extra.ie6.css, Wuthering/extra.css, Wuthering/extra.ie6.css, extra.rtl.css)

---

[Commit revision 15630ef]
Author: Nao
Date: Fri, 14 Mar 2014 15:44:01 +0100
Stats: 1 file changed; +63 (insertions), -61 (deletions)

• Reordered main menu CSS to make most of it part of the .menu class definition. (index.css)
• Menu text selection is now forbidden via CSS, rather than through JS. (index.css)

---

[Commit revision 8fe99a0]
Author: Nao
Date: Fri, 14 Mar 2014 15:45:28 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

• Added hardware acceleration for notification popups. See..? That was easy. Try to do that everywhere you have a scrollable element. (index.css)

[Commit revision 751384a]
Author: Nao
Date: Fri, 14 Mar 2014 21:34:00 +0100
Stats: 1 file changed; +5 (insertions), -1 (deletion)

• Ensuring that logos don't get out of bounds if used in a Wine, Warm or Wuthering banner. (Wine/extra.css)
• Note that you can change the banner height with the $banner_height variable. It's currently set to 100px, which is the height of that nice little banner I have for Wine and Warm.

[Commit revision 4128eed]
Author: Nao
Date: Sat, 15 Mar 2014 10:06:58 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

• Wess already supports backface-visibility's prefix handling. (common.css)

---

[Commit revision e5d32ea]
Author: Nao
Date: Sat, 15 Mar 2014 10:10:01 +0100
Stats: 1 file changed; +2 (insertions), -3 (deletions)

• Removed tabindex helpers from sel_* select boxes in the post editor. Why, should you ask..? Because they're in the way. If you switch from title to body with the tab key, you'll end up hitting at least two barely used select boxes first, and it's a PITA. Seriously, I'm not going to help 'accessibility' by allowing easier access to features that get in the way of actual productivity. If you customize font faces for all your posts, you have a problem. (Class-Editor.php)

---

[Commit revision 8d76189]
Author: Nao
Date: Sat, 15 Mar 2014 10:15:56 +0100
Stats: 6 files changed; +24 (insertions), -11 (deletions)

• Added a new helper function, strhas(), which is the equivalent of strpos() !== false, but also supports arrays of strings, to avoid multiple strpos tests, or even worse -- preg_match tests, which are so much slower than strpos calls (actually, the more calls, the faster strpos gets.) (Subs.php)
• Replaced some obvious culprits with strhas. I'm sure you'll agree that it rocks, at this point. Or you won't care. Which is more likely. (Class-CSS.php, Class-System.php, Login.php, Login2.php, Security.php)

[Commit revision 59cb728]
Author: Nao
Date: Sat, 15 Mar 2014 18:08:53 +0100
Stats: 3 files changed; +9 (insertions), -19 (deletions)

• More fixes and tweaks to the banner area. (Warm/macros.xml, Wilde/extra.css, index.css)

---

[Commit revision 00ddf19]
Author: Nao
Date: Sat, 15 Mar 2014 18:11:18 +0100
Stats: 1 file changed; +4 (insertions), -4 (deletions)

• My old iPod 4 doesn't like notification backgrounds, so I'm adding an exception for it. I don't know enough anymore about iOS to be able to do better than that. I'm just trying to make the homepage watchable everywhere I can test it. (index.css)

---

[Commit revision 133e7d8]
Author: Nao
Date: Sat, 15 Mar 2014 18:14:47 +0100
Stats: 1 file changed; +6 (insertions), -1 (deletion)

• Disable the tap highlighter on mobile devices for main menus and contextual menus. It was especially horrible in Android's stock browser. (index.css)

[Commit revision e27bd50]
Author: Nao
Date: Sat, 15 Mar 2014 20:35:12 +0100
Stats: 14 files changed; +18 (insertions), -19 (deletions)

• More strpos to strhas updates. The one in Subs-Cache, in particular, is really cool. (Class-DB, Class-DBHelper, Class-Editor, Class-System, Feed, Load, ManageErrors, Subs-Auth, Subs-BBC, Subs-Cache, Subs-Members, Subs-Template, Subs, media/Aeva-Embed)

---

[Commit revision 53fcfe9]
Author: Nao
Date: Sun, 16 Mar 2014 00:20:02 +0100
Stats: 2 files changed; +3 (insertions), -22 (deletions)

• Wedge didn't actually need the $oldurl fix being postponed to loadTheme. I was careful in moving as much processing to cleanRequest() as I could, but I left board-related fixes to loadTheme, which I didn't have to, because (1) moderator links are actually based on the https://wedge.org/index.php pseudo-constant, not on an outdated URL, and (2) at that point, the new URL was already active, and thus 'theme' data was up to date as well. Tsssk. (Load.php, QueryString.php)

[Commit revision 4f321a2]
Author: Nao
Date: Sun, 16 Mar 2014 20:12:40 +0100
Stats: 4 files changed; +38 (insertions), -29 (deletions)

• Split cleanRequest() into two different functions: one for path fixes, and one for query string fixes. Also changed the source code to run these two functions from within loadSettings, rather than index/SSI. (index.php, SSI.php, Load.php, QueryString.php)

[Commit revision e340092]
Author: Nao
Date: Sun, 16 Mar 2014 22:10:29 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

• Typo in the folder check code. Honestly, I have no idea why it worked so far... (index.php)

---

[Commit revision 0dd259e]
Author: Nao
Date: Sun, 16 Mar 2014 22:24:54 +0100
Stats: 1 file changed; +64 (insertions), -60 (deletions)

• Don't load login & register-related CSS if you're logged in. Because you'll never get to use it anyway. Duh. (sections.css)

---

[Commit revision 303eba2]
Author: Nao
Date: Sun, 16 Mar 2014 22:28:10 +0100
Stats: 1 file changed; +3 (insertions), -3 (deletions)

• Hmm, nope! Actually, the vv_special class has nothing to do with registration, and should be kept out of it altogether. (sections.css)

---

[Commit revision 690f5b5]
Author: Nao
Date: Sun, 16 Mar 2014 22:43:54 +0100
Stats: 7 files changed; +42 (insertions), -68 (deletions)

• Removed avatar_dir/avatar_url (ManageAttachments.php, Profile-Modify.php, QueryString.php, Admin.english.php)
• Removed smileys_dir/smileys_url (ManageSmileys.php, QueryString.php, Subs-Cache.php, ManageSmileys.english.php)
• Unused global. (Profile-Modify.php)
• This is the first phase of the hard-coding process for Wedge folders.

---

[Commit revision 232bf29]
Author: Nao
Date: Sun, 16 Mar 2014 22:44:31 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

• And another unused global. (MessageIndex.template.php)

---

[Commit revision ba10fd6]
Author: Nao
Date: Sun, 16 Mar 2014 22:45:17 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)

• Outdated @remove command. (Wilde/extra.css)

---

[Commit revision cde49dd]
Author: Nao
Date: Sun, 16 Mar 2014 22:46:16 +0100
Stats: 1 file changed; +9 (insertions), -19 (deletions)

• Did away with txt_* variables in the registration JavaScript. This saves a dozen gzipped bytes. Not much, but no reason to keep these variables either. (register.js)

Note: I've only committed about 2/3 of my current hard-coding rewrite, the rest needs more work but it works on my local install. However, since it's not 100% guaranteed to work and I'm too tired to finish my work tonight, I *DO NOT* recommend upgrading to the latest commits. Stick to 303eba2 (dated 22:08) if you want to be up to date.

Note 2: this is the first time in years I'm posting a message that's not a changelog... Don't be surprised, though -- ever since I switched to git, I've slowly started adopting the 'git flow' of committing often, and separating smaller commits into chunks rather than grouping them all thematically, like I used to do. You may like it better or less, it doesn't matter, it is how it is. :P

[Commit revision 47061f5]
Author: Nao
Date: Mon, 17 Mar 2014 15:24:09 +0100
Stats: 2 files changed; +11 (insertions), -8 (deletions)

• Fixed border radius. For the record, if you want to add page corners on your custom skins, just set $radius to 10px or 20px or whatever. To remove page corners from a skin inherited from Wilde, set $radius to 0 (not 0px). (index.css, Wilde/extra.css)
• Minor tweak to slogan styling. (index.css)

[Commit revision bb2f039]
Author: Nao
Date: Mon, 17 Mar 2014 17:43:27 +0100
Stats: 1 file changed; +3 (insertions), -3 (deletions)

• $action_list needs to be filled before cleanRequest() is called. I may go about moving it to loadSettings, which would make the index file lighter... (It's the only file that can't eventually be minified.) (index.php)

[Commit revision 6993896]
Author: Nao
Date: Mon, 17 Mar 2014 17:44:52 +0100
Stats: 1 file changed; +3 (insertions), -3 (deletions)

• Undefined $scripturl. (QueryString.php)

[Commit revision ab4c495]
Author: Nao
Date: Mon, 17 Mar 2014 19:56:55 +0100
Stats: 3 files changed; +212 (insertions), -199 (deletions)

• Moved action list to the Load file. This whole loading order was getting on my nerves... Eventually, I'll probably move all of the initial loading to its own file, merged with QueryString or something. (index.php, Load.php)
• Moved PHP minification code to its own short file (which will never get minified, because you don't eat where you compile.) (index.php, Subs-MinifyPHP.php)
• Unneeded global. (Load.php)

[Commit revision bfb804f]
Author: Nao
Date: Mon, 17 Mar 2014 23:17:16 +0100
Stats: 1 file changed; +2 (insertions), -5 (deletions)

• Temporarily disabling JS/CSS compression on default installs. You can still enable them from the admin menu, of course. But I'm still waiting on some feedback (and finding time to myself test this further), so... Well, better safe than sorry. (install.sql)
• Removing smiley and avatar URLs from installer. (install.sql)
• show_avatars wasn't in the installer. As a result, I think avatars were disabled by default in Wedge... Feedback on this welcomed, too. (install.sql)

[Commit revision 577a103]
Author: Nao
Date: Tue, 18 Mar 2014 13:00:41 +0100
Stats: 1 file changed; +7 (insertions), -1 (deletion)

• Changing the default language for a forum should force a cache flush for JS files, otherwise you'll get multiple languages on a single page... (ManageLanguages.php)

---

[Commit revision 043f72c]
Author: Nao
Date: Tue, 18 Mar 2014 13:02:15 +0100
Stats: 1 file changed; +6 (insertions), -2 (deletions)

• Some fixes to the installer's banner. (install.css)

---

[Commit revision b19e3d9]
Author: Nao
Date: Tue, 18 Mar 2014 18:48:12 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

• Ensuring that plugin folders refuse xml file requests, in addition to archives. (OriginalFiles.php)