New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2535, on March 26th, 2014, 02:12 PM »
[Commit revision ffe7887]
Author: Nao
Date: Tue, 25 Mar 2014 23:23:23 +0100
Stats: 1 file changed; +4 (insertions), -3 (deletions)
  • If your forum was using a non-English default language, UK English could be compiled to the default language by mistake. (Load.php)
  • Added tentative support for inherited languages other than English UK. Basically, if you want to add support for Québécois (which is slightly different from French), or any variation on a full language translation, your folder name must reflect the parent language, then add a dash and the name (or code) of your language variation. For instance, here, the folder could be called 'french-ca', or 'french-qc', whatever you like. Or 'portuguese-brazilian', you get the idea. Seems to be working for me, but it's always good to test. (Load.php)
[Commit revision a0d9cf7]
Author: Nao
Date: Wed, 26 Mar 2014 13:57:34 +0100
Stats: 1 file changed; +16 (insertions), -8 (deletions)
  • Added support for the 'local' keyword to @if and @is tests. (Subs-Cache.php)
  • I think it was the last suffix that was missing from the list, and I should even be able to remove prefix support to make things simpler for me, but I don't think I will. Also, the extra code might seem a bit overkill, but really, it isn't. I tried another route yesterday, and ended up making a mess out of the Wess class. Wow, that was bad.
[Commit revision 8f5284f]
Author: Nao
Date: Wed, 26 Mar 2014 14:00:25 +0100
Stats: 5 files changed; +14 (insertions), -19 (deletions)
  • Tweaked CSS to ensure that the dark blue color on menu hover only applies to Weaving. Even if it's the root skin, it shouldn't 'impose' its design choices upon its children, and yet I don't want to remove what's giving it some originality, either. The solution was oh-so-simple: just add an "@if local" test around it. As a result, I was able to remove some extra CSS from Wilde. This is actually the first time I'm doing it in the mainline code, and it should give you a very good idea of its flexibility, I suppose... ;) (index.css, Warm/extra.css, Wilde/extra.css, Wine/extra.css, Wuthering/extra.css)

Posted: March 26th, 2014, 02:00 PM

[Commit revision 3b9c7ed]
Author: Nao
Date: Wed, 26 Mar 2014 14:11:57 +0100
Stats: 4 files changed; +7 (insertions), -25 (deletions)
  • More local simplifications. I learn fast! (Warm, Wilde, Wine, Wuthering/extra.css)
Re: New revs
« Reply #2536, on March 26th, 2014, 05:41 PM »
[Commit revision d17fae9]
Author: Nao
Date: Wed, 26 Mar 2014 17:20:43 +0100
Stats: 3 files changed; +40 (insertions), -34 (deletions)
  • If someone deleted their sent PMs before you had a chance to read them, their notification would remain in the PM popup forever. And ever. Now it'll still remain there, but the notification will be marked as read when it can't find the PM. (PersonalMessage.php, PersonalMessage.english.php)
  • Spacinazi. (Errors.english.php)
Re: New revs
« Reply #2537, on March 26th, 2014, 07:51 PM »
[Commit revision e74c00b]
Author: Nao
Date: Wed, 26 Mar 2014 19:48:26 +0100
Stats: 2 files changed; +45 (insertions), -1 (deletion)
  • get_preferred_language() should be able to set anyone's default language to their current browser language, if it's set. Totally untested, as tradition tells. (Class-System.php, Subs.php)
[Commit revision e48c3ee]
Author: Nao
Date: Wed, 26 Mar 2014 19:51:00 +0100
Stats: 2 files changed; +15 (insertions), -54 (deletions)
  • loadConstants() was called a BIT too soon. The installer should be triggered before it, because it has yet to actually set the proper $boardurl. (index.php)
  • Attempting to fix the installer: the thingy above, but also finding the proper paths for language files, and not initializing some things that were already set. Maybe this all makes it even worse... I don't know. (install.php)
Re: New revs
« Reply #2538, on March 26th, 2014, 10:42 PM »
[Commit revision c704a26]
Author: Nao
Date: Wed, 26 Mar 2014 22:29:40 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Spacinazi. (Notifications.english.php)
[Commit revision de050eb]
Author: Nao
Date: Wed, 26 Mar 2014 22:33:26 +0100
Stats: 4 files changed; +31 (insertions), -24 (deletions)
  • Merged both profile notification pages into submenus. (Notifications.php, Profile.php, Profile.template.php, Profile.english.php)
[Commit revision c1f38d8]
Author: Nao
Date: Wed, 26 Mar 2014 22:40:38 +0100
Stats: 6 files changed; +56 (insertions), -56 (deletions)
  • Moved SSI.php to the core folder. The reason is, again, that I want to keep the root as clean as possible. You'll need to update all of your files that require SSI, of course. It's just a matter of adding 'core/' to the call. (SSI.php, Subs-Admin.php, Home.template.php, install/ssi_*.*, subscriptions.php)
Re: New revs
« Reply #2539, on March 26th, 2014, 11:27 PM »
[Commit revision b46d62f]
Author: Nao
Date: Wed, 26 Mar 2014 23:26:57 +0100
Stats: 1 file changed; +2 (insertions), -3 (deletions)
  • Going to bed, so I might as well commit my tentative fix for the installer! (install.php)
Re: New revs
« Reply #2540, on March 27th, 2014, 11:38 AM »
[Commit revision 928f869]
Author: Nao
Date: Thu, 27 Mar 2014 11:38:13 +0100
Stats: 1 file changed; +5 (insertions), -1 (deletion)
  • Fixed the installer. For good, this time. As in, "I tested it." (install.php)
Re: New revs
« Reply #2541, on March 27th, 2014, 04:41 PM »
[Commit revision b1a1086]
Author: Nao
Date: Thu, 27 Mar 2014 12:04:04 +0100
Stats: 2 files changed; +4 (insertions), -8 (deletions)
  • Removed some useless stuff from the settings file. Copyright info is already in the containing file anyway. (OriginalFiles.php)
  • A media cache key was getting too long. I probably shouldn't be using binhex to make keys filename-friendly, but I've always found md5 to be a bit overkill... (Aeva-Gallery.php)
[Commit revision 70d4775]
Author: Nao
Date: Thu, 27 Mar 2014 15:52:08 +0100
Stats: 1 file changed; +7 (insertions), -7 (deletions)
  • Menu icons had turned invisible in the media area. (Aeva-Gallery.php)
[Commit revision bfecbba]
Author: Nao
Date: Thu, 27 Mar 2014 16:35:07 +0100
Stats: 1 file changed; +6 (insertions), -0 (deletion)
  • Added a htaccess for the template folder, which should allow your server to debug template errors when template eval is enabled. Otherwise, the whole template eval feature might as well be removed... (core/html/.htaccess)
[Commit revision 3f1acd5]
Author: Nao
Date: Thu, 27 Mar 2014 16:40:11 +0100
Stats: 1 file changed; +2 (insertions), -0 (deletion)
  • This quick code accounts for template eval errors that are due to the .htaccess file missing from core/html. (ManageErrors.php)
  • Yes, it's hardcoded stuff, but it's unlikely you'll ever view it anyway... (Needs for htaccess file to be missing or non-Apache server to be running, AND template evals being enabled in an obscure admin page.)
Re: New revs
« Reply #2542, on March 27th, 2014, 06:30 PM »
[Commit revision 0ad741a]
Author: Nao
Date: Thu, 27 Mar 2014 18:30:13 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Language cache was behaving strangely on some servers if no language sub-folders were created. (Load.php)
Re: New revs
« Reply #2543, on March 27th, 2014, 08:16 PM »
[Commit revision 93ae09c]
Author: Nao
Date: Thu, 27 Mar 2014 20:16:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Couldn't edit message icons. (ManageSmileys.php)
Re: New revs
« Reply #2544, on March 28th, 2014, 09:59 AM »
[Commit revision f609e91]
Author: Nao
Date: Fri, 28 Mar 2014 09:55:16 +0100
Stats: 7 files changed; +17 (insertions), -3 (deletions)
  • Added bypass_edit_disable permission, which allows specific users to bypass, as its name implies, the edit_disable_time setting, and effectively be able to edit their posts anytime after the grace period has expired. (Class-System.php, ManagePermissions.php, ManagePosts.php, Security.php, Help.english.php, ManagePermissions.english.php)
  • Improving readability for reply_number. (index.english.php)
  • Note, bypass_edit_disable is basically untested. I haven't found anyone willing to test it (!), so I'll just consider it does.
  • This is a global permission, meaning it's applied on all boards, instead of per-board per-profile per-group. I just think it's better that way. And, less complicated.
Re: New revs
« Reply #2545, on March 28th, 2014, 11:06 PM »
[Commit revision 7d8f681]
Author: Nao
Date: Fri, 28 Mar 2014 18:27:55 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Doing a quick test to see if a percentage width gives better results on mobile PM pages. This is the best I can do apart from converting the PM template to use the Msg skeleton, and quite honestly I have other priorities for now. :-/
[Commit revision 3673754]
Author: Nao
Date: Fri, 28 Mar 2014 21:20:42 +0100
Stats: 11 files changed; +26 (insertions), -118 (deletions)
  • After reducing 'topicseen' URLs to 'seen', they're now reduced to '', which is definitely better... Seriously, I've removed this old ability (pre-1.0!) that SMF had of showing unread status on boards in the board index. The first reason was that it was buggy, and apparently not due to Wedge. The second reason was that after a quick poll, I realized others were just like me, completely ignoring these icons, and simply reading new posts through other methods like Unread Topics, Unread Replies, Recent Posts, etc. Board icons are better used as a way of showing activity in a board. (SSI.php, Announce.php, Display.php, MessageIndex.php, QuickMod.php, Subs-BoardIndex.php, Subs-Boards.php, Subs-Post.php, Unread.php, UnreadReplies.php, Search.template.php)
  • Left to do: remove the log_boards table.
Re: New revs
« Reply #2546, on March 30th, 2014, 12:41 AM »
[Commit revision da98ab2]
Author: Nao
Date: Sat, 29 Mar 2014 15:21:29 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Eliminating a logged error from stupid bots. This is mainly Wedge.org-oriented, but it's pretty much free. (Load.php)
[Commit revision 7c36c80]
Author: Nao
Date: Sat, 29 Mar 2014 19:37:02 +0100
Stats: 1 file changed; +0 (insertion), -1 (deletion)
  • An old unused variable. (ManagePermissions.php)
[Commit revision b7aa32d]
Author: Nao
Date: Sat, 29 Mar 2014 20:23:34 +0100
Stats: 1 file changed; +19 (insertions), -45 (deletions)
  • Removed some pre-2004 updateSettingsFile code (I'm sure the "server oddities" mentioned were fixed in the meantime!), and replaced it with file_put_contents and a rename. This is cleaner, shorter, and should work better against low disk space. (Subs-Admin.php)
  • Note: updateSettingsFile now returns false if an error occurred. Instead of nothing special.
[Commit revision 57328c4]
Author: Nao
Date: Sat, 29 Mar 2014 20:24:56 +0100
Stats: 2 files changed; +20 (insertions), -17 (deletions)
  • This one's messed up... It looks like doing updateSettingsFile and subsequently redirecting to the same page will not always load the correct settings file. Perhaps it's due to my Windows setup, I don't know. But I'd rather do an ugly, visible refresh than give the user a finger and force them to reload the page manually. (Subs.php, Upgrade.php)
[Commit revision b0db1d0]
Author: Nao
Date: Sat, 29 Mar 2014 20:31:41 +0100
Stats: 1 file changed; +4 (insertions), -12 (deletions)
  • Maintenance. (ManageMaintenance.php) (Had to be.)
Re: New revs
« Reply #2547, on March 30th, 2014, 12:52 AM »
[Commit revision da7e415]
Author: Nao
Date: Sun, 30 Mar 2014 00:43:09 +0100
Stats: 1 file changed; +3 (insertions), -7 (deletions)
  • Class-ZipExtract was already loaded by ManagePlugins. (Subs-Plugins.php)
[Commit revision 5ed43d4]
Author: Nao
Date: Sun, 30 Mar 2014 00:43:57 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Unneeded parameter. (Display.php)
Re: New revs
« Reply #2548, on March 30th, 2014, 11:24 PM »
[Commit revision bf04bdc]
Author: Nao
Date: Sun, 30 Mar 2014 23:24:11 +0200
Stats: 3 files changed; +19 (insertions), -20 (deletions)
  • Move Topic page wasn't working on mobile devices. (sections.css)
  • Spacinazi. (Unread.php, UnreadReplies.php)
  • Details. (sections.css)
Re: New revs
« Reply #2549, on March 31st, 2014, 04:26 PM »
[Commit revision 187bcbc]
Author: Nao
Date: Mon, 31 Mar 2014 15:58:34 +0200
Stats: 2 files changed; +47 (insertions), -31 (deletions)
  • Fixed topic privacy. Hopefully. (Class-System.php, Load.php)
  • Fixed bypass_edit_disable permission. This one's 100% confirmed. (Class-System.php, Load.php)
  • This was due to permissions being tested against before they were loaded at all. We are not amused.

Posted: March 31st, 2014, 03:58 PM

[Commit revision 200556a]
Author: Nao
Date: Mon, 31 Mar 2014 16:26:09 +0200
Stats: 1 file changed; +24 (insertions), -28 (deletions)
  • A partial revert of the topic privacy fix. The fix was all about the fact that non-admins with permission to approve posts wouldn't be able to see see unapproved posts. Which is pretty bad, so I'll need to rewrite a query in loadBoard because it's caught in a logic loop with loadPermission. In the meantime, because my fix was breaking inside uncached boards, I'll just leave the code where it used to be -- it'll work fine for everyone else. (Class-System.php)
Plugin revs »