Wedge

Public area => The Pub => Features => Topic started by: Nao on September 2nd, 2010, 02:57 PM

Title: New revs
Post by: Nao on September 2nd, 2010, 02:57 PM
Note to the Wedge audience!

What is this topic about?

It's our official changelog. Every time we commit something to the central SVN server (which retains the master copy of Wedge), we document our changes, and then we post them here.
Pete uses the SVN format to post his changelogs here, while I've been using a slightly different format (eventually adding extra line breaks to improve readability of the whole damn thing.)

As you can see below, this topic started at revision 23, so it's missing about a week's worth of changes, maybe we'll report them later.

There's already a feature list. What's the point of this topic?

The point is that we're being open about what we're currently working on. Not many people do that. They tend to keep you updated once in a blue moon. Our goal has always been to make this topic public, at least after the first alpha release. We're just making that happen a bit earlier.
We're also being honest about our blunders. Perhaps because there aren't a lot of them, eh eh. And honest about the time it sometimes takes us to implement something. Writing a new feature is not as easy as "one two three done". Sometimes you'll just give up on it for some time, come back to it, etc. I think it's an interesting way of going through our numerous changes to the original SMF codebase.
And of course, the feature list is a good thing, and pretty complete as it is, but it doesn't get updated too often.

Another point is that SMF users can finally get to know about SMF quirks we've been fixing. The feature list has an obscure entry about 'SMF bugs' being fixed. I didn't want to reveal what they were. After some consideration, I decided that they 'might as well be told'. So, if anyone has the courage to dig through the complete changelog and compile a list of SMF bugs we fixed (I always try to indicate 'smf bug' or a similar mention in the changelog when I fix one), feel free to transmit it to SMF. We personally don't give a damn about them.

So, do I need to read it?

No. Only if you're a hardcore fan. In which case you probably already had access to it before. I'd recommend you read through the changelog after rev ~750 though. That is, when I compiled the feature list. Anything done after is not in the feature list. I'll update it of course, eventually.

The topic is locked, how do I comment it?

It is locked to help with readability. We don't want to bury the changelogs in the middle of pages and pages of off-topic discussions.
There's already a private comment topic, but it's private and WILL remain so.
The official comment topic is here:
http://wedge.org/pub/feats/6803/new-revs-public-comments/
But you can create new topics or whatever you'd like.

Back to the original post!



Hmm, I don't know if it'll work, but I'll try to make a specific thread where we can post our latest rev logs, and maybe discuss them. We're already doing that in the To-do topic, but there's a long post I have to answer over there, and I don't want to forget it :P
Anyway, this is to give more visibility for our cheerleaders, who currently have no way to test the code themselves (or see it in action anywhere.)

rev 23
* Updating to SMF rev 10072 (fixes to strlen and board/topic optimizations) (changelog.txt, ManageSettings.php, News.php, Post.php, Search.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, Subs-Auth.php, Subs.php)
! Small @ hack in ManageSmileys to avoid errors when the smiley list is empty (wrong folder, etc.) (ManageSmileys.php)

--> Yeah, I ended up committing that one... Sorry, it was too tempting :lol:
Title: Re: New revs
Post by: Arantor on September 2nd, 2010, 03:12 PM
Revision: 24
Author: arantor
Date: 14:10:29, 02 September 2010
Message:
! Fix broken line endings from SMF patch (Post.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, Subs-Auth.php, Subs-Editor.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Editor.php




This proves beyond any doubt (not that I had any) that it's not your commits fudging the line endings. If it were, ManageSmileys would have been affected too.
Title: Re: New revs
Post by: Nao on September 2nd, 2010, 08:27 PM
rev 25
! Fixed remaining CR-LF files. (changelog.txt, install.php, ssi_examples.php, mailQueueCron.php, repair_settings.php, upgrade.php, Admin.php)
Title: Re: New revs
Post by: Arantor on September 3rd, 2010, 02:14 AM
Revision: 26
Author: arantor
Date: 01:12:53, 03 September 2010
Message:
+ Attempt to detect user time offset on registration (Register.php, Register.template.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php


NB This closes Ticket 10: Time zone auto detection on registration(http://wedge.org/?action=helpdesk;sa=ticket;ticket=10)
Title: Re: New revs
Post by: Nao on September 3rd, 2010, 06:05 PM
rev 28
! Fixed a potential error in $board_info['moderators'][id]['link'] ($txt is not supposed to be loaded at this point). Besides, this entry is never used as far as I know, so it might as well be removed entirely... (Load.php)

rev 29
! Incorrect indenting (Display.template.php)
! Minor spacing fixes. (Subs-Editor.php, QueryString.php, Profile-Modify.php, ManagePaid.php, ManageNews.php, upgrade.php, smf_api.php, repair.php)

rev 30
* Updated to SMF rev 10075 + minor spacing fixes. (changelog.txt, convert.php, Subs.php)
@ This needs being looked into. convert.php and Subs.php have apparently been converted to full UTF8. Is this as desired?

rev 31
* Updated to SMF rev 10083. (changelog.txt, repair_settings.php, Subs-Calendar.php)
@ This mostly moves old themes and the tools folder to their own repository. As a direct result, the tools folder is still here, and the old themes are gone, but since we'd already removed them anyway, it's all just fine.
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 12:27 AM
Revision: 35
Author: arantor
Date: 23:42:23, 03 September 2010
Message:
! Fix ARIN WHOIS lookup URL (Profile-View.php)
----
Modified : /trunk/Sources/Profile-View.php



Revision: 34
Author: arantor
Date: 23:25:25, 03 September 2010
Message:
! Encoding safe version of the legacy attachment filename function (Subs.php)
----
Modified : /trunk/Sources/Subs.php

NB this is the function I complained so bitterly about Norv breaking. This fixes it once and for all in a way that never gets broken by encoding, it's all 7-bit safe.



Not sure where rev 33 went?



Revision: 32
Author: nao
Date: 17:36:05, 03 September 2010
Message:
! CRLFs go home! (changelog.txt, repair_settings.php, Subs-Calendar.php)
----
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/changelog.txt
Modified : /trunk/Sources/Subs-Calendar.php
Title: Re: New revs
Post by: Nao on September 4th, 2010, 09:53 AM
rev 33
! Putting a windowbg block inside a windowbg2? Eh? (Help.template.php)
* Starting the wrc conversion process. Only one for now... More will follow :P (Recent.template.php)

What's the issue? Aren't you able to view the svn log?

As for rev 34 -- very interesting! I'll have a look.
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 11:45 AM
Rev 33 didn't show in the SVN log for some reason.
Title: Re: New revs
Post by: Nao on September 4th, 2010, 12:18 PM
I didn't do anything special with it, your Honour! Honest to God!
Title: Re: New revs
Post by: Nao on September 4th, 2010, 02:12 PM
rev 36
* Applied Pete's rockin' fix from Subs.php to convert.php as well. (convert.php)

(This one tends to get forgotten in the process... Maybe because now over at sm.org the tools folder is in an external repository, I don't know. "Ommit externals" is disabled in my Tortoise copy.)
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 02:13 PM
I forget about convert.php, mostly because I figure with all the changes that are going to be made, we'll end up rewriting the converter core (at least) anyway.
Title: Re: New revs
Post by: Nao on September 4th, 2010, 02:58 PM
Not a problem... When I said "forgotten", I really meant Norv didn't fix it the same way as he fixed Subs.php...
And as I wrote in my earlier rant... As unimportant a fix is, what matters is commitment. We both have it, let's keep it that way :)
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 07:10 PM
Revision: 37
Author: arantor
Date: 18:09:04, 04 September 2010
Message:
+ Added unified editor class (Class-Editor.php) (for ticket 3)
! Updated editor handlers to do WYSIWYG->BBC parsing in the class rather than having the logic totally in the calling script (Post.php, PersonalMessage.php)
! Removed old functions that are no longer relevant as now part of the class (Subs-Editor.php, Subs-Post.php, GenericControls.template.php)
! Modified all the other places that used preparsecode and friends to use the class (I *think* I got everything right) (ManageNews.php, ModerationCenter.php, MoveTopic.php, PersonalMessage.php, Post.php, Profile-Modify.php)
! Updated sources and templates to use class instantiation/referencing (Post.php, Post.template.php, PersonalMessage.php, PersonalMessage.template.php)
----
Added : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/index.php


I forgot to add to the note I also updated index.php to call the class instead of Subs-Editor for the code that is used when switching between the WYSIWYG and normal editors.

What I need to do next - and I've got to out to a wedding reception, ack - is document the changes, because this is HUGE in what it changes.
Title: Re: New revs
Post by: Nao on September 5th, 2010, 01:39 AM
Wow, I totally need to read this backlog... I haven't looked into the "Bigger changes" topic yet (it's opened in a tab -- only, I have about 50 tabs open just for wedgeforum.com...!! Have to read them all!), neither have I looked into your code refactoring tickets (shame on me. Same reason.)

So, you're not much into social events either, eh? :P
[off-topic real life crap]Tonight I was at my brother in law's birthday party... Very noisy bar, very hot in there, and boring people (next time I see someone demonstrating their new iPhone, I'll be using my fists.)
I like my BIL (he lives in London and I don't get to see him a lot), but he was overcrowded today so I didn't even get to tell him a word, lol. The guy I talked for the longest (about... 10 minutes) was a geek co-worker of his who was in Paris for the first time. We discussed TV shows, the hate of commuting to London (guess why) and other things. The only 10 interesting minutes -- and it reminded me just how AWFUL my accent is. And there's no Backspace key in a muscle-powered vocal controller. God bless the Backspace key. I can fix all (most) of my English mistakes as soon as they take shape, and nobody needs to know! I'm looking forward to meeting you in the future and making a fool out of myself :D

Tomorrow I'm set to see BIL again... With family, this time. Argh. Someone, please free me from non-geeks! I bore them to death, and they return the favour with pleasure![/off-topic real life crap]
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 02:12 AM
No, I'm really not a social person.

The reason for this one is to make it much easier to build on and/or replace in the event of using something like CKEditor; now whatever we do in terms of altering the code, we just have to update wedgeEditor rather than liberally hitting up the code throughout Wedge.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 03:07 AM
Revision: 38
Author: arantor
Date: 02:06:18, 05 September 2010
Message:
! Ensure the auto added topic is updated to actually be the new admin's by ownership. (other/install.php) (ticket 21)
----
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Nao on September 5th, 2010, 09:20 AM
Thanks for the auto-topic fix, I really don't have time to work on anything this weekend... (I hate it.)
BTW, the "Mark Resolved" feature in SD doesn't seem to work when clicked from within a ticket. It does work when using the icon in the ticket list.
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
Quote
The reason for this one is to make it much easier to build on and/or replace in the event of using something like CKEditor; now whatever we do in terms of altering the code, we just have to update wedgeEditor rather than liberally hitting up the code throughout Wedge.
Oh... Right! Then it's fantastic.
I love it that you baptized our project :) Very logically, too, since this is something that is unlikely of reaching SMF at all. (And if it does, they'd better keep the name :P)
Title: Re: New revs
Post by: Nao on September 5th, 2010, 12:05 PM
rev 39
- Removed php_412_bugfix leftovers. (Load.php, smf_api.php, install.php)
- Some of the files were not requiring PHP 5. (index.php, webinstall.php, install.php, upgrade.php, Subs-Compat.php)
@ Is the eval() necessary in convert.php? Will it run on PHP4 without them? (Considering PHP4 isn't supported, it's not important but...)

--> The eval() stuff should be unneeded, but I'm just not sure whether PHP4 won't choke on some stuff in it. I don't think so, but I kinda have a hangover, AND I'm about to go to that stupid party in a minute.
Anyway, I'm not yet finished with the PHP5 requirements (I only did the files that should be a "barrier" to installing Wegde on PHP4). There are many more lines to remove, I'll do them later today when I get back, so we're finished with it.

I've also upgraded to the latest SMF rev (10093), and I'm nearly finished with the botslice/topslice stuff, hopefully, tonight, or tomorrow morning everything will be committed.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 03:45 PM
If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.

Adding try/catch is not something I'm overly looking at yet, since SMF's code is written to pretty much avoid failing anyway.
Posted: September 5th, 2010, 02:41 PM

Revision: 40
Author: arantor
Date: 14:02:17, 05 September 2010
Message:
! Removed unnecessary eval from dropping PHP 4 support (convert.php)
----
Modified : /trunk/other/converters/convert.php



EDIT to add
Quote
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
Posted: September 5th, 2010, 03:02 PM

Revision: 41
Author: arantor
Date: 14:26:17, 05 September 2010
Message:
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
----
Modified : /trunk/other/install_2-0_mysql.sql

Posted: September 5th, 2010, 03:26 PM

Revision: 42
Author: arantor
Date: 14:44:43, 05 September 2010
Message:
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
----
Modified : /trunk/Sources/Subs-Auth.php
Title: Re: New revs
Post by: MultiformeIngegno on September 5th, 2010, 04:27 PM
I love seeing new revs! :D
Can't wait to test Wedge!!
Title: Re: New revs
Post by: Nao on September 5th, 2010, 04:38 PM
@Lorenzo> An exclusive for you! Here's a short sample from some of our custom code!

Code: [Select]
if (!empty(

Sorry, can't show more. Hope it keeps you excited  :eheh:
Quote from Arantor on September 5th, 2010, 03:45 PM
If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
Quote
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
That's nice... But I'm sure it can be rewritten, still ;)
Quote
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
Yeah, I have yet to look into the mysql install files. I'm really removing things as things go, like, this morning I was simply looking for php_version and tried getting rid of all of the unneeded stuff. Still a lot remains to be done. Nothing biggie though.
Quote
Revision: 42
Author: arantor
Ahhhh!! You, filthy thief!![1] You stole my rev! I was looking forward to committing it myself! :P

'kay, just kidding, I already had rev 10.000 on SMF, and no one will take that one away from me... Despite Norv's efforts to revert part of that commit :niark:
Next stop: rev 69. Who will be getting it? :ph34r:

We just finished eating and I'm quite a bit wasted, again. What a weekend... And what with that 26'' monitor my hosts are using?! Why do they need that much space?
Anyway, I'll deal with all of these commits tonight (I have at least 3 on my waiting list, as I try to separate different fixes/additions into different commits).
Quote
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
Can't look into the svn right now (see above), so... Are you doing stuff in my stead? Maybe we should determine how to deal with commit conflicts. Usually we work on different parts at the same time so it's okay, but for instance, if you're going to tackle a task in the bug tracker, could you assign it to yourself first? That way I would have a way to make sure we're not working on fixing the same issue at the same time. Which at best is a waste of time for one of us, and at worst, brings commit confusion. (I'm talking about big fixes and features, of course. If it's just a few lines of code, who cares if we're wasting time.)
 1. I like the sound of that.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 04:43 PM
Quote
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
It'll be a fatal error since try/catch is a language construct not in PHP 4. Since we don't support PHP 4 at all, it's not worth worrying about unless we reinstate the original branch too (since the eval will just return false in PHP 4 and do absolutely nothing otherwise)
Quote
That's nice... But I'm sure it can be rewritten, still
Sure it can. Just remember that each block is given specific parameters in order to specify what will be in each block. It shouldn't be too hard to deal with that though.
Quote
Yeah, I have yet to look into the mysql install files
It only occurred to me as I was adding the return_to_post entry which lives in the same place.
Quote
Ahhhh!! You, filthy thief!!
Hahaha
Quote
Can't look into the svn right now (see above), so... Are you doing stuff in my stead?
All I did was remove the code that defines session_regenerate_id() if it doesn't exist, it's not done with a PHP_VERSION check but a function_exists(), so it's possible you wouldn't find it otherwise.

Sure, can assign stuff, it's been a while since I worked in a team!
Title: Re: New revs
Post by: MultiformeIngegno on September 5th, 2010, 04:47 PM
@Nao: I can't keep it secret!!!! Everybody needs to know this incredible scoop!! :P
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 04:49 PM
Quote from MultiformeIngegno on September 5th, 2010, 04:47 PM
@Nao: I can't keep it secret!!!! Everybody needs to know this incredible scoop!! :P
I'd love to tell people, but 1) it would risk being overhyped, and 2) we've kept it quiet as a courtesy to SMF. It is, as Nao has said, a PR move. Can you imagine what would happen if it were public what we were doing?
Title: Re: New revs
Post by: Nao on September 5th, 2010, 04:52 PM
Quote from Arantor on September 5th, 2010, 04:43 PM
Quote
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
It'll be a fatal error since try/catch is a language construct not in PHP 4. Since we don't support PHP 4 at all, it's not worth worrying about unless we reinstate the original branch too (since the eval will just return false in PHP 4 and do absolutely nothing otherwise)
I think I need to explain myself better, sorry. What I mean is, when you put a syntax error into a function, even a function that never gets called, PHP will directly crash on running the file. Would the try+catch and com_exception be considered as syntax errors? Because in that case, it would crash convert.php even before getting to the error message about the need to upgrade php.
However, it doesn't really matter, because you need to install your forum before you can convert to it, and if it won't install, there's no need to run the file anyway. So I'm good.
Quote
All I did was remove the code that defines session_regenerate_id() if it doesn't exist, it's not done with a PHP_VERSION check but a function_exists(), so it's possible you wouldn't find it otherwise.
I was actually planning to do a site-wide search on function_exists() as well, don't worry :) I only thought about it at the last moment though, so you're right, I could just as well have forgotten about it.
Quote
Sure, can assign stuff, it's been a while since I worked in a team!
We're a bit rusty :blush:

@Lorenzo> If you share that piece of code, even under a nickname, we'll KNOW it was your doing!

@Pete> He was kidding, re-read my previous PM with the code quote ;)
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 04:55 PM
Just for reference, yes, try/catch (I keep typing cache instead, haha) would be a syntax error in PHP 4, so yes it would crash PHP in that respect.
Title: Re: New revs
Post by: Nao on September 5th, 2010, 06:02 PM
Quote from Arantor on September 5th, 2010, 04:55 PM
Just for reference, yes, try/catch (I keep typing cache instead, haha)
Thta's not a porblem, we're not hree to witre a thises. We're hree to wrok on Webge Wegde[/s] Wgede.
Quote
would be a syntax error in PHP 4, so yes it would crash PHP in that respect.
Yeah, that's what I feared...
Oh well, as I said, it's okay because convert.php is unlikely to be used if the installer refused to work in the first place.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 08:19 PM
Revision: 43
Author: arantor
Date: 19:18:15, 05 September 2010
Message:
! db_show_debug can now be shown to different user groups (admin, admin+mod, all logged in users, everyone), optionally with query log being separated. (ManageServer.php, Subs.php, ViewQuery.php, Help.english.php, ManageSettings.english.php) (ticket 12)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on September 5th, 2010, 09:27 PM
Nice! Although that adds a lot of lines, but they'll run fast enough so that's okay :)
BTW --> I compressed the two isset()->unset() into a single unset() with both variables listed in it. isset() isn't needed, as PHP5 won't generate an error if you try unsetting a non-existent variable (it won't even do it if you try to unset an array entry in a non-existent array). So, might as well unset both in one go. :)

My first big one is here... (Mostly Norv's doing.)

rev 44
Code: [Select]
- More PHP4 stuff removal. (index.php, SSI.php)
* Updated to SMF rev 10093:
  ! Fixed calculating steps/substeps for log_actions changes (upgrade script) [Bug 4427]
  ! Added the optional (in 1.1 spec) assoc_type to OpenID parameters (Subs-OpenID.php) [Bug 4420]
  ! Small improvement to be more mod-friendly, a useless variable usage could have caused issues with mods (Load.php) [Bug 4445]
  ! Avatars loaded from remote locations may have failed resizing in some cases (script.js) [Bug 3842]
  ! Re-added a couple of flock() calls, as fclose() does not unlock the file on PHP 5.3.2+ (Load.php, ManageMaintenance.php) [Bug 4330]
  ! Improved 'who's online' behavior for a user who toggles WYSIWYG view (index.php) [Bug 4415]
  ! MySQL needs the autoincrement column defined as primary key (DbPackages-mysql.php) [Bug 4422]
  ! A variable was overwritten for font-size style tag, but needed later for <a> tag preservation (Subs-Editor.php -> Class-Editor.php) [Bug 4447]
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 09:43 PM
Quote
PHP5 won't generate an error if you try unsetting a non-existent variable (it won't even do it if you try to unset an array entry in a non-existent array)
And again... -.- If it weren't actually kind of important this would be almost funny.


Revision: 45
Author: arantor
Date: 20:42:54, 05 September 2010
Message:
! Again with the CRLF line endings having to disappear. (index.php, upgrade_2-0_mysql.sql, DbPackages-mysql.php, ManageMaintenance.php, Subs-OpenID.php, script.js)
----
Modified : /trunk/Sources/DbPackages-mysql.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/index.php
Modified : /trunk/other/upgrade_2-0_mysql.sql
Title: Re: New revs
Post by: Nao on September 5th, 2010, 10:43 PM
Can you believe I always forget to make sure it's okay?

I really need to find the setting in Subversion that will allow for all files be saved as LF...
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 10:46 PM
Can you believe the SMF team are still this sloppy?

It wouldn't hurt to fix it on our side, but they should be fixing it on theirs, and really how can you do a commit review if you can't check it is what it is supposed to be?
Title: Re: New revs
Post by: Nao on September 5th, 2010, 11:09 PM
I don't know, I'm trying my best to imagine it's not their fault but mine. (Blame my low self-esteem.)

http://gnuwin32.sourceforge.net/packages/patch.htm
Quote
On MS-Windows, the patchfile must be a text file, i.e. CR-LF must be used as line endings. A file with LF may give the error: "Assertion failed, hunk, file patch.c, line 343," unless the option '--binary' is given.
Maybe Tortoise forces the patch file to be in CR-LF format to ensure patch.exe won't screw it...? Because yes, the diff patch is itself in CR-LF in the first place. So that could explain it..?
(For devs using Windows or Linux as their platform) -> editing a LF file -> saving as LF -> committing patch
(For other dev using Windows as their platform) -> updating SVN (LF) -> generating a manual diff patch to apply on other branch (automatic CR LF) -> applying patch (CR LF) -> doing changes on that branch, committing to SVN in CR LF. File is 'remembered' as CR LF on the svn server (where data is always stored in LF.)

I really don't know. What I know is, the best way to get rid of these seems to have some sort of script that would automatically turn CRLF files into LF after a patch is done, or before a commit is done.

In any case, even though my SMF SVN indeed has a mix of CRLF and LF that can only be explained through the above examples (or simply a bad editor...), *my* commits are at fault, too. I should be careful.

PS: ah, I see you finally caught up with me in terms of posts here! I was wondering why it took you so long. :) Next step: 10k posts by next week! :lol:
Title: Re: New revs
Post by: Nao on September 5th, 2010, 11:15 PM
rev 46
* One-line version of a 4-line block. (Subs.php)
@ Okay, I just committed this because I discussed it, and forgot to commit.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 11:22 PM
Does Tortoise use GNU patch? I thought it used its own to be honest.

But if that's the case, repair_settings.php should be affected out of the last patch - and it wasn't. Which means it still is with them. It wouldn't hurt to have our stuff above reproach, but really it should be fixed at source, and how many times have you told them about this?
Title: Re: New revs
Post by: Nao on September 5th, 2010, 11:43 PM
I don't know about which one Tortoise uses, I installed a package or something...
repair_settings.php was my own fix. It wasn't touched by Norv.

BTW, there's more legacy code in repair_settings.php on selecting the current database type. I guess all of this should be removed? We're never going to go beyond ONE supported db system are we?
I just want to clean it up as soon as possible. $db_type should be a good search word.
Also need to finish php_version and function_exists searches.
And also re-fix board list in Search template.

Tomorrow is 100% work for me, at last :) (People who enjoy work... Looneys!)


rev 47
* First part of the big commit on the rounded corner rewrite. botslice and topslice empty spans are replaced with a parent class of wrc. IE adds support through Javascript. (ssi_examples.php, admin.css, index.css, and these templates, wait for it: Admin, Display, Errors, Help, index, ManageAttachments, ManageBans, ManageBoards, ManageCalendar, ManageMail, ManageMaintenance, ManageMembergroups, ManageMembers, ManagePaid, ManagePermissions, ManageScheduledTasks, ManageSearch, ManageSmileys, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Register, Reports, Search, SendTopic, SplitTopics, Stats, Themes and Who.)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 12:48 AM
Quote
I guess all of this should be removed? We're never going to go beyond ONE supported db system are we?
I'd kind of like to keep the code in there in case we ever want to support something alongside MySQL (i.e. community support), but really, the way it's all engineered generally, the entire query system would need rewriting to support proper query building.

In which case... you know where the delete button is, hehe :D


Hmm, maybe it is the patch executable then? Hmm, I don't know.
Posted: September 5th, 2010, 11:49 PM

Anyway.

I got brave and just did this.


Revision: 48
Author: arantor
Date: 23:47:06, 05 September 2010
Message:
! Added PMs being saved in sent items by default for new accounts (install_2-0_mysql.sql)
----
Modified : /trunk/other/install_2-0_mysql.sql
Title: Re: New revs
Post by: MultiformeIngegno on September 6th, 2010, 02:37 AM
Quote from Arantor on September 6th, 2010, 12:48 AM
! Added PMs being saved in sent items by default for new accounts (install_2-0_mysql.sql)
:cool:
Title: Re: New revs
Post by: Nao on September 6th, 2010, 12:25 PM
rev 49
* SMF2 changelog, back to LF endings... (yawn) (changelog.txt)
* More PHP5 optimization. Ain't done yet. (phpBB3_Login_Fix.xml, install.php, Display.php, Load.php)
- complex_preg_chars trigger (PHP 4.3.3+) is no longer needed. (Class-Editor.php, Load.php, Register.php, Search.php, Subs-Members.php, Subs-Post.php, Subs.php)
Posted: September 6th, 2010, 10:31 AM
Quote from Arantor on September 6th, 2010, 12:48 AM
I'd kind of like to keep the code in there in case we ever want to support something alongside MySQL (i.e. community support),
Community support?
Quote
but really, the way it's all engineered generally, the entire query system would need rewriting to support proper query building.

In which case... you know where the delete button is, hehe :D
Is it the red one or the blue one?
Posted: September 6th, 2010, 10:32 AM

rev 50
* Cleaned up some of the convert.php file... Honestly, this one is a real mess, I only did the end of it. (convert.php)
- Removed debug_* compatibility code. (convert.php, recount_boards.php, recount_categories.php, recount_membergroups.php, upgrade.php, Class-Package.php, Errors.php, Subs-Db-mysql.php)
- Kept removing PHP4 compatibility code. (convert.php, readme_*.html, Display.php, Load.php, LogInOut.php, QueryString.php, Search.php, Subs-Auth.php, Subs-OpenID.php, Subs.php, Help.english.php)
- Deleted Subs-Compat.php file, as it's no longer needed. Will reintroduce... if ever needed again.

So that's 50 commits in a week and a half or so. Nice numbers :)
Lunch break...
Title: Re: New revs
Post by: Dismal Shadow on September 6th, 2010, 01:40 PM
Wedge's 50 commits vs SMF's 1 commit per week...
Title: Re: New revs
Post by: Nao on September 6th, 2010, 02:10 PM
@Dismal> Actually, since last Thursday, Norv committed about 23 times, and some of Wedge's commits (many of mine, actually) aren't really feature additions, rather feature removals, which are easier to do... Such as this one:

rev 51
- Removed smflib folder (not used in SMF2, not likely to be used in Wedge.)
- Removed compatibility code for array_combine, array_fill, sha1, file_put_contents, ob_clean, ob_get_level (although this one isn't really needed.) (create_backup.php, repair.php, restore_backup.php, smf_api.php, webinstall.php, Display.php, DumpDatabase.php)
- Removed rawdata templating (leftover from SMF 1.0 days.) (ManageMaintenance.php, ManageServer.php, RepairBoards.php, Subs.php)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 02:34 PM
Quote
Community support?
Something that YSF discussed, the idea that the core would support only MySQL by default but that those who wanted other things (PGSQL, SQLite, heck even MSSQL) could bolt it on. Trouble is, each of those has their own requirements and the way to go is not to throw the query from MySQL at a series of string replacements to make it sort of work with other things (and in MSSQL's case, that's asking for trouble anyway)
Title: Re: New revs
Post by: Nao on September 6th, 2010, 03:05 PM
Yeah, the problem with other databases is that they're not plug & play when it comes to replacing MySQL functionality... Even the current state of SMF2 is a series of hacks designed to add support for PG and SQLite, but it doesn't help much. I'm sure that if the core team wanted to add support for some other DB at this point, they would have to hack into new areas as well because they found out there's an incompatibility here and there...
It's quite pointless to me. SMF started as MySQL and MySQL is still the de facto database system on the Interneds.
(I'm not removing extra support code unless you want it too, though.)

rev 52
* Updated to SMF rev 10095. Also fixed line endings, hopefully for the last time...
  ! Fixed avatars resized with javascript (script.js)
  * Tweaked the attachments cleaning to allow single file removals (script.js, Post template) [Bug 3559]
  & Tweaked the language string accordingly (Post english)
  ! Chose a hopefully more portable fix for cleaning file input (script.js) [Bug 3780]

--------> rev 10096 and 10097 are about fixing LF endings... Unfortunately, I just tried, and svn diff still generates a CRLF file, and patch still generates a CRLF file as well. So... I don't know.
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 03:11 PM
Part of me would like to keep it, but there's no reason it should stay unless we're seriously planning on providing the ability to deal with it later, which I doubt.

Most of the hacks for PGSQL are because SMF uses this banal system of comma-separated values in a string column. It may have made sense long ago but in the current day and age, it's not viable. Don't even get me started on trying to hack in MSSQL support, I actually gave that up as a lost cause in the current environment. (Seriously, how stupid is it not to support LIMIT x, y as a clause? You can have the TOP x rows, but can't page through like that.)
Title: Re: New revs
Post by: Nao on September 6th, 2010, 03:23 PM
I need to find another solution for the CRLF stuff.
First, I should try if converting my diff files to LF will preserve LF on the target files at patching time. I may have to add --binary to the patch call though. And I don't know if it won't generate other issues.
Too bad setting up Subversion to use LF didn't help a bit.
Quote from Arantor on September 6th, 2010, 03:11 PM
Part of me would like to keep it, but there's no reason it should stay unless we're seriously planning on providing the ability to deal with it later, which I doubt.
Here's the thing: I'm no good at PG and SQLite. Really, no good. I don't know a thing. It took me twice longer to write the Ignore Topic mod because I had to add support for PG and SQ. I thought it sucked. Now, the thing is, the more I spend time on crap like that, the less I can spend time on more interesting features. MySQL has at least a 90% marketshare in forum software, so I don't care about the remaining 10%. I'm not here to eat market shares, I'm here to team up with you and have fun making the best possible forum software for MySQL and PHP5. I'll leave market share issues to SMF.
Another thing is -- if someone adds support for a new DB system, then we'll feel compelled to help with it. And then we'll end up having to support it. And then we'll figure, okay let's put back support for PG and SQLite, since it was already there to begin with, we can simply revert some stuff...
And we'll be back to square one.

I really, really would vote for removal of what is left of the multiple database code. (Not a priority, though, but if it can save time generating a SMF page, then I want it.)
Quote
Most of the hacks for PGSQL are because SMF uses this banal system of comma-separated values in a string column. It may have made sense long ago but in the current day and age, it's not viable.
You mean, things like FIND_IN_SET?
Quote
Don't even get me started on trying to hack in MSSQL support, I actually gave that up as a lost cause in the current environment. (Seriously, how stupid is it not to support LIMIT x, y as a clause? You can have the TOP x rows, but can't page through like that.)
Oh, you gotta love Microsoft... :)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 03:30 PM
*nods*

/mehands Nao the axe to finish chopping the multi DB code out.
Point of interest: vBulletin only supports MySQL, IPB supports MySQL with MSSQL as a paid plugin (though knowing how that handles queries, it's not impossible to make it support other DBs without too much work)

Yeah, FIND_IN_SET is ridiculous, and doubly so since in PGSQL's case it doesn't exist at all, and has to be shoe-horned in as a user function (at a performance penalty, too), which returns T or F (or t or f sometimes), so you end up having to rewrite every instance of FIND_IN_SET in queries. I mean, seriously... who does it like that?
Title: Re: New revs
Post by: MultiformeIngegno on September 6th, 2010, 03:44 PM
What about MySQL destiny with Oracle..? Honestly I know nothing of what's happening with it, I only read scrolled ( :P ) some articles.. can it rely on a stable development?
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 03:58 PM
I think it can. Oracle has jettisoned the areas it's not interested in (OpenSolaris for one), and MySQL is a money maker for it, especially as it can sell very expensive training, then upgrades to Oracle gear later on (with support contracts)

I don't think there's anything to fear for MySQL at the current time, and I suspect it's got life for years yet.[1]
 1. /mewaits for this to come back to haunt him haha
Title: Re: New revs
Post by: Nao on September 6th, 2010, 04:27 PM
Quote from Arantor on September 6th, 2010, 03:30 PM
*nods*

/mehands Nao the axe to finish chopping the multi DB code out.
rev 53
- Removed more of the multi-database code. (install.php, Settings.php, Settings_bak.php, create_backup.php, repair.php, repair_settings.php, restore_backup.php, smf_api.php, upgrade.php)
! Typo in repair.php, 'smc_compat_dtabase' (this should also be backported to SMF2.) (repair.php)
! Re-introducing SMF rev 9976's fix of the backup system when some tables have fields using reserved names. (DbExtra-mysql.php)

I'm not completely finished but nearly so... I should change $databases['mysql'] to just $database, but I'm a bit tired of constantly proof-reading my own code.
Quote
Point of interest: vBulletin only supports MySQL,
'course.
"We only do evil, but we're good at it." :eheheh:
Quote
Yeah, FIND_IN_SET is ridiculous, and doubly so since in PGSQL's case it doesn't exist at all, and has to be shoe-horned in as a user function (at a performance penalty, too), which returns T or F (or t or f sometimes), so you end up having to rewrite every instance of FIND_IN_SET in queries. I mean, seriously... who does it like that?
I actually like FIND_IN_SET... :lol:
But keeping it in place when trying to support other database systems would be silly, indeed.
Title: Re: New revs
Post by: Nao on September 6th, 2010, 04:28 PM
Quote from Arantor on September 6th, 2010, 03:58 PM
I think it can. Oracle has jettisoned the areas it's not interested in (OpenSolaris for one), and MySQL is a money maker for it, especially as it can sell very expensive training, then upgrades to Oracle gear later on (with support contracts)
I wouldn't add support for Oracle DB... My girlfriend could, though! (Well, she'd be my living documentation on their custom stuff, at least.)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 04:30 PM
Just to clarify: FIND_IN_SET has its place, like everything else. But to use it to hunt through what is really relational data (user belongs-to group, board belongs-to group), which results in a table scan vs using indexes really is ridiculous.


When you're done with that, I'll begin on replacing $scripturl with a constant (along with the other similar globals that shouldn't really be global variables but constants)


Re Oracle: If we make the move to everything being properly relational anyway, it becomes so much easier to build for... but I don't like building for something I can't test, hahah.
Title: Re: New revs
Post by: Nao on September 6th, 2010, 04:36 PM
Quote from Arantor on September 6th, 2010, 04:30 PM
Just to clarify: FIND_IN_SET has its place, like everything else. But to use it to hunt through what is really relational data (user belongs-to group, board belongs-to group), which results in a table scan vs using indexes really is ridiculous.
Are you sure it's inefficient? I remember reading about performance issues and the conclusion was that it was just as fast as an extra table... Couldn't say, myself. Haven't been looking into {query_see_board} and stuff for a long time.
Quote
When you're done with that, I'll begin on replacing $scripturl with a constant (along with the other similar globals that shouldn't really be global variables but constants)
Hmm... You means replacing $scripturl with SCRIPTURL?
I noticed your use of constants inside SD...
May I give you my honest opinion?
It looks kinda ugly........... :unsure:
Actually takes me back to the days of SMF1, with $ID_MEMBER, $ID_BOARD and such.
Quote
Re Oracle: If we make the move to everything being properly relational anyway, it becomes so much easier to build for... but I don't like building for something I can't test, hahah.
Same here!

+1 for going relational, though. We already have plenty of tables... Why not add a few dozen more, people won't notice :P
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 04:42 PM
Quote
Are you sure it's inefficient? I remember reading about performance issues and the conclusion was that it was just as fast as an extra table... Couldn't say, myself. Haven't been looking into {query_see_board} and stuff for a long time.
I don't see how it can be even close as efficient. If you're using a relational table, you have the benefit of indexes. If you're using FIND_IN_SET, you're forced to traverse the table row by row, since you can't use an index on it, and parse the row.


In the case of SMF 1 and $ID_MEMBER and so on, I know why they did that, and in practice it's... interesting. Not only describing the column by name, you're implicitly implying it forms part of a primary and/or foreign key without any other characters. That was ugly.

I'm not on the fence about it being a constant, because really, it's defined once, and used throughout the code, which means so many passes back and forth through scope that it's unreal. In terms of formatting, what about actually making it 'scripturl'? Nothing says a constant has to be upper case, but it makes it easier to see if it is.

I also believe it should be faster too.

In SD's case, it was pure readability I was going for. No way was I going to remember in every case that status 3 was resolved or that 6 was deleted, but I knew I'd follow it better with TICKET_STATUS_CLOSED or TICKET_STATUS_DELETED. I found it was only ugly initially because I wasn't used to seeing it.
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 07:53 PM
Revision: 54
Author: arantor
Date: 18:21:42, 06 September 2010
Message:
! Fixed bug in unified editor class where BBC was loaded without the post language file first, in PMs. (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php

Posted: September 6th, 2010, 07:22 PM

Revision: 55
Author: arantor
Date: 18:27:53, 06 September 2010
Message:
! Quote now references the individual message only. Not 100% sure this is the fastest way to evaluate the regexp though. (Post.php, Subs.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs.php

Posted: September 6th, 2010, 07:28 PM

Revision: 56
Author: arantor
Date: 18:53:32, 06 September 2010
Message:
! Make the quick search box be hidden if the user doesn't have permission. (index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Title: Re: New revs
Post by: Nao on September 6th, 2010, 09:22 PM
Don't remember having ever touched the code you modified to add msg=... Are you sure it was needed? :)

rev 57
! Extra tabs/spaces, and typo fixes in comments, like its/it's and lets/let's. (Many files)
Posted: September 6th, 2010, 09:15 PM

Pete, I've re-read the install and upgrade scripts, and I really hope I got them done without breaking anything. In terms of logic, it should be okay. Just don't yell at me if you try running one of the scripts and it crashes :) I just wanted to be done with it...

rev 58
- Hopefully, removed all of the remaining multi-database code. (install.php, smfinfo.php, upgrade.php, DbPackages-mysql.php, DbSearch-mysql.php, Search.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 10:47 PM
Quote
Don't remember having ever touched the code you modified to add msg=... Are you sure it was needed?
Unless you did something funky, I found I needed it since link= doesn't accept msg on its own (it requires either (board+)topic or threadid, optionally followed by the msg number for the # fragment, or action=profile with user id for PMs)
Quote
Pete, I've re-read the install and upgrade scripts, and I really hope I got them done without breaking anything. In terms of logic, it should be okay. Just don't yell at me if you try running one of the scripts and it crashes  I just wanted to be done with it...
Well, every time I do something half way big, I push it through a fresh install, so I'll be able to test. I'm not so worried about the upgrade script right now personally (since I'm not planning to test it anytime soon :P)
Title: Re: New revs
Post by: Nao on September 6th, 2010, 10:52 PM
Quote from Arantor on September 6th, 2010, 10:47 PM
Unless you did something funky, I found I needed it since link= doesn't accept msg on its own (it requires either (board+)topic or threadid, optionally followed by the msg number for the # fragment, or action=profile with user id for PMs)
Yeah, that was totally needed and what I'd done in the first place. (See ticket #31)
Quote
Well, every time I do something half way big, I push it through a fresh install, so I'll be able to test. I'm not so worried about the upgrade script right now personally (since I'm not planning to test it anytime soon :P)
Unfortunately, the only way to properly test a forum install is to use it... ::)
(In the end, it's my goal to convert wedgeo to a vanilla Wedge, of course.)

PS: 1000+ posts on wedgeo :)
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 12:01 AM
Well, the installer doesn't appear to be broken...


Revision: 59
Author: arantor
Date: 22:59:27, 06 September 2010
Message:
+ Selecting IMG or URL buttons in non WYSIWYG mode prompts for IMG and URL (and also linktext for url bbc)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js


This is essentially the same as http://arantormods.com/index.php?action=media;sa=item;in=3 except it also handles it for img too. In other news, I rediscovered that IE has a custom prompt that's used in WYSIWYG mode, I may have to remove that in the interests of cross-browser experience being the same.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 07:25 AM
Great news for everything :)
(Install script or upgrade script?)
Title: Re: New revs
Post by: Nao on September 7th, 2010, 08:00 AM
"Please enter what text the link should say." -> Is this straightforward, or could people be confused with this? I would have said (with my limited English) something like, "You may enter a caption (description?) for the link if you'd like." It doesn't seem mandatory.
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 09:00 AM
It's no less straightforward than the prompt immediately before it, IMO, but I *am* a geek which means what sounds normal to me probably isn't, heh. I'll get my better half to look at it tonight.

It isn't actually mandatory, by design, so if people hit cancel on that prompt it gives them a url bbcode with the URL itself as the linktext.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 11:40 AM
It's just a matter of phrasing stuff correctly. I don't mean yours isn't correct -- just that it can be confusing.
I'm confused myself. With my post, not your phrasing. Or am I. Or is it.

I should go back to bed.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 12:14 PM
rev 60
* Renamed files with mysql in the filename to make it more generic. (install.php, create_backup.php, repair.php, repair_settings.php, restore_backup.php, smf_api.php, upgrade.php, detailed-version.js, Load.php, renamed: Db*-mysql.php to Db*.php, Subs-Db-mysql.php to Subs-Database.php)

--> I think "DbExtra.php" doesn't look good, but it's better than "DbExtra-mysql.php" which is redundant (MySQL *is* a Db.) Maybe "Data-Extra.php" or "Database-Extra.php"...? Dunno. It's not very important ;)

Okay, I should get back to my templating stuff now...
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 06:35 PM
Revision: 61
Author: arantor
Date: 17:33:04, 07 September 2010
Message:
! Remove unnecessary board and threadid from quote bbc handler. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on September 7th, 2010, 10:56 PM
rev 62
* URL prompt in editor should use [url] type instead of [url=] when no description is provided. (editor.js)
! Fixing on-the-fly rounded corners for IE when splitting topics. (SplitTopics.template.php)
* Minor stuff. (Recent.template.php, index.css, Subs.php)

--> when it comes to Subs.php, your modified regex had a "(?:topic)" in it... Just replaced it with "topic" ;)
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 11:04 PM
Oh, yeah, nice optimisation there on the URL prompt, I missed that in passing.


As for Subs.php... I figured there had to be a reason it was there as a positive assertion so left it until I had a reason to remove it, really.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 11:35 PM
- editor: I was surprised to have noticed that myself ;D
- Subs: (?:topic) really does nothing. The regex engine will disregard it. The only reason to use (?:) is if you provide a quantifier after the parenthesis. (?:topic)? is logical. It's either topic, or nothing. (?:topic) means it's even topic, or topic. :lol:
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 11:41 PM
Subs: Not entirely... if it's part of a paranthesised expression, it won't be matched.

But yeah, it's irrelevant here :P
Title: Re: New revs
Post by: Nao on September 7th, 2010, 11:43 PM
I assure you that it means "topic or topic". :whistle:

Okay, bed time for me...
Title: Re: New revs
Post by: Arantor on September 8th, 2010, 12:02 AM
Sorry, I meant *captured* in the match. ((?:topic=)\d+) would only match the number in a backref.
Title: Re: New revs
Post by: Nao on September 8th, 2010, 12:32 AM
No... "((?:topic=)\d+)" would return "topic=1", I'm pretty sure of it. (I wouldn't bet my life on it, but I'm still quite certain.)
Title: Re: New revs
Post by: Arantor on September 8th, 2010, 03:17 AM
My bad, I was thinking of ?= rather than ?:, ?= is non matching assertion, ?: is a subpattern, so yes it would match that.
Posted: September 8th, 2010, 12:34 AM

Revision: 63
Author: arantor
Date: 02:16:59, 08 September 2010
Message:
! Add 'banned' to possible moderation statuses in display area (in addition to 'watched', 'moderated', 'muted'
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/warning_ban.gif
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on September 8th, 2010, 02:36 PM
rev 64
* Updated to SVN rev 10098 (hmm, just a line to change. Cleaned up the function, too, as the comment was a bit contradictory.)
 ! Add attachments cleaning for IE as well, though it allows manually deleting the file input box (script.js)
Title: Re: New revs
Post by: Arantor on September 9th, 2010, 12:57 AM
Revision: 65
Author: arantor
Date: 18:56:14, 08 September 2010
Message:
+ Add conversion from quick to inline full editor in Quick Reply (Display.php, index.css, Display.template.php, index.english.php, topic.js)
! Fix change of state in buttons if bbcode disabled (editor.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/topic.js


The edit to editor.js was to fix some errors coming up in FF when bbcode was disabled entirely. I couldn't reproduce in RC3 public, so I'm not 100% sure it isn't a regression caused by the editor changes, but it all functions as it's supposed to now, so not sure what to make of that.
Posted: September 8th, 2010, 07:57 PM

Revision: 66
Author: arantor
Date: 19:51:49, 08 September 2010
Message:
! Fixed font size selector to actually work as intended (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Posted: September 8th, 2010, 08:55 PM

Revision: 67
Author: arantor
Date: 23:57:05, 08 September 2010
Message:
+ Add post time on wireless views (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php
Title: Re: New revs
Post by: Nao on September 9th, 2010, 02:45 PM
Sometimes... I really feel like a small-time hacker with my minor revs :P

rev 68
- Removed needs_size_fix hack, as it was only used in Babylon themes. (Load.php)
- Removed nopadding from Admin template -- looked ugly for no reason. (Admin.template.php, admin.css)
* Pete... I'm afraid I'm a parenthesis nazi. (Load.php, Display.template.php)
! Fixed Register and SplitTopics templates to apply rounded corners to divs instead of lists and forms. This allows for faster parsing when in compatibility mode. (Register.template.php, SplitTopics.template.php)
Posted: September 9th, 2010, 11:25 AM

Okay, this one's a bit better actually :eheheh:
I'm not too sure about the is_opera105up though... And I'd be tempted to delete WAY MORE is_* variables at this point. (Discuss in related topic, thanks.)

rev 69
+ Added code to automatically detect browser support for border-radius and box-shadow. (script.js)
* Moved rounded corner emulation code to script.js, as it's likely to be more stable now. (index.template.php, script.js)
* Started conversion of roundframe divs to delete non-semantic code. (index.css, BoardIndex.template.php)
* Rewrote browser detection code to be more efficient. Dropped versions is_ie4, is_opera5/6/7/8 are now forced to false, is_safari is only set if not in a smartphone environment, dropped is_opera96 entirely (was it used at all?), added is_opera105up (not is_opera105 though... I don't want to overdo it), is_ff is really only set for the actual Firefox and assimilated, and added is_ie9 and is_ie9up. (script.js)
* Updated this.bRichTextPossible initialization code accordingly. (editor.js)
! Deleted more IE4 compatibility code and fixed typos. (script.js)
! Fixed admin sub-menus to avoid showing a scrollbar. (index.css)
Posted: September 9th, 2010, 11:37 AM

rev 70
* Plenty of cleaning up. @todo: what's with the random registration code hardcoded into this..?! (Help.template.php)
* Some cleaning up. (Memberlist.template.php)
- Removed legacy class innerframe. (Help.template.php, BoardIndex.template.php, Profile.template.php)
* Finished converting roundframe divs to the new system. Yay! (Templates: Admin, Calendar, Display, Help, Login, Memberlist, Notify, PersonalMessage, Poll, Post, Profile, Register, Reminder, Search)
Posted: September 9th, 2010, 12:13 PM

rev 71
- Removing securityPackages folder, as it's SMF-specific and being well behaved, we don't play with others' toys.
! Fixed undefined error 'submit_label'. (Display.php)

rev 72
! Fixed incorrect regex in browser detection. (script.js)

(Sorry, forgot to commit the second one at the same time...)
Posted: September 9th, 2010, 01:29 PM

rev 73
! Clean fix for the font size dropdown in Opera (see here(http://dev.simplemachines.org/mantis/view.php?id=4453)), and added support for 6pt font size. (Class-Editor.php, editor.js)
* Another coup from the Parenthenazi. (Wireless.template.php)
Title: Re: New revs
Post by: Arantor on September 9th, 2010, 02:49 PM
Re r73... so, then, where the select is later set to value = 0 to reset it, what happens? The idea is that in WYSIWYG mode it should retain its value until deselected, or in non WYSIWYG mode it should deselect.

Chrome didn't care, FF didn't like it either (before). Will have to test whether it works now.
Title: Re: New revs
Post by: Arantor on September 9th, 2010, 03:06 PM
Revision: 74
Author: arantor
Date: 14:05:08, 09 September 2010
Message:
! Removal of easter eggs:
 the clock (Calendar.php, Calendar.template.php, index.php)
 the Books of Unknown (Karma.php, index.php)
 i am the administrator. (Post.php)
 iamanoompaloompa (Subs-Menu.php)
 chocolate cake (Subs-Members.php)
 fake integrate_egg_nog (ViewQuery.php)
 OH NOES (ManageMaintenance.php)
----
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/index.php


As per http://wedge.org/up/6160/easter-eggs/
Title: Re: New revs
Post by: Nao on September 10th, 2010, 12:39 AM
What happened with your fix, was that selecting "Select font size" would add [size=0pt][/size] to the message box... :)
So I simply did it the way other boxes were done. Now it works, it simply returns "" (insteaf of "0") and thus doesn't show anything.

BTW, wrong place to discuss but I'm a bit lazy...

   $breaker = '<span style="margin: 0 -0.5ex 0 0;"> </span>';

This is in the code to fix long words. Uh... How about we use the proper tool -- &shy;?
Posted: September 9th, 2010, 03:06 PM

rev 75
- Removed setRequestHeader test for Opera... That issue was only in the 5yo Opera 8.00 (note the specific minor version number), so... what the heck?! (Post.template.php, topic.js)

(Looks like Wedge is on a diet, today... ;))
Posted: September 9th, 2010, 03:09 PM

rev 76
- Market share for IE 5.x was 0.08% in 2009... We're in 2010. IE5 support is out. (Load.php, Subs.php, Display.template.php, editor.js, script.js, topic.js)

rev 77
! Oops again. (Load.php) <-- crash

rev 78
! is_opera105up wasn't properly filled in. (script.js)
! document.body isn't always initialized. Replaced with a createElement. (script.js)
+ Re-introduced ActiveX hack, as IE6 also made use of it. Limiting to the newer namespace, though. (script.js)
* If browser supports querySelectorAll(), use that in the rounded corner emulator. Probably only Opera 9.x through 10.10 can make use of that. (script.js)

Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
I don't even have access to the console, for a reason unknown. :(
Posted: September 10th, 2010, 12:03 AM
Quote from Nao/Gilles on September 10th, 2010, 12:03 AM
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
Grmpf... Did the update, and it works in O 9.5. Dunno if it was broken in O9 because I had some wrong configuration. Anyway... O9.5+ is 90% of the Opera userbase or so. Fine with it.
Title: Re: New revs
Post by: Nao on September 10th, 2010, 01:50 PM
rev 79
! grabJumpToContent() is called through onmousemover if document.implementation isn't defined... It should be done for all, or nothing. (script.js)
* set/getInnerHTML are deprecated, but weren't actually removed from the SMF codebase. (install.php, ssi_examples.php, repair_settings.php, smfinfo.php, unittest.js, upgrade.php, latest-news.js, latest-support.js, admin.js, editor.js, fader.js, PersonalMessage.js, script.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, Templates: Admin, ManageMaintenance ManageSearch, ManageSmileys, MessageIndex, Packages, PersonalMessage, Post, Profile, SplitTopics, Themes)
Posted: September 10th, 2010, 10:46 AM

rev 80
+ Added a placeholder for parse_bbc_inline(). Should be rewritten to use regex later. (Subs.php)
Title: Re: New revs
Post by: Arantor on September 10th, 2010, 09:07 PM
You know you fixed up an easter egg in r79, right? :P ssi-examples.php, line 52...
Title: Re: New revs
Post by: Nao on September 10th, 2010, 09:27 PM
Yeah... ;) I actually considered changing the text to say some other thing, but then I decided against it, as I like chocobos, too :P Had it been a Pokémon reference, I would have changed it haha.

Good to see you're reading every fucking borin' line of my stuff!
How do you do it? I mean, I do it too, but sometimes when there are too many changes, I have to take a few minutes to build a diff patch out so I can read more comfortably instead of checking out the log and having to watch the changes file by file...
Title: Re: New revs
Post by: Arantor on September 10th, 2010, 09:30 PM
The slow way; I look through the log, rev by rev, and then file by file. Though depending on the level and nature of changes I have been known to run two revs together, such as when we were fixing CRLFs, when I'd run two revs together to see the total changes between them.

Basically whatever looks like it'll give me the best clue as to what's changed in the code.
Title: Re: New revs
Post by: Nao on September 10th, 2010, 09:35 PM
Yeah, I have a SVN and a SVN_2 folder to make my diff patches for SMF, and a SVN and SVN_all folder for Wedge, although it's a bit different (SVN is a shortcut to trunk, so I can't diff patch between the two, I have to specify SVN_all/trunk and it's boring... :P)
If I could find a way to automate the entire process, that'd be swell... Retrieve rev number in SVN folder, update SVN2 to that rev, then update SVN to latest rev. If different, generate a patch, with name "dev-CURRENT_REV.diff". Make coffee, too.
Title: Re: New revs
Post by: Nao on September 11th, 2010, 12:26 AM
rev 81
* Uninteresting code cleanup and optimizations. (Class-Editor.php, Load.php, index.css, script.js)
! replaceText() could fail on Opera if run on a message without any carriage return. (script.js)
! Post editor smileys and bbcode buttons would fail on Opera < 10.5 and IE 6-8 because setting innerHTML or outerHTML on an object with dynamic events will reset the event list in these browsers. (script.js)
Title: Re: New revs
Post by: Nao on September 11th, 2010, 01:26 AM
rev 82
* If modder forgets to put empty quotes at the beginning of a smf_db_query call, let's fix it for them. Dunno if it could be useful. Just felt like it. (Subs-Database.php)
* Cleanup for script.js
- Removed all of the optional parameters in queries, as they were only used by PGSQL and SQlite. (All other files -- please don't make me list them!)

--> Don't bother testing the param stuff Pete, there are about 75 occurrences and I checked them all, one by one. (Automatic search & replace so it was unlikely to fail anyway.)
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 03:56 AM
There was me checking one by one since I tried to commit myself in the interim...

Revision: 83
Author: arantor
Date: 00:35:43, 11 September 2010
Message:
! Remove support for the no longer maintained Turck MMcache (it doesn't even support PHP 5.x properly not having been updated in 7 years) (smfinfo.php, Admin.php, Load.php, ManageServer.php, Subs-Admin.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/tools/smfinfo.php
Posted: September 11th, 2010, 01:36 AM

Revision: 84
Author: arantor
Date: 01:02:19, 11 September 2010
Message:
! Minor optimisation for participation icons (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Posted: September 11th, 2010, 02:02 AM

Revision: 85
Author: arantor
Date: 02:55:32, 11 September 2010
Message:
! Fix bug with the top selector in Who's Online not working (Who.php)
----
Modified : /trunk/Sources/Who.php


As reported by http://www.simplemachines.org/community/index.php?topic=399617.0
Title: Re: New revs
Post by: Nao on September 11th, 2010, 09:05 AM
rev 86
* Updating to SMF rev 10101. Parenthenazi kills SD.
 ! fetch_web_data didn't properly parse ports (Subs-Package.php)
 ! constructPageIndex didn't respect flexible start for compact pagination (Subs.php)

(Yikes, I felt dirty committing this, even though the fixes were made by the reporters, not the committers... They're giving commit access to SlammedDime, after what he did to the team's rep?! Woohoo... And vbgamer45 made his first commit in something like *4 months*, to backport that fetch_web_data fix which isn't even perfect but... :P)

! Minor optimisation for participation icons (Recent.php) <--------- Hey, that was my find :P Thief! :lol:
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 01:53 PM
SlammedDime has had commit access for years, just he never uses it.
Title: Re: New revs
Post by: Nao on September 11th, 2010, 02:59 PM
rev 87
! Sending PM and moving topics were broken due to wedgeEditor not being correctly loaded. (MoveTopic.php, Subs-Post.php)
* Renamed install/upgrade_2-0_mysql.sql to install/upgrade_2-0.sql, to match the 1.1 branch files. (install.php, upgrade.php, *.sql)
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 03:09 PM
Oops, I broke it :P

Are we going to update changelog.txt?

Also, did you see my proposed changes for the PM UI? (http://tracker.wedge.org/?sa=ticket;ticket=18.msg253#msg253)
Title: Re: New revs
Post by: Nao on September 11th, 2010, 04:18 PM
Quote from Arantor on September 11th, 2010, 03:09 PM
Oops, I broke it :P
Told ya I hadn't looked into Class-Editor... ;)
I must say, I'm not too excited about having to type wedgeEditor::preparsecode instead of just preparsecode(), but I'm sure there's a good reason behind it, I trust you on that one. (If there isn't, then I'll kill you dead for it :P)
Quote
Are we going to update changelog.txt?
Well, one of the things that really piss me off with changelogs, is that NOBODY reads them, even when you're trying HARD to make them fun to read... (Just have a look at some of Aeva/SMG/AeMe's log entries. I even placed a Blade Runner quote in AeMe and nobody probably saw it :P)
So, having a 800KB changelog is totally useless in that respect. What people need is the kind of changelog I do for AeMe on big version updates: I categorize changes by interest. The biggest changes are put first, then the "cool" changes, then at the end I have a list of geeky, uninteresting changes, and finally the mandatory line "Plenty of bug fixes as usual", which is totally right.

I generate my changelogs at release time (or close to), by getting them from Tortoise and reordering them.
We could try having a changelog generated automatically from the svn (I'm sure there's a tool for that), and then we can go through it and delete anything that's not of interest to the reader.

Also, one of the things that piss me off in SMF's changelog, is that they document fixes for *unreleased revs*. Yay... Like it's going to be of any interest to non-testers! Even them don't read changelogs -- at best, they go through (most of) the bug tracker.
Quote
Also, did you see my proposed changes for the PM UI? (http://tracker.wedge.org/?sa=ticket;ticket=18.msg253#msg253)
Yes, and that's precisely what got me to find the crash ;) And subsequently the ClassEditor missing a dash.
I was trying to send meself a PM to see if you had committed the change already (I wasn't sure.)
Anyway, yeah, do try and commit it. ANYTHING is better than what's up right now...! :) We'll fix it later if it needs anything.

Really, really -- let's all have fun with Wedge. It's been over 2 weeks now, and it's been a lot of fun already. I can't stop working on it, it's so thrilling to finally be able to get rid of legacy code and add features that have been waiting for so long. And I haven't even got started on converting Noisen features!! ;)

At some point, we'll have to consider posting a working copy of Wedge in private, for our users here. I'm sure they'll appreciate being able to browse through the changes instead of just discussing them. Since we're working on local copies, it won't be updated as often, but it could.
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 08:51 PM
Quote
(If there isn't, then I'll kill you dead for it )
There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.

I liked how you did the AeMe changelog though I'll admit I never read it in detail.

I hadn't committed the PM stuff, I wanted to get opinions on it before I did since it wasn't very cleanly done. I'll commit in a minute and we can pick the bones out of it later.
Posted: September 11th, 2010, 08:30 PM

Revision: 88
Author: arantor
Date: 19:50:12, 11 September 2010
Message:
+ Dropdown selector for PM viewing mode (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php


Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.
Title: Re: New revs
Post by: Nao on September 12th, 2010, 01:03 AM
/meis in a trance listening to the Atari ST Chambers of Shaolin soundtrack...
Quote from Arantor on September 11th, 2010, 08:51 PM
There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()? Nothing says it was added through the editor itself... It could have been imported through a feed, etc... (Or even generated by SMF or a mod...)
Quote
I liked how you did the AeMe changelog though I'll admit I never read it in detail.
Well, that only proves my point :P
I don't believe anyone ever admitted to me having read the changelog at all. It's okay with me. It's THERE to be read if you need to. If you don't, then that's okay. But it's just like buying a new car and thinking, "okay it's cool, I can drive a car already, I don't need to read the manual..." And then of course you realize some things are done differently, then you read the changelog, and discover in the meantime a feature you never knew had been added, so you figure you'll read the entire changelog to spot other hidden features, and all you end up finding is easter eggs... :P

Oh my... Chambers... of... Shaolin... It's so great, I can't focus on this post... Too bad the Amiga version sounds so dull(http://www.youtube.com/watch?v=yG9ppmpuYTE#)...
Quote
Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.
Sure!
I'll have a look tomorrow...
Title: Re: New revs
Post by: Arantor on September 12th, 2010, 01:22 AM
Quote
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()?
When it comes to having it in a random file that seems disjointed, or at least tied to the behaviour in which it is most directly used, I'd rather have it attached to where it is used.

There is no use within SMF/Wedge where preparsecode is used where the content hasn't come from the editor. Sure... it could come from a feed or a mod, but in that case it's still coming from an arbitrary place. As far as I'm concerned, we talking about the function being just in a file, versus being with the code that hands content to it.

For me it's a step towards creating some semblance of order where, right now, I don't really see it.

I'd like to think we can make a useful changelog for people much like the AeMe one, in a way that's fun as well.
Title: Re: New revs
Post by: Nao on September 12th, 2010, 01:36 AM
Quote from Arantor on September 12th, 2010, 01:22 AM
Quote
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()?
When it comes to having it in a random file that seems disjointed, or at least tied to the behaviour in which it is most directly used, I'd rather have it attached to where it is used.
Fine, but... In an editor object?
Look at Aeva-Media.php... It has the media object in it. See the extList function? I put it outside the object because I was getting errors when running in strict mode (dunno why.) Still, I think it's better in that place because basically it was mainly unrelated to the media object and made no use of it. The function is still in the better file, but doesn't have to be in the object itself.
Quote
There is no use within SMF/Wedge where preparsecode is used where the content hasn't come from the editor. Sure... it could come from a feed or a mod, but in that case it's still coming from an arbitrary place. As far as I'm concerned, we talking about the function being just in a file, versus being with the code that hands content to it.
Is this, anyway, really going to help the adding of TinyMCE, CKEditor etc?
Quote
I'd like to think we can make a useful changelog for people much like the AeMe one, in a way that's fun as well.
Of course we can :) If only for us to keep track of what makes Wedge great!
Title: Re: New revs
Post by: Arantor on September 12th, 2010, 02:14 PM
Yes, in an editor object, because the only time I ever actually saw it used outside of coming from the editor was for shoutboxes.
Quote
Is this, anyway, really going to help the adding of TinyMCE, CKEditor etc?
Yes, now the underlying reason. Code that comes from one of those will need some kind of treatment before it can be saved - I don't know about you, but I'm hesitant to trust anything from the user. Don't care what it is, I don't want to trust it without some kind of processing.

I need to sit down and look at exactly what is sent, to figure out what changes are going to be necessary to the preparse routine, but some changes *are* going to be required, and having all the code in one place means it's possible to keep all the related behaviour together.

I'm not sure yet exactly we'll handle the editors, whether we just have one only, or multiple (since that was something YSF wanted), or fix up the WYSIWYG editor in some fashion, so I haven't yet made it trivial to switch behaviours, but having the class structure will make it easier in the long run.
Posted: September 12th, 2010, 01:47 AM

Revision: 89
Author: arantor
Date: 01:17:59, 12 September 2010
Message:
! Change 'stars' to 'rank images' (including renaming the star*.gif files though left the table column alone) (yabbse_to_smf.sql, install_2-0.sql, upgrade_1-0.sql, ManageMembers.english.php)
----
Added : /trunk/Themes/default/images/rank.gif (Copy from path: /trunk/Themes/default/images/star.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankadmin.gif (Copy from path: /trunk/Themes/default/images/staradmin.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankgmod.gif (Copy from path: /trunk/Themes/default/images/stargmod.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankmod.gif (Copy from path: /trunk/Themes/default/images/starmod.gif, Revision, 87)
Deleted : /trunk/Themes/default/images/star.gif
Deleted : /trunk/Themes/default/images/staradmin.gif
Deleted : /trunk/Themes/default/images/stargmod.gif
Deleted : /trunk/Themes/default/images/starmod.gif
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/other/converters/yabbse_to_smf.sql
Modified : /trunk/other/install_2-0.sql
Modified : /trunk/other/upgrade_1-0.sql

(ticket 36)
Posted: September 12th, 2010, 02:18 AM

Revision: 90
Author: arantor
Date: 04:16:31, 12 September 2010
Message:
+ Dropdown user menu added (Display.php, Display.template.php, index.english.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/topic.js

It's not overly pretty, but I think it's better handled than my original mod; firstly, it doesn't show in wireless when it isn't meant to, and it is now JS controlled, but the JS isn't particularly elegant - and for some reason it's not dropping smf_scripturl into the URL when it begins with ? - I didn't see a need to spell out $scripturl every time in the array. Note that since PHP 5 rather than 5.1 or 5.2 has been stated, I'm using a homebrew limited version of json_encode to pump the array of data.

I also didn't have the catbg header bar I had before, didn't see a need to throw that into the mix as well. Works in FF and Chrome, too late tonight to test any more (or debug that last oddity)
Posted: September 12th, 2010, 05:19 AM

Revision: 91
Author: arantor
Date: 12:41:48, 12 September 2010
Message:
! Actual fix for who's online glitch (removing previous fix too) (Who.php, Who.template.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Who.template.php
Posted: September 12th, 2010, 01:42 PM

-sigh-

I just realised my fix works for those folks who use JS but not for those who don't. Argh, why did they do it the stupid way they did it? (One form, two dropdowns, and never checking between the two sets of values)

Revision: 92
Author: arantor
Date: 13:13:44, 12 September 2010
Message:
! Additional fix to who's online for non JS users (Who.php, Who.template.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Who.template.php
Title: Re: New revs
Post by: Nao on September 12th, 2010, 04:17 PM
I'm not very confident that we can actually keep both the internal Wysiwyg editor AND add support for others without too much hacking, but I'll let you play with it if you want ;) I wouldn't mind only supporting external editors, myself.

BTW, what tool do you use to do your site-wide searches, and search & replace events?
Personally, I'm with very old tools (outdated?): Super Text Search for searches (supports regex so I kept it so far), and BK ReplaceEm for search & replace.

Also, in PersonalMessage.php:
Code: [Select]
// Changing view?
if (isset($_REQUEST['view']))
{
$_GET['view'] = (int) $_GET['view'];
Is it wanted? $_REQUEST then $_GET? Not logical to me...

On to the boring stuff... (Haven't tested user menus yet. Excited about 'em.)

rev 93
- Removed support for Konqueror. (Load.php, Subs.php, Admin.template.php, Packages.template.php)
- Removed support for some browser version numbers: Opera 9/10, Firefox 1/2/3, as they're not known to have specific issues. Added user agent in $context['browser']['ua'] for modders to get a clean way to search for specific version numbers. (Load.php)
* After looking through Who.php, I realized I'm also an isset-nazi. Starting work on merging isset() && isset() calls together. (Subs-Editor.php, Subs-List.php, Subs-Menu.php, Subs-MessageIndex.php, ViewQuery.php, Who.php, Post.template.php, Wireless.template.php)
+ Added a msnbot (Bing) check in possibly_robot, but it should be useless anyway. Maybe just in case they decide to add "Mozilla" in their user agent string... (Load.php)

rev 94
! I don't know what a profie is... Is it a profitable profile? (Display.php, index.english.php)
- Deleted im_switch.gif. Goodbye, and please don't call, we won't miss you. (im_switch.gif, Help.template.php)
* Spacing nazi (index.css, Display.template.php, topic.js)
Title: Re: New revs
Post by: Arantor on September 12th, 2010, 04:52 PM
Quote
I'm not very confident that we can actually keep both the internal Wysiwyg editor AND add support for others without too much hacking
Neither am I and that wasn't the plan. The current editor is... broken. So either we fix it or we kill it and replace it a new one. A better one.
Quote
BTW, what tool do you use to do your site-wide searches, and search & replace events?
Notepad++
Quote
Also, in PersonalMessage.php:
Yeah, implemented that one in a bit of a hurry (I think I said it was ugly). Should be $_GET really, and I don't think I did it as a form submit because of the rest of the form on the page. Though perhaps something properly AJAXish would be better? (And more prone to breaking on custom themes). In any case I'm so used to SMF interchanging $_REQUEST, $_GET and $_POST for the wrong reasons :(

Haven't looked at the changes yet, but all sounds good to me.
Title: Re: New revs
Post by: Nao on September 12th, 2010, 06:49 PM
rev 95
! upgrade_2-0.sql file didn't get deleted after an upgrade process. (upgrade.php)
! Fixed Display template showing an error next to a guest poster. It currently links to a dummy URL, will fix when I had proper support for this Noisen.com feature. (Display.php)
* Moved conversation selector from left to center in PM homepage, as it takes less space there and might be placed more logically this way. But am I to talk... (PersonalMessage.template.php)
* Changed possibly_robot again, to use preg_match() and more generic search terms. (Load.php)

(Feel free to discuss!)
Title: Re: New revs
Post by: Nao on September 12th, 2010, 10:25 PM
rev 96
+ Re-implemented pseudo-'link' for guests in Display page, for alternative themes. (Display.php)
* Tweaked a couple of language entries. (index.english.php)
* Spacing nazi. (ManagePermissions.template.php)
Title: Re: New revs
Post by: Nao on September 13th, 2010, 10:27 AM
rev 97
* Changing $_REQUEST to $_GET where logic says so. (PersonalMessage.php)
! Class typos. (ModerationCenter.template.php, Packages.template.php)

Next rev will change all <h[34] class="*bg" to remove the bg class, as they're all enclosed within cat/title_bars anyway, and this can be styled accordingly.
Title: Re: New revs
Post by: Nao on September 13th, 2010, 05:17 PM
rev 98
* Removed catbg and titlebg classes from all h3 and h4 tags, and updated styling to match this. (Class-Editor.php, ManagePaid.php, index.css, admin.css, ie6.css, ie7.css, rtl.css, plus most template files.)
- Deleted title_barIC class, as it's only used in the information center and there's really no point in having a separate styling for it. (index.css, BoardIndex.template.php)
- Deleted catbg2 and catbg3 classes (unused in Curve.)
* Changed header font to Georgia, for a change really. Will change to something else later. (index.css)
@ Warning! index.css is a work in progress -- I'm currently trying to separate legacy emulation of corners into a new file that will be included through JS, and I need some time to make sure it's usable.
@ In non-compat mode, the titlebg class is now a bit brighter. I like it better this way...
Posted: September 13th, 2010, 05:15 PM

rev 99
- Deleted all occurrences of menu_gfx.png (replaced with menu.png and buttons.png files, respectively, buttons.png being called only on non-compat browsers.)
Title: Re: New revs
Post by: Nao on September 13th, 2010, 05:25 PM
rev 100
* Updated to SMF rev 10105. And Wedge reaches rev 100...
  ! Clean up package servers (PackageGet.php)
  ! Topic moderation logs were not listed on mod report details page. (ModerationCenter.php) [Bug 4419]
  ! 'moderate_board' permission does not really make sense for guests (ManagePermissions.php) [Bug 4460]

(They also included the topic participation patch I offered. Obviously I didn't reinclude it here ;))
Title: Re: New revs
Post by: Nao on September 13th, 2010, 08:53 PM
rev 101
* Moved border-radius compatibility code to old.css, and loading it dynamically if needed via JS. Bit cleaner... (script.js, old.css, index.css)
- No longer deleting the wrc and rrc classes on old browsers -- only nulling them. (script.js, old.css)

(How's your Tardis search going?)
Title: Re: New revs
Post by: Arantor on September 14th, 2010, 12:33 AM
OK, now I'm back from tidying the house (and it's still not finished), I'll sit and review everything, but you HAVE been busy.
Title: Re: New revs
Post by: Nao on September 14th, 2010, 01:27 AM
Don't bother about the unnamed template files in rev 98 -- they're really super boring. I checked them all, there's approx. 300-400 lines changed, always the same (<h3 class="catbg"> -> <h3>)
Title: Re: New revs
Post by: Arantor on September 14th, 2010, 11:14 AM
I just checked everything as a unified diff from where I was to current, seeing all the changes as the total sum of changes per file. Looks good to me.



Revision: 102
Author: arantor
Date: 10:13:32, 14 September 2010
Message:
+ Code documentation (Subs-Sound.php)
----
Modified : /trunk/Sources/Subs-Sound.php
Title: Re: New revs
Post by: Nao on September 14th, 2010, 11:18 AM
Good then.
Hey we commit a few minutes apart from each other, eheh.

rev 103
* Restored topslice/botslice/upperframe/lowerframe classes to index.css, to preserve compatibility with mods -- for now. (index.css, old.css)
* Moved border-radius emulation code to theme.js, where it'd probably better be. (script.js, theme.js)
* Speeded up the on-the-fly image resizer initialization on modern browsers, by calling only images with a 'resized' class. (theme.js)

Should I be checking your code documentation? I really suck at docs...
Title: Re: New revs
Post by: Arantor on September 14th, 2010, 11:31 AM
Quote
Should I be checking your code documentation? I really suck at docs...
Up to you. That one was particularly dull to document, just threw it together last night before going to bed.
Title: Re: New revs
Post by: Nao on September 14th, 2010, 11:57 AM
Documenting is your thing :P
I, myself, will rather strive to simply comment my code because it's probably my weakest area... I realized that when I went through Aeva Lite the other day to add a feature for YouTube compatibility, only to realize an hour later that it was ALREADY implemented :lol:
Title: Re: New revs
Post by: Arantor on September 15th, 2010, 05:18 AM
You'll likely find it easier to get into once more of the source is documented. I'm gonna do Errors.php next, did a bit of it earlier before going back to bed. More to follow if I manage to get enough of the house tidy that I don't get murderalised for going back to bed...
Posted: September 14th, 2010, 05:01 PM

Revision: 104
Author: arantor
Date: 02:56:44, 15 September 2010
Message:
+ More code documentation (Errors.php)
----
Modified : /trunk/Sources/Errors.php
Posted: September 15th, 2010, 03:57 AM

Revision: 105
Author: arantor
Date: 04:18:21, 15 September 2010
Message:
+ More code documentation (LockTopic.php)
----
Modified : /trunk/Sources/LockTopic.php
Title: Re: New revs
Post by: Nao on September 15th, 2010, 08:59 PM
(The usual boring series...)

rev 106
* Finished converting isset() && isset() occurrences to isset(..., ...) (convert.php, upgrade_1-1.sql, upgrade_2-0.sql, MessageIndex.template.php and 40 source files)
Title: Re: New revs
Post by: Nao on September 16th, 2010, 01:48 AM
rev 107
! Fixed button strips in both CSS3 and emulation. (index.css, old.css)

The main menu fixes will be for tomorrow. (They're using the same concept as button strips, so it's basically the same work.)
I also need to make sure cat_bar and window_bg work the same in both css3 and non-css3 modes.
/meis tired.
:edit: Uh, apparently cat_bar is good!
Posted: September 16th, 2010, 12:05 AM

rev 108
* Replaced titlebg.png and catbg.png with a single file that is even smaller in size. (index.css, bars.png)
Title: Re: New revs
Post by: Arantor on September 16th, 2010, 04:44 AM
Revision: 109
Author: arantor
Date: 02:53:03, 16 September 2010
Message:
+ More code documentation (Karma.php, Printpage.php)
----
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/Printpage.php
Posted: September 16th, 2010, 03:53 AM

Revision: 110
Author: arantor
Date: 03:44:02, 16 September 2010
Message:
+ Further code documentation (DumpDatabase.php, Subs-MessageIndex.php)
----
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Title: Re: New revs
Post by: Nao on September 16th, 2010, 04:47 PM
rev 111
* Some cosmetic fixes to a couple of icons. (stats_posters.gif, stats_replies.gif)
! On very short posts, the poster information area could overflow. (index.css)
! Icons inside bars were a bit too close to the top of the bar. (index.css)
! .title_bar h4 bars were a bit too tall. Why just them, I don't know. Don't ask. (index.css)
- Removed a couple of h3/h4 related styles that didn't seem to be of any use. (index.css)

(At this point, I feel like I'm a themer, rather than a coder...... Don't worry, it won't be forever :P)
Title: Re: New revs
Post by: Arantor on September 16th, 2010, 09:42 PM
Revision: 112
Author: arantor
Date: 20:41:41, 16 September 2010
Message:
! Stupid documentation fixes (DumpDatabase.php, Karma.php, LockTopic.php, Printpage.php, Subs-MessageIndex.php)
+ New code documentation (BoardIndex.php, Xml.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/LockTopic.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Xml.php
Title: Re: New revs
Post by: Nao on September 16th, 2010, 10:15 PM
rev 113
* Dozens and dozens of comma fixes... You gotta love the spacing nazi, eh? And I didn't even do them all. It's boring, even for me. (Don't you dare ask me for a file list.)

Seriously, that's plenty of files. The diff patch is relatively short though, so if you want to analyze the changes, please do it through a diff ;)
Title: Re: New revs
Post by: Nao on September 17th, 2010, 01:20 AM
rev 114
* Updated to SMF rev 10119. Got a lot of conflicts... We're getting away from the SMF2 code quick!
  + * Avatars and other packages removals missed session vars (Package template) [Bug 4463]
  + ! Small cleanup and tweaks [Bug 4461]
  + ! Fix attachments boxes cleanup for Safari [Bug 4470]
  + * Variant selection was disregarded when previewing a theme. (Themes template) [Bug 4433]
  + * Redirect back to the post instead of board, after reporting a post. (Display.php, MessageIndex.php, SendTopic.php, Display template, MessageIndex template) [Bug 4452]
  + ! Adjusted the URL for the arin whois service to reflect its new location. (Profile-View.php) [Bug 4464]
  + * Incorrect label assignment in Reattribute User Posts section. (ManageMaintenance template) [Bug 4467]
  + ! Restoring moderate_board permission for guests. (ManagePermissions.php)
  + * Ignored members' posts were not hidden in topic summary. (Post.php, Post template, Xml template) [Bug 4466]
  + * Variant selection was broken with reserved variant names. (Themes template) [Bug 4435]

And that annoying "Ignore User" feature is adding more bloat to SMF... (Check out the extra xml line in Xml.php, for instance.)
Title: Re: New revs
Post by: Arantor on September 17th, 2010, 01:36 AM
Bug 4463 and 4464 were ones I already patched? Though 4464 had some extra bits in the notes about being cleaner than what I did?
Title: Re: New revs
Post by: Nao on September 17th, 2010, 05:19 AM
- 4464 provides a different URL compared to yours. If doesn't have "query.do" in it, and is cleaner. I haven't tested it, but I suppose it's the official URL.
- 4463, as I said elsewhere, adds an extra check somewhere.

Rest of the interleaved patches -- didn't apply, and didn't document. I left everything in the changelog.txt file, though (for what it's worth, since the file will be going away ASAP.)
Posted: September 17th, 2010, 01:39 AM

rev 115
! For an unknown reason, the Post template wasn't correctly updated, even though I did it manually in the first place... (Post.template.php)
Title: Re: New revs
Post by: Nao on September 17th, 2010, 05:17 PM
rev 116
- Removed a PGSQL fix that doesn't sound very logical with MySQL. (Profile-View.php)
! Finally fixed menu items. Wedge's template is finally entirely pixel-perfect and CSS3-driven if available! (Profile-View.php)
Title: Re: New revs
Post by: Nao on September 18th, 2010, 01:46 PM
rev 117
! Fixed IE6 emulation code for rounded corners. (theme.js)
- Deleted insertAfter() function and moved a replacement to theme.js because, well, I don't think it'll be used much... (script.js, theme.js)
* We don't really need to obfuscate copyright checking code anymore, do we...? (Subs.php)

FWIW, Wedge doesn't look great with IE6, but it's only details (like a repeating background on roundframes where it shouldn't repeat...), nothing that can't be fixed if we're really anal about them.
Title: Re: New revs
Post by: Nao on September 18th, 2010, 05:19 PM
rev 118
* Replaced SMF's menu system with own. Warning, work in progress! GenericMenu needs cleaning up, GIFs could be sprited, etc. (ie6.css, index.css, GenericMenu.template.php, script.js, submenu.gif, subsection.gif)
Title: Re: New revs
Post by: Nao on September 18th, 2010, 11:58 PM
rev 119
* Finished implementing a workaround for the iPhone's lack of onmouseover()/onmouseout() in the new system. New code is particularly cool, and I'm not saying that because I spent my entire day on it. Ah well. (script.js, ie6.css, index.css)
! Forgot to indent HTML code for menu. Originally needed to be in a block because of a IE6 bug. (GenericMenu.template.php)
! Spacing nazi. (Recent.template.php)
Title: Re: New revs
Post by: Nao on September 19th, 2010, 05:01 PM
rev 120
* Replaced default SMF logo with a Wedge logo... Might as well do it, uh? Need to replace all smglogo occurrences in the source code. (install.php, index.css, rtl.css, wedgelogo.png, index.template.php)
+ Added a menu file I forgot. (white-op85.png)
! Fixed menu system to be able to handle several menus at the same time. (script.js, index.css, GenericMenu.template.php, ie6.css)
! .cat_bar h4 used a dark text color. Should be a bright one, given the background context. (index.css)
* Implemented the new menu system for SMF's main menu. Yay! (index.css, index.template.php)
@ To do: finish Wedge logo replacements, delete template_old_menu, harmonize Subs-Menu.php and Load.php menu generators (why are there two to begin with?!), change menu CSS to harmonize it with Curve, fix non-breaking minor glitch in menu system in IE6. And get started with the on-the-fly sidebar-menu transformation...

(Sorry that I'm fixing several issues in a single shot, but I kinda can't commit index.css in several portions, that would be dull...)

(Also, I'm not used to committing commented out or useless code, but I'd rather keep template_old_menu under the hand just in case I need to refer to it when doing further work.)
Title: Re: New revs
Post by: Nao on September 20th, 2010, 01:00 PM
rev 121
* Improved menu styling. (index.css)
* Merged menu arrows into a single file. (submenu.gif, subsection.gif, menu.gif)
* Cleaning up. (script.js)
! Fixed padding in live_news box. (admin.css)

(Ain't done yet!)
Title: Re: New revs
Post by: Nao on September 20th, 2010, 08:44 PM
rev 122
* More menu styling changes. It's starting to look better, now... (index.css, script.js)
* Updated to SMF rev 10121. SendTopic lines were screwed up, BTW... (Class-Editor.php, SendTopic.template.php, PersonalMessage.template.php, MessageIndex.template.php, Display.template.php)
@ I decided not to go with bugfix 4446. Personal choice...

http://dev.simplemachines.org/mantis/view.php?id=4446
Title: Re: New revs
Post by: Arantor on September 20th, 2010, 10:37 PM
Revision: 123
Author: arantor
Date: 21:31:00, 20 September 2010
Message:
+ Code documentation and a half (Post.php)
----
Modified : /trunk/Sources/Post.php


This added 130 new lines of documentation, and replaced the 60 or so incomplete lines there anyway...


@ Nao, I looked at bug 4446, I'm not sure what was actually applied - but is there a better fix than they've discussed? (CSS is not my forte) Or at least, one that is better for us?
Title: Re: New revs
Post by: Nao on September 20th, 2010, 11:04 PM
Well, the proposed fix was to apply overflow: hidden to .post_wrapper, which is EXACTLY what was already done on Wedge... (I don't know if I did it -- I probably did, although I don't remember.) I didn't know about this bug report until I looked into the fix.
What was done instead, was to apply float: left; width: 100% to the class.
However, I applied this to wedgeforum.com and noisen.com, and the windowbg/windowbg2 classes ended up getting a height of 0px, and the contents were overflowing from them obviously. I re-established my overflow, and it worked again. So I figured, to hell with this fix... I prefer mine. While Antechinus says it "doesn't work on every browser", in my experience it does. Even in IE6... Specifying an overflow setting has saved me from numerous issues with floating divs, really.
Title: Re: New revs
Post by: Arantor on September 20th, 2010, 11:06 PM
Then as far as I'm concerned your solution is better and works more in a way that works for us :) Yay for diverging routes!
Title: Re: New revs
Post by: Nao on September 20th, 2010, 11:27 PM
Given that I have to edit everything manually everytime they change a template (because of the header changes), I'm getting used to diverging routes... ;)
Title: Re: New revs
Post by: Arantor on September 21st, 2010, 03:05 AM
Revision: 124
Author: arantor
Date: 01:50:45, 21 September 2010
Message:
- Remove the help stuff:
 - Remove the action=help itself (index.php, Help.php)
 - Remove the menu item (Subs.php)
 - Remove the no-longer-used templates (Help.template.php)
 - Remove the no-longer-used text strings (Who.english.php, Manual.english.php removal entirely)
 - Remove semantic links to the page (index.template.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/index.template.php
Deleted : /trunk/Themes/default/languages/Manual.english.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php


Revision: 125
Author: arantor
Date: 01:53:19, 21 September 2010
Message:
! Revert commit of install.php, did not intend to commit local use changes.
----
Modified : /trunk/other/install.php



I didn't actually mean to commit install.php in r124, because that's my modified version to handle the UTF-8 changes... so I've reverted it. But really, it shouldn't be a problem (and you can see what I did in r124) - the sole idea was to bump the minimum MySQL version to 4.1.0 and just make it install without complaining such that if UTF-8 was ticked (and it was by default), that it would install it. (Right now, it really doesn't work properly, but it's a non issue for testing purposes)
Posted: September 21st, 2010, 02:55 AM

Revision: 126
Author: arantor
Date: 02:05:25, 21 September 2010
Message:
+ Added Yandex to the list of supported search engines (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql
Title: Re: New revs
Post by: Nao on September 21st, 2010, 12:26 PM
Good job.

You forgot to mention this one you committed:
rev 127
+ Added the ability to override banned users' avatars and simply hide them. More options will follow, hence building it like this. (ManageAttachments.php, Load.php, Admin.english.php, Help.english.php)

Also, as discussed earlier:

rev 128
- Removed converters folder, because right now we're only planning on supporting conversion from SMF2. Once it's ready, anyone can go from their forum system to SMF2, and then to Wedge.
Posted: September 21st, 2010, 12:22 PM

rev 129
- Deleted help_convert folder, as it's obviously a very outdated system related to the help templates.

(If you look at the copyright, it says Lewis Media 2006... I doubt it was updated after that!)
Title: Re: New revs
Post by: Nao on September 21st, 2010, 07:36 PM
rev 130
* Renamed MSN bot to Bing. (install_2-0.sql)
* Some help-related cleaning up. (*.dtd, Help.php)
- Dropped hover addon function for IE, because the new menu is cool and doesn't need that. (theme.js)
- Dropped rounded corner compatibility code, because... Well, screw IE! (index.css, old.css, theme.js)
- Dropped compat.css, in the same vein, because... Well, it sucks as a converter.
- Removed .rrc class from all templates. (Admin, BoardIndex, Calendar, Display, Help, Login, Memberlist, Notify, PM, Poll, Post, Profile, Register, Reminder, Search)
* A couple of fixes to IE6 layout, and IE7 cleanup. (ie6.css, ie7.css)
* Redesigned Curve layout. Mostly for the menu system. (index.css, menu.png, white-op85.png, grad*.png)
* Restarted menu layout code from the original SMF code, in a cleaner way. (GenericMenu.template.php, index.template.php)
@ TODO: Delete main_block.png, deal with rtl.css, and more cleanup.

Pete, hopefully you won't have the design changes too much! Remember, it's a work in progress. The header is to be redone. I just wanted to get rid of the SMF frame ASAP and couldn't find a suitable replacement!
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 11:21 AM
A cleanup commit entiely...

rev 131
- Deleted help area styling. (index.css, rtl.css)
- Deleted rounded corner compatibility code... For good!! (theme.js)
- Deleted tags when an ID is specified for them, as it's useless and hurts performance. (index.css, rtl.css, admin.css)
- Deleted topslice_quote and botslice_quote placeholders from quotes, because, well... If you're going to emulate rounded corners, you don't need them. And don't tempt me into deleting the quotefooter placeholder entirely! (Subs.php)
* Renamed left_adm* and main_adm* classes because they're generic, not admin-centered. (index.css, rtl.css, ie6.css, GenericMenu.template.php)
! Fixed a few issues with rounded corners. (SplitTopics.template.php)
* Moved style.css linking a few lines above in the head section, so that the browser will notice it sooner in case the HTML page isn't gzipped. (index.template.php)
* Spacinazi. (PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 07:39 PM
I'll commit today's changes ASAP. I'm not sure I'm done yet but my time for today is up.
I've also internally updated to the SMF rev 10127... Norv has started documenting the files! Well, by "documenting", I mean "replacing the "// !!!" with single-line descriptions of the functions ;)
Title: Re: New revs
Post by: Arantor on September 22nd, 2010, 07:45 PM
Quote
Norv has started documenting the files! Well, by "documenting", I mean "replacing the "// !!!" with single-line descriptions of the functions
I wouldn't really call that documentation. I would, however, call the awesomeness in Post.php documentation :P
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 10:05 PM
Indeed! At last, you found a place to express the endlessly-fuelled creativity of your talkativeness. :eheh:
Title: Re: New revs
Post by: Arantor on September 22nd, 2010, 10:08 PM
Quote from Nao/Gilles on September 22nd, 2010, 10:05 PM
Indeed! At last, you found a place to express the caffeine-fuelled creativity of your talkativeness. :eheh:
Fixed that for you :P But yes, yes I did.
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 11:42 PM
Eheh.

http://dev.simplemachines.org/mantis/view.php?id=4471
This is an incomplete report, and it's been fixed in an incomplete manner... There are dozens of places where the icon class isn't applied. I noticed that while removing the ie6_header... And then I thought, "what's the point of that anyway? I never see more than one icon per header... So we can just as well access it with .cat_bar img, .title_bar img, it'll save a few bytes each time...
Anyway, I started removing icon classes earlier today. Do you think it's okay if I keep doing it? I really don't see a reason for keeping these in... (And I can't reopen reports to tell them. Which is why I was complaining originally that I was put into a minor group on the tracker...)
Title: Re: New revs
Post by: Arantor on September 23rd, 2010, 04:33 AM
Quote
This is an incomplete report, and it's been fixed in an incomplete manner
Status normal, captain.
Quote
I never see more than one icon per header
That's because it never happens. Many headings don't even have one. That said I'm not sure off the top of my head if cat_bg that is collapsible with a left icon, might not use icon for the upshrink (if that makes sense)? Either way, those cases will be pretty few and far between, and can be fixed if we find them - I'd say you're completely good to clear yet more cruft.
Posted: September 22nd, 2010, 11:45 PM

Revision: 132
Author: arantor
Date: 23:32:18, 22 September 2010
Message:
! Fix for editor generating extra divs when using custom div mode. (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php

Posted: September 23rd, 2010, 12:33 AM

Revision: 133
Author: arantor
Date: 23:35:04, 22 September 2010
Message:
! Fix error in SQL installer, with forgotten parameter (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql


This one was stupid. I missed the 4th parameter in the insert query.
Posted: September 23rd, 2010, 12:35 AM

Revision: 134
Author: arantor
Date: 03:32:35, 23 September 2010
Message:
+ Code documentation (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 11:55 AM
(Just getting rid of the quick update... Take note of my outrageous way to diminish the SMF team in a passive-aggressive way :P Interesting that it's happening on post #666 for me... Hmm.)

rev 135
* Updated to SMF rev 10127. Just a fix I reported, a minor security issue with word censorship, and some documentation which Pete will be rewriting from scratch anyway. (changelog.txt, install.php, create_backup.php, restore_backup.php, Admin.php, Class-Package.php, DbExtra.php, DbPackages.php, DbSearch.php, Display.php, Groups.php, LogInOut.php, ManageSearch.php, PackageGet.php, Subs-Database.php)
Title: Re: New revs
Post by: Arantor on September 23rd, 2010, 01:13 PM
Well, I was curious to see what documentation he'd done.
Quote
string function smf_db_get_version()
      - get the version number.
No shit! Still one line of description is better than none.
Quote
void QuickInTopicModeration()
      - in-topic quick moderation.
Or not, maybe. Literally taking the function name and re-ordering it to make a different phrase sort of isn't the plan.

And when you have a load of functions in one file, generally it's best to document everything, or at least put placeholders in (not like Subs-Database.php where only the first function has a description)


The security change... hmm, why does that look familiar? I guess he listened to what I proposed :)
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 02:35 PM
Y'know, there are people who hate documenting more than anything... ;)
I made my Kyodai Mahjongg help files under WordPad (sic), in RTF format (sic), and had to do both English and French versions at the same time (as for everything I do really), and didn't have a diff compare tool at the time... Oh, what fun it was!

Anyway... Finally!!

rev 136
@ The patch equivalent weighs in at 92KB... Yay.
@ This is only about templates, so add ".template.php" to the filenames.
- Replaced these horrible ie6_header/floatleft hacks with some actual common sense. Needs testing on all browsers! (Admin, BoardIndex, Display, GenericList, GenericMenu, Login, ManageMaintenance, ManageMembers, ManageNews, ManagePermissions, Memberlist, ModerationCenter, Notify, Packages, PersonalMessage, Profile, Recent, Search, SendTopic, Stats, Themes, index.css, ie6.css)
- Deleted png_fix and newupshrink classes/ids, which were not even used in a vanilla SMF2... (Admin, index.css)
- Deleted all img.icon classes, as they're all used within a title_bar/cat_bar and were replaced with contextual styling. (BoardIndex, Display, GenericMenu, Login, ManageNews, Memberlist, Notify, Packages, Profile, Recent, Search, SendTopic, Stats, Themes, index.css, admin.css, index.css, ie6.css, rtl.css)
* Added cellspacing="0" to table_grid declarations missing a cellspacing, and reverted table_grid border-collapse to separate, so that table headers can be properly rounded in a standards-compliant fashion. Also deleted border="0" declarations, as borders are set to 0 by default. (Admin, Errors, ManageBans, ManageMembergroups, ManageMembers, ManageNews, ManagePaid, ManagePermissions, Memberlist, ModerationCenter, Packages, PersonalMessage, Profile, Reports, SplitTopics, Stats, Themes, index.css)
! Fixed isset($config_var['postinput']) into !empty, as it was always set and would thus generate an extra tab in the HTML code. (Admin)
* Moved menu/sidebar toggle to the left... I say it's a matter of logic. Now if you'll stop bothering me, I'm busy writing this changelog... (index.css)
* Renamed generic menu classes, from their adm* and admin equivalents, as generic menus are supposed to be... generic. (GenericMenu, index.css, rtl.css)
* Spacing. (ManageBoards, Packages, PersonalMessage, Search)
* Moved profile summary's boxes a bit lower. Ideally, I should be doing this for every box that touches any dual-colspan cat_bar/title_bar... (index.css)
* Gave more padding to the hosted avatar selector. Seriously, were they asleep or something when they designed this? (index.css)
* Improved overall design. I'm actually starting to like it... I said started. Got rid of min-height in header (a leftover from the earlier frame). (index.css)
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 07:53 PM
Quote from Nao/Gilles on September 23rd, 2010, 02:35 PM
* Moved menu/sidebar toggle to the left... I say it's a matter of logic. Now if you'll stop bothering me, I'm busy writing this changelog... (index.css)
Well, I was busy a lot... So much that I forgot that I'd put it back to the right of the screen after I noticed it didn't play well with most browsers :P
Will have to fix this at some point...
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 11:35 PM
rev 137
! Fixed a good part of the RTL issues. Missing button strips, have yet to check more specific areas. (index.css, rtl.css)
! Fixed submenu positions in RTL mode. (script.js)
* Moved extra stylesheets to the top of the header, too. (index.template.php)
Title: Re: New revs
Post by: Nao on September 24th, 2010, 11:43 AM
rev 138
! Fixed capacity bar in PM area. (index.css)
! Added an overflow hack to cat_bar/title_bar to avoid any annoying float glitches in the future. I'd rather not use it, though. (index.css)
* Renamed 'MSN Messenger' to 'Live Messenger' in the language files. (Internally, it's still the same old horrible MSN Messenger.) (index.english.php, Profile.english.php)

Re: the overflow hack, this is a simple one I've been advocating to the SMF team and they always say "it doesn't work everywhere" (even though it does...) and they wouldn't use it (even if they use it in their own title_bar/cat_bar definition, albeit not in the best way.) The most logical way to avoid float glitches is really to avoid having ONLY floated elements inside a div... But in some cases it's hard to find the right balance. For instance, in the PM box, I tried deleting one of the capacity bar floats, and it didn't look good. So I came back to an all-float thingy, and added a &nbsp; (!!) at the end, and guess what, it worked... Uh. Well, it's still a hack, and I don't know if it's nice. Ideally, I would check all of the floated areas in the source code and fix them all manually.
Then again, maybe the overflow hack is best.

What do you think?
Title: Re: New revs
Post by: Nao on September 24th, 2010, 12:09 PM
rev 139
! Damn IE6's Javascript engine! (Class-Editor.php)
! Fixed Javascript error when viewing a post with no reply permission. (Display.template.php)

(Please don't forget to discuss the post above, though :P In another topic if you'd like...)
Title: Re: New revs
Post by: Arantor on September 24th, 2010, 12:17 PM
OK, I'm going to keep this one short and sweet.

Part of the layout issues SMF has is because of tag soup - so many floated things, so many divs and so on, that you so much as breathe on some bits and it falls apart on you.

There isn't really a best solution as a result - only a collection of least-worst alternatives, and none of them are particularly compelling. What you've got there is probably the least worst of the least worst solutions, without doing something drastic like ripping it all out and using tables everywhere.
Title: Re: New revs
Post by: Nao on September 24th, 2010, 05:07 PM
I don't know. I don't like having to make so many compromises... Here's another one:

rev 140
! A mystic fix for IE's overflow issues in topic pages... .wrc { width: 100% }. Take that! (ie6.css)
* Replaced bars.png with yet another gradient in my arsenal, grad40.png -- this should allow themers to change cat_bar and title_bg background colors on a whim. (index.css)
- Removed theme graphics that were no longer used... :) (backdrop.png, bars.png, frame_repeat.png, main_block.png, menu.png)

I'm not happy with the new cat_bar/title_bar color. And believe me I spent my entire afternoon setting it up. I want to have only one gradient file for both bars. In the end I'll probably change the colors anyway, but I want to have a 'Curve' CSS variant and would like it to be as vibrant as the original. Feel free to change the gradient if you can come up with anything better.
Title: Re: New revs
Post by: Nao on September 24th, 2010, 07:43 PM
Feeling a bit down... Not even css work can help here.

rev 141
* Changed menu hover color. If you can spot a difference, you're holy. (index.css)
* Reworked quotes, so that they don't look half as ugly. (index.css)
* Added a subtle border around cat_bar and title_bar, to make them a bit livelier. (index.css)
* Modified the admin/profile sidebar, because it's one of the ugliest Curve designs ever. Really. I hate cat_bar, but putting them as separators between plain white backgrounds is evil. (index.css, GenericMenu.template.php)
! Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)
Title: Re: New revs
Post by: Arantor on September 24th, 2010, 07:52 PM
Quote
Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)
Awesome, thank you :)
Quote
Changed menu hover color. If you can spot a difference, you're holy.
Do you see the light?!

Jesus H. Christ, I see the light! The band, Elwood, the band!

(Actually no, I haven't looked yet, but if you're saying that, odds are I wouldn't be able to tell the difference)
Title: Re: New revs
Post by: Nao on September 24th, 2010, 08:30 PM
rev 142
- Deleted the quotefast compatibility code for IE5. (Load.php, Post.php, Post.english.php, Post.template.php, topic.js)
! quotefast was called in a couple of places with a never used 'pb' var (it's an actual SMF bug, BTW, when used along with the 'xml' var.) (Post.template.php, topic.js)
* previewPost() should always assume that Ajax is available. (Post.template.php)

So, you're into my last modified fix? I thought you weren't :P Trying to cheer me up I'm sure :lol:
Oh, that BB scene was priceless. I never cared to watch the movie until a couple of months ago. What a treat!
Title: Re: New revs
Post by: Arantor on September 24th, 2010, 11:36 PM
Quote
So, you're into my last modified fix? I thought you weren't
I don't recall ever discussing it but the idea makes a lot of sense :)
Quote
Oh, that BB scene was priceless.
The whole film's pretty good. Note the cameo from Steven Spielburg (himself) as the tax assessor guy right at the end.
Title: Re: New revs
Post by: Nao on September 24th, 2010, 11:59 PM
http://www.simplemachines.org/community/index.php?topic=393528.0

Yeah I didn't notice Spielberg in the first place (no beard, IIRC!), but after I saw the trivia on imdb.com, I went back to the movie and was stunned. Eheh.
Title: Re: New revs
Post by: Nao on September 25th, 2010, 12:45 PM
rev 143
+ Added support for rounded corners for IE 6, 7 and 8, through ie-css3.htc (the only solution that worked for me), and only for wrc and roundframe classes (to save on performance). (ie6.css, ie7.css, ie8.css, ie-css3.htc, index.template.php)
! Forgot to add grad40.png gradient file. Really?
- Deleted roadmap.txt and todo.txt files (early SMF1 stuff.)
* Spacinazi. (GenericMenu.template.php, Packages.template.php)
Title: Re: New revs
Post by: Nao on September 25th, 2010, 07:46 PM
rev 144
* Renamed ie-css3.htc to css3.htc, fixed a couple of crashers in the code[1], and deleted all code related to box-shadow and text-shadow, as we won't be using it. (css3.htc)
* Found a better fix for wrc class not behaving correctly: it simply needed to have layout. Uh. Replaced width: 100% with zoom: 1, so it can be applied to all of its variations. (ie6.css)
+ Added a PNG fix script for IE6 emulation of transparent PNGs and correct background repeat. Believe me, it's a miracle that this thing works. (pngfix.js, index.template.php)
- Deleted ie8.css because it's only two lines, and added them to the index template.
* Moved body styling to a new wrapper, so that the body background can be properly redrawn in IE6. (index.template.php, index.css)
 1. First time in my life I'm fixing a .htc file... Fortunately it's just more JS :p
Title: Re: New revs
Post by: Nao on September 25th, 2010, 08:08 PM
'kay, what's with the dozens of topics updated all of a sudden? :^^;:

rev 145
- Deleted upgrade_1-0.sql and upgrade_1-1.sql, as we're not going to support upgrading from SMF 1.x anyway. (upgrade.php)
- Deleted ability to upgrade from YaBBSE. Did you know it was still in there?! (upgrade.php, Install.english.php)
- Deleted one of the smiley sets, because I have a problem with its name right now. :P
! Fixed a misplaced menu in the admin area in RTL mode. Although it might break sidebars... We'll see about that later. (rtl.css)
Title: Re: New revs
Post by: MultiformeIngegno on September 25th, 2010, 08:41 PM
Quote from Nao/Gilles on September 25th, 2010, 07:46 PM
+ Added a PNG fix script for IE6 emulation of transparent PNGs and correct background repeat. Believe me, it's a miracle that this thing works. (pngfix.js, index.template.php)
Doesn't this affect performances? :blush:
Title: Re: New revs
Post by: Nao on September 25th, 2010, 08:44 PM
Nope... That's why I said it was a miracle.
Title: Re: New revs
Post by: MultiformeIngegno on September 25th, 2010, 08:47 PM
Quote from Nao/Gilles on September 25th, 2010, 08:44 PM
Nope... That's why I said it was a miracle.
Great! :)
Title: Re: New revs
Post by: Nao on September 25th, 2010, 09:36 PM
rev 146
* Put submenu entries on the same line as their LI containers, to make menus a little bit less overwhelming when viewing the HTML source. (GenericMenu.template.php, index.template.php)
+ Added index.php protection to xkcd avatar folder.
* Updated to SMF rev 10141.
  * Minor typos and glitches
  ! The check on package server URL for http:// prefix failed.
  ! Incorrect parameter given for checkImageContents() on avatar uploads.
  ! Members with moderate_forum permission can no longer access Manage Posts admin area.
  * All new replies added via JavaScript were marked as ignored.
  * Fixed secret question page, and overflow error in admin menus.
  ! Tables should be created with SMF's charset and collation
  ! Installing as UTF8 should make all tables UTF8 <-- that's Pete's fix :)
Title: Re: New revs
Post by: Arantor on September 26th, 2010, 06:03 PM
Revision: 147
Author: arantor
Date: 05:03:01, 26 September 2010
Message:
+ First part of the naughty bot prevention code (plenty more to come though)
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php


This adds the whitelisting stuff. Note the use of a constant; this is for use later throughout in a way that can't be tampered with.
Posted: September 26th, 2010, 06:04 AM

Revision: 148
Author: arantor
Date: 14:04:47, 26 September 2010
Message:
! Fix user menu inability to relate to message id (use %msg% in the URL for menu items) (Display.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/scripts/topic.js

Posted: September 26th, 2010, 03:05 PM

Revision: 149
Author: arantor
Date: 15:00:07, 26 September 2010
Message:
! Remove 'send email' from user menu, added 'report to moderator' (Display.php)
- Removed unnecessary passing of current topic page into the send-report code, it wasn't being used for anything (Display.php, Display.template.php, SendTopic.php, SendTopic.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/SendTopic.template.php

Posted: September 26th, 2010, 04:00 PM

Revision: 150
Author: arantor
Date: 16:32:57, 26 September 2010
Message:
! Removed topic class icon column from message index, unread/replies page (MessageIndex.template.php, Recent.template.php)
! Added icon to the subject area (MessageIndex.template.php, Recent.template.php, index.css, 4 new images)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/icons/quick_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_my.gif

Just a few notes.

1. icon1 class has not been removed. I don't *think* it's in use anywhere else.
2. Had to add 4 new images since the lock/stick/both icon in the subject column is a background image. Still, we can if we choose, proceed to ditch some of the images in the topic folder now.
3. I haven't touched the message index footer yet, not sure what to do with that exactly.
4. Topic class is currently still being determined both in the message index and in the topic itself (it's the icon in the top left corner of the topic). Since we're not using it in the message index, we can remove that (I'll do that later if you want, I was just concerned about getting it implemented as-is), but not sure about removing it from the topic yet. Makes little odds to me, I don't even notice it most (any?) of the time.
Posted: September 26th, 2010, 05:36 PM

Revision: 151
Author: arantor
Date: 17:03:07, 26 September 2010
Message:
+ Added new permissions for editing website and signature (independently of any other profile settings) (ManagePermissions.english.php, ManagePermissions.php)
+ Added enforcement of permissions (Profile-Modify.php)
+ Added permissions to edit own website/own signature to regular members and global moderators by default (install_2-0.sql)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install_2-0.sql
Title: Re: New revs
Post by: Arantor on September 26th, 2010, 07:51 PM
Revision: 152
Author: arantor
Date: 18:49:29, 26 September 2010
Message:
! Rearranging the order of Core Features - a feature whose title begins with A should be before something that begins with C. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php


...even if it was originally called 'Custom Profile Fields'... it's now called Advanced Profile Fields. And everything else is in... oh damn. I meant to move search engines too.
Posted: September 26th, 2010, 07:51 PM

Revision: 153
Author: arantor
Date: 18:51:41, 26 September 2010
Message:
! Also move search engines to be in the right alphabetic place (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Title: Re: New revs
Post by: Nao on September 26th, 2010, 08:27 PM
As always, my revs aren't nearly as exciting as Pete's ;) But they must be done, too. And I'm here to do them, whether it rains or snows.

rev 154
+ Introduced #navi to contain the main menu and linktree areas and avoid breaking the menu under IE6 (don't ask.) (index.css, ie6.css, index.template.php)
- Deleted grad350.png, replacing header background with grad250.png because it's been reduced in height anyway. Doesn't look as good when folding it, but the header fold feature will probably be removed in the future anyway.
* Harmonized div.frame paddings, as they're confusing in their current state, and the trick was only useful in a vanilla Curve. (index.css)
! ie8.css was still being called by error. (index.template.php)
* Put linktree items on the same line as their LI parents, just like menu items. (index.template.php)
* Spacinazi. (QueryString.php, Subs.php)
* Saving a few bytes off JS files. (pngfix.js, css3.htc)
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 01:30 AM
Revision: 155
Author: arantor
Date: 23:00:41, 26 September 2010
Message:
! Fixed up outstanding issue with smiley set (install_2-0.sql, Install.english.php)
- Removed remaining topic icon fluff (I think I got it all)
 - Class determination function (Subs.php)
 - Display in the topic view (Display.php, Display.template.php)
 - Fix for alignment of author/title without icon (index.css)
 - Cleaning up topic class in message index (MessageIndex.php, MessageIndex.template.php)
 - And unread/replies (Recent.php, Recent.template.php)
 - And search (Search.php)
 - And the admin panel (ManagePosts.php)
 - And all language strings (FixLanguage.php, Admin.english.php, Help.english.php, index.english.php)
 - And pruning the images that are no longer used (lots, there's still a couple actually used, but 45 gone bye-bye)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/FixLanguage.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Deleted : /trunk/Themes/default/images/topic/hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_sticky.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql


Yeah, this was an exciting commit ;)
Posted: September 27th, 2010, 12:01 AM

Revision: 156
Author: arantor
Date: 23:06:56, 26 September 2010
Message:
! Converted outstanding .icon1 and .icon2 to .icon (index.css, MessageIndex.template.php, Recent.template.php)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css

Posted: September 27th, 2010, 12:07 AM

Revision: 157
Author: arantor
Date: 00:27:57, 27 September 2010
Message:
! Misc typo fixes (smfinfo.php, Subs.php)
+ Error counter log (index.php, Errors.php, ManageErrors.php, Subs.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php
Modified : /trunk/other/tools/smfinfo.php


In case it's not clear what's going on (and it is a little convoluted, if I'm honest) - the logic behind it is that if an error occurs during execution, it adds to a counter, then if there were errors during runtime, save that in $modSettings at the end of runtime. It's far lighter to do that than it is to query it (or query then cache it) every page load, and really if we're honest, the idea is to encourage admins to resolve errors sooner rather than later.
Title: Re: New revs
Post by: Nao on September 27th, 2010, 09:48 AM
rev 158
- Deleted remaining hotTopic vars from install script. (install_2-0.sql)
! Fixed padding issues in main menu. (index.css, ie6.css)

Not much, but I'm quite happy with the main menu now. ;)
Title: Re: New revs
Post by: Nao on September 27th, 2010, 11:32 AM
rev 159
- Deleted some theme compatibility leftovers. Again: Wedge is not compatible with SMF 1.x themes. Use SMF 2.x if you need compatibility. (detailed-version.js, Load.php, Compat.template.php)
- Deleted $settings['separate_sticky_lock'] from index template, as the feature was deleted from Wedge and if it's not supported in the default theme, external themes should deal with it by themselves. (index.template.php)
- Deleted $settings['doctype'], which isn't used in Curve. I don't think it should cause any incompatibilities with future HTML5 themes... (Or use XHTML5, heck.) (index.template.php)
- Deleted leftovers from older themes in language files. (index.english.php)
* Various subtle CSS improvements. (index.css, MessageIndex.template.php, Recent.template.php)
* Spacinazi. (ManageErrors.php, Subs.php, MessageIndex.template.php, Recent.template.php)

(May require a bit of double-checking... I *hope* my logic for separate_sticky_lock is good, because otherwise it means I don't have a damn idea of how themes are supposed to work :P
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 10:16 PM
Revision: 160
Author: arantor
Date: 19:30:42, 27 September 2010
Message:
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
----
Modified : /trunk/Themes/default/scripts/editor.js


I'll take a look at revs 158 and 159 shortly, I just wanted to fix that outstanding issue because it was bugging me. Looking at the code in replacetext from whence I borrowed, IE 6 (and 7?) may not support the change, but IE 8 and Chrome do, and since it's labelled in replacetext as 'Mozilla', I'm assuming FF does, though I haven't tested.
Posted: September 27th, 2010, 08:32 PM

Revision: 161
Author: arantor
Date: 20:51:55, 27 September 2010
Message:
+ Code documentation (ManageRegistration.php)
----
Modified : /trunk/Sources/ManageRegistration.php

Posted: September 27th, 2010, 09:52 PM

Revision: 162
Author: arantor
Date: 21:15:53, 27 September 2010
Message:
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
----
Modified : /trunk/Sources/Themes.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on September 27th, 2010, 10:36 PM
Quote from Arantor on September 27th, 2010, 10:16 PM
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
I have a feeling of déjà-vu... Is it normal? I wanted to do this at some point... Did I suggest it? Did you? Or did someone on the SMF bug tracker, maybe? Nah, I don't think so, I remember once thinking about this while not in front of my PC... Was dying to try implementing that, but forgot afterwards...
Quote
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
Yay! I thought we hardly had anything left to strip at that point...... ;)
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 10:47 PM
You suggested it - http://tracker.wedge.org/?sa=ticket;ticket=41

It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
Quote
Yay! I thought we hardly had anything left to strip at that point......
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)
Title: Re: New revs
Post by: Nao on September 27th, 2010, 10:52 PM
Quote from Arantor on September 27th, 2010, 10:47 PM
You suggested it - http://tracker.wedge.org/?sa=ticket;ticket=41
Phew......!!! I really felt bad about that déjà-vu! :lol:
Quote
It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
IE8 is bitchy with the post editor. Recently Ante committed a fix suggested by whomever I don't remember, which basically replaced the min-width;max-width with a normal width, and added a very high number of cols to the textarea (a hack to make it work.)
Quote
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)
I like it when you do these things.

...

No, it's nothing sexual. For crying out loud.
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 10:56 PM
I saw that hack, I'm still not convinced it would actually work entirely as intended either.
Quote
For crying out loud.
Probably not the best line to say to a Meat Loaf fan...

Meat Loaf - For Crying Out Loud(http://www.youtube.com/watch?v=qHPetLms4ZU#)

"For crying out loud, you know I love you...."
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 03:20 AM
Revision: 163
Author: arantor
Date: 02:19:54, 28 September 2010
Message:
! Moved IP icon and made it tooltip of image (Display.template.php)
+ Made viewing own/any IP address a permission, and ensured it is managed in all the appropriate places (Display.php, ManageMembers.php, ManageMembers.template.php, ManagePermissions.php, ManagePermissions.english.php, Modlog.php, Profile-View.php, Who.php)
- Removed old help tooltip for admin IP viewing (Help.english.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:38 AM
rev 164
* Replaced apache_request_headers() emulation code with a shorter, faster version. (QueryString.php)
! Fixed validation error. (Search.template.php)

(The validation error is also in SMF2, AFAIK. Also, my fix is technically all right, but logically wrong. I'll rewrite it in the next commit, sorry.)
Posted: September 28th, 2010, 09:15 AM

BTW, nice catch on ManageMembers... Fixing the 'cols' into 'columns'. Another SMF2 stock bug...!
Posted: September 28th, 2010, 09:29 AM

$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Posted: September 28th, 2010, 09:36 AM

$txt['permissionname_view_ip_address'] = 'View IP addresses in the main forum';
(And a couple other occurrences)

'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Maybe 'front-end', 'outside the admin area' or something like that..?
Posted: September 28th, 2010, 09:38 AM

Is the view own IP permission set by default? I don't think it is?
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 09:41 AM
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Quote
'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Quote
Is the view own IP permission set by default? I don't think it is?
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:48 AM
Quote from Arantor on September 28th, 2010, 09:41 AM
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Quote
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Lazy ass :P
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
Quote
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)
Dunno what's best.

$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
Posted: September 28th, 2010, 09:45 AM

Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess :)
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 09:50 AM
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Quote
Lazy ass
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
The only original code I committed last night was moving the icon :P as well as spacing fixes. But yeah, the language strings could be improved.
Quote
Dunno what's best.
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Quote
$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
It could be moved to the modlog lang file?
Quote
Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess
Yes it is. Something I didn't remember in the original mod...
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:50 AM
rev 165
- Removed a YaBBSE leftover. (upgrade.php)
! New IP text was missing LI tags. (Display.template.php)
! Fixed quick moderation checkboxes logic. (Search.template.php, Recent.template.php)

Done with the proof-reading :)
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:54 AM
Quote from Arantor on September 28th, 2010, 09:50 AM
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Then I'll let you rephrase it :P
I'm just not comfortable enough with the English (NOT Scottish!) language.
Quote
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Well... That's a good idea. I'd go with it.
Quote
It could be moved to the modlog lang file?
Or that, yes. :)
Quote
[quoet]
Pwned! Didn't use insertQuoteFast :P
Quote
Yes it is. Something I didn't remember in the original mod...
You mean the original mod had the hole? ;)
(Ah yes, I just checked, the fix is in it, indeed. Good thing we're both checking the code, always a failsafe for when we're lazy :))

I should stop posting so many smileys...
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 10:17 AM
Quote
You mean the original mod had the hole
Sure did, and no-one ever called me out on it, either and the original mod was written back in December 2009...
Quote
Pwned! Didn't use insertQuoteFast
You can't use it to insert only parts of posts unless you modified it here...


I'll take care of the above momentarily.

:edit: Actually, I *did* take care of the permission checking for searching. Basically, the unset items are all to do with removing it from the list of things it knows about for searching/displaying within the manage area.
Posted: September 28th, 2010, 09:56 AM

Revision: 166
Author: arantor
Date: 09:16:59, 28 September 2010
Message:
! Ensure view-IP permissions are applied during install (install_2-0.sql)
! Add view-IP permissions to the internal templates (ManagePermissions.english.php)
& Move 'Logged' to Modlog (index.english.php, Modlog.english.php)
& Rephrase view-IP permission name and user help (ManagePermissions.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql
Title: Re: New revs
Post by: Nao on September 28th, 2010, 11:35 AM
Quote from Arantor on September 28th, 2010, 10:17 AM
Sure did, and no-one ever called me out on it, either and the original mod was written back in December 2009...
That's probably because we don't take code for granted, even our own.
Quote
You can't use it to insert only parts of posts unless you modified it here...
Ah yes, I had already merged it of course. Was faster to quote manually.
Quote
:edit: Actually, I *did* take care of the permission checking for searching. Basically, the unset items are all to do with removing it from the list of things it knows about for searching/displaying within the manage area.
Err, from what you're saying, your fix was already in your mod, then?
You've lost me here...
In my previous post, I mentioned how I'd found the fix in ManageMembers.php, with the unset().
Quote
! Ensure view-IP permissions are applied during install (install_2-0.sql)
So, in the end you're leaving the perms in, instead of using the ban perms?
Quote
& Rephrase view-IP permission name and user help (ManagePermissions.english.php, Help.english.php)
It still implies that can_view_ip_own doesn't exist, and that no one but the admin can have can_view_ip_any...
I guess it's a WIP for now :)
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 11:44 AM
Quote
That's probably because we don't take code for granted, even our own.
I try not to, because I try to be mindful of the consequences of changing things.
Quote
Err, from what you're saying, your fix was already in your mod, then?
You've lost me here...
I initially thought I missed it, then I edited to say I hadn't, because of the unset items - which were in the original mod too. I missed your edit, it seems.
Quote
So, in the end you're leaving the perms in, instead of using the ban perms?
Yes... I see I wasn't clear with what I meant. I set it up so that users who would have ban permissions, would also gain by default the view-all-IPs permission in the templates and in installation, since if you have the ability to ban it follows that you probably should have view all IPs too.

But I didn't want to make them tied together; I can think of cases where users might want to give out some but not the others.

There's a thought, actually... ban user does also use the IP in the ban dialogue. I don't think I hit that one.
Quote
It still implies that can_view_ip_own doesn't exist, and that no one but the admin can have can_view_ip_any...
I guess it's a WIP for now
Yeah, I think so. I've found being a programmer makes me very good at some things - breaking down tasks and so on, but lousy in others - trying to communicate a complex concept to non-technical users (like with the help string) will tend to break down.
Title: Re: New revs
Post by: Nao on September 28th, 2010, 01:33 PM
Quote from Arantor on September 28th, 2010, 11:44 AM
Quote
That's probably because we don't take code for granted, even our own.
I try not to, because I try to be mindful of the consequences of changing things.
You shouldn't worry about that too much. We're both capable programmers and we're both checking each other's code. Meaning that 90% of our errors are spotted by ourselves -- and the remaining 9% have a chance of being caught by the other. I'm leaving an extra 1% for future users to play with ;)
Quote
I initially thought I missed it, then I edited to say I hadn't, because of the unset items - which were in the original mod too. I missed your edit, it seems.
Yeah, we tend to edit too much :P
I also caught a message of yours on another topic, that you'd posted 2 minutes before me, and I didn't get the "Another message was posted" warning when sending it... I'm a bit surprised. Or maybe I just disregarded the message, I don't know. I'll have to answer it.
Quote
Yes... I see I wasn't clear with what I meant. I set it up so that users who would have ban permissions, would also gain by default the view-all-IPs permission in the templates and in installation, since if you have the ability to ban it follows that you probably should have view all IPs too.
Oh... Right. If it suits you then :)
I'm not sure exactly, but checking perms is a fast process, isn't it? I think that once perms are loaded for someone, they're cached.
Quote
There's a thought, actually... ban user does also use the IP in the ban dialogue. I don't think I hit that one.
Want me to look into all of the 'ip' occurrences in the code? (I think I might have better things to do today, though :P)
Quote
Yeah, I think so. I've found being a programmer makes me very good at some things - breaking down tasks and so on, but lousy in others - trying to communicate a complex concept to non-technical users (like with the help string) will tend to break down.
I'm not very good at that too. But I'm very good at bugging people :P Just make the text shorter and more vague! As if you were writing my résumé! :angel:
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 02:10 PM
Quote
I'm not sure exactly, but checking perms is a fast process, isn't it? I think that once perms are loaded for someone, they're cached.
It is, but it's not the fastest it could be (though the difference is basically a micro-optimisation) - $user_info['permissions'] becomes an array of strings of the permission names, matched via in_array. The faster way would be to array_flip it at some point during loading and do isset($user_info['permission'][$perm_name]), though note that if a board's id is specified, it's a DB query - and uncached IIRC. This is pretty infrequent however.

I'm quite happy to change it - it just seemed logical to tie it up into its own permission rather than tie it into something else; that way you don't give out permissions unnecessarily.
Quote
Want me to look into all of the 'ip' occurrences in the code?
Only if you get really bored.
Title: Re: New revs
Post by: Nao on September 29th, 2010, 10:14 AM
Yeah, array_flip() could be beneficial. And instead of isset(), we could use !empty(), so we could actually set perm values to something else than just on/off: numbers, for instance... Like in 'max number of PMs allowed in your box', things like that. I'm not a perm specialist, though.

rev 167
* Updated to SMF rev 10144:
 ! Fixed missing global $smcFunc in prepareIndexes function (SearchAPI-Custom.php)
 ! $smcFunc['db_list_indexes'] was broken for SQLite. (DbPackages-sqlite.php)
 - removed getOuterHTML(), outdated javascript function (script.js) [Bug 4284]

- removed an extra getOuterHTML declaration which was not even used anymore... (repair_settings.php)
- removed getInnerHTML and setInnerHTML declarations, to encourage modders to use the proper way (innerHTML property.) (script.js)
- rewrote a couple of files that were still using getOuterHTML... Dunno if these files will be of any use one day anyway. (latest-packages.js, latest-themes.js)
! IE6 wasn't showing the hover color on menu items that had no submenu. (ie6.css)
* Spacinazi. (ManagePaid.template.php)
Title: Re: New revs
Post by: Arantor on September 29th, 2010, 01:42 PM
Quote
Yeah, array_flip() could be beneficial. And instead of isset(), we could use !empty(), so we could actually set perm values to something else than just on/off: numbers, for instance... Like in 'max number of PMs allowed in your box', things like that. I'm not a perm specialist, though.
I actually did something closer to this in SimpleDesk actually. Need to look at exactly what I did because I think I just had it store a value of 1, 0 or -1 depending on allow, disallow, deny (though they were constants instead so the code was clear)
Title: Re: New revs
Post by: Nao on September 29th, 2010, 02:23 PM
Ahh...... You and your constants :D

I suspect the permission system overhaul[1] will be one of our biggest (and longest) subprojects.
 1. I loved how you mentioned an "overall overhaul" on arantor.org, ahah.
Title: Re: New revs
Post by: Arantor on September 29th, 2010, 02:31 PM
That's the thing... for me, seeing if ($some_array['value'] == ROLEPERM_ALLOW) is way more readable than if ($some_array['value'] == 1) - what does that 1 mean?

I also talked about magicalness; I have an idea for an easter egg out of it :D

Yeah, it will be one of the larger changes, but probably not the largest; some of the stuff I've suggested for group management is probably a touch larger.
Title: Re: New revs
Post by: Nao on September 29th, 2010, 03:23 PM
Yeah it's more readable, I'm just saying -- you and your constants :P
It's not exactly of common use in SMF. Since I learned 90% of my PHP skills through the SMF codebase, I have to admit it's really not something I'd do myself. Not because it's no good -- only because I'm not used to that.
I'm only asking to be educated :)

rev 168 -- aka the IE6 mess fixer!
! Fixed header being too tall in IE6. (ie6.css)
! Fixed quick task list alignment in admin area under IE6. (ie6.css)
! Fixed contextual tabs hover state in admin area under IE6. (ie6.css)
! Fixed invisible gradients in cat_bar th declarations. (index.css)
* Replaced ie-css3 library with PIE, which is way bigger but also works perfectly in IE6/7/8. (PIE.htc, index.template.php)
* Reverted removal of get/setInnerHTML(), as they're currently being used in SMF's news files. (script.js)
Posted: September 29th, 2010, 03:19 PM

Re: IPs -- it's cool to have the icon in the left side now. Really... Thanks for the idea. Help text for IP: I didn't test, but should I assume that it only shows up if user HAS permission to see their own IP? If yes, then it's correctly phrased. Otherwise, it needs fixing.
Title: Re: New revs
Post by: Arantor on September 29th, 2010, 03:53 PM
Quote
Help text for IP: I didn't test, but should I assume that it only shows up if user HAS permission to see their own IP? If yes, then it's correctly phrased. Otherwise, it needs fixing.
Correct. If they can't see it, nothing shows at all.
Posted: September 29th, 2010, 03:27 PM

Revision: 169
Author: arantor
Date: 14:52:32, 29 September 2010
Message:
! Speculative fix for specifying PayPal language from subscriptions to checkout. Not overly happy about binding the list of known 'languages' into the core, but don't really see a better way at this time... short of including the language code into $txt in index.english.php (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Subscriptions-PayPal.php


Yeah, it occurred to me as I was writing up the note that we could include the PayPal language code in the language file itself but didn't want to set that precedent (since if we include other payment gateways in the future, something similar would be required)
Title: Re: New revs
Post by: Nao on September 30th, 2010, 11:13 PM
rev 170
+ Implemented the preceding space trick for smileys into IE. I think I love hating that crap they call a browser. (editor.js)

Phew! Let it be said that no day shall pass without at least ONE commit 8-)
Title: Re: New revs
Post by: Nao on October 1st, 2010, 09:58 AM
rev 171
* Renamed #footer_section to #footer, to match the earlier #header. (install.php, readme_*.html, ssi_examples.php, upgrade.php, index.template.php, index.css, ie6.css)
* Provided fallback border colors for browsers that don't support rgba() in CSS. (index.css)
* Rewrote buttonlist class to get better performance in IE and less clutter. Non-semantic spans are boring anyway. (index.css, index.template.php)
* Recompiled PIE library to shave 10KB off it. IE6 doesn't like it. Screw you, IE. Removed wrc and roundframe emulation for it. (PIE.htc)
! Fixed validation error in menus. (GenericMenu.template.php)
! IE9 doesn't need emulation code. For once... (index.template.php)

I'm currently considering dropping border-radius entirely for IE6... I realize I spent TWO fucking weeks on that piece of shit. Now I'm getting "Operation aborted" errors on PIE with it. Only happens SOME OF THE TIME. And of course it can't be debugged... That's the joy of HTC files. Maybe I should find a way to include the file differently (i.e. through JS, not HTC.)
Title: Re: New revs
Post by: MultiformeIngegno on October 1st, 2010, 10:07 AM
:(

I'd say: don't give a shit about IE6! just... I'm really sorry you spent 2 weeks on this for nothing!
Title: Re: New revs
Post by: Nao on October 1st, 2010, 10:34 AM
Well, these 2 weeks were also spent on IE7 and IE8, which are way better and actually usable... (Except that IE7 also has Operation Aborted issues, but not with PIE, oddly.)
Title: Re: New revs
Post by: Nao on October 1st, 2010, 10:59 AM
Now this is the most annoying thing ever...
I have a file, PIE_uncompressed.htc, which works fine in IE6. I've tried countless times to generate an error, it just doesn't.
NOW, I'll just take that file and COPY it, and rename the new version (byte-for-byte identical!) to PIE_uncompressed2.htc...
I'll reload IE6, and voilà, I get my Operation Aborted errors.

Now, before you ask -- yes, I empty the cache and even restart IETester every time! lol moment...

:edit: I just tried with an earlier copy of IE6 and it's throwing errors on the 'clean' file as well... Uh.
Title: Re: New revs
Post by: Nao on October 1st, 2010, 11:50 AM
rev 172
! Hopefully fixed the Operation Aborted error in IE6 and re-added support for rounded borders in wrc and roundframe... It's still very slow on IE6, though! (PIE.htc, index.template.php)

As discussed here(http://css3pie.com/forum/viewtopic.php?f=3&t=174&p=702#p702).
Title: Re: New revs
Post by: Nao on October 1st, 2010, 10:29 PM
rev 173
- After single-handedly managing to fix all border-radius bugs in IE6, removing support for it because it's so freakin' slow. (index.template.php)
* Changing topic area's quick button font from Arial to uppercase Trebuchet MS (a-la Noisen) (index.css)
* Changing header bar font from Georgia to Segoe UI, using a dark-on-light color scheme in cat_bar/catbg, and adjusted plenty of styles accordingly. Of course, I'm not happy with the results... That wouldn't be fun, would it? (index.css)

As not discussed anywhere. Pete, could you look into the new styles? I spent a couple of hours on this and I'm not happy... This is the best I could come up with, now I want to go eat... My... It's nearly time to go to bed...
Title: Re: New revs
Post by: Arantor on October 2nd, 2010, 12:52 AM
I'll look at the new style when I'm finished with the attachments UI stuff I've been meaning to do (this ticket(http://tracker.wedge.org/?sa=ticket;ticket=53))
Posted: October 1st, 2010, 10:40 PM

Revision: 174
Author: arantor
Date: 23:47:48, 01 October 2010
Message:
+ Updated attachment UI. Sort of broken in IE right now though :( (Post.php, Post.template.php, Post.english.php, editor.js)
- Removed cleanFileInput function as no longer necessary (script.js)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/script.js


When I say it's broken in IE, the error condition isn't right. The <input type="file"> needs to be cleared in the event of an error, which is fine. Now, a type=file is read-only for security reasons but everyone except IE accepts an empty string to clear it.

IE however makes it fully read-only (I have no idea why, that seems pretty stupid to me, when just accepting empty string isn't a security risk), which leaves the only alternative to being removing and replacing the element. This requires adding in spans or divs around the file element that weren't there before (and managing all the sleight of hand required to make it work given all the other stuff going on), and additionally all of the replace methods end up dropping the event handling. Yay, good times.

It can be done, I just don't have the inclination right now to do so.


As for the new style; hmm. The not-quite-black seems too pale, so it's not as striking against the background as perhaps it might be. Looks good otherwise though :)
Title: Re: New revs
Post by: Nao on October 2nd, 2010, 02:25 AM
Nice stuff. Maybe the Remove button could be placed to the left, so that all buttons are aligned? Also, put some padding below the file selector? Something like 4 to 6px would be good...

I thought you were planning to use WebForms (or whatver it's called in HTML5). If it's behaving like Opera's implementation, it allows you to get a lot of information on a file before uploading it... Things like filesize!
I actually planned to use that in Aeva Media, but at the time, Opera was the only browser that supported WebForms, so I gave up. Now it could be possible here.

We could also use YUI Upload to select multiple files from the file selector :P
Quote from Arantor on October 2nd, 2010, 12:52 AM
IE however makes it fully read-only (I have no idea why, that seems pretty stupid to me, when just accepting empty string isn't a security risk), which leaves the only alternative to being removing and replacing the element.
Hmm...
Quote
This requires adding in spans or divs around the file element that weren't there before (and managing all the sleight of hand required to make it work given all the other stuff going on), and additionally all of the replace methods end up dropping the event handling. Yay, good times.
Well.......... I would gladly help you, but I don't know if you heard, I'm just back from a 2-week vacation in Hell...... :evil:
Quote
As for the new style; hmm. The not-quite-black seems too pale, so it's not as striking against the background as perhaps it might be. Looks good otherwise though :)
Thanks. It's really HORRIBLE trying to get the lowest common denominator, whatever it's called in English.
I always feel inspired when I hack into my own websites... But Wedge really is something else.

One of the things that annoy me the most is the 50KB css file... Considering that half of that is for special styles from specific pages, it would be nice to have an index.css and an index_extra.css, and then at the time of caching index.css, automatically concatenate both... Would allow me to focus on the main stylesheet file.



rev 175
* A couple more improvements to the cat_bar styling. (index.css)
* Spacinazi. (Post.template.php, captcha.js, Stats.template.php)

(I changed the catbar color to something... greener. Tell me if you think it's better?)
Title: Re: New revs
Post by: Arantor on October 2nd, 2010, 04:14 AM
Well, AFAIK, doesn't YUI make use of things like Flash? Sure it's doable but I'd hate to make Flash an inherent dependency even for something just like uploading files.

I also wasn't aware that HTML5 contained anything that let you have access to anything useful like the file size, especially since the major browsers can't even agree what the value of a <input type="file"> should be - some browsers only return the basename of the file, some make the full path accessible.
Quote
Well.......... I would gladly help you, but I don't know if you heard, I'm just back from a 2-week vacation in Hell...... :evil:
:P I just wanted to get it committed, didn't feel up to making it work properly seeing how I cut the number of changes vs the SimpleDesk implementation in half and only made it basically a UI change as opposed to UI+logic change that it so nearly was.
Quote
Thanks. It's really HORRIBLE trying to get the lowest common denominator, whatever it's called in English.
I always feel inspired when I hack into my own websites... But Wedge really is something else.
It's the right term; trying to find that common theme for everyone is tricky.
Title: Re: New revs
Post by: Nao on October 2nd, 2010, 07:12 PM
rev 176
* More tweaks to the cat_bar style... I'm starting to like it. (index.css)
* Replaced the original Wedge logo with new mockup. SMF for real -- SMF for real men. Ah ah. And women, too. And dogs. And cats. And other minorities. (wedgelogo.png)

Just so that I don't spend a day without committing...  :niark:
Title: Re: New revs
Post by: Arantor on October 3rd, 2010, 06:30 PM
Revision: 177
Author: arantor
Date: 14:35:55, 03 October 2010
Message:
+ Provide option for redirect boards opening in new window/tab
 + New column, redirect_newtab added to boards table (install_2-0.sql)
 + New admin option for setting it (ManageBoards.english.php, ManageBoards.php, ManageBoards.template.php, Subs-BoardIndex.php, Subs-Boards.php)
 + Displaying changes (BoardIndex.template.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install_2-0.sql

Posted: October 3rd, 2010, 03:37 PM

Revision: 178
Author: arantor
Date: 14:53:21, 03 October 2010
Message:
! Render the time in smaller font on WAP2 (cannot apply to iMode or WAP as neither supports variable height fonts) (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php

Posted: October 3rd, 2010, 03:53 PM

Revision: 179
Author: arantor
Date: 17:30:12, 03 October 2010
Message:
! Convert opendir/readdir/closedir to scandir as appropriate (upgrade.php, ManageAttachments.php, ManagePaid.php, ManageSearch.php, PackageGet.php, Packages.php, Post.php, Subs-Package.php, Subs-Post.php, Subs.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on October 3rd, 2010, 07:48 PM
You did the scandir stuff? I had assigned it to myself and thought of doing it this month ;)
Well, I guess it'll give me more time for other tasks, eheh.
Title: Re: New revs
Post by: Arantor on October 3rd, 2010, 07:51 PM
Yeah, I did. Basically I knew my time would be fragmented today and so doing anything big probably wasn't worth the effort, so I figured I'd look at smaller stuff, and besides, it's more green on the tracker (and I like green) :)
Title: Re: New revs
Post by: Nao on October 3rd, 2010, 08:01 PM
Yeah that's exactly why I was planning to do it as well... My 'big project' is the theme redesign, and all of the philosophy changes that come with it (and you know it's a huge weight on my shoulders. I'm really no designer and I have trouble thinking ahead. Hence why I'm very happy to have Bloc here now :))
Although I wouldn't have called scandir a "smaller" thing, if only because it can't be replaced in an automated manner. (Deleting <div class="content"> won't be easy either. 750+ occurrences, none of them can be automated unless I give up the idea of having proper indentation... I still want to do it at some point, though.)
Title: Re: New revs
Post by: Arantor on October 3rd, 2010, 09:37 PM
scandir was a smaller thing, since as you remarked yourself it was only used in a couple of dozen places; a quick search on opendir showed it wouldn't be a big thing to change - and as you can see from the changelog, it wasn't.


Revision: 180
Author: arantor
Date: 20:35:56, 03 October 2010
Message:
- Remove WAP, imode support (index.php, BoardIndex.php, Display.php, ManageBans.php, PersonalMessage.php, Profile.php, Subs-Auth.php, Subs.php, Wireless.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on October 6th, 2010, 02:41 PM
rev 181
* Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
* Spacinazi and typo killing. (upgrade.php, Class-Editor.php, Profile-Actions.php, Subs.php, GenericList.template.php, Post.template.php, script.js)
+ nobbc tag should be allowed in parse_bbc_inline. (Subs.php)
! A regex in preparsecode() didn't require a return value. Saves about a micro-millisecond of CPU time per day. Think of the trees. (Class-Editor.php)
- Replaced useless javascript:void(0) calls that could easily be replaced with a # as long as the associated onclick() event returns false. (ssi_examples.php, repair_settings.php, smfinfo.php, Subs.php, templates: Help, ManageMembergroups, ManageNews, ManagePermissions, Packages, PersonalMessage, Profile, Search, Themes)
* I believe all of those typeof=undefined and null tests in Javascript are useless and can simply be replaced with a if (var) test as long as var can't take a value of false. (script.js)

----> Pete, you may safely skip the changes in all files (they're minor and double-checked already), but I'd like you to have a look at my changes in script.js... I would hate having added a logic bug. I've tested on my side with Opera and it works. Maybe older IEs will choke on these though...

PS: nothing was committed in the last 3 days...? Wow. I think it's our record. We're going the SMF way ;)
Title: Re: New revs
Post by: Arantor on October 6th, 2010, 08:28 PM
Quote
Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
Are you planning to change all the other things that are similarly bools in nature? There is not a single bool amongst SMF's tables, never has been, and in the case of older MySQL versions it is neither smaller, nor faster to do so.

Will take a look at script.js shortly.
Title: Re: New revs
Post by: Nao on October 6th, 2010, 08:40 PM
Quote from Arantor on October 6th, 2010, 08:28 PM
Quote
Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
Are you planning to change all the other things that are similarly bools in nature?
I don't know... Should I?
Depends on whatever I find out, I guess...
Quote
Will take a look at script.js shortly.
Thanksalot.
Title: Re: New revs
Post by: Arantor on October 6th, 2010, 09:47 PM
There's a lot of fields that fall into the same category of being tinyint when they logically should be bool.

Trouble is, even on more modern MySQL I'm not sure it's any faster and in some cases it will be slower as it messes round fixing up part bytes (especially in fields with variable width columns that implicitly force everything else as bytes).

There's also a lot of fields whose use is never stated anywhere... yay for undocumented schemas.
Posted: October 6th, 2010, 08:45 PM

OK, took a look at script.js.

All the stuff with == null vs ! should work, and seems to.

There's only two things I'm wary of.

Code: [Select]
doForm.passwrd.value = is_ff != -1 ? '' : doForm.passwrd.value = doForm.passwrd.value.replace(/./g, '*');

Surely that should be:
Code: [Select]
doForm.passwrd.value = is_ff != -1 ? '' : doForm.passwrd.value.replace(/./g, '*');


And also,
Code: [Select]
bInit = typeof(bInit) == 'undefined' ? false : true;

vs
Code: [Select]
bInit = bInit ? true : false;

Seems a bit redundant logically, not to mention inaccurate.

I'd suggest:
Code: [Select]
bInit = typeof(bInit) != 'undefined';
and just be done with it.
Posted: October 6th, 2010, 09:37 PM

Revision: 182
Author: arantor
Date: 20:46:32, 06 October 2010
Message:
! Missed a closedir that should have been removed before (Subs-Post.php)
----
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on October 7th, 2010, 12:14 AM
rev 183
! Fixed wrong cat_bar color in IE6. (ie6.css)
* Optimized wedgelogo.png to save a kilobyte in size.
! Oops moment, thanks Pete. (script.js)

Really sorry that I screwed the doForm line. Of course it was simply a bad manipulation on my part.
As for bInit, I don't see how it would be inaccurate?
I turned it into "bInit = !!bInit", which is even shorter and less readable. :P
's that okay?

Re: BOOL sizes, I'd say once again, feel free to reinitalize the field to TINYINT(4)!
Title: Re: New revs
Post by: Nao on October 8th, 2010, 12:16 AM
rev 184
+ Added on_timeformat function (and somehow documented it), for use in quotes. (Subs.php)
- Deleted FixLanguage.php, as well as template and language upgrade systems, as they should never be needed in Wedge. (upgrade.php, detailed-version.js)
- Deleted login_to_post language string (ghost entry.) (Errors.english.php)
! Spacinazi. (Admin.english.php, Subs.php)
Title: Re: New revs
Post by: Arantor on October 8th, 2010, 01:29 AM
Revision: 185
Author: arantor
Date: 00:28:20, 08 October 2010
Message:
! Make $context['sub_template'] accept an array as a list of subtemplates to call (Subs.php)
! Separate the board index templates as they should have been originally (BoardIndex.php, BoardIndex.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Title: Re: New revs
Post by: Nao on October 8th, 2010, 09:30 AM
Ah, just noticed your new rev... Will check in a minute.

rev 186
+ Added support for icons in main menu's top level. Can be improved. Provided a sample set of sprited icons. (Subs.php, index.css, index.template.php, sprite.png)
* Changed menu highlighting color to something more sober. (index.css)
+ Added language string for 'Simple search'... Just in case? (index.english.php)

--> I don't know if it's good to have icons in the main menu. I mean... Wedge's implementation has dropdown arrows next to the titles. Now there's an icon, then the title, then the arrow. Maybe be a little... crowded? Please give your opinion on this. Also, icons can be sprited or stand-alone. Just look into index.template.php for how it's done. This is a slightly modified version of Noisen's code. ONLY TESTED IN OPERA! May fail in Firefox & co...

:edit: You made a very small change... But a very smart one :) This was something that bothered the hell for me several times in the past!
Title: Re: New revs
Post by: Arantor on October 8th, 2010, 09:56 AM
Modularity is awesome :)

Now, we could trivially have it so that the info centre can be disabled cleanly without resorting to putting changes in the template... but that's only the beginning.
Title: Re: New revs
Post by: Nao on October 8th, 2010, 11:07 AM
Yeah. Modularity, that's the word... I guess it's got something to do with portal blocks.

(Can you give me your opinion on adding icons to the main menu, still?)
Title: Re: New revs
Post by: Arantor on October 8th, 2010, 11:15 AM
I like the idea of icons, haven't looked at the implementation yet.

It does add something and I know full well that icons can make or break a UI, but often if they're meaningful icons, they add to it :)

If it's anything like here, it works for me.
Title: Re: New revs
Post by: Nao on October 8th, 2010, 03:56 PM
rev 187
* Once again, sobriety... Replaced existing icon sprite with a Diagona set. (sprite.png, index.css, Subs.php)
+ Added Login icon, and an alternative PM icon when you've got mail. (sprite.png, Subs.php)
- IE6 sucks at showing sprited icons, so removed icons for it. (index.template.php, ie6.css)
* Retooled index.css to show brackets next to class names. This saves about 600 lines and is easier to navigate. (index.css)
* The forumtitle id sucked... Changed it for a better font and styling. (index.css)

*NOW* I'm happier with the icons... I just needed to use icons from a single set. No matter what the set. What matters is that they're all made by the same person. It can be improved, of course. But right now it won't induce nightmares anymore.

God, I swear I'm starting to love the Wedge theme now!! At last!
Title: Re: New revs
Post by: Nao on October 8th, 2010, 09:15 PM
rev 188
- Simplified theme_copyright... Let's not be paranoid, okay? (Subs.php)
* Modified copyright notice to add Wedge and ourselves to it. Now Wedge is officially illegal. (index.english.php, index.css, index.php)
+ Added direct link to local credits page in footer. (index.english.php, index.template.php)
! Fixed a very, very, very annoying menu bug in IE6. (script.js)
! Fixed icon problems with IE6 and deleted the IE7 hack as it wasn't needed. (index.css, index.template.php)
* Spacinazi. (Themes.php)

(I added 'Wedgeward' as the copyright holder... That's us. Our temp name. Because my fave book is the Windward Horde. But again -- temp!)
Title: Re: New revs
Post by: Nao on October 10th, 2010, 02:25 PM
rev 189 (This was all done yesterday but I'm having some computer issues and wasting time...)
+ Changed Calendar icon to a new, sprited one. Added sprited icon for Register. Fixed icon widths. (Subs.php)
* Updated to SMF rev 10150, with a lot of minor tweaks to layout and styling.
  * Missing icon in profile/ignore boards. Markup/css to allow large content above the linktree (Profile.template.php, index.template.php, index.css) (NB: was already done in Wedge anyway...)
  * Minor cleaning up in admin. Better highlighting of search results. Defined new_win class. Better description for post options (Admin.template.php, admin.css, index.css, Post.english.php)
  * Fixed post-breaking bug in IE6 and IE7. Removed $context['right_to_left'] from two templates. (ie6.css, ie7.css, index.css, rtl.css, Display.template.php, Memberlist.template.php)
  * Fixed board selection in profile and help. Cleaned up stats markup. (Profile.template.php, Help.template.php, Stats.template.php, index.css, rtl.css)
Title: Re: New revs
Post by: Arantor on October 10th, 2010, 05:25 PM
The one thing about the icons is that they're hardcoded right now; would be hard for theme authors to set the icons themselves.

While this would be somewhat ugly, would it not be preferable to define classes in CSS for each icon (like how the sprite icons work in the thread view normally) and control it all through CSS so theme authors can override/ignore it as they see fit?
Title: Re: New revs
Post by: Arantor on October 10th, 2010, 06:25 PM
Revision: 190
Author: arantor
Date: 17:24:43, 10 October 2010
Message:
+ Provide a default favicon.ico and have it called from the theme too (favicon.ico, index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Added : /trunk/favicon.ico
Title: Re: New revs
Post by: Nao on October 10th, 2010, 07:20 PM
Reasons why I didn't add a favicon myself:
- From the beginning, I was very happy with the favico I made for wedgeforum.com, but unhappy with the logo itself. Now, I'm very happy with my current Wedge logo, but unhappy with the (unused) favico I made from it...
- If admin has a favico for their site, they may erase it by thoughtlessly uploading the Wedge files to their website.
- If they're uploading to a subfolder, they may not like having a different favico than their main site, either.

This is basically why I didn't play with this...

Regarding the MIME type, why did you use "x-icon"?
The official type (as used on noisen and wedgeo) is "vdn/microsoft_crappy_files"
Cf. http://en.wikipedia.org/wiki/ICO_(file_format)
Posted: October 10th, 2010, 07:18 PM
Quote from Arantor on October 10th, 2010, 05:25 PM
The one thing about the icons is that they're hardcoded right now; would be hard for theme authors to set the icons themselves.
You mean, the sprited icons? Yes, that's always been the problem obviously...
Quote
While this would be somewhat ugly, would it not be preferable to define classes in CSS for each icon (like how the sprite icons work in the thread view normally) and control it all through CSS so theme authors can override/ignore it as they see fit?
Well, sure can do that, yes.
I'm sorry I didn't think of doing that from the beginning.
Title: Re: New revs
Post by: Arantor on October 10th, 2010, 07:51 PM
Quote
- From the beginning, I was very happy with the favico I made for wedgeforum.com, but unhappy with the logo itself. Now, I'm very happy with my current Wedge logo, but unhappy with the (unused) favico I made from it...
You can change it :P Just it was something to hand that was convenient.
Quote
- If admin has a favico for their site, they may erase it by thoughtlessly uploading the Wedge files to their website.
Sure, but how often do site admins have a favicon already in place for a top level domain and have nothing else there when adding a forum to the top level of the domain?
Quote
- If they're uploading to a subfolder, they may not like having a different favico than their main site, either.
Sure, but having it set up like this will mean they just copy theirs over the top of the provided one (we don't have to include it in upgrades).

It also means if they just want to customise it, they have a point of reference.
Quote
Well, sure can do that, yes.
I'm sorry I didn't think of doing that from the beginning.
No need to apologise; only reason I thought of it is because I've been doing a similarly styleable menu for my other project and one of the things was to make it as flexible as possible to style in pure CSS.
Title: Re: New revs
Post by: Nao on October 10th, 2010, 11:18 PM
rev 191
* Made main menu background a bit brighter. Subtility, crap like that... (index.css)
+ Made sure to hide the dropdown arrow if a top-level menu entry doesn't have any submenu. (index.css, index.template.php)
* Moved main menu icon definitions to index.css, and replaced spriting code with a simple 'padding' parameter to tell the menu code the actual width of the current icon. (Subs.php, index.css, index.template.php)
* Changed favicon MIME type to the official one. (index.template.php)
Quote from Arantor on October 10th, 2010, 07:51 PM
You can change it :P Just it was something to hand that was convenient.
We'll be keeping it for now, I guess...
Quote
Sure, but how often do site admins have a favicon already in place for a top level domain and have nothing else there when adding a forum to the top level of the domain?
Hmm... Well...
I don't know.
To me, that Wedge icon was pretty much the symbol for our website, rather than our software. See what I mean...?
Just like SMF has their own favicon at simplemachines.org, but they don't include it in the package.
Quote
Sure, but having it set up like this will mean they just copy theirs over the top of the provided one (we don't have to include it in upgrades).
Hmm... I guess. But if they don't know the first time around... And if they don't keep a copy somewhere... (Okay, then that's THEIR problem.)
Quote
No need to apologise; only reason I thought of it is because I've been doing a similarly styleable menu for my other project and one of the things was to make it as flexible as possible to style in pure CSS.
I was probably influenced a bit too much by my own Noisen code for adding icons in the main menu.
(And seriously -- I don't understand a bit why it was so incredibly easy to implement them in a tableless fashion in Wedge, when I broke my teeth for several days trying the same in Noisen... And finally settled on a table version.)
Title: Re: New revs
Post by: Arantor on October 11th, 2010, 12:04 AM
Quote
Hmm... Well...
I don't know.
To me, that Wedge icon was pretty much the symbol for our website, rather than our software. See what I mean...?
Just like SMF has their own favicon at simplemachines.org, but they don't include it in the package.
It's not really about the icon itself that I made the change; the icon just happened to be what I had to hand. The idea is to provide something out of the box for those users who would want it - I'm thinking about things we can do to minimise support requests generally, and having it set up like that will mean that people can just upload a new one and everything will just support it regardless of anything else.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 01:02 AM
Revision: 192
Author: arantor
Date: 00:01:09, 12 October 2010
Message:
- Remove karma (lots of files, including removing from the installer, language strings, even the icon for it in Core Features)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/DbPackages.php
Deleted : /trunk/Sources/Karma.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/News.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Deleted : /trunk/Themes/default/images/admin/feature_k.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install_2-0.sql
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/other/xml/detailed-version.js


Surprising how many places needed to be edited for what is really a minor feature.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 05:05 AM
Revision: 193
Author: arantor
Date: 02:45:10, 12 October 2010
Message:
! Make Wedge UTF-8 only. Note, there are still some legacy functions roaming around (notably the legacy attachment handler and the conversion functions to handle other-to-UTF-8 and entities-to-UTF-8-characters) which can remain for now until we get that sorted in the converters.
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/DbPackages.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/LogInOut.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/News.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Printpage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/Themes/default/Xml.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Modified : /trunk/other/Sphinx/sphinx_config.php
Modified : /trunk/other/install.php
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/templates/UnitTest.template.php
Modified : /trunk/other/upgrade.php



I don't think I broke anything, either, and I think I got rid of most (if not all) of the language strings though I may have left some for the legacy conversion interface in there.
Posted: October 12th, 2010, 03:45 AM

Revision: 194
Author: arantor
Date: 03:23:23, 12 October 2010
Message:
! More anti-UTF-8 removals
 ! Fixing the language editor (ManageServer.php, Admin.template.php)
 ! Fixing language loaders (Load.php, ManageServer.php)
 ! Yet more language strings going bye-bye (Install.english.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


I yoinked out some more stuff in the admin panel. Nothing exciting.
Posted: October 12th, 2010, 04:24 AM

Revision: 195
Author: arantor
Date: 04:03:50, 12 October 2010
Message:
! Fix minimum version in web installer
+ Added check for GD2 plus the functions we need in the CAPTCHA and attachment handlers
----
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/webinstall.php


There's more to the GD stuff; now that's in, there's legacy stuff like the gif-to-png magic converter, plus the files in the fonts/ directory that are GIFs, and the CAPTCHA-without-GD code that can go too. Time for bed for me though, didn't have time to do them today.
Title: Re: New revs
Post by: live627 on October 12th, 2010, 08:14 AM
Quote from Arantor on October 12th, 2010, 01:02 AM
- Remove karma (lots of files, including removing from the installer, language strings, even the icon for it in Core Features)
So does that imply that Fustrate's Rep mod won't work?


What program lets you copy the entire output? TortoiseSVN?
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 08:57 AM
It won't work, no, because I ripped out the DB fields too.

Yup, I use TortoiseSVN, all I do for my commit notices is go to the trunk root, right click, view the log then right click on my commit and copy to clipboard.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 10:09 AM
Revision: 196
Author: nao
Date: 08:26:55, 12 October 2010
Message:
* Renamed content_section to content. (Various files)
----
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/ie7.css
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/other/readme_convert.html
Modified : /trunk/other/readme_install.html
Modified : /trunk/other/readme_update.html
Modified : /trunk/other/readme_upgrade.html


Revision: 197
Author: arantor
Date: 09:08:17, 12 October 2010
Message:
- Remove legacy CAPTCHA code using only premade images shown in a line (ManageSettings.php, ManageSettings.english.php, Register.php, Subs-Editor.php, Subs-Graphics.php, GenericControls.template.php)
- Remove all the premade image folders (Candice, Hootie, President)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Themes/default/GenericControls.template.php
Deleted : /trunk/Themes/default/fonts/Candice
Deleted : /trunk/Themes/default/fonts/Hootie
Deleted : /trunk/Themes/default/fonts/President
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on October 12th, 2010, 10:27 AM
I was going to post my 196 log ;)
Reason I did that small commit, is to save me some time when diff'ing the files. In the end it was pretty useless because several of the files needed to be updated first, so I didn't commit those... So it's a half-broken update, ah ah! Just don't bother about it. I'll commit the final 3 files when I'm done reviewing your tons of edits.
As for myself, I copy what I type into the changelog, directly before posting it, because if a file is out of sync, it friggin' erases the log and doesn't let me copy it for my next attempt! So, I use the opportunity to post the text here... Hence why it doesn't have your more verbose changelog formatting.

rev 198
* Simplified htmlspecialchars(). (Load.php)
- Removed smf_charset Javascript variable. (ssi_examples.php, upgrade.php, index.template.php, script.js)
- Removed any charsets other than UTF8 from php_to8bit(). That felt GOOD! (script.js)
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 10:49 AM
Quote
As for myself, I copy what I type into the changelog, directly before posting it, because if a file is out of sync, it friggin' erases the log and doesn't let me copy it for my next attempt!
Never have that problem, even when it's out of sync. TortoiseSVN keeps all mine even if I hit cancel; above the changelog textbox there's a 'Recent Messages' button you can click... maybe you need a more recent version?
Quote
* Simplified htmlspecialchars(). (Load.php)
Interesting change... any particular reason? The one thing I'd note is that now every ' that comes in will be converted to an entity (which may have other consequences for the places where no override was given, where it will just use ENT_COMPAT, so only double quotes would be entitified before)
Title: Re: New revs
Post by: Nao on October 12th, 2010, 12:04 PM
rev 199
- Karma leftovers. (upgrade_2-0.sql)
- getLanguage() utf8 leftovers. (ManageServer.php, Profile-Modify.php)
- char_set leftover. (ScheduledTasks.php)

I'll leave you the pleasure of submitting rev 200!
Quote from Arantor on October 12th, 2010, 10:49 AM
Never have that problem, even when it's out of sync. TortoiseSVN keeps all mine even if I hit cancel; above the changelog textbox there's a 'Recent Messages' button you can click... maybe you need a more recent version?
Yeah, maybe. I have a fairly recent version (several months.)
I'll be sure to have a look next time.
Quote
Quote
* Simplified htmlspecialchars(). (Load.php)
Interesting change... any particular reason? The one thing I'd note is that now every ' that comes in will be converted to an entity (which may have other consequences for the places where no override was given, where it will just use ENT_COMPAT, so only double quotes would be entitified before)
I... I'm not sure I understand. I was just read through the log, saw something that I would sum up as "$a = 'hello'; echo $a;" and turned it into "echo 'a';"... Did I make a mistake? Feel free to revert, of course.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 01:16 PM
Quote
I... I'm not sure I understand. I was just read through the log, saw something that I would sum up as "$a = 'hello'; echo $a;" and turned it into "echo 'a';"... Did I make a mistake? Feel free to revert, of course.
htmlspecialchars does one core job, converting key HTML items into entities, namely stuff like & to &amp;. It also has options for handling quotes, ENT_COMPAT, ENT_NOQUOTES and ENT_QUOTES. ENT_COMPAT is the default, which converts " to &quot;, ENT_NOQUOTES leaves both " and ' alone, and ENT_QUOTES does both " to &quot; and ' to  according to php.net's page on it. (At least, it definitely turns ' into entities)

It's probably OK to do that, actually, but it may have unintended side effects. I'll revert it for now because I don't want to get extra unintended stuff breaking - the UTF-8 changes were huge, and may mean other stuff may fail in interesting ways yet, and I'd rather not change something like that just yet. (It is a good idea to simplify it down though, as I'm not entirely sure that it's needed outside the query parameterisation)
Posted: October 12th, 2010, 12:25 PM

Revision: 200
Author: arantor
Date: 11:40:49, 12 October 2010
Message:
! Expand installer strtolower version to match main source (install.php)
! Fix broken regexp for sanitising lists (Class-Editor.php)
! Quasi-revert htmlspecialchars change for now, but remove charset parameter (Load.php)
! Remove lang_character_set from the language editor options (ManageServer.php)
! Fix caller for recursive Unicode validation (Subs.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/install.php

Posted: October 12th, 2010, 12:41 PM

Revision: 201
Author: arantor
Date: 12:16:01, 12 October 2010
Message:
! Restructure download handler into its own file (Display.php, index.php, Download.php)
! Fix broken attachments (reverting previous optimisation) (Download.php)
----
Modified : /trunk/Sources/Display.php
Added : /trunk/Sources/Download.php
Modified : /trunk/index.php


This marks the start of breaking up the monolithic files in the core; there's really no need to have them like that, especially as it makes things slower in fact (Display being one of the most heavily used files, needs to be kept lighter!)
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:04 PM
rev 202
- Removed unused globals from Xml functions. (Xml.template.php)
* Complicated code just for an unset... (index.php, SSI.php)
* Spacinazi. (ManageSettings.php, Admin.template.php)

rev 203
* Committed the last few conflicted files with content_section changes. (install.php, ssi_examples.php, upgrade.php, index.template.php)
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 02:17 PM
Quote
* Complicated code just for an unset... (index.php, SSI.php)
It didn't used to be complicated for a single unset, when it had two items in it... but in hindsight it was still complicated.
Quote
* Spacinazi. (ManageSettings.php, Admin.template.php)
Won't that break the settings pages since $context['settings_post_javascript'] doesn't add its own <script> tag...?
Quote
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Yes, that was an oops moment, sorry...
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:27 PM
Phew... Finally done reading through your changes. I can't believe you did all of that in a single night...! What are you on?

Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Quote from Arantor on October 12th, 2010, 01:16 PM
htmlspecialchars does one core job, converting key HTML items into entities, namely stuff like & to &amp;. It also has options for handling quotes, ENT_COMPAT, ENT_NOQUOTES and ENT_QUOTES. ENT_COMPAT is the default, which converts " to &quot;, ENT_NOQUOTES leaves both " and ' alone, and ENT_QUOTES does both " to &quot; and ' to  according to php.net's page on it. (At least, it definitely turns ' into entities)
Oh... I see what you mean, very sorry. I didn't notice the separator. I was changing the data in the parameter list -- and that was a "default" parameter but it could be changed... I've never been very comfy with create_function.
I totally broke htmlspecialchars, ahah!
BTW, there were two remaining calls in ManageServer.php that specified UTF-8 at the end, I've modified them locally. Will be in the next commit.
Quote
(It is a good idea to simplify it down though, as I'm not entirely sure that it's needed outside the query parameterisation)
Oh well then that's a good thing I missed the point in the first place... 8-)
Quote
! Expand installer strtolower version to match main source (install.php)
+1
Quote
! Fix broken regexp for sanitising lists (Class-Editor.php)
-1 :niark:
Quote
! Fix caller for recursive Unicode validation (Subs.php)
BTW, makes me think... Is this Unicode or UTF? If it's Unicode, then I don't even know what the function is there for... SMF/Wedge never ever generate Unicode stuff, AFAIK...
Quote
! Fix broken attachments (reverting previous optimisation) (Download.php)
That was one of mine... Actually I just followed the comment's suggestion. ("Would use ob_clean but that's PHP 4.2") I figured okay it's PHP 5.0 now so let's use ob_clean...
Now, I'm not sure in what way it was broken? It's been a long time since I've played with output buffer manipulation. Especially in SMF, where there are plenty of buffers at a time...
Quote
This marks the start of breaking up the monolithic files in the core; there's really no need to have them like that, especially as it makes things slower in fact (Display being one of the most heavily used files, needs to be kept lighter!)
That's a good idea, indeed...
Quote from Arantor on October 12th, 2010, 02:17 PM
It didn't used to be complicated for a single unset, when it had two items in it... but in hindsight it was still complicated.
Well, yes it was complicated, even at the time... My problem is that I'm not auditing the codebase. Maybe I should. I only find such issues when checking commits and making changes to the code myself.

unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);

As you can see... It does two unsets, and it's still a single call ;)
Quote
Quote
* Spacinazi. (ManageSettings.php, Admin.template.php)
Won't that break the settings pages since $context['settings_post_javascript'] doesn't add its own <script> tag...?
Well, I added the script tag in ManageSettings, didn't I...?
I mainly did it because you unindented the code and it wasn't in line with the script tag. Also, SMF's implementation would automatically add a tab. I just deleted the hell out of those ugly lines and made it cleaner.
That's my job...[1]
Quote
Quote
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Yes, that was an oops moment, sorry...
 1. I'M NOT A WINDOW CLEANER!!!!![1]
 1. Okay, it only works if you've read my first post on runic's place[1].
 1. *And* you watched this year's IT Crowd...
Given these last few hectic hours, it's no surprise we're both making blunders here and there. That's why we proof-read each other's code. Glad to be of help :)

Hey, my footnotes got in the wrong place... I'll make sure I've applied my Wedge fix on them.

:edit: Argh, it seems that it's already applied... :-/ Will need to fix that, then.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 02:36 PM
Quote
Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Get a better browser then; Chrome's had it built in for ages. :P
Quote
BTW, makes me think... Is this Unicode or UTF? If it's Unicode, then I don't even know what the function is there for... SMF/Wedge never ever generate Unicode stuff, AFAIK...
Well... UTF-8 is one form of Unicode. The whole concept is a total mess anyway -sigh-. Anyway, the idea is that it should always be valid UTF-8 (and by proxy valid Unicode) except that in some cases it isn't, but I have no idea why that might be. It's been there since 1.1, and it may not be relevant any more - doubly so since it never seemed to be called before.
Quote
Now, I'm not sure in what way it was broken? It's been a long time since I've played with output buffer manipulation. Especially in SMF, where there are plenty of buffers at a time...
Attachments totally failed to load before. Just went to an error message about not being able to load the page.

What was happening is that there was an extra output buffer existing that shouldn't have existed, which was causing content not to be flushed properly - and even if it did get flushed, the result would be corrupted because it would be gzipped content when the header implied otherwise. (I haven't checked the browser-specific stuff yet, that's next up)

Gzipping binary content when you're serving in true binary probably isn't a clever idea ;) And if it's over 4MB, you don't really want to be managing that in PHP anyway since it'll be coming out of PHP memory, PHP buffering and possibly fail between PHP and webserver.
Quote
unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);
I wonder why SMF never did that.
Quote
Well, I added the script tag in ManageSettings, didn't I...?
It still breaks though, vomiting raw JS onto the page :/
Quote
Given these last few hectic hours, it's no surprise we're both making blunders here and there. That's why we proof-read each other's code. Glad to be of help
Not only that but we've made some very large changes to the codebase, and it's unlikely we'd have totally caught every one first time simply because they are very large changes with lots of consequences.
Title: Re: New revs
Post by: MultiformeIngegno on October 12th, 2010, 02:51 PM
Quote from Arantor on October 12th, 2010, 02:36 PM
Get a better browser then; Chrome's had it built in for ages. :P
Chrome rulez!! :cool: :lol:
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:55 PM
rev 204
+ Added :edit: smiley. (install_2-0.sql, Install.english.php, Class-Editor.php, Subs.php)
* htmlspecialchars leftover. (ManageSettings.php)

PS: reproduced footnote error in Wedge... Hmpf. This will never end... I'll take a break or something.
Quote from Arantor on October 12th, 2010, 02:36 PM
Get a better browser then; Chrome's had it built in for ages. :P
Yeah, I remember that... Damn you, Google fanboys! :ph34r:
I'll stay with my lousy browser. It just added Web Sockets support. Yeah, I know, you've had it for a year, blah blah blah... But your tab UI has sucked from day one :niark:
Quote
Well... UTF-8 is one form of Unicode. The whole concept is a total mess anyway -sigh-. Anyway, the idea is that it should always be valid UTF-8 (and by proxy valid Unicode) except that in some cases it isn't, but I have no idea why that might be. It's been there since 1.1, and it may not be relevant any more - doubly so since it never seemed to be called before.
Yeah... Which is why I reported(http://dev.simplemachines.org/mantis/view.php?id=4498) the issue to the SMF devs. Maybe they'll figure it out... We have much work on our hands, too.
Quote
What was happening is that there was an extra output buffer existing that shouldn't have existed, which was causing content not to be flushed properly - and even if it did get flushed, the result would be corrupted because it would be gzipped content when the header implied otherwise. (I haven't checked the browser-specific stuff yet, that's next up)
Okay... ob_clean is supposed to empty the buffer without deleting the hooks. So I guess what happened is: originally, there was one less buffer called, and the dev added that remark. Then, someone added an extra buffer that should NOT be used in attachments, and forgot (or wisely decided) not to use it in the code we're talking about, so that their buffer wasn't re-created after ob_get_clean(). But forgot to delete the mention about ob_clean().
Quote
Quote
unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);
I wonder why SMF never did that.
They can probably explain that using isset() saves 0.07 microseconds off execution time.
Of course, the foreach with a custom array will definitely eat that...

Let's just say they didn't know unset() could be called with multiple parameters.
Or that unset() on an undefined variable didn't generate any warnings or errors (except on an undefinex index in an undefined array, in PHP4 only.)
Maybe the foreach() was there because they planned to add more vars to it later...
Just like in Subs-Members.php... I see no other reason to use THAT, and even the comment spells it out. 'Characters'. (Feel free to delete it.)

Code: [Select]
// Characters we just shouldn't allow, regardless.
foreach (array('*') as $char)
if (strpos($checkName, $char) !== false)
if ($fatal)
fatal_lang_error('username_reserved', 'password', array($char));
else
return true;

IIRC, I already fixed a similar code block long ago. Was probably in Aeva Media... Something Dragooon had copied from SMF, I'd venture.
Quote
It still breaks though, vomiting raw JS onto the page :/
Okay, I see what you mean... The var is modified after that. Uh. That's what happens when you're busy fixing 12 things at the same time.
Well, I'll fix that back...
Quote
Not only that but we've made some very large changes to the codebase, and it's unlikely we'd have totally caught every one first time simply because they are very large changes with lots of consequences.
Not only that, but you have no idea how fun it's going to be when I get to update to the latest SMF SVN...
Basically, I now have to do all of the templates manually because they always change stuff around a .catbg class (which no longer exists), now I'll have to edit source files manually every time they make a change around a UTF call... ;)
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:58 PM
rev 205
! Fixing the settings_post_javascript fix. Today's the fixing game. (ManageSettings.php, Admin.template.php)

(Just to get this off my hands...)
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 04:13 PM
Quote
Yeah, I remember that... Damn you, Google fanboys!
I thought I remembered seeing Opera have a resizeable textarea a year or more ago? Then again that would have been during my Star Pirates/Greasemonkey days where I was fudging GM to work on Firefox, Opera, Safari with SIMBL support (thanks to Asgard), so I sorta lost track of what did what.
Quote
Let's just say they didn't know unset() could be called with multiple parameters.
Works for me ;)
Quote
Just like in Subs-Members.php... I see no other reason to use THAT, and even the comment spells it out. 'Characters'. (Feel free to delete it.)
I bet once upon a time there were more characters in that list, or should have been.
Quote
Not only that, but you have no idea how fun it's going to be when I get to update to the latest SMF SVN...
As I keep trying to tell Antechinus, spending time farting around with stupid little changes in the source that doesn't benefit anyone just slows down actually fixing real issues.
Posted: October 12th, 2010, 03:00 PM

Revision: 206
Author: arantor
Date: 15:13:11, 12 October 2010
Message:
! Removed random support for Firefox and Opera in downloads, they work just fine with the default, even with filenames with UTF-8 in them. (Download.php)
! Another silly bugfix from the UTF-8 stuff. (Subs-Post.php)
----
Modified : /trunk/Sources/Download.php
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on October 12th, 2010, 05:52 PM
Quote from Arantor on October 12th, 2010, 04:13 PM
Quote
Yeah, I remember that... Damn you, Google fanboys!
I thought I remembered seeing Opera have a resizeable textarea a year or more ago?
Nope... None I can think of.
Quote
Then again that would have been during my Star Pirates/Greasemonkey days where I was fudging GM to work on Firefox, Opera, Safari with SIMBL support (thanks to Asgard), so I sorta lost track of what did what.
Opera has UserJS and indeed it probably can 'fix' that. It has dozens of hacks like that for every possible use.
I'm not using any, though. Vanilla Opera is just right for me. (Usually.)
Quote
I bet once upon a time there were more characters in that list, or should have been.
Actually, not... Was added in SMF2 RC3.
Quote
As I keep trying to tell Antechinus, spending time farting around with stupid little changes in the source that doesn't benefit anyone just slows down actually fixing real issues.
Hmm, some of these stupid little changes are interesting for the future... And we do discuss mostly little changes, too ;) So I wouldn't criticize him on that.
Look (if need be, since you're also following these) at what they're discussing these days: (last pages of these topics, obviously.)
http://www.simplemachines.org/community/index.php?topic=403149.0 --> Fustrate and splitting monolithic files into many files.
http://www.simplemachines.org/community/index.php?topic=404100.40 --> Ante adding jQuery to SMF 2.1
http://www.simplemachines.org/community/index.php?topic=400219.msg2815429#msg2815429 --> Norv and his "joke" (?!) about splitting the members table into several relational tables...


Speaking of Ante, I just found this amusing post from him...
Look at the date.
http://portamx.com/topic_1480.msg8657.html#msg8657
Now that he's a dev... Well, let's just say he's had a change of heart. ::)
(And Fel is again referring to self as "the PortaMx corp." :lol:) <PRV>

Also, Ante is a veteran coder, as can be seen here:
http://portamx.com/topic_535.msg5728.html#msg5728
Quote
! Removed random support for Firefox and Opera in downloads, they work just fine with the default, even with filenames with UTF-8 in them. (Download.php)
Yay, I knew it :) That's what you get when code stays static for years!
Did you test with older but still supported versions of Opera and FF? I can test with Opera 9 if you ask me.
Title: Re: New revs
Post by: Nao on October 12th, 2010, 05:57 PM
Quote from Arantor on October 12th, 2010, 04:13 PM
! Another silly bugfix from the UTF-8 stuff. (Subs-Post.php)
Can't we just remove the first parameter? It'll always be set to UTF-8 anyway...
list($charset, ...) =
There's plenty of $charset happiness to crush heartlessly.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 08:19 PM
Quote
That's what you get when code stays static for years!
Did you test with older but still supported versions of Opera and FF? I can test with Opera 9 if you ask me.
I didn't test with older stuff particularly; Chrome 7, FF 3.6.9 or 3.6.10, Opera 10.60 (I think) and IE 8. But as a general rule users on non IE platforms are much better about staying up to date, and really I think they've all moved on a long way since 2006. Except IE that still needs its hand holding otherwise it tries so hard to be clever and fails so dismally. No, IE, I am not using Windows-1252 for this!
Quote
Can't we just remove the first parameter? It'll always be set to UTF-8 anyway...
I just wanted it to work without spewing errors for registrations so I could sign up test accounts for attachment testing.
Title: Re: New revs
Post by: live627 on October 12th, 2010, 09:25 PM
Quote from Arantor on October 12th, 2010, 02:36 PM
Quote
Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Get a better browser then; Chrome's had it built in for ages. :P
Firefox is fine, but it doesn't have resizeable text boxes that those... webkit browsers
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 09:26 PM
C'mon, you LURVE those Webkit browsers :D
Title: Re: New revs
Post by: live627 on October 12th, 2010, 09:32 PM
TROLL :P lol
Title: Re: New revs
Post by: Nao on October 13th, 2010, 11:21 PM
rev 207
+ Added French language translation -- hopefully up to date! (*.french.php)
+ Added flag icons for French and English languages -- a future feature. (Flag.english.png, Flag.french.png)
- Removed some core/babylon/classic theme leftovers. (upgrade_2-0.sql, Install.english.php)
* Temporarily renamed default theme to 'Wager'. (Install.english.php)
* Replaced logo with a cleaner version made by Bloc. (wedgelogo.png, index.template.php)
+ Added language strings for upcoming features: Ignore Topics, Merge double posts, Spoiler tag, Topic privacy, Blog system. (Errors.english.php, Help.english.php, index.english.php, ManageMembers.english.php, ManageSettings.english.php)
! Some permission names implied that *_any was for "other members", rather than "all members" (i.e. the *_own permission doesn't need to be enabled at the same time.) There may be some leftovers. (ManagePermissions.english.php)
Quote from Arantor on October 12th, 2010, 08:19 PM
I just wanted it to work without spewing errors for registrations so I could sign up test accounts for attachment testing.
Why would it give errors...? Oh, you mean it was a quick hack, somehow?
Title: Re: New revs
Post by: Arantor on October 13th, 2010, 11:52 PM
I just had the account sign up regularly, which causes an email, and the email functions still had $charset in them without $charset being defined.
Title: Re: New revs
Post by: Nao on October 13th, 2010, 11:57 PM
rev 208
- Removed a few past dates from the calendar installer. Also deleted the next Thanksgiving because we won't be out by then. And we're British and French. Do you think we care about Thanksgiving? We can be bastards 365 days a year. That's cool. (install_2-0.sql)
* The unused UTF8 converter added a curious string to the database. Probably not worth looking into it as it'll be removed anyway. (ManageMaintenance.php)
- Removed a $context['utf8'] leftover. Used some escaping so I guess that's why Pete missed it. (Profile-Modify.php)
! Syntax error. (Admin.french.php)

---> Note to self: check why calendar seems to take more than 100% width.
Quote from Arantor on October 13th, 2010, 11:52 PM
I just had the account sign up regularly, which causes an email, and the email functions still had $charset in them without $charset being defined.
And no way to delete that?
Title: Re: New revs
Post by: Arantor on October 14th, 2010, 12:03 AM
I didn't look into it that highly, I just wanted it to work without errors, I figured I'd worry about it being perfectly clean later.
Title: Re: New revs
Post by: Nao on October 14th, 2010, 12:05 AM
It just generated an error when saving one's profile account page.
(Happened after I changed my default language to French.)
Title: Re: New revs
Post by: Arantor on October 15th, 2010, 10:26 AM
Revision: 209
Author: arantor
Date: 08:49:41, 15 October 2010
Message:
! Added flag to the manage languages page (ManageServer.php)
! Clarified that the language name is clickable (ManageSettings.english.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php

Posted: October 15th, 2010, 09:50 AM

Revision: 210
Author: arantor
Date: 09:06:09, 15 October 2010
Message:
- Remove legacy GIF support (detailed-version.js, Class-Graphics.php, Subs-Graphics.php)
----
Deleted : /trunk/Sources/Class-Graphics.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/other/xml/detailed-version.js

Posted: October 15th, 2010, 10:06 AM

Revision: 211
Author: arantor
Date: 09:26:06, 15 October 2010
Message:
! Attachments now have .ext extensions by default to ensure they are not treated as ASCII files accidentally. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on October 15th, 2010, 10:28 AM
(Maybe I should do that .ext thing for AeMe as well...)
Title: Re: New revs
Post by: Arantor on October 15th, 2010, 03:04 PM
Revision: 212
Author: arantor
Date: 12:39:21, 15 October 2010
Message:
! Being bold.
 ! The info center is now its own template file. (BoardIndexInfoCenter.template.php)
 ! The board index and info center have been broken down into smaller subtemplates and called as a group. (BoardIndex.php, BoardIndex.template.php, BoardIndexInfoCenter.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Added : /trunk/Themes/default/BoardIndexInfoCenter.template.php

Posted: October 15th, 2010, 01:39 PM

I do sort of want to break up the board index and message index into a board listing template; the code used between the two is identical except for spacing only and the initial foreach.

If I break them off into a new function which accepts an array (by reference) of boards, then foreachs through that array, we can cut the size of the board and message indexes down, and have them share the board listing code.
Posted: October 15th, 2010, 01:41 PM

Revision: 213
Author: arantor
Date: 13:25:44, 15 October 2010
Message:
! More cleanup now we know GD2 must be available (Subs-Graphics.php)
----
Modified : /trunk/Sources/Subs-Graphics.php

Posted: October 15th, 2010, 02:26 PM

Revision: 214
Author: arantor
Date: 13:44:05, 15 October 2010
Message:
! Doc additions, cleanups (Help.php, Subs-Graphics.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs-Graphics.php

Posted: October 15th, 2010, 02:44 PM

Revision: 215
Author: arantor
Date: 14:04:03, 15 October 2010
Message:
! Announcement sending now in its own files instead of bulking up the Post files (index.php, Post.php, Post.template.php, Announce.php, Announce.template.php)
----
Added : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on October 15th, 2010, 04:56 PM
rev 216
* Minor spacing, and French translation. (Post.php, Subs-Graphics.php, ManageSettings.french.php)

(Well, it just means I'm done reviewing your commits :P)

BTW, why call the new file BoardIndexInfoCenter.template.php, rather than just InfoCenter.template.php? I know it's only initialized in the board index, but still... It could be recycled, couldn't it?

(I'm all for removal of recycled code, BTW!)
Title: Re: New revs
Post by: Arantor on October 15th, 2010, 04:58 PM
I did think about that, but it's tied to BoardIndex.php right now, since BoardIndex() gets all the stats, birthdays, recent posts, calendar entries, online folks etc to make it work.

The only way we could reasonably separate it and make it stand alone like that would be to make a InfoCenter.php, with InfoCenter(), which could be called from BoardIndex.php (or, notionally, Subs-BoardIndex.php) to get the information. Thing is you could have this subsidiary function manage the changes to the template list, as well as loading the other template, meaning BoardIndex would be 99% just for the board index itself (which would be neat)
Title: Re: New revs
Post by: Nao on October 16th, 2010, 11:46 AM
rev 217
* Updated to SMF rev 10171, and hacked my own style into the changes. (changelog.txt, tools folder, ManagePaid.php, Profile-Modify.php, Profile-View.php, Subs.php, ie6.css, ie7.css, index.css, GenericMenu.template.php, Post.template.php, Profile.template.php, editor.js)
- Since we're not upgrading from SMF1, removed the dont_repeat_theme_core process in install/upgrade. Kept the equivalent smiley upgrade process for now, because we may need that code for the SMF2->Wedge converter. (install_2-0.sql, upgrade_2-0.sql)
* Improved visuals for the search highlight class. (index.css)
* Improved Wedge logo. Not perfect... But better. (wedgelogo.png)

I postponed work on <div class="content"> until I was done with SMF.
I'll get started today... Will probably commit in several batches because I doubt I'll be finished today.
Posted: October 16th, 2010, 11:44 AM
Quote from Arantor on October 15th, 2010, 04:58 PM
I did think about that, but it's tied to BoardIndex.php right now, since BoardIndex() gets all the stats, birthdays, recent posts, calendar entries, online folks etc to make it work.
We could simply add a comment in InfoCenter.template.php stating that this is called from within BoardIndex()... No?
Title: Re: New revs
Post by: Arantor on October 16th, 2010, 12:08 PM
I'm in the midst of polishing up the Bad Behavior implementation (for stopping bad bots and spammers) and won't commit until I'm all done because it's pretty intricate - also means I probably won't review those patches until I'm ready to commit.

Seems to me there's a lot of purely style tweaks when the dev time would be better spent fixing bugs.
Title: Re: New revs
Post by: Nao on October 16th, 2010, 01:23 PM
Looking at the logs, 99% of what Antechinus does is style tweaks and template fixes. That's basically all he's been doing since the beginning -- visual tweaks. I know I'm doing a lot of these too, as it's one of my favorite things to do, but I'm not that focused...!
Norv does the converter stuff (I ain't importing that, though.) and hasn't committed anything interesting the last 3 weeks. Same for SiNaN, pretty much.
Uh...

"content" is going at a good pace but I'm currently stuck on a styling dilemma with the Display template. I'm crazy enough to spend time trying to fix a single pixel.
Title: Re: New revs
Post by: Arantor on October 16th, 2010, 03:46 PM
Ahtalkanus is allegedly on the team as a designer and by his own admission is not a strong programmer.

Norv's had commit rights to the converters branch since even before I left the team, which I thought was somewhat awkward.

As for the display template, I've been trying to figure out how I want to split that up since I think it does need to be split up.
Title: Re: New revs
Post by: Nao on October 16th, 2010, 06:19 PM
Quote from Arantor on October 16th, 2010, 03:46 PM
Ahtalkanus is allegedly on the team as a designer and by his own admission is not a strong programmer.
That's to his credit then, but I'm not as fine with the team hiring non-devs to do dev work.
I mean, why didn't they just invite Bloc instead? He wrote Curve in the first place, he can fix it! Ante's main achievement on Curve was... What? Adding more markup?
Quote
As for the display template, I've been trying to figure out how I want to split that up since I think it does need to be split up.
Well, it does. At the very least, we should elaborate on how we implement templating for floating topics.
Title: Re: New revs
Post by: Arantor on October 16th, 2010, 06:34 PM
Note the reason Ahtalkanus has a Dev badge as opposed to a Core Dev badge, that's the principle difference. That, and that Dev rather than Core Dev was also TE's position for a long time as he looked after converters rather than the core.

Interestingly Bloc used to be on the dev team, with a Dev (rather than Core Dev) badge when he initially designed Curve.
Title: Re: New revs
Post by: Nao on October 17th, 2010, 02:18 PM
All right... Makes more sense when said this way.
Posted: October 16th, 2010, 07:09 PM
Quote from Nao/Gilles on October 16th, 2010, 01:23 PM
"content" is going at a good pace but I'm currently stuck on a styling dilemma with the Display template. I'm crazy enough to spend time trying to fix a single pixel.
Fixed dilemma yesterday. Didn't get to commit any batch. That's because it's moving at a faster pace than I expected... I just finished doing all instances :) Even had time to fix hundreds of indentation bugs, as well as a few other bugs. (http://dev.simplemachines.org/mantis/view.php?id=4505#bugnotes)
Will commit today, but I'll need to review all of my fixes first... (Ah ah, more fun. I'm so tired.)
Title: Re: New revs
Post by: Nao on October 17th, 2010, 04:40 PM
Revision: 218
Author: nao
Date: 16:37:00, dimanche 17 octobre 2010
Message:
* Introducing a new favicon and associated logo. (favicon.ico, wedgelogo.png)
! Uppercase $_POST is duh. (PersonalMessage.php, PersonalMessage.template.php)
! Fixed a Javascript exception when clicking an editor button under Opera. (script.js)
* Board lists in BoardIndex and MessageIndex weren't clearly targeted in index.css (BoardIndex.template.php, MessageIndex.template.php, index.css)
* Various spacinazi and minor fixes. (BoardIndexInfoCenter.template.php, GenericMenu.template.php, PersonalMessage.template.php)
! A user's list of posts should show the Delete/Quote/etc. buttons next to their title, rather than below the message, for consistency reasons. (Profile.template.php)
! Fixed two validation errors. (index.template.php)
- Deleted all .content occurrences, as they no longer were needed. Fixed dozens of indenting and spacing issues in the process. (ssi_examples.php, ie6.css, rtl.css, index.css, Templates: Admin, BoardIndex, Display, ManageAttachments / Bans / Boards / Calendar / Mail / Maintenance / Membergroups / Members / News / Paid / Permissions / ScheduledTasks / Search / Smileys, MessageIndex, Packages, PersonalMessage, Post, Profile, Recent, Register, Reports, Search, SendTopic, SplitTopics, Stats, Themes, Who)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Stats.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/css/admin.css
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/css/rtl.css
Modified : /trunk/Themes/default/images/wedgelogo.png
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/changelog.txt
Modified : /trunk/favicon.ico
Modified : /trunk/other/ssi_examples.php

FYI, this rev saved a total of 22.800 bytes (SVN included, so it's not exactly byte for byte.)
Not much, but still welcome...!
Title: Re: New revs
Post by: Nao on October 17th, 2010, 08:20 PM
rev 219
* Updated to SMF svn 10185 whatever needed to be updated. *sob* Second time I get my name in the changelog. Also updated French version.
  ! Oops, yet some more formatting cleanup! Nao in action :). And other pedantic stuff. (several files) [Bug 4505]
  * Moved CSS and JavaScript to top. (index template) [Bug 4468]
  ! Fixed an undefined variable in some cases (Subs.php) (Note from Nao: changed the code to avoid using an extra line.)
  ! Some actions were unnecessarily logged. (index.php) [Bug 4465]
  & Who's Online language strings were missing for some actions. (Who.php, Who language file) [Bug 4465]
Title: Re: New revs
Post by: live627 on October 17th, 2010, 11:33 PM
Quote from Nao/Gilles on October 17th, 2010, 04:40 PM
! Uppercase $_POST is duh.
You mean they were lowercase?
Title: Re: New revs
Post by: Arantor on October 17th, 2010, 11:33 PM
Nah, there was $_POST['ID_ADMIN'] or something similar IIRC in the PersonalMessage files.
Title: Re: Editor JS
Post by: Nao on October 18th, 2010, 05:19 PM
rev 220, 221, 222: http://wedge.org/?msg=249861

rev 223
- Removed validate_unicode__recursive entirely. (QueryString.php, Subs.php)
* Updated to SMF rev 10187. All of the changes are DB related, and most of them were already done in Wedge. (changelog.txt, upgrade.php, DbExtra.php, DbPackages.php, DbSearch.php)
  ! UTF8 fixes. Thank you, Nao! (Subs.php, Subs-Post.php) [Bug 4498]
  ! One more slight change, in supported versions. (install, upgrade, convert scripts)
  ! Now MySQL versions support ENGINE, so simplify some things. (several files)
  ! Escaping potential identifiers used as column names (DbExtra-mysql.php, DbExtra-postgresql.php) [Bug 4261]
Title: Re: Editor JS
Post by: Arantor on October 18th, 2010, 07:23 PM
Revision: 224
Author: arantor
Date: 18:21:43, 18 October 2010
Message:
+ Bad Behavior tests now part of the core (sorry for all the language strings, note also that not every BB test is included). Still needs a log viewer to be implemented, though.
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Errors.template.php
Added : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install_2-0.sql


Just to clarify; every intrusion attempt/bad hit is logged with enough details to be able to see what the issue is, and the error specifically encourages the recipient to ask the admin quoting the 'incident number' which is the id in the table. Sorry for the size of the commit but I wanted to get it all in one go.
Title: Re: New revs
Post by: Nao on October 18th, 2010, 09:16 PM
Oh my... An awful lot of code! Must have been painful to implement... Question time on the related topic!
Title: Re: New revs
Post by: Arantor on October 18th, 2010, 10:06 PM
It's still smaller than the original WTF-laden code :P
Posted: October 18th, 2010, 09:18 PM

Revision: 225
Author: arantor
Date: 21:05:57, 18 October 2010
Message:
! Fixed version of CIDR compare function. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 11:06 AM
rev 226 -- a.k.a. biggest one evah.
(And probably buggiest, too.)

* Updated to SMF rev 10205. Check out the changelog. (changelog.txt, index.php, Admin.php, Class-Editor.php, Load.php, ManagePaid.php, Profile.php, Subs-Boards.php, Subs.php, Who.php, install.css, Display.template.php, ManagePaid.template.php, MessageIndex.template.php, ManagePaid language, Who language, editor.js, script.js)

@ !!! Need to change $user_info['url'] etc. (index.php, Load.php)

@ !!! Added avatar and image caching, but mod_header is required, so leaving it commented out for now. (.htaccess)

+ Added support for merging double posts. Most of the magic happens in SplitTopics. (index.php, Admin.php, Display.php, ManagePosts.php, SplitTopics.php, Subs-Post.php, index.css, Display.template.php, Admin language, Errors language, index language, ManageSettings language, mergeposts.gif)

+ Added support for URL trimming. (ManagePosts.php, Subs.php, Admin language)

+ Added partial Pretty URLs feature. QueryString.php is awfully hardcoded and a WIP. Support for finding topics by name should be deleted or improved. (index.php, .htaccess, install_2-0.sql, readme_*.html, Admin.php, Display.php, Load.php, ManageBoards.php, ManageErrors.php, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, RemoveTopic.php, SplitTopics.php, Subs-Boards.php, Subs-PrettyUrls.php, Subs.php, SSI.php, Admin.template.php, admin.css, index.template.php, ManageBoards.template.php, Admin language)

- Removed queryless URL feature. (.htaccess, readme_*.html, repair_settings.php, smfinfo.php, ManageSettings.php, News.php, QueryString.php, Subs.php, Help language, ManageSettings language)

- Removed parameters in db_insert_id function. (install.php, Display.php, ManageBans.php, ManagePermissions.php, Poll.php, Post.php, Profile-Actions.php, Profile-Modify.php, RemoveTopic.php, RepairBoards.php, Security.php, SendTopic.php, SplitTopics.php, Subs-Boards.php, Subs-Calendar.php, Subs-Categories.php, Subs-Database.php, Subs-Graphics.php, Subs-Members.php, Subs-Post.php, Subs.php)

+ Added in boards table the preliminary structure for many upcoming features: per-board allowed and banned members, board owners, board type (should probably be called internally "board_type" rather than "wedge_type"), custom style, show title, per-board stats, per-board language. (install_2-0.sql)

+ Added more preliminary support for board owners. (Load.php:571+)

+ Added more preliminary support for per-board allowed and banned members. Need to implement a limit + group_concat, or just disregard multiple contradictory entries in the board_members table and rewrite code at line 714. (Load.php:576+)

+ Added very preliminary support for board privacy. (Load.php:633)

+ Added automatic creation date within the boards table. This could be useful in the future. (install_2-0.sql)

! Some default settings were applied to guests when they should have been applied to members instead. (install_2-0.sql)

* Changed some defaults at install time: week starting day (previously Sunday, now Monday), return to post, save PMs, display quick mod checkboxes, quick reply on and closed by default, view newest PMs first, remove inbox label when applying PM label, and show Today and Yesterday in dates. (install_2-0.sql)

* Increased post box size and board description box size. (Class-Editor.php, ManageBoards.template.php)

@ !!! bareimg placeholder. (Class-Editor.php)

@ !!! placeholders for {query_see_topic} (topic privacy) and a friend subselect override, which may or may not be rewritten later. (Subs-Database.php)

@ !!! placeholder for Ignore Topics. (Admin language)

+ Added support for align parameters in img tags. (Class-Editor.php)

* Don't fix url tags into a more developed version, there's no point in that using more space in the database. (Class-Editor.php)

* Disallow bots from accessing the Post template. Is this a good idea? (Display.php)

* If not on a forum, blog posters can't remove their own topics if not a moderator. Is that logical? I don't know. You tell me. I probably had a good reason for that. (RemoveTopic.php)

* Show bots in green italics in Who's Online. Noisen style. (Who.php)

+ Show board URLs next to topic links in Who's Online. Noisen style, too. (Who.php)

+ Added support for the 'more' BBC tag, which allows blog posts (upcoming feature) to be trimmed in the homepage, and shown in full in the dedicated post page. (Subs.php)

* Moved "Add Poll" button to the Topic Moderation strip, as currently there can only be one poll per topic and it changes their nature. (Display.template.php)

! Accidentally double-clicking a user name in topic pages when using the user menu could select said name. (Display.template.php)

! Unreverted a spacing commit I made for SMF that they reverted because they're bad people. I have your names, I'll tell your moms. (Display.template.php)

- This ":" in the Last Edit area has always annoyed me. (Display.template.php)

- Deleted a few remaining GD warnings from the language files. Please note that there are more GD-related tests that can be safely removed in plenty of places now. (Admin language)

! Fixed various errors in the French version. Also discovered the horror that is the EmailTemplates French translation. Oh, my... I'm nearly tempted to revert it back to English to save French users the agony of going through these emails. (EmailTemplates, Help, Login, Post, Profile)

+ Added French version of the Security language file. About half of it is translated for now... (Security.french.php)

* Spacinazi. (SplitTopics.php, MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 08:39 PM
rev 227

- Removed a couple of GD warning leftovers. (ManageAttachments.php, Register.php)
* Having some fun with subtle fade-in effects in non-IE6/7/8 browsers... (index.css, script.js)

Pete, can you have a look at the menu effect? I tested in Chrome, Opera 11 and IE6/8. Doesn't work in IE but doesn't break anything, either. I like the effect, but I'm a bit concerned that it could make it a bit TOO stylish at this point... You know, the more goodies you add, the less they stand out?
Title: Re: New revs
Post by: Arantor on October 22nd, 2010, 08:48 PM
I just ran through clean install - haven't checked any of the changes in either revs 226 or 227 but wanted to look at this quickly for you.

Installer has a much wider right margin than left now for some reason but more importantly:
Quote
Line #1603: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{db_prefix}pretty_urls_cache (
url_id varchar(255) NOT NULL,
replacement v' at line 1
Should be {$db_prefix} in the install script IIRC

:edit: So I fixed that in the installer, and get the following just on the last step (the 'do you want to delete the install files' one)
Quote
Notice: Undefined index: pretty_enable_cache in C:\Dev\public_html\smf_test\wedge\Sources\Subs.php on line 160

Notice: Undefined index: pretty in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Notice: Undefined index: db_count in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218


Going back to the original point, the fade-in looks nice, and I think I'm right in saying you moved the menus to left-align under the icon rather than the text? It's subtle and understated - I'd leave it as is personally.

Merging is broken - Admin > Posts > Merging gives:
Quote
Fatal error: Call to undefined function prepareDBSettingContext() in C:\Dev\public_html\smf_test\wedge\Sources\ManagePosts.php on line 421
Need to make sure ManageServer.php is included in the function.
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 09:04 PM
Quote from Arantor on October 22nd, 2010, 08:48 PM
I just ran through clean install - haven't checked any of the changes in either revs 226 or 227 but wanted to look at this quickly for you.
Thanks.
Quote
Installer has a much wider right margin than left now for some reason
That's probably because of the body { width: 90% } that the SMF team added very recently at the top of install.css. I left it as is but suspect it would only bring problems. Okay, I just launched the installer and -- wow -- it looks good with my css, eheh :) I removed width: 90% and replaced it with padding-top: 20px; looks better.
Quote
Should be {$db_prefix} in the install script IIRC
Indeed, sorry about that. Fixed. Whoever commits it first :P
Quote
Notice: Undefined index: pretty_enable_cache in C:\Dev\public_html\smf_test\wedge\Sources\Subs.php on line 160

Notice: Undefined index: pretty in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Notice: Undefined index: db_count in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218
Hmm... That probably means this requires initializing PURL first. (In the admin.)
I guess I'll have to do it in the installer, or something...
Quote
Going back to the original point, the fade-in looks nice, and I think I'm right in saying you moved the menus to left-align under the icon rather than the text? It's subtle and understated - I'd leave it as is personally.
Hmm, actually it's been like that since the day I added the icons. I used a padding trick to achieve that effect. It's totally different from the trick in use at wedgeforum.com, because this time I figured out how to do it in CSS rather than with tables :P
Quote
Merging is broken - Admin > Posts > Merging gives:
Quote
Fatal error: Call to undefined function prepareDBSettingContext() in C:\Dev\public_html\smf_test\wedge\Sources\ManagePosts.php on line 421
Hmm yeah I didn't test the admin area, only the actual merging (which is enabled by default apparently...)
Quote
Need to make sure ManageServer.php is included in the function.
Yup. Thanks for the feedback.
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 09:33 PM
rev 228
! Fixed broken installer. (install_2-0.sql)
! Fixed PrettyURLs warnings. (Subs.php, Subs-PrettyUrls.php)
* Improved installer styling. (install.css)
* catbg class wasn't using the same color as cat_bar. (index.css)
! Fixed double post merging admin area. (ManagePosts.php, Admin languages, ManageSettings languages)

Thanks Pete!
Title: Re: New revs
Post by: Nao on October 23rd, 2010, 10:46 PM
rev 229
* Put 31 of the BBC button images into a single sprite. Yay! (Class-Editor.php, editor.js, index.css)
+ Added Spoiler tag. (Subs.php, index.css, bbc/sprite.png, index language, Post language)
Title: Re: New revs
Post by: Nao on October 24th, 2010, 01:10 AM
rev 230
* Improved settings styling in admin area by separating setting titles from setting descriptions. (index.css)
* Spacinazi -- today, we remove all double spaces except from comments. (Plenty of files. Ouch.)
! Javascript error in admin error log when using the French version. Why isn't JavaScriptEscape used everywhere, eh? (Errors.template.php)
Title: Re: New revs
Post by: Nao on October 24th, 2010, 09:50 PM
rev 231
- Deleted unused "database filename" feature from SQLite leftovers. (install.php, Install files)
* Updated all files to reflect the change to the SMF 2.0 RC4 codebase.
* Spacinazi. (index.template.php)
* Updated to SMF rev 10242. At this point, isn't the data parameter in clean_cache('data') redundant? What else is left to delete, anyway?
  ! Reverting 10207 for Subs.php. Should be included only if it can be properly tested.
  ! Fixed webkit unexpected behavior when setting font styles (thank you Nibogo!) (editor.js) [Bug 4511]
  ! Allow nested [size] tags - we do allow them anyway, just not in all combinations (Subs.php)
  ! censor area should only be available to admins - reported by more, including KinG-InFeT.
  ! Package servers URLs and names properly cleaned for all circumstances - reported by KinG-InFeT.
  & Adapt a language string to the changes in SMF meta keywords. (Help.english.php) [Bug 4515]
  & Notify about PostgreSQL of older and newer versions not supported in the same database. (install language file) [Bug 4214]
  ! Language files are no longer cached. (Load.php, ManageMaintenance.php, ManageServer.php, Subs.php, Themes.php)
  & Remove the note about caching from all language files. (many files)
  ! Load English version of language files as a fallback for missing language strings. (Load.php) [Bug 2743]
  * Added a new group type, protected, for too powerful groups to be managed only by true admins. (Groups.php, ManageMembergroups.php, Profile-Modify.php, Subs-Membergroups.php, ManageMembergroups template, Profile template) [Bug 3528]
  & Added the new group type language string for the change above. (ManageMembers language file) [Bug 3528]
  ! Make sure Administrator group type is set to protected on install and upgrade. (install_2-0_*.sql, upgrade_2-0_*.sql)
  ! Making sure eol-style is on all files on other directory as well. (might have been missed) (/other files)
  ! Making sure eol-style is set on all our converters as well. (/other/converters ASCII files)

Well... Looks like the dev team got to work, eh!
I'm surprised they added such a feature as "protected membergroups"... It demanded a lot of code updates. Hopefully it isn't buggy...
Also, all of the files are updated because RC3 had to be changed to RC4.
Title: Re: New revs
Post by: Nao on October 24th, 2010, 11:52 PM
rev 232
* Replaced all reqWin(this.href) calls with reqWin(this), to make calls shorter and allow positioning the popup window next to the clicked link. (Plenty of files, script.js)
Title: Re: New revs
Post by: Arantor on October 25th, 2010, 08:03 PM
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.

Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.

Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
Title: Re: New revs
Post by: Nao on October 26th, 2010, 10:09 AM
rev 233
! Fixed undefined error in merge admin. (ManagePosts.php)
* Optimized index.css for size. "0.5em" becomes ".5em", "padding: 1px 3px 2px 3px" becomes "padding: 1px 3px 2px", things like that... Inspired by a CSS minifier. (index.css)
* Reverted hover color on main menu's top-level entries, to match the admin menu color. Too many different colors can be confusing... (index.css)
* Updated to SMF rev 10246.
  ! Fix for windows check (ManageServer.php)
@ Also in latest SMF revs: RC4 version updates, and smfinfo.php was updated to a new version... It doesn't work very well, though, failing notably at showing the current version, uh. Should probably remove that file from the svn entirely...
Quote from Arantor on October 25th, 2010, 08:03 PM
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.
I don't know, it adds plenty of code and it's slightly obscure... Well, at least on first look.
Sinan asked for beta testers to look into the addition. I'm afraid I can't bother...
Quote
Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.
I don't know... I couldn't even find the word 'censor' in the diff patch (?!), and the changelog doesn't specify which file was changed... (Good job!)
Quote
Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
clean_cache('data') might be worth mentioning, though...
But maybe we'll add more cache types later. CSS? Hmm...
Title: Re: New revs
Post by: Nao on October 26th, 2010, 12:29 PM
rev 234
* resize-handle.gif is a horribly wrong version... Seriously, 800+ bytes for that? Also reworked the 'picture' to suggest enlargement. (resize-handle.gif)
* Repositioned sprites so that the empty space is at the bottom right. (bbc/sprite.png)
+ Did I actually forget to commit edit.gif in the smiley list...? Maybe this should be a BBC button instead, though... (edit.gif)
! Fixed wrong resizer bar width on IE browsers. (editor_ie.css)
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 04:29 PM
Going back to the censoring, I seem to recall it's in either Admin or ManagePosts, where the permission is changed from moderate_board to admin_board.

For cache cleaning, there's a bunch of different things, primarily data_ and lang_ that get cached but I think there are more in the bowels of the system.
Title: Re: New revs
Post by: Nao on October 26th, 2010, 06:10 PM
Code: [Select]
'posts' => array('ModifyPostSettings', 'admin_forum'),
'bbc' => array('ModifyBBCSettings', 'admin_forum'),
'censor' => array('SetCensor', 'moderate_forum'),
'topics' => array('ModifyTopicSettings', 'admin_forum'),

This has been in both Wedge and SMF for at least the last month... I really don't see any changes in SMF RC4 in that respect!
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 07:10 PM
Is that Admin.php or ManagePosts.php?
Title: Re: New revs
Post by: Nao on October 26th, 2010, 07:17 PM
ManagePosts... The code that redirects to the respective tabs at the beginning.
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 07:25 PM
Well, there's an entry in the Admin menu, and IIRC there's another entry at the start of ManagePosts, but I can't remember off hand which is actually needed to be changed - if in doubt both should be set to admin_forum.
Title: Re: New revs
Post by: Nao on October 26th, 2010, 08:31 PM
All righty, in Admin.php:

Code: [Select]
'postsettings' => array(
'label' => $txt['manageposts'],
'file' => 'ManagePosts.php',
'function' => 'ManagePostSettings',
'permission' => array('admin_forum'),
'icon' => 'posts.gif',
'subsections' => array(
'posts' => array($txt['manageposts_settings']),
'bbc' => array($txt['manageposts_bbc_settings']),
'censor' => array($txt['admin_censored_words']),
'topics' => array($txt['manageposts_topic_settings']),
'merge' => array($txt['manageposts_merge']),
),
),

So, apparently one needs to have admin_forum to access all of these tabs...
Which means ManagePosts is buggy in that respect.

:edit:

http://dev.simplemachines.org/mantis/view.php?id=4520
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 09:14 PM
Wouldn't that imply that ManagePosts doesn't even need to be checking at all? (Or indeed, any of the other files within the admin area)

This isn't a trivial thing to change, because it's either being checked twice and Admin.php holds all the keys to the kingdom (and everywhere else can drop the secondary checks) - or Admin.php simply checks it for the menu and each file is still responsible for its own permissions (much as SMF 1 used to do)
Title: Re: New revs
Post by: Nao on October 26th, 2010, 09:36 PM
Yeah, I was wondering the same... Maybe the report will clear this up.

rev 235
! Fixed htaccess by making sure mod_headers is enabled before we try to rewrite headers. (.htaccess)
! Forgot to apply group_type to membergroups table at install time. (install_2-0.sql)
+ Added support for the following pretty URLs: /topic_id/topic_name/page_number/, /year/month/day/, /cat/category_name/, /tag/tag_name/, and /board_page/ (QueryString.php)
Title: Re: New revs
Post by: Nao on October 26th, 2010, 10:09 PM
rev 236
* Updated to SMF rev 10247.
  ! A safer handling of the database last error and generally writing Settings.php [Bug 4222]

--> Mainly it moves db_show_error to Errors.php... I updated the docs, hopefully it's okay.
Now db_fatal_error() is 100% an alias. Norv forgot to remove the $sourcedir global, I finished that.
There's a @todo in there. Yeah, the function could be removed, but... mods, maybe?
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 10:12 PM
I don't know any mods that modified that (not even mine), since really any errors should be funnelled through fatal_*_error or trigger_error if you're doing something funky. No need to worry about such changes affecting mods :)
Title: Re: New revs
Post by: Nao on October 27th, 2010, 12:07 AM
rev 237
- Deleted db_fatal_error(), as it was no longer used. (index.php, Errors.php, Load.php, Subs-Database.php)

I double-checked, and there was no such "or db_fatal_error()" occurrences in the code, even though that's mentioned in the SMF source files...
Title: Re: New revs
Post by: Arantor on October 27th, 2010, 12:27 AM
It may well have been like that once upon a time.

It would be worth forcing the conditions that would otherwise cause it to trigger that error (certain DB connectivity issues) just to prove it doesn't abort inappropriately.
Title: Re: New revs
Post by: Nao on November 2nd, 2010, 01:13 PM
I figured I should commit whatever I have that isn't related to CSS variants... It'll be easier for me in the longer term because I don't know when I'll be ready to commit.

rev 238

* Renamed install and upgrade scripts to drop the version number, as Wedge is 1.0, not 2.0. (install.php, install.sql, upgrade.php, upgrade.sql)
- Removed most of the credits. Technically, these names have nothing to do with our project... (Who.php, Who.template.php)
* Updated to SMF svn 10260. There are still a couple of revs to catch up with...
  ! Last minute: boards incorrectly retrieved (Subs-Boards.php, Load.php) (NB: Load.php not done yet.)
  ! Last minute: an incorrect warning (Profile-Actions.php)
  ! Last minute: adding SMF favicon. (favicon.ico)
  * Validation errors due to a typo in themes list (Themes template) [Bug 4505]
  ! On some versions of Opera the cursor wasn't displayed in WYSIWYG editor (thanks TE) [Bug 4521]
  ! Clean the entire cache on the disk, if any, during scheduled maintenance (ScheduledTasks.php)
  ! Small addition to clean_cache() documentation (Subs.php)
  ! Manage Posts area should only check for admin_forum permission. (ManagePosts.php) [Bug 4520]
  * Undefined index in Subs.php for Core theme (Display template)
Title: Re: New revs
Post by: Nao on November 5th, 2010, 09:14 AM
rev 239

@ The big "theme stylings" initial commit!
@ todo: remove support CSS variants to avoid confusion? Make sure caching is solid (has flush option, fixes folder rights, etc.) Maybe separate theme entries from styling entries with Javascript in ManageBoards. Allow choosing a styling for non-board pages, too! (via $modSettings)
+ Added support for stylings and added two sample stylings. (install.sql, Class-Editor.php, Load.php, ManageBoards.php, Subs.php, Subs-Boards.php, css/index.css, index.template.php, ManageBoards.template.php, css/cache, css/Green/*, css/Nix/*)
+ Added support for gzipped CSS files. (.htaccess)
+ Store current user agent in $context['browser']['agent'] for later use. (Load.php)
* More SMF svn fixes. This will be my last batch, since SMF no longer want us to be able to stick to their codebase. (Class-Editor.php, Load.php)
! Fixed undefined error. (ManageAttachments.php)
! Pretty URLs really need some fixin'... (QueryString.php, Subs-Boards.php)
* Merged mergeposts.gif button into quickbuttons.png sprite file. (css/index.css)
* Spacinazi. (Load.php, Subs.php, Themes.php)

PS: forgot to mention Subs.php being modified by the styling feature in the svn changelog. Adding it here...
Title: Re: New revs
Post by: Arantor on November 5th, 2010, 09:57 AM
Some kind of separation is needed since the idea is to detect which file to run by looking for a file with the same name as the action, and I don't really want to have to give it rules like not firing on Load/QueryString/Manage*/Subs-*/etc
Title: Re: New revs
Post by: Nao on November 5th, 2010, 12:17 PM
The more we do to fix sMF, the more we realize we have to do if we are to follow our instincts. <sigh>
Title: Re: New revs
Post by: Arantor on November 5th, 2010, 12:20 PM
Of course, the corollary: the more we follow our instincts, the further we get from SMF's lock-down mentality.
Title: Re: New revs
Post by: Nao on November 5th, 2010, 06:43 PM
rev 240
! A misplaced "}" broke board identification if Pretty URLs were disabled. (QueryString.php)
! Couldn't disable Pretty URLs once enabled. (ManageSettings.php, Admin.template.php)
Title: Re: New revs
Post by: Nao on November 5th, 2010, 07:14 PM
rev 241
! Don't show the Pretty URLs area if you're editing a board with Pretty URLs disabled... (ManageBoards.php, ManageBoards.template.php)
! Could possibly keep using Pretty URLs even if it was disabled in the admin. (QueryString.php)

PS: leave rev 242 to me, it's one of my lucky numbers :P
Title: Re: New revs
Post by: Arantor on November 5th, 2010, 09:27 PM
Go for rev 242 :) I haven't started the changes yet due to other stuff going on.
Title: Re: New revs
Post by: Nao on November 5th, 2010, 09:34 PM
It's a scam!

rev 242
* Replaced » with a graphic arrow in the linktree. It sucks and may not work outside of Opera, but I wanted to have rev 242. Mwahaha. Okay, I'll take my pills. (index.css, index.template.php)
+ Placeholder for theme styling in themes table. (install.sql)

Seriously, this 242 isn't linked to 42 or anything... It's just that it was the length in kilobytes of the scrolltext I wrote for a music compilation back in 1990... It was the world record and I think it never was broken. Unfortunately that screen never found itself featured in a demo disk AFAIK... But I got to show it off in a few coding parties, including the legendary STNICCC. Ah ah, good times. Too bad I've lost said demo!

Also up to post #1500 at the same time, eh eh.
Title: Re: New revs
Post by: Arantor on November 6th, 2010, 01:25 AM
Chrome no like the gzipped CSS file :( Just comes up without any styles at all (though ?board=1 works now, haha)
Posted: November 6th, 2010, 12:02 AM

Revision: 243
Author: arantor
Date: 00:12:33, 06 November 2010
Message:
! First batch of conversions of splitting some actions into their own files (index.php, Admin.php, MessageIndex.php, Post.php, Register.php, SplitTopics.php, Who.php, Activate.php, CoppaForm.php, Credits.php, QuickMod.php, QuoteFast.php)
----
Added : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/CoppaForm.php
Added : /trunk/Sources/Credits.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Sources/QuickMod.php
Added : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on November 6th, 2010, 07:25 AM
Quote from Arantor on November 6th, 2010, 01:25 AM
Chrome no like the gzipped CSS file :(
It should... I tested it in Chrome (stable), too. Are you sure you enabled the .htaccess file? It has an updated rule.
In any case, I'll add a setting to the db to enable it or not -- and it'll be disabled by default, just like PHP gzipping. I just postponed it because it requires adding an $helptxt or something, and I hate writing docs. (Because I have to do it twice... Once in French, once in English.)
Quote
! First batch of conversions of splitting some actions into their own files (index.php, Admin.php, MessageIndex.php, Post.php, Register.php, SplitTopics.php, Who.php, Activate.php, CoppaForm.php, Credits.php, QuickMod.php, QuoteFast.php)
Oh oh! I'll have a look!
Title: Re: New revs
Post by: Arantor on November 6th, 2010, 08:26 PM
In Chrome beta it just ignored it. I did see the .htaccess file (and it should be being copied with the installation) but I'll double check.

The first batch is simply moving some functions around and making some files - there's little in the way of dependencies there, unlike so many other things :(
Title: Re: New revs
Post by: Nao on November 7th, 2010, 05:42 PM
rev 244

* Changed default DB table prefix to wedge_, to make sure Wedge can be installed next to a vanilla SMF install. (install.php)
! php_value/php_flag aren't supported in CGI PHP. (.htaccess)
* Minor details. (index.css, Admin.french.php)
Title: Re: New revs
Post by: Arantor on November 9th, 2010, 06:10 PM
Revision: 245
Author: arantor
Date: 16:59:29, 09 November 2010
Message:
! More of the function/action rearranging (Admin.php, Post.php, Post2.php, Printpage.php, Register.php, SMStats.php, Spellcheck.php, Stats.php, Subs-Editor.php, Subs-Post.php, Subs-Sound.php, Suggest.php, VerificationCode.php, ViewSMFile.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Register.php
Added : /trunk/Sources/SMStats.php
Added : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Sound.php
Added : /trunk/Sources/Suggest.php
Added : /trunk/Sources/VerificationCode.php
Added : /trunk/Sources/ViewSMFile.php
Modified : /trunk/index.php

(And index.php got modified too, of course. I'm getting closer to where I want to be with this. Not there yet though.)
Title: Re: New revs
Post by: Nao on November 9th, 2010, 06:58 PM
I was wondering... Wasn't the point of these changes, putting the files into a \Sources\Admin folder?
Or do you prefer to have plenty of files in one place, and not have to go through several folders when updating some code?



rev 246

+ Added setting to enable CSS compression. Disabled by default. (ManageServer.php, Subs.php, Help language, ManageSettings language)
* Updated footer copyright to the new URLs, and disabled copyright check because, why bother. (Subs.php, index language)
Title: Re: New revs
Post by: Arantor on November 9th, 2010, 06:59 PM
I'm just splitting them up into the relevant actions first, is a bit easier that way to rearrange later.
Title: Re: New revs
Post by: Nao on November 9th, 2010, 07:39 PM
Gotta go, no time to check my commit thoroughly... Please have a quick look!

rev 247
* Generate non-gzipped cached files for user agents that don't support gzipping. (Subs.php)
- I'm a big fan of Grandia and Terranigma myself, and it hurts to delete that Easter egg, but I'd rather not waste cycles in a regularly called function, thank you. (Spellcheck.php)
Title: Re: New revs
Post by: Arantor on November 9th, 2010, 10:33 PM
Revision: 248
Author: arantor
Date: 21:32:53, 09 November 2010
Message:
- Remove getLastPost() which does not seem to be have been called anywhere in the source (even in RC3 or RC4) (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Title: Re: New revs
Post by: Nao on November 9th, 2010, 11:42 PM
Actually, getLastPost() was already in the code as of SMF 1.0 beta 4 (!), and never used, even at the time.
My *guess*, is that it was written for modder convenience.
But honestly -- that kind of undocumented helper function isn't gonna help anyone. Because anyone with half a brain would write the function themselves instead of spending an hour trying to find an hypothetical function that does what they want.
Title: Re: New revs
Post by: Arantor on November 10th, 2010, 02:11 AM
:o That's what I call a WTF then.
Posted: November 9th, 2010, 11:48 PM

Revision: 249
Author: arantor
Date: 00:20:10, 10 November 2010
Message:
! More of the reshuffle, splitting Recent.php up... including breaking the one function into two files for unread/unreadreplies, I don't think I broke anything with it though it definitely could be harmonised by finding common code and making a Subs-Unread.php file (index.php, Recent.php, Unread.php, Unreadreplies.php)
----
Modified : /trunk/Sources/Recent.php
Added : /trunk/Sources/Unread.php
Added : /trunk/Sources/Unreadreplies.php
Modified : /trunk/index.php

Posted: November 10th, 2010, 01:20 AM

Revision: 250
Author: arantor
Date: 01:04:17, 10 November 2010
Message:
! Harmonsied some function names with filenames/actions: Download became Dlattach, Admin.php's AdminMain became Admin (Dlattach.php, Admin.php, index.php)
! More of the cleanup (Post.php, JSModify.php, index.php)
+ Some actions now identify they should not be logged through defining WEDGE_NO_LOG (index.php, Dlattach.php, SMStats.php, VerificationCode.php, ViewQuery.php, ViewSMFile.php)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/Dlattach.php (Copy from path: /trunk/Sources/Download.php, Revision, 247)
Deleted : /trunk/Sources/Download.php
Added : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on November 10th, 2010, 08:11 AM
Yeah, a WTF indeed...
Thanks for finding that kind of WTF, btw. I'm lagging in terms of codebase knowledge, and because you're moving everything around, it's not going to be better soon eheh.
Title: Re: New revs
Post by: Arantor on November 10th, 2010, 12:32 PM
That's one of the benefits of going through and breaking the files up, you get to find where the function dependencies are.
Title: Re: New revs
Post by: Nao on November 10th, 2010, 03:06 PM
Sure is!
Title: Re: New revs
Post by: Nao on November 10th, 2010, 04:01 PM
Was unrelated until now, but since this will probably all find its way into Wedge... Here's the Aeva Media latest rev changelog, eheh :)

rev 11

+ Added transparency flag to pictures, and functions to determine transparency. (db_aeva.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs.php, Aeva.template.php)
* Changed album page layout to show only thumbnails and titles, and hide the rest, which will instead appear in a popup when you hover over the thumbnail or title. (Aeva-Subs.php, am.css)
* Instead of just kilobytes, show filesize in bytes, kilobytes or megabytes in item pages. (Aeva-Gallery.php, Aeva.template.php)
+ Added a function to hide/show popups in IE6. (Aeva-Subs.php, am.js)
! Fixed error when deleting a comment. (Aeva-Gallery.php)
! Fixed animated GIFs shown at incorrect sizes when using ImageMagick. (Aeva-Media.php)
Title: Re: New revs
Post by: Nao on November 10th, 2010, 08:25 PM
rev 251

! $modSettings['pretty_enable'] didn't actually exist, so it screwed up a lot of Pretty URLs code... (ManageBoards.php, QueryString.php, ManageBoards.template.php)
! Fixed some styling. (ManageServer.php, ManageSettings.php, index.css)
! Foolishly trying to make all browsers like each other when showing popups. Sob. (script.js)
+ Added placeholder about a "Wedge license"... Need to setup an URL and actually put something there. (script.js)
Title: Re: New revs
Post by: Nao on November 12th, 2010, 05:40 PM
rev 252

! In case guests can post to topics, make sure they return to the topic after they posted. (install.sql)
* Renaming hook-related functions and variables. Integration functions become call/add/remove_hook for simplicity reasons. Hooks are renamed from $modSettings['integrate_something'] to $modSettings['hooks']['something'], and are now proper arrays. Finally, SMF_INTEGRATION_SETTINGS is renamed to WEDGE_HOOK_SETTINGS. So what? (index.php, Activate.php, Admin.php, Class-Editor.php, Errors.php, Load.php, LogInOut.php, ManageMembers.php, Profile-Actions.php, Profile-Modify.php, Profile.php, Register.php, Reminder.php, Security.php, Subs-Auth.php, Subs-Members.php, Subs-Post.php, Subs.php, Who.php, Display and MessageIndex templates)
* Made sure that the error message can be tampered with by the output_error hook. Otherwise, it's relatively useless. (Errors.php)
* Given that the outgoing_email hook has permission to tamper with e-mail data, personal_message and create_topic hooks should be able to play around with their data, too. Same with $data in the change_member_data hook in updateMemberData. (Subs.php, Subs-Post.php)
Title: Re: New revs
Post by: Arantor on November 12th, 2010, 05:46 PM
Regarding the last change, I haven't looked yet, but I seem to recall that outgoing_email occurs before the email is sent, but the PM and create topic hooks happen after the PM is sent/topic is created...?

/mewill review in a minute, just trying to dry off after going out in the rain to get fixings for dinner...
Title: Re: New revs
Post by: Nao on November 12th, 2010, 05:55 PM
Hmm yeah I didn't notice that but if you're saying so it's probably right!
I made a mistake anyway when I complained about reset_pass, I think that it's never passed as a ref...
Title: Re: New revs
Post by: Nao on November 13th, 2010, 04:42 PM
rev 253

* Renaming Wedge 1.0 Alpha to SMF 2.0 RC4 (Wedge 0.1), for as long as the BSD licensing is not official. (index.php)
! Clearly separated temporary from permanent hooks. (Load.php, Subs.php)
* The reqWin function will now open an iframe instead of a popup window. It's less aggressive and it's cooler. Also, it now properly positions it. (Help.template.php, script.js)

PS: reqWin was tested under Opera, not other browsers though... It may not work elsewhere. I'm quite happy with the current results, although we may want to go Ajax on this, so that we can add cool animations and show/hide on hover...
Title: Re: New revs
Post by: Nao on November 14th, 2010, 08:54 PM
rev 254

* Renamed "Wedge Default theme" to just "Wedge"... If we call our main theme "Wedge", people will understand that it's the default theme, right? Right? (Install.english.php, Install.french.php)
! Fixed a XML bug reported by live627. Thanks! (Subs.php)
* Reworked the theme/styling selector to better emphasize the overall hierarchy. (ManageBoards.template.php, admin.css)
Title: Re: New revs
Post by: Nao on November 14th, 2010, 10:40 PM
rev 255

* Renamed "package" to "add-on", "package-info" to "addon-info", "paquet" (French) to "extension", "modification" to "code add-on", etc. (tools/package/modifications/*, PackageGet.php, Packages.php, Subs-Package.php, language files in English and French: Admin, Errors, Help, index, Install, ManagePermissions, ManageSettings, Packages, Who)

Just to be clear... I only renamed these where the user has interaction with them. Internally, I didn't rename anything, because there are 2500+ occurrences of "package", and it's not ALWAYS related to actual add-ons...
If you want to do it, Pete, feel free, but our efforts should be focus on more important things.
Still, I'd like to see /Packages/ renamed to /Addons/. Would be nice.
BTW, I used "Extension" for French. It looks cool.
Posted: November 14th, 2010, 09:48 PM

rev 256

* A few more renames I forgot. (Admin.*.php, Help.*.php, ManageSettings.english.php, Packages.*.php, Who.french.php)

(I just hope I didn't rename anything that shouldn't have been.)
Posted: November 14th, 2010, 09:57 PM

rev 257

* Found better entities for representing theme hierarchy. I was dying to commit that. (ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on November 15th, 2010, 11:20 AM
rev 258

* Moved CSS cache folder to the theme folder's root. (Subs.php)
* Replaced Wedge logo with a simpler one. (wedgelogo.png)
+ Added a help description for the styling selector. (ManageBoards language files)
* Spacinazi is adding a useless space, for once. It's just to make large hierarchies readable in Opera... (ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on November 15th, 2010, 03:16 PM
rev 259

+ Added hooks for copyright management ('place_credit'), and Pretty URL manipulation ('determine_location'). (Credits.php, QueryString.php)
- Removed the "orignal" txt strng, as it was emty in the fist plce. (Who.englsh.php, Who.frnch.pp)
Title: Re: New revs
Post by: Nao on November 16th, 2010, 11:30 PM
rev 260

+ Added support for compressed JS files, just like CSS files but with different syntax. (.htaccess, Load.php, ManageServer.php, Help language, ManageSettings language)
* Moved all Display and Editor javascript to the footer, including some inline code that was in the header. (Class-Editor.php, Display.template.php)
+ Added wedge_add_css and wedge_add_js functions to make life easier. (Load.php, Subs.php)
+ Added a short copyright notice in the HTML source code, to have a signature left when people will remove the onscreen credits. (index.template.php)
! Fixed mixup between default theme and current theme when looking for CSS folders. (Subs.php)
! Started adding missing semicolons that would make the JS minifier fail. (editor.js, script.js)
@ JS minifier is a work in progress. Can't account for all lazy Javascript coders putting some strange code in... (Subs.php)
Title: Re: New revs
Post by: live627 on November 16th, 2010, 11:50 PM
I always wondered why some JS lacked a semicolon appended to the line.. It certainly works to go the PHP way and use a semicolon EVERYWHERE (and easier too!)
Title: Re: New revs
Post by: Nao on November 17th, 2010, 11:48 AM
Absolutely.
I'm tempted to add them everywhere (in prototype definitions) and then force users to use them as well, by failing to compile their JS if they don't.
Title: Re: New revs
Post by: Nao on November 17th, 2010, 07:23 PM
Okay, I'm committing, hopefully you can look into my code changes and my remarks in the changelog....

rev 261

! Trying to add support for .jgz and .cgz for Safari, but even if just using uncompressed .css, it doesn't seem to work on Safari 5.0.2... Needs some further research! (.htaccess, Subs.php)
* Moved the rest of the common Javascript to the bottom of the page. IE6 pawa. (index.template.php)
+ Started replacing onclick events with a neat trick I devised, to prevent UI clicks before the scripts are actually loaded. (Okay, I'm proud of myself, so what. Go away. I'm the only reading these changelogs anyway.) (Display.template.php, script.js)
! SMF bug: <span id="top_subject"> was missing, causing quick edit to fail on first topic posts. They don't want me as beta tester so I'll just let them find out by themselves. Ah ah. (Display.template.php)
* The user menu didn't return specific values, so return false anyway, so save a few bytes in the Display template. (topic.js, Display.template.php)
! User menu failed when clicking a guest account. (topic.js)
! Syntax error. (RemoveTopic.php)
! Whatever you put into onclick, it's *already* in Javascript... No need to specify it is! (Post.template.php, Display.template.php)
* Spacinazi on addPollOption. Why is that function duplicated anyway?! Should be changed... (Poll.template.php, Post.template.php)
Title: Re: New revs
Post by: Nao on November 17th, 2010, 09:58 PM
rev 262

! It would be a shame to break w3c validation just for this... Changed the lang trick to use comments instead. So, basically, move your onclick code, unmodified, to a comment immediately after the target element, and add a clickme class to that element. (Display.template.php, index.template.php, script.js)
- Removed a few nbsp's from Javascript confirm boxes. (index.french.php)
+ Finished French translation of the new Security language file. Hopefully... (Security.french.php)

Tested the comments trick successfully on Opera 9.62 (I figured it'd be more representative than v10.6x), Safari 5.0.2 (which BTW now seems to accept my CGZ files... Don't ask me), and IE8. It should be a tad slower than the lang version, but only because it retrieves firstChild and then possibly nextSibling.
Title: Re: New revs
Post by: live627 on November 17th, 2010, 11:28 PM
Quote from Nao/Gilles on November 17th, 2010, 07:23 PM
! SMF bug: <span id="top_subject"> was missing, causing quick edit to fail on first topic posts. They don't want me as beta tester so I'll just let them find out by themselves. Ah ah. (Display.template.php)
grep -nHIi -- top_subject (in directory: /var/www/smf_dev/Themes/default)
Help.template.php:663:               <span id="top_subject">', $txt['manual_topic_heading'], '</span>
Search completed with 1 match.

Need I say more? :P
Title: Re: New revs
Post by: Nao on November 18th, 2010, 12:08 AM
Yes you do...

It stayed in the Help template, yes (the one which we removed from Wedge), but it's only an example page, it's not the proper Display page.
Just compare RC3 to RC4's Display template. The top_subject went away ;)
They can remove it if they want... But then they should remove any code that manipulates it!
Title: Re: New revs
Post by: live627 on November 18th, 2010, 01:06 AM
So in other words they removed code but not completely... heh, so typical of them. <PRV>
Title: Re: New revs
Post by: Nao on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Title: Re: New revs
Post by: Nao on November 18th, 2010, 02:32 PM
Quote from Nao/Gilles on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Any reason why you're blatantly ignoring me...?

I could use some of your hindsight, really.
Title: Re: New revs
Post by: Arantor on November 18th, 2010, 02:59 PM
I'm not ignoring you - I really just haven't had time to keep up with everything :(
Title: Re: New revs
Post by: Nao on November 18th, 2010, 03:26 PM
Sorry, bit tired here. Already 24 hours spent on making sure I can move all JS code to the bottom...
I said that because you've been here a lot today, and you didn't answer my questions... :P
Title: Re: New revs
Post by: Arantor on November 18th, 2010, 03:28 PM
Wouldn't call it 'a lot' - I'm still reading everything, but it's hard to get everything straight. First thing I'll be doing when I get back from town will be reading through the last few commits, and then back through the discussions on the JS stuff.
Title: Re: New revs
Post by: Nao on November 18th, 2010, 04:33 PM
You should do your checks quickly, because I'll probably be moving the theme to HTML5 ASAP, meaning you'll have meaningless code to check in addition to proper code... It's best to first check proper code, and then just skim quickly through the meaningless HTML5 upgrade.

(BTW: XHTML5, right? I'm not interested in changing the /> stuff anyway... I learned to like them.)
Posted: November 18th, 2010, 04:17 PM
Quote from Nao/Gilles on November 18th, 2010, 04:17 PM
skim quickly through
Skim over or scan through... I'm always bad with prepositions.
Title: Re: New revs
Post by: Arantor on November 18th, 2010, 04:36 PM
Makes no odds to me, I still look through commit by commit as I always do.

As for X/HTML, I actually have no preference - whatever works is fine with me. Browsers interpret it fairly well these days.
Title: Re: New revs
Post by: Nao on November 18th, 2010, 05:11 PM
rev 263

* Moved storeCaret() from editor.js to PHP, as it's too short to bother waiting for editor.js to finish loading... (Class-Editor.php, editor.js)
* Replaced existing onclick hacks with a new trick that is cleaner but requires moving templates to HTML5. We would have had to do it at one point anyway... (Class-Editor.php, Display.template.php, script.js, index.template.php, Poll.template.php, Post.template.php)
* Spacinazi. (PrettyUrls-Filters.php)
Title: Re: New revs
Post by: Nao on November 18th, 2010, 05:48 PM
rev 264

* Wedge is now officially using HTML5. (index.template.php)
* Fixed footer indentation. (Class-Editor.php, Display.template.php, index.template.php)
+ Added placeholder function for manipulating external links. @todo: Fix domain name detection, or remove the function. (script.js)
! HTML5 compatibility in Footnotes. (Subs.php)
! Horrible typo. (script.js)
Title: Re: New revs
Post by: live627 on November 18th, 2010, 10:48 PM
Quote from Nao/Gilles on November 18th, 2010, 02:32 PM
Quote from Nao/Gilles on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Any reason why you're blatantly ignoring me...?

I could use some of your hindsight, really.
Know that I'm still offering my help  - that is, if you are wanting someone other than Pete to join the fray :)
Title: Re: New revs
Post by: MultiformeIngegno on November 18th, 2010, 11:05 PM
Quote from Nao/Gilles on November 18th, 2010, 05:48 PM
* Wedge is now officially using HTML5. (index.template.php)
:yahoo: :cool:
Title: Re: New revs
Post by: Arantor on November 19th, 2010, 03:12 AM
OK, back to business. I've taken too long out working on this paid project, I need time to recover!

So... reviewed all the changes (holy crap, there's been a lot of commits in the last 9 days), nothing huge is jumping out at me, I did fix a change in the code docs though, SMF_HOOK_SETTINGS vs WEDGE_HOOK_SETTINGS. Also, now we're listing JS files and there seems to be changes to the list of included stylesheets if I'm not mistaken (bearing in mind loadTemplate can load stylesheets), we probably should fix up the debug info in ViewQuery.php.

I'm looking at building the new DB class first though.



Revision: 265
Author: arantor
Date: 01:20:29, 19 November 2010
Message:
! Minor doc fix (Load.php)
----
Modified : /trunk/Sources/Load.php

Posted: November 19th, 2010, 02:23 AM

Revision: 266
Author: arantor
Date: 02:11:21, 19 November 2010
Message:
! Remove legacy case-sensitivity parameter from DB processes (Subs-Database.php, LogInOut.php, Subs-Auth.php, Subs-Post.php)
----
Modified : /trunk/Sources/LogInOut.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Post.php

Posted: November 19th, 2010, 03:11 AM

Revision: 267
Author: arantor
Date: 02:12:34, 19 November 2010
Message:
! More legacy parameters not used in the DB subsystem. (Subs-Database.php)
----
Modified : /trunk/Sources/Subs-Database.php
Title: Re: New revs
Post by: Nao on November 19th, 2010, 11:21 AM
Aeva Media rev 12 (<-- since it'll soon be merged with Wedge)

! Adding proper UTF8 handling in htmlspecialchars when editing custom fields, showing RSS feeds, errors and item titles. Also when showing SMG code (is that useful, really?) (Aeva-Admin.php, Aeva-Foxy.php, Aeva-Media.php, Aeva-Subs-Vital.php, Aeva-Subs.php)
- Removed Noisen copyright from auto-embedder code. This is ONLY for AeMe2 and Wedge! (Aeva-Embed.php)
+ Added an extra field to Exif data... Not that it's of any interest. Should really update that Exif library at some point. (Aeva-Exif.php)
* More improvements to visual details. (am.css, am.js)
Title: Re: New revs
Post by: Nao on November 19th, 2010, 04:41 PM
rev 268

* Remove registered hooks that no longer exist. (e.g. file was deleted after uninstalling an add-on.) Hopefully this is the right thing to do... (Load.php, Subs.php)
* Continuing HTML5 conversion, introducing cellspacing and cellpadding replacement classes. (Subs.php, ViewQuery.php, Calendar.template.php, index.css, GenericList.template.php, Memberlist.template.php, Register.template.php, Reports.template.php, Stats.template.php)
* Moved more JS inline code to the footer. (Post.template.php, Stats.template.php)
* Indenazi. (Calendar.template.php, Post.template.php, Register.template.php, Stats.template.php)
! For an unknown reason, HTML5 doesn't play well with the quick icon selector's padding on hover. (script.js)
Title: Re: New revs
Post by: Nao on November 20th, 2010, 09:25 AM
rev 269

* Converted two more files. (Calendar.template.php, Post.template.php)
* Started work on PM template -- need to move inline scripts to the footer. (PersonalMessage.template.php)
+ Added workaround for IE6 table borders and HTML5 tags. (ie6.css, index.template.php)
- Started deleting type="text/javascript" references. Thanks HTML5! (Class-Editor.php)
* Replaced context-type meta tag with meta charset. Thanks HTML5! (index.template.php)
! Calendar design was broken. (index.css)
! HTML5 validation no longer allows numeric entities in the C1 range, so turned … into &hellip; (Admin.french.php, ManageMaintenance.french.php, Post.english.php, Post.french.php)
! SMF bug: error message in Post template was shown with two <dt>'s rather than a <dt><dd> pair. (Post.template.php)
! SMF bug: File-type inputs don't accept a size parameter. (Post.template.php)
Title: Re: New revs
Post by: Nao on November 20th, 2010, 09:45 AM
rev 270

! data-on* trick didn't work on anything else than data-onclick. (script.js)

"Oops! Infinite loop."
Was due to a last minute change in variable names and I didn't change it everywhere... As a result, my thread was running at 100% because I had a tab set on a page with this code running. Uh. Opera is very powerful, but it could be a little helpful and offer me to warn me when a script is in an infinite loop... Even IE does... Because it seriously impaired my work yesterday.
Title: Re: New revs
Post by: Nao on November 20th, 2010, 04:41 PM
rev 271

* A few more data-on* conversions and JS fixes. (Groups.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMembergroups.php, ManageMembers.php, ManageSearchEngines.php, ManageServer.php, ManageSmileys.php, Modlog.php, Profile-Modify.php, Subs-Package.php, Subs.php, Calendar.template.php, GenericMenu.template.php, index.template.php, ManageMaintenance.template.php, MessageIndex.template.php)
* The VERY boring, extremely DULL, but totally PRICELESS JavaScriptEscape mega-update. All occurrences of confirm() now sport a proper JSE call that prevents broken scripts. Thank you for that superb bug, SMF, and you can keep the change. (Groups.php, ManageAttachments.php, ManageBans.php, ManageBoards.php, ManageMail.php, ManageMembers.php, ManagePaid.php, ManageSearchEngines.php, ManageSmileys.php, ModerationCenter.php, TEMPLATES: Admin, Calendar, Display, ManageAttachments, ManageBans, ManageBoards, ManageMaintenance, ManageMembergroups, ManageNews, ManageSearch, ManageSmileys, MessageIndex, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Recent, Search, Themes, LANGUAGES: Admin, index, ManageBoards, ManageMail, ManageMaintenance, ManageMembers, ManagePaid, ManageSettings, ManageSmileys, ModerationCenter, Packages, PersonalMessage, Search, Themes)
* Commenazi. (Subscriptions-PayPal.php)
Title: Re: New revs
Post by: Nao on November 20th, 2010, 05:12 PM
rev 272

! Fixed PIE bug that prevented it from being called from the header. (PIE.htc)
- Deleted two unused language strings. Unless I'm wrong?! (ManagePermissions.english.php, ManagePermissions.french.php)
* French version was using a misleading translation for "template" in the Themes file. (Themes.french.php)
* Some extra fixes to the JavaScriptEscape mega-update. (I'm not gonna list all of the files again!)

I think I'm done for JSE... Finished with alert() and confirm(), at least.
There are plenty more occurrences of the "use/don't use entities" comment in language files, that we REALLY need to look into. Either they're already gone (i.e. entry was deleted from Curve, but not from the language files), or they're for e-mails (in which case we can't do much except make an EmailEscape function), or they shouldn't be here.
Title: Re: New revs
Post by: MultiformeIngegno on November 20th, 2010, 05:37 PM
Wow! Awesome work!
Title: Re: New revs
Post by: Nao on November 21st, 2010, 12:42 AM
Thanks :)
I'm not finished, unfortunately... I just took a break after I finished the JSE portions (I'm also trying not to overwhelm Pete with code to verify...)
I still have to finish the data-* implementation, *and* convert all templates... Most notably drop all of the old params (align, valign, cellspacing, cellpadding, type...), and... I don't remember the rest, I'm too tired. Good night!

rev 273

! Implemented a quick hack to fix menus not working in IE6 since rev 260. I have no idea why this fixes it, but it does, so let's shoot first and ask questions later. (index.template.php)
* Indenazi. (BoardIndex.php)
Posted: November 21st, 2010, 12:24 AM

rev 274

- Dropped XHTML5 specification for now, because it needs to be served with an unrealistic MIME type. Just plain HTML5 is fine enough. @todo: determine whether existing application/xhtml+xml support should be removed, and remove support for strict doctypes as well, since HTML5 only has one doctype anyway. (index.template.php)
* Changed XHTML to HTML5 in the footer. (index.template.php, index.english.php, index.french.php)
Title: Re: New revs
Post by: Arantor on November 21st, 2010, 12:55 AM
Re the todo: see other comment, it 'should' be OK - if in doubt, try removing it, then putting it in debug mode (logged in as admin, add debug to the GET URL, e.g. index.php?debug) and see whether the browser gets pissy about having been given invalid HTML or not.
Title: Re: New revs
Post by: Nao on November 21st, 2010, 11:20 AM
I tend to forget that debug mode != stats at the bottom... I never use debug mode, myself.
Well, I tested under Safari and it works just fine. (Safari because I need memory for another app right now and Opera with its 350 tabs is a bit too demanding right now.)
Title: Re: New revs
Post by: Nao on November 21st, 2010, 10:18 PM
rev 275

- Deleted the validation unit test. Seriously, what was that anyway? And we're going HTML5 now... (other/unittest/validation/*)
- Deleted the forced XHTML header from debug pages. (Load.php, Subs.php)
- Deleted the strict doctype fix, as, known song, we're going HTML5. (Subs.php, index.template.php)
! A class could be empty at some point... Bad logic, change logic. (Memberlist.template.php)
* Turned stand-alone nowrap styles into a nowrap class. (Admin.template.php, index.css, Errors.template.php, Install.english.php, Install.french.php, ManageBoards.template.php, Memberlist.template.php)
* Turned small stand-alone pages to HTML5 as well, even if it's not needed. Consistency. (install.php, Class-Editor.php, Errors.php, Load.php, ViewQuery.php, Errors.template.php, Help.template.php, ModerationCenter.template.php, Packages.template.php, Post.template.php, Printpage.template.php, Register.template.php)
Posted: November 21st, 2010, 09:46 PM

rev 276

* Turned a few addcslashes into more semantic JavaScriptEscape calls. (Class-Editor.php)
* Commenazi. (index.template.php)

(Small, but I don't know if I'll be able to commit later tonight.)
Title: Re: New revs
Post by: Nao on November 21st, 2010, 11:22 PM
rev 277

! There's probably never going to be something as stupidly exciting as rewriting a feature that took you dozens of lines in dozens of files, in ONE single line. Fixed XMLHttpRequest calls for different domains and subdomains. (script.js)
! Fixed a potential JS error. (topic.js)
! Syntax error. (ViewQuery.php)
* Converted MessageIndex template to HTML5, moved more inline code to footer, etc. (MessageIndex.template.php)

Seriously -- that domain name fix...? Why didn't I think of that in the first place, uh? I don't EVEN need to specify a proper variable with a subdomain like on wedgeforum.com (smf_suburl).
Posted: November 21st, 2010, 11:16 PM

Not too impressive, but thanks to that silly trick, my noisen patch is down from 480 to 467KB...
Title: Re: New revs
Post by: Nao on November 22nd, 2010, 10:38 AM
rev 278

* Hopefully converted all of Packages and Profile to HTML5. (Packages.template.php, Profile.template.php)
* More JSE fixes. (Register.template.php, Profile.template.php, Login.english.php, Login.french.php)
- Removed DOMContentLoaded calls, as they're unneeded when JS is only loaded at the end of the page. (profile.js, script.js)
! Fixed Moderator list being empty in linktree when board has no owner. (Load.php)

I'm dying of boredom... HTML5 conversion has got to be the most annoying thing I've done in months. It makes IE6 compatibility look like heaven. So many deprecated elements... And not always for the better! Why isn't there a "transitional" setting for HTML5, that would do without the deprecated align/valign/width stuff...? It really, REALLY eats a lot of space to turn these all into inline CSS.
Title: Re: New revs
Post by: Nao on November 22nd, 2010, 12:34 PM
rev 279

* Mega-update with the end of cellspacing's, cellpadding's, align's, valign's, width's and other things that are deprecated in HTML5. Most boring task of the month. (Class-Editor.php, Modlog.php, Subs.php, index.css, editor.js, ManageSettings.french.php, ManageSettings.english.php, TEMPLATES: pretty much *all* of them so please don't force me to look into it)
* More JSE fixes. (index.english.php, index.french.php, ManageBans/Boards/Maintenance/Membergroups/News/Paid.template.php, PersonalMessage.template.php, Profile.template.php)

(I had to do all of these manually. One by one. AM I THROUGH NOW? :sob:)
Title: Re: New revs
Post by: Nao on November 22nd, 2010, 05:06 PM
rev 280

- Deleted all type="text/javascript" from script tags, as it's no longer required in HTML5. (All files)
* Tablenazi. (Packages.template.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2010, 12:13 AM
rev 281

* Added two defines, SCRIPT_HEADER and SCRIPT_FOOTER, to make it easier to declare Javascript snippets with proper CDATA protection. You may still use <script> alone, it's up to you. Converting a few files to use these. (index.php, BoardIndex.php, Class-Editor.php, Subs.php, GenericMenu.template.php, index.template.php, Packages.template.php)
* More JSE fixes and footer movement. (Packages.template.php)
* When showing the footer Javascript, make sure to delete any redundant script tags. This may not be worth the trouble, but you know me and my regular expressions... (index.template.php)
* addLoadEvent() is not for dogs. (French saying.) (Subs.php)

Would like some opinions on SCRIPT_HEADER and SCRIPT_FOOTER...
Basically, this turns something like this:

Code: [Select]
$context['footer'] .= '
<script><!-- // --><![CDATA[
initMenu(document.getElementById("amen' . ($mid > 1 ? '_' . ($mid-1) : '') . '"));
// ]]></script>';

Into this:

Code: [Select]
$context['footer'] .= SCRIPT_HEADER . '
initMenu(document.getElementById("amen' . ($mid > 1 ? '_' . ($mid-1) : '') . '"));' . SCRIPT_FOOTER;

Is it worth it? Would you, as programmers, be more like to use these instead of typing the CDATA from memory or copying it from other code stuff?
Would it be more natural/less confusing to just do something like this?

Code: [Select]
$context['footer'] .= '
<script>' . CDATA_HEADER . '
initMenu(document.getElementById("amen' . ($mid > 1 ? '_' . ($mid-1) : '') . '"));
' . CDATA_FOOTER . '</script>';

I like CDATA_HEADER better, but I figured most people would rather have SCRIPT_HEADER from the beginning...
Posted: November 22nd, 2010, 11:47 PM

Silly me... Alternatively, I could do it this way: users write scripts with <script> (no CDATA), and at runtime I'll simply add the CDATA before printing the tag. I'd just need to make sure not to add CDATA header/footer to <script url="something"></script>
(Obviously, it would take a bit more server CPU time to process. Not much though...)
Title: Re: New revs
Post by: live627 on November 23rd, 2010, 12:43 AM
rev 282

* More converting deprecated attributes to CSS equivalents (Themes.template.php, Search.template.php, Profile.template.php, Packages.template.php, MessageIndex.template.php, Login.template.php, Display.template.php, Admin.template.php)
Posted: November 23rd, 2010, 12:33 AM

The CDATA... bit hard to say. CDATA_HEADER seems more logical because it gives the impressiion that a CDATA tag is being used. SCRIPT_HEADER...... sounds like it contains <script>. To me, anywzay.

Is it worth it? No idea..
Title: Re: New revs
Post by: Arantor on November 23rd, 2010, 12:45 AM
/mewould prefer to use CDATA_ rather than SCRIPT_
Title: Re: New revs
Post by: live627 on November 23rd, 2010, 06:55 AM
Oh wait... the actual tag is included. Perhaps SCRIPT_HEADER fits after all.
Posted: November 23rd, 2010, 02:36 AM

rev 284 (:edit: :P)

! Parse error (LogInOut.php)
* Converted another file to HTML5. Moving Javascript to the footer, using data-onclick (Register.template.php)
! Audio verification close button should close an iframe and not a window (Register.template.php)
* Changed an inline style to its equivalent class (Register.template.php)
! SMF bug: Refreshing the CAPTCHA would bring you to the top of the page (GenericControls.template.php)



Note to whoever finishes converting that file (probably me): Only the guest registration area was tackled; the other tmpl functions still need looked at.
Title: Re: New revs
Post by: Nao on November 23rd, 2010, 11:48 AM
rev 285

! Fixed captcha sound popup and simplified Javascript. (GenericControls.template.php, Register.template.php, captcha.js)
! Reverted Profile template to revision 281. (Profile.template.php)
! Reverted all <img style="width/height"> changes, as HTML5 perfectly supports <img width/height>. (Display.template.php, Login.template.php, MessageIndex.template.php, Packages.template.php, Search.template.php)
* Fixed cat_bar margins and indentation in the admin settings. (Admin.template.php, admin.css)
* Added a seamless parameter to the preview iframe, as recommended in HTML5. (Themes.template.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2010, 03:42 PM
rev 286

* Split $context['footer'] into $context['footer'] (regular HTML) and $context['footer_js'] (postponed Javascript). (Load.php, index.template.php, etc.)
- Removed SCRIPT_HEADER/SCRIPT_FOOTER because of the better implementation. (index.php, etc.)
+ Added new Javascript encapsulator. add_js() (temp name) will add your postponed Javascript to $context['footer_js'] and deal with the layout for you. You can still manually add to $context['footer_js'], for instead if you need to manipulate the JS buffer or add characters without newlines. The main benefit is that you can call add_js('hello', $world) and it will behave the same as add_js('hello' . $world'), which makes it easy to convert older templates. (BoardIndex.php, Class-Editor.php, Load.php, ManageBoards.php, ManageMail.php, ManageNews.php, ManagePaid.php, ManageRegistration.php, ManageSearchEngines.php, ManageSettings.php, QueryString.php, Subs.php, TEMPLATES: Admin, Calendar, Display, GenericMenu, MessageIndex, Packages, Post, Register, Stats)
+ Also added add_js_file() function, to specify a JS file to load later, or a list of files. Warning: doing add_js_file($scripturl, '?something') will consider $scripturl as a standalone script. I could improve the behavior but I don't know if it's worth it. (Class-Editor.php, QueryString.php, TEMPLATES: Admin, Display, MessageIndex, Register, Stats)

Now, finishing inline JS should be a piece of cake... :)
Will still need to finish the data-* fixes (has to be done manually because of the hitme complexity + some onclick calls don't require postponing). And I'll be done...
Title: Re: New revs
Post by: live627 on November 24th, 2010, 01:41 AM
rev 287

! JSE fix on alert (Register.template.php)
* Moving Javascript to the footer using add_js() (Profile.template.php, Register.template.php)
Title: Re: New revs
Post by: live627 on November 24th, 2010, 06:55 AM
rev 288

* Moved more Javascript to the bottom (TEMPLATES: Admin, Announce, BoardIndex, Errors, GenericList, index, Login, ManageAttachments, ManageBans, ManageBoards, ManageCalendar, ManageMaintenance, ManageMembergroups, ManageMembers, ManageNews)
! More JSE fixes (ManageMembers.template.php, ManageNews.template.php)



I went ahead and sent IE's HTML5 JS hack in index.template to the bottom - is this the right thing to do? I don't have IE (in Linuxland) so can't test that.

Login.template has Javascripts to set focus to the username inputs. Why not take advantage of HTML5's autofocus feature?

:edit: Perhaps the username field on the registration page can have the autofocus attribute as well.
Title: Re: New revs
Post by: Nao on November 24th, 2010, 02:18 PM
rev 289

- Reverted rev 287-288

rev 290

+ Added placeholder for a dynamic file cache suffix (*.js?suffix), in case we want to use it.
- Commented out the statistics sharing code. We're not SMF. (install.php, upgrade.php)
* More add_js/add_js_file. (Admin.template.php, Subs-Editor.php
- Deleted all copyright removal test code. We'll see to that later but we're certainly not selling the right to delete a copyright. You just need to ask nicely. (Credits.php, Subs.php, Admin.template.php, Who.template.php, Admin language, Errors language)
* Renamed some of the SMF stuff to Wedge and fixed scheduled task SM files to point to our website. (install.php, install.sql, upgrade.php, Install language, ScheduledTasks.php, Subs-Database.php, other/xml/*.js renamed to *.php)
Title: Re: New revs
Post by: Nao on November 24th, 2010, 03:40 PM
rev 291

* More SMF to Wedge changes. (Settings.php, Settings_bak.php, repair_settings.php, smfinfo.php,
+ Added an add_js_inline() to add JS code before the big scripts at the end. Right now it is an alias to add_js(). If used in enough cases, it will be made into a proper function. (QueryString.php, PersonalMessage.template.php)
* Optimized add_js() to justify using it even in loops. Modders are big boys, they don't need newlines to be added automatically for them. (QueryString.php)
* Continuing the add_js quest. (ManageMail.php, PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on November 24th, 2010, 11:55 PM
I can't believe I spent my entire day on this... So many bugs to fix!!

rev 292

@ 30 files done. Got 21 more templates to document before I can commit them... I'll do that tomorrow alright? Man's gotta sleep sometimes.
* More SMF to Wedge renaming. (current-version.php, detailed-version.php)
* More add_js conversion. (TEMPLATES: Admin, Announce, BoardIndex, GenericList)
! Fixed missing parenthesis. (ManageMail.php)
- $profile_fields['js_submit'] and ['js'] are never set in the first place. (Profile-Modify.php)
* Indenazi. (index.php, ManageMembers.php, ManageServer.php, ManageSmileys.php, Admin.template.php, Nix/index.css, ManageSettings.english.php, ManageSettings.french.php)
* Made submit buttons slightly rounded if CSS3 is available. Eh, why not. I'm bored. (index.css)
* Added some margin below fatal errors. Looks better for the Return link. (index.css)
* Changed stats page column internal widths to allow for more space on the left side. (index.css)
! Generic lists could sometimes set width to "100%px"... Yeah. (GenericList.template.php)
! addcslashes/JSE fixes. (Search.php, Search.template.php, ManageMembers.english.php, ManageMembers.french.php)
! Precedence logic issue in cascaded tables. (index.css)
! Cellspacing values weren't working, at least in Opera. (index.css)
! CSS wasn't applied correctly to reports. (report.css)
! SMF glitch: broken class. (ManageScheduledTasks.php)
! Validation error in custom profile fields page. (ManageSettings.php)
! French translation fixes. (index.french.php, Help.french.php, Reports.french.php)
! Alignment issues when opening a month via Ajax in stats page. (stats.js)
! Editor BBC button list was vertical (uh!) in IE6 and IE7 (ahah!) (ie6.css, ie7.css)
! Pete bug (evil grin): auto-suggester was broken. Restored a few lines but they probably would best be removed. (Suggest.php)
! Nao bug (annoyed grunt): removed an extra </div> from the admin settings template. (Admin.template.php)
! Admin area would print label tags linked to non-forms, causing HTML5 validation to break. Yeah I know, they're a PITA... (Admin.template.php)
Title: Re: New revs
Post by: Nao on November 25th, 2010, 05:26 PM
rev 293

! Two errors with SMF variables. (install.php, Install languages)
* Continuing the inline JS exodus. (TEMPLATES: Login, ManageAttachments/Bans/Boards/Calendar/Maintenance/ Membergroups/Members/News/Paid/Permissions, ModerationCenter, Packages, Post, Profile, Search, SplitTopics, Stats)
! SMF bug: Javascript error when editing the Local Moderator membergroup. (ManageMembergroups.template.php)
- Removed unused variables $context['profile_javascript'] and $context['profile_onsubmit_javascript']. BTW, the latter's implementation was buggy. (Profile.template.php)
+ Added description for membergroup color setting. (ManageMembergroups.template.php, ManageMembergroups language)
+ Added a label for duration radio boxes. UI FTW. (ManagePaid.template.php)
! isset($something) ? $something : $something has to be the funniest waste of space I've seen today. Four times. In the same file. (ManagePaid.template.php)
! Fixed validation broken due to [] in URLs. Too bored to look for other URLs manually... (PersonalMessage.template.php)
! SMF glitch: validation was broken in profiles due to a self-closed span. Whatever. (Profile.template.php)
* Started replacing <br /><span class="smalltext"> with <div class="smalltext">. Allows for setting some padding in the settings area to avoid getting long descriptions to touch the right side of the area. (TEMPLATES: ManageBans, ManagePaid, ManagePermissions, PersonalMessage, Profile)
! Fixed leap year handling. The problem won't occur before 2100, but we might as well be ready for the far future. That's what Wedge is. (Calendar.template.php, ManageCalendar.template.php)
! JSE fixes in various places, most notably all doAutoSubmit() functions. Maybe we should be putting this into a JS file...? (TEMPLATES: Admin, Announce, ManageAttachments, ManageMaintenance, ManageMembers, ManageNews, ManageSearch, Packages, Register, Search)
* Seriously, plenty more fixes that I couldn't both to log. Do you realize I spent an entire day just writing this changelog and checking it again and again? Is there someone reading me anyway? Hello? Mom is that you?
* Indenazi. (Reports.php)

I'm only halfway through it! I have just as many files left to commit. And I'm not even started on onclicks, lol...
Title: Re: New revs
Post by: Nao on November 25th, 2010, 05:59 PM
rev 294

+ Adding proper support for add_js_inline(). (Load.php, QueryString.php, index.template.php)
* Don't show debug info in help popups. Seriously, this was too silly. (Subs.php)
- Removing submit button's rounded corners until I figure out a way to properly disable the outline that shows up in Opera when clicking it. (index.css)
* Simplified init process for both objects in admin.js file. (admin.js)
* Give some padding to descriptions inside the settings area. At least some breathing space... (index.css)
+ Forgot to translate an entry to French. (Admin.french.php)
* Finished committing a few multi-file fixes that were mentioned in the previous commit: <span>'s to <div>'s, leap year fix and renamed functions. (ManageAttachments.php, ManageScheduledTasks.php, ManageServer.php, ManageSmileys.php, Profile-Modify.php, TEMPLATES: Calendar, Help, ManageCalendar, ManageSmileys, Post, Themes)

Phew... Here are are.
Many files, but less changes per file, thankfully, so it was way quicker to build this changelog.
One more commit coming up, with the last smalltext span fixes...
Title: Re: New revs
Post by: Nao on November 25th, 2010, 06:09 PM
rev 295

- Couple of useless classes. (index.css)
* Finished replacing <span>'s with <div>'s. Phew. One good thing done... (All other files in that rev. Honest.)

TAKING A BREAK! :P
Title: Re: New revs
Post by: Nao on November 25th, 2010, 09:48 PM
rev 296

* The manage smileys page had a very ugly link at the bottom. (ManageSmileys.php)
* More inline JS movement. (Admin.template.php, ManageSmileys.template.php, Packages.template.php, Reminder.template.php, Themes.template.php)
* Scheduled Tasks translation to French was inconsistent. (Admin, Help and ManageSettings language files)
* Fixed latest-*.php files to prevent them from sending errors to Wedge. Whatever... (xml/latest-*.php)
Title: Re: New revs
Post by: Nao on November 25th, 2010, 11:02 PM
rev 297

- Removed support for theme variants... We have stylings now, and they're easier to grasp for themers, hopefully. Better documented, too. Maybe it'll get me to finally enable choosing a styling for the forum theme (outside of boards)... And maybe customization for users, but honestly I'm not fond of that idea. (Load.php, Themes.php, BoardIndex.template.php, Themes language, MessageIndex.template.php, Themes.template.php)
* Continuing, and pretty much finishing, the inline JS migration. Every single script tag left means the data can safely be stored inside the JS and doesn't rely on externals. (ManageMembergroups.template.php, ManagePaid.template.php, Packages.template.php, Poll.template.php, Profile.template.php)
* Forgot to fix the leap year on one of the files. (ManagePaid.template.php)
Title: Re: New revs
Post by: Nao on November 26th, 2010, 08:17 PM
rev 298

+ Added ability to specify a default styling for the forum. (install.sql, Load.php, ManageBoards.php, Themes.php, ManageBoards.template.php, Themes.template.php)
* A few minor tweaks to Themes language files, hopefully for the better. (Themes.english.php, Themes.french.php)
@ To do: allow members to set their own styling preferences, too.
Title: Re: New revs
Post by: Nao on November 26th, 2010, 11:10 PM
rev 299

* At last, STYLINGS ARE F'ING DONE! Implemented user's ability to select different stylings by default. (install.sql, Load.php, Themes.php, Themes.template.php, Themes.english.php, Themes.french.php)
* Some tweaks in stylings and their settings file. (Nix/index.css, Nix/settings.xml, Green/settings.xml)
Title: Re: New revs
Post by: Nao on November 26th, 2010, 11:20 PM
rev 300

* Theme preview/use page was beginning to be a bit crowded. (Themes.template.php)
+ Added a quick "proof of concept" styling. Dunno if it's worth including it in the final file. (css/Green/Green again/*)
@ Okay, so what? I just wanted to have rev 300 done before going to bed... Sue me.
Title: Re: New revs
Post by: Arantor on November 27th, 2010, 02:57 AM
Holy cow, lots of things to review, will try and look at them tomorrow.
Title: Re: New revs
Post by: Nao on November 27th, 2010, 04:34 PM
rev 301

* Show link underlines in posts. I've always found it silly that SMF insisted on pretty much hiding links from posts. If anything, it encourages spamming. (index.css)
* Moved smf_mousePose over to editor.js (the only file that uses it), and renamed it to getMousePosition (more logical). (editor.js, script.js)
* Moved the IconList object from script.js to topic.js, as it's only used on topic pages. (script.js, topic.js)
- Removed setInnerHTML/getInnerHTML functions, as they're no longer required. At all. Yes. Also removed smfFooterHighlight because it's an old compat function. We don't care about that. (script.js)
Title: Re: New revs
Post by: Nao on November 27th, 2010, 05:13 PM
rev 302

- Purged everything evil out of theme_copyright. (Subs.php)
* Slight DOM traversing optimizations (on Pete's suggestion.) (ManageAttachments.template.php, ManageBans.template.php)
Title: Re: New revs
Post by: Arantor on November 27th, 2010, 06:06 PM
Revision: 303
Author: arantor
Date: 17:05:02, 27 November 2010
Message:
! func_get_args() can't be used as a parameter for a function prior to PHP 5.3.0 (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php



It's a really quirky one, this, but func_get_args() relies on scope, and the scope model changed fairly heavily in 5.3.0 - to a more powerful one. It's to do with the point at which scope is resolved for the function whose arguments you're getting. Downside is that for < 5.3, you have to push it into a variable first.
Title: Re: New revs
Post by: Arantor on November 27th, 2010, 11:57 PM
Quote
Well, putting the args into a variable before imploding them takes more time and memory...
There's actually not a lot in it, I think, if you dig down to the underlying C code, since a string and an array are internally managed through pointers rather than the physical value being pushed; it's sort of by-reference-but-pretending-otherwise as opposed to really-by-reference. (This is most noticeable when calling C stuff from something like Visual Basic where you have to be explicit and strings, arrays etc are always ByRef even if the intent is not.)
Quote
We still have plenty of issues to fix...
The current code seems to work, work quite well and achieves what the original intent was - putting everything that much closer to the end to get faster rendering and add <insert JS library here> if we wanted. So there are bigger fish to fry, so to speak.


Right now I'm trying to visualise exactly how drafts would play out - see my notes in http://tracker.wedge.org/?sa=ticket;ticket=51 for more of the issues that need to be tackled.
Posted: November 27th, 2010, 08:23 PM

Revision: 304
Author: arantor
Date: 19:32:42, 27 November 2010
Message:
- Remove installed add-ons list seeing how we already have the same list in the Browse Add-ons page (Admin.php, Packages.php, PackageGet.php, Packages.template.php, Admin.english.php, Admin.french.php, Packages.english.php, Packages.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php

Posted: November 27th, 2010, 08:33 PM

Revision: 305
Author: arantor
Date: 22:56:55, 27 November 2010
Message:
! More movement of actions to their own files (Search.php, Search2.php, Themes.php, Jsoption.php, index.php)
! Fix for broken info centre toggle (BoardIndex.php)
----
Modified : /trunk/Sources/BoardIndex.php
Added : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Search.php
Added : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: MultiformeIngegno on November 28th, 2010, 02:07 AM
It's great to see arantor working again! :)
Title: Re: New revs
Post by: Arantor on November 28th, 2010, 07:19 PM
Revision: 306
Author: arantor
Date: 18:19:11, 28 November 2010
Message:
! Converted redirects to blank.gif into outputting raw image from shared function to avoid redirections. (index.php, Subs.php, Jsoption.php, VerificationCode.php)
! Some uses of raw image output had to be inlined because Subs.php isn't loaded at that point (install.php, repair_settings.php, upgrade.php)
! Removed legacy files listed in installer (install.php)
----
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on November 29th, 2010, 09:43 AM
rev 307

* Updated license.txt to Wedge's. Not many differences though. Also moved it to the root instead of a license in Themes and one in other/*. (license.txt)
* Optimized a DOM traversing function, and moved it to the inline section. (Admin.template.php)
* Gave more padding to autosuggest popups. (index.css)
Title: Re: New revs
Post by: Nao on November 29th, 2010, 10:05 AM
rev 308

* Simplifying calls to the auto-suggest widget: setting sSearchType to 'member' by default until we write more suggestion types, making sSuggestId the same as sControlId (a prefix is added to it anyway so collision chances are close to zero), and bItemList already accounted for the lack of parameter. (suggest.js, PersonalMessage.js, TEMPLATES: ManageBans, ManageBoards, ManageMaintenance, ManageMembergroups, ManageNews, ManagePaid, Profile)
! Fixed syntax error in Member Tasks. (ManageMaintenance.template.php)
Title: Re: New revs
Post by: Nao on November 29th, 2010, 11:48 PM
rev 309 (I hate revs ending in "9", I usually reserve them for my crappy commits :P Well, it will be a first...)

+ Added jQuery into Wedge. YES! (jquery-1.4.4.min.js)
+ Added new setting, $modSettings['jquery_remote'], defaulting to false, determining whether jQuery should be loaded from the Google CDN or merged into script.js, cached and gzipped locally. No UI for it yet. (Load.php, index.template.php)
* Replaced own JS minification routines with a more efficient version based on Dean Edwards' Packer 2.0. (Class-Minify.php, Subs.php)
* Optimized minification by listing all variable names that can safely be renamed. (Subs.php, script.js, theme.js)
* Added a quick fix for Javascript errors when a minified file has something = function () {} without a closing semicolon. Strings containing solo "}" or "{" are not supported. I can't fix your weird code all by myself. (Subs.php)
! Fixed some Nix styling colors. (Nix/index.css)
- submitonce() doesn't actually take any parameter. (script.js, editor.js, TEMPLATES: MoveTopic, Packages, PersonalMessage, Poll, Post)

So, I guess this build will crash on everyone's machine, ah ah. It may work, too. I hope I didn't forget to commit any file (I had to add Class-Minify.php and jquery.js manually.)
If it crashes, please wait until tomorrow morning and I'll have a look. Right now I have to hurry to bed.

TOMORROW-- let's have some fun with jQuery!! ;)
Title: Re: New revs
Post by: Arantor on November 30th, 2010, 12:05 PM
I knew it was hard to debug since it was an error on line 1... but it's all line 1 >_< I can enable that to test it, sure. If the option is disabled, it probably shouldn't go through Packer. Thing is, though, which performs better overall - Minification & Packer strikes me as though it should underperform compared to Minification & Gzip.

Meanwhile...


Revision: 310
Author: arantor
Date: 08:46:41, 30 November 2010
Message:
! Renamed the .xml action as feed which just seems more logical, as well as moved it around (index.php, Feed.php, Load.php, News.php, BoardIndexInfoCenter.template.php, index.php, Help.english.php, Help.french.php)
! Cleaned up xmlhttp action as part of ongoing harmonisation (index.php, Xml.php, Xmlhttp.php)
----
Added : /trunk/Sources/Feed.php (Copy from path: /trunk/Sources/News.php, Revision, 309)
Modified : /trunk/Sources/Load.php
Deleted : /trunk/Sources/News.php
Deleted : /trunk/Sources/Xml.php
Added : /trunk/Sources/Xmlhttp.php (Copy from path: /trunk/Sources/Xml.php, Revision, 309)
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 09:49 AM

OK so I enabled it, and Chrome did not like the compressed file one bit. Yay for unstyled page!
Posted: November 30th, 2010, 09:51 AM

Revision: 311
Author: arantor
Date: 09:01:37, 30 November 2010
Message:
! Removed legacy requestmembers action and function (index.php, Subs-Auth.php)
----
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/index.php


This was the old auto-suggest handler from 1.1.x, only no-one removed it, haha. Needless to say it'll still be in 2.0 final >_<
Posted: November 30th, 2010, 10:02 AM

Revision: 312
Author: arantor
Date: 09:08:09, 30 November 2010
Message:
! Harmonised action=jseditor, including removing the method from the editor class (strictly speaking it feels a little less like it should be in the class anyway) (index.php, Class-Editor.php, Jseditor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Added : /trunk/Sources/Jseditor.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 10:08 AM

Revision: 313
Author: arantor
Date: 09:46:55, 30 November 2010
Message:
! Tidy up the WAP2 PM find-member action into its own file (index.php, Findmember.php, Subs-Auth.php)
! Remove the non WAP template for findmember since it doesn't appear to be in use anywhere (Findmember.php, Help.template.php)
----
Added : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 10:57 AM

Revision: 314
Author: arantor
Date: 10:12:23, 30 November 2010
Message:
! Silently rewrite action=.xml into action=feed (index.php)
! Move the buddy, lock and sticky actions into their own files (index.php, Buddy.php, Subs-Members.php, LockTopic.php, Lock.php, Sticky.php)
----
Added : /trunk/Sources/Buddy.php
Added : /trunk/Sources/Lock.php (Copy from path: /trunk/Sources/LockTopic.php, Revision, 309)
Deleted : /trunk/Sources/LockTopic.php
Added : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 11:12 AM

Revision: 315
Author: arantor
Date: 11:05:06, 30 November 2010
Message:
! Split LogInOut into separate actions and support, and fix all the links to it (index.php, LogInOut.php, Subs-Login.php, Login.php, Login2.php, Logout.php, Load.php, Profile-Actions.php, Reminder.php, Security.php, Subs-OpenID.php)
----
Modified : /trunk/Sources/Load.php
Deleted : /trunk/Sources/LogInOut.php
Added : /trunk/Sources/Login.php
Added : /trunk/Sources/Login2.php
Added : /trunk/Sources/Logout.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Security.php
Added : /trunk/Sources/Subs-Login.php (Copy from path: /trunk/Sources/LogInOut.php, Revision, 309)
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on November 30th, 2010, 06:28 PM
rev 316

* Spacinazi. (Findmember.php, ModerationCenter.template.php)
! Missing div and incorrect bar. (ModerationCenter.template.php)
- Removed some test code. (theme.js)
* The index template has two RSS links, but they were formed differently. Spider engines will appreciate that we use the exact same link. (index.template.php)
Posted: November 30th, 2010, 02:15 PM

rev 317

* Updated logo and favicon to the newest ones. (wedgelogo.png, favicon.ico)
* Spacinazi. (Class-Minify.php)
* Pete, I'll hate you forever for ignoring my moving plea. <scream> Removed my own custom minifying code. (Subs.php)
+ Added support for JSMin minifier. Delete the DEFINE('JSMIN', 1) line to test support for Packer. (Subs.php, Class-JSMin.php)
* JSMin keeps multi-line comments in cached files, so used the opportunity to add license information to a couple of them. (editor.js (yes, it isn't packed yet, but it will come), script.js, theme.js)
Posted: November 30th, 2010, 06:26 PM

Forgot that one...

rev 318

+ Added a compatibility sheet for IE6 in Nix styling. (Nix/ie6.css)
Title: Re: New revs
Post by: Nao on November 30th, 2010, 06:42 PM
rev 319

! JSMin doesn't need the semicolon fix. (Subs.php)

(Sorry! Forgot to move the block...)
Title: Re: New revs
Post by: Arantor on December 1st, 2010, 04:19 AM
Revision: 320
Author: arantor
Date: 19:50:43, 30 November 2010
Message:
! Convert action=collapse into its own file (index.php, BoardIndex.php, Collapse.php)
! Remove legacy modifycat action (index.php, ManageBoards.php)
----
Modified : /trunk/Sources/BoardIndex.php
Added : /trunk/Sources/Collapse.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 08:51 PM

Revision: 321
Author: arantor
Date: 20:44:34, 30 November 2010
Message:
! Convert polls to be a action=poll with subactions (index.php, Poll.php, Who.english.php, Who.french.php, Poll.template.php, Display.template.php)
+ Add the ability for topic-permission (whotopic) strings that support specific action/subaction strings (Who.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 09:44 PM

Revision: 322
Author: arantor
Date: 03:19:01, 01 December 2010
Message:
! loadSource introduced. (Load.php)
! A decent number of files converted to use loadSource where possible without lots of work, and globalisation of $sourcedir removed in the process. Not all files are finished yet. (Lots and lots of files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Collapse.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/index.php
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Arantor on December 1st, 2010, 11:22 AM
Revision: 323
Author: arantor
Date: 10:22:11, 01 December 2010
Message:
! Fixing most of the rest of the uses of $sourcedir / loadSource in main source (lots of files)
! Reverting use of loadSource where function not available at that point (Subs-Database.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Unreadreplies.php
Title: Re: New revs
Post by: Nao on December 1st, 2010, 12:31 PM
rev 324

! Wrong loadSource destination. (ManagePaid.php)
Title: Re: New revs
Post by: Nao on December 1st, 2010, 08:37 PM
rev 325

- Removed preg_match hack from loadUserSettings, as the security issue is fixed in PHP 5.0.2, and we won't accept anything below 5.0.2 anyway. (Load.php)
* Updated createList() to use loadSource(). (ManageCalendar.php, ManageMembergroups.php, ManageMembers.php, Subs-List.php)
- Removed hitme classes, as they won't be used in the end. (ManageMembers.php, ManageSmileys.php, TEMPLATES: Calendar, MessageIndex, Post)
! Another file with a .php extension where it shouldn't have had it. (Profile.php)
@ todo: implement hitme replacement, and update the minimum PHP version.
Title: Re: New revs
Post by: Nao on December 1st, 2010, 11:05 PM
rev 326

* Upping minimum version of PHP from 5.0.0 to 5.1.2. (install.php, readme_*.html, webinstall.php, upgrade.php)
* Upping minimum version of MySQL from inconsistent stuff to 4.1.2. (install.sql, readme_*.html, upgrade.php, ManageMaintenance.php, SearchAPI-Fulltext.php, ManageMaintenance language)
Title: Re: New revs
Post by: Arantor on December 2nd, 2010, 01:33 AM
Revision: 327
Author: arantor
Date: 22:35:19, 01 December 2010
Message:
! Minor formatting fix to fatal error page (Errors.template.php)
! Replaced $smcFunc['db_*'] functions with the weDB family of classes. (LOTS of files. Far too many for a sane person, or even not so sane person, to list here manually.)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Announce.php
Added : /trunk/Sources/Class-DB.php
Added : /trunk/Sources/Class-DBExtra.php
Added : /trunk/Sources/Class-DBPackages.php
Added : /trunk/Sources/Class-DBSearch.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/CoppaForm.php
Deleted : /trunk/Sources/DbExtra.php
Deleted : /trunk/Sources/DbPackages.php
Deleted : /trunk/Sources/DbSearch.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Deleted : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/other/install.php
Modified : /trunk/subscriptions.php

Posted: December 1st, 2010, 11:36 PM

Revision: 328
Author: arantor
Date: 00:11:26, 02 December 2010
Message:
! Stupid bugfix for installer looking for the wrong file (install.php)
! Remove boardmod support (Packages.php, Subs-Package.php, Packages.template.php)
----
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/other/install.php

Posted: December 2nd, 2010, 01:11 AM

Revision: 329
Author: arantor
Date: 00:32:51, 02 December 2010
Message:
! Reformatted the browse packages template to have a single subfunction handling the different lists of add-ons rather than doing it 4 times (Packages.template.php)
----
Modified : /trunk/Themes/default/Packages.template.php
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 12:11 PM
rev 330

* Now that we're using PHP 5.1.2 as minimum version, date_default_timezone_set() is always available, so don't bother looking for it. Also made a couple of related time function fixes. (install.php, upgrade.sql, Calendar.php, Load.php, ManageSettings.php)
- Deleted a few unused globals. There's probably room for more to be removed here. (install.php)
- Delete clickMagic(), as it will now be done inline. (script.js)
! Fatal error pages could break the header layout. (css/index.css)
! CRLF fix. (Nix/ie6.css)

(I forgot to document the script.js change in the changelog -- actually I was planning to commit it in the next batch rather than now, oops...)
Pete, can you look into these useless globals in install.php? I don't see why there were so many declared in the first place...
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 02:15 PM
rev 331

@ First official use of jQuery in Wedge![1] (QueryString.php, topic.js)
* Finalized inline JS code. Now, all events are automatically moved to the end of the page, with all duplicates merged, and executed after jQuery is loaded. (QueryString.php, index.template.php)
* Modified Quick Reply, Quick Modify and User Menu objects to allow for better duplicate management. Deleted xDeprecated argument from QuickReply.quote(). (Display.template.php, topic.js)
- Deleted data- prefixes from events in Display template. Other files will be done next. (Display.template.php)
* User menu is now a bit more user-friendly... User can click anywhere in the page to cancel an opened menu, and clicking on another user name will also close previously opened menus. (topic.js)
Posted: December 2nd, 2010, 02:00 PM

rev 332

- Reverted all 60+ existing data-on* events to happily use the new system. (Class-Editor.php, Groups.php, Manage*.php, Modlog.php, Profile-Modify.php, Subs-Package.php, Subs.php, TEMPLATES: Admin, Calendar, ManageMaintenance, MessageIndex, ModerationCenter, Poll, Post, Profile, Register, Stats)
 1. As far as I know... :mdr:
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 02:30 PM
rev 333

* Renamed weDB, weDBExtra, weDBPackages and weDBSearch classes to wedb, wedbExtra, wedbPackages and wedbSearch. This took a minute to do. Can be reverted if someone's unhappy. Just wanted to see how it looked and felt ;) (Plenty of files, obviously.)

To Pete: I didn't wait for your feedback to do this... I'm well aware that you might not like this, so I made sure it's done in a separate commit. If you don't like it, either manually do a search & replace on wedb to weDB (or "wdb"?), or just revert rev 333! This is NOT a hostile fork commit... :^^;:

Also, obviously, if you're going to analyze revs 330-332, please update to rev 332, not 333 ;)
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 07:49 PM
rev 334

* ssi_examples fix. Plenty of things were broken in the first place. (other/ssi_examples.*)
* Converted more templates to HTML5. Some of these files in other/* are a real mess... Might as well throw them away at some point. (news_readme.html, readme_*.html, sphinx_config.php, ssi_examples.*, package/*.html, package/test_modification.php, repair_settings.php, webinstall.php, SSI.php)
- Did you know that link rel="stylesheet" tags could also do without the type="text/css" attribute? Yes? Well, I didn't. I tried, and it validates. Away they go. (install.php, Class-Editor.php, ViewQuery.php, and most of the files above. TEMPLATES: Errors, Help, index, ModerationCenter, Packages, Post, Register, Reports)
- Forgot to update the documentation when I removed specific browser version sniffing in rev 93. (Load.php)
Posted: December 2nd, 2010, 07:07 PM

rev 335

- Deleted empty alt's from img tags, as they're not required by the HTML5 specs. (ssi_examples.php, Display.php, Load.php, Subs-Menu.php, Subs.php, editor.js, TEMPLATES: Admin, BoardIndex, Display, Errors, GenericList, GenericMenu, Login, ManageMembergroups, ManageSmileys, Memberlist, MessageIndex, ModerationCenter, Notify, Packages, PersonalMessage, Post, Profile, Recent, Search, SendTopic, Stats, Themes, Who)
* Fixed posting_icons alignment. (index.css)
Title: Re: New revs
Post by: Nao on December 3rd, 2010, 08:59 AM
rev 336

! Events could be postponed even when inserted in the footer area. (QueryString.php, index.template.php)
Title: Re: New revs
Post by: Arantor on December 3rd, 2010, 02:45 PM
Revision: 337
Author: arantor
Date: 12:40:36, 03 December 2010
Message:
! Don't show the login screen for someone who is already logged (Login.php)
----
Modified : /trunk/Sources/Login.php

Posted: December 3rd, 2010, 01:41 PM

Revision: 338
Author: arantor
Date: 13:44:42, 03 December 2010
Message:
! Make bbcode be loaded from a table rather than stored hardcoded in the parser (Subs.php, install.sql)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on December 3rd, 2010, 05:50 PM
Revision: 339
Author: arantor
Date: 16:49:46, 03 December 2010
Message:
+ westring class (Class-String.php)
! Die, $smcFunc, die. (MANY files, many changes pretty automated which is why some of the other/ files are done)
! Stripping out a few more of the db_* functions that should have gone yesterday (RepairBoards.php and a couple of others)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-Editor.php
Added : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/tools/restore_backup.php
Modified : /trunk/other/tools/smf_api.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/tests/Class-UnitTest.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_parsesmileys.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/subscriptions.php

(Oh, and there is a change to Login.php to kick registered users back to the main page since we shouldn't really show the login page to non-guests.)
Title: Re: New revs
Post by: Nao on December 4th, 2010, 11:02 AM
rev 340

* Many script.js changes. Dropped is_ie4, is_ie5 and other deprecated browser vars (testing for if (is_ie4) is going to return false, whether they're declared or not, so let's not waste time initializing them...), used more logical ways to determine version numbers (Opera 9.5+ and IE versions), used jQuery in many places to save up to 3KB of script code. Turned addLoadEvent into a jQuery alias. (script.js)
! Fixed the following bugs in inline JS postponing: double ob_sessrewrite calls, events not getting compiled at runtime (used function() instead of new Function()), exotic templates generating errors (xml, etc), and self-closing tags breaking validation after being modified. Also used a static instead of a global var to store duplicate events. (QueryString.php)
* helpFrame was no longer working due to variable name optimizations. Renamed it to helf and optimized related code. BTW this Help template is ridiculously short now, as well as a couple other templates... Maybe we should integrate them into another file... (Help.template.php, Register.template.php, script.js)
* As inline events no longer require to have entities instead of <, >, & etc, converted all of the existing events to use clean code. (Groups.php, TEMPLATES: ManageBans, ManageMaintenance, ManageMembergroups, ManageSearch, MessageIndex, ModerationCenter, Packages, Search)
* Turned <div class="smalltext"> descriptions in admin zones, to use <dfn> (definition term), which validates when inside <dt> tags. (index.css, ManageBans.template.php, up to 214 more changes to come...)
* Minor details. (Errors.english.php, Errors.french.php, ManageMaintenance.french.php, Profile.template.php)

It's not yet out... But I've written the changelog already, so here it is :P
Obviously it would be out already if it didn't collide with the latest revs, ah ah... I can feel the fun already.
:edit: Not a single collision, actually. :wow:
:edit: :edit: Done!
Title: Re: New revs
Post by: Nao on December 4th, 2010, 01:56 PM
rev 341

* 172 more <div class="smalltext"> replacements to <dfn>. Should be done now... (ManageSettings.php, index.css, TEMPLATES: ManageBoards, ManageMembergroups, ManageNews, ManagePaid, ManageScheduledTasks, ManageSearch, ManageSmileys, ModerationCenter, Packages, PersonalMessage, Profile, Register, SendTopic, Themes, LANGUAGES: Admin, ManageSettings, Search)
* Spacinazi and valinazi (small issues that broke validation :P). (Errors.template.php, Profile.template.php, Themes.template.php)
Posted: December 4th, 2010, 01:28 PM

rev 342

* Some optimizations in parse_bbc(). Not all, though. Yeah, I know, I could have used === instead of ==... Stop bothering me now, will you? (Subs.php)
Title: Re: New revs
Post by: Nao on December 4th, 2010, 04:17 PM
rev 343

* Mass renaming 'westring' class to 'westr'. (About 60 files.)
Posted: December 4th, 2010, 04:17 PM

rev 344

- Oops! Test code. (index.template.php)
Title: Re: New revs
Post by: Nao on December 4th, 2010, 07:30 PM
rev 345

* More jQuery fun. (script.js, suggest.js, topic.js)
! Fixed addLoadEvent no longer accepting strings as parameter, e.g. auto-suggest init. (script.js)
Title: Re: New revs
Post by: Nao on December 5th, 2010, 12:31 AM
rev 346

* Turned Ajax functions into jQuery $.ajax() calls. Seems to work on everything I tested (auto-suggest, topic pages.) (script.js, suggest.js)

This is a 'big' part even though it doesn't show. Maybe we don't want to do this conversion right now... Still, it can't hurt to at least *try*. It saves nearly an extra kilobyte off the script file... And a mere 160 bytes from the minified, gzipped file.
Title: Re: New revs
Post by: Arantor on December 5th, 2010, 04:16 PM
Revision: 347
Author: arantor
Date: 15:15:57, 05 December 2010
Message:
! Updated to r10296
 - expanded support for size types in size bbc (install.sql)
 - caching board parents information (Load.php)
 - OpenID fix (Subs-OpenID.php)
 - moving action spamming checks earlier in workflow (Login2.php, SendTopic.php)
 - some servers send $_SERVER['HTTPS'] in different ways (ManageServer.php)
 - comment fixes (Errors.php, ManagePosts.php, Subs-Menu.php)
 - make sure cache is cleared when boards are altered (Subs-Boards.php)
 - make sure cache-clearing also invalidates cache in case files weren't removed (Subs.php)
 - minor layout tweak (admin.css)
 - remove signature padding for IE6 and IE7 (ie6.css, ie7.css)
 - language cleanups including a missing error message (Admin, Errors, Help, index, Profile)
 - Fix for additional space in post template (Post.template.php)
 - Formatting change in profile template for requesting a group membership (Profile.template.php)
 - Change of reserved words to use change in admin CSS (additional by me: dropping of name attribute for HTML5) (Register.template.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/css/admin.css
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/ie7.css
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql



(Changes from RC4 public to r10296)
Title: Re: New revs
Post by: Nao on December 5th, 2010, 07:38 PM
rev 348

! Auto-suggest search could generate errors in the log. (Suggest.php)
* Updated French translation. (Admin, Errors, Help, index, Profile)
Title: Re: New revs
Post by: Nao on December 5th, 2010, 08:31 PM
rev 349

- Removed support for bbcode tags: glow (out of fashion), shadow (meh), move (epileptic FTW), and acronym (deprecated in HTML5, use abbr instead. Yes I know, I could have just made an alias for that one...) (install.sql, Subs.php, Post.english.php, Post.french.php, Admin.french.php)
- Removed corresponding icons (glow, shadow and move) from the sprite. (Class-Editor.php, bbc/sprite.png)
! Fixed a couple of issues in the bbcode table's default contents. (install.sql)

I couldn't determine whether <acronym> was really deprecated in HTML5[1] (most websites say yes, but the w3schools site, which is run by the w3c IIRC, doesn't mention it), but I figured it wouldn't matter anyway.
We need to (1) make that "things to do in the converter" topic, (2) mention that we should update posts to delete these tags.
Posted: December 5th, 2010, 08:19 PM

rev 350

* <tt> is deprecated in HTML5. Replacing HTML contents for the tag. (install.sql)
 1. :edit: Seems really likely...
Title: Re: New revs
Post by: Nao on December 6th, 2010, 10:48 AM
rev 351

* Renamed wedb class to wesql, for consistency with both the westr class, and the original mysql_* functions. Whatever, eh? (SSI.php, subscriptions.php, other/install.php, Sources/*.php)

(Put into its own separate commit, so that you can cancel it if you end up not liking it.)
(Also, I haven't renamed wedbPackages and wedbExtra yet. I don't really know what to do about them... Maybe weDbPackages and weDbExtra? Or weDBPackages and weDBExtra, like their Class-*.php filenames?)
Title: Re: New revs
Post by: Nao on December 6th, 2010, 11:49 AM
rev 352

* Slightly optimized parse_bbc() by removing its two easter eggs (chrissy and kissy), avoiding copying $master_codes to $codes, and referencing $master_codes when filling the BBCode array, instead of copying it. (Subs.php)
* User menus are no longer triggered when clicking a username, rather they'll pop up when hovering the username, and close automatically when moving the mouse somewhere else. Oddly, this makes the code a bit simpler, as body click events and double-click cancellations (via onmousedown) are no longer necessary. (Display.template.php, topic.js)
+ Added French image folder. Just so we don't forget providing it later... (images/french/*)

(Have yet to commit my partial editor.js conversion to jQuery. I wouldn't even know where to begin with testing, ah ah...)
Title: Re: New revs
Post by: Nao on December 6th, 2010, 04:23 PM
rev 353

! Error when renaming the wedb class. (Class-DB.php)
* hover() is shorter than a double bind. (Display.template.php)
* Moved avatar management code in profile to the footer area. (Profile.template.php)

(Sorry for the crash bug. I'm busy debugging the main menu in IE (it's currently broken) and I didn't test everything.)
Title: Re: New revs
Post by: Nao on December 6th, 2010, 11:49 PM
rev 354

! Fixed a few functions that were broken during the conversion to jQuery. (script.js)
Posted: December 6th, 2010, 10:26 PM

rev 355

* Improved menu performance in Internet Explorer by a factor of 42. I'm so proud. (script.js)
! Fixed iframe shim for IE. Should be working well in IE6 now. (script.js)
* More jQuery goodness. Can be improved, as usual... (script.js)
@ todo: fix editor in IE6... Doesn't seem to accept Wysiwyg, and icons don't show. (Already fixed that once last month... Uh. IE.)
Title: Re: New revs
Post by: Nao on December 7th, 2010, 06:39 PM
Ah... Finally done with that commit... -_-

rev 356

* Too bad jQuery doesn't support the pageshow event... Still, moving that to the footer. (Post.template.php)
- Replaced event listeners with jQuery's implementation. (register.js, topic.js)
* Replaced XMLHttpRequest tests with a can_ajax variable, and removed all tmpMethod hacks. The Themes template still has a different hack that needs to go. (upgrade.php, TEMPLATES: Display, MessageIndex, Packages, Search, SplitTopics, Themes, register.js, stats.js, suggest.js, topic.js)
* Style file inputs to get a default width of 300px. (index.css, Packages.template.php)
* Replaced Comic Sans MS with Segoe UI. Yeah, Comic is a popular font, but it doesn't make me laugh. That would actually be the opposite... Also replaced the ugly Courier with Courier New, and deleted an extra, unused copy of the font list from the script file. (Class-Editor.php, editor.js)
* Made main menu code faster, and saved an awful lot of code, too. (script.js)
* Been slightly more aggressive when minifying CSS... Saves a few bytes per file. (Subs.php)
* Renamed is_ie9 JS var to is_ie9up, as it's really what it does now... (script.js)
- getMousePosition() was no longer needed, as its task is already fulfilled by jQuery. (editor.js)
* The 'more' bbcode tag was hardcoded. I know it's not finished yet (add button, etc..?), but it still needed to get its own class and translations. (Subs.php, index.css, index.english.php, index.french.php)
@ Discuss: Shouldn't parse_bbc use UTF8-safe strlen/substr functions everywhere..?
@ Note for later: IE6 doesn't like $('<input>', { object }). Whatever they say on the web... It doesn't. It has to be fully formed in the HTML portion.
Title: Re: New revs
Post by: Nao on December 7th, 2010, 09:04 PM
rev 357

+ The smc_Toggle class was screaming to be upgraded to use jQuery's animations! Looks great and saves 5 lines of code, ah ah! (script.js)
Title: Re: New revs
Post by: Nao on December 9th, 2010, 06:30 PM
rev 358

* Modified the menu system to turn it into a pure CSS menu when Javascript is not available. Oh yes. (index.css, script.js, GenericMenu.template.php, index.template.php)
* Changed toggle class animation to make it slide up and down, instead of shrink and fade. This should be a bit better for performance, and accomodate for weirder layouts, if ever needed. (script.js)
! Fixed remaining chars counter in the 'more' tag, to take multi-byte chars into account. Also, don't bother showing anything if the tag was put at the end of the message. (Subs.php)
! Fixed many CSS bugs in the main menu implementation for IE6 and IE7. (ie6.css, ie7.css)
* Couple of translation tweaks. (Admin.french.php)
* More jQuery conversion work... Errr... Just turned a 5-line loop into a 2-line parentsUntil() chain. So what. It's a cool geeky instruction. (script.js)
- Removed a 'move' bbcode leftover. Thanks Pete! (Post.template.php)
Title: Re: New revs
Post by: MultiformeIngegno on December 9th, 2010, 08:02 PM
Great! :cool:
Title: Re: New revs
Post by: Nao on December 9th, 2010, 08:06 PM
Thanks ;)
Please post your comments in the appropriate topic though... We're trying to make this one has only the changelogs, to make it easier to go through ;)

rev 359

- Hack for ob_sessrewrite was no longer needed, as Wedge doesn't use ob_end_clean() anywhere. (QueryString.php)
Title: Re: New revs
Post by: Nao on December 10th, 2010, 12:50 AM
rev 360

* More jQuery optimization. Simplified help frame to avoid storing a variable in memory just for that. (script.js, Help.template.php, Register.template.php)
* Made submitThisOnce() work on Safari 3.0+, because the comment indicates the hack is for v1.3 beta... Logic dictates that recent builds should work fine. (script.js)
* Moved array_search() to editor.js, as it was only used over there. (editor.js, script.js)
* Spacinazi. (Subs.php, script.js)
Title: Re: New revs
Post by: Nao on December 10th, 2010, 10:00 AM
rev 361

* Converted smf_avatarResize() to jQuery, and removed some leftover code. (script.js)

I think 99% of the jQuery conversion is done in script.js... I mean, I don't really see anything else to do. I'll probably be able to save at most 10 more lines by doing micro-changes here and there... Nothing more.
Still, all in all I've managed to shave nearly 7 kilobytes off the size of script.js -- that is, about 18%, or twice more than the best I thought I could have achieved.

I have a feeling that editor.js can get a similar treatment, but I don't know if it's worth thinking about it, because of the talk on including CKEditor. I figure it means editor.js will go at some point...? Or at least most of it?
Title: Re: New revs
Post by: Arantor on December 10th, 2010, 11:50 AM
Quote
I have a feeling that editor.js can get a similar treatment, but I don't know if it's worth thinking about it, because of the talk on including CKEditor. I figure it means editor.js will go at some point...? Or at least most of it?
At least most of it.
Title: Re: New revs
Post by: Nao on December 10th, 2010, 03:12 PM
So I'm working on suggest.js instead. :P
Title: Re: New revs
Post by: Nao on December 10th, 2010, 07:26 PM
rev 362

! Fixed a SMF bug in the auto-suggest control, where the popup would reappear after selecting an entry if the typed text was the same as the suggested (and selected) text, only with different letter case. (suggest.js)
- Removed handleSubmit() function, which was really pointless, and oRealTextHandle object, which... you get the idea. (suggest.js)
+ Added subtle animation effect to auto-suggest popups. (suggest.js)
* Overall, converted auto-suggest to jQuery. (suggest.js)
Title: Re: New revs
Post by: Arantor on December 11th, 2010, 12:52 AM
Revision: 363
Author: arantor
Date: 23:37:37, 10 December 2010
Message:
! Performance enhancement to SSI's ssi_recentTopics function (thanks to live627)
----
Modified : /trunk/SSI.php

Posted: December 11th, 2010, 12:38 AM

Revision: 364
Author: arantor
Date: 23:52:11, 10 December 2010
Message:
! Fixed installer not logging in user on new install (install.php)
----
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Nao on December 11th, 2010, 01:27 AM
rev 365

* Moved storeCaret() to the footer, and made sure only IE runs it. Because only IE needs it... (Class-Editor.php)
* Made sure that the Quick Reply toggle text isn't selectable, and moved its JS call to the footer. (Display.template.php)
* Some tweaks in IE7... (ie7.css)
* ...And some other general CSS tweaks. (index.css)
- postAttachment3 doesn't exist... Does it? (index.css, rtl.css, Post.template.php)
* Replaced a few hardcoded input box sizes with CSS. Thanks live627! (Post.template.php)
* Missing capitals in a few entries. (Admin.english.php, Admin.french.php)
* Spacinazi. (Display.template.php, Post.template.php)
- What's the point in calling init() at the end of some object constructors, when we could just stay in these functions? (editor.js, topic.js)
+ Added animation effects in Quick Reply (opening, closing and switching to Wysiwyg), and started conversion to jQuery. (topic.js)
* The More Options area in the post template should be hidden immediately when collapsed, instead of triggering the relatively lengthy animation. (Post.template.php)
* Optimized spell-check JS and converted it to jQuery. (spellcheck.js)

Good luck for having a look at it all, Pete... My changes are sometimes a bit complicated -- but hopefully not buggy!!
Title: Re: New revs
Post by: Arantor on December 11th, 2010, 12:51 PM
Revision: 366
Author: arantor
Date: 11:51:13, 11 December 2010
Message:
! Fix the bugs caused by trying to code something quickly when tired (SSI.php)
----
Modified : /trunk/SSI.php
Title: Re: New revs
Post by: Nao on December 11th, 2010, 09:30 PM
rev 367

- Removed all "old theme compatibility code" related to the session variable name. Seriously, we're not compatible with SMF1 themes. Get over it. A few sesc/sc lines are left in the overall codebase, because I'm unsure whether they should be touched. (topic.js, script.js)
* Pretty much finished converting topic.js to jQuery. XML tree manipulation is way cooler with it. (topic.js)
* Converted Post template's JS area to jQuery. (Post.template.php)
- Some of the XML parsing did strange things, like concatenating all children in a node to build the quote or body strings, when the XML template would always return a single child anyway...! (topic.js, Post.template.php)
- $context['quote']['text'] and $context['quote']['mozilla'] are never used anywhere... Are they? (QuoteFast.php)
* Moved smf_addButton() to topic.js, as it's only used over there. (theme.js, topic.js)
* Minor layout tweaks and spacinazi. (index.css, Xml.template.php)
* One extra DOM node to convert to jQuery... Gotta get'em all! (suggest.js)
* Updated generateDays() to jQuery. Whatever. (Calendar.template.php, ManageCalendar.template.php, ManagePaid.template.php, Post.template.php)
! Forgot to add a dummy link to the quick reply toggle. (Display.template.php)

I can't feel my legs... Help... Hours spent just to double-check my Post template and topic.js changes... Arghhh...
Title: Re: New revs
Post by: Nao on December 11th, 2010, 11:19 PM
rev 368

! Fixed BBC button layout in IE6. (ie6.css)
Title: Re: New revs
Post by: Arantor on December 12th, 2010, 07:50 PM
Revision: 369
Author: arantor
Date: 03:53:25, 12 December 2010
Message:
+ Added ability to recount member posts into Admin / Maintenance / Members (ManageMaintenance.php, ManageMaintenance.template.php, ManageMaintenance.english.php)
----
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php

Posted: December 12th, 2010, 04:53 AM

Revision: 370
Author: arantor
Date: 04:21:14, 12 December 2010
Message:
+ Scheduled tasks can now specify a file to load that contains the actual function to be called (install.sql, ScheduledTasks.php, ManageScheduledTasks.php)
----
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/other/install.sql

Posted: December 12th, 2010, 05:21 AM

Revision: 371
Author: arantor
Date: 18:49:50, 12 December 2010
Message:
! Rewrote news fader to run in jQuery (BoardIndex.template.php, fader.js)
----
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/scripts/fader.js
Title: Re: New revs
Post by: Nao on December 13th, 2010, 01:13 PM
rev 372

+ Added automatic minification and gzipping of *all* Javascript files. Yay. (Class-Editor.php, QueryString.php, Spellcheck.php, Subs-Editor.php, Subs.php, TEMPLATES: Admin, BoardIndex, index, Login, ManageBans/Boards/Maintenance/Membergroups/News/Paid/Smileys, MessageIndex, ModerationCenter, Packages, PersonalMessage, Post, Profile, Register, Reminder, Stats, Themes)
+ Put cached JS timestamps inside the filename to help with caching, and added automatic removal of earlier cached versions. (Subs.php)
* Spent some quality time with JSLint, the infamous Javascript validator, and applied a good chunk of its hints. Thanks, man. (pm.js, TEMPLATES: Display, ManagePermissions, Packages, PersonalMessage, Post, SplitTopics)
* Replaced time_format's default day handler with %e, because I don't see why we have to cope with extra zero padding just because Windows servers can't do it... Also, SMF kept warning people against using it, but the help file was outdated (implying there was no hack to make it work), and said hack was definitely not up to date either. Anyway... Rewrote all of that. (upgrade.php, Help language, Install language)
- Did we actually ever use wedge_add_js? No? That's what I thought. Also optimized wedge_add_css(). (Load.php, Subs.php)
! Quick Reply didn't return false. Oops. (Display.template.php)
! Error box always showed up when previewing a message, even if empty. (Post.template.php)
* Spacinazi. (ManageMaintenance.php, PersonalMessage.template.php)
* Removed "min" from jquery-1.4.4.min.js because it's already long enough as it as, and renamed PersonalMessage.js to pm.js, for consistency within the scripts folder. (pm.js)
+ Added French translation for new Recount maintenance task. Also made a few tweaks to various translations. We use Cookie in French. Not Témoin. Stop with the silly French words. (Admin, Help, ManageMaintenance, Post, Themes languages)
* Fix for 'More Options' animation overflow in IE6. (ie6.css)
@ todo: add support for $modSettings['obfuscateFilenames'], add a switch for JSMin/Packer use, and make sure to always save cache in the current theme. Also, the spellcheck window is currently broken because it doesn't show anything. Needs rewriting.

(Also need to commit the rest of the JS files. Oh my, and I want to eat! And play DeathSpank!)
Posted: December 13th, 2010, 12:55 PM

rev 373

- Uh... Wrong copy/paste manipulation. (index.template.php)
Title: Re: New revs
Post by: Nao on December 13th, 2010, 04:37 PM
rev 374

+ Added support for topic subscriptions to the RSS feed feature. (Feed.php)
* Save some time on each request by caching the value of $_REQUEST['action']. (index.php)
! A preg_replace's second parameter is a proper PHP string, it doesn't follow the regex engine's twisted rules. ;) (Class-String.php)
- SMF bug: A few queries are overly complicated, because $board is already taken into account in $query_this, and they're still testing for it. (Feed.php)
! SMF bug: cdata_parse() is a byte-aware function, as opposed to char-aware, so westr::substr would find full entities instead of just an ampersang, resulting in an infinite loop. (Feed.php)

A few things to note:
- Is it a SMF bug or a Class-String.php bug? I'm thinking SMF bug, very strongly, because $smcFunc['substr'] does indeed attempt to get full entities as a single character, but I'm not fluent on the conversion work and maybe they use an alternate codepath in some cases and these cases weren't taken into account properly? I don't know. Warrants another check!
- Seriously, why didn't anyone cache the $_REQUEST['action'] in all these years...? :lol:
- The per-topic RSS feed doesn't take unapproved posts into account. Could you look into that, Pete? After implementing that feature AND fixing the cdata_parse() function, let's just say I'm not too excited to look into Feed.php even for an extra minute ;)
- The $board optimization in queries is a last-minute fix. I tested it on my local install, but I don't have "hidden" boards or anything, but I don't think they'd be related to that anyway. Seriously, another waste of CPU cycles to me...
Posted: December 13th, 2010, 04:01 PM

rev 375

! SMF bug: using PHP syntax to add a string (w00t!), and making that string an unknown variable... Assuming they mean this.opt.sUniqueId. It's a wonder this doesn't even throw an error, but it's still a nasty one. (editor.js)
! Nao bug: unknown variable in smfSelectText(). Oops. (editor.js)
- We don't need to deal with window.event in events that are initialized through jQuery. (script.js)
* Finishing the JSLint-induced changes. Most notably, adding semicolons at the end of prototype definitions. This should make it possible to compress files through Packer without the need for an extra pass of semicolon checks (see QueryString.php). Also, I didn't bother with the ==/=== suggested changes. Not confident enough in SMF's code strictness in that particular area. Finally, removed many unused variables. (admin.js, captcha.js, editor.js, profile.js, register.js, script.js, sha1.js, spellcheck.js, stats.js, suggest.js, topic.js)
Title: Re: New revs
Post by: Arantor on December 14th, 2010, 12:17 PM
Revision: 376
Author: arantor
Date: 10:44:30, 14 December 2010
Message:
! More documentation (Activate.php, Buddy.php)
! Add a hook to the buddy action in case we want to do something interesting with the new buddy. (Buddy.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Buddy.php

Posted: December 14th, 2010, 11:44 AM

Revision: 377
Author: arantor
Date: 11:17:25, 14 December 2010
Message:
! More documentation (CoppaForm.php, Credits.php, Dlattach.php)
----
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Dlattach.php
Title: Re: New revs
Post by: Nao on December 15th, 2010, 12:12 PM
rev 378

* In the main menu, if we're browsing a board, show a popup menu under 'Home' giving a link to both the forum homepage and the current board's homepage. (Subs.php)
+ Added switch for Javascript filename obfuscation. (ManageServer.php, QueryString.php, Help language, ManageSettings language)
+ Added Minify UI in Manage Server. (install.sql, ManageServer.php, Subs.php, Help language, ManageSettings language)
+ Added switch to choose jQuery server. (install.sql, Load.php, ManageServer.php, index.template.php, Help language, ManageSettings language)
+ Proceed to delete all JS from cache when JS-related options are set, and CSS as well when 'compressed data' option is set. (ManageServer.php)
* Make sure to always create cached files in the current theme's folder. (Subs.php)
Posted: December 15th, 2010, 12:04 PM

rev 379

* Replaced cdata_parse() function with a single-line thingy that should take care of it all. Revert if it doesn't work. (That's why I'm committing this apart from the rest.) (Feed.php)
Posted: December 15th, 2010, 12:12 PM

rev 380

+ Added RSS link for current board in board index, and RSS link for current topic in the button strip. There's no rss.gif file for now but I'll try to think of something to add icons. (MessageIndex.template.php, Display.template.php)
* Renamed 'RSS feed' to RSS for the reason above. I don't know if it's a good idea though, for non-techies... (index language)
+ Added a subtle shadow under help iframes. (index.css)
! Fixed spellcheck window... Err, actually, committing a proposed fix. I have no way to test it for now, ahah. I'm a funny guy. (Post.template.php)
! Minor typos. (Activate.php, Buddy.php, Credits.php)
* Replaced sizes with classes. Not that it's important at all. (SendTopic.template.php)
Title: Re: New revs
Post by: Nao on December 15th, 2010, 02:06 PM
rev 381

* Modified the php bbcode to use a proper html tag (code), and applied the same styling as with the code bbcode. The only thing missing is the "select" text, but it's not like anyone complained about its lack so far. (install.sql, index.css)

Forgot to add to the changelog that I've also changed the font size from "x-small" (which is apparently 7.5pt) to "8pt"... I don't know what "x-small" is supposed to fix, but I know that it's very small in Opera and makes it hard to read proper code. If you don't want to make it readable -- attach it as a zip file or something :lol:
Title: Re: New revs
Post by: Nao on December 15th, 2010, 07:41 PM
rev 382

* Replaced the help popup's iframe with an Ajax popup, shown with style and in pure jQuery fashion. (Help.template.php, script.js)

(The animation is a simple fadeIn effect... I tried with toggle() and it reflows the text as it enlarges. Is there a way to prevent text reflowing in this kind of animation?)
Title: Re: New revs
Post by: Arantor on December 15th, 2010, 11:15 PM
Nice!
Quote
(The animation is a simple fadeIn effect... I tried with toggle() and it reflows the text as it enlarges. Is there a way to prevent text reflowing in this kind of animation?)
I don't believe so due to the techniques used in toggle(), which IIRC is resizing as well as other things, as opposed to fadeIn being purely an opacity change.
Title: Re: New revs
Post by: Nao on December 17th, 2010, 04:25 PM
rev 383

! The cache manager didn't properly delete earlier Javascript cached files. (Subs.php)
! In Quick Reply mode, the spellcheck form was declared twice (once in the Display template, once in Class-Editor.php), causing browsers to fail finding the proper window. Sorry for the poor hack, this needs better fixing. (Display.template.php)
* script.js all alone won't work without jQuery... Will need to do this on all files that call it directly. And obfuscate the links, too. And add an .htaccess rule to prevent viewing the files from within the scripts folder. Is it me who's being paranoid here? (install.php)
* If an error is found when launching the spellcheck window, just close it automatically, instead of showing a blank page. (Spellcheck.php)
Title: Re: New revs
Post by: Arantor on December 18th, 2010, 03:41 AM
Revision: 384
Author: arantor
Date: 02:40:44, 18 December 2010
Message:
! Remove the white, black, blue, red, green bbcodes from installer - these are all removed during preparsecode anyway. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 18th, 2010, 12:41 PM
rev 385

* When forcing loading of an uncached jQuery, get it from the jQuery CDN. (install.php, repair_settings.php, upgrade.php)
! Fixed repair_settings.php to, err... At least run. (repair_settings.php)
* Rewrote some JS to add animations. (ssi_examples.php)
+ Added Aeva Media helpers (I'm working on integrating it... Even if I'm doing it outside the SVN, it has to creep into the main codebase at some point.) (Class-DB.php)
+ Implemented theme_base_js() and theme_base_css() helpers, and added them wherever I could. sphinx_config and ssi_examples will now use the current theme rather than the default one I believe, so maybe it's not a good idea for these. (sphinx_config.php, ssi_examples.php, Load.php, Subs.php, ViewQuery.php, TEMPLATES: Errors, Help, index, ModerationCenter, Packages, Post, Register)
* Commenazi and French collaborator. (ManageMaintenance.php, Install.french.php)
Title: Re: New revs
Post by: Nao on December 18th, 2010, 10:51 PM
rev 386

* Modified the license agreement to rename WedgeBox to Wedgeward (don't bother, I'll probably get around to changing it again before you know it), and add the "vbgamer45 clause". Or at least a placeholder... (license.txt)
* Renamed WedgeBox to Wedgeward everywhere else. (install.php, ssi_examples.shtml, upgrade.php, Credits.php, index.template.php, LANGUAGES: index, Install)
Title: Re: New revs
Post by: Arantor on December 20th, 2010, 04:48 PM
Revision: 387
Author: arantor
Date: 15:47:43, 20 December 2010
Message:
+ First part of the drafts system
 + Added ability to save drafts (lots of files)
 + Editor gained ability to specify buttons programmatically without editing the editor code (Class-Editor.php)
 ! Area to display drafts (Profile-View.php, Profile.php, Profile.english.php, Profile.template.php)
 ! Better display of saved drafts than original mod (MessageIndex.php, MessageIndex.template.php, Display.php, Display.template.php)
 ! Permissions (ManagePermissions.english.php, ManagePermissions.php)
 ! Admin on/off switches (ManagePosts.php, Admin.english.php)
 ! If the topic is no longer available when trying to handle a draft, display a warning to the user and handle the draft as if trying to create a new topic (Profile-View.php, Profile.template.php)

@todo in rough priority: Saving of personal messages, display of PM saved drafts, auto saving, fix what to do if a board isn't available (give the user another board to pick instead)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 21st, 2010, 12:49 AM
rev 388

* Spacinazi. (Post.php, Post2.php, Profile.php, Subs-Post.php, Profile.template.php, index.english.php)
! As a reminder, the align attribute doesn't validate in HTML5. (Profile.template.php)
* French translation for drafts. WIP. (LANGUAGES: Admin, index, ManagePermissions, Profile)
Title: Re: New revs
Post by: Nao on December 21st, 2010, 06:23 PM
rev 389

! Fixed inline topic title modification, which was awfully broken since the switch to jQuery. (MessageIndex.template.php, topic.js)
! Fixed help popup for IE. Also made sure to close the popup if user clicks anywhere outside of it. (script.js)
* wesql::insert can't accept a "default" value for its first parameter, since its remaining parameters are mandatory... (Class-DB.php)
* Added a quick hack for lazy DB insertion. This is temporary (for AeMe integration), and should probably be removed later, unless proved solid. (Class-DB.php)
* Spacinazi: replaced NULL with null, just for consistency. (Class-Editor.php, Load.php, ManageSearchEngines.php, SplitTopics.php)
! CSS minification didn't optimize "element > element". (Subs.php)
+ Added some code to prevent Packer from removing /*! comments (copyright stuff) from the compressed files. Doesn't work when the file is compressed with Packer, though (as opposed to just minified.) (Subs.php, script.js)
* Moved add_linktree() from AeMe to Wedge. (Subs.php)
* Menu tweaks. (index.css, Green/index.css, Nix/index.css, ie6.css, ie7.css, rtl.css)
* Help popup should properly underline links. (index.css)
* Adjusted voice popup to use jQuery to close its own div. (Register.template.php)
* Optimized for size reduction and taking advantage of Packer variable minification. (spellcheck.js, topic.js, script.js)
* The menu system was rewritten so thoroughly... I looked into it, and it no longer uses any of the original code, only the original idea. (script.js)
* Stopped using smf_itemPos() at all. Should we remove it? (suggest.js, script.js, topic.js)
* More jQuery optimization. (script.js)
Title: Re: New revs
Post by: Nao on December 22nd, 2010, 08:44 PM
rev 390

* Rewrote some of the menu code to make it even tighter. A bit slower maybe, but only by milliseconds. (script.js, index.css)
- Removed setOuterHTML function and replaced it with native jQuery calls. Also various minor jQuery conversions. (upgrade.php, script.js, topic.js, TEMPLATES: Admin, ManageNews, PersonalMessage, Poll, Post)
- Don't attempt to use Base62 encoding with Packer. It seems to be broken in v3.1 anyway. (Subs.php)
- Cancelling underscores in variable names to make sure they don't collide with other scripts. (topic.js)
+ A French file in SMF/Wedge wasn't completely translated. Ha! (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on December 23rd, 2010, 12:55 PM
rev 391

+ Err... I think no one bothers to test minification because I forgot to delete Class-Minify and commit the Packer class instead, ah ah. Okay, that's not funny. (Class-Packer.php)
! Duplicate filenames should be removed earlier in the caching process. (QueryString.php, Subs.php)
* Simplified Packer constructor, because basically this is a custom object and I'd rather hack into it from its class file rather than anything else. (Subs.php)
- Commented out the semicolon addition hack for Packer. This is because all of Wedge's files are fixed by now, and only those who use badly coded JS files should worry about using that code block. (Subs.php)
* Some edit_poll style optimization. At this point it's quite clear that no real thought has been put into SMF's CSS. It needs some severe reworking to make it much shorter. 59KB is a joke. (index.css)
! sha1.js being a base JS file, it shouldn't be included through add_js_file(). (Login.template.php)
! Code typo. (Post.template.php)
* Moved hashLogin/AdminPassword functions to sha1.js because they require hex_sha1() and thus shouldn't be in the main script file. (script.js, sha1.js)
* More script.js optimizations. isEmptyText() is reduced to one line because jQuery has $.trim(), same for in_array/$.inArray(), setTimeout functions don't need the 'window' prefix, used temp variables to hold long object names, etc. (script.js)
@ Note: $('<option />').appendTo(SomeDocumentFragment) doesn't seem to work. Doing it with appendChild fixes it. (script.js)
Title: Re: New revs
Post by: Nao on December 23rd, 2010, 06:25 PM
rev 392

- Got rid of those annoying eval's. (Class-Editor.php, editor.js, pm.js)
- Got rid of those annoying init's. (admin.js, pm.js, stats.js)
! Fixed BCC help popup not showing up. Complicated hack for a link no one ever clicks, uh... (script.js)
* More JS optimization. (pm.js, script.js, suggest.js)

Note for Pete: Add BCC is still slightly broken... The auto-suggest pops up where the text input was in the first place, rather than its current position. Haven't found out why. Also, I can enter my name as many times as I want, it adds it repeatedly. I seemed to remember that SMF had a mechanism to prevent duplicates. Did I break something or was I dreaming?
Title: Re: New revs
Post by: Nao on December 24th, 2010, 10:11 PM
rev 393

* Moved JS/CSS cache folder to the root cache. (cache/.htaccess, ManageServer.php, QueryString.php, Subs.php)

(I'm committing in two chunks -- this one is the quicker one as it's only one feature change, tested to work. I'll do the rest of my commits when I'm more available.)
Title: Re: New revs
Post by: Nao on December 25th, 2010, 12:02 AM
rev 394, aka the Santa Caummit. Ho ho hoooo! (Midnight, French time.)

* Made the auto-suggest popup colors a little less depressing. (index.css)
* Turned the quick edit button into a div and made it always show immediately. A big mistake from SMF, fixed at last... (index.css, Display.template.php, topic.js)
- Removed a few evil eval's. (ManageBans.template.php)
* There's no point in creating a Loading indicator if we want to remove it in the first place. (script.js)
! The Add BCC link would forget to return false as expected. (pm.js)
* More JS optimizations. (captcha.js, sha1.js, stats.js, theme.js, topic.js)
* Note to self: .first() is more logical and faster than :first if we really only want the first item in the list. (script.js)

Pete --- I really didn't have time to test all of these. Please, please make sure to check the JS files here. Most notably sha1.js (hopefully nothing broken), stats.js, theme.js and basically the other JS files (although less important.) I'm surprised I got to squeeze even more bytes out of the original files. Some of these are way shorter now... (theme.js isn't very big in the first place, but I've shaved another 30% off it I believe.)
Bed time! Merry Christmas to all.
Title: Re: New revs
Post by: Arantor on December 25th, 2010, 03:54 AM
Revision: 395
Author: arantor
Date: 01:01:38, 25 December 2010
Message:
+ Added ability to remove all drafts at once (Profile-View.php, Profile.english.php, Profile.template.php)
+ Added ability to automatically prune posts, as well as advising the user of the time drafts live for. (install.sql, ManagePosts.php, ScheduledTasks.php, Help.english.php, Profile-View.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql

Posted: December 25th, 2010, 02:02 AM

Revision: 396
Author: arantor
Date: 01:37:18, 25 December 2010
Message:
! Cleaned up how 'topic-no-longer-exists' is determined ready for later (Profile-View.php, Profile.template.php)
! Bug fixes in resaving drafts (Subs-Post.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Profile.template.php

Posted: December 25th, 2010, 02:38 AM

Revision: 397
Author: arantor
Date: 01:41:11, 25 December 2010
Message:
! Move the call to load the error language file into determineActions since this can be called from the profile area too, rather than only Who(). (Who.php)
----
Modified : /trunk/Sources/Who.php

Posted: December 25th, 2010, 02:41 AM

Revision: 398
Author: arantor
Date: 02:54:14, 25 December 2010
Message:
! Fix the installer dumping updateStats cache files in the wrong place because $cachedir wasn't brought into scope properly. (install.php)
----
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Arantor on December 26th, 2010, 02:51 AM
Revision: 399
Author: arantor
Date: 01:51:09, 26 December 2010
Message:
+ If a topic is locked, and the user does not have moderation powers, the message for drafts is handled appropriately as well as offering to make it a new topic. (Profile-View.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Title: Re: New revs
Post by: Arantor on December 26th, 2010, 05:29 AM
Revision: 400
Author: arantor
Date: 04:28:59, 26 December 2010
Message:
! Bug fix for missing legend text in admin panel (Admin.english.php)
+ Main menu items for drafts, both in posts (under profile) and PMs (under messages) (Subs.php, index.english.php)
+ Saving PM drafts (Class-Editor.php, Display.php, PersonalMessage.php, Post.php, Subs-Post.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on December 26th, 2010, 10:15 AM
Waking up... Trying to get back to work and checking your stuff...

rev 401

* Use $cachedir instead of $boarddir . '/cache'... (ManageServer.php, QueryString.php, Subs.php)
! A variable was global'ed twice. We should double-check for these... (QueryString.php)
Title: Re: New revs
Post by: Nao on December 26th, 2010, 02:16 PM
rev 402

* Renamed more window.setTimeout/clearTimeout to just the function names. (upgrade.php, Load.php, fader.js, topic.js, Themes.template.php)
* More JS optimizations. Most notably, topic.js turns a 11-line code block into a single-line jQuery call, although it has yet to be tested. (fader.js, register.js, suggest.js, topic.js)
* Spacinazi/typonazi. (Class-Editor.php, Profile.english.php, Profile.template.php, captcha.js)
* Less pinkish colors for the auto-suggest popup. (index.css)
+ French translation of new draft features. (LANGUAGES: Admin, Help, index, Profile)
* Made a help text more specific about something. (Help.english.php)
* Fixed uglyish PM post box layout. (PersonalMessage.template.php, index.css)
Title: Re: New revs
Post by: Arantor on December 26th, 2010, 05:05 PM
Revision: 403
Author: arantor
Date: 16:04:47, 26 December 2010
Message:
+ Added ability to view saved PM drafts (including fix to menu) (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php, Subs.php, index.english.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on December 26th, 2010, 08:17 PM
rev 404

* Log 404 errors as proper 404 errors. (QueryString.php)
* Renamed $pretty_* to $full_*, to make them a little more understandable here. (QueryString.php)
* More JS optimizations. (register.js)

:eheh:
Title: Re: New revs
Post by: Nao on December 27th, 2010, 03:33 PM
rev 405

* Properly record pretty URLs when logging errors. (Errors.php)
* Attempt to close opened tags when showing errors. (Errors.php)
* Minor JS optimizations. (register.js)
Posted: December 26th, 2010, 11:57 PM

rev 406

* French translation. (index, PersonalMessage)
* Minor fixes. (PersonalMessage.template.php, captcha.js)
Posted: December 27th, 2010, 01:30 PM

rev 407

* Cut captcha.js size by 30%, due to many options being unused by now. (Subs-Editor.php, captcha.js)
Title: Re: New revs
Post by: Arantor on December 27th, 2010, 05:20 PM
Revision: 408
Author: arantor
Date: 16:20:25, 27 December 2010
Message:
+ Added auto saving drafts
 + Added draft saving object, plus hopefully all the event catches for it (editor.js)
 ! Modified post and PM display areas to accept AJAX input and not output the main display (Profile-View.php, PersonalMessage.php)
 ! Modified post and PM triggers to respond with XML if XML was requested (AJAX version) since both draft handlers deal with both normal and AJAX drafts (Post2.php, PersonalMessage.php)
 ! Updated editor to output draft initialiser (Class-Editor.php)
 + Added XML return to provide draft id, last saved time/string and remove URL so that Pretty URLs can rewrite it if necessary (Subs-Post.php)
 ! Minor language string changes (index.english.php, PersonalMessage.english.php, Profile.english.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Title: Re: New revs
Post by: Nao on December 27th, 2010, 11:17 PM
rev 409

* More jQuery and Packer optimizations. (script.js, Subs.php, ManageAttachments.php, ManageBoards.php, Subscriptions-PayPal.php, GenericMenu.template.php, index.template.php)
! Clicking a menu item could cause a delay on slow browsers before the page is loaded. (script.js)
Posted: December 27th, 2010, 10:05 PM

rev 410

* More jQuery optimizations. (ManageMail.php, ManageNews.php, ManagePaid.php, ManageRegistration.php, ManageSearchEngines.php, ManageSettings.php, ManageSmileys.php, script.js, TEMPLATES: Calendar, ManageCalendar, ManagePaid, Post, Profile)
Posted: December 27th, 2010, 10:33 PM

rev 411

* Spacinazi and French translation. (Subs-Post.php, editor.js, LANGUAGES: index, PersonalMessage, Profile)
Posted: December 27th, 2010, 10:52 PM

rev 412

! On-the-fly caching regression when deleting older versions. (QueryString.php)
! Okay, sometimes a span works better than a div. (PersonalMessage.template.php)
! Missing semicolon would break minification. (editor.js)
Title: Re: New revs
Post by: Arantor on December 28th, 2010, 03:30 AM
Revision: 413
Author: arantor
Date: 01:45:40, 28 December 2010
Message:
! Minor jQuery optimisations to condense multiple selectors (ManageRegistration.php, Profile.template.php)
----
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Themes/default/Profile.template.php

Posted: December 28th, 2010, 02:45 AM

Revision: 414
Author: arantor
Date: 02:30:29, 28 December 2010
Message:
! Updated to SMF 27/12/2010 daily build equivalent
 ! Convert newlines in birthday emails into HTML linebreaks for later handling (ManageMail.php)
 ! Link in manage-search engines needs to point to the right place (ManageSearchEngines.php)
 ! Add timeout resets for deleting members. We need to revisit this sometime though. (Profile-Actions.php, RemoveTopic.php)
 ! Code niceties (Subs-Admin.php, Subs-Members.php)
 ! Removed new_win styling from URL bbc links (does it need to be done on, say, FTP as well?) (install.sql)
 ! Minor language improvements (Admin.english.php, ManagePermissions.english.php)
 ! Formatting issue in moderation center, should be a space between the number and the title. (ModerationCenter.template.php)
----
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on December 28th, 2010, 04:01 AM
Revision: 416
Author: arantor
Date: 02:46:22, 28 December 2010
Message:
! Oops, didn't fix the comment. (Login2.php)
----
Modified : /trunk/Sources/Login2.php

Revision: 415
Author: arantor
Date: 02:45:19, 28 December 2010
Message:
! Don't bother searching table for email address at login if the username doesn't contain a @ (SMF #4339) (Login2.php)
----
Modified : /trunk/Sources/Login2.php

Posted: December 28th, 2010, 03:46 AM

Revision: 417
Author: arantor
Date: 03:01:24, 28 December 2010
Message:
! Used the 'digits only' subtext on 'Number of posts' on Profile/Account Settings. (SMF #4554) (Profile-Modify.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Title: Re: New revs
Post by: Arantor on December 28th, 2010, 12:54 PM
Revision: 418
Author: arantor
Date: 11:54:01, 28 December 2010
Message:
! Prevent possible undefined index in verification code (SMF #4546) (VerificationCode.php)
----
Modified : /trunk/Sources/VerificationCode.php
Title: Re: New revs
Post by: Nao on December 28th, 2010, 05:14 PM
I'm all good with your revs...

rev 419

! Fixed and jQueried stats.js (stats.js)
* typeof-optimized most JS files. (admin.js, editor.js, profile.js, spellcheck.js, suggest.js)
! French nitpicking. (EmailTemplates.french.php, Admin.french.php)
! Typo (Profile-Actions.php)
Title: Re: New revs
Post by: Arantor on December 29th, 2010, 04:04 AM
Revision: 420
Author: arantor
Date: 03:03:57, 29 December 2010
Message:
! Bug fix to backtrace function, debugging should work properly again. (Class-DB.php)
----
Modified : /trunk/Sources/Class-DB.php
Title: Re: New revs
Post by: Arantor on December 29th, 2010, 04:51 AM
Revision: 421
Author: arantor
Date: 03:49:47, 29 December 2010
Message:
+ Paid subscriptions now have group requirements, which allows for things like discounts for renewing subscriptions. UI might need some work, and there is a bug relating to auto suggest into a textbox to deal with. (install.sql, ManagePaid.php, ManagePaid.english.php, ManagePaid.template.php, Profile-Actions.php)
----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 29th, 2010, 09:44 AM
rev 422

! Fixed a long standing IE+SMF bug where pressing Enter in an auto-suggest control would submit the form. (suggest.js)
* Tightened up some of the Javascript. (suggest.js)
* Some more cool jQuerification. (profile.js, spellcheck.js)
! Fixed undefined var. (Errors.php)
Posted: December 29th, 2010, 09:14 AM

rev 423

! [Repost] Fixed a long standing IE+SMF bug where pressing Enter in an auto-suggest control would submit the form. (suggest.js)
* [Repost] Tightened up some of the Javascript. (suggest.js)
* French translation. (ManagePaid)
- A comment implied a PHP bug when it's just a PHP limitation. (Profile-Actions.php)

(Dunno what happened with suggest.js... Probably got unchecked without my knowledge at commit time.)
Title: Re: New revs
Post by: Nao on December 29th, 2010, 02:59 PM
rev 424

! Fixed deepest menu level not always losing its hovered state when moving the mouse outside the menu area. (script.js)

(Always wanted to deal with that one... Wanted a quicker way to do it, but the event object didn't cooperate with me so I'm just testing whether the item has submenus.)
Title: Re: New revs
Post by: Nao on December 29th, 2010, 06:17 PM
rev 425

+ Added support for menu separators. (Subs-Menu.php, index.css, GenericMenu.template.php)
! Fixed top menu entry not leaving hovered state when clicking a menu item. (script.js)
* Plenty more jQuery/pure JS optimizations. (register.js)
@ Note: divHandle items in verificationFields don't seem to be used at all. (register.js)
Title: Re: New revs
Post by: Nao on December 30th, 2010, 01:07 AM
rev 426

* Modified Core Features layout to use two columns instead of one. (admin.css, Admin.template.php, ManageSettings.french.php)
* Reduced filesize of big icons in the Core Features area. (images/admin/feature_*.png)
* Very minor JS optimizations. (profile.js, stats.js, topic.js)
* Spacinazi. (ManageSettings.php)
Title: Re: New revs
Post by: Arantor on December 30th, 2010, 03:30 AM
Revision: 427
Author: arantor
Date: 02:30:15, 30 December 2010
Message:
! Undefined index moderators fix (ManageBoards.php)
+ Ability to set a default language for a given board (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, ManageBoards.english.php, ManageBoards.template.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 30th, 2010, 10:59 AM
rev 428

! For a reason that escapes me, Opera suddenly stopped registering arrow key presses in the auto-suggest. Using the same trick as in IE worked, though. Also fixed the Enter key possibly triggering wrongly when keydown and keypress events are called in a row. (suggest.js)
! Fixed auto-suggest popup position not being adjusted if it results in the master input's position being modified. (suggest.js)
- There's probably a good reason to calling autoSuggestActualHide() at the start of populateDiv(), but I couldn't find it. Removing it solved most of the issues associated with auto-suggest animations. (suggest.js)
Title: Re: New revs
Post by: Nao on December 30th, 2010, 05:59 PM
rev 429

+ Added Media Gallery and Auto-embed Core Features placeholders. This totally won't work, of course. Just wanted to make a couple of icons for future use. (The Gallery one sucks, I know.) (ManageSettings.php, ManageSettings languages, images/admin/feature_*.png)
- Removed theme_postbox() as it's SMF 1.1 emulation code. (Subs-Editor.php)
! Add BCC link was incorrectly indented in IE. (PersonalMessage.template.php)
! PM settings page was broken due to using double quotes inside an inline event. (Profile.template.php)
* At registration time, autoDetectTimeOffset() was hardcoded into the template instead of retrieved from profile.js. (Register.template.php)
* More jQuery conversions. (Packages.template.php, Register.template.php, Themes.template.php)
! Fixed news fader to show readable text in IE6 and offer better minification. (fader.js)
! IE fixes. (admin.css, ie6.css)
* Mininazi. (script.js)
* Spacinazi. (Display.template.php, Post.template.php)

@ Note: Add BCC help link seems to be broken in IE. I couldn't figure out why so far... #helf seems to fail being added to $('body') in that situation. Other occurrences work fine. I'm stumped.
Posted: December 30th, 2010, 04:47 PM

rev 430

* French translation. (ManageBoards.french.php)
* Spacinazi. (Load.php, ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on December 31st, 2010, 12:04 AM
rev 431

+ Added a few separators in the admin menu, and made minor changes to item order. (Admin.php)
! Fixed cases where separators would appear at the beginning or end of a popup menu, or would have more than one separator in a row. (Subs-Menu.php)
- IE6 and IE7 don't support separators. Don't want to waste time on them. (ie6.css, ie7.css)
! Fixed IE6 not showing BCC help popup. (PersonalMessage.template.php, pm.js)
* Minor French language fixes. (Packages.french.php)
Title: Re: New revs
Post by: Arantor on December 31st, 2010, 10:08 AM
Revision: 432
Author: arantor
Date: 08:32:14, 31 December 2010
Message:
! Widen calendar events column (install.sql)
! Fix that bloody attachments handler even in IE (Post.template.php, editor.js)
----
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/other/install.sql

Posted: December 31st, 2010, 09:32 AM

Revision: 433
Author: arantor
Date: 09:08:05, 31 December 2010
Message:
! Added a couple of missing tables to the protected list and fixed a potential issue with the static property not being defined. (Class-DBPackages.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Title: Re: New revs
Post by: Arantor on December 31st, 2010, 12:58 PM
Revision: 434
Author: arantor
Date: 11:58:28, 31 December 2010
Message:
! Re-defer profile Javascript events from being inline since they have a dependency on jQuery (Profile.template.php)
+ Gravatar support (install.sql, Load.php, ManageAttachments.php, Profile-Modify.php, Subs.php, Admin.english.php, Help.english.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 31st, 2010, 01:07 PM
rev 435

+ Added some padding around menu separators through a minor hack. Way more usable now. (index.css, GenericMenu.template.php)
Title: Re: New revs
Post by: Nao on December 31st, 2010, 05:27 PM
rev 436

* Regex simplification. (Profile-Modify.php)
* strpos() is supposedly 20% faster than the equivalent substr() test... Whatever. (Subs.php)
* French translation. (LANGUAGES: Admin, Help, Profile)
* Spacinazi. (Profile.template.php)
Title: Re: New revs
Post by: Nao on January 1st, 2011, 03:06 PM
rev 437

* Rewrote menu separator system to be slightly more semantic and still save a couple of bytes, taking advantage of the fact that anchor tags now accept children divs. (GenericMenu.template.php, index.css)
! Fixed links not being transformed in the support area, because getServerVersions() overwrites the corresponding $txt entry. (Admin.php)
* Minor changes. (ie7.css, editor.js, Help.french.php)

Note: the menu separator will now use only one <li>, but extra <a> and <div>'s are used. All in all the final code is shorter though, and a bit more semantic. Also, the separator lines no longer extend to the full width of the menus. Which is more stylish, I think. (Can be overridden.)
Title: Re: New revs
Post by: Nao on January 3rd, 2011, 12:55 PM
rev 438

- [SMF bug] Removed toggleBBCDisabled() function, as it's a SMF1 leftover. (Admin.template.php)
! Fixed year variable not getting set. (Calendar.template.php)
! A few functions were added through add_js_inline() when they were better off in add_js(). (TEMPLATES: Admin, Calendar, ManageCalendar, ManageMaintenance, ManagePaid, Packages, Post)

(I tried figuring out what that function did, to no avail. Signature settings/BBC settings are separated and their disabled BBC tags are as well, and it doesn't break anything, so I don't see the point.)
Title: Re: New revs
Post by: Nao on January 3rd, 2011, 06:14 PM
rev 439

* Turned e-mail verification regular expressions into a proper function and simplified those that can't access it. (install.php, smf_api.php, Activate.php, Post.php, Post2.php, Profile-Modify.php, Register.php, SendTopic.php, Subs-Members.php, Subs.php)
* Split editor.js into two files: editor.js has the Wysiwyg editor, and post.js has all of the helper functions and objects that are also used outside of Wysiwyg mode. (Class-Editor.php, editor.js, post.js)
* Spacinazi. (ManageBans.php)
! E-mails can't have surrounding whitespace. They're trimmed as a test, they should be trimmed for the real deal too. (Profile-Modify.php)
* Changed menu separator to use the proper hr tag, and added basic support for IE6 and IE7. (ie6.css, ie7.css, index.css, GenericMenu.template.php)
* Slightly improved link colors as well as IE7/8's menu hover colors. (ie6.css, ie7.css, index.css)
Title: Re: New revs
Post by: Nao on January 4th, 2011, 12:49 AM
rev 440

+ Since stylings are powerful theme variations, they should be allowed to call custom CSS and JS. Moved main styling (Pastel)'s CSS and JS to settings.xml and added support for such customizations. Also added {root} variable to point to the current page's root folder, regardless of the subdomain. Useful for behavior and JavaScript URLs. (index.template.php, Subs.php, css/settings.xml)
* Spacinazi & to-do list. (ManageBoards.php, ManageSettings.php, QueryString.php)
* Pixelnazi. (index.css)
* Minor code cleanup. (PrettyUrls-Filters.php, QueryString.php, Subs-PrettyUrls.php)
- For optimization purposes, two globals were unset... Twice. Kudos, SMF. (QueryString.php)
Title: Re: New revs
Post by: Nao on January 4th, 2011, 12:53 PM
rev 441

- Main theme link in admin menu didn't require a custom URL. (Admin.php)
+ Added a hook for admin settings search. (Admin.php)
! Moved some jQuery code to the footer. (Themes.template.php)

(Giving up on moving Logs to their own menu for now... It worked, but it required rewriting many templates and I got bored after a while and cancelled all of my changes.)
Title: Re: New revs
Post by: Nao on January 4th, 2011, 11:14 PM
rev 442

- Removed unused headerpadding class, and board_permissions id. (Display.template.php, ManagePermissions.template.php)
! Fixed floatright in moderation reports. (ModerationCenter.template.php)
* Turned all <div class="title_bar"> blocks into <we:title> tags that are transformed back to title_bar at runtime. (ManagePaid.php, QueryString.php, admin.css, and all 24 templates in the list)
Title: Re: New revs
Post by: Nao on January 5th, 2011, 10:12 AM
rev 443

+ Implemented basic overrides for <we:> blocks through stylings. Use this format: <block name="title"><start>|<end></block> (Load.php, QueryString.php, Subs.php)

Note: this isn't to piss anyone off, all right? :P It's all a proof of concept. Can be reverted after all. Now the idea is that if someone wants to re-implement Curve without using JavaScript to inject custom tags (i.e. small delay before curves show up on first load), they can do it through this. While this MAY go in the future, I don't think there's any reason NOT to use this as of now, regardless of what happens in future versions. The things with </we:title> is that it can be automatically replaced to a </div> with a single multi-file search & replace (while the other way around isn't possible :P)
Title: Re: New revs
Post by: Arantor on January 5th, 2011, 05:36 PM
Revision: 444
Author: arantor
Date: 16:27:33, 05 January 2011
Message:
! Bug in email checking routine returning wrong answer (Subs.php)
+ Additional hook for behavioural checking (index.php)
+ Replacement image CAPTCHA code
 - Removal of old code including old lang strings (Subs-Graphics.php, VerificationCode.php, Subs-Editor.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php, install.sql)
 + Adding new code including auto detection (Subs-Captcha.php, captcha/*, Class-GifAnimator.php, plus all files mentioned above)
----
Added : /trunk/Sources/Class-GifAnimator.php
Modified : /trunk/Sources/ManageSettings.php
Added : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Added : /trunk/Sources/captcha
Added : /trunk/Sources/captcha/captcha-grid.php
Added : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-recomposeanim.php
Added : /trunk/Sources/captcha/captcha-recomposeanim_cycle.php
Added : /trunk/Sources/captcha/captcha-recomposeanim_cycle2.php
Added : /trunk/Sources/captcha/captcha-recomposeanim_shadow.php
Added : /trunk/Sources/captcha/captcha-silhouette.php
Added : /trunk/Sources/captcha/captcha-simpleanim.php
Added : /trunk/Sources/captcha/captcha-stripes.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql

Posted: January 5th, 2011, 05:28 PM

Revision: 445
Author: arantor
Date: 16:36:34, 05 January 2011
Message:
! Oops, forgot to make the animated CAPTCHAs respect the 'use animated' option (captcha-recomposeanim.php, captcha-recomposeanim_cycle.php, captcha-recomposeanim_cycle2.php, captcha-recomposeanim_shadow.php, captcha-simpleanim.php)
----
Modified : /trunk/Sources/captcha/captcha-recomposeanim.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle2.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_shadow.php
Modified : /trunk/Sources/captcha/captcha-simpleanim.php
Title: Re: New revs
Post by: Nao on January 6th, 2011, 11:48 AM
rev 446

! A new file was in CRLF format. Bugger. (post.js)
* CAPTCHA translation. (ManageSettings.french.php)
! Fixed message margins in topic splitter, and converted code to jQuery. (SplitTopics.template.php)
Title: Re: New revs
Post by: Nao on January 6th, 2011, 03:32 PM
rev 447

! Fixed logic error when logging errors. Apart from the bad pun, I'm going to start cursing Pretty URLs. There has to be a better way to do that... (Errors.php, ManageErrors.php)
Posted: January 6th, 2011, 03:14 PM

rev 448

! Actually, rev 447 was wrong: it can be even worse. This is the proof. (Errors.php)
! Fixed error count in the main menu when meeting a 404 error. (QueryString.php)
! Two years into it, and I'm still fixing bad French text... (Admin.french.php, ManageMaintenance.french.php, Profile.french.php)
Title: Re: New revs
Post by: Arantor on January 6th, 2011, 03:42 PM
Revision: 449
Author: arantor
Date: 14:42:02, 06 January 2011
Message:
! Updated internal Bad Behaviour checks to match changes in BB 2.1.8
 - Due to a PHP bug, DNS lookups can fail and not report failure properly, so disabled those checks for the time being. (Subs.php)
 ! Two new spammer user-agents, update of existing user-agent to prevent some (rare) false positives (Security.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on January 6th, 2011, 05:10 PM
rev 450

! Gravatar e-mails were never shown after they were recorded. (Profile.template.php)
! hr's were pointlessly styled. Probably leftovers from old themes. (admin.css, TEMPLATES: Admin, ManageBoards, ManageNews, ManagePaid, Packages, Profile, SplitTopics, Themes)
* Moved the Wedge logo code over to CSS, to make it easier to hide it or remove it via stylings. (index.css, index.template.php)

Note: is ['avatar']['name'] the best place to retrieve the gravatar:// link? I'm not sure. It's also stored in another place...
Title: Re: New revs
Post by: Nao on January 6th, 2011, 11:59 PM
rev 451/452

! Fixed Javascript for CSS editor preview (it even had a leftover of pre-getXMLDocument era!), but it's pointless as right now it supports neither stylings, nor CSS caching. Anyone up for fixing that? Uh? Don't be so shy. (Themes.template.php)
! More jQuery fixin'. (Profile.template.php)
! Fixed IE6 margins for hr's. Untested. (ie6.css)
- Leftover debug code. (Themes.template.php)
Posted: January 6th, 2011, 10:44 PM

I can't believe I've been spending the last few hours debugging the css editor, when I never knew this thing existed before today.... :^^;:
It's not working, but at least I've made some progress.
BTW Pete, I think the 'default board language' setting doesn't work. I mean it works, but I've noticed it overrides my very own default language. (i.e. I forced a board to English and even though my language is set to French, it showed in English.)
Don't have time to work on checking that myself.
Title: Re: New revs
Post by: Arantor on January 7th, 2011, 09:23 AM
Revision: 453
Author: arantor
Date: 08:22:42, 07 January 2011
Message:
! Syntax error in registration screen JS (register.js)
! strftime issues dates with 0 prefixes, which upsets Javascript, so send the Unix epoch in milliseconds to build server time from instead (Profile-Modify.php, Register.php, Profile.template.php, Register.template.php, profile.js)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/scripts/profile.js
Modified : /trunk/Themes/default/scripts/register.js
Title: Re: New revs
Post by: Arantor on January 7th, 2011, 09:49 AM
Revision: 454
Author: arantor
Date: 08:48:55, 07 January 2011
Message:
+ Add a hidden input box in all instances of the verification/CAPTCHA, which will be removed if Javascript is run, or at least hidden out the way, and if this box is submitted to the CAPTCHA receipt with content, kick it back. (Bots don't normally run JS, so won't remove it, but will typically populate it.) (Subs-Editor.php, GenericControls.template.php, index.english.php, index.css)
----
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on January 7th, 2011, 12:09 PM
rev 455

+ Added support for stylings in the WYSIWYG CSS editor. (Themes.template.php)
+ Implemented a way to disable CSS caching and showing links directly for admins. Needed by the above. (QueryString.php, Subs.php)
+ Can you believe I actually forgot to implement replace-type stylings...? Unfortunately, this forces Wedge to load settings.xml for all nested stylings, but there's obviously no workaround for that. (Subs.php)
* Made CSS preview box a bit taller (from 300 to 400 pixels.) (Themes.template.php)
* More inline JS moved to the footer. (Profile.template.php)

BUG: if you browse your website from within the CSS preview iframe, it seems like the LAST component in the query string is ignored. i.e. ?action=pm with bring you to the board index, and ?action=pm;sa=send will show you the PM front page. I've been unable to find the reason for this. But frankly, this is better than nothing. Pete, let's say it bluntly, I spent hours on fixing this feature I never saw before, and I'm totally pissed off by the number of issues I had to fix. I can live with that one. If you want to look into it, please be my guest because I just won't do it.

NOTE: not yet actually committed. We both modified Subs.php (the joys of Subversion...), so it won't let me commit until I'm up to date. I'll look at your changes now, but while I'm at it: is there any point in showing a box and hiding it via JS? I mean, users with JS disabled will have a problem with it, *and* anyone writing a bot to pass through the Wedge CAPTCHA *will* notice that anyway and simply prevent the bot from filling it any other inputs... No?
Posted: January 7th, 2011, 12:02 PM

Also: your strftime stuff... What exactly does it do and fix? Is that a bug that happens everywhere?
Title: Re: New revs
Post by: Nao on January 7th, 2011, 06:43 PM
rev 456

! When using gravatars, pages would no longer validate. Thankfully, Gravatar.com seems to support ";" URL separators, so no need to wonder about turning ampersands into entities. (Subs.php)
* Split index.css into index.css, guest.css and sections.css to make it easier to browse through the main file (guest.css is just here as a test.) (guest.css, index.css, sections.css, Load.php)
* Micro-optimization. (Class-Editor.php)
* Spacinazi. Mainly removed useless tabs. (captcha-*.php, Class-DB.php, Class-GifAnimator.php, ManageMaintenance.php, PersonalMessage.php, Post.php, Profile-Actions.php, Profile-View.php, Subs-Editor.php, MessageIndex.template.php, post.js)
Title: Re: New revs
Post by: Nao on January 8th, 2011, 06:57 PM
rev 457

* Some windowbg/windowbg2 classes were missing their system wrc class. Reviewing all files to determine if they can be added. WIP. (upgrade.php, Class-Editor.php, Subs.php)
* Started work on reordering cat_bar's against title_bar's. (Admin.template.php, Packages.template.php)
! $reservedTables was incorrectly declared as $reservedTypes, causing a crash. (Class-DBPackages.php)
! Wrong smiley variable was put to the cache. (Class-Editor.php)
! Crash in list_getNumSmileys(). (ManageSmileys.php)
! Who thought it was funny to resize the title's text at the same time as the live news box? (admin.css)
* Moved Add-on link to the bottom of its menu entry. OCD stuff. (Subs.php)
* Used shorthands on a few long CSS declarations. (index.css)
- Some useless styles on legend tags. (admin.css)
! Security French language wasn't in UTF-8 mode, causing issues when showing text. (Security.french.php)
* Spacinazi. (Dlattach.php, Errors.php, ManageMaintenance.php, ManageServer.php, ManageSmileys.php, Memberlist.php, Profile-Modify.php, ScheduledTasks.php, SendTopic.php, SplitTopics.php, Subs-Calendar.php, Subs-Post.php, MessageIndex.template.php)

Note: popup in the error log is buggy. If you click a filename, it opens the source code in a 800+px high popup, even though it's requested as a 400px high popup.
Title: Re: New revs
Post by: Arantor on January 9th, 2011, 04:59 PM
Revision: 458
Author: arantor
Date: 15:59:07, 09 January 2011
Message:
! Fix the translatable captions in DB-based bbcode. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on January 10th, 2011, 04:29 PM
rev 459

- Rewrote CSS hack for the WYSIWYG editor in IE to something that actually makes sense and takes 2 lines of code instead of 74. (Class-Editor.php, editor_ie.css, ie6.css, ie7.css, ie8.css, editor.js)
! A few popup windows were missing the UTF-8 attribute while $txt was being used in them. (Errors.php, ViewQuery.php, Errors.template.php)
! Validation error with IE6. (index.template.php)
* Keeping up with changing cat/title header logic where needed. (Admin.template.php)
* Avoid an error in reattribute posts feature, if JS is disabled. (ManageMaintenance.php)
* As always, \w is the winner when it comes to regular expressions. (Subs.php)
* More JS moved to the footer. (Errors.template.php, ManageNews.template.php)
* Minor changes. (QueryString.php, index.css, Post.template.php)
+ Added a smaller logo for use in the next styling. (minilogo.png) (not documented in the SVN, sorry.)

(Another one coming up...)
Posted: January 10th, 2011, 04:12 PM

rev 460

* Rewrote member maintenance area to use jQuery. Also fixed a few SMF UI bugs in that area. (ManageMaintenance.template.php)
* More JS code moved to the footer. (ManagePermissions.template.php)
! Code viewer in the error log was buggy. Fixed presentation with a dirty hack, I'm afraid. Compensated for the extra bytes by micro-optimizing strings in that function and using a jQuery hack found in its source code for cancelling event propagation. I'm clinically insane. (script.js)
! More French translation fixes. And I thought 2 months spent on that back in 2008 were enough... (Admin.french.php)
* Minor changes. (theme.js)
Title: Re: New revs
Post by: Nao on January 11th, 2011, 12:32 AM
rev 461

- Removed $settings['theme_version'], as it's a compatibility setting for SMF1/2. Will reimplement if ever needed... Probably not! (Subs-Menu.php, Subs.php, index.template.php)
- Removed other unused compatibility variables. (Subs.php)
* More jQuery conversions and, possibly, the final removal of inlined JS code. Yay! Only got AeMe code left to convert now... It'll come in time. (ManageMembergroups.template.php, ManageSearch.template.php, ManageSmileys.template.php, PersonalMessage.template.php, Register.template.php, Search.template.php)
@ The Membergroups stuff also had indentation bugs. And it used to be faster without jQuery. Ah, well. Can't have everything. (ManageMembergroups.template.php)
Posted: January 10th, 2011, 11:57 PM

rev 462

* The sweet taste of revenge. Or whatever. Just tweaked the search area to something a bit smarter. (Search.template.php)
Title: Re: New revs
Post by: Nao on January 11th, 2011, 05:03 PM
rev 463

* Slightly enlarged source code viewer in the error log. Since it can never be too large... (ManageErrors.php)
! Fixed undefined index error when viewing a subscription with no allowed groups. (Profile-Actions.php)
- Removed unneeded '-sections' from CSS file URLs. (Subs.php)
! Not sure why, but unlink() would sometimes fail on cache files, even if they're confirmed to exist. Stat cache anyone? (Subs.php)
* CSS editor font was too small. (Themes.template.php)
* More title/cat balancing. (Admin.template.php)
Posted: January 11th, 2011, 04:00 PM

rev 464

! Pages wouldn't validate if their title had an accent in it, because the charset was defined after the title. Silly... (index.template.php)
! Missing div broke validation. (Search.template.php)
Title: Re: New revs
Post by: Nao on January 11th, 2011, 11:52 PM
rev 465

+ Added support for cat bars as list headers. Dunno, it just felt like the only way to easily fix page logic... (ManageServer.php, Subs-List.php, GenericList.template.php)
! Fixed regression introduced in rev 440 that caused URLs to be incorrectly transformed when they had a page start value. (PrettyUrls-Filters.php)
* Micro-optimization for a preg_replace. Actually, this could be turned into a simple str_replace with a trick or two. Would probably be worth benchmarking. (QueryString.php, Subs.php)

(Sorry for the regression!)
Title: Re: New revs
Post by: Nao on January 12th, 2011, 10:21 PM
rev 466

* Renamed linktree classes to IDs and rewrote template to avoid using non-semantic code to show the arrows. (index.template.php, index.css, rtl.css, Nix/index.css)
* French translation. (ModerationCenter.french.php)
Title: Re: New revs
Post by: Nao on January 13th, 2011, 05:54 PM
This is to celebrate your return! :niark:

rev 467

* Cleaned up Pretty URLs. Removed some code that prevented using an URL twice (never happens because we're always specifying the topic ID), used variable references in foreach (we're in PHP5, let's use that), removed or commented out some Noisen-specific code, removed url_id from the URL table (this was never used), micro-optimized preg_match'es by doing strpos tests beforehand (should be twice faster if the test fail, and 30% slower if it passes. May need further testing.) (PrettyUrls-Filters.php, QueryString.php)
+ Added proper support for actions in Pretty URLs. Using format /do/action, waiting for the Actions rewrite to be completed before we move it to just /action or whatever. (PrettyUrls-Filters.php, QueryString.php)
+ Added proper support for profiles in Pretty URLs. Still a bit buggy, I believe. u= needs to be set right after the profile action. (PrettyUrls-Filters.php, QueryString.php)
- Removed debug code that didn't have the corresponding helper function (obsafe_print_r) anyway. (QueryString.php)
! The determine_location hook wasn't triggered if not inside a board. (QueryString.php)
* Replaced sesc= and sc= replacements with the proper session_var. If any sesc/sc is still in the code, it should be removed. I think. (QueryString.php)
! Fixed Pretty URLs not showing its load times, and moved that to the very bottom, to include other dynamic buffer replacements. (QueryString.php)
* Added some comments about various bugs or potential issues in Pretty URLs. (QueryString.php)
Title: Re: New revs
Post by: Nao on January 13th, 2011, 08:02 PM
rev 468

! Fixed ob_sessrewrite getting called twice. Against all odds, the ob_get_contents()/ob_clean() pair does trigger the current output buffer handler, even if it doesn't destroy it later. I'd be tempted to call that a PHP bug, but anyway, maybe I'm just too dumb to understand that logic. Worked around it by putting all of the debug info into a variable, and showing it at ob_sessrewrite time, rather than getting the existing buffer. (QueryString.php, Subs.php)
- Removed an unused url_id from redirectexit(). (Subs.php)
Title: Re: New revs
Post by: Arantor on January 14th, 2011, 10:15 AM
Revision: 469
Author: arantor
Date: 09:11:32, 14 January 2011
Message:
+ New CAPTCHA: ledicons-animated (captcha-ledicons.php, captcha-ledicons_anim.php)
----
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-ledicons_anim.php

Posted: January 14th, 2011, 10:11 AM

Revision: 470
Author: arantor
Date: 09:15:29, 14 January 2011
Message:
+ Optionally display flags on board indexes for board-specific languages (install.sql, BoardIndex.php, BoardIndex.template.php, MessageIndex.php, MessageIndex.template.php, Subs-BoardIndex.php, ManageBoards.php, ManageBoards.english.php, Help.english.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on January 14th, 2011, 10:30 AM
Revision: 471
Author: arantor
Date: 09:30:03, 14 January 2011
Message:
! Enforced 'allow guests to browse the forum' being disabled - guests have no access when that's off, so no permissions, no access to anything other than logging in.
 ! Enforce it for permissions, board access in SSI context and all SSI functions (SSI.php, Security.php)
 ! Hide guests group from all reports when access disabled (Reports.php)
 ! Hide guests option from board access (ManageBoards.php)
 ! Hide guests option from all permissions UIs (ManagePermissions.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Arantor on January 14th, 2011, 11:02 AM
Revision: 472
Author: arantor
Date: 10:01:48, 14 January 2011
Message:
! Fixing an undefined index in $context (Unreadreplies.php)
----
Modified : /trunk/Sources/Unreadreplies.php
Title: Re: New revs
Post by: Nao on January 14th, 2011, 01:08 PM
I tried to separate this commit in two, to make it possibly easier to review.... But it's definitely not possible to make them even. The big new features really span too many different files.

rev 473

! Fixed /~/ URLs to redirect to current user's profile. Yeah, I know... I should use /profile/ instead. (QueryString.php)
! Fixed pretty profile URLs as shown inside subdomains. (PrettyUrls-Filters.php)
* Rewrote guest reattribution area text to make it easier to understand. At least for me... (ManageMaintenance language files)
+ French translation. (Help.french.php, ManageBoard.french.php)

rev 474

+ Added a sidebar area. Only tested under the currently uncommitted styling. (BoardIndex.php, Subs.php, index.template.php, index.css)
* Rewrote the sub-template system to allow for mini-layers. (BoardIndex.php, Load.php, Subs.php, index.template.php)
* Reordered profile URLs to always show the 'u' component in second position. (Display.php, ModerationCenter.php, Profile-Modify.php, Profile-View.php, Profile.php, ScheduledTasks.php, Subs-Menu.php, TEMPLATES: Display, PersonalMessage, Profile, Who)
- Removed leftover code: main_below test in loadSubTemplate(), function description in Subs-Members, and outdated documentation in the index template. (Load.php, Subs-Members.php, index.template.php)
- Removed all *_my classes and instead used an additional 'my' class. This won't work in IE6, but my doctor said I shouldn't care. (Green/index.css, index.css, Nix/index.css, sections.css, MessageIndex.template.php, Recent.template.php)
! Renamed linktree ID to a class, to avoid validation issues. Thanks Pete for the reminder. (index.css, Nix/index.css, rtl.css, index.template.php)
Title: Re: New revs
Post by: Nao on January 14th, 2011, 05:15 PM
Again, splitting a commit in two for easier reference.

rev 475

* Renamed some $VARIABLES to $variables. (install.php, upgrade.php, Memberlist.php, PersonalMessage.php, Profile-Actions.php, Reports.php, ScheduledTasks.php, Stats.php)

rev 476

! Sidebar was going crazy in the default styling. (index.css)
! Fixed display pages not playing along with the sidebar. Will probably have to remove all of the clear states from the code. Yikes. (sections.css)
* Turned search field into type="search" and gravatar field into type="email"... Not that it's needed, but supposedly the fallback for non-supporting browsers is type="text", so it's the call of the future. Will need to change more input fields this way, obviously. Consider this a personal note. (index.template.php, Profile.template.php)
! Fixed ignored boards indentation (whatever) in Search, and applied fixes to Profile as well (forgot that one). (Profile.template.php, Search.template.php)
Title: Re: New revs
Post by: Nao on January 14th, 2011, 09:22 PM
rev 477

! Fixed menus showing stray or duplicate separators in some cases. (Subs-Menu.php)
* Added a minor optimization to CSS if an empty rule is found. Useful if we want to offer empty placeholders. (Subs.php)
! Fixed auto-suggest on pages where only one entry is requested. (suggest.js)
Title: Re: New revs
Post by: Nao on January 15th, 2011, 01:26 PM
rev 478

! Fixed htaccess to make it work with Pretty URLs when installed in a sub-folder. (other/.htaccess)
! Fixed undefined index if query string wasn't set. (Errors.php)
! Fixed clear issues in MessageIndex. (sections.css)
Title: Re: New revs
Post by: Arantor on January 16th, 2011, 05:28 PM
Revision: 479
Author: arantor
Date: 16:28:17, 16 January 2011
Message:
! If possible, save a query for getting last post's time for a thread (for whether it's old enough there should be a warning to user) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Arantor on January 16th, 2011, 05:38 PM
Revision: 480
Author: arantor
Date: 16:37:30, 16 January 2011
Message:
! Stray poll action cleaned up (index.php, Poll.php)
+ Imperative scheduled tasks now exist though UNTESTED (index.php, Load.php, Subs-Scheduled.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Poll.php
Added : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql


Of course, imperative scheduled tasks has a new table.
Title: Re: New revs
Post by: Arantor on January 16th, 2011, 06:46 PM
Revision: 481
Author: arantor
Date: 17:46:04, 16 January 2011
Message:
+ Provide option whether moved topics can only be moved into areas the user could theoretically create a new topic in, or any board they can see. (ManagePosts.php, MoveTopic.php, Admin.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Title: Re: New revs
Post by: Arantor on January 17th, 2011, 08:16 AM
Revision: 482
Author: arantor
Date: 07:15:57, 17 January 2011
Message:
! Remove unread since last visit, so unread just triggers all unread now. (index.english.php, index.template.php, Unread.php, Unreadreplies.php, Recent.template.php)
----
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on January 17th, 2011, 08:34 AM
Revision: 483
Author: arantor
Date: 07:33:54, 17 January 2011
Message:
! Recent posts was broken, oops (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Title: Re: New revs
Post by: Arantor on January 17th, 2011, 02:13 PM
Revision: 484
Author: arantor
Date: 13:13:23, 17 January 2011
Message:
! Sync to SMF rev 10323
 ! Prevent wildcard-only censoring (ManagePosts.php)
 ! Converted passwords not recognised when using double MD5 hashing (Login2.php)
 ! Removed <b> tags that shouldn't be there (Reminder.php, PersonalMessage.template.php)
 & Wrong URL destination in 'birthday_email' help popup (Help.english.php)
 ! Extended maxlength for event titles, but see below (Calendar.template.php, Post.template.php)

!! Not applied:
 * revs 10317 and 10318 to Subs.php for the hook functions since they were previously rewritten anyway and the changes don't really apply now.
 * rev 10316 - the maxlength of event title's textbox was upped from 70 (Calendar) and 60 (Post) to 255 to match the expanded field size, except that the field is subject to htmlspecialchars which can mean cropped entities. I've moved both to 80 for us, and the fields are now correctly sized as 255 in the schema (I missed one of them before)
 * rev 10318's "pedantry" to index.css to move the definition of .new_win earlier in the file and make it fit stylistically with all the other CSS declarations.
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on January 17th, 2011, 03:37 PM
(Sorry about the hiccups. Once again...)

rev 485

@ A few of the files will be in the next commit instead. (I've got a weird way of dealing with SVN conflicts.) (index.php, Display.template.php, Post.template.php)
* Renamed $actionArray to $action_list and turned it into a global (temporarily at least), to make it easier for Pretty URLs to differentiate between actions and board names. (index.php, QueryString.php)
! Fixed relative paths when caching CSS (they were broken after the cache was moved up to the root.) (Subs.php)
+ Added a function to automatically add browser prefixes to CSS3 extensions (currently border-radius, box-shadow and transition.) (Subs.php, index.css, Nix/index.css, rtl.css)
- Started removing input_* and button_* classes, which are only useful to IE6, and added fallbacks for a couple of these in IE6 (which will probably be removed in the end.) (ie6.css, ie7.css, rtl.css, sections.css, settings.xml)
* More type="email" and adding some required fields. Also cleaned up some code and started simplifying form elements. (TEMPLATES: Display, ManageBans, Post)
* Now we can safely remove cols attributes from textareas, right...? (ManageNews.template.php)

rev 486
* in_array stuff and spacinazi. Don't mind me. Again this conflict issue. (Class-Editor.php, Load.php)

rev 487
@ Committing the rest. (index.php, Display.template.php, Post.template.php)
* French translation. (Admin, Help, index)
Posted: January 17th, 2011, 03:22 PM

Forgot to document the fact that I fixed a IE6 bug in that width:100% on any child of #main_contents broke the page. Putting hasLayout on #main_contents fixed that.
Title: Re: New revs
Post by: Arantor on January 18th, 2011, 11:24 AM
Revision: 488
Author: arantor
Date: 10:24:12, 18 January 2011
Message:
! PM unread indicator shouldn't be set twice (Subs.php)
+ Ability to mark PMs as read (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Title: Re: New revs
Post by: Nao on January 18th, 2011, 02:54 PM
rev 489

+ Added a CSS file parser that allows for plenty of nice things like nested selectors. (Class-CSS.php, Subs.php)
* Converted sections.css to use nested selectors; saved 2KB in the process. Started basic work on the index file. (index.css, sections.css)
* Now you can actually call your styling folder 'css', or whatever. (Subs.php)
* Spacinazi. (Class-Package.php)
Title: Re: New revs
Post by: Arantor on January 18th, 2011, 04:25 PM
Revision: 490
Author: arantor
Date: 15:24:41, 18 January 2011
Message:
! Sync to SMF 10336
 ! The value of checkbox custom fields were displayed incorrectly on topic display. (Load.php, ManageSettings.php)
 ! Paid subscriptions scheduled taks should be disabled when paid subscriptions feature is disabled. (ManageSettings.php, install.sql)
 & Unclear help strings for post unapproved replies and attachments permissions. (ManagePermissions.english.php)
 & Outdated information in calendar help string. (Help.english.php)
 ! The check for empty body on personal message body failed in some cases. (PersonalMessage.php)
 ! Calendar maximum year was not adjusted on forums upgraded from older versions. (Updated from 2016 to 2020 in installer) (install.sql)
 ! Member approvals did not take account deletion requests into account when registration method is not set to member approval. (ManageMembers.php, Subs.php)
 ! News items now get HTML encoded as they should be. (ManageNews.php, Admin.english.php)

!! Not applying:
 ! rev 10328: WAP template being called from Post.php; we don't have the WAP template any more thus the code does not apply to us.
 ! revs 10333-10335: SSI permissions have been fixed in SMF, by checking a new variable and if not found, booting back to the login page. Interesting approach, if a little blunt... anyway we already did our own. There is a change to side padding in SSI examples in 10334 but I figured we'd redo that anyway...
 ! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql


(This was ALL done by Sinan last night. Guy's a legend it seems.)
Title: Re: New revs
Post by: Nao on January 18th, 2011, 05:47 PM
Quote from Arantor on January 18th, 2011, 04:25 PM
! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
What did they link to instead?
So, they're dropping their awful help section for good? They should have done that much earlier...
Quote
(This was ALL done by Sinan last night. Guy's a legend it seems.)
I'm not sure what you mean by that?
Sure, it's nice that someone in the dev team has woken up -- but what's been done here accounts for about 10 kilobytes at most... I think I've done more today, and I'd even venture into saying that my daily average is actually better than that... Not to mention yours.
Anyway! :^^;:

rev 491

+ Added $context['bottom_linktree']. If set to true, the linktree will also be shown at the bottom of the page. Probably a tiny bit more flexible than the SMF implementation...? (TEMPLATES: Display, MessageIndex, index)
* Pretty much finished converting index.css to use nested selectors; saved 1.2KB. (index.css, guest.css)
* CSS parser optimizations. (Subs.php, Class-CSS.php)
* French translation. (Admin, Help, ManagePermissions)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 08:57 AM
Revision: 492
Author: arantor
Date: 07:57:21, 19 January 2011
Message:
! Sync to SMF 10337
 ! Integrated output buffers can now use static functions in classes (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 10:44 AM
Revision: 493
Author: arantor
Date: 09:44:10, 19 January 2011
Message:
! Make auto suggest extensible through hooks, and make the registration check also check that a function is truly callable as opposed to merely existing (Suggest.php)
----
Modified : /trunk/Sources/Suggest.php
Title: Re: New revs
Post by: Nao on January 19th, 2011, 12:01 PM
rev 494

! Technically, trim() doesn't work on arrays. There was also one too many trim(). (Subs.php)
* Sometimes, I wake up and I want to micro-optimize a useless function. That's who I am. Genius has got its downsides. (post.js)

(Bigger one coming up.)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 12:36 PM
Revision: 495
Author: arantor
Date: 11:36:22, 19 January 2011
Message:
! Restructure the post template into smaller chunks. (Post.template.php)
----
Modified : /trunk/Themes/default/Post.template.php
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 01:14 PM
Revision: 496
Author: arantor
Date: 12:14:07, 19 January 2011
Message:
! Scheduled tasks (regular and imperative) threw errors in browsers since the content was being requested as an image and returned in text/html MIME type (ScheduledTasks.php, Subs-Scheduled.php)
! Little tidying up of actions (index.php, Announce.php, SendTopic.php, Reporttm.php)
----
Modified : /trunk/Sources/Announce.php
Added : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on January 19th, 2011, 01:32 PM
rev 497

! Images were loaded from the wrong relative URL. (sections.css)
* Moved all opening curly brackets to the end of the rule definitions in CSS files, where it wasn't already the case. Only for consistency. (editor.css, ie7.css, ie8.css, install.css, report.css, rtl.css, webkit.css, wireless.css)
* Finished converting css files to use nested selectors. (admin.css, ie6.css, ie7.css, ie8.css, install.css, Nix/index.css, rtl.css, wireless.css)
@ Currently using table layouts in the uncommitted Warm styling... Let's just say it feel very hackish. :(
@ Need to rewrite the installer to convert index.css and install.css before using them... :-/

I have a feeling that we'll reach rev 500 today... :)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 01:35 PM
Revision: 498
Author: arantor
Date: 12:34:42, 19 January 2011
Message:
! Instead of trying to cache individual news items, let's be smart and cache the entire, bbc-parsed news item list in a single hit, saving a call to parse_bbc for every news item nearly every page. (ManageNews.php, Subs.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Subs.php


Easily, I should think :)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 02:14 PM
Revision: 499
Author: arantor
Date: 13:13:59, 19 January 2011
Message:
! Made constant variable injection (e.g. {db_prefix}, {query_see_board}) into query engine extensible without any modifications to Class-DB being required by modders. (Class-DB.php, Load.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Nao on January 19th, 2011, 02:45 PM
rev 500

+ Added basic support for OK and Cancel icons in submit buttons. It's only an example... (index.css, cross.png, tick.png)
* Dropped float-based sidebar in favor of a display:table system. Seems to work much better but it feels too hackish, and doesn't support IE6/7 (for now.) (index.css, index.template.php)

Champagne !

(And given it took me half an hour to analyze your latest commits[1] and finish up this one, I was expecting this to be rev 505 or so :P)
 1. Great stuff, as always!
Title: Re: New revs
Post by: Nao on January 19th, 2011, 03:50 PM
rev 501

- Remove media-specific query_see_* declarations, as they're in the (as yet uncommitted) media source files now. (Class-DB.php)
+ Added the Warm styling. Even though it's still a work in progress, there's really no reason to keep it away from the repository. (Warm/*)
! Fixed the Green styling. A bit. (Green/index.css)
Title: Re: New revs
Post by: Nao on January 19th, 2011, 06:17 PM
rev 502

- Removed all input_* classes, fixed many typos in that area, shortened checked/selected/disabled and basically used HTML5 goodness to simplify everything. button_* will come later. (68 files. Not gonna list them all!)
Title: Re: New revs
Post by: Nao on January 19th, 2011, 09:55 PM
rev 503

* Started work on button_submit conversions. Yes, I'm slower than earlier today. (install.php, SSI.php)
* Turned all string calls in setTimeout to proper function calls. Death to eval! (create_backup.php, repair*.php, restore_backup.php, upgrade.php, Load.php, TEMPLATES: Admin, Announce, ManageMaintenance, ManageNews, ManageSearch, Packages, Profile, Themes)

Thanks to w3fools for the tip on JS... I didn't even know it was possible and it pissed me off when I made the original reworking for jQuery. I never realized SMF used proper functions at some (rare) points.
Title: Re: New revs
Post by: Nao on January 20th, 2011, 12:02 AM
rev 504

+ Added a new button class, save, which should be semantically appropriate for a lot of areas, beginning with drafts. Also added spell class but it's unstyled for now. (Class-Editor.php, icons/save.png, Profile.template.php)
+ Styled search-type inputs. Dunno if it's a good idea to always show that icon in the header, though. (Admin.template.php, index.template.php, index.css)
! Inherited stylings didn't correctly reproduce the <we:> templates. (settings.xml)
* More abuse of the simpler, shorter HTML5 tag format. (index.template.php)
* More button conversions. And yes, I know, it still all looks ugly... And the Cancel button is broken, now. (index.css, Profile.template.php, Themes.template.php)
! The W3C Validator for HTML5 suddenly started giving errors on the JavaScript code in the debug footer, saying "invalid return". I'm sorry, man, but return false is totally justified here. Ah, well. Went back to SMF's way of doing it (javascript:void(0)). (Subs.php)
! Fixed an undefined offset error in the admin quick search. (Admin.php)
* Inpunazi. (install.sql)
Title: Re: New revs
Post by: Nao on January 20th, 2011, 11:39 AM
rev 505

* Added 'delete' and 'new' input buttons, converted some more button-heavy templates and resumed <we:> transforms. (Admin.template.php, ManageBoards.template.php, ManageMaintenance.template.php, index.css, add.png)
! Fixed the Cancel button and added a small 3D effect. Not as visible as in SMF, though. But they don't have icons in buttons. (index.css)
+ Added proper (temp?) hack for display:table in IE6 and IE7. May I say one word? "Ewwwwwwwwwwwwwwwww." (index.template.php)
* Made core feature boxes slightly larger. Even IE6 seems to accept 50% here, so why bother. (admin.css)
! Fixed a potential XML error when parsing CSS under IE. (Class-CSS.php)
! An input_* class had escaped me. Rats! (Display.php)
! Commenazi. (Subs.php)
Title: Re: New revs
Post by: Arantor on January 20th, 2011, 12:34 PM
Revision: 506
Author: arantor
Date: 11:32:46, 20 January 2011
Message:
! Move draft post settings into their own little menu (Admin.php, ManagePosts.php, Admin.english.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/languages/Admin.english.php


I like the revision to the buttons - they're back to being as 3D-ish as they were before IMO, but the rounded corners are a nice touch.

The only search type input I see that's affected is the one in the admin panel, but that's not looking right anyway.
Title: Re: New revs
Post by: Nao on January 20th, 2011, 05:06 PM
rev 507

* Fixed form inside the h3 tag. The div will be fixed once we:cats are written to use something more flexible. Or whatever. (Admin.template.php, admin.css, rtl.css)
+ Added a white bevel inside buttons (only for modern browsers.) If you can spot the difference without zooming, you don't need glasses. It's only a test. (index.css, bevel.png)
! Safari and Chrome don't like CSS on search-type inputs. Thankfully, they provide a workaround for that... (webkit.css)
* Some more conversion work. (PersonalMessage.template.php)
* French translation. (Admin.french.php)
Title: Re: New revs
Post by: Arantor on January 20th, 2011, 05:56 PM
Revision: 508
Author: arantor
Date: 16:56:19, 20 January 2011
Message:
! Length parameter should have been in the truncate function (Class-String.php)
----
Modified : /trunk/Sources/Class-String.php
Title: Re: New revs
Post by: Nao on January 21st, 2011, 04:29 PM
rev 509

* Finished remodeling buttons in a way that I actually appreciate. Also added a workaround to see icons in IE -- they will have to be moved to the semantically more relevant ie*.css when the number of icons has stabilized. (index.css)
* Replaced button icons with a single sprite and provided an original copy (for modifications) and a copy processed through "pngquant -nofs 64" (to save bandwidth.) (buttons.png, buttons-32bit.png, add.png, cross.png, save.png, tick.png, index.css)
- Removed the original button background. Nothing that can't be replaced with a bevel (4 times smaller). IE? Screw IE. (submit_bg.png)
* Continuing we:cat transforms and button class additions. (Display.template.php, PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on January 21st, 2011, 07:26 PM
rev 510

+ Added very preliminary (and thankfully short) code to automatically switch between sidebar and jumbo footer depending on the window width. Jumbo footer isn't styled at all. (index.template.php)

(Just to get that out of my way... :P)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 01:07 AM
rev 511

* Started converting < br /> to < br> in the code logic. Well, hopefully it won't screw it up... (install.sql, Profile-Modify.php)
* Continuing work on simplifying self-closing tags, replacing button classes and transforming <we:cat>s. I don't even known why I'm doing all of these manually. (sphinx_config.php, create_backup.php, repair.php, Profile-Modify.php, Profile.template.php)
! Fixed png backgrounds in Nix for IE6. (Nix/ie6.css)
* Indenazi. (Profile.template.php)

Going to bed... Leaving you the very geeky rev 2^9 ;)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 03:49 PM
Okay, well apparently I'm getting 2^9 too :P Too many changes to leave them hanging. Don't worry, you can safely update your svn without checking everything, I double-checked all br and hr conversions.
Also forgot to mention that I added more <we:cat>s and button classes, as usual. (In Search)

rev 512

! The Search menu item shouldn't have submenu entries if simple search is disabled. (Subs.php)
* Turned < br /> into < br> on all template and language files. Also did it for < hr> and class'ed variations. I know, it's a bit scary when you're using to XHTML... But it saves a whooping 1.6kb of template code. What do you mean, "who cares?" (All templates but 8 (should make sure no XHTML templates are touched), most language files, spellcheck.js, settings.xml)
! Fixed a small issue with the dynamic sidebar in IE. Might be useful for other browsers, too. (index.css)
! Button icons were incorrectly positioned in simple search mode. (sections.css)
* Updated Warm styling to the recent template changes. (Warm/admin.css, Warm/index.css, Warm/webkit.css)
Posted: January 22nd, 2011, 02:28 PM

rev 513

! Fixed <we:cat> not being converted in the default styling. Oops, that's what happens when you never use it... (Load.php)
* Continuing we:cat, button_submit and self-closing tag conversions. Statistics: 729 self-closers, 268 cat_bars and 79 button_submits left to convert... And that's only in the templates. Someone help me please, I'm gonna drown. (TEMPLATES: Announce, Calendar, Errors, Login, Memberlist, MessageIndex, ModerationCenter, Themes, Who, sections.css)
* Moved #sidebar to a semantically more logical place in index.css, and added vertical-aligns, even though it should already be the default one. You never know. (index.css)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 04:58 PM
rev 514

- Removed a bunch of useless ' . ' (no need to concatenate two strings like that...) (repair_settings.php, Load.php, ManageSmileys.php, Packages.php, Search2.php, Subs.php, Themes.php, BoardIndexInfoCenter.template.php, Memberlist.template.php)
* Simplified a serious amount of hacks regarding \<\? and such, replaced br regexes with stronger ones, continued HTML5 conversions and the usual crap. (Admin.php, Class-Package.php, Load.php, ManageRegistration.php, Packages.php, PersonalMessage.php, Post.php, QuoteFast.php, Themes.php)
! Here's a funny regex. "Look for anything that isn't >. Then, look for something that isn't /, followed by >. But if there's no /, it's still okay." Can someone tell me why they're looking for / at all?! Just leaving out the "it's still okay" portion, because it makes sense to prevent the / at the end in script and style tags because they're not self-closing. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 07:25 PM
rev 515

* The commit that may make or break Wedge... Self-closing tag conversions for the entire Sources folder. Also converting button_submit classes and the usual rest. (Announce.php, Class-DB.php, CoppaForm.php, Display.php, Errors.php, Groups.php, Load.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManageRegistration.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Packages.php, PersonalMessage.php, Post2.php, Profile-View.php, Profile.php, QuoteFast.php, Reminder.php, RemoveTopic.php, Reports.php, Search2.php, Security.php, SplitTopics.php, Subs-Auth.php, Subs-BoardIndex.php, Subs-Menu.php, Subs-Package.php, Subs-Post.php, Subs-Recent.php, Subs.php, Subscriptions-PayPal.php, Unread.php, Unreadreplies.php, ViewQuery.php, Who.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 10:23 PM
rev 516

* Using non-xhtml version of nl2br (thanks Pete!) (install.php, restore_backup.php, upgrade.php, Class-DB.php, ManageMail.php, Packages.php, Subs.php, ViewQuery.php)
! Finished a regex conversion which I'd forgotten in the last rev. (Packages.php)
! Fixed an SMF bug with strong tags not being taken into account. (Themes.php)
+ Added left and right classes for img tags. Not used for now. (index.css)
* Self-closing tags. (install.php, restore_backup.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2011, 06:30 PM
rev 517

* Finished HTML5 conversion work, w3:cat and button_submit transforms. Ahhhhhhh!!! (create_backup.php, test_modification.php, repair*.php, Load.php, Admin.english.php, Admin.french.php, editor.js, script.js, suggest.js, topic.js, TEMPLATES: Admin, Announce, BoardIndex, BoardIndexInfoCenter, Display, GenericControls, GenericList, GenericMenu, Help, Login, ManageAttachments/ Bans/ Calendar/ Mail/ Maintenance/ Membergroups/ Members/ News/ Paid/ Permissions/ ScheduledTasks/ Search/ Smileys, ModerationCenter, MoveTopic, Notify, Packages, PersonalMessage, Poll, Post, Printpage, Recent, Register, Reminder, Reports, Search, SendTopic, SplitTopics, Stats, Themes, Who)
! Missed one search input conversion. (Search.template.php)
! Typo. (Search.english.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2011, 08:50 PM
rev 518

+ Added support for CSS variables, as well as the ability to set their values depending on the current CSS state (browser, rtl, login...) (Class-CSS.php, Subs.php)
+ Added ability to supply a member.css file for logged in users. (Load.php)
+ Added the following default CSS variables: $images, $theme, $root and $here. (Subs.php)
* Renamed {root} to $behavior in settings.xml, to make it easier to understand, in light of the new CSS variables. (Subs.php, settings.xml)
* Tweaked Nix header settings for a less dark outcome. (Nix/index.css)
! The dynamic sidebar doesn't work in IE6 and IE7. Tweaked the code to at least avoid error messages at startup. Will require a deeper rewrite later, though. (index.template.php)
! Fixed a couple of wrong URLs and added a sample variable to the Warm styling. (Warm/index.css)
- Removed relative path fixer, as it was no longer needed. (Subs.php)
- Removed h3.grid_header, as it's never used anywhere. (admin.css)
* Rewrote button hack for IE6 in Pastel. Now it should actually work. (ie6.css, settings.xml)
* Rewrote CSS files to use $images instead of relative paths. (admin.css, editor.css, settings.xml, index.css, rtl.css, sections.css)

(Phew!!! At last, finished with the big commits :))
Posted: January 23rd, 2011, 08:45 PM

rev 519

* Fixed a few inverted rules and added a newline to the beginning of all CSS files (for consistency.) (css/*.css)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 12:15 AM
rev 520

! Fixed a SMF bug: a deletion confirmation was apparently only asked... if the entered data was invalid in the first place. (ManageSearch.template.php)
! Fixed a Nao bug: autoSetup() was broken during the conversion to jQuery. (register.js)
* Converted most of the remaining stray getElementById's in inline events. Left aside the ones that can't use jQuery, and those that are in loops. (Calendar.template.php, ManageMembergroups.template.php, ManageSmileys.template.php, MoveTopic.template.php, Profile.template.php, Register.template.php, post.js, register.js, script.js, suggest.js, topic.js)
* Converted admin.js to jQuery... Yes, apparently I'd missed the file. (admin.js)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 10:17 AM
rev 521

+ Added ability to add double quotes around CSS variables (allowing empty strings to be set), and recursive replacements to allow using variable names inside other variable definitions. (Class-CSS.php)
* Updated button code to provide IE fixes for IE only. (index.css)
* Backported Warm changes to Pastel. (index.css)
+ Added a proper member-only file to both Pastel and Warm. (member.css)
* Styled Remove button in the post attachment area. (post.js)
! Fixed bevel in Simple Search area's search button. (sections.css)
! Typo. (admin.js)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 04:31 PM
rev 522

+ Added very basic support for CSS functions, starting with darken() and lighten(). They don't even take luma coefficients into account, ah ah, what a noob! (Class-CSS.php, Subs.php, index.css)
* In Post pages, show the original post's title in linktrees under square brackets and without extra spacing. Looks a tad better this way. (Post.php)

(Class-CSS adds a few functions from the PHP port of Sass -- I will end up using them, and I credited the originals, even though they're quite short and not exactly rocket science for anyone interested in RGB vs HSL.)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 08:41 PM
Trying to change my mind after my complete and utter failure in RL... :(

rev 523

! Fixed SMF bug (how many SMF bugs have we found these last few months really?!), where the second JavaScript block in constructPageIndex wasn't updated to use JavaScriptEscape, resulting in (1) a small waste of time, (2) a fully visible incorrect URL, resulting in Google being able to fail on it. (Subs.php)
* Moved inline styling to the correct place. (Subs.php, index.css)
* Simplified titles and categories in Warm. (Warm/index.css, Warm/settings.xml)
Posted: January 24th, 2011, 08:39 PM

rev 524

! Woops. (Subs.php)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 09:23 PM
rev 525

+ Rewrote darken/lighten to use a more realistic HSL transform, and added support for saturize(), desaturize() and hue(). Yeah baby. Tell me it sends shivers down your spine. (Class-CSS.php, Warm/index.css)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 11:24 PM
rev 526

+ Added support for base64 encoding of images for non-IE browsers. Heck, it actually works, *and* compresses to the same size as usual... I don't even know if it's worth adding a setting to disable it... (Class-CSS.php)
! Fixed wrong hex encoding for RGB components lower than 16. (Class-CSS.php)
+ Added support for nested functions (darken(desaturize($color, 10), 10)) (Class-CSS.php)
Posted: January 24th, 2011, 11:09 PM

rev 527

! IE6 and IE7 don't support data URI schemes. Bad IE. (Subs.php)

@ Also of note: if you update an image, you need to also empty the cache or update a css file because Wedge won't guess it by itself... Seriously, I'm not checking all of these files on every page load!
Title: Re: New revs
Post by: Nao on January 25th, 2011, 05:41 PM
rev 528
(26 files, 31kb transferred)

! JPG images should have a MIME type of image/jpeg, not image/jpg. (Class-CSS.php)
* Minor changes. (Subs.php, latest-packages.php)
* Optimized CSS to only load some repeated images once. The size savings are better than I expected. (index.css, sections.css)
+ Added 'search' and 'cancel' classes to related inputs, to make it faster to find them (and avoid using some JS in IE.) There weren't a lot of them anyway. There's also one in Display but I'll commit it later. (sections.css, settings.xml, TEMPLATES: Admin, index, ManageAttachments, ManageBoards, Memberlist, PersonalMessage, Profile, Search)
! Fixed title_bar and cat_bar to title and cat classes. (Warm/admin.css, ie6.css, ie7.css, index.css, rtl.css, sections.css, webkit.css)
! Fixed icons, button padding and general handling of inputs for IE. (ie6.css, ie7.css, ie8.css, index.css)

PS: I'll try, from now on, to indicate the stats given by TortoiseSVN after I'm finished committing. This should make it easier to determine the amount of data you'll have to check. ;)
Title: Re: New revs
Post by: Nao on January 25th, 2011, 11:48 PM
rev 529
(1 file, 7kb)

! Fixed SMF bug: clicking frenetically the Quick Modify button at load time could result in errors and UI glitches. Fixed by only setting the edit mode as active after the actual original message is received. (topic.js)
* Let's just make this clear: if I'm editing a post, and I'm suddenly clicking the Quick Modify button for it, IT'S PROBABLY NOT WANTED. Cancelling any such actions. If you want to start a message over, use the Cancel button and then click Quick Modify. (topic.js)
* bInEditMode was redundant, using sCurMessageId now. Also replaced in Display.template.php, will commit later. (topic.js)

(It may not be the best fix, if only because I'm not even sure it fixes it, but it certainly works great in IE6 and Opera 11, where I tested, and it's a clean and short solution, as mentioned before.)
Title: Re: New revs
Post by: Nao on January 26th, 2011, 11:15 AM
rev 530
(12 files, 13kb)

! Fixed a SMF bug: if the outbox isn't empty, people should still be able to view it, even if they can't send *new* PMs. (PersonalMessage.php)
+ Added a message saying "A response to this message was sent." if you're viewing your outbox and at least one of the recipients replied to a message. This was way overdue... (PersonalMessage.php, PersonalMessage.english.php, PersonalMessage.french.php, PersonalMessage.template.php)
- Removed mentions about forwarding in "You have responded to this message". It was confusing. Whether you reply to the original poster or to someone else is your own choice, but it's not proper "forwarding". PMs are often private and this shouldn't be encouraged too much. (PersonalMessage.english.php, PersonalMessage.french.php)
! Fixed a variable collision due to a micro-optimization in smc_saveEntities. (script.js)
! Fixed a small IE6 layout issue in topic pages. (Display.template.php)
! Fixed potential browser errors if you're trying to access the quick modify or quick reply areas before they're actually initialized. Which should only happen if you're trying hard at doing it, really. (Display.template.php)
* A few !!!SLOW comments were converted to !!! SLOW. I just can't live with the idea of missing spaces. (Memberlist.php, PersonalMessage.php, Profile-View.php, Recent.php, Subs-Boards.php, Subs-Recent.php)
* Spellinazi -- 'accessable'. Urgh. (readme_convert.html, Subs-Recent.php)
Title: Re: New revs
Post by: Nao on January 26th, 2011, 03:55 PM
rev 531
(8 files, 14kb)

+ Added ability to see the number of users who replied to a PM in the event of a mass PM. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php, PersonalMessage.french.php)
! A regression in last commit concealed PM recipients in the inbox. (PersonalMessage.php)
! In the CSS parser, any hex RGB output could be corrupted by incorrect numbers, and didn't round numbers correctly. (Class-CSS.php)
* Don't add the 'o' prefix to Opera files when parsing box-shadow and border-radius. Ah ah, what a weird hack... (Subs.php)
* Modified comment stripping to actually keep comments starting with /*!, just like when parsing JS files. (Class-CSS.php, Subs.php, Warm/index.css)
* Disabled double clicks on the Quick Modify buttons. I need help, now. (Display.template.php)
Posted: January 26th, 2011, 03:18 PM

rev 532
(4 files, 15kb)

+ Added a Spellchecker icon of my making. (index.css, buttons.png, buttons-32bit.png)
Title: Re: New revs
Post by: Nao on January 26th, 2011, 10:25 PM
rev 533
(3 files, 6kb)

! Fixed toggler glitch where if the starting position was collapsed, the block would open and then animate to disappear. Uh. (script.js)
- Started removing nocsscache code... It's neat and all, but the CSS previewer is going away. Bye bye, we won't miss you that much, you can't fight the goodness that is CSS parsing. (QueryString.php, Subs.php)
+ Added a 'dynamic_rewrite' hook in ob_sessrewrite, to allow manipulating the buffer before the URLs are handled by the Pretty URLs module (the output buffer hook system happens *after* they're transformed, so it was really needed.) (QueryString.php)

(Toggler bug was visible in the news fader area on the board index, btw.)
Title: Re: New revs
Post by: Nao on January 27th, 2011, 09:30 AM
rev 534
(7 files, 13kb)

! Fixed the dreaded 'This address is already in use' that Pete hated so much. Eheh. (Subs-Boards.php, Subs-PrettyUrls.php)
! Translation errors or improvements. (ManageBoards.french.php, Themes.english.php, Themes.french.php)
Title: Re: New revs
Post by: Nao on January 27th, 2011, 04:35 PM
rev 535
(3 files, 12kb)

+ CSS parser now sports support for: alpha function (alpha(rgb(255,255,255), -.25) returns rgba(255,255,255,.75) if the browser supports it), named colors (the 16 basic HTML ones plus 'grey' for Pete's sake), hsl, hsla, rgba, mixed case, and 3-letter hex codes. PHEW! (Class-CSS.php)
* In case of a syntax error while parsing CSS, you'll get a big red color instead. That should tell you where to look... (Class-CSS.php)
! Since HTML5 is case-insensitive, inline event tags should be as well. (QueryString.php)
! &quot; is automatically turned into a double quote inside inline events, but this is not the case outside of these. Converting them manually. (QueryString.php)
! Fixed the very annoying bug where newlines in JavaScript alerts/confirms were shown in plain text as \n. Oh, this one was annoying. (QueryString.php)
* Dotnazi. (Profile.english.php)
Posted: January 27th, 2011, 04:22 PM

BTW, some friends are visiting in a few minutes so I'll probably be offline for the entire evening. ;)
Title: Re: New revs
Post by: Nao on January 28th, 2011, 12:05 PM
rev 537
(23 files, 78kb, mostly clean-up though)

+ The CSS parser now accepts variable names with a dash in them (they're supported in class names so why not vars?), and now limits the maximal filesize for data inclusion to 4KB, because it really shouldn't accept more, technically and ethically. (Class-CSS.php)
* Loaded all CSS files together before calling the CSS parser. This improves performance by about 20% here. (Subs.php)
- Removed a few unused strings in the Install language files, as well as many &nbsp;'s found in alert or confirm boxes. JavaScript doesn't like that. Also did minor tweaks. (LANGUAGE: Install, ManageBoards, ManageCalendar, ManageMaintenance, ManageSmileys, ModerationCenter, PersonalMessage, Profile, Search, Themes)
! Some of the new files were in CR-LF format. Okay, I've added to my to-do-list that I should quit all of my Notepad2 windows and change the default format to LF. It has to work at some point hasn't it? (guest.css, ie8.css, member.css, sections.css)
* Layout tweaks to the moderation report viewing page. (ModerationCenter.template.php)
Title: Re: New revs
Post by: Arantor on January 28th, 2011, 12:18 PM
Revision: 538
Author: arantor
Date: 11:17:30, 28 January 2011
Message:
! Updated bundled Bad Behaviour install to 2.1.10, involving:
 + Add less hackish proxy support (Admin.php, Admin.english.php, ManageServer.php, ManageSettings.english.php, Help.english.php, QueryString.php, Security.php)
 ! Test for Yahoo's bot should have been included before but was overlooked, but at least I translated that one into French, even my rusty language skills could do that! (Security.php, Security.english.php, Security.french.php)
 ! Rejigged the tests for Google, MSN and Yahoo to test the IP against the known netblocks first (again, originally part of BB anyway) (Security.php)
 ! Confirmed licence notes for BB as being LGPL 3.0 and included a good-faith note regarding our lack of inclusion of the GPL and LGPL licence files. (QueryString.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/Themes/default/languages/Security.french.php
Modified : /trunk/other/install.sql


I implemented the UI back into the original admin panel for now simply because I'm still trying to figure out where everything needs to go, so reverted the (minor) changes in code to keep parity with SVN for now. All my real work's on paper at the moment...

There was also a bug fix in the code that BB had to have, but I'd already fixed around it anyway (the test for allowing external forms needed tweaking but I'd already tweaked it to work properly)
Title: Re: New revs
Post by: Arantor on January 28th, 2011, 02:05 PM
Revision: 539
Author: arantor
Date: 13:04:38, 28 January 2011
Message:
! Create a recycling board by default on install. (install.sql, Install.english.php)
----
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on January 28th, 2011, 06:01 PM
rev 540
(6 files, 15kb)

+ Added a slightly dirty, but still relatively fast and totally awesome[1] 'base' CSS property, where you can easily inherit an existing class or even an existing tag structure. If it turns out to be bug-free, we can safely remove the 'BasedOn' plugin. (Class-CSS.php)
* Replacing a preg_match with a strpos is always best. Especially, *especially* when you're calling it in a huge loop. (Class-CSS.php)
* We're not using getNodesByNodeName in other areas, so optimized it to fit our needs. @todo: determine whether the XML parser always returns uppercase tags, in which case we can do without the strtolower(). (Class-CSS.php)
* Started using base: and optimizing Warm. It's just an example but it works well as it is. (Warm/index.css, Warm/sections.css)
* Minor performance optimization. That silly PageSpeed plugin told me to. Ask him. (index.css)
* Renamed CSS cache classes to something more, err... memory-cacheable. (Class-CSS.php, Subs.php)
! Fixed wrong CSS nesting. (css/sections.css)
 1. I'm serious. Took me all afternoon to figure out how to implement that, and that was well worth it.
Title: Re: New revs
Post by: Nao on January 28th, 2011, 06:40 PM
(Pete, you forgot to post that one ;))

Revision: 536
Author: arantor
Date: 10:30:00, vendredi 28 janvier 2011
Message:
! Sync to SMF rev 10346
 * Incorrect fallback for pm receive options when buddy/ignore lists are disabled. (Profile.template.php) [Bug 4596]
 ! Upgrade did not update group types. (NB I did alter the change to use 'have not' instead of 'haven't' due to possible issues with the ' in the upgrade script. (upgrade.sql) [Bug 4577]
 ! Protected but visible group details could not be viewed by non-admins. (Groups.php) [Bug 4525]
 ! Search returned incorrect results for database users without create_temporary privilege. (Search2.php)
 ! Search may result in database errors for database users without create_temporary privilege. (Search2.php)
 & Copyright years update (index.english.php, index.french.php, install.php, upgrade.php)

Not applied:
 ! r10338 Removal of .new_win class definition (the one that was width: 400px, height: 400px) as it wasn't in our theme anyway.
 ! r10339 Fix for buffers trying to call arrays whose contents were not being trimmed; Nao already implemented more thorough trimming.
----
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/upgrade.sql
Title: Re: New revs
Post by: Nao on January 28th, 2011, 06:46 PM
rev 541
(6 files, 10kb)

* French translation. Although, I have absolutely no idea what this is talking about. CIDR blocks for IP zone HTTP headers? Yeah sure, I'll call my lawyer and I'll get back to you. (Admin, Help, Install, ManageSettings)
* Thou shalt not commit XHTML, especially after all the time it took me to convert the damn templates back to dirty HTML :P (Profile.template.php)
Title: Re: New revs
Post by: Nao on January 28th, 2011, 09:15 PM
rev 542
(8 files, 17kb)

- Removed BasedOn plugin -- it's clearly inefficient compared to the new base: feature, and I shouldn't encourage its use. (Class-CSS.php, Subs.php)
* Moved OpenID graphics to guest.css (why did I forget that?), converted more rules to use base:, removed some styles that were never applied or duplicate. (index.css, sections.css)
Title: Re: New revs
Post by: Nao on January 29th, 2011, 04:08 PM
rev 543
(1 file, 8kb)

+ Color functions now accept percentage values. (Class-CSS.php)
! Fixed rgb_output() treating a=0 as having full opacity. Simplified the function. (Class-CSS.php)
+ Added channels() function to treat each RGBA channel separately. Example: channels(rgba(255, 128, 0, .5), -50, -50%, 255, -50%) should return rgba(205, 64, 255, .25). The alpha channel is not mandatory. It also works to change RGBA channels on HSLA colors, if you ever want to do that. (Class-CSS.php)
* Improved regex to be more restrictive with alpha declarations (it used to accept "0.5.1"). (Class-CSS.php)
Posted: January 29th, 2011, 02:58 PM

rev 544
(4 files, missed size, not much.)

! Fixed JavaScript error when the page counter allowed expanding to the right. (Subs.php)
! Fixed inverted background coordinates on a couple of icons. (sections.css, post.js)
* The Send PM page should use a cat instead of a title. (PersonalMessage.template.php)
Posted: January 29th, 2011, 03:46 PM

rev 545
(7 files, and AGAIN missed size and it's not much.)

+ Added a warning at install time if libxml is not activated. (install.php, readme_*.html, Install.english.php, Install.french.php)
* Does SMF2 *really* install on a server with 2.5MB of storage space, eh? I'd say at least 10MB... Let alone when Wedge gets AeMe as default... (readme_*.html)
* Saving 6 bytes of code. Don't worry, that's only because I tried adding some menu animations, wasn't too happy UI-wise, reverted and just kept the only worthy change. Uh. (script.js)
Title: Re: New revs
Post by: Nao on January 30th, 2011, 12:21 AM
rev 546
(12 files, 19kb)

! Rewrote HSL conversion to fix a few bugs, notably the hue being rounded incorrectly when the processed color was mainly red. (Class-CSS.php)
* .windowbg2 and .windowbg3 should always have inherited from .windowbg, from day one. The resulting files will be a few bytes larger because of newly added selectors, but it's for the better really. (index.css, admin.css, Nix/ie6.css, report.css, sections.css, wireless.css)
* Moved all PM-related CSS to the member-only CSS file, as it's very, very unlikely that you ever receive a PM if you're guest. If I were you, I wouldn't hold my breath waiting for that. (sections.css, member.css)
- Removed .lower_padding class (never used). (index.css)

Forgot to document: harmonized linktree with the bottom version. (padding, etc.) Added a temp background color to it.
Title: Re: New revs
Post by: Nao on January 30th, 2011, 04:30 PM
rev 547
(5 files, 11kb)

* Renamed $context['browser'] to a new $browser global, and referenced it into $context['browser']. Memory concerns I'd say. (Class-CSS.php, Load.php)
+ Added support for percentage values in rgb, rgba, hsl and hsla colors. (Class-CSS.php)
+ Added a workaround to get IE6/7/8 to support rgba, hsl and hsla colors. Oh yeah. (Class-CSS.php)
* Made sure that channels() gets 4 channels to play with, setting the rest to 0 if less are provided. (Class-CSS.php)
+ Added a $browser['is_ie8down'] variable in PHP and is_ie8down in JS, because it's likely to be useful for other users. (Load.php, Subs.php, Class-CSS.php, index.template.php, script.js)

(Nearly finished with my CSS parser, really... Still need to look into implementing a math parser.)
Title: Re: New revs
Post by: Nao on January 30th, 2011, 05:25 PM
rev 548
(2 files, 4kb)

! Selectors could be treated as base selectors by Wedge if their name included the one of an existing base selector. (Class-CSS.php)
* More CSS parsing use. I'm loving it. (Warm/index.css)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 12:38 PM
rev 549
(4 files, 6kb)

* Renamed SI_* classes to CSS_*... Makes more sense in this context. (Class-CSS.php)
- Removed header from the 'more smileys' popup. If you clicked that link, you know what to do. (Class-Editor.php)
* Replaced the dynamic str_replace for debug data insertion, with a substr_replace which is faster in effect, and less error-prone. (QueryString.php)
! A misplaced preview linebreak was visible even when the preview wasn't. (Post.template.php)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 06:46 PM
rev 550
(1 file, 5kb)

! Fixed a bug in the IE codepath: rgba and hsla colors weren't correctly transformed to rgb. Maybe I should start testing my code before committing it... Hmm... Wait, no that's too hard to do. (Class-CSS.php)
! Fixed (although it never generated any glitch?) a regex bug in the rule parser: a "+" was needlessly escaped, and worse, a "." should have been escaped. Plus, uppercase chars weren't taken into account, even though they should. (Class-CSS.php)
! Fixed a dirty bug where selectors were treated more than they should, resulting in long parsing times when using class inheritance. Maybe I should start tes... Look behind you, a three-headed monkey! (Class-CSS.php)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 09:37 PM
rev 551
(3 files, 12kb)

+ Added a horrible, complicated and rather ugly hack called $alpha_matte. On the other hand, it allows using RGBA/HSLA colors without providing a fallback for IE 6/7/8. If you have a better idea, please share. (Class-CSS.php, Warm/index.css)
! Fixed named colors not working at all. Yes, I didn't test these either. So, did you see that three-headed monkey or not? (Class-CSS.php)
* Moved color extraction code to its own method. Not because it's cleaner, but because it allows me to call it again. (Class-CSS.php)
- Removed the buggy, and unused, server import function. (Class-CSS.php, Subs.php)
Posted: January 31st, 2011, 08:50 PM

rev 552
(2 files, 6kb)

* Updated ie6.css to remove the original rgba() hacks. Although... Can someone please tell me why it doesn't show backgrounds anymore? And why does the h4.hove work, but not the li.hove one? Eh? You don't care? You're mean. (Warm/ie6.css)
* Rewrote menu.gif handling to call it only once and save some space in the cached CSS file. (Warm/index.css)
Posted: January 31st, 2011, 09:20 PM

rev 553
(2 files, 5kb)

* Added ability to specify email and URL fields in Profile inputs, and changed a couple of these entries to force them. iPhone users will like me more for that. I need love. (Profile-Modify.php, Profile.template.php)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 11:30 PM
rev 554
(5 files added, 1 deleted, 2 updated, 18kb)

* Renamed Nix styling to Wine (in keeping with the 'W' theme...), and tweaked the colors to be more inviting. Hips! (Wine/*, various files)

I *hope* you'll like it, Pete! I didn't change much, but I don't know how I could possibly make the catbar and titlebar brighter... :^^;: It would spoil the styling's name :P
I think I'll keep the 'Nix' name (or Nyx) for a REAL black theme ;)
Title: Re: New revs
Post by: Nao on February 2nd, 2011, 04:40 PM
rev 555
(2 files, 13kb --- sometimes, sad stats are really sad. That one was a lot of work :P)

+ Added support for Sass-style CSS files. It is a bit fragile, but it works. (Class-CSS.php)
+ Added support for ".class extends .other_class" as a selector, mimicking PHP syntax. (Class-CSS.php)
+ Added support for & shortcuts after extends and base keywords. (Class-CSS.php)
+ Added support for // line comments. (Subs.php)
* Converted \r linebreaks to \n to simplify operations. (Subs.php, Class-CSS.php)
* Renamed CSS_NestedSelectors class to CSS_Nesting, because that's me. (Subs.php, Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 3rd, 2011, 10:06 AM
rev 556
(12 files, 18kb)

! Replaced nl2br($string, false) (PHP 5.3+ only) with a preg_replace in the westr object. (Class-DB.php, Class-String.php, ManageMail.php, Packages.php, Subs.php, ViewQuery.php)
! Fixed a few hardcoded replacements and errors when processing profile URLs. (PrettyUrls-Filters.php)
! Setting $_GET['board'] to 0 instead of unsetting it was a bad idea, as it would end up in the URL when rebuilding the query string from scratch, as Subs-Auth.php does. (QueryString.php)
* Moved the action to the beginning of the query string to allow easier 'prettification'. (Subs-Auth.php)
! Some user agents (bots, probably?) wouldn't return a HTTP_ACCEPT_ENCODING header. Disable gzipping for them losers. (Subs.php)
! Made sure that the menu system didn't try printing anything when an entire section was unavailable, for guests for instance. (GenericMenu.template.php)
* Updated copyright year to 2011 in the footer. (index.english.php, index.french.php)
Title: Re: New revs
Post by: Nao on February 4th, 2011, 04:44 PM
rev 557
(13 files, 105kb)

* The big Warm commit: full conversion to the simplified CSS syntax. (Warm/*.css)
! Fixed parsing of simplified syntax CSS files when stray semicolons were being used. And yes, you still can't use several properties on a single line. It's fixable, but not without making the code more complex to maintain, and simplicity and readability are the goal here, whether in CSS or in PHP. (Class-CSS.php)
* Minor optimization of earlier code. (Subs-Auth.php)

Stats: Warm/* used to account for 85.1kb, now it's at 78.8kb, saving about 8% off the previous size. Or, "the previous size was 9.2% bigger than the new one." Whichever you like best. ;)
Title: Re: New revs
Post by: Nao on February 4th, 2011, 06:50 PM
rev 558
(5 files, 8kb)

+ Added a $context['is_ajax'] that is only set if the page is being called by jQuery. (QueryString.php)
! Fixed error log's code browser and any popup in general to hide sidebar and debug info when called from jQuery. (Subs.php, Help.template.php)
* Marked some registration fields as required (in HTML5 terminology) and added a type="email" over there. (Register.template.php)
! Registration username validator always returned true. (register.js)
Title: Re: New revs
Post by: Nao on February 4th, 2011, 11:27 PM
rev 559
(3 files, 8kb)

+ Added mixin support, which is basically the stuff I removed last week, but with a better syntax, and the ability to specify parameters. Didn't use it in the CSS, so I just provided a few samples. (Class-CSS.php, Subs.php, Warm/index.css)

(I really need to start writing some proper documentation for themers...)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 09:24 AM
rev 560
(2 files, 8kb)

! Fixed indentation in mixin use. You can safely use a mixin: at deep nesting levels, as well as use nesting inside the mixin blocks themselves. Also changed the commented out samples to reflect that. (Class-CSS.php, Warm/index.css)
* Only allow mixin declaration at the start of a new line, i.e. indentation won't work. This is more of a semantic change than anything else, really. (Class-CSS.php)
* Added a comment explaining why I'm not doing "$var: 0" variable definitions, as would be more logical. (Class-CSS.php)

(Thought of this mixin fix all night, ruined my sleep >_<)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 04:05 PM
rev 561
(1 file, 7kb)

+ Added support for deep extends. For instance, with ".class1 / .class2 extends .class1 / .class3 extends .class2", class3 will correctly extend class1 as well. And so on. (Class-CSS.php)
! Fixed a few bugs in the process. It's a miracle that it all worked before. (Class-CSS.php)
- There was really no reason to go through array_map('trim') on exploded selectors. It's all trimmed by the CSS optimizer later anyway. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 05:31 PM
rev 561
(1 file, 5kb)

! Fixed extends where if the base was for instance, ".class a" or ".class th", and it would match ".class abbr" or ".class thead". Bummer. (Class-CSS.php)
! Fixed extends where if the base was ".class something" and another earlier selector inherited ".class", the current selector wouldn't inherit anything. Extends are a complicated beast. Don't abuse them, or I'll eat you. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 07:22 PM
rev 562
(25 files, 22kb)

+ Added basic math functions to CSS parser -- and this will be the last feature I'm adding to it, otherwise I'm gonna faint. The feature is as short as possible, and uses eval() to allow you to use regular PHP syntax in your math. Example: border-width: math($default-border-width*2)/3px). (Class-CSS.php, Subs.php)
* As a rule of thumb: inside a character class, most metacharacters are regular characters again. With this in mind, simplified many, many expressions throughout the source code. Wasn't fun. Ah, and a reminder to the SMF team: \w matches underscores, too... (Class-CSS.php, Class-DB.php, JSModify.php, Load.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, PackageGet.php, Packages.php, Post.php, Post2.php, PrettyUrls-Filters.php, Profile-Modify.php, QueryString.php, Search2.php, Security.php, Subs-Auth.php, Subs-Boards.php, Subs-Post.php, Subs.php, Themes.php, ManageBoards.template.php, ManagePaid.template.php)
- I said I don't care about lower_padding! Grr. (MoveTopic.template.php)

Note: here's to you, Pete. Hopefully you're not the one who'll faint in front of these dozens of regex changes! I tested most of them... But sometimes it's hard to just grasp the idea that in a character class, [ is the same as \[ or even \\[... Or whatever... But that \ needs to be escaped twice... \\\\. Yay.

:edit: Oops... I committed a "work in progress" by mistake. That's the Themes template, FWIW. Please don't bother looking into it. ;) Basically I started removing the CSS previewer, but it was hard to do because I worked so much on fixing it... Maybe you'd like to finish the job for me? :^^;: Or maybe I'll find a way to at least keep the previewer (just not the real-time preview.)
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 02:55 AM
Revision: 564
Author: arantor
Date: 01:55:03, 06 February 2011
Message:
! Can't create proper lambda functions before PHP 5.3.0. (Class-CSS.php)
----
Modified : /trunk/Sources/Class-CSS.php
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 03:21 AM
Sync'd to SMF r10396
 & Fixed a couple of languages strings. [Bug 4566] (Help.english.php, ManagePermissions.english.php)
 ! Fixed validation error and header bar markup. [Bug 4549] (ModerationCenter.template.php) (Note from commit: We have several cases in admin where HTML validation is borked if there are no items displayed in a table. The problem is that the php was written without taking into account the possibility of empty tables. I'll fix them as I come across them but wont go looking for them at this stage.) (NB, I fixed this differently to them, i.e. not having an extra if after the foreach)
 * Fixed newsletter IE7 issue and some other IE issues. (ManageNews.template.php, Login.template.php, index.css, Warm/index.css, rtl.css, Warm/rtl.css, ie6.css, ie7.css, Warm/ie6.css, Warm/ie7.css) [Bug 4567] (NB: These don't appear to make a difference to me, but might on IE, haven't tested them)
 * Incorrect id's fixed. (SplitTopics.template.php) [Bug 4582]
 * Minor markup fixes. (Profile.template.php) [Bug 4607] (One did not apply to us!)
 ! Fixed display of spider log title/information. (ManageSearchEngines.php) [Bug 4608]
 ! Broken function call in ManageMail (ManageMail.php)
 ! Credits updates. (Credits.php, Who.english.php) (NB: I've added Brett as consulting dev since some of his work has gone into the patches here, and added the server team but not any of the miscellaneous people moves since they're not part of Team Wedge)
 * Added array flip for buttonlists to fix untracked ltr/rtl issues in IE6/7. (rtl.css, index.template.php)
 ! messageIconChecks_disable should be enable [Bug 4095] (Display.php, MessageIndex.php, Search2.php, Unread.php, Unreadreplies.php, SSI.php) [2.1 branch but was in the tracker for ages so fair game]
 ! Multitable deletes possible in MySQL. (ManageBans.php, ManageMaintenance.php, ManagePermissions.php) [2.1 branch, ignored the == to === micro optimisations]
 ! Checking for search API files could cause an open_basedir error. (ManageSearch.php) [Bug 4251]
 ! Visual verification could cause undefined index errors in some cases. (Subs-Editor.php) [Bug 4546]
 ! add_index function failed on duplicate indexes. (Class-DBPackages.php) [Bug 4536]
 ! Allow search methods to modify search settings. (ManageSearch.php) [Bug 4606]

Not added from SMF SVN
 ! revs 10347-10350 (branches in SVN, plus backporting a change to 1.1.x branch)
 ! rev 10351 (SSI change to prevent functions being called from GET when as a guest; since protection is added at function level rather than the file level, we don't need to add this)
 ! revs 10352-10355 (SSI changes from 2.0 being backported to 1.0 and 1.1, plus version number bumps for these versions)
 ! rev 10356 (typo fix in 1.1.x SSI)
 ! revs 10360, 10363 and 10368 in relation to admin submenu not having clear on narrower widths properly... cannot reproduce this myself though their fixes seem to be generic to IE6 too (and revolve around putting a br clear in the generic template. Also, they add a white-space: pre, we already have a related white-space: nowrap in our equivalent menu CSS)
 ! rev 10361 (removes the 3px left padding in h3.titlebg only in admin panel)
 ! rev 10362 (missing class="icon" on some h3s in Admin and Themes templates... we don't use that any more)
 ! rev 10370 (?fin20 to ?rc5 for URLs)
 ! rev 10371 (bump to 2.0 RC5 - save that for another commit I think)
 ! rev 10373 (creation of 2.1 branch in SVN)
 ! rev 10374 (1.1.x ManageNews version change)
 ! rev 10375 (removal of an extra space in 1.1.x SSI)
 ! revs 10376-10379, 10381-10383 (preparation of patch files for just the security changes, 1.1 patch, 2.0 patch, patch cleanup, 1.1 patch, 2.0 patch, version bumps in installer/upgrader)
 ! rev 10380 (Admin language file in 1.1.x cleanup)
 ! rev 10384 (1.0/1.1 changelog notices for security)
 ! rev 10385 ([2.1 branch] check for @ before attempting to query supplied username in email field)
 ! rev 10387 ([2.1 branch] replace all calls to time() with $_SERVER['REQUEST_TIME']... aside from a (IMO) negligable benefit, that relies on the server setting it up, and I don't expect it to be completely consistent on all environments)
 ! rev 10389 (tweaks for manual/wiki changes)
 ! rev 10390 (help section not right in Core)
 ! rev 10396 ([2.1 branch] rewrites of version_compare to use "nice syntax" with symbols - we don't have any outside the installer to worry about, and apparently there's a search bug fixed but I don't see what it is from the diff)
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 12:36 PM
Revision: 566
Author: arantor
Date: 11:35:45, 06 February 2011
Message:
! Updated version number across the source to 2.0 RC5, I don't think they were selective in what files were updated, don't see why I should be (Many many files, simple find/replace on 2.0 RC4 to 2.0 RC5)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Buddy.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Class-DBExtra.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Class-DBSearch.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-GifAnimator.php
Modified : /trunk/Sources/Class-Package.php
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/Collapse.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Sources/Subs-Sound.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/Sources/captcha/captcha-grid.php
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Modified : /trunk/Sources/captcha/captcha-ledicons_anim.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle2.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_shadow.php
Modified : /trunk/Sources/captcha/captcha-silhouette.php
Modified : /trunk/Sources/captcha/captcha-simpleanim.php
Modified : /trunk/Sources/captcha/captcha-stripes.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Notify.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Printpage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Stats.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/Themes/default/Xml.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Modified : /trunk/Themes/default/languages/ManageCalendar.english.php
Modified : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/Themes/default/languages/ManageMail.french.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.french.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/ManagePaid.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.english.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Modifications.english.php
Modified : /trunk/Themes/default/languages/Modifications.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/Settings.english.php
Modified : /trunk/Themes/default/languages/Settings.french.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/Stats.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/Wireless.english.php
Modified : /trunk/Themes/default/languages/Wireless.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/Settings.php
Modified : /trunk/other/Settings_bak.php
Modified : /trunk/other/Sphinx/SearchAPI-Sphinx.php
Modified : /trunk/other/Sphinx/sphinx_config.php
Modified : /trunk/other/Subscriptions-Authorize.php
Modified : /trunk/other/Subscriptions-twoCheckOut.php
Modified : /trunk/other/install.php
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/bbc_test.php
Modified : /trunk/other/tools/cleanup_mark_read.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/mailQueueCron.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/tools/restore_backup.php
Modified : /trunk/other/tools/smf_api.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/tools/status.php
Modified : /trunk/other/tools/webinstall.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/xml/current-version.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Nao on February 6th, 2011, 12:53 PM
rev 567
(4 files, 10kb)

* Optimized the CSS to XML pre-parser by a factor of 20 or something. Seriously -- don't use str_replace in an evaluated preg_replace that gets called thousands of times. Just don't forget that. (Class-CSS.php)
! usort() may not accept a dynamic function before PHP 5.3, but it doesn't accept $this->kind_of_call either ;) (Class-CSS.php)
* Cached the parent node in searchExtends, as it's pointless to recalculate it on every loop. (Class-CSS.php)
! Fixed a few minor issues. (Class-CSS.php)
! Fixed an incorrect conversion to the simplified syntax for the profile area. (Warm/sections.css)
* Moved the cache folder's cache settings to its own .htaccess file, instead of the top-level one. Dunno if it'll help, but I also added a Cache-Control header to that. Also added a note about FallbackResource (I just found out about that one.) (other/.htaccess, cache/.htaccess)

--> Now I can take some time to look into your other additions... And don't make me believe you checked all of my week's commits in just a few minutes :P
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 01:09 PM
Revision: 568
Author: arantor
Date: 12:08:42, 06 February 2011
Message:
! If calling a function in a static way, it needs to be declared as static. (Class-CSS.php)
----
Modified : /trunk/Sources/Class-CSS.php
Title: Re: New revs
Post by: Nao on February 6th, 2011, 05:30 PM
rev 569
(14 files, 14kb)

* Moved calendar months to the sidebar, to save an extra column. (Calendar.php, Calendar.template.php, sections.css, Warm/sections.css)
! The IE6 stylesheet wouldn't compile properly, because of the use of a "<". (Class-CSS.php)
+ Show lines in context when errors are found during compilation. (Class-CSS.php)
- Removed commented out lines after testing them to work in login and register pages. (ie6.css, ie7.css, Warm/ie6.css, Warm/ie7.css)
- Removed copyright removal text. (Who.english.php, Who.french.php)
* More $context['browser'] to $browser. (index.template.php)
* French translation. (Help, ManagePermissions, Who)
Title: Re: New revs
Post by: Nao on February 6th, 2011, 10:04 PM
rev 570
(2 files, 6kb)

* Improved performance of XML tree builder by 20% by applying various micro-optimizations. Not that it'll be noticeable, but a CPU cycle is a CPU cycle. (Class-CSS.php)
! Forgot to declare .title2 in Warm styling. (Warm/index.css)
Title: Re: New revs
Post by: Arantor on February 7th, 2011, 12:05 AM
Revision: 571
Author: arantor
Date: 23:00:29, 06 February 2011
Message:
! Sync to SMF 10403
 ! Non-existent permission profiles could cause undefined index errors. (ManagePermissions.php) [Bug 4612]
 ! Incorrect dots during upgrade with multiple script files. (upgrade.php) [Bug 4617]
 ! Who's Online integration hook was too restrictive. (Who.php) [Bug 4615] (+credits update, Credits.php)
 * Auto suggest could not handle display names with html special characters. (suggest.js) [Bug 4604]

Not included
 ! r10397 (changelog formatting)
 ! r10400 (possible to add the same function to a hook twice; not necessary due to the already-rewritten code)
 ! r10402 (typo in version check in fulltext API - but we require 4.1.2 which is over their version check automatically)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/scripts/suggest.js
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on February 7th, 2011, 01:21 PM
rev 572
(10 files, 20kb)

* Rewrote the CSS parser to get rid of the XML parser and optimize parsing speed. Mission accomplished, with performance doubled, and code shortened by 90 lines and 2.6 KB. (Class-CSS.php)
- Got rid of the libxml dependency. Oh yeah. (install.php, readme_*.html, Class-CSS.php, Install.english.php, Install.french.php)
* Playing with Warm colors... Just for fun... (Warm/index.css)
* Typonazi. (Class-Package.php, Subs.php, readme_*.html)
Title: Re: New revs
Post by: Nao on February 8th, 2011, 12:15 AM
rev 573
(2 files, 5kb) (a very small fix update.)

! The lighten function was broken. (Class-CSS.php)
- Removed some leftover debug code. (Subs.php)
Title: Re: New revs
Post by: Arantor on February 8th, 2011, 04:57 PM
Revision: 574
Author: arantor
Date: 15:56:48, 08 February 2011
Message:
! Tweak to licence wording for our protection (license.txt)
! Sync to SMF 10446 aka "Clusterfuck"
 ! (10404) Minor improvements to integration hooks. (Admin.php, Load.php, ManagePermissions.php, ManageSettings.php)
 ! (10405) [2.1] Added detection for Litespeed as part of the server config. (Load.php)
 ! (10408) Tabs within code tags were not parsed correctly for some browsers. (Subs.php) [Bug 4578]
 ! (10414) Validate odd URLs (QueryString, Subs.php) *See notes
 ! (10415) Oops. Remove completely incorrect protection against $cachedir removal. (upgrade.php)
 ! (10419) Update the change in 10414, so that password flood is validated regardless of the number of times before it. (Load.php)
 ! (10439) Save a query on posting (topic=161621) (Post2.php)
 ! (10441) [2.1] Don't log robot views on topics or attachments. (Display.php, Dlattach.php)
 ! (10442) sprintf call for support resources language string was overridden. (Admin.php)

Not implemented
* r10406 [2.1] Moves the admin helper functions out of ManageServer and into Admin. I'll be doing this in the rewrite (I'm not so bothered about syncing 2.1 changes back to us and there are potential licence issues anyway with just using 2.1 branch code). There is also a tweak to allow for $context['body_id'] to be defined and if defined, attach that id to the body tag. I left it off because I'm not really sure where this would actually be useful. There is also a lot of changes for the language editor from/to display sanitising but I have absolutely no idea why it's changed (since it's not referred to at all anywhere I can find)
* r10407 [2.1] parsesmileys() created a regex too complex - I'm sure this has consequences I don't like, while it has performance, it's also more naive in how it approaches things I think (it's discussed in the beta board, and Unknown was trying to talk groundup out of it more than once) and it's more == to === conversions to safely ignore.
* r10409-10413 Minor fixes (1.0 SSI, 1.0 patch file, 1.1 spacinazi, 1.1 SSI, 1.1 patch file)
* r10416 Changelog update
* r10417 The change in 10414 to sanitise $_REQUEST['start'], I already added the check that this rev adds (that $_REQUEST['start'] is defined before trying to (int) it)
* r10418 Changing the SSI security thing AGAIN (in line with what 10409-10413 did, basically to ensure that the kickguest only got called when appropriate, but we don't kick the guest to login anyway, we do what makes more sense in the first place: restrict the user's access in SSI so they can't see anything they're not supposed to and let the folks who use SSI figure out what they want to do with the user thereafter)
* r10420-10437, 10443-446 Updating 2.0 patch file, spacinazi and patch file, 10414's fix backported to 1.0, and for 1.1, file versions for both, 1.0 patch file, 1.1 patch file, 1.0 cleanup, 1.0 patch file, 1.1 file version typo, 1.1 spacinazi, CRLF issues, more CRLF issues, 1.1 patch file, 1.0 language file version, 1.1 SSI examples, 2.0 patch file, update to manual to match the trademark slogan of SMF, 1.1 language file version, 1.0 patch file, 1.1 patch file, 2.0 patch file
* r10438 [2.1] Caching members online stats is fine but I don't like the way it's done (should really be done differently all round), and also more == to === changes
* r10440 [2.1] Moving a function from Subs-Auth to Subs-Compat is great but it's not relevant to us since it's in 4.3.2 and up!

Notes
* r10404 Sinan also added a hook to ManageSettings.php for general mod settings but that was already added by Nao under a slightly different name. In SVN log: [SiNaN] knows that he'll be shot for doing this but he still has the heart of a modder.
* r10405 [2.1] also covers making queryless URLs work on Litespeed but that doesn't apply to us. There's also a removal of a @ error suppressor in the install file and a few == to === conversions. Really though, this is pure pedantry.
* r10408 implements it with browser conditions in the definition of $tag['content'] in the original array. Since that's not an option for us, I handled it inside the validate function. I did also fix the rather frustrating issue of IE not putting treating br tags as line breaks for copying, this is something they haven't.
* r10414 is a strange one. I'll buy validation of the URLs to prevent oddities (QueryString, Subs) but it also has two other changes: it removes the char 38 replacement in un_preparsecode, which seems to be OK because & is still escaped to its entity form (though I don't see what prompted it to be changed) and there is more robust checking of password flooding, specifically that a user isn't logged out when there's a password attack.
* r10439 The idea is to move the 'logging boards read', so that if goback is set, we fold that into the 'logging unread' process. Their method involves having an if and two queries' code, mine just manipulates the query variables, heh.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/license.txt
Modified : /trunk/other/install.sql
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on February 8th, 2011, 11:34 PM
rev 575
(9 files + 1 addition, ~10kb)

* Did some serious reworking of the header area. As always, it's a WIP, so feel free to share your ideas to improve on it (or just revert to what it was before.) Haven't tested in Pastel, I'm sure it'll be fun to see how broken it is. (index.template.php, Warm/index.css, images/theme/bg.jpg)
* Rewrote the cat bar and title bar to something else. Me likey.
- Don't waste time and bandwidth showing a clickable link on categories. They already have a collapse button next to them, that should be enough. Who uses collapsing anyway? (Subs-BoardIndex.php)
* Don't use windowbg overrides in the board list. Too many colors can kill the fun, really. (BoardIndex.template.php)
- Don't show the website's name next to "Info Center". The website's name is already in big large letters in the header. What's the point. (BoardIndexInfoCenter.template.php, index.english.php, index.french.php)
* The Search icon in the menu is off by one pixel. Or am I crazy? (Warm/index.css)
! Fixed issues with the channels() function. (Class-CSS.php)
+ Added ability to group properties together if they have the same value, e.g. "height, line-height: 20px". (Class-CSS.php, Warm/index.css)
* Various CSS tweaks. (Warm/index.css, Warm/sections.css, BoardIndexInfoCenter.template.php)

I'm expecting your feedback on the design tweaks, Pete! (And Bloc, maybe...?)
Not too happy with the part that prints the website's name, but the rest, I'm a bit happier with than with the earlier versions. And it's hard to please me really...
Title: Re: New revs
Post by: Nao on February 9th, 2011, 03:43 PM
rev 576
(5 files, 8kb)

* Saved another tenth of a second at CSS compilation time, by replacing a preg_replace_eval with a preg_replace_callback. Seriously, for a single instruction to take a tenth of a second... That's crazy. (Class-CSS.php)
! Mixin declarations would fail if they only a single-line 'function'. (Class-CSS.php)
! Mixin declarations should stop at the first line that has a shorter indentation than the first line of the 'function', rather than the first empty new line. That should teach you to behave. (Class-CSS.php)
! Fixed a missing overflow in Pastel. (css/index.css)
! IE6 was behaving badly in Warm because I forgot to update one of its hacks. (Warm/ie6.css)
* More tweaking to the Warm layout and colors. (Warm/index.css)
* The theme picker could use a visible title, really. (Themes.template.php)

NB: I'm currently playing with drag & drop, trying to make my routine as small as possible, and compatible with position:fixed (which represents most of the difficulty in this exercise.) Still, it's a funny thing to implement, and I need it for our future Highslide replacement.
Title: Re: New revs
Post by: Nao on February 10th, 2011, 09:56 AM
rev 577
(5 files, 12kb)

+ Added ability to compress and cache more CSS files that aren't in the base set. (QueryString.php, Subs.php)
! Fixed installer to properly compress and cache JS and CSS. At last. No animals were harmed during the fixing of this bug. Several gigabytes of data, though, were savagely killed on my test bed because I forgot to set a value for $cachedir. (install.php)
! Fixed Wireless template to use nested CSS. (Wireless.template.php)
- The script tag doesn't need a type for JavaScript. Forgot that one line. (index.template.php)

Note: Should we remove $is_direct_url from add_css_file and add_js_file? It sounds to me like it's a legacy option...
Title: Re: New revs
Post by: Nao on February 10th, 2011, 10:52 AM
rev 578
(4 files, 10kb)

+ Added <we:logo>, a placeholder for putting your own text and logo and styling it like you want. It's totally uncool. Punish me, master. Or at least revert. (Load.php, Subs.php, css/settings.xml, index.template.php)
! Fixed a bug in the CSS parser introduced in rev 577. Just needed to replace $files with $css. (Subs.php)

(I've never hated more a commit of mine than this one, so you've been warned. Still, if we can't make this kind of thing, then we might as well immediately drop the idea of integrating Tox-G in the future.)
Title: Re: New revs
Post by: Nao on February 11th, 2011, 08:11 PM
rev 579
(7 files, 13kb)

+ Added 'final' keyword to selectors, allowing to forbid another selector from inheriting a specific selector through the extends/base system. (Class-CSS.php, Subs.php, Warm/index.css)
* Tweaked header and reverted the order in which the user box and logo show up. Also did plenty of small tweaks to Warm based on user feedback. Thanks everyone! (css/index.css, Warm/index.css, index.template.php)
- Reverted <we:logo> code. I really felt it wasn't the right way to do it. (Load.php, Subs.php, css/settings.xml)

Note to Pete: I rewrote the 'final' code, as I wanted. Now it correctly cancels inheritance for nested selectors when the 'final' keyword is on a child, non-inherited level. If that means anything to you :P
Posted: February 11th, 2011, 07:46 PM

rev 580
(3 files, 9kb)

+ Added a short and sweet drag'n'drop function. Well, just the 'drag' part, but it's all I wanted anyway. (script.js)
+ Added ability to prevent an object from being dragged, by assigning the 'nodrag' class to it. (script.js, Help.template.php, Errors.template.php)
* Avoid initializing a HTML document if we're just coming through Ajax... (Errors.template.php)
- Removed all optimizations related to local variable/function names, because Parser supports them anyway. And if you're not using Parser, it means you don't care about filesize anyway... (script.js)
Title: Re: New revs
Post by: Nao on February 11th, 2011, 09:21 PM
rev 581
(13 files, 15kb)

* Renamed obfuscate_js back to obfuscate_filenames, as CSS filenames are now obfuscated just the same time as JS files. (install.php, ManageServer.php, QueryString.php, Help.english.php, Help.french.php, ManageSettings.english.php, ManageSettings.french.php)
* Restored alternating backgrounds in the board list, only horizontally this time... Not that I find this more exciting... Just wanna find out which is best. (BoardIndex.template.php)
! Toggle icon padding was incorrect in the news fader. (Warm/sections.css)
* Replaced toggle icons with way sexier ones (modified FamFam). Don't thank me. (collapse.gif, expand.gif)
* Prevent double-clicking the toggle icons. (script.js)
* Maintenance area was flooded with cat bars. Seriously, title bars are the way to go here. (ManageMaintenance.template.php)
Title: Re: New revs
Post by: Nao on February 12th, 2011, 07:18 PM
rev 582
(85 files, 83kb) (phew...)

* Important for modders -- $context['sub_template'] = $template has now become a function, showSubTemplate($template), which will automatically manage multiple sub-templates and sidebar sub-templates (showSubTemplate($template, 'sidebar')). (Activate.php, Admin.php, Announce.php, BoardIndex.php, Calendar.php, CoppaForm.php, Credits.php, Display.php, Findmember.php, Groups.php, Help.php, Jseditor.php, JSModify.php, Load.php, Login.php, Login2.php, ManageAttachments.php, ManageBans.php, ManageBoards.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePosts.php, ManageRegistration.php, ManageScheduledTasks.php, ManageSearch.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Memberlist.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Notify.php, PackageGet.php, Packages.php, PersonalMessage.php, Post.php, PostModeration.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, QuoteFast.php, Register.php, Reminder.php, RepairBoards.php, Reports.php, Reporttm.php, Search2.php, Security.php, SendTopic.php, Spellcheck.php, SplitTopics.php, Stats.php, Subs-Auth.php, Subs-Menu.php, Subs-Package.php, Subs.php, Suggest.php, Themes.php, Unread.php, Unreadreplies.php, VerificationCode.php, Xmlhttp.php)
* Rewrote menu system to use regular sub-templates rather than template layers, and allow putting them inside the sidebar flow. Still a bit buggy when it comes to tabs, though. (Subs-Menu.php, GenericMenu.template.php)
* I've always hated empty lines with tabs in source code. Yikes. (Profile.template.php)
* Simplified some CSS related to earlier implementations of the profile/admin sidebars, and made use of media queries instead of conditional refitting. (ie6.css, index.css, rtl.css, sections.css, Warm/ie6.css, Warm/index.css, Warm/rtl.css, Warm/sections.css)
- Removed #context .custom_field hack, as I couldn't find any issue with these in IE6 and Opera. (sections.css, Warm/sections.css)
- Removed support for old-style tabs, as pre-SMF2 themes aren't compatible with Wedge anyway. (GenericMenu.template.php, Recent.template.php, Reports.template.php)

@ Note: WrapAction() in Themes.php... Shouldn't this be removed, now that a hook caters for that?
@ Note: remove .left_menu and .side_section classes?
Title: Re: New revs
Post by: Nao on February 12th, 2011, 11:18 PM
rev 583
(11 files, 15kb)

+ Added support for $context['top_template'], which holds the secondary menus and tab buttons, and is protected from overwrites. (Load.php, Subs-Menu.php, Subs.php)
- Removed $settings['catch_action']. Seriously, it's totally undocumented, I couldn't find any mod using it, and we're pushing for the use of hooks anyway. And there's a hook that does exactly the same task. (index.php, Themes.php)
! Another fix for user agents not specifying the type of contents they accept. (QueryString.php)
* Tweaked sub_template handling. (Errors.php, Load.php, Profile.php, Security.php)
! Fixed an undefined index error that you'll never get anyway. (GenericMenu.template.php)
! Fixed XHTML Mobile 1.0 validation. (Wireless.template.php)
Title: Re: New revs
Post by: Nao on February 13th, 2011, 12:12 AM
rev 584
(1 file, 7kb)

! Fixed CSS parser bug where multiple selectors were given a same base (".class1, .class2 { base: .class }") and only the last one would correctly reflect that. (Class-CSS.php)
* Optimized inheritance parser to avoid running dozens of preg_replace's. (Class-CSS.php)
! Fixed handling of the 'final' keyword for finalized selectors' children. (Class-CSS.php)
! Fixed potential false positives when parsing selectors starting with an alphanumeric character. (e.g. a tag name) (Class-CSS.php)

@ Note: found another bug, will fix tomorrow... $this->getAncestorSelectors($this->rules[$node['parent']]['parent'])...? How does that work anyway? The function is expecting a node but it returns an ID. This works only if all cases where the selector is a root one.
Posted: February 12th, 2011, 11:50 PM

rev 585
(2 files, 5kb)

! Fixed extended selectors not applied correctly when they are themselves children of another selector. (Class-CSS.php)
* Spacinazi. (Warm/admin.css)

(Sorry for the last minute commit. I really didn't notice the bug until I reviewed the code for commit.)
Title: Re: New revs
Post by: Nao on February 13th, 2011, 01:08 PM
rev 586
(5 files, 10kb)

+ Added separators to the profile menu. (Profile.php)
! The duplicate separator removal code was buggy. Rewrote it from scratch. (Subs-Menu.php, GenericMenu.template.php)
! Don't show top_template items in Ajax mode. (Subs.php)
! Fixed missing parens in a dynamic function. (ManageMail.php)
Title: Re: New revs
Post by: Nao on February 13th, 2011, 05:32 PM
rev 587
(3 files + 2 added, 157kb) (nothing changed really... Only renamed "permute()" to "bbc_permute()" to avoid potential conflicts in function names.)

+ Added Subs-Cache file, that includes all of the code for caching regular data, CSS and JS, thus off-loading Subs.php, Load.php and QueryString.php. (Load.php, QueryString.php, Subs-Cache.php, Subs.php)
+ Added Subs-BBC file, that includes all of the code for parsing BBCode, thus off-loading Subs.php, and... that's all. It's already a lot. (Subs-BBC.php, Subs.php)
* Moved match_cidr() to the IP function area. (Subs.php)
Title: Re: New revs
Post by: Arantor on February 13th, 2011, 07:36 PM
Revision: 588
Author: arantor
Date: 18:35:49, 13 February 2011
Message:
! Preliminary IPv6 support (lots of files)
! Minor tweaks to installer to prevent throwing of errors over SMF constant. This needs cleanup though. (install.php)

@todo:
 Profile IP tracking stuff is still broken
 Bans also broken (which likely means non admin users are also broken for now)
 match_cidr() needs updating
 host_from_ip() needs testing for IPv6
 Proxy code needs rewriting, it's just commented out for now but it was actually broken before

When I say it's preliminary support, I mean just that - it doesn't immediately fall over, but it's going to be fragile for now. There's also likely stuff I've forgotten for now, but I think I got the major stuff either resolved or at least 'known'. (And some would love to add IPv6 support as a mod...? Sigh.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on February 14th, 2011, 05:37 PM
I think it's the first time I see you commit commented out code... Hang in there!

rev 589
(5 files, 13kb)

! Fixed CSS not showing up in the installer if the forum is installed in a sub-folder. Hopefully. (install.php)
* Moved censorText() to a more logical place. Again -- hopefully. (Load.php, Subs-BBC.php)
+ Added separators to the internal PM menu. (PersonalMessage.php)
! Fixed various obvious bad translations in the installer. Okay, what did I do during these two months I spent on fixing these files? Did someone throw them away or was I just that careless? (Install.french.php)

PS: Another commit coming up... Just sorting out the files for now. Also, I'm not too sure about that code I added in install.php... I think I should instead change Subs-Cache.php to return "cache/" instead of $boardurl . "/" when $boardurl is empty... That'd probably make more sense. The only reason I didn't do it is that it's unlikely $boardurl isn't set when the forum is installed. Meaning it just wastes a CPU cycle for nothing...
Title: Re: New revs
Post by: Nao on February 14th, 2011, 11:31 PM
rev 590
(8 files, 12kb)

* Changed the dynamic sidebar removal to instead move it to the far left, and restore it (with an animation) when hovering it. Only tested in Opera for now. Also adds a box-shadow in this mode, to make it clear that it's no longer in the regular flow. (index.css, Warm/index.css, index.template.php)
* If the linktree only has one item, it has to be the home page, hasn't it? Let's not waste time showing it then... But keep the linktree div in it, since we might have some padding applied to it. (index.template.php)
! The special popup at runtime wasn't using the new system. (install.php, Install.english.php, Install.french.php)
! Fixed a horizontal scrollbar at board creation time. (ManageBoards.template.php)
! Fixed a warning when caching the Pastel styling -- had forgotten a bracket. Next step: drop stupid CSS and use the new syntax everywhere. (sections.css)

@ Note: should we care about the legacy code for older PHP versions in the installer...? Lines 102-117. (install.php)
@ Note2: cool changes innit? :P As indicated, it's only tested in Opera for the sidebar stuff (should work everywhere but IE won't get the animation obviously), and the linktree area -- I'm not sure the homepage is the only place that has only one item. If it's not the case then we should change the other areas to have at least two items, /mesays.
@ Comments welcome.
Title: Re: New revs
Post by: Arantor on February 15th, 2011, 02:48 AM
Revision: 591
Author: arantor
Date: 01:47:47, 15 February 2011
Message:
! Kill 'enable sticky option', they're now wired on. (Surprisingly many files.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on February 15th, 2011, 09:40 AM
rev 592
(5 files, 8kb)

! Fixed and optimized math function in the CSS parser. I was pretty sure I'd tested it thoroughly, eh... (Class-CSS.php)
+ Added support for some basic PHP functions in math(), in case you need them: round, ceil, floor, abs and fmod. (Class-CSS.php)
* Moved gz Mime type overrides to the cache folder. (other/.htaccess, cache/.htaccess)
* Ensure WAP2 mode never uses more than .5em of whitespace between lines. (wireless.css)
* Made a code block more compact, because I've learned to hate it, and I don't want to see it anymore. (script.js)
Title: Re: New revs
Post by: Nao on February 15th, 2011, 01:32 PM
rev 593
(22 files, 23kb)

* Modified add_css_file() to use less parameters, allow for extension-less filenames and get files from the current styling, or their closest parent if unavailable. (install.php, Subs-Cache.php, Packages.template.php, Reports.template.php, Wireless.template.php, Xml.template.php)
* Renamed 'css' folder to 'styles', and updated related code. Haven't done it on the SVN yet to make it easier to spot changes, the actual renaming will be in the next commit. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, ManageBoards.template.php, Themes.template.php, */settings.xml, */index.css)
! The Bad Behavior code was using $context['html_headers'] at some point, instead of $context['http_headers']. (Security.php)
Posted: February 15th, 2011, 11:13 AM

rev 594
(n/a)

* Renamed css folder to styles.
Posted: February 15th, 2011, 11:27 AM

rev 595
(n/a)

+ Added .htaccess files to styling folders, preventing reading the CSS files for regular users. I may be paranoid, but no an android.

(Currently fighting with a tree conflict... Did 'rename' on my css folder, then committed and forgot to update it BEFORE committing, which is never mentioning anywhere... Because of that, I can't even touch my work folder anymore, I have to work from a clean folder. Grrr...)
Posted: February 15th, 2011, 11:36 AM

rev 596
(n/a)

+ Cleaning up my SVN... Committing two files that I thought I'd committed before: the actual button bevel (3D effect), and the script folder protection. (images/theme/bevel.png, scripts/.htaccess)

(Okay, I think my SVN is good now... Phew. I had to manually edit my SVN files, ah ah.)
Posted: February 15th, 2011, 12:10 PM

rev 597
(2 files, 4kb)

- Removed legacy PHP code. (install.php)
! Fixed wrong param number in preg_match_all. (Security.php)
Title: Re: New revs
Post by: Nao on February 16th, 2011, 12:18 AM
rev 598
(3 files, 11kb)

! Added a child div in the sidebar to account for a Chrome bug in "display: table-cell" blocks... Yay... (index.template.php, Warm/index.css)
! Fixed outdated JS code for the auto-resizer. Now it should correctly hide the sidebar before it starts doing crazy things. (index.template.php)
* Minor padding/margin/width tweaking in the sidebar. (index.css, Warm/index.css)
Title: Re: New revs
Post by: Arantor on February 16th, 2011, 12:58 AM
Revision: 599
Author: arantor
Date: 23:58:25, 15 February 2011
Message:
! Installer fixes: $to_header no longer defined for add_css_file, Subs-Cache would infinite loop due to missing $context['styles'], not to mention never actually finding the files it wanted. (install.php, Subs-Cache.php)
! Rewire board access to be based on a separate table, rather than the FIND_IN_SET against a text field. (install.sql, Load.php)

@todo
 Refit admin panel
 Provide facility for board/topic privacy to be configured since currently it is reusing the membergroups field to set $board_info['privacy'], though that doesn't appear to be used by anything right now.
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 17th, 2011, 03:33 AM
Revision: 600
Author: arantor
Date: 02:33:06, 17 February 2011
Message:
! Reinstate proxy handling for IPv6. Still needs more testing and match_cidr to be rewritten for IPv6 though. (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php
Title: Re: New revs
Post by: Nao on February 17th, 2011, 11:48 AM
rev 601
(3 files + 6 added, 22kb)

+ Added WarmWine (temp name of course), a child styling for Warm that basically reproduces the original Wine. There are a few differences but mainly in padding and stuff. (Warm/Wine/*)
! is_ipv4() wasn't using the given parameter. (QueryString.php)
! A better fix for the infinite loop in add_css_file(). (Subs-Cache.php, install.php)
Title: Re: New revs
Post by: Nao on February 18th, 2011, 04:46 PM
rev 602
(23 files, 167kb, plenty of search & replace but also plenty of manual fixing :P)

* Converted all remaining stylings to the new simplified CSS syntax. (styles/*)
! The clean_cache() function systematically deleted all files from the cache. As it is called by a scheduled task, added a parameter to prevent deleting CSS and JS files when they don't need it. They're still purged when going to the admin area and changing a file compression/obfuscation setting. (Subs-Cache.php)
! Typo in Pastel. (mad-width, ahah, that one should be standard.) (styles/index.css)
@ Moved Green stylings by mistake. Will move them back later... Don't want to screw up my svn copy again.
Title: Re: New revs
Post by: Nao on February 18th, 2011, 06:57 PM
rev 603
(11 files, 20kb)

+ If user doesn't have permission to view own or any profile, strip links leading to them. (QueryString.php)
* Minor tweaks to Pastel and Warm. (*.css)
Title: Re: New revs
Post by: Arantor on February 19th, 2011, 12:55 PM
Revision: 604
Author: arantor
Date: 11:54:58, 19 February 2011
Message:
! Sync to Bad Behavior 2.1.11
 ! Remove test for Google Wireless in anti-Google spoof as it is a special proxy not a search engine. (Security.php)
! Sync to SMF 10465
 ! (r10449) Cache bug in upgrader (upgrade.php)
 ! (r10466) Typo in forum profile loader, makes custom fields more internally consistent (Profile-Modify.php)
 ! (r10467) 64-bit created zip file decompression fix (Subs-Package.php)

Not implemented from SMF
 * r10447 Tweak of censored words UI (going to be rewritten anyway)
 * r10448 Shuffling of setlocale and time format in 2.1 branch, not convinced it is beneficial yet, and not convinced it doesn't have issues (it certianly has some issues in the hacky changes to Load.php if mb_* functions aren't available... like fatal errors)
 * r10450,10457-10459 Tagging 1.0.21, 1.1.13, 2.0 RC5, branching in 2.1/other
 * r10451 Pedantry and minor typo fix in converter (not applicable to us because the importer needs to be written from scratch anyway)
 * r10452 Conversions of substr($x, $y, 1) to $x[$y]... it makes it harder to follow and the speed factor is not hugely significant even if it is inside parse_bbc (it's *where* it's inside parse_bbc, in validate functions mostly)
 * r10453 Pedantry: removal of @ in front of ini_get/ini_set and ob_start calls
 * r10454 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10455 Removal of @ in front of set memory limit calls in converters
 * r10456 More == to === conversions
 * r10460 Yet more == to === in Post.php for 'testing commits'
 * r10461-3 Converting TYPE to ENGINE in upgrader scripts, then reverting it
 * r10464 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10465 Changing the 'clean attachment' to 'clear attachment' - we already revised the UI entirely
 * r10468 PostgreSQL specific fix in upgrader.
 * r10469 [2.1] "Replaced some strtr with str_replace and some strpos(strtolower()) with stripos() and some strtolower() == strtolower() with strcasecmp(). Just pedantic stuff."
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on February 20th, 2011, 11:56 PM
rev 605

* Upgrading Warm to default styling, and moving Pastel to its own folder. Doing it in two phases to avoid SVN conflicts.
Posted: February 20th, 2011, 11:48 PM

rev 606/607

* Moved Green and Green again to Pastel (will have to delete Green again, we got the point), cleaned up Pastel (will have to test tomorrow), and deleted the Warm subfolder. Hopefully it's all done now.
Title: Re: New revs
Post by: Nao on February 21st, 2011, 10:52 PM
rev 608
(7 files, 12kb)

* Renamed CSSCache class to wecss, to match the default naming style. (Class-CSS.php, Subs.php)
* Moved PIE.htc to the scripts folder, mainly because it's a JavaScript file really. (scripts/PIE.htc, Pastel/settings.xml)
* Swapped styling types for Warm and Pastel. (styles/settings.xml, Pastel/settings.xml)
! Updated default replacements blocks when the default styling is used. (Load.php)
! Fixed a minor bug in button padding. (styles/index.css)
Title: Re: New revs
Post by: Nao on February 21st, 2011, 11:43 PM
rev 609
(1 file, 1 line actually...)

* Added a workaround to support @-webkit-keyframes rules in the CSS parser. (Class-CSS.php)
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 03:21 AM
Revision: 610
Author: arantor
Date: 02:20:38, 22 February 2011
Message:
! Make sure board type is available to the board loader (Load.php)
! Refactor the code for getting who is in a board/topic for display, reducing duplicate code (MessageIndex.php, Display.php, Subs-MembersOnline.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 11:23 AM
Revision: 611
Author: arantor
Date: 10:20:21, 22 February 2011
Message:
+ Board topic order can be controlled by the database now, and there is the possibility of forcing any given board to be arranged in a particular way with no ability for user to override (install.sql, Load.php, MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/other/install.sql


In other words, the functionality of the 'board sort method' mod without the admin panel option (yet) for it. Functionality is managed in the database only right now (pending ACP overhaul), where sort_method dictates what method should be used to order boards, which is the full list ('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post') and sort_order dictates how it should be done.

natural_* indicates that it should be done as default but not forced (i.e. what happens when none is specified), forced_* indicates that this is the order to use and cannot be overridden by the user.
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 01:20 PM
Revision: 612
Author: arantor
Date: 12:14:44, 22 February 2011
Message:
+ More bbcode icon (Class-Editor.php, sprite.png, Post.english.php)
! Fixed more bbcode to actually work, it's only just inside a topic it should be empty, all other cases it should be firing, not just when we're inside a board, like it should in feeds (install.sql, Subs-BBC.php)
+ Modified feed handler such that if we have a limit on feed length, check whether the more bbcode is present and is set within the space of that limit - if it's inside the limit, or not too far outside, use more bbc instead of auto cropping. (Feed.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/images/bbc/sprite.png
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/other/install.sql

Posted: February 22nd, 2011, 01:15 PM

Revision: 613
Author: arantor
Date: 12:19:54, 22 February 2011
Message:
! Woops, forgot to put the query quite right. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 03:40 PM
Revision: 614
Author: arantor
Date: 14:39:44, 22 February 2011
Message:
! Page indexes should include previous/next links to go with pages (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on February 22nd, 2011, 10:56 PM
rev 615
(4 files, 14kb)

! Made sure that single-line comments match "// " (with a space or tab) rather than just "//", e.g. in hardcoded URLs. (Subs-Cache.php)
* Removed roundframe div from info center, fixed indentation and simplified some areas. (BoardIndexInfoCenter.template.php)
* Show the small Wedge logo to the right of the footer, rather than next to the copyright info. (styles/index.css)
+ French translation. (Post.french.php)
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 05:15 PM
Revision: 616
Author: arantor
Date: 16:03:13, 24 February 2011
Message:
! Get the first post in each thread for blog posts in message index, also rework the ordering of operations so we censor before bbc parsing as appropriate (MessageIndex.php)
! A little rearrangement of the message index code, plus some indentinazi (MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 05:51 PM
Revision: 617
Author: arantor
Date: 16:51:24, 24 February 2011
Message:
! More cleanup of message index: moving the who's viewing to the sidebar. Not sure if the header to that needs to change though. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 06:01 PM
Revision: 618
Author: arantor
Date: 17:01:26, 24 February 2011
Message:
! And moving the online stuff to the sidebar in topics too. (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Nao on February 24th, 2011, 06:24 PM
rev 619
(6 files, 14kb)

* Heavily reworked the header area in Warm, and fixed a few glitches in the process. (index.css, index.template.php)
* Added a list-type disc next to menu items in the sidebar. I thought it would feel a bit more natural, as it's an actual unordered list... (sections.css)
! Fixed CSS parser failing to define variables when they were followed by a single-line comment. (Class-CSS.php)
* Renamed $alpha_matte to $alphamix. Don't ask. (Class-CSS.php, index.css)
+ Added a workaround to allow IE6 and IE7 to emulate rgba() in key areas. Because filters are CPU intensive, use with care. Basically, just follow your color variable or direct color with a "/hex". e.g. filter:gradient(startColorstr=$color/hex, endColorstr=$color/hex) should generate an alpha-blended background. (Class-CSS.php, ie6.css, ie7.css)
! Fixed CSS parser failing to parse alpha filters for IE. Maybe I should rename the function... But 'alpha' sounds so cool. (Class-CSS.php)

More coming... But this was the bulk of the commit really.
Title: Re: New revs
Post by: Nao on February 24th, 2011, 06:53 PM
rev 620
(9 files, 14kb)

* Some of the $memberContext areas were being initialized later in the process. Since they were always set up, it's slightly faster to set them up in the main array. (Load.php)
- Moved 'webkit' and 'gecko' further down in the list that sets up the 'agent' variable. This is to make sure we get the most precise current user agent. If you want to test whether a browser is using the Webkit engine, use $browser['is_webkit']. (Load.php)
* Not too fond of this one, but I added 'webkit' to the list of default stylesheets, in addition to the Webkit-based agent name. Maybe I should do the same with 'ie'... Or maybe I should just split webkit.css into as many files as required? (Load.php)
! Fixed indentation regarding the sidebar. Ouch. (BoardIndexInfoCenter.template.php)
! A French string was out of date. (index.french.php)
! Meta keywords are disabled by default... Changed wording to reflect that. (ManageSettings.english.php, ManageSettings.french.php)
! Fixed visibility for upper right switch. (script.js)
* Minor adjustments to the sidebar width in Pastel. (Pastel/index.css)
- Deleted an unused $board_info. (Class-Editor.php)
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 08:43 PM
Revision: 621
Author: arantor
Date: 19:43:01, 24 February 2011
Message:
! More tweaks: moving the icon legend into the sidebar, and moving the navigation menu out of the theme entirely (it should never have been there in the first place) (MessageIndex.php, MessageIndex.template.php, index.english.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on February 24th, 2011, 09:18 PM
rev 622
(3 files, 6kb)

+ Show all available language flags in the bottom left corner. I totally hate global'ing $user_info just to get one variable (I should move that one) and glob'ing an entire folder on every single page to find the flags, so if you have a better implementation or want to add some caching... Please do it! :^^;: (index.template.php)
! Fixed size and rating for gravatars. (Subs.php)
* Don't show the 'webkit' name twice in the URL for browsers that use WebKit but aren't Safari, Chrome or Android stuff. If that even exists. (Load.php)

:edit: My main goal was to add the friggin' flags to the top bar, to bring it closer to the wedgeforum goodies. I really don't like having flags shown that way, and the extra hit per language available, things like that... But I can hardly do any better -- I mean, it's not like it's hardcoded so I can't do a sprite like here.
Title: Re: New revs
Post by: Nao on February 24th, 2011, 11:10 PM
rev 623
(forgot to log stats.)

* Modified previous/next links in Display template to be shown in a <we:cat> instead, next to the topic title at the top, and next to the jump box at the bottom. This should help differentiate between page prev/next and topic prev/next. (Display.php, Display.template.php, sections.css)
* Forgot to apply rgba() fix to IE8. (ie8.css)
* French translation. (index.french.php)
* Indenazi. (index.template.php)
Title: Re: New revs
Post by: Arantor on February 25th, 2011, 02:37 AM
Revision: 624
Author: arantor
Date: 01:36:36, 25 February 2011
Message:
! $db_prefix was not being properly updated when no DB selection was taking place (i.e. SSI) (Class-DB.php)
----
Modified : /trunk/Sources/Class-DB.php


This was an Arantorbug™. Nailed now though.
Title: Re: New revs
Post by: Arantor on February 25th, 2011, 12:27 PM
Revision: 625
Author: arantor
Date: 11:27:30, 25 February 2011
Message:
! Avatars brought onto the server did not always get the .ext extension they should have had. (Profile-Modify.php, Subs-Graphics.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Graphics.php
Title: Re: New revs
Post by: Arantor on February 25th, 2011, 04:40 PM
Revision: 626
Author: arantor
Date: 15:37:44, 25 February 2011
Message:
! Preliminary blog support in the template (MessageIndex.php, MessageIndex.template.php)
! The 'you have saved as a draft' is now a subtemplate in its own right and called through layers. (MessageIndex.php, MessageIndex.template.php)
! Moving the stable icons arrays to a central place to encourage them to remain consistent (Display.php, MessageIndex.php, Search2.php, Subs.php, Unread.php, Unreadreplies.php, SSI.php)
+ Android posting icon for Android devices. It sucks, sorry. But all the logos I see have a white border to it and 16x16 isn't very big. More icons to come though. (android.gif, Post2.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/post/android.gif
Title: Re: New revs
Post by: Arantor on February 27th, 2011, 02:22 AM
Revision: 627
Author: arantor
Date: 01:22:10, 27 February 2011
Message:
! Added RSS block to sidebar, removing RSS feed links from footer, display and message indexes. Layout's not set in stone, just that we get to declutter the menu bars this way, and make it easier to find the RSS links. (index.php, index.english.php, index.template.php, Display.template.php, MessageIndex.php, feed.png)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/Display.template.php
Added : /trunk/Themes/default/images/icons/feed.png
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on March 2nd, 2011, 04:41 PM
He's back, and kickin'!! 8-)

rev 628
(20 files, 34kb)

* Converted Pastel to inherit Warm. Yay. Now I won't break it every single time I change the markup... (Pastel/*)
* Reworked user box in the sidebar. A bit better. Not perfect, yet. (index.template.php, index.css)
- Removed the "Topic:" from topic titles. Like it was needed, uh... (Display.template.php)
- Removed the filler text in the sidebar. It's filled with stuff, now. Eh. (index.template.php)
! Fixing some styling logic problem that lacks it (logic). Anyway. (Load.php)
* Why show three empty anchors when we need only one? (Display.template.php)
* Moving the Jump To box to the very bottom. Dunno if it's better -- logically it is, but it makes the quick reply box less accessible... Hmm. (Display.template.php)
! That's we:title2, not we:title. (Display.template.php, index.template.php)
! Guests would trigger error messages because $context['button_list'] was empty for them. Maybe we should just avoid unsetting it... (MessageIndex.template.php)
! I can't believe I actually used a valign="top" again... Me, of all people!! (index.template.php)
! Language flags always had "Français" as their title. Oops. (index.template.php)
* Made the "Unread posts" and "Unread replies" texts a bit shorter. Whatever. (index.english.php)
* French translation update and fixes. (index.french.php, Install.french.php)
* Spacinazi, indenazi. (Themes.php, Display.template.php, index.template.php, Profile.template.php)
* Various minor CSS optimizations and fixes. (admin.css, index.css)
Title: Re: New revs
Post by: Nao on March 2nd, 2011, 05:54 PM
rev 629
(6 files, 9kb)

! Some fixin' for IE in Pastel and stuff. (Pastel/ie7.css, Pastel/ie8.css, Pastel/sections.css, rtl.css, sections.css)
* Moved jump box back above the quick reply area. (Display.template.php)
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 01:28 AM
Revision: 630
Author: arantor
Date: 00:28:32, 03 March 2011
Message:
! Get the correct posts with pagination, and ordering, based on whether this is a board or blog topic. (Display.php)
----
Modified : /trunk/Sources/Display.php
Title: Re: New revs
Post by: Nao on March 3rd, 2011, 11:06 AM
rev 631
(5 files, small commit)

* $user_info['host'] should have the real host, not the fake one. I'm starting to get lost with all of this Pretty URL crap... (Load.php, QueryString.php, Subs-Cache.php)
* Updated Microsoft CDN URL for jQuery. Heck, the new URL is so ugly. Who wants to use that? (Load.php)
! Fixed menu not opening correctly in IE6 with Pastel. This was due to Belated_PNG taking too much time rendering the page background or something, so I simply replaced the PNG with a gradient filter. Magic. (Pastel/ie6.css)
* Spacinazi. (Pastel/ie6.css, Pastel/index.css)
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 11:35 AM
Revision: 632
Author: arantor
Date: 10:33:49, 03 March 2011
Message:
! A bit of reorganisation of the display template, likely more to come (Display.template.php)
! Don't allow merging the first reply into the post unless we're actually in a board context (so no merging the first reply to a blog post, for example) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Nao on March 3rd, 2011, 04:29 PM
rev 633
(4 files, 12kb)

+ Now showing topic titles and direct links instead of 'Previous' and 'Next' in the prev_next area. Because it's a complicated addition, I'm committing it for reviewing purposes only. (Display.php, */sections.css)
! Modified some board type logic to use != 'board' instead of == 'blog'. Hopefully more future-proof? (Display.php)
* Slightly reworked the linktree in Pastel. (Pastel/index.css)
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 05:07 PM
Revision: 634
Author: arantor
Date: 16:07:38, 03 March 2011
Message:
! Do not check for union or subselects in the query engine, we might use them. (Class-DB.php)
! Oops, forgot to bring $modSettings into scope (Display.template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 05:13 PM
Revision: 635
Author: arantor
Date: 16:12:57, 03 March 2011
Message:
! Fix counting of replies for multi-page non-forum topics, so we don't display "reply #x" when we shouldn't. (Display.php)
----
Modified : /trunk/Sources/Display.php
Title: Re: New revs
Post by: Nao on March 3rd, 2011, 06:30 PM
rev 636
(1 file, 3kb)

- Prev/next queries no longer need the enableQueryCheck hack. (Display.php)
! Forgot to take the board ID into account for blogs. (Display.php)
Title: Re: New revs
Post by: Nao on March 4th, 2011, 08:26 PM
rev 637
(27 files, 33kb)

! Various fixes to installer glitches or indentation. (install.php, install.css)
* Use the Google CDN by default to retrieve jQuery. (install.sql)
* Implemented custom sorting into prev/next code. Leaving the extra code commented out in case we want to optimize later. (Display.php)
* Did some serious fixing for prev/next layout. (Display.template.php, index.template.php, ie6.css, ie7.css, index.css, Pastel/index.css, Pastel/sections.css, sections.css, Wine/index.css)
* Started using on_timeformat() instead of timeformat() for some areas. Also, $txt['on'] is not clear enough. I'm sure there are languages where it sounds awkward, so I added $txt['on_date'] for use in sprintf() calls. Needs more conversion work! (Display.php, Recent.php, Search2.php, index.english.php, index.french.php, Recent.template.php, Search.template.php)
* Started converting some <label for=""> tags to just <label>. (TEMPLATES: Admin, Announce, Errors, ManageAttachments)
+ Added support for box-sizing CSS property. (Subs-Cache.php)
+ Added img_blankGif() function. Unused for now, but it may prove useful in the future. (Subs.php)
- Removed PIE.htc and support for border-radius in IE6/7/8. That's what you get when you suck, IE! (PIE.htc, Pastel/settings.xml)

I started work on a few simplifications as you can see (labels, on_date), but I'm a bit tired with it... Do you think you could do the rest, Pete? At least for on_timeformat... label stuff is repetitive crap that I can do mindlessly ahah.
Title: Re: New revs
Post by: Nao on March 5th, 2011, 04:44 PM
rev 638
(16 files, 25kb)

* Updated the RSS block to align links next to each other. This looks better. (index.template.php, index.css, index.english.php, index.french.php)
* Updated Pastel and inherited styles to use .cat and .title instead of .cat_bar and .title_bar... This should make it easier to update Warm without breaking the rest. (Pastel/*)
! Undefined index error. (ManageServer.php)
Title: Re: New revs
Post by: Nao on March 5th, 2011, 08:16 PM
rev 639
(4 files, 13kb)

+ Implemented string cutter, direct from Aeva Media. Hopefully it works. (Class-String.php)
* Cut prev/next topic titles if they're too long for the header. (Display.php)
- No need for the top subject template anymore... (Display.template.php, topic.js)
Title: Re: New revs
Post by: Nao on March 5th, 2011, 10:13 PM
rev 640
(8 files, 11kb)

* Moved "Read x times" to the sidebar, and added sidebar stats for boards/blogs and topics. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php, index language files)
! Fixed wrong margin in the sidebar userbox. (index.css)
! Pixel-perfect. (Pastel/index.css)

NB: It'll be longer to implement actual per-board stats, though... Just getting the number of posts and topics is boring. We need something like Noisen with the number of different posters as well as specific stat pages for each board.
Title: Re: New revs
Post by: Nao on March 6th, 2011, 12:14 AM
rev 641
(1 file, 5kb)

+ A short but nice one... Drop a "custom.css" file to any of your style folders, and you can change that styling without the need to create a sub-styling (or, worse, editing the supplied styling files.) (Subs-Cache.php)
Title: Re: New revs
Post by: Arantor on March 6th, 2011, 01:42 AM
Revision: 642
Author: arantor
Date: 00:42:06, 06 March 2011
Message:
! Incorrect sprintf formatting in English string (index.english.php)
! Fixed board RSS feeds having Array instead of the board id (index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on March 6th, 2011, 03:48 AM
Revision: 643
Author: arantor
Date: 02:43:21, 06 March 2011
Message:
! Attempt to fix ordering for prev/next topics (Display.php)
----
Modified : /trunk/Sources/Display.php


OK, this is a WIP fix. It deals with all the cases where we don't need the poster's name (first poster/last poster), I thought this was supplied by $topicinfo but it isn't.

The second problem is that invariably, the second query in the UNION sucks, and I mean *really* sucks. Right now I'm seeing 1.5s or more, but the reason is the way MySQL handles that selection on my 209k topic board; it's not using an index because it figures a table scan will be faster, but ultimately ends up filesorting the lot - here's the subselect on its own:

Code: [Select]
EXPLAIN SELECT t2.id_topic
FROM wedge_topics AS t2
INNER JOIN wedge_messages AS mf ON ( t2.id_first_msg = mf.id_msg )
WHERE t2.id_board =1
AND t2.id_topic <209240
ORDER BY t2.is_sticky DESC , t2.id_topic DESC
LIMIT 1


id   select_type   table   type   possible_keys   key   key_len   ref   rows   Extra
1   SIMPLE   t2   range   PRIMARY,first_message,id_board,last_message_sticky...   PRIMARY   3   NULL   209239   Using where; Using filesort
1   SIMPLE   mf   eq_ref   PRIMARY   PRIMARY   4   wedge.t2.id_first_msg   1   Using index

(t2 used in case MySQL was crapping itself between what t was, but it doesn't matter in this case, it makes no difference)

We gotta figure out a better way of handling this, it's not even using the primary key as a sorting criteria. :( But at least the ordering seems to be right now for the given criteria...
Title: Re: New revs
Post by: Nao on March 7th, 2011, 10:03 AM
rev 644
(16 files, 50kb -- all of my changes from this weekend. Didn't get to commit them until now.)

! Fixed a couple of bugs in westr::strlen and westr::strpos. (Class-String.php)[1]
* Rewrote theme thumbnail system to use thumbnail.jpg (instead of thumbnail.gif) and have them in their corresponding style folders, rather than in the images folder. (Themes.php, Themes.template.php, thumbnail.gif, Settings.english.php, Settings.french.php)
* Modified terminology of "child boards" to become "sub-boards" instead. Kept all variable names, we're only changing the English language for this. (LANGUAGES: Help, index, ManageBoards, ManageMaintenance, Profile)
! Fixed some minor font issues in the menu system. They were apparent in Windows XP + ClearType, maybe in other systems too. (index.css)
+ Added TEMPORARY thumbnails for Warm, Pastel and Wine. Need to do them again with a clean install... (thumbnail.jpg)
 1. Still warrants a recheck ;) Most notably, I'm not sure why there's the STRPOS* const at all, since basically it's only being used alongside "|." and could easily be replaced with "ENTLIST|." if you catch my drift.)
Title: Re: New revs
Post by: Nao on March 7th, 2011, 06:57 PM
rev 645
(22 files, 33kb)

+ Added a RSS icon for board categories. (BoardIndex.template.php)
+ Added ability to prevent a small image from being inlined in CSS files, through url-no-base64(). Useful for graphics that only show up in the admin area, things like that. Although really you want to put these declarations to admin.css instead... (Class-CSS.php, sections.css)
* Rewrote the toggler object to avoid wasting hits on graphics. bToggleEnabled was removed (if you don't want to run the toggler, just don't initialize it in the first place), srcExpanded and srcCollapsed are replaced with background positioning. Converted most togglers, more left to do. (BoardIndex.php, script.js, stats.js, topic.js, index.css, sections.css, foldable.gif, shrinkable.png, sortselect.gif, TEMPLATES: Admin, BoardIndex, BoardIndexInfoCenter, Display, index, ManagePermissions, Packages, PersonalMessage, Post, Search, Stats)
! Fixed default styling's thumbnail in theme picker, in case the default isn't in the root. (Themes.template.php)
! Fixed styling in daily stats called through Ajax. (stats.js, sections.css)

NB: I've tested 95% of all togglers. Hopefully, there aren't any bugs left... I know, the new system is less flexible (requires spriting your stuff, and having it in doubled square dimensions, e.g. 20px*40px or 12px*24px), but OTOH it saves a hit, and it has less 'glitches' than the SMF method. That's why, ultimately, I figured the pros outweighted the cons.
Title: Re: New revs
Post by: Nao on March 7th, 2011, 09:18 PM
rev 646
(17 files, 17kb)

* Reworked the toggler spriting system to use a class toggler instead of changing background-position. This way, spriting is no longer mandatory, and two different images can be used in the CSS. (script.js, stats.js, topic.js, sections.css, TEMPLATES: index, ManagePermissions, PersonalMessage, Search)
* Don't bother specifying altCollapsed and msgCollapsed if they're identical to altExpanded and msgExpanded. (BoardIndex.php, script.js, stats.js, TEMPLATES: Admin, BoardIndex, index, ManagePermissions, Packages, Post)
! Fixed stats header layout and colors. (Stats.template.php, index.css, Wine/index.css)
* Converted category collapse code to the new system. (Subs-BoardIndex.php)
* Improved header in Wine. (Wine/index.css)
Title: Re: New revs
Post by: Nao on March 8th, 2011, 01:05 AM
rev 647
(21 files, -4 files, 19kb)

* Converted maintenance area to use sprited collapse, and fixed code in the topic management page. (ManageMaintenance.template.php)
- Removed earlier files that are no longer used anywhere in Wedge. (collapse.gif, expand.gif, upshrink.png, upshrink2.png)
* More Wine style details. (Wine/index.css)
* Rewrote silly array[array.length] = x calls into array.push(x)... (smfinfo.php, Class-Editor.php, ManageSmileys.php, editor.js, fader.js, post.js, script.js, spellcheck.js, stats.js, topic.js, TEMPLATES: Calendar, Display, ManageCalendar, ManagePaid, MessageIndex, PersonalMessage, Post, Search)

Note: generateDays() uses dayElement.options[dayElement.length]. It should probably be dayElement.options[dayElement.options.length] and I treated the conversion this way. Hopefully nothing was broken in the process... I only tested the JumpTo stuff (it works fine.)
Title: Re: New revs
Post by: Nao on March 8th, 2011, 03:16 PM
rev 648
(8 files, 15kb)

* Plenty of fixes, simplifications and optimizations for string-related functions. (Class-String.php)[1]
* Rewrote string cutter to: fix strlen/substr when mb_* functions aren't available, fix mb_* when available (forgot to force them to UTF), and avoid cutting the ellipsis in half with a soft hyphen. Yes, it was possible to do that... Uh. (Class-String.php)
* Renamed {query_see_only_board} to {query_list_board} and {query_wanna_see_only_board} to {query_wanna_list_board}, and related variables. It means 'make sure the board can be listed', as opposed to not only listed, but also browsed. (Load.php)
! Added query_wanna_see_board to ssi_topTopics() for very large boards. If performance is an issue... Just don't use SSI, all right? (SSI.php)
* Replaced operator/notoperator with proper >/< signs. Saves a bit of processing time... (Display.php)
* Made the category collapse image stylable. (Subs-BoardIndex.php, sections.css)
* French translation tweak. (index.french.php)
* Single-byte-nazi. (Class-Editor.php)
 1. Pete, if you're unsure about any of these, feel free to ask and I'll explain my changes ;)
Title: Re: New revs
Post by: Nao on March 8th, 2011, 07:53 PM
rev 649
(30 files, 33kb... All done manually and double-checked at commit time >_<)

- Replaced all <label for="..."> occurrences with just <label> whenever it was possible. (install.php, Display.php, Profile.php, Subscriptions-PayPal.php, SSI.php, TEMPLATES: Admin, Display, ManageBans/Boards/Maintenance/Membergroups, ManageMembers/News/Paid/Search/Smileys, Memberlist, ModerationCenter, MoveTopic, Packages, PersonalMessage, Poll, Post, Profile, Register, Reminder, Reports, Search, SplitTopics, Themes)

NB: I removed the associated id in a minority of cases -- stopped when it proved too dull to do as I had to check whether JavaScript used these ids at all. Sounds like a job half done, but... 'screw you, I'm going home.' All I can say is that it's best to remove the id in loops (I tried to do it as much as possible), and in pages that get visited often. (Didn't look hard for these, though. But I know the setting pages in the profile area don't seem to use the id's too much. Or at all. Still -- I'm done. Too boring!)

:edit: I also didn't touch some of the 'other' folder's files. Too boring, once again, for files we may not even keep...
Title: Re: New revs
Post by: Arantor on March 11th, 2011, 10:58 AM
Revision: 650
Author: arantor
Date: 09:50:11, 11 March 2011
Message:
! Fix ordering to support topic starter/last poster name sorting. It's not pretty, but it's not a common case, and there isn't really a way to optimise it any better without nailing up queries that will have even more impact. (Display.php)
----
Modified : /trunk/Sources/Display.php

Posted: March 11th, 2011, 10:50 AM

Revision: 651
Author: arantor
Date: 09:57:52, 11 March 2011
Message:
! Remove the ambiguous (and often unnecessary) join that should have been committed last time, oops. (Display.php)
----
Modified : /trunk/Sources/Display.php
Title: Re: New revs
Post by: Nao on March 11th, 2011, 03:09 PM
rev 652
(2 files, 7kb) -- just so that I can focus on other things...

* Removed $ent_list and $ent_check variables from westr (not used), and replaced them with $can_mb, which determines whether mb_* functions are supported. Maybe it's slower than an is_callable, I don't know, I don't care. (Class-String.php)
* Force UTF-8 encoding on mb_* functions. Just wanted to point out that UTF-8 is not always the default charset in mb functions. (Class-String.php)
! Fixed an undefined index in westr::strpos(). (Class-String.php)
* Made westr::strlen() about 3 times faster by saving an extra round of preg_replace and using mb_strlen if available. (Class-String.php)
* Tweak on poll option margins. (sections.css)
Title: Re: New revs
Post by: Nao on March 13th, 2011, 09:26 PM
My work for the weekend... (Not including a few WIPs.)

rev 653
(5 files, 10kb)

+ Added support for automatic quote splitting. (editor.js, post.js)
* Allow single-character selectors (a, p...) to extend something else. (Class-CSS.php)
! Fixed self::strlen() not working in itself. (Class-String.php)
! Fixed regression in preg_split's. (Class-String.php)
! Fixed in-topic moderation checkboxes. (topic.js)
Posted: March 13th, 2011, 08:47 PM

rev 654
(2 files, 8kb)

+ Added a 'wip' folder (Works in progress), because we need some place to commit stuff that is either not finished but could use retooling, or finished but not actually used anywhere. (other/wip, other/wip/text-overflow.js)
* Minor restyling of topic titles. (sections.css)
Title: Re: New revs
Post by: Nao on March 13th, 2011, 11:23 PM
rev 655
(2 files, 6kb)

* Wedge now correctly uses the current list of protected and self-closed tags (disabled or not), to build the list of exceptions for the auto-quote splitter. (Class-Editor.php, post.js)
! Fixed selectionStart processing in IE. (post.js)
! Fixed an error in JS logic... Well, actually, fixed the error popup, not the actual error. Will need some extra work... (post.js)
Posted: March 13th, 2011, 11:18 PM

rev 656
(+1 file, 6kb... Err, the file itself is 107 bytes though :P)

! Fixed sidebar position in Firefox when in hidden mode. (gecko.css)

:edit: the bug showed up in Wine. I fixed it in Warm so hopefully it was theme-wide, not Wine-wide. Otherwise the file needs to be moved to the Wine folder ;)
Title: Re: New revs
Post by: Nao on March 15th, 2011, 05:42 PM
rev 657
(4 files modded, 3 deleted, 9 added, 48kb)

* Replaced foldable system with a simple div instead of the cool, but slightly annoying inline blank image. This saves a total of 83 bytes per call. (index.css, sections.css, upshrinks.png, index.template.php, BoardIndexInfoCenter.template.php, more files to come.)
+ Added other/images folder, where we should store 32-bit, unedited versions of our icons and such before optimizing them for filesize. The menu sprite, I'm afraid, is a bit outdated, but I couldn't find a fresher copy. (buttons-32bit.png, quickbuttons-32bit.png, sprite-32bit.png, sprite-32bit (menu, old).png, upshrinks-32bit.png, also moved foldable.gif and shrinkable.png)
Title: Re: New revs
Post by: Nao on March 16th, 2011, 12:16 PM
rev 658
(12 files, 16kb)

* Applied new foldable code to category collapsing and news. Also fixed plenty of minor issues regarding IE support for these icons. Grmpf. (Subs-BoardIndex.php, BoardIndex.template.php, ie6.css, ie7.css, index.css, rtl.css, sections.css
* Removed #boardindex_table id and used #board_list instead. Also indenazi and added a placeholder class for category RSS icons. (BoardIndex.template.php, */settings.xml)
* Topic titles need different things. They can't use we:cat anymore. Let it go, now. We need the freedom to style these. (Display.template.php)
! Fixed validation on IE6/7. Not that anyone cares... (index.template.php)

As always... Some complicated shit! Also, can't get category collapse icons to show both states in IE6 because of its inability to style two classes at once. It works in other icons only because they're linked to a smc_Toggle() object. I changed the order from &.fold to .fold& (which, admittedly is uglier), because I think it's best to always see the "-" icon, rather than either the "+" icon or no icon at all...
Title: Re: New revs
Post by: Nao on March 18th, 2011, 04:45 PM
rev 659
(4 files, 9kb)

+ Added support for browser-specific CSS mixins. Example: mixin {ie6,ie7} sample(attribute: 0px) (Class-CSS.php)
! Enforced removal of child selectors when parsing class extensions for IE6. Basically, without this, the entire list of inherited selectors is discarded. (Class-CSS.php)
! Fixed CSS cache file URLs (should start with "Wedge" for the default styling, not "styles".) (Load.php)
! Always load settings.xml, even if we're using the default styling. IE6 still needs the freakin' help with transparent PNGs... (Subs-Cache.php)
! Fixed JS error in stat page when using IE6. (stats.js)

(Just committing the easier stuff. ;))
Title: Re: New revs
Post by: Nao on March 18th, 2011, 11:14 PM
rev 660
(23 files, 58kb)

+ Added support for complement() alias function in the CSS parser (equivalent of hue(color, 180) or hue(color, 50%)). (Class-CSS.php)
+ Added support for custom color functions through a hook (untested, though.) (Class-CSS.php)
* Replaced regular board status icons with a sprite that makes it possible to change the icons in stylings. Because IE6 doesn't support transparent PNGs and we don't want to waste time over it, I'm using a special, smaller version of the sprite with no transparency effect. Also, these new class names suck... Anyone got a better idea? (boardstatus.png in both PNG8 and PNG32, boardstatus-ie6.png, sections.css, ie6.css, BoardIndex.template.php, MessageIndex.template.php)
+ Added a 'ping' class to images with a transparent PNG. (Admin.template.php, and... Is that all? Is there really no other PNG32 image left?)
* Replaced toggler icons with sprited versions, and made them stylable as well. Some places in the admin area still require an update. It doesn't work well in IE6, but you know the drill... Screw you, IE6. (Display.template.php, Post.template.php, Search.template.php, gecko.css, sections.css)
* Moved bottom linktree to below the content area, allowing for more precise fine-tuning of its styling. (index.template.php)
* Lots, lots of fixes for IE6. Also fixed a couple of issues with IE. Warm and Wine should now be closer to their modern browser appearance. The 'grey' color isn't recognized in IE6, so changing it to the Americanish 'gray'. And changed the transparent PNG process to be much faster. (ie6.css, Wine/ie6.css, ie7.css, index.css, settings.xml, Wine/index.css, Wine/settings.xml, Wine/ie7.css, Wine/ie8.css)
* Changed topic pages to show titles in a new .posthead div, inherited from .cat -- technically, there's no reason to force all cat's to be table-based when it's really only used in that single place. (ie6.css, sections.css)

This is the big bulk of my changes to the CSS. Pete, you'll need to make sure your styling isn't broken by my changes to Wine!
Title: Re: New revs
Post by: Nao on March 18th, 2011, 11:42 PM
rev 661
(the "I'm going to bed, just want to be done with these..." revision)

* Updated boardstatus.png with a version that is 40% smaller and doesn't show any significant decrease in quality. (boardstatus.png)
* Pixelnazi. (sections.css)
- Board list no longer needs a PNG fix, eh... (settings.xml)
* Windowbg needs one, though. (Wine/settings.xml)
Title: Re: New revs
Post by: Nao on March 20th, 2011, 09:31 AM
rev 662
(3 files, 5kb -- interim release...)

! Typo in clean_cache. Thanks Aaron! (Subs-Cache.php)
! Don't bother splitting quotes when the open tag list is empty... (post.js)
- No need to PNGize #board_list img anymore. (Pastel/settings.xml)
Title: Re: New revs
Post by: Nao on March 20th, 2011, 07:54 PM
rev 663
(7 files, 15kb)

+ Added a new custom CSS property, 'gradient-background', which allows you to set a transparent background, or a (transparent or not) gradient background. The point is that, in addition to vendor tags, it also deals with IE and makes it compatible with IE 6-9. Only supports vertical gradients for now. (Class-CSS.php, ie6.css, ie7.css, ie8.css, index.css)
! Fixed a bug introduced in revision 76 which caused Firefox not to be detected in $browser. Yeah, that's an old one... Goes to show how much we test in Firefox, eh..? Or just the fact that it doesn't need too many hacks. (Load.php)
- Removed the ugly '/hex' solution for IE filters, since gradient-background will now take care of that. Moved color conversion to its own area, saving some processing time for other browsers. (Class-CSS.php, Subs-Cache.php)

Note: the gradient-background() function is still a bit... fragile. Meaning, it won't work with #rrggbb values, things like that. It only takes rgb, rgba, hsl and hsla as values, or color functions (when they return a non-# value). I will need to fix that, obviously... Also, just specifying one color ("gradient-background: rgba(0,0,0,.5)") will simply make it act as a "background-image: rgba(0,0,0,.5)", with an automatic fallback for IE (which was the goal, after all.)
Please comment on it -- whether you like it or not! ;)
Title: Re: New revs
Post by: Nao on March 21st, 2011, 04:59 PM
rev 664
(11 files, 18kb)

+ Added a third optional parameter to gradient-background, top/left which determines whether the gradient is vertical or horizontal. (Class-CSS.php)
* gradient-background should now accept any kind of color parameter. Untested, though. (Class-CSS.php)
* Optimized rgba emulation for IE and generally reworked the wecss class's structure, for whatever reason I don't remember. But it was probably a good one. (Class-CSS.php)
! IE8 doesn't support rgba(), either... I tend to forget that even that version sucks. (Subs-Cache.php)
* Trying to save a few milliseconds in IE6 when resizing the screen. On the other hand, I should disable it altogether for IE6, as it doesn't really work with it... (index.template.php)
* Moved the top linktree to the root, and renamed .linktree to #linktree and .linktree.bt to #linktree_bt (inherited). Should make it easier to style. (index.template.php, index.css, rtl.css, Pastel/index.css)
! Fixed some foldable icon margins and other glitches. (sections.css, Wine/index.css, Pastel/ie6.css)
- Debug code. (Post.template.php)
Title: Re: New revs
Post by: Nao on March 24th, 2011, 10:07 PM
rev 665
(3 files +1, 17kb)

! Fixed a potential undefined variable error when applying mixins. (Class-CSS.php)
! Added support for Safari gradients. Newer versions of the browser were fine, but not the current ones. (Class-CSS.php)
! It would seem that some versions of PHP, or whatever, don't support self::method calls inside a preg_replace_callback. Changed these to array($this, 'method'). (Class-CSS.php)
* Made French version clearer for keyboard shortcuts in the post box. (Post.french.php)
+ Added a different mini-logo in the Wine footer. (Wine/index.css, wedgesight.png)

None of this is about vertical alignment. I committed everything NOT related to it, actually. I'm strongly considering reverting my current local changes because, well... It's probably not worth all the trouble in the end.
Title: Re: New revs
Post by: Nao on March 25th, 2011, 11:12 AM
rev 666
(14 files, 21kb)

! A selector followed with "extends something" needed to have at least one child property (the alternative being to use "base: something" as a property) -- this is no longer the case, indentation is enough to point out that the selector is just supposed to inherit something else. (Class-CSS.php)
! Some fixes to the object logic (visibility and instances). I'm starting to grasp how it works. Yay. (Class-String.php)
! Re-split top page IDs into three single anchors as they used to be. This is because the page won't validate otherwise. Uhhhhh. (Display.template.php)
- Don't show the window resize script in IE6 and IE7, as the current table-based solution isn't out-of-the-box compatible with the display:table one. Also made the related function a bit shorter. (index.template.php)
* we:title2 should only be used when within a hierarchy below we:title... Also, RSS header text was missing some white space. (index.template.php)
- Removed 'p' tags inside prev/next links. They were a leftover from a previous hack... (Display.php)
- $substr wasn't used in westr::cut. (Class-String.php)
* More stuff needing white space. (Stats.template.php)
* Indenazi. (index.template.php, Memberlist.template.php)
* Some 'Allons-y, Alonso!' tweaks to the language files. (index.*.php)
* Tidbits. Dozens of minor changes that aren't worthy of a changelog line, but are still there. Mostly, remnants of my epic but failed attempt at introducing a general vertical alignment process. (Post.template.php, ie6.css, ie7.css, index.css, sections.css)
Posted: March 25th, 2011, 11:11 AM

Note: I forgot to add the Class-CSS.php file to the commit list. Will be in #667, as soon as I find a sec' to look into the instance crap.
Title: Re: New revs
Post by: Nao on March 25th, 2011, 11:42 AM
rev 667
(5 files, 10kb)

* Changed headers to actually use the header tag now... Might as well start using HTML5 tags now! (*/settings.xml)
! Oops, forgot to actually commit Class-CSS in the previous rev... (Class-CSS.php)
* Turned gradient_background and rgba2rgb into static methods, and fixed rgba2rgb to actually stop using class variables. (Class-CSS.php)
! Forgot to add a PNG workaround for IE6 in Wine's footer logo. (Wine/settings.xml)
Title: Re: New revs
Post by: Nao on March 25th, 2011, 02:07 PM
rev 668
(28 files, 26kb)

* Updated the official website link from wedgeforum.com to wedge.org
Title: Re: New revs
Post by: Nao on March 25th, 2011, 05:09 PM
rev 669
(5 files, 7kb)

! Fixed wrong alignment for category headers in IE6. (BoardIndex.template.php)
! Fixed header styling in browsers that don't support the header tag. Uh. (index.css)
! Fixed more IE6 issues: menu toggler arrow in IE6, and various minor details. (GenericMenu.template.php, ie6.css, index.css, rtl.css)
Title: Re: New revs
Post by: Nao on March 26th, 2011, 02:20 PM
rev 670
(5 files +1, 20kb)

+ Added support for version number of main browsers (IE, Opera, Firefox, Chrome, Safari), via a floating point number. (Load.php, Class-CSS.php)
- Removing a work in progress that I committed by mistake in the wedge.org renaming batch: alternative quote handling in Post.php. Moved it to the wip folder instead. (Post.php, other/wip/Post-alt-quotes.php)
@ Also committed another WIP by mistake, in Load.php this time, but it's working, so I'm leaving it in, hopefully we'll end up using it: on_date() function in Subs.php, which does all the work on 'on January 1st / today' formatting. It's just a single line though... (Subs.php)
! Board status icons were broken in IE6. (ie6.css)
- Removed useless img styling. (Pastel/index.css)
Title: Re: New revs
Post by: Nao on March 27th, 2011, 05:04 PM
rev 671
(13 files +1, 17kb)

* Moved img_blankGif() to a new wip file (Unused.php, where we should add all of our code snippets that aren't used but may be used in the future), and updated all files to use divs instead of these blank images. (other/wip/Unused.php, Subs.php, Admin.template.php, ManageMaintenance.template.php, ManagePermissions.template.php, Packages.template.php, PersonalMessage.template.php)
* Cleaned up the alt tags in togglers. (script.js, and a file of the above files.)
- Don't bother retrieving Safari/* version numbers, because we care about the Version/*, not the build number. (Load.php)
! Added a temp fix to set the left margin to zero in the user box if no avatar is selected. (index.template.php, index.css)
! Fixed potential XML error. (ManageServer.php)
* Minor tidbits. (member.css, Pastel/index.css)
Title: Re: New revs
Post by: Nao on March 29th, 2011, 10:39 PM
rev 672
(17 files, 19kb)

+ Added support for the $language variable in cached CSS files. Will be useful once I move the 'New' icon to CSS. (Subs-Cache.php)
! Make sure the index template is loaded before we add the RSS sidebar block. It would crash on $simpleActions otherwise. (index.php)
* $context['is_ajax'] isn't the only case where the chrome should be hidden, so I introduced a $context['hide_chrome'] variable instead, which is also set to true automatically in Ajax mode. (QueryString.php, Subs.php, Errors.template.php)
+ Added a new function, hideChrome(), which ensures Wedge will avoid showing the top and sidebar templates. You may also add a parameter that will list the main template layers you wish to use. Haven't tested most of the changes, but it should be fine. (CoppaForm.php, Load.php, ModerationCenter.php, Packages.php, Printpage.php, Reports.php, Spellcheck.php, Subs.php, VerificationCode.php)
! Fixed a cases where resetting the template layers was already done, something like that. (Help.php)
* Spacinazi. (CoppaForm.php, ManageErrors.php, Printpage.php, Subs-Cache.php, Admin.template.php, Errors.template.php, Search.template.php)

@ Note: $txt['image_lang'] isn't defined in our languages, but is used in the code. Should we remove it, or is it used for some specific languages? (Load.php)
@ Also: Pete, can you look into the hideChrome() occurrences? I didn't realize there were so many template resets... To think that most of them were broken in the previous rev, and none of us noticed it! :^^;:
Title: Re: New revs
Post by: Nao on March 29th, 2011, 10:45 PM
As often, I'm trying to commit big releases in several chunks, for readability reasons. I still need to fix Wine (I'm currently moving it to the root, 90% finished, took me many hours to do the move, oddly.)

rev 673
(9 files, 17kb)

* Renamed some classes in special templates to avoid confusing them with classes in the main style. Also made the names shorter because WAP cellphones usually have limited bandwidth... Saving money is good. (Reports.template.php, Wireless.template.php, report.css, wireless.css)
! News fader's icon didn't match the starting fold state. (BoardIndex.template.php)
- Removed .header class, which breaks the layout, but it'll be fixed in the next commit (big stuff coming.) (BoardIndex.template.php)
- Removed #menu_container class, as #navi already acted as such. Also removed .forumtitle class, as there's only one h1 tag in the headers. Styling coming in the next commit. (index.template.php)
* Replaced alt="!" crap with actual IDs. Styling coming..you know the drill. (GenericMenu.template.php, Pastel/index.css)
- Sometimes, some obscure, rarely used stuff is too precisely styled. Why bother? (member.css)
Title: Re: New revs
Post by: Nao on March 31st, 2011, 04:44 PM
rev 674
(36 files + 4, 71kb - mostly maintenance stuff but might be worth a look, if only at the changelog.)

* Harmonized file endings in the Sources folder, and other very minor spacing or logic changes. Oops, I forgot the closing PHP tag on a few of the classes I created... (Class-CSS.php, Class-JSMin.php, Class-Packer.php, ManageMaintenance.php, ManageMembers.php, ManageNews.php, ManageServer.php, PostModeration.php, PrettyUrls-Filters.php, Profile.php, Security.php, Subs-Captcha.php, Subs-Post.php, Subs-PrettyUrls.php, Subs.php)
* Reduced filesize of Wedge mini-logo and symbol, and moved original 32-bit versions to the other/images folder. (minilogo.png, wedgesight.png, wedgeship.png, minilogo-256.png)
* Every nerd knows that math trumps sex. (index.php, SSI.php)
* Saved a whopping two bytes per page load. What? (index.template.php)
* A detail in the French translation. Details annoy me enough to fix them. (index.french.php)
* Board manager had inverted cat and title header types. (ManageBoards.template.php)
- Removed debug parameter in updateSettings (unused.) (Subs.php)
- We don't see a reason to initialize rand_seed separately with microtime() instead of mt_rand. (Subs.php)
- No need for an extra cookie test when showing the newsfader. (BoardIndex.template.php)
- Removing the ONLY remaining occurrence of the titlebg2 class in Wedge. (Calendar.template.php)
- Removing last occurrences of tborder and bordercolor classes. They're remnants from SMF's Core theme, mainly. Also fixed related indentation. (TEMPLATES: Display, Login, Memberlist, MessageIndex, Packages, PersonalMessage, Profile, Recent, Register, Reminder, SplitTopics, Themes, admin.css)
Title: Re: New revs
Post by: Nao on March 31st, 2011, 11:33 PM
rev 675
(many files, big size. Didn't check it exactly, as I was busy fighting tree conflicts.)

* Switched Warm for Wine as new default styling. Wine is now a replace type, and Warm is an add type. Removed many useless default props for regular divs. Nested a few more declarations for readability. Got rid of titlebg2, tborder and other useless styles. (styles/*)
+ Added support for the "for" keyword in styling blocks. For instance <block name="cat" for="ie6,ie7"> should generate markup exclusive to IE6 and IE7. (Subs-Cache.php)
* Core Features page should show an underline for active feature links. (admin.css)
* Styling pick page in the profile area could use better header hierarchy. (Themes.template.php)
* Improved board list in Manage Board area, by showing a dotted bottom border instead of a complete solid border. (admin.css)
* IE6 doesn't need PNG fixes for the header area's reddish zones. A simple solid background saves time. (ie6.css)
* Re-implemented PNG fixes for windowbg/windowbg2, though. It's not that slow to apply, and it looks slightly better. Added instructions to disable it if you like. (settings.xml, ie6.css)
! Fixed a very small bright line that always showed up below the main menu in Wine. Finally got the bugger. (ie6.css)
! Fixed various details in the Pastel styling. Still needs a LOT of fixing. (Pastel/ie6.css, Pastel/index.css)
! Fixed double float margin in IE6 for upshrinks. (sections.css)
- Webkit didn't like the catbg/titlebg forced height. (webkit.css)
Title: Re: New revs
Post by: Nao on April 1st, 2011, 11:42 PM
Quite satisfied with tonight's work... Quick, barely buggy on first try, and all in all interesting -- notably the fact that WeCSS now supports retrieving file sizes dynamically. (Maybe I should use $images instead of $images_dir and transform the URL on the fly, though... But the current solution is, err... Safer?)

rev 676
(14 files, 18kb)

+ Renamed wecss_func class to wecss_color, and implemented wecss_func class with two new functions. width(url) and height(url) will return the dimensions of any image. Make sure to use the _dir variable variations for best results. ($images_dir instead of $images, etc.) (Class-CSS.php, Subs-Cache.php)
+ Added $language_dir, $images_dir and $theme_dir variables, for the above. Also fixed $language to actually work.
+ Added westr::safe(), which is just like westr::htmlspecialchars() but slightly faster (and simpler.)
* Turned language-specific new.gif into a base64 icon. YES. (Profile-Modify.php, SSI.php, BoardIndex.template.php, MessageIndex.template.php, PersonalMessage.template.php, Post.template.php, Recent.template.php, sections.css)
! $user_info['url'] (used in the language switcher) didn't have the proper current URL if inside a board. Hopefully this weird fix won't cause trouble. (Load.php)
! Don't need to recalculate $css_vars['$here'] on every file addition... Only the last one is needed. (Subs-Cache.php)
- Don't bother with IE6 emulation of windowbg backgrounds, because it doesn't seem to work on tr tags, and my patience is limited. (ie6.css)
Title: Re: New revs
Post by: Nao on April 2nd, 2011, 08:15 PM
The more time I spend on Pastel, the more depressed I am... Hence its new name :P

rev 677
(12 files + 7 modified, 45kb)

* Moved feed icon to CSS. (BoardIndex.template.php, index.template.php, index.css)
* Moved Pastel to under Warm, renamed it to Wuthering and fixed it. Not perfect, and not optimized... But I don't really care at this point. (Pastel/*, Warm/Wuthering/*)
! Fixed CSS variable declarations with mismatched opening or ending double quotes. (Class-CSS.php)
* Renamed "News" item to "In the news" in the French version. Makes more sense. (index.french.php)
* Replaced the semi-colon next to "News" with an arrow. (index.template.php, index.css, sections.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 01:30 AM
rev 678
(21 files +3, 22kb)

* Replaced all helptopics.gif occurrences with CSS. Again: YAY. (sections.css, other/ssi_examples.php, Modlog.php, Admin.english.php, Admin.french.php, TEMPLATES: Admin, Errors, GenericMenu, Login, ManageMaintenance, ManageNews, ManagePermissions, ManageSearch, ModerationCenter, Packages, Profile, Themes)
! Fixin' bad filters in Warm. Cancelled the fixes in Wuthering because they get inherited anyway. (Warm/ie*.css)
! Fixin' some odd stuff in IE6 admin layout. (ie6.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 10:59 AM
rev 679
(7 files, 11kb)

! A few of the help text links were being hidden by the help icon. (Admin.english.php, Admin.french.php, Login.template.php, Packages.template.php, Profile.template.php, Register.template.php)
* Indenazi. (Profile.template.php, sections.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 11:08 PM
rev 680
(7 files, 9kb)

! Fixed sidebar width in Chrome/Safari, due to a minor glitch in the var parsing regex. (Class-CSS.php)
! Fixed horizontal matching of dt/dd tags not working in IE6/IE7 due to a bug with clear: both and floated elements. Fixed through trial and error... (ie6.css, ie7.css, index.css)
! Fixed main content (next to sidebar) width in most browsers, due to an earlier fix for IE (what else?). (index.css)
- dl.settings_title is never used anywhere. (index.css)
- Can't find #ip_list anywhere either. (rtl.css)
- And .header... I think I removed the last one this week. (webkit.css)
* Modified Warm to make the sidebar blend in with the background, and have a single vertical rule separate it from the main content. (Warm/index.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 11:46 PM
rev 681

* Wuthering is back to being a root subfolder. Saves 700 bytes off the gzipped CSS file, and is slightly simpler. (Wuthering/*)
Title: Re: New revs
Post by: Nao on April 6th, 2011, 07:24 PM
Okay... There it is! :)
It's got a bug every ten lines, but it doesn't crash (at least not superficially.)
A note for testers: take the file /other/db_aeva.php, move it to the root, and run it from your browser. It should safely add all of the needed tables and table fields for you, just like Aeva Media's installer. Eventually, this file will be integrated into install.php, obviously.

rev 682
(98 files +197 files, 3.0 megabytes... W00t!!! :lol:)

+ Added Aeva Media. Now we're talking. (index.php, media/*, other/db_aeva.php, other/images/sprite-32bit.png, other/install.sql, Admin.php, Class-Editor.php, Load.php, ManagePermissions.php, Profile.php, Subs.php, Themes/default/aeva/*, images/aeva/*, images/bbc/sprite.png, Media.template.php, ManageMedia.template.php, editor.js, media.js, media-admin.js, uploader.js, index.css, media.css, up.css, LANGUAGES: Admin, Errors, Help, index, ManageMedia, ManagePermissions, Media, Post, Who)
* Renamed loadSubTemplate() to execSubTemplate(), and showSubTemplate() to loadSubTemplate(). Makes more sense. (Activate.php, Admin.php, Announce.php, BoardIndex.php, Calendar.php, CoppaForm.php, Credits.php, Display.php, Errors.php, Findmember.php, Groups.php, Help.php, Jseditor.php, JSModify.php, Load.php, Login.php, Login2.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePosts.php, ManageRegistration.php, ManageScheduledTasks.php, ManageSearch.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Memberlist.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Notify.php, PackageGet.php, Packages.php, PersonalMessage.php, Post.php, PostModeration.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, QueryString.php, QuoteFast.php, Register.php, Reminder.php, RepairBoards.php, Reports.php, Reporttm.php, Search2.php, Security.php, SendTopic.php, Spellcheck.php, SplitTopics.php, Stats.php, Subs-Auth.php, Subs-Menu.php, Subs-Package.php, Subs.php, Suggest.php, Themes.php, Unread.php, Unreadreplies.php, VerificationCode.php, Xmlhttp.php)
! Potential undefined index in browser detection code. (Load.php)
! Fixed infinite loop when providing a CSS file with a wrong path. (Subs-Cache.php)
! If asking for a full HTML5 tag along with the CSS file, the wrong parameter was used (src instead of href). (Subs-Cache.php)
! Small icon fix in menu code, and a temporary fix for Aeva Media icons. This one needs to go! (Subs-Menu.php)
! Fixed $here position to be dependent on the current file's position, rather than the final file, when several files were being requested at once. (Subs-Cache.php)
! Saving one's personal options for the first time wouldn't refresh the options page with the new settings. (Profile-Modify.php)
! Prevent user from moving popup window in source browser (error log). (ManageErrors.php, script.js)
* Moving Unknown's credit to the SMF2 area and other minor details. (Credits.php, Who.english.php, Who.french.php, Who.template.php)
* Use hideChrome instead of the old method. (ViewSMFile.php)

@ Need to make sure including Exifer is okay. (GPL license)
@ My biggest commit ever (in the past, AND in the future I hope)... This is madness.
Title: Re: New revs
Post by: Nao on April 7th, 2011, 11:10 AM
rev 683 -- another cool commit IMHO :)
(10 files, 22kb)

+ Added support for complex blocks. (Load.php, QueryString.php, Subs-Cache.php, index.template.php, settings.xml)
+ Finished implementing Aeva Media's install-both.xml file. Used the opportunity to also protect PMs with only a video in them, and add HTML5's video and audio tags to the whitelist. (JSModify.php, Post2.php, Subs-BBC.php, Who.php)
! Fixed a silly undefined index error. (Profile-Modify.php)

@ To do: add support for complex blocks in stylings other than Wine. Move default block setup to index.template.php's template_init(), so that it can effectively be set up by the theme itself.
Title: Re: New revs
Post by: Nao on April 7th, 2011, 12:13 PM
rev 684
(2 files, 7kb)

! Fixed undefined index errors anywhere Aeva was in action. $context['utf8'] no longer exists in Wedge, since we're always in UTF mode... Also removed a corresponding helper function, and a few 'u' modifiers that really didn't make sense at all. (Aeva-Embed.php, Aeva-Subs-Vital.php)
Title: Re: New revs
Post by: Nao on April 7th, 2011, 07:03 PM
rev 685
(17 files, 60kb)

! Block matching would crash on the front page, for a reason too obscure to me (and thus, probably to you too.) Replaced main regex to use atomic grouping. Although it shouldn't be of any use, it has proven its value in the similarly weird Goddess of All Regex in Aeva-Embed.php. Also made sure that identical nested blocks don't collide with each other. And finally, array_shift() shouldn't be called on an empty array, even if it doesn't generate an error. Now, who reads these changelogs anyway? Fixed some stuff buddies, and it works better now, that's all ya need to know. (Subs.php)
* Since 99% of all template_button_strip calls use a "right" parameter, set it to be the default. And seriously, the default actually generates a floattop class, which doesn't exist. SMF glitch! (Media.template.php, Display.template.php, index.template.php)
! Fixed loadLanguage calling for Aeva files instead of Media. (Aeva-Embed.php, Aeva-Foxy.php, ManageMedia3.php, Subs-Media.php
! Other aeva/media fixes, and removed debug code. (Aeva-Gallery.php, Aeva-Gallery2.php, LANGUAGES: ManageMedia, Media)
! Fixed rich editor to work in the Media area. (Subs-Media.php)
* Moved output buffer post-processing functions from the QueryString file to Subs, at least temporarily. (QueryString.php, Subs.php)
! Minor glitch in definition lists. Whatever. (index.css, sections.css)

@ Note: button strips need to be context_menus, actually.
Title: Re: New revs
Post by: Nao on April 8th, 2011, 01:33 AM
rev 686
(3 files, 11kb) (small, but took my evening away... >_<)

! Rewrote the block system (again!) to fix more crashes and allow for better handling of complex nested blocks with or without parameters, and define the default entries in the index template, rather than the Load file. Also documented some of the features. (Load.php, Subs.php, index.template.php)
* Moved sidebar and main content into blocks, and used the block system's browser detection feature to deal with IE6/7. (index.template.php)

NB: Here's what I changed in the block detection code, if you're interested...
  [^<] gets a + to save some memory by handling multiple non-< characters at once.
  Allow nested blocks within a block search, as long as it doesn't have the same block type. It doesn't work without the \\1. Will need further tests to understand why.
  Use the greedy setting to minimize memory consumption on big pages.
  Used a similar regex change on the <if> block searches.
  Rearranged variable search code in a way that makes more sense (and actually works.)
Title: Re: New revs
Post by: Nao on April 8th, 2011, 01:42 AM
rev 687
(3 files, 5kb)

! Load Aeva-Gallery2.php properly. Allows viewing the media pages in profile areas. (ManageMedia.php, Profile.php)
! The thing is called Exifixer, not Exifer, even though the original library says Exifer... (exif/exif.php)

(Some last-minute changes before I go to bed.)
Title: Re: New revs
Post by: Nao on April 8th, 2011, 02:15 PM
rev 688
(9 files +1, 12kb)

! A couple of areas still had mod_security compatibility issues. One of them was pointed out by myself and [Unknown] in 2009 to the SMF team and never fixed. I only remembered it now. Way to go, SMF. (ManageAttachments.php, Media.template.php)
* Added support for the newest URLs of YouTube. (Subs-Aeva-Sites.php)
+ Might as well put that useless $txt['lang_dictionary'] to good use and use it as a lang parameter in the html tag until we add a proper 2-letter code entry. (index.template.php)
+ Added an index.php protection to the Sources/media folder. Not very useful though.... (media/index.php)
* Renamed action=helpadmin;help=... to action=help;in=... because we no longer use the help action anyway, and it's not only for use in the admin area. Will do the rest in a batch in the next commit. (index.php, Help.php, Load.php, ManageMembergroups.php)
Posted: April 8th, 2011, 02:07 PM

rev 689
(23 files, 16kb)

* Finished renaming helpadmin to help. (All 23 files.)
Title: Re: New revs
Post by: Nao on April 8th, 2011, 09:28 PM
rev 690
(10 files, 24kb)

! parsesmileys() would search for every smiley twice (once in a normal version, once in a htmlspecialchar'ed version), even if they were the same. It also applied htmlspecialchar to a same string three times in a row... Oh please, come on! (Subs-BBC.php)
* Optimized parsesmileys() replacement code. Both versions are lightning fast. The new version is 10 to 20% slower when the string has no smileys, but 2 to 5 times faster when it meets one or more smileys. (Subs-BBC.php)
* Optimized the block replacement function code. Replaced the super-cool regexp with a lame series of strpos calls. The new version is much faster when using hundreds of blocks, but a bit slower with few blocks (could be made faster by removing the case-sensitivity code.) It's still more robust anyway, and easier to understand. (Subs.php)
* Providing a means for the playlist area to know whether the album link should be shown. Yeah I know -- extra query... (Aeva-Foxy.php)
* Simplified media menu and fixed current area highlighting. (Aeva-Gallery.php)
! Fixed headers in playlist area. (Aeva-Foxy.php)
! Some areas didn't properly rename Aeva-Subs to Subs-Media. (Aeva-Subs-Vital.php, Subs-Media.php, Subs-BBC.php, Subs.php, Who.php)
! Converted the Aeva Media changelog to UTF8, to avoid errors at parse time. This will eventually be used in the Wedge changelog, hopefully. (default/aeva/changelog.txt)
* Minor button strip fixes. Hopefully the new forced overflows won't break anything. (Media.template.php, index.css)
! .title2 link color should be the same as when not linked. (index.css)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 12:08 AM
rev 691
(7 files, 12kb)

- Removed case insensivity code from the block replacement path. Although very fast, it's not worth the trouble -- just be wise and use lowercase, there's no point in going uppercase here. (Subs.php, index.template.php)
! Fixed <if> replacements in the new code. (Subs.php)
! Block building code in Load.php was needlessly long (by 11 lines!), and forgot to apply the scripturl transform. (Load.php)
! Fixed image URLs in Media stylesheets. (media.css, up.css)
* Moved dummy block overrides from Wine to Warm (our 'sample case'), where I can take some time to explain what it does... (settings.xml, Warm/settings.xml)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 12:56 AM
rev 692
(1 file, 5kb) (Uh, actually one byte changed :P)

! Mismatched tags. (MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 04:29 PM
rev 693
(forgot to check stats, whatever.)

+ Added media icon to the main menu. (sprite-menu-32bit.png, sprite.png, Subs.php, index.css)
+ Added 3 pixels around each menu icon to avoid getting artifacts in some browsers (IE6, Safari Mobile...) (sprite*.png, index.css)
! Fixed three syntax errors in the ban manager. (ManageBans.php)
* A small change to avoid infinite loops when a tag is unclosed. (Subs.php)
* Starting HTML5 conversion of Media templates. Okay, just three lines... So what? (Media.template.php)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 05:42 PM
rev 694
(5 files, 7kb)

* Moved the admin notification area to the actual template to avoid issues with <we:> tags, and removed the related code from admin.js -- which was only used for that one case anyway. (Admin.template.php, admin.js, admin.css)
* It's Wedge, not SMF. (Admin.language.php)
Title: Re: New revs
Post by: Nao on April 10th, 2011, 01:52 AM
rev 695
(21 files +1-1, 29kb)

* Made Media area work. It is now possible to create albums, upload single items, and view the album and item pages. The rest is coming, of course. (Media.template.php, media.js and other files.)
! Fallback code in the wesql::insert function was incorrect. (Class-DB.php, Aeva-Gallery.php, Aeva-Gallery2.php
! Fixed (un_)preparsecode calls in Media area. (Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php,
! Fixed call to media.js and hs.css in Media area. (Aeva-Gallery.php, Media.template.php)
* Outdated table names. (Subs-Media.php)
* Renamed wedgeEditor object to wedit, for consistency reasons. (Class-Editor.php, Display.php, Jseditor.php, JSModify.php, ManageNews.php, ModerationCenter.php, MoveTopic.php, PersonalMessage.php, Post.php, Subs-Media.php, Post2.php, Profile-Modify.php, QuoteFast.php, Subs-Post.php)
* Minor details. (Media.template.php)

More coming tomorrow... Just a bit late, see?
I'm very glad that the gallery finally works. It was less work than expected (I estimated two weeks of work minimum, not one week!)
Title: Re: New revs
Post by: Nao on April 10th, 2011, 02:20 PM
rev 696
(25 files -1, 34kb)

* Enabled Gallery and Auto-embed settings to actually be enabled/disabled through the Core Features area. Hide the main and admin menus with respect to these settings. (Admin.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php, ManageMedia3.php, Subs-BBC.php, Subs.php, Media.english.php, Media.french.php)
* Core Features should be detected through an isset(). Should be faster than in_array(). Both methods will be available until everything's converted. (Admin.php, Load.php)
* Renamed Exif to Metadata in the UI and internally, to make room for potential future implementations. (db_aeva.php, Aeva-Foxy.php, Aeva-Gallery.php, Class-Media.php, ManageMedia.php, Subs-Media.php, Media.template.php, Admin.english.php, Admin.french.php, ManageMedia.english.php, ManageMedia.french.php, Media.english.php, Media.french.php)
* Renamed a few remaining 'aeva' fields to 'media' or 'misc'. (db_aeva.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia2.php, Subs-Media.php, Subs.php, Media.template.php)
- Removed Sources/media/exif folder, as it was an old version of Subs-Exif.php (oops.)
! Calling in_array('m', array('m,cd,cp')) is going to return false. I'm just telling you, SMF. This is how it works. (install.sql, Load.php)
! Fixed infinite loop when dealing with an empty menu. (Subs-Menu.php)
Title: Re: New revs
Post by: Nao on April 10th, 2011, 04:14 PM
rev 697
(9 files, 11kb)

* Renamed (again) media and auto-embed core features to use 'media_enabled' and 'embed_enabled' single settings. Eventually, core features will all have their own settings and use them where needed. (install.sql, Admin.php, ManageSettings.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php, Subs-BBC.php, Subs.php)
Title: Re: New revs
Post by: Nao on April 11th, 2011, 01:22 PM
rev 698
(14 files, 16kb)

* Turned admin_features into a series of variables. (install.sql, upgrade.sql, Admin.php, Display.php, Load.php, ManagePermissions.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, Profile-View.php, Profile.php)
! Fixed post boxes in media area. (Subs-Media.php, Media.template.php)
* Temp header update. (media.js)
Title: Re: New revs
Post by: Nao on April 11th, 2011, 07:46 PM
rev 699
(2 files, 12kb)

- Removed self-closed tag closers (?) from Media templates and fixed a few things (labels, etc.) Source files aren't done yet. (Media.template.php, ManageMedia.template.php)
Posted: April 11th, 2011, 07:17 PM

rev 700
(12 files, 15kb)

- These source files have tons of templating in them... So much for the MVC model uh. Removed all />'s where needed, and a few more fixes as usual. Renamed all remaining SMG tags to MEDIA. (Sources/media/*, ManageMedia.language.php, Media.template.php)
Title: Re: New revs
Post by: Nao on April 11th, 2011, 11:29 PM
rev 701
(6 files, 11kb)

! Fixed lists of children albums looking really bad due to the new rounded corner markup. Well, I couldn't find a perfect solution so I made a couple of changes. I'm not satisfied though... (Subs-Media.php, media.css)
! Minor thingies. (ManageMedia.english.php, Media.template.php, hs.css)
+ Added .wrc_top and .wrc_bottom classes, in case they ever make themselves useful. Not for now though... (index.css)
Title: Re: New revs
Post by: Nao on April 12th, 2011, 04:11 PM
tl:dr --- mass upload fixed :)

rev 702
(10 files +1, 32kb)

* Added support for icon transparency in playlist headers. (Aeva-Foxy.php, media.css)
* Cleaned up mass upload interface and JS, and delayed said JS to the bottom. (Aeva-Gallery2.php, Media.template.php, index.css, up.css)
! Fixed mass upload. It now actually works, although the jQuery version is still being worked on. (up.js, uploader.js)
! Fixed some wrong paths for Media scripts. (Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php)
! Silly oversight in block replacement code caused empty params to show an unprocessed if-block instead of hiding it or processing it. (Subs.php)
Title: Re: New revs
Post by: Nao on April 12th, 2011, 06:13 PM
tl:dr -- Highslide fixed :)

rev 703
(5 files +1-2, 115kb) (that's mainly because of the JS files being swapped... Actual changes are minor.)

! Forgot to capture a match during template error processing. (Load.php)
! Fixed Highslide support. (Aeva-Subs-Vital.php, aeva/highslide.js)
* Fixed item pages with no comments to show something actually watchable. (Media.template.php)
* Restored jQuery version of uploader JS, as I finally found why it was going cuckoo. (up.js)
Title: Re: New revs
Post by: Nao on April 12th, 2011, 08:04 PM
rev 704
(4 files, 8kb)

! Fixed item commenting. (Aeva-Gallery.php, Media.template.php)
* Styling details. (up.js, media.css)
Title: Re: New revs
Post by: Nao on April 13th, 2011, 12:22 AM
rev 705
(8 files, 12kb)

! Fixed hover popups in album pages. The IE hack makes use of the selector precedence algorithm. I think it's the first time I actually devised this, instead of doing it by chance. (media.css, ie6.css, ie7.css)
! clear_thumbnames should be set by default, because we want the best possible performance for avatars. (db_aeva.php)
! Media Maintenance tasks were broken. (ManageMedia2.php)
* Don't turn -moz-border-radius into -moz-webkit-border-radius, things like that. Remember, friends: just use border-radius. Wedge will do the rest. (Subs-Cache.php)
* Fixed uploader script and converted the rest to jQuery. (up.js)
* Minor details. (Load.php)

@Note: Highslide is broken (again). I don't know what exactly caused this, since it worked up until the previous rev, if I'm not mistaken. :-/
Title: Re: New revs
Post by: Nao on April 13th, 2011, 10:39 AM
rev 706
(1 file)

! Fixed Highslide by replacing it with an older, more solid version... Until I get to replace it with another library, really. (highslide.js)
Title: Re: New revs
Post by: Nao on April 13th, 2011, 08:11 PM
rev 707
(6 files +1, 86kb -- mostly the addition of highslide-full.js)

* Fixed Highslide full version, moved JavaScript calls to the JS footer, and rewrote code to use rel tags instead of events. (Aeva-Embed.php, Aeva-Subs-Vital.php, Subs-Media.php, ManageMedia.template.php, Media.template.php, highslide-full.js)
! Media tag helper popup needed a scrollbar. (Media.template.php)
! Fixed JavaScript error when manually removing a file that was rejected by the script for being too large. (up.js)
Title: Re: New revs
Post by: Nao on April 15th, 2011, 09:52 AM
rev 708
(7 files +17-15, 82kb)

* Swapped SMF and Wedge names in the footer, so that we can use Wedge on live websites without breaking the mandatory SMF copyright mention. (index.php)
* Updated variable names in AeMe installer, although it's only useful for tester upgrades, not for new installs. (db_aeva.php)
- cal_enabled was defined twice in the installer. (install.sql)
* Partly rewrote the CSS caching system to allow for more flexibility (at the cost of more file_exists tests, which shouldn't be a problem with OS caching.) css_generic_files is split into another array, css_main_files, which contains the actual main CSS files, while css_generic_files now only contains overriding stylesheets, and is also loaded by stand-alone stylesheets, making it easy to override any stylesheet with stylesheet_name.override_name.css (Load.php, Subs-Cache.php)
* Renamed all override-type files to index.original_name.css, and moved Media-specific hacks to media.original_name.css. (*.css)
- Hide the 'webkit' keyword in CSS URLs if we have a more specific browser recognized by Wedge. (Subs-Cache.php)
! CSS caching didn't work at install time because of the missing $context['user'] variable. (Subs-Cache.php)
+ Added a .hide class that simply does display:none... It's cleaner this way, although it requires loading the CSS to apply it. Could turn out to be useful, though. (index.css)
* Made a comment a bit clearer. (Subs.php)

@ Note: should rewrite wedge_cache_css to merge it with add_css_file. Both do pretty much the same thing, with a few tweaks for main CSS files. (Subs-Cache.php)

@ Note: should really, really test the CSS caching system with new themes... Have never done so. It probably doesn't even work properly. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on April 15th, 2011, 11:18 AM
rev 709
(4 files, 6kb)

! webkit keyword wasn't removed from filename if at the beginning or the end[1]. (Subs-Cache.php)
! Made DragSlide a bit more open to non-reqWin popups. (script.js)
* Details. (Aeva-Gallery.php, media.js)
 1. Tested in Safari...
Title: Re: New revs
Post by: Arantor on April 16th, 2011, 10:38 AM
Revision: 710
Author: arantor
Date: 09:37:11, 16 April 2011
Message:
! Make sure user-agent is actually defined for the purposes of BB checking. (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on April 16th, 2011, 09:06 PM
rev 711, aka "My revisions are badass!"
(13 files +5, 44kb)

* Replaced Highslide with a WIP lightbox called zoomedia. Excuse the pun. It isn't feature complete, and tends to fail on .scrollTop() requests, but it can be fixed, hopefully, and it's a pretty tight library. (close.png, close-32bit.png, Aeva-Subs-Vital.php (temp code!), hs.css (WIP), zoomedia.js)
+ Added a micro-optimization to Javascript cache code, allowing for slightly smaller files. (Subs-Cache.php)
! Fixed a bug that caused earlier versions of cached files not to be deleted as thought of. (Subs-Cache.php)
! Apparently, the File API specification was modified since the Aeva Media days, which triggered an error in Opera 11.10. (Aeva-Gallery.php)
* Clean-up job. Nothing worthy of documenting, but somehow important to me. (Class-Packer.php, Errors.template.php, Media.english.php, Media.french.php, editor.js, script.js, admin.css, index.css, sections.css, aeva/change_menu*.png (temp fix for silent errors))
Title: Re: New revs
Post by: Arantor on April 16th, 2011, 11:46 PM
Revision: 712
Author: arantor
Date: 22:45:36, 16 April 2011
Message:
! PHP is not as smart as humans at dealing with one line branches, so better be clearer for PHP's benefit. (Security.php)
----
Modified : /trunk/Sources/Security.php


While the fix technically made sense, PHP could have been ambiguous in its handling of the branch else because it wasn't clear whether it applied to the nested if or the parent one, so I gave it braces.
Title: Re: New revs
Post by: Nao on April 17th, 2011, 12:13 AM
rev 713, aka "It's a 2-line commit, too. Nah, just kidding, just got more work for you guys."
(9 files, 34kb)

* Updated the mass upload area. Updated YUI Uploader to v2.8.x, moved their Uploader JS to local so as to fix a bug in SWFObject + Opera (maybe other browsers). Reworked layout for cooler file lists. (Aeva-Gallery2.php, uploader.swf, up.js, up.css)
! Fixed regression where sub-files added to the main CSS file list weren't correctly cached. (Subs-Cache.php)
* Done some extra work to make the Media template a bit more validator-friendly. (Media.template.php)
* Pathetic urge to save even more bytes in zoomedia... Now 658 bytes after compression. (zoomedia.js)
* Error log was ugly. Me no like ugly things. Me like beer and women. In that order. (admin.css)
! Context menus could be followed up by a misaligned element. (index.css)
Title: Re: New revs
Post by: Nao on April 17th, 2011, 02:38 AM
rev 714
(5 files, 9kb)

! Late night woopsies.

Too tired to document. View the diff patch ;)
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 02:52 AM
Revision: 715
Author: arantor
Date: 01:52:23, 17 April 2011
Message:
! Some fixes for undefined character set (legacy stuff) (Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php, Media.template.php)
----
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Themes/default/Media.template.php
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 03:35 AM
Revision: 716
Author: arantor
Date: 02:34:44, 17 April 2011
Message:
! Fix missing dependencies for the mass uploader (Aeva-Gallery2.php)
----
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 03:47 AM
Revision: 717
Author: arantor
Date: 02:46:59, 17 April 2011
Message:
! Aeva DB changes should not require default values on text columns (db_aeva.php)
! Harmonising media permissions fully (Admin.php, ManagePermissions.php, ManagePermissions.english.php, ManagePermissions.french.php, ManageMedia.php, Aeva-Subs-Vital.php, Subs-Media.php, Profile.php, Subs.php, Errors.english.php, Errors.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Aeva-Subs-Vital.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/other/db_aeva.php
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 03:54 AM
Revision: 718
Author: arantor
Date: 02:54:32, 17 April 2011
Message:
! Oops, forgot to update the permissions/group associations. (ManagePermissions.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Title: Re: New revs
Post by: Nao on April 17th, 2011, 09:13 AM
rev 719, aka "I can do one-liners, too, just like the SMF team!"
(1 file, 4kb)

* Updated aeva_allowedTo permissions. (Aeva-Subs-Vital.php)
Title: Re: New revs
Post by: Nao on April 17th, 2011, 10:33 AM
rev 720
(6 files, 28kb)

! The mass upload script should really be linked with ampersands. (Aeva-Gallery2.php)
* YUI 2.9.0 updated the Flash file as well. (aeva/uploader.swf)
* Button schmutton. Changed all 'button' strings to 'item' in the main menu code. (Subs.php, SSI.php, index.template.php)
* Updated the media language header to reflect the newfound difficulties for translators. (Media.english.php)
Title: Re: New revs
Post by: Nao on April 17th, 2011, 04:09 PM
rev 721
(12 files, 16kb)

! iPhone devices were internally recognized as Safari instead of iPhone.
! Fixed a few undefined strings in non-admin situations. (Aeva-Gallery.php, Aeva-Gallery2.php)
* Don't bother showing auto-resize code for iPhone, it doesn't work well. Rewrote CSS and added some JS to show the sidebar at the bottom instead. (index.template.php, index.iphone.css, settings.xml)
! A few language strings were using entities uselessly. (ManageMaintenance.french.php, ManagePaid.*.php, ManagePermissions.french.php, ManageScheduledTasks.french.php, ManageSettings.french.php)

@ Note: for iPhone, should work further on it to make the sidebar fill the screen width optimally... Should also implement <meta name="viewport" content="width=device-width"> at some point.
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 11:26 PM
Revision: 722
Author: arantor
Date: 22:23:42, 17 April 2011
Message:
! Fix check against Expect:100-continue header to be check for HTTP/1.0 as a failure condition. (Security.php)
! Upgrade bundled test library to use that from BB 2.1.12, which solely affects the list of IP blocks known to be held by Googlebot. (Of course, until IPv6 is completely finished this doesn't make a lot of difference...) (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on April 18th, 2011, 12:12 AM
rev 723
(4 files +2, 10kb)

+ Finished implementation of overlay descriptions. Pretty neat. (Aeva-Subs-Vital.php, zoomedia.js, hs.css, hs.ie6.css, hs.ie7.css)
* Replaced last non-CSS implementation of the New icon. (Subs-Media.php)

PS: demo site is updated with these overlays. Have a look at album pages! Oh, I'm starting to love jQuery again... :)
Posted: April 17th, 2011, 11:55 PM

rev 724
(2 files, 6kb)

! Fixed glitches in overlay descriptions. (zoomedia.js, hs.css)
Title: Re: New revs
Post by: Arantor on April 18th, 2011, 06:06 PM
Revision: 725
Author: arantor
Date: 17:06:03, 18 April 2011
Message:
! Don't try loading the sidebar items for who's viewing a topic/board in WAP2 mode, because it's extra fluff that we can't really afford and because it wasn't even handled by the wireless template anyway. (Display.php, MessageIndex.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MessageIndex.php
Title: Re: New revs
Post by: Nao on April 18th, 2011, 08:31 PM
rev 726
(9 files +5-3, 36kb)

* Keeping up with the Highslide to Zoomedia replacement process. (Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.template.php, Media.template.php, zoomedia.js, hs.*.css, zoom.*.css)
+ Improved description overlays and implemented language strings and loader icon in Zoomedia. The loader doesn't show up if the image is already cached. (zoomedia.js, zoom.css)
+ Added a nice animated loading icon. And it's transparent, yay. Not cancellable yet, though. (images/loading-flow.gif)
! Fixed (hopefully) all of the positioning bugs in Opera, IE6, IE7 and IE8. (zoomedia.js)
! Did I really forget to commit the iPhone stylesheet..? (index.iphone.css)
* Lowercase nazi. (install.sql)

PS: svn testers, please feed my back! ;) Isn't on the demo site yet, though. I'll post when it's done.
Title: Re: New revs
Post by: Nao on April 19th, 2011, 03:07 PM
rev 727
(10 files +1-1, 21kb)

* Replaced loading-flow icon to a smaller one (thanks for reminding me of that web service, Lorenzo!), and renamed it. (loader.gif, loading-flow.gif, zoom.css)
* Adding pngfix to IE6 in the default template is bad practice IMHO. Added an 'include' parameter to the code blocks in styling files, allowing to specify a list of comma-separated URLs for script files to be added for browser compatibility purposes. Also documented the whole damn thing in the Warm styling, as usual. That's pretty much one of the only things I've been documenting actually... (Subs-Cache.php, index.template.php, settings.xml)
* In the media area, transparent items would get a box-shadow override. Replaced this with a proper ping class (which was already there to tell IE6 an image was transparent). Ironically, DD_belatedPNG doesn't seem to work well on divs with a transparent background, so transparency still won't work in IE6... Did I hear someone say "screw IE6"? Is that you sir? Thank you, what's your name? Well Mr. Obvious, you're welcome to my place anytime! (Aeva-Foxy.php, Subs-Media.php, Media.template.php, index.css)
+ Added iOS hack to Warm and Wuthering. (settings.xml)
Title: Re: New revs
Post by: Nao on April 19th, 2011, 05:15 PM
rev 728
(3 files, 6kb)

! Pardon my French, but I'm fucking good. Leveraged the power of jQuery to make the ping class work on media items in IE6. Ah HA! (settings.xml)
Title: Re: New revs
Post by: Nao on April 19th, 2011, 11:34 PM
rev 729
(2 files, 8kb)

! Fixed
constructs to actually show several items next to each other. Also show captions in overlay mode... (Subs-Media.php)
* Detail. (index.css)
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 10:00 AM
Dammit... The SVN server is down. >_< (http://status.repositoryhosting.com)
I'll still post the full changelog. I took time to write it, and I just need to do the proper commit operation. I'll do it tomorrow if it's back online.

rev 730
(30 files +1-1, 75kb)

! A couple of fixes in the Help action to make it possible to use blocks inside text strings... Although I'm not using any in the end. (Help.php, Load.php, Help.template.php, index.css)
! Pages without chrome shouldn't be able to restyle the content block, as this one usually contains data connected to the sidebar block. Temp fix. (Subs.php)
* Seriously reworked the internals of the album page layout. Too much to say, but it's basically better. (Subs-Media.php)
* Making sure that the media.js file is always loaded when media headers are requested. This is a temp solution because this file will end up being merged with script.js, given its small size... (Subs-Media.php)
! Prevent a same JS file from being cached multiple times. (Subs-Cache.php)
* The media tag helper page should say what it's about to begin with... (Help.language.php)
+ Added footer, class and style parameters to <we:block>. Note to self: maybe this should be a generic parameter that can be set in an easier way...? (index.template.php)
! Moved delayed events to the very bottom, in case some of them are calling functions that are defined by stylings. (index.template.php)
* Completely overhauled the media item page layout. And guess what, I'm not happy with it... A small list of changes: turned tables into divs and lists, moved item to the left and item details to the right as a sidebar, aligned them similarly to a table (not tested in IE though), reordered details, and so on. (Media.template.php)
* Rewrote ajax_indicator in a simpler, jQuery-worthy way. (script.js)
- Merged media.js with script.js (media.js, Subs-Media.php, Aeva-Gallery.php)
+ Click the "Loading" indicator in media pages to cancel the load request. (zoomedia.js)
+ Added an alternative white background for Zoomedia boxes. Use the 'black' class on the zoom div to use the earlier one. (zoom.css)
* Moved most inheritable classes to their own section and added a new class that holds the loader icon. (index.css)
* Replaced Ajax indicator's close button with the loader icon. It can still be clicked to cancel the action... (index.css)
! Fixed checkbox/radio button styling in IE6. And yes, it's a bit hackish... (index.css, index.ie6.css, settings.xml)
! Fixed outdated block redefinitions in Wuthering. (settings.xml)
* Improved styling of the <we:block> blocks. (media.css)
* Rewrote media area CSS files to use the wecss formatting style. (media.*.css, zoom.css, up.css)
+ Added ie6hover.js script, which transparently makes IE6 accepts hover states on any given selector. (settings.xml, ie6hover.js)
! Fixed PNG transparency for IE6 in media area, which was broken in some specific cases due to weird markup. (Subs-Media.php, settings.xml)
- Removed aeva_header class and galurl JS variable. (Aeva-Foxy.php, Aeva-Gallery2.php, ManageMedia.php, media-admin.js)
Posted: April 21st, 2011, 11:55 PM

Committed.
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 05:14 PM
Got more work done, but it's not stable enough... Committing whatever I can.

rev 731
(4 files, 6kb)

* Moved item playlist template to the proper template file. (Aeva-Foxy.php, Media.template.php)
* Split media item template into several functions. (Aeva-Gallery.php, Media.template.php)
! One strlen call should have been passed through westr. (Media.template.php)
* Minor layout improvements. (medias.css)
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 05:49 PM
And... Still not happy with the new item page layout. Even with this new revision...

rev 732
(4 files, 8kb)

* <we:block> should have a .block class by default, not .windowbg... Will probably not work in this rev, because I have yet to commit the proper index.css file. (index.template.php)
* Moved media item details to the regular sidebar. Should add an option to choose where to show them... (Aeva-Gallery.php, Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 09:06 PM
rev 733
(13 files +1-1, 17kb)

! Fixed gradient backgrounds in IE 6/7/8 when a single color was fed to them. (Class-CSS.php)
* Make sure execSubTemplate() ignores empty sub-template entries, which makes it easier for us to conditionally set extra sub-templates... (Load.php, Aeva-Gallery.php)
* IE 6/7 don't like display: table, so put the media item details in the sidebar automatically. (Aeva-Gallery.php, media.ie*.css)
* Stopped right-aligning media item details. It actually looks better when left-aligned with a small margin... (media.css)
! Media RSS feeds needed some fixin'. (Aeva-Foxy.php)
* 'Information', and more importantly 'info', is not clear English, AFAIK. And yes, 'AFAIK' is clear English. (Media.english.php)
- Removed loadingbar.png and replaced it with simple CSS. (loadingbar.png, index.css)
* Other minor details. (index.css, Subs.php, Help.language.php)
! Undefined variable. (Media.template.php)

:edit: This is my 500th commit! :eheh:
Title: Re: New revs
Post by: Nao on April 23rd, 2011, 01:45 AM
rev 734
(3 files, 5kb)

- Is there a reason why all websites say to use "-ms-filter" for IE8? It accepts the simpler "filter" perfectly well... (Class-CSS.php)
! Apparently, all used HTML5 tags should get their display type redefined, otherwise the layout's broken in IE8. (index.css)
- mgabs? What's that? Where's that? Probably an old leftover... (media.css)
Title: Re: New revs
Post by: Arantor on April 25th, 2011, 05:08 PM
Revision: 735
Author: arantor
Date: 16:08:07, 25 April 2011
Message:
! Sync to BB 2.1.13 (all to Security.php)
 ! Two new ranges that Google contains. (Which will reactivate once IPv6 support is complete.)
 ! The other change to BB in 2.1.13 was in how it exited tests after detecting a search engine; this does not appear to affect our implementation.

! Sync to SMF 10488
 ! r10474, r10476 Cleanup of Subs-Calendar actually using the values passed to functions rather than relying on $_REQUEST for them. (Subs-Calendar.php)
 ! r10478 Don't do anything with the view-query page if debug mode isn't enabled (regardless of being an admin or not) (ViewQuery.php)
 ! r10480 Spacinazi, minor template bug (Subs.php, Admin.template.php)
 ! r10481 When creating a new ban, tick the boxes by default (ManageBans.template.php)
 ! r10482 News link was incorrect in places. (I also took the liberty of putting the right URL in the comment in ManageNews.php, their's is wrong still) (Admin.php, ManageNews.php)
 ! r10483 A few id mentions in the URL at times needed to be removed for mod_security. Note that their patch doesn't bother to strip $_GET['id'] use from Themes.php while I did here. (Themes.php, script.js)
 ! r10485 Updated create_table function signature to 'ignore' by default, in line with what they've done. This will need to be fixed properly at some point though. (Class-DBPackages.php)
 ! r10486 Changes to Subs-Members for PostgreSQL's benefit, but we will be pulled up on using the old code otherwise unless we feel like rewriting this bit. Pointless change from our POV. (Subs-Members.php)
 ! r10487 bbc that's destined for package readme display should be preparsecode'd first. (Packages.php)
 ! r10488 Warning status was shown inappropriately at times (Display.php, PersonalMessage.php)

! Not synced
 ! r10473 Removing __ magic methods and certain types of call_user_func/_array from the DB backtrace; since we're using an actual class rather than a pseudo extended/overloaded class like SleePy was playing with, it should not affect us. In any case, our criteria in the backtrace is different (for good reason)
 ! r10475 MySQL 5.5 compatibility fixes for SMF 1.1.x.
 ! r10477 MySQL 5.5 compatibility fixes for upgrader from 1.0.
 ! r10479 ;id= removed from ManageAttachments.php (was already done)
 ! r10484 Scheduled tasks did not return with an image when an image was requested; we already implemented this, and did it more cleanly.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/scripts/script.js
Title: Re: New revs
Post by: Nao on April 25th, 2011, 05:40 PM
Please make sure the menu css changes work in your favorite browser! (Tested browser list is below.)

rev 736
(8 files, 10kb)

* Removed padding parameter from the main menu, and replaced it with a few CSS tweaks that should allow for it to work the same. Tested successfully in Opera 11.1, Firefox 3.6, Safari 5, Chrome 12, IE6, IE7 and IE8. I think. (Subs.php, index.template.php, index.css, index.ie6.css, index.ie7.css)
- Hover emulation in IE6 was slow. Removed emulation from form elements and the .css class to save time. (.css is never used once JavaScript is active anyway.) (ie6hover.js)
* Hey Nao, you know you can use jQuery in events, right? (Aeva-Foxy.php)
* Spacinazi. (Profile-View.php)
Title: Re: New revs
Post by: Nao on April 26th, 2011, 02:25 AM
rev 737
(5 files, 10kb)

! Fixed user menu not staying open[1]. Also restyled it a little, and added an opening animation. (topic.js, index.css)
! Fixed outdated fixes in IE6 menus. (index.ie6.css)
* Moved some JS from the Display template to topic.js, and a class to where it should be. (Display.template.php, topic.js, sections.css)
 1. Finally!!
Title: Re: New revs
Post by: Nao on April 26th, 2011, 03:23 PM
rev 738
(5 files, 11kb)

* Rewrote user menu to use as little JavaScript as possible in the HTML page. Everything we need is processed in topic.js, and strings are stored in a new object. Also removed current_user_menu global, as it wasn't needed. (Display.php, Display.template.php, topic.js)
* Improved user menu styling. (topic.js, index.css)
* Spacinazi. (Class-Editor.php)

(Pete, feel free to tell me what you think about the rewrite.)
Title: Re: New revs
Post by: Nao on April 26th, 2011, 11:55 PM
rev 739
(4 files, 6kb)

! Fixed undefined variables in various situations. (Buddy.php, Subs-Cache.php)
* Testing for getElementById? Seriously? (db_aeva.php)
* Made user menu code slightly clearer. (topic.js)
Title: Re: New revs
Post by: Nao on April 27th, 2011, 10:24 AM
rev 740 (useless markup commit.)
(5 files, 9kb)

* multiple attribute is valueless. (Admin.template.php, ManageMedia.template.php, Media.template.php)
* checked attribute is valueless. This was fixed long ago, but the latest SMF sync brought in a couple more. (ManageBans.template.php)
* <a name> is deprecated in favor of <a id>. Forgot to fix that when importing AeMe. (Media.template.php)
* Commenazi. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on April 27th, 2011, 11:55 AM
rev 741 (useless rename commit.)
(38 files -3, 37kb)

* Renamed Javascript to JavaScript, for case nazis. I'm not one, but... Oh right, maybe I am. (Class-JSMin.php, Load.php, ManageMembers.php, ManageRegistration.php, Aeva-Embed.php, Spellcheck.php, Subs-Cache.php, Subs.php, Subscriptions-PayPal.php, aeva/readme.txt, TEMPLATES: Display, index, ManageBoards, ManagePaid, ManagePermissions, MessageIndex, Post, Profile, LANGUAGES: Help, ManageMedia, ManageScheduledTasks, ManageSettings, Media, PersonalMessage)
* Renamed use_lightbox to use_zoom, and other lightbox variables to zoom or zoomedia. I think most people are unfamiliar with what a lightbox is -- and zoomedia is more self-descript. (db_aeva.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.english.php, ManageMedia.french.php, Media.english.php, Media.french.php, ManageMedia.template.php, Media.template.php)
- Removed Highslide JavaScript files and outlines folder. The hs folder will wait until I'm finished converting. (aeva/highslide*.js, aeva/hs/outlines)
Posted: April 27th, 2011, 11:32 AM

Note: if you have use_zoom problems when reloading, that's because you have to go to Admin > Media > Settings > Appearance, and enable (or disable) Zoomedia. The variable is supposedly always set in the DB so I won't bother to add empty() tests.
Title: Re: New revs
Post by: Nao on April 27th, 2011, 11:59 AM
rev 742 (useless color conversion commit.)
(48 files -1, 172kb)

* Converted all 32-bit PNGs in the aeva images folder to 32-color PNG-8s, moved originals to other/images. (other/images/aeva32, images/aeva/*.png)
! Undefined index error in media area. (Aeva-Subs-Vital.php)
- white-op85.png was never used in media area. (images/aeva/white-op85.png)
Title: Re: New revs
Post by: Nao on April 27th, 2011, 07:09 PM
rev 743 (useless function removal commit.)
(7 files, 9kb)

- Removed stylesheet parameter from loadTemplate(). Instead, use add_css_file('myfile', true) to load extra CSS. This was only ever used to load admin.css in Moderation and Package areas, so it's not a big loss. As a note, the fatal parameter isn't used either, so it could go just the same. (Admin.php, Load.php, ModerationCenter.php, PackageGet.php, Packages.php)
- Removed wedge_add_css just the same. Wedge is really better off with only the main CSS being cached in its own file. Contextual files need to be in their own files. Next step: merge wedge_cache_css with add_css_file. They're like twins! (Class-Editor.php, Subs-Cache.php)
Title: Re: New revs
Post by: Nao on April 28th, 2011, 03:39 PM
rev 744 (useless not-so-useless commit.)
(24 files, 52kb)

* Hopefully finished converting the Media template to validate HTML5. (Media.template.php, Media language, ManageMedia language)
- Removed debug mode for auto-embedding. It probably had a point back when it wasn't as efficient as it is nowadays... If your embedding is slow, just disable a bunch of sites. (Aeva-Embed.php, ManageMedia language, Media language)
! Renamed aeva_* variables to embed_* in everything related to auto-embedding. Hopefully should work. Also renamed $context['media_disable'] to $context['disable_media_tag']. (db_aeva.php, Aeva-Embed.php, ManageMedia.php, ManageMedia3.php, Subs-Media.php, ManageMedia language)
+ Added a .bbc_pre class to emulate <pre> mode in spans. Did some fixing on other occurrences of <pre>. (index.css, install.sql, Load.php, Subs-BBC.php)
- Removed support for pre_include hook. I don't think it's the 'right' way of doing it. Also removed WEDGE_HOOK_SETTINGS, since there's actually no point in providing support for a deprecated way of adding hooks... I must have been drunk when I did that in rev 252. (Load.php, Subs.php)
+ Added file parameter in add_hook(). You can now specify the required source file directly in that call. Skip the php extension and make sure it's a relative path based on the Sources folder. (Subs.php, Credits.php, ManageSettings.php)
! Fixed URL trimmer. It didn't actually work until now... (install.sql, Subs-BBC.php, ManagePosts.php, Admin language)
* Spacinazi. (db_aeva.php, Subs-Exif.php, captcha-ledicons_anim.php, Aeva-ModCP.php, Aeva-Subs-Vital.php)

@ Note: I renamed the aeva_ variables to fix issues with settings not being saved (they were expecting media_ vars so I changed everything to embed_). Maybe I should have simply told Wedge to expected aeva_ vars, but it's too late to change my mind now... Hopefully if there's any error in my change list, it'll be found soon enough. Or at least faster than it took me to realize trim_url wasn't working... :whistle:
Title: Re: New revs
Post by: Nao on April 28th, 2011, 06:58 PM
rev 745 (so useless I forgot to post it here)
(3 files, 8kb)

! Fixed a bug where after quick editing a post, you couldn't quick edit it again without either reloading the page or quick editing and cancelling another post. (topic.js)
! The hide_prefixes variables is a global, so it shouldn't be declared as local. (topic.js)
- Removed optimize section from topic.js, as I'm starting to dislike the systematic use of this feature on variable names. (topic.js)
* Tags can be in HTML5 format inside XML as long as they're inside CDATA tags... (Xml.template.php)
* The $xml variable in the CSS parser is misleading. It's not a XML document we're building, just some regular, arbitrary, crawlable HTML soup. Renamed it to $tree. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on April 28th, 2011, 10:39 PM
rev 746 (useless IE fixin')
(2 files, 5kb)

! I don't remember why (or when) I did that, but I think it seemed important at the time. Reverted the 'nowrap' white-space rule to 'pre' for .bbc_code and .php_code, as it didn't work in IE7 and IE8. (index.css)
! IE8 screws up short messages with smileys. (index.ie8.css)

@ Note: I really don't remember... >_< The first occurrence of the change is when I changed the default styling from Wuthering to Warm... But apparently, Warm wasn't already stored in the SVN at that point. So it kinda comes out of nowhere... Please test a multi-line code tag in Firefox, Chrome and Safari if you're interested in making sure it keeps working...!
Title: Re: New revs
Post by: Nao on April 29th, 2011, 12:34 AM
rev 747 (useless iPhone commit)
(1 file +1, 6kb)

+ Added a (temp?) iPhone icon and made sure to use the icon by default when posting from an iPhone or iPod Touch. (Post2.php, images/post/iphone.gif)

Note: tested on the demo site...
Title: Re: New revs
Post by: Nao on April 29th, 2011, 04:31 PM
rev 748 (useless commit except for Pete and others here :P)
(2 files +1, 9kb)

+ Added hook for plugins to automatically modify $browser right after it's been built. (Load.php)
+ Added 'tablet' entry to browser detection. It only detects the iPad for now. Hi Pete! (Load.php)
+ Added a tablet entry to the list of wireless devices that get their own icon in posts. (Post2.php, images/post/tablet.gif)
Title: Re: New revs
Post by: Arantor on April 30th, 2011, 01:25 AM
Revision: 749
Author: arantor
Date: 00:25:07, 30 April 2011
Message:
! Sync to SMF 10497
 ! r10489 Setting base_theme_dir caused undefined index errors in manage languages area. (ManageServer.php) [Bug 4634]
 ! r10490 Personal message preview did not display post errors. (PersonalMessages.php) [Bug 4653]
 ! r10491-2 Custom language strings were not loaded when editing theme settings. (Themes.php) [Bug 4658]
 ! r10493 modify_modifications hook should be triggered earlier in the code. (ManageSettings.php) [Bug 4638]
 ! r10494-5 menu_items hook was triggered too late in the code. (Subs.php) [Bug 4637,4670]
 ! r10496 (adapted) Undefined index errors when there were not any recent posts. (BoardIndexInfoCenter.template.php) [Bug 4650]
 ! r10497 CAPTCHA settings were linked to the incorrect area in admin search results. (Admin.php) [Bug 4707]

I'm not entirely happy with the changes in r10494/5, as per my comments originally in bug 4637; I do not entirely agree that the menu items hooked items should be cached like this unless you guarantee to flush the cache at any point when you will removing add-ons, or you have add-ons that do funky dynamic buttons. (Any add-ons should really be paying attention. It isn't that hard, either. But I can see the flip side of why it's been done, too, that it does simplify and make consistent additive item behaviour. So I've committed it, after some internal deliberation. It will be interesting to see how this stands up for add-ons that actually do this; I suspect no-one's actually been using the hooks for this other than Fel (for PortaMX), Live (for EP) and myself (SimpleDesk) anyway. Won't get into the debate here over whether a system author should listen to the needs of those who modify the system or not.)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Title: Re: New revs
Post by: Arantor on May 1st, 2011, 02:23 AM
Not a very exciting r750, but still...


Revision: 750
Author: arantor
Date: 01:23:17, 01 May 2011
Message:
! Centralised the setlocale calls instead of making them on every call to formatting some time, as well as centralising the locale definition in the language files (Load.php, Subs.php, Subs-Media.php, index.french.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Nao on May 1st, 2011, 08:50 AM
rev 751 (useless "it's not 750, dude!" commit)
(7 files +3, 29kb)

+ Added support for new CSS keywords (Class-CSS.php)
  + Cancel inheritance ('unextend' keyword, useful for inherited stylings)
  + Delete a property entirely ('@remove' command)
+ Added support for all possible unit types in math functions. Also removed the mismatched unit protection code, because I'm not sure whether it's best to keep it to not. I'd have to rewrite it anyway. (Class-CSS.php)
* Optimized grad700.png for size, moved original to the image backup folder, as well as the original iPhone and Tablet icons. (other/images/*, grad700.png)
* Updated credits. Project managers are Wedgeward (still us!), added tentative Consultant and Support teams to Wedge credits. Made page more readable. (Credits.php, sections.css)
+ Added support for browser-agnostic linear-gradient call. (Although older Safari versions and IE6/7/8/9 will choke on it.) Also simplified call to the CSS property fixer. (Subs-Cache.php)
* Replaced 'create_topic' hook with the more interesting 'create_post_before' and 'create_post_after'. (Subs-Post.php)
+ Added 'modify_post_before' and 'modify_post_after' hooks. Guess what they do. (Subs-Post.php)
+ Added dummy example for a CSS section in styling file. (Warm/settings.xml)
Title: Re: New revs
Post by: Nao on May 1st, 2011, 05:51 PM
rev 752
(4 files +1, 41kb)

+ Added support for CSS math functions max, min and rand. I should have done min and max from day one. (Class-CSS.php)
* Committing CSS preparser with 'reset' keyword in the WIP folder. Although I'm sure it'll never be used. (other/wip/Class-CSS (reset keyword).php)
! Non-main CSS files needed an extra dash in the URL. (Subs-Cache.php)
! Fixed JumpTo and optimized for speed and size. (script.js)
! Fixed Wuthering header. (Wuthering/index.css)
Title: Re: New revs
Post by: Nao on May 2nd, 2011, 11:58 AM
rev 753
(4 files, 7kb)

! In the case where multiple selectors were extended at the same time, Wedge didn't always apply inheritance to all of them. (Class-CSS.php)
! Fixed stray dash in CSS cache files when using the default styling (oops.) (Subs-Cache.php)
! Hopefully fixed post overflow issues by, ahem... Setting it to visible. Eh, what? (index.css, index.ie8.css)
+ Added $big_font and $post_font CSS variables. Trying to be more... Semantic, see? Something like that. (index.css)
Title: Re: New revs
Post by: Nao on May 2nd, 2011, 03:27 PM
rev 754
(7 files, 10kb)

! Fixed CSS/JS caching on Mobile Safari. (It appears the extension issue only occurs in the desktop version.) (Subs-Cache.php)
! Fixed Mobile Safari crash (why only this?) caused by incorrectly moved variable declaration. (topic.js)
! Webkit keyword wasn't removed from CSS URLs in the main file caching function. (Subs-Cache.php)
! Added missing device icons to stable_icons(). (Subs.php)
* IE always defined createTextRange, doesn't it? (Class-Editor.php)
* Added a meta tag for iPhone devices to increase image and text size. It doesn't look very good, but it's way more usable. (index.iphone.css, index.template.php)
* Overflow problems in polls. (sections.css)

@ Not too happy with the new iPhone look, but honestly... It can serve as a starting point, and usability is more important on a handheld device than looks.
Title: Re: New revs
Post by: Nao on May 2nd, 2011, 07:51 PM
rev 755
(1 file, 7kb)

+ Added ability to inherit CSS elements from multiple parents. Specify a comma-separated list of items in base: for this, or if you prefer the extends syntax like me, use double quotes around the list (.class extends ".class2, .class3"), otherwise Wedge will consider anything after the first comma to be outside the extend declaration (".class extends .class2", .class3). Not used in Wedge yet, but this can be very interesting in the long run for themers and us. (Class-CSS.php)
! If extending with the use of an ampersand alias, Wedge will now make sure there's only one parent. If there are more, it will only extend based on the first listed parent, to avoid any complications. (Class-CSS.php)

@ That last line -- I could have fixed it to apply to all elements in the list, but honestly at this point it's probably a logic error in the themer's file, and I don't want to waste CPU cycles applying verbatim a request that comes from someone who didn't get what "&" does exactly...
Title: Re: New revs
Post by: Arantor on May 3rd, 2011, 01:12 PM
Revision: 756
Author: arantor
Date: 12:12:01, 03 May 2011
Message:
! Sync to SMF 10503
 ! r10498 Fix the header bar in reports area to be category rather than title. (Reports.template.php) (SMF rev also changed Admin template, this was already done in Wedge)
 ! r10499 Fix to stop linktree anchors scrunching in IE6 and IE7. (index.css) [Bug 4651]

! Not including
 ! r10500 Making category titles not into links if they're not collapsible - in our case, the category header wasn't even a link to start with.
 ! r10501 CSS change for layout related bug on collapsed categories - bug doesn't affect us as far as I can tell or reproduce (see bug 4639)
 ! r10502 Renaming 'Packages' to 'Package Manager' just for consistency in the menu (this was a reported bug!)... well, they're not called packages here...
 ! r10503 Restructuring the size of dl items in the admin panel just because it throws scrollbars when using the existing sidebar on sub 1024 wide screens... no thanks. (The dl becomes 25% wide and the dt 71% wide...)

! Other
 ! Fix category links to point to #category_n instead of #cn because the category title anchor no longer exists. (Load.php, Recent.php, Search2.php, Unread.php, Unreadreplies.php, ModerationCenter.template.php) (Replaces SMF r10500 only done so much nicer)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/styles/index.css



You can guess who made these SMF revs, can't you?
Title: Re: New revs
Post by: Nao on May 3rd, 2011, 03:36 PM
I'd say Unknown committed these. It's so Unknown! :niark:

Soooo... One commit per minor bug fix, eh? Even with that trick, they still have barely done 430 commits since we started work on Wedge... And we certainly don't settle on a single change per commit :whistle:

rev 757
(12 files, 18kb)

* Reworked poll layout. Moved it below the topic title (to keep a sense of unity when switching between topics with the prev/next links), moved moderation buttons to the top, turned the box into a we:block, etc. (Display.template.php)
! Skip sidebar/top templating in Wireless. It's already done in a few areas to save CPU time, but should be systematic. (Load.php)
! Fixed wrong text string index. (Subs-Media.php)
! If a block specifies an empty parameter, it should be ignored entirely. (Subs.php)
+ Added an 'id' parameter to we:blocks. (index.template.php)
! Because of the sidebar, poll question inputs could overflow easily. (Poll.template.php)
* Reworked profile warning level system's layout. (Profile.template.php)
- ajax_indicator() is always defined. Don't bother testing for it. (topic.js)
! document.body isn't set up on all browsers, or so I've heard. (topic.js)
! User menus were closing unexpectedly in some situations. (topic.js, index.css, sections.css)
* Spacinazi. (Display.php, ManageSettings.php)
Title: Re: New revs
Post by: Nao on May 4th, 2011, 12:21 PM
rev 758
(19 files, 22kb)

+ Added 'e' parameter to all delayed events. You can now directly access the jQuery-normalized event object for any inline event using the 'e' variable. (Subs.php, example in Profile.template.php)
* Rewrote timing strings in footer to use sprintf, say '1 query' instead of '1 queries', and use a str_replace instead of a preg_replace. (Subs.php, index.template.php, index language)
+ Added language strings for Dynamic Replacements. (Subs.php, index language)
* Rewrote timing functions to use microtime(true) instead of the tricky microtime() for $time_start. You can now easily determine the amount of seconds spent in the page execution with "microtime(true) - $time_start". Also, SMF used time() in a few places to track time spent... Ah ah! No, it's not a joke actually. (index.php, SSI.php, ssi_examples.php, Class-DB.php, ManageAttachments.php, ManageMail.php, ManageMaintenance.php, Aeva-Gallery2.php, ManageMedia.php, Packages.php, RepairBoards.php, ScheduledTasks.php, Subs.php)
! Fixed user menu bug in FF4 and removed useless e.toElement calls, as e.relatedTarget is standardized in jQuery. (script.js, topic.js)
* Rewrote Issue Warning JS to actually work as the SMF code *wanted* it to work (drag'n'slide to change percentage), because yes, it didn't work. (Profile.template.php)
Title: Re: New revs
Post by: Nao on May 4th, 2011, 12:30 PM
rev 759
(11 files, 11kb)

* Fixed remaining microtime() calls. (tools/*, Feed.php, ManageScheduledTasks.php, Subs-BBC.php, Subs-Cache.php)
! $context['show_page_load'] was used in the index template - chose to restore it instead of removing it. (Subs.php, index.template.php)
Title: Re: New revs
Post by: Nao on May 5th, 2011, 08:50 PM
rev 760
(11 files, 12kb)

* Changed .attr() calls to be compatible with jQuery 1.6, as we'll probably move to it eventually. (ManageBoards.php, ManageNews.php, Subscriptions-PayPal.php, ManageMaintenance.template.php, ManagePermissions.template.php, ManageSmileys.template.php, Profile.template.php, Register.template.php, up.js)
! Oops, .titlebg was inheriting from the wrong selector. (index.css)
* Details. (post.js, script.js)

NB: Might want to consider optimizing .is() calls in a loop...?
Title: Re: New revs
Post by: Nao on May 6th, 2011, 12:08 AM
rev 761
(2 files, 7kb)

! It's show_load_time, not show_page_load... (Subs.php)
* Minor optimizations on the uploader JS. (up.js)
Title: Re: New revs
Post by: Nao on May 6th, 2011, 07:39 PM
rev 762
(1 file +1, 95kb)

* Now using jQuery 1.6 instead of 1.4.4. Keeping the old file in the SVN for now, we never know. (Load.php, jquery-1.6.js)

(What? I'll show the SMF guys I can do single-file commits, too! :niark:)
Title: Re: New revs
Post by: Nao on May 7th, 2011, 07:31 PM
rev 763
(8 files, 10kb)

! In some cases, the template footer wouldn't be called, and an error would be generated. (Subs.php)
! Why ask Wedge to do a simple addition on tag processing, when developers can do it once and for all? (Subs-BBC.php)
! Inline post edit could generate errors, and trigger yet another error when trying to announce it. (topic.js)
+ Added 'headline' class to the more tag, for themers to style post introductions. (Subs-BBC.php, index.css)
* Upgraded other jQuery 1.4.4 occurrences. (install.php, repair_settings.php, upgrade.php)
* ajax_in_progress box was too big. (index.css)
- Outdated documentation. (admin.js)
Title: Re: New revs
Post by: Nao on May 9th, 2011, 09:56 PM
rev 764
(4 files +1, 97kb)

* Updated credits with missing names. (Credits.php)
! Replaced main jQuery 1.6 calls with version 1.5.2 instead. Waiting for 1.6.1 with the fix to $.offset() (Load.php, jquery-1.5.2.js)
+ Added minor but nice animation to the menu system. It's just two lines... Can be reverted easily. (script.js)
* Post font spacing was one pixel too big for my taste. (index.css)
* Fixed menu border color and made them slightly less transparent. We got it, it's transparent, it's cool. It should be readable, too. (index.css)
Title: Re: New revs
Post by: Nao on May 10th, 2011, 12:38 PM
rev 765
(7 files, 27kb)

* Massive rewrite for Zoomedia. (zoomedia.js, zoom.css)
  * Starting position for zoom animation now matches exactly the origin thumbnail.
  * Slightly reduced border size, as it was a bit too much for my taste.
  * Descriptions no longer show up as overlays on the image. They also enlarge the zoomedia box if it's too narrow to hold the description.
  + Double-click the original thumbnail, or the opened preview, to enlarge it into the fullsize version. Includes annoying fix for IE 6/7/8.
  ! IE6 always showed the Loading label, even if the image was cached.
  ! Outside closing clicks were tested even with no zoomedia box opened. Ooops.
+ Added menu animation for low-level menu entries as well. (script.js)
- Removed useless 'added' parameter from sitelist. (ManageMedia3.php, Subs-Aeva-Sites.php)
- Removed hss() as full zoom handler. This is now done entirely by Zoomedia. (Aeva-Subs-Vital.php, Subs-Media.php)

Zoomedia tested under IE6, IE7, IE8 and Opera 11.50... Haven't tested in Chrome for a few days but it should work.
Title: Re: New revs
Post by: Nao on May 11th, 2011, 11:59 AM
rev 766
(13 files, 12kb)

! base64-encoding bypass technique failed when base64 encoding wasn't supported. (Class-CSS.php, Subs-Cache.php)
! The More tag could cause errors when parsed outside of a topic. (Subs-BBC.php)
! Some headers still had an icon next to the header text without any whitespace. (TEMPLATES: Login, Memberlist, Notify, PersonalMessage, Recent, Themes)
* Don't need strong tags in a header... Chances are it's already in bold. (Aeva-Foxy.php, ManagePermissions.template.php)
* $()[0].checked is faster than $().is(':checked'), so use that in loops. (ManagePermissions.template.php)
* Minor typos and such. (BoardIndex.php, Packages.template.php)
Title: Re: New revs
Post by: Nao on May 12th, 2011, 01:06 AM
rev 767
(16 files +1, 24kb)

+ Officially added outline types 'drop-shadow', 'white' and 'black', replacing the Highslide equivalents and adding black to the lot. (Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php, zoomedia.js)
* Replaced table-based layout with inline-blocks for media item lists. This allows for simpler handling of list layout, especially with different screen sizes. Opera, oddly, needed a trick to avoid generating scrollbars on hover. Took me hours to figure one out. (Subs-Media.php, media.css, media.ie6.css, media.ie7.css, media.opera.css)
- Removed num_items_per_line options, as they're a moot point with the new item lists. (db_aeva.php, ManageMedia.php, Subs-Media.php, ManageMedia.language.php, Media.template.php)
- AFAIK, media item hover boxes don't need to bother with a 'faux' trick... (Subs-Media.php, media.css)
- And jQuery can do without a 'px' mention when animating or setting CSS. (zoomedia.js)

@ Known issue: the zoomedia close button doesn't show consistently across all browsers, especially when resizing to full size. (zoomedia.js)
Title: Re: New revs
Post by: Nao on May 12th, 2011, 06:52 PM
rev 768
(7 files, 12kb)

! Guests could generate an internal error when updating the topic view count. (Display.php)
+ Added $new_topic to the list of params that can be read and rewritten in createPost. (Subs-Post.php)
! Unseen media area was using the wrong language strings and had misplaced buttons. (Media.template.php)
! Some of the media permissions still had the 'aeva_' name in them. Hopefully I've updated everything that needed it. (ManageMedia.php, ManageMedia.language.php, ManageMedia.template.php)

(Can't believe some of these bugs I never noticed until now... :P)
Posted: May 12th, 2011, 06:50 PM

(And yes, that's probably the reason why single-upload didn't work on the demo site...)
Title: Re: New revs
Post by: Nao on May 13th, 2011, 10:03 AM
rev 769
(8 files +1-1, 23kb)

* Renamed media-admin.js to mediadmin.js, to avoid possible confusion in filenames. There was no harm done, but as a general rule of thumb, we should avoid hyphens in JS/CSS filenames when one of the filename's elements is a common one, like... media, or admin. (Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php)
! Fixed a language string possibly not being loaded in the album manager. (Aeva-Gallery2.php)
! One of the PNG8 files didn't correctly set the alpha bit. (arrow_inout.png)
! admin_toggle() was broken due to the use of .has() instead of .is() (mediadmin.js)
! admin_toggle() only takes one parameter. (ManageMedia.template.php, Media.template.php, mediadmin.js)
! Media pruning area was broken. (ManageMedia2.php)
* Moved admin_prune_toggle() to the actual media pruning admin page -- it's only used there, and it's short. (ManageMedia.template.php)
* admin_toggle() will now open its flower only after its related icon has finished loading. Maybe better, maybe worse. (mediadmin.js)
* Alignazi. (Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on May 13th, 2011, 08:15 PM
rev 770
(10 files -1, 11kb)

* Parenazi. (Security.php)
* Bad whitespace! (Errors.template.php)
* Apparently, .attr('value') is frowned upon. (script.js, suggest.js, topic.js)
* Removed that silly white-space 'fix' devised by the SMF devs for linktrees, and replaced it with what I call a fix. (index.css, index.ie6.css, index.ie7.css)
! admin_toggle() shouldn't use expand/collapse icons, they're no longer provided. (mediadmin.js)
- Removing unneeded placeholder code in linktrees. (index.template.php)
- Removing jQuery 1.6, it sucked. (jquery-1.6.js)
Title: Re: New revs
Post by: Nao on May 13th, 2011, 08:28 PM
rev 771
(9 files, 18kb)

! Reverted allowedTo('media') to aeva_allowedTo(), because it's not the same. Really. And it fucked up permission profiles. Can I say 'fuck' in the changelog? No? Oops. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Subs-Media.php, Media templates)
! More expand/collapse fixes. (ManageMedia.template.php, Media.template.php)
* Cleaned up some variables, to be set in the Sources folder now, rather than in the Media template. (Aeva-Gallery.php, Media.template.php)
* Cleaned up table names. (ManageMedia.language.php)
Title: Re: New revs
Post by: Nao on May 15th, 2011, 04:06 PM
rev 772
(9 files, 13kb)

+ If Today/Yesterday date transformations are enabled, check for the year and remove it if it's the current one. (Subs.php)
! If pretty URLs were enabled, the jump box would redirect to the homepage because 'board' wasn't treated in the URL. (QueryString.php)
* Removed a few 'px' suffixes whenever jQuery could handle them by itself. (editor.js, script.js, suggest.js,
! Style fixes. (index.css, media.css)
* Indenazi. (Media.template.php)

@ The date thing was an idea I had and executed in a few minutes time only. I'm not SURE it's for the best, but I like it for now. The reason why it's in Today/Yesterday is to avoid an extra getdate() call, as well as avoid transforming whenever we want the full date (e.g. "Hello user, today is...")
Title: Re: New revs
Post by: Nao on May 17th, 2011, 10:18 AM
rev 773
(7 files, 12kb)

! Zoom outline options weren't passed to album pages. (Needs a fix in zoomedia.js as well, but I'm in the middle of rewriting it.) (Subs-Media.php)
* A few language strings were using longform XHTML tags. (ManageMedia.language.php, Media.language.php)
! French version recommended 6-char passwords or more, even when security settings force it to be at least 8 chars. (Profile.french.php)
* Spacinazi. (ManageMedia.template.php)
Title: Re: New revs
Post by: Nao on May 18th, 2011, 04:02 PM
rev 774
(13 files, 17kb)

! SMF bug: crash when providing several negative search terms (i.e. excluded terms) in a search. This was due to the inner_join array containing multiple occurrences of the same JOIN. (Search2.php)
* Renamed <strong class="highlight> to the more semantic and shorter <mark>, and renamed the highlight2 class to highlight, since it's no longer in use. (ManageServer.php, PersonalMessage.php, Search2.php, Profile.template.php, spellcheck.js, index.css, sections.css)
! Since we don't exactly know what HTML flavor SSI.php is being run with, make sure to use alt params in img tags. (SSI.php)
* Moved title from link to image in selectable language flags. And yes, I know, img title support in screen readers is pretty poor. Maybe we should add an alt for these. Uh. (index.template.php)
* Added <meta name="generator" content="Wedge">, both as a signature, and to stop HTML validation from pestering us with yet another change in the mandatory use of alt params in img tags. (index.template.php)
* Hopefully finished converting the admin area's media template to HTML5. (ManageMedia.template.php)
* Signatures shouldn't have the same color as post bodies. Chose a slightly less contrasted version. (sections.css)
* Shaving a few bytes off script.js. You know me... I can't stop myself. (script.js)
+ Added very preliminary support for paragraph headers inside blocks. (index.css)
* Too much vertical space wasted between thumbnails in album pages. (media.css)

@ Note: this changelog needs being discussed, I *think*...
Title: Re: New revs
Post by: Nao on May 19th, 2011, 11:00 AM
Okay, well, apparently rev 774 didn't need discussin'? :P
This new one is short but still required hours of testing. >_<

rev 775
(2 files, 7kb)

+ User menus will now extend to the width of the user name, even if it's very long. Well, probably not in IE6 but who cares. (topic.js)
+ Added some extra code to ensure the user name is still visible uncropped when hovering over the menu rather than the user name itself. (topic.js, sections.css)
Title: Re: New revs
Post by: Nao on May 19th, 2011, 03:00 PM
rev 776
(2 files, 6kb)

! The 'code' tag security check at registration time should be case-insensitive. I think. (Register.php)
* Modified user menu again to close it even when the mouse isn't moving. We just need to store all mouse events during the animation... (topic.js)
Title: Re: New revs
Post by: Nao on May 21st, 2011, 03:23 PM
rev 777
(8 files, 23kb)

* Rewrote most of Zoomedia to make it more solid across all browsers, especially when it comes to the double click behavior, and making sure any CSS changes to zoom box padding won't affect the JS code. (zoomedia.js, media.css, media.opera.css, zoom.css)
* CSS details. (other/wip/text-overflow.js, post.js, script.js)
* Saving a few bytes at compression time. (topic.js)

@ Left to fix: zoom box descriptions in small viewports. I don't really know how to fix... I was thinking of 'simply' resizing the box to make it fit *and* keep the description height the same (otherwise it will overflow), but come to think of it, it'd probably be smarter to actually hide the description because we could use that size, and simply show a "Details" link along with some indication that it has a description.

What do you think?
Title: Re: New revs
Post by: Arantor on May 21st, 2011, 07:17 PM
Revision: 778
Author: arantor
Date: 18:16:47, 21 May 2011
Message:
! Sync to SMF
 ! r10504 Validation error with collapsed boards. (And I got the indentation right.) (BoardIndex.template.php)
 ! r10505 Making a board child of itself crashed the forum. (Subs-Boards.php, Errors.english.php) [Bug 4710]
 ! r10506 Theme option changes was not loaded after profile changes in some cases. (This fix is slightly more thorough than the one posted before, it actually checks the input is an array before trying to use it as such, but otherwise it's the same fix.) (Profile-Modify.php) [Bug 4675]
 ! r10510 Member language selection was not reset upon a language deletion. (ManageServer.php) [Bug 4641] (And I fixed the comments, which they didn't.)
 * r10511 JavaScript quick topic modify did not work when quick moderation mode was 'icons'. (MessageIndex.template.php) [Bug 4715]
 ! r10512 It was possible to create permission profiles without names. (ManagePermissions.php) [Bug 4709]
 ! r10513 Additional group changes were not tracked properly. (Profile-Modify.php) [Bug 4718]
 ! r10514 Ignore boards options were ignored in MessageIndex. (Subs-BoardIndex.php) [Bug 4719]
 ! r10515-6 Remove Inactive Members maintenance removed members it should not. (ManageMaintenance.php) [Bug 4716]
 ! r10517-8, 10520 Reserved member name check failed with HTML entities. (Subs-Members.php) [Bug 4717]
 ! r10522 Minor break in PM replies fixed. (PersonalMessage.template.php) [Bug 4713] (Couldn't seem to replicate this in SMF, let alone Wedge, so have included it for now anyway)
 ! r10523 Fixed incorrect class on checkbox. Changed default removal selection to safest option.(ManageMaintenance.template.php) (The class was already gone, so that wasn't an issue, but I agreed with the change about the topic maintenance, instead of the default of 'any' being default under the purge-old area, the default is now 'moved notices')
 ! r10527 Installing, upgrading and uninstalling packages were not logged in admin log. (Packages.php, Modlog.english.php) [Bug 4469] (I actually made this one last spring as a mod, and handed it to the team on a plate to implement. They finally did!)
 * r10528 It was not possible to remove avatar when selecting avatar from gallery was disabled. (Profile-Modify.php, Profile template) [Bug 4636]
 ! r10529 Automated conversion of URLs to hyperlinks failed with URLs containing exclamation mark. (Subs-BBC.php) [Bug 4624]
 * r10530 Topic moderation using checkboxes did not function correctly for non-moderators. (topic.js) [Bug 4706] (This got jQuery-ified in the process. Hopefully this isn't too ugly now.)
 ! r10532 Profile updates did not load all previously saved data. (Profile.php, Profile-Modify.php) [Bug 4635]
 ! r10533 Login session data was cleared when it shouldn't have. [Bug 4644] And while we're at it, login by $_GET is not needed. (Login2.php, Subs-Login.php)
 ! r10537 Incorrect custom menu URL for unapproved posts moderation area. (ModerationCenter.php) [Bug 4728]
 ! r10538-9 Languages which doesn't support 12 hour time format had their 'am/pm's stripped. (Subs.php, index.english.php) [Bug 4720] (I've implemented this as is, but we may want to revert this in the time to come; there is likely a better way of doing it.)
 ! r10540 Incorrect error message when attempting to remove a non-existing post. (RemoveTopic.php) [Bug 4705]
 * Tabs and line endings within code tags were not parsed correctly for some browsers. (Packages.php, Packages.template.php) [Bug 4578] (I already attacked most of this previously, as it happens, only the package manager stuff wasn't done, and done differently - and likely better.)

! Not sync'd
 ! r10507 Bringing back the good, old welcome guest note along with activation link. [Bug 4703] (Apart from actually not doing what the changelog describes (it actually turns the 'Please login or register' into 'Welcome, Guest, please login or register')... that particular change is already better reflected in the sidebar.
 ! r10508 Upgrader fixes for MySQL 5.5 for upgrading from 1.0 and 1.1 [Bug 4698]
 ! r10509 Supposedly makes sure the MIME type gets fixed when upgrading from before 2.0, but I don't see how checking that smfVersion is identical to '2.0 a' is a viable trigger here... [Bug 4700]
 ! r10519 Replicating the change from 10517-8 into 1.1 branch
 ! r10521 More MySQL 5.5 fixes, this time for 1.0
 ! r10524 Fixed Webkit/Presto bug with sidebar menus enabled. Deleted superfluous code from webkit.css and rtl.css (index.css, rtl.css, webkit.css) (The main change in index.css isn't relevant to us anyway, the RTL changes ditto... and the Webkit changes, well, I think they should probably have left the clear:right in, the others don't apply...)
 ! r10526 Categories which could not be collapsed were still given collapse links. (Subs-BoardIndex.php) [Bug 4639] (We didn't give them collapse links directly like SMF do anyway, this was never an issue for us.)
 ! r10531 Sidebar fixes - Fixing class 'clear clear' from r10525, making #avatar_upload be overflow:auto (though I have no idea what's prompted that) and giving #creator dd the same overflow, again no idea why it's necessary... so I didn't include them. Oh, and resizing an input type=file...
 ! r10534-6 Converters stuff
 ! r10542 Like 10509, this adds a test for version being '2.0 a' into the theme upgrader code.

! Special stuff
 ! r10525 Lots of weird little layout 'fixes' "mostly for IE6". The individual changes are not documented in the changelog, nor anywhere else I can find.
  - Subs-BoardIndex.php, breaking the category links up so instead of a single a tag being the anchor for categories and the link for collapsing it, they separated it. We were already separate anyway after the last time they messed with this. (NOT ADDED)
  - Admin template, instances of hr tags all getting .clear added to them, not entirely sure why. Including one instance of hr that needed it so badly, it became class="hrcolor clear clear". Not entirely sure why they did this. (NOT ADDED)
  - admin.css, removing a resizing of dt and dd relative to each other inside the admin area (for narrower screens with sidebar). Code doesn't apply to us. (NOT ADDED)
  - ie6.css, they adjusted a height for the 'admin panel' from 655px to 100%, but the code doesn't apply to us. (NOT ADDED)
  - index.css: removing the weird -99em left margin for no-collapse titles (which we already noted was ridiculous at the time Ant added it, also removed from rtl.css), made the dd bigger in dl.settings (now occupies 56% instead of 48%) and also make it overflow auto to cope with smaller resolutions, they also adjusted #creator dd to float right, which is the right panel in the profile area... for no reason I can see. (ADDED, except the #creator change)
  - BoardIndex template, rejigging how the category title was output with the surrounding markup. Incidentally, it's now virtually what we already had, with the actual name being output last, relative to the collapse and unread links. (NOT ADDED)
  - ManageBans template, making one text field bigger than the DB field that holds it, plus resizing the different text boxes to line up; we're going to be ripping this out anyway. (NOT ADDED)
  - ManageBoards template, adding style="float:left; width:100%;" to the ul that forms the category contents of the main manage-boards screen, really no idea why. (NOT ADDED)
  - ManageMembers template, making some catbgs rounded when they weren't before. (ADDED)
  - ManagePermissions template, making one area handle oversize content better. (ADDED)
  - ManageSearch template, moving the save-search-weights button into the curved area and to the right, to be more consistent with everything else, and moving the save-search-method button to the right, again for consistency. (ADDED)
  - Packages template, making the textboxes all the same size. (ADDED)
  - Profile template, the instances of hr tags all got .clear added to them, like Admin template. (NOT ADDED)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/topic.js
Modified : /trunk/Themes/default/styles/index.css
Title: Re: New revs
Post by: Nao on May 22nd, 2011, 12:18 AM
rev 779
(17 files, 26kb)

! rev 778 didn't use westr::htmlspecialchars where needed. (Packages.php, Subs-Members.php)
! A $_POST was being tested after checking whether the corresponding $_REQUEST was set. (Subs-Login.php)
* French translation. (Errors.french.php, index.french.php, Modlog.french.php, Profile.french.php)
* I thought I'd optimized all of the labels... Apparently not. I'm just doing this one okay? (Profile.template.php)
! $.length() doesn't work. It's $.length, not a function. Also optimized code for compressed size. (topic.js)
! Button strips don't have child divs, they use unordered lists. Also, the default class for them is floatleft, not floatbottom. (topic.js)
! User box user names were being shown on top of zoom boxes. (sections.css, zoom.css)
! Removed useless right padding from stat months/days. Way better in small resolutions. (sections.css)
! It's add-on, not package. I think. (Modlog.english.php)
* Spacinazi. (ManageServer.php, Aeva-Gallery.php, Profile-Modify.php, index.language.php)
* Ugly CSS. (ManagePermissions.template.php)

Please read the changelog above and review the code fixes!
Title: Re: New revs
Post by: Nao on May 22nd, 2011, 08:17 AM
rev 780
(4 files, 10kb)

* Zoomedia now properly resizes a zoom box to the viewport height when needed, and gets rid of the description to save space. (zoomedia.js)

* The aelink class is no longer a class for links but for the link container in item descriptions. Cleaner this way. (Subs-Media.php, media.css)

* Avatar selection code was too big when it could be done in 5 lines. Uh. (Profile.template.php)

* Server-based avatar selection box was too large. Now it should be better integrated. (Profile.template.php)
Title: Re: New revs
Post by: Nao on May 22nd, 2011, 11:59 PM
rev 781
(1 file, 5kb)

! Safari and Chrome didn't reset the sidebar when resizing to a small viewport and then back to a normal viewport. Fixed by setting the 'hidden' sidebar state to a block instead of a table. Sounds easy but it took hours to debug. Hate it when it happens. (index.css)

(Just wanted to commit this ASAP because it really was a PITA. I'm surprised Pete didn't notice anything -- you're using Chrome right?)
Title: Re: New revs
Post by: Nao on May 24th, 2011, 12:34 AM
rev 782
(4 files, 9kb)

! Fixed various issues in several browsers when resizing a zoom box to fit the viewport height. Had to add a IE6/7 hack to make it barely work, though. Will try fixing it later. (zoomedia.js)

* Applied the Opera 'hack' to all browsers, because it actually works best when resizing the screen. (zoomedia.js, zoom.css, zoom.ie6.css, zoom.ie7.css)

* Optimized a few bytes by turning 'auto' into a variable. (zoomedia.js)

! Fixed zoom box padding when showing HTML. (zoom.css)

! Fixed potential JS error when cancelling a zoom before the image was actually loaded at all. (zoomedia.js)

PS: I committed my fixed zoomedia.js because it currently works in IE6/7/8, Chrome and Opera (didn't test other browsers.) But it could be better really... I'm super-pissed.
Title: Re: New revs
Post by: Nao on May 25th, 2011, 03:23 PM
rev 783
(4 files, 7kb)

* Rewrote the zoom box resizer to rely more on CSS and less on browser hacks... Only to fail miserably, because IE7 wouldn't cooperate. Oddly, IE6 fares much better here. So, I'm now using hacks only for IE7, including a very ugly one. Hardcoding a width value? Somebody do something! (zoomedia.js, zoom.css, zoom.ie6.css, zoom.ie7.css)

! Forgot a semi-colon to close a function variable. (zoom.css)

PS: if I have to spend ONE extra minute on this fucking resizer code, I'll kill a random cat!! So IE isn't pixel perfect on description paddings here, and I don't fucking care. It's the first time I'm getting it to work on ALL browsers I tested on...
Title: Re: New revs
Post by: Nao on May 25th, 2011, 03:24 PM
I'm committing in three small thematic batches -- if it's any more readable...

rev 784
(2 files, 7kb)

! Made sure that // comments in CSS files are stripped if they're at the beginning of a line, regardless what they're followed by. (Subs-Cache.php)

* Prevented jQuery from being re-minified. Saves processing time and gives better results. (Subs-Cache.php, jquery-1.5.2.js)
Title: Re: New revs
Post by: Nao on May 25th, 2011, 03:27 PM
rev 785
(3 files, 5kb)

+ Added two tentative new hooks in the topic display loop: display_prepare_post and display_post_done. (Display.php)

! Some of the user menu code was prepared even if no menu was to be displayed. (Display.php)

! Some browser still had issues with the sidebar transmorphing code. (index.css)

- I don't see any reasons to add a meta description that's exactly the same as the page title. Waste of bandwidth. (index.template.php)
Title: Re: New revs
Post by: Nao on May 26th, 2011, 11:50 AM
rev 786
(7 files, 11kb)

+ Added support for 'glass' outline type in Zoomedia. It's also enabled by default, at least for now. (Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php, zoom.css)

! Zoomedia didn't comply with the expand duration variable. Also made sure to change its default from 250 to 800ms. Let's enjoy these animations, shan't we? (Aeva-Gallery2.php, Aeva-Subs-Vital.php, zoomedia.js)

! Found the reason for the IE7 bug... 'overflow: hidden' triggers hasLayout and messes up with its width. Setting it to hidden after calculating the width does the trick. (zoomedia.js, zoom.css)

! Zoom out animation wasn't correctly resetting the overflow value either. (zoomedia.js)

- Removed a debug line. (zoomedia.js)

- Removed closeOnClick option (will never be used, seriously.) (zoomedia.js)

NB: the new trick is tested in IE6, IE7, IE8 and Firefox 5. Haven't tried in other browsers... Please do it for me? :angel:

NB²: do you like it if I separate the changelog lines with extra line breaks like on this page...? Is it more readable or just not worth it?
Title: Re: New revs
Post by: Nao on May 26th, 2011, 11:33 PM
rev 787
(1 file, 4kb) (actually just an if() test added...)

! Well, in the end, I STILL get to re-introduce an IE7 hack... Glitch otherwise happens when opening an item without resizing it, and showing a multi-line description. Stupid hasLayout! (zoomedia.js)
Posted: May 26th, 2011, 11:26 PM

rev 788
(1 file, 5kb) (just reverting the previous addition, and moving a line around...)

! I really must insist on removing these hacks, sir... Just hoping I'm not breaking Firefox 3.5.7 beta 2 for Ubuntu 1.03 alpha 7 by doing this. I've seen stranger things you know. (zoomedia.js)
Title: Re: New revs
Post by: Nao on May 27th, 2011, 10:17 PM
rev 789
(61 files, 44kb)

+ Added $context['session_query'] = $context['session_var'] . '=' . $context['session_id'], which should save some valuable CPU time concatenating these strings into URLs... There were over 300 occurrences to modify. (Load.php and all other files in this commit. Should allow for an easy mass-revert in case problems arise.)

(As per our discussion a few weeks ago!)
Title: Re: New revs
Post by: Nao on May 27th, 2011, 11:12 PM
rev 790
(1 file, 6kb)

! Don't animate menus if the mouse cursor exits the menu zone and immediately comes back to it through the same menu entry. (script.js)

* Some code optimization to help minification... Although, funny story, it fares worse in the gzipping stage. Yay. (script.js)
Title: Re: New revs
Post by: Nao on May 29th, 2011, 12:16 AM
rev 791
(12 files +1-1, 18kb)

* Changed windowbg colors a tiny bit to make them a bit more lively. (index.css)

* wrc-based intertitles now use the h6 tag. Hopefully it shouldn't carry too much weight and can be used any way you like. (index.css)

* Reworked the stats page layout. Both windowbg colors are now used. The first area gets its items reordered in a more logical way. Got rid of title2 blocks in favor of h6. (Stats.template.php, index.css, sections.css)

* Renamed $txt['parent_boards'] to $txt['sub_boards'], to reflect what it's actually used for... (I call that a SMF bug.) (BoardIndex.template.php, MessageIndex.template.php, Wireless.template.php, index.language.php)

* Updated some icons to use the same size as the others. (stats_posters.gif, stats_replies.gif)

- Forgot to delete jQuery 1.4 from the SVN. (jquery-1.4.4.js)

! Glass effect in Zoomedia didn't work in Safari. (zoom.css, zoom.webkit.css)

! Fixed validation error (divs in ths). (Stats.template.php)

* Indenazi. (zoomedia.js)
Posted: May 29th, 2011, 12:14 AM

(Note: rev 792 is a dummy/empty one, due to a wrong manipulation.)
Title: Re: New revs
Post by: Nao on May 31st, 2011, 10:57 AM
rev 793
(7 files, 10kb)

! Item upload page would consider empty quota lists as errors, instead of falling back to the overall default quota. (Aeva-Gallery.php)

! Error in the English version -- "add an item to this album" should just be "add an item", since the item uploader allows you to choose your target album... (Media.english.php)

* Readability nazi. (Subs-Media.php)

* Sidebar shouldn't have cat blocks. Using title2 in calendar. (Calendar.template.php)

* h6 intertitles have no reason to be linked to .wrc, since they're never used in other situations. (index.css)

* Zoomedia's glass effect was a tad too strong in some situations. (zoom.css, zoom.webkit.css)
Title: Re: New revs
Post by: Nao on June 1st, 2011, 08:04 PM
rev 794
(8 files, 17kb)

* Overhaul of the credits area. Still needs some work. (Credits.php, Who.language.php, sections.css, Who.template.php)

* Simplified the footer copyright, given that it'll be legal by the end of the week... (index.language.php)

* Reworked stats area to show long strings over the entire line instead of cutting it in half. Try resizing the window to see how it improves on the earlier behavior. (sections.css)

! Fixed a session bug (thanks TE). (Login2.php)

NOTE: this does NOT include the font family changes I made to Wedge...
Title: Re: New revs
Post by: Nao on June 3rd, 2011, 06:23 PM
rev 795
(8 files, 10kb)

* Credits update. Added nice little South Park avatars of the Wedgeward guys, sorted long lists in (an)alphabetic order, removed a consulting developer (who never committed to the actual repository), and moved the remaining one (that's me) to the developer list (since that's what I was, unofficially.) (Credits.php)

* Made sure the copyright list takes the entire width in the credits area. (Who.template.php)

! Poll questions are limited to 255 characters, just like poll options. (Poll.template.php)

- Removed some unused or useless font fallbacks. (media.css, report.css, sections.css, Warm/index.css, Wuthering/index.css)
Title: Re: New revs
Post by: Nao on June 4th, 2011, 06:16 PM
rev 796
(4 files, 7kb)

! Usernames with special characters were incorrectly processed in profile pretty URLs. (QueryString.php)

* Use a dfn tag rather than a custom span to show the help text for password changing. (Profile-Modify.php)

* Don't hide additional membergroups if there aren't enough to justify it. (Profile.template.php)

* Parenazi. (Subs.php)
Title: Re: New revs
Post by: Nao on June 5th, 2011, 11:42 PM
rev 797
(5 files, 30kb) (mainly because of binary changes.)

* The stats area in the board info center was way too crowded. Turned the area into an unordered list. (BoardIndexInfoCenter.template.php)

! The mini Wedge logo didn't have the strike-through line in 'we'. (other/images/minilogo.png, images/minilogo.png)

! The main menu icons for login and logout had disgracious corners. (other/images/sprite-menu-32bit.png, images/icons/sprite.png)
Title: Re: New revs
Post by: Arantor on June 7th, 2011, 05:12 PM
rev 798
(273 files, 304kb) (mainly because near enough every PHP file had to be touched)

This has taken me all day to do. (There were problems accessing the server recently...)

! Sync to SMF 10595
 ! r10547 The cookie shouldn't be reset. (Subs-Auth.php, Subs-Login.php) (In our case, we get to remove a chunk of code that they kept because we don't have to do PHP 4.3.2 specific tests...)

 ! r10548 Search strips so much it may end up with nothing! (Search2.php)

 ! r10549 Minor smiley misalignment fixed. (sections.css) [Bug 4727] (The img.smiley class may live better somewhere else, not sure.)

 ! r10553 "A few trivial fixes as per bug reports topics." (Profile.template.php, PersonalMessage.template.php)

 & r10557 Small clearer text. (Help.english.php)

 ! r10561 Updated [SiNaN]'s name as per SMF credits. (Credits.php)

 ! r10562 A necessary language file was not loaded when using read_tgz_data() function outside Packages area. (Subs-Package.php) [Bug 4732]

 ! r10564 Testing change for the wiki links and redirects. (Admin.php) (Plus I reinstated the change I broke from before.)

 ! r10565 Updates of readme files (readme_*.html) (We may want to keep these for the future, so I updated them with their new content and licence, but I left all the instances of SMF alone for now... I think I got everything.)

 ! r10566 This one didn't have a commit note but it ensures the board ordering for membergroup access is in the right order - it wasn't necessarily the case in either MySQL/InnoDB or PostgreSQL. (ManageMembergroups.php)

 ! r10569 I quote SVN: "Tweaked the install/upgrade/convert readme's for added grooviness." (readme_install.html, readme_update.html, readme_convert.html, readme_upgrade.html) (Not sure anyone even reads these though... the convert one was missed from the other changes, and the upgrade one was missed in this commit)

 ! r10570 Fixing the HTML5 validation link (index.template.php) [Bug 4740]

 ! r10571-2, r10574 Tweak how the URL is preprocessed to ensure it doesn't damage OpenID.

 ! r10573 Members only with manage membergroups permission could create groups that inherit from or based of off protected groups, and members having manage membergroups and moderate forum members could register members protected groups as their primary group. (ManageMembergroups.php, ManageRegistration.php, Subs-Members.php)

 ! r10576 Beginning the version bump saga. (index.php, install.php)

 ! r10580 All those headers changed in Sources/ and index/SSI/payment gateways (many files)

 ! r10582 Upgrader should now check for @version in index.php rather than the old file header (upgrader.php)

 ! r10583, r10585 Language files get version bumped, template files get version bumped, then they decided to add the new header... so two sets of big-ass commits. (Didn't version bump the language files new in Wedge)

 ! r10586 Make sure the right version is examined for 'view file versions' (Subs-Admin.php)

 ! r10588 Themes code should also be detecting the version format correctly too. (Themes.php)

 ! r10589 Templates don't have to be compared between their filename and their contents, we can use the version number listed inside now.

 ! r10591 More header cleanups, including a couple that I managed to miss. (Calendar.php, SplitTopics.php, Subs-Captcha.php, Subs-Graphics.php) (But still no Class-Graphics.php since I killed that.)

 ! r10593 Adding a missing die-if-not-declared test (Subs-MessageIndex.php, Subscriptions-*.php) (And they did some spacinazi changes, but I already fixed those anyway, plus I did it in all three payment gateways, rather than just the one.)

 ! r10595 Version bumps including for tests. (Search.php, Search2.php, SearchAPI-*.php, ssi_examples.php)



@ Not sync'd
 ! r10543 Tweak converter name (vbulletin 3)

 ! r10544 Copyright testing function changes, these had already been removed anyway and in any case functionality changed - they still figure out the version of SMF for SSI, we don't bother. (Oh, and removing $txt['am'] and $txt['pm'] again, probably due to unsync'd local copies)

 ! r10545 Fixing the previous break as well as adding &reg; to the trademark in the manual - which we don't have now.

 ! r10546 Credits updates that we're not keeping (non dev updates)

 ! r10550 Some minor style fixes that weren't relevant to us (mostly Core)

 ! r10551 Removal of the manage-copyright stuff, plus changing the footer - we've already done this to something we're happy with.

 ! r10552 PostgreSQL specific changes

 ! r10554-5 1.1 fixes and version bump, and patch

 ! r10556 Upgrader fixes for renaming old theme, and fixing known themes - but none of the code being changed even exists in our upgrade.sql, leads me to believe it's not relevant to us anyway.

 ! r10558 PostgreSQL specific changes to ManageSmileys.php

 ! r10559 Changing LLC to NPO in installer and upgrader scripts

 ! r10560 Mark Rose is also now credited as a consulting dev. Haven't seen a commit - but to be fair I have seen a fair amount of thoughts from him on improvement. Have not added to SMF cons. dev. yet but no objections to doing so.

 ! r10563 My name is already in our credits fully as opposed to just a pseudonym...

 ! r10567 PostgreSQL connections do allow spaces in usernames and passwords...

 ! r10575 Minor changes to news_readme.html that don't apply (version bump, moving the copyright)

 ! r10577 license.txt contains New BSD licence. Since we're not adopting that to start with...

 ! r10578 Spacinazi that we already did in a few files.

 ! r10579 Minor code cleanup in the converters only.

 ! r10581 Adding a space to their copyright in the installer footer... we already had it looking nice anyway.

 ! r10584 They changed the code I mentioned in r10544, so that SSI doesn't display a copyright at all as opposed to just using a versionless one like we do.

 ! r10587 We don't have to bump a ton of version numbers throughout the system to decache scripts and stylesheets.

 ! r10590 Changing the license.txt file in the theme directories to be BSD... but we never had those files in the first place.

 ! r10592 Tidy up the header in ssi_examples.php, but I already did that.

 ! r10594 Minor cleanup in headers (one file doesn't exist, the other was spacinazi I already fixed)



@ Did not add the new header to Wedge Media files, last time I played in there I broke things, so staying out of that for now.
 
@ Nao, please take a look at the change made in QueryString.php, urldecode not being called on URLs may have consequences for Pretty URLs I'm not currently aware of.

@ r10568 has not been included, and I'm not sure about including it. Basically it's the apparent "uberfix" for jumping edit boxes in IE, with the caveat that IE6/7 ends up with a funny width of some 600 odd px wide edit boxes. I don't think I can replicate it on Wedge so don't want to shove something like this in without good reason...
Title: Re: New revs
Post by: Nao on June 7th, 2011, 11:34 PM
These are some of my things from the last few days... Not committing everything because the Arial redesign isn't complete yet.

rev 799
(22 files, 28kb)

* Don't load media strings anymore when viewing the Who's Online page, and test for generic sub-actions before falling back to the 'unknown' action. Added RSS action to the list. (Subs-Media.php, Who.language.php, Media.language.php)

* Rewrote album listings for a cleaner look. (Subs-Media.php, media.css)

* My credit avatar needed some margin. Otherwise, in some situations it could end up glued next to Pete. We like each other, but not that way! (Credits.php)

* Retooled the footer to only use unordered lists. (index.template.php)

* Moved admin-only "RD" stat line in the footer, to its own list item, allowing to style it individually. (Subs.php)

* Spacinazi. (Class-JSMin.php, Display.php, Load.php, ManageMaintenance.php, Aeva-Sites-Custom-Example.php, module.audio-video.real.php, Subs-Aeva-Sites.php, Subs-Exif.php, MessageIndex.php, Profile-Modify.php)

! SMF bug: it should be class="new_win", not rel="new_win". (Display.template.php)

* Don't bother forcing a font size on buttons if they already have their own custom class, which we can style... (Display.template.php)

- W3C validator doesn't seem to like <link type="contents">, even though it says it doesn't mind. Whatever. (index.template.php)

* Turned $txt['hello_member_ndt'] into a sprintf'ed string, because some languages put the greeting after the name, not before it. (index.template.php, index.language.php)
Title: Re: New revs
Post by: Nao on June 8th, 2011, 11:58 AM
rev 800
(88 files +1-1, 72kb)

* Dull, boring and annoying update of many, many files just to fix/update their description in the header. Typos, British vs American spellings, confusing descriptions and anything needing some normalization was my target.

(index.php, Subscriptions-*.php, Admin.php, Ajax.php, BoardIndex.php, Class-DB.php, Credits.php, Groups.php, Jseditor.php, Jsoption.php, Lock.php, Login2.php, Logout.php, ManageMaintenance.php, ManageNews.php, ManageScheduledTasks.php, MoveTopic.php, PackageGet.php, PersonalMessage.php, Poll.php, PrettyUrls-Filters.php, Profile-Modify.php, Profile-View.php, Profile.php, Search.php, Security.php, Sticky.php, Subs-Auth.php, Subs-Boards.php, Subs-Editor.php, Subs-List.php, Subs-Login.php, Subs-Menu.php, Subs-PrettyUrls.php, Subs-Recent.php, Unread.php, Unreadreplies.php, ViewQuery.php, ViewSMFile.php, Who.php, subscriptions.php, TEMPLATES: Announce, Calendar, Display, Errors, Login, ManageAttachments, ManageMembers, PersonalMessage, Printpage, Recent, Search, Settings, Stats, Themes)

! Wedge didn't indicate the version number in the footer, even though it was supposed to. (index.french.php, index.english.php)

* Renamed XMLHttp action to Ajax, as it's more natural to most users. (index.php, Ajax.php, Load.php, QuoteFast.php, SplitTopics.php, Stats.php, script.js, topic.js)

- Removed CACHE_SUFFIX constant. This was a leftover from rev 290 which I never remembered to delete. (index.php)

- Removed version checking from Search features. This was only for compatibility with SMF2 betas... (SearchAPI-Sphinx.php, Search.php, Search2.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, SearchAPI-Standard.php)

* Modified $forum_version and WEDGE_VERSION to make them work as intended. (index.php, other/install.php, other/smfinfo.php, other/upgrade.php, Calendar.php, Feed.php, ManageServer.php, Aeva-Foxy.php, ManageMedia.php, Subs-Media.php, PackageGet.php, Packages.php, Subs-Package.php, ManageMedia.template.php)

* Missing HTML5 conversions, and typonazi. (other/readme_*.html, other/ssi_examples.shtml)

* Updated/fixed help language files. (Help.english.php, Help.french.php)
Title: Re: New revs
Post by: Nao on June 8th, 2011, 08:09 PM
rev 801
(32 files, 34kb)

! ManageMembergroups sync didn't convert $smcFunc to wesql. (ManageMembergroups.php)

* Reworked admin home page layout. (Admin.template.php, admin.js, admin.css)

* Started using the new header on a few more files. (other/.htaccess, other/Sphinx/*.php,

* Some more SMF to Wedge renaming. (Admin.language.php)

* Typonazi. (Suggest.php, EmailTemplates.english.php, ManageSettings.french.php)

* Spacinazi/indenazi. (media folder's index files, other/upgrade.php, Class-DB.php, ManageBans.php, ManagePermissions.php, ManageServer.php, ManageMedia2.php, Subs-OpenID.php, Subs-Package.php, Themes.php, Who.php, SSI.php, Admin.template.php, EmailTemplates.language.php, index.language.php, sha1.js)
Title: Re: New revs
Post by: Arantor on June 9th, 2011, 03:40 AM
Revision: 802
Author: arantor
Date: 02:39:49, 09 June 2011
Message:
! Several small bug fixes to the hooks code, notably that remove_hook couldn't ever remove a given hook because it actually requires the filename to be passed to it too, so it can be matched, plus the discrepancy of add_hook not explicitly checking for .php entries, plus handling some undefined variables. (Subs.php)

+ Addon Manager now understands a new XML entry in addon-info.xml files, specifically for managing hooks. (Packages.php, Subs-Package.php, Packages.english.php)

@ Documentation forthcoming in the New Revs - Comments thread, along with the one known bug at this time.
----
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Title: Re: New revs
Post by: Nao on June 9th, 2011, 09:11 PM
rev 803
(22 files -1, 24kb)

- Removed support for SMStats (remote logging of server stats at install time). We don't want to bother you with that, and we wouldn't be checking out the stats anyway... (index.php, install.php, upgrade.php, SMStats.php, Install.language.php)

* Renamed fetchSMFiles to fetchRemoteFiles, and other SMF to Wedge changes. (upgrade.php, upgrade.sql, ScheduledTasks.php, ManageScheduledTasks.language.php, ModerationCenter.language.php)

* Added some documentation to color functions in WeCSS. Just in case I forget later... And actually added 'WeCSS' to the header. (Class-CSS.php)

* Removed the hackish linear-gradient fix, as the new generic prefix system replaces it flawlessly. (Subs-Cache.php, zoom.css, zoom.webkit.css)

* That action list was getting long... Replaced it with an array. (Subs-Package.php)

! Add-on manager doesn't need to fully parse the file name for hooks, as remove_hook() does it by itself. (Subs-Package.php)

! $sourcedir wasn't in the globals, and remove_hook() didn't behave the same way as add_hook(). Now it's fixed. Also removed a line in add_hook(). I hate seeing a variable set up when it's not needed, eheh. (Subs.php)

* French translation. (Packages.french.php)

* SMF bug: using $txt['smf_stats_14'] (a leftover from SMF 1.0's era?) when the exact same text was available in the same file, as $txt['most_online']. Fixed that, but also changed the Stats template to use most_online_ever instead of most_online in a place where it made more sense. (Stats.language.php, Stats.template.php)

@ Note: the 'readme' action is not in the add-on manager's action list. That's because it's not repeated in the second area... I figured it's a special case.

(NB: the Note got logged into the changelog as well... I usually make sure this doesn't happen, sorry!)
Title: Re: New revs
Post by: Nao on June 10th, 2011, 05:25 PM
rev 804
(4 files, 7kb)

* Finished implementing the small changes to how the packman deals with hookfile. As is customary with me, this is totally untested. Mwaha. (Packages.php)

! Whoever thought enabling magic quotes through the .htaccess was a bloody idiot. (other/.htaccess)

* Typonazi, parenazi. (ManageSettings.php, Subs-Package.php)
Title: Re: New revs
Post by: Arantor on June 12th, 2011, 01:23 AM
! Sync to SMF 2.0 final. I really can't be arsed to do this commit by commit, so I won't.
 ! Fix of editor width in IE8, basically any time a relative width is applied to the editor, it goes funny. The fix is IE8 specific... and only after applying it did I wonder if it shouldn't just have been added to the IE8 specific markup and be done with it >_< It's there for now, can always change it later. (Themes.template.php, SendTopic.template.php, Profile.template.php, PersonalMessage.template.php, ModerationCenter.template.php, ManageNews.template.php, ManageMembergroups.template.php, ManageBoards.template.php, Display.template.php, Admin.template.php)

 ! Non-broken version of admin compare-versions function. I took the liberty of removing the switch-and-bait that changed 2.0 RC1-1 into 2.0 RC1.1. (admin.js)

 ! Fix of language guidance in permission string. (ManagePermissions.english.php)

 ! Non-broken version compare in package manager. In the end we're going to be ditching this because we should really use the proper PHP function instead. (Subs-Package.php)

 ! Search should also use the non-broken version of version compare. (Search2.php)

 ! Make sure to use the correct URL when just after we've uploaded an avatar and we go back to the profile (as on a custom folder it would be wrong) (Profile-Modify.php)

! Things not included
 ! Removal of comma in Who.template.php because 'name, name, and name' was wrong apparently. Our template's been gutted since then.
 ! Applying $context['theme_variant_url'] in the board index for expand/collapse images as not relevant to us.
 ! PostgreSQL fix to manage membergroups because PostgreSQL returns F for false instead of 0 like MySQL, and the code doesn't like it.



@ Important: While this represents the final change set until 2.0 final, I need to do one last sweep of the files to verify that we got everything we had to get and that anything we didn't, is dealt with appropriately. I'm pretty happy that it's a non-issue, but given what's been said before now, I have to be sure.
Title: Re: New revs
Post by: Nao on June 14th, 2011, 11:01 AM
rev 806 - the "hard drive & PC loss aftermath" commit (i.e. I actually re-used the installer for the first time this year...)
(7 files, 8kb)

! 'Last modified' in topic pages should use the on_* time format. (Display.php)
! Styling generation failed during install because the folder variable wasn't set. (install.php)
! Runtime error due to outdated insert_id call. (db_aeva.php)
! jQuery 1.6 was used in hardcoded areas, instead of the official Wedge version (1.5.2). (upgrade.php, install.php, repair_settings.php)
- Removed last remains of the SMF stats setting in the installer. (install.php)
* Strange '/' thing in the installer can be confusing. Replacing it with the word 'slash'. (Install.language.php)
Title: Re: New revs
Post by: Nao on June 15th, 2011, 10:06 AM
rev 807
(3 files +1-1, 10kb)

* Renamed media/generic_images to media/icons. Makes more sense... (media/icons)
- Cleaned up the Aeva installer, got rid of all compatibility code (SMF 1, non-MySQL, SMG...), in order to make it easier to merge into the main Wedge installer later. (db_aeva.php, install.sql)

@ Note to Thorsten: obviously, the importer will need to re-use code that I just deleted from the Aeva installer. I think you have the file...
Title: Re: New revs
Post by: Nao on June 16th, 2011, 10:07 AM
rev 808
(5 files, 7kb)

+ Added a $boarddomain variable in the installer (it's basically $boardurl without the http:// stuff), and fixed the first board's default pretty URL. (install.php, install.sql)
! Don't use dfn tags inside descriptions... They are for the description itself. (ManageBoards.template.php, Admin.language.php)
Title: Re: New revs
Post by: Nao on June 16th, 2011, 11:42 AM
rev 809
(13 files +1-1, 23kb)

! Forgot to re-order the action list after renaming the Ajax action. (index.php)

* Moved general settings from Aeva installer to regular installer. Also moved wedbPackages init code to where it should be. (db_aeva.php, install.sql)

! The installer said it was going to "install 0.1"... Added Wedge back into it. (install.php)

* Moved version_warning style to the actual CSS file. Also semicolonazi. (install.php, upgrade.php, install.css)

! Temp fix for Wedge crash during media database creation. (Subs.php)

! French translation was... drunk or something. Not my fault! (Install.french.php)

* Renamed ViewSMFile to ViewRemote. (ViewRemote.php, TEMPLATES: Admin, ManageSmileys, ModerationCenter, Packages, Themes)

! reqWin failed in Firefox 4, and opened a popup window instead. Yikes. Only drawback is that this fix doesn't work while installing (the 'success' test). (script.js)

@ Important: once we merge the installers together, we'll have to remove the SMF !== SSI test in Subs.php
@ Even more important: try to figure out why Firefox 4 fails on reqWin when installing.
Title: Re: New revs
Post by: Nao on June 16th, 2011, 11:44 PM
rev 810
(5 files, 7kb)

! Undid the reqWin fix. Better have a popup window than nothing at all. (script.js)

! Fixed the installer's Firefox bug in a different way, by setting window.event at the time the click event is triggered. Seriously, jQuery really should normalize that one... (Install.language.php)

! Forgot to commit the install.css file.

* Saving a couple of bytes. Hopefully. (admin.js)
Title: Re: New revs
Post by: Nao on June 18th, 2011, 07:44 PM
rev 811
(21 files, 20kb)

! Some version numbers weren't correctly updated. (current-version.php, detailed-version.php, Subs-Package.php)

* Renaming 'integrations' and 'integration hooks' to just 'hooks' once and for all. Also removed the last reference to the old 'hook constant'. (Activate.php, Class-Editor.php, Errors.php, Load.php, Login2.php, Profile-Actions.php, Profile-Modify.php, Subs-Login.php, Subs-Members.php, Subs-Post.php)

! Fixed a French string. (ManagePermissions.french.php)

* Minor Packer-aware optimizations. (admin.js)
Title: Re: New revs
Post by: Nao on June 21st, 2011, 07:50 PM
rev 812
(32 files +2-2, 46kb)

- Removed support for rel="index" meta tags, as it's no longer part of the HTML5 standard. Also moved meta tags below all link tags, to ensure any external files are loaded as soon as possible. (index.template.php)

- Trimmed down external latest news. (other/xml/latest-news.php)

* Changed button strips to use a 'class' element rather than an 'active' boolean, avoiding validation errors when trying to add custom CSS classes. (Aeva-Gallery.php, Aeva-ModCP.php, MessageIndex.php, TEMPLATES: index, Display, Media, Memberlist, PersonalMessage, Recent, Reports)

* Some of my uncommitted layout changes are starting to make their way into the code... Without the stylesheets. Meh. Coming soon! (BoardIndexInfoCenter.template.php, Display.template.php)

* I just don't like seeing 5 lines of code that could look cool and fit on a single line... (Subs-Login.php)

* The default feed format is now Atom rather than RSS 1, and support for SMF (custom) and Webslice feeds has been removed because they've never been commonly used anyway. Media feeds remain in RSS 2 format for now. (Feed.php, BoardIndexInfoCenter.template.php, index.template.php, index.language.php)

* Renamed 'RSS' to 'Atom' or 'feeds'. (index.php, db_aeva.php, rss.png, Feed.php, Load.php, Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php, Subs-Media.php, media.css, TEMPLATES: BoardIndex, BoardIndexInfoCenter, index, Media, LANGUAGES: Admin, Help, index, ManageMedia, Post, Stats, Who)

@ Note: I removed the mention about feeds in the Help file, because we're going to move it somewhere else... Let's just not forget to document it when it's done. ;)
Title: Re: New revs
Post by: Nao on June 22nd, 2011, 04:15 PM
rev 813
(13 files +1, 14kb)

* Bumped minimum PHP version from 5.1.2 to 5.2. Also removed a couple of replacements for PHP 5.2+ specific functions. (install.php, readme_*.html, webinstall.php, Load.php, ManageSettings.php, ManageMedia3.php, Subs-Cache.php)

! A language string wasn't properly updated in feeds. (Feed.php)

! IE9 doesn't support text-shadow. All other browsers have supported it for the last 125 years. Get real, IE. (index.ie9.css)

- Leftover from an early AeMe feature. (Aeva-Sites-Custom-Example.php)
Title: Re: New revs
Post by: Nao on June 24th, 2011, 07:43 PM
rev 814
(12 files, 16kb)

* Moved the pretty URL initialization code to the installer, removing the need to do it from the admin area. Also greatly simplified the code internally. (install.php, install.sql, ManageSettings.php, PrettyUrls-Filters.php, Subs-PrettyUrls.php, Subs.php, Admin.template.php, Admin.language.php)

* Saved a few bytes from CDATA parsing in feeds. Well, only in case a ]]> sign is used in posts. Which probably never happens. (Feed.php)

* Just changing text-align to right for the sidebar in Warm. Looks a bit better... Unsure though. (Warm/index.css)

! Fixed mismatched closing tag in Warm definition. (Warm/settings.xml)
Title: Re: New revs
Post by: Nao on June 24th, 2011, 11:37 PM
rev 815
(12 files, 13kb)

* Simplified pretty_filters setting a lot. Removed 'requires' and 'id' (never used), as well as 'priority' (real men use array_splice). The array is unserialized at startup. Specific hacks no longer test for the global pretty URL setting, and instead test for the filter type they're related to. Finally, pretty_enable_filters will only be set if at least one of the filters is enabled. (install.php, Display.php, Load.php, ManageBoards.php, ManageSettings.php, Aeva-Foxy.php, QueryString.php, Subs-PrettyUrls.php, Subs.php, ManageBoards.template.php)

- Leftover. (Admin.french.php)

NOTE: this release is totally, completely untested... I was trying to get confused by my own code changes so I decided to give myself a break :P Obviously if bugs are found, I'll fix them. But normally it should be more 'logical' than the previous incarnation of Pretty URLs.
Also, we definitely need to add a few hook points for PURLs. The determine_location hook is certainly not enough.
Title: Re: New revs
Post by: Nao on June 26th, 2011, 05:55 PM
rev 816
(8 files, 18kb)

! Given that IE9 still doesn't support CSS gradients, rewrote gradient_background() to add proper support for it, and redirect to the rgba version in case of a solid color. (Class-CSS.php, Subs-Cache.php)

* Moved 'column' div to the sidebar block definition (should help with hooking), and reworked sidebar indentation to match this and save a few bytes. (index.template.php, BoardIndexInfoCenter.template.php, Calendar.template.php, GenericMenu.template.php)

- Removed some hardcoded Pretty URL code that wasn't actually needed. Documented a function. (Subs-Boards.php, Subs-PrettyUrls.php)
Title: Re: New revs
Post by: Nao on June 26th, 2011, 08:20 PM
rev 817
(5 files +1, 9kb)

+ Added support for IE 10 in the PHP code, and used it to provide real gradients for it. (Class-CSS.php, Load.php, index.ie10.css)

! Pretty URLs were broken. Again. (ManageSettings.php, Subs.php, Admin.template.php)
Title: Re: New revs
Post by: Nao on June 28th, 2011, 11:58 AM
rev 818
(10 files, 14kb)

* Replaced zoomedia's "rel" hack with actual class names[1]. Still not used for now, but it'll be better in the long run anyway. (Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php) Media.template.php)

* Moved media details to the sidebar in case the browser is Safari Mobile. It can't cope with the width anyway. (Aeva-Gallery.php)

* Moved some media action bools to proper context variables. Added bonus: action bar won't show up at all if you can't do anything. (Aeva-Gallery.php, Media.template.php)

! Search was broken. (Search2.php)

! Hardcoded language string. (zoomedia.js)

* Some layout improvements in media homepage and media item pages. (Media.template.php)

- Removed shortcut keys from media strings, as they're no longer valid. (Media.language.php)

* Improved vertical alignment in error log. (Errors.template.php)

- No need for an id in auto-generated shims. (zoomedia.js)
 1. That's because they don't validate in the new html5 validator...
Title: Re: New revs
Post by: Nao on June 30th, 2011, 09:39 AM
rev 819
(5 files, 7kb)

! The WYSIWYG editor had a reverse color palette. Not exactly sure why... (editor.css)

! Guests could be attributed illogical (and illegal) permissions in the gallery, such as moderating it. (ManagePermissions.php)

* Modified the order of some media permissions to separate moderation-type permissions from regular ones. (ManagePermissions.php)

* Made it clearer that the 'Auto-approve albums' permission allows regular users creating their own albums. (ManagePermissions.language.php)

* Small code logic clarification. (Aeva-Gallery2.php)
Title: Re: New revs
Post by: Arantor on July 1st, 2011, 12:27 PM
Revision: 820
Author: arantor
Date: 11:22:11, 01 July 2011
Message:
! The IP address displayed in the reminder emails was not properly formatted.
----
Modified : /trunk/Sources/Reminder.php

Posted: July 1st, 2011, 12:22 PM

Revision: 821
Author: arantor
Date: 11:27:21, 01 July 2011
Message:
! Add the ability to specify a separate email address for 'from' in emails. I don't think I explained it that well, but basically this means you can trivially set a different outgoing address, preventing people who are too dumb to read properly from sending you emails when they should be using the forum instead.
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Title: Re: New revs
Post by: Nao on July 2nd, 2011, 01:00 AM
rev 822
(24 files, 26kb)

* Rewrote the 'More smileys' feature to show new smileys below the default smiley list, instead of opening an ugly popup. Also simplifies the JS code a lot. (Class-Editor.php, Post.language.php, post.js)

* Moved the 'Customize Smileys' option to the top of the smiley admin page, mostly to make it stand out, and clarified what it's for in the language strings. (ManageSmileys.php, ManageSmileys.language.php)

! The Re: prefix was broken in the French version. Somehow, somewhere, the nbsp entity is now converted to an ASCII character, so it wouldn't recognize prefixes in existing posts. Rather than fix the bug, I decided to simply use a breakable space. Older posts might need to be converted... (index.french.php)

+ Adding [Unknown] to the Consultant list in the credits area. (Credits.php)

* Updated header comments for all gallery-related files to match the new PHPDoc style and add credits to Dragooon where credit is due. (Sources/media/*.php, Media.template.php, ManageMedia.template.php, mediadmin.js, up.js)

- Media popups really didn't need the extra classes. I'd say. (Aeva-Gallery.php, Media.template.php)

@ Note: other JS files probably need their headers to be updated as well...
Title: Re: New revs
Post by: Nao on July 2nd, 2011, 01:12 PM
rev 823
(6 files, 13kb)

! The mail sending code uses $modSettings['mail_from'] while our admin code was $modSettings['from_email']. (ManageServer.php)

! Fixed Packer to allow for structures such as "for (var something in { object: true })", and added a comment with a link to my bug report and original fix. (Class-Packer.php)

* Rewrote the help text for mail_from. It may have been a bit unclear. At least to me. (Help.english.php)

* Translated new strings to French. (Admin.french.php, Help.french.php)

- Stray comment. (Subs-Post.php)
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 12:56 AM
Revision: 824
Author: arantor
Date: 23:56:29, 02 July 2011
Message:
! Remove 'Reports Generation' from Core Features. I mean, it was enabled already and all the Core Feature option does is show/hide the area, it's not like it actually prevents any ongoing performance problems, so there really wasn't much point actually making it optional in the first place. (install.sql, Admin.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 01:44 AM
Revision: 825
Author: arantor
Date: 00:44:09, 03 July 2011
Message:
! Moved the news and version info into the sidebar (and if the menu is in sidebar, it'll be under the menu though that's not going to be an issue for long), plus fixed the styling and language strings to match (Admin.php, Admin.template.php, Admin.english.php, admin.css, index.rtl.css)
! Removed the AdminSearchOM function. Not only do we not use it (because we don't have an online manual to search), the chances are if and when we do, we won't use the same method they had anyway, meaning that we don't really want it around. (Admin.php, Admin.template.php, Admin.english.php, Admin.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/styles/admin.css
Modified : /trunk/Themes/default/styles/index.rtl.css
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 02:16 AM
Revision: 826
Author: arantor
Date: 01:14:40, 03 July 2011
Message:
! The sidebar has more dependencies than I thought it did, need to make sure the list of admins is obtained and that the JavaScript is included where necessary. (Admin.php, Admin.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/Admin.template.php

Posted: July 3rd, 2011, 02:14 AM

Revision: 827
Author: arantor
Date: 01:16:14, 03 July 2011
Message:
! And oops, a missing global variable or two... (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 02:31 AM
Revision: 828
Author: arantor
Date: 01:30:53, 03 July 2011
Message:
! Fixed some more oddities with the subtemplate not being called right. Also, split up AdminHome into two functions - there is no need for the admin front page to actually do everything needed for the credits as well, and vice versa. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Title: Re: New revs
Post by: Nao on July 3rd, 2011, 10:59 AM
rev 829
(10 files, 15kb)

* Every time I see a we:title where a we:cat should be, I really feel the need to change it. More to go, whatever. (Profile.template.php)

* Converted some of the media template into proper Wedge-like templates. Tables are good. But not systematically, eh. (Media.template.php)

- Removed windowbg/windowbg2 mentions from description areas, because description already sets its own background color... It's a big boy now. (Profile.template.php, PersonalMessage.template.php, Help.template.php, GenericMenu.template.php, ViewQuery.php, upgrade.php)

* Added more space in the Delete Account area. If you're going to delete your own account, you may want to get some gasping time. (Profile.template.php)

* Pointless optimizations. (suggest.js, editor.js, Aeva-Foxy.php)

@ It's a pointless commit overall but if you're gonna commit in smaller chunks, so shall I :P
Title: Re: New revs
Post by: Nao on July 3rd, 2011, 08:48 PM
rev 830
(2 files, 8kb)

* The permissions page's Simple mode shows empty headers for no reason whatsoever. Also reworked indentation. (ManagePermissions.template.php)

* Globals on two lines, uh? (Profile-Modify.php)
Posted: July 3rd, 2011, 11:54 AM

rev 831
(1 file, 5kb)

! An annoying bug in Packer makes some servers crash on long strings. Well, on my local server it does, but not on my remote one. I used a quick workaround. Hopefully I can fix the problem at the source in the future... (suggest.js)
Title: Re: New revs
Post by: Nao on July 3rd, 2011, 10:59 PM
rev 832
(4 files, 8kb)

! Is it me, or did the SMF team actually forget to fill the MySQL version number in the admin area...? (Admin.php)

! A forgotten semicolon would crash the admin homepage if Packer was enabled. (admin.js)

* Some improvements to the admin sidebar layout. (admin.css)

* Commenazi. (Admin.template.php)
Title: Re: New revs
Post by: Nao on July 4th, 2011, 12:20 AM
rev 833
(11 files, 29kb)

! Using the same format as SMF for version numbers. (detailed-version.php)

* Devised a method to provide day and month names in the user's current language when showing the latest news. (Somehow, I think it's a bit overkill for such a small detail....) (latest-news.php, Admin.php, admin.js)

* Admin homepage needed some extra space. (Admin.template.php)

* wedgeAnnouncements instead of smfAnnouncements. (ModerationCenter.template.php, latest-news.php, admin.js)

* Translation. (Admin.french.php)

- I'm sure there's a good reason to have $txt['months_titles'] that are exactly the same as $txt['months'], and to only use them in the calendar, but OTOH just using $txt['months'] in the calendar will teach it a lesson. Bad calendar! (Calendar.template.php, index.language.php)

- Removing some temp SMF code. (ViewRemote.php)
Posted: July 4th, 2011, 12:15 AM

rev 834
(1 file +1, 7kb)

+ Forgot to add new file admin.rtl.css, which at it says, is the RTL version of admin.css. We really should move as much code as possible from index.rtl.css to whatever.rtl.css, especially in the admin/moderation area. Oh, and that index.rtl file really needs to be overhauled. From top to bottom... (admin.rtl.css, index.rtl.css)
Title: Re: New revs
Post by: Arantor on July 4th, 2011, 03:31 PM
Revision: 835
Author: arantor
Date: 14:28:16, 04 July 2011
Message:
! The revised admin panel (lots of files, including new ones and getting rid of old ones)

The main thing that's different is the front page, and there's still some compatibility code in there from earlier drafts, this isn't finished at all - more icons are needed, as well as completing the move of some features. In the end, Core Features should ultimately be removed from the system, as the first step.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/admin/attach.png
Added : /trunk/Themes/default/images/admin/autoembed.png
Added : /trunk/Themes/default/images/admin/autoembed_off.png
Added : /trunk/Themes/default/images/admin/autoembed_on.png
Added : /trunk/Themes/default/images/admin/banlist.png
Added : /trunk/Themes/default/images/admin/calendar.png
Added : /trunk/Themes/default/images/admin/calendar_off.png
Added : /trunk/Themes/default/images/admin/calendar_on.png
Deleted : /trunk/Themes/default/images/admin/feature_cd.png
Deleted : /trunk/Themes/default/images/admin/feature_ps.png
Deleted : /trunk/Themes/default/images/admin/feature_rg.png
Added : /trunk/Themes/default/images/admin/languages.png
Added : /trunk/Themes/default/images/admin/logs.png
Added : /trunk/Themes/default/images/admin/mail_settings.png
Added : /trunk/Themes/default/images/admin/maintenance.png
Added : /trunk/Themes/default/images/admin/membergroups.png
Modified : /trunk/Themes/default/images/admin/members.png
Added : /trunk/Themes/default/images/admin/paid_subs.png
Added : /trunk/Themes/default/images/admin/paid_subs_off.png
Added : /trunk/Themes/default/images/admin/paid_subs_on.png
Modified : /trunk/Themes/default/images/admin/permissions.png
Added : /trunk/Themes/default/images/admin/registration.png
Added : /trunk/Themes/default/images/admin/reports.png
Added : /trunk/Themes/default/images/admin/scheduled_tasks.png
Added : /trunk/Themes/default/images/admin/search.png
Modified : /trunk/Themes/default/images/admin/support_and_credits.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/styles/admin.css
Title: Re: New revs
Post by: Nao on July 5th, 2011, 10:25 AM
rev 836
(5 files, 7kb)

* French translation updates and fixes. Sorry, couldn't bring myself to delete the admin intro, only commented it out. Also deleted the support_resources string since it's no longer showing anything (for now at least.) (Admin.template.php, Admin.language.php, ManageSettings.french.php, PersonalMessage.french.php)

- Removed support resources text, since it was no longer in the language files... (Admin.template.php, Admin.language.php)
Title: Re: New revs
Post by: Nao on July 6th, 2011, 12:16 AM
rev 837
(5 files, 7kb)

! Classic Permission headers looked odd. (ManagePermissions.template.php)

! Fixed bug in determineVersions(). (admin.js)

* Two lines become one. Very moving. (Subs-Admin.php)

* Current Wedge version is 0.1, not 1.0 Alpha. (Security.language.php)

(As always, most of my day's work isn't ready for a commit, being linked to changes in index.css and sections.css...)
Title: Re: New revs
Post by: Arantor on July 6th, 2011, 12:01 PM
Yay, a changelog that's probably bigger than its changes. But still, things that bugged me.


Revision: 838
Author: arantor
Date: 11:01:04, 06 July 2011
Message:
! The support block in the admin sidebar shouldn't be linked to anything now, especially not a page that doesn't exist any more. (Admin.template.php)
! Minor layout fix to the items in the admin area, it was bugging me how everything was misaligned. (Yes, the placeholder icons are *still* misaligned, but they're not my main problem!) (admin.css)
! The feed block in the sidebar should have more spacing than it did. (index.css)
----
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/styles/admin.css
Modified : /trunk/Themes/default/styles/index.css
Title: Re: New revs
Post by: Arantor on July 6th, 2011, 02:57 PM
Another relatively minor set of changes, but I'd rather keep changes like this encapsulated in case we revert them later.

Revision: 839
Author: arantor
Date: 13:57:37, 06 July 2011
Message:
! If the mail queue is disabled, don't provide the mail queue page. (ManageMail.php, Admin.php)
! Minor tweaks to the server settings page - widen the from-email box, and give a ? description to the webmaster email option. (ManageServer.php, Help.english.php)
! "Allow users to turn off word censoring" shouldn't be a theme setting, it makes no sense for it to be, so I relocated it to the Censored Words area. (Admin.english.php, Admin.french.php, Themes.english.php, Themes.french.php, Profile.template.php, Settings.template.php, Admin.template.php, Subs-BBC.php, ManagePosts.php, install.sql)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on July 7th, 2011, 12:46 AM
AAAAND... The big commit! Comment away! Compare with the demo site!

rev 840
(6 files, 22kb) (Wait, what... ONLY 22kb?!?! REFUND!!!)

* Changed menu animation to show it coming from below, rather than from above. (index.css, script.js)

* Many, MANY styling changes... Documenting them in order of appearance in the index file. Also please read the notes for suggestions. (index.css)

  * Main font was changed from Verdana to Arial.

  * Left and right borders are now black with a subtle gradient at the top. Main content padding was adjusted accordingly. (Also index.ie6.css)

  ! Fixed margin on first title header in sidebar.

  ! Fixed link color in sidebar for 'Unread posts' etc.

  ! Sidebar could be shown below other elements in some situations.

  ! Fixed details in the top section. (Also index.ie6.css, index.ie7.css)

  + Renamed $big_font to $head_font (font for bigger text like headers), and added $menu_font (menu font), for more flexibility.

  * $head_font is set to PT Sans by default.

  - No longer showing the Wedge logo in the upper header. The Wedge triangle in the footer is enough in my opinion.

  - Removed orange lines in the header and footer (leaving them in .cat), and replaced them with grayish lines that are the exactly median color between the wine shades and white.

  * Linktree color set to gray when not clickable, e.g. "Moderator" mention.

  * Changed footer link colors and layout.

  * An easter egg comment was actually wrong. Just rewatched this and fixed the quote. I think it's worth mentioning that I'm serious even about the stupid stuff.

  * A slightly more readable legend for fieldsets in the admin homepage. Note: IE6 screws up the background in all situations. Ah well.

  - Removed border from .wrc class, e.g. topic posts. Actually I just commented it out... Just in case.

  * Reset text color in windowbg to #444 instead of pure black. It doesn't hurt readability, and with ClearType it really renders more smoothly.

  * Changed windowbg color to light gray. Note: original was #f9f6f0. It MIGHT be better than the new one... Needs some testing.

  * Input buttons now get a forced height, to compensate (a bit) for cross-browser inconsistency.

  + Added a subtle gradient to input buttons.

  * Changed selected top menu items to be in the same rounded box than hover effects, instead of looking like they're connected to the bottom. This is due to inconsistencies in IE and Safari Mobile. And frankly it got old quickly anyway. Should be either made stronger, or removed entirely. Which I did.

  * Forcing a height on menu items, because, once again, of browser inconsistency...

  * Submenu are now vertically aligned with the top menu's gray bottom border. It's a detail but it's important.

  * Changed selected top menu item background from orange to dark greenish. Subtle is the new black.

  - No longer forcing smalltext classes to use the default font family.

  * Changed background color for quotes, and chose alternating colors to match their parent windowbg.

  * Moved post font definition to sections.css.

  - Couldn't find a reason for overflow:auto to be applied to dd tags at this point.

  * dfn tags now styled with default font.

  ! Renamed #rss to #feed. (Note: this is why it failed for you, Pete. I had yet to commit that.)

  * Category headers now use Arial on links. (In case you have PT Sans installed. Which is unlikely. Oh well.)

  * Extra padding for icons in category headers. I'm sure it'll fail in some browsers though... Been there done that.

  * More changes on text styling in headers.

  * Very subtle changes on mini-header styling (h6 tag) and button lists.

* Now going for the many changes in section.css, which is basically index.css for specific areas of Wedge. (sections.css)

  * Board names in board index now use $head_font.

  * Added proper padding around stats in the homepage sidebar. (Also index.ie6.css)

  * Moderator links now use the default font.

  * Restyled previous/next topic links. Still not happy though...

  * Restyled #top_subject. This totally breaks the usual $head_font setting though...

  * Ensure that topic titles (as reproduced in individual posts) get properly broken with a text ellipsis if the browser supports it.

  * Now using display: table on the title/date/actions header in individual posts. This is totally gonna break some browsers... (Also index.ie6.css, index.ie7.css, index.ie8.css)

  * Also using $head_font on user names now, in both posts and profiles.

  * Forcing Verdana on user menu items. Again, it breaks the self-imposed standard, but I've gotten used to that one... Uh. Can be changed, after all.

  * Moved Split Topic and Merge Posts buttons to the right of the action list. They should have been together from the beginning, even though they're not directly related. Also fixed horizontal icon alignments.

  * Setting a maximum height and overflow on the smiley box, as promised.
Title: Re: New revs
Post by: Arantor on July 7th, 2011, 01:21 AM
Revision: 841
Author: arantor
Date: 00:21:11, 07 July 2011
Message:
! Remove the option for 'enabling mark as read'. Not only does it really not need to be optional, it really really didn't need to be a theme option. (install.sql, upgrade.php, Display.php, MessageIndex.php, BoardIndex.template.php, Recent.template.php, Settings.template.php, Themes.english.php, Themes.french.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on July 7th, 2011, 02:03 PM
rev 842
(5 files, 7kb) -- and with this, ALL of my files are committed. Except for Subs.php though -- JSE rewrite is on hold.

! Variable name typo in installer. (install.sql)

+ Added a first-post class to the first post in a topic. (Display.template.php)

! Silly me... Forgot to commit the other changes to the Display page. (Display.template.php)

* French translation and minor English rewording. (Help.language.php)

- Removed some no-longer-used classes from the media area. (media.css)
Title: Re: New revs
Post by: Nao on July 7th, 2011, 07:45 PM
rev 843 - aka the "I didn't plan to work on that AT ALL today..." commit.
(13 files, 21kb)

* Rewrote quote, code and php BBCode to use HTML5 header and footer tags, harmonize their markup altogether and provide the ability to style the entire quote/code/php area, e.g. get the same width in headers and footers as in quote boxes. The code parser in install.sql is a bit hackish, but the original wasn't very clean to begin with. Oh, and it's untested in Warm and Wuthering. (install.sql, ssi_examples.php, bbc_test.php or whatever, Printpage.template.php, index.css, index.ie6.css, report.css, sections.css, Warm/index.css, Wuthering/index.css)

* Cleaner way of alternating quote colors. It doesn't work in IE6, but *who* exactly cares about alternating quotes in IE6? Get a life! (Subs-BBC.php, index.css)

* 'Last Modified' field is now shown in a much less obvious font color, by popular request (that is, one person. And me. Don't deny it, I'm popular. Chicks dig me.) (sections.css)

! 'on' was repeated twice in quote tags, because of the use of on_timeformat(). (install.sql)

! The French translation for 'Quote' in the quote boxes was 'Citer'... The actual verb. Reminds me of the $txt['reply'] bug report I made years ago, ahh... Good times. Well, time to fix that, innit? (install.sql, index.language.php)
Title: Re: New revs
Post by: Arantor on July 8th, 2011, 04:29 PM
Revision: 844
Author: arantor
Date: 15:28:23, 08 July 2011
Message:
! Remove RDF type feeds too. (Feed.php)
----
Modified : /trunk/Sources/Feed.php
Title: Re: New revs
Post by: Nao on July 9th, 2011, 01:14 AM
rev 845
(5 files, 7kb)

* Rewrote quote tag styles to something more... Err... Classy. (index.css)

+ Added missing files to the version list. (other/xml/detailed-version.php)

! Added a safety against endless loop if CSS variables are referencing each other. (Class-CSS.php)

! Media area was still using the deprecated loadClassFile() at one point. (Subs-Media.php)

! Cancel-type buttons now sport a gradient, just like other buttons. (index.css)

! Menu background was not actually using $menu_bg variable... Oopps. Still need to get back to using $main_bg, $head_bg, $footer_bg, $board_col and $sidebar-width, which were used in Warm but not in Wine. (index.css)

* Changed windowbg color to use the same background color as the sidebar. Looks pretty good. Maybe not definitive, though. (index.css)

@ Note: quote tag css isn't definitive, but it's 95% of what I was looking for (at least in my current state of mind.) Please tell me whether you like it or not!
Posted: July 9th, 2011, 12:55 AM

Important!

Forgot to mention this in the SVN changelog. So I'm adding it here:

- Removed 'Last post' mention from Recent posts. (Recent.template.php)

Years and years and years after this was implemented, SMF still has it. But what it's showing is the date of the post listed right below the date. it is NOT always the LAST message in the topic. So it really doesn't mean a THING! :^^;:
Title: Re: New revs
Post by: Nao on July 9th, 2011, 04:36 PM
rev 846
(3 files, 8kb)

- From last rev (forgot to document it): Removed 'Last post' mention from Recent posts. (Recent.template.php)

* Renamed custom CSS "gradient-background:" to just "gradient:", as it's unlikely to be mixed up with Safari's old "gradient()" function. And honestly, I was lost myself as to what the exact name of the rule was. (Class-CSS.php, index.css, media.css)

* If showing a top-down gradient through the gradient rule, don't bother printing 'top', as it's not required. (Class-CSS.php)

* Some slight changes to the quote box styling. Trying Lucida Sans as quote headers. (Class-CSS.php)

@ Note: I'm working on removing the SMF type of feed data. Also, looking into a workaround for the <author> tag in the RSS specification... Didn't even know they made it mandatory to use an e-mail address in these. A godsend for spammers ;)
Title: Re: New revs
Post by: Nao on July 10th, 2011, 08:22 PM
rev 847
(3 files, ??kb)

+ Added a $modSettings['feed_root'] variable, automatically set to $scripturl on the first use of a feed, which should serve as a 'permanent' root for Atom feed IDs even after a domain move. (Feed.php)

! Pretty URLs weren't used at all in feeds. Although <guid> would best be left alone, the old PURLs mod from SMF converted them, so for now we'll convert them as well... (Feed.php)

! Indenazi in the original dumpTags call and a comment. (Feed.php, Subs-Boards.php)

- Removed some extra code for the deprecated SMF feed type. A few lines left to delete. (Feed.php)

! Although this warrants further research regarding the usefulness of parsing an entity-encoded item, I cdata-parsed a few things that needed some harmonizing there. (Board names, author names, etc.) (Feed.php)

* Trebuchet MS is an acceptable fallback for quote box headers. (index.css)



rev 848
(1 file, 6kb)

! Fixed the category bug in feeds. Also made schemes non-required (and prettified if present), because it's hardly semantic in our case. (Feed.php)

* Don't bother cdata-parsing a string if it has no objectionable content. (Feed.php)

! category labels shouldn't be cdata-parsed, and instead protected against double quotes. (Feed.php)
Title: Re: New revs
Post by: Nao on July 11th, 2011, 12:15 AM
rev 849
(1 file, 6kb)

* Atom's id field now uses a UUID for id entries, calculated from the original URL of the item. It's actually a single md5 call so it's really a UUID, but FWIW feed readers won't notice the trick. (Feed.php)

- Deleted a few unused variables from the feed code: num_replies, id_first_member, first_subject, first_poster_name. (Feed.php)

- Removed even more SMF feed code. Put inside parenthesis the rest of the code to be removed. (Feed.php)

@ Pete, feel free to remove the remainder of the commented out code. The only reason I didn't finish this is because I'm falling asleep right now. I don't believe there's anything we need to keep -- or, on the contrary, we could concatenate all of the extra profile info into the description field in Atom and RSS feeds. Whatever you like best...
Title: Re: New revs
Post by: Arantor on July 11th, 2011, 12:58 PM
Revision: 850
Author: arantor
Date: 11:58:15, 11 July 2011
Message:
! Move the IM fields into custom field templates. While there are slight changes to formatting, it *should* work out OK; I tested using the newer links and still got the information I should have had... (ManageSettings.php, ManageSettings.english.php, Admin.template.php, facebook.png, steam.png, twitter.png)

@todo: Add a couple more fields (PSN, XBox Live), remove the existing fields.
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/facebook.png
Added : /trunk/Themes/default/images/steam.png
Added : /trunk/Themes/default/images/twitter.png
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on July 12th, 2011, 09:56 AM
Revision: 851
Author: arantor
Date: 08:56:12, 12 July 2011
Message:
! Add a time gate to registration. First visit to the registration screen should force a limit of 10 seconds on filling the main form out, if you have any errors, that limit should be reduced to 5 seconds on returning the form. There is, presently, no limit on accepting the registration agreement (should there be one?) (Register.php, Errors.english.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Title: Re: New revs
Post by: Nao on July 12th, 2011, 11:29 AM
rev 852
(3 files, ??kb)

- Right now, I don't believe custom CSS browser prefixes are disabled once the proper rule is implemented[1], so why not save a few bytes off the final files and prevent browsers from giving CSS errors? (Subs-Cache.php)

! Slightly incorrect way of handling $data in getXmlProfile(). (Feed.php)

! Code tags would get incorrect header styling when used within quote tags. Reordered styles to avoid that. (index.css)

* Changed code tag background to adapt itself to any windowbg colors, while retaining the blueish color. (index.css)

* Changed h6 tag (used notably as mini-headers in the credits page) to use the Corbel font on Windows 7 systems. Also increased letter spacing to, hmm... Give peace a chance. Probably gonna change my mind later. Seriously though, Corbel and Calibri are nice fonts, and they have a larger install base than PT Sans, so I should do something with them. (index.css)
 1. I actually spent some time trying to find details about that but found nothing online about it, so I guess they keep compatibility options on.
Title: Re: New revs
Post by: Arantor on July 12th, 2011, 11:35 AM
Revision: 853
Author: arantor
Date: 10:34:48, 12 July 2011
Message:
! All instances of setcookie should now be indicating to use httponly. (Since we're using PHP 5.2, there's not even the effort required to make a compatibility function.) (smf_api.php, Poll.php, Security.php, Subs-Auth.php, SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/other/tools/smf_api.php
Title: Re: New revs
Post by: Nao on July 12th, 2011, 02:33 PM
rev 854
(8 files, 13kb)

! Regexp error in the Facebook custom field array. (ManageSettings.php)

! Admin settings use windowbg2 as the default background. (Admin.template.php)

* Validation & indentation nazi. (Admin.template.php)

* Made it a bit clearer (uh, in my fashion...) that the registration error is due to you being a spambot. And also something that bothered me with the Facebook string (again.) (Errors.english.php, ManageSettings.english.php)

* French translation. (Errors.french.php, ManageSettings.french.php)

* Something I'm not sure about, waiting for feedback... Help popups will automatically attempt to retrieve the string they're about, and will reproduce it at the top of the popup. (script.js)

- Removing border color on fieldset legends with windowbg. Maybe it was a tad too much... Adding a border to help popups though. (index.css)

- Back to square one for the h6 tag. Worked well in the credits page, but not anywhere else. (index.css)
Title: Re: New revs
Post by: Nao on July 12th, 2011, 06:58 PM
rev 855
(4 files, 8kb)

* Moved the admin search box outside of the header, and re-introduced an admin welcome message next to it, this time focusing exclusively on navigational help, or whatever. (Admin.template.php, Admin.language.php, admin.css)

(Just a small feature, I'm adding it separately in case you want to revert it, Pete. Although I'm positive it makes the homepage look less busy.)
Title: Re: New revs
Post by: Arantor on July 12th, 2011, 11:59 PM
Revision: 856
Author: arantor
Date: 22:53:38, 12 July 2011
Message:
! Removed the ICQ/AIM/Y!IM/MSN fields from the core; they're now only available as custom profile fields. Really no big loss.

Did also rearrange the last of the strings and tied one up. Hopefully I got the French version right too.

Note that I've left the icons in because they're still usable for now but I'm going to clean them up too shortly. (install.php, install.sql, smf_api.php, Feed.php, Load.php, ManageMembers.php, ManageSettings.php, Memberlist.php, Profile-Modify.php, Register.php, Subs-Members.php, Display.template.php, Admin.english.php, Admin.french.php, Help.english.php, Help.french.php, index.english.php, index.french.php, ManageSettings.english.php, ManageSettings.french.php, Profile.english.php, Profile.french.php, ManageMembers.template.php, Memberlist.template.php, PersonalMessage.template.php, Profile.template.php, Who.template.php)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/smf_api.php
Title: Re: New revs
Post by: Arantor on July 13th, 2011, 02:13 AM
Revision: 857
Author: arantor
Date: 01:13:03, 13 July 2011
Message:
! Remove custom fields from being in core features, and have it just behave naturally as part of the system. Interestingly there is absolutely no performance change involved. (install.sql, Admin.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php, feature_cp.png)

! Random legacy $smcFunc call we missed (Search2.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Themes/default/images/admin/feature_cp.png
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on July 13th, 2011, 09:33 AM
Revision: 858
Author: arantor
Date: 08:32:41, 13 July 2011
Message:
! Move all the field icons into their own little folder. (ManageSettings.php, fields/*)
----
Modified : /trunk/Sources/ManageSettings.php
Deleted : /trunk/Themes/default/images/aim.gif
Deleted : /trunk/Themes/default/images/facebook.png
Added : /trunk/Themes/default/images/fields
Added : /trunk/Themes/default/images/fields/aim.gif
Added : /trunk/Themes/default/images/fields/facebook.png
Added : /trunk/Themes/default/images/fields/msntalk.gif
Added : /trunk/Themes/default/images/fields/steam.png
Added : /trunk/Themes/default/images/fields/twitter.png
Deleted : /trunk/Themes/default/images/msntalk.gif
Deleted : /trunk/Themes/default/images/steam.png
Deleted : /trunk/Themes/default/images/twitter.png
Title: Re: New revs
Post by: Nao on July 13th, 2011, 12:01 PM
rev 859
(19 files +4-4, 42kb)

* Renamed Stylings to Skins. Renamed Styles folders to Skins. Renamed settings.xml to skin.xml. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, TEMPLATES: index, ManageBoards, Themes, LANGUAGES: ManageBoards, Themes, SKINS: index.css)

* Moved moderatorbar inside the post area, to facilitate its styling. Err... Yes, what? I'm currently working on it. (Display.template.php)

! Who crapped into our source code? Fixed a weird bug in the version retrieval code. (Themes.php)

@ To svn readers: rename 'styling' to 'skin' in the member and board tables, go to the admin area > Themes and Layout > Manage and Install, and hit Save.
Title: Re: New revs
Post by: Arantor on July 13th, 2011, 01:38 PM
Revision: 860
Author: arantor
Date: 12:38:19, 13 July 2011
Message:
! More admin panel reorganisation: Maintenance is now Server & Maintenance, and Server Settings and Mail live in there (reducing their prominence as they're less commonly used settings), auto embedding is now under Forum, and Media's Maintenance is now also under the Server & Maint. area. Also, auto embedding is no longer in Core Features, but controlled by its own page (in line with the other stuff), which means pretty much going back to AeMe's own code in that respect. (Admin.php, Admin.template.php, Admin.english.php, ManageMedia.english.php, ManageSettings.english.php, ManageSettings.french.php, feature_e.png)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/media/ManageMedia3.php
Modified : /trunk/Themes/default/Admin.template.php
Deleted : /trunk/Themes/default/images/admin/feature_e.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on July 13th, 2011, 06:14 PM
rev 861
(8 files, 20kb)

+ Added separators to submenu items, slightly reordered a few entries, and fixed a logic issue in the menu cleanup code. (Admin.php, Subs-Menu.php, GenericMenu.template.php)

! Information box was too small. (ManagePaid.php)

* Added rounded corners to the admin homepage fieldsets, but it doesn't work well in Opera... Ah well, if it's an Opera bug, I'm not gonna prevent other browsers from showing these. (Admin.template.php)

* Refined Pretty URLs admin area. Made it clearer what the cache option is for (until now, it wasn't even obvious that disabling it would still keep PURLs enabled.) (Admin.template.php, Admin.language.php, admin.css)

* French translation fixes in the admin area. It had a tendency to use words like 'Réglages' a bit too much where 'Paramètres' made more sense. Also, the 'Forum' menu area is called 'layout' internally, so the French translation had 'Apparence'. Since Pete moved the Theme options to another menu area, it was time to reflect the change in the French version as well... (Admin.french.php)
Title: Re: New revs
Post by: Nao on July 13th, 2011, 07:20 PM
rev 862
(6 files, 9kb)

* Minor details and fixes for the separator code. (Admin.php, GenericMenu.template.php)

- Why are we adding a class for something that's not even useful? (Admin.template.php, admin.css)

! Just because I spent months on that silly translation already, doesn't mean I don't have to keep improving it. (Help.french.php, Profile.french.php)
Title: Re: New revs
Post by: Nao on July 14th, 2011, 12:57 AM
rev 863
(5 files, 11kb)

* Rewrote uuid code in Atom feeds to instead use a tag URI (RFC 4151), in the form "tag:domain.com,2011-07-01:msg-7". It may not be the definitive code, but it's better than a UUID. Also removed the last compatibility code block. Really no need for that... (Feed.php, QueryString.php)

! Typo. (Help.french.php)

* In a world where war rages on every day, I believe it's important to say 'Hello' rather than 'Hi'. Who is Wedge to say you want to say Hi when you may not even know who you're talking to? (ManageSettings.language.php)


@ Note: totally unrelated... It appears that not many people tested the automatic quote splitter :P It fails badly when pressing Enter after a self-closed tag such as more, media etc. Also fails horribly when splitting URL tags. Okay, is anyone ever testing my crappy code? :P
Title: Re: New revs
Post by: Nao on July 14th, 2011, 06:40 PM
rev 864 (another big one!)
(36 files, 37kb)

* Rewrote the post layout for topic views. Ohhhh yeah. Now using display: table and sporting more freedom. Will fix IE6 and IE7 later. If they're nice enough. Also, section.css could probably use some cleaning up. (Display.template.php, sections.css)

* Rewrote JavaScriptEscape() to avoid escaping tabs and newlines. Also gave up on escaping tag closers, as I couldn't find any single reason for doing so. And using shorter hacks for script, href and scripturl situations. (Subs.php)

* Renamed global smf_* Js variables to we_*, and smf_scripturl to we_script, as it's used more often, so might as well have it shorter. (various other/* files, editor.js, mediadmin.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js, Admin.php, TEMPLATES: index, ManageMembergroups, Packages, Post, SplitTopics, Themes)

* Moved registration center next to the member list in the admin menu, as semantically it's closer to that, than to the permission/ban stuff. (Admin.php)

! Avoid duplicates in closed tag list when doing the split quote thing. Needs a rewrite though. (Class-Editor.php)

* Indenazi, Pretty URL replace buffer cleanup and other useless changes. (Subs.php, ManageMedia.english.php, post.js, index.css)

! Event delayer was systematically doing a failed bind() for each and every event in the page. Oops, my bad. (Subs.php)

- sScriptUrl and sImagesUrl are never used (or never useful) in a couple of JS objects. (Display.template.php, Media.template.php, topic.js)

* Renamed admin menu entry 'Reports' to 'Detailed Reports'. I think it should help differentiate it from moderator reports. I always get confused by this. (Admin.language.php)

* Updated French translation. (Admin.french.php, ManageMedia.french.php)

! It's Rank images, not Stars. (ManageMembers.language.php, Reports.language.php)

! Fixed toggler in the email settings page. Note: we need to turn this into a PROPER Wedge toggler... (ManageNews.template.php)

* Various script.js changes that may or may not be reverted later: a semi-fix for reqWin title retrieval (doesn't actually work on text nodes, uh...), and a hack to prevent Firefox from fixing the reqWin event. (script.js)

! Apparently, Firefox 5 (and earlier?) doesn't like when jQuery creates a hidden input and adds a name param separately. Fixed by putting the name into the tag string itself. (suggest.js, topic.js)
Posted: July 14th, 2011, 05:09 PM

rev 865

! Typo crash. (Admin.php)
Title: Re: New revs
Post by: Nao on July 14th, 2011, 09:28 PM
rev 866 (another big commit... U mad bro?)
(16 files, 27kb)

* Moved user box template to its own function. (Display.template.php)

* Subtle changes to the post box to please Pete, err, to make it less crowded. (sections.css)

* Boldly attempting to remove the border around fieldsets in the admin homepage. Only there, eh. Makes the page less... crowded, you got it. (index.css)

! Media embedder still had a deprecated table align. Ouch. (Subs-Media.php)

! In some situations (namely Wedge rewriting the tab_data stuff with its own data to finetune tab positions), Wedge would fail noticing that it shouldn't be trying to show a context menu item. (GenericMenu.template.php)

- As far as I know, $txt['attachment_log'] is not used anywhere. (Admin.language.php)

* Ugly warning in Attachment/Avatar admin area. (ManageAttachments.php, Admin.language.php)

* Log pruning area has long descriptions in French, so I added bold tags around the actual names of the logs. (ManageSettings.french.php)

* Indenazi. (Subs-Menu.php)

* Large cleanup in the Log admin area. spider logs lost their plural, all log menu entries are now repeated (once for their in-context menu entry, once for the Log menu area, enabling to drop the 'log' part of the name and keep the context menu on a single line in French and other long languages), renamed pruning_title to log_pruning, etc. (Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin.language.php, Search.language.php, ManageSearch.template.php)
Title: Re: New revs
Post by: Nao on July 14th, 2011, 11:45 PM
rev 867
(6 files +1, 11kb)

* More changes to the topic view. Both Report to Moderator links are now in the user box, with the main one getting its own (temp) icon. And it no longer shows on user's own posts (which always baffled me because sometimes they'd use this as a way to draw attention on their own posts.) Also reworded 'Report to moderator' to 'Report this message to a moderator', because hover titles can be longer, right? (Display.template.php, report.gif, index.language.php, sections.css)

* Nothing interesting. (PersonalMessage.english.php, ManageNews.template.php)
Title: Re: New revs
Post by: Arantor on July 15th, 2011, 08:48 AM
Revision: 868
Author: arantor
Date: 07:48:22, 15 July 2011
Message:
! Some more icons for the admin panel. (Admin.php, *.png)
! Minor tag mismatch in the credits page. (Credits.php)
+ Added ability for icon copyrights to be displayed in the credits too. Feel free to edit or mash up if you don't like it, but we should be attributing where appropriate. (Credits.php, Who.english.php, Who.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Themes/default/Who.template.php
Added : /trunk/Themes/default/images/admin/about.png
Added : /trunk/Themes/default/images/admin/addon_manager.png
Added : /trunk/Themes/default/images/admin/addon_settings.png
Added : /trunk/Themes/default/images/admin/current_theme.png
Added : /trunk/Themes/default/images/admin/custom_fields.png
Added : /trunk/Themes/default/images/admin/media_maintenance.png
Added : /trunk/Themes/default/images/admin/mediasettings.png
Added : /trunk/Themes/default/images/admin/news_and_newsletters.png
Added : /trunk/Themes/default/images/admin/search_engines.png
Added : /trunk/Themes/default/images/admin/serversettings.png
Added : /trunk/Themes/default/images/admin/smileys.png
Modified : /trunk/Themes/default/images/admin/themes_and_layout.png
Modified : /trunk/Themes/default/languages/Who.english.php
Title: Re: New revs
Post by: Nao on July 15th, 2011, 09:31 AM
rev 869
(8 files +3-3, 18kb)

! Never noticed that before, but the main content was misaligned in floating sidebar mode. (index.css)

* Don't show « » in Last edit, and show it in italics only through CSS. (Display.template.php, sections.css)

* Say "Last edited" instead of "Last edit", since it's followed with "today", "yesterday" or "on Date". (index.english.php)

* Renamed some bigicons to keep underscore consistency. (ban_list.png, media_settings.png, server_settings.png, Admin.php)

* The admin area's placeholder icon should be at the same size as the rest... (Admin.template.php)

* Translation, or lack thereof. (Who.french.php)
Title: Re: New revs
Post by: Arantor on July 15th, 2011, 10:41 AM
Revision: 870
Author: arantor
Date: 09:41:22, 15 July 2011
Message:
! Added an alternative hostname resolver that should be faster on most systems with no noticeable change in quality of result (and won't hit timeouts the same way gethostbyaddr does if the address is non-existent) (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on July 15th, 2011, 05:01 PM
rev 871
(6 files, 14kb)

+ Added ability to position message user boxes to the right of the post, instead of the left. Defaults to the right for now (opposite the sidebar.) (Display.php, Display.template.php, sections.css)

* Improved AeMe image embedding styling. (media.css)

* Repositioned down arrows in the main menu a pixel further down, because it felt a bit misaligned. Only a bit really. Also saved a few bytes by not re-including menu.gif, which was already included for h4 tags. (index.css)

* Some profile options had finishing periods, when surrounding options didn't. (Profile.english.php)
Title: Re: New revs
Post by: Nao on July 15th, 2011, 11:39 PM
rev 872
(7 files, 32kb)

- AeMe code was still using reqWin(this.href). Although technically still all right, we don't need to specify the ".href" anymore... (Aeva-Gallery2.php, ManageMedia2.php, Media.template.php)

! Applied youtu.be fix to thumbnail retrieval. (Aeva-Embed.php)

* Rewrote title retrieval code for help popups. Now works on all of the help links I could think of. I'm not going to test them all, eh... Hopefully we'll rewrite this mess of an admin area later. (script.js)

* Serious update to the help popup language files. Hardcoded titles were removed. Quote entities changed to double quotes. Double spaces made single again. Updated SMF and simplemachines to Wedge where expected. Rewrote time_format and custom_mask help popups to be actually usable, and to fix many inconsistencies in the descriptions. Fixed some "users" to users' or user's. (Someone was having problems with their English grammar.) (Help.english.php, Help.french.php)
Title: Re: New revs
Post by: Nao on July 16th, 2011, 12:10 PM
rev 873
(8 files, 10kb)

* Turned media banning's findmember into an auto-suggest. More to come. (ManageMedia2.php)

! Media banning language string fixes. (Admin.language.php, ManageMedia.language.php, ManageMedia.template.php)

! Javascript trimmer was being incorrectly implemented, should have been $.trim($()), not $().trim(). Hey, what did you expect. (script.js)

* Moved .windowbg/2/3 background colors to $winddow_bg/2/3 variables. (index.css)
Title: Re: New revs
Post by: Nao on July 16th, 2011, 10:46 PM
rev 874
(31 files, 37kb)

* Renamed smf_prepareScriptUrl to we_prepareScriptUrl, and removed the parameter. It was systematically we_script anyway... BTW, I think I spotted a SMF bug in the multilingual readme selector for packages. (index.template.php, Packages.template.php, Post.template.php, SplitTopics.template.php, Themes.template.php, editor.js, mediadmin.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js)

* Rewrote Jump To box to use pretty URLs when they're enabled. (Ajax.php, Xml.template.php, script.js)

- Simplified Jump To parameters and removed lots of static vars. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php, script.js)

- Removed Jump To from the Search area. Did anyone actually notice there was one in there...? Yup, just what I thought. (Search2.php, Search.template.php)

* Renamed Jump To to Quick Access. UI stuff, you know. I'm not paid a million bucks a month for nothing. BTW, I'm still waiting for my first check. (index.english.php, index.french.php)

* Rewrote Jump To/Quick Access (okay, it's the last time I'm talking about this) to get rid of the "Go" button. To ensure one can still access the current board (which can be done through the linktree next to it anyway), Wedge no longer fills in the current board name separately. Instead, it emphasizes it with a different background color. The rewrite also allowed me to save nearly 300 bytes off the gzipped size of the script file. Yay for me. And I removed the IE hack because, well, it didn't work. Who cares about IE glitches. (script.js)

* Moved Legend icons to the sidebar in Unread Replies and Unread Topics. (Unread.php, Unreadreplies.php, Recent.template.php)

- Class quickbuttons already implied reset and smalltext. (PersonalMessage.template.php, Post.template.php, Profile.template.php, Recent.template.php, Search.template.php)

! Class quickbuttons (again) should only be a table cell in topic view, otherwise it doesn't render well in Recent Posts. (sections.css)

* Slightly modified design for the post title and jump to boxes in topic view. (sections.css)

! In the search box's ignored board list, if you didn't have many boards the layout was odd. (Search.template.php)

- Removed #topic_icons definitions, no longer used. (index.ie6.css, index.ie7.css, sections.css)
Title: Re: New revs
Post by: Nao on July 17th, 2011, 08:09 PM
rev 875
(7 files, 12kb)

* Instead of 'My Community', Wedge will now set a default non-generic name for your board at install time, based on the URL. For instance, installing it "http://wedge.org/forum/" will automatically name it "Wedge Forum". (install.php, Install.language.php)

! e.keyCode is not standard. jQuery has e.which. (MessageIndex.template.php)

! Found a more 'semantic' workaround for the reqWin event fixer. I still don't want to force recording the current event in delayed events. (script.js)

! Wrong variable name (event should be e). (topic.js)

* Changed menu background again to add the gradient effect back into it. This is now officially the most crowded design I've ever seen for a menu. I'll be right back after my seppuku. (index.css)
Title: Re: New revs
Post by: Nao on July 18th, 2011, 03:54 PM
rev 876
(12 files, 29kb)

+ Added support for separators in the main menu. (Subs.php, index.template.php)

* Merged the Admin and Moderate menus. Now admins will no longer have to deal with that silly Moderate button, everything is added to the admin menu below a separator. (Subs.php, sprite-menu-32bit.png, sprite.png, index.css)

* Shortened 'Unapproved posts and topics' to just 'Unapproved posts'. Really, it's the same... (index.language.php)

* Made the main menu background a bit more uniform. (index.css)

* Forgot to rename wedge_news in a few places. Also gave the 'we' prefix to admin objects. Also fixed JS errors in the moderation center. (latest-news.php, Admin.php, Admin.template.php, ModerationCenter.template.php, admin.js)
Title: Re: New revs
Post by: Nao on July 19th, 2011, 08:19 PM
rev 877
(7 files, 23kb)

+ Added an 'action menu' that is for individual posts what the user menu is for post authors. Moved 'report to moderator' to that menu. Work in progress (although it works fine as it is.) (Display.php, Display.template.php, index.language.php, topic.js, sections.css)

! Undefined $php_errormsg. (Load.php)

@ Sorry for the slightly hackish solutions in sections.css, Display.php and topic.js... These were the simplest ones I could devise. Also should point out that for design consistency, I reused the quickbuttons styling on the user menu -- i.e. it now uses uppercase Trebuchet MS instead of normal Verdana. Still unhappy with text alignments, but it's hard to do something 'clean' when you have to use background-image to add icons... :-/
Title: Re: New revs
Post by: Nao on July 20th, 2011, 01:03 AM
rev 878
(3 files, ??kb)

* Reordered internal array for action menus, added a placeholder for link hover titles, and turned the 'click' member into 'custom', as it could be used for anything really. (Display.php, topic.js)

! mouseleave event didn't work correctly on user menus with the 'right-side' class applied to them. (topic.js)

* Even more hacking to prevent right-aligned user menus from animating the links inside them. Using float:right instead of text-align:right does the trick, although it also forces us to use the overflow:hidden clearfix, as well as some careful reordering. Gotta love CSS in those moments... (sections.css)

@ I still don't know if you guys like this all... I mean do you think it's better with or without the action menu?
Title: Re: New revs
Post by: Nao on July 20th, 2011, 08:51 PM
rev 879
(3 files, 14kb)

* Merged the two mini-menu objects (user, action) into a single one, saving about 1.2KB in the process. Gets a tad confusing though... Should try and make the two menus more similar internally. (topic.js)

* Moved profile icons to their own function. (Display.template.php)

* Minor display template changes. (Display.template.php)

! Selector inheritance bug in mini-menu. (sections.css)
Title: Re: New revs
Post by: Nao on July 20th, 2011, 10:29 PM
rev 880
(3 files, 12kb)

* Converted user menus to use the same object structure as action menus. Saves about 300 bytes in the topic.js file, but it's mostly for the slight benefit of readability. (Display.php, Display.template.php, topic.js)

! Minor jQuery error with opacity animation. (topic.js)

@ I think I'm done with these menus... Might just wanna add icons to the user menu, now.
Title: Re: New revs
Post by: Nao on July 21st, 2011, 12:41 AM
rev 881
(8 files, 14kb)

+ Added icons to the user menu. Uh. Actually, only one really... But at the least code skeleton is here. Also swapped class contents between list items and anchors in mini menus. (Display.php, Display.template.php, sections.css)

- Couldn't find the reason why there were non-semantic span tags inside mini-menu calls. So I removed them, because that's who I am. (TEMPLATES: Display, PersonalMessage, Post, Profile, Recent)

! Fixed icon positions in mini-menu. (topic.js)
Title: Re: New revs
Post by: Nao on July 21st, 2011, 11:42 PM
rev 882
(1 file, 7kb)

* More size optimizations for mini-menus (an extra 100 bytes saved.) (topic.js)

* Also made a few things clearer. Overall it should now be easier to write a fallback for non-JS by writing all of the code through PHP instead. (topic.js)
Title: Re: New revs
Post by: Nao on July 22nd, 2011, 11:01 PM
rev 883
(6 files, 10kb)

+ Added buttons for all of the currently available user menu items. Some are temp. Someone please find something worthy for them... And possibly move some of these icons to index.member.css -- at the very least, 'Send PM' and 'Add to buddies'! (Display.php, sections.css)

! Website links didn't work in user menu, because of extra quotes in them. (Display.php)

! $user_info['url'] was incorrectly set up in boards and topics when pretty URLs were used. As a result, the quick language change link would always redirect to the upper level. (Load.php)

* Spacinazi. (Profile-Modify.php)

! Member titles in user boxes used the title header styling, because of the ambiguous class name (li class="title"). (Display.template.php)

- Main forum header doesn't need a font size class to be set, as it's overridden in CSS anyway. (index.template.php)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 11:01 AM
rev 884
(4 files, 12kb)

+ Added $message['has_buttons'], which can be modified in the per-post hook ('display_post_done'). Allows you to add action menu buttons without too much of a hassle. Well, eventually at least... (Display.php, Display.template.php)

! User and action menus were incorrectly viewed as never empty on non-guest posts, and thus failing some tests for guests or users without any permissions. (Display.php)

* Moved buddy and PM buttons to the member CSS, saving some bandwidth for guests. (index.member.css, sections.css)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 12:50 PM
rev 885
(3 files, 5kb)

! SMF bug when handling admin membergroup. Thanks live627! (ManageMembergroups.php)

* Signatures didn't have enough breathing room at the bottom. (sections.css)

* Linktree array was being counted once, plus once for each linktree entry. Reduced this to only once overall. (index.template.php)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 01:39 PM
rev 886 -- aka the 'is_last' commit. Easy to revert, just in case...
(6 files, 8kb)

- Removed 'is_last' element from contextual tabs. They were only used in SMF 1.x themes, dropped in SMF 2.0, and these can be re-introduced easily through hooks. If anyone needs them, at least... (ManageBans.php, ManageErrors.php, ManageMembers.php, GenericMenu.template.php)

- Removed 'is_last' element from generic menus. They weren't used either in Wedge, and were pretty buggy. (1) $first_sa was tested for emptiness at a point where it could never be empty. (2) Current, first and last entries were set twice -- once during the main loop, and once after the loop was finished. (3) First and last entries in a submenu were swapped if in RTL mode. Since when does RTL include 'bottom to top'...? (Subs-Menu.php)

- Removed 'is_last' element from the main menu. Pretty much the same reason... Also fixes another SMF bug: $last_button ($last_item in Wedge) is set but never used, and is_last is unset in some situations but never reset elsewhere. (Subs.php)

! The Media tab in the main menu shouldn't show a submenu if it's only going to show a repeat of the top link... (Subs.php)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 08:43 PM
rev 887
(23 files +2-1, 50kb)

* Renamed reporttm action to report, as the word 'report' itself wasn't taken... Also added a temp Report button. (index.php, unit test, Display.php, Report.php, Subs.php, Display.template.php, SendTopic.template.php, Errors.language.php, index.english.php, Who.language.php, sections.css, report.png)

* Started renaming the warning system in the French translation. I was always bothered by its lack of coherence. "Report" is now "Avertir" instead of "Signaler", while "Issue warning" becomes "Sanctionner" instead of "Avertir". Also improved/fixed translation.
(Errors.french.php, Help.language.php, index.french.php, ManagePermissions.french.php, ManageSettings.french.php, ModerationCenter.language.php, Modlog.french.php, Profile.french.php, Reports.french.php)

* Renamed a couple of credit categories. (Who.language.php)

! The Remove button in the action menu was pretty broken. (Display.php)

! Rev 880 typo introduced a bug in the user menu regarding user vs post IDs. Blame copy & paste. (Display.php, Display.template.php)

! The IP icon had a help icon behind it. Fixed by renaming its class to helpc (for 'help cursor'). Also a shameless plug for multiple inheritance, ah ah. (Display.template.php, index.css, sections.css)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 11:53 PM
rev 888
(4 files, 8kb -- an appropriate size, dare I say.)

! Apparently, the Atom feed implementation was written around the time Atom 0.3 was out. Version 1.0 changes the modified tag to updated, and tagline to subtitle. Updated Wedge to use them. Also switched from summary tags to content tags, because as the name implies, summary should be for post extracts, not entire bodies. (Feed.php)

! Fixed RSS implementation bug: language should be specified in the language tag, rather than xml:lang (RSS is not proper XML so it doesn't officially understand that.) (Feed.php)

* Added a comment about the fact that pubDate for items is for RSS 0.93 and RSS 2.0, thus it renders the RSS 0.92 feed invalid. (Not that I'm not planning to remove it anyway...) (Feed.php)

* Top-level submenus are now horizontally aligned on their parent's label, rather than their icon. I guess it's something that could warrant a discussion, but apparently it's not a fascinating subject, so I'll just leave it at that. I probably should rewrite the menu code to make it simpler at this point. (script.js)

! Updated Trophy icon (used in the stats area) to fit in the same dimensions as the other icons on the page. Approximately, at least. (stats_posters.gif)

! Report button had too much padding on the right. (sections.css)

@ When will the bug fixing end? :P
Title: Re: New revs
Post by: Arantor on July 25th, 2011, 04:22 PM
Revision: 889
Author: arantor
Date: 15:21:08, 25 July 2011
Message:
! IP address unformatted if logged as a failed-admin-login-attempt where the IP address was in the body of the error. (Subs-Auth.php)

! Moving numeric formatting strings to the language files rather than a single global variable that was even wrong by default (1234.00 is not the format normally used in the US) (install.sql, Load.php, ManageSettings.php, Subs.php, Help+index+ManageSettings language files)

! Removing the ban log as part of removing the ban system generally (install.sql, repair.php, Admin.php, Class-DBPackages.php, ManageBans.php, ManageMaintenance.php, ManageSettings.php, ScheduledTasks.php, Security.php, Subs-Members.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/repair.php


w00t one less table! More to disappear too, inevitably.
Title: Re: New revs
Post by: Arantor on July 25th, 2011, 05:29 PM
Revision: 890
Author: arantor
Date: 16:29:09, 25 July 2011
Message:
! Improve how timezones are handled, namely: 1) Don't try forcing use of Etc/ legacy timezones that are actually confusing by nature anyway, but actually attempt to query for proper timezone instead of estimating, 2) ensure an actual timezone will be set even if we don't have one in the DB for any reason as a fallback, 3) improve the selector in the admin panel to limit to only the regions of interest. (install.php, Load.php, ManageSettings.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Nao on July 25th, 2011, 07:14 PM
rev 891
(13 files, 20kb)

- Don't call JSE on mini-menu strings that won't be shown in the first place. (Display.php, Display.template.php)

* Harmonized string names for mini-menus and added descriptions to all of them. Removed all related strings that weren't used anywhere else. (Display.php, index.language.php, topic.js)

! Fixed Close button not showing up on zoomed items when double-clicking them (happened only if no further zoom level was available.) (zoomedia.js)

! The number of new PMs was being tested twice per page. Removed it from the menu array, and kept the one in the menu builder. (Subs.php)

* New PM indicator was ugly (red text on dark background), replaced it with the usual 'New' icon. (Subs.php, index.css)

* Replaced New icons with versions that don't show white pixels around them on dark backgrounds. Uh. (new.gif)

* IE details. They're still heavily broken. I don't care for now. (index.ie6.css, index.ie7.css)

- Removed .postarea { margin: 0 0 0 15em }, as it's useless in display:table mode. This will, as you guessed correctly, break IE6 and IE7 even more. And again: I don't care for now. I'll fix that when I feel like it. (sections.css)
Title: Re: New revs
Post by: Arantor on July 25th, 2011, 09:29 PM
Revision: 892
Author: arantor
Date: 20:27:35, 25 July 2011
Message:
! First use of the proposed number_context function to aid in i18n of language strings. I've applied it to the board index and message index for the number of posts, topics and redirections for each board, with an appropriate 'No topics' type string for 0, which just looks nicer to me. (Subs.php, BoardIndex.template.php, MessageIndex.template.php, index.english.php)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/index.english.php


Yup. I finally implemented this sucker. It is a touch more elaborate than my original - because it also calls on comma_format while it's at it, meaning the language string has to have a %s in the right place for the numbers. But there are examples of this now!!
Title: Re: New revs
Post by: Nao on July 26th, 2011, 12:13 AM
rev 893
(7 files, 11kb)

* Cleaned up more DELETE FROM entries. Inspired by the latest commit. (ManagePermissions.php, ManageMedia2.php, Subs-Media.php, ScheduledTasks.php, Subs-Scheduled.php)

* French translation. Also, I believe our separator for floating point is a comma, not a period. (index.french.php)

* One-liner replacement for number_format. I'm sorry, I'm just like that. Please don't look at me that way. (Subs.php)
Title: Re: New revs
Post by: Nao on July 27th, 2011, 10:44 AM
rev 894
(13 files, 13kb)

* Modified error log's code previewer to show only 30 lines instead of 20[1] and use a monospaced font instead of the default. This ensures we get the entire preview without triggering a vertical scrollbar, improving usability. (ManageErrors.php, Errors.template.php, admin.css)

* Rename 'buddies' to 'contacts' in the English version, and other minor changes. To do: asymetrical contacts. (LANGUAGES: index, ManageSettings, Packages, PersonalMessage, Profile, Who, Wireless)

* Do not show "Age: N/A" in profiles if no age was specified. Just hide the line entirely. It's a waste of time, bandwidth and intelligence. (Profile.template.php)

! allow_no_censored should be tested through !empty(), as is often done. Not that it'll have any influence on a properly installed Wedge, but it's always been done this way with $modSettings, so we should harmonize it. Either add !empty() everywhere, or remove them everywhere. Considering updateSettings() is optimized for a systematical use of !empty(), it might also warrant a rewrite. (Profile.template.php)
 1. I meant '30 lines instead of 40'. Changelog error, sorry.
Title: Re: New revs
Post by: Nao on July 28th, 2011, 01:08 AM
rev 895
(8 files, 10kb)

! Whitespace trimmer in BBC parsing code was broken. (Subs-BBC.php)

* encodeURIComponent() has been supported as far back as IE 5.5, so there's no reason to use SMF's way of emulating it (string.php_tp8bit().php_urlencode()). (Packages.template.php, Post.template.php, editor.js, register.js, script.js, suggest.js, topic.js)

* php_strtr uses charAt when it could use [] instead. It's a bit faster, which is good in long loops. (script.js)

@ Note: there are two extra escape() calls in PM and Search templates, followed with unescapes. I'm letting them be for now because they're testing for %u in the URL, which only happens in escape()'d strings. I can probably just change the test to % alone... What do you think Pete? I haven't tested this.
Title: Re: New revs
Post by: Nao on July 28th, 2011, 12:42 PM
rev 896
(2 files, 9kb)

* Since php_strtr, php_strtolower and php_to8bit are only used in sha1.js, moved these functions to the correct file, saving 1.5kb (0.5kb gzipped) off the final cached file. If any mod wants to use them -- just include sha1.js in your stuff or copy the functions. I'm not forcing extra bandwidth use for logged in members. (script.js, sha1.js)

! The reason why charAt() is being used instead of [] is because IE6/IE7 don't support this. My bad, I thought they were decent browsers. Nah, just kidding, we all know they suck. Well, since php_strtr is only used in password encryption, it's not like it needed any optimization anyway. (sha1.js)

+ Added headers to the JS files. Well, at least we should start to do it. (script.js, sha1.js)
Title: Re: New revs
Post by: Nao on July 29th, 2011, 12:58 AM
rev 897 (a small one before going to bed...)
(4 files, 7kb)

* Replaced the very last escape/unescape calls with encodeURIComponent/decodeURIComponent. They're better suited for URL encoding. (PersonalMessage.template.php, Search.template.php)

* Removed {db_prefix}members:media and added {db_prefix}messages:id_parent. Both are unused, but id_parent can be used later for building a threaded view. (install.sql)

! If a timezone has no slash in it (such as 'UTC'), the timezone retrieval code will generate a warning. (ManageSettings.php)
Title: Re: New revs
Post by: Nao on July 29th, 2011, 08:21 PM
rev 898
(4 files, 7kb)

* More JavaScript function changes. Deleted php_addslashes (never used anywhere), moved easyReplace from script.js to post.js (it's only used by the smiley manager), turned _replaceEntities into an anonymous function (as it's only used by removeEntities). (post.js, script.js)

+ Added ability to call a regular popup window in reqWin, as opposed to an Ajax popup. (script.js)

! Fixed media button to call a popup window, as it's a two-step process and the second page wouldn't load in the Ajax popup. (Aeva-Gallery.php, editor.js)

@ Note: I wanted to use an iframe or something cooler than a popup window, but hey... Nobody ever complained about the AeMe popup in the first place, so why bother/waste time on this. As long as it works...
Title: Re: New revs
Post by: Nao on August 1st, 2011, 01:56 PM
rev 899
(11 files, 12kb)

* Upped the minimum PHP version to 5.2.3, so we can use the double_encode parameter on htmlspecialchars(). (install.php, readme_*.html, webinstall.php, upgrade.php, Class-String.php)

* Changed is_integer() to is_int() or a version that's approximately twice faster, (int) $number === $number. (smf_api.php, Class-String.php, Aeva-Subs-Vital.php)

* jQuerification of packman's file permission page. (Packages.template.php)

! Fixed folder icon alignment and padding in file permission page. (Packages.template.php)

@ NB: big commit today, so I'm splitting it in two. The next one will be there in a few.
Title: Re: New revs
Post by: Nao on August 1st, 2011, 02:00 PM
rev 900
(7 files, 14kb)

+ Added format_comma parameter to number_context(), allowing to disable comma formatting in specific cases. (Subs.php)

+ Optimized comma_format() to skip the (albeit very fast) number_format() call if the number is an integer (no decimal separator) and has less than 4 digits (no thousands separator). Performance is about 25% slower if the test fails, and 400% faster if it succeeds. (Subs.php)

! Searched PM messages didn't show the number of users in a replied PM, unlike other areas in Wedge. (PersonalMessage.php)

- Deleted wedge_checkReplied, as it was basically an early draft of number_context(). (PersonalMessage.php)

* Number of moderator reports now uses number_context(). (index.template.php, index.language.php)

* draftAutoPurge now uses number_context(), as originally intended. (PersonalMessage.template.php, Profile.template.php)
Title: Re: New revs
Post by: Arantor on August 1st, 2011, 02:49 PM
Revision: 901
Author: arantor
Date: 13:49:16, 01 August 2011
Message:
! First part of handling timezones from user perspective, there's no interface for it yet but it works from the database. (install.sql, Load.php, ManageSettings.php)

! The title derived from the current URL should not have a leading space. (install.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on August 1st, 2011, 05:55 PM
Revision: 902
Author: arantor
Date: 16:52:27, 01 August 2011
Message:
+ Provide the ability for people moving a topic to set how long the topic redirection notice stays in place for. (MoveTopic.php, MoveTopic.template.php, Subs-Scheduled.php, index.english.php)

! Miscellaneous layout bug in the move topic template, due to overwide dd forcing wrapping rather than floating. (sections.css)

! Miscellaneous bugs in the imperative scheduled system (Load.php, Subs-Scheduled.php)

! The recount-reports function is sometimes going to be run when permissions aren't loaded (namely during scheduled/imperative tasks), make sure the mod cache is loaded in that circumstance. (ModerationCenter.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/skins/sections.css



@ This isn't really finished, it's just at a convenient stopping place. The default is 1 day simply because it's at the top of the list, not because it's set that way - but that's actually an improvement in usability terms to the previous version IME. I haven't decided about allowing admins to set a default yet.

@ See also the discussion about dealing with redirections automatically; the way I solved it in the redirection topics mod I originally wrote was a separate table. Given the minimal approach I wanted to SMF modding at the time, this was the closest I could get, and it would only clean up once per day rather than actually as needed, so the individual table was useful then.
Title: Re: New revs
Post by: Nao on August 1st, 2011, 10:13 PM
rev 903
(9 files, 11kb)

* Don't show a submenu on mail settings (admin area) if the mail queue is disabled. (Admin.php)

! Fixed accidental revert from the last timezone commit. (ManageSettings.php)

* Changed 'Mail' label to 'Email Settings' in the Server & Maintenance admin menu. (Admin.language.php)

* I thought it would be amusing if the redirection topic strings actually used number_context()... (index.language.php, MoveTopic.template.php)

* Very minor fixes/changes. (ManageMedia.template.php, sections.css)

* French translation. (index.french.php)
Title: Re: New revs
Post by: Nao on August 2nd, 2011, 01:02 PM
rev 904
(6 files +2, 18kb)

* Changed wedge_type field name to board_type. At this point I'm unsure we'll keep the 'wedge' terminology for boards and blogs, so there's no point in adding more confusion. (install.sql, Load.php, RemoveTopic.php)

+ Re: my post 257238(http://wedge.org/pub/6538/plugin-hooks/msg257238/#msg257238) at the forum, implementing 'before', 'after' and 'override' generic hooks for all template functions. The total overhead is no more than a millisecond per page. Needs more work. (Load.php)

! Resetting global locale scope to LC_TIME instead of LC_ALL, to avoid issues in the CSS parser. Although we could have fixed that directly in the parser, we're never far away from meeting more issues, so for now we'd rather remain compatible with the SMF method. (Load.php)

+ Added index.php dummy files for a couple of folders that missed them. (images/fields, images/theme)

! Typonazi. (Install.french.php)
Title: Re: New revs
Post by: Arantor on August 4th, 2011, 03:05 AM
Revision: 905
Author: arantor
Date: 02:04:48, 04 August 2011
Message:
! Removed several settings that irritate me in the admin panel:
- Current theme / Show BBC buttons in PM and Post Pages; you'd control this from the BBC and smileys areas instead. (Class-Editor.php, Settings.template.php, Admin.*.php)

- Go up/down buttons (on by default instead now) (ManageSettings.php, ManageSettings.*.php, Help.*.php, Display.template.php, MessageIndex.template.php)

- Show current position as text in linktree (I cannot seriously imagine anyone actually using this. It sort of defeats the point of a *link* tree.) (upgrade.php, Settings.template.php, Themes.*.php)

----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on August 4th, 2011, 03:09 PM
rev 906
(10 files, 15kb)

+ Added ability to disable prev/next links in page index[1]. This is mostly useful in the message index. (MessageIndex.php, Subs.php)

! A couple of columns were wrongly colored in the admin member list. Also fixed comment typos and optimized styles/classes. (ManageMembers.php)

! Use $context['start'] instead of $_REQUEST['start'] in the message index. (MessageIndex.php)

- Deleted 'list_menu' and 'use_tabs' generic list features, as they're not used in Wedge. Or even in SMF, actually. (Subs-List.php, GenericList.template.php)

! Logic error in media admin JS, as well as a useless .each() call. (mediadmin.js)

- Removed another useless .each() call, this time for img.resized. (theme.js)

- Removed two unused footer classes and a useless ic_login. (index.css, index.rtl.css, sections.css)

+ Added a max-width for images. Should think of a better solution... (index.css)
 1. When calling the function, I mean. That is, it's internal to Wedge.
Title: Re: New revs
Post by: Nao on August 5th, 2011, 05:39 PM
rev 907
(7 files, 11kb) <-- much less than the time spent on it, comparatively :P

- Deleted stupid addLoadEvent() and rewrote the last couple of items that still used it to use better equivalents ($(window).load() and add_js). (install.php, upgrade.php, Subs.php, script.js, theme.js)

! When hovering out of a top-level menu entry with no submenus attached to it, it would remain highlighted for a second because the hover class was being removed from the wrong element. (script.js)

! Fixed one remaining occurrence of a wrong $.trim() implementation. (script.js)

* Simplified version retrieval at install time. (install.php)

* Changed the default minification process to Packer. I figure if modders can't make it work on a default install, they'll be more cautious about this whole semicolon issue, and I'd rather have to deal with modder issues than with user issues once they enable Packer. (install.sql)

- Removed outdated holidays from the calendar. (install.sql)

* Keep-alive timeout should be using a function name rather than a string. Same for the toggler object and menu_hide_me at one point. (script.js)

* Plenty of minor cleanup operations. (editor.js, script.js)
Title: Re: New revs
Post by: Nao on August 6th, 2011, 11:35 AM
rev 908
(9 files, 12kb)

- Removed site list's ability to self-update, as I don't see myself updating it outside of the main software's updates themselves. You can update manually from further Wedge updates, obviously. Also removed some outdated code that checked for new Aeva Media versions. (Aeva-Embed.php, ManageMedia.php, ManageMedia3.php, Subs-Media.php, ManageMedia.language.php, Media.language.php)

* Casenazi. (PersonalMessage.php)
Title: Re: New revs
Post by: Nao on August 7th, 2011, 09:54 AM
rev 909
(29 files +5-5, 104kb)

* Replaced $forum_version with WEDGE_VERSION constant. It was already defined, just not used. This eliminates the need to globalize $forum_version each time you need it. Version number also gets rid of the 'Wedge' element. We only want a number! (index.php, install.php, smfinfo.php, upgrade.php, current-version.php, detailed-version.php, Calendar.php, Class-DB.php, Credits.php + Who template collateral, Feed.php, ManageMaintenance.php, ManageMedia.php, ManageServer.php, PackageGet.php, ScheduledTasks.php, Subs-Package.php, Subs.php, index.language.php, Packages.template.php)

* More renaming of SMF to Wedge in versioning and things like that, like fixing and optimizing the JS for the detailed version page. It was all very messy to begin with and it's done across this commit and the next anyway. (Install.language.php, admin.js...)

* Renamed Findmember to FindMember, Jseditor to JSEditor, Jsoption to JSOption, Printpage to PrintPage and Unreadreplies to UnreadReplies. Both for function names and file names. The next commit will fix the filenames (due to a SVN limitation.) (index.php, temp.*.php)

* Simplified admin JS object, by shortening some ridiculously long variable names and hardcoding version compare DOM IDs. Who would change them anyway?! SMF2 has a tendency to encourage the multiplication of settings when it should instead be deciding whether or not something is likely to be changed in the future. (Admin.php, admin.js)

* list (), not list()... (upgrade.sql, current-version.php, latest-packages.php, latest-themes.php)
Title: Re: New revs
Post by: Nao on August 7th, 2011, 09:59 AM
rev 910
(10 files, 12kb)

! Fixed Safari 2.x not using readOnly on form submit (heck, I'm not even sure if this bug was valid to begin with?), and optimized invertAll. (script.js)

! Helper functions should use camelCase, thanks John. (PersonalMessage.php)

* Finished version renaming stuff. (Admin.template.php)

! What was 'Wedge (originally SMF) Add-on' language string supposed to mean in the Admin area's detailed version page? It's only giving us the main version... And if it's supposed to be the version of the package that made the upgrade... Isn't it supposed to be the same? (Admin.language.php)

- Removed more of the auto-update code for AeMe. (ManageMedia.template.php, Media.template.php)

* Updated some outdated file headers. (Subs-Aeva-Sites.php, Media.language.php)
Posted: August 7th, 2011, 09:57 AM

rev 911
(0 files +5-5)

! Grmpf... Was in a hurry to grab something to eat, and forgot to rename the files like I was supposed to in rev 910. (temp.*.php)
Title: Re: New revs
Post by: Nao on August 7th, 2011, 12:49 PM
rev 912
(27 files, 26kb)

* Renamed smfVersion to weVersion and smfVersions to weVersions (also changes the smfVersion setting name in the DB, FYI). Also renamed a few rarely used global JS variables in a similar fashion. (install.php, install.sql, smfinfo.php, upgrade.php, upgrade.sql, current-version.php, detailed-version.php, latest-*.php, mirrors.xml, Class-DB.php, Themes.php, admin.js, TEMPLATES: Admin, ManageSmileys, Packages, Themes)

* Renamed remaining typeof()s to just typeof. (smfinfo.php, latest-themes.php, Aeva-Foxy.php, MessageIndex.template.php, Packages.template.php, Profile.template.php, Themes.template.php, spellcheck.js)

* Normalized all remaining keyCode calls to $.which. (MessageIndex.template.php, zoomedia.js)

- There was no reason to call smf_codeFix since it's always called as needed in the default theme anyway... (Post.template.php)

* One more variable name optimization. (script.js)

@ Note: I'm not 100% sure about documenting all of the files where typeof was changed. Who cares...
Title: Re: New revs
Post by: Nao on August 7th, 2011, 01:35 PM
rev 913
(3 files, 19kb)

* Moved media table creation from db_aeva to the regular Wedge installer. db_aeva still needs to be run at this point, but it'll soon be a thing of the past. (db_aeva.php, install.sql)

* Forgot to save the editor, where I had another keyCode to which conversion. (editor.js)
Title: Re: New revs
Post by: Arantor on August 8th, 2011, 10:34 AM
Revision: 914
Author: arantor
Date: 09:33:24, 08 August 2011
Message:
! Remove the 'make emails visible' option, it's just not needed to present emails as-is for all members (even just to other members) as an option. (All files mentioned here are related to this change, namely cleaning out the old 'yes' branch)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Arantor on August 8th, 2011, 10:52 AM
Revision: 915
Author: arantor
Date: 09:48:56, 08 August 2011
Message:
! Made the warning system permanently on, seeing how we're going to be making more use of it. Most of this is simply removing two sets of is-enabled checks. (install.sql, Admin.php, Display.php, ManagePermissions.php, ModerationCenter.php, PersonalMessage.php, Profile-Actions.php, Profile-View.php, Profile.php, ScheduledTasks.php, ManageSettings.language.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql

Posted: August 8th, 2011, 10:49 AM

Revision: 916
Author: arantor
Date: 09:52:00, 08 August 2011
Message:
! Oops, forgot to remove the warning_enabled default setting from the installer. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on August 8th, 2011, 11:48 AM
rev 917
(8 files, 12kb)

* Renamed $txt['board_topics_*'] to $txt['topics_*'] to harmonize with posts and redirects, grouped them together, and fixed the few occurrences of $txt['board_topics'] that weren't converted yet. Also removed the ucfirst on processed Posts, Topics and Redirects, since they're guaranteed to have a number before them. (SSI.php, BoardIndex.template.php, MessageIndex.template.php, index.language.php)

! add_js() was using a wrong restarter CDATA, oops. (Subs-Cache.php)

* Some tweaks to the user box. (sections.css)

* First topic post now sports a slightly larger font to differentiate it from the rest. Best used in blog posts. (sections.css)

* Testing other fonts for topic posts. Readability is vital here, and Arial 14px, as cool as it is in the UI, may not be the most suitable for posts. (index.css)
Title: Re: New revs
Post by: Nao on August 8th, 2011, 06:37 PM
rev 918
(13 files, 16kb)

! Aeva auto-embedding should now be applied only to popular sites by default (until you fine-tune the admin settings). This saves about 0.1s per call to parse_bbc(). (Aeva-Embed.php, ManageMedia3.php)

! self:: doesn't seem to work on public static functions. Using the object name instead. (Class-String.php)

* Removed these websites from the Popular embed list (not actually that popular these days): Bebo, Imeem, Truveo. (Subs-Aeva-Sites.php)

* Moved these websites to the Popular embed list (according to Alexa ranks): Break, Hulu, Last.fm (Audio). (Subs-Aeva-Sites.php)

* Spacinazi. Ternary operators are always processed after == :) (Feed.php, Subs-Auth.php)

* Moved a long comment out of a function. (Security.php)

* Okay, I give up for now... Back to Verdana for posts for now. In terms of readability, it's hard to do better on an imported SMF forum, otherwise it's too much of a change. For now. (index.css, sections.css)

* Now calling number_context in board index and in-topic stats, for the number of replies and views. (Display.template.php, MessageIndex.template.php, index.language.php)

- Had a remaining board_topics call. (MessageIndex.template.php)

@ Note: I would really appreciate if someone could take some time and look into video site popularities. Or even test the current state of Aeva embedding -- do all sites work as expected, etc. I wonder if I really should have sites like MySpace Videos or video.msn.com in the popular list... Do people embed these often?
Title: Re: New revs
Post by: Nao on August 8th, 2011, 07:39 PM
rev 919
(3 files, 5kb)

! Error when no news lines were filled in. (Subs.php, index.template.php)

* Spacinazi. (Subs-BoardIndex.php)
Title: Re: New revs
Post by: Nao on August 9th, 2011, 04:16 PM
rev 920
(32 files, 45kb)

* Updated 'div ul.buttonlist' to 'ul.buttonlist'. Saves some space. (index.template.php, index.css, sections.css, topic.js, Media.template.php)

* Updated the button strip visuals to something a tad less gloomy. (sections.css, index.rtl.css, media.css)
* Harmonized and simplified approvebg, stickybg, lockedbg. Also cleaned up half a dozen unused classes. (index.css, sections.css, index.rtl.css, media.css, Wuthering/sections.css, Display.template.php, MessageIndex.template.php, Recent.template.php)

* Harmonized pagesection divs, and turned pagelinks into .pagesection nav. (Aeva-Foxy.php, Aeva-Gallery2.php, Media.language.php, TEMPLATES: Display, GenericList, ManageMedia, ManageMembergroups, Media, Memberlist, MessageIndex, ModerationCenter, PersonalMessage, Profile, Recent, Reminder, Search, SplitTopics, Who)

! Undefined $merge_safe variable in some situations. (Display.php)

! Fixed text colors in viewquery mode. (ViewQuery.php)

- Removed the default 'right' parameter from button strips when still used. (TEMPLATES: BoardIndex, Calendar, PersonalMessage, Recent, Reports)

- References to .align_* classes were left in. (Reminder.template.php)

! SMF bugs: if a topic is stickied and locked, the Search template won't generate the correct class. Also, the template never actually uses it... (Search.template.php)

* Spacinazi. (Profile.template.php, Xml.template.php)
Title: Re: New revs
Post by: Nao on August 10th, 2011, 06:15 PM
rev 921
(3 files, 6kb, not a very interesting commit I know...)

* Renamed cache keys to use Wedge instead of SMF. There are going to be a lot of minor renames like this overall... (Subs-Cache.php)

! Category headers could be pushed to the right (e.g. by the menu) when reducing the window width. (index.css)

* Approve button was a bit off, too. (sections.css)
Title: Re: New revs
Post by: Arantor on August 11th, 2011, 01:59 PM
Revision: 922
Author: arantor
Date: 12:58:49, 11 August 2011
Message:
! Mismatched tags in the who's viewing sidebar template in message index. (MessageIndex.template.php)

! Time to be controversial; removing meta keywords. Most forums have them turned off, the ones that don't have global keywords that don't help, and major search engines don't use them anyway, so it's actually work that isn't needed. (Subs.php, ManageSettings.php, index.template.php, ManageSettings and Help language files)

! Added general facility for meta description support, now to be used in the message index and more places in future. (index.template.php, MessageIndex.php)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on August 11th, 2011, 05:14 PM
rev 923
(5 files, 7kb)

+ Added ability to load a CSS file in the header even after that header has been filled, e.g. from within parse_bbc(). (Subs-Cache.php, Subs.php, index.template.php)

* Minor tweaks to the post button bar. (sections.css)

* Harmonized text color on button strips. (sections.css)

! Mismatched curly brace. (GenericList.template.php)
Title: Re: New revs
Post by: Nao on August 13th, 2011, 04:36 PM
rev 924 (and that's not even the big commit... :whistle:)
(15 files +1, 20kb)

- Replacing seldom used we_images_url JavaScript variable with we_theme_url + '/images'. (index.template.php, ManageMembergroups.template.php, Themes.template.php, suggest.js, register.js)

* Minor fixed to post page button layout. (sections.css)

* Spacinazi. Please note that 'input_attr' now expects an extra space. I'm not wasting CPU cycles on just two specific form entries. (Register.template.php, Profile.template.php, Profile-Modify.php)

! Harmonized descriptions for smileys and smiley-based topic icons. Also fixed bad French translations for these. (index.language.php, Install.language.php)

+ Added the Edit smiley to the Aaron smiley set. (edit.gif)

* Smileys that are not installed by default in the visible postbox area should be in the popup, rather than hidden. (install.sql)
Title: Re: New revs
Post by: Nao on August 13th, 2011, 07:42 PM
rev 925 (and there it is... now we're talking.)
(11 files, 47kb)

* Rewrote the smiley handling system. Parsed smileys now use a div enclosing the actual smiley code. Benefit #1: copying and pasting text will retain smileys as text code in all browsers (SMF limits it to Firefox). Benefit #2: the most used smileys can now be encoded into the CSS, resulting in very fast loading times. As a note, the WYSIWYG editor will still use image tags to show smileys, otherwise navigating smileys through keyboards wouldn't work as well. (Class-Editor.php, ManageSmileys.php, Subs-BBC.php, editor.js, post.js)

+ Added aforementioned cache for BBC tag images. Should work across different smiley sets and browsers, using the same settings as the regular CSS cache. (Subs-BBC.php, Subs-Cache.php)

* Micro-optimized the editor JS code to take less space in the page (replacing objects with arrays, etc.) Because the editor code is unlikely to be changed (much) by mods, and because we now tend to add it even in topic pages, it makes sense to compact it, especially for uncompressed HTML pages where we save over 3 kilobytes. The js files also saved a kilobyte, and about 200 bytes once gzipped. (Class-Editor.php, editor.js, post.js)

- Removed smf_smileys_url (no longer used.) (Class-Editor.php)

- Removed some code that assumed $modSettings['smileys_dir'] and smileys_url weren't set... Probably some SMF1 compatibility code, because it's always set in Wedge. (ManageSmileys.php)

* Removed $txt['icon_laugh'] as it's not a 'default' smiley per the editor code. Added $txt['icon_edit'] because it is. (Subs-BBC.php, Class-Editor.php, index.language.php)

* Rewrote clean_cache to accept any kinds of extensions, instead of their 3 last characters. (Subs-Cache.php)

! clean_cache was broken when specifying extensions, as it used the wrong variable name. (Subs-Cache.php)

* Harmonized JS code for "Object.prototype.function = function ()". Oops, I mean 'spacinazi'. (editor.js, pm.js, post.js, suggest.js, topic.js)

* Moved the Delete button in File attachments to the left, for feng-shui reasons. Also fixed bevel in the button, although I have a feeling it'll break in Safari again... Also, did anyone notice that the input form button is never disabled, even when kindly asked to do so..? (post.js)

@ Note to Pete: maybe the file input should be hidden, as opposed to disabled....?

:edit: I updated Safari to v5.1, and the bug I mentioned is finally gone. So it's all good now... Only problem is, smileys don't show up in the editor :lol: Another bug I'll have to fix...

:edit: 2 - Postbox smileys are buggy in IE (all versions including 9), and Safari. They work well in Chrome, Firefox and Opera, the 'good guys'.
Title: Re: New revs
Post by: Nao on August 14th, 2011, 06:26 PM
rev 926
(26 files -1, 36kb) (........yet another big commit.)

* The 'more' button in smiley rows should now be on the right, and clicking it will show the new smileys through a slide animation. (Class-Editor.php)

* Now generating the smiley cache for each different different, allowing for IE6 to skip base64-encoded smileys. Also skipping the bigger smileys (>4KB), because we're only here to save bandwidth, not play with base64. (Subs-BBC.php, Subs-Cache.php)

! SMF bug (with no impact on code logic though): $smileyPregSearch is a string, not an array! (Subs-BBC.php)

* Renamed 'smiley_*' to 'smiley *' and thus moved smiley CSS logic to the main CSS file, in order to save some data (approx. 200 bytes after compression, by default.) (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)

* Reintroduced code to disable smiley resizing in Firefox... Unfortunately, it doesn't work. Tried TinyMCE, CKEditor and a few others -- same issue, so I guess Firefox is to blame. Bad Firefox, baaad! (Class-Editor.php)

! Fixed a last-minute bug that prevented Wysiwyg smileys from being converted correctly. (Class-Editor.php)

! Fixed editor to still load the CSS for smileys, even if parsesmileys() is never called on the page. What a load of code just for that... (Class-Editor.php)

* More silly JS code simplification. What can I do, I'm a sucker for micro-optimizations... (Class-Editor.php)

* Commented out a function that isn't used for now in the Zoomedia code. Will need to convert it, really... (Aeva-Subs-Vital.php)

* Renamed smfRegister to weRegister. (Profile.template.php, Register.template.php, Reminder.template.php, register.js)

- Removed profile.js, as it was a bit too short to be justified at this point. (Profile.template.php, Register.template.php, profile.js)

+ Added proper Wedge headers to all JS files that didn't have it. (admin.js, captcha.js, editor.js, fader.js, pm.js, post.js, register.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, zoomedia.js)

! Fixed smiley padding in Wysiwyg editor. (editor.css)

* Generic buttons should have a more generic background color, if you ask me. (index.css)

! More robust image replacement technique for smileys. (sections.css, index.ie6.css, index.ie7.css)

! Fixed bug with code tag fixer in Firefox. (theme.js)

* Spacinazi. (ManageMedia.template.php)
Title: Re: New revs
Post by: Nao on August 15th, 2011, 01:07 AM
rev 927
(6 files, 15kb)

+ All of the default smileys are now accessible in the post editor by default. Heck, aren't they worth it? No? (Class-Editor.php)

! In some situations, the smileys wouldn't show up in the post editor smiley box, because of an incorrect link tag. (Class-Editor.php)

! Some css cache filenames were incomplete because I forgot to update an integer after renaming the css folder. (Subs-Cache.php)

! Validation error. Since when can't inputs be put inside paragraph tags, already...? (Post.template.php)

* Updated file list, for whatever it's worth. We won't be using that file anyway. (xml/detailed-version.php)

! Did some tweaking on Warm and Wuthering skins to give them more personality, notably by changing the font. (Warm/index.css, Wuthering/index.css)
Title: Re: New revs
Post by: Nao on August 15th, 2011, 10:09 PM
rev 928 (this one was committed by Pete, who forgot to post it here........ :whistle:)
(7 files, ??kb)

! Move some of the member specific stuff (general options, plus signatures and profile fields) into their own entry in Members area, instead of under Features and Options. I gave the new settings their own file because ManageSettings is enormous - even now it's still 800 lines, as opposed to 2000. (Admin.php, Admin.template.php, Admin.english.php, ManageMemberOptions.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php)

rev 929 (this one is mine...)
(8 files, ??kb)

! Fixed Warm: background color for hidden sidebar and user menu, removed bullets, right-floated the avatar, and removed a couple of extra empty lines from the main menu. (Warm/index.css)

! Don't bother to base64-encode smileys if gzip is not supported by the browser, as it'll take too much space. (Subs-Cache.php)

! Ensure the Actions pretty URL filter doesn't cannibalize the Profiles filter by being run before it. (ManageSettings.php)

* Unencoded smiley URLs should be relative, not absolute. (Subs-Cache.php)

* Nanosecond optimization. (PrettyUrls-Filters.php, Subs-PrettyUrls.php)

* Terminology (temp?) fix. (Admin.language.php)

* Commenazi. (Post2.php)

rev 930
(2 files, 6kb)

* Translation. (Admin.french.php, ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on August 16th, 2011, 04:08 PM
rev 931
(32 files, 35kb) (most of it automated really. With a double-check.)

! Fixed right alignment of sidebar feed links in Warm. (Warm/index.css)

* Preventing horizontal overflow for code boxes. Need to find something better... (index.css)

* Renamed smc_* to we_* (or we* depending on the object), project-wide. You should now use weEditor, weAutoSuggest, weSaveEntities, weButtonBox, etc. (30 files, not listing them all.)
Title: Re: New revs
Post by: Nao on August 16th, 2011, 11:55 PM
rev 932
(39 files, 32kb -- did all of these manually... ouch >_<)

* Got rid of most display:none's and replaced them with the 'hide' class. (install.sql, Class-Editor.php, Aeva-Foxy.php, Subs.php, TEMPLATES: Admin, BoardIndexInfoCenter, Calendar, index, ManageMaintenance/Media/Membergroups/ ManageNews/Paid/Permissions/Smileys, Media, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Recent, Register, Reminder, Search, SplitTopics, Themes)

* Started converting smf_ to wedge_ or we_, or at least preparing the code for the change. Renamed smfSelectText to weSelectText. (install.sql, readme_convert.html, ssi-examples.php, upgrade.php, latest-news.php, Credits.php, ManageMedia.language.php, Who.language.php, ManageMedia.template.php, script.js)

- detailed-version.js was attempting to be included twice. Wedge didn't let that happen, but might as well not try in the first place, right...? (Admin.template.php)

- Removed smf_session_id fallback -- it's a leftover from SMF 1.0 (emphasis on the zero.) (sha1.js)

+ Although it's a hidden setting, disable_smf_js should be used consistently, including in the moderation center. I'm still leaving it out of the detailed version page, though... It would make sense not to use it there. (ModerationCenter.template.php)

@ Tomorrow: the smf_ automated update :P (Checked them all, the 700+ occurrences, should be good... Except for variables that will get reset.)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 10:38 AM
rev 933
(18 files, 18kb)

* More manual name conversions, this time from _smf to _wedge and smf_ to wedge_. (readme_convert.html, smfinfo.php, latest-packages.php, Admin.php, ManageServer.php, THEMES: Admin, ManageSmileys, ModerationCenter, Packages, Themes, LANGUAGES: Admin, ManageSettings)

- Removed utf8 parameter from the language file manager, considering all language files are now UTF8... (ManageServer.php, Admin.template.php, ManageSettings.language.php)

- SMF bug: removed unused string $txt['identification_by_smf']. (Login.language.php)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 11:01 AM
rev 934
(166 files, 100kb)

* Changed the SMF constant to WEDGE, in pretty much all files outside of the theme (automatic replacements, manually checked.) Also started converting regular SMF string to Wedge or whatever the context requires. (index.php, readm... hey, I said pretty much ALL the files, do you honestly think I'm going to list them all?!)
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 12:08 PM
Revision: 935
Author: arantor
Date: 11:04:44, 17 August 2011
Message:
! Don't allow edits of posts to have drafts; if you're editing a post, you can just resave it in situ instead, no need to keep saving drafts of it. (Post.php, Subs-Post.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on August 17th, 2011, 12:51 PM
rev 936
(68 files +1-3, 91kb)

! Forgot to convert a smf_sess. Also removed the last remaining smf_session_id, and removed a useless test. (Load.php, script.js)

- Removed a couple of outdated files and renamed smf_api to wedge_api (although I doubt we'll ever use it, just like most of the tools.) (wedge_api.php, add_settings-1x.php, boardmod.mod)

* Removed the 'Demo' version type (I don't think we're ever going to release a 'demo'?), renamed CVS version type to SVN, and removed a few CVS filename handling tests (who uses that nowadays?). (current-version.php, Class-DB.php, Subs-Package.php, Themes.php)

* Renamed smfLanguage* and smfUpdate* variables to we*. (tools, admin.js)

* Renamed smf_editorArray to weEditors. (script.js, etc.)

* Renamed smf_oCurrentResizeEditor to weCurrentResizeEditor, and smf_execCommand to we*. (editor.js)

* Renamed smf_openid_* and smf_openID_* to we_openID_*. (index.php, Login2.php, Profile.php, Profile-Modify.php, Register.php, ScheduledTasks.php, Security.php, Subs-OpenID.php)

* Changed Aeva's lookup user agent to something more browsery and with a proper URL for server admins to check. (Aeva-Embed.php)

* And finally, renamed SMF (uppercase) to Wedge wherever it was used to qualify the current software (i.e. not older versions, or proper credit.) (Dozens of files...)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 01:25 PM
rev 937
(31 files, 30kb)

* Renamed every single remaining smf_ reference to either we_ or we. Too. Tired. Won't. List. Files. (About 30)

- Removed unused $txt['cannot_connect_doc_site'] variable. (Errors.language.php)
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 02:28 PM
More admin panel stuff. Yes, the typo is there in the original log entry too :P


Revision: 938
Author: arantor
Date: 13:26:47, 17 August 2011
Message:
! Convert the 'Log Pruning' page into a more general 'Log Settings' page, and move a couple of items to it, for controlling the error log. (Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin and ManageSettinsg language files, old unit test)

! Template eval is now disabled by default. (install.sql)

! Default password strength is medium, not low, by default. Means 8 character password, no reusing username, instead of 4 character minimum. (install.sql)

! Made 'Registration' into 'Registration and Login' since some of the settings apply to both login and registration instead of some random area of the admin panel, and moved a couple of settings into it. (ManageRegistration.php, ManageSettings.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 03:29 PM
Revision: 939
Author: arantor
Date: 14:25:54, 17 August 2011
Message:
! Removal of the last vestiges of 'do not show contact details to guests, they're just not shown to guests now. (ManageSettings.php, Security.php, SendTopic.php, Help and ManageSettings language files)

! Custom fields now have an option for visible to guests (only when the field would otherwise be available to regular users), which means the profile fields that are used for things like AIM can be hidden from guests, which was the remaining thing controlled by the above setting. (install.sql, Load.php, ManageMemberOptions.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql

Posted: August 17th, 2011, 03:26 PM

Revision: 940
Author: arantor
Date: 14:29:30, 17 August 2011
Message:
! Admin / Members / Member Options had the wrong default function, should have used the first tab not the last. (ManageMemberOptions.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Title: Re: New revs
Post by: Nao on August 17th, 2011, 03:38 PM
rev 941
(12 files, 12kb)

- The Settings files shouldn't have a version number in them, as they're not intended to be upgraded later. (Settings.php, Settings_bak.php)

* A few more contextual changes from Simple Machines to Wedge. (*/readme.html, ManageServer.php, ModerationCenter.php, Themes.php, Admin.language.php)

* French translation. (Admin.french.php, ManageSettings.french.php)

! Warm's windowbg classes shouldn't really use alpha transparency, as the class is used in so many different places. Maybe I should introduce a postbg and postbg2 or something to account for topics, and have them based automatically on windowbg...? (Warm/index.css)

@ Pete: what was the typo you mentioned in 938...?
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 03:39 PM