Wedge

Public area => The Pub => Features => Topic started by: Nao on September 2nd, 2010, 02:57 PM

Title: New revs
Post by: Nao on September 2nd, 2010, 02:57 PM
Note to the Wedge audience!

What is this topic about?

It's our official changelog. Every time we commit something to the central SVN server (which retains the master copy of Wedge), we document our changes, and then we post them here.
Pete uses the SVN format to post his changelogs here, while I've been using a slightly different format (eventually adding extra line breaks to improve readability of the whole damn thing.)

As you can see below, this topic started at revision 23, so it's missing about a week's worth of changes, maybe we'll report them later.

There's already a feature list. What's the point of this topic?

The point is that we're being open about what we're currently working on. Not many people do that. They tend to keep you updated once in a blue moon. Our goal has always been to make this topic public, at least after the first alpha release. We're just making that happen a bit earlier.
We're also being honest about our blunders. Perhaps because there aren't a lot of them, eh eh. And honest about the time it sometimes takes us to implement something. Writing a new feature is not as easy as "one two three done". Sometimes you'll just give up on it for some time, come back to it, etc. I think it's an interesting way of going through our numerous changes to the original SMF codebase.
And of course, the feature list is a good thing, and pretty complete as it is, but it doesn't get updated too often.

Another point is that SMF users can finally get to know about SMF quirks we've been fixing. The feature list has an obscure entry about 'SMF bugs' being fixed. I didn't want to reveal what they were. After some consideration, I decided that they 'might as well be told'. So, if anyone has the courage to dig through the complete changelog and compile a list of SMF bugs we fixed (I always try to indicate 'smf bug' or a similar mention in the changelog when I fix one), feel free to transmit it to SMF. We personally don't give a damn about them.

So, do I need to read it?

No. Only if you're a hardcore fan. In which case you probably already had access to it before. I'd recommend you read through the changelog after rev ~750 though. That is, when I compiled the feature list. Anything done after is not in the feature list. I'll update it of course, eventually.

The topic is locked, how do I comment it?

It is locked to help with readability. We don't want to bury the changelogs in the middle of pages and pages of off-topic discussions.
There's already a private comment topic, but it's private and WILL remain so.
The official comment topic is here:
http://wedge.org/pub/feats/6803/new-revs-public-comments/
But you can create new topics or whatever you'd like.

Back to the original post!



Hmm, I don't know if it'll work, but I'll try to make a specific thread where we can post our latest rev logs, and maybe discuss them. We're already doing that in the To-do topic, but there's a long post I have to answer over there, and I don't want to forget it :P
Anyway, this is to give more visibility for our cheerleaders, who currently have no way to test the code themselves (or see it in action anywhere.)

rev 23
* Updating to SMF rev 10072 (fixes to strlen and board/topic optimizations) (changelog.txt, ManageSettings.php, News.php, Post.php, Search.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, Subs-Auth.php, Subs.php)
! Small @ hack in ManageSmileys to avoid errors when the smiley list is empty (wrong folder, etc.) (ManageSmileys.php)

--> Yeah, I ended up committing that one... Sorry, it was too tempting :lol:
Title: Re: New revs
Post by: Arantor on September 2nd, 2010, 03:12 PM
Revision: 24
Author: arantor
Date: 14:10:29, 02 September 2010
Message:
! Fix broken line endings from SMF patch (Post.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, Subs-Auth.php, Subs-Editor.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Editor.php




This proves beyond any doubt (not that I had any) that it's not your commits fudging the line endings. If it were, ManageSmileys would have been affected too.
Title: Re: New revs
Post by: Nao on September 2nd, 2010, 08:27 PM
rev 25
! Fixed remaining CR-LF files. (changelog.txt, install.php, ssi_examples.php, mailQueueCron.php, repair_settings.php, upgrade.php, Admin.php)
Title: Re: New revs
Post by: Arantor on September 3rd, 2010, 02:14 AM
Revision: 26
Author: arantor
Date: 01:12:53, 03 September 2010
Message:
+ Attempt to detect user time offset on registration (Register.php, Register.template.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php


NB This closes Ticket 10: Time zone auto detection on registration(http://wedge.org/?action=helpdesk;sa=ticket;ticket=10)
Title: Re: New revs
Post by: Nao on September 3rd, 2010, 06:05 PM
rev 28
! Fixed a potential error in $board_info['moderators'][id]['link'] ($txt is not supposed to be loaded at this point). Besides, this entry is never used as far as I know, so it might as well be removed entirely... (Load.php)

rev 29
! Incorrect indenting (Display.template.php)
! Minor spacing fixes. (Subs-Editor.php, QueryString.php, Profile-Modify.php, ManagePaid.php, ManageNews.php, upgrade.php, smf_api.php, repair.php)

rev 30
* Updated to SMF rev 10075 + minor spacing fixes. (changelog.txt, convert.php, Subs.php)
@ This needs being looked into. convert.php and Subs.php have apparently been converted to full UTF8. Is this as desired?

rev 31
* Updated to SMF rev 10083. (changelog.txt, repair_settings.php, Subs-Calendar.php)
@ This mostly moves old themes and the tools folder to their own repository. As a direct result, the tools folder is still here, and the old themes are gone, but since we'd already removed them anyway, it's all just fine.
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 12:27 AM
Revision: 35
Author: arantor
Date: 23:42:23, 03 September 2010
Message:
! Fix ARIN WHOIS lookup URL (Profile-View.php)
----
Modified : /trunk/Sources/Profile-View.php



Revision: 34
Author: arantor
Date: 23:25:25, 03 September 2010
Message:
! Encoding safe version of the legacy attachment filename function (Subs.php)
----
Modified : /trunk/Sources/Subs.php

NB this is the function I complained so bitterly about Norv breaking. This fixes it once and for all in a way that never gets broken by encoding, it's all 7-bit safe.



Not sure where rev 33 went?



Revision: 32
Author: nao
Date: 17:36:05, 03 September 2010
Message:
! CRLFs go home! (changelog.txt, repair_settings.php, Subs-Calendar.php)
----
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/changelog.txt
Modified : /trunk/Sources/Subs-Calendar.php
Title: Re: New revs
Post by: Nao on September 4th, 2010, 09:53 AM
rev 33
! Putting a windowbg block inside a windowbg2? Eh? (Help.template.php)
* Starting the wrc conversion process. Only one for now... More will follow :P (Recent.template.php)

What's the issue? Aren't you able to view the svn log?

As for rev 34 -- very interesting! I'll have a look.
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 11:45 AM
Rev 33 didn't show in the SVN log for some reason.
Title: Re: New revs
Post by: Nao on September 4th, 2010, 12:18 PM
I didn't do anything special with it, your Honour! Honest to God!
Title: Re: New revs
Post by: Nao on September 4th, 2010, 02:12 PM
rev 36
* Applied Pete's rockin' fix from Subs.php to convert.php as well. (convert.php)

(This one tends to get forgotten in the process... Maybe because now over at sm.org the tools folder is in an external repository, I don't know. "Ommit externals" is disabled in my Tortoise copy.)
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 02:13 PM
I forget about convert.php, mostly because I figure with all the changes that are going to be made, we'll end up rewriting the converter core (at least) anyway.
Title: Re: New revs
Post by: Nao on September 4th, 2010, 02:58 PM
Not a problem... When I said "forgotten", I really meant Norv didn't fix it the same way as he fixed Subs.php...
And as I wrote in my earlier rant... As unimportant a fix is, what matters is commitment. We both have it, let's keep it that way :)
Title: Re: New revs
Post by: Arantor on September 4th, 2010, 07:10 PM
Revision: 37
Author: arantor
Date: 18:09:04, 04 September 2010
Message:
+ Added unified editor class (Class-Editor.php) (for ticket 3)
! Updated editor handlers to do WYSIWYG->BBC parsing in the class rather than having the logic totally in the calling script (Post.php, PersonalMessage.php)
! Removed old functions that are no longer relevant as now part of the class (Subs-Editor.php, Subs-Post.php, GenericControls.template.php)
! Modified all the other places that used preparsecode and friends to use the class (I *think* I got everything right) (ManageNews.php, ModerationCenter.php, MoveTopic.php, PersonalMessage.php, Post.php, Profile-Modify.php)
! Updated sources and templates to use class instantiation/referencing (Post.php, Post.template.php, PersonalMessage.php, PersonalMessage.template.php)
----
Added : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/index.php


I forgot to add to the note I also updated index.php to call the class instead of Subs-Editor for the code that is used when switching between the WYSIWYG and normal editors.

What I need to do next - and I've got to out to a wedding reception, ack - is document the changes, because this is HUGE in what it changes.
Title: Re: New revs
Post by: Nao on September 5th, 2010, 01:39 AM
Wow, I totally need to read this backlog... I haven't looked into the "Bigger changes" topic yet (it's opened in a tab -- only, I have about 50 tabs open just for wedgeforum.com...!! Have to read them all!), neither have I looked into your code refactoring tickets (shame on me. Same reason.)

So, you're not much into social events either, eh? :P
[off-topic real life crap]Tonight I was at my brother in law's birthday party... Very noisy bar, very hot in there, and boring people (next time I see someone demonstrating their new iPhone, I'll be using my fists.)
I like my BIL (he lives in London and I don't get to see him a lot), but he was overcrowded today so I didn't even get to tell him a word, lol. The guy I talked for the longest (about... 10 minutes) was a geek co-worker of his who was in Paris for the first time. We discussed TV shows, the hate of commuting to London (guess why) and other things. The only 10 interesting minutes -- and it reminded me just how AWFUL my accent is. And there's no Backspace key in a muscle-powered vocal controller. God bless the Backspace key. I can fix all (most) of my English mistakes as soon as they take shape, and nobody needs to know! I'm looking forward to meeting you in the future and making a fool out of myself :D

Tomorrow I'm set to see BIL again... With family, this time. Argh. Someone, please free me from non-geeks! I bore them to death, and they return the favour with pleasure![/off-topic real life crap]
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 02:12 AM
No, I'm really not a social person.

The reason for this one is to make it much easier to build on and/or replace in the event of using something like CKEditor; now whatever we do in terms of altering the code, we just have to update wedgeEditor rather than liberally hitting up the code throughout Wedge.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 03:07 AM
Revision: 38
Author: arantor
Date: 02:06:18, 05 September 2010
Message:
! Ensure the auto added topic is updated to actually be the new admin's by ownership. (other/install.php) (ticket 21)
----
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Nao on September 5th, 2010, 09:20 AM
Thanks for the auto-topic fix, I really don't have time to work on anything this weekend... (I hate it.)
BTW, the "Mark Resolved" feature in SD doesn't seem to work when clicked from within a ticket. It does work when using the icon in the ticket list.
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
Quote
The reason for this one is to make it much easier to build on and/or replace in the event of using something like CKEditor; now whatever we do in terms of altering the code, we just have to update wedgeEditor rather than liberally hitting up the code throughout Wedge.
Oh... Right! Then it's fantastic.
I love it that you baptized our project :) Very logically, too, since this is something that is unlikely of reaching SMF at all. (And if it does, they'd better keep the name :P)
Title: Re: New revs
Post by: Nao on September 5th, 2010, 12:05 PM
rev 39
- Removed php_412_bugfix leftovers. (Load.php, smf_api.php, install.php)
- Some of the files were not requiring PHP 5. (index.php, webinstall.php, install.php, upgrade.php, Subs-Compat.php)
@ Is the eval() necessary in convert.php? Will it run on PHP4 without them? (Considering PHP4 isn't supported, it's not important but...)

--> The eval() stuff should be unneeded, but I'm just not sure whether PHP4 won't choke on some stuff in it. I don't think so, but I kinda have a hangover, AND I'm about to go to that stupid party in a minute.
Anyway, I'm not yet finished with the PHP5 requirements (I only did the files that should be a "barrier" to installing Wegde on PHP4). There are many more lines to remove, I'll do them later today when I get back, so we're finished with it.

I've also upgraded to the latest SMF rev (10093), and I'm nearly finished with the botslice/topslice stuff, hopefully, tonight, or tomorrow morning everything will be committed.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 03:45 PM
If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.

Adding try/catch is not something I'm overly looking at yet, since SMF's code is written to pretty much avoid failing anyway.
Posted: September 5th, 2010, 02:41 PM

Revision: 40
Author: arantor
Date: 14:02:17, 05 September 2010
Message:
! Removed unnecessary eval from dropping PHP 4 support (convert.php)
----
Modified : /trunk/other/converters/convert.php



EDIT to add
Quote
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
Posted: September 5th, 2010, 03:02 PM

Revision: 41
Author: arantor
Date: 14:26:17, 05 September 2010
Message:
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
----
Modified : /trunk/other/install_2-0_mysql.sql

Posted: September 5th, 2010, 03:26 PM

Revision: 42
Author: arantor
Date: 14:44:43, 05 September 2010
Message:
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
----
Modified : /trunk/Sources/Subs-Auth.php
Title: Re: New revs
Post by: MultiformeIngegno on September 5th, 2010, 04:27 PM
I love seeing new revs! :D
Can't wait to test Wedge!!
Title: Re: New revs
Post by: Nao on September 5th, 2010, 04:38 PM
@Lorenzo> An exclusive for you! Here's a short sample from some of our custom code!

Code: [Select]
if (!empty(

Sorry, can't show more. Hope it keeps you excited  :eheh:
Quote from Arantor on September 5th, 2010, 03:45 PM
If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
Quote
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
That's nice... But I'm sure it can be rewritten, still ;)
Quote
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
Yeah, I have yet to look into the mysql install files. I'm really removing things as things go, like, this morning I was simply looking for php_version and tried getting rid of all of the unneeded stuff. Still a lot remains to be done. Nothing biggie though.
Quote
Revision: 42
Author: arantor
Ahhhh!! You, filthy thief!![1] You stole my rev! I was looking forward to committing it myself! :P

'kay, just kidding, I already had rev 10.000 on SMF, and no one will take that one away from me... Despite Norv's efforts to revert part of that commit :niark:
Next stop: rev 69. Who will be getting it? :ph34r:

We just finished eating and I'm quite a bit wasted, again. What a weekend... And what with that 26'' monitor my hosts are using?! Why do they need that much space?
Anyway, I'll deal with all of these commits tonight (I have at least 3 on my waiting list, as I try to separate different fixes/additions into different commits).
Quote
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
Can't look into the svn right now (see above), so... Are you doing stuff in my stead? Maybe we should determine how to deal with commit conflicts. Usually we work on different parts at the same time so it's okay, but for instance, if you're going to tackle a task in the bug tracker, could you assign it to yourself first? That way I would have a way to make sure we're not working on fixing the same issue at the same time. Which at best is a waste of time for one of us, and at worst, brings commit confusion. (I'm talking about big fixes and features, of course. If it's just a few lines of code, who cares if we're wasting time.)
 1. I like the sound of that.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 04:43 PM
Quote
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
It'll be a fatal error since try/catch is a language construct not in PHP 4. Since we don't support PHP 4 at all, it's not worth worrying about unless we reinstate the original branch too (since the eval will just return false in PHP 4 and do absolutely nothing otherwise)
Quote
That's nice... But I'm sure it can be rewritten, still
Sure it can. Just remember that each block is given specific parameters in order to specify what will be in each block. It shouldn't be too hard to deal with that though.
Quote
Yeah, I have yet to look into the mysql install files
It only occurred to me as I was adding the return_to_post entry which lives in the same place.
Quote
Ahhhh!! You, filthy thief!!
Hahaha
Quote
Can't look into the svn right now (see above), so... Are you doing stuff in my stead?
All I did was remove the code that defines session_regenerate_id() if it doesn't exist, it's not done with a PHP_VERSION check but a function_exists(), so it's possible you wouldn't find it otherwise.

Sure, can assign stuff, it's been a while since I worked in a team!
Title: Re: New revs
Post by: MultiformeIngegno on September 5th, 2010, 04:47 PM
@Nao: I can't keep it secret!!!! Everybody needs to know this incredible scoop!! :P
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 04:49 PM
Quote from MultiformeIngegno on September 5th, 2010, 04:47 PM
@Nao: I can't keep it secret!!!! Everybody needs to know this incredible scoop!! :P
I'd love to tell people, but 1) it would risk being overhyped, and 2) we've kept it quiet as a courtesy to SMF. It is, as Nao has said, a PR move. Can you imagine what would happen if it were public what we were doing?
Title: Re: New revs
Post by: Nao on September 5th, 2010, 04:52 PM
Quote from Arantor on September 5th, 2010, 04:43 PM
Quote
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
It'll be a fatal error since try/catch is a language construct not in PHP 4. Since we don't support PHP 4 at all, it's not worth worrying about unless we reinstate the original branch too (since the eval will just return false in PHP 4 and do absolutely nothing otherwise)
I think I need to explain myself better, sorry. What I mean is, when you put a syntax error into a function, even a function that never gets called, PHP will directly crash on running the file. Would the try+catch and com_exception be considered as syntax errors? Because in that case, it would crash convert.php even before getting to the error message about the need to upgrade php.
However, it doesn't really matter, because you need to install your forum before you can convert to it, and if it won't install, there's no need to run the file anyway. So I'm good.
Quote
All I did was remove the code that defines session_regenerate_id() if it doesn't exist, it's not done with a PHP_VERSION check but a function_exists(), so it's possible you wouldn't find it otherwise.
I was actually planning to do a site-wide search on function_exists() as well, don't worry :) I only thought about it at the last moment though, so you're right, I could just as well have forgotten about it.
Quote
Sure, can assign stuff, it's been a while since I worked in a team!
We're a bit rusty :blush:

@Lorenzo> If you share that piece of code, even under a nickname, we'll KNOW it was your doing!

@Pete> He was kidding, re-read my previous PM with the code quote ;)
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 04:55 PM
Just for reference, yes, try/catch (I keep typing cache instead, haha) would be a syntax error in PHP 4, so yes it would crash PHP in that respect.
Title: Re: New revs
Post by: Nao on September 5th, 2010, 06:02 PM
Quote from Arantor on September 5th, 2010, 04:55 PM
Just for reference, yes, try/catch (I keep typing cache instead, haha)
Thta's not a porblem, we're not hree to witre a thises. We're hree to wrok on Webge Wegde[/s] Wgede.
Quote
would be a syntax error in PHP 4, so yes it would crash PHP in that respect.
Yeah, that's what I feared...
Oh well, as I said, it's okay because convert.php is unlikely to be used if the installer refused to work in the first place.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 08:19 PM
Revision: 43
Author: arantor
Date: 19:18:15, 05 September 2010
Message:
! db_show_debug can now be shown to different user groups (admin, admin+mod, all logged in users, everyone), optionally with query log being separated. (ManageServer.php, Subs.php, ViewQuery.php, Help.english.php, ManageSettings.english.php) (ticket 12)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on September 5th, 2010, 09:27 PM
Nice! Although that adds a lot of lines, but they'll run fast enough so that's okay :)
BTW --> I compressed the two isset()->unset() into a single unset() with both variables listed in it. isset() isn't needed, as PHP5 won't generate an error if you try unsetting a non-existent variable (it won't even do it if you try to unset an array entry in a non-existent array). So, might as well unset both in one go. :)

My first big one is here... (Mostly Norv's doing.)

rev 44
Code: [Select]
- More PHP4 stuff removal. (index.php, SSI.php)
* Updated to SMF rev 10093:
  ! Fixed calculating steps/substeps for log_actions changes (upgrade script) [Bug 4427]
  ! Added the optional (in 1.1 spec) assoc_type to OpenID parameters (Subs-OpenID.php) [Bug 4420]
  ! Small improvement to be more mod-friendly, a useless variable usage could have caused issues with mods (Load.php) [Bug 4445]
  ! Avatars loaded from remote locations may have failed resizing in some cases (script.js) [Bug 3842]
  ! Re-added a couple of flock() calls, as fclose() does not unlock the file on PHP 5.3.2+ (Load.php, ManageMaintenance.php) [Bug 4330]
  ! Improved 'who's online' behavior for a user who toggles WYSIWYG view (index.php) [Bug 4415]
  ! MySQL needs the autoincrement column defined as primary key (DbPackages-mysql.php) [Bug 4422]
  ! A variable was overwritten for font-size style tag, but needed later for <a> tag preservation (Subs-Editor.php -> Class-Editor.php) [Bug 4447]
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 09:43 PM
Quote
PHP5 won't generate an error if you try unsetting a non-existent variable (it won't even do it if you try to unset an array entry in a non-existent array)
And again... -.- If it weren't actually kind of important this would be almost funny.


Revision: 45
Author: arantor
Date: 20:42:54, 05 September 2010
Message:
! Again with the CRLF line endings having to disappear. (index.php, upgrade_2-0_mysql.sql, DbPackages-mysql.php, ManageMaintenance.php, Subs-OpenID.php, script.js)
----
Modified : /trunk/Sources/DbPackages-mysql.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/index.php
Modified : /trunk/other/upgrade_2-0_mysql.sql
Title: Re: New revs
Post by: Nao on September 5th, 2010, 10:43 PM
Can you believe I always forget to make sure it's okay?

I really need to find the setting in Subversion that will allow for all files be saved as LF...
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 10:46 PM
Can you believe the SMF team are still this sloppy?

It wouldn't hurt to fix it on our side, but they should be fixing it on theirs, and really how can you do a commit review if you can't check it is what it is supposed to be?
Title: Re: New revs
Post by: Nao on September 5th, 2010, 11:09 PM
I don't know, I'm trying my best to imagine it's not their fault but mine. (Blame my low self-esteem.)

http://gnuwin32.sourceforge.net/packages/patch.htm
Quote
On MS-Windows, the patchfile must be a text file, i.e. CR-LF must be used as line endings. A file with LF may give the error: "Assertion failed, hunk, file patch.c, line 343," unless the option '--binary' is given.
Maybe Tortoise forces the patch file to be in CR-LF format to ensure patch.exe won't screw it...? Because yes, the diff patch is itself in CR-LF in the first place. So that could explain it..?
(For devs using Windows or Linux as their platform) -> editing a LF file -> saving as LF -> committing patch
(For other dev using Windows as their platform) -> updating SVN (LF) -> generating a manual diff patch to apply on other branch (automatic CR LF) -> applying patch (CR LF) -> doing changes on that branch, committing to SVN in CR LF. File is 'remembered' as CR LF on the svn server (where data is always stored in LF.)

I really don't know. What I know is, the best way to get rid of these seems to have some sort of script that would automatically turn CRLF files into LF after a patch is done, or before a commit is done.

In any case, even though my SMF SVN indeed has a mix of CRLF and LF that can only be explained through the above examples (or simply a bad editor...), *my* commits are at fault, too. I should be careful.

PS: ah, I see you finally caught up with me in terms of posts here! I was wondering why it took you so long. :) Next step: 10k posts by next week! :lol:
Title: Re: New revs
Post by: Nao on September 5th, 2010, 11:15 PM
rev 46
* One-line version of a 4-line block. (Subs.php)
@ Okay, I just committed this because I discussed it, and forgot to commit.
Title: Re: New revs
Post by: Arantor on September 5th, 2010, 11:22 PM
Does Tortoise use GNU patch? I thought it used its own to be honest.

But if that's the case, repair_settings.php should be affected out of the last patch - and it wasn't. Which means it still is with them. It wouldn't hurt to have our stuff above reproach, but really it should be fixed at source, and how many times have you told them about this?
Title: Re: New revs
Post by: Nao on September 5th, 2010, 11:43 PM
I don't know about which one Tortoise uses, I installed a package or something...
repair_settings.php was my own fix. It wasn't touched by Norv.

BTW, there's more legacy code in repair_settings.php on selecting the current database type. I guess all of this should be removed? We're never going to go beyond ONE supported db system are we?
I just want to clean it up as soon as possible. $db_type should be a good search word.
Also need to finish php_version and function_exists searches.
And also re-fix board list in Search template.

Tomorrow is 100% work for me, at last :) (People who enjoy work... Looneys!)


rev 47
* First part of the big commit on the rounded corner rewrite. botslice and topslice empty spans are replaced with a parent class of wrc. IE adds support through Javascript. (ssi_examples.php, admin.css, index.css, and these templates, wait for it: Admin, Display, Errors, Help, index, ManageAttachments, ManageBans, ManageBoards, ManageCalendar, ManageMail, ManageMaintenance, ManageMembergroups, ManageMembers, ManagePaid, ManagePermissions, ManageScheduledTasks, ManageSearch, ManageSmileys, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Register, Reports, Search, SendTopic, SplitTopics, Stats, Themes and Who.)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 12:48 AM
Quote
I guess all of this should be removed? We're never going to go beyond ONE supported db system are we?
I'd kind of like to keep the code in there in case we ever want to support something alongside MySQL (i.e. community support), but really, the way it's all engineered generally, the entire query system would need rewriting to support proper query building.

In which case... you know where the delete button is, hehe :D


Hmm, maybe it is the patch executable then? Hmm, I don't know.
Posted: September 5th, 2010, 11:49 PM

Anyway.

I got brave and just did this.


Revision: 48
Author: arantor
Date: 23:47:06, 05 September 2010
Message:
! Added PMs being saved in sent items by default for new accounts (install_2-0_mysql.sql)
----
Modified : /trunk/other/install_2-0_mysql.sql
Title: Re: New revs
Post by: MultiformeIngegno on September 6th, 2010, 02:37 AM
Quote from Arantor on September 6th, 2010, 12:48 AM
! Added PMs being saved in sent items by default for new accounts (install_2-0_mysql.sql)
:cool:
Title: Re: New revs
Post by: Nao on September 6th, 2010, 12:25 PM
rev 49
* SMF2 changelog, back to LF endings... (yawn) (changelog.txt)
* More PHP5 optimization. Ain't done yet. (phpBB3_Login_Fix.xml, install.php, Display.php, Load.php)
- complex_preg_chars trigger (PHP 4.3.3+) is no longer needed. (Class-Editor.php, Load.php, Register.php, Search.php, Subs-Members.php, Subs-Post.php, Subs.php)
Posted: September 6th, 2010, 10:31 AM
Quote from Arantor on September 6th, 2010, 12:48 AM
I'd kind of like to keep the code in there in case we ever want to support something alongside MySQL (i.e. community support),
Community support?
Quote
but really, the way it's all engineered generally, the entire query system would need rewriting to support proper query building.

In which case... you know where the delete button is, hehe :D
Is it the red one or the blue one?
Posted: September 6th, 2010, 10:32 AM

rev 50
* Cleaned up some of the convert.php file... Honestly, this one is a real mess, I only did the end of it. (convert.php)
- Removed debug_* compatibility code. (convert.php, recount_boards.php, recount_categories.php, recount_membergroups.php, upgrade.php, Class-Package.php, Errors.php, Subs-Db-mysql.php)
- Kept removing PHP4 compatibility code. (convert.php, readme_*.html, Display.php, Load.php, LogInOut.php, QueryString.php, Search.php, Subs-Auth.php, Subs-OpenID.php, Subs.php, Help.english.php)
- Deleted Subs-Compat.php file, as it's no longer needed. Will reintroduce... if ever needed again.

So that's 50 commits in a week and a half or so. Nice numbers :)
Lunch break...
Title: Re: New revs
Post by: Dismal Shadow on September 6th, 2010, 01:40 PM
Wedge's 50 commits vs SMF's 1 commit per week...
Title: Re: New revs
Post by: Nao on September 6th, 2010, 02:10 PM
@Dismal> Actually, since last Thursday, Norv committed about 23 times, and some of Wedge's commits (many of mine, actually) aren't really feature additions, rather feature removals, which are easier to do... Such as this one:

rev 51
- Removed smflib folder (not used in SMF2, not likely to be used in Wedge.)
- Removed compatibility code for array_combine, array_fill, sha1, file_put_contents, ob_clean, ob_get_level (although this one isn't really needed.) (create_backup.php, repair.php, restore_backup.php, smf_api.php, webinstall.php, Display.php, DumpDatabase.php)
- Removed rawdata templating (leftover from SMF 1.0 days.) (ManageMaintenance.php, ManageServer.php, RepairBoards.php, Subs.php)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 02:34 PM
Quote
Community support?
Something that YSF discussed, the idea that the core would support only MySQL by default but that those who wanted other things (PGSQL, SQLite, heck even MSSQL) could bolt it on. Trouble is, each of those has their own requirements and the way to go is not to throw the query from MySQL at a series of string replacements to make it sort of work with other things (and in MSSQL's case, that's asking for trouble anyway)
Title: Re: New revs
Post by: Nao on September 6th, 2010, 03:05 PM
Yeah, the problem with other databases is that they're not plug & play when it comes to replacing MySQL functionality... Even the current state of SMF2 is a series of hacks designed to add support for PG and SQLite, but it doesn't help much. I'm sure that if the core team wanted to add support for some other DB at this point, they would have to hack into new areas as well because they found out there's an incompatibility here and there...
It's quite pointless to me. SMF started as MySQL and MySQL is still the de facto database system on the Interneds.
(I'm not removing extra support code unless you want it too, though.)

rev 52
* Updated to SMF rev 10095. Also fixed line endings, hopefully for the last time...
  ! Fixed avatars resized with javascript (script.js)
  * Tweaked the attachments cleaning to allow single file removals (script.js, Post template) [Bug 3559]
  & Tweaked the language string accordingly (Post english)
  ! Chose a hopefully more portable fix for cleaning file input (script.js) [Bug 3780]

--------> rev 10096 and 10097 are about fixing LF endings... Unfortunately, I just tried, and svn diff still generates a CRLF file, and patch still generates a CRLF file as well. So... I don't know.
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 03:11 PM
Part of me would like to keep it, but there's no reason it should stay unless we're seriously planning on providing the ability to deal with it later, which I doubt.

Most of the hacks for PGSQL are because SMF uses this banal system of comma-separated values in a string column. It may have made sense long ago but in the current day and age, it's not viable. Don't even get me started on trying to hack in MSSQL support, I actually gave that up as a lost cause in the current environment. (Seriously, how stupid is it not to support LIMIT x, y as a clause? You can have the TOP x rows, but can't page through like that.)
Title: Re: New revs
Post by: Nao on September 6th, 2010, 03:23 PM
I need to find another solution for the CRLF stuff.
First, I should try if converting my diff files to LF will preserve LF on the target files at patching time. I may have to add --binary to the patch call though. And I don't know if it won't generate other issues.
Too bad setting up Subversion to use LF didn't help a bit.
Quote from Arantor on September 6th, 2010, 03:11 PM
Part of me would like to keep it, but there's no reason it should stay unless we're seriously planning on providing the ability to deal with it later, which I doubt.
Here's the thing: I'm no good at PG and SQLite. Really, no good. I don't know a thing. It took me twice longer to write the Ignore Topic mod because I had to add support for PG and SQ. I thought it sucked. Now, the thing is, the more I spend time on crap like that, the less I can spend time on more interesting features. MySQL has at least a 90% marketshare in forum software, so I don't care about the remaining 10%. I'm not here to eat market shares, I'm here to team up with you and have fun making the best possible forum software for MySQL and PHP5. I'll leave market share issues to SMF.
Another thing is -- if someone adds support for a new DB system, then we'll feel compelled to help with it. And then we'll end up having to support it. And then we'll figure, okay let's put back support for PG and SQLite, since it was already there to begin with, we can simply revert some stuff...
And we'll be back to square one.

I really, really would vote for removal of what is left of the multiple database code. (Not a priority, though, but if it can save time generating a SMF page, then I want it.)
Quote
Most of the hacks for PGSQL are because SMF uses this banal system of comma-separated values in a string column. It may have made sense long ago but in the current day and age, it's not viable.
You mean, things like FIND_IN_SET?
Quote
Don't even get me started on trying to hack in MSSQL support, I actually gave that up as a lost cause in the current environment. (Seriously, how stupid is it not to support LIMIT x, y as a clause? You can have the TOP x rows, but can't page through like that.)
Oh, you gotta love Microsoft... :)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 03:30 PM
*nods*

/mehands Nao the axe to finish chopping the multi DB code out.
Point of interest: vBulletin only supports MySQL, IPB supports MySQL with MSSQL as a paid plugin (though knowing how that handles queries, it's not impossible to make it support other DBs without too much work)

Yeah, FIND_IN_SET is ridiculous, and doubly so since in PGSQL's case it doesn't exist at all, and has to be shoe-horned in as a user function (at a performance penalty, too), which returns T or F (or t or f sometimes), so you end up having to rewrite every instance of FIND_IN_SET in queries. I mean, seriously... who does it like that?
Title: Re: New revs
Post by: MultiformeIngegno on September 6th, 2010, 03:44 PM
What about MySQL destiny with Oracle..? Honestly I know nothing of what's happening with it, I only read scrolled ( :P ) some articles.. can it rely on a stable development?
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 03:58 PM
I think it can. Oracle has jettisoned the areas it's not interested in (OpenSolaris for one), and MySQL is a money maker for it, especially as it can sell very expensive training, then upgrades to Oracle gear later on (with support contracts)

I don't think there's anything to fear for MySQL at the current time, and I suspect it's got life for years yet.[1]
 1. /mewaits for this to come back to haunt him haha
Title: Re: New revs
Post by: Nao on September 6th, 2010, 04:27 PM
Quote from Arantor on September 6th, 2010, 03:30 PM
*nods*

/mehands Nao the axe to finish chopping the multi DB code out.
rev 53
- Removed more of the multi-database code. (install.php, Settings.php, Settings_bak.php, create_backup.php, repair.php, repair_settings.php, restore_backup.php, smf_api.php, upgrade.php)
! Typo in repair.php, 'smc_compat_dtabase' (this should also be backported to SMF2.) (repair.php)
! Re-introducing SMF rev 9976's fix of the backup system when some tables have fields using reserved names. (DbExtra-mysql.php)

I'm not completely finished but nearly so... I should change $databases['mysql'] to just $database, but I'm a bit tired of constantly proof-reading my own code.
Quote
Point of interest: vBulletin only supports MySQL,
'course.
"We only do evil, but we're good at it." :eheheh:
Quote
Yeah, FIND_IN_SET is ridiculous, and doubly so since in PGSQL's case it doesn't exist at all, and has to be shoe-horned in as a user function (at a performance penalty, too), which returns T or F (or t or f sometimes), so you end up having to rewrite every instance of FIND_IN_SET in queries. I mean, seriously... who does it like that?
I actually like FIND_IN_SET... :lol:
But keeping it in place when trying to support other database systems would be silly, indeed.
Title: Re: New revs
Post by: Nao on September 6th, 2010, 04:28 PM
Quote from Arantor on September 6th, 2010, 03:58 PM
I think it can. Oracle has jettisoned the areas it's not interested in (OpenSolaris for one), and MySQL is a money maker for it, especially as it can sell very expensive training, then upgrades to Oracle gear later on (with support contracts)
I wouldn't add support for Oracle DB... My girlfriend could, though! (Well, she'd be my living documentation on their custom stuff, at least.)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 04:30 PM
Just to clarify: FIND_IN_SET has its place, like everything else. But to use it to hunt through what is really relational data (user belongs-to group, board belongs-to group), which results in a table scan vs using indexes really is ridiculous.


When you're done with that, I'll begin on replacing $scripturl with a constant (along with the other similar globals that shouldn't really be global variables but constants)


Re Oracle: If we make the move to everything being properly relational anyway, it becomes so much easier to build for... but I don't like building for something I can't test, hahah.
Title: Re: New revs
Post by: Nao on September 6th, 2010, 04:36 PM
Quote from Arantor on September 6th, 2010, 04:30 PM
Just to clarify: FIND_IN_SET has its place, like everything else. But to use it to hunt through what is really relational data (user belongs-to group, board belongs-to group), which results in a table scan vs using indexes really is ridiculous.
Are you sure it's inefficient? I remember reading about performance issues and the conclusion was that it was just as fast as an extra table... Couldn't say, myself. Haven't been looking into {query_see_board} and stuff for a long time.
Quote
When you're done with that, I'll begin on replacing $scripturl with a constant (along with the other similar globals that shouldn't really be global variables but constants)
Hmm... You means replacing $scripturl with SCRIPTURL?
I noticed your use of constants inside SD...
May I give you my honest opinion?
It looks kinda ugly........... :unsure:
Actually takes me back to the days of SMF1, with $ID_MEMBER, $ID_BOARD and such.
Quote
Re Oracle: If we make the move to everything being properly relational anyway, it becomes so much easier to build for... but I don't like building for something I can't test, hahah.
Same here!

+1 for going relational, though. We already have plenty of tables... Why not add a few dozen more, people won't notice :P
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 04:42 PM
Quote
Are you sure it's inefficient? I remember reading about performance issues and the conclusion was that it was just as fast as an extra table... Couldn't say, myself. Haven't been looking into {query_see_board} and stuff for a long time.
I don't see how it can be even close as efficient. If you're using a relational table, you have the benefit of indexes. If you're using FIND_IN_SET, you're forced to traverse the table row by row, since you can't use an index on it, and parse the row.


In the case of SMF 1 and $ID_MEMBER and so on, I know why they did that, and in practice it's... interesting. Not only describing the column by name, you're implicitly implying it forms part of a primary and/or foreign key without any other characters. That was ugly.

I'm not on the fence about it being a constant, because really, it's defined once, and used throughout the code, which means so many passes back and forth through scope that it's unreal. In terms of formatting, what about actually making it 'scripturl'? Nothing says a constant has to be upper case, but it makes it easier to see if it is.

I also believe it should be faster too.

In SD's case, it was pure readability I was going for. No way was I going to remember in every case that status 3 was resolved or that 6 was deleted, but I knew I'd follow it better with TICKET_STATUS_CLOSED or TICKET_STATUS_DELETED. I found it was only ugly initially because I wasn't used to seeing it.
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 07:53 PM
Revision: 54
Author: arantor
Date: 18:21:42, 06 September 2010
Message:
! Fixed bug in unified editor class where BBC was loaded without the post language file first, in PMs. (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php

Posted: September 6th, 2010, 07:22 PM

Revision: 55
Author: arantor
Date: 18:27:53, 06 September 2010
Message:
! Quote now references the individual message only. Not 100% sure this is the fastest way to evaluate the regexp though. (Post.php, Subs.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs.php

Posted: September 6th, 2010, 07:28 PM

Revision: 56
Author: arantor
Date: 18:53:32, 06 September 2010
Message:
! Make the quick search box be hidden if the user doesn't have permission. (index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Title: Re: New revs
Post by: Nao on September 6th, 2010, 09:22 PM
Don't remember having ever touched the code you modified to add msg=... Are you sure it was needed? :)

rev 57
! Extra tabs/spaces, and typo fixes in comments, like its/it's and lets/let's. (Many files)
Posted: September 6th, 2010, 09:15 PM

Pete, I've re-read the install and upgrade scripts, and I really hope I got them done without breaking anything. In terms of logic, it should be okay. Just don't yell at me if you try running one of the scripts and it crashes :) I just wanted to be done with it...

rev 58
- Hopefully, removed all of the remaining multi-database code. (install.php, smfinfo.php, upgrade.php, DbPackages-mysql.php, DbSearch-mysql.php, Search.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php)
Title: Re: New revs
Post by: Arantor on September 6th, 2010, 10:47 PM
Quote
Don't remember having ever touched the code you modified to add msg=... Are you sure it was needed?
Unless you did something funky, I found I needed it since link= doesn't accept msg on its own (it requires either (board+)topic or threadid, optionally followed by the msg number for the # fragment, or action=profile with user id for PMs)
Quote
Pete, I've re-read the install and upgrade scripts, and I really hope I got them done without breaking anything. In terms of logic, it should be okay. Just don't yell at me if you try running one of the scripts and it crashes  I just wanted to be done with it...
Well, every time I do something half way big, I push it through a fresh install, so I'll be able to test. I'm not so worried about the upgrade script right now personally (since I'm not planning to test it anytime soon :P)
Title: Re: New revs
Post by: Nao on September 6th, 2010, 10:52 PM
Quote from Arantor on September 6th, 2010, 10:47 PM
Unless you did something funky, I found I needed it since link= doesn't accept msg on its own (it requires either (board+)topic or threadid, optionally followed by the msg number for the # fragment, or action=profile with user id for PMs)
Yeah, that was totally needed and what I'd done in the first place. (See ticket #31)
Quote
Well, every time I do something half way big, I push it through a fresh install, so I'll be able to test. I'm not so worried about the upgrade script right now personally (since I'm not planning to test it anytime soon :P)
Unfortunately, the only way to properly test a forum install is to use it... ::)
(In the end, it's my goal to convert wedgeo to a vanilla Wedge, of course.)

PS: 1000+ posts on wedgeo :)
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 12:01 AM
Well, the installer doesn't appear to be broken...


Revision: 59
Author: arantor
Date: 22:59:27, 06 September 2010
Message:
+ Selecting IMG or URL buttons in non WYSIWYG mode prompts for IMG and URL (and also linktext for url bbc)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js


This is essentially the same as http://arantormods.com/index.php?action=media;sa=item;in=3 except it also handles it for img too. In other news, I rediscovered that IE has a custom prompt that's used in WYSIWYG mode, I may have to remove that in the interests of cross-browser experience being the same.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 07:25 AM
Great news for everything :)
(Install script or upgrade script?)
Title: Re: New revs
Post by: Nao on September 7th, 2010, 08:00 AM
"Please enter what text the link should say." -> Is this straightforward, or could people be confused with this? I would have said (with my limited English) something like, "You may enter a caption (description?) for the link if you'd like." It doesn't seem mandatory.
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 09:00 AM
It's no less straightforward than the prompt immediately before it, IMO, but I *am* a geek which means what sounds normal to me probably isn't, heh. I'll get my better half to look at it tonight.

It isn't actually mandatory, by design, so if people hit cancel on that prompt it gives them a url bbcode with the URL itself as the linktext.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 11:40 AM
It's just a matter of phrasing stuff correctly. I don't mean yours isn't correct -- just that it can be confusing.
I'm confused myself. With my post, not your phrasing. Or am I. Or is it.

I should go back to bed.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 12:14 PM
rev 60
* Renamed files with mysql in the filename to make it more generic. (install.php, create_backup.php, repair.php, repair_settings.php, restore_backup.php, smf_api.php, upgrade.php, detailed-version.js, Load.php, renamed: Db*-mysql.php to Db*.php, Subs-Db-mysql.php to Subs-Database.php)

--> I think "DbExtra.php" doesn't look good, but it's better than "DbExtra-mysql.php" which is redundant (MySQL *is* a Db.) Maybe "Data-Extra.php" or "Database-Extra.php"...? Dunno. It's not very important ;)

Okay, I should get back to my templating stuff now...
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 06:35 PM
Revision: 61
Author: arantor
Date: 17:33:04, 07 September 2010
Message:
! Remove unnecessary board and threadid from quote bbc handler. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on September 7th, 2010, 10:56 PM
rev 62
* URL prompt in editor should use [url] type instead of [url=] when no description is provided. (editor.js)
! Fixing on-the-fly rounded corners for IE when splitting topics. (SplitTopics.template.php)
* Minor stuff. (Recent.template.php, index.css, Subs.php)

--> when it comes to Subs.php, your modified regex had a "(?:topic)" in it... Just replaced it with "topic" ;)
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 11:04 PM
Oh, yeah, nice optimisation there on the URL prompt, I missed that in passing.


As for Subs.php... I figured there had to be a reason it was there as a positive assertion so left it until I had a reason to remove it, really.
Title: Re: New revs
Post by: Nao on September 7th, 2010, 11:35 PM
- editor: I was surprised to have noticed that myself ;D
- Subs: (?:topic) really does nothing. The regex engine will disregard it. The only reason to use (?:) is if you provide a quantifier after the parenthesis. (?:topic)? is logical. It's either topic, or nothing. (?:topic) means it's even topic, or topic. :lol:
Title: Re: New revs
Post by: Arantor on September 7th, 2010, 11:41 PM
Subs: Not entirely... if it's part of a paranthesised expression, it won't be matched.

But yeah, it's irrelevant here :P
Title: Re: New revs
Post by: Nao on September 7th, 2010, 11:43 PM
I assure you that it means "topic or topic". :whistle:

Okay, bed time for me...
Title: Re: New revs
Post by: Arantor on September 8th, 2010, 12:02 AM
Sorry, I meant *captured* in the match. ((?:topic=)\d+) would only match the number in a backref.
Title: Re: New revs
Post by: Nao on September 8th, 2010, 12:32 AM
No... "((?:topic=)\d+)" would return "topic=1", I'm pretty sure of it. (I wouldn't bet my life on it, but I'm still quite certain.)
Title: Re: New revs
Post by: Arantor on September 8th, 2010, 03:17 AM
My bad, I was thinking of ?= rather than ?:, ?= is non matching assertion, ?: is a subpattern, so yes it would match that.
Posted: September 8th, 2010, 12:34 AM

Revision: 63
Author: arantor
Date: 02:16:59, 08 September 2010
Message:
! Add 'banned' to possible moderation statuses in display area (in addition to 'watched', 'moderated', 'muted'
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/warning_ban.gif
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on September 8th, 2010, 02:36 PM
rev 64
* Updated to SVN rev 10098 (hmm, just a line to change. Cleaned up the function, too, as the comment was a bit contradictory.)
 ! Add attachments cleaning for IE as well, though it allows manually deleting the file input box (script.js)
Title: Re: New revs
Post by: Arantor on September 9th, 2010, 12:57 AM
Revision: 65
Author: arantor
Date: 18:56:14, 08 September 2010
Message:
+ Add conversion from quick to inline full editor in Quick Reply (Display.php, index.css, Display.template.php, index.english.php, topic.js)
! Fix change of state in buttons if bbcode disabled (editor.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/topic.js


The edit to editor.js was to fix some errors coming up in FF when bbcode was disabled entirely. I couldn't reproduce in RC3 public, so I'm not 100% sure it isn't a regression caused by the editor changes, but it all functions as it's supposed to now, so not sure what to make of that.
Posted: September 8th, 2010, 07:57 PM

Revision: 66
Author: arantor
Date: 19:51:49, 08 September 2010
Message:
! Fixed font size selector to actually work as intended (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Posted: September 8th, 2010, 08:55 PM

Revision: 67
Author: arantor
Date: 23:57:05, 08 September 2010
Message:
+ Add post time on wireless views (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php
Title: Re: New revs
Post by: Nao on September 9th, 2010, 02:45 PM
Sometimes... I really feel like a small-time hacker with my minor revs :P

rev 68
- Removed needs_size_fix hack, as it was only used in Babylon themes. (Load.php)
- Removed nopadding from Admin template -- looked ugly for no reason. (Admin.template.php, admin.css)
* Pete... I'm afraid I'm a parenthesis nazi. (Load.php, Display.template.php)
! Fixed Register and SplitTopics templates to apply rounded corners to divs instead of lists and forms. This allows for faster parsing when in compatibility mode. (Register.template.php, SplitTopics.template.php)
Posted: September 9th, 2010, 11:25 AM

Okay, this one's a bit better actually :eheheh:
I'm not too sure about the is_opera105up though... And I'd be tempted to delete WAY MORE is_* variables at this point. (Discuss in related topic, thanks.)

rev 69
+ Added code to automatically detect browser support for border-radius and box-shadow. (script.js)
* Moved rounded corner emulation code to script.js, as it's likely to be more stable now. (index.template.php, script.js)
* Started conversion of roundframe divs to delete non-semantic code. (index.css, BoardIndex.template.php)
* Rewrote browser detection code to be more efficient. Dropped versions is_ie4, is_opera5/6/7/8 are now forced to false, is_safari is only set if not in a smartphone environment, dropped is_opera96 entirely (was it used at all?), added is_opera105up (not is_opera105 though... I don't want to overdo it), is_ff is really only set for the actual Firefox and assimilated, and added is_ie9 and is_ie9up. (script.js)
* Updated this.bRichTextPossible initialization code accordingly. (editor.js)
! Deleted more IE4 compatibility code and fixed typos. (script.js)
! Fixed admin sub-menus to avoid showing a scrollbar. (index.css)
Posted: September 9th, 2010, 11:37 AM

rev 70
* Plenty of cleaning up. @todo: what's with the random registration code hardcoded into this..?! (Help.template.php)
* Some cleaning up. (Memberlist.template.php)
- Removed legacy class innerframe. (Help.template.php, BoardIndex.template.php, Profile.template.php)
* Finished converting roundframe divs to the new system. Yay! (Templates: Admin, Calendar, Display, Help, Login, Memberlist, Notify, PersonalMessage, Poll, Post, Profile, Register, Reminder, Search)
Posted: September 9th, 2010, 12:13 PM

rev 71
- Removing securityPackages folder, as it's SMF-specific and being well behaved, we don't play with others' toys.
! Fixed undefined error 'submit_label'. (Display.php)

rev 72
! Fixed incorrect regex in browser detection. (script.js)

(Sorry, forgot to commit the second one at the same time...)
Posted: September 9th, 2010, 01:29 PM

rev 73
! Clean fix for the font size dropdown in Opera (see here(http://dev.simplemachines.org/mantis/view.php?id=4453)), and added support for 6pt font size. (Class-Editor.php, editor.js)
* Another coup from the Parenthenazi. (Wireless.template.php)
Title: Re: New revs
Post by: Arantor on September 9th, 2010, 02:49 PM
Re r73... so, then, where the select is later set to value = 0 to reset it, what happens? The idea is that in WYSIWYG mode it should retain its value until deselected, or in non WYSIWYG mode it should deselect.

Chrome didn't care, FF didn't like it either (before). Will have to test whether it works now.
Title: Re: New revs
Post by: Arantor on September 9th, 2010, 03:06 PM
Revision: 74
Author: arantor
Date: 14:05:08, 09 September 2010
Message:
! Removal of easter eggs:
 the clock (Calendar.php, Calendar.template.php, index.php)
 the Books of Unknown (Karma.php, index.php)
 i am the administrator. (Post.php)
 iamanoompaloompa (Subs-Menu.php)
 chocolate cake (Subs-Members.php)
 fake integrate_egg_nog (ViewQuery.php)
 OH NOES (ManageMaintenance.php)
----
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/index.php


As per http://wedge.org/up/6160/easter-eggs/
Title: Re: New revs
Post by: Nao on September 10th, 2010, 12:39 AM
What happened with your fix, was that selecting "Select font size" would add [size=0pt][/size] to the message box... :)
So I simply did it the way other boxes were done. Now it works, it simply returns "" (insteaf of "0") and thus doesn't show anything.

BTW, wrong place to discuss but I'm a bit lazy...

   $breaker = '<span style="margin: 0 -0.5ex 0 0;"> </span>';

This is in the code to fix long words. Uh... How about we use the proper tool -- &shy;?
Posted: September 9th, 2010, 03:06 PM

rev 75
- Removed setRequestHeader test for Opera... That issue was only in the 5yo Opera 8.00 (note the specific minor version number), so... what the heck?! (Post.template.php, topic.js)

(Looks like Wedge is on a diet, today... ;))
Posted: September 9th, 2010, 03:09 PM

rev 76
- Market share for IE 5.x was 0.08% in 2009... We're in 2010. IE5 support is out. (Load.php, Subs.php, Display.template.php, editor.js, script.js, topic.js)

rev 77
! Oops again. (Load.php) <-- crash

rev 78
! is_opera105up wasn't properly filled in. (script.js)
! document.body isn't always initialized. Replaced with a createElement. (script.js)
+ Re-introduced ActiveX hack, as IE6 also made use of it. Limiting to the newer namespace, though. (script.js)
* If browser supports querySelectorAll(), use that in the rounded corner emulator. Probably only Opera 9.x through 10.10 can make use of that. (script.js)

Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
I don't even have access to the console, for a reason unknown. :(
Posted: September 10th, 2010, 12:03 AM
Quote from Nao/Gilles on September 10th, 2010, 12:03 AM
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
Grmpf... Did the update, and it works in O 9.5. Dunno if it was broken in O9 because I had some wrong configuration. Anyway... O9.5+ is 90% of the Opera userbase or so. Fine with it.
Title: Re: New revs
Post by: Nao on September 10th, 2010, 01:50 PM
rev 79
! grabJumpToContent() is called through onmousemover if document.implementation isn't defined... It should be done for all, or nothing. (script.js)
* set/getInnerHTML are deprecated, but weren't actually removed from the SMF codebase. (install.php, ssi_examples.php, repair_settings.php, smfinfo.php, unittest.js, upgrade.php, latest-news.js, latest-support.js, admin.js, editor.js, fader.js, PersonalMessage.js, script.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, Templates: Admin, ManageMaintenance ManageSearch, ManageSmileys, MessageIndex, Packages, PersonalMessage, Post, Profile, SplitTopics, Themes)
Posted: September 10th, 2010, 10:46 AM

rev 80
+ Added a placeholder for parse_bbc_inline(). Should be rewritten to use regex later. (Subs.php)
Title: Re: New revs
Post by: Arantor on September 10th, 2010, 09:07 PM
You know you fixed up an easter egg in r79, right? :P ssi-examples.php, line 52...
Title: Re: New revs
Post by: Nao on September 10th, 2010, 09:27 PM
Yeah... ;) I actually considered changing the text to say some other thing, but then I decided against it, as I like chocobos, too :P Had it been a Pokémon reference, I would have changed it haha.

Good to see you're reading every fucking borin' line of my stuff!
How do you do it? I mean, I do it too, but sometimes when there are too many changes, I have to take a few minutes to build a diff patch out so I can read more comfortably instead of checking out the log and having to watch the changes file by file...
Title: Re: New revs
Post by: Arantor on September 10th, 2010, 09:30 PM
The slow way; I look through the log, rev by rev, and then file by file. Though depending on the level and nature of changes I have been known to run two revs together, such as when we were fixing CRLFs, when I'd run two revs together to see the total changes between them.

Basically whatever looks like it'll give me the best clue as to what's changed in the code.
Title: Re: New revs
Post by: Nao on September 10th, 2010, 09:35 PM
Yeah, I have a SVN and a SVN_2 folder to make my diff patches for SMF, and a SVN and SVN_all folder for Wedge, although it's a bit different (SVN is a shortcut to trunk, so I can't diff patch between the two, I have to specify SVN_all/trunk and it's boring... :P)
If I could find a way to automate the entire process, that'd be swell... Retrieve rev number in SVN folder, update SVN2 to that rev, then update SVN to latest rev. If different, generate a patch, with name "dev-CURRENT_REV.diff". Make coffee, too.
Title: Re: New revs
Post by: Nao on September 11th, 2010, 12:26 AM
rev 81
* Uninteresting code cleanup and optimizations. (Class-Editor.php, Load.php, index.css, script.js)
! replaceText() could fail on Opera if run on a message without any carriage return. (script.js)
! Post editor smileys and bbcode buttons would fail on Opera < 10.5 and IE 6-8 because setting innerHTML or outerHTML on an object with dynamic events will reset the event list in these browsers. (script.js)
Title: Re: New revs
Post by: Nao on September 11th, 2010, 01:26 AM
rev 82
* If modder forgets to put empty quotes at the beginning of a smf_db_query call, let's fix it for them. Dunno if it could be useful. Just felt like it. (Subs-Database.php)
* Cleanup for script.js
- Removed all of the optional parameters in queries, as they were only used by PGSQL and SQlite. (All other files -- please don't make me list them!)

--> Don't bother testing the param stuff Pete, there are about 75 occurrences and I checked them all, one by one. (Automatic search & replace so it was unlikely to fail anyway.)
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 03:56 AM
There was me checking one by one since I tried to commit myself in the interim...

Revision: 83
Author: arantor
Date: 00:35:43, 11 September 2010
Message:
! Remove support for the no longer maintained Turck MMcache (it doesn't even support PHP 5.x properly not having been updated in 7 years) (smfinfo.php, Admin.php, Load.php, ManageServer.php, Subs-Admin.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/tools/smfinfo.php
Posted: September 11th, 2010, 01:36 AM

Revision: 84
Author: arantor
Date: 01:02:19, 11 September 2010
Message:
! Minor optimisation for participation icons (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Posted: September 11th, 2010, 02:02 AM

Revision: 85
Author: arantor
Date: 02:55:32, 11 September 2010
Message:
! Fix bug with the top selector in Who's Online not working (Who.php)
----
Modified : /trunk/Sources/Who.php


As reported by http://www.simplemachines.org/community/index.php?topic=399617.0
Title: Re: New revs
Post by: Nao on September 11th, 2010, 09:05 AM
rev 86
* Updating to SMF rev 10101. Parenthenazi kills SD.
 ! fetch_web_data didn't properly parse ports (Subs-Package.php)
 ! constructPageIndex didn't respect flexible start for compact pagination (Subs.php)

(Yikes, I felt dirty committing this, even though the fixes were made by the reporters, not the committers... They're giving commit access to SlammedDime, after what he did to the team's rep?! Woohoo... And vbgamer45 made his first commit in something like *4 months*, to backport that fetch_web_data fix which isn't even perfect but... :P)

! Minor optimisation for participation icons (Recent.php) <--------- Hey, that was my find :P Thief! :lol:
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 01:53 PM
SlammedDime has had commit access for years, just he never uses it.
Title: Re: New revs
Post by: Nao on September 11th, 2010, 02:59 PM
rev 87
! Sending PM and moving topics were broken due to wedgeEditor not being correctly loaded. (MoveTopic.php, Subs-Post.php)
* Renamed install/upgrade_2-0_mysql.sql to install/upgrade_2-0.sql, to match the 1.1 branch files. (install.php, upgrade.php, *.sql)
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 03:09 PM
Oops, I broke it :P

Are we going to update changelog.txt?

Also, did you see my proposed changes for the PM UI? (http://tracker.wedge.org/?sa=ticket;ticket=18.msg253#msg253)
Title: Re: New revs
Post by: Nao on September 11th, 2010, 04:18 PM
Quote from Arantor on September 11th, 2010, 03:09 PM
Oops, I broke it :P
Told ya I hadn't looked into Class-Editor... ;)
I must say, I'm not too excited about having to type wedgeEditor::preparsecode instead of just preparsecode(), but I'm sure there's a good reason behind it, I trust you on that one. (If there isn't, then I'll kill you dead for it :P)
Quote
Are we going to update changelog.txt?
Well, one of the things that really piss me off with changelogs, is that NOBODY reads them, even when you're trying HARD to make them fun to read... (Just have a look at some of Aeva/SMG/AeMe's log entries. I even placed a Blade Runner quote in AeMe and nobody probably saw it :P)
So, having a 800KB changelog is totally useless in that respect. What people need is the kind of changelog I do for AeMe on big version updates: I categorize changes by interest. The biggest changes are put first, then the "cool" changes, then at the end I have a list of geeky, uninteresting changes, and finally the mandatory line "Plenty of bug fixes as usual", which is totally right.

I generate my changelogs at release time (or close to), by getting them from Tortoise and reordering them.
We could try having a changelog generated automatically from the svn (I'm sure there's a tool for that), and then we can go through it and delete anything that's not of interest to the reader.

Also, one of the things that piss me off in SMF's changelog, is that they document fixes for *unreleased revs*. Yay... Like it's going to be of any interest to non-testers! Even them don't read changelogs -- at best, they go through (most of) the bug tracker.
Quote
Also, did you see my proposed changes for the PM UI? (http://tracker.wedge.org/?sa=ticket;ticket=18.msg253#msg253)
Yes, and that's precisely what got me to find the crash ;) And subsequently the ClassEditor missing a dash.
I was trying to send meself a PM to see if you had committed the change already (I wasn't sure.)
Anyway, yeah, do try and commit it. ANYTHING is better than what's up right now...! :) We'll fix it later if it needs anything.

Really, really -- let's all have fun with Wedge. It's been over 2 weeks now, and it's been a lot of fun already. I can't stop working on it, it's so thrilling to finally be able to get rid of legacy code and add features that have been waiting for so long. And I haven't even got started on converting Noisen features!! ;)

At some point, we'll have to consider posting a working copy of Wedge in private, for our users here. I'm sure they'll appreciate being able to browse through the changes instead of just discussing them. Since we're working on local copies, it won't be updated as often, but it could.
Title: Re: New revs
Post by: Arantor on September 11th, 2010, 08:51 PM
Quote
(If there isn't, then I'll kill you dead for it )
There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.

I liked how you did the AeMe changelog though I'll admit I never read it in detail.

I hadn't committed the PM stuff, I wanted to get opinions on it before I did since it wasn't very cleanly done. I'll commit in a minute and we can pick the bones out of it later.
Posted: September 11th, 2010, 08:30 PM

Revision: 88
Author: arantor
Date: 19:50:12, 11 September 2010
Message:
+ Dropdown selector for PM viewing mode (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php


Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.
Title: Re: New revs
Post by: Nao on September 12th, 2010, 01:03 AM
/meis in a trance listening to the Atari ST Chambers of Shaolin soundtrack...
Quote from Arantor on September 11th, 2010, 08:51 PM
There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()? Nothing says it was added through the editor itself... It could have been imported through a feed, etc... (Or even generated by SMF or a mod...)
Quote
I liked how you did the AeMe changelog though I'll admit I never read it in detail.
Well, that only proves my point :P
I don't believe anyone ever admitted to me having read the changelog at all. It's okay with me. It's THERE to be read if you need to. If you don't, then that's okay. But it's just like buying a new car and thinking, "okay it's cool, I can drive a car already, I don't need to read the manual..." And then of course you realize some things are done differently, then you read the changelog, and discover in the meantime a feature you never knew had been added, so you figure you'll read the entire changelog to spot other hidden features, and all you end up finding is easter eggs... :P

Oh my... Chambers... of... Shaolin... It's so great, I can't focus on this post... Too bad the Amiga version sounds so dull(http://www.youtube.com/watch?v=yG9ppmpuYTE#)...
Quote
Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.
Sure!
I'll have a look tomorrow...
Title: Re: New revs
Post by: Arantor on September 12th, 2010, 01:22 AM
Quote
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()?
When it comes to having it in a random file that seems disjointed, or at least tied to the behaviour in which it is most directly used, I'd rather have it attached to where it is used.

There is no use within SMF/Wedge where preparsecode is used where the content hasn't come from the editor. Sure... it could come from a feed or a mod, but in that case it's still coming from an arbitrary place. As far as I'm concerned, we talking about the function being just in a file, versus being with the code that hands content to it.

For me it's a step towards creating some semblance of order where, right now, I don't really see it.

I'd like to think we can make a useful changelog for people much like the AeMe one, in a way that's fun as well.
Title: Re: New revs
Post by: Nao on September 12th, 2010, 01:36 AM
Quote from Arantor on September 12th, 2010, 01:22 AM
Quote
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()?
When it comes to having it in a random file that seems disjointed, or at least tied to the behaviour in which it is most directly used, I'd rather have it attached to where it is used.
Fine, but... In an editor object?
Look at Aeva-Media.php... It has the media object in it. See the extList function? I put it outside the object because I was getting errors when running in strict mode (dunno why.) Still, I think it's better in that place because basically it was mainly unrelated to the media object and made no use of it. The function is still in the better file, but doesn't have to be in the object itself.
Quote
There is no use within SMF/Wedge where preparsecode is used where the content hasn't come from the editor. Sure... it could come from a feed or a mod, but in that case it's still coming from an arbitrary place. As far as I'm concerned, we talking about the function being just in a file, versus being with the code that hands content to it.
Is this, anyway, really going to help the adding of TinyMCE, CKEditor etc?
Quote
I'd like to think we can make a useful changelog for people much like the AeMe one, in a way that's fun as well.
Of course we can :) If only for us to keep track of what makes Wedge great!
Title: Re: New revs
Post by: Arantor on September 12th, 2010, 02:14 PM
Yes, in an editor object, because the only time I ever actually saw it used outside of coming from the editor was for shoutboxes.
Quote
Is this, anyway, really going to help the adding of TinyMCE, CKEditor etc?
Yes, now the underlying reason. Code that comes from one of those will need some kind of treatment before it can be saved - I don't know about you, but I'm hesitant to trust anything from the user. Don't care what it is, I don't want to trust it without some kind of processing.

I need to sit down and look at exactly what is sent, to figure out what changes are going to be necessary to the preparse routine, but some changes *are* going to be required, and having all the code in one place means it's possible to keep all the related behaviour together.

I'm not sure yet exactly we'll handle the editors, whether we just have one only, or multiple (since that was something YSF wanted), or fix up the WYSIWYG editor in some fashion, so I haven't yet made it trivial to switch behaviours, but having the class structure will make it easier in the long run.
Posted: September 12th, 2010, 01:47 AM

Revision: 89
Author: arantor
Date: 01:17:59, 12 September 2010
Message:
! Change 'stars' to 'rank images' (including renaming the star*.gif files though left the table column alone) (yabbse_to_smf.sql, install_2-0.sql, upgrade_1-0.sql, ManageMembers.english.php)
----
Added : /trunk/Themes/default/images/rank.gif (Copy from path: /trunk/Themes/default/images/star.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankadmin.gif (Copy from path: /trunk/Themes/default/images/staradmin.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankgmod.gif (Copy from path: /trunk/Themes/default/images/stargmod.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankmod.gif (Copy from path: /trunk/Themes/default/images/starmod.gif, Revision, 87)
Deleted : /trunk/Themes/default/images/star.gif
Deleted : /trunk/Themes/default/images/staradmin.gif
Deleted : /trunk/Themes/default/images/stargmod.gif
Deleted : /trunk/Themes/default/images/starmod.gif
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/other/converters/yabbse_to_smf.sql
Modified : /trunk/other/install_2-0.sql
Modified : /trunk/other/upgrade_1-0.sql

(ticket 36)
Posted: September 12th, 2010, 02:18 AM

Revision: 90
Author: arantor
Date: 04:16:31, 12 September 2010
Message:
+ Dropdown user menu added (Display.php, Display.template.php, index.english.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/topic.js

It's not overly pretty, but I think it's better handled than my original mod; firstly, it doesn't show in wireless when it isn't meant to, and it is now JS controlled, but the JS isn't particularly elegant - and for some reason it's not dropping smf_scripturl into the URL when it begins with ? - I didn't see a need to spell out $scripturl every time in the array. Note that since PHP 5 rather than 5.1 or 5.2 has been stated, I'm using a homebrew limited version of json_encode to pump the array of data.

I also didn't have the catbg header bar I had before, didn't see a need to throw that into the mix as well. Works in FF and Chrome, too late tonight to test any more (or debug that last oddity)
Posted: September 12th, 2010, 05:19 AM

Revision: 91
Author: arantor
Date: 12:41:48, 12 September 2010
Message:
! Actual fix for who's online glitch (removing previous fix too) (Who.php, Who.template.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Who.template.php
Posted: September 12th, 2010, 01:42 PM

-sigh-

I just realised my fix works for those folks who use JS but not for those who don't. Argh, why did they do it the stupid way they did it? (One form, two dropdowns, and never checking between the two sets of values)

Revision: 92
Author: arantor
Date: 13:13:44, 12 September 2010
Message:
! Additional fix to who's online for non JS users (Who.php, Who.template.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Who.template.php
Title: Re: New revs
Post by: Nao on September 12th, 2010, 04:17 PM
I'm not very confident that we can actually keep both the internal Wysiwyg editor AND add support for others without too much hacking, but I'll let you play with it if you want ;) I wouldn't mind only supporting external editors, myself.

BTW, what tool do you use to do your site-wide searches, and search & replace events?
Personally, I'm with very old tools (outdated?): Super Text Search for searches (supports regex so I kept it so far), and BK ReplaceEm for search & replace.

Also, in PersonalMessage.php:
Code: [Select]
// Changing view?
if (isset($_REQUEST['view']))
{
$_GET['view'] = (int) $_GET['view'];
Is it wanted? $_REQUEST then $_GET? Not logical to me...

On to the boring stuff... (Haven't tested user menus yet. Excited about 'em.)

rev 93
- Removed support for Konqueror. (Load.php, Subs.php, Admin.template.php, Packages.template.php)
- Removed support for some browser version numbers: Opera 9/10, Firefox 1/2/3, as they're not known to have specific issues. Added user agent in $context['browser']['ua'] for modders to get a clean way to search for specific version numbers. (Load.php)
* After looking through Who.php, I realized I'm also an isset-nazi. Starting work on merging isset() && isset() calls together. (Subs-Editor.php, Subs-List.php, Subs-Menu.php, Subs-MessageIndex.php, ViewQuery.php, Who.php, Post.template.php, Wireless.template.php)
+ Added a msnbot (Bing) check in possibly_robot, but it should be useless anyway. Maybe just in case they decide to add "Mozilla" in their user agent string... (Load.php)

rev 94
! I don't know what a profie is... Is it a profitable profile? (Display.php, index.english.php)
- Deleted im_switch.gif. Goodbye, and please don't call, we won't miss you. (im_switch.gif, Help.template.php)
* Spacing nazi (index.css, Display.template.php, topic.js)
Title: Re: New revs
Post by: Arantor on September 12th, 2010, 04:52 PM
Quote
I'm not very confident that we can actually keep both the internal Wysiwyg editor AND add support for others without too much hacking
Neither am I and that wasn't the plan. The current editor is... broken. So either we fix it or we kill it and replace it a new one. A better one.
Quote
BTW, what tool do you use to do your site-wide searches, and search & replace events?
Notepad++
Quote
Also, in PersonalMessage.php:
Yeah, implemented that one in a bit of a hurry (I think I said it was ugly). Should be $_GET really, and I don't think I did it as a form submit because of the rest of the form on the page. Though perhaps something properly AJAXish would be better? (And more prone to breaking on custom themes). In any case I'm so used to SMF interchanging $_REQUEST, $_GET and $_POST for the wrong reasons :(

Haven't looked at the changes yet, but all sounds good to me.
Title: Re: New revs
Post by: Nao on September 12th, 2010, 06:49 PM
rev 95
! upgrade_2-0.sql file didn't get deleted after an upgrade process. (upgrade.php)
! Fixed Display template showing an error next to a guest poster. It currently links to a dummy URL, will fix when I had proper support for this Noisen.com feature. (Display.php)
* Moved conversation selector from left to center in PM homepage, as it takes less space there and might be placed more logically this way. But am I to talk... (PersonalMessage.template.php)
* Changed possibly_robot again, to use preg_match() and more generic search terms. (Load.php)

(Feel free to discuss!)
Title: Re: New revs
Post by: Nao on September 12th, 2010, 10:25 PM
rev 96
+ Re-implemented pseudo-'link' for guests in Display page, for alternative themes. (Display.php)
* Tweaked a couple of language entries. (index.english.php)
* Spacing nazi. (ManagePermissions.template.php)
Title: Re: New revs
Post by: Nao on September 13th, 2010, 10:27 AM
rev 97
* Changing $_REQUEST to $_GET where logic says so. (PersonalMessage.php)
! Class typos. (ModerationCenter.template.php, Packages.template.php)

Next rev will change all <h[34] class="*bg" to remove the bg class, as they're all enclosed within cat/title_bars anyway, and this can be styled accordingly.
Title: Re: New revs
Post by: Nao on September 13th, 2010, 05:17 PM
rev 98
* Removed catbg and titlebg classes from all h3 and h4 tags, and updated styling to match this. (Class-Editor.php, ManagePaid.php, index.css, admin.css, ie6.css, ie7.css, rtl.css, plus most template files.)
- Deleted title_barIC class, as it's only used in the information center and there's really no point in having a separate styling for it. (index.css, BoardIndex.template.php)
- Deleted catbg2 and catbg3 classes (unused in Curve.)
* Changed header font to Georgia, for a change really. Will change to something else later. (index.css)
@ Warning! index.css is a work in progress -- I'm currently trying to separate legacy emulation of corners into a new file that will be included through JS, and I need some time to make sure it's usable.
@ In non-compat mode, the titlebg class is now a bit brighter. I like it better this way...
Posted: September 13th, 2010, 05:15 PM

rev 99
- Deleted all occurrences of menu_gfx.png (replaced with menu.png and buttons.png files, respectively, buttons.png being called only on non-compat browsers.)
Title: Re: New revs
Post by: Nao on September 13th, 2010, 05:25 PM
rev 100
* Updated to SMF rev 10105. And Wedge reaches rev 100...
  ! Clean up package servers (PackageGet.php)
  ! Topic moderation logs were not listed on mod report details page. (ModerationCenter.php) [Bug 4419]
  ! 'moderate_board' permission does not really make sense for guests (ManagePermissions.php) [Bug 4460]

(They also included the topic participation patch I offered. Obviously I didn't reinclude it here ;))
Title: Re: New revs
Post by: Nao on September 13th, 2010, 08:53 PM
rev 101
* Moved border-radius compatibility code to old.css, and loading it dynamically if needed via JS. Bit cleaner... (script.js, old.css, index.css)
- No longer deleting the wrc and rrc classes on old browsers -- only nulling them. (script.js, old.css)

(How's your Tardis search going?)
Title: Re: New revs
Post by: Arantor on September 14th, 2010, 12:33 AM
OK, now I'm back from tidying the house (and it's still not finished), I'll sit and review everything, but you HAVE been busy.
Title: Re: New revs
Post by: Nao on September 14th, 2010, 01:27 AM
Don't bother about the unnamed template files in rev 98 -- they're really super boring. I checked them all, there's approx. 300-400 lines changed, always the same (<h3 class="catbg"> -> <h3>)
Title: Re: New revs
Post by: Arantor on September 14th, 2010, 11:14 AM
I just checked everything as a unified diff from where I was to current, seeing all the changes as the total sum of changes per file. Looks good to me.



Revision: 102
Author: arantor
Date: 10:13:32, 14 September 2010
Message:
+ Code documentation (Subs-Sound.php)
----
Modified : /trunk/Sources/Subs-Sound.php
Title: Re: New revs
Post by: Nao on September 14th, 2010, 11:18 AM
Good then.
Hey we commit a few minutes apart from each other, eheh.

rev 103
* Restored topslice/botslice/upperframe/lowerframe classes to index.css, to preserve compatibility with mods -- for now. (index.css, old.css)
* Moved border-radius emulation code to theme.js, where it'd probably better be. (script.js, theme.js)
* Speeded up the on-the-fly image resizer initialization on modern browsers, by calling only images with a 'resized' class. (theme.js)

Should I be checking your code documentation? I really suck at docs...
Title: Re: New revs
Post by: Arantor on September 14th, 2010, 11:31 AM
Quote
Should I be checking your code documentation? I really suck at docs...
Up to you. That one was particularly dull to document, just threw it together last night before going to bed.
Title: Re: New revs
Post by: Nao on September 14th, 2010, 11:57 AM
Documenting is your thing :P
I, myself, will rather strive to simply comment my code because it's probably my weakest area... I realized that when I went through Aeva Lite the other day to add a feature for YouTube compatibility, only to realize an hour later that it was ALREADY implemented :lol:
Title: Re: New revs
Post by: Arantor on September 15th, 2010, 05:18 AM
You'll likely find it easier to get into once more of the source is documented. I'm gonna do Errors.php next, did a bit of it earlier before going back to bed. More to follow if I manage to get enough of the house tidy that I don't get murderalised for going back to bed...
Posted: September 14th, 2010, 05:01 PM

Revision: 104
Author: arantor
Date: 02:56:44, 15 September 2010
Message:
+ More code documentation (Errors.php)
----
Modified : /trunk/Sources/Errors.php
Posted: September 15th, 2010, 03:57 AM

Revision: 105
Author: arantor
Date: 04:18:21, 15 September 2010
Message:
+ More code documentation (LockTopic.php)
----
Modified : /trunk/Sources/LockTopic.php
Title: Re: New revs
Post by: Nao on September 15th, 2010, 08:59 PM
(The usual boring series...)

rev 106
* Finished converting isset() && isset() occurrences to isset(..., ...) (convert.php, upgrade_1-1.sql, upgrade_2-0.sql, MessageIndex.template.php and 40 source files)
Title: Re: New revs
Post by: Nao on September 16th, 2010, 01:48 AM
rev 107
! Fixed button strips in both CSS3 and emulation. (index.css, old.css)

The main menu fixes will be for tomorrow. (They're using the same concept as button strips, so it's basically the same work.)
I also need to make sure cat_bar and window_bg work the same in both css3 and non-css3 modes.
/meis tired.
:edit: Uh, apparently cat_bar is good!
Posted: September 16th, 2010, 12:05 AM

rev 108
* Replaced titlebg.png and catbg.png with a single file that is even smaller in size. (index.css, bars.png)
Title: Re: New revs
Post by: Arantor on September 16th, 2010, 04:44 AM
Revision: 109
Author: arantor
Date: 02:53:03, 16 September 2010
Message:
+ More code documentation (Karma.php, Printpage.php)
----
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/Printpage.php
Posted: September 16th, 2010, 03:53 AM

Revision: 110
Author: arantor
Date: 03:44:02, 16 September 2010
Message:
+ Further code documentation (DumpDatabase.php, Subs-MessageIndex.php)
----
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Title: Re: New revs
Post by: Nao on September 16th, 2010, 04:47 PM
rev 111
* Some cosmetic fixes to a couple of icons. (stats_posters.gif, stats_replies.gif)
! On very short posts, the poster information area could overflow. (index.css)
! Icons inside bars were a bit too close to the top of the bar. (index.css)
! .title_bar h4 bars were a bit too tall. Why just them, I don't know. Don't ask. (index.css)
- Removed a couple of h3/h4 related styles that didn't seem to be of any use. (index.css)

(At this point, I feel like I'm a themer, rather than a coder...... Don't worry, it won't be forever :P)
Title: Re: New revs
Post by: Arantor on September 16th, 2010, 09:42 PM
Revision: 112
Author: arantor
Date: 20:41:41, 16 September 2010
Message:
! Stupid documentation fixes (DumpDatabase.php, Karma.php, LockTopic.php, Printpage.php, Subs-MessageIndex.php)
+ New code documentation (BoardIndex.php, Xml.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/LockTopic.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Xml.php
Title: Re: New revs
Post by: Nao on September 16th, 2010, 10:15 PM
rev 113
* Dozens and dozens of comma fixes... You gotta love the spacing nazi, eh? And I didn't even do them all. It's boring, even for me. (Don't you dare ask me for a file list.)

Seriously, that's plenty of files. The diff patch is relatively short though, so if you want to analyze the changes, please do it through a diff ;)
Title: Re: New revs
Post by: Nao on September 17th, 2010, 01:20 AM
rev 114
* Updated to SMF rev 10119. Got a lot of conflicts... We're getting away from the SMF2 code quick!
  + * Avatars and other packages removals missed session vars (Package template) [Bug 4463]
  + ! Small cleanup and tweaks [Bug 4461]
  + ! Fix attachments boxes cleanup for Safari [Bug 4470]
  + * Variant selection was disregarded when previewing a theme. (Themes template) [Bug 4433]
  + * Redirect back to the post instead of board, after reporting a post. (Display.php, MessageIndex.php, SendTopic.php, Display template, MessageIndex template) [Bug 4452]
  + ! Adjusted the URL for the arin whois service to reflect its new location. (Profile-View.php) [Bug 4464]
  + * Incorrect label assignment in Reattribute User Posts section. (ManageMaintenance template) [Bug 4467]
  + ! Restoring moderate_board permission for guests. (ManagePermissions.php)
  + * Ignored members' posts were not hidden in topic summary. (Post.php, Post template, Xml template) [Bug 4466]
  + * Variant selection was broken with reserved variant names. (Themes template) [Bug 4435]

And that annoying "Ignore User" feature is adding more bloat to SMF... (Check out the extra xml line in Xml.php, for instance.)
Title: Re: New revs
Post by: Arantor on September 17th, 2010, 01:36 AM
Bug 4463 and 4464 were ones I already patched? Though 4464 had some extra bits in the notes about being cleaner than what I did?
Title: Re: New revs
Post by: Nao on September 17th, 2010, 05:19 AM
- 4464 provides a different URL compared to yours. If doesn't have "query.do" in it, and is cleaner. I haven't tested it, but I suppose it's the official URL.
- 4463, as I said elsewhere, adds an extra check somewhere.

Rest of the interleaved patches -- didn't apply, and didn't document. I left everything in the changelog.txt file, though (for what it's worth, since the file will be going away ASAP.)
Posted: September 17th, 2010, 01:39 AM

rev 115
! For an unknown reason, the Post template wasn't correctly updated, even though I did it manually in the first place... (Post.template.php)
Title: Re: New revs
Post by: Nao on September 17th, 2010, 05:17 PM
rev 116
- Removed a PGSQL fix that doesn't sound very logical with MySQL. (Profile-View.php)
! Finally fixed menu items. Wedge's template is finally entirely pixel-perfect and CSS3-driven if available! (Profile-View.php)
Title: Re: New revs
Post by: Nao on September 18th, 2010, 01:46 PM
rev 117
! Fixed IE6 emulation code for rounded corners. (theme.js)
- Deleted insertAfter() function and moved a replacement to theme.js because, well, I don't think it'll be used much... (script.js, theme.js)
* We don't really need to obfuscate copyright checking code anymore, do we...? (Subs.php)

FWIW, Wedge doesn't look great with IE6, but it's only details (like a repeating background on roundframes where it shouldn't repeat...), nothing that can't be fixed if we're really anal about them.
Title: Re: New revs
Post by: Nao on September 18th, 2010, 05:19 PM
rev 118
* Replaced SMF's menu system with own. Warning, work in progress! GenericMenu needs cleaning up, GIFs could be sprited, etc. (ie6.css, index.css, GenericMenu.template.php, script.js, submenu.gif, subsection.gif)
Title: Re: New revs
Post by: Nao on September 18th, 2010, 11:58 PM
rev 119
* Finished implementing a workaround for the iPhone's lack of onmouseover()/onmouseout() in the new system. New code is particularly cool, and I'm not saying that because I spent my entire day on it. Ah well. (script.js, ie6.css, index.css)
! Forgot to indent HTML code for menu. Originally needed to be in a block because of a IE6 bug. (GenericMenu.template.php)
! Spacing nazi. (Recent.template.php)
Title: Re: New revs
Post by: Nao on September 19th, 2010, 05:01 PM
rev 120
* Replaced default SMF logo with a Wedge logo... Might as well do it, uh? Need to replace all smglogo occurrences in the source code. (install.php, index.css, rtl.css, wedgelogo.png, index.template.php)
+ Added a menu file I forgot. (white-op85.png)
! Fixed menu system to be able to handle several menus at the same time. (script.js, index.css, GenericMenu.template.php, ie6.css)
! .cat_bar h4 used a dark text color. Should be a bright one, given the background context. (index.css)
* Implemented the new menu system for SMF's main menu. Yay! (index.css, index.template.php)
@ To do: finish Wedge logo replacements, delete template_old_menu, harmonize Subs-Menu.php and Load.php menu generators (why are there two to begin with?!), change menu CSS to harmonize it with Curve, fix non-breaking minor glitch in menu system in IE6. And get started with the on-the-fly sidebar-menu transformation...

(Sorry that I'm fixing several issues in a single shot, but I kinda can't commit index.css in several portions, that would be dull...)

(Also, I'm not used to committing commented out or useless code, but I'd rather keep template_old_menu under the hand just in case I need to refer to it when doing further work.)
Title: Re: New revs
Post by: Nao on September 20th, 2010, 01:00 PM
rev 121
* Improved menu styling. (index.css)
* Merged menu arrows into a single file. (submenu.gif, subsection.gif, menu.gif)
* Cleaning up. (script.js)
! Fixed padding in live_news box. (admin.css)

(Ain't done yet!)
Title: Re: New revs
Post by: Nao on September 20th, 2010, 08:44 PM
rev 122
* More menu styling changes. It's starting to look better, now... (index.css, script.js)
* Updated to SMF rev 10121. SendTopic lines were screwed up, BTW... (Class-Editor.php, SendTopic.template.php, PersonalMessage.template.php, MessageIndex.template.php, Display.template.php)
@ I decided not to go with bugfix 4446. Personal choice...

http://dev.simplemachines.org/mantis/view.php?id=4446
Title: Re: New revs
Post by: Arantor on September 20th, 2010, 10:37 PM
Revision: 123
Author: arantor
Date: 21:31:00, 20 September 2010
Message:
+ Code documentation and a half (Post.php)
----
Modified : /trunk/Sources/Post.php


This added 130 new lines of documentation, and replaced the 60 or so incomplete lines there anyway...


@ Nao, I looked at bug 4446, I'm not sure what was actually applied - but is there a better fix than they've discussed? (CSS is not my forte) Or at least, one that is better for us?
Title: Re: New revs
Post by: Nao on September 20th, 2010, 11:04 PM
Well, the proposed fix was to apply overflow: hidden to .post_wrapper, which is EXACTLY what was already done on Wedge... (I don't know if I did it -- I probably did, although I don't remember.) I didn't know about this bug report until I looked into the fix.
What was done instead, was to apply float: left; width: 100% to the class.
However, I applied this to wedgeforum.com and noisen.com, and the windowbg/windowbg2 classes ended up getting a height of 0px, and the contents were overflowing from them obviously. I re-established my overflow, and it worked again. So I figured, to hell with this fix... I prefer mine. While Antechinus says it "doesn't work on every browser", in my experience it does. Even in IE6... Specifying an overflow setting has saved me from numerous issues with floating divs, really.
Title: Re: New revs
Post by: Arantor on September 20th, 2010, 11:06 PM
Then as far as I'm concerned your solution is better and works more in a way that works for us :) Yay for diverging routes!
Title: Re: New revs
Post by: Nao on September 20th, 2010, 11:27 PM
Given that I have to edit everything manually everytime they change a template (because of the header changes), I'm getting used to diverging routes... ;)
Title: Re: New revs
Post by: Arantor on September 21st, 2010, 03:05 AM
Revision: 124
Author: arantor
Date: 01:50:45, 21 September 2010
Message:
- Remove the help stuff:
 - Remove the action=help itself (index.php, Help.php)
 - Remove the menu item (Subs.php)
 - Remove the no-longer-used templates (Help.template.php)
 - Remove the no-longer-used text strings (Who.english.php, Manual.english.php removal entirely)
 - Remove semantic links to the page (index.template.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/index.template.php
Deleted : /trunk/Themes/default/languages/Manual.english.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php


Revision: 125
Author: arantor
Date: 01:53:19, 21 September 2010
Message:
! Revert commit of install.php, did not intend to commit local use changes.
----
Modified : /trunk/other/install.php



I didn't actually mean to commit install.php in r124, because that's my modified version to handle the UTF-8 changes... so I've reverted it. But really, it shouldn't be a problem (and you can see what I did in r124) - the sole idea was to bump the minimum MySQL version to 4.1.0 and just make it install without complaining such that if UTF-8 was ticked (and it was by default), that it would install it. (Right now, it really doesn't work properly, but it's a non issue for testing purposes)
Posted: September 21st, 2010, 02:55 AM

Revision: 126
Author: arantor
Date: 02:05:25, 21 September 2010
Message:
+ Added Yandex to the list of supported search engines (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql
Title: Re: New revs
Post by: Nao on September 21st, 2010, 12:26 PM
Good job.

You forgot to mention this one you committed:
rev 127
+ Added the ability to override banned users' avatars and simply hide them. More options will follow, hence building it like this. (ManageAttachments.php, Load.php, Admin.english.php, Help.english.php)

Also, as discussed earlier:

rev 128
- Removed converters folder, because right now we're only planning on supporting conversion from SMF2. Once it's ready, anyone can go from their forum system to SMF2, and then to Wedge.
Posted: September 21st, 2010, 12:22 PM

rev 129
- Deleted help_convert folder, as it's obviously a very outdated system related to the help templates.

(If you look at the copyright, it says Lewis Media 2006... I doubt it was updated after that!)
Title: Re: New revs
Post by: Nao on September 21st, 2010, 07:36 PM
rev 130
* Renamed MSN bot to Bing. (install_2-0.sql)
* Some help-related cleaning up. (*.dtd, Help.php)
- Dropped hover addon function for IE, because the new menu is cool and doesn't need that. (theme.js)
- Dropped rounded corner compatibility code, because... Well, screw IE! (index.css, old.css, theme.js)
- Dropped compat.css, in the same vein, because... Well, it sucks as a converter.
- Removed .rrc class from all templates. (Admin, BoardIndex, Calendar, Display, Help, Login, Memberlist, Notify, PM, Poll, Post, Profile, Register, Reminder, Search)
* A couple of fixes to IE6 layout, and IE7 cleanup. (ie6.css, ie7.css)
* Redesigned Curve layout. Mostly for the menu system. (index.css, menu.png, white-op85.png, grad*.png)
* Restarted menu layout code from the original SMF code, in a cleaner way. (GenericMenu.template.php, index.template.php)
@ TODO: Delete main_block.png, deal with rtl.css, and more cleanup.

Pete, hopefully you won't have the design changes too much! Remember, it's a work in progress. The header is to be redone. I just wanted to get rid of the SMF frame ASAP and couldn't find a suitable replacement!
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 11:21 AM
A cleanup commit entiely...

rev 131
- Deleted help area styling. (index.css, rtl.css)
- Deleted rounded corner compatibility code... For good!! (theme.js)
- Deleted tags when an ID is specified for them, as it's useless and hurts performance. (index.css, rtl.css, admin.css)
- Deleted topslice_quote and botslice_quote placeholders from quotes, because, well... If you're going to emulate rounded corners, you don't need them. And don't tempt me into deleting the quotefooter placeholder entirely! (Subs.php)
* Renamed left_adm* and main_adm* classes because they're generic, not admin-centered. (index.css, rtl.css, ie6.css, GenericMenu.template.php)
! Fixed a few issues with rounded corners. (SplitTopics.template.php)
* Moved style.css linking a few lines above in the head section, so that the browser will notice it sooner in case the HTML page isn't gzipped. (index.template.php)
* Spacinazi. (PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 07:39 PM
I'll commit today's changes ASAP. I'm not sure I'm done yet but my time for today is up.
I've also internally updated to the SMF rev 10127... Norv has started documenting the files! Well, by "documenting", I mean "replacing the "// !!!" with single-line descriptions of the functions ;)
Title: Re: New revs
Post by: Arantor on September 22nd, 2010, 07:45 PM
Quote
Norv has started documenting the files! Well, by "documenting", I mean "replacing the "// !!!" with single-line descriptions of the functions
I wouldn't really call that documentation. I would, however, call the awesomeness in Post.php documentation :P
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 10:05 PM
Indeed! At last, you found a place to express the endlessly-fuelled creativity of your talkativeness. :eheh:
Title: Re: New revs
Post by: Arantor on September 22nd, 2010, 10:08 PM
Quote from Nao/Gilles on September 22nd, 2010, 10:05 PM
Indeed! At last, you found a place to express the caffeine-fuelled creativity of your talkativeness. :eheh:
Fixed that for you :P But yes, yes I did.
Title: Re: New revs
Post by: Nao on September 22nd, 2010, 11:42 PM
Eheh.

http://dev.simplemachines.org/mantis/view.php?id=4471
This is an incomplete report, and it's been fixed in an incomplete manner... There are dozens of places where the icon class isn't applied. I noticed that while removing the ie6_header... And then I thought, "what's the point of that anyway? I never see more than one icon per header... So we can just as well access it with .cat_bar img, .title_bar img, it'll save a few bytes each time...
Anyway, I started removing icon classes earlier today. Do you think it's okay if I keep doing it? I really don't see a reason for keeping these in... (And I can't reopen reports to tell them. Which is why I was complaining originally that I was put into a minor group on the tracker...)
Title: Re: New revs
Post by: Arantor on September 23rd, 2010, 04:33 AM
Quote
This is an incomplete report, and it's been fixed in an incomplete manner
Status normal, captain.
Quote
I never see more than one icon per header
That's because it never happens. Many headings don't even have one. That said I'm not sure off the top of my head if cat_bg that is collapsible with a left icon, might not use icon for the upshrink (if that makes sense)? Either way, those cases will be pretty few and far between, and can be fixed if we find them - I'd say you're completely good to clear yet more cruft.
Posted: September 22nd, 2010, 11:45 PM

Revision: 132
Author: arantor
Date: 23:32:18, 22 September 2010
Message:
! Fix for editor generating extra divs when using custom div mode. (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php

Posted: September 23rd, 2010, 12:33 AM

Revision: 133
Author: arantor
Date: 23:35:04, 22 September 2010
Message:
! Fix error in SQL installer, with forgotten parameter (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql


This one was stupid. I missed the 4th parameter in the insert query.
Posted: September 23rd, 2010, 12:35 AM

Revision: 134
Author: arantor
Date: 03:32:35, 23 September 2010
Message:
+ Code documentation (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 11:55 AM
(Just getting rid of the quick update... Take note of my outrageous way to diminish the SMF team in a passive-aggressive way :P Interesting that it's happening on post #666 for me... Hmm.)

rev 135
* Updated to SMF rev 10127. Just a fix I reported, a minor security issue with word censorship, and some documentation which Pete will be rewriting from scratch anyway. (changelog.txt, install.php, create_backup.php, restore_backup.php, Admin.php, Class-Package.php, DbExtra.php, DbPackages.php, DbSearch.php, Display.php, Groups.php, LogInOut.php, ManageSearch.php, PackageGet.php, Subs-Database.php)
Title: Re: New revs
Post by: Arantor on September 23rd, 2010, 01:13 PM
Well, I was curious to see what documentation he'd done.
Quote
string function smf_db_get_version()
      - get the version number.
No shit! Still one line of description is better than none.
Quote
void QuickInTopicModeration()
      - in-topic quick moderation.
Or not, maybe. Literally taking the function name and re-ordering it to make a different phrase sort of isn't the plan.

And when you have a load of functions in one file, generally it's best to document everything, or at least put placeholders in (not like Subs-Database.php where only the first function has a description)


The security change... hmm, why does that look familiar? I guess he listened to what I proposed :)
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 02:35 PM
Y'know, there are people who hate documenting more than anything... ;)
I made my Kyodai Mahjongg help files under WordPad (sic), in RTF format (sic), and had to do both English and French versions at the same time (as for everything I do really), and didn't have a diff compare tool at the time... Oh, what fun it was!

Anyway... Finally!!

rev 136
@ The patch equivalent weighs in at 92KB... Yay.
@ This is only about templates, so add ".template.php" to the filenames.
- Replaced these horrible ie6_header/floatleft hacks with some actual common sense. Needs testing on all browsers! (Admin, BoardIndex, Display, GenericList, GenericMenu, Login, ManageMaintenance, ManageMembers, ManageNews, ManagePermissions, Memberlist, ModerationCenter, Notify, Packages, PersonalMessage, Profile, Recent, Search, SendTopic, Stats, Themes, index.css, ie6.css)
- Deleted png_fix and newupshrink classes/ids, which were not even used in a vanilla SMF2... (Admin, index.css)
- Deleted all img.icon classes, as they're all used within a title_bar/cat_bar and were replaced with contextual styling. (BoardIndex, Display, GenericMenu, Login, ManageNews, Memberlist, Notify, Packages, Profile, Recent, Search, SendTopic, Stats, Themes, index.css, admin.css, index.css, ie6.css, rtl.css)
* Added cellspacing="0" to table_grid declarations missing a cellspacing, and reverted table_grid border-collapse to separate, so that table headers can be properly rounded in a standards-compliant fashion. Also deleted border="0" declarations, as borders are set to 0 by default. (Admin, Errors, ManageBans, ManageMembergroups, ManageMembers, ManageNews, ManagePaid, ManagePermissions, Memberlist, ModerationCenter, Packages, PersonalMessage, Profile, Reports, SplitTopics, Stats, Themes, index.css)
! Fixed isset($config_var['postinput']) into !empty, as it was always set and would thus generate an extra tab in the HTML code. (Admin)
* Moved menu/sidebar toggle to the left... I say it's a matter of logic. Now if you'll stop bothering me, I'm busy writing this changelog... (index.css)
* Renamed generic menu classes, from their adm* and admin equivalents, as generic menus are supposed to be... generic. (GenericMenu, index.css, rtl.css)
* Spacing. (ManageBoards, Packages, PersonalMessage, Search)
* Moved profile summary's boxes a bit lower. Ideally, I should be doing this for every box that touches any dual-colspan cat_bar/title_bar... (index.css)
* Gave more padding to the hosted avatar selector. Seriously, were they asleep or something when they designed this? (index.css)
* Improved overall design. I'm actually starting to like it... I said started. Got rid of min-height in header (a leftover from the earlier frame). (index.css)
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 07:53 PM
Quote from Nao/Gilles on September 23rd, 2010, 02:35 PM
* Moved menu/sidebar toggle to the left... I say it's a matter of logic. Now if you'll stop bothering me, I'm busy writing this changelog... (index.css)
Well, I was busy a lot... So much that I forgot that I'd put it back to the right of the screen after I noticed it didn't play well with most browsers :P
Will have to fix this at some point...
Title: Re: New revs
Post by: Nao on September 23rd, 2010, 11:35 PM
rev 137
! Fixed a good part of the RTL issues. Missing button strips, have yet to check more specific areas. (index.css, rtl.css)
! Fixed submenu positions in RTL mode. (script.js)
* Moved extra stylesheets to the top of the header, too. (index.template.php)
Title: Re: New revs
Post by: Nao on September 24th, 2010, 11:43 AM
rev 138
! Fixed capacity bar in PM area. (index.css)
! Added an overflow hack to cat_bar/title_bar to avoid any annoying float glitches in the future. I'd rather not use it, though. (index.css)
* Renamed 'MSN Messenger' to 'Live Messenger' in the language files. (Internally, it's still the same old horrible MSN Messenger.) (index.english.php, Profile.english.php)

Re: the overflow hack, this is a simple one I've been advocating to the SMF team and they always say "it doesn't work everywhere" (even though it does...) and they wouldn't use it (even if they use it in their own title_bar/cat_bar definition, albeit not in the best way.) The most logical way to avoid float glitches is really to avoid having ONLY floated elements inside a div... But in some cases it's hard to find the right balance. For instance, in the PM box, I tried deleting one of the capacity bar floats, and it didn't look good. So I came back to an all-float thingy, and added a &nbsp; (!!) at the end, and guess what, it worked... Uh. Well, it's still a hack, and I don't know if it's nice. Ideally, I would check all of the floated areas in the source code and fix them all manually.
Then again, maybe the overflow hack is best.

What do you think?
Title: Re: New revs
Post by: Nao on September 24th, 2010, 12:09 PM
rev 139
! Damn IE6's Javascript engine! (Class-Editor.php)
! Fixed Javascript error when viewing a post with no reply permission. (Display.template.php)

(Please don't forget to discuss the post above, though :P In another topic if you'd like...)
Title: Re: New revs
Post by: Arantor on September 24th, 2010, 12:17 PM
OK, I'm going to keep this one short and sweet.

Part of the layout issues SMF has is because of tag soup - so many floated things, so many divs and so on, that you so much as breathe on some bits and it falls apart on you.

There isn't really a best solution as a result - only a collection of least-worst alternatives, and none of them are particularly compelling. What you've got there is probably the least worst of the least worst solutions, without doing something drastic like ripping it all out and using tables everywhere.
Title: Re: New revs
Post by: Nao on September 24th, 2010, 05:07 PM
I don't know. I don't like having to make so many compromises... Here's another one:

rev 140
! A mystic fix for IE's overflow issues in topic pages... .wrc { width: 100% }. Take that! (ie6.css)
* Replaced bars.png with yet another gradient in my arsenal, grad40.png -- this should allow themers to change cat_bar and title_bg background colors on a whim. (index.css)
- Removed theme graphics that were no longer used... :) (backdrop.png, bars.png, frame_repeat.png, main_block.png, menu.png)

I'm not happy with the new cat_bar/title_bar color. And believe me I spent my entire afternoon setting it up. I want to have only one gradient file for both bars. In the end I'll probably change the colors anyway, but I want to have a 'Curve' CSS variant and would like it to be as vibrant as the original. Feel free to change the gradient if you can come up with anything better.
Title: Re: New revs
Post by: Nao on September 24th, 2010, 07:43 PM
Feeling a bit down... Not even css work can help here.

rev 141
* Changed menu hover color. If you can spot a difference, you're holy. (index.css)
* Reworked quotes, so that they don't look half as ugly. (index.css)
* Added a subtle border around cat_bar and title_bar, to make them a bit livelier. (index.css)
* Modified the admin/profile sidebar, because it's one of the ugliest Curve designs ever. Really. I hate cat_bar, but putting them as separators between plain white backgrounds is evil. (index.css, GenericMenu.template.php)
! Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)
Title: Re: New revs
Post by: Arantor on September 24th, 2010, 07:52 PM
Quote
Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)
Awesome, thank you :)
Quote
Changed menu hover color. If you can spot a difference, you're holy.
Do you see the light?!

Jesus H. Christ, I see the light! The band, Elwood, the band!

(Actually no, I haven't looked yet, but if you're saying that, odds are I wouldn't be able to tell the difference)
Title: Re: New revs
Post by: Nao on September 24th, 2010, 08:30 PM
rev 142
- Deleted the quotefast compatibility code for IE5. (Load.php, Post.php, Post.english.php, Post.template.php, topic.js)
! quotefast was called in a couple of places with a never used 'pb' var (it's an actual SMF bug, BTW, when used along with the 'xml' var.) (Post.template.php, topic.js)
* previewPost() should always assume that Ajax is available. (Post.template.php)

So, you're into my last modified fix? I thought you weren't :P Trying to cheer me up I'm sure :lol:
Oh, that BB scene was priceless. I never cared to watch the movie until a couple of months ago. What a treat!
Title: Re: New revs
Post by: Arantor on September 24th, 2010, 11:36 PM
Quote
So, you're into my last modified fix? I thought you weren't
I don't recall ever discussing it but the idea makes a lot of sense :)
Quote
Oh, that BB scene was priceless.
The whole film's pretty good. Note the cameo from Steven Spielburg (himself) as the tax assessor guy right at the end.
Title: Re: New revs
Post by: Nao on September 24th, 2010, 11:59 PM
http://www.simplemachines.org/community/index.php?topic=393528.0

Yeah I didn't notice Spielberg in the first place (no beard, IIRC!), but after I saw the trivia on imdb.com, I went back to the movie and was stunned. Eheh.
Title: Re: New revs
Post by: Nao on September 25th, 2010, 12:45 PM
rev 143
+ Added support for rounded corners for IE 6, 7 and 8, through ie-css3.htc (the only solution that worked for me), and only for wrc and roundframe classes (to save on performance). (ie6.css, ie7.css, ie8.css, ie-css3.htc, index.template.php)
! Forgot to add grad40.png gradient file. Really?
- Deleted roadmap.txt and todo.txt files (early SMF1 stuff.)
* Spacinazi. (GenericMenu.template.php, Packages.template.php)
Title: Re: New revs
Post by: Nao on September 25th, 2010, 07:46 PM
rev 144
* Renamed ie-css3.htc to css3.htc, fixed a couple of crashers in the code[1], and deleted all code related to box-shadow and text-shadow, as we won't be using it. (css3.htc)
* Found a better fix for wrc class not behaving correctly: it simply needed to have layout. Uh. Replaced width: 100% with zoom: 1, so it can be applied to all of its variations. (ie6.css)
+ Added a PNG fix script for IE6 emulation of transparent PNGs and correct background repeat. Believe me, it's a miracle that this thing works. (pngfix.js, index.template.php)
- Deleted ie8.css because it's only two lines, and added them to the index template.
* Moved body styling to a new wrapper, so that the body background can be properly redrawn in IE6. (index.template.php, index.css)
 1. First time in my life I'm fixing a .htc file... Fortunately it's just more JS :p
Title: Re: New revs
Post by: Nao on September 25th, 2010, 08:08 PM
'kay, what's with the dozens of topics updated all of a sudden? :^^;:

rev 145
- Deleted upgrade_1-0.sql and upgrade_1-1.sql, as we're not going to support upgrading from SMF 1.x anyway. (upgrade.php)
- Deleted ability to upgrade from YaBBSE. Did you know it was still in there?! (upgrade.php, Install.english.php)
- Deleted one of the smiley sets, because I have a problem with its name right now. :P
! Fixed a misplaced menu in the admin area in RTL mode. Although it might break sidebars... We'll see about that later. (rtl.css)
Title: Re: New revs
Post by: MultiformeIngegno on September 25th, 2010, 08:41 PM
Quote from Nao/Gilles on September 25th, 2010, 07:46 PM
+ Added a PNG fix script for IE6 emulation of transparent PNGs and correct background repeat. Believe me, it's a miracle that this thing works. (pngfix.js, index.template.php)
Doesn't this affect performances? :blush:
Title: Re: New revs
Post by: Nao on September 25th, 2010, 08:44 PM
Nope... That's why I said it was a miracle.
Title: Re: New revs
Post by: MultiformeIngegno on September 25th, 2010, 08:47 PM
Quote from Nao/Gilles on September 25th, 2010, 08:44 PM
Nope... That's why I said it was a miracle.
Great! :)
Title: Re: New revs
Post by: Nao on September 25th, 2010, 09:36 PM
rev 146
* Put submenu entries on the same line as their LI containers, to make menus a little bit less overwhelming when viewing the HTML source. (GenericMenu.template.php, index.template.php)
+ Added index.php protection to xkcd avatar folder.
* Updated to SMF rev 10141.
  * Minor typos and glitches
  ! The check on package server URL for http:// prefix failed.
  ! Incorrect parameter given for checkImageContents() on avatar uploads.
  ! Members with moderate_forum permission can no longer access Manage Posts admin area.
  * All new replies added via JavaScript were marked as ignored.
  * Fixed secret question page, and overflow error in admin menus.
  ! Tables should be created with SMF's charset and collation
  ! Installing as UTF8 should make all tables UTF8 <-- that's Pete's fix :)
Title: Re: New revs
Post by: Arantor on September 26th, 2010, 06:03 PM
Revision: 147
Author: arantor
Date: 05:03:01, 26 September 2010
Message:
+ First part of the naughty bot prevention code (plenty more to come though)
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php


This adds the whitelisting stuff. Note the use of a constant; this is for use later throughout in a way that can't be tampered with.
Posted: September 26th, 2010, 06:04 AM

Revision: 148
Author: arantor
Date: 14:04:47, 26 September 2010
Message:
! Fix user menu inability to relate to message id (use %msg% in the URL for menu items) (Display.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/scripts/topic.js

Posted: September 26th, 2010, 03:05 PM

Revision: 149
Author: arantor
Date: 15:00:07, 26 September 2010
Message:
! Remove 'send email' from user menu, added 'report to moderator' (Display.php)
- Removed unnecessary passing of current topic page into the send-report code, it wasn't being used for anything (Display.php, Display.template.php, SendTopic.php, SendTopic.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/SendTopic.template.php

Posted: September 26th, 2010, 04:00 PM

Revision: 150
Author: arantor
Date: 16:32:57, 26 September 2010
Message:
! Removed topic class icon column from message index, unread/replies page (MessageIndex.template.php, Recent.template.php)
! Added icon to the subject area (MessageIndex.template.php, Recent.template.php, index.css, 4 new images)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/icons/quick_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_my.gif

Just a few notes.

1. icon1 class has not been removed. I don't *think* it's in use anywhere else.
2. Had to add 4 new images since the lock/stick/both icon in the subject column is a background image. Still, we can if we choose, proceed to ditch some of the images in the topic folder now.
3. I haven't touched the message index footer yet, not sure what to do with that exactly.
4. Topic class is currently still being determined both in the message index and in the topic itself (it's the icon in the top left corner of the topic). Since we're not using it in the message index, we can remove that (I'll do that later if you want, I was just concerned about getting it implemented as-is), but not sure about removing it from the topic yet. Makes little odds to me, I don't even notice it most (any?) of the time.
Posted: September 26th, 2010, 05:36 PM

Revision: 151
Author: arantor
Date: 17:03:07, 26 September 2010
Message:
+ Added new permissions for editing website and signature (independently of any other profile settings) (ManagePermissions.english.php, ManagePermissions.php)
+ Added enforcement of permissions (Profile-Modify.php)
+ Added permissions to edit own website/own signature to regular members and global moderators by default (install_2-0.sql)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install_2-0.sql
Title: Re: New revs
Post by: Arantor on September 26th, 2010, 07:51 PM
Revision: 152
Author: arantor
Date: 18:49:29, 26 September 2010
Message:
! Rearranging the order of Core Features - a feature whose title begins with A should be before something that begins with C. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php


...even if it was originally called 'Custom Profile Fields'... it's now called Advanced Profile Fields. And everything else is in... oh damn. I meant to move search engines too.
Posted: September 26th, 2010, 07:51 PM

Revision: 153
Author: arantor
Date: 18:51:41, 26 September 2010
Message:
! Also move search engines to be in the right alphabetic place (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Title: Re: New revs
Post by: Nao on September 26th, 2010, 08:27 PM
As always, my revs aren't nearly as exciting as Pete's ;) But they must be done, too. And I'm here to do them, whether it rains or snows.

rev 154
+ Introduced #navi to contain the main menu and linktree areas and avoid breaking the menu under IE6 (don't ask.) (index.css, ie6.css, index.template.php)
- Deleted grad350.png, replacing header background with grad250.png because it's been reduced in height anyway. Doesn't look as good when folding it, but the header fold feature will probably be removed in the future anyway.
* Harmonized div.frame paddings, as they're confusing in their current state, and the trick was only useful in a vanilla Curve. (index.css)
! ie8.css was still being called by error. (index.template.php)
* Put linktree items on the same line as their LI parents, just like menu items. (index.template.php)
* Spacinazi. (QueryString.php, Subs.php)
* Saving a few bytes off JS files. (pngfix.js, css3.htc)
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 01:30 AM
Revision: 155
Author: arantor
Date: 23:00:41, 26 September 2010
Message:
! Fixed up outstanding issue with smiley set (install_2-0.sql, Install.english.php)
- Removed remaining topic icon fluff (I think I got it all)
 - Class determination function (Subs.php)
 - Display in the topic view (Display.php, Display.template.php)
 - Fix for alignment of author/title without icon (index.css)
 - Cleaning up topic class in message index (MessageIndex.php, MessageIndex.template.php)
 - And unread/replies (Recent.php, Recent.template.php)
 - And search (Search.php)
 - And the admin panel (ManagePosts.php)
 - And all language strings (FixLanguage.php, Admin.english.php, Help.english.php, index.english.php)
 - And pruning the images that are no longer used (lots, there's still a couple actually used, but 45 gone bye-bye)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/FixLanguage.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Deleted : /trunk/Themes/default/images/topic/hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_sticky.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql


Yeah, this was an exciting commit ;)
Posted: September 27th, 2010, 12:01 AM

Revision: 156
Author: arantor
Date: 23:06:56, 26 September 2010
Message:
! Converted outstanding .icon1 and .icon2 to .icon (index.css, MessageIndex.template.php, Recent.template.php)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css

Posted: September 27th, 2010, 12:07 AM

Revision: 157
Author: arantor
Date: 00:27:57, 27 September 2010
Message:
! Misc typo fixes (smfinfo.php, Subs.php)
+ Error counter log (index.php, Errors.php, ManageErrors.php, Subs.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php
Modified : /trunk/other/tools/smfinfo.php


In case it's not clear what's going on (and it is a little convoluted, if I'm honest) - the logic behind it is that if an error occurs during execution, it adds to a counter, then if there were errors during runtime, save that in $modSettings at the end of runtime. It's far lighter to do that than it is to query it (or query then cache it) every page load, and really if we're honest, the idea is to encourage admins to resolve errors sooner rather than later.
Title: Re: New revs
Post by: Nao on September 27th, 2010, 09:48 AM
rev 158
- Deleted remaining hotTopic vars from install script. (install_2-0.sql)
! Fixed padding issues in main menu. (index.css, ie6.css)

Not much, but I'm quite happy with the main menu now. ;)
Title: Re: New revs
Post by: Nao on September 27th, 2010, 11:32 AM
rev 159
- Deleted some theme compatibility leftovers. Again: Wedge is not compatible with SMF 1.x themes. Use SMF 2.x if you need compatibility. (detailed-version.js, Load.php, Compat.template.php)
- Deleted $settings['separate_sticky_lock'] from index template, as the feature was deleted from Wedge and if it's not supported in the default theme, external themes should deal with it by themselves. (index.template.php)
- Deleted $settings['doctype'], which isn't used in Curve. I don't think it should cause any incompatibilities with future HTML5 themes... (Or use XHTML5, heck.) (index.template.php)
- Deleted leftovers from older themes in language files. (index.english.php)
* Various subtle CSS improvements. (index.css, MessageIndex.template.php, Recent.template.php)
* Spacinazi. (ManageErrors.php, Subs.php, MessageIndex.template.php, Recent.template.php)

(May require a bit of double-checking... I *hope* my logic for separate_sticky_lock is good, because otherwise it means I don't have a damn idea of how themes are supposed to work :P
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 10:16 PM
Revision: 160
Author: arantor
Date: 19:30:42, 27 September 2010
Message:
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
----
Modified : /trunk/Themes/default/scripts/editor.js


I'll take a look at revs 158 and 159 shortly, I just wanted to fix that outstanding issue because it was bugging me. Looking at the code in replacetext from whence I borrowed, IE 6 (and 7?) may not support the change, but IE 8 and Chrome do, and since it's labelled in replacetext as 'Mozilla', I'm assuming FF does, though I haven't tested.
Posted: September 27th, 2010, 08:32 PM

Revision: 161
Author: arantor
Date: 20:51:55, 27 September 2010
Message:
+ Code documentation (ManageRegistration.php)
----
Modified : /trunk/Sources/ManageRegistration.php

Posted: September 27th, 2010, 09:52 PM

Revision: 162
Author: arantor
Date: 21:15:53, 27 September 2010
Message:
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
----
Modified : /trunk/Sources/Themes.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on September 27th, 2010, 10:36 PM
Quote from Arantor on September 27th, 2010, 10:16 PM
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
I have a feeling of déjà-vu... Is it normal? I wanted to do this at some point... Did I suggest it? Did you? Or did someone on the SMF bug tracker, maybe? Nah, I don't think so, I remember once thinking about this while not in front of my PC... Was dying to try implementing that, but forgot afterwards...
Quote
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
Yay! I thought we hardly had anything left to strip at that point...... ;)
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 10:47 PM
You suggested it - http://tracker.wedge.org/?sa=ticket;ticket=41

It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
Quote
Yay! I thought we hardly had anything left to strip at that point......
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)
Title: Re: New revs
Post by: Nao on September 27th, 2010, 10:52 PM
Quote from Arantor on September 27th, 2010, 10:47 PM
You suggested it - http://tracker.wedge.org/?sa=ticket;ticket=41
Phew......!!! I really felt bad about that déjà-vu! :lol:
Quote
It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
IE8 is bitchy with the post editor. Recently Ante committed a fix suggested by whomever I don't remember, which basically replaced the min-width;max-width with a normal width, and added a very high number of cols to the textarea (a hack to make it work.)
Quote
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)
I like it when you do these things.

...

No, it's nothing sexual. For crying out loud.
Title: Re: New revs
Post by: Arantor on September 27th, 2010, 10:56 PM
I saw that hack, I'm still not convinced it would actually work entirely as intended either.
Quote
For crying out loud.
Probably not the best line to say to a Meat Loaf fan...

Meat Loaf - For Crying Out Loud(http://www.youtube.com/watch?v=qHPetLms4ZU#)

"For crying out loud, you know I love you...."
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 03:20 AM
Revision: 163
Author: arantor
Date: 02:19:54, 28 September 2010
Message:
! Moved IP icon and made it tooltip of image (Display.template.php)
+ Made viewing own/any IP address a permission, and ensured it is managed in all the appropriate places (Display.php, ManageMembers.php, ManageMembers.template.php, ManagePermissions.php, ManagePermissions.english.php, Modlog.php, Profile-View.php, Who.php)
- Removed old help tooltip for admin IP viewing (Help.english.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:38 AM
rev 164
* Replaced apache_request_headers() emulation code with a shorter, faster version. (QueryString.php)
! Fixed validation error. (Search.template.php)

(The validation error is also in SMF2, AFAIK. Also, my fix is technically all right, but logically wrong. I'll rewrite it in the next commit, sorry.)
Posted: September 28th, 2010, 09:15 AM

BTW, nice catch on ManageMembers... Fixing the 'cols' into 'columns'. Another SMF2 stock bug...!
Posted: September 28th, 2010, 09:29 AM

$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Posted: September 28th, 2010, 09:36 AM

$txt['permissionname_view_ip_address'] = 'View IP addresses in the main forum';
(And a couple other occurrences)

'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Maybe 'front-end', 'outside the admin area' or something like that..?
Posted: September 28th, 2010, 09:38 AM

Is the view own IP permission set by default? I don't think it is?
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 09:41 AM
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Quote
'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Quote
Is the view own IP permission set by default? I don't think it is?
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:48 AM
Quote from Arantor on September 28th, 2010, 09:41 AM
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Quote
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Lazy ass :P
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
Quote
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)
Dunno what's best.

$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
Posted: September 28th, 2010, 09:45 AM

Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess :)
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 09:50 AM
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Quote
Lazy ass
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
The only original code I committed last night was moving the icon :P as well as spacing fixes. But yeah, the language strings could be improved.
Quote
Dunno what's best.
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Quote
$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
It could be moved to the modlog lang file?
Quote
Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess
Yes it is. Something I didn't remember in the original mod...
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:50 AM
rev 165
- Removed a YaBBSE leftover. (upgrade.php)
! New IP text was missing LI tags. (Display.template.php)
! Fixed quick moderation checkboxes logic. (Search.template.php, Recent.template.php)

Done with the proof-reading :)
Title: Re: New revs
Post by: Nao on September 28th, 2010, 09:54 AM
Quote from Arantor on September 28th, 2010, 09:50 AM
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Then I'll let you rephrase it :P
I'm just not comfortable enough with the English (NOT Scottish!) language.
Quote
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Well... That's a good idea. I'd go with it.
Quote
It could be moved to the modlog lang file?
Or that, yes. :)
Quote
[quoet]
Pwned! Didn't use insertQuoteFast :P
Quote
Yes it is. Something I didn't remember in the original mod...
You mean the original mod had the hole? ;)
(Ah yes, I just checked, the fix is in it, indeed. Good thing we're both checking the code, always a failsafe for when we're lazy :))

I should stop posting so many smileys...
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 10:17 AM
Quote
You mean the original mod had the hole
Sure did, and no-one ever called me out on it, either and the original mod was written back in December 2009...
Quote
Pwned! Didn't use insertQuoteFast
You can't use it to insert only parts of posts unless you modified it here...


I'll take care of the above momentarily.

:edit: Actually, I *did* take care of the permission checking for searching. Basically, the unset items are all to do with removing it from the list of things it knows about for searching/displaying within the manage area.
Posted: September 28th, 2010, 09:56 AM

Revision: 166
Author: arantor
Date: 09:16:59, 28 September 2010
Message:
! Ensure view-IP permissions are applied during install (install_2-0.sql)
! Add view-IP permissions to the internal templates (ManagePermissions.english.php)
& Move 'Logged' to Modlog (index.english.php, Modlog.english.php)
& Rephrase view-IP permission name and user help (ManagePermissions.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql
Title: Re: New revs
Post by: Nao on September 28th, 2010, 11:35 AM
Quote from Arantor on September 28th, 2010, 10:17 AM
Sure did, and no-one ever called me out on it, either and the original mod was written back in December 2009...
That's probably because we don't take code for granted, even our own.
Quote
You can't use it to insert only parts of posts unless you modified it here...
Ah yes, I had already merged it of course. Was faster to quote manually.
Quote
:edit: Actually, I *did* take care of the permission checking for searching. Basically, the unset items are all to do with removing it from the list of things it knows about for searching/displaying within the manage area.
Err, from what you're saying, your fix was already in your mod, then?
You've lost me here...
In my previous post, I mentioned how I'd found the fix in ManageMembers.php, with the unset().
Quote
! Ensure view-IP permissions are applied during install (install_2-0.sql)
So, in the end you're leaving the perms in, instead of using the ban perms?
Quote
& Rephrase view-IP permission name and user help (ManagePermissions.english.php, Help.english.php)
It still implies that can_view_ip_own doesn't exist, and that no one but the admin can have can_view_ip_any...
I guess it's a WIP for now :)
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 11:44 AM
Quote
That's probably because we don't take code for granted, even our own.
I try not to, because I try to be mindful of the consequences of changing things.
Quote
Err, from what you're saying, your fix was already in your mod, then?
You've lost me here...
I initially thought I missed it, then I edited to say I hadn't, because of the unset items - which were in the original mod too. I missed your edit, it seems.
Quote
So, in the end you're leaving the perms in, instead of using the ban perms?
Yes... I see I wasn't clear with what I meant. I set it up so that users who would have ban permissions, would also gain by default the view-all-IPs permission in the templates and in installation, since if you have the ability to ban it follows that you probably should have view all IPs too.

But I didn't want to make them tied together; I can think of cases where users might want to give out some but not the others.

There's a thought, actually... ban user does also use the IP in the ban dialogue. I don't think I hit that one.
Quote
It still implies that can_view_ip_own doesn't exist, and that no one but the admin can have can_view_ip_any...
I guess it's a WIP for now
Yeah, I think so. I've found being a programmer makes me very good at some things - breaking down tasks and so on, but lousy in others - trying to communicate a complex concept to non-technical users (like with the help string) will tend to break down.
Title: Re: New revs
Post by: Nao on September 28th, 2010, 01:33 PM
Quote from Arantor on September 28th, 2010, 11:44 AM
Quote
That's probably because we don't take code for granted, even our own.
I try not to, because I try to be mindful of the consequences of changing things.
You shouldn't worry about that too much. We're both capable programmers and we're both checking each other's code. Meaning that 90% of our errors are spotted by ourselves -- and the remaining 9% have a chance of being caught by the other. I'm leaving an extra 1% for future users to play with ;)
Quote
I initially thought I missed it, then I edited to say I hadn't, because of the unset items - which were in the original mod too. I missed your edit, it seems.
Yeah, we tend to edit too much :P
I also caught a message of yours on another topic, that you'd posted 2 minutes before me, and I didn't get the "Another message was posted" warning when sending it... I'm a bit surprised. Or maybe I just disregarded the message, I don't know. I'll have to answer it.
Quote
Yes... I see I wasn't clear with what I meant. I set it up so that users who would have ban permissions, would also gain by default the view-all-IPs permission in the templates and in installation, since if you have the ability to ban it follows that you probably should have view all IPs too.
Oh... Right. If it suits you then :)
I'm not sure exactly, but checking perms is a fast process, isn't it? I think that once perms are loaded for someone, they're cached.
Quote
There's a thought, actually... ban user does also use the IP in the ban dialogue. I don't think I hit that one.
Want me to look into all of the 'ip' occurrences in the code? (I think I might have better things to do today, though :P)
Quote
Yeah, I think so. I've found being a programmer makes me very good at some things - breaking down tasks and so on, but lousy in others - trying to communicate a complex concept to non-technical users (like with the help string) will tend to break down.
I'm not very good at that too. But I'm very good at bugging people :P Just make the text shorter and more vague! As if you were writing my résumé! :angel:
Title: Re: New revs
Post by: Arantor on September 28th, 2010, 02:10 PM
Quote
I'm not sure exactly, but checking perms is a fast process, isn't it? I think that once perms are loaded for someone, they're cached.
It is, but it's not the fastest it could be (though the difference is basically a micro-optimisation) - $user_info['permissions'] becomes an array of strings of the permission names, matched via in_array. The faster way would be to array_flip it at some point during loading and do isset($user_info['permission'][$perm_name]), though note that if a board's id is specified, it's a DB query - and uncached IIRC. This is pretty infrequent however.

I'm quite happy to change it - it just seemed logical to tie it up into its own permission rather than tie it into something else; that way you don't give out permissions unnecessarily.
Quote
Want me to look into all of the 'ip' occurrences in the code?
Only if you get really bored.
Title: Re: New revs
Post by: Nao on September 29th, 2010, 10:14 AM
Yeah, array_flip() could be beneficial. And instead of isset(), we could use !empty(), so we could actually set perm values to something else than just on/off: numbers, for instance... Like in 'max number of PMs allowed in your box', things like that. I'm not a perm specialist, though.

rev 167
* Updated to SMF rev 10144:
 ! Fixed missing global $smcFunc in prepareIndexes function (SearchAPI-Custom.php)
 ! $smcFunc['db_list_indexes'] was broken for SQLite. (DbPackages-sqlite.php)
 - removed getOuterHTML(), outdated javascript function (script.js) [Bug 4284]

- removed an extra getOuterHTML declaration which was not even used anymore... (repair_settings.php)
- removed getInnerHTML and setInnerHTML declarations, to encourage modders to use the proper way (innerHTML property.) (script.js)
- rewrote a couple of files that were still using getOuterHTML... Dunno if these files will be of any use one day anyway. (latest-packages.js, latest-themes.js)
! IE6 wasn't showing the hover color on menu items that had no submenu. (ie6.css)
* Spacinazi. (ManagePaid.template.php)
Title: Re: New revs
Post by: Arantor on September 29th, 2010, 01:42 PM
Quote
Yeah, array_flip() could be beneficial. And instead of isset(), we could use !empty(), so we could actually set perm values to something else than just on/off: numbers, for instance... Like in 'max number of PMs allowed in your box', things like that. I'm not a perm specialist, though.
I actually did something closer to this in SimpleDesk actually. Need to look at exactly what I did because I think I just had it store a value of 1, 0 or -1 depending on allow, disallow, deny (though they were constants instead so the code was clear)
Title: Re: New revs
Post by: Nao on September 29th, 2010, 02:23 PM
Ahh...... You and your constants :D

I suspect the permission system overhaul[1] will be one of our biggest (and longest) subprojects.
 1. I loved how you mentioned an "overall overhaul" on arantor.org, ahah.
Title: Re: New revs
Post by: Arantor on September 29th, 2010, 02:31 PM
That's the thing... for me, seeing if ($some_array['value'] == ROLEPERM_ALLOW) is way more readable than if ($some_array['value'] == 1) - what does that 1 mean?

I also talked about magicalness; I have an idea for an easter egg out of it :D

Yeah, it will be one of the larger changes, but probably not the largest; some of the stuff I've suggested for group management is probably a touch larger.
Title: Re: New revs
Post by: Nao on September 29th, 2010, 03:23 PM
Yeah it's more readable, I'm just saying -- you and your constants :P
It's not exactly of common use in SMF. Since I learned 90% of my PHP skills through the SMF codebase, I have to admit it's really not something I'd do myself. Not because it's no good -- only because I'm not used to that.
I'm only asking to be educated :)

rev 168 -- aka the IE6 mess fixer!
! Fixed header being too tall in IE6. (ie6.css)
! Fixed quick task list alignment in admin area under IE6. (ie6.css)
! Fixed contextual tabs hover state in admin area under IE6. (ie6.css)
! Fixed invisible gradients in cat_bar th declarations. (index.css)
* Replaced ie-css3 library with PIE, which is way bigger but also works perfectly in IE6/7/8. (PIE.htc, index.template.php)
* Reverted removal of get/setInnerHTML(), as they're currently being used in SMF's news files. (script.js)
Posted: September 29th, 2010, 03:19 PM

Re: IPs -- it's cool to have the icon in the left side now. Really... Thanks for the idea. Help text for IP: I didn't test, but should I assume that it only shows up if user HAS permission to see their own IP? If yes, then it's correctly phrased. Otherwise, it needs fixing.
Title: Re: New revs
Post by: Arantor on September 29th, 2010, 03:53 PM
Quote
Help text for IP: I didn't test, but should I assume that it only shows up if user HAS permission to see their own IP? If yes, then it's correctly phrased. Otherwise, it needs fixing.
Correct. If they can't see it, nothing shows at all.
Posted: September 29th, 2010, 03:27 PM

Revision: 169
Author: arantor
Date: 14:52:32, 29 September 2010
Message:
! Speculative fix for specifying PayPal language from subscriptions to checkout. Not overly happy about binding the list of known 'languages' into the core, but don't really see a better way at this time... short of including the language code into $txt in index.english.php (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Subscriptions-PayPal.php


Yeah, it occurred to me as I was writing up the note that we could include the PayPal language code in the language file itself but didn't want to set that precedent (since if we include other payment gateways in the future, something similar would be required)
Title: Re: New revs
Post by: Nao on September 30th, 2010, 11:13 PM
rev 170
+ Implemented the preceding space trick for smileys into IE. I think I love hating that crap they call a browser. (editor.js)

Phew! Let it be said that no day shall pass without at least ONE commit 8-)
Title: Re: New revs
Post by: Nao on October 1st, 2010, 09:58 AM
rev 171
* Renamed #footer_section to #footer, to match the earlier #header. (install.php, readme_*.html, ssi_examples.php, upgrade.php, index.template.php, index.css, ie6.css)
* Provided fallback border colors for browsers that don't support rgba() in CSS. (index.css)
* Rewrote buttonlist class to get better performance in IE and less clutter. Non-semantic spans are boring anyway. (index.css, index.template.php)
* Recompiled PIE library to shave 10KB off it. IE6 doesn't like it. Screw you, IE. Removed wrc and roundframe emulation for it. (PIE.htc)
! Fixed validation error in menus. (GenericMenu.template.php)
! IE9 doesn't need emulation code. For once... (index.template.php)

I'm currently considering dropping border-radius entirely for IE6... I realize I spent TWO fucking weeks on that piece of shit. Now I'm getting "Operation aborted" errors on PIE with it. Only happens SOME OF THE TIME. And of course it can't be debugged... That's the joy of HTC files. Maybe I should find a way to include the file differently (i.e. through JS, not HTC.)
Title: Re: New revs
Post by: MultiformeIngegno on October 1st, 2010, 10:07 AM
:(

I'd say: don't give a shit about IE6! just... I'm really sorry you spent 2 weeks on this for nothing!
Title: Re: New revs
Post by: Nao on October 1st, 2010, 10:34 AM
Well, these 2 weeks were also spent on IE7 and IE8, which are way better and actually usable... (Except that IE7 also has Operation Aborted issues, but not with PIE, oddly.)
Title: Re: New revs
Post by: Nao on October 1st, 2010, 10:59 AM
Now this is the most annoying thing ever...
I have a file, PIE_uncompressed.htc, which works fine in IE6. I've tried countless times to generate an error, it just doesn't.
NOW, I'll just take that file and COPY it, and rename the new version (byte-for-byte identical!) to PIE_uncompressed2.htc...
I'll reload IE6, and voilà, I get my Operation Aborted errors.

Now, before you ask -- yes, I empty the cache and even restart IETester every time! lol moment...

:edit: I just tried with an earlier copy of IE6 and it's throwing errors on the 'clean' file as well... Uh.
Title: Re: New revs
Post by: Nao on October 1st, 2010, 11:50 AM
rev 172
! Hopefully fixed the Operation Aborted error in IE6 and re-added support for rounded borders in wrc and roundframe... It's still very slow on IE6, though! (PIE.htc, index.template.php)

As discussed here(http://css3pie.com/forum/viewtopic.php?f=3&t=174&p=702#p702).
Title: Re: New revs
Post by: Nao on October 1st, 2010, 10:29 PM
rev 173
- After single-handedly managing to fix all border-radius bugs in IE6, removing support for it because it's so freakin' slow. (index.template.php)
* Changing topic area's quick button font from Arial to uppercase Trebuchet MS (a-la Noisen) (index.css)
* Changing header bar font from Georgia to Segoe UI, using a dark-on-light color scheme in cat_bar/catbg, and adjusted plenty of styles accordingly. Of course, I'm not happy with the results... That wouldn't be fun, would it? (index.css)

As not discussed anywhere. Pete, could you look into the new styles? I spent a couple of hours on this and I'm not happy... This is the best I could come up with, now I want to go eat... My... It's nearly time to go to bed...
Title: Re: New revs
Post by: Arantor on October 2nd, 2010, 12:52 AM
I'll look at the new style when I'm finished with the attachments UI stuff I've been meaning to do (this ticket(http://tracker.wedge.org/?sa=ticket;ticket=53))
Posted: October 1st, 2010, 10:40 PM

Revision: 174
Author: arantor
Date: 23:47:48, 01 October 2010
Message:
+ Updated attachment UI. Sort of broken in IE right now though :( (Post.php, Post.template.php, Post.english.php, editor.js)
- Removed cleanFileInput function as no longer necessary (script.js)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/script.js


When I say it's broken in IE, the error condition isn't right. The <input type="file"> needs to be cleared in the event of an error, which is fine. Now, a type=file is read-only for security reasons but everyone except IE accepts an empty string to clear it.

IE however makes it fully read-only (I have no idea why, that seems pretty stupid to me, when just accepting empty string isn't a security risk), which leaves the only alternative to being removing and replacing the element. This requires adding in spans or divs around the file element that weren't there before (and managing all the sleight of hand required to make it work given all the other stuff going on), and additionally all of the replace methods end up dropping the event handling. Yay, good times.

It can be done, I just don't have the inclination right now to do so.


As for the new style; hmm. The not-quite-black seems too pale, so it's not as striking against the background as perhaps it might be. Looks good otherwise though :)
Title: Re: New revs
Post by: Nao on October 2nd, 2010, 02:25 AM
Nice stuff. Maybe the Remove button could be placed to the left, so that all buttons are aligned? Also, put some padding below the file selector? Something like 4 to 6px would be good...

I thought you were planning to use WebForms (or whatver it's called in HTML5). If it's behaving like Opera's implementation, it allows you to get a lot of information on a file before uploading it... Things like filesize!
I actually planned to use that in Aeva Media, but at the time, Opera was the only browser that supported WebForms, so I gave up. Now it could be possible here.

We could also use YUI Upload to select multiple files from the file selector :P
Quote from Arantor on October 2nd, 2010, 12:52 AM
IE however makes it fully read-only (I have no idea why, that seems pretty stupid to me, when just accepting empty string isn't a security risk), which leaves the only alternative to being removing and replacing the element.
Hmm...
Quote
This requires adding in spans or divs around the file element that weren't there before (and managing all the sleight of hand required to make it work given all the other stuff going on), and additionally all of the replace methods end up dropping the event handling. Yay, good times.
Well.......... I would gladly help you, but I don't know if you heard, I'm just back from a 2-week vacation in Hell...... :evil:
Quote
As for the new style; hmm. The not-quite-black seems too pale, so it's not as striking against the background as perhaps it might be. Looks good otherwise though :)
Thanks. It's really HORRIBLE trying to get the lowest common denominator, whatever it's called in English.
I always feel inspired when I hack into my own websites... But Wedge really is something else.

One of the things that annoy me the most is the 50KB css file... Considering that half of that is for special styles from specific pages, it would be nice to have an index.css and an index_extra.css, and then at the time of caching index.css, automatically concatenate both... Would allow me to focus on the main stylesheet file.



rev 175
* A couple more improvements to the cat_bar styling. (index.css)
* Spacinazi. (Post.template.php, captcha.js, Stats.template.php)

(I changed the catbar color to something... greener. Tell me if you think it's better?)
Title: Re: New revs
Post by: Arantor on October 2nd, 2010, 04:14 AM
Well, AFAIK, doesn't YUI make use of things like Flash? Sure it's doable but I'd hate to make Flash an inherent dependency even for something just like uploading files.

I also wasn't aware that HTML5 contained anything that let you have access to anything useful like the file size, especially since the major browsers can't even agree what the value of a <input type="file"> should be - some browsers only return the basename of the file, some make the full path accessible.
Quote
Well.......... I would gladly help you, but I don't know if you heard, I'm just back from a 2-week vacation in Hell...... :evil:
:P I just wanted to get it committed, didn't feel up to making it work properly seeing how I cut the number of changes vs the SimpleDesk implementation in half and only made it basically a UI change as opposed to UI+logic change that it so nearly was.
Quote
Thanks. It's really HORRIBLE trying to get the lowest common denominator, whatever it's called in English.
I always feel inspired when I hack into my own websites... But Wedge really is something else.
It's the right term; trying to find that common theme for everyone is tricky.
Title: Re: New revs
Post by: Nao on October 2nd, 2010, 07:12 PM
rev 176
* More tweaks to the cat_bar style... I'm starting to like it. (index.css)
* Replaced the original Wedge logo with new mockup. SMF for real -- SMF for real men. Ah ah. And women, too. And dogs. And cats. And other minorities. (wedgelogo.png)

Just so that I don't spend a day without committing...  :niark:
Title: Re: New revs
Post by: Arantor on October 3rd, 2010, 06:30 PM
Revision: 177
Author: arantor
Date: 14:35:55, 03 October 2010
Message:
+ Provide option for redirect boards opening in new window/tab
 + New column, redirect_newtab added to boards table (install_2-0.sql)
 + New admin option for setting it (ManageBoards.english.php, ManageBoards.php, ManageBoards.template.php, Subs-BoardIndex.php, Subs-Boards.php)
 + Displaying changes (BoardIndex.template.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install_2-0.sql

Posted: October 3rd, 2010, 03:37 PM

Revision: 178
Author: arantor
Date: 14:53:21, 03 October 2010
Message:
! Render the time in smaller font on WAP2 (cannot apply to iMode or WAP as neither supports variable height fonts) (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php

Posted: October 3rd, 2010, 03:53 PM

Revision: 179
Author: arantor
Date: 17:30:12, 03 October 2010
Message:
! Convert opendir/readdir/closedir to scandir as appropriate (upgrade.php, ManageAttachments.php, ManagePaid.php, ManageSearch.php, PackageGet.php, Packages.php, Post.php, Subs-Package.php, Subs-Post.php, Subs.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on October 3rd, 2010, 07:48 PM
You did the scandir stuff? I had assigned it to myself and thought of doing it this month ;)
Well, I guess it'll give me more time for other tasks, eheh.
Title: Re: New revs
Post by: Arantor on October 3rd, 2010, 07:51 PM
Yeah, I did. Basically I knew my time would be fragmented today and so doing anything big probably wasn't worth the effort, so I figured I'd look at smaller stuff, and besides, it's more green on the tracker (and I like green) :)
Title: Re: New revs
Post by: Nao on October 3rd, 2010, 08:01 PM
Yeah that's exactly why I was planning to do it as well... My 'big project' is the theme redesign, and all of the philosophy changes that come with it (and you know it's a huge weight on my shoulders. I'm really no designer and I have trouble thinking ahead. Hence why I'm very happy to have Bloc here now :))
Although I wouldn't have called scandir a "smaller" thing, if only because it can't be replaced in an automated manner. (Deleting <div class="content"> won't be easy either. 750+ occurrences, none of them can be automated unless I give up the idea of having proper indentation... I still want to do it at some point, though.)
Title: Re: New revs
Post by: Arantor on October 3rd, 2010, 09:37 PM
scandir was a smaller thing, since as you remarked yourself it was only used in a couple of dozen places; a quick search on opendir showed it wouldn't be a big thing to change - and as you can see from the changelog, it wasn't.


Revision: 180
Author: arantor
Date: 20:35:56, 03 October 2010
Message:
- Remove WAP, imode support (index.php, BoardIndex.php, Display.php, ManageBans.php, PersonalMessage.php, Profile.php, Subs-Auth.php, Subs.php, Wireless.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on October 6th, 2010, 02:41 PM
rev 181
* Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
* Spacinazi and typo killing. (upgrade.php, Class-Editor.php, Profile-Actions.php, Subs.php, GenericList.template.php, Post.template.php, script.js)
+ nobbc tag should be allowed in parse_bbc_inline. (Subs.php)
! A regex in preparsecode() didn't require a return value. Saves about a micro-millisecond of CPU time per day. Think of the trees. (Class-Editor.php)
- Replaced useless javascript:void(0) calls that could easily be replaced with a # as long as the associated onclick() event returns false. (ssi_examples.php, repair_settings.php, smfinfo.php, Subs.php, templates: Help, ManageMembergroups, ManageNews, ManagePermissions, Packages, PersonalMessage, Profile, Search, Themes)
* I believe all of those typeof=undefined and null tests in Javascript are useless and can simply be replaced with a if (var) test as long as var can't take a value of false. (script.js)

----> Pete, you may safely skip the changes in all files (they're minor and double-checked already), but I'd like you to have a look at my changes in script.js... I would hate having added a logic bug. I've tested on my side with Opera and it works. Maybe older IEs will choke on these though...

PS: nothing was committed in the last 3 days...? Wow. I think it's our record. We're going the SMF way ;)
Title: Re: New revs
Post by: Arantor on October 6th, 2010, 08:28 PM
Quote
Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
Are you planning to change all the other things that are similarly bools in nature? There is not a single bool amongst SMF's tables, never has been, and in the case of older MySQL versions it is neither smaller, nor faster to do so.

Will take a look at script.js shortly.
Title: Re: New revs
Post by: Nao on October 6th, 2010, 08:40 PM
Quote from Arantor on October 6th, 2010, 08:28 PM
Quote
Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
Are you planning to change all the other things that are similarly bools in nature?
I don't know... Should I?
Depends on whatever I find out, I guess...
Quote
Will take a look at script.js shortly.
Thanksalot.
Title: Re: New revs
Post by: Arantor on October 6th, 2010, 09:47 PM
There's a lot of fields that fall into the same category of being tinyint when they logically should be bool.

Trouble is, even on more modern MySQL I'm not sure it's any faster and in some cases it will be slower as it messes round fixing up part bytes (especially in fields with variable width columns that implicitly force everything else as bytes).

There's also a lot of fields whose use is never stated anywhere... yay for undocumented schemas.
Posted: October 6th, 2010, 08:45 PM

OK, took a look at script.js.

All the stuff with == null vs ! should work, and seems to.

There's only two things I'm wary of.

Code: [Select]
doForm.passwrd.value = is_ff != -1 ? '' : doForm.passwrd.value = doForm.passwrd.value.replace(/./g, '*');

Surely that should be:
Code: [Select]
doForm.passwrd.value = is_ff != -1 ? '' : doForm.passwrd.value.replace(/./g, '*');


And also,
Code: [Select]
bInit = typeof(bInit) == 'undefined' ? false : true;

vs
Code: [Select]
bInit = bInit ? true : false;

Seems a bit redundant logically, not to mention inaccurate.

I'd suggest:
Code: [Select]
bInit = typeof(bInit) != 'undefined';
and just be done with it.
Posted: October 6th, 2010, 09:37 PM

Revision: 182
Author: arantor
Date: 20:46:32, 06 October 2010
Message:
! Missed a closedir that should have been removed before (Subs-Post.php)
----
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on October 7th, 2010, 12:14 AM
rev 183
! Fixed wrong cat_bar color in IE6. (ie6.css)
* Optimized wedgelogo.png to save a kilobyte in size.
! Oops moment, thanks Pete. (script.js)

Really sorry that I screwed the doForm line. Of course it was simply a bad manipulation on my part.
As for bInit, I don't see how it would be inaccurate?
I turned it into "bInit = !!bInit", which is even shorter and less readable. :P
's that okay?

Re: BOOL sizes, I'd say once again, feel free to reinitalize the field to TINYINT(4)!
Title: Re: New revs
Post by: Nao on October 8th, 2010, 12:16 AM
rev 184
+ Added on_timeformat function (and somehow documented it), for use in quotes. (Subs.php)
- Deleted FixLanguage.php, as well as template and language upgrade systems, as they should never be needed in Wedge. (upgrade.php, detailed-version.js)
- Deleted login_to_post language string (ghost entry.) (Errors.english.php)
! Spacinazi. (Admin.english.php, Subs.php)
Title: Re: New revs
Post by: Arantor on October 8th, 2010, 01:29 AM
Revision: 185
Author: arantor
Date: 00:28:20, 08 October 2010
Message:
! Make $context['sub_template'] accept an array as a list of subtemplates to call (Subs.php)
! Separate the board index templates as they should have been originally (BoardIndex.php, BoardIndex.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Title: Re: New revs
Post by: Nao on October 8th, 2010, 09:30 AM
Ah, just noticed your new rev... Will check in a minute.

rev 186
+ Added support for icons in main menu's top level. Can be improved. Provided a sample set of sprited icons. (Subs.php, index.css, index.template.php, sprite.png)
* Changed menu highlighting color to something more sober. (index.css)
+ Added language string for 'Simple search'... Just in case? (index.english.php)

--> I don't know if it's good to have icons in the main menu. I mean... Wedge's implementation has dropdown arrows next to the titles. Now there's an icon, then the title, then the arrow. Maybe be a little... crowded? Please give your opinion on this. Also, icons can be sprited or stand-alone. Just look into index.template.php for how it's done. This is a slightly modified version of Noisen's code. ONLY TESTED IN OPERA! May fail in Firefox & co...

:edit: You made a very small change... But a very smart one :) This was something that bothered the hell for me several times in the past!
Title: Re: New revs
Post by: Arantor on October 8th, 2010, 09:56 AM
Modularity is awesome :)

Now, we could trivially have it so that the info centre can be disabled cleanly without resorting to putting changes in the template... but that's only the beginning.
Title: Re: New revs
Post by: Nao on October 8th, 2010, 11:07 AM
Yeah. Modularity, that's the word... I guess it's got something to do with portal blocks.

(Can you give me your opinion on adding icons to the main menu, still?)
Title: Re: New revs
Post by: Arantor on October 8th, 2010, 11:15 AM
I like the idea of icons, haven't looked at the implementation yet.

It does add something and I know full well that icons can make or break a UI, but often if they're meaningful icons, they add to it :)

If it's anything like here, it works for me.
Title: Re: New revs
Post by: Nao on October 8th, 2010, 03:56 PM
rev 187
* Once again, sobriety... Replaced existing icon sprite with a Diagona set. (sprite.png, index.css, Subs.php)
+ Added Login icon, and an alternative PM icon when you've got mail. (sprite.png, Subs.php)
- IE6 sucks at showing sprited icons, so removed icons for it. (index.template.php, ie6.css)
* Retooled index.css to show brackets next to class names. This saves about 600 lines and is easier to navigate. (index.css)
* The forumtitle id sucked... Changed it for a better font and styling. (index.css)

*NOW* I'm happier with the icons... I just needed to use icons from a single set. No matter what the set. What matters is that they're all made by the same person. It can be improved, of course. But right now it won't induce nightmares anymore.

God, I swear I'm starting to love the Wedge theme now!! At last!
Title: Re: New revs
Post by: Nao on October 8th, 2010, 09:15 PM
rev 188
- Simplified theme_copyright... Let's not be paranoid, okay? (Subs.php)
* Modified copyright notice to add Wedge and ourselves to it. Now Wedge is officially illegal. (index.english.php, index.css, index.php)
+ Added direct link to local credits page in footer. (index.english.php, index.template.php)
! Fixed a very, very, very annoying menu bug in IE6. (script.js)
! Fixed icon problems with IE6 and deleted the IE7 hack as it wasn't needed. (index.css, index.template.php)
* Spacinazi. (Themes.php)

(I added 'Wedgeward' as the copyright holder... That's us. Our temp name. Because my fave book is the Windward Horde. But again -- temp!)
Title: Re: New revs
Post by: Nao on October 10th, 2010, 02:25 PM
rev 189 (This was all done yesterday but I'm having some computer issues and wasting time...)
+ Changed Calendar icon to a new, sprited one. Added sprited icon for Register. Fixed icon widths. (Subs.php)
* Updated to SMF rev 10150, with a lot of minor tweaks to layout and styling.
  * Missing icon in profile/ignore boards. Markup/css to allow large content above the linktree (Profile.template.php, index.template.php, index.css) (NB: was already done in Wedge anyway...)
  * Minor cleaning up in admin. Better highlighting of search results. Defined new_win class. Better description for post options (Admin.template.php, admin.css, index.css, Post.english.php)
  * Fixed post-breaking bug in IE6 and IE7. Removed $context['right_to_left'] from two templates. (ie6.css, ie7.css, index.css, rtl.css, Display.template.php, Memberlist.template.php)
  * Fixed board selection in profile and help. Cleaned up stats markup. (Profile.template.php, Help.template.php, Stats.template.php, index.css, rtl.css)
Title: Re: New revs
Post by: Arantor on October 10th, 2010, 05:25 PM
The one thing about the icons is that they're hardcoded right now; would be hard for theme authors to set the icons themselves.

While this would be somewhat ugly, would it not be preferable to define classes in CSS for each icon (like how the sprite icons work in the thread view normally) and control it all through CSS so theme authors can override/ignore it as they see fit?
Title: Re: New revs
Post by: Arantor on October 10th, 2010, 06:25 PM
Revision: 190
Author: arantor
Date: 17:24:43, 10 October 2010
Message:
+ Provide a default favicon.ico and have it called from the theme too (favicon.ico, index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Added : /trunk/favicon.ico
Title: Re: New revs
Post by: Nao on October 10th, 2010, 07:20 PM
Reasons why I didn't add a favicon myself:
- From the beginning, I was very happy with the favico I made for wedgeforum.com, but unhappy with the logo itself. Now, I'm very happy with my current Wedge logo, but unhappy with the (unused) favico I made from it...
- If admin has a favico for their site, they may erase it by thoughtlessly uploading the Wedge files to their website.
- If they're uploading to a subfolder, they may not like having a different favico than their main site, either.

This is basically why I didn't play with this...

Regarding the MIME type, why did you use "x-icon"?
The official type (as used on noisen and wedgeo) is "vdn/microsoft_crappy_files"
Cf. http://en.wikipedia.org/wiki/ICO_(file_format)
Posted: October 10th, 2010, 07:18 PM
Quote from Arantor on October 10th, 2010, 05:25 PM
The one thing about the icons is that they're hardcoded right now; would be hard for theme authors to set the icons themselves.
You mean, the sprited icons? Yes, that's always been the problem obviously...
Quote
While this would be somewhat ugly, would it not be preferable to define classes in CSS for each icon (like how the sprite icons work in the thread view normally) and control it all through CSS so theme authors can override/ignore it as they see fit?
Well, sure can do that, yes.
I'm sorry I didn't think of doing that from the beginning.
Title: Re: New revs
Post by: Arantor on October 10th, 2010, 07:51 PM
Quote
- From the beginning, I was very happy with the favico I made for wedgeforum.com, but unhappy with the logo itself. Now, I'm very happy with my current Wedge logo, but unhappy with the (unused) favico I made from it...
You can change it :P Just it was something to hand that was convenient.
Quote
- If admin has a favico for their site, they may erase it by thoughtlessly uploading the Wedge files to their website.
Sure, but how often do site admins have a favicon already in place for a top level domain and have nothing else there when adding a forum to the top level of the domain?
Quote
- If they're uploading to a subfolder, they may not like having a different favico than their main site, either.
Sure, but having it set up like this will mean they just copy theirs over the top of the provided one (we don't have to include it in upgrades).

It also means if they just want to customise it, they have a point of reference.
Quote
Well, sure can do that, yes.
I'm sorry I didn't think of doing that from the beginning.
No need to apologise; only reason I thought of it is because I've been doing a similarly styleable menu for my other project and one of the things was to make it as flexible as possible to style in pure CSS.
Title: Re: New revs
Post by: Nao on October 10th, 2010, 11:18 PM
rev 191
* Made main menu background a bit brighter. Subtility, crap like that... (index.css)
+ Made sure to hide the dropdown arrow if a top-level menu entry doesn't have any submenu. (index.css, index.template.php)
* Moved main menu icon definitions to index.css, and replaced spriting code with a simple 'padding' parameter to tell the menu code the actual width of the current icon. (Subs.php, index.css, index.template.php)
* Changed favicon MIME type to the official one. (index.template.php)
Quote from Arantor on October 10th, 2010, 07:51 PM
You can change it :P Just it was something to hand that was convenient.
We'll be keeping it for now, I guess...
Quote
Sure, but how often do site admins have a favicon already in place for a top level domain and have nothing else there when adding a forum to the top level of the domain?
Hmm... Well...
I don't know.
To me, that Wedge icon was pretty much the symbol for our website, rather than our software. See what I mean...?
Just like SMF has their own favicon at simplemachines.org, but they don't include it in the package.
Quote
Sure, but having it set up like this will mean they just copy theirs over the top of the provided one (we don't have to include it in upgrades).
Hmm... I guess. But if they don't know the first time around... And if they don't keep a copy somewhere... (Okay, then that's THEIR problem.)
Quote
No need to apologise; only reason I thought of it is because I've been doing a similarly styleable menu for my other project and one of the things was to make it as flexible as possible to style in pure CSS.
I was probably influenced a bit too much by my own Noisen code for adding icons in the main menu.
(And seriously -- I don't understand a bit why it was so incredibly easy to implement them in a tableless fashion in Wedge, when I broke my teeth for several days trying the same in Noisen... And finally settled on a table version.)
Title: Re: New revs
Post by: Arantor on October 11th, 2010, 12:04 AM
Quote
Hmm... Well...
I don't know.
To me, that Wedge icon was pretty much the symbol for our website, rather than our software. See what I mean...?
Just like SMF has their own favicon at simplemachines.org, but they don't include it in the package.
It's not really about the icon itself that I made the change; the icon just happened to be what I had to hand. The idea is to provide something out of the box for those users who would want it - I'm thinking about things we can do to minimise support requests generally, and having it set up like that will mean that people can just upload a new one and everything will just support it regardless of anything else.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 01:02 AM
Revision: 192
Author: arantor
Date: 00:01:09, 12 October 2010
Message:
- Remove karma (lots of files, including removing from the installer, language strings, even the icon for it in Core Features)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/DbPackages.php
Deleted : /trunk/Sources/Karma.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/News.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Deleted : /trunk/Themes/default/images/admin/feature_k.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install_2-0.sql
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/other/xml/detailed-version.js


Surprising how many places needed to be edited for what is really a minor feature.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 05:05 AM
Revision: 193
Author: arantor
Date: 02:45:10, 12 October 2010
Message:
! Make Wedge UTF-8 only. Note, there are still some legacy functions roaming around (notably the legacy attachment handler and the conversion functions to handle other-to-UTF-8 and entities-to-UTF-8-characters) which can remain for now until we get that sorted in the converters.
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/DbPackages.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/LogInOut.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/News.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Printpage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/Themes/default/Xml.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Modified : /trunk/other/Sphinx/sphinx_config.php
Modified : /trunk/other/install.php
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/templates/UnitTest.template.php
Modified : /trunk/other/upgrade.php



I don't think I broke anything, either, and I think I got rid of most (if not all) of the language strings though I may have left some for the legacy conversion interface in there.
Posted: October 12th, 2010, 03:45 AM

Revision: 194
Author: arantor
Date: 03:23:23, 12 October 2010
Message:
! More anti-UTF-8 removals
 ! Fixing the language editor (ManageServer.php, Admin.template.php)
 ! Fixing language loaders (Load.php, ManageServer.php)
 ! Yet more language strings going bye-bye (Install.english.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


I yoinked out some more stuff in the admin panel. Nothing exciting.
Posted: October 12th, 2010, 04:24 AM

Revision: 195
Author: arantor
Date: 04:03:50, 12 October 2010
Message:
! Fix minimum version in web installer
+ Added check for GD2 plus the functions we need in the CAPTCHA and attachment handlers
----
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/webinstall.php


There's more to the GD stuff; now that's in, there's legacy stuff like the gif-to-png magic converter, plus the files in the fonts/ directory that are GIFs, and the CAPTCHA-without-GD code that can go too. Time for bed for me though, didn't have time to do them today.
Title: Re: New revs
Post by: live627 on October 12th, 2010, 08:14 AM
Quote from Arantor on October 12th, 2010, 01:02 AM
- Remove karma (lots of files, including removing from the installer, language strings, even the icon for it in Core Features)
So does that imply that Fustrate's Rep mod won't work?


What program lets you copy the entire output? TortoiseSVN?
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 08:57 AM
It won't work, no, because I ripped out the DB fields too.

Yup, I use TortoiseSVN, all I do for my commit notices is go to the trunk root, right click, view the log then right click on my commit and copy to clipboard.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 10:09 AM
Revision: 196
Author: nao
Date: 08:26:55, 12 October 2010
Message:
* Renamed content_section to content. (Various files)
----
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/ie7.css
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/other/readme_convert.html
Modified : /trunk/other/readme_install.html
Modified : /trunk/other/readme_update.html
Modified : /trunk/other/readme_upgrade.html


Revision: 197
Author: arantor
Date: 09:08:17, 12 October 2010
Message:
- Remove legacy CAPTCHA code using only premade images shown in a line (ManageSettings.php, ManageSettings.english.php, Register.php, Subs-Editor.php, Subs-Graphics.php, GenericControls.template.php)
- Remove all the premade image folders (Candice, Hootie, President)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Themes/default/GenericControls.template.php
Deleted : /trunk/Themes/default/fonts/Candice
Deleted : /trunk/Themes/default/fonts/Hootie
Deleted : /trunk/Themes/default/fonts/President
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on October 12th, 2010, 10:27 AM
I was going to post my 196 log ;)
Reason I did that small commit, is to save me some time when diff'ing the files. In the end it was pretty useless because several of the files needed to be updated first, so I didn't commit those... So it's a half-broken update, ah ah! Just don't bother about it. I'll commit the final 3 files when I'm done reviewing your tons of edits.
As for myself, I copy what I type into the changelog, directly before posting it, because if a file is out of sync, it friggin' erases the log and doesn't let me copy it for my next attempt! So, I use the opportunity to post the text here... Hence why it doesn't have your more verbose changelog formatting.

rev 198
* Simplified htmlspecialchars(). (Load.php)
- Removed smf_charset Javascript variable. (ssi_examples.php, upgrade.php, index.template.php, script.js)
- Removed any charsets other than UTF8 from php_to8bit(). That felt GOOD! (script.js)
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 10:49 AM
Quote
As for myself, I copy what I type into the changelog, directly before posting it, because if a file is out of sync, it friggin' erases the log and doesn't let me copy it for my next attempt!
Never have that problem, even when it's out of sync. TortoiseSVN keeps all mine even if I hit cancel; above the changelog textbox there's a 'Recent Messages' button you can click... maybe you need a more recent version?
Quote
* Simplified htmlspecialchars(). (Load.php)
Interesting change... any particular reason? The one thing I'd note is that now every ' that comes in will be converted to an entity (which may have other consequences for the places where no override was given, where it will just use ENT_COMPAT, so only double quotes would be entitified before)
Title: Re: New revs
Post by: Nao on October 12th, 2010, 12:04 PM
rev 199
- Karma leftovers. (upgrade_2-0.sql)
- getLanguage() utf8 leftovers. (ManageServer.php, Profile-Modify.php)
- char_set leftover. (ScheduledTasks.php)

I'll leave you the pleasure of submitting rev 200!
Quote from Arantor on October 12th, 2010, 10:49 AM
Never have that problem, even when it's out of sync. TortoiseSVN keeps all mine even if I hit cancel; above the changelog textbox there's a 'Recent Messages' button you can click... maybe you need a more recent version?
Yeah, maybe. I have a fairly recent version (several months.)
I'll be sure to have a look next time.
Quote
Quote
* Simplified htmlspecialchars(). (Load.php)
Interesting change... any particular reason? The one thing I'd note is that now every ' that comes in will be converted to an entity (which may have other consequences for the places where no override was given, where it will just use ENT_COMPAT, so only double quotes would be entitified before)
I... I'm not sure I understand. I was just read through the log, saw something that I would sum up as "$a = 'hello'; echo $a;" and turned it into "echo 'a';"... Did I make a mistake? Feel free to revert, of course.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 01:16 PM
Quote
I... I'm not sure I understand. I was just read through the log, saw something that I would sum up as "$a = 'hello'; echo $a;" and turned it into "echo 'a';"... Did I make a mistake? Feel free to revert, of course.
htmlspecialchars does one core job, converting key HTML items into entities, namely stuff like & to &amp;. It also has options for handling quotes, ENT_COMPAT, ENT_NOQUOTES and ENT_QUOTES. ENT_COMPAT is the default, which converts " to &quot;, ENT_NOQUOTES leaves both " and ' alone, and ENT_QUOTES does both " to &quot; and ' to  according to php.net's page on it. (At least, it definitely turns ' into entities)

It's probably OK to do that, actually, but it may have unintended side effects. I'll revert it for now because I don't want to get extra unintended stuff breaking - the UTF-8 changes were huge, and may mean other stuff may fail in interesting ways yet, and I'd rather not change something like that just yet. (It is a good idea to simplify it down though, as I'm not entirely sure that it's needed outside the query parameterisation)
Posted: October 12th, 2010, 12:25 PM

Revision: 200
Author: arantor
Date: 11:40:49, 12 October 2010
Message:
! Expand installer strtolower version to match main source (install.php)
! Fix broken regexp for sanitising lists (Class-Editor.php)
! Quasi-revert htmlspecialchars change for now, but remove charset parameter (Load.php)
! Remove lang_character_set from the language editor options (ManageServer.php)
! Fix caller for recursive Unicode validation (Subs.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/install.php

Posted: October 12th, 2010, 12:41 PM

Revision: 201
Author: arantor
Date: 12:16:01, 12 October 2010
Message:
! Restructure download handler into its own file (Display.php, index.php, Download.php)
! Fix broken attachments (reverting previous optimisation) (Download.php)
----
Modified : /trunk/Sources/Display.php
Added : /trunk/Sources/Download.php
Modified : /trunk/index.php


This marks the start of breaking up the monolithic files in the core; there's really no need to have them like that, especially as it makes things slower in fact (Display being one of the most heavily used files, needs to be kept lighter!)
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:04 PM
rev 202
- Removed unused globals from Xml functions. (Xml.template.php)
* Complicated code just for an unset... (index.php, SSI.php)
* Spacinazi. (ManageSettings.php, Admin.template.php)

rev 203
* Committed the last few conflicted files with content_section changes. (install.php, ssi_examples.php, upgrade.php, index.template.php)
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 02:17 PM
Quote
* Complicated code just for an unset... (index.php, SSI.php)
It didn't used to be complicated for a single unset, when it had two items in it... but in hindsight it was still complicated.
Quote
* Spacinazi. (ManageSettings.php, Admin.template.php)
Won't that break the settings pages since $context['settings_post_javascript'] doesn't add its own <script> tag...?
Quote
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Yes, that was an oops moment, sorry...
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:27 PM
Phew... Finally done reading through your changes. I can't believe you did all of that in a single night...! What are you on?

Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Quote from Arantor on October 12th, 2010, 01:16 PM
htmlspecialchars does one core job, converting key HTML items into entities, namely stuff like & to &amp;. It also has options for handling quotes, ENT_COMPAT, ENT_NOQUOTES and ENT_QUOTES. ENT_COMPAT is the default, which converts " to &quot;, ENT_NOQUOTES leaves both " and ' alone, and ENT_QUOTES does both " to &quot; and ' to  according to php.net's page on it. (At least, it definitely turns ' into entities)
Oh... I see what you mean, very sorry. I didn't notice the separator. I was changing the data in the parameter list -- and that was a "default" parameter but it could be changed... I've never been very comfy with create_function.
I totally broke htmlspecialchars, ahah!
BTW, there were two remaining calls in ManageServer.php that specified UTF-8 at the end, I've modified them locally. Will be in the next commit.
Quote
(It is a good idea to simplify it down though, as I'm not entirely sure that it's needed outside the query parameterisation)
Oh well then that's a good thing I missed the point in the first place... 8-)
Quote
! Expand installer strtolower version to match main source (install.php)
+1
Quote
! Fix broken regexp for sanitising lists (Class-Editor.php)
-1 :niark:
Quote
! Fix caller for recursive Unicode validation (Subs.php)
BTW, makes me think... Is this Unicode or UTF? If it's Unicode, then I don't even know what the function is there for... SMF/Wedge never ever generate Unicode stuff, AFAIK...
Quote
! Fix broken attachments (reverting previous optimisation) (Download.php)
That was one of mine... Actually I just followed the comment's suggestion. ("Would use ob_clean but that's PHP 4.2") I figured okay it's PHP 5.0 now so let's use ob_clean...
Now, I'm not sure in what way it was broken? It's been a long time since I've played with output buffer manipulation. Especially in SMF, where there are plenty of buffers at a time...
Quote
This marks the start of breaking up the monolithic files in the core; there's really no need to have them like that, especially as it makes things slower in fact (Display being one of the most heavily used files, needs to be kept lighter!)
That's a good idea, indeed...
Quote from Arantor on October 12th, 2010, 02:17 PM
It didn't used to be complicated for a single unset, when it had two items in it... but in hindsight it was still complicated.
Well, yes it was complicated, even at the time... My problem is that I'm not auditing the codebase. Maybe I should. I only find such issues when checking commits and making changes to the code myself.

unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);

As you can see... It does two unsets, and it's still a single call ;)
Quote
Quote
* Spacinazi. (ManageSettings.php, Admin.template.php)
Won't that break the settings pages since $context['settings_post_javascript'] doesn't add its own <script> tag...?
Well, I added the script tag in ManageSettings, didn't I...?
I mainly did it because you unindented the code and it wasn't in line with the script tag. Also, SMF's implementation would automatically add a tab. I just deleted the hell out of those ugly lines and made it cleaner.
That's my job...[1]
Quote
Quote
! Regex is an art form. Like, modern art for the ego. (Class-Editor.php)
Yes, that was an oops moment, sorry...
 1. I'M NOT A WINDOW CLEANER!!!!![1]
 1. Okay, it only works if you've read my first post on runic's place[1].
 1. *And* you watched this year's IT Crowd...
Given these last few hectic hours, it's no surprise we're both making blunders here and there. That's why we proof-read each other's code. Glad to be of help :)

Hey, my footnotes got in the wrong place... I'll make sure I've applied my Wedge fix on them.

:edit: Argh, it seems that it's already applied... :-/ Will need to fix that, then.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 02:36 PM
Quote
Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Get a better browser then; Chrome's had it built in for ages. :P
Quote
BTW, makes me think... Is this Unicode or UTF? If it's Unicode, then I don't even know what the function is there for... SMF/Wedge never ever generate Unicode stuff, AFAIK...
Well... UTF-8 is one form of Unicode. The whole concept is a total mess anyway -sigh-. Anyway, the idea is that it should always be valid UTF-8 (and by proxy valid Unicode) except that in some cases it isn't, but I have no idea why that might be. It's been there since 1.1, and it may not be relevant any more - doubly so since it never seemed to be called before.
Quote
Now, I'm not sure in what way it was broken? It's been a long time since I've played with output buffer manipulation. Especially in SMF, where there are plenty of buffers at a time...
Attachments totally failed to load before. Just went to an error message about not being able to load the page.

What was happening is that there was an extra output buffer existing that shouldn't have existed, which was causing content not to be flushed properly - and even if it did get flushed, the result would be corrupted because it would be gzipped content when the header implied otherwise. (I haven't checked the browser-specific stuff yet, that's next up)

Gzipping binary content when you're serving in true binary probably isn't a clever idea ;) And if it's over 4MB, you don't really want to be managing that in PHP anyway since it'll be coming out of PHP memory, PHP buffering and possibly fail between PHP and webserver.
Quote
unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);
I wonder why SMF never did that.
Quote
Well, I added the script tag in ManageSettings, didn't I...?
It still breaks though, vomiting raw JS onto the page :/
Quote
Given these last few hectic hours, it's no surprise we're both making blunders here and there. That's why we proof-read each other's code. Glad to be of help
Not only that but we've made some very large changes to the codebase, and it's unlikely we'd have totally caught every one first time simply because they are very large changes with lots of consequences.
Title: Re: New revs
Post by: MultiformeIngegno on October 12th, 2010, 02:51 PM
Quote from Arantor on October 12th, 2010, 02:36 PM
Get a better browser then; Chrome's had it built in for ages. :P
Chrome rulez!! :cool: :lol:
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:55 PM
rev 204
+ Added :edit: smiley. (install_2-0.sql, Install.english.php, Class-Editor.php, Subs.php)
* htmlspecialchars leftover. (ManageSettings.php)

PS: reproduced footnote error in Wedge... Hmpf. This will never end... I'll take a break or something.
Quote from Arantor on October 12th, 2010, 02:36 PM
Get a better browser then; Chrome's had it built in for ages. :P
Yeah, I remember that... Damn you, Google fanboys! :ph34r:
I'll stay with my lousy browser. It just added Web Sockets support. Yeah, I know, you've had it for a year, blah blah blah... But your tab UI has sucked from day one :niark:
Quote
Well... UTF-8 is one form of Unicode. The whole concept is a total mess anyway -sigh-. Anyway, the idea is that it should always be valid UTF-8 (and by proxy valid Unicode) except that in some cases it isn't, but I have no idea why that might be. It's been there since 1.1, and it may not be relevant any more - doubly so since it never seemed to be called before.
Yeah... Which is why I reported(http://dev.simplemachines.org/mantis/view.php?id=4498) the issue to the SMF devs. Maybe they'll figure it out... We have much work on our hands, too.
Quote
What was happening is that there was an extra output buffer existing that shouldn't have existed, which was causing content not to be flushed properly - and even if it did get flushed, the result would be corrupted because it would be gzipped content when the header implied otherwise. (I haven't checked the browser-specific stuff yet, that's next up)
Okay... ob_clean is supposed to empty the buffer without deleting the hooks. So I guess what happened is: originally, there was one less buffer called, and the dev added that remark. Then, someone added an extra buffer that should NOT be used in attachments, and forgot (or wisely decided) not to use it in the code we're talking about, so that their buffer wasn't re-created after ob_get_clean(). But forgot to delete the mention about ob_clean().
Quote
Quote
unset($GLOBALS['cachedir'], $GLOBALS['db_character_set']);
I wonder why SMF never did that.
They can probably explain that using isset() saves 0.07 microseconds off execution time.
Of course, the foreach with a custom array will definitely eat that...

Let's just say they didn't know unset() could be called with multiple parameters.
Or that unset() on an undefined variable didn't generate any warnings or errors (except on an undefinex index in an undefined array, in PHP4 only.)
Maybe the foreach() was there because they planned to add more vars to it later...
Just like in Subs-Members.php... I see no other reason to use THAT, and even the comment spells it out. 'Characters'. (Feel free to delete it.)

Code: [Select]
// Characters we just shouldn't allow, regardless.
foreach (array('*') as $char)
if (strpos($checkName, $char) !== false)
if ($fatal)
fatal_lang_error('username_reserved', 'password', array($char));
else
return true;

IIRC, I already fixed a similar code block long ago. Was probably in Aeva Media... Something Dragooon had copied from SMF, I'd venture.
Quote
It still breaks though, vomiting raw JS onto the page :/
Okay, I see what you mean... The var is modified after that. Uh. That's what happens when you're busy fixing 12 things at the same time.
Well, I'll fix that back...
Quote
Not only that but we've made some very large changes to the codebase, and it's unlikely we'd have totally caught every one first time simply because they are very large changes with lots of consequences.
Not only that, but you have no idea how fun it's going to be when I get to update to the latest SMF SVN...
Basically, I now have to do all of the templates manually because they always change stuff around a .catbg class (which no longer exists), now I'll have to edit source files manually every time they make a change around a UTF call... ;)
Title: Re: New revs
Post by: Nao on October 12th, 2010, 02:58 PM
rev 205
! Fixing the settings_post_javascript fix. Today's the fixing game. (ManageSettings.php, Admin.template.php)

(Just to get this off my hands...)
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 04:13 PM
Quote
Yeah, I remember that... Damn you, Google fanboys!
I thought I remembered seeing Opera have a resizeable textarea a year or more ago? Then again that would have been during my Star Pirates/Greasemonkey days where I was fudging GM to work on Firefox, Opera, Safari with SIMBL support (thanks to Asgard), so I sorta lost track of what did what.
Quote
Let's just say they didn't know unset() could be called with multiple parameters.
Works for me ;)
Quote
Just like in Subs-Members.php... I see no other reason to use THAT, and even the comment spells it out. 'Characters'. (Feel free to delete it.)
I bet once upon a time there were more characters in that list, or should have been.
Quote
Not only that, but you have no idea how fun it's going to be when I get to update to the latest SMF SVN...
As I keep trying to tell Antechinus, spending time farting around with stupid little changes in the source that doesn't benefit anyone just slows down actually fixing real issues.
Posted: October 12th, 2010, 03:00 PM

Revision: 206
Author: arantor
Date: 15:13:11, 12 October 2010
Message:
! Removed random support for Firefox and Opera in downloads, they work just fine with the default, even with filenames with UTF-8 in them. (Download.php)
! Another silly bugfix from the UTF-8 stuff. (Subs-Post.php)
----
Modified : /trunk/Sources/Download.php
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on October 12th, 2010, 05:52 PM
Quote from Arantor on October 12th, 2010, 04:13 PM
Quote
Yeah, I remember that... Damn you, Google fanboys!
I thought I remembered seeing Opera have a resizeable textarea a year or more ago?
Nope... None I can think of.
Quote
Then again that would have been during my Star Pirates/Greasemonkey days where I was fudging GM to work on Firefox, Opera, Safari with SIMBL support (thanks to Asgard), so I sorta lost track of what did what.
Opera has UserJS and indeed it probably can 'fix' that. It has dozens of hacks like that for every possible use.
I'm not using any, though. Vanilla Opera is just right for me. (Usually.)
Quote
I bet once upon a time there were more characters in that list, or should have been.
Actually, not... Was added in SMF2 RC3.
Quote
As I keep trying to tell Antechinus, spending time farting around with stupid little changes in the source that doesn't benefit anyone just slows down actually fixing real issues.
Hmm, some of these stupid little changes are interesting for the future... And we do discuss mostly little changes, too ;) So I wouldn't criticize him on that.
Look (if need be, since you're also following these) at what they're discussing these days: (last pages of these topics, obviously.)
http://www.simplemachines.org/community/index.php?topic=403149.0 --> Fustrate and splitting monolithic files into many files.
http://www.simplemachines.org/community/index.php?topic=404100.40 --> Ante adding jQuery to SMF 2.1
http://www.simplemachines.org/community/index.php?topic=400219.msg2815429#msg2815429 --> Norv and his "joke" (?!) about splitting the members table into several relational tables...


Speaking of Ante, I just found this amusing post from him...
Look at the date.
http://portamx.com/topic_1480.msg8657.html#msg8657
Now that he's a dev... Well, let's just say he's had a change of heart. ::)
(And Fel is again referring to self as "the PortaMx corp." :lol:) <PRV>

Also, Ante is a veteran coder, as can be seen here:
http://portamx.com/topic_535.msg5728.html#msg5728
Quote
! Removed random support for Firefox and Opera in downloads, they work just fine with the default, even with filenames with UTF-8 in them. (Download.php)
Yay, I knew it :) That's what you get when code stays static for years!
Did you test with older but still supported versions of Opera and FF? I can test with Opera 9 if you ask me.
Title: Re: New revs
Post by: Nao on October 12th, 2010, 05:57 PM
Quote from Arantor on October 12th, 2010, 04:13 PM
! Another silly bugfix from the UTF-8 stuff. (Subs-Post.php)
Can't we just remove the first parameter? It'll always be set to UTF-8 anyway...
list($charset, ...) =
There's plenty of $charset happiness to crush heartlessly.
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 08:19 PM
Quote
That's what you get when code stays static for years!
Did you test with older but still supported versions of Opera and FF? I can test with Opera 9 if you ask me.
I didn't test with older stuff particularly; Chrome 7, FF 3.6.9 or 3.6.10, Opera 10.60 (I think) and IE 8. But as a general rule users on non IE platforms are much better about staying up to date, and really I think they've all moved on a long way since 2006. Except IE that still needs its hand holding otherwise it tries so hard to be clever and fails so dismally. No, IE, I am not using Windows-1252 for this!
Quote
Can't we just remove the first parameter? It'll always be set to UTF-8 anyway...
I just wanted it to work without spewing errors for registrations so I could sign up test accounts for attachment testing.
Title: Re: New revs
Post by: live627 on October 12th, 2010, 09:25 PM
Quote from Arantor on October 12th, 2010, 02:36 PM
Quote
Okay, I'll switch to the post editor... Quick Reply is cool when you're not replying to a long post. There's no handle to increase its size... (Idea for later.)
Get a better browser then; Chrome's had it built in for ages. :P
Firefox is fine, but it doesn't have resizeable text boxes that those... webkit browsers
Title: Re: New revs
Post by: Arantor on October 12th, 2010, 09:26 PM
C'mon, you LURVE those Webkit browsers :D
Title: Re: New revs
Post by: live627 on October 12th, 2010, 09:32 PM
TROLL :P lol
Title: Re: New revs
Post by: Nao on October 13th, 2010, 11:21 PM
rev 207
+ Added French language translation -- hopefully up to date! (*.french.php)
+ Added flag icons for French and English languages -- a future feature. (Flag.english.png, Flag.french.png)
- Removed some core/babylon/classic theme leftovers. (upgrade_2-0.sql, Install.english.php)
* Temporarily renamed default theme to 'Wager'. (Install.english.php)
* Replaced logo with a cleaner version made by Bloc. (wedgelogo.png, index.template.php)
+ Added language strings for upcoming features: Ignore Topics, Merge double posts, Spoiler tag, Topic privacy, Blog system. (Errors.english.php, Help.english.php, index.english.php, ManageMembers.english.php, ManageSettings.english.php)
! Some permission names implied that *_any was for "other members", rather than "all members" (i.e. the *_own permission doesn't need to be enabled at the same time.) There may be some leftovers. (ManagePermissions.english.php)
Quote from Arantor on October 12th, 2010, 08:19 PM
I just wanted it to work without spewing errors for registrations so I could sign up test accounts for attachment testing.
Why would it give errors...? Oh, you mean it was a quick hack, somehow?
Title: Re: New revs
Post by: Arantor on October 13th, 2010, 11:52 PM
I just had the account sign up regularly, which causes an email, and the email functions still had $charset in them without $charset being defined.
Title: Re: New revs
Post by: Nao on October 13th, 2010, 11:57 PM
rev 208
- Removed a few past dates from the calendar installer. Also deleted the next Thanksgiving because we won't be out by then. And we're British and French. Do you think we care about Thanksgiving? We can be bastards 365 days a year. That's cool. (install_2-0.sql)
* The unused UTF8 converter added a curious string to the database. Probably not worth looking into it as it'll be removed anyway. (ManageMaintenance.php)
- Removed a $context['utf8'] leftover. Used some escaping so I guess that's why Pete missed it. (Profile-Modify.php)
! Syntax error. (Admin.french.php)

---> Note to self: check why calendar seems to take more than 100% width.
Quote from Arantor on October 13th, 2010, 11:52 PM
I just had the account sign up regularly, which causes an email, and the email functions still had $charset in them without $charset being defined.
And no way to delete that?
Title: Re: New revs
Post by: Arantor on October 14th, 2010, 12:03 AM
I didn't look into it that highly, I just wanted it to work without errors, I figured I'd worry about it being perfectly clean later.
Title: Re: New revs
Post by: Nao on October 14th, 2010, 12:05 AM
It just generated an error when saving one's profile account page.
(Happened after I changed my default language to French.)
Title: Re: New revs
Post by: Arantor on October 15th, 2010, 10:26 AM
Revision: 209
Author: arantor
Date: 08:49:41, 15 October 2010
Message:
! Added flag to the manage languages page (ManageServer.php)
! Clarified that the language name is clickable (ManageSettings.english.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php

Posted: October 15th, 2010, 09:50 AM

Revision: 210
Author: arantor
Date: 09:06:09, 15 October 2010
Message:
- Remove legacy GIF support (detailed-version.js, Class-Graphics.php, Subs-Graphics.php)
----
Deleted : /trunk/Sources/Class-Graphics.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/other/xml/detailed-version.js

Posted: October 15th, 2010, 10:06 AM

Revision: 211
Author: arantor
Date: 09:26:06, 15 October 2010
Message:
! Attachments now have .ext extensions by default to ensure they are not treated as ASCII files accidentally. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on October 15th, 2010, 10:28 AM
(Maybe I should do that .ext thing for AeMe as well...)
Title: Re: New revs
Post by: Arantor on October 15th, 2010, 03:04 PM
Revision: 212
Author: arantor
Date: 12:39:21, 15 October 2010
Message:
! Being bold.
 ! The info center is now its own template file. (BoardIndexInfoCenter.template.php)
 ! The board index and info center have been broken down into smaller subtemplates and called as a group. (BoardIndex.php, BoardIndex.template.php, BoardIndexInfoCenter.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Added : /trunk/Themes/default/BoardIndexInfoCenter.template.php

Posted: October 15th, 2010, 01:39 PM

I do sort of want to break up the board index and message index into a board listing template; the code used between the two is identical except for spacing only and the initial foreach.

If I break them off into a new function which accepts an array (by reference) of boards, then foreachs through that array, we can cut the size of the board and message indexes down, and have them share the board listing code.
Posted: October 15th, 2010, 01:41 PM

Revision: 213
Author: arantor
Date: 13:25:44, 15 October 2010
Message:
! More cleanup now we know GD2 must be available (Subs-Graphics.php)
----
Modified : /trunk/Sources/Subs-Graphics.php

Posted: October 15th, 2010, 02:26 PM

Revision: 214
Author: arantor
Date: 13:44:05, 15 October 2010
Message:
! Doc additions, cleanups (Help.php, Subs-Graphics.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs-Graphics.php

Posted: October 15th, 2010, 02:44 PM

Revision: 215
Author: arantor
Date: 14:04:03, 15 October 2010
Message:
! Announcement sending now in its own files instead of bulking up the Post files (index.php, Post.php, Post.template.php, Announce.php, Announce.template.php)
----
Added : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on October 15th, 2010, 04:56 PM
rev 216
* Minor spacing, and French translation. (Post.php, Subs-Graphics.php, ManageSettings.french.php)

(Well, it just means I'm done reviewing your commits :P)

BTW, why call the new file BoardIndexInfoCenter.template.php, rather than just InfoCenter.template.php? I know it's only initialized in the board index, but still... It could be recycled, couldn't it?

(I'm all for removal of recycled code, BTW!)
Title: Re: New revs
Post by: Arantor on October 15th, 2010, 04:58 PM
I did think about that, but it's tied to BoardIndex.php right now, since BoardIndex() gets all the stats, birthdays, recent posts, calendar entries, online folks etc to make it work.

The only way we could reasonably separate it and make it stand alone like that would be to make a InfoCenter.php, with InfoCenter(), which could be called from BoardIndex.php (or, notionally, Subs-BoardIndex.php) to get the information. Thing is you could have this subsidiary function manage the changes to the template list, as well as loading the other template, meaning BoardIndex would be 99% just for the board index itself (which would be neat)
Title: Re: New revs
Post by: Nao on October 16th, 2010, 11:46 AM
rev 217
* Updated to SMF rev 10171, and hacked my own style into the changes. (changelog.txt, tools folder, ManagePaid.php, Profile-Modify.php, Profile-View.php, Subs.php, ie6.css, ie7.css, index.css, GenericMenu.template.php, Post.template.php, Profile.template.php, editor.js)
- Since we're not upgrading from SMF1, removed the dont_repeat_theme_core process in install/upgrade. Kept the equivalent smiley upgrade process for now, because we may need that code for the SMF2->Wedge converter. (install_2-0.sql, upgrade_2-0.sql)
* Improved visuals for the search highlight class. (index.css)
* Improved Wedge logo. Not perfect... But better. (wedgelogo.png)

I postponed work on <div class="content"> until I was done with SMF.
I'll get started today... Will probably commit in several batches because I doubt I'll be finished today.
Posted: October 16th, 2010, 11:44 AM
Quote from Arantor on October 15th, 2010, 04:58 PM
I did think about that, but it's tied to BoardIndex.php right now, since BoardIndex() gets all the stats, birthdays, recent posts, calendar entries, online folks etc to make it work.
We could simply add a comment in InfoCenter.template.php stating that this is called from within BoardIndex()... No?
Title: Re: New revs
Post by: Arantor on October 16th, 2010, 12:08 PM
I'm in the midst of polishing up the Bad Behavior implementation (for stopping bad bots and spammers) and won't commit until I'm all done because it's pretty intricate - also means I probably won't review those patches until I'm ready to commit.

Seems to me there's a lot of purely style tweaks when the dev time would be better spent fixing bugs.
Title: Re: New revs
Post by: Nao on October 16th, 2010, 01:23 PM
Looking at the logs, 99% of what Antechinus does is style tweaks and template fixes. That's basically all he's been doing since the beginning -- visual tweaks. I know I'm doing a lot of these too, as it's one of my favorite things to do, but I'm not that focused...!
Norv does the converter stuff (I ain't importing that, though.) and hasn't committed anything interesting the last 3 weeks. Same for SiNaN, pretty much.
Uh...

"content" is going at a good pace but I'm currently stuck on a styling dilemma with the Display template. I'm crazy enough to spend time trying to fix a single pixel.
Title: Re: New revs
Post by: Arantor on October 16th, 2010, 03:46 PM
Ahtalkanus is allegedly on the team as a designer and by his own admission is not a strong programmer.

Norv's had commit rights to the converters branch since even before I left the team, which I thought was somewhat awkward.

As for the display template, I've been trying to figure out how I want to split that up since I think it does need to be split up.
Title: Re: New revs
Post by: Nao on October 16th, 2010, 06:19 PM
Quote from Arantor on October 16th, 2010, 03:46 PM
Ahtalkanus is allegedly on the team as a designer and by his own admission is not a strong programmer.
That's to his credit then, but I'm not as fine with the team hiring non-devs to do dev work.
I mean, why didn't they just invite Bloc instead? He wrote Curve in the first place, he can fix it! Ante's main achievement on Curve was... What? Adding more markup?
Quote
As for the display template, I've been trying to figure out how I want to split that up since I think it does need to be split up.
Well, it does. At the very least, we should elaborate on how we implement templating for floating topics.
Title: Re: New revs
Post by: Arantor on October 16th, 2010, 06:34 PM
Note the reason Ahtalkanus has a Dev badge as opposed to a Core Dev badge, that's the principle difference. That, and that Dev rather than Core Dev was also TE's position for a long time as he looked after converters rather than the core.

Interestingly Bloc used to be on the dev team, with a Dev (rather than Core Dev) badge when he initially designed Curve.
Title: Re: New revs
Post by: Nao on October 17th, 2010, 02:18 PM
All right... Makes more sense when said this way.
Posted: October 16th, 2010, 07:09 PM
Quote from Nao/Gilles on October 16th, 2010, 01:23 PM
"content" is going at a good pace but I'm currently stuck on a styling dilemma with the Display template. I'm crazy enough to spend time trying to fix a single pixel.
Fixed dilemma yesterday. Didn't get to commit any batch. That's because it's moving at a faster pace than I expected... I just finished doing all instances :) Even had time to fix hundreds of indentation bugs, as well as a few other bugs. (http://dev.simplemachines.org/mantis/view.php?id=4505#bugnotes)
Will commit today, but I'll need to review all of my fixes first... (Ah ah, more fun. I'm so tired.)
Title: Re: New revs
Post by: Nao on October 17th, 2010, 04:40 PM
Revision: 218
Author: nao
Date: 16:37:00, dimanche 17 octobre 2010
Message:
* Introducing a new favicon and associated logo. (favicon.ico, wedgelogo.png)
! Uppercase $_POST is duh. (PersonalMessage.php, PersonalMessage.template.php)
! Fixed a Javascript exception when clicking an editor button under Opera. (script.js)
* Board lists in BoardIndex and MessageIndex weren't clearly targeted in index.css (BoardIndex.template.php, MessageIndex.template.php, index.css)
* Various spacinazi and minor fixes. (BoardIndexInfoCenter.template.php, GenericMenu.template.php, PersonalMessage.template.php)
! A user's list of posts should show the Delete/Quote/etc. buttons next to their title, rather than below the message, for consistency reasons. (Profile.template.php)
! Fixed two validation errors. (index.template.php)
- Deleted all .content occurrences, as they no longer were needed. Fixed dozens of indenting and spacing issues in the process. (ssi_examples.php, ie6.css, rtl.css, index.css, Templates: Admin, BoardIndex, Display, ManageAttachments / Bans / Boards / Calendar / Mail / Maintenance / Membergroups / Members / News / Paid / Permissions / ScheduledTasks / Search / Smileys, MessageIndex, Packages, PersonalMessage, Post, Profile, Recent, Register, Reports, Search, SendTopic, SplitTopics, Stats, Themes, Who)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Stats.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/css/admin.css
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/css/rtl.css
Modified : /trunk/Themes/default/images/wedgelogo.png
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/changelog.txt
Modified : /trunk/favicon.ico
Modified : /trunk/other/ssi_examples.php

FYI, this rev saved a total of 22.800 bytes (SVN included, so it's not exactly byte for byte.)
Not much, but still welcome...!
Title: Re: New revs
Post by: Nao on October 17th, 2010, 08:20 PM
rev 219
* Updated to SMF svn 10185 whatever needed to be updated. *sob* Second time I get my name in the changelog. Also updated French version.
  ! Oops, yet some more formatting cleanup! Nao in action :). And other pedantic stuff. (several files) [Bug 4505]
  * Moved CSS and JavaScript to top. (index template) [Bug 4468]
  ! Fixed an undefined variable in some cases (Subs.php) (Note from Nao: changed the code to avoid using an extra line.)
  ! Some actions were unnecessarily logged. (index.php) [Bug 4465]
  & Who's Online language strings were missing for some actions. (Who.php, Who language file) [Bug 4465]
Title: Re: New revs
Post by: live627 on October 17th, 2010, 11:33 PM
Quote from Nao/Gilles on October 17th, 2010, 04:40 PM
! Uppercase $_POST is duh.
You mean they were lowercase?
Title: Re: New revs
Post by: Arantor on October 17th, 2010, 11:33 PM
Nah, there was $_POST['ID_ADMIN'] or something similar IIRC in the PersonalMessage files.
Title: Re: Editor JS
Post by: Nao on October 18th, 2010, 05:19 PM
rev 220, 221, 222: http://wedge.org/?msg=249861

rev 223
- Removed validate_unicode__recursive entirely. (QueryString.php, Subs.php)
* Updated to SMF rev 10187. All of the changes are DB related, and most of them were already done in Wedge. (changelog.txt, upgrade.php, DbExtra.php, DbPackages.php, DbSearch.php)
  ! UTF8 fixes. Thank you, Nao! (Subs.php, Subs-Post.php) [Bug 4498]
  ! One more slight change, in supported versions. (install, upgrade, convert scripts)
  ! Now MySQL versions support ENGINE, so simplify some things. (several files)
  ! Escaping potential identifiers used as column names (DbExtra-mysql.php, DbExtra-postgresql.php) [Bug 4261]
Title: Re: Editor JS
Post by: Arantor on October 18th, 2010, 07:23 PM
Revision: 224
Author: arantor
Date: 18:21:43, 18 October 2010
Message:
+ Bad Behavior tests now part of the core (sorry for all the language strings, note also that not every BB test is included). Still needs a log viewer to be implemented, though.
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Errors.template.php
Added : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install_2-0.sql


Just to clarify; every intrusion attempt/bad hit is logged with enough details to be able to see what the issue is, and the error specifically encourages the recipient to ask the admin quoting the 'incident number' which is the id in the table. Sorry for the size of the commit but I wanted to get it all in one go.
Title: Re: New revs
Post by: Nao on October 18th, 2010, 09:16 PM
Oh my... An awful lot of code! Must have been painful to implement... Question time on the related topic!
Title: Re: New revs
Post by: Arantor on October 18th, 2010, 10:06 PM
It's still smaller than the original WTF-laden code :P
Posted: October 18th, 2010, 09:18 PM

Revision: 225
Author: arantor
Date: 21:05:57, 18 October 2010
Message:
! Fixed version of CIDR compare function. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 11:06 AM
rev 226 -- a.k.a. biggest one evah.
(And probably buggiest, too.)

* Updated to SMF rev 10205. Check out the changelog. (changelog.txt, index.php, Admin.php, Class-Editor.php, Load.php, ManagePaid.php, Profile.php, Subs-Boards.php, Subs.php, Who.php, install.css, Display.template.php, ManagePaid.template.php, MessageIndex.template.php, ManagePaid language, Who language, editor.js, script.js)

@ !!! Need to change $user_info['url'] etc. (index.php, Load.php)

@ !!! Added avatar and image caching, but mod_header is required, so leaving it commented out for now. (.htaccess)

+ Added support for merging double posts. Most of the magic happens in SplitTopics. (index.php, Admin.php, Display.php, ManagePosts.php, SplitTopics.php, Subs-Post.php, index.css, Display.template.php, Admin language, Errors language, index language, ManageSettings language, mergeposts.gif)

+ Added support for URL trimming. (ManagePosts.php, Subs.php, Admin language)

+ Added partial Pretty URLs feature. QueryString.php is awfully hardcoded and a WIP. Support for finding topics by name should be deleted or improved. (index.php, .htaccess, install_2-0.sql, readme_*.html, Admin.php, Display.php, Load.php, ManageBoards.php, ManageErrors.php, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, RemoveTopic.php, SplitTopics.php, Subs-Boards.php, Subs-PrettyUrls.php, Subs.php, SSI.php, Admin.template.php, admin.css, index.template.php, ManageBoards.template.php, Admin language)

- Removed queryless URL feature. (.htaccess, readme_*.html, repair_settings.php, smfinfo.php, ManageSettings.php, News.php, QueryString.php, Subs.php, Help language, ManageSettings language)

- Removed parameters in db_insert_id function. (install.php, Display.php, ManageBans.php, ManagePermissions.php, Poll.php, Post.php, Profile-Actions.php, Profile-Modify.php, RemoveTopic.php, RepairBoards.php, Security.php, SendTopic.php, SplitTopics.php, Subs-Boards.php, Subs-Calendar.php, Subs-Categories.php, Subs-Database.php, Subs-Graphics.php, Subs-Members.php, Subs-Post.php, Subs.php)

+ Added in boards table the preliminary structure for many upcoming features: per-board allowed and banned members, board owners, board type (should probably be called internally "board_type" rather than "wedge_type"), custom style, show title, per-board stats, per-board language. (install_2-0.sql)

+ Added more preliminary support for board owners. (Load.php:571+)

+ Added more preliminary support for per-board allowed and banned members. Need to implement a limit + group_concat, or just disregard multiple contradictory entries in the board_members table and rewrite code at line 714. (Load.php:576+)

+ Added very preliminary support for board privacy. (Load.php:633)

+ Added automatic creation date within the boards table. This could be useful in the future. (install_2-0.sql)

! Some default settings were applied to guests when they should have been applied to members instead. (install_2-0.sql)

* Changed some defaults at install time: week starting day (previously Sunday, now Monday), return to post, save PMs, display quick mod checkboxes, quick reply on and closed by default, view newest PMs first, remove inbox label when applying PM label, and show Today and Yesterday in dates. (install_2-0.sql)

* Increased post box size and board description box size. (Class-Editor.php, ManageBoards.template.php)

@ !!! bareimg placeholder. (Class-Editor.php)

@ !!! placeholders for {query_see_topic} (topic privacy) and a friend subselect override, which may or may not be rewritten later. (Subs-Database.php)

@ !!! placeholder for Ignore Topics. (Admin language)

+ Added support for align parameters in img tags. (Class-Editor.php)

* Don't fix url tags into a more developed version, there's no point in that using more space in the database. (Class-Editor.php)

* Disallow bots from accessing the Post template. Is this a good idea? (Display.php)

* If not on a forum, blog posters can't remove their own topics if not a moderator. Is that logical? I don't know. You tell me. I probably had a good reason for that. (RemoveTopic.php)

* Show bots in green italics in Who's Online. Noisen style. (Who.php)

+ Show board URLs next to topic links in Who's Online. Noisen style, too. (Who.php)

+ Added support for the 'more' BBC tag, which allows blog posts (upcoming feature) to be trimmed in the homepage, and shown in full in the dedicated post page. (Subs.php)

* Moved "Add Poll" button to the Topic Moderation strip, as currently there can only be one poll per topic and it changes their nature. (Display.template.php)

! Accidentally double-clicking a user name in topic pages when using the user menu could select said name. (Display.template.php)

! Unreverted a spacing commit I made for SMF that they reverted because they're bad people. I have your names, I'll tell your moms. (Display.template.php)

- This ":" in the Last Edit area has always annoyed me. (Display.template.php)

- Deleted a few remaining GD warnings from the language files. Please note that there are more GD-related tests that can be safely removed in plenty of places now. (Admin language)

! Fixed various errors in the French version. Also discovered the horror that is the EmailTemplates French translation. Oh, my... I'm nearly tempted to revert it back to English to save French users the agony of going through these emails. (EmailTemplates, Help, Login, Post, Profile)

+ Added French version of the Security language file. About half of it is translated for now... (Security.french.php)

* Spacinazi. (SplitTopics.php, MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 08:39 PM
rev 227

- Removed a couple of GD warning leftovers. (ManageAttachments.php, Register.php)
* Having some fun with subtle fade-in effects in non-IE6/7/8 browsers... (index.css, script.js)

Pete, can you have a look at the menu effect? I tested in Chrome, Opera 11 and IE6/8. Doesn't work in IE but doesn't break anything, either. I like the effect, but I'm a bit concerned that it could make it a bit TOO stylish at this point... You know, the more goodies you add, the less they stand out?
Title: Re: New revs
Post by: Arantor on October 22nd, 2010, 08:48 PM
I just ran through clean install - haven't checked any of the changes in either revs 226 or 227 but wanted to look at this quickly for you.

Installer has a much wider right margin than left now for some reason but more importantly:
Quote
Line #1603: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{db_prefix}pretty_urls_cache (
url_id varchar(255) NOT NULL,
replacement v' at line 1
Should be {$db_prefix} in the install script IIRC

:edit: So I fixed that in the installer, and get the following just on the last step (the 'do you want to delete the install files' one)
Quote
Notice: Undefined index: pretty_enable_cache in C:\Dev\public_html\smf_test\wedge\Sources\Subs.php on line 160

Notice: Undefined index: pretty in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Notice: Undefined index: db_count in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218


Going back to the original point, the fade-in looks nice, and I think I'm right in saying you moved the menus to left-align under the icon rather than the text? It's subtle and understated - I'd leave it as is personally.

Merging is broken - Admin > Posts > Merging gives:
Quote
Fatal error: Call to undefined function prepareDBSettingContext() in C:\Dev\public_html\smf_test\wedge\Sources\ManagePosts.php on line 421
Need to make sure ManageServer.php is included in the function.
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 09:04 PM
Quote from Arantor on October 22nd, 2010, 08:48 PM
I just ran through clean install - haven't checked any of the changes in either revs 226 or 227 but wanted to look at this quickly for you.
Thanks.
Quote
Installer has a much wider right margin than left now for some reason
That's probably because of the body { width: 90% } that the SMF team added very recently at the top of install.css. I left it as is but suspect it would only bring problems. Okay, I just launched the installer and -- wow -- it looks good with my css, eheh :) I removed width: 90% and replaced it with padding-top: 20px; looks better.
Quote
Should be {$db_prefix} in the install script IIRC
Indeed, sorry about that. Fixed. Whoever commits it first :P
Quote
Notice: Undefined index: pretty_enable_cache in C:\Dev\public_html\smf_test\wedge\Sources\Subs.php on line 160

Notice: Undefined index: pretty in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Notice: Undefined index: db_count in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218
Hmm... That probably means this requires initializing PURL first. (In the admin.)
I guess I'll have to do it in the installer, or something...
Quote
Going back to the original point, the fade-in looks nice, and I think I'm right in saying you moved the menus to left-align under the icon rather than the text? It's subtle and understated - I'd leave it as is personally.
Hmm, actually it's been like that since the day I added the icons. I used a padding trick to achieve that effect. It's totally different from the trick in use at wedgeforum.com, because this time I figured out how to do it in CSS rather than with tables :P
Quote
Merging is broken - Admin > Posts > Merging gives:
Quote
Fatal error: Call to undefined function prepareDBSettingContext() in C:\Dev\public_html\smf_test\wedge\Sources\ManagePosts.php on line 421
Hmm yeah I didn't test the admin area, only the actual merging (which is enabled by default apparently...)
Quote
Need to make sure ManageServer.php is included in the function.
Yup. Thanks for the feedback.
Title: Re: New revs
Post by: Nao on October 22nd, 2010, 09:33 PM
rev 228
! Fixed broken installer. (install_2-0.sql)
! Fixed PrettyURLs warnings. (Subs.php, Subs-PrettyUrls.php)
* Improved installer styling. (install.css)
* catbg class wasn't using the same color as cat_bar. (index.css)
! Fixed double post merging admin area. (ManagePosts.php, Admin languages, ManageSettings languages)

Thanks Pete!
Title: Re: New revs
Post by: Nao on October 23rd, 2010, 10:46 PM
rev 229
* Put 31 of the BBC button images into a single sprite. Yay! (Class-Editor.php, editor.js, index.css)
+ Added Spoiler tag. (Subs.php, index.css, bbc/sprite.png, index language, Post language)
Title: Re: New revs
Post by: Nao on October 24th, 2010, 01:10 AM
rev 230
* Improved settings styling in admin area by separating setting titles from setting descriptions. (index.css)
* Spacinazi -- today, we remove all double spaces except from comments. (Plenty of files. Ouch.)
! Javascript error in admin error log when using the French version. Why isn't JavaScriptEscape used everywhere, eh? (Errors.template.php)
Title: Re: New revs
Post by: Nao on October 24th, 2010, 09:50 PM
rev 231
- Deleted unused "database filename" feature from SQLite leftovers. (install.php, Install files)
* Updated all files to reflect the change to the SMF 2.0 RC4 codebase.
* Spacinazi. (index.template.php)
* Updated to SMF rev 10242. At this point, isn't the data parameter in clean_cache('data') redundant? What else is left to delete, anyway?
  ! Reverting 10207 for Subs.php. Should be included only if it can be properly tested.
  ! Fixed webkit unexpected behavior when setting font styles (thank you Nibogo!) (editor.js) [Bug 4511]
  ! Allow nested [size] tags - we do allow them anyway, just not in all combinations (Subs.php)
  ! censor area should only be available to admins - reported by more, including KinG-InFeT.
  ! Package servers URLs and names properly cleaned for all circumstances - reported by KinG-InFeT.
  & Adapt a language string to the changes in SMF meta keywords. (Help.english.php) [Bug 4515]
  & Notify about PostgreSQL of older and newer versions not supported in the same database. (install language file) [Bug 4214]
  ! Language files are no longer cached. (Load.php, ManageMaintenance.php, ManageServer.php, Subs.php, Themes.php)
  & Remove the note about caching from all language files. (many files)
  ! Load English version of language files as a fallback for missing language strings. (Load.php) [Bug 2743]
  * Added a new group type, protected, for too powerful groups to be managed only by true admins. (Groups.php, ManageMembergroups.php, Profile-Modify.php, Subs-Membergroups.php, ManageMembergroups template, Profile template) [Bug 3528]
  & Added the new group type language string for the change above. (ManageMembers language file) [Bug 3528]
  ! Make sure Administrator group type is set to protected on install and upgrade. (install_2-0_*.sql, upgrade_2-0_*.sql)
  ! Making sure eol-style is on all files on other directory as well. (might have been missed) (/other files)
  ! Making sure eol-style is set on all our converters as well. (/other/converters ASCII files)

Well... Looks like the dev team got to work, eh!
I'm surprised they added such a feature as "protected membergroups"... It demanded a lot of code updates. Hopefully it isn't buggy...
Also, all of the files are updated because RC3 had to be changed to RC4.
Title: Re: New revs
Post by: Nao on October 24th, 2010, 11:52 PM
rev 232
* Replaced all reqWin(this.href) calls with reqWin(this), to make calls shorter and allow positioning the popup window next to the clicked link. (Plenty of files, script.js)
Title: Re: New revs
Post by: Arantor on October 25th, 2010, 08:03 PM
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.

Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.

Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
Title: Re: New revs
Post by: Nao on October 26th, 2010, 10:09 AM
rev 233
! Fixed undefined error in merge admin. (ManagePosts.php)
* Optimized index.css for size. "0.5em" becomes ".5em", "padding: 1px 3px 2px 3px" becomes "padding: 1px 3px 2px", things like that... Inspired by a CSS minifier. (index.css)
* Reverted hover color on main menu's top-level entries, to match the admin menu color. Too many different colors can be confusing... (index.css)
* Updated to SMF rev 10246.
  ! Fix for windows check (ManageServer.php)
@ Also in latest SMF revs: RC4 version updates, and smfinfo.php was updated to a new version... It doesn't work very well, though, failing notably at showing the current version, uh. Should probably remove that file from the svn entirely...
Quote from Arantor on October 25th, 2010, 08:03 PM
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.
I don't know, it adds plenty of code and it's slightly obscure... Well, at least on first look.
Sinan asked for beta testers to look into the addition. I'm afraid I can't bother...
Quote
Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.
I don't know... I couldn't even find the word 'censor' in the diff patch (?!), and the changelog doesn't specify which file was changed... (Good job!)
Quote
Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
clean_cache('data') might be worth mentioning, though...
But maybe we'll add more cache types later. CSS? Hmm...
Title: Re: New revs
Post by: Nao on October 26th, 2010, 12:29 PM
rev 234
* resize-handle.gif is a horribly wrong version... Seriously, 800+ bytes for that? Also reworked the 'picture' to suggest enlargement. (resize-handle.gif)
* Repositioned sprites so that the empty space is at the bottom right. (bbc/sprite.png)
+ Did I actually forget to commit edit.gif in the smiley list...? Maybe this should be a BBC button instead, though... (edit.gif)
! Fixed wrong resizer bar width on IE browsers. (editor_ie.css)
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 04:29 PM
Going back to the censoring, I seem to recall it's in either Admin or ManagePosts, where the permission is changed from moderate_board to admin_board.

For cache cleaning, there's a bunch of different things, primarily data_ and lang_ that get cached but I think there are more in the bowels of the system.
Title: Re: New revs
Post by: Nao on October 26th, 2010, 06:10 PM
Code: [Select]
'posts' => array('ModifyPostSettings', 'admin_forum'),
'bbc' => array('ModifyBBCSettings', 'admin_forum'),
'censor' => array('SetCensor', 'moderate_forum'),
'topics' => array('ModifyTopicSettings', 'admin_forum'),

This has been in both Wedge and SMF for at least the last month... I really don't see any changes in SMF RC4 in that respect!
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 07:10 PM
Is that Admin.php or ManagePosts.php?
Title: Re: New revs
Post by: Nao on October 26th, 2010, 07:17 PM
ManagePosts... The code that redirects to the respective tabs at the beginning.
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 07:25 PM
Well, there's an entry in the Admin menu, and IIRC there's another entry at the start of ManagePosts, but I can't remember off hand which is actually needed to be changed - if in doubt both should be set to admin_forum.
Title: Re: New revs
Post by: Nao on October 26th, 2010, 08:31 PM
All righty, in Admin.php:

Code: [Select]
'postsettings' => array(
'label' => $txt['manageposts'],
'file' => 'ManagePosts.php',
'function' => 'ManagePostSettings',
'permission' => array('admin_forum'),
'icon' => 'posts.gif',
'subsections' => array(
'posts' => array($txt['manageposts_settings']),
'bbc' => array($txt['manageposts_bbc_settings']),
'censor' => array($txt['admin_censored_words']),
'topics' => array($txt['manageposts_topic_settings']),
'merge' => array($txt['manageposts_merge']),
),
),

So, apparently one needs to have admin_forum to access all of these tabs...
Which means ManagePosts is buggy in that respect.

:edit:

http://dev.simplemachines.org/mantis/view.php?id=4520
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 09:14 PM
Wouldn't that imply that ManagePosts doesn't even need to be checking at all? (Or indeed, any of the other files within the admin area)

This isn't a trivial thing to change, because it's either being checked twice and Admin.php holds all the keys to the kingdom (and everywhere else can drop the secondary checks) - or Admin.php simply checks it for the menu and each file is still responsible for its own permissions (much as SMF 1 used to do)
Title: Re: New revs
Post by: Nao on October 26th, 2010, 09:36 PM
Yeah, I was wondering the same... Maybe the report will clear this up.

rev 235
! Fixed htaccess by making sure mod_headers is enabled before we try to rewrite headers. (.htaccess)
! Forgot to apply group_type to membergroups table at install time. (install_2-0.sql)
+ Added support for the following pretty URLs: /topic_id/topic_name/page_number/, /year/month/day/, /cat/category_name/, /tag/tag_name/, and /board_page/ (QueryString.php)
Title: Re: New revs
Post by: Nao on October 26th, 2010, 10:09 PM
rev 236
* Updated to SMF rev 10247.
  ! A safer handling of the database last error and generally writing Settings.php [Bug 4222]

--> Mainly it moves db_show_error to Errors.php... I updated the docs, hopefully it's okay.
Now db_fatal_error() is 100% an alias. Norv forgot to remove the $sourcedir global, I finished that.
There's a @todo in there. Yeah, the function could be removed, but... mods, maybe?
Title: Re: New revs
Post by: Arantor on October 26th, 2010, 10:12 PM
I don't know any mods that modified that (not even mine), since really any errors should be funnelled through fatal_*_error or trigger_error if you're doing something funky. No need to worry about such changes affecting mods :)
Title: Re: New revs
Post by: Nao on October 27th, 2010, 12:07 AM
rev 237
- Deleted db_fatal_error(), as it was no longer used. (index.php, Errors.php, Load.php, Subs-Database.php)

I double-checked, and there was no such "or db_fatal_error()" occurrences in the code, even though that's mentioned in the SMF source files...
Title: Re: New revs
Post by: Arantor on October 27th, 2010, 12:27 AM
It may well have been like that once upon a time.

It would be worth forcing the conditions that would otherwise cause it to trigger that error (certain DB connectivity issues) just to prove it doesn't abort inappropriately.
Title: Re: New revs
Post by: Nao on November 2nd, 2010, 01:13 PM
I figured I should commit whatever I have that isn't related to CSS variants... It'll be easier for me in the longer term because I don't know when I'll be ready to commit.

rev 238

* Renamed install and upgrade scripts to drop the version number, as Wedge is 1.0, not 2.0. (install.php, install.sql, upgrade.php, upgrade.sql)
- Removed most of the credits. Technically, these names have nothing to do with our project... (Who.php, Who.template.php)
* Updated to SMF svn 10260. There are still a couple of revs to catch up with...
  ! Last minute: boards incorrectly retrieved (Subs-Boards.php, Load.php) (NB: Load.php not done yet.)
  ! Last minute: an incorrect warning (Profile-Actions.php)
  ! Last minute: adding SMF favicon. (favicon.ico)
  * Validation errors due to a typo in themes list (Themes template) [Bug 4505]
  ! On some versions of Opera the cursor wasn't displayed in WYSIWYG editor (thanks TE) [Bug 4521]
  ! Clean the entire cache on the disk, if any, during scheduled maintenance (ScheduledTasks.php)
  ! Small addition to clean_cache() documentation (Subs.php)
  ! Manage Posts area should only check for admin_forum permission. (ManagePosts.php) [Bug 4520]
  * Undefined index in Subs.php for Core theme (Display template)
Title: Re: New revs
Post by: Nao on November 5th, 2010, 09:14 AM
rev 239

@ The big "theme stylings" initial commit!
@ todo: remove support CSS variants to avoid confusion? Make sure caching is solid (has flush option, fixes folder rights, etc.) Maybe separate theme entries from styling entries with Javascript in ManageBoards. Allow choosing a styling for non-board pages, too! (via $modSettings)
+ Added support for stylings and added two sample stylings. (install.sql, Class-Editor.php, Load.php, ManageBoards.php, Subs.php, Subs-Boards.php, css/index.css, index.template.php, ManageBoards.template.php, css/cache, css/Green/*, css/Nix/*)
+ Added support for gzipped CSS files. (.htaccess)
+ Store current user agent in $context['browser']['agent'] for later use. (Load.php)
* More SMF svn fixes. This will be my last batch, since SMF no longer want us to be able to stick to their codebase. (Class-Editor.php, Load.php)
! Fixed undefined error. (ManageAttachments.php)
! Pretty URLs really need some fixin'... (QueryString.php, Subs-Boards.php)
* Merged mergeposts.gif button into quickbuttons.png sprite file. (css/index.css)
* Spacinazi. (Load.php, Subs.php, Themes.php)

PS: forgot to mention Subs.php being modified by the styling feature in the svn changelog. Adding it here...
Title: Re: New revs
Post by: Arantor on November 5th, 2010, 09:57 AM
Some kind of separation is needed since the idea is to detect which file to run by looking for a file with the same name as the action, and I don't really want to have to give it rules like not firing on Load/QueryString/Manage*/Subs-*/etc
Title: Re: New revs
Post by: Nao on November 5th, 2010, 12:17 PM
The more we do to fix sMF, the more we realize we have to do if we are to follow our instincts. <sigh>
Title: Re: New revs
Post by: Arantor on November 5th, 2010, 12:20 PM
Of course, the corollary: the more we follow our instincts, the further we get from SMF's lock-down mentality.
Title: Re: New revs
Post by: Nao on November 5th, 2010, 06:43 PM
rev 240
! A misplaced "}" broke board identification if Pretty URLs were disabled. (QueryString.php)
! Couldn't disable Pretty URLs once enabled. (ManageSettings.php, Admin.template.php)
Title: Re: New revs
Post by: Nao on November 5th, 2010, 07:14 PM
rev 241
! Don't show the Pretty URLs area if you're editing a board with Pretty URLs disabled... (ManageBoards.php, ManageBoards.template.php)
! Could possibly keep using Pretty URLs even if it was disabled in the admin. (QueryString.php)

PS: leave rev 242 to me, it's one of my lucky numbers :P
Title: Re: New revs
Post by: Arantor on November 5th, 2010, 09:27 PM
Go for rev 242 :) I haven't started the changes yet due to other stuff going on.
Title: Re: New revs
Post by: Nao on November 5th, 2010, 09:34 PM
It's a scam!

rev 242
* Replaced » with a graphic arrow in the linktree. It sucks and may not work outside of Opera, but I wanted to have rev 242. Mwahaha. Okay, I'll take my pills. (index.css, index.template.php)
+ Placeholder for theme styling in themes table. (install.sql)

Seriously, this 242 isn't linked to 42 or anything... It's just that it was the length in kilobytes of the scrolltext I wrote for a music compilation back in 1990... It was the world record and I think it never was broken. Unfortunately that screen never found itself featured in a demo disk AFAIK... But I got to show it off in a few coding parties, including the legendary STNICCC. Ah ah, good times. Too bad I've lost said demo!

Also up to post #1500 at the same time, eh eh.
Title: Re: New revs
Post by: Arantor on November 6th, 2010, 01:25 AM
Chrome no like the gzipped CSS file :( Just comes up without any styles at all (though ?board=1 works now, haha)
Posted: November 6th, 2010, 12:02 AM

Revision: 243
Author: arantor
Date: 00:12:33, 06 November 2010
Message:
! First batch of conversions of splitting some actions into their own files (index.php, Admin.php, MessageIndex.php, Post.php, Register.php, SplitTopics.php, Who.php, Activate.php, CoppaForm.php, Credits.php, QuickMod.php, QuoteFast.php)
----
Added : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/CoppaForm.php
Added : /trunk/Sources/Credits.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Sources/QuickMod.php
Added : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on November 6th, 2010, 07:25 AM
Quote from Arantor on November 6th, 2010, 01:25 AM
Chrome no like the gzipped CSS file :(
It should... I tested it in Chrome (stable), too. Are you sure you enabled the .htaccess file? It has an updated rule.
In any case, I'll add a setting to the db to enable it or not -- and it'll be disabled by default, just like PHP gzipping. I just postponed it because it requires adding an $helptxt or something, and I hate writing docs. (Because I have to do it twice... Once in French, once in English.)
Quote
! First batch of conversions of splitting some actions into their own files (index.php, Admin.php, MessageIndex.php, Post.php, Register.php, SplitTopics.php, Who.php, Activate.php, CoppaForm.php, Credits.php, QuickMod.php, QuoteFast.php)
Oh oh! I'll have a look!
Title: Re: New revs
Post by: Arantor on November 6th, 2010, 08:26 PM
In Chrome beta it just ignored it. I did see the .htaccess file (and it should be being copied with the installation) but I'll double check.

The first batch is simply moving some functions around and making some files - there's little in the way of dependencies there, unlike so many other things :(
Title: Re: New revs
Post by: Nao on November 7th, 2010, 05:42 PM
rev 244

* Changed default DB table prefix to wedge_, to make sure Wedge can be installed next to a vanilla SMF install. (install.php)
! php_value/php_flag aren't supported in CGI PHP. (.htaccess)
* Minor details. (index.css, Admin.french.php)
Title: Re: New revs
Post by: Arantor on November 9th, 2010, 06:10 PM
Revision: 245
Author: arantor
Date: 16:59:29, 09 November 2010
Message:
! More of the function/action rearranging (Admin.php, Post.php, Post2.php, Printpage.php, Register.php, SMStats.php, Spellcheck.php, Stats.php, Subs-Editor.php, Subs-Post.php, Subs-Sound.php, Suggest.php, VerificationCode.php, ViewSMFile.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Register.php
Added : /trunk/Sources/SMStats.php
Added : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Sound.php
Added : /trunk/Sources/Suggest.php
Added : /trunk/Sources/VerificationCode.php
Added : /trunk/Sources/ViewSMFile.php
Modified : /trunk/index.php

(And index.php got modified too, of course. I'm getting closer to where I want to be with this. Not there yet though.)
Title: Re: New revs
Post by: Nao on November 9th, 2010, 06:58 PM
I was wondering... Wasn't the point of these changes, putting the files into a \Sources\Admin folder?
Or do you prefer to have plenty of files in one place, and not have to go through several folders when updating some code?



rev 246

+ Added setting to enable CSS compression. Disabled by default. (ManageServer.php, Subs.php, Help language, ManageSettings language)
* Updated footer copyright to the new URLs, and disabled copyright check because, why bother. (Subs.php, index language)
Title: Re: New revs
Post by: Arantor on November 9th, 2010, 06:59 PM
I'm just splitting them up into the relevant actions first, is a bit easier that way to rearrange later.
Title: Re: New revs
Post by: Nao on November 9th, 2010, 07:39 PM
Gotta go, no time to check my commit thoroughly... Please have a quick look!

rev 247
* Generate non-gzipped cached files for user agents that don't support gzipping. (Subs.php)
- I'm a big fan of Grandia and Terranigma myself, and it hurts to delete that Easter egg, but I'd rather not waste cycles in a regularly called function, thank you. (Spellcheck.php)
Title: Re: New revs
Post by: Arantor on November 9th, 2010, 10:33 PM
Revision: 248
Author: arantor
Date: 21:32:53, 09 November 2010
Message:
- Remove getLastPost() which does not seem to be have been called anywhere in the source (even in RC3 or RC4) (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Title: Re: New revs
Post by: Nao on November 9th, 2010, 11:42 PM
Actually, getLastPost() was already in the code as of SMF 1.0 beta 4 (!), and never used, even at the time.
My *guess*, is that it was written for modder convenience.
But honestly -- that kind of undocumented helper function isn't gonna help anyone. Because anyone with half a brain would write the function themselves instead of spending an hour trying to find an hypothetical function that does what they want.
Title: Re: New revs
Post by: Arantor on November 10th, 2010, 02:11 AM
:o That's what I call a WTF then.
Posted: November 9th, 2010, 11:48 PM

Revision: 249
Author: arantor
Date: 00:20:10, 10 November 2010
Message:
! More of the reshuffle, splitting Recent.php up... including breaking the one function into two files for unread/unreadreplies, I don't think I broke anything with it though it definitely could be harmonised by finding common code and making a Subs-Unread.php file (index.php, Recent.php, Unread.php, Unreadreplies.php)
----
Modified : /trunk/Sources/Recent.php
Added : /trunk/Sources/Unread.php
Added : /trunk/Sources/Unreadreplies.php
Modified : /trunk/index.php

Posted: November 10th, 2010, 01:20 AM

Revision: 250
Author: arantor
Date: 01:04:17, 10 November 2010
Message:
! Harmonsied some function names with filenames/actions: Download became Dlattach, Admin.php's AdminMain became Admin (Dlattach.php, Admin.php, index.php)
! More of the cleanup (Post.php, JSModify.php, index.php)
+ Some actions now identify they should not be logged through defining WEDGE_NO_LOG (index.php, Dlattach.php, SMStats.php, VerificationCode.php, ViewQuery.php, ViewSMFile.php)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/Dlattach.php (Copy from path: /trunk/Sources/Download.php, Revision, 247)
Deleted : /trunk/Sources/Download.php
Added : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on November 10th, 2010, 08:11 AM
Yeah, a WTF indeed...
Thanks for finding that kind of WTF, btw. I'm lagging in terms of codebase knowledge, and because you're moving everything around, it's not going to be better soon eheh.
Title: Re: New revs
Post by: Arantor on November 10th, 2010, 12:32 PM
That's one of the benefits of going through and breaking the files up, you get to find where the function dependencies are.
Title: Re: New revs
Post by: Nao on November 10th, 2010, 03:06 PM
Sure is!
Title: Re: New revs
Post by: Nao on November 10th, 2010, 04:01 PM
Was unrelated until now, but since this will probably all find its way into Wedge... Here's the Aeva Media latest rev changelog, eheh :)

rev 11

+ Added transparency flag to pictures, and functions to determine transparency. (db_aeva.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs.php, Aeva.template.php)
* Changed album page layout to show only thumbnails and titles, and hide the rest, which will instead appear in a popup when you hover over the thumbnail or title. (Aeva-Subs.php, am.css)
* Instead of just kilobytes, show filesize in bytes, kilobytes or megabytes in item pages. (Aeva-Gallery.php, Aeva.template.php)
+ Added a function to hide/show popups in IE6. (Aeva-Subs.php, am.js)
! Fixed error when deleting a comment. (Aeva-Gallery.php)
! Fixed animated GIFs shown at incorrect sizes when using ImageMagick. (Aeva-Media.php)
Title: Re: New revs
Post by: Nao on November 10th, 2010, 08:25 PM
rev 251

! $modSettings['pretty_enable'] didn't actually exist, so it screwed up a lot of Pretty URLs code... (ManageBoards.php, QueryString.php, ManageBoards.template.php)
! Fixed some styling. (ManageServer.php, ManageSettings.php, index.css)
! Foolishly trying to make all browsers like each other when showing popups. Sob. (script.js)
+ Added placeholder about a "Wedge license"... Need to setup an URL and actually put something there. (script.js)
Title: Re: New revs
Post by: Nao on November 12th, 2010, 05:40 PM
rev 252

! In case guests can post to topics, make sure they return to the topic after they posted. (install.sql)
* Renaming hook-related functions and variables. Integration functions become call/add/remove_hook for simplicity reasons. Hooks are renamed from $modSettings['integrate_something'] to $modSettings['hooks']['something'], and are now proper arrays. Finally, SMF_INTEGRATION_SETTINGS is renamed to WEDGE_HOOK_SETTINGS. So what? (index.php, Activate.php, Admin.php, Class-Editor.php, Errors.php, Load.php, LogInOut.php, ManageMembers.php, Profile-Actions.php, Profile-Modify.php, Profile.php, Register.php, Reminder.php, Security.php, Subs-Auth.php, Subs-Members.php, Subs-Post.php, Subs.php, Who.php, Display and MessageIndex templates)
* Made sure that the error message can be tampered with by the output_error hook. Otherwise, it's relatively useless. (Errors.php)
* Given that the outgoing_email hook has permission to tamper with e-mail data, personal_message and create_topic hooks should be able to play around with their data, too. Same with $data in the change_member_data hook in updateMemberData. (Subs.php, Subs-Post.php)
Title: Re: New revs
Post by: Arantor on November 12th, 2010, 05:46 PM
Regarding the last change, I haven't looked yet, but I seem to recall that outgoing_email occurs before the email is sent, but the PM and create topic hooks happen after the PM is sent/topic is created...?

/mewill review in a minute, just trying to dry off after going out in the rain to get fixings for dinner...
Title: Re: New revs
Post by: Nao on November 12th, 2010, 05:55 PM
Hmm yeah I didn't notice that but if you're saying so it's probably right!
I made a mistake anyway when I complained about reset_pass, I think that it's never passed as a ref...
Title: Re: New revs
Post by: Nao on November 13th, 2010, 04:42 PM
rev 253

* Renaming Wedge 1.0 Alpha to SMF 2.0 RC4 (Wedge 0.1), for as long as the BSD licensing is not official. (index.php)
! Clearly separated temporary from permanent hooks. (Load.php, Subs.php)
* The reqWin function will now open an iframe instead of a popup window. It's less aggressive and it's cooler. Also, it now properly positions it. (Help.template.php, script.js)

PS: reqWin was tested under Opera, not other browsers though... It may not work elsewhere. I'm quite happy with the current results, although we may want to go Ajax on this, so that we can add cool animations and show/hide on hover...
Title: Re: New revs
Post by: Nao on November 14th, 2010, 08:54 PM
rev 254

* Renamed "Wedge Default theme" to just "Wedge"... If we call our main theme "Wedge", people will understand that it's the default theme, right? Right? (Install.english.php, Install.french.php)
! Fixed a XML bug reported by live627. Thanks! (Subs.php)
* Reworked the theme/styling selector to better emphasize the overall hierarchy. (ManageBoards.template.php, admin.css)
Title: Re: New revs
Post by: Nao on November 14th, 2010, 10:40 PM
rev 255

* Renamed "package" to "add-on", "package-info" to "addon-info", "paquet" (French) to "extension", "modification" to "code add-on", etc. (tools/package/modifications/*, PackageGet.php, Packages.php, Subs-Package.php, language files in English and French: Admin, Errors, Help, index, Install, ManagePermissions, ManageSettings, Packages, Who)

Just to be clear... I only renamed these where the user has interaction with them. Internally, I didn't rename anything, because there are 2500+ occurrences of "package", and it's not ALWAYS related to actual add-ons...
If you want to do it, Pete, feel free, but our efforts should be focus on more important things.
Still, I'd like to see /Packages/ renamed to /Addons/. Would be nice.
BTW, I used "Extension" for French. It looks cool.
Posted: November 14th, 2010, 09:48 PM

rev 256

* A few more renames I forgot. (Admin.*.php, Help.*.php, ManageSettings.english.php, Packages.*.php, Who.french.php)

(I just hope I didn't rename anything that shouldn't have been.)
Posted: November 14th, 2010, 09:57 PM

rev 257

* Found better entities for representing theme hierarchy. I was dying to commit that. (ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on November 15th, 2010, 11:20 AM
rev 258

* Moved CSS cache folder to the theme folder's root. (Subs.php)
* Replaced Wedge logo with a simpler one. (wedgelogo.png)
+ Added a help description for the styling selector. (ManageBoards language files)
* Spacinazi is adding a useless space, for once. It's just to make large hierarchies readable in Opera... (ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on November 15th, 2010, 03:16 PM
rev 259

+ Added hooks for copyright management ('place_credit'), and Pretty URL manipulation ('determine_location'). (Credits.php, QueryString.php)
- Removed the "orignal" txt strng, as it was emty in the fist plce. (Who.englsh.php, Who.frnch.pp)
Title: Re: New revs
Post by: Nao on November 16th, 2010, 11:30 PM
rev 260

+ Added support for compressed JS files, just like CSS files but with different syntax. (.htaccess, Load.php, ManageServer.php, Help language, ManageSettings language)
* Moved all Display and Editor javascript to the footer, including some inline code that was in the header. (Class-Editor.php, Display.template.php)
+ Added wedge_add_css and wedge_add_js functions to make life easier. (Load.php, Subs.php)
+ Added a short copyright notice in the HTML source code, to have a signature left when people will remove the onscreen credits. (index.template.php)
! Fixed mixup between default theme and current theme when looking for CSS folders. (Subs.php)
! Started adding missing semicolons that would make the JS minifier fail. (editor.js, script.js)
@ JS minifier is a work in progress. Can't account for all lazy Javascript coders putting some strange code in... (Subs.php)
Title: Re: New revs
Post by: live627 on November 16th, 2010, 11:50 PM
I always wondered why some JS lacked a semicolon appended to the line.. It certainly works to go the PHP way and use a semicolon EVERYWHERE (and easier too!)
Title: Re: New revs
Post by: Nao on November 17th, 2010, 11:48 AM
Absolutely.
I'm tempted to add them everywhere (in prototype definitions) and then force users to use them as well, by failing to compile their JS if they don't.
Title: Re: New revs
Post by: Nao on November 17th, 2010, 07:23 PM
Okay, I'm committing, hopefully you can look into my code changes and my remarks in the changelog....

rev 261

! Trying to add support for .jgz and .cgz for Safari, but even if just using uncompressed .css, it doesn't seem to work on Safari 5.0.2... Needs some further research! (.htaccess, Subs.php)
* Moved the rest of the common Javascript to the bottom of the page. IE6 pawa. (index.template.php)
+ Started replacing onclick events with a neat trick I devised, to prevent UI clicks before the scripts are actually loaded. (Okay, I'm proud of myself, so what. Go away. I'm the only reading these changelogs anyway.) (Display.template.php, script.js)
! SMF bug: <span id="top_subject"> was missing, causing quick edit to fail on first topic posts. They don't want me as beta tester so I'll just let them find out by themselves. Ah ah. (Display.template.php)
* The user menu didn't return specific values, so return false anyway, so save a few bytes in the Display template. (topic.js, Display.template.php)
! User menu failed when clicking a guest account. (topic.js)
! Syntax error. (RemoveTopic.php)
! Whatever you put into onclick, it's *already* in Javascript... No need to specify it is! (Post.template.php, Display.template.php)
* Spacinazi on addPollOption. Why is that function duplicated anyway?! Should be changed... (Poll.template.php, Post.template.php)
Title: Re: New revs
Post by: Nao on November 17th, 2010, 09:58 PM
rev 262

! It would be a shame to break w3c validation just for this... Changed the lang trick to use comments instead. So, basically, move your onclick code, unmodified, to a comment immediately after the target element, and add a clickme class to that element. (Display.template.php, index.template.php, script.js)
- Removed a few nbsp's from Javascript confirm boxes. (index.french.php)
+ Finished French translation of the new Security language file. Hopefully... (Security.french.php)

Tested the comments trick successfully on Opera 9.62 (I figured it'd be more representative than v10.6x), Safari 5.0.2 (which BTW now seems to accept my CGZ files... Don't ask me), and IE8. It should be a tad slower than the lang version, but only because it retrieves firstChild and then possibly nextSibling.
Title: Re: New revs
Post by: live627 on November 17th, 2010, 11:28 PM
Quote from Nao/Gilles on November 17th, 2010, 07:23 PM
! SMF bug: <span id="top_subject"> was missing, causing quick edit to fail on first topic posts. They don't want me as beta tester so I'll just let them find out by themselves. Ah ah. (Display.template.php)
grep -nHIi -- top_subject (in directory: /var/www/smf_dev/Themes/default)
Help.template.php:663:               <span id="top_subject">', $txt['manual_topic_heading'], '</span>
Search completed with 1 match.

Need I say more? :P
Title: Re: New revs
Post by: Nao on November 18th, 2010, 12:08 AM
Yes you do...

It stayed in the Help template, yes (the one which we removed from Wedge), but it's only an example page, it's not the proper Display page.
Just compare RC3 to RC4's Display template. The top_subject went away ;)
They can remove it if they want... But then they should remove any code that manipulates it!
Title: Re: New revs
Post by: live627 on November 18th, 2010, 01:06 AM
So in other words they removed code but not completely... heh, so typical of them. <PRV>
Title: Re: New revs
Post by: Nao on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Title: Re: New revs
Post by: Nao on November 18th, 2010, 02:32 PM
Quote from Nao/Gilles on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Any reason why you're blatantly ignoring me...?

I could use some of your hindsight, really.
Title: Re: New revs
Post by: Arantor on November 18th, 2010, 02:59 PM
I'm not ignoring you - I really just haven't had time to keep up with everything :(
Title: Re: New revs
Post by: Nao on November 18th, 2010, 03:26 PM
Sorry, bit tired here. Already 24 hours spent on making sure I can move all JS code to the bottom...
I said that because you've been here a lot today, and you didn't answer my questions... :P
Title: Re: New revs
Post by: Arantor on November 18th, 2010, 03:28 PM
Wouldn't call it 'a lot' - I'm still reading everything, but it's hard to get everything straight. First thing I'll be doing when I get back from town will be reading through the last few commits, and then back through the discussions on the JS stuff.
Title: Re: New revs
Post by: Nao on November 18th, 2010, 04:33 PM
You should do your checks quickly, because I'll probably be moving the theme to HTML5 ASAP, meaning you'll have meaningless code to check in addition to proper code... It's best to first check proper code, and then just skim quickly through the meaningless HTML5 upgrade.

(BTW: XHTML5, right? I'm not interested in changing the /> stuff anyway... I learned to like them.)
Posted: November 18th, 2010, 04:17 PM
Quote from Nao/Gilles on November 18th, 2010, 04:17 PM
skim quickly through
Skim over or scan through... I'm always bad with prepositions.
Title: Re: New revs
Post by: Arantor on November 18th, 2010, 04:36 PM
Makes no odds to me, I still look through commit by commit as I always do.

As for X/HTML, I actually have no preference - whatever works is fine with me. Browsers interpret it fairly well these days.
Title: Re: New revs
Post by: Nao on November 18th, 2010, 05:11 PM
rev 263

* Moved storeCaret() from editor.js to PHP, as it's too short to bother waiting for editor.js to finish loading... (Class-Editor.php, editor.js)
* Replaced existing onclick hacks with a new trick that is cleaner but requires moving templates to HTML5. We would have had to do it at one point anyway... (Class-Editor.php, Display.template.php, script.js, index.template.php, Poll.template.php, Post.template.php)
* Spacinazi. (PrettyUrls-Filters.php)
Title: Re: New revs
Post by: Nao on November 18th, 2010, 05:48 PM
rev 264

* Wedge is now officially using HTML5. (index.template.php)
* Fixed footer indentation. (Class-Editor.php, Display.template.php, index.template.php)
+ Added placeholder function for manipulating external links. @todo: Fix domain name detection, or remove the function. (script.js)
! HTML5 compatibility in Footnotes. (Subs.php)
! Horrible typo. (script.js)
Title: Re: New revs
Post by: live627 on November 18th, 2010, 10:48 PM
Quote from Nao/Gilles on November 18th, 2010, 02:32 PM
Quote from Nao/Gilles on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Any reason why you're blatantly ignoring me...?

I could use some of your hindsight, really.
Know that I'm still offering my help  - that is, if you are wanting someone other than Pete to join the fray :)
Title: Re: New revs
Post by: MultiformeIngegno on November 18th, 2010, 11:05 PM
Quote from Nao/Gilles on November 18th, 2010, 05:48 PM
* Wedge is now officially using HTML5. (index.template.php)
:yahoo: :cool:
Title: Re: New revs
Post by: Arantor on November 19th, 2010, 03:12 AM
OK, back to business. I've taken too long out working on this paid project, I need time to recover!

So... reviewed all the changes (holy crap, there's been a lot of commits in the last 9 days), nothing huge is jumping out at me, I did fix a change in the code docs though, SMF_HOOK_SETTINGS vs WEDGE_HOOK_SETTINGS. Also, now we're listing JS files and there seems to be changes to the list of included stylesheets if I'm not mistaken (bearing in mind loadTemplate can load stylesheets), we probably should fix up the debug info in ViewQuery.php.

I'm looking at building the new DB class first though.



Revision: 265
Author: arantor
Date: 01:20:29, 19 November 2010
Message:
! Minor doc fix (Load.php)
----
Modified : /trunk/Sources/Load.php

Posted: November 19th, 2010, 02:23 AM

Revision: 266
Author: arantor
Date: 02:11:21, 19 November 2010
Message:
! Remove legacy case-sensitivity parameter from DB processes (Subs-Database.php, LogInOut.php, Subs-Auth.php, Subs-Post.php)
----
Modified : /trunk/Sources/LogInOut.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Post.php

Posted: November 19th, 2010, 03:11 AM

Revision: 267
Author: arantor
Date: 02:12:34, 19 November 2010
Message:
! More legacy parameters not used in the DB subsystem. (Subs-Database.php)
----
Modified : /trunk/Sources/Subs-Database.php
Title: Re: New revs
Post by: Nao on November 19th, 2010, 11:21 AM
Aeva Media rev 12 (<-- since it'll soon be merged with Wedge)

! Adding proper UTF8 handling in htmlspecialchars when editing custom fields, showing RSS feeds, errors and item titles. Also when showing SMG code (is that useful, really?) (Aeva-Admin.php, Aeva-Foxy.php, Aeva-Media.php, Aeva-Subs-Vital.php, Aeva-Subs.php)
- Removed Noisen copyright from auto-embedder code. This is ONLY for AeMe2 and Wedge! (Aeva-Embed.php)
+ Added an extra field to Exif data... Not that it's of any interest. Should really update that Exif library at some point. (Aeva-Exif.php)
* More improvements to visual details. (am.css, am.js)
Title: Re: New revs
Post by: Nao on November 19th, 2010, 04:41 PM
rev 268

* Remove registered hooks that no longer exist. (e.g. file was deleted after uninstalling an add-on.) Hopefully this is the right thing to do... (Load.php, Subs.php)
* Continuing HTML5 conversion, introducing cellspacing and cellpadding replacement classes. (Subs.php, ViewQuery.php, Calendar.template.php, index.css, GenericList.template.php, Memberlist.template.php, Register.template.php, Reports.template.php, Stats.template.php)
* Moved more JS inline code to the footer. (Post.template.php, Stats.template.php)
* Indenazi. (Calendar.template.php, Post.template.php, Register.template.php, Stats.template.php)
! For an unknown reason, HTML5 doesn't play well with the quick icon selector's padding on hover. (script.js)
Title: Re: New revs
Post by: Nao on November 20th, 2010, 09:25 AM
rev 269

* Converted two more files. (Calendar.template.php, Post.template.php)
* Started work on PM template -- need to move inline scripts to the footer. (PersonalMessage.template.php)
+ Added workaround for IE6 table borders and HTML5 tags. (ie6.css, index.template.php)
- Started deleting type="text/javascript" references. Thanks HTML5! (Class-Editor.php)
* Replaced context-type meta tag with meta charset. Thanks HTML5! (index.template.php)
! Calendar design was broken. (index.css)
! HTML5 validation no longer allows numeric entities in the C1 range, so turned … into &hellip; (Admin.french.php, ManageMaintenance.french.php, Post.english.php, Post.french.php)
! SMF bug: error message in Post template was shown with two <dt>'s rather than a <dt><dd> pair. (Post.template.php)
! SMF bug: File-type inputs don't accept a size parameter. (Post.template.php)
Title: Re: New revs
Post by: Nao on November 20th, 2010, 09:45 AM
rev 270

! data-on* trick didn't work on anything else than data-onclick. (script.js)

"Oops! Infinite loop."
Was due to a last minute change in variable names and I didn't change it everywhere... As a result, my thread was running at 100% because I had a tab set on a page with this code running. Uh. Opera is very powerful, but it could be a little helpful and offer me to warn me when a script is in an infinite loop... Even IE does... Because it seriously impaired my work yesterday.
Title: Re: New revs
Post by: Nao on November 20th, 2010, 04:41 PM
rev 271

* A few more data-on* conversions and JS fixes. (Groups.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMembergroups.php, ManageMembers.php, ManageSearchEngines.php, ManageServer.php, ManageSmileys.php, Modlog.php, Profile-Modify.php, Subs-Package.php, Subs.php, Calendar.template.php, GenericMenu.template.php, index.template.php, ManageMaintenance.template.php, MessageIndex.template.php)
* The VERY boring, extremely DULL, but totally PRICELESS JavaScriptEscape mega-update. All occurrences of confirm() now sport a proper JSE call that prevents broken scripts. Thank you for that superb bug, SMF, and you can keep the change. (Groups.php, ManageAttachments.php, ManageBans.php, ManageBoards.php, ManageMail.php, ManageMembers.php, ManagePaid.php, ManageSearchEngines.php, ManageSmileys.php, ModerationCenter.php, TEMPLATES: Admin, Calendar, Display, ManageAttachments, ManageBans, ManageBoards, ManageMaintenance, ManageMembergroups, ManageNews, ManageSearch, ManageSmileys, MessageIndex, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Recent, Search, Themes, LANGUAGES: Admin, index, ManageBoards, ManageMail, ManageMaintenance, ManageMembers, ManagePaid, ManageSettings, ManageSmileys, ModerationCenter, Packages, PersonalMessage, Search, Themes)
* Commenazi. (Subscriptions-PayPal.php)
Title: Re: New revs
Post by: Nao on November 20th, 2010, 05:12 PM
rev 272

! Fixed PIE bug that prevented it from being called from the header. (PIE.htc)
- Deleted two unused language strings. Unless I'm wrong?! (ManagePermissions.english.php, ManagePermissions.french.php)
* French version was using a misleading translation for "template" in the Themes file. (Themes.french.php)
* Some extra fixes to the JavaScriptEscape mega-update. (I'm not gonna list all of the files again!)

I think I'm done for JSE... Finished with alert() and confirm(), at least.
There are plenty more occurrences of the "use/don't use entities" comment in language files, that we REALLY need to look into. Either they're already gone (i.e. entry was deleted from Curve, but not from the language files), or they're for e-mails (in which case we can't do much except make an EmailEscape function), or they shouldn't be here.
Title: Re: New revs
Post by: MultiformeIngegno on November 20th, 2010, 05:37 PM
Wow! Awesome work!
Title: Re: New revs
Post by: Nao on November 21st, 2010, 12:42 AM
Thanks :)
I'm not finished, unfortunately... I just took a break after I finished the JSE portions (I'm also trying not to overwhelm Pete with code to verify...)
I still have to finish the data-* implementation, *and* convert all templates... Most notably drop all of the old params (align, valign, cellspacing, cellpadding, type...), and... I don't remember the rest, I'm too tired. Good night!

rev 273

! Implemented a quick hack to fix menus not working in IE6 since rev 260. I have no idea why this fixes it, but it does, so let's shoot first and ask questions later. (index.template.php)
* Indenazi. (BoardIndex.php)
Posted: November 21st, 2010, 12:24 AM

rev 274

- Dropped XHTML5 specification for now, because it needs to be served with an unrealistic MIME type. Just plain HTML5 is fine enough. @todo: determine whether existing application/xhtml+xml support should be removed, and remove support for strict doctypes as well, since HTML5 only has one doctype anyway. (index.template.php)
* Changed XHTML to HTML5 in the footer. (index.template.php, index.english.php, index.french.php)
Title: Re: New revs
Post by: Arantor on November 21st, 2010, 12:55 AM
Re the todo: see other comment, it 'should' be OK - if in doubt, try removing it, then putting it in debug mode (logged in as admin, add debug to the GET URL, e.g. index.php?debug) and see whether the browser gets pissy about having been given invalid HTML or not.
Title: Re: New revs
Post by: Nao on November 21st, 2010, 11:20 AM
I tend to forget that debug mode != stats at the bottom... I never use debug mode, myself.
Well, I tested under Safari and it works just fine. (Safari because I need memory for another app right now and Opera with its 350 tabs is a bit too demanding right now.)
Title: Re: New revs
Post by: Nao on November 21st, 2010, 10:18 PM
rev 275

- Deleted the validation unit test. Seriously, what was that anyway? And we're going HTML5 now... (other/unittest/validation/*)
- Deleted the forced XHTML header from debug pages. (Load.php, Subs.php)
- Deleted the strict doctype fix, as, known song, we're going HTML5. (Subs.php, index.template.php)
! A class could be empty at some point... Bad logic, change logic. (Memberlist.template.php)
* Turned stand-alone nowrap styles into a nowrap class. (Admin.template.php, index.css, Errors.template.php, Install.english.php, Install.french.php, ManageBoards.template.php, Memberlist.template.php)
* Turned small stand-alone pages to HTML5 as well, even if it's not needed. Consistency. (install.php, Class-Editor.php, Errors.php, Load.php, ViewQuery.php, Errors.template.php, Help.template.php, ModerationCenter.template.php, Packages.template.php, Post.template.php, Printpage.template.php, Register.template.php)
Posted: November 21st, 2010, 09:46 PM

rev 276

* Turned a few addcslashes into more semantic JavaScriptEscape calls. (Class-Editor.php)
* Commenazi. (index.template.php)

(Small, but I don't know if I'll be able to commit later tonight.)
Title: Re: New revs
Post by: Nao on November 21st, 2010, 11:22 PM
rev 277

! There's probably never going to be something as stupidly exciting as rewriting a feature that took you dozens of lines in dozens of files, in ONE single line. Fixed XMLHttpRequest calls for different domains and subdomains. (script.js)
! Fixed a potential JS error. (topic.js)
! Syntax error. (ViewQuery.php)
* Converted MessageIndex template to HTML5, moved more inline code to footer, etc. (MessageIndex.template.php)

Seriously -- that domain name fix...? Why didn't I think of that in the first place, uh? I don't EVEN need to specify a proper variable with a subdomain like on wedgeforum.com (smf_suburl).
Posted: November 21st, 2010, 11:16 PM

Not too impressive, but thanks to that silly trick, my noisen patch is down from 480 to 467KB...
Title: Re: New revs
Post by: Nao on November 22nd, 2010, 10:38 AM
rev 278

* Hopefully converted all of Packages and Profile to HTML5. (Packages.template.php, Profile.template.php)
* More JSE fixes. (Register.template.php, Profile.template.php, Login.english.php, Login.french.php)
- Removed DOMContentLoaded calls, as they're unneeded when JS is only loaded at the end of the page. (profile.js, script.js)
! Fixed Moderator list being empty in linktree when board has no owner. (Load.php)

I'm dying of boredom... HTML5 conversion has got to be the most annoying thing I've done in months. It makes IE6 compatibility look like heaven. So many deprecated elements... And not always for the better! Why isn't there a "transitional" setting for HTML5, that would do without the deprecated align/valign/width stuff...? It really, REALLY eats a lot of space to turn these all into inline CSS.
Title: Re: New revs
Post by: Nao on November 22nd, 2010, 12:34 PM
rev 279

* Mega-update with the end of cellspacing's, cellpadding's, align's, valign's, width's and other things that are deprecated in HTML5. Most boring task of the month. (Class-Editor.php, Modlog.php, Subs.php, index.css, editor.js, ManageSettings.french.php, ManageSettings.english.php, TEMPLATES: pretty much *all* of them so please don't force me to look into it)
* More JSE fixes. (index.english.php, index.french.php, ManageBans/Boards/Maintenance/Membergroups/News/Paid.template.php, PersonalMessage.template.php, Profile.template.php)

(I had to do all of these manually. One by one. AM I THROUGH NOW? :sob:)
Title: Re: New revs
Post by: Nao on November 22nd, 2010, 05:06 PM
rev 280

- Deleted all type="text/javascript" from script tags, as it's no longer required in HTML5. (All files)
* Tablenazi. (Packages.template.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2010, 12:13 AM
rev 281

* Added two defines, SCRIPT_HEADER and SCRIPT_FOOTER, to make it easier to declare Javascript snippets with proper CDATA protection. You may still use <script> alone, it's up to you. Converting a few files to use these. (index.php, BoardIndex.php, Class-Editor.php, Subs.php, GenericMenu.template.php, index.template.php, Packages.template.php)
* More JSE fixes and footer movement. (Packages.template.php)
* When showing the footer Javascript, make sure to delete any redundant script tags. This may not be worth the trouble, but you know me and my regular expressions... (index.template.php)
* addLoadEvent() is not for dogs. (French saying.) (Subs.php)

Would like some opinions on SCRIPT_HEADER and SCRIPT_FOOTER...
Basically, this turns something like this:

Code: [Select]
$context['footer'] .= '
<script><!-- // --><![CDATA[
initMenu(document.getElementById("amen' . ($mid > 1 ? '_' . ($mid-1) : '') . '"));
// ]]></script>';

Into this:

Code: [Select]
$context['footer'] .= SCRIPT_HEADER . '
initMenu(document.getElementById("amen' . ($mid > 1 ? '_' . ($mid-1) : '') . '"));' . SCRIPT_FOOTER;

Is it worth it? Would you, as programmers, be more like to use these instead of typing the CDATA from memory or copying it from other code stuff?
Would it be more natural/less confusing to just do something like this?

Code: [Select]
$context['footer'] .= '
<script>' . CDATA_HEADER . '
initMenu(document.getElementById("amen' . ($mid > 1 ? '_' . ($mid-1) : '') . '"));
' . CDATA_FOOTER . '</script>';

I like CDATA_HEADER better, but I figured most people would rather have SCRIPT_HEADER from the beginning...
Posted: November 22nd, 2010, 11:47 PM

Silly me... Alternatively, I could do it this way: users write scripts with <script> (no CDATA), and at runtime I'll simply add the CDATA before printing the tag. I'd just need to make sure not to add CDATA header/footer to <script url="something"></script>
(Obviously, it would take a bit more server CPU time to process. Not much though...)
Title: Re: New revs
Post by: live627 on November 23rd, 2010, 12:43 AM
rev 282

* More converting deprecated attributes to CSS equivalents (Themes.template.php, Search.template.php, Profile.template.php, Packages.template.php, MessageIndex.template.php, Login.template.php, Display.template.php, Admin.template.php)
Posted: November 23rd, 2010, 12:33 AM

The CDATA... bit hard to say. CDATA_HEADER seems more logical because it gives the impressiion that a CDATA tag is being used. SCRIPT_HEADER...... sounds like it contains <script>. To me, anywzay.

Is it worth it? No idea..
Title: Re: New revs
Post by: Arantor on November 23rd, 2010, 12:45 AM
/mewould prefer to use CDATA_ rather than SCRIPT_
Title: Re: New revs
Post by: live627 on November 23rd, 2010, 06:55 AM
Oh wait... the actual tag is included. Perhaps SCRIPT_HEADER fits after all.
Posted: November 23rd, 2010, 02:36 AM

rev 284 (:edit: :P)

! Parse error (LogInOut.php)
* Converted another file to HTML5. Moving Javascript to the footer, using data-onclick (Register.template.php)
! Audio verification close button should close an iframe and not a window (Register.template.php)
* Changed an inline style to its equivalent class (Register.template.php)
! SMF bug: Refreshing the CAPTCHA would bring you to the top of the page (GenericControls.template.php)



Note to whoever finishes converting that file (probably me): Only the guest registration area was tackled; the other tmpl functions still need looked at.
Title: Re: New revs
Post by: Nao on November 23rd, 2010, 11:48 AM
rev 285

! Fixed captcha sound popup and simplified Javascript. (GenericControls.template.php, Register.template.php, captcha.js)
! Reverted Profile template to revision 281. (Profile.template.php)
! Reverted all <img style="width/height"> changes, as HTML5 perfectly supports <img width/height>. (Display.template.php, Login.template.php, MessageIndex.template.php, Packages.template.php, Search.template.php)
* Fixed cat_bar margins and indentation in the admin settings. (Admin.template.php, admin.css)
* Added a seamless parameter to the preview iframe, as recommended in HTML5. (Themes.template.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2010, 03:42 PM
rev 286

* Split $context['footer'] into $context['footer'] (regular HTML) and $context['footer_js'] (postponed Javascript). (Load.php, index.template.php, etc.)
- Removed SCRIPT_HEADER/SCRIPT_FOOTER because of the better implementation. (index.php, etc.)
+ Added new Javascript encapsulator. add_js() (temp name) will add your postponed Javascript to $context['footer_js'] and deal with the layout for you. You can still manually add to $context['footer_js'], for instead if you need to manipulate the JS buffer or add characters without newlines. The main benefit is that you can call add_js('hello', $world) and it will behave the same as add_js('hello' . $world'), which makes it easy to convert older templates. (BoardIndex.php, Class-Editor.php, Load.php, ManageBoards.php, ManageMail.php, ManageNews.php, ManagePaid.php, ManageRegistration.php, ManageSearchEngines.php, ManageSettings.php, QueryString.php, Subs.php, TEMPLATES: Admin, Calendar, Display, GenericMenu, MessageIndex, Packages, Post, Register, Stats)
+ Also added add_js_file() function, to specify a JS file to load later, or a list of files. Warning: doing add_js_file($scripturl, '?something') will consider $scripturl as a standalone script. I could improve the behavior but I don't know if it's worth it. (Class-Editor.php, QueryString.php, TEMPLATES: Admin, Display, MessageIndex, Register, Stats)

Now, finishing inline JS should be a piece of cake... :)
Will still need to finish the data-* fixes (has to be done manually because of the hitme complexity + some onclick calls don't require postponing). And I'll be done...
Title: Re: New revs
Post by: live627 on November 24th, 2010, 01:41 AM
rev 287

! JSE fix on alert (Register.template.php)
* Moving Javascript to the footer using add_js() (Profile.template.php, Register.template.php)
Title: Re: New revs
Post by: live627 on November 24th, 2010, 06:55 AM
rev 288

* Moved more Javascript to the bottom (TEMPLATES: Admin, Announce, BoardIndex, Errors, GenericList, index, Login, ManageAttachments, ManageBans, ManageBoards, ManageCalendar, ManageMaintenance, ManageMembergroups, ManageMembers, ManageNews)
! More JSE fixes (ManageMembers.template.php, ManageNews.template.php)



I went ahead and sent IE's HTML5 JS hack in index.template to the bottom - is this the right thing to do? I don't have IE (in Linuxland) so can't test that.

Login.template has Javascripts to set focus to the username inputs. Why not take advantage of HTML5's autofocus feature?

:edit: Perhaps the username field on the registration page can have the autofocus attribute as well.
Title: Re: New revs
Post by: Nao on November 24th, 2010, 02:18 PM
rev 289

- Reverted rev 287-288

rev 290

+ Added placeholder for a dynamic file cache suffix (*.js?suffix), in case we want to use it.
- Commented out the statistics sharing code. We're not SMF. (install.php, upgrade.php)
* More add_js/add_js_file. (Admin.template.php, Subs-Editor.php
- Deleted all copyright removal test code. We'll see to that later but we're certainly not selling the right to delete a copyright. You just need to ask nicely. (Credits.php, Subs.php, Admin.template.php, Who.template.php, Admin language, Errors language)
* Renamed some of the SMF stuff to Wedge and fixed scheduled task SM files to point to our website. (install.php, install.sql, upgrade.php, Install language, ScheduledTasks.php, Subs-Database.php, other/xml/*.js renamed to *.php)
Title: Re: New revs
Post by: Nao on November 24th, 2010, 03:40 PM
rev 291

* More SMF to Wedge changes. (Settings.php, Settings_bak.php, repair_settings.php, smfinfo.php,
+ Added an add_js_inline() to add JS code before the big scripts at the end. Right now it is an alias to add_js(). If used in enough cases, it will be made into a proper function. (QueryString.php, PersonalMessage.template.php)
* Optimized add_js() to justify using it even in loops. Modders are big boys, they don't need newlines to be added automatically for them. (QueryString.php)
* Continuing the add_js quest. (ManageMail.php, PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on November 24th, 2010, 11:55 PM
I can't believe I spent my entire day on this... So many bugs to fix!!

rev 292

@ 30 files done. Got 21 more templates to document before I can commit them... I'll do that tomorrow alright? Man's gotta sleep sometimes.
* More SMF to Wedge renaming. (current-version.php, detailed-version.php)
* More add_js conversion. (TEMPLATES: Admin, Announce, BoardIndex, GenericList)
! Fixed missing parenthesis. (ManageMail.php)
- $profile_fields['js_submit'] and ['js'] are never set in the first place. (Profile-Modify.php)
* Indenazi. (index.php, ManageMembers.php, ManageServer.php, ManageSmileys.php, Admin.template.php, Nix/index.css, ManageSettings.english.php, ManageSettings.french.php)
* Made submit buttons slightly rounded if CSS3 is available. Eh, why not. I'm bored. (index.css)
* Added some margin below fatal errors. Looks better for the Return link. (index.css)
* Changed stats page column internal widths to allow for more space on the left side. (index.css)
! Generic lists could sometimes set width to "100%px"... Yeah. (GenericList.template.php)
! addcslashes/JSE fixes. (Search.php, Search.template.php, ManageMembers.english.php, ManageMembers.french.php)
! Precedence logic issue in cascaded tables. (index.css)
! Cellspacing values weren't working, at least in Opera. (index.css)
! CSS wasn't applied correctly to reports. (report.css)
! SMF glitch: broken class. (ManageScheduledTasks.php)
! Validation error in custom profile fields page. (ManageSettings.php)
! French translation fixes. (index.french.php, Help.french.php, Reports.french.php)
! Alignment issues when opening a month via Ajax in stats page. (stats.js)
! Editor BBC button list was vertical (uh!) in IE6 and IE7 (ahah!) (ie6.css, ie7.css)
! Pete bug (evil grin): auto-suggester was broken. Restored a few lines but they probably would best be removed. (Suggest.php)
! Nao bug (annoyed grunt): removed an extra </div> from the admin settings template. (Admin.template.php)
! Admin area would print label tags linked to non-forms, causing HTML5 validation to break. Yeah I know, they're a PITA... (Admin.template.php)
Title: Re: New revs
Post by: Nao on November 25th, 2010, 05:26 PM
rev 293

! Two errors with SMF variables. (install.php, Install languages)
* Continuing the inline JS exodus. (TEMPLATES: Login, ManageAttachments/Bans/Boards/Calendar/Maintenance/ Membergroups/Members/News/Paid/Permissions, ModerationCenter, Packages, Post, Profile, Search, SplitTopics, Stats)
! SMF bug: Javascript error when editing the Local Moderator membergroup. (ManageMembergroups.template.php)
- Removed unused variables $context['profile_javascript'] and $context['profile_onsubmit_javascript']. BTW, the latter's implementation was buggy. (Profile.template.php)
+ Added description for membergroup color setting. (ManageMembergroups.template.php, ManageMembergroups language)
+ Added a label for duration radio boxes. UI FTW. (ManagePaid.template.php)
! isset($something) ? $something : $something has to be the funniest waste of space I've seen today. Four times. In the same file. (ManagePaid.template.php)
! Fixed validation broken due to [] in URLs. Too bored to look for other URLs manually... (PersonalMessage.template.php)
! SMF glitch: validation was broken in profiles due to a self-closed span. Whatever. (Profile.template.php)
* Started replacing <br /><span class="smalltext"> with <div class="smalltext">. Allows for setting some padding in the settings area to avoid getting long descriptions to touch the right side of the area. (TEMPLATES: ManageBans, ManagePaid, ManagePermissions, PersonalMessage, Profile)
! Fixed leap year handling. The problem won't occur before 2100, but we might as well be ready for the far future. That's what Wedge is. (Calendar.template.php, ManageCalendar.template.php)
! JSE fixes in various places, most notably all doAutoSubmit() functions. Maybe we should be putting this into a JS file...? (TEMPLATES: Admin, Announce, ManageAttachments, ManageMaintenance, ManageMembers, ManageNews, ManageSearch, Packages, Register, Search)
* Seriously, plenty more fixes that I couldn't both to log. Do you realize I spent an entire day just writing this changelog and checking it again and again? Is there someone reading me anyway? Hello? Mom is that you?
* Indenazi. (Reports.php)

I'm only halfway through it! I have just as many files left to commit. And I'm not even started on onclicks, lol...
Title: Re: New revs
Post by: Nao on November 25th, 2010, 05:59 PM
rev 294

+ Adding proper support for add_js_inline(). (Load.php, QueryString.php, index.template.php)
* Don't show debug info in help popups. Seriously, this was too silly. (Subs.php)
- Removing submit button's rounded corners until I figure out a way to properly disable the outline that shows up in Opera when clicking it. (index.css)
* Simplified init process for both objects in admin.js file. (admin.js)
* Give some padding to descriptions inside the settings area. At least some breathing space... (index.css)
+ Forgot to translate an entry to French. (Admin.french.php)
* Finished committing a few multi-file fixes that were mentioned in the previous commit: <span>'s to <div>'s, leap year fix and renamed functions. (ManageAttachments.php, ManageScheduledTasks.php, ManageServer.php, ManageSmileys.php, Profile-Modify.php, TEMPLATES: Calendar, Help, ManageCalendar, ManageSmileys, Post, Themes)

Phew... Here are are.
Many files, but less changes per file, thankfully, so it was way quicker to build this changelog.
One more commit coming up, with the last smalltext span fixes...
Title: Re: New revs
Post by: Nao on November 25th, 2010, 06:09 PM
rev 295

- Couple of useless classes. (index.css)
* Finished replacing <span>'s with <div>'s. Phew. One good thing done... (All other files in that rev. Honest.)

TAKING A BREAK! :P
Title: Re: New revs
Post by: Nao on November 25th, 2010, 09:48 PM
rev 296

* The manage smileys page had a very ugly link at the bottom. (ManageSmileys.php)
* More inline JS movement. (Admin.template.php, ManageSmileys.template.php, Packages.template.php, Reminder.template.php, Themes.template.php)
* Scheduled Tasks translation to French was inconsistent. (Admin, Help and ManageSettings language files)
* Fixed latest-*.php files to prevent them from sending errors to Wedge. Whatever... (xml/latest-*.php)
Title: Re: New revs
Post by: Nao on November 25th, 2010, 11:02 PM
rev 297

- Removed support for theme variants... We have stylings now, and they're easier to grasp for themers, hopefully. Better documented, too. Maybe it'll get me to finally enable choosing a styling for the forum theme (outside of boards)... And maybe customization for users, but honestly I'm not fond of that idea. (Load.php, Themes.php, BoardIndex.template.php, Themes language, MessageIndex.template.php, Themes.template.php)
* Continuing, and pretty much finishing, the inline JS migration. Every single script tag left means the data can safely be stored inside the JS and doesn't rely on externals. (ManageMembergroups.template.php, ManagePaid.template.php, Packages.template.php, Poll.template.php, Profile.template.php)
* Forgot to fix the leap year on one of the files. (ManagePaid.template.php)
Title: Re: New revs
Post by: Nao on November 26th, 2010, 08:17 PM
rev 298

+ Added ability to specify a default styling for the forum. (install.sql, Load.php, ManageBoards.php, Themes.php, ManageBoards.template.php, Themes.template.php)
* A few minor tweaks to Themes language files, hopefully for the better. (Themes.english.php, Themes.french.php)
@ To do: allow members to set their own styling preferences, too.
Title: Re: New revs
Post by: Nao on November 26th, 2010, 11:10 PM
rev 299

* At last, STYLINGS ARE F'ING DONE! Implemented user's ability to select different stylings by default. (install.sql, Load.php, Themes.php, Themes.template.php, Themes.english.php, Themes.french.php)
* Some tweaks in stylings and their settings file. (Nix/index.css, Nix/settings.xml, Green/settings.xml)
Title: Re: New revs
Post by: Nao on November 26th, 2010, 11:20 PM
rev 300

* Theme preview/use page was beginning to be a bit crowded. (Themes.template.php)
+ Added a quick "proof of concept" styling. Dunno if it's worth including it in the final file. (css/Green/Green again/*)
@ Okay, so what? I just wanted to have rev 300 done before going to bed... Sue me.
Title: Re: New revs
Post by: Arantor on November 27th, 2010, 02:57 AM
Holy cow, lots of things to review, will try and look at them tomorrow.
Title: Re: New revs
Post by: Nao on November 27th, 2010, 04:34 PM
rev 301

* Show link underlines in posts. I've always found it silly that SMF insisted on pretty much hiding links from posts. If anything, it encourages spamming. (index.css)
* Moved smf_mousePose over to editor.js (the only file that uses it), and renamed it to getMousePosition (more logical). (editor.js, script.js)
* Moved the IconList object from script.js to topic.js, as it's only used on topic pages. (script.js, topic.js)
- Removed setInnerHTML/getInnerHTML functions, as they're no longer required. At all. Yes. Also removed smfFooterHighlight because it's an old compat function. We don't care about that. (script.js)
Title: Re: New revs
Post by: Nao on November 27th, 2010, 05:13 PM
rev 302

- Purged everything evil out of theme_copyright. (Subs.php)
* Slight DOM traversing optimizations (on Pete's suggestion.) (ManageAttachments.template.php, ManageBans.template.php)
Title: Re: New revs
Post by: Arantor on November 27th, 2010, 06:06 PM
Revision: 303
Author: arantor
Date: 17:05:02, 27 November 2010
Message:
! func_get_args() can't be used as a parameter for a function prior to PHP 5.3.0 (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php



It's a really quirky one, this, but func_get_args() relies on scope, and the scope model changed fairly heavily in 5.3.0 - to a more powerful one. It's to do with the point at which scope is resolved for the function whose arguments you're getting. Downside is that for < 5.3, you have to push it into a variable first.
Title: Re: New revs
Post by: Arantor on November 27th, 2010, 11:57 PM
Quote
Well, putting the args into a variable before imploding them takes more time and memory...
There's actually not a lot in it, I think, if you dig down to the underlying C code, since a string and an array are internally managed through pointers rather than the physical value being pushed; it's sort of by-reference-but-pretending-otherwise as opposed to really-by-reference. (This is most noticeable when calling C stuff from something like Visual Basic where you have to be explicit and strings, arrays etc are always ByRef even if the intent is not.)
Quote
We still have plenty of issues to fix...
The current code seems to work, work quite well and achieves what the original intent was - putting everything that much closer to the end to get faster rendering and add <insert JS library here> if we wanted. So there are bigger fish to fry, so to speak.


Right now I'm trying to visualise exactly how drafts would play out - see my notes in http://tracker.wedge.org/?sa=ticket;ticket=51 for more of the issues that need to be tackled.
Posted: November 27th, 2010, 08:23 PM

Revision: 304
Author: arantor
Date: 19:32:42, 27 November 2010
Message:
- Remove installed add-ons list seeing how we already have the same list in the Browse Add-ons page (Admin.php, Packages.php, PackageGet.php, Packages.template.php, Admin.english.php, Admin.french.php, Packages.english.php, Packages.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php

Posted: November 27th, 2010, 08:33 PM

Revision: 305
Author: arantor
Date: 22:56:55, 27 November 2010
Message:
! More movement of actions to their own files (Search.php, Search2.php, Themes.php, Jsoption.php, index.php)
! Fix for broken info centre toggle (BoardIndex.php)
----
Modified : /trunk/Sources/BoardIndex.php
Added : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Search.php
Added : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: MultiformeIngegno on November 28th, 2010, 02:07 AM
It's great to see arantor working again! :)
Title: Re: New revs
Post by: Arantor on November 28th, 2010, 07:19 PM
Revision: 306
Author: arantor
Date: 18:19:11, 28 November 2010
Message:
! Converted redirects to blank.gif into outputting raw image from shared function to avoid redirections. (index.php, Subs.php, Jsoption.php, VerificationCode.php)
! Some uses of raw image output had to be inlined because Subs.php isn't loaded at that point (install.php, repair_settings.php, upgrade.php)
! Removed legacy files listed in installer (install.php)
----
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on November 29th, 2010, 09:43 AM
rev 307

* Updated license.txt to Wedge's. Not many differences though. Also moved it to the root instead of a license in Themes and one in other/*. (license.txt)
* Optimized a DOM traversing function, and moved it to the inline section. (Admin.template.php)
* Gave more padding to autosuggest popups. (index.css)
Title: Re: New revs
Post by: Nao on November 29th, 2010, 10:05 AM
rev 308

* Simplifying calls to the auto-suggest widget: setting sSearchType to 'member' by default until we write more suggestion types, making sSuggestId the same as sControlId (a prefix is added to it anyway so collision chances are close to zero), and bItemList already accounted for the lack of parameter. (suggest.js, PersonalMessage.js, TEMPLATES: ManageBans, ManageBoards, ManageMaintenance, ManageMembergroups, ManageNews, ManagePaid, Profile)
! Fixed syntax error in Member Tasks. (ManageMaintenance.template.php)
Title: Re: New revs
Post by: Nao on November 29th, 2010, 11:48 PM
rev 309 (I hate revs ending in "9", I usually reserve them for my crappy commits :P Well, it will be a first...)

+ Added jQuery into Wedge. YES! (jquery-1.4.4.min.js)
+ Added new setting, $modSettings['jquery_remote'], defaulting to false, determining whether jQuery should be loaded from the Google CDN or merged into script.js, cached and gzipped locally. No UI for it yet. (Load.php, index.template.php)
* Replaced own JS minification routines with a more efficient version based on Dean Edwards' Packer 2.0. (Class-Minify.php, Subs.php)
* Optimized minification by listing all variable names that can safely be renamed. (Subs.php, script.js, theme.js)
* Added a quick fix for Javascript errors when a minified file has something = function () {} without a closing semicolon. Strings containing solo "}" or "{" are not supported. I can't fix your weird code all by myself. (Subs.php)
! Fixed some Nix styling colors. (Nix/index.css)
- submitonce() doesn't actually take any parameter. (script.js, editor.js, TEMPLATES: MoveTopic, Packages, PersonalMessage, Poll, Post)

So, I guess this build will crash on everyone's machine, ah ah. It may work, too. I hope I didn't forget to commit any file (I had to add Class-Minify.php and jquery.js manually.)
If it crashes, please wait until tomorrow morning and I'll have a look. Right now I have to hurry to bed.

TOMORROW-- let's have some fun with jQuery!! ;)
Title: Re: New revs
Post by: Arantor on November 30th, 2010, 12:05 PM
I knew it was hard to debug since it was an error on line 1... but it's all line 1 >_< I can enable that to test it, sure. If the option is disabled, it probably shouldn't go through Packer. Thing is, though, which performs better overall - Minification & Packer strikes me as though it should underperform compared to Minification & Gzip.

Meanwhile...


Revision: 310
Author: arantor
Date: 08:46:41, 30 November 2010
Message:
! Renamed the .xml action as feed which just seems more logical, as well as moved it around (index.php, Feed.php, Load.php, News.php, BoardIndexInfoCenter.template.php, index.php, Help.english.php, Help.french.php)
! Cleaned up xmlhttp action as part of ongoing harmonisation (index.php, Xml.php, Xmlhttp.php)
----
Added : /trunk/Sources/Feed.php (Copy from path: /trunk/Sources/News.php, Revision, 309)
Modified : /trunk/Sources/Load.php
Deleted : /trunk/Sources/News.php
Deleted : /trunk/Sources/Xml.php
Added : /trunk/Sources/Xmlhttp.php (Copy from path: /trunk/Sources/Xml.php, Revision, 309)
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 09:49 AM

OK so I enabled it, and Chrome did not like the compressed file one bit. Yay for unstyled page!
Posted: November 30th, 2010, 09:51 AM

Revision: 311
Author: arantor
Date: 09:01:37, 30 November 2010
Message:
! Removed legacy requestmembers action and function (index.php, Subs-Auth.php)
----
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/index.php


This was the old auto-suggest handler from 1.1.x, only no-one removed it, haha. Needless to say it'll still be in 2.0 final >_<
Posted: November 30th, 2010, 10:02 AM

Revision: 312
Author: arantor
Date: 09:08:09, 30 November 2010
Message:
! Harmonised action=jseditor, including removing the method from the editor class (strictly speaking it feels a little less like it should be in the class anyway) (index.php, Class-Editor.php, Jseditor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Added : /trunk/Sources/Jseditor.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 10:08 AM

Revision: 313
Author: arantor
Date: 09:46:55, 30 November 2010
Message:
! Tidy up the WAP2 PM find-member action into its own file (index.php, Findmember.php, Subs-Auth.php)
! Remove the non WAP template for findmember since it doesn't appear to be in use anywhere (Findmember.php, Help.template.php)
----
Added : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 10:57 AM

Revision: 314
Author: arantor
Date: 10:12:23, 30 November 2010
Message:
! Silently rewrite action=.xml into action=feed (index.php)
! Move the buddy, lock and sticky actions into their own files (index.php, Buddy.php, Subs-Members.php, LockTopic.php, Lock.php, Sticky.php)
----
Added : /trunk/Sources/Buddy.php
Added : /trunk/Sources/Lock.php (Copy from path: /trunk/Sources/LockTopic.php, Revision, 309)
Deleted : /trunk/Sources/LockTopic.php
Added : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 11:12 AM

Revision: 315
Author: arantor
Date: 11:05:06, 30 November 2010
Message:
! Split LogInOut into separate actions and support, and fix all the links to it (index.php, LogInOut.php, Subs-Login.php, Login.php, Login2.php, Logout.php, Load.php, Profile-Actions.php, Reminder.php, Security.php, Subs-OpenID.php)
----
Modified : /trunk/Sources/Load.php
Deleted : /trunk/Sources/LogInOut.php
Added : /trunk/Sources/Login.php
Added : /trunk/Sources/Login2.php
Added : /trunk/Sources/Logout.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Security.php
Added : /trunk/Sources/Subs-Login.php (Copy from path: /trunk/Sources/LogInOut.php, Revision, 309)
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on November 30th, 2010, 06:28 PM
rev 316

* Spacinazi. (Findmember.php, ModerationCenter.template.php)
! Missing div and incorrect bar. (ModerationCenter.template.php)
- Removed some test code. (theme.js)
* The index template has two RSS links, but they were formed differently. Spider engines will appreciate that we use the exact same link. (index.template.php)
Posted: November 30th, 2010, 02:15 PM

rev 317

* Updated logo and favicon to the newest ones. (wedgelogo.png, favicon.ico)
* Spacinazi. (Class-Minify.php)
* Pete, I'll hate you forever for ignoring my moving plea. <scream> Removed my own custom minifying code. (Subs.php)
+ Added support for JSMin minifier. Delete the DEFINE('JSMIN', 1) line to test support for Packer. (Subs.php, Class-JSMin.php)
* JSMin keeps multi-line comments in cached files, so used the opportunity to add license information to a couple of them. (editor.js (yes, it isn't packed yet, but it will come), script.js, theme.js)
Posted: November 30th, 2010, 06:26 PM

Forgot that one...

rev 318

+ Added a compatibility sheet for IE6 in Nix styling. (Nix/ie6.css)
Title: Re: New revs
Post by: Nao on November 30th, 2010, 06:42 PM
rev 319

! JSMin doesn't need the semicolon fix. (Subs.php)

(Sorry! Forgot to move the block...)
Title: Re: New revs
Post by: Arantor on December 1st, 2010, 04:19 AM
Revision: 320
Author: arantor
Date: 19:50:43, 30 November 2010
Message:
! Convert action=collapse into its own file (index.php, BoardIndex.php, Collapse.php)
! Remove legacy modifycat action (index.php, ManageBoards.php)
----
Modified : /trunk/Sources/BoardIndex.php
Added : /trunk/Sources/Collapse.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 08:51 PM

Revision: 321
Author: arantor
Date: 20:44:34, 30 November 2010
Message:
! Convert polls to be a action=poll with subactions (index.php, Poll.php, Who.english.php, Who.french.php, Poll.template.php, Display.template.php)
+ Add the ability for topic-permission (whotopic) strings that support specific action/subaction strings (Who.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/index.php

Posted: November 30th, 2010, 09:44 PM

Revision: 322
Author: arantor
Date: 03:19:01, 01 December 2010
Message:
! loadSource introduced. (Load.php)
! A decent number of files converted to use loadSource where possible without lots of work, and globalisation of $sourcedir removed in the process. Not all files are finished yet. (Lots and lots of files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Collapse.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/index.php
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Arantor on December 1st, 2010, 11:22 AM
Revision: 323
Author: arantor
Date: 10:22:11, 01 December 2010
Message:
! Fixing most of the rest of the uses of $sourcedir / loadSource in main source (lots of files)
! Reverting use of loadSource where function not available at that point (Subs-Database.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Unreadreplies.php
Title: Re: New revs
Post by: Nao on December 1st, 2010, 12:31 PM
rev 324

! Wrong loadSource destination. (ManagePaid.php)
Title: Re: New revs
Post by: Nao on December 1st, 2010, 08:37 PM
rev 325

- Removed preg_match hack from loadUserSettings, as the security issue is fixed in PHP 5.0.2, and we won't accept anything below 5.0.2 anyway. (Load.php)
* Updated createList() to use loadSource(). (ManageCalendar.php, ManageMembergroups.php, ManageMembers.php, Subs-List.php)
- Removed hitme classes, as they won't be used in the end. (ManageMembers.php, ManageSmileys.php, TEMPLATES: Calendar, MessageIndex, Post)
! Another file with a .php extension where it shouldn't have had it. (Profile.php)
@ todo: implement hitme replacement, and update the minimum PHP version.
Title: Re: New revs
Post by: Nao on December 1st, 2010, 11:05 PM
rev 326

* Upping minimum version of PHP from 5.0.0 to 5.1.2. (install.php, readme_*.html, webinstall.php, upgrade.php)
* Upping minimum version of MySQL from inconsistent stuff to 4.1.2. (install.sql, readme_*.html, upgrade.php, ManageMaintenance.php, SearchAPI-Fulltext.php, ManageMaintenance language)
Title: Re: New revs
Post by: Arantor on December 2nd, 2010, 01:33 AM
Revision: 327
Author: arantor
Date: 22:35:19, 01 December 2010
Message:
! Minor formatting fix to fatal error page (Errors.template.php)
! Replaced $smcFunc['db_*'] functions with the weDB family of classes. (LOTS of files. Far too many for a sane person, or even not so sane person, to list here manually.)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Announce.php
Added : /trunk/Sources/Class-DB.php
Added : /trunk/Sources/Class-DBExtra.php
Added : /trunk/Sources/Class-DBPackages.php
Added : /trunk/Sources/Class-DBSearch.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/CoppaForm.php
Deleted : /trunk/Sources/DbExtra.php
Deleted : /trunk/Sources/DbPackages.php
Deleted : /trunk/Sources/DbSearch.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Deleted : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/other/install.php
Modified : /trunk/subscriptions.php

Posted: December 1st, 2010, 11:36 PM

Revision: 328
Author: arantor
Date: 00:11:26, 02 December 2010
Message:
! Stupid bugfix for installer looking for the wrong file (install.php)
! Remove boardmod support (Packages.php, Subs-Package.php, Packages.template.php)
----
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/other/install.php

Posted: December 2nd, 2010, 01:11 AM

Revision: 329
Author: arantor
Date: 00:32:51, 02 December 2010
Message:
! Reformatted the browse packages template to have a single subfunction handling the different lists of add-ons rather than doing it 4 times (Packages.template.php)
----
Modified : /trunk/Themes/default/Packages.template.php
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 12:11 PM
rev 330

* Now that we're using PHP 5.1.2 as minimum version, date_default_timezone_set() is always available, so don't bother looking for it. Also made a couple of related time function fixes. (install.php, upgrade.sql, Calendar.php, Load.php, ManageSettings.php)
- Deleted a few unused globals. There's probably room for more to be removed here. (install.php)
- Delete clickMagic(), as it will now be done inline. (script.js)
! Fatal error pages could break the header layout. (css/index.css)
! CRLF fix. (Nix/ie6.css)

(I forgot to document the script.js change in the changelog -- actually I was planning to commit it in the next batch rather than now, oops...)
Pete, can you look into these useless globals in install.php? I don't see why there were so many declared in the first place...
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 02:15 PM
rev 331

@ First official use of jQuery in Wedge![1] (QueryString.php, topic.js)
* Finalized inline JS code. Now, all events are automatically moved to the end of the page, with all duplicates merged, and executed after jQuery is loaded. (QueryString.php, index.template.php)
* Modified Quick Reply, Quick Modify and User Menu objects to allow for better duplicate management. Deleted xDeprecated argument from QuickReply.quote(). (Display.template.php, topic.js)
- Deleted data- prefixes from events in Display template. Other files will be done next. (Display.template.php)
* User menu is now a bit more user-friendly... User can click anywhere in the page to cancel an opened menu, and clicking on another user name will also close previously opened menus. (topic.js)
Posted: December 2nd, 2010, 02:00 PM

rev 332

- Reverted all 60+ existing data-on* events to happily use the new system. (Class-Editor.php, Groups.php, Manage*.php, Modlog.php, Profile-Modify.php, Subs-Package.php, Subs.php, TEMPLATES: Admin, Calendar, ManageMaintenance, MessageIndex, ModerationCenter, Poll, Post, Profile, Register, Stats)
 1. As far as I know... :mdr:
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 02:30 PM
rev 333

* Renamed weDB, weDBExtra, weDBPackages and weDBSearch classes to wedb, wedbExtra, wedbPackages and wedbSearch. This took a minute to do. Can be reverted if someone's unhappy. Just wanted to see how it looked and felt ;) (Plenty of files, obviously.)

To Pete: I didn't wait for your feedback to do this... I'm well aware that you might not like this, so I made sure it's done in a separate commit. If you don't like it, either manually do a search & replace on wedb to weDB (or "wdb"?), or just revert rev 333! This is NOT a hostile fork commit... :^^;:

Also, obviously, if you're going to analyze revs 330-332, please update to rev 332, not 333 ;)
Title: Re: New revs
Post by: Nao on December 2nd, 2010, 07:49 PM
rev 334

* ssi_examples fix. Plenty of things were broken in the first place. (other/ssi_examples.*)
* Converted more templates to HTML5. Some of these files in other/* are a real mess... Might as well throw them away at some point. (news_readme.html, readme_*.html, sphinx_config.php, ssi_examples.*, package/*.html, package/test_modification.php, repair_settings.php, webinstall.php, SSI.php)
- Did you know that link rel="stylesheet" tags could also do without the type="text/css" attribute? Yes? Well, I didn't. I tried, and it validates. Away they go. (install.php, Class-Editor.php, ViewQuery.php, and most of the files above. TEMPLATES: Errors, Help, index, ModerationCenter, Packages, Post, Register, Reports)
- Forgot to update the documentation when I removed specific browser version sniffing in rev 93. (Load.php)
Posted: December 2nd, 2010, 07:07 PM

rev 335

- Deleted empty alt's from img tags, as they're not required by the HTML5 specs. (ssi_examples.php, Display.php, Load.php, Subs-Menu.php, Subs.php, editor.js, TEMPLATES: Admin, BoardIndex, Display, Errors, GenericList, GenericMenu, Login, ManageMembergroups, ManageSmileys, Memberlist, MessageIndex, ModerationCenter, Notify, Packages, PersonalMessage, Post, Profile, Recent, Search, SendTopic, Stats, Themes, Who)
* Fixed posting_icons alignment. (index.css)
Title: Re: New revs
Post by: Nao on December 3rd, 2010, 08:59 AM
rev 336

! Events could be postponed even when inserted in the footer area. (QueryString.php, index.template.php)
Title: Re: New revs
Post by: Arantor on December 3rd, 2010, 02:45 PM
Revision: 337
Author: arantor
Date: 12:40:36, 03 December 2010
Message:
! Don't show the login screen for someone who is already logged (Login.php)
----
Modified : /trunk/Sources/Login.php

Posted: December 3rd, 2010, 01:41 PM

Revision: 338
Author: arantor
Date: 13:44:42, 03 December 2010
Message:
! Make bbcode be loaded from a table rather than stored hardcoded in the parser (Subs.php, install.sql)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on December 3rd, 2010, 05:50 PM
Revision: 339
Author: arantor
Date: 16:49:46, 03 December 2010
Message:
+ westring class (Class-String.php)
! Die, $smcFunc, die. (MANY files, many changes pretty automated which is why some of the other/ files are done)
! Stripping out a few more of the db_* functions that should have gone yesterday (RepairBoards.php and a couple of others)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-Editor.php
Added : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/tools/restore_backup.php
Modified : /trunk/other/tools/smf_api.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/tests/Class-UnitTest.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_parsesmileys.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/subscriptions.php

(Oh, and there is a change to Login.php to kick registered users back to the main page since we shouldn't really show the login page to non-guests.)
Title: Re: New revs
Post by: Nao on December 4th, 2010, 11:02 AM
rev 340

* Many script.js changes. Dropped is_ie4, is_ie5 and other deprecated browser vars (testing for if (is_ie4) is going to return false, whether they're declared or not, so let's not waste time initializing them...), used more logical ways to determine version numbers (Opera 9.5+ and IE versions), used jQuery in many places to save up to 3KB of script code. Turned addLoadEvent into a jQuery alias. (script.js)
! Fixed the following bugs in inline JS postponing: double ob_sessrewrite calls, events not getting compiled at runtime (used function() instead of new Function()), exotic templates generating errors (xml, etc), and self-closing tags breaking validation after being modified. Also used a static instead of a global var to store duplicate events. (QueryString.php)
* helpFrame was no longer working due to variable name optimizations. Renamed it to helf and optimized related code. BTW this Help template is ridiculously short now, as well as a couple other templates... Maybe we should integrate them into another file... (Help.template.php, Register.template.php, script.js)
* As inline events no longer require to have entities instead of <, >, & etc, converted all of the existing events to use clean code. (Groups.php, TEMPLATES: ManageBans, ManageMaintenance, ManageMembergroups, ManageSearch, MessageIndex, ModerationCenter, Packages, Search)
* Turned <div class="smalltext"> descriptions in admin zones, to use <dfn> (definition term), which validates when inside <dt> tags. (index.css, ManageBans.template.php, up to 214 more changes to come...)
* Minor details. (Errors.english.php, Errors.french.php, ManageMaintenance.french.php, Profile.template.php)

It's not yet out... But I've written the changelog already, so here it is :P
Obviously it would be out already if it didn't collide with the latest revs, ah ah... I can feel the fun already.
:edit: Not a single collision, actually. :wow:
:edit: :edit: Done!
Title: Re: New revs
Post by: Nao on December 4th, 2010, 01:56 PM
rev 341

* 172 more <div class="smalltext"> replacements to <dfn>. Should be done now... (ManageSettings.php, index.css, TEMPLATES: ManageBoards, ManageMembergroups, ManageNews, ManagePaid, ManageScheduledTasks, ManageSearch, ManageSmileys, ModerationCenter, Packages, PersonalMessage, Profile, Register, SendTopic, Themes, LANGUAGES: Admin, ManageSettings, Search)
* Spacinazi and valinazi (small issues that broke validation :P). (Errors.template.php, Profile.template.php, Themes.template.php)
Posted: December 4th, 2010, 01:28 PM

rev 342

* Some optimizations in parse_bbc(). Not all, though. Yeah, I know, I could have used === instead of ==... Stop bothering me now, will you? (Subs.php)
Title: Re: New revs
Post by: Nao on December 4th, 2010, 04:17 PM
rev 343

* Mass renaming 'westring' class to 'westr'. (About 60 files.)
Posted: December 4th, 2010, 04:17 PM

rev 344

- Oops! Test code. (index.template.php)
Title: Re: New revs
Post by: Nao on December 4th, 2010, 07:30 PM
rev 345

* More jQuery fun. (script.js, suggest.js, topic.js)
! Fixed addLoadEvent no longer accepting strings as parameter, e.g. auto-suggest init. (script.js)
Title: Re: New revs
Post by: Nao on December 5th, 2010, 12:31 AM
rev 346

* Turned Ajax functions into jQuery $.ajax() calls. Seems to work on everything I tested (auto-suggest, topic pages.) (script.js, suggest.js)

This is a 'big' part even though it doesn't show. Maybe we don't want to do this conversion right now... Still, it can't hurt to at least *try*. It saves nearly an extra kilobyte off the script file... And a mere 160 bytes from the minified, gzipped file.
Title: Re: New revs
Post by: Arantor on December 5th, 2010, 04:16 PM
Revision: 347
Author: arantor
Date: 15:15:57, 05 December 2010
Message:
! Updated to r10296
 - expanded support for size types in size bbc (install.sql)
 - caching board parents information (Load.php)
 - OpenID fix (Subs-OpenID.php)
 - moving action spamming checks earlier in workflow (Login2.php, SendTopic.php)
 - some servers send $_SERVER['HTTPS'] in different ways (ManageServer.php)
 - comment fixes (Errors.php, ManagePosts.php, Subs-Menu.php)
 - make sure cache is cleared when boards are altered (Subs-Boards.php)
 - make sure cache-clearing also invalidates cache in case files weren't removed (Subs.php)
 - minor layout tweak (admin.css)
 - remove signature padding for IE6 and IE7 (ie6.css, ie7.css)
 - language cleanups including a missing error message (Admin, Errors, Help, index, Profile)
 - Fix for additional space in post template (Post.template.php)
 - Formatting change in profile template for requesting a group membership (Profile.template.php)
 - Change of reserved words to use change in admin CSS (additional by me: dropping of name attribute for HTML5) (Register.template.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/css/admin.css
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/ie7.css
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql



(Changes from RC4 public to r10296)
Title: Re: New revs
Post by: Nao on December 5th, 2010, 07:38 PM
rev 348

! Auto-suggest search could generate errors in the log. (Suggest.php)
* Updated French translation. (Admin, Errors, Help, index, Profile)
Title: Re: New revs
Post by: Nao on December 5th, 2010, 08:31 PM
rev 349

- Removed support for bbcode tags: glow (out of fashion), shadow (meh), move (epileptic FTW), and acronym (deprecated in HTML5, use abbr instead. Yes I know, I could have just made an alias for that one...) (install.sql, Subs.php, Post.english.php, Post.french.php, Admin.french.php)
- Removed corresponding icons (glow, shadow and move) from the sprite. (Class-Editor.php, bbc/sprite.png)
! Fixed a couple of issues in the bbcode table's default contents. (install.sql)

I couldn't determine whether <acronym> was really deprecated in HTML5[1] (most websites say yes, but the w3schools site, which is run by the w3c IIRC, doesn't mention it), but I figured it wouldn't matter anyway.
We need to (1) make that "things to do in the converter" topic, (2) mention that we should update posts to delete these tags.
Posted: December 5th, 2010, 08:19 PM

rev 350

* <tt> is deprecated in HTML5. Replacing HTML contents for the tag. (install.sql)
 1. :edit: Seems really likely...
Title: Re: New revs
Post by: Nao on December 6th, 2010, 10:48 AM
rev 351

* Renamed wedb class to wesql, for consistency with both the westr class, and the original mysql_* functions. Whatever, eh? (SSI.php, subscriptions.php, other/install.php, Sources/*.php)

(Put into its own separate commit, so that you can cancel it if you end up not liking it.)
(Also, I haven't renamed wedbPackages and wedbExtra yet. I don't really know what to do about them... Maybe weDbPackages and weDbExtra? Or weDBPackages and weDBExtra, like their Class-*.php filenames?)
Title: Re: New revs
Post by: Nao on December 6th, 2010, 11:49 AM
rev 352

* Slightly optimized parse_bbc() by removing its two easter eggs (chrissy and kissy), avoiding copying $master_codes to $codes, and referencing $master_codes when filling the BBCode array, instead of copying it. (Subs.php)
* User menus are no longer triggered when clicking a username, rather they'll pop up when hovering the username, and close automatically when moving the mouse somewhere else. Oddly, this makes the code a bit simpler, as body click events and double-click cancellations (via onmousedown) are no longer necessary. (Display.template.php, topic.js)
+ Added French image folder. Just so we don't forget providing it later... (images/french/*)

(Have yet to commit my partial editor.js conversion to jQuery. I wouldn't even know where to begin with testing, ah ah...)
Title: Re: New revs
Post by: Nao on December 6th, 2010, 04:23 PM
rev 353

! Error when renaming the wedb class. (Class-DB.php)
* hover() is shorter than a double bind. (Display.template.php)
* Moved avatar management code in profile to the footer area. (Profile.template.php)

(Sorry for the crash bug. I'm busy debugging the main menu in IE (it's currently broken) and I didn't test everything.)
Title: Re: New revs
Post by: Nao on December 6th, 2010, 11:49 PM
rev 354

! Fixed a few functions that were broken during the conversion to jQuery. (script.js)
Posted: December 6th, 2010, 10:26 PM

rev 355

* Improved menu performance in Internet Explorer by a factor of 42. I'm so proud. (script.js)
! Fixed iframe shim for IE. Should be working well in IE6 now. (script.js)
* More jQuery goodness. Can be improved, as usual... (script.js)
@ todo: fix editor in IE6... Doesn't seem to accept Wysiwyg, and icons don't show. (Already fixed that once last month... Uh. IE.)
Title: Re: New revs
Post by: Nao on December 7th, 2010, 06:39 PM
Ah... Finally done with that commit... -_-

rev 356

* Too bad jQuery doesn't support the pageshow event... Still, moving that to the footer. (Post.template.php)
- Replaced event listeners with jQuery's implementation. (register.js, topic.js)
* Replaced XMLHttpRequest tests with a can_ajax variable, and removed all tmpMethod hacks. The Themes template still has a different hack that needs to go. (upgrade.php, TEMPLATES: Display, MessageIndex, Packages, Search, SplitTopics, Themes, register.js, stats.js, suggest.js, topic.js)
* Style file inputs to get a default width of 300px. (index.css, Packages.template.php)
* Replaced Comic Sans MS with Segoe UI. Yeah, Comic is a popular font, but it doesn't make me laugh. That would actually be the opposite... Also replaced the ugly Courier with Courier New, and deleted an extra, unused copy of the font list from the script file. (Class-Editor.php, editor.js)
* Made main menu code faster, and saved an awful lot of code, too. (script.js)
* Been slightly more aggressive when minifying CSS... Saves a few bytes per file. (Subs.php)
* Renamed is_ie9 JS var to is_ie9up, as it's really what it does now... (script.js)
- getMousePosition() was no longer needed, as its task is already fulfilled by jQuery. (editor.js)
* The 'more' bbcode tag was hardcoded. I know it's not finished yet (add button, etc..?), but it still needed to get its own class and translations. (Subs.php, index.css, index.english.php, index.french.php)
@ Discuss: Shouldn't parse_bbc use UTF8-safe strlen/substr functions everywhere..?
@ Note for later: IE6 doesn't like $('<input>', { object }). Whatever they say on the web... It doesn't. It has to be fully formed in the HTML portion.
Title: Re: New revs
Post by: Nao on December 7th, 2010, 09:04 PM
rev 357

+ The smc_Toggle class was screaming to be upgraded to use jQuery's animations! Looks great and saves 5 lines of code, ah ah! (script.js)
Title: Re: New revs
Post by: Nao on December 9th, 2010, 06:30 PM
rev 358

* Modified the menu system to turn it into a pure CSS menu when Javascript is not available. Oh yes. (index.css, script.js, GenericMenu.template.php, index.template.php)
* Changed toggle class animation to make it slide up and down, instead of shrink and fade. This should be a bit better for performance, and accomodate for weirder layouts, if ever needed. (script.js)
! Fixed remaining chars counter in the 'more' tag, to take multi-byte chars into account. Also, don't bother showing anything if the tag was put at the end of the message. (Subs.php)
! Fixed many CSS bugs in the main menu implementation for IE6 and IE7. (ie6.css, ie7.css)
* Couple of translation tweaks. (Admin.french.php)
* More jQuery conversion work... Errr... Just turned a 5-line loop into a 2-line parentsUntil() chain. So what. It's a cool geeky instruction. (script.js)
- Removed a 'move' bbcode leftover. Thanks Pete! (Post.template.php)
Title: Re: New revs
Post by: MultiformeIngegno on December 9th, 2010, 08:02 PM
Great! :cool:
Title: Re: New revs
Post by: Nao on December 9th, 2010, 08:06 PM
Thanks ;)
Please post your comments in the appropriate topic though... We're trying to make this one has only the changelogs, to make it easier to go through ;)

rev 359

- Hack for ob_sessrewrite was no longer needed, as Wedge doesn't use ob_end_clean() anywhere. (QueryString.php)
Title: Re: New revs
Post by: Nao on December 10th, 2010, 12:50 AM
rev 360

* More jQuery optimization. Simplified help frame to avoid storing a variable in memory just for that. (script.js, Help.template.php, Register.template.php)
* Made submitThisOnce() work on Safari 3.0+, because the comment indicates the hack is for v1.3 beta... Logic dictates that recent builds should work fine. (script.js)
* Moved array_search() to editor.js, as it was only used over there. (editor.js, script.js)
* Spacinazi. (Subs.php, script.js)
Title: Re: New revs
Post by: Nao on December 10th, 2010, 10:00 AM
rev 361

* Converted smf_avatarResize() to jQuery, and removed some leftover code. (script.js)

I think 99% of the jQuery conversion is done in script.js... I mean, I don't really see anything else to do. I'll probably be able to save at most 10 more lines by doing micro-changes here and there... Nothing more.
Still, all in all I've managed to shave nearly 7 kilobytes off the size of script.js -- that is, about 18%, or twice more than the best I thought I could have achieved.

I have a feeling that editor.js can get a similar treatment, but I don't know if it's worth thinking about it, because of the talk on including CKEditor. I figure it means editor.js will go at some point...? Or at least most of it?
Title: Re: New revs
Post by: Arantor on December 10th, 2010, 11:50 AM
Quote
I have a feeling that editor.js can get a similar treatment, but I don't know if it's worth thinking about it, because of the talk on including CKEditor. I figure it means editor.js will go at some point...? Or at least most of it?
At least most of it.
Title: Re: New revs
Post by: Nao on December 10th, 2010, 03:12 PM
So I'm working on suggest.js instead. :P
Title: Re: New revs
Post by: Nao on December 10th, 2010, 07:26 PM
rev 362

! Fixed a SMF bug in the auto-suggest control, where the popup would reappear after selecting an entry if the typed text was the same as the suggested (and selected) text, only with different letter case. (suggest.js)
- Removed handleSubmit() function, which was really pointless, and oRealTextHandle object, which... you get the idea. (suggest.js)
+ Added subtle animation effect to auto-suggest popups. (suggest.js)
* Overall, converted auto-suggest to jQuery. (suggest.js)
Title: Re: New revs
Post by: Arantor on December 11th, 2010, 12:52 AM
Revision: 363
Author: arantor
Date: 23:37:37, 10 December 2010
Message:
! Performance enhancement to SSI's ssi_recentTopics function (thanks to live627)
----
Modified : /trunk/SSI.php

Posted: December 11th, 2010, 12:38 AM

Revision: 364
Author: arantor
Date: 23:52:11, 10 December 2010
Message:
! Fixed installer not logging in user on new install (install.php)
----
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Nao on December 11th, 2010, 01:27 AM
rev 365

* Moved storeCaret() to the footer, and made sure only IE runs it. Because only IE needs it... (Class-Editor.php)
* Made sure that the Quick Reply toggle text isn't selectable, and moved its JS call to the footer. (Display.template.php)
* Some tweaks in IE7... (ie7.css)
* ...And some other general CSS tweaks. (index.css)
- postAttachment3 doesn't exist... Does it? (index.css, rtl.css, Post.template.php)
* Replaced a few hardcoded input box sizes with CSS. Thanks live627! (Post.template.php)
* Missing capitals in a few entries. (Admin.english.php, Admin.french.php)
* Spacinazi. (Display.template.php, Post.template.php)
- What's the point in calling init() at the end of some object constructors, when we could just stay in these functions? (editor.js, topic.js)
+ Added animation effects in Quick Reply (opening, closing and switching to Wysiwyg), and started conversion to jQuery. (topic.js)
* The More Options area in the post template should be hidden immediately when collapsed, instead of triggering the relatively lengthy animation. (Post.template.php)
* Optimized spell-check JS and converted it to jQuery. (spellcheck.js)

Good luck for having a look at it all, Pete... My changes are sometimes a bit complicated -- but hopefully not buggy!!
Title: Re: New revs
Post by: Arantor on December 11th, 2010, 12:51 PM
Revision: 366
Author: arantor
Date: 11:51:13, 11 December 2010
Message:
! Fix the bugs caused by trying to code something quickly when tired (SSI.php)
----
Modified : /trunk/SSI.php
Title: Re: New revs
Post by: Nao on December 11th, 2010, 09:30 PM
rev 367

- Removed all "old theme compatibility code" related to the session variable name. Seriously, we're not compatible with SMF1 themes. Get over it. A few sesc/sc lines are left in the overall codebase, because I'm unsure whether they should be touched. (topic.js, script.js)
* Pretty much finished converting topic.js to jQuery. XML tree manipulation is way cooler with it. (topic.js)
* Converted Post template's JS area to jQuery. (Post.template.php)
- Some of the XML parsing did strange things, like concatenating all children in a node to build the quote or body strings, when the XML template would always return a single child anyway...! (topic.js, Post.template.php)
- $context['quote']['text'] and $context['quote']['mozilla'] are never used anywhere... Are they? (QuoteFast.php)
* Moved smf_addButton() to topic.js, as it's only used over there. (theme.js, topic.js)
* Minor layout tweaks and spacinazi. (index.css, Xml.template.php)
* One extra DOM node to convert to jQuery... Gotta get'em all! (suggest.js)
* Updated generateDays() to jQuery. Whatever. (Calendar.template.php, ManageCalendar.template.php, ManagePaid.template.php, Post.template.php)
! Forgot to add a dummy link to the quick reply toggle. (Display.template.php)

I can't feel my legs... Help... Hours spent just to double-check my Post template and topic.js changes... Arghhh...
Title: Re: New revs
Post by: Nao on December 11th, 2010, 11:19 PM
rev 368

! Fixed BBC button layout in IE6. (ie6.css)
Title: Re: New revs
Post by: Arantor on December 12th, 2010, 07:50 PM
Revision: 369
Author: arantor
Date: 03:53:25, 12 December 2010
Message:
+ Added ability to recount member posts into Admin / Maintenance / Members (ManageMaintenance.php, ManageMaintenance.template.php, ManageMaintenance.english.php)
----
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php

Posted: December 12th, 2010, 04:53 AM

Revision: 370
Author: arantor
Date: 04:21:14, 12 December 2010
Message:
+ Scheduled tasks can now specify a file to load that contains the actual function to be called (install.sql, ScheduledTasks.php, ManageScheduledTasks.php)
----
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/other/install.sql

Posted: December 12th, 2010, 05:21 AM

Revision: 371
Author: arantor
Date: 18:49:50, 12 December 2010
Message:
! Rewrote news fader to run in jQuery (BoardIndex.template.php, fader.js)
----
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/scripts/fader.js
Title: Re: New revs
Post by: Nao on December 13th, 2010, 01:13 PM
rev 372

+ Added automatic minification and gzipping of *all* Javascript files. Yay. (Class-Editor.php, QueryString.php, Spellcheck.php, Subs-Editor.php, Subs.php, TEMPLATES: Admin, BoardIndex, index, Login, ManageBans/Boards/Maintenance/Membergroups/News/Paid/Smileys, MessageIndex, ModerationCenter, Packages, PersonalMessage, Post, Profile, Register, Reminder, Stats, Themes)
+ Put cached JS timestamps inside the filename to help with caching, and added automatic removal of earlier cached versions. (Subs.php)
* Spent some quality time with JSLint, the infamous Javascript validator, and applied a good chunk of its hints. Thanks, man. (pm.js, TEMPLATES: Display, ManagePermissions, Packages, PersonalMessage, Post, SplitTopics)
* Replaced time_format's default day handler with %e, because I don't see why we have to cope with extra zero padding just because Windows servers can't do it... Also, SMF kept warning people against using it, but the help file was outdated (implying there was no hack to make it work), and said hack was definitely not up to date either. Anyway... Rewrote all of that. (upgrade.php, Help language, Install language)
- Did we actually ever use wedge_add_js? No? That's what I thought. Also optimized wedge_add_css(). (Load.php, Subs.php)
! Quick Reply didn't return false. Oops. (Display.template.php)
! Error box always showed up when previewing a message, even if empty. (Post.template.php)
* Spacinazi. (ManageMaintenance.php, PersonalMessage.template.php)
* Removed "min" from jquery-1.4.4.min.js because it's already long enough as it as, and renamed PersonalMessage.js to pm.js, for consistency within the scripts folder. (pm.js)
+ Added French translation for new Recount maintenance task. Also made a few tweaks to various translations. We use Cookie in French. Not Témoin. Stop with the silly French words. (Admin, Help, ManageMaintenance, Post, Themes languages)
* Fix for 'More Options' animation overflow in IE6. (ie6.css)
@ todo: add support for $modSettings['obfuscateFilenames'], add a switch for JSMin/Packer use, and make sure to always save cache in the current theme. Also, the spellcheck window is currently broken because it doesn't show anything. Needs rewriting.

(Also need to commit the rest of the JS files. Oh my, and I want to eat! And play DeathSpank!)
Posted: December 13th, 2010, 12:55 PM

rev 373

- Uh... Wrong copy/paste manipulation. (index.template.php)
Title: Re: New revs
Post by: Nao on December 13th, 2010, 04:37 PM
rev 374

+ Added support for topic subscriptions to the RSS feed feature. (Feed.php)
* Save some time on each request by caching the value of $_REQUEST['action']. (index.php)
! A preg_replace's second parameter is a proper PHP string, it doesn't follow the regex engine's twisted rules. ;) (Class-String.php)
- SMF bug: A few queries are overly complicated, because $board is already taken into account in $query_this, and they're still testing for it. (Feed.php)
! SMF bug: cdata_parse() is a byte-aware function, as opposed to char-aware, so westr::substr would find full entities instead of just an ampersang, resulting in an infinite loop. (Feed.php)

A few things to note:
- Is it a SMF bug or a Class-String.php bug? I'm thinking SMF bug, very strongly, because $smcFunc['substr'] does indeed attempt to get full entities as a single character, but I'm not fluent on the conversion work and maybe they use an alternate codepath in some cases and these cases weren't taken into account properly? I don't know. Warrants another check!
- Seriously, why didn't anyone cache the $_REQUEST['action'] in all these years...? :lol:
- The per-topic RSS feed doesn't take unapproved posts into account. Could you look into that, Pete? After implementing that feature AND fixing the cdata_parse() function, let's just say I'm not too excited to look into Feed.php even for an extra minute ;)
- The $board optimization in queries is a last-minute fix. I tested it on my local install, but I don't have "hidden" boards or anything, but I don't think they'd be related to that anyway. Seriously, another waste of CPU cycles to me...
Posted: December 13th, 2010, 04:01 PM

rev 375

! SMF bug: using PHP syntax to add a string (w00t!), and making that string an unknown variable... Assuming they mean this.opt.sUniqueId. It's a wonder this doesn't even throw an error, but it's still a nasty one. (editor.js)
! Nao bug: unknown variable in smfSelectText(). Oops. (editor.js)
- We don't need to deal with window.event in events that are initialized through jQuery. (script.js)
* Finishing the JSLint-induced changes. Most notably, adding semicolons at the end of prototype definitions. This should make it possible to compress files through Packer without the need for an extra pass of semicolon checks (see QueryString.php). Also, I didn't bother with the ==/=== suggested changes. Not confident enough in SMF's code strictness in that particular area. Finally, removed many unused variables. (admin.js, captcha.js, editor.js, profile.js, register.js, script.js, sha1.js, spellcheck.js, stats.js, suggest.js, topic.js)
Title: Re: New revs
Post by: Arantor on December 14th, 2010, 12:17 PM
Revision: 376
Author: arantor
Date: 10:44:30, 14 December 2010
Message:
! More documentation (Activate.php, Buddy.php)
! Add a hook to the buddy action in case we want to do something interesting with the new buddy. (Buddy.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Buddy.php

Posted: December 14th, 2010, 11:44 AM

Revision: 377
Author: arantor
Date: 11:17:25, 14 December 2010
Message:
! More documentation (CoppaForm.php, Credits.php, Dlattach.php)
----
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Dlattach.php
Title: Re: New revs
Post by: Nao on December 15th, 2010, 12:12 PM
rev 378

* In the main menu, if we're browsing a board, show a popup menu under 'Home' giving a link to both the forum homepage and the current board's homepage. (Subs.php)
+ Added switch for Javascript filename obfuscation. (ManageServer.php, QueryString.php, Help language, ManageSettings language)
+ Added Minify UI in Manage Server. (install.sql, ManageServer.php, Subs.php, Help language, ManageSettings language)
+ Added switch to choose jQuery server. (install.sql, Load.php, ManageServer.php, index.template.php, Help language, ManageSettings language)
+ Proceed to delete all JS from cache when JS-related options are set, and CSS as well when 'compressed data' option is set. (ManageServer.php)
* Make sure to always create cached files in the current theme's folder. (Subs.php)
Posted: December 15th, 2010, 12:04 PM

rev 379

* Replaced cdata_parse() function with a single-line thingy that should take care of it all. Revert if it doesn't work. (That's why I'm committing this apart from the rest.) (Feed.php)
Posted: December 15th, 2010, 12:12 PM

rev 380

+ Added RSS link for current board in board index, and RSS link for current topic in the button strip. There's no rss.gif file for now but I'll try to think of something to add icons. (MessageIndex.template.php, Display.template.php)
* Renamed 'RSS feed' to RSS for the reason above. I don't know if it's a good idea though, for non-techies... (index language)
+ Added a subtle shadow under help iframes. (index.css)
! Fixed spellcheck window... Err, actually, committing a proposed fix. I have no way to test it for now, ahah. I'm a funny guy. (Post.template.php)
! Minor typos. (Activate.php, Buddy.php, Credits.php)
* Replaced sizes with classes. Not that it's important at all. (SendTopic.template.php)
Title: Re: New revs
Post by: Nao on December 15th, 2010, 02:06 PM
rev 381

* Modified the php bbcode to use a proper html tag (code), and applied the same styling as with the code bbcode. The only thing missing is the "select" text, but it's not like anyone complained about its lack so far. (install.sql, index.css)

Forgot to add to the changelog that I've also changed the font size from "x-small" (which is apparently 7.5pt) to "8pt"... I don't know what "x-small" is supposed to fix, but I know that it's very small in Opera and makes it hard to read proper code. If you don't want to make it readable -- attach it as a zip file or something :lol:
Title: Re: New revs
Post by: Nao on December 15th, 2010, 07:41 PM
rev 382

* Replaced the help popup's iframe with an Ajax popup, shown with style and in pure jQuery fashion. (Help.template.php, script.js)

(The animation is a simple fadeIn effect... I tried with toggle() and it reflows the text as it enlarges. Is there a way to prevent text reflowing in this kind of animation?)
Title: Re: New revs
Post by: Arantor on December 15th, 2010, 11:15 PM
Nice!
Quote
(The animation is a simple fadeIn effect... I tried with toggle() and it reflows the text as it enlarges. Is there a way to prevent text reflowing in this kind of animation?)
I don't believe so due to the techniques used in toggle(), which IIRC is resizing as well as other things, as opposed to fadeIn being purely an opacity change.
Title: Re: New revs
Post by: Nao on December 17th, 2010, 04:25 PM
rev 383

! The cache manager didn't properly delete earlier Javascript cached files. (Subs.php)
! In Quick Reply mode, the spellcheck form was declared twice (once in the Display template, once in Class-Editor.php), causing browsers to fail finding the proper window. Sorry for the poor hack, this needs better fixing. (Display.template.php)
* script.js all alone won't work without jQuery... Will need to do this on all files that call it directly. And obfuscate the links, too. And add an .htaccess rule to prevent viewing the files from within the scripts folder. Is it me who's being paranoid here? (install.php)
* If an error is found when launching the spellcheck window, just close it automatically, instead of showing a blank page. (Spellcheck.php)
Title: Re: New revs
Post by: Arantor on December 18th, 2010, 03:41 AM
Revision: 384
Author: arantor
Date: 02:40:44, 18 December 2010
Message:
! Remove the white, black, blue, red, green bbcodes from installer - these are all removed during preparsecode anyway. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 18th, 2010, 12:41 PM
rev 385

* When forcing loading of an uncached jQuery, get it from the jQuery CDN. (install.php, repair_settings.php, upgrade.php)
! Fixed repair_settings.php to, err... At least run. (repair_settings.php)
* Rewrote some JS to add animations. (ssi_examples.php)
+ Added Aeva Media helpers (I'm working on integrating it... Even if I'm doing it outside the SVN, it has to creep into the main codebase at some point.) (Class-DB.php)
+ Implemented theme_base_js() and theme_base_css() helpers, and added them wherever I could. sphinx_config and ssi_examples will now use the current theme rather than the default one I believe, so maybe it's not a good idea for these. (sphinx_config.php, ssi_examples.php, Load.php, Subs.php, ViewQuery.php, TEMPLATES: Errors, Help, index, ModerationCenter, Packages, Post, Register)
* Commenazi and French collaborator. (ManageMaintenance.php, Install.french.php)
Title: Re: New revs
Post by: Nao on December 18th, 2010, 10:51 PM
rev 386

* Modified the license agreement to rename WedgeBox to Wedgeward (don't bother, I'll probably get around to changing it again before you know it), and add the "vbgamer45 clause". Or at least a placeholder... (license.txt)
* Renamed WedgeBox to Wedgeward everywhere else. (install.php, ssi_examples.shtml, upgrade.php, Credits.php, index.template.php, LANGUAGES: index, Install)
Title: Re: New revs
Post by: Arantor on December 20th, 2010, 04:48 PM
Revision: 387
Author: arantor
Date: 15:47:43, 20 December 2010
Message:
+ First part of the drafts system
 + Added ability to save drafts (lots of files)
 + Editor gained ability to specify buttons programmatically without editing the editor code (Class-Editor.php)
 ! Area to display drafts (Profile-View.php, Profile.php, Profile.english.php, Profile.template.php)
 ! Better display of saved drafts than original mod (MessageIndex.php, MessageIndex.template.php, Display.php, Display.template.php)
 ! Permissions (ManagePermissions.english.php, ManagePermissions.php)
 ! Admin on/off switches (ManagePosts.php, Admin.english.php)
 ! If the topic is no longer available when trying to handle a draft, display a warning to the user and handle the draft as if trying to create a new topic (Profile-View.php, Profile.template.php)

@todo in rough priority: Saving of personal messages, display of PM saved drafts, auto saving, fix what to do if a board isn't available (give the user another board to pick instead)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 21st, 2010, 12:49 AM
rev 388

* Spacinazi. (Post.php, Post2.php, Profile.php, Subs-Post.php, Profile.template.php, index.english.php)
! As a reminder, the align attribute doesn't validate in HTML5. (Profile.template.php)
* French translation for drafts. WIP. (LANGUAGES: Admin, index, ManagePermissions, Profile)
Title: Re: New revs
Post by: Nao on December 21st, 2010, 06:23 PM
rev 389

! Fixed inline topic title modification, which was awfully broken since the switch to jQuery. (MessageIndex.template.php, topic.js)
! Fixed help popup for IE. Also made sure to close the popup if user clicks anywhere outside of it. (script.js)
* wesql::insert can't accept a "default" value for its first parameter, since its remaining parameters are mandatory... (Class-DB.php)
* Added a quick hack for lazy DB insertion. This is temporary (for AeMe integration), and should probably be removed later, unless proved solid. (Class-DB.php)
* Spacinazi: replaced NULL with null, just for consistency. (Class-Editor.php, Load.php, ManageSearchEngines.php, SplitTopics.php)
! CSS minification didn't optimize "element > element". (Subs.php)
+ Added some code to prevent Packer from removing /*! comments (copyright stuff) from the compressed files. Doesn't work when the file is compressed with Packer, though (as opposed to just minified.) (Subs.php, script.js)
* Moved add_linktree() from AeMe to Wedge. (Subs.php)
* Menu tweaks. (index.css, Green/index.css, Nix/index.css, ie6.css, ie7.css, rtl.css)
* Help popup should properly underline links. (index.css)
* Adjusted voice popup to use jQuery to close its own div. (Register.template.php)
* Optimized for size reduction and taking advantage of Packer variable minification. (spellcheck.js, topic.js, script.js)
* The menu system was rewritten so thoroughly... I looked into it, and it no longer uses any of the original code, only the original idea. (script.js)
* Stopped using smf_itemPos() at all. Should we remove it? (suggest.js, script.js, topic.js)
* More jQuery optimization. (script.js)
Title: Re: New revs
Post by: Nao on December 22nd, 2010, 08:44 PM
rev 390

* Rewrote some of the menu code to make it even tighter. A bit slower maybe, but only by milliseconds. (script.js, index.css)
- Removed setOuterHTML function and replaced it with native jQuery calls. Also various minor jQuery conversions. (upgrade.php, script.js, topic.js, TEMPLATES: Admin, ManageNews, PersonalMessage, Poll, Post)
- Don't attempt to use Base62 encoding with Packer. It seems to be broken in v3.1 anyway. (Subs.php)
- Cancelling underscores in variable names to make sure they don't collide with other scripts. (topic.js)
+ A French file in SMF/Wedge wasn't completely translated. Ha! (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on December 23rd, 2010, 12:55 PM
rev 391

+ Err... I think no one bothers to test minification because I forgot to delete Class-Minify and commit the Packer class instead, ah ah. Okay, that's not funny. (Class-Packer.php)
! Duplicate filenames should be removed earlier in the caching process. (QueryString.php, Subs.php)
* Simplified Packer constructor, because basically this is a custom object and I'd rather hack into it from its class file rather than anything else. (Subs.php)
- Commented out the semicolon addition hack for Packer. This is because all of Wedge's files are fixed by now, and only those who use badly coded JS files should worry about using that code block. (Subs.php)
* Some edit_poll style optimization. At this point it's quite clear that no real thought has been put into SMF's CSS. It needs some severe reworking to make it much shorter. 59KB is a joke. (index.css)
! sha1.js being a base JS file, it shouldn't be included through add_js_file(). (Login.template.php)
! Code typo. (Post.template.php)
* Moved hashLogin/AdminPassword functions to sha1.js because they require hex_sha1() and thus shouldn't be in the main script file. (script.js, sha1.js)
* More script.js optimizations. isEmptyText() is reduced to one line because jQuery has $.trim(), same for in_array/$.inArray(), setTimeout functions don't need the 'window' prefix, used temp variables to hold long object names, etc. (script.js)
@ Note: $('<option />').appendTo(SomeDocumentFragment) doesn't seem to work. Doing it with appendChild fixes it. (script.js)
Title: Re: New revs
Post by: Nao on December 23rd, 2010, 06:25 PM
rev 392

- Got rid of those annoying eval's. (Class-Editor.php, editor.js, pm.js)
- Got rid of those annoying init's. (admin.js, pm.js, stats.js)
! Fixed BCC help popup not showing up. Complicated hack for a link no one ever clicks, uh... (script.js)
* More JS optimization. (pm.js, script.js, suggest.js)

Note for Pete: Add BCC is still slightly broken... The auto-suggest pops up where the text input was in the first place, rather than its current position. Haven't found out why. Also, I can enter my name as many times as I want, it adds it repeatedly. I seemed to remember that SMF had a mechanism to prevent duplicates. Did I break something or was I dreaming?
Title: Re: New revs
Post by: Nao on December 24th, 2010, 10:11 PM
rev 393

* Moved JS/CSS cache folder to the root cache. (cache/.htaccess, ManageServer.php, QueryString.php, Subs.php)

(I'm committing in two chunks -- this one is the quicker one as it's only one feature change, tested to work. I'll do the rest of my commits when I'm more available.)
Title: Re: New revs
Post by: Nao on December 25th, 2010, 12:02 AM
rev 394, aka the Santa Caummit. Ho ho hoooo! (Midnight, French time.)

* Made the auto-suggest popup colors a little less depressing. (index.css)
* Turned the quick edit button into a div and made it always show immediately. A big mistake from SMF, fixed at last... (index.css, Display.template.php, topic.js)
- Removed a few evil eval's. (ManageBans.template.php)
* There's no point in creating a Loading indicator if we want to remove it in the first place. (script.js)
! The Add BCC link would forget to return false as expected. (pm.js)
* More JS optimizations. (captcha.js, sha1.js, stats.js, theme.js, topic.js)
* Note to self: .first() is more logical and faster than :first if we really only want the first item in the list. (script.js)

Pete --- I really didn't have time to test all of these. Please, please make sure to check the JS files here. Most notably sha1.js (hopefully nothing broken), stats.js, theme.js and basically the other JS files (although less important.) I'm surprised I got to squeeze even more bytes out of the original files. Some of these are way shorter now... (theme.js isn't very big in the first place, but I've shaved another 30% off it I believe.)
Bed time! Merry Christmas to all.
Title: Re: New revs
Post by: Arantor on December 25th, 2010, 03:54 AM
Revision: 395
Author: arantor
Date: 01:01:38, 25 December 2010
Message:
+ Added ability to remove all drafts at once (Profile-View.php, Profile.english.php, Profile.template.php)
+ Added ability to automatically prune posts, as well as advising the user of the time drafts live for. (install.sql, ManagePosts.php, ScheduledTasks.php, Help.english.php, Profile-View.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql

Posted: December 25th, 2010, 02:02 AM

Revision: 396
Author: arantor
Date: 01:37:18, 25 December 2010
Message:
! Cleaned up how 'topic-no-longer-exists' is determined ready for later (Profile-View.php, Profile.template.php)
! Bug fixes in resaving drafts (Subs-Post.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Profile.template.php

Posted: December 25th, 2010, 02:38 AM

Revision: 397
Author: arantor
Date: 01:41:11, 25 December 2010
Message:
! Move the call to load the error language file into determineActions since this can be called from the profile area too, rather than only Who(). (Who.php)
----
Modified : /trunk/Sources/Who.php

Posted: December 25th, 2010, 02:41 AM

Revision: 398
Author: arantor
Date: 02:54:14, 25 December 2010
Message:
! Fix the installer dumping updateStats cache files in the wrong place because $cachedir wasn't brought into scope properly. (install.php)
----
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Arantor on December 26th, 2010, 02:51 AM
Revision: 399
Author: arantor
Date: 01:51:09, 26 December 2010
Message:
+ If a topic is locked, and the user does not have moderation powers, the message for drafts is handled appropriately as well as offering to make it a new topic. (Profile-View.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Title: Re: New revs
Post by: Arantor on December 26th, 2010, 05:29 AM
Revision: 400
Author: arantor
Date: 04:28:59, 26 December 2010
Message:
! Bug fix for missing legend text in admin panel (Admin.english.php)
+ Main menu items for drafts, both in posts (under profile) and PMs (under messages) (Subs.php, index.english.php)
+ Saving PM drafts (Class-Editor.php, Display.php, PersonalMessage.php, Post.php, Subs-Post.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on December 26th, 2010, 10:15 AM
Waking up... Trying to get back to work and checking your stuff...

rev 401

* Use $cachedir instead of $boarddir . '/cache'... (ManageServer.php, QueryString.php, Subs.php)
! A variable was global'ed twice. We should double-check for these... (QueryString.php)
Title: Re: New revs
Post by: Nao on December 26th, 2010, 02:16 PM
rev 402

* Renamed more window.setTimeout/clearTimeout to just the function names. (upgrade.php, Load.php, fader.js, topic.js, Themes.template.php)
* More JS optimizations. Most notably, topic.js turns a 11-line code block into a single-line jQuery call, although it has yet to be tested. (fader.js, register.js, suggest.js, topic.js)
* Spacinazi/typonazi. (Class-Editor.php, Profile.english.php, Profile.template.php, captcha.js)
* Less pinkish colors for the auto-suggest popup. (index.css)
+ French translation of new draft features. (LANGUAGES: Admin, Help, index, Profile)
* Made a help text more specific about something. (Help.english.php)
* Fixed uglyish PM post box layout. (PersonalMessage.template.php, index.css)
Title: Re: New revs
Post by: Arantor on December 26th, 2010, 05:05 PM
Revision: 403
Author: arantor
Date: 16:04:47, 26 December 2010
Message:
+ Added ability to view saved PM drafts (including fix to menu) (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php, Subs.php, index.english.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on December 26th, 2010, 08:17 PM
rev 404

* Log 404 errors as proper 404 errors. (QueryString.php)
* Renamed $pretty_* to $full_*, to make them a little more understandable here. (QueryString.php)
* More JS optimizations. (register.js)

:eheh:
Title: Re: New revs
Post by: Nao on December 27th, 2010, 03:33 PM
rev 405

* Properly record pretty URLs when logging errors. (Errors.php)
* Attempt to close opened tags when showing errors. (Errors.php)
* Minor JS optimizations. (register.js)
Posted: December 26th, 2010, 11:57 PM

rev 406

* French translation. (index, PersonalMessage)
* Minor fixes. (PersonalMessage.template.php, captcha.js)
Posted: December 27th, 2010, 01:30 PM

rev 407

* Cut captcha.js size by 30%, due to many options being unused by now. (Subs-Editor.php, captcha.js)
Title: Re: New revs
Post by: Arantor on December 27th, 2010, 05:20 PM
Revision: 408
Author: arantor
Date: 16:20:25, 27 December 2010
Message:
+ Added auto saving drafts
 + Added draft saving object, plus hopefully all the event catches for it (editor.js)
 ! Modified post and PM display areas to accept AJAX input and not output the main display (Profile-View.php, PersonalMessage.php)
 ! Modified post and PM triggers to respond with XML if XML was requested (AJAX version) since both draft handlers deal with both normal and AJAX drafts (Post2.php, PersonalMessage.php)
 ! Updated editor to output draft initialiser (Class-Editor.php)
 + Added XML return to provide draft id, last saved time/string and remove URL so that Pretty URLs can rewrite it if necessary (Subs-Post.php)
 ! Minor language string changes (index.english.php, PersonalMessage.english.php, Profile.english.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Title: Re: New revs
Post by: Nao on December 27th, 2010, 11:17 PM
rev 409

* More jQuery and Packer optimizations. (script.js, Subs.php, ManageAttachments.php, ManageBoards.php, Subscriptions-PayPal.php, GenericMenu.template.php, index.template.php)
! Clicking a menu item could cause a delay on slow browsers before the page is loaded. (script.js)
Posted: December 27th, 2010, 10:05 PM

rev 410

* More jQuery optimizations. (ManageMail.php, ManageNews.php, ManagePaid.php, ManageRegistration.php, ManageSearchEngines.php, ManageSettings.php, ManageSmileys.php, script.js, TEMPLATES: Calendar, ManageCalendar, ManagePaid, Post, Profile)
Posted: December 27th, 2010, 10:33 PM

rev 411

* Spacinazi and French translation. (Subs-Post.php, editor.js, LANGUAGES: index, PersonalMessage, Profile)
Posted: December 27th, 2010, 10:52 PM

rev 412

! On-the-fly caching regression when deleting older versions. (QueryString.php)
! Okay, sometimes a span works better than a div. (PersonalMessage.template.php)
! Missing semicolon would break minification. (editor.js)
Title: Re: New revs
Post by: Arantor on December 28th, 2010, 03:30 AM
Revision: 413
Author: arantor
Date: 01:45:40, 28 December 2010
Message:
! Minor jQuery optimisations to condense multiple selectors (ManageRegistration.php, Profile.template.php)
----
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Themes/default/Profile.template.php

Posted: December 28th, 2010, 02:45 AM

Revision: 414
Author: arantor
Date: 02:30:29, 28 December 2010
Message:
! Updated to SMF 27/12/2010 daily build equivalent
 ! Convert newlines in birthday emails into HTML linebreaks for later handling (ManageMail.php)
 ! Link in manage-search engines needs to point to the right place (ManageSearchEngines.php)
 ! Add timeout resets for deleting members. We need to revisit this sometime though. (Profile-Actions.php, RemoveTopic.php)
 ! Code niceties (Subs-Admin.php, Subs-Members.php)
 ! Removed new_win styling from URL bbc links (does it need to be done on, say, FTP as well?) (install.sql)
 ! Minor language improvements (Admin.english.php, ManagePermissions.english.php)
 ! Formatting issue in moderation center, should be a space between the number and the title. (ModerationCenter.template.php)
----
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on December 28th, 2010, 04:01 AM
Revision: 416
Author: arantor
Date: 02:46:22, 28 December 2010
Message:
! Oops, didn't fix the comment. (Login2.php)
----
Modified : /trunk/Sources/Login2.php

Revision: 415
Author: arantor
Date: 02:45:19, 28 December 2010
Message:
! Don't bother searching table for email address at login if the username doesn't contain a @ (SMF #4339) (Login2.php)
----
Modified : /trunk/Sources/Login2.php

Posted: December 28th, 2010, 03:46 AM

Revision: 417
Author: arantor
Date: 03:01:24, 28 December 2010
Message:
! Used the 'digits only' subtext on 'Number of posts' on Profile/Account Settings. (SMF #4554) (Profile-Modify.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Title: Re: New revs
Post by: Arantor on December 28th, 2010, 12:54 PM
Revision: 418
Author: arantor
Date: 11:54:01, 28 December 2010
Message:
! Prevent possible undefined index in verification code (SMF #4546) (VerificationCode.php)
----
Modified : /trunk/Sources/VerificationCode.php
Title: Re: New revs
Post by: Nao on December 28th, 2010, 05:14 PM
I'm all good with your revs...

rev 419

! Fixed and jQueried stats.js (stats.js)
* typeof-optimized most JS files. (admin.js, editor.js, profile.js, spellcheck.js, suggest.js)
! French nitpicking. (EmailTemplates.french.php, Admin.french.php)
! Typo (Profile-Actions.php)
Title: Re: New revs
Post by: Arantor on December 29th, 2010, 04:04 AM
Revision: 420
Author: arantor
Date: 03:03:57, 29 December 2010
Message:
! Bug fix to backtrace function, debugging should work properly again. (Class-DB.php)
----
Modified : /trunk/Sources/Class-DB.php
Title: Re: New revs
Post by: Arantor on December 29th, 2010, 04:51 AM
Revision: 421
Author: arantor
Date: 03:49:47, 29 December 2010
Message:
+ Paid subscriptions now have group requirements, which allows for things like discounts for renewing subscriptions. UI might need some work, and there is a bug relating to auto suggest into a textbox to deal with. (install.sql, ManagePaid.php, ManagePaid.english.php, ManagePaid.template.php, Profile-Actions.php)
----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 29th, 2010, 09:44 AM
rev 422

! Fixed a long standing IE+SMF bug where pressing Enter in an auto-suggest control would submit the form. (suggest.js)
* Tightened up some of the Javascript. (suggest.js)
* Some more cool jQuerification. (profile.js, spellcheck.js)
! Fixed undefined var. (Errors.php)
Posted: December 29th, 2010, 09:14 AM

rev 423

! [Repost] Fixed a long standing IE+SMF bug where pressing Enter in an auto-suggest control would submit the form. (suggest.js)
* [Repost] Tightened up some of the Javascript. (suggest.js)
* French translation. (ManagePaid)
- A comment implied a PHP bug when it's just a PHP limitation. (Profile-Actions.php)

(Dunno what happened with suggest.js... Probably got unchecked without my knowledge at commit time.)
Title: Re: New revs
Post by: Nao on December 29th, 2010, 02:59 PM
rev 424

! Fixed deepest menu level not always losing its hovered state when moving the mouse outside the menu area. (script.js)

(Always wanted to deal with that one... Wanted a quicker way to do it, but the event object didn't cooperate with me so I'm just testing whether the item has submenus.)
Title: Re: New revs
Post by: Nao on December 29th, 2010, 06:17 PM
rev 425

+ Added support for menu separators. (Subs-Menu.php, index.css, GenericMenu.template.php)
! Fixed top menu entry not leaving hovered state when clicking a menu item. (script.js)
* Plenty more jQuery/pure JS optimizations. (register.js)
@ Note: divHandle items in verificationFields don't seem to be used at all. (register.js)
Title: Re: New revs
Post by: Nao on December 30th, 2010, 01:07 AM
rev 426

* Modified Core Features layout to use two columns instead of one. (admin.css, Admin.template.php, ManageSettings.french.php)
* Reduced filesize of big icons in the Core Features area. (images/admin/feature_*.png)
* Very minor JS optimizations. (profile.js, stats.js, topic.js)
* Spacinazi. (ManageSettings.php)
Title: Re: New revs
Post by: Arantor on December 30th, 2010, 03:30 AM
Revision: 427
Author: arantor
Date: 02:30:15, 30 December 2010
Message:
! Undefined index moderators fix (ManageBoards.php)
+ Ability to set a default language for a given board (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, ManageBoards.english.php, ManageBoards.template.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 30th, 2010, 10:59 AM
rev 428

! For a reason that escapes me, Opera suddenly stopped registering arrow key presses in the auto-suggest. Using the same trick as in IE worked, though. Also fixed the Enter key possibly triggering wrongly when keydown and keypress events are called in a row. (suggest.js)
! Fixed auto-suggest popup position not being adjusted if it results in the master input's position being modified. (suggest.js)
- There's probably a good reason to calling autoSuggestActualHide() at the start of populateDiv(), but I couldn't find it. Removing it solved most of the issues associated with auto-suggest animations. (suggest.js)
Title: Re: New revs
Post by: Nao on December 30th, 2010, 05:59 PM
rev 429

+ Added Media Gallery and Auto-embed Core Features placeholders. This totally won't work, of course. Just wanted to make a couple of icons for future use. (The Gallery one sucks, I know.) (ManageSettings.php, ManageSettings languages, images/admin/feature_*.png)
- Removed theme_postbox() as it's SMF 1.1 emulation code. (Subs-Editor.php)
! Add BCC link was incorrectly indented in IE. (PersonalMessage.template.php)
! PM settings page was broken due to using double quotes inside an inline event. (Profile.template.php)
* At registration time, autoDetectTimeOffset() was hardcoded into the template instead of retrieved from profile.js. (Register.template.php)
* More jQuery conversions. (Packages.template.php, Register.template.php, Themes.template.php)
! Fixed news fader to show readable text in IE6 and offer better minification. (fader.js)
! IE fixes. (admin.css, ie6.css)
* Mininazi. (script.js)
* Spacinazi. (Display.template.php, Post.template.php)

@ Note: Add BCC help link seems to be broken in IE. I couldn't figure out why so far... #helf seems to fail being added to $('body') in that situation. Other occurrences work fine. I'm stumped.
Posted: December 30th, 2010, 04:47 PM

rev 430

* French translation. (ManageBoards.french.php)
* Spacinazi. (Load.php, ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on December 31st, 2010, 12:04 AM
rev 431

+ Added a few separators in the admin menu, and made minor changes to item order. (Admin.php)
! Fixed cases where separators would appear at the beginning or end of a popup menu, or would have more than one separator in a row. (Subs-Menu.php)
- IE6 and IE7 don't support separators. Don't want to waste time on them. (ie6.css, ie7.css)
! Fixed IE6 not showing BCC help popup. (PersonalMessage.template.php, pm.js)
* Minor French language fixes. (Packages.french.php)
Title: Re: New revs
Post by: Arantor on December 31st, 2010, 10:08 AM
Revision: 432
Author: arantor
Date: 08:32:14, 31 December 2010
Message:
! Widen calendar events column (install.sql)
! Fix that bloody attachments handler even in IE (Post.template.php, editor.js)
----
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/other/install.sql

Posted: December 31st, 2010, 09:32 AM

Revision: 433
Author: arantor
Date: 09:08:05, 31 December 2010
Message:
! Added a couple of missing tables to the protected list and fixed a potential issue with the static property not being defined. (Class-DBPackages.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Title: Re: New revs
Post by: Arantor on December 31st, 2010, 12:58 PM
Revision: 434
Author: arantor
Date: 11:58:28, 31 December 2010
Message:
! Re-defer profile Javascript events from being inline since they have a dependency on jQuery (Profile.template.php)
+ Gravatar support (install.sql, Load.php, ManageAttachments.php, Profile-Modify.php, Subs.php, Admin.english.php, Help.english.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on December 31st, 2010, 01:07 PM
rev 435

+ Added some padding around menu separators through a minor hack. Way more usable now. (index.css, GenericMenu.template.php)
Title: Re: New revs
Post by: Nao on December 31st, 2010, 05:27 PM
rev 436

* Regex simplification. (Profile-Modify.php)
* strpos() is supposedly 20% faster than the equivalent substr() test... Whatever. (Subs.php)
* French translation. (LANGUAGES: Admin, Help, Profile)
* Spacinazi. (Profile.template.php)
Title: Re: New revs
Post by: Nao on January 1st, 2011, 03:06 PM
rev 437

* Rewrote menu separator system to be slightly more semantic and still save a couple of bytes, taking advantage of the fact that anchor tags now accept children divs. (GenericMenu.template.php, index.css)
! Fixed links not being transformed in the support area, because getServerVersions() overwrites the corresponding $txt entry. (Admin.php)
* Minor changes. (ie7.css, editor.js, Help.french.php)

Note: the menu separator will now use only one <li>, but extra <a> and <div>'s are used. All in all the final code is shorter though, and a bit more semantic. Also, the separator lines no longer extend to the full width of the menus. Which is more stylish, I think. (Can be overridden.)
Title: Re: New revs
Post by: Nao on January 3rd, 2011, 12:55 PM
rev 438

- [SMF bug] Removed toggleBBCDisabled() function, as it's a SMF1 leftover. (Admin.template.php)
! Fixed year variable not getting set. (Calendar.template.php)
! A few functions were added through add_js_inline() when they were better off in add_js(). (TEMPLATES: Admin, Calendar, ManageCalendar, ManageMaintenance, ManagePaid, Packages, Post)

(I tried figuring out what that function did, to no avail. Signature settings/BBC settings are separated and their disabled BBC tags are as well, and it doesn't break anything, so I don't see the point.)
Title: Re: New revs
Post by: Nao on January 3rd, 2011, 06:14 PM
rev 439

* Turned e-mail verification regular expressions into a proper function and simplified those that can't access it. (install.php, smf_api.php, Activate.php, Post.php, Post2.php, Profile-Modify.php, Register.php, SendTopic.php, Subs-Members.php, Subs.php)
* Split editor.js into two files: editor.js has the Wysiwyg editor, and post.js has all of the helper functions and objects that are also used outside of Wysiwyg mode. (Class-Editor.php, editor.js, post.js)
* Spacinazi. (ManageBans.php)
! E-mails can't have surrounding whitespace. They're trimmed as a test, they should be trimmed for the real deal too. (Profile-Modify.php)
* Changed menu separator to use the proper hr tag, and added basic support for IE6 and IE7. (ie6.css, ie7.css, index.css, GenericMenu.template.php)
* Slightly improved link colors as well as IE7/8's menu hover colors. (ie6.css, ie7.css, index.css)
Title: Re: New revs
Post by: Nao on January 4th, 2011, 12:49 AM
rev 440

+ Since stylings are powerful theme variations, they should be allowed to call custom CSS and JS. Moved main styling (Pastel)'s CSS and JS to settings.xml and added support for such customizations. Also added {root} variable to point to the current page's root folder, regardless of the subdomain. Useful for behavior and JavaScript URLs. (index.template.php, Subs.php, css/settings.xml)
* Spacinazi & to-do list. (ManageBoards.php, ManageSettings.php, QueryString.php)
* Pixelnazi. (index.css)
* Minor code cleanup. (PrettyUrls-Filters.php, QueryString.php, Subs-PrettyUrls.php)
- For optimization purposes, two globals were unset... Twice. Kudos, SMF. (QueryString.php)
Title: Re: New revs
Post by: Nao on January 4th, 2011, 12:53 PM
rev 441

- Main theme link in admin menu didn't require a custom URL. (Admin.php)
+ Added a hook for admin settings search. (Admin.php)
! Moved some jQuery code to the footer. (Themes.template.php)

(Giving up on moving Logs to their own menu for now... It worked, but it required rewriting many templates and I got bored after a while and cancelled all of my changes.)
Title: Re: New revs
Post by: Nao on January 4th, 2011, 11:14 PM
rev 442

- Removed unused headerpadding class, and board_permissions id. (Display.template.php, ManagePermissions.template.php)
! Fixed floatright in moderation reports. (ModerationCenter.template.php)
* Turned all <div class="title_bar"> blocks into <we:title> tags that are transformed back to title_bar at runtime. (ManagePaid.php, QueryString.php, admin.css, and all 24 templates in the list)
Title: Re: New revs
Post by: Nao on January 5th, 2011, 10:12 AM
rev 443

+ Implemented basic overrides for <we:> blocks through stylings. Use this format: <block name="title"><start>|<end></block> (Load.php, QueryString.php, Subs.php)

Note: this isn't to piss anyone off, all right? :P It's all a proof of concept. Can be reverted after all. Now the idea is that if someone wants to re-implement Curve without using JavaScript to inject custom tags (i.e. small delay before curves show up on first load), they can do it through this. While this MAY go in the future, I don't think there's any reason NOT to use this as of now, regardless of what happens in future versions. The things with </we:title> is that it can be automatically replaced to a </div> with a single multi-file search & replace (while the other way around isn't possible :P)
Title: Re: New revs
Post by: Arantor on January 5th, 2011, 05:36 PM
Revision: 444
Author: arantor
Date: 16:27:33, 05 January 2011
Message:
! Bug in email checking routine returning wrong answer (Subs.php)
+ Additional hook for behavioural checking (index.php)
+ Replacement image CAPTCHA code
 - Removal of old code including old lang strings (Subs-Graphics.php, VerificationCode.php, Subs-Editor.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php, install.sql)
 + Adding new code including auto detection (Subs-Captcha.php, captcha/*, Class-GifAnimator.php, plus all files mentioned above)
----
Added : /trunk/Sources/Class-GifAnimator.php
Modified : /trunk/Sources/ManageSettings.php
Added : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Added : /trunk/Sources/captcha
Added : /trunk/Sources/captcha/captcha-grid.php
Added : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-recomposeanim.php
Added : /trunk/Sources/captcha/captcha-recomposeanim_cycle.php
Added : /trunk/Sources/captcha/captcha-recomposeanim_cycle2.php
Added : /trunk/Sources/captcha/captcha-recomposeanim_shadow.php
Added : /trunk/Sources/captcha/captcha-silhouette.php
Added : /trunk/Sources/captcha/captcha-simpleanim.php
Added : /trunk/Sources/captcha/captcha-stripes.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql

Posted: January 5th, 2011, 05:28 PM

Revision: 445
Author: arantor
Date: 16:36:34, 05 January 2011
Message:
! Oops, forgot to make the animated CAPTCHAs respect the 'use animated' option (captcha-recomposeanim.php, captcha-recomposeanim_cycle.php, captcha-recomposeanim_cycle2.php, captcha-recomposeanim_shadow.php, captcha-simpleanim.php)
----
Modified : /trunk/Sources/captcha/captcha-recomposeanim.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle2.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_shadow.php
Modified : /trunk/Sources/captcha/captcha-simpleanim.php
Title: Re: New revs
Post by: Nao on January 6th, 2011, 11:48 AM
rev 446

! A new file was in CRLF format. Bugger. (post.js)
* CAPTCHA translation. (ManageSettings.french.php)
! Fixed message margins in topic splitter, and converted code to jQuery. (SplitTopics.template.php)
Title: Re: New revs
Post by: Nao on January 6th, 2011, 03:32 PM
rev 447

! Fixed logic error when logging errors. Apart from the bad pun, I'm going to start cursing Pretty URLs. There has to be a better way to do that... (Errors.php, ManageErrors.php)
Posted: January 6th, 2011, 03:14 PM

rev 448

! Actually, rev 447 was wrong: it can be even worse. This is the proof. (Errors.php)
! Fixed error count in the main menu when meeting a 404 error. (QueryString.php)
! Two years into it, and I'm still fixing bad French text... (Admin.french.php, ManageMaintenance.french.php, Profile.french.php)
Title: Re: New revs
Post by: Arantor on January 6th, 2011, 03:42 PM
Revision: 449
Author: arantor
Date: 14:42:02, 06 January 2011
Message:
! Updated internal Bad Behaviour checks to match changes in BB 2.1.8
 - Due to a PHP bug, DNS lookups can fail and not report failure properly, so disabled those checks for the time being. (Subs.php)
 ! Two new spammer user-agents, update of existing user-agent to prevent some (rare) false positives (Security.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on January 6th, 2011, 05:10 PM
rev 450

! Gravatar e-mails were never shown after they were recorded. (Profile.template.php)
! hr's were pointlessly styled. Probably leftovers from old themes. (admin.css, TEMPLATES: Admin, ManageBoards, ManageNews, ManagePaid, Packages, Profile, SplitTopics, Themes)
* Moved the Wedge logo code over to CSS, to make it easier to hide it or remove it via stylings. (index.css, index.template.php)

Note: is ['avatar']['name'] the best place to retrieve the gravatar:// link? I'm not sure. It's also stored in another place...
Title: Re: New revs
Post by: Nao on January 6th, 2011, 11:59 PM
rev 451/452

! Fixed Javascript for CSS editor preview (it even had a leftover of pre-getXMLDocument era!), but it's pointless as right now it supports neither stylings, nor CSS caching. Anyone up for fixing that? Uh? Don't be so shy. (Themes.template.php)
! More jQuery fixin'. (Profile.template.php)
! Fixed IE6 margins for hr's. Untested. (ie6.css)
- Leftover debug code. (Themes.template.php)
Posted: January 6th, 2011, 10:44 PM

I can't believe I've been spending the last few hours debugging the css editor, when I never knew this thing existed before today.... :^^;:
It's not working, but at least I've made some progress.
BTW Pete, I think the 'default board language' setting doesn't work. I mean it works, but I've noticed it overrides my very own default language. (i.e. I forced a board to English and even though my language is set to French, it showed in English.)
Don't have time to work on checking that myself.
Title: Re: New revs
Post by: Arantor on January 7th, 2011, 09:23 AM
Revision: 453
Author: arantor
Date: 08:22:42, 07 January 2011
Message:
! Syntax error in registration screen JS (register.js)
! strftime issues dates with 0 prefixes, which upsets Javascript, so send the Unix epoch in milliseconds to build server time from instead (Profile-Modify.php, Register.php, Profile.template.php, Register.template.php, profile.js)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/scripts/profile.js
Modified : /trunk/Themes/default/scripts/register.js
Title: Re: New revs
Post by: Arantor on January 7th, 2011, 09:49 AM
Revision: 454
Author: arantor
Date: 08:48:55, 07 January 2011
Message:
+ Add a hidden input box in all instances of the verification/CAPTCHA, which will be removed if Javascript is run, or at least hidden out the way, and if this box is submitted to the CAPTCHA receipt with content, kick it back. (Bots don't normally run JS, so won't remove it, but will typically populate it.) (Subs-Editor.php, GenericControls.template.php, index.english.php, index.css)
----
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on January 7th, 2011, 12:09 PM
rev 455

+ Added support for stylings in the WYSIWYG CSS editor. (Themes.template.php)
+ Implemented a way to disable CSS caching and showing links directly for admins. Needed by the above. (QueryString.php, Subs.php)
+ Can you believe I actually forgot to implement replace-type stylings...? Unfortunately, this forces Wedge to load settings.xml for all nested stylings, but there's obviously no workaround for that. (Subs.php)
* Made CSS preview box a bit taller (from 300 to 400 pixels.) (Themes.template.php)
* More inline JS moved to the footer. (Profile.template.php)

BUG: if you browse your website from within the CSS preview iframe, it seems like the LAST component in the query string is ignored. i.e. ?action=pm with bring you to the board index, and ?action=pm;sa=send will show you the PM front page. I've been unable to find the reason for this. But frankly, this is better than nothing. Pete, let's say it bluntly, I spent hours on fixing this feature I never saw before, and I'm totally pissed off by the number of issues I had to fix. I can live with that one. If you want to look into it, please be my guest because I just won't do it.

NOTE: not yet actually committed. We both modified Subs.php (the joys of Subversion...), so it won't let me commit until I'm up to date. I'll look at your changes now, but while I'm at it: is there any point in showing a box and hiding it via JS? I mean, users with JS disabled will have a problem with it, *and* anyone writing a bot to pass through the Wedge CAPTCHA *will* notice that anyway and simply prevent the bot from filling it any other inputs... No?
Posted: January 7th, 2011, 12:02 PM

Also: your strftime stuff... What exactly does it do and fix? Is that a bug that happens everywhere?
Title: Re: New revs
Post by: Nao on January 7th, 2011, 06:43 PM
rev 456

! When using gravatars, pages would no longer validate. Thankfully, Gravatar.com seems to support ";" URL separators, so no need to wonder about turning ampersands into entities. (Subs.php)
* Split index.css into index.css, guest.css and sections.css to make it easier to browse through the main file (guest.css is just here as a test.) (guest.css, index.css, sections.css, Load.php)
* Micro-optimization. (Class-Editor.php)
* Spacinazi. Mainly removed useless tabs. (captcha-*.php, Class-DB.php, Class-GifAnimator.php, ManageMaintenance.php, PersonalMessage.php, Post.php, Profile-Actions.php, Profile-View.php, Subs-Editor.php, MessageIndex.template.php, post.js)
Title: Re: New revs
Post by: Nao on January 8th, 2011, 06:57 PM
rev 457

* Some windowbg/windowbg2 classes were missing their system wrc class. Reviewing all files to determine if they can be added. WIP. (upgrade.php, Class-Editor.php, Subs.php)
* Started work on reordering cat_bar's against title_bar's. (Admin.template.php, Packages.template.php)
! $reservedTables was incorrectly declared as $reservedTypes, causing a crash. (Class-DBPackages.php)
! Wrong smiley variable was put to the cache. (Class-Editor.php)
! Crash in list_getNumSmileys(). (ManageSmileys.php)
! Who thought it was funny to resize the title's text at the same time as the live news box? (admin.css)
* Moved Add-on link to the bottom of its menu entry. OCD stuff. (Subs.php)
* Used shorthands on a few long CSS declarations. (index.css)
- Some useless styles on legend tags. (admin.css)
! Security French language wasn't in UTF-8 mode, causing issues when showing text. (Security.french.php)
* Spacinazi. (Dlattach.php, Errors.php, ManageMaintenance.php, ManageServer.php, ManageSmileys.php, Memberlist.php, Profile-Modify.php, ScheduledTasks.php, SendTopic.php, SplitTopics.php, Subs-Calendar.php, Subs-Post.php, MessageIndex.template.php)

Note: popup in the error log is buggy. If you click a filename, it opens the source code in a 800+px high popup, even though it's requested as a 400px high popup.
Title: Re: New revs
Post by: Arantor on January 9th, 2011, 04:59 PM
Revision: 458
Author: arantor
Date: 15:59:07, 09 January 2011
Message:
! Fix the translatable captions in DB-based bbcode. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on January 10th, 2011, 04:29 PM
rev 459

- Rewrote CSS hack for the WYSIWYG editor in IE to something that actually makes sense and takes 2 lines of code instead of 74. (Class-Editor.php, editor_ie.css, ie6.css, ie7.css, ie8.css, editor.js)
! A few popup windows were missing the UTF-8 attribute while $txt was being used in them. (Errors.php, ViewQuery.php, Errors.template.php)
! Validation error with IE6. (index.template.php)
* Keeping up with changing cat/title header logic where needed. (Admin.template.php)
* Avoid an error in reattribute posts feature, if JS is disabled. (ManageMaintenance.php)
* As always, \w is the winner when it comes to regular expressions. (Subs.php)
* More JS moved to the footer. (Errors.template.php, ManageNews.template.php)
* Minor changes. (QueryString.php, index.css, Post.template.php)
+ Added a smaller logo for use in the next styling. (minilogo.png) (not documented in the SVN, sorry.)

(Another one coming up...)
Posted: January 10th, 2011, 04:12 PM

rev 460

* Rewrote member maintenance area to use jQuery. Also fixed a few SMF UI bugs in that area. (ManageMaintenance.template.php)
* More JS code moved to the footer. (ManagePermissions.template.php)
! Code viewer in the error log was buggy. Fixed presentation with a dirty hack, I'm afraid. Compensated for the extra bytes by micro-optimizing strings in that function and using a jQuery hack found in its source code for cancelling event propagation. I'm clinically insane. (script.js)
! More French translation fixes. And I thought 2 months spent on that back in 2008 were enough... (Admin.french.php)
* Minor changes. (theme.js)
Title: Re: New revs
Post by: Nao on January 11th, 2011, 12:32 AM
rev 461

- Removed $settings['theme_version'], as it's a compatibility setting for SMF1/2. Will reimplement if ever needed... Probably not! (Subs-Menu.php, Subs.php, index.template.php)
- Removed other unused compatibility variables. (Subs.php)
* More jQuery conversions and, possibly, the final removal of inlined JS code. Yay! Only got AeMe code left to convert now... It'll come in time. (ManageMembergroups.template.php, ManageSearch.template.php, ManageSmileys.template.php, PersonalMessage.template.php, Register.template.php, Search.template.php)
@ The Membergroups stuff also had indentation bugs. And it used to be faster without jQuery. Ah, well. Can't have everything. (ManageMembergroups.template.php)
Posted: January 10th, 2011, 11:57 PM

rev 462

* The sweet taste of revenge. Or whatever. Just tweaked the search area to something a bit smarter. (Search.template.php)
Title: Re: New revs
Post by: Nao on January 11th, 2011, 05:03 PM
rev 463

* Slightly enlarged source code viewer in the error log. Since it can never be too large... (ManageErrors.php)
! Fixed undefined index error when viewing a subscription with no allowed groups. (Profile-Actions.php)
- Removed unneeded '-sections' from CSS file URLs. (Subs.php)
! Not sure why, but unlink() would sometimes fail on cache files, even if they're confirmed to exist. Stat cache anyone? (Subs.php)
* CSS editor font was too small. (Themes.template.php)
* More title/cat balancing. (Admin.template.php)
Posted: January 11th, 2011, 04:00 PM

rev 464

! Pages wouldn't validate if their title had an accent in it, because the charset was defined after the title. Silly... (index.template.php)
! Missing div broke validation. (Search.template.php)
Title: Re: New revs
Post by: Nao on January 11th, 2011, 11:52 PM
rev 465

+ Added support for cat bars as list headers. Dunno, it just felt like the only way to easily fix page logic... (ManageServer.php, Subs-List.php, GenericList.template.php)
! Fixed regression introduced in rev 440 that caused URLs to be incorrectly transformed when they had a page start value. (PrettyUrls-Filters.php)
* Micro-optimization for a preg_replace. Actually, this could be turned into a simple str_replace with a trick or two. Would probably be worth benchmarking. (QueryString.php, Subs.php)

(Sorry for the regression!)
Title: Re: New revs
Post by: Nao on January 12th, 2011, 10:21 PM
rev 466

* Renamed linktree classes to IDs and rewrote template to avoid using non-semantic code to show the arrows. (index.template.php, index.css, rtl.css, Nix/index.css)
* French translation. (ModerationCenter.french.php)
Title: Re: New revs
Post by: Nao on January 13th, 2011, 05:54 PM
This is to celebrate your return! :niark:

rev 467

* Cleaned up Pretty URLs. Removed some code that prevented using an URL twice (never happens because we're always specifying the topic ID), used variable references in foreach (we're in PHP5, let's use that), removed or commented out some Noisen-specific code, removed url_id from the URL table (this was never used), micro-optimized preg_match'es by doing strpos tests beforehand (should be twice faster if the test fail, and 30% slower if it passes. May need further testing.) (PrettyUrls-Filters.php, QueryString.php)
+ Added proper support for actions in Pretty URLs. Using format /do/action, waiting for the Actions rewrite to be completed before we move it to just /action or whatever. (PrettyUrls-Filters.php, QueryString.php)
+ Added proper support for profiles in Pretty URLs. Still a bit buggy, I believe. u= needs to be set right after the profile action. (PrettyUrls-Filters.php, QueryString.php)
- Removed debug code that didn't have the corresponding helper function (obsafe_print_r) anyway. (QueryString.php)
! The determine_location hook wasn't triggered if not inside a board. (QueryString.php)
* Replaced sesc= and sc= replacements with the proper session_var. If any sesc/sc is still in the code, it should be removed. I think. (QueryString.php)
! Fixed Pretty URLs not showing its load times, and moved that to the very bottom, to include other dynamic buffer replacements. (QueryString.php)
* Added some comments about various bugs or potential issues in Pretty URLs. (QueryString.php)
Title: Re: New revs
Post by: Nao on January 13th, 2011, 08:02 PM
rev 468

! Fixed ob_sessrewrite getting called twice. Against all odds, the ob_get_contents()/ob_clean() pair does trigger the current output buffer handler, even if it doesn't destroy it later. I'd be tempted to call that a PHP bug, but anyway, maybe I'm just too dumb to understand that logic. Worked around it by putting all of the debug info into a variable, and showing it at ob_sessrewrite time, rather than getting the existing buffer. (QueryString.php, Subs.php)
- Removed an unused url_id from redirectexit(). (Subs.php)
Title: Re: New revs
Post by: Arantor on January 14th, 2011, 10:15 AM
Revision: 469
Author: arantor
Date: 09:11:32, 14 January 2011
Message:
+ New CAPTCHA: ledicons-animated (captcha-ledicons.php, captcha-ledicons_anim.php)
----
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-ledicons_anim.php

Posted: January 14th, 2011, 10:11 AM

Revision: 470
Author: arantor
Date: 09:15:29, 14 January 2011
Message:
+ Optionally display flags on board indexes for board-specific languages (install.sql, BoardIndex.php, BoardIndex.template.php, MessageIndex.php, MessageIndex.template.php, Subs-BoardIndex.php, ManageBoards.php, ManageBoards.english.php, Help.english.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on January 14th, 2011, 10:30 AM
Revision: 471
Author: arantor
Date: 09:30:03, 14 January 2011
Message:
! Enforced 'allow guests to browse the forum' being disabled - guests have no access when that's off, so no permissions, no access to anything other than logging in.
 ! Enforce it for permissions, board access in SSI context and all SSI functions (SSI.php, Security.php)
 ! Hide guests group from all reports when access disabled (Reports.php)
 ! Hide guests option from board access (ManageBoards.php)
 ! Hide guests option from all permissions UIs (ManagePermissions.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Arantor on January 14th, 2011, 11:02 AM
Revision: 472
Author: arantor
Date: 10:01:48, 14 January 2011
Message:
! Fixing an undefined index in $context (Unreadreplies.php)
----
Modified : /trunk/Sources/Unreadreplies.php
Title: Re: New revs
Post by: Nao on January 14th, 2011, 01:08 PM
I tried to separate this commit in two, to make it possibly easier to review.... But it's definitely not possible to make them even. The big new features really span too many different files.

rev 473

! Fixed /~/ URLs to redirect to current user's profile. Yeah, I know... I should use /profile/ instead. (QueryString.php)
! Fixed pretty profile URLs as shown inside subdomains. (PrettyUrls-Filters.php)
* Rewrote guest reattribution area text to make it easier to understand. At least for me... (ManageMaintenance language files)
+ French translation. (Help.french.php, ManageBoard.french.php)

rev 474

+ Added a sidebar area. Only tested under the currently uncommitted styling. (BoardIndex.php, Subs.php, index.template.php, index.css)
* Rewrote the sub-template system to allow for mini-layers. (BoardIndex.php, Load.php, Subs.php, index.template.php)
* Reordered profile URLs to always show the 'u' component in second position. (Display.php, ModerationCenter.php, Profile-Modify.php, Profile-View.php, Profile.php, ScheduledTasks.php, Subs-Menu.php, TEMPLATES: Display, PersonalMessage, Profile, Who)
- Removed leftover code: main_below test in loadSubTemplate(), function description in Subs-Members, and outdated documentation in the index template. (Load.php, Subs-Members.php, index.template.php)
- Removed all *_my classes and instead used an additional 'my' class. This won't work in IE6, but my doctor said I shouldn't care. (Green/index.css, index.css, Nix/index.css, sections.css, MessageIndex.template.php, Recent.template.php)
! Renamed linktree ID to a class, to avoid validation issues. Thanks Pete for the reminder. (index.css, Nix/index.css, rtl.css, index.template.php)
Title: Re: New revs
Post by: Nao on January 14th, 2011, 05:15 PM
Again, splitting a commit in two for easier reference.

rev 475

* Renamed some $VARIABLES to $variables. (install.php, upgrade.php, Memberlist.php, PersonalMessage.php, Profile-Actions.php, Reports.php, ScheduledTasks.php, Stats.php)

rev 476

! Sidebar was going crazy in the default styling. (index.css)
! Fixed display pages not playing along with the sidebar. Will probably have to remove all of the clear states from the code. Yikes. (sections.css)
* Turned search field into type="search" and gravatar field into type="email"... Not that it's needed, but supposedly the fallback for non-supporting browsers is type="text", so it's the call of the future. Will need to change more input fields this way, obviously. Consider this a personal note. (index.template.php, Profile.template.php)
! Fixed ignored boards indentation (whatever) in Search, and applied fixes to Profile as well (forgot that one). (Profile.template.php, Search.template.php)
Title: Re: New revs
Post by: Nao on January 14th, 2011, 09:22 PM
rev 477

! Fixed menus showing stray or duplicate separators in some cases. (Subs-Menu.php)
* Added a minor optimization to CSS if an empty rule is found. Useful if we want to offer empty placeholders. (Subs.php)
! Fixed auto-suggest on pages where only one entry is requested. (suggest.js)
Title: Re: New revs
Post by: Nao on January 15th, 2011, 01:26 PM
rev 478

! Fixed htaccess to make it work with Pretty URLs when installed in a sub-folder. (other/.htaccess)
! Fixed undefined index if query string wasn't set. (Errors.php)
! Fixed clear issues in MessageIndex. (sections.css)
Title: Re: New revs
Post by: Arantor on January 16th, 2011, 05:28 PM
Revision: 479
Author: arantor
Date: 16:28:17, 16 January 2011
Message:
! If possible, save a query for getting last post's time for a thread (for whether it's old enough there should be a warning to user) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Arantor on January 16th, 2011, 05:38 PM
Revision: 480
Author: arantor
Date: 16:37:30, 16 January 2011
Message:
! Stray poll action cleaned up (index.php, Poll.php)
+ Imperative scheduled tasks now exist though UNTESTED (index.php, Load.php, Subs-Scheduled.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Poll.php
Added : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql


Of course, imperative scheduled tasks has a new table.
Title: Re: New revs
Post by: Arantor on January 16th, 2011, 06:46 PM
Revision: 481
Author: arantor
Date: 17:46:04, 16 January 2011
Message:
+ Provide option whether moved topics can only be moved into areas the user could theoretically create a new topic in, or any board they can see. (ManagePosts.php, MoveTopic.php, Admin.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Title: Re: New revs
Post by: Arantor on January 17th, 2011, 08:16 AM
Revision: 482
Author: arantor
Date: 07:15:57, 17 January 2011
Message:
! Remove unread since last visit, so unread just triggers all unread now. (index.english.php, index.template.php, Unread.php, Unreadreplies.php, Recent.template.php)
----
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on January 17th, 2011, 08:34 AM
Revision: 483
Author: arantor
Date: 07:33:54, 17 January 2011
Message:
! Recent posts was broken, oops (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Title: Re: New revs
Post by: Arantor on January 17th, 2011, 02:13 PM
Revision: 484
Author: arantor
Date: 13:13:23, 17 January 2011
Message:
! Sync to SMF rev 10323
 ! Prevent wildcard-only censoring (ManagePosts.php)
 ! Converted passwords not recognised when using double MD5 hashing (Login2.php)
 ! Removed <b> tags that shouldn't be there (Reminder.php, PersonalMessage.template.php)
 & Wrong URL destination in 'birthday_email' help popup (Help.english.php)
 ! Extended maxlength for event titles, but see below (Calendar.template.php, Post.template.php)

!! Not applied:
 * revs 10317 and 10318 to Subs.php for the hook functions since they were previously rewritten anyway and the changes don't really apply now.
 * rev 10316 - the maxlength of event title's textbox was upped from 70 (Calendar) and 60 (Post) to 255 to match the expanded field size, except that the field is subject to htmlspecialchars which can mean cropped entities. I've moved both to 80 for us, and the fields are now correctly sized as 255 in the schema (I missed one of them before)
 * rev 10318's "pedantry" to index.css to move the definition of .new_win earlier in the file and make it fit stylistically with all the other CSS declarations.
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on January 17th, 2011, 03:37 PM
(Sorry about the hiccups. Once again...)

rev 485

@ A few of the files will be in the next commit instead. (I've got a weird way of dealing with SVN conflicts.) (index.php, Display.template.php, Post.template.php)
* Renamed $actionArray to $action_list and turned it into a global (temporarily at least), to make it easier for Pretty URLs to differentiate between actions and board names. (index.php, QueryString.php)
! Fixed relative paths when caching CSS (they were broken after the cache was moved up to the root.) (Subs.php)
+ Added a function to automatically add browser prefixes to CSS3 extensions (currently border-radius, box-shadow and transition.) (Subs.php, index.css, Nix/index.css, rtl.css)
- Started removing input_* and button_* classes, which are only useful to IE6, and added fallbacks for a couple of these in IE6 (which will probably be removed in the end.) (ie6.css, ie7.css, rtl.css, sections.css, settings.xml)
* More type="email" and adding some required fields. Also cleaned up some code and started simplifying form elements. (TEMPLATES: Display, ManageBans, Post)
* Now we can safely remove cols attributes from textareas, right...? (ManageNews.template.php)

rev 486
* in_array stuff and spacinazi. Don't mind me. Again this conflict issue. (Class-Editor.php, Load.php)

rev 487
@ Committing the rest. (index.php, Display.template.php, Post.template.php)
* French translation. (Admin, Help, index)
Posted: January 17th, 2011, 03:22 PM

Forgot to document the fact that I fixed a IE6 bug in that width:100% on any child of #main_contents broke the page. Putting hasLayout on #main_contents fixed that.
Title: Re: New revs
Post by: Arantor on January 18th, 2011, 11:24 AM
Revision: 488
Author: arantor
Date: 10:24:12, 18 January 2011
Message:
! PM unread indicator shouldn't be set twice (Subs.php)
+ Ability to mark PMs as read (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Title: Re: New revs
Post by: Nao on January 18th, 2011, 02:54 PM
rev 489

+ Added a CSS file parser that allows for plenty of nice things like nested selectors. (Class-CSS.php, Subs.php)
* Converted sections.css to use nested selectors; saved 2KB in the process. Started basic work on the index file. (index.css, sections.css)
* Now you can actually call your styling folder 'css', or whatever. (Subs.php)
* Spacinazi. (Class-Package.php)
Title: Re: New revs
Post by: Arantor on January 18th, 2011, 04:25 PM
Revision: 490
Author: arantor
Date: 15:24:41, 18 January 2011
Message:
! Sync to SMF 10336
 ! The value of checkbox custom fields were displayed incorrectly on topic display. (Load.php, ManageSettings.php)
 ! Paid subscriptions scheduled taks should be disabled when paid subscriptions feature is disabled. (ManageSettings.php, install.sql)
 & Unclear help strings for post unapproved replies and attachments permissions. (ManagePermissions.english.php)
 & Outdated information in calendar help string. (Help.english.php)
 ! The check for empty body on personal message body failed in some cases. (PersonalMessage.php)
 ! Calendar maximum year was not adjusted on forums upgraded from older versions. (Updated from 2016 to 2020 in installer) (install.sql)
 ! Member approvals did not take account deletion requests into account when registration method is not set to member approval. (ManageMembers.php, Subs.php)
 ! News items now get HTML encoded as they should be. (ManageNews.php, Admin.english.php)

!! Not applying:
 ! rev 10328: WAP template being called from Post.php; we don't have the WAP template any more thus the code does not apply to us.
 ! revs 10333-10335: SSI permissions have been fixed in SMF, by checking a new variable and if not found, booting back to the login page. Interesting approach, if a little blunt... anyway we already did our own. There is a change to side padding in SSI examples in 10334 but I figured we'd redo that anyway...
 ! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql


(This was ALL done by Sinan last night. Guy's a legend it seems.)
Title: Re: New revs
Post by: Nao on January 18th, 2011, 05:47 PM
Quote from Arantor on January 18th, 2011, 04:25 PM
! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
What did they link to instead?
So, they're dropping their awful help section for good? They should have done that much earlier...
Quote
(This was ALL done by Sinan last night. Guy's a legend it seems.)
I'm not sure what you mean by that?
Sure, it's nice that someone in the dev team has woken up -- but what's been done here accounts for about 10 kilobytes at most... I think I've done more today, and I'd even venture into saying that my daily average is actually better than that... Not to mention yours.
Anyway! :^^;:

rev 491

+ Added $context['bottom_linktree']. If set to true, the linktree will also be shown at the bottom of the page. Probably a tiny bit more flexible than the SMF implementation...? (TEMPLATES: Display, MessageIndex, index)
* Pretty much finished converting index.css to use nested selectors; saved 1.2KB. (index.css, guest.css)
* CSS parser optimizations. (Subs.php, Class-CSS.php)
* French translation. (Admin, Help, ManagePermissions)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 08:57 AM
Revision: 492
Author: arantor
Date: 07:57:21, 19 January 2011
Message:
! Sync to SMF 10337
 ! Integrated output buffers can now use static functions in classes (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 10:44 AM
Revision: 493
Author: arantor
Date: 09:44:10, 19 January 2011
Message:
! Make auto suggest extensible through hooks, and make the registration check also check that a function is truly callable as opposed to merely existing (Suggest.php)
----
Modified : /trunk/Sources/Suggest.php
Title: Re: New revs
Post by: Nao on January 19th, 2011, 12:01 PM
rev 494

! Technically, trim() doesn't work on arrays. There was also one too many trim(). (Subs.php)
* Sometimes, I wake up and I want to micro-optimize a useless function. That's who I am. Genius has got its downsides. (post.js)

(Bigger one coming up.)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 12:36 PM
Revision: 495
Author: arantor
Date: 11:36:22, 19 January 2011
Message:
! Restructure the post template into smaller chunks. (Post.template.php)
----
Modified : /trunk/Themes/default/Post.template.php
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 01:14 PM
Revision: 496
Author: arantor
Date: 12:14:07, 19 January 2011
Message:
! Scheduled tasks (regular and imperative) threw errors in browsers since the content was being requested as an image and returned in text/html MIME type (ScheduledTasks.php, Subs-Scheduled.php)
! Little tidying up of actions (index.php, Announce.php, SendTopic.php, Reporttm.php)
----
Modified : /trunk/Sources/Announce.php
Added : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on January 19th, 2011, 01:32 PM
rev 497

! Images were loaded from the wrong relative URL. (sections.css)
* Moved all opening curly brackets to the end of the rule definitions in CSS files, where it wasn't already the case. Only for consistency. (editor.css, ie7.css, ie8.css, install.css, report.css, rtl.css, webkit.css, wireless.css)
* Finished converting css files to use nested selectors. (admin.css, ie6.css, ie7.css, ie8.css, install.css, Nix/index.css, rtl.css, wireless.css)
@ Currently using table layouts in the uncommitted Warm styling... Let's just say it feel very hackish. :(
@ Need to rewrite the installer to convert index.css and install.css before using them... :-/

I have a feeling that we'll reach rev 500 today... :)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 01:35 PM
Revision: 498
Author: arantor
Date: 12:34:42, 19 January 2011
Message:
! Instead of trying to cache individual news items, let's be smart and cache the entire, bbc-parsed news item list in a single hit, saving a call to parse_bbc for every news item nearly every page. (ManageNews.php, Subs.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Subs.php


Easily, I should think :)
Title: Re: New revs
Post by: Arantor on January 19th, 2011, 02:14 PM
Revision: 499
Author: arantor
Date: 13:13:59, 19 January 2011
Message:
! Made constant variable injection (e.g. {db_prefix}, {query_see_board}) into query engine extensible without any modifications to Class-DB being required by modders. (Class-DB.php, Load.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Nao on January 19th, 2011, 02:45 PM
rev 500

+ Added basic support for OK and Cancel icons in submit buttons. It's only an example... (index.css, cross.png, tick.png)
* Dropped float-based sidebar in favor of a display:table system. Seems to work much better but it feels too hackish, and doesn't support IE6/7 (for now.) (index.css, index.template.php)

Champagne !

(And given it took me half an hour to analyze your latest commits[1] and finish up this one, I was expecting this to be rev 505 or so :P)
 1. Great stuff, as always!
Title: Re: New revs
Post by: Nao on January 19th, 2011, 03:50 PM
rev 501

- Remove media-specific query_see_* declarations, as they're in the (as yet uncommitted) media source files now. (Class-DB.php)
+ Added the Warm styling. Even though it's still a work in progress, there's really no reason to keep it away from the repository. (Warm/*)
! Fixed the Green styling. A bit. (Green/index.css)
Title: Re: New revs
Post by: Nao on January 19th, 2011, 06:17 PM
rev 502

- Removed all input_* classes, fixed many typos in that area, shortened checked/selected/disabled and basically used HTML5 goodness to simplify everything. button_* will come later. (68 files. Not gonna list them all!)
Title: Re: New revs
Post by: Nao on January 19th, 2011, 09:55 PM
rev 503

* Started work on button_submit conversions. Yes, I'm slower than earlier today. (install.php, SSI.php)
* Turned all string calls in setTimeout to proper function calls. Death to eval! (create_backup.php, repair*.php, restore_backup.php, upgrade.php, Load.php, TEMPLATES: Admin, Announce, ManageMaintenance, ManageNews, ManageSearch, Packages, Profile, Themes)

Thanks to w3fools for the tip on JS... I didn't even know it was possible and it pissed me off when I made the original reworking for jQuery. I never realized SMF used proper functions at some (rare) points.
Title: Re: New revs
Post by: Nao on January 20th, 2011, 12:02 AM
rev 504

+ Added a new button class, save, which should be semantically appropriate for a lot of areas, beginning with drafts. Also added spell class but it's unstyled for now. (Class-Editor.php, icons/save.png, Profile.template.php)
+ Styled search-type inputs. Dunno if it's a good idea to always show that icon in the header, though. (Admin.template.php, index.template.php, index.css)
! Inherited stylings didn't correctly reproduce the <we:> templates. (settings.xml)
* More abuse of the simpler, shorter HTML5 tag format. (index.template.php)
* More button conversions. And yes, I know, it still all looks ugly... And the Cancel button is broken, now. (index.css, Profile.template.php, Themes.template.php)
! The W3C Validator for HTML5 suddenly started giving errors on the JavaScript code in the debug footer, saying "invalid return". I'm sorry, man, but return false is totally justified here. Ah, well. Went back to SMF's way of doing it (javascript:void(0)). (Subs.php)
! Fixed an undefined offset error in the admin quick search. (Admin.php)
* Inpunazi. (install.sql)
Title: Re: New revs
Post by: Nao on January 20th, 2011, 11:39 AM
rev 505

* Added 'delete' and 'new' input buttons, converted some more button-heavy templates and resumed <we:> transforms. (Admin.template.php, ManageBoards.template.php, ManageMaintenance.template.php, index.css, add.png)
! Fixed the Cancel button and added a small 3D effect. Not as visible as in SMF, though. But they don't have icons in buttons. (index.css)
+ Added proper (temp?) hack for display:table in IE6 and IE7. May I say one word? "Ewwwwwwwwwwwwwwwww." (index.template.php)
* Made core feature boxes slightly larger. Even IE6 seems to accept 50% here, so why bother. (admin.css)
! Fixed a potential XML error when parsing CSS under IE. (Class-CSS.php)
! An input_* class had escaped me. Rats! (Display.php)
! Commenazi. (Subs.php)
Title: Re: New revs
Post by: Arantor on January 20th, 2011, 12:34 PM
Revision: 506
Author: arantor
Date: 11:32:46, 20 January 2011
Message:
! Move draft post settings into their own little menu (Admin.php, ManagePosts.php, Admin.english.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/languages/Admin.english.php


I like the revision to the buttons - they're back to being as 3D-ish as they were before IMO, but the rounded corners are a nice touch.

The only search type input I see that's affected is the one in the admin panel, but that's not looking right anyway.
Title: Re: New revs
Post by: Nao on January 20th, 2011, 05:06 PM
rev 507

* Fixed form inside the h3 tag. The div will be fixed once we:cats are written to use something more flexible. Or whatever. (Admin.template.php, admin.css, rtl.css)
+ Added a white bevel inside buttons (only for modern browsers.) If you can spot the difference without zooming, you don't need glasses. It's only a test. (index.css, bevel.png)
! Safari and Chrome don't like CSS on search-type inputs. Thankfully, they provide a workaround for that... (webkit.css)
* Some more conversion work. (PersonalMessage.template.php)
* French translation. (Admin.french.php)
Title: Re: New revs
Post by: Arantor on January 20th, 2011, 05:56 PM
Revision: 508
Author: arantor
Date: 16:56:19, 20 January 2011
Message:
! Length parameter should have been in the truncate function (Class-String.php)
----
Modified : /trunk/Sources/Class-String.php
Title: Re: New revs
Post by: Nao on January 21st, 2011, 04:29 PM
rev 509

* Finished remodeling buttons in a way that I actually appreciate. Also added a workaround to see icons in IE -- they will have to be moved to the semantically more relevant ie*.css when the number of icons has stabilized. (index.css)
* Replaced button icons with a single sprite and provided an original copy (for modifications) and a copy processed through "pngquant -nofs 64" (to save bandwidth.) (buttons.png, buttons-32bit.png, add.png, cross.png, save.png, tick.png, index.css)
- Removed the original button background. Nothing that can't be replaced with a bevel (4 times smaller). IE? Screw IE. (submit_bg.png)
* Continuing we:cat transforms and button class additions. (Display.template.php, PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on January 21st, 2011, 07:26 PM
rev 510

+ Added very preliminary (and thankfully short) code to automatically switch between sidebar and jumbo footer depending on the window width. Jumbo footer isn't styled at all. (index.template.php)

(Just to get that out of my way... :P)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 01:07 AM
rev 511

* Started converting < br /> to < br> in the code logic. Well, hopefully it won't screw it up... (install.sql, Profile-Modify.php)
* Continuing work on simplifying self-closing tags, replacing button classes and transforming <we:cat>s. I don't even known why I'm doing all of these manually. (sphinx_config.php, create_backup.php, repair.php, Profile-Modify.php, Profile.template.php)
! Fixed png backgrounds in Nix for IE6. (Nix/ie6.css)
* Indenazi. (Profile.template.php)

Going to bed... Leaving you the very geeky rev 2^9 ;)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 03:49 PM
Okay, well apparently I'm getting 2^9 too :P Too many changes to leave them hanging. Don't worry, you can safely update your svn without checking everything, I double-checked all br and hr conversions.
Also forgot to mention that I added more <we:cat>s and button classes, as usual. (In Search)

rev 512

! The Search menu item shouldn't have submenu entries if simple search is disabled. (Subs.php)
* Turned < br /> into < br> on all template and language files. Also did it for < hr> and class'ed variations. I know, it's a bit scary when you're using to XHTML... But it saves a whooping 1.6kb of template code. What do you mean, "who cares?" (All templates but 8 (should make sure no XHTML templates are touched), most language files, spellcheck.js, settings.xml)
! Fixed a small issue with the dynamic sidebar in IE. Might be useful for other browsers, too. (index.css)
! Button icons were incorrectly positioned in simple search mode. (sections.css)
* Updated Warm styling to the recent template changes. (Warm/admin.css, Warm/index.css, Warm/webkit.css)
Posted: January 22nd, 2011, 02:28 PM

rev 513

! Fixed <we:cat> not being converted in the default styling. Oops, that's what happens when you never use it... (Load.php)
* Continuing we:cat, button_submit and self-closing tag conversions. Statistics: 729 self-closers, 268 cat_bars and 79 button_submits left to convert... And that's only in the templates. Someone help me please, I'm gonna drown. (TEMPLATES: Announce, Calendar, Errors, Login, Memberlist, MessageIndex, ModerationCenter, Themes, Who, sections.css)
* Moved #sidebar to a semantically more logical place in index.css, and added vertical-aligns, even though it should already be the default one. You never know. (index.css)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 04:58 PM
rev 514

- Removed a bunch of useless ' . ' (no need to concatenate two strings like that...) (repair_settings.php, Load.php, ManageSmileys.php, Packages.php, Search2.php, Subs.php, Themes.php, BoardIndexInfoCenter.template.php, Memberlist.template.php)
* Simplified a serious amount of hacks regarding \<\? and such, replaced br regexes with stronger ones, continued HTML5 conversions and the usual crap. (Admin.php, Class-Package.php, Load.php, ManageRegistration.php, Packages.php, PersonalMessage.php, Post.php, QuoteFast.php, Themes.php)
! Here's a funny regex. "Look for anything that isn't >. Then, look for something that isn't /, followed by >. But if there's no /, it's still okay." Can someone tell me why they're looking for / at all?! Just leaving out the "it's still okay" portion, because it makes sense to prevent the / at the end in script and style tags because they're not self-closing. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 07:25 PM
rev 515

* The commit that may make or break Wedge... Self-closing tag conversions for the entire Sources folder. Also converting button_submit classes and the usual rest. (Announce.php, Class-DB.php, CoppaForm.php, Display.php, Errors.php, Groups.php, Load.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManageRegistration.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Packages.php, PersonalMessage.php, Post2.php, Profile-View.php, Profile.php, QuoteFast.php, Reminder.php, RemoveTopic.php, Reports.php, Search2.php, Security.php, SplitTopics.php, Subs-Auth.php, Subs-BoardIndex.php, Subs-Menu.php, Subs-Package.php, Subs-Post.php, Subs-Recent.php, Subs.php, Subscriptions-PayPal.php, Unread.php, Unreadreplies.php, ViewQuery.php, Who.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2011, 10:23 PM
rev 516

* Using non-xhtml version of nl2br (thanks Pete!) (install.php, restore_backup.php, upgrade.php, Class-DB.php, ManageMail.php, Packages.php, Subs.php, ViewQuery.php)
! Finished a regex conversion which I'd forgotten in the last rev. (Packages.php)
! Fixed an SMF bug with strong tags not being taken into account. (Themes.php)
+ Added left and right classes for img tags. Not used for now. (index.css)
* Self-closing tags. (install.php, restore_backup.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2011, 06:30 PM
rev 517

* Finished HTML5 conversion work, w3:cat and button_submit transforms. Ahhhhhhh!!! (create_backup.php, test_modification.php, repair*.php, Load.php, Admin.english.php, Admin.french.php, editor.js, script.js, suggest.js, topic.js, TEMPLATES: Admin, Announce, BoardIndex, BoardIndexInfoCenter, Display, GenericControls, GenericList, GenericMenu, Help, Login, ManageAttachments/ Bans/ Calendar/ Mail/ Maintenance/ Membergroups/ Members/ News/ Paid/ Permissions/ ScheduledTasks/ Search/ Smileys, ModerationCenter, MoveTopic, Notify, Packages, PersonalMessage, Poll, Post, Printpage, Recent, Register, Reminder, Reports, Search, SendTopic, SplitTopics, Stats, Themes, Who)
! Missed one search input conversion. (Search.template.php)
! Typo. (Search.english.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2011, 08:50 PM
rev 518

+ Added support for CSS variables, as well as the ability to set their values depending on the current CSS state (browser, rtl, login...) (Class-CSS.php, Subs.php)
+ Added ability to supply a member.css file for logged in users. (Load.php)
+ Added the following default CSS variables: $images, $theme, $root and $here. (Subs.php)
* Renamed {root} to $behavior in settings.xml, to make it easier to understand, in light of the new CSS variables. (Subs.php, settings.xml)
* Tweaked Nix header settings for a less dark outcome. (Nix/index.css)
! The dynamic sidebar doesn't work in IE6 and IE7. Tweaked the code to at least avoid error messages at startup. Will require a deeper rewrite later, though. (index.template.php)
! Fixed a couple of wrong URLs and added a sample variable to the Warm styling. (Warm/index.css)
- Removed relative path fixer, as it was no longer needed. (Subs.php)
- Removed h3.grid_header, as it's never used anywhere. (admin.css)
* Rewrote button hack for IE6 in Pastel. Now it should actually work. (ie6.css, settings.xml)
* Rewrote CSS files to use $images instead of relative paths. (admin.css, editor.css, settings.xml, index.css, rtl.css, sections.css)

(Phew!!! At last, finished with the big commits :))
Posted: January 23rd, 2011, 08:45 PM

rev 519

* Fixed a few inverted rules and added a newline to the beginning of all CSS files (for consistency.) (css/*.css)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 12:15 AM
rev 520

! Fixed a SMF bug: a deletion confirmation was apparently only asked... if the entered data was invalid in the first place. (ManageSearch.template.php)
! Fixed a Nao bug: autoSetup() was broken during the conversion to jQuery. (register.js)
* Converted most of the remaining stray getElementById's in inline events. Left aside the ones that can't use jQuery, and those that are in loops. (Calendar.template.php, ManageMembergroups.template.php, ManageSmileys.template.php, MoveTopic.template.php, Profile.template.php, Register.template.php, post.js, register.js, script.js, suggest.js, topic.js)
* Converted admin.js to jQuery... Yes, apparently I'd missed the file. (admin.js)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 10:17 AM
rev 521

+ Added ability to add double quotes around CSS variables (allowing empty strings to be set), and recursive replacements to allow using variable names inside other variable definitions. (Class-CSS.php)
* Updated button code to provide IE fixes for IE only. (index.css)
* Backported Warm changes to Pastel. (index.css)
+ Added a proper member-only file to both Pastel and Warm. (member.css)
* Styled Remove button in the post attachment area. (post.js)
! Fixed bevel in Simple Search area's search button. (sections.css)
! Typo. (admin.js)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 04:31 PM
rev 522

+ Added very basic support for CSS functions, starting with darken() and lighten(). They don't even take luma coefficients into account, ah ah, what a noob! (Class-CSS.php, Subs.php, index.css)
* In Post pages, show the original post's title in linktrees under square brackets and without extra spacing. Looks a tad better this way. (Post.php)

(Class-CSS adds a few functions from the PHP port of Sass -- I will end up using them, and I credited the originals, even though they're quite short and not exactly rocket science for anyone interested in RGB vs HSL.)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 08:41 PM
Trying to change my mind after my complete and utter failure in RL... :(

rev 523

! Fixed SMF bug (how many SMF bugs have we found these last few months really?!), where the second JavaScript block in constructPageIndex wasn't updated to use JavaScriptEscape, resulting in (1) a small waste of time, (2) a fully visible incorrect URL, resulting in Google being able to fail on it. (Subs.php)
* Moved inline styling to the correct place. (Subs.php, index.css)
* Simplified titles and categories in Warm. (Warm/index.css, Warm/settings.xml)
Posted: January 24th, 2011, 08:39 PM

rev 524

! Woops. (Subs.php)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 09:23 PM
rev 525

+ Rewrote darken/lighten to use a more realistic HSL transform, and added support for saturize(), desaturize() and hue(). Yeah baby. Tell me it sends shivers down your spine. (Class-CSS.php, Warm/index.css)
Title: Re: New revs
Post by: Nao on January 24th, 2011, 11:24 PM
rev 526

+ Added support for base64 encoding of images for non-IE browsers. Heck, it actually works, *and* compresses to the same size as usual... I don't even know if it's worth adding a setting to disable it... (Class-CSS.php)
! Fixed wrong hex encoding for RGB components lower than 16. (Class-CSS.php)
+ Added support for nested functions (darken(desaturize($color, 10), 10)) (Class-CSS.php)
Posted: January 24th, 2011, 11:09 PM

rev 527

! IE6 and IE7 don't support data URI schemes. Bad IE. (Subs.php)

@ Also of note: if you update an image, you need to also empty the cache or update a css file because Wedge won't guess it by itself... Seriously, I'm not checking all of these files on every page load!
Title: Re: New revs
Post by: Nao on January 25th, 2011, 05:41 PM
rev 528
(26 files, 31kb transferred)

! JPG images should have a MIME type of image/jpeg, not image/jpg. (Class-CSS.php)
* Minor changes. (Subs.php, latest-packages.php)
* Optimized CSS to only load some repeated images once. The size savings are better than I expected. (index.css, sections.css)
+ Added 'search' and 'cancel' classes to related inputs, to make it faster to find them (and avoid using some JS in IE.) There weren't a lot of them anyway. There's also one in Display but I'll commit it later. (sections.css, settings.xml, TEMPLATES: Admin, index, ManageAttachments, ManageBoards, Memberlist, PersonalMessage, Profile, Search)
! Fixed title_bar and cat_bar to title and cat classes. (Warm/admin.css, ie6.css, ie7.css, index.css, rtl.css, sections.css, webkit.css)
! Fixed icons, button padding and general handling of inputs for IE. (ie6.css, ie7.css, ie8.css, index.css)

PS: I'll try, from now on, to indicate the stats given by TortoiseSVN after I'm finished committing. This should make it easier to determine the amount of data you'll have to check. ;)
Title: Re: New revs
Post by: Nao on January 25th, 2011, 11:48 PM
rev 529
(1 file, 7kb)

! Fixed SMF bug: clicking frenetically the Quick Modify button at load time could result in errors and UI glitches. Fixed by only setting the edit mode as active after the actual original message is received. (topic.js)
* Let's just make this clear: if I'm editing a post, and I'm suddenly clicking the Quick Modify button for it, IT'S PROBABLY NOT WANTED. Cancelling any such actions. If you want to start a message over, use the Cancel button and then click Quick Modify. (topic.js)
* bInEditMode was redundant, using sCurMessageId now. Also replaced in Display.template.php, will commit later. (topic.js)

(It may not be the best fix, if only because I'm not even sure it fixes it, but it certainly works great in IE6 and Opera 11, where I tested, and it's a clean and short solution, as mentioned before.)
Title: Re: New revs
Post by: Nao on January 26th, 2011, 11:15 AM
rev 530
(12 files, 13kb)

! Fixed a SMF bug: if the outbox isn't empty, people should still be able to view it, even if they can't send *new* PMs. (PersonalMessage.php)
+ Added a message saying "A response to this message was sent." if you're viewing your outbox and at least one of the recipients replied to a message. This was way overdue... (PersonalMessage.php, PersonalMessage.english.php, PersonalMessage.french.php, PersonalMessage.template.php)
- Removed mentions about forwarding in "You have responded to this message". It was confusing. Whether you reply to the original poster or to someone else is your own choice, but it's not proper "forwarding". PMs are often private and this shouldn't be encouraged too much. (PersonalMessage.english.php, PersonalMessage.french.php)
! Fixed a variable collision due to a micro-optimization in smc_saveEntities. (script.js)
! Fixed a small IE6 layout issue in topic pages. (Display.template.php)
! Fixed potential browser errors if you're trying to access the quick modify or quick reply areas before they're actually initialized. Which should only happen if you're trying hard at doing it, really. (Display.template.php)
* A few !!!SLOW comments were converted to !!! SLOW. I just can't live with the idea of missing spaces. (Memberlist.php, PersonalMessage.php, Profile-View.php, Recent.php, Subs-Boards.php, Subs-Recent.php)
* Spellinazi -- 'accessable'. Urgh. (readme_convert.html, Subs-Recent.php)
Title: Re: New revs
Post by: Nao on January 26th, 2011, 03:55 PM
rev 531
(8 files, 14kb)

+ Added ability to see the number of users who replied to a PM in the event of a mass PM. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php, PersonalMessage.french.php)
! A regression in last commit concealed PM recipients in the inbox. (PersonalMessage.php)
! In the CSS parser, any hex RGB output could be corrupted by incorrect numbers, and didn't round numbers correctly. (Class-CSS.php)
* Don't add the 'o' prefix to Opera files when parsing box-shadow and border-radius. Ah ah, what a weird hack... (Subs.php)
* Modified comment stripping to actually keep comments starting with /*!, just like when parsing JS files. (Class-CSS.php, Subs.php, Warm/index.css)
* Disabled double clicks on the Quick Modify buttons. I need help, now. (Display.template.php)
Posted: January 26th, 2011, 03:18 PM

rev 532
(4 files, 15kb)

+ Added a Spellchecker icon of my making. (index.css, buttons.png, buttons-32bit.png)
Title: Re: New revs
Post by: Nao on January 26th, 2011, 10:25 PM
rev 533
(3 files, 6kb)

! Fixed toggler glitch where if the starting position was collapsed, the block would open and then animate to disappear. Uh. (script.js)
- Started removing nocsscache code... It's neat and all, but the CSS previewer is going away. Bye bye, we won't miss you that much, you can't fight the goodness that is CSS parsing. (QueryString.php, Subs.php)
+ Added a 'dynamic_rewrite' hook in ob_sessrewrite, to allow manipulating the buffer before the URLs are handled by the Pretty URLs module (the output buffer hook system happens *after* they're transformed, so it was really needed.) (QueryString.php)

(Toggler bug was visible in the news fader area on the board index, btw.)
Title: Re: New revs
Post by: Nao on January 27th, 2011, 09:30 AM
rev 534
(7 files, 13kb)

! Fixed the dreaded 'This address is already in use' that Pete hated so much. Eheh. (Subs-Boards.php, Subs-PrettyUrls.php)
! Translation errors or improvements. (ManageBoards.french.php, Themes.english.php, Themes.french.php)
Title: Re: New revs
Post by: Nao on January 27th, 2011, 04:35 PM
rev 535
(3 files, 12kb)

+ CSS parser now sports support for: alpha function (alpha(rgb(255,255,255), -.25) returns rgba(255,255,255,.75) if the browser supports it), named colors (the 16 basic HTML ones plus 'grey' for Pete's sake), hsl, hsla, rgba, mixed case, and 3-letter hex codes. PHEW! (Class-CSS.php)
* In case of a syntax error while parsing CSS, you'll get a big red color instead. That should tell you where to look... (Class-CSS.php)
! Since HTML5 is case-insensitive, inline event tags should be as well. (QueryString.php)
! &quot; is automatically turned into a double quote inside inline events, but this is not the case outside of these. Converting them manually. (QueryString.php)
! Fixed the very annoying bug where newlines in JavaScript alerts/confirms were shown in plain text as \n. Oh, this one was annoying. (QueryString.php)
* Dotnazi. (Profile.english.php)
Posted: January 27th, 2011, 04:22 PM

BTW, some friends are visiting in a few minutes so I'll probably be offline for the entire evening. ;)
Title: Re: New revs
Post by: Nao on January 28th, 2011, 12:05 PM
rev 537
(23 files, 78kb, mostly clean-up though)

+ The CSS parser now accepts variable names with a dash in them (they're supported in class names so why not vars?), and now limits the maximal filesize for data inclusion to 4KB, because it really shouldn't accept more, technically and ethically. (Class-CSS.php)
* Loaded all CSS files together before calling the CSS parser. This improves performance by about 20% here. (Subs.php)
- Removed a few unused strings in the Install language files, as well as many &nbsp;'s found in alert or confirm boxes. JavaScript doesn't like that. Also did minor tweaks. (LANGUAGE: Install, ManageBoards, ManageCalendar, ManageMaintenance, ManageSmileys, ModerationCenter, PersonalMessage, Profile, Search, Themes)
! Some of the new files were in CR-LF format. Okay, I've added to my to-do-list that I should quit all of my Notepad2 windows and change the default format to LF. It has to work at some point hasn't it? (guest.css, ie8.css, member.css, sections.css)
* Layout tweaks to the moderation report viewing page. (ModerationCenter.template.php)
Title: Re: New revs
Post by: Arantor on January 28th, 2011, 12:18 PM
Revision: 538
Author: arantor
Date: 11:17:30, 28 January 2011
Message:
! Updated bundled Bad Behaviour install to 2.1.10, involving:
 + Add less hackish proxy support (Admin.php, Admin.english.php, ManageServer.php, ManageSettings.english.php, Help.english.php, QueryString.php, Security.php)
 ! Test for Yahoo's bot should have been included before but was overlooked, but at least I translated that one into French, even my rusty language skills could do that! (Security.php, Security.english.php, Security.french.php)
 ! Rejigged the tests for Google, MSN and Yahoo to test the IP against the known netblocks first (again, originally part of BB anyway) (Security.php)
 ! Confirmed licence notes for BB as being LGPL 3.0 and included a good-faith note regarding our lack of inclusion of the GPL and LGPL licence files. (QueryString.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/Themes/default/languages/Security.french.php
Modified : /trunk/other/install.sql


I implemented the UI back into the original admin panel for now simply because I'm still trying to figure out where everything needs to go, so reverted the (minor) changes in code to keep parity with SVN for now. All my real work's on paper at the moment...

There was also a bug fix in the code that BB had to have, but I'd already fixed around it anyway (the test for allowing external forms needed tweaking but I'd already tweaked it to work properly)
Title: Re: New revs
Post by: Arantor on January 28th, 2011, 02:05 PM
Revision: 539
Author: arantor
Date: 13:04:38, 28 January 2011
Message:
! Create a recycling board by default on install. (install.sql, Install.english.php)
----
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on January 28th, 2011, 06:01 PM
rev 540
(6 files, 15kb)

+ Added a slightly dirty, but still relatively fast and totally awesome[1] 'base' CSS property, where you can easily inherit an existing class or even an existing tag structure. If it turns out to be bug-free, we can safely remove the 'BasedOn' plugin. (Class-CSS.php)
* Replacing a preg_match with a strpos is always best. Especially, *especially* when you're calling it in a huge loop. (Class-CSS.php)
* We're not using getNodesByNodeName in other areas, so optimized it to fit our needs. @todo: determine whether the XML parser always returns uppercase tags, in which case we can do without the strtolower(). (Class-CSS.php)
* Started using base: and optimizing Warm. It's just an example but it works well as it is. (Warm/index.css, Warm/sections.css)
* Minor performance optimization. That silly PageSpeed plugin told me to. Ask him. (index.css)
* Renamed CSS cache classes to something more, err... memory-cacheable. (Class-CSS.php, Subs.php)
! Fixed wrong CSS nesting. (css/sections.css)
 1. I'm serious. Took me all afternoon to figure out how to implement that, and that was well worth it.
Title: Re: New revs
Post by: Nao on January 28th, 2011, 06:40 PM
(Pete, you forgot to post that one ;))

Revision: 536
Author: arantor
Date: 10:30:00, vendredi 28 janvier 2011
Message:
! Sync to SMF rev 10346
 * Incorrect fallback for pm receive options when buddy/ignore lists are disabled. (Profile.template.php) [Bug 4596]
 ! Upgrade did not update group types. (NB I did alter the change to use 'have not' instead of 'haven't' due to possible issues with the ' in the upgrade script. (upgrade.sql) [Bug 4577]
 ! Protected but visible group details could not be viewed by non-admins. (Groups.php) [Bug 4525]
 ! Search returned incorrect results for database users without create_temporary privilege. (Search2.php)
 ! Search may result in database errors for database users without create_temporary privilege. (Search2.php)
 & Copyright years update (index.english.php, index.french.php, install.php, upgrade.php)

Not applied:
 ! r10338 Removal of .new_win class definition (the one that was width: 400px, height: 400px) as it wasn't in our theme anyway.
 ! r10339 Fix for buffers trying to call arrays whose contents were not being trimmed; Nao already implemented more thorough trimming.
----
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/upgrade.sql
Title: Re: New revs
Post by: Nao on January 28th, 2011, 06:46 PM
rev 541
(6 files, 10kb)

* French translation. Although, I have absolutely no idea what this is talking about. CIDR blocks for IP zone HTTP headers? Yeah sure, I'll call my lawyer and I'll get back to you. (Admin, Help, Install, ManageSettings)
* Thou shalt not commit XHTML, especially after all the time it took me to convert the damn templates back to dirty HTML :P (Profile.template.php)
Title: Re: New revs
Post by: Nao on January 28th, 2011, 09:15 PM
rev 542
(8 files, 17kb)

- Removed BasedOn plugin -- it's clearly inefficient compared to the new base: feature, and I shouldn't encourage its use. (Class-CSS.php, Subs.php)
* Moved OpenID graphics to guest.css (why did I forget that?), converted more rules to use base:, removed some styles that were never applied or duplicate. (index.css, sections.css)
Title: Re: New revs
Post by: Nao on January 29th, 2011, 04:08 PM
rev 543
(1 file, 8kb)

+ Color functions now accept percentage values. (Class-CSS.php)
! Fixed rgb_output() treating a=0 as having full opacity. Simplified the function. (Class-CSS.php)
+ Added channels() function to treat each RGBA channel separately. Example: channels(rgba(255, 128, 0, .5), -50, -50%, 255, -50%) should return rgba(205, 64, 255, .25). The alpha channel is not mandatory. It also works to change RGBA channels on HSLA colors, if you ever want to do that. (Class-CSS.php)
* Improved regex to be more restrictive with alpha declarations (it used to accept "0.5.1"). (Class-CSS.php)
Posted: January 29th, 2011, 02:58 PM

rev 544
(4 files, missed size, not much.)

! Fixed JavaScript error when the page counter allowed expanding to the right. (Subs.php)
! Fixed inverted background coordinates on a couple of icons. (sections.css, post.js)
* The Send PM page should use a cat instead of a title. (PersonalMessage.template.php)
Posted: January 29th, 2011, 03:46 PM

rev 545
(7 files, and AGAIN missed size and it's not much.)

+ Added a warning at install time if libxml is not activated. (install.php, readme_*.html, Install.english.php, Install.french.php)
* Does SMF2 *really* install on a server with 2.5MB of storage space, eh? I'd say at least 10MB... Let alone when Wedge gets AeMe as default... (readme_*.html)
* Saving 6 bytes of code. Don't worry, that's only because I tried adding some menu animations, wasn't too happy UI-wise, reverted and just kept the only worthy change. Uh. (script.js)
Title: Re: New revs
Post by: Nao on January 30th, 2011, 12:21 AM
rev 546
(12 files, 19kb)

! Rewrote HSL conversion to fix a few bugs, notably the hue being rounded incorrectly when the processed color was mainly red. (Class-CSS.php)
* .windowbg2 and .windowbg3 should always have inherited from .windowbg, from day one. The resulting files will be a few bytes larger because of newly added selectors, but it's for the better really. (index.css, admin.css, Nix/ie6.css, report.css, sections.css, wireless.css)
* Moved all PM-related CSS to the member-only CSS file, as it's very, very unlikely that you ever receive a PM if you're guest. If I were you, I wouldn't hold my breath waiting for that. (sections.css, member.css)
- Removed .lower_padding class (never used). (index.css)

Forgot to document: harmonized linktree with the bottom version. (padding, etc.) Added a temp background color to it.
Title: Re: New revs
Post by: Nao on January 30th, 2011, 04:30 PM
rev 547
(5 files, 11kb)

* Renamed $context['browser'] to a new $browser global, and referenced it into $context['browser']. Memory concerns I'd say. (Class-CSS.php, Load.php)
+ Added support for percentage values in rgb, rgba, hsl and hsla colors. (Class-CSS.php)
+ Added a workaround to get IE6/7/8 to support rgba, hsl and hsla colors. Oh yeah. (Class-CSS.php)
* Made sure that channels() gets 4 channels to play with, setting the rest to 0 if less are provided. (Class-CSS.php)
+ Added a $browser['is_ie8down'] variable in PHP and is_ie8down in JS, because it's likely to be useful for other users. (Load.php, Subs.php, Class-CSS.php, index.template.php, script.js)

(Nearly finished with my CSS parser, really... Still need to look into implementing a math parser.)
Title: Re: New revs
Post by: Nao on January 30th, 2011, 05:25 PM
rev 548
(2 files, 4kb)

! Selectors could be treated as base selectors by Wedge if their name included the one of an existing base selector. (Class-CSS.php)
* More CSS parsing use. I'm loving it. (Warm/index.css)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 12:38 PM
rev 549
(4 files, 6kb)

* Renamed SI_* classes to CSS_*... Makes more sense in this context. (Class-CSS.php)
- Removed header from the 'more smileys' popup. If you clicked that link, you know what to do. (Class-Editor.php)
* Replaced the dynamic str_replace for debug data insertion, with a substr_replace which is faster in effect, and less error-prone. (QueryString.php)
! A misplaced preview linebreak was visible even when the preview wasn't. (Post.template.php)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 06:46 PM
rev 550
(1 file, 5kb)

! Fixed a bug in the IE codepath: rgba and hsla colors weren't correctly transformed to rgb. Maybe I should start testing my code before committing it... Hmm... Wait, no that's too hard to do. (Class-CSS.php)
! Fixed (although it never generated any glitch?) a regex bug in the rule parser: a "+" was needlessly escaped, and worse, a "." should have been escaped. Plus, uppercase chars weren't taken into account, even though they should. (Class-CSS.php)
! Fixed a dirty bug where selectors were treated more than they should, resulting in long parsing times when using class inheritance. Maybe I should start tes... Look behind you, a three-headed monkey! (Class-CSS.php)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 09:37 PM
rev 551
(3 files, 12kb)

+ Added a horrible, complicated and rather ugly hack called $alpha_matte. On the other hand, it allows using RGBA/HSLA colors without providing a fallback for IE 6/7/8. If you have a better idea, please share. (Class-CSS.php, Warm/index.css)
! Fixed named colors not working at all. Yes, I didn't test these either. So, did you see that three-headed monkey or not? (Class-CSS.php)
* Moved color extraction code to its own method. Not because it's cleaner, but because it allows me to call it again. (Class-CSS.php)
- Removed the buggy, and unused, server import function. (Class-CSS.php, Subs.php)
Posted: January 31st, 2011, 08:50 PM

rev 552
(2 files, 6kb)

* Updated ie6.css to remove the original rgba() hacks. Although... Can someone please tell me why it doesn't show backgrounds anymore? And why does the h4.hove work, but not the li.hove one? Eh? You don't care? You're mean. (Warm/ie6.css)
* Rewrote menu.gif handling to call it only once and save some space in the cached CSS file. (Warm/index.css)
Posted: January 31st, 2011, 09:20 PM

rev 553
(2 files, 5kb)

* Added ability to specify email and URL fields in Profile inputs, and changed a couple of these entries to force them. iPhone users will like me more for that. I need love. (Profile-Modify.php, Profile.template.php)
Title: Re: New revs
Post by: Nao on January 31st, 2011, 11:30 PM
rev 554
(5 files added, 1 deleted, 2 updated, 18kb)

* Renamed Nix styling to Wine (in keeping with the 'W' theme...), and tweaked the colors to be more inviting. Hips! (Wine/*, various files)

I *hope* you'll like it, Pete! I didn't change much, but I don't know how I could possibly make the catbar and titlebar brighter... :^^;: It would spoil the styling's name :P
I think I'll keep the 'Nix' name (or Nyx) for a REAL black theme ;)
Title: Re: New revs
Post by: Nao on February 2nd, 2011, 04:40 PM
rev 555
(2 files, 13kb --- sometimes, sad stats are really sad. That one was a lot of work :P)

+ Added support for Sass-style CSS files. It is a bit fragile, but it works. (Class-CSS.php)
+ Added support for ".class extends .other_class" as a selector, mimicking PHP syntax. (Class-CSS.php)
+ Added support for & shortcuts after extends and base keywords. (Class-CSS.php)
+ Added support for // line comments. (Subs.php)
* Converted \r linebreaks to \n to simplify operations. (Subs.php, Class-CSS.php)
* Renamed CSS_NestedSelectors class to CSS_Nesting, because that's me. (Subs.php, Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 3rd, 2011, 10:06 AM
rev 556
(12 files, 18kb)

! Replaced nl2br($string, false) (PHP 5.3+ only) with a preg_replace in the westr object. (Class-DB.php, Class-String.php, ManageMail.php, Packages.php, Subs.php, ViewQuery.php)
! Fixed a few hardcoded replacements and errors when processing profile URLs. (PrettyUrls-Filters.php)
! Setting $_GET['board'] to 0 instead of unsetting it was a bad idea, as it would end up in the URL when rebuilding the query string from scratch, as Subs-Auth.php does. (QueryString.php)
* Moved the action to the beginning of the query string to allow easier 'prettification'. (Subs-Auth.php)
! Some user agents (bots, probably?) wouldn't return a HTTP_ACCEPT_ENCODING header. Disable gzipping for them losers. (Subs.php)
! Made sure that the menu system didn't try printing anything when an entire section was unavailable, for guests for instance. (GenericMenu.template.php)
* Updated copyright year to 2011 in the footer. (index.english.php, index.french.php)
Title: Re: New revs
Post by: Nao on February 4th, 2011, 04:44 PM
rev 557
(13 files, 105kb)

* The big Warm commit: full conversion to the simplified CSS syntax. (Warm/*.css)
! Fixed parsing of simplified syntax CSS files when stray semicolons were being used. And yes, you still can't use several properties on a single line. It's fixable, but not without making the code more complex to maintain, and simplicity and readability are the goal here, whether in CSS or in PHP. (Class-CSS.php)
* Minor optimization of earlier code. (Subs-Auth.php)

Stats: Warm/* used to account for 85.1kb, now it's at 78.8kb, saving about 8% off the previous size. Or, "the previous size was 9.2% bigger than the new one." Whichever you like best. ;)
Title: Re: New revs
Post by: Nao on February 4th, 2011, 06:50 PM
rev 558
(5 files, 8kb)

+ Added a $context['is_ajax'] that is only set if the page is being called by jQuery. (QueryString.php)
! Fixed error log's code browser and any popup in general to hide sidebar and debug info when called from jQuery. (Subs.php, Help.template.php)
* Marked some registration fields as required (in HTML5 terminology) and added a type="email" over there. (Register.template.php)
! Registration username validator always returned true. (register.js)
Title: Re: New revs
Post by: Nao on February 4th, 2011, 11:27 PM
rev 559
(3 files, 8kb)

+ Added mixin support, which is basically the stuff I removed last week, but with a better syntax, and the ability to specify parameters. Didn't use it in the CSS, so I just provided a few samples. (Class-CSS.php, Subs.php, Warm/index.css)

(I really need to start writing some proper documentation for themers...)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 09:24 AM
rev 560
(2 files, 8kb)

! Fixed indentation in mixin use. You can safely use a mixin: at deep nesting levels, as well as use nesting inside the mixin blocks themselves. Also changed the commented out samples to reflect that. (Class-CSS.php, Warm/index.css)
* Only allow mixin declaration at the start of a new line, i.e. indentation won't work. This is more of a semantic change than anything else, really. (Class-CSS.php)
* Added a comment explaining why I'm not doing "$var: 0" variable definitions, as would be more logical. (Class-CSS.php)

(Thought of this mixin fix all night, ruined my sleep >_<)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 04:05 PM
rev 561
(1 file, 7kb)

+ Added support for deep extends. For instance, with ".class1 / .class2 extends .class1 / .class3 extends .class2", class3 will correctly extend class1 as well. And so on. (Class-CSS.php)
! Fixed a few bugs in the process. It's a miracle that it all worked before. (Class-CSS.php)
- There was really no reason to go through array_map('trim') on exploded selectors. It's all trimmed by the CSS optimizer later anyway. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 05:31 PM
rev 561
(1 file, 5kb)

! Fixed extends where if the base was for instance, ".class a" or ".class th", and it would match ".class abbr" or ".class thead". Bummer. (Class-CSS.php)
! Fixed extends where if the base was ".class something" and another earlier selector inherited ".class", the current selector wouldn't inherit anything. Extends are a complicated beast. Don't abuse them, or I'll eat you. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 5th, 2011, 07:22 PM
rev 562
(25 files, 22kb)

+ Added basic math functions to CSS parser -- and this will be the last feature I'm adding to it, otherwise I'm gonna faint. The feature is as short as possible, and uses eval() to allow you to use regular PHP syntax in your math. Example: border-width: math($default-border-width*2)/3px). (Class-CSS.php, Subs.php)
* As a rule of thumb: inside a character class, most metacharacters are regular characters again. With this in mind, simplified many, many expressions throughout the source code. Wasn't fun. Ah, and a reminder to the SMF team: \w matches underscores, too... (Class-CSS.php, Class-DB.php, JSModify.php, Load.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, PackageGet.php, Packages.php, Post.php, Post2.php, PrettyUrls-Filters.php, Profile-Modify.php, QueryString.php, Search2.php, Security.php, Subs-Auth.php, Subs-Boards.php, Subs-Post.php, Subs.php, Themes.php, ManageBoards.template.php, ManagePaid.template.php)
- I said I don't care about lower_padding! Grr. (MoveTopic.template.php)

Note: here's to you, Pete. Hopefully you're not the one who'll faint in front of these dozens of regex changes! I tested most of them... But sometimes it's hard to just grasp the idea that in a character class, [ is the same as \[ or even \\[... Or whatever... But that \ needs to be escaped twice... \\\\. Yay.

:edit: Oops... I committed a "work in progress" by mistake. That's the Themes template, FWIW. Please don't bother looking into it. ;) Basically I started removing the CSS previewer, but it was hard to do because I worked so much on fixing it... Maybe you'd like to finish the job for me? :^^;: Or maybe I'll find a way to at least keep the previewer (just not the real-time preview.)
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 02:55 AM
Revision: 564
Author: arantor
Date: 01:55:03, 06 February 2011
Message:
! Can't create proper lambda functions before PHP 5.3.0. (Class-CSS.php)
----
Modified : /trunk/Sources/Class-CSS.php
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 03:21 AM
Sync'd to SMF r10396
 & Fixed a couple of languages strings. [Bug 4566] (Help.english.php, ManagePermissions.english.php)
 ! Fixed validation error and header bar markup. [Bug 4549] (ModerationCenter.template.php) (Note from commit: We have several cases in admin where HTML validation is borked if there are no items displayed in a table. The problem is that the php was written without taking into account the possibility of empty tables. I'll fix them as I come across them but wont go looking for them at this stage.) (NB, I fixed this differently to them, i.e. not having an extra if after the foreach)
 * Fixed newsletter IE7 issue and some other IE issues. (ManageNews.template.php, Login.template.php, index.css, Warm/index.css, rtl.css, Warm/rtl.css, ie6.css, ie7.css, Warm/ie6.css, Warm/ie7.css) [Bug 4567] (NB: These don't appear to make a difference to me, but might on IE, haven't tested them)
 * Incorrect id's fixed. (SplitTopics.template.php) [Bug 4582]
 * Minor markup fixes. (Profile.template.php) [Bug 4607] (One did not apply to us!)
 ! Fixed display of spider log title/information. (ManageSearchEngines.php) [Bug 4608]
 ! Broken function call in ManageMail (ManageMail.php)
 ! Credits updates. (Credits.php, Who.english.php) (NB: I've added Brett as consulting dev since some of his work has gone into the patches here, and added the server team but not any of the miscellaneous people moves since they're not part of Team Wedge)
 * Added array flip for buttonlists to fix untracked ltr/rtl issues in IE6/7. (rtl.css, index.template.php)
 ! messageIconChecks_disable should be enable [Bug 4095] (Display.php, MessageIndex.php, Search2.php, Unread.php, Unreadreplies.php, SSI.php) [2.1 branch but was in the tracker for ages so fair game]
 ! Multitable deletes possible in MySQL. (ManageBans.php, ManageMaintenance.php, ManagePermissions.php) [2.1 branch, ignored the == to === micro optimisations]
 ! Checking for search API files could cause an open_basedir error. (ManageSearch.php) [Bug 4251]
 ! Visual verification could cause undefined index errors in some cases. (Subs-Editor.php) [Bug 4546]
 ! add_index function failed on duplicate indexes. (Class-DBPackages.php) [Bug 4536]
 ! Allow search methods to modify search settings. (ManageSearch.php) [Bug 4606]

Not added from SMF SVN
 ! revs 10347-10350 (branches in SVN, plus backporting a change to 1.1.x branch)
 ! rev 10351 (SSI change to prevent functions being called from GET when as a guest; since protection is added at function level rather than the file level, we don't need to add this)
 ! revs 10352-10355 (SSI changes from 2.0 being backported to 1.0 and 1.1, plus version number bumps for these versions)
 ! rev 10356 (typo fix in 1.1.x SSI)
 ! revs 10360, 10363 and 10368 in relation to admin submenu not having clear on narrower widths properly... cannot reproduce this myself though their fixes seem to be generic to IE6 too (and revolve around putting a br clear in the generic template. Also, they add a white-space: pre, we already have a related white-space: nowrap in our equivalent menu CSS)
 ! rev 10361 (removes the 3px left padding in h3.titlebg only in admin panel)
 ! rev 10362 (missing class="icon" on some h3s in Admin and Themes templates... we don't use that any more)
 ! rev 10370 (?fin20 to ?rc5 for URLs)
 ! rev 10371 (bump to 2.0 RC5 - save that for another commit I think)
 ! rev 10373 (creation of 2.1 branch in SVN)
 ! rev 10374 (1.1.x ManageNews version change)
 ! rev 10375 (removal of an extra space in 1.1.x SSI)
 ! revs 10376-10379, 10381-10383 (preparation of patch files for just the security changes, 1.1 patch, 2.0 patch, patch cleanup, 1.1 patch, 2.0 patch, version bumps in installer/upgrader)
 ! rev 10380 (Admin language file in 1.1.x cleanup)
 ! rev 10384 (1.0/1.1 changelog notices for security)
 ! rev 10385 ([2.1 branch] check for @ before attempting to query supplied username in email field)
 ! rev 10387 ([2.1 branch] replace all calls to time() with $_SERVER['REQUEST_TIME']... aside from a (IMO) negligable benefit, that relies on the server setting it up, and I don't expect it to be completely consistent on all environments)
 ! rev 10389 (tweaks for manual/wiki changes)
 ! rev 10390 (help section not right in Core)
 ! rev 10396 ([2.1 branch] rewrites of version_compare to use "nice syntax" with symbols - we don't have any outside the installer to worry about, and apparently there's a search bug fixed but I don't see what it is from the diff)
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 12:36 PM
Revision: 566
Author: arantor
Date: 11:35:45, 06 February 2011
Message:
! Updated version number across the source to 2.0 RC5, I don't think they were selective in what files were updated, don't see why I should be (Many many files, simple find/replace on 2.0 RC4 to 2.0 RC5)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Buddy.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Class-DBExtra.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Class-DBSearch.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-GifAnimator.php
Modified : /trunk/Sources/Class-Package.php
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/Collapse.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Sources/Subs-Sound.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/Sources/captcha/captcha-grid.php
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Modified : /trunk/Sources/captcha/captcha-ledicons_anim.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_cycle2.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim_shadow.php
Modified : /trunk/Sources/captcha/captcha-silhouette.php
Modified : /trunk/Sources/captcha/captcha-simpleanim.php
Modified : /trunk/Sources/captcha/captcha-stripes.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Notify.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Printpage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Stats.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/Themes/default/Xml.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Modified : /trunk/Themes/default/languages/ManageCalendar.english.php
Modified : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/Themes/default/languages/ManageMail.french.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.french.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/ManagePaid.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.english.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Modifications.english.php
Modified : /trunk/Themes/default/languages/Modifications.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/Settings.english.php
Modified : /trunk/Themes/default/languages/Settings.french.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/Stats.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/Wireless.english.php
Modified : /trunk/Themes/default/languages/Wireless.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/Settings.php
Modified : /trunk/other/Settings_bak.php
Modified : /trunk/other/Sphinx/SearchAPI-Sphinx.php
Modified : /trunk/other/Sphinx/sphinx_config.php
Modified : /trunk/other/Subscriptions-Authorize.php
Modified : /trunk/other/Subscriptions-twoCheckOut.php
Modified : /trunk/other/install.php
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/bbc_test.php
Modified : /trunk/other/tools/cleanup_mark_read.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/mailQueueCron.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/tools/restore_backup.php
Modified : /trunk/other/tools/smf_api.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/tools/status.php
Modified : /trunk/other/tools/webinstall.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/xml/current-version.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Nao on February 6th, 2011, 12:53 PM
rev 567
(4 files, 10kb)

* Optimized the CSS to XML pre-parser by a factor of 20 or something. Seriously -- don't use str_replace in an evaluated preg_replace that gets called thousands of times. Just don't forget that. (Class-CSS.php)
! usort() may not accept a dynamic function before PHP 5.3, but it doesn't accept $this->kind_of_call either ;) (Class-CSS.php)
* Cached the parent node in searchExtends, as it's pointless to recalculate it on every loop. (Class-CSS.php)
! Fixed a few minor issues. (Class-CSS.php)
! Fixed an incorrect conversion to the simplified syntax for the profile area. (Warm/sections.css)
* Moved the cache folder's cache settings to its own .htaccess file, instead of the top-level one. Dunno if it'll help, but I also added a Cache-Control header to that. Also added a note about FallbackResource (I just found out about that one.) (other/.htaccess, cache/.htaccess)

--> Now I can take some time to look into your other additions... And don't make me believe you checked all of my week's commits in just a few minutes :P
Title: Re: New revs
Post by: Arantor on February 6th, 2011, 01:09 PM
Revision: 568
Author: arantor
Date: 12:08:42, 06 February 2011
Message:
! If calling a function in a static way, it needs to be declared as static. (Class-CSS.php)
----
Modified : /trunk/Sources/Class-CSS.php
Title: Re: New revs
Post by: Nao on February 6th, 2011, 05:30 PM
rev 569
(14 files, 14kb)

* Moved calendar months to the sidebar, to save an extra column. (Calendar.php, Calendar.template.php, sections.css, Warm/sections.css)
! The IE6 stylesheet wouldn't compile properly, because of the use of a "<". (Class-CSS.php)
+ Show lines in context when errors are found during compilation. (Class-CSS.php)
- Removed commented out lines after testing them to work in login and register pages. (ie6.css, ie7.css, Warm/ie6.css, Warm/ie7.css)
- Removed copyright removal text. (Who.english.php, Who.french.php)
* More $context['browser'] to $browser. (index.template.php)
* French translation. (Help, ManagePermissions, Who)
Title: Re: New revs
Post by: Nao on February 6th, 2011, 10:04 PM
rev 570
(2 files, 6kb)

* Improved performance of XML tree builder by 20% by applying various micro-optimizations. Not that it'll be noticeable, but a CPU cycle is a CPU cycle. (Class-CSS.php)
! Forgot to declare .title2 in Warm styling. (Warm/index.css)
Title: Re: New revs
Post by: Arantor on February 7th, 2011, 12:05 AM
Revision: 571
Author: arantor
Date: 23:00:29, 06 February 2011
Message:
! Sync to SMF 10403
 ! Non-existent permission profiles could cause undefined index errors. (ManagePermissions.php) [Bug 4612]
 ! Incorrect dots during upgrade with multiple script files. (upgrade.php) [Bug 4617]
 ! Who's Online integration hook was too restrictive. (Who.php) [Bug 4615] (+credits update, Credits.php)
 * Auto suggest could not handle display names with html special characters. (suggest.js) [Bug 4604]

Not included
 ! r10397 (changelog formatting)
 ! r10400 (possible to add the same function to a hook twice; not necessary due to the already-rewritten code)
 ! r10402 (typo in version check in fulltext API - but we require 4.1.2 which is over their version check automatically)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/scripts/suggest.js
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on February 7th, 2011, 01:21 PM
rev 572
(10 files, 20kb)

* Rewrote the CSS parser to get rid of the XML parser and optimize parsing speed. Mission accomplished, with performance doubled, and code shortened by 90 lines and 2.6 KB. (Class-CSS.php)
- Got rid of the libxml dependency. Oh yeah. (install.php, readme_*.html, Class-CSS.php, Install.english.php, Install.french.php)
* Playing with Warm colors... Just for fun... (Warm/index.css)
* Typonazi. (Class-Package.php, Subs.php, readme_*.html)
Title: Re: New revs
Post by: Nao on February 8th, 2011, 12:15 AM
rev 573
(2 files, 5kb) (a very small fix update.)

! The lighten function was broken. (Class-CSS.php)
- Removed some leftover debug code. (Subs.php)
Title: Re: New revs
Post by: Arantor on February 8th, 2011, 04:57 PM
Revision: 574
Author: arantor
Date: 15:56:48, 08 February 2011
Message:
! Tweak to licence wording for our protection (license.txt)
! Sync to SMF 10446 aka "Clusterfuck"
 ! (10404) Minor improvements to integration hooks. (Admin.php, Load.php, ManagePermissions.php, ManageSettings.php)
 ! (10405) [2.1] Added detection for Litespeed as part of the server config. (Load.php)
 ! (10408) Tabs within code tags were not parsed correctly for some browsers. (Subs.php) [Bug 4578]
 ! (10414) Validate odd URLs (QueryString, Subs.php) *See notes
 ! (10415) Oops. Remove completely incorrect protection against $cachedir removal. (upgrade.php)
 ! (10419) Update the change in 10414, so that password flood is validated regardless of the number of times before it. (Load.php)
 ! (10439) Save a query on posting (topic=161621) (Post2.php)
 ! (10441) [2.1] Don't log robot views on topics or attachments. (Display.php, Dlattach.php)
 ! (10442) sprintf call for support resources language string was overridden. (Admin.php)

Not implemented
* r10406 [2.1] Moves the admin helper functions out of ManageServer and into Admin. I'll be doing this in the rewrite (I'm not so bothered about syncing 2.1 changes back to us and there are potential licence issues anyway with just using 2.1 branch code). There is also a tweak to allow for $context['body_id'] to be defined and if defined, attach that id to the body tag. I left it off because I'm not really sure where this would actually be useful. There is also a lot of changes for the language editor from/to display sanitising but I have absolutely no idea why it's changed (since it's not referred to at all anywhere I can find)
* r10407 [2.1] parsesmileys() created a regex too complex - I'm sure this has consequences I don't like, while it has performance, it's also more naive in how it approaches things I think (it's discussed in the beta board, and Unknown was trying to talk groundup out of it more than once) and it's more == to === conversions to safely ignore.
* r10409-10413 Minor fixes (1.0 SSI, 1.0 patch file, 1.1 spacinazi, 1.1 SSI, 1.1 patch file)
* r10416 Changelog update
* r10417 The change in 10414 to sanitise $_REQUEST['start'], I already added the check that this rev adds (that $_REQUEST['start'] is defined before trying to (int) it)
* r10418 Changing the SSI security thing AGAIN (in line with what 10409-10413 did, basically to ensure that the kickguest only got called when appropriate, but we don't kick the guest to login anyway, we do what makes more sense in the first place: restrict the user's access in SSI so they can't see anything they're not supposed to and let the folks who use SSI figure out what they want to do with the user thereafter)
* r10420-10437, 10443-446 Updating 2.0 patch file, spacinazi and patch file, 10414's fix backported to 1.0, and for 1.1, file versions for both, 1.0 patch file, 1.1 patch file, 1.0 cleanup, 1.0 patch file, 1.1 file version typo, 1.1 spacinazi, CRLF issues, more CRLF issues, 1.1 patch file, 1.0 language file version, 1.1 SSI examples, 2.0 patch file, update to manual to match the trademark slogan of SMF, 1.1 language file version, 1.0 patch file, 1.1 patch file, 2.0 patch file
* r10438 [2.1] Caching members online stats is fine but I don't like the way it's done (should really be done differently all round), and also more == to === changes
* r10440 [2.1] Moving a function from Subs-Auth to Subs-Compat is great but it's not relevant to us since it's in 4.3.2 and up!

Notes
* r10404 Sinan also added a hook to ManageSettings.php for general mod settings but that was already added by Nao under a slightly different name. In SVN log: [SiNaN] knows that he'll be shot for doing this but he still has the heart of a modder.
* r10405 [2.1] also covers making queryless URLs work on Litespeed but that doesn't apply to us. There's also a removal of a @ error suppressor in the install file and a few == to === conversions. Really though, this is pure pedantry.
* r10408 implements it with browser conditions in the definition of $tag['content'] in the original array. Since that's not an option for us, I handled it inside the validate function. I did also fix the rather frustrating issue of IE not putting treating br tags as line breaks for copying, this is something they haven't.
* r10414 is a strange one. I'll buy validation of the URLs to prevent oddities (QueryString, Subs) but it also has two other changes: it removes the char 38 replacement in un_preparsecode, which seems to be OK because & is still escaped to its entity form (though I don't see what prompted it to be changed) and there is more robust checking of password flooding, specifically that a user isn't logged out when there's a password attack.
* r10439 The idea is to move the 'logging boards read', so that if goback is set, we fold that into the 'logging unread' process. Their method involves having an if and two queries' code, mine just manipulates the query variables, heh.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/license.txt
Modified : /trunk/other/install.sql
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on February 8th, 2011, 11:34 PM
rev 575
(9 files + 1 addition, ~10kb)

* Did some serious reworking of the header area. As always, it's a WIP, so feel free to share your ideas to improve on it (or just revert to what it was before.) Haven't tested in Pastel, I'm sure it'll be fun to see how broken it is. (index.template.php, Warm/index.css, images/theme/bg.jpg)
* Rewrote the cat bar and title bar to something else. Me likey.
- Don't waste time and bandwidth showing a clickable link on categories. They already have a collapse button next to them, that should be enough. Who uses collapsing anyway? (Subs-BoardIndex.php)
* Don't use windowbg overrides in the board list. Too many colors can kill the fun, really. (BoardIndex.template.php)
- Don't show the website's name next to "Info Center". The website's name is already in big large letters in the header. What's the point. (BoardIndexInfoCenter.template.php, index.english.php, index.french.php)
* The Search icon in the menu is off by one pixel. Or am I crazy? (Warm/index.css)
! Fixed issues with the channels() function. (Class-CSS.php)
+ Added ability to group properties together if they have the same value, e.g. "height, line-height: 20px". (Class-CSS.php, Warm/index.css)
* Various CSS tweaks. (Warm/index.css, Warm/sections.css, BoardIndexInfoCenter.template.php)

I'm expecting your feedback on the design tweaks, Pete! (And Bloc, maybe...?)
Not too happy with the part that prints the website's name, but the rest, I'm a bit happier with than with the earlier versions. And it's hard to please me really...
Title: Re: New revs
Post by: Nao on February 9th, 2011, 03:43 PM
rev 576
(5 files, 8kb)

* Saved another tenth of a second at CSS compilation time, by replacing a preg_replace_eval with a preg_replace_callback. Seriously, for a single instruction to take a tenth of a second... That's crazy. (Class-CSS.php)
! Mixin declarations would fail if they only a single-line 'function'. (Class-CSS.php)
! Mixin declarations should stop at the first line that has a shorter indentation than the first line of the 'function', rather than the first empty new line. That should teach you to behave. (Class-CSS.php)
! Fixed a missing overflow in Pastel. (css/index.css)
! IE6 was behaving badly in Warm because I forgot to update one of its hacks. (Warm/ie6.css)
* More tweaking to the Warm layout and colors. (Warm/index.css)
* The theme picker could use a visible title, really. (Themes.template.php)

NB: I'm currently playing with drag & drop, trying to make my routine as small as possible, and compatible with position:fixed (which represents most of the difficulty in this exercise.) Still, it's a funny thing to implement, and I need it for our future Highslide replacement.
Title: Re: New revs
Post by: Nao on February 10th, 2011, 09:56 AM
rev 577
(5 files, 12kb)

+ Added ability to compress and cache more CSS files that aren't in the base set. (QueryString.php, Subs.php)
! Fixed installer to properly compress and cache JS and CSS. At last. No animals were harmed during the fixing of this bug. Several gigabytes of data, though, were savagely killed on my test bed because I forgot to set a value for $cachedir. (install.php)
! Fixed Wireless template to use nested CSS. (Wireless.template.php)
- The script tag doesn't need a type for JavaScript. Forgot that one line. (index.template.php)

Note: Should we remove $is_direct_url from add_css_file and add_js_file? It sounds to me like it's a legacy option...
Title: Re: New revs
Post by: Nao on February 10th, 2011, 10:52 AM
rev 578
(4 files, 10kb)

+ Added <we:logo>, a placeholder for putting your own text and logo and styling it like you want. It's totally uncool. Punish me, master. Or at least revert. (Load.php, Subs.php, css/settings.xml, index.template.php)
! Fixed a bug in the CSS parser introduced in rev 577. Just needed to replace $files with $css. (Subs.php)

(I've never hated more a commit of mine than this one, so you've been warned. Still, if we can't make this kind of thing, then we might as well immediately drop the idea of integrating Tox-G in the future.)
Title: Re: New revs
Post by: Nao on February 11th, 2011, 08:11 PM
rev 579
(7 files, 13kb)

+ Added 'final' keyword to selectors, allowing to forbid another selector from inheriting a specific selector through the extends/base system. (Class-CSS.php, Subs.php, Warm/index.css)
* Tweaked header and reverted the order in which the user box and logo show up. Also did plenty of small tweaks to Warm based on user feedback. Thanks everyone! (css/index.css, Warm/index.css, index.template.php)
- Reverted <we:logo> code. I really felt it wasn't the right way to do it. (Load.php, Subs.php, css/settings.xml)

Note to Pete: I rewrote the 'final' code, as I wanted. Now it correctly cancels inheritance for nested selectors when the 'final' keyword is on a child, non-inherited level. If that means anything to you :P
Posted: February 11th, 2011, 07:46 PM

rev 580
(3 files, 9kb)

+ Added a short and sweet drag'n'drop function. Well, just the 'drag' part, but it's all I wanted anyway. (script.js)
+ Added ability to prevent an object from being dragged, by assigning the 'nodrag' class to it. (script.js, Help.template.php, Errors.template.php)
* Avoid initializing a HTML document if we're just coming through Ajax... (Errors.template.php)
- Removed all optimizations related to local variable/function names, because Parser supports them anyway. And if you're not using Parser, it means you don't care about filesize anyway... (script.js)
Title: Re: New revs
Post by: Nao on February 11th, 2011, 09:21 PM
rev 581
(13 files, 15kb)

* Renamed obfuscate_js back to obfuscate_filenames, as CSS filenames are now obfuscated just the same time as JS files. (install.php, ManageServer.php, QueryString.php, Help.english.php, Help.french.php, ManageSettings.english.php, ManageSettings.french.php)
* Restored alternating backgrounds in the board list, only horizontally this time... Not that I find this more exciting... Just wanna find out which is best. (BoardIndex.template.php)
! Toggle icon padding was incorrect in the news fader. (Warm/sections.css)
* Replaced toggle icons with way sexier ones (modified FamFam). Don't thank me. (collapse.gif, expand.gif)
* Prevent double-clicking the toggle icons. (script.js)
* Maintenance area was flooded with cat bars. Seriously, title bars are the way to go here. (ManageMaintenance.template.php)
Title: Re: New revs
Post by: Nao on February 12th, 2011, 07:18 PM
rev 582
(85 files, 83kb) (phew...)

* Important for modders -- $context['sub_template'] = $template has now become a function, showSubTemplate($template), which will automatically manage multiple sub-templates and sidebar sub-templates (showSubTemplate($template, 'sidebar')). (Activate.php, Admin.php, Announce.php, BoardIndex.php, Calendar.php, CoppaForm.php, Credits.php, Display.php, Findmember.php, Groups.php, Help.php, Jseditor.php, JSModify.php, Load.php, Login.php, Login2.php, ManageAttachments.php, ManageBans.php, ManageBoards.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePosts.php, ManageRegistration.php, ManageScheduledTasks.php, ManageSearch.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Memberlist.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Notify.php, PackageGet.php, Packages.php, PersonalMessage.php, Post.php, PostModeration.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, QuoteFast.php, Register.php, Reminder.php, RepairBoards.php, Reports.php, Reporttm.php, Search2.php, Security.php, SendTopic.php, Spellcheck.php, SplitTopics.php, Stats.php, Subs-Auth.php, Subs-Menu.php, Subs-Package.php, Subs.php, Suggest.php, Themes.php, Unread.php, Unreadreplies.php, VerificationCode.php, Xmlhttp.php)
* Rewrote menu system to use regular sub-templates rather than template layers, and allow putting them inside the sidebar flow. Still a bit buggy when it comes to tabs, though. (Subs-Menu.php, GenericMenu.template.php)
* I've always hated empty lines with tabs in source code. Yikes. (Profile.template.php)
* Simplified some CSS related to earlier implementations of the profile/admin sidebars, and made use of media queries instead of conditional refitting. (ie6.css, index.css, rtl.css, sections.css, Warm/ie6.css, Warm/index.css, Warm/rtl.css, Warm/sections.css)
- Removed #context .custom_field hack, as I couldn't find any issue with these in IE6 and Opera. (sections.css, Warm/sections.css)
- Removed support for old-style tabs, as pre-SMF2 themes aren't compatible with Wedge anyway. (GenericMenu.template.php, Recent.template.php, Reports.template.php)

@ Note: WrapAction() in Themes.php... Shouldn't this be removed, now that a hook caters for that?
@ Note: remove .left_menu and .side_section classes?
Title: Re: New revs
Post by: Nao on February 12th, 2011, 11:18 PM
rev 583
(11 files, 15kb)

+ Added support for $context['top_template'], which holds the secondary menus and tab buttons, and is protected from overwrites. (Load.php, Subs-Menu.php, Subs.php)
- Removed $settings['catch_action']. Seriously, it's totally undocumented, I couldn't find any mod using it, and we're pushing for the use of hooks anyway. And there's a hook that does exactly the same task. (index.php, Themes.php)
! Another fix for user agents not specifying the type of contents they accept. (QueryString.php)
* Tweaked sub_template handling. (Errors.php, Load.php, Profile.php, Security.php)
! Fixed an undefined index error that you'll never get anyway. (GenericMenu.template.php)
! Fixed XHTML Mobile 1.0 validation. (Wireless.template.php)
Title: Re: New revs
Post by: Nao on February 13th, 2011, 12:12 AM
rev 584
(1 file, 7kb)

! Fixed CSS parser bug where multiple selectors were given a same base (".class1, .class2 { base: .class }") and only the last one would correctly reflect that. (Class-CSS.php)
* Optimized inheritance parser to avoid running dozens of preg_replace's. (Class-CSS.php)
! Fixed handling of the 'final' keyword for finalized selectors' children. (Class-CSS.php)
! Fixed potential false positives when parsing selectors starting with an alphanumeric character. (e.g. a tag name) (Class-CSS.php)

@ Note: found another bug, will fix tomorrow... $this->getAncestorSelectors($this->rules[$node['parent']]['parent'])...? How does that work anyway? The function is expecting a node but it returns an ID. This works only if all cases where the selector is a root one.
Posted: February 12th, 2011, 11:50 PM

rev 585
(2 files, 5kb)

! Fixed extended selectors not applied correctly when they are themselves children of another selector. (Class-CSS.php)
* Spacinazi. (Warm/admin.css)

(Sorry for the last minute commit. I really didn't notice the bug until I reviewed the code for commit.)
Title: Re: New revs
Post by: Nao on February 13th, 2011, 01:08 PM
rev 586
(5 files, 10kb)

+ Added separators to the profile menu. (Profile.php)
! The duplicate separator removal code was buggy. Rewrote it from scratch. (Subs-Menu.php, GenericMenu.template.php)
! Don't show top_template items in Ajax mode. (Subs.php)
! Fixed missing parens in a dynamic function. (ManageMail.php)
Title: Re: New revs
Post by: Nao on February 13th, 2011, 05:32 PM
rev 587
(3 files + 2 added, 157kb) (nothing changed really... Only renamed "permute()" to "bbc_permute()" to avoid potential conflicts in function names.)

+ Added Subs-Cache file, that includes all of the code for caching regular data, CSS and JS, thus off-loading Subs.php, Load.php and QueryString.php. (Load.php, QueryString.php, Subs-Cache.php, Subs.php)
+ Added Subs-BBC file, that includes all of the code for parsing BBCode, thus off-loading Subs.php, and... that's all. It's already a lot. (Subs-BBC.php, Subs.php)
* Moved match_cidr() to the IP function area. (Subs.php)
Title: Re: New revs
Post by: Arantor on February 13th, 2011, 07:36 PM
Revision: 588
Author: arantor
Date: 18:35:49, 13 February 2011
Message:
! Preliminary IPv6 support (lots of files)
! Minor tweaks to installer to prevent throwing of errors over SMF constant. This needs cleanup though. (install.php)

@todo:
 Profile IP tracking stuff is still broken
 Bans also broken (which likely means non admin users are also broken for now)
 match_cidr() needs updating
 host_from_ip() needs testing for IPv6
 Proxy code needs rewriting, it's just commented out for now but it was actually broken before

When I say it's preliminary support, I mean just that - it doesn't immediately fall over, but it's going to be fragile for now. There's also likely stuff I've forgotten for now, but I think I got the major stuff either resolved or at least 'known'. (And some would love to add IPv6 support as a mod...? Sigh.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on February 14th, 2011, 05:37 PM
I think it's the first time I see you commit commented out code... Hang in there!

rev 589
(5 files, 13kb)

! Fixed CSS not showing up in the installer if the forum is installed in a sub-folder. Hopefully. (install.php)
* Moved censorText() to a more logical place. Again -- hopefully. (Load.php, Subs-BBC.php)
+ Added separators to the internal PM menu. (PersonalMessage.php)
! Fixed various obvious bad translations in the installer. Okay, what did I do during these two months I spent on fixing these files? Did someone throw them away or was I just that careless? (Install.french.php)

PS: Another commit coming up... Just sorting out the files for now. Also, I'm not too sure about that code I added in install.php... I think I should instead change Subs-Cache.php to return "cache/" instead of $boardurl . "/" when $boardurl is empty... That'd probably make more sense. The only reason I didn't do it is that it's unlikely $boardurl isn't set when the forum is installed. Meaning it just wastes a CPU cycle for nothing...
Title: Re: New revs
Post by: Nao on February 14th, 2011, 11:31 PM
rev 590
(8 files, 12kb)

* Changed the dynamic sidebar removal to instead move it to the far left, and restore it (with an animation) when hovering it. Only tested in Opera for now. Also adds a box-shadow in this mode, to make it clear that it's no longer in the regular flow. (index.css, Warm/index.css, index.template.php)
* If the linktree only has one item, it has to be the home page, hasn't it? Let's not waste time showing it then... But keep the linktree div in it, since we might have some padding applied to it. (index.template.php)
! The special popup at runtime wasn't using the new system. (install.php, Install.english.php, Install.french.php)
! Fixed a horizontal scrollbar at board creation time. (ManageBoards.template.php)
! Fixed a warning when caching the Pastel styling -- had forgotten a bracket. Next step: drop stupid CSS and use the new syntax everywhere. (sections.css)

@ Note: should we care about the legacy code for older PHP versions in the installer...? Lines 102-117. (install.php)
@ Note2: cool changes innit? :P As indicated, it's only tested in Opera for the sidebar stuff (should work everywhere but IE won't get the animation obviously), and the linktree area -- I'm not sure the homepage is the only place that has only one item. If it's not the case then we should change the other areas to have at least two items, /mesays.
@ Comments welcome.
Title: Re: New revs
Post by: Arantor on February 15th, 2011, 02:48 AM
Revision: 591
Author: arantor
Date: 01:47:47, 15 February 2011
Message:
! Kill 'enable sticky option', they're now wired on. (Surprisingly many files.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on February 15th, 2011, 09:40 AM
rev 592
(5 files, 8kb)

! Fixed and optimized math function in the CSS parser. I was pretty sure I'd tested it thoroughly, eh... (Class-CSS.php)
+ Added support for some basic PHP functions in math(), in case you need them: round, ceil, floor, abs and fmod. (Class-CSS.php)
* Moved gz Mime type overrides to the cache folder. (other/.htaccess, cache/.htaccess)
* Ensure WAP2 mode never uses more than .5em of whitespace between lines. (wireless.css)
* Made a code block more compact, because I've learned to hate it, and I don't want to see it anymore. (script.js)
Title: Re: New revs
Post by: Nao on February 15th, 2011, 01:32 PM
rev 593
(22 files, 23kb)

* Modified add_css_file() to use less parameters, allow for extension-less filenames and get files from the current styling, or their closest parent if unavailable. (install.php, Subs-Cache.php, Packages.template.php, Reports.template.php, Wireless.template.php, Xml.template.php)
* Renamed 'css' folder to 'styles', and updated related code. Haven't done it on the SVN yet to make it easier to spot changes, the actual renaming will be in the next commit. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, ManageBoards.template.php, Themes.template.php, */settings.xml, */index.css)
! The Bad Behavior code was using $context['html_headers'] at some point, instead of $context['http_headers']. (Security.php)
Posted: February 15th, 2011, 11:13 AM

rev 594
(n/a)

* Renamed css folder to styles.
Posted: February 15th, 2011, 11:27 AM

rev 595
(n/a)

+ Added .htaccess files to styling folders, preventing reading the CSS files for regular users. I may be paranoid, but no an android.

(Currently fighting with a tree conflict... Did 'rename' on my css folder, then committed and forgot to update it BEFORE committing, which is never mentioning anywhere... Because of that, I can't even touch my work folder anymore, I have to work from a clean folder. Grrr...)
Posted: February 15th, 2011, 11:36 AM

rev 596
(n/a)

+ Cleaning up my SVN... Committing two files that I thought I'd committed before: the actual button bevel (3D effect), and the script folder protection. (images/theme/bevel.png, scripts/.htaccess)

(Okay, I think my SVN is good now... Phew. I had to manually edit my SVN files, ah ah.)
Posted: February 15th, 2011, 12:10 PM

rev 597
(2 files, 4kb)

- Removed legacy PHP code. (install.php)
! Fixed wrong param number in preg_match_all. (Security.php)
Title: Re: New revs
Post by: Nao on February 16th, 2011, 12:18 AM
rev 598
(3 files, 11kb)

! Added a child div in the sidebar to account for a Chrome bug in "display: table-cell" blocks... Yay... (index.template.php, Warm/index.css)
! Fixed outdated JS code for the auto-resizer. Now it should correctly hide the sidebar before it starts doing crazy things. (index.template.php)
* Minor padding/margin/width tweaking in the sidebar. (index.css, Warm/index.css)
Title: Re: New revs
Post by: Arantor on February 16th, 2011, 12:58 AM
Revision: 599
Author: arantor
Date: 23:58:25, 15 February 2011
Message:
! Installer fixes: $to_header no longer defined for add_css_file, Subs-Cache would infinite loop due to missing $context['styles'], not to mention never actually finding the files it wanted. (install.php, Subs-Cache.php)
! Rewire board access to be based on a separate table, rather than the FIND_IN_SET against a text field. (install.sql, Load.php)

@todo
 Refit admin panel
 Provide facility for board/topic privacy to be configured since currently it is reusing the membergroups field to set $board_info['privacy'], though that doesn't appear to be used by anything right now.
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 17th, 2011, 03:33 AM
Revision: 600
Author: arantor
Date: 02:33:06, 17 February 2011
Message:
! Reinstate proxy handling for IPv6. Still needs more testing and match_cidr to be rewritten for IPv6 though. (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php
Title: Re: New revs
Post by: Nao on February 17th, 2011, 11:48 AM
rev 601
(3 files + 6 added, 22kb)

+ Added WarmWine (temp name of course), a child styling for Warm that basically reproduces the original Wine. There are a few differences but mainly in padding and stuff. (Warm/Wine/*)
! is_ipv4() wasn't using the given parameter. (QueryString.php)
! A better fix for the infinite loop in add_css_file(). (Subs-Cache.php, install.php)
Title: Re: New revs
Post by: Nao on February 18th, 2011, 04:46 PM
rev 602
(23 files, 167kb, plenty of search & replace but also plenty of manual fixing :P)

* Converted all remaining stylings to the new simplified CSS syntax. (styles/*)
! The clean_cache() function systematically deleted all files from the cache. As it is called by a scheduled task, added a parameter to prevent deleting CSS and JS files when they don't need it. They're still purged when going to the admin area and changing a file compression/obfuscation setting. (Subs-Cache.php)
! Typo in Pastel. (mad-width, ahah, that one should be standard.) (styles/index.css)
@ Moved Green stylings by mistake. Will move them back later... Don't want to screw up my svn copy again.
Title: Re: New revs
Post by: Nao on February 18th, 2011, 06:57 PM
rev 603
(11 files, 20kb)

+ If user doesn't have permission to view own or any profile, strip links leading to them. (QueryString.php)
* Minor tweaks to Pastel and Warm. (*.css)
Title: Re: New revs
Post by: Arantor on February 19th, 2011, 12:55 PM
Revision: 604
Author: arantor
Date: 11:54:58, 19 February 2011
Message:
! Sync to Bad Behavior 2.1.11
 ! Remove test for Google Wireless in anti-Google spoof as it is a special proxy not a search engine. (Security.php)
! Sync to SMF 10465
 ! (r10449) Cache bug in upgrader (upgrade.php)
 ! (r10466) Typo in forum profile loader, makes custom fields more internally consistent (Profile-Modify.php)
 ! (r10467) 64-bit created zip file decompression fix (Subs-Package.php)

Not implemented from SMF
 * r10447 Tweak of censored words UI (going to be rewritten anyway)
 * r10448 Shuffling of setlocale and time format in 2.1 branch, not convinced it is beneficial yet, and not convinced it doesn't have issues (it certianly has some issues in the hacky changes to Load.php if mb_* functions aren't available... like fatal errors)
 * r10450,10457-10459 Tagging 1.0.21, 1.1.13, 2.0 RC5, branching in 2.1/other
 * r10451 Pedantry and minor typo fix in converter (not applicable to us because the importer needs to be written from scratch anyway)
 * r10452 Conversions of substr($x, $y, 1) to $x[$y]... it makes it harder to follow and the speed factor is not hugely significant even if it is inside parse_bbc (it's *where* it's inside parse_bbc, in validate functions mostly)
 * r10453 Pedantry: removal of @ in front of ini_get/ini_set and ob_start calls
 * r10454 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10455 Removal of @ in front of set memory limit calls in converters
 * r10456 More == to === conversions
 * r10460 Yet more == to === in Post.php for 'testing commits'
 * r10461-3 Converting TYPE to ENGINE in upgrader scripts, then reverting it
 * r10464 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10465 Changing the 'clean attachment' to 'clear attachment' - we already revised the UI entirely
 * r10468 PostgreSQL specific fix in upgrader.
 * r10469 [2.1] "Replaced some strtr with str_replace and some strpos(strtolower()) with stripos() and some strtolower() == strtolower() with strcasecmp(). Just pedantic stuff."
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on February 20th, 2011, 11:56 PM
rev 605

* Upgrading Warm to default styling, and moving Pastel to its own folder. Doing it in two phases to avoid SVN conflicts.
Posted: February 20th, 2011, 11:48 PM

rev 606/607

* Moved Green and Green again to Pastel (will have to delete Green again, we got the point), cleaned up Pastel (will have to test tomorrow), and deleted the Warm subfolder. Hopefully it's all done now.
Title: Re: New revs
Post by: Nao on February 21st, 2011, 10:52 PM
rev 608
(7 files, 12kb)

* Renamed CSSCache class to wecss, to match the default naming style. (Class-CSS.php, Subs.php)
* Moved PIE.htc to the scripts folder, mainly because it's a JavaScript file really. (scripts/PIE.htc, Pastel/settings.xml)
* Swapped styling types for Warm and Pastel. (styles/settings.xml, Pastel/settings.xml)
! Updated default replacements blocks when the default styling is used. (Load.php)
! Fixed a minor bug in button padding. (styles/index.css)
Title: Re: New revs
Post by: Nao on February 21st, 2011, 11:43 PM
rev 609
(1 file, 1 line actually...)

* Added a workaround to support @-webkit-keyframes rules in the CSS parser. (Class-CSS.php)
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 03:21 AM
Revision: 610
Author: arantor
Date: 02:20:38, 22 February 2011
Message:
! Make sure board type is available to the board loader (Load.php)
! Refactor the code for getting who is in a board/topic for display, reducing duplicate code (MessageIndex.php, Display.php, Subs-MembersOnline.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 11:23 AM
Revision: 611
Author: arantor
Date: 10:20:21, 22 February 2011
Message:
+ Board topic order can be controlled by the database now, and there is the possibility of forcing any given board to be arranged in a particular way with no ability for user to override (install.sql, Load.php, MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/other/install.sql


In other words, the functionality of the 'board sort method' mod without the admin panel option (yet) for it. Functionality is managed in the database only right now (pending ACP overhaul), where sort_method dictates what method should be used to order boards, which is the full list ('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post') and sort_order dictates how it should be done.

natural_* indicates that it should be done as default but not forced (i.e. what happens when none is specified), forced_* indicates that this is the order to use and cannot be overridden by the user.
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 01:20 PM
Revision: 612
Author: arantor
Date: 12:14:44, 22 February 2011
Message:
+ More bbcode icon (Class-Editor.php, sprite.png, Post.english.php)
! Fixed more bbcode to actually work, it's only just inside a topic it should be empty, all other cases it should be firing, not just when we're inside a board, like it should in feeds (install.sql, Subs-BBC.php)
+ Modified feed handler such that if we have a limit on feed length, check whether the more bbcode is present and is set within the space of that limit - if it's inside the limit, or not too far outside, use more bbc instead of auto cropping. (Feed.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/images/bbc/sprite.png
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/other/install.sql

Posted: February 22nd, 2011, 01:15 PM

Revision: 613
Author: arantor
Date: 12:19:54, 22 February 2011
Message:
! Woops, forgot to put the query quite right. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 22nd, 2011, 03:40 PM
Revision: 614
Author: arantor
Date: 14:39:44, 22 February 2011
Message:
! Page indexes should include previous/next links to go with pages (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on February 22nd, 2011, 10:56 PM
rev 615
(4 files, 14kb)

! Made sure that single-line comments match "// " (with a space or tab) rather than just "//", e.g. in hardcoded URLs. (Subs-Cache.php)
* Removed roundframe div from info center, fixed indentation and simplified some areas. (BoardIndexInfoCenter.template.php)
* Show the small Wedge logo to the right of the footer, rather than next to the copyright info. (styles/index.css)
+ French translation. (Post.french.php)
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 05:15 PM
Revision: 616
Author: arantor
Date: 16:03:13, 24 February 2011
Message:
! Get the first post in each thread for blog posts in message index, also rework the ordering of operations so we censor before bbc parsing as appropriate (MessageIndex.php)
! A little rearrangement of the message index code, plus some indentinazi (MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 05:51 PM
Revision: 617
Author: arantor
Date: 16:51:24, 24 February 2011
Message:
! More cleanup of message index: moving the who's viewing to the sidebar. Not sure if the header to that needs to change though. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 06:01 PM
Revision: 618
Author: arantor
Date: 17:01:26, 24 February 2011
Message:
! And moving the online stuff to the sidebar in topics too. (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Nao on February 24th, 2011, 06:24 PM
rev 619
(6 files, 14kb)

* Heavily reworked the header area in Warm, and fixed a few glitches in the process. (index.css, index.template.php)
* Added a list-type disc next to menu items in the sidebar. I thought it would feel a bit more natural, as it's an actual unordered list... (sections.css)
! Fixed CSS parser failing to define variables when they were followed by a single-line comment. (Class-CSS.php)
* Renamed $alpha_matte to $alphamix. Don't ask. (Class-CSS.php, index.css)
+ Added a workaround to allow IE6 and IE7 to emulate rgba() in key areas. Because filters are CPU intensive, use with care. Basically, just follow your color variable or direct color with a "/hex". e.g. filter:gradient(startColorstr=$color/hex, endColorstr=$color/hex) should generate an alpha-blended background. (Class-CSS.php, ie6.css, ie7.css)
! Fixed CSS parser failing to parse alpha filters for IE. Maybe I should rename the function... But 'alpha' sounds so cool. (Class-CSS.php)

More coming... But this was the bulk of the commit really.
Title: Re: New revs
Post by: Nao on February 24th, 2011, 06:53 PM
rev 620
(9 files, 14kb)

* Some of the $memberContext areas were being initialized later in the process. Since they were always set up, it's slightly faster to set them up in the main array. (Load.php)
- Moved 'webkit' and 'gecko' further down in the list that sets up the 'agent' variable. This is to make sure we get the most precise current user agent. If you want to test whether a browser is using the Webkit engine, use $browser['is_webkit']. (Load.php)
* Not too fond of this one, but I added 'webkit' to the list of default stylesheets, in addition to the Webkit-based agent name. Maybe I should do the same with 'ie'... Or maybe I should just split webkit.css into as many files as required? (Load.php)
! Fixed indentation regarding the sidebar. Ouch. (BoardIndexInfoCenter.template.php)
! A French string was out of date. (index.french.php)
! Meta keywords are disabled by default... Changed wording to reflect that. (ManageSettings.english.php, ManageSettings.french.php)
! Fixed visibility for upper right switch. (script.js)
* Minor adjustments to the sidebar width in Pastel. (Pastel/index.css)
- Deleted an unused $board_info. (Class-Editor.php)
Title: Re: New revs
Post by: Arantor on February 24th, 2011, 08:43 PM
Revision: 621
Author: arantor
Date: 19:43:01, 24 February 2011
Message:
! More tweaks: moving the icon legend into the sidebar, and moving the navigation menu out of the theme entirely (it should never have been there in the first place) (MessageIndex.php, MessageIndex.template.php, index.english.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on February 24th, 2011, 09:18 PM
rev 622
(3 files, 6kb)

+ Show all available language flags in the bottom left corner. I totally hate global'ing $user_info just to get one variable (I should move that one) and glob'ing an entire folder on every single page to find the flags, so if you have a better implementation or want to add some caching... Please do it! :^^;: (index.template.php)
! Fixed size and rating for gravatars. (Subs.php)
* Don't show the 'webkit' name twice in the URL for browsers that use WebKit but aren't Safari, Chrome or Android stuff. If that even exists. (Load.php)

:edit: My main goal was to add the friggin' flags to the top bar, to bring it closer to the wedgeforum goodies. I really don't like having flags shown that way, and the extra hit per language available, things like that... But I can hardly do any better -- I mean, it's not like it's hardcoded so I can't do a sprite like here.
Title: Re: New revs
Post by: Nao on February 24th, 2011, 11:10 PM
rev 623
(forgot to log stats.)

* Modified previous/next links in Display template to be shown in a <we:cat> instead, next to the topic title at the top, and next to the jump box at the bottom. This should help differentiate between page prev/next and topic prev/next. (Display.php, Display.template.php, sections.css)
* Forgot to apply rgba() fix to IE8. (ie8.css)
* French translation. (index.french.php)
* Indenazi. (index.template.php)
Title: Re: New revs
Post by: Arantor on February 25th, 2011, 02:37 AM
Revision: 624
Author: arantor
Date: 01:36:36, 25 February 2011
Message:
! $db_prefix was not being properly updated when no DB selection was taking place (i.e. SSI) (Class-DB.php)
----
Modified : /trunk/Sources/Class-DB.php


This was an Arantorbug™. Nailed now though.
Title: Re: New revs
Post by: Arantor on February 25th, 2011, 12:27 PM
Revision: 625
Author: arantor
Date: 11:27:30, 25 February 2011
Message:
! Avatars brought onto the server did not always get the .ext extension they should have had. (Profile-Modify.php, Subs-Graphics.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Graphics.php
Title: Re: New revs
Post by: Arantor on February 25th, 2011, 04:40 PM
Revision: 626
Author: arantor
Date: 15:37:44, 25 February 2011
Message:
! Preliminary blog support in the template (MessageIndex.php, MessageIndex.template.php)
! The 'you have saved as a draft' is now a subtemplate in its own right and called through layers. (MessageIndex.php, MessageIndex.template.php)
! Moving the stable icons arrays to a central place to encourage them to remain consistent (Display.php, MessageIndex.php, Search2.php, Subs.php, Unread.php, Unreadreplies.php, SSI.php)
+ Android posting icon for Android devices. It sucks, sorry. But all the logos I see have a white border to it and 16x16 isn't very big. More icons to come though. (android.gif, Post2.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/post/android.gif
Title: Re: New revs
Post by: Arantor on February 27th, 2011, 02:22 AM
Revision: 627
Author: arantor
Date: 01:22:10, 27 February 2011
Message:
! Added RSS block to sidebar, removing RSS feed links from footer, display and message indexes. Layout's not set in stone, just that we get to declutter the menu bars this way, and make it easier to find the RSS links. (index.php, index.english.php, index.template.php, Display.template.php, MessageIndex.php, feed.png)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/Display.template.php
Added : /trunk/Themes/default/images/icons/feed.png
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on March 2nd, 2011, 04:41 PM
He's back, and kickin'!! 8-)

rev 628
(20 files, 34kb)

* Converted Pastel to inherit Warm. Yay. Now I won't break it every single time I change the markup... (Pastel/*)
* Reworked user box in the sidebar. A bit better. Not perfect, yet. (index.template.php, index.css)
- Removed the "Topic:" from topic titles. Like it was needed, uh... (Display.template.php)
- Removed the filler text in the sidebar. It's filled with stuff, now. Eh. (index.template.php)
! Fixing some styling logic problem that lacks it (logic). Anyway. (Load.php)
* Why show three empty anchors when we need only one? (Display.template.php)
* Moving the Jump To box to the very bottom. Dunno if it's better -- logically it is, but it makes the quick reply box less accessible... Hmm. (Display.template.php)
! That's we:title2, not we:title. (Display.template.php, index.template.php)
! Guests would trigger error messages because $context['button_list'] was empty for them. Maybe we should just avoid unsetting it... (MessageIndex.template.php)
! I can't believe I actually used a valign="top" again... Me, of all people!! (index.template.php)
! Language flags always had "Français" as their title. Oops. (index.template.php)
* Made the "Unread posts" and "Unread replies" texts a bit shorter. Whatever. (index.english.php)
* French translation update and fixes. (index.french.php, Install.french.php)
* Spacinazi, indenazi. (Themes.php, Display.template.php, index.template.php, Profile.template.php)
* Various minor CSS optimizations and fixes. (admin.css, index.css)
Title: Re: New revs
Post by: Nao on March 2nd, 2011, 05:54 PM
rev 629
(6 files, 9kb)

! Some fixin' for IE in Pastel and stuff. (Pastel/ie7.css, Pastel/ie8.css, Pastel/sections.css, rtl.css, sections.css)
* Moved jump box back above the quick reply area. (Display.template.php)
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 01:28 AM
Revision: 630
Author: arantor
Date: 00:28:32, 03 March 2011
Message:
! Get the correct posts with pagination, and ordering, based on whether this is a board or blog topic. (Display.php)
----
Modified : /trunk/Sources/Display.php
Title: Re: New revs
Post by: Nao on March 3rd, 2011, 11:06 AM
rev 631
(5 files, small commit)

* $user_info['host'] should have the real host, not the fake one. I'm starting to get lost with all of this Pretty URL crap... (Load.php, QueryString.php, Subs-Cache.php)
* Updated Microsoft CDN URL for jQuery. Heck, the new URL is so ugly. Who wants to use that? (Load.php)
! Fixed menu not opening correctly in IE6 with Pastel. This was due to Belated_PNG taking too much time rendering the page background or something, so I simply replaced the PNG with a gradient filter. Magic. (Pastel/ie6.css)
* Spacinazi. (Pastel/ie6.css, Pastel/index.css)
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 11:35 AM
Revision: 632
Author: arantor
Date: 10:33:49, 03 March 2011
Message:
! A bit of reorganisation of the display template, likely more to come (Display.template.php)
! Don't allow merging the first reply into the post unless we're actually in a board context (so no merging the first reply to a blog post, for example) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Nao on March 3rd, 2011, 04:29 PM
rev 633
(4 files, 12kb)

+ Now showing topic titles and direct links instead of 'Previous' and 'Next' in the prev_next area. Because it's a complicated addition, I'm committing it for reviewing purposes only. (Display.php, */sections.css)
! Modified some board type logic to use != 'board' instead of == 'blog'. Hopefully more future-proof? (Display.php)
* Slightly reworked the linktree in Pastel. (Pastel/index.css)
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 05:07 PM
Revision: 634
Author: arantor
Date: 16:07:38, 03 March 2011
Message:
! Do not check for union or subselects in the query engine, we might use them. (Class-DB.php)
! Oops, forgot to bring $modSettings into scope (Display.template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Arantor on March 3rd, 2011, 05:13 PM
Revision: 635
Author: arantor
Date: 16:12:57, 03 March 2011
Message:
! Fix counting of replies for multi-page non-forum topics, so we don't display "reply #x" when we shouldn't. (Display.php)
----
Modified : /trunk/Sources/Display.php
Title: Re: New revs
Post by: Nao on March 3rd, 2011, 06:30 PM
rev 636
(1 file, 3kb)

- Prev/next queries no longer need the enableQueryCheck hack. (Display.php)
! Forgot to take the board ID into account for blogs. (Display.php)
Title: Re: New revs
Post by: Nao on March 4th, 2011, 08:26 PM
rev 637
(27 files, 33kb)

! Various fixes to installer glitches or indentation. (install.php, install.css)
* Use the Google CDN by default to retrieve jQuery. (install.sql)
* Implemented custom sorting into prev/next code. Leaving the extra code commented out in case we want to optimize later. (Display.php)
* Did some serious fixing for prev/next layout. (Display.template.php, index.template.php, ie6.css, ie7.css, index.css, Pastel/index.css, Pastel/sections.css, sections.css, Wine/index.css)
* Started using on_timeformat() instead of timeformat() for some areas. Also, $txt['on'] is not clear enough. I'm sure there are languages where it sounds awkward, so I added $txt['on_date'] for use in sprintf() calls. Needs more conversion work! (Display.php, Recent.php, Search2.php, index.english.php, index.french.php, Recent.template.php, Search.template.php)
* Started converting some <label for=""> tags to just <label>. (TEMPLATES: Admin, Announce, Errors, ManageAttachments)
+ Added support for box-sizing CSS property. (Subs-Cache.php)
+ Added img_blankGif() function. Unused for now, but it may prove useful in the future. (Subs.php)
- Removed PIE.htc and support for border-radius in IE6/7/8. That's what you get when you suck, IE! (PIE.htc, Pastel/settings.xml)

I started work on a few simplifications as you can see (labels, on_date), but I'm a bit tired with it... Do you think you could do the rest, Pete? At least for on_timeformat... label stuff is repetitive crap that I can do mindlessly ahah.
Title: Re: New revs
Post by: Nao on March 5th, 2011, 04:44 PM
rev 638
(16 files, 25kb)

* Updated the RSS block to align links next to each other. This looks better. (index.template.php, index.css, index.english.php, index.french.php)
* Updated Pastel and inherited styles to use .cat and .title instead of .cat_bar and .title_bar... This should make it easier to update Warm without breaking the rest. (Pastel/*)
! Undefined index error. (ManageServer.php)
Title: Re: New revs
Post by: Nao on March 5th, 2011, 08:16 PM
rev 639
(4 files, 13kb)

+ Implemented string cutter, direct from Aeva Media. Hopefully it works. (Class-String.php)
* Cut prev/next topic titles if they're too long for the header. (Display.php)
- No need for the top subject template anymore... (Display.template.php, topic.js)
Title: Re: New revs
Post by: Nao on March 5th, 2011, 10:13 PM
rev 640
(8 files, 11kb)

* Moved "Read x times" to the sidebar, and added sidebar stats for boards/blogs and topics. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php, index language files)
! Fixed wrong margin in the sidebar userbox. (index.css)
! Pixel-perfect. (Pastel/index.css)

NB: It'll be longer to implement actual per-board stats, though... Just getting the number of posts and topics is boring. We need something like Noisen with the number of different posters as well as specific stat pages for each board.
Title: Re: New revs
Post by: Nao on March 6th, 2011, 12:14 AM
rev 641
(1 file, 5kb)

+ A short but nice one... Drop a "custom.css" file to any of your style folders, and you can change that styling without the need to create a sub-styling (or, worse, editing the supplied styling files.) (Subs-Cache.php)
Title: Re: New revs
Post by: Arantor on March 6th, 2011, 01:42 AM
Revision: 642
Author: arantor
Date: 00:42:06, 06 March 2011
Message:
! Incorrect sprintf formatting in English string (index.english.php)
! Fixed board RSS feeds having Array instead of the board id (index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on March 6th, 2011, 03:48 AM
Revision: 643
Author: arantor
Date: 02:43:21, 06 March 2011
Message:
! Attempt to fix ordering for prev/next topics (Display.php)
----
Modified : /trunk/Sources/Display.php


OK, this is a WIP fix. It deals with all the cases where we don't need the poster's name (first poster/last poster), I thought this was supplied by $topicinfo but it isn't.

The second problem is that invariably, the second query in the UNION sucks, and I mean *really* sucks. Right now I'm seeing 1.5s or more, but the reason is the way MySQL handles that selection on my 209k topic board; it's not using an index because it figures a table scan will be faster, but ultimately ends up filesorting the lot - here's the subselect on its own:

Code: [Select]
EXPLAIN SELECT t2.id_topic
FROM wedge_topics AS t2
INNER JOIN wedge_messages AS mf ON ( t2.id_first_msg = mf.id_msg )
WHERE t2.id_board =1
AND t2.id_topic <209240
ORDER BY t2.is_sticky DESC , t2.id_topic DESC
LIMIT 1


id   select_type   table   type   possible_keys   key   key_len   ref   rows   Extra
1   SIMPLE   t2   range   PRIMARY,first_message,id_board,last_message_sticky...   PRIMARY   3   NULL   209239   Using where; Using filesort
1   SIMPLE   mf   eq_ref   PRIMARY   PRIMARY   4   wedge.t2.id_first_msg   1   Using index

(t2 used in case MySQL was crapping itself between what t was, but it doesn't matter in this case, it makes no difference)

We gotta figure out a better way of handling this, it's not even using the primary key as a sorting criteria. :( But at least the ordering seems to be right now for the given criteria...
Title: Re: New revs
Post by: Nao on March 7th, 2011, 10:03 AM
rev 644
(16 files, 50kb -- all of my changes from this weekend. Didn't get to commit them until now.)

! Fixed a couple of bugs in westr::strlen and westr::strpos. (Class-String.php)[1]
* Rewrote theme thumbnail system to use thumbnail.jpg (instead of thumbnail.gif) and have them in their corresponding style folders, rather than in the images folder. (Themes.php, Themes.template.php, thumbnail.gif, Settings.english.php, Settings.french.php)
* Modified terminology of "child boards" to become "sub-boards" instead. Kept all variable names, we're only changing the English language for this. (LANGUAGES: Help, index, ManageBoards, ManageMaintenance, Profile)
! Fixed some minor font issues in the menu system. They were apparent in Windows XP + ClearType, maybe in other systems too. (index.css)
+ Added TEMPORARY thumbnails for Warm, Pastel and Wine. Need to do them again with a clean install... (thumbnail.jpg)
 1. Still warrants a recheck ;) Most notably, I'm not sure why there's the STRPOS* const at all, since basically it's only being used alongside "|." and could easily be replaced with "ENTLIST|." if you catch my drift.)
Title: Re: New revs
Post by: Nao on March 7th, 2011, 06:57 PM
rev 645
(22 files, 33kb)

+ Added a RSS icon for board categories. (BoardIndex.template.php)
+ Added ability to prevent a small image from being inlined in CSS files, through url-no-base64(). Useful for graphics that only show up in the admin area, things like that. Although really you want to put these declarations to admin.css instead... (Class-CSS.php, sections.css)
* Rewrote the toggler object to avoid wasting hits on graphics. bToggleEnabled was removed (if you don't want to run the toggler, just don't initialize it in the first place), srcExpanded and srcCollapsed are replaced with background positioning. Converted most togglers, more left to do. (BoardIndex.php, script.js, stats.js, topic.js, index.css, sections.css, foldable.gif, shrinkable.png, sortselect.gif, TEMPLATES: Admin, BoardIndex, BoardIndexInfoCenter, Display, index, ManagePermissions, Packages, PersonalMessage, Post, Search, Stats)
! Fixed default styling's thumbnail in theme picker, in case the default isn't in the root. (Themes.template.php)
! Fixed styling in daily stats called through Ajax. (stats.js, sections.css)

NB: I've tested 95% of all togglers. Hopefully, there aren't any bugs left... I know, the new system is less flexible (requires spriting your stuff, and having it in doubled square dimensions, e.g. 20px*40px or 12px*24px), but OTOH it saves a hit, and it has less 'glitches' than the SMF method. That's why, ultimately, I figured the pros outweighted the cons.
Title: Re: New revs
Post by: Nao on March 7th, 2011, 09:18 PM
rev 646
(17 files, 17kb)

* Reworked the toggler spriting system to use a class toggler instead of changing background-position. This way, spriting is no longer mandatory, and two different images can be used in the CSS. (script.js, stats.js, topic.js, sections.css, TEMPLATES: index, ManagePermissions, PersonalMessage, Search)
* Don't bother specifying altCollapsed and msgCollapsed if they're identical to altExpanded and msgExpanded. (BoardIndex.php, script.js, stats.js, TEMPLATES: Admin, BoardIndex, index, ManagePermissions, Packages, Post)
! Fixed stats header layout and colors. (Stats.template.php, index.css, Wine/index.css)
* Converted category collapse code to the new system. (Subs-BoardIndex.php)
* Improved header in Wine. (Wine/index.css)
Title: Re: New revs
Post by: Nao on March 8th, 2011, 01:05 AM
rev 647
(21 files, -4 files, 19kb)

* Converted maintenance area to use sprited collapse, and fixed code in the topic management page. (ManageMaintenance.template.php)
- Removed earlier files that are no longer used anywhere in Wedge. (collapse.gif, expand.gif, upshrink.png, upshrink2.png)
* More Wine style details. (Wine/index.css)
* Rewrote silly array[array.length] = x calls into array.push(x)... (smfinfo.php, Class-Editor.php, ManageSmileys.php, editor.js, fader.js, post.js, script.js, spellcheck.js, stats.js, topic.js, TEMPLATES: Calendar, Display, ManageCalendar, ManagePaid, MessageIndex, PersonalMessage, Post, Search)

Note: generateDays() uses dayElement.options[dayElement.length]. It should probably be dayElement.options[dayElement.options.length] and I treated the conversion this way. Hopefully nothing was broken in the process... I only tested the JumpTo stuff (it works fine.)
Title: Re: New revs
Post by: Nao on March 8th, 2011, 03:16 PM
rev 648
(8 files, 15kb)

* Plenty of fixes, simplifications and optimizations for string-related functions. (Class-String.php)[1]
* Rewrote string cutter to: fix strlen/substr when mb_* functions aren't available, fix mb_* when available (forgot to force them to UTF), and avoid cutting the ellipsis in half with a soft hyphen. Yes, it was possible to do that... Uh. (Class-String.php)
* Renamed {query_see_only_board} to {query_list_board} and {query_wanna_see_only_board} to {query_wanna_list_board}, and related variables. It means 'make sure the board can be listed', as opposed to not only listed, but also browsed. (Load.php)
! Added query_wanna_see_board to ssi_topTopics() for very large boards. If performance is an issue... Just don't use SSI, all right? (SSI.php)
* Replaced operator/notoperator with proper >/< signs. Saves a bit of processing time... (Display.php)
* Made the category collapse image stylable. (Subs-BoardIndex.php, sections.css)
* French translation tweak. (index.french.php)
* Single-byte-nazi. (Class-Editor.php)
 1. Pete, if you're unsure about any of these, feel free to ask and I'll explain my changes ;)
Title: Re: New revs
Post by: Nao on March 8th, 2011, 07:53 PM
rev 649
(30 files, 33kb... All done manually and double-checked at commit time >_<)

- Replaced all <label for="..."> occurrences with just <label> whenever it was possible. (install.php, Display.php, Profile.php, Subscriptions-PayPal.php, SSI.php, TEMPLATES: Admin, Display, ManageBans/Boards/Maintenance/Membergroups, ManageMembers/News/Paid/Search/Smileys, Memberlist, ModerationCenter, MoveTopic, Packages, PersonalMessage, Poll, Post, Profile, Register, Reminder, Reports, Search, SplitTopics, Themes)

NB: I removed the associated id in a minority of cases -- stopped when it proved too dull to do as I had to check whether JavaScript used these ids at all. Sounds like a job half done, but... 'screw you, I'm going home.' All I can say is that it's best to remove the id in loops (I tried to do it as much as possible), and in pages that get visited often. (Didn't look hard for these, though. But I know the setting pages in the profile area don't seem to use the id's too much. Or at all. Still -- I'm done. Too boring!)

:edit: I also didn't touch some of the 'other' folder's files. Too boring, once again, for files we may not even keep...
Title: Re: New revs
Post by: Arantor on March 11th, 2011, 10:58 AM
Revision: 650
Author: arantor
Date: 09:50:11, 11 March 2011
Message:
! Fix ordering to support topic starter/last poster name sorting. It's not pretty, but it's not a common case, and there isn't really a way to optimise it any better without nailing up queries that will have even more impact. (Display.php)
----
Modified : /trunk/Sources/Display.php

Posted: March 11th, 2011, 10:50 AM

Revision: 651
Author: arantor
Date: 09:57:52, 11 March 2011
Message:
! Remove the ambiguous (and often unnecessary) join that should have been committed last time, oops. (Display.php)
----
Modified : /trunk/Sources/Display.php
Title: Re: New revs
Post by: Nao on March 11th, 2011, 03:09 PM
rev 652
(2 files, 7kb) -- just so that I can focus on other things...

* Removed $ent_list and $ent_check variables from westr (not used), and replaced them with $can_mb, which determines whether mb_* functions are supported. Maybe it's slower than an is_callable, I don't know, I don't care. (Class-String.php)
* Force UTF-8 encoding on mb_* functions. Just wanted to point out that UTF-8 is not always the default charset in mb functions. (Class-String.php)
! Fixed an undefined index in westr::strpos(). (Class-String.php)
* Made westr::strlen() about 3 times faster by saving an extra round of preg_replace and using mb_strlen if available. (Class-String.php)
* Tweak on poll option margins. (sections.css)
Title: Re: New revs
Post by: Nao on March 13th, 2011, 09:26 PM
My work for the weekend... (Not including a few WIPs.)

rev 653
(5 files, 10kb)

+ Added support for automatic quote splitting. (editor.js, post.js)
* Allow single-character selectors (a, p...) to extend something else. (Class-CSS.php)
! Fixed self::strlen() not working in itself. (Class-String.php)
! Fixed regression in preg_split's. (Class-String.php)
! Fixed in-topic moderation checkboxes. (topic.js)
Posted: March 13th, 2011, 08:47 PM

rev 654
(2 files, 8kb)

+ Added a 'wip' folder (Works in progress), because we need some place to commit stuff that is either not finished but could use retooling, or finished but not actually used anywhere. (other/wip, other/wip/text-overflow.js)
* Minor restyling of topic titles. (sections.css)
Title: Re: New revs
Post by: Nao on March 13th, 2011, 11:23 PM
rev 655
(2 files, 6kb)

* Wedge now correctly uses the current list of protected and self-closed tags (disabled or not), to build the list of exceptions for the auto-quote splitter. (Class-Editor.php, post.js)
! Fixed selectionStart processing in IE. (post.js)
! Fixed an error in JS logic... Well, actually, fixed the error popup, not the actual error. Will need some extra work... (post.js)
Posted: March 13th, 2011, 11:18 PM

rev 656
(+1 file, 6kb... Err, the file itself is 107 bytes though :P)

! Fixed sidebar position in Firefox when in hidden mode. (gecko.css)

:edit: the bug showed up in Wine. I fixed it in Warm so hopefully it was theme-wide, not Wine-wide. Otherwise the file needs to be moved to the Wine folder ;)
Title: Re: New revs
Post by: Nao on March 15th, 2011, 05:42 PM
rev 657
(4 files modded, 3 deleted, 9 added, 48kb)

* Replaced foldable system with a simple div instead of the cool, but slightly annoying inline blank image. This saves a total of 83 bytes per call. (index.css, sections.css, upshrinks.png, index.template.php, BoardIndexInfoCenter.template.php, more files to come.)
+ Added other/images folder, where we should store 32-bit, unedited versions of our icons and such before optimizing them for filesize. The menu sprite, I'm afraid, is a bit outdated, but I couldn't find a fresher copy. (buttons-32bit.png, quickbuttons-32bit.png, sprite-32bit.png, sprite-32bit (menu, old).png, upshrinks-32bit.png, also moved foldable.gif and shrinkable.png)
Title: Re: New revs
Post by: Nao on March 16th, 2011, 12:16 PM
rev 658
(12 files, 16kb)

* Applied new foldable code to category collapsing and news. Also fixed plenty of minor issues regarding IE support for these icons. Grmpf. (Subs-BoardIndex.php, BoardIndex.template.php, ie6.css, ie7.css, index.css, rtl.css, sections.css
* Removed #boardindex_table id and used #board_list instead. Also indenazi and added a placeholder class for category RSS icons. (BoardIndex.template.php, */settings.xml)
* Topic titles need different things. They can't use we:cat anymore. Let it go, now. We need the freedom to style these. (Display.template.php)
! Fixed validation on IE6/7. Not that anyone cares... (index.template.php)

As always... Some complicated shit! Also, can't get category collapse icons to show both states in IE6 because of its inability to style two classes at once. It works in other icons only because they're linked to a smc_Toggle() object. I changed the order from &.fold to .fold& (which, admittedly is uglier), because I think it's best to always see the "-" icon, rather than either the "+" icon or no icon at all...
Title: Re: New revs
Post by: Nao on March 18th, 2011, 04:45 PM
rev 659
(4 files, 9kb)

+ Added support for browser-specific CSS mixins. Example: mixin {ie6,ie7} sample(attribute: 0px) (Class-CSS.php)
! Enforced removal of child selectors when parsing class extensions for IE6. Basically, without this, the entire list of inherited selectors is discarded. (Class-CSS.php)
! Fixed CSS cache file URLs (should start with "Wedge" for the default styling, not "styles".) (Load.php)
! Always load settings.xml, even if we're using the default styling. IE6 still needs the freakin' help with transparent PNGs... (Subs-Cache.php)
! Fixed JS error in stat page when using IE6. (stats.js)

(Just committing the easier stuff. ;))
Title: Re: New revs
Post by: Nao on March 18th, 2011, 11:14 PM
rev 660
(23 files, 58kb)

+ Added support for complement() alias function in the CSS parser (equivalent of hue(color, 180) or hue(color, 50%)). (Class-CSS.php)
+ Added support for custom color functions through a hook (untested, though.) (Class-CSS.php)
* Replaced regular board status icons with a sprite that makes it possible to change the icons in stylings. Because IE6 doesn't support transparent PNGs and we don't want to waste time over it, I'm using a special, smaller version of the sprite with no transparency effect. Also, these new class names suck... Anyone got a better idea? (boardstatus.png in both PNG8 and PNG32, boardstatus-ie6.png, sections.css, ie6.css, BoardIndex.template.php, MessageIndex.template.php)
+ Added a 'ping' class to images with a transparent PNG. (Admin.template.php, and... Is that all? Is there really no other PNG32 image left?)
* Replaced toggler icons with sprited versions, and made them stylable as well. Some places in the admin area still require an update. It doesn't work well in IE6, but you know the drill... Screw you, IE6. (Display.template.php, Post.template.php, Search.template.php, gecko.css, sections.css)
* Moved bottom linktree to below the content area, allowing for more precise fine-tuning of its styling. (index.template.php)
* Lots, lots of fixes for IE6. Also fixed a couple of issues with IE. Warm and Wine should now be closer to their modern browser appearance. The 'grey' color isn't recognized in IE6, so changing it to the Americanish 'gray'. And changed the transparent PNG process to be much faster. (ie6.css, Wine/ie6.css, ie7.css, index.css, settings.xml, Wine/index.css, Wine/settings.xml, Wine/ie7.css, Wine/ie8.css)
* Changed topic pages to show titles in a new .posthead div, inherited from .cat -- technically, there's no reason to force all cat's to be table-based when it's really only used in that single place. (ie6.css, sections.css)

This is the big bulk of my changes to the CSS. Pete, you'll need to make sure your styling isn't broken by my changes to Wine!
Title: Re: New revs
Post by: Nao on March 18th, 2011, 11:42 PM
rev 661
(the "I'm going to bed, just want to be done with these..." revision)

* Updated boardstatus.png with a version that is 40% smaller and doesn't show any significant decrease in quality. (boardstatus.png)
* Pixelnazi. (sections.css)
- Board list no longer needs a PNG fix, eh... (settings.xml)
* Windowbg needs one, though. (Wine/settings.xml)
Title: Re: New revs
Post by: Nao on March 20th, 2011, 09:31 AM
rev 662
(3 files, 5kb -- interim release...)

! Typo in clean_cache. Thanks Aaron! (Subs-Cache.php)
! Don't bother splitting quotes when the open tag list is empty... (post.js)
- No need to PNGize #board_list img anymore. (Pastel/settings.xml)
Title: Re: New revs
Post by: Nao on March 20th, 2011, 07:54 PM
rev 663
(7 files, 15kb)

+ Added a new custom CSS property, 'gradient-background', which allows you to set a transparent background, or a (transparent or not) gradient background. The point is that, in addition to vendor tags, it also deals with IE and makes it compatible with IE 6-9. Only supports vertical gradients for now. (Class-CSS.php, ie6.css, ie7.css, ie8.css, index.css)
! Fixed a bug introduced in revision 76 which caused Firefox not to be detected in $browser. Yeah, that's an old one... Goes to show how much we test in Firefox, eh..? Or just the fact that it doesn't need too many hacks. (Load.php)
- Removed the ugly '/hex' solution for IE filters, since gradient-background will now take care of that. Moved color conversion to its own area, saving some processing time for other browsers. (Class-CSS.php, Subs-Cache.php)

Note: the gradient-background() function is still a bit... fragile. Meaning, it won't work with #rrggbb values, things like that. It only takes rgb, rgba, hsl and hsla as values, or color functions (when they return a non-# value). I will need to fix that, obviously... Also, just specifying one color ("gradient-background: rgba(0,0,0,.5)") will simply make it act as a "background-image: rgba(0,0,0,.5)", with an automatic fallback for IE (which was the goal, after all.)
Please comment on it -- whether you like it or not! ;)
Title: Re: New revs
Post by: Nao on March 21st, 2011, 04:59 PM
rev 664
(11 files, 18kb)

+ Added a third optional parameter to gradient-background, top/left which determines whether the gradient is vertical or horizontal. (Class-CSS.php)
* gradient-background should now accept any kind of color parameter. Untested, though. (Class-CSS.php)
* Optimized rgba emulation for IE and generally reworked the wecss class's structure, for whatever reason I don't remember. But it was probably a good one. (Class-CSS.php)
! IE8 doesn't support rgba(), either... I tend to forget that even that version sucks. (Subs-Cache.php)
* Trying to save a few milliseconds in IE6 when resizing the screen. On the other hand, I should disable it altogether for IE6, as it doesn't really work with it... (index.template.php)
* Moved the top linktree to the root, and renamed .linktree to #linktree and .linktree.bt to #linktree_bt (inherited). Should make it easier to style. (index.template.php, index.css, rtl.css, Pastel/index.css)
! Fixed some foldable icon margins and other glitches. (sections.css, Wine/index.css, Pastel/ie6.css)
- Debug code. (Post.template.php)
Title: Re: New revs
Post by: Nao on March 24th, 2011, 10:07 PM
rev 665
(3 files +1, 17kb)

! Fixed a potential undefined variable error when applying mixins. (Class-CSS.php)
! Added support for Safari gradients. Newer versions of the browser were fine, but not the current ones. (Class-CSS.php)
! It would seem that some versions of PHP, or whatever, don't support self::method calls inside a preg_replace_callback. Changed these to array($this, 'method'). (Class-CSS.php)
* Made French version clearer for keyboard shortcuts in the post box. (Post.french.php)
+ Added a different mini-logo in the Wine footer. (Wine/index.css, wedgesight.png)

None of this is about vertical alignment. I committed everything NOT related to it, actually. I'm strongly considering reverting my current local changes because, well... It's probably not worth all the trouble in the end.
Title: Re: New revs
Post by: Nao on March 25th, 2011, 11:12 AM
rev 666
(14 files, 21kb)

! A selector followed with "extends something" needed to have at least one child property (the alternative being to use "base: something" as a property) -- this is no longer the case, indentation is enough to point out that the selector is just supposed to inherit something else. (Class-CSS.php)
! Some fixes to the object logic (visibility and instances). I'm starting to grasp how it works. Yay. (Class-String.php)
! Re-split top page IDs into three single anchors as they used to be. This is because the page won't validate otherwise. Uhhhhh. (Display.template.php)
- Don't show the window resize script in IE6 and IE7, as the current table-based solution isn't out-of-the-box compatible with the display:table one. Also made the related function a bit shorter. (index.template.php)
* we:title2 should only be used when within a hierarchy below we:title... Also, RSS header text was missing some white space. (index.template.php)
- Removed 'p' tags inside prev/next links. They were a leftover from a previous hack... (Display.php)
- $substr wasn't used in westr::cut. (Class-String.php)
* More stuff needing white space. (Stats.template.php)
* Indenazi. (index.template.php, Memberlist.template.php)
* Some 'Allons-y, Alonso!' tweaks to the language files. (index.*.php)
* Tidbits. Dozens of minor changes that aren't worthy of a changelog line, but are still there. Mostly, remnants of my epic but failed attempt at introducing a general vertical alignment process. (Post.template.php, ie6.css, ie7.css, index.css, sections.css)
Posted: March 25th, 2011, 11:11 AM

Note: I forgot to add the Class-CSS.php file to the commit list. Will be in #667, as soon as I find a sec' to look into the instance crap.
Title: Re: New revs
Post by: Nao on March 25th, 2011, 11:42 AM
rev 667
(5 files, 10kb)

* Changed headers to actually use the header tag now... Might as well start using HTML5 tags now! (*/settings.xml)
! Oops, forgot to actually commit Class-CSS in the previous rev... (Class-CSS.php)
* Turned gradient_background and rgba2rgb into static methods, and fixed rgba2rgb to actually stop using class variables. (Class-CSS.php)
! Forgot to add a PNG workaround for IE6 in Wine's footer logo. (Wine/settings.xml)
Title: Re: New revs
Post by: Nao on March 25th, 2011, 02:07 PM
rev 668
(28 files, 26kb)

* Updated the official website link from wedgeforum.com to wedge.org
Title: Re: New revs
Post by: Nao on March 25th, 2011, 05:09 PM
rev 669
(5 files, 7kb)

! Fixed wrong alignment for category headers in IE6. (BoardIndex.template.php)
! Fixed header styling in browsers that don't support the header tag. Uh. (index.css)
! Fixed more IE6 issues: menu toggler arrow in IE6, and various minor details. (GenericMenu.template.php, ie6.css, index.css, rtl.css)
Title: Re: New revs
Post by: Nao on March 26th, 2011, 02:20 PM
rev 670
(5 files +1, 20kb)

+ Added support for version number of main browsers (IE, Opera, Firefox, Chrome, Safari), via a floating point number. (Load.php, Class-CSS.php)
- Removing a work in progress that I committed by mistake in the wedge.org renaming batch: alternative quote handling in Post.php. Moved it to the wip folder instead. (Post.php, other/wip/Post-alt-quotes.php)
@ Also committed another WIP by mistake, in Load.php this time, but it's working, so I'm leaving it in, hopefully we'll end up using it: on_date() function in Subs.php, which does all the work on 'on January 1st / today' formatting. It's just a single line though... (Subs.php)
! Board status icons were broken in IE6. (ie6.css)
- Removed useless img styling. (Pastel/index.css)
Title: Re: New revs
Post by: Nao on March 27th, 2011, 05:04 PM
rev 671
(13 files +1, 17kb)

* Moved img_blankGif() to a new wip file (Unused.php, where we should add all of our code snippets that aren't used but may be used in the future), and updated all files to use divs instead of these blank images. (other/wip/Unused.php, Subs.php, Admin.template.php, ManageMaintenance.template.php, ManagePermissions.template.php, Packages.template.php, PersonalMessage.template.php)
* Cleaned up the alt tags in togglers. (script.js, and a file of the above files.)
- Don't bother retrieving Safari/* version numbers, because we care about the Version/*, not the build number. (Load.php)
! Added a temp fix to set the left margin to zero in the user box if no avatar is selected. (index.template.php, index.css)
! Fixed potential XML error. (ManageServer.php)
* Minor tidbits. (member.css, Pastel/index.css)
Title: Re: New revs
Post by: Nao on March 29th, 2011, 10:39 PM
rev 672
(17 files, 19kb)

+ Added support for the $language variable in cached CSS files. Will be useful once I move the 'New' icon to CSS. (Subs-Cache.php)
! Make sure the index template is loaded before we add the RSS sidebar block. It would crash on $simpleActions otherwise. (index.php)
* $context['is_ajax'] isn't the only case where the chrome should be hidden, so I introduced a $context['hide_chrome'] variable instead, which is also set to true automatically in Ajax mode. (QueryString.php, Subs.php, Errors.template.php)
+ Added a new function, hideChrome(), which ensures Wedge will avoid showing the top and sidebar templates. You may also add a parameter that will list the main template layers you wish to use. Haven't tested most of the changes, but it should be fine. (CoppaForm.php, Load.php, ModerationCenter.php, Packages.php, Printpage.php, Reports.php, Spellcheck.php, Subs.php, VerificationCode.php)
! Fixed a cases where resetting the template layers was already done, something like that. (Help.php)
* Spacinazi. (CoppaForm.php, ManageErrors.php, Printpage.php, Subs-Cache.php, Admin.template.php, Errors.template.php, Search.template.php)

@ Note: $txt['image_lang'] isn't defined in our languages, but is used in the code. Should we remove it, or is it used for some specific languages? (Load.php)
@ Also: Pete, can you look into the hideChrome() occurrences? I didn't realize there were so many template resets... To think that most of them were broken in the previous rev, and none of us noticed it! :^^;:
Title: Re: New revs
Post by: Nao on March 29th, 2011, 10:45 PM
As often, I'm trying to commit big releases in several chunks, for readability reasons. I still need to fix Wine (I'm currently moving it to the root, 90% finished, took me many hours to do the move, oddly.)

rev 673
(9 files, 17kb)

* Renamed some classes in special templates to avoid confusing them with classes in the main style. Also made the names shorter because WAP cellphones usually have limited bandwidth... Saving money is good. (Reports.template.php, Wireless.template.php, report.css, wireless.css)
! News fader's icon didn't match the starting fold state. (BoardIndex.template.php)
- Removed .header class, which breaks the layout, but it'll be fixed in the next commit (big stuff coming.) (BoardIndex.template.php)
- Removed #menu_container class, as #navi already acted as such. Also removed .forumtitle class, as there's only one h1 tag in the headers. Styling coming in the next commit. (index.template.php)
* Replaced alt="!" crap with actual IDs. Styling coming..you know the drill. (GenericMenu.template.php, Pastel/index.css)
- Sometimes, some obscure, rarely used stuff is too precisely styled. Why bother? (member.css)
Title: Re: New revs
Post by: Nao on March 31st, 2011, 04:44 PM
rev 674
(36 files + 4, 71kb - mostly maintenance stuff but might be worth a look, if only at the changelog.)

* Harmonized file endings in the Sources folder, and other very minor spacing or logic changes. Oops, I forgot the closing PHP tag on a few of the classes I created... (Class-CSS.php, Class-JSMin.php, Class-Packer.php, ManageMaintenance.php, ManageMembers.php, ManageNews.php, ManageServer.php, PostModeration.php, PrettyUrls-Filters.php, Profile.php, Security.php, Subs-Captcha.php, Subs-Post.php, Subs-PrettyUrls.php, Subs.php)
* Reduced filesize of Wedge mini-logo and symbol, and moved original 32-bit versions to the other/images folder. (minilogo.png, wedgesight.png, wedgeship.png, minilogo-256.png)
* Every nerd knows that math trumps sex. (index.php, SSI.php)
* Saved a whopping two bytes per page load. What? (index.template.php)
* A detail in the French translation. Details annoy me enough to fix them. (index.french.php)
* Board manager had inverted cat and title header types. (ManageBoards.template.php)
- Removed debug parameter in updateSettings (unused.) (Subs.php)
- We don't see a reason to initialize rand_seed separately with microtime() instead of mt_rand. (Subs.php)
- No need for an extra cookie test when showing the newsfader. (BoardIndex.template.php)
- Removing the ONLY remaining occurrence of the titlebg2 class in Wedge. (Calendar.template.php)
- Removing last occurrences of tborder and bordercolor classes. They're remnants from SMF's Core theme, mainly. Also fixed related indentation. (TEMPLATES: Display, Login, Memberlist, MessageIndex, Packages, PersonalMessage, Profile, Recent, Register, Reminder, SplitTopics, Themes, admin.css)
Title: Re: New revs
Post by: Nao on March 31st, 2011, 11:33 PM
rev 675
(many files, big size. Didn't check it exactly, as I was busy fighting tree conflicts.)

* Switched Warm for Wine as new default styling. Wine is now a replace type, and Warm is an add type. Removed many useless default props for regular divs. Nested a few more declarations for readability. Got rid of titlebg2, tborder and other useless styles. (styles/*)
+ Added support for the "for" keyword in styling blocks. For instance <block name="cat" for="ie6,ie7"> should generate markup exclusive to IE6 and IE7. (Subs-Cache.php)
* Core Features page should show an underline for active feature links. (admin.css)
* Styling pick page in the profile area could use better header hierarchy. (Themes.template.php)
* Improved board list in Manage Board area, by showing a dotted bottom border instead of a complete solid border. (admin.css)
* IE6 doesn't need PNG fixes for the header area's reddish zones. A simple solid background saves time. (ie6.css)
* Re-implemented PNG fixes for windowbg/windowbg2, though. It's not that slow to apply, and it looks slightly better. Added instructions to disable it if you like. (settings.xml, ie6.css)
! Fixed a very small bright line that always showed up below the main menu in Wine. Finally got the bugger. (ie6.css)
! Fixed various details in the Pastel styling. Still needs a LOT of fixing. (Pastel/ie6.css, Pastel/index.css)
! Fixed double float margin in IE6 for upshrinks. (sections.css)
- Webkit didn't like the catbg/titlebg forced height. (webkit.css)
Title: Re: New revs
Post by: Nao on April 1st, 2011, 11:42 PM
Quite satisfied with tonight's work... Quick, barely buggy on first try, and all in all interesting -- notably the fact that WeCSS now supports retrieving file sizes dynamically. (Maybe I should use $images instead of $images_dir and transform the URL on the fly, though... But the current solution is, err... Safer?)

rev 676
(14 files, 18kb)

+ Renamed wecss_func class to wecss_color, and implemented wecss_func class with two new functions. width(url) and height(url) will return the dimensions of any image. Make sure to use the _dir variable variations for best results. ($images_dir instead of $images, etc.) (Class-CSS.php, Subs-Cache.php)
+ Added $language_dir, $images_dir and $theme_dir variables, for the above. Also fixed $language to actually work.
+ Added westr::safe(), which is just like westr::htmlspecialchars() but slightly faster (and simpler.)
* Turned language-specific new.gif into a base64 icon. YES. (Profile-Modify.php, SSI.php, BoardIndex.template.php, MessageIndex.template.php, PersonalMessage.template.php, Post.template.php, Recent.template.php, sections.css)
! $user_info['url'] (used in the language switcher) didn't have the proper current URL if inside a board. Hopefully this weird fix won't cause trouble. (Load.php)
! Don't need to recalculate $css_vars['$here'] on every file addition... Only the last one is needed. (Subs-Cache.php)
- Don't bother with IE6 emulation of windowbg backgrounds, because it doesn't seem to work on tr tags, and my patience is limited. (ie6.css)
Title: Re: New revs
Post by: Nao on April 2nd, 2011, 08:15 PM
The more time I spend on Pastel, the more depressed I am... Hence its new name :P

rev 677
(12 files + 7 modified, 45kb)

* Moved feed icon to CSS. (BoardIndex.template.php, index.template.php, index.css)
* Moved Pastel to under Warm, renamed it to Wuthering and fixed it. Not perfect, and not optimized... But I don't really care at this point. (Pastel/*, Warm/Wuthering/*)
! Fixed CSS variable declarations with mismatched opening or ending double quotes. (Class-CSS.php)
* Renamed "News" item to "In the news" in the French version. Makes more sense. (index.french.php)
* Replaced the semi-colon next to "News" with an arrow. (index.template.php, index.css, sections.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 01:30 AM
rev 678
(21 files +3, 22kb)

* Replaced all helptopics.gif occurrences with CSS. Again: YAY. (sections.css, other/ssi_examples.php, Modlog.php, Admin.english.php, Admin.french.php, TEMPLATES: Admin, Errors, GenericMenu, Login, ManageMaintenance, ManageNews, ManagePermissions, ManageSearch, ModerationCenter, Packages, Profile, Themes)
! Fixin' bad filters in Warm. Cancelled the fixes in Wuthering because they get inherited anyway. (Warm/ie*.css)
! Fixin' some odd stuff in IE6 admin layout. (ie6.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 10:59 AM
rev 679
(7 files, 11kb)

! A few of the help text links were being hidden by the help icon. (Admin.english.php, Admin.french.php, Login.template.php, Packages.template.php, Profile.template.php, Register.template.php)
* Indenazi. (Profile.template.php, sections.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 11:08 PM
rev 680
(7 files, 9kb)

! Fixed sidebar width in Chrome/Safari, due to a minor glitch in the var parsing regex. (Class-CSS.php)
! Fixed horizontal matching of dt/dd tags not working in IE6/IE7 due to a bug with clear: both and floated elements. Fixed through trial and error... (ie6.css, ie7.css, index.css)
! Fixed main content (next to sidebar) width in most browsers, due to an earlier fix for IE (what else?). (index.css)
- dl.settings_title is never used anywhere. (index.css)
- Can't find #ip_list anywhere either. (rtl.css)
- And .header... I think I removed the last one this week. (webkit.css)
* Modified Warm to make the sidebar blend in with the background, and have a single vertical rule separate it from the main content. (Warm/index.css)
Title: Re: New revs
Post by: Nao on April 3rd, 2011, 11:46 PM
rev 681

* Wuthering is back to being a root subfolder. Saves 700 bytes off the gzipped CSS file, and is slightly simpler. (Wuthering/*)
Title: Re: New revs
Post by: Nao on April 6th, 2011, 07:24 PM
Okay... There it is! :)
It's got a bug every ten lines, but it doesn't crash (at least not superficially.)
A note for testers: take the file /other/db_aeva.php, move it to the root, and run it from your browser. It should safely add all of the needed tables and table fields for you, just like Aeva Media's installer. Eventually, this file will be integrated into install.php, obviously.

rev 682
(98 files +197 files, 3.0 megabytes... W00t!!! :lol:)

+ Added Aeva Media. Now we're talking. (index.php, media/*, other/db_aeva.php, other/images/sprite-32bit.png, other/install.sql, Admin.php, Class-Editor.php, Load.php, ManagePermissions.php, Profile.php, Subs.php, Themes/default/aeva/*, images/aeva/*, images/bbc/sprite.png, Media.template.php, ManageMedia.template.php, editor.js, media.js, media-admin.js, uploader.js, index.css, media.css, up.css, LANGUAGES: Admin, Errors, Help, index, ManageMedia, ManagePermissions, Media, Post, Who)
* Renamed loadSubTemplate() to execSubTemplate(), and showSubTemplate() to loadSubTemplate(). Makes more sense. (Activate.php, Admin.php, Announce.php, BoardIndex.php, Calendar.php, CoppaForm.php, Credits.php, Display.php, Errors.php, Findmember.php, Groups.php, Help.php, Jseditor.php, JSModify.php, Load.php, Login.php, Login2.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePosts.php, ManageRegistration.php, ManageScheduledTasks.php, ManageSearch.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Memberlist.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Notify.php, PackageGet.php, Packages.php, PersonalMessage.php, Post.php, PostModeration.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, QueryString.php, QuoteFast.php, Register.php, Reminder.php, RepairBoards.php, Reports.php, Reporttm.php, Search2.php, Security.php, SendTopic.php, Spellcheck.php, SplitTopics.php, Stats.php, Subs-Auth.php, Subs-Menu.php, Subs-Package.php, Subs.php, Suggest.php, Themes.php, Unread.php, Unreadreplies.php, VerificationCode.php, Xmlhttp.php)
! Potential undefined index in browser detection code. (Load.php)
! Fixed infinite loop when providing a CSS file with a wrong path. (Subs-Cache.php)
! If asking for a full HTML5 tag along with the CSS file, the wrong parameter was used (src instead of href). (Subs-Cache.php)
! Small icon fix in menu code, and a temporary fix for Aeva Media icons. This one needs to go! (Subs-Menu.php)
! Fixed $here position to be dependent on the current file's position, rather than the final file, when several files were being requested at once. (Subs-Cache.php)
! Saving one's personal options for the first time wouldn't refresh the options page with the new settings. (Profile-Modify.php)
! Prevent user from moving popup window in source browser (error log). (ManageErrors.php, script.js)
* Moving Unknown's credit to the SMF2 area and other minor details. (Credits.php, Who.english.php, Who.french.php, Who.template.php)
* Use hideChrome instead of the old method. (ViewSMFile.php)

@ Need to make sure including Exifer is okay. (GPL license)
@ My biggest commit ever (in the past, AND in the future I hope)... This is madness.
Title: Re: New revs
Post by: Nao on April 7th, 2011, 11:10 AM
rev 683 -- another cool commit IMHO :)
(10 files, 22kb)

+ Added support for complex blocks. (Load.php, QueryString.php, Subs-Cache.php, index.template.php, settings.xml)
+ Finished implementing Aeva Media's install-both.xml file. Used the opportunity to also protect PMs with only a video in them, and add HTML5's video and audio tags to the whitelist. (JSModify.php, Post2.php, Subs-BBC.php, Who.php)
! Fixed a silly undefined index error. (Profile-Modify.php)

@ To do: add support for complex blocks in stylings other than Wine. Move default block setup to index.template.php's template_init(), so that it can effectively be set up by the theme itself.
Title: Re: New revs
Post by: Nao on April 7th, 2011, 12:13 PM
rev 684
(2 files, 7kb)

! Fixed undefined index errors anywhere Aeva was in action. $context['utf8'] no longer exists in Wedge, since we're always in UTF mode... Also removed a corresponding helper function, and a few 'u' modifiers that really didn't make sense at all. (Aeva-Embed.php, Aeva-Subs-Vital.php)
Title: Re: New revs
Post by: Nao on April 7th, 2011, 07:03 PM
rev 685
(17 files, 60kb)

! Block matching would crash on the front page, for a reason too obscure to me (and thus, probably to you too.) Replaced main regex to use atomic grouping. Although it shouldn't be of any use, it has proven its value in the similarly weird Goddess of All Regex in Aeva-Embed.php. Also made sure that identical nested blocks don't collide with each other. And finally, array_shift() shouldn't be called on an empty array, even if it doesn't generate an error. Now, who reads these changelogs anyway? Fixed some stuff buddies, and it works better now, that's all ya need to know. (Subs.php)
* Since 99% of all template_button_strip calls use a "right" parameter, set it to be the default. And seriously, the default actually generates a floattop class, which doesn't exist. SMF glitch! (Media.template.php, Display.template.php, index.template.php)
! Fixed loadLanguage calling for Aeva files instead of Media. (Aeva-Embed.php, Aeva-Foxy.php, ManageMedia3.php, Subs-Media.php
! Other aeva/media fixes, and removed debug code. (Aeva-Gallery.php, Aeva-Gallery2.php, LANGUAGES: ManageMedia, Media)
! Fixed rich editor to work in the Media area. (Subs-Media.php)
* Moved output buffer post-processing functions from the QueryString file to Subs, at least temporarily. (QueryString.php, Subs.php)
! Minor glitch in definition lists. Whatever. (index.css, sections.css)

@ Note: button strips need to be context_menus, actually.
Title: Re: New revs
Post by: Nao on April 8th, 2011, 01:33 AM
rev 686
(3 files, 11kb) (small, but took my evening away... >_<)

! Rewrote the block system (again!) to fix more crashes and allow for better handling of complex nested blocks with or without parameters, and define the default entries in the index template, rather than the Load file. Also documented some of the features. (Load.php, Subs.php, index.template.php)
* Moved sidebar and main content into blocks, and used the block system's browser detection feature to deal with IE6/7. (index.template.php)

NB: Here's what I changed in the block detection code, if you're interested...
  [^<] gets a + to save some memory by handling multiple non-< characters at once.
  Allow nested blocks within a block search, as long as it doesn't have the same block type. It doesn't work without the \\1. Will need further tests to understand why.
  Use the greedy setting to minimize memory consumption on big pages.
  Used a similar regex change on the <if> block searches.
  Rearranged variable search code in a way that makes more sense (and actually works.)
Title: Re: New revs
Post by: Nao on April 8th, 2011, 01:42 AM
rev 687
(3 files, 5kb)

! Load Aeva-Gallery2.php properly. Allows viewing the media pages in profile areas. (ManageMedia.php, Profile.php)
! The thing is called Exifixer, not Exifer, even though the original library says Exifer... (exif/exif.php)

(Some last-minute changes before I go to bed.)
Title: Re: New revs
Post by: Nao on April 8th, 2011, 02:15 PM
rev 688
(9 files +1, 12kb)

! A couple of areas still had mod_security compatibility issues. One of them was pointed out by myself and [Unknown] in 2009 to the SMF team and never fixed. I only remembered it now. Way to go, SMF. (ManageAttachments.php, Media.template.php)
* Added support for the newest URLs of YouTube. (Subs-Aeva-Sites.php)
+ Might as well put that useless $txt['lang_dictionary'] to good use and use it as a lang parameter in the html tag until we add a proper 2-letter code entry. (index.template.php)
+ Added an index.php protection to the Sources/media folder. Not very useful though.... (media/index.php)
* Renamed action=helpadmin;help=... to action=help;in=... because we no longer use the help action anyway, and it's not only for use in the admin area. Will do the rest in a batch in the next commit. (index.php, Help.php, Load.php, ManageMembergroups.php)
Posted: April 8th, 2011, 02:07 PM

rev 689
(23 files, 16kb)

* Finished renaming helpadmin to help. (All 23 files.)
Title: Re: New revs
Post by: Nao on April 8th, 2011, 09:28 PM
rev 690
(10 files, 24kb)

! parsesmileys() would search for every smiley twice (once in a normal version, once in a htmlspecialchar'ed version), even if they were the same. It also applied htmlspecialchar to a same string three times in a row... Oh please, come on! (Subs-BBC.php)
* Optimized parsesmileys() replacement code. Both versions are lightning fast. The new version is 10 to 20% slower when the string has no smileys, but 2 to 5 times faster when it meets one or more smileys. (Subs-BBC.php)
* Optimized the block replacement function code. Replaced the super-cool regexp with a lame series of strpos calls. The new version is much faster when using hundreds of blocks, but a bit slower with few blocks (could be made faster by removing the case-sensitivity code.) It's still more robust anyway, and easier to understand. (Subs.php)
* Providing a means for the playlist area to know whether the album link should be shown. Yeah I know -- extra query... (Aeva-Foxy.php)
* Simplified media menu and fixed current area highlighting. (Aeva-Gallery.php)
! Fixed headers in playlist area. (Aeva-Foxy.php)
! Some areas didn't properly rename Aeva-Subs to Subs-Media. (Aeva-Subs-Vital.php, Subs-Media.php, Subs-BBC.php, Subs.php, Who.php)
! Converted the Aeva Media changelog to UTF8, to avoid errors at parse time. This will eventually be used in the Wedge changelog, hopefully. (default/aeva/changelog.txt)
* Minor button strip fixes. Hopefully the new forced overflows won't break anything. (Media.template.php, index.css)
! .title2 link color should be the same as when not linked. (index.css)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 12:08 AM
rev 691
(7 files, 12kb)

- Removed case insensivity code from the block replacement path. Although very fast, it's not worth the trouble -- just be wise and use lowercase, there's no point in going uppercase here. (Subs.php, index.template.php)
! Fixed <if> replacements in the new code. (Subs.php)
! Block building code in Load.php was needlessly long (by 11 lines!), and forgot to apply the scripturl transform. (Load.php)
! Fixed image URLs in Media stylesheets. (media.css, up.css)
* Moved dummy block overrides from Wine to Warm (our 'sample case'), where I can take some time to explain what it does... (settings.xml, Warm/settings.xml)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 12:56 AM
rev 692
(1 file, 5kb) (Uh, actually one byte changed :P)

! Mismatched tags. (MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 04:29 PM
rev 693
(forgot to check stats, whatever.)

+ Added media icon to the main menu. (sprite-menu-32bit.png, sprite.png, Subs.php, index.css)
+ Added 3 pixels around each menu icon to avoid getting artifacts in some browsers (IE6, Safari Mobile...) (sprite*.png, index.css)
! Fixed three syntax errors in the ban manager. (ManageBans.php)
* A small change to avoid infinite loops when a tag is unclosed. (Subs.php)
* Starting HTML5 conversion of Media templates. Okay, just three lines... So what? (Media.template.php)
Title: Re: New revs
Post by: Nao on April 9th, 2011, 05:42 PM
rev 694
(5 files, 7kb)

* Moved the admin notification area to the actual template to avoid issues with <we:> tags, and removed the related code from admin.js -- which was only used for that one case anyway. (Admin.template.php, admin.js, admin.css)
* It's Wedge, not SMF. (Admin.language.php)
Title: Re: New revs
Post by: Nao on April 10th, 2011, 01:52 AM
rev 695
(21 files +1-1, 29kb)

* Made Media area work. It is now possible to create albums, upload single items, and view the album and item pages. The rest is coming, of course. (Media.template.php, media.js and other files.)
! Fallback code in the wesql::insert function was incorrect. (Class-DB.php, Aeva-Gallery.php, Aeva-Gallery2.php
! Fixed (un_)preparsecode calls in Media area. (Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php,
! Fixed call to media.js and hs.css in Media area. (Aeva-Gallery.php, Media.template.php)
* Outdated table names. (Subs-Media.php)
* Renamed wedgeEditor object to wedit, for consistency reasons. (Class-Editor.php, Display.php, Jseditor.php, JSModify.php, ManageNews.php, ModerationCenter.php, MoveTopic.php, PersonalMessage.php, Post.php, Subs-Media.php, Post2.php, Profile-Modify.php, QuoteFast.php, Subs-Post.php)
* Minor details. (Media.template.php)

More coming tomorrow... Just a bit late, see?
I'm very glad that the gallery finally works. It was less work than expected (I estimated two weeks of work minimum, not one week!)
Title: Re: New revs
Post by: Nao on April 10th, 2011, 02:20 PM
rev 696
(25 files -1, 34kb)

* Enabled Gallery and Auto-embed settings to actually be enabled/disabled through the Core Features area. Hide the main and admin menus with respect to these settings. (Admin.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php, ManageMedia3.php, Subs-BBC.php, Subs.php, Media.english.php, Media.french.php)
* Core Features should be detected through an isset(). Should be faster than in_array(). Both methods will be available until everything's converted. (Admin.php, Load.php)
* Renamed Exif to Metadata in the UI and internally, to make room for potential future implementations. (db_aeva.php, Aeva-Foxy.php, Aeva-Gallery.php, Class-Media.php, ManageMedia.php, Subs-Media.php, Media.template.php, Admin.english.php, Admin.french.php, ManageMedia.english.php, ManageMedia.french.php, Media.english.php, Media.french.php)
* Renamed a few remaining 'aeva' fields to 'media' or 'misc'. (db_aeva.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia2.php, Subs-Media.php, Subs.php, Media.template.php)
- Removed Sources/media/exif folder, as it was an old version of Subs-Exif.php (oops.)
! Calling in_array('m', array('m,cd,cp')) is going to return false. I'm just telling you, SMF. This is how it works. (install.sql, Load.php)
! Fixed infinite loop when dealing with an empty menu. (Subs-Menu.php)
Title: Re: New revs
Post by: Nao on April 10th, 2011, 04:14 PM
rev 697
(9 files, 11kb)

* Renamed (again) media and auto-embed core features to use 'media_enabled' and 'embed_enabled' single settings. Eventually, core features will all have their own settings and use them where needed. (install.sql, Admin.php, ManageSettings.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php, Subs-BBC.php, Subs.php)
Title: Re: New revs
Post by: Nao on April 11th, 2011, 01:22 PM
rev 698
(14 files, 16kb)

* Turned admin_features into a series of variables. (install.sql, upgrade.sql, Admin.php, Display.php, Load.php, ManagePermissions.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, Profile-View.php, Profile.php)
! Fixed post boxes in media area. (Subs-Media.php, Media.template.php)
* Temp header update. (media.js)
Title: Re: New revs
Post by: Nao on April 11th, 2011, 07:46 PM
rev 699
(2 files, 12kb)

- Removed self-closed tag closers (?) from Media templates and fixed a few things (labels, etc.) Source files aren't done yet. (Media.template.php, ManageMedia.template.php)
Posted: April 11th, 2011, 07:17 PM

rev 700
(12 files, 15kb)

- These source files have tons of templating in them... So much for the MVC model uh. Removed all />'s where needed, and a few more fixes as usual. Renamed all remaining SMG tags to MEDIA. (Sources/media/*, ManageMedia.language.php, Media.template.php)
Title: Re: New revs
Post by: Nao on April 11th, 2011, 11:29 PM
rev 701
(6 files, 11kb)

! Fixed lists of children albums looking really bad due to the new rounded corner markup. Well, I couldn't find a perfect solution so I made a couple of changes. I'm not satisfied though... (Subs-Media.php, media.css)
! Minor thingies. (ManageMedia.english.php, Media.template.php, hs.css)
+ Added .wrc_top and .wrc_bottom classes, in case they ever make themselves useful. Not for now though... (index.css)
Title: Re: New revs
Post by: Nao on April 12th, 2011, 04:11 PM
tl:dr --- mass upload fixed :)

rev 702
(10 files +1, 32kb)

* Added support for icon transparency in playlist headers. (Aeva-Foxy.php, media.css)
* Cleaned up mass upload interface and JS, and delayed said JS to the bottom. (Aeva-Gallery2.php, Media.template.php, index.css, up.css)
! Fixed mass upload. It now actually works, although the jQuery version is still being worked on. (up.js, uploader.js)
! Fixed some wrong paths for Media scripts. (Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php)
! Silly oversight in block replacement code caused empty params to show an unprocessed if-block instead of hiding it or processing it. (Subs.php)
Title: Re: New revs
Post by: Nao on April 12th, 2011, 06:13 PM
tl:dr -- Highslide fixed :)

rev 703
(5 files +1-2, 115kb) (that's mainly because of the JS files being swapped... Actual changes are minor.)

! Forgot to capture a match during template error processing. (Load.php)
! Fixed Highslide support. (Aeva-Subs-Vital.php, aeva/highslide.js)
* Fixed item pages with no comments to show something actually watchable. (Media.template.php)
* Restored jQuery version of uploader JS, as I finally found why it was going cuckoo. (up.js)
Title: Re: New revs
Post by: Nao on April 12th, 2011, 08:04 PM
rev 704
(4 files, 8kb)

! Fixed item commenting. (Aeva-Gallery.php, Media.template.php)
* Styling details. (up.js, media.css)
Title: Re: New revs
Post by: Nao on April 13th, 2011, 12:22 AM
rev 705
(8 files, 12kb)

! Fixed hover popups in album pages. The IE hack makes use of the selector precedence algorithm. I think it's the first time I actually devised this, instead of doing it by chance. (media.css, ie6.css, ie7.css)
! clear_thumbnames should be set by default, because we want the best possible performance for avatars. (db_aeva.php)
! Media Maintenance tasks were broken. (ManageMedia2.php)
* Don't turn -moz-border-radius into -moz-webkit-border-radius, things like that. Remember, friends: just use border-radius. Wedge will do the rest. (Subs-Cache.php)
* Fixed uploader script and converted the rest to jQuery. (up.js)
* Minor details. (Load.php)

@Note: Highslide is broken (again). I don't know what exactly caused this, since it worked up until the previous rev, if I'm not mistaken. :-/
Title: Re: New revs
Post by: Nao on April 13th, 2011, 10:39 AM
rev 706
(1 file)

! Fixed Highslide by replacing it with an older, more solid version... Until I get to replace it with another library, really. (highslide.js)
Title: Re: New revs
Post by: Nao on April 13th, 2011, 08:11 PM
rev 707
(6 files +1, 86kb -- mostly the addition of highslide-full.js)

* Fixed Highslide full version, moved JavaScript calls to the JS footer, and rewrote code to use rel tags instead of events. (Aeva-Embed.php, Aeva-Subs-Vital.php, Subs-Media.php, ManageMedia.template.php, Media.template.php, highslide-full.js)
! Media tag helper popup needed a scrollbar. (Media.template.php)
! Fixed JavaScript error when manually removing a file that was rejected by the script for being too large. (up.js)
Title: Re: New revs
Post by: Nao on April 15th, 2011, 09:52 AM
rev 708
(7 files +17-15, 82kb)

* Swapped SMF and Wedge names in the footer, so that we can use Wedge on live websites without breaking the mandatory SMF copyright mention. (index.php)
* Updated variable names in AeMe installer, although it's only useful for tester upgrades, not for new installs. (db_aeva.php)
- cal_enabled was defined twice in the installer. (install.sql)
* Partly rewrote the CSS caching system to allow for more flexibility (at the cost of more file_exists tests, which shouldn't be a problem with OS caching.) css_generic_files is split into another array, css_main_files, which contains the actual main CSS files, while css_generic_files now only contains overriding stylesheets, and is also loaded by stand-alone stylesheets, making it easy to override any stylesheet with stylesheet_name.override_name.css (Load.php, Subs-Cache.php)
* Renamed all override-type files to index.original_name.css, and moved Media-specific hacks to media.original_name.css. (*.css)
- Hide the 'webkit' keyword in CSS URLs if we have a more specific browser recognized by Wedge. (Subs-Cache.php)
! CSS caching didn't work at install time because of the missing $context['user'] variable. (Subs-Cache.php)
+ Added a .hide class that simply does display:none... It's cleaner this way, although it requires loading the CSS to apply it. Could turn out to be useful, though. (index.css)
* Made a comment a bit clearer. (Subs.php)

@ Note: should rewrite wedge_cache_css to merge it with add_css_file. Both do pretty much the same thing, with a few tweaks for main CSS files. (Subs-Cache.php)

@ Note: should really, really test the CSS caching system with new themes... Have never done so. It probably doesn't even work properly. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on April 15th, 2011, 11:18 AM
rev 709
(4 files, 6kb)

! webkit keyword wasn't removed from filename if at the beginning or the end[1]. (Subs-Cache.php)
! Made DragSlide a bit more open to non-reqWin popups. (script.js)
* Details. (Aeva-Gallery.php, media.js)
 1. Tested in Safari...
Title: Re: New revs
Post by: Arantor on April 16th, 2011, 10:38 AM
Revision: 710
Author: arantor
Date: 09:37:11, 16 April 2011
Message:
! Make sure user-agent is actually defined for the purposes of BB checking. (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on April 16th, 2011, 09:06 PM
rev 711, aka "My revisions are badass!"
(13 files +5, 44kb)

* Replaced Highslide with a WIP lightbox called zoomedia. Excuse the pun. It isn't feature complete, and tends to fail on .scrollTop() requests, but it can be fixed, hopefully, and it's a pretty tight library. (close.png, close-32bit.png, Aeva-Subs-Vital.php (temp code!), hs.css (WIP), zoomedia.js)
+ Added a micro-optimization to Javascript cache code, allowing for slightly smaller files. (Subs-Cache.php)
! Fixed a bug that caused earlier versions of cached files not to be deleted as thought of. (Subs-Cache.php)
! Apparently, the File API specification was modified since the Aeva Media days, which triggered an error in Opera 11.10. (Aeva-Gallery.php)
* Clean-up job. Nothing worthy of documenting, but somehow important to me. (Class-Packer.php, Errors.template.php, Media.english.php, Media.french.php, editor.js, script.js, admin.css, index.css, sections.css, aeva/change_menu*.png (temp fix for silent errors))
Title: Re: New revs
Post by: Arantor on April 16th, 2011, 11:46 PM
Revision: 712
Author: arantor
Date: 22:45:36, 16 April 2011
Message:
! PHP is not as smart as humans at dealing with one line branches, so better be clearer for PHP's benefit. (Security.php)
----
Modified : /trunk/Sources/Security.php


While the fix technically made sense, PHP could have been ambiguous in its handling of the branch else because it wasn't clear whether it applied to the nested if or the parent one, so I gave it braces.
Title: Re: New revs
Post by: Nao on April 17th, 2011, 12:13 AM
rev 713, aka "It's a 2-line commit, too. Nah, just kidding, just got more work for you guys."
(9 files, 34kb)

* Updated the mass upload area. Updated YUI Uploader to v2.8.x, moved their Uploader JS to local so as to fix a bug in SWFObject + Opera (maybe other browsers). Reworked layout for cooler file lists. (Aeva-Gallery2.php, uploader.swf, up.js, up.css)
! Fixed regression where sub-files added to the main CSS file list weren't correctly cached. (Subs-Cache.php)
* Done some extra work to make the Media template a bit more validator-friendly. (Media.template.php)
* Pathetic urge to save even more bytes in zoomedia... Now 658 bytes after compression. (zoomedia.js)
* Error log was ugly. Me no like ugly things. Me like beer and women. In that order. (admin.css)
! Context menus could be followed up by a misaligned element. (index.css)
Title: Re: New revs
Post by: Nao on April 17th, 2011, 02:38 AM
rev 714
(5 files, 9kb)

! Late night woopsies.

Too tired to document. View the diff patch ;)
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 02:52 AM
Revision: 715
Author: arantor
Date: 01:52:23, 17 April 2011
Message:
! Some fixes for undefined character set (legacy stuff) (Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php, Media.template.php)
----
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Themes/default/Media.template.php
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 03:35 AM
Revision: 716
Author: arantor
Date: 02:34:44, 17 April 2011
Message:
! Fix missing dependencies for the mass uploader (Aeva-Gallery2.php)
----
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 03:47 AM
Revision: 717
Author: arantor
Date: 02:46:59, 17 April 2011
Message:
! Aeva DB changes should not require default values on text columns (db_aeva.php)
! Harmonising media permissions fully (Admin.php, ManagePermissions.php, ManagePermissions.english.php, ManagePermissions.french.php, ManageMedia.php, Aeva-Subs-Vital.php, Subs-Media.php, Profile.php, Subs.php, Errors.english.php, Errors.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Aeva-Subs-Vital.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/other/db_aeva.php
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 03:54 AM
Revision: 718
Author: arantor
Date: 02:54:32, 17 April 2011
Message:
! Oops, forgot to update the permissions/group associations. (ManagePermissions.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Title: Re: New revs
Post by: Nao on April 17th, 2011, 09:13 AM
rev 719, aka "I can do one-liners, too, just like the SMF team!"
(1 file, 4kb)

* Updated aeva_allowedTo permissions. (Aeva-Subs-Vital.php)
Title: Re: New revs
Post by: Nao on April 17th, 2011, 10:33 AM
rev 720
(6 files, 28kb)

! The mass upload script should really be linked with ampersands. (Aeva-Gallery2.php)
* YUI 2.9.0 updated the Flash file as well. (aeva/uploader.swf)
* Button schmutton. Changed all 'button' strings to 'item' in the main menu code. (Subs.php, SSI.php, index.template.php)
* Updated the media language header to reflect the newfound difficulties for translators. (Media.english.php)
Title: Re: New revs
Post by: Nao on April 17th, 2011, 04:09 PM
rev 721
(12 files, 16kb)

! iPhone devices were internally recognized as Safari instead of iPhone.
! Fixed a few undefined strings in non-admin situations. (Aeva-Gallery.php, Aeva-Gallery2.php)
* Don't bother showing auto-resize code for iPhone, it doesn't work well. Rewrote CSS and added some JS to show the sidebar at the bottom instead. (index.template.php, index.iphone.css, settings.xml)
! A few language strings were using entities uselessly. (ManageMaintenance.french.php, ManagePaid.*.php, ManagePermissions.french.php, ManageScheduledTasks.french.php, ManageSettings.french.php)

@ Note: for iPhone, should work further on it to make the sidebar fill the screen width optimally... Should also implement <meta name="viewport" content="width=device-width"> at some point.
Title: Re: New revs
Post by: Arantor on April 17th, 2011, 11:26 PM
Revision: 722
Author: arantor
Date: 22:23:42, 17 April 2011
Message:
! Fix check against Expect:100-continue header to be check for HTTP/1.0 as a failure condition. (Security.php)
! Upgrade bundled test library to use that from BB 2.1.12, which solely affects the list of IP blocks known to be held by Googlebot. (Of course, until IPv6 is completely finished this doesn't make a lot of difference...) (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on April 18th, 2011, 12:12 AM
rev 723
(4 files +2, 10kb)

+ Finished implementation of overlay descriptions. Pretty neat. (Aeva-Subs-Vital.php, zoomedia.js, hs.css, hs.ie6.css, hs.ie7.css)
* Replaced last non-CSS implementation of the New icon. (Subs-Media.php)

PS: demo site is updated with these overlays. Have a look at album pages! Oh, I'm starting to love jQuery again... :)
Posted: April 17th, 2011, 11:55 PM

rev 724
(2 files, 6kb)

! Fixed glitches in overlay descriptions. (zoomedia.js, hs.css)
Title: Re: New revs
Post by: Arantor on April 18th, 2011, 06:06 PM
Revision: 725
Author: arantor
Date: 17:06:03, 18 April 2011
Message:
! Don't try loading the sidebar items for who's viewing a topic/board in WAP2 mode, because it's extra fluff that we can't really afford and because it wasn't even handled by the wireless template anyway. (Display.php, MessageIndex.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MessageIndex.php
Title: Re: New revs
Post by: Nao on April 18th, 2011, 08:31 PM
rev 726
(9 files +5-3, 36kb)

* Keeping up with the Highslide to Zoomedia replacement process. (Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.template.php, Media.template.php, zoomedia.js, hs.*.css, zoom.*.css)
+ Improved description overlays and implemented language strings and loader icon in Zoomedia. The loader doesn't show up if the image is already cached. (zoomedia.js, zoom.css)
+ Added a nice animated loading icon. And it's transparent, yay. Not cancellable yet, though. (images/loading-flow.gif)
! Fixed (hopefully) all of the positioning bugs in Opera, IE6, IE7 and IE8. (zoomedia.js)
! Did I really forget to commit the iPhone stylesheet..? (index.iphone.css)
* Lowercase nazi. (install.sql)

PS: svn testers, please feed my back! ;) Isn't on the demo site yet, though. I'll post when it's done.
Title: Re: New revs
Post by: Nao on April 19th, 2011, 03:07 PM
rev 727
(10 files +1-1, 21kb)

* Replaced loading-flow icon to a smaller one (thanks for reminding me of that web service, Lorenzo!), and renamed it. (loader.gif, loading-flow.gif, zoom.css)
* Adding pngfix to IE6 in the default template is bad practice IMHO. Added an 'include' parameter to the code blocks in styling files, allowing to specify a list of comma-separated URLs for script files to be added for browser compatibility purposes. Also documented the whole damn thing in the Warm styling, as usual. That's pretty much one of the only things I've been documenting actually... (Subs-Cache.php, index.template.php, settings.xml)
* In the media area, transparent items would get a box-shadow override. Replaced this with a proper ping class (which was already there to tell IE6 an image was transparent). Ironically, DD_belatedPNG doesn't seem to work well on divs with a transparent background, so transparency still won't work in IE6... Did I hear someone say "screw IE6"? Is that you sir? Thank you, what's your name? Well Mr. Obvious, you're welcome to my place anytime! (Aeva-Foxy.php, Subs-Media.php, Media.template.php, index.css)
+ Added iOS hack to Warm and Wuthering. (settings.xml)
Title: Re: New revs
Post by: Nao on April 19th, 2011, 05:15 PM
rev 728
(3 files, 6kb)

! Pardon my French, but I'm fucking good. Leveraged the power of jQuery to make the ping class work on media items in IE6. Ah HA! (settings.xml)
Title: Re: New revs
Post by: Nao on April 19th, 2011, 11:34 PM
rev 729
(2 files, 8kb)

! Fixed
constructs to actually show several items next to each other. Also show captions in overlay mode... (Subs-Media.php)
* Detail. (index.css)
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 10:00 AM
Dammit... The SVN server is down. >_< (http://status.repositoryhosting.com)
I'll still post the full changelog. I took time to write it, and I just need to do the proper commit operation. I'll do it tomorrow if it's back online.

rev 730
(30 files +1-1, 75kb)

! A couple of fixes in the Help action to make it possible to use blocks inside text strings... Although I'm not using any in the end. (Help.php, Load.php, Help.template.php, index.css)
! Pages without chrome shouldn't be able to restyle the content block, as this one usually contains data connected to the sidebar block. Temp fix. (Subs.php)
* Seriously reworked the internals of the album page layout. Too much to say, but it's basically better. (Subs-Media.php)
* Making sure that the media.js file is always loaded when media headers are requested. This is a temp solution because this file will end up being merged with script.js, given its small size... (Subs-Media.php)
! Prevent a same JS file from being cached multiple times. (Subs-Cache.php)
* The media tag helper page should say what it's about to begin with... (Help.language.php)
+ Added footer, class and style parameters to <we:block>. Note to self: maybe this should be a generic parameter that can be set in an easier way...? (index.template.php)
! Moved delayed events to the very bottom, in case some of them are calling functions that are defined by stylings. (index.template.php)
* Completely overhauled the media item page layout. And guess what, I'm not happy with it... A small list of changes: turned tables into divs and lists, moved item to the left and item details to the right as a sidebar, aligned them similarly to a table (not tested in IE though), reordered details, and so on. (Media.template.php)
* Rewrote ajax_indicator in a simpler, jQuery-worthy way. (script.js)
- Merged media.js with script.js (media.js, Subs-Media.php, Aeva-Gallery.php)
+ Click the "Loading" indicator in media pages to cancel the load request. (zoomedia.js)
+ Added an alternative white background for Zoomedia boxes. Use the 'black' class on the zoom div to use the earlier one. (zoom.css)
* Moved most inheritable classes to their own section and added a new class that holds the loader icon. (index.css)
* Replaced Ajax indicator's close button with the loader icon. It can still be clicked to cancel the action... (index.css)
! Fixed checkbox/radio button styling in IE6. And yes, it's a bit hackish... (index.css, index.ie6.css, settings.xml)
! Fixed outdated block redefinitions in Wuthering. (settings.xml)
* Improved styling of the <we:block> blocks. (media.css)
* Rewrote media area CSS files to use the wecss formatting style. (media.*.css, zoom.css, up.css)
+ Added ie6hover.js script, which transparently makes IE6 accepts hover states on any given selector. (settings.xml, ie6hover.js)
! Fixed PNG transparency for IE6 in media area, which was broken in some specific cases due to weird markup. (Subs-Media.php, settings.xml)
- Removed aeva_header class and galurl JS variable. (Aeva-Foxy.php, Aeva-Gallery2.php, ManageMedia.php, media-admin.js)
Posted: April 21st, 2011, 11:55 PM

Committed.
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 05:14 PM
Got more work done, but it's not stable enough... Committing whatever I can.

rev 731
(4 files, 6kb)

* Moved item playlist template to the proper template file. (Aeva-Foxy.php, Media.template.php)
* Split media item template into several functions. (Aeva-Gallery.php, Media.template.php)
! One strlen call should have been passed through westr. (Media.template.php)
* Minor layout improvements. (medias.css)
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 05:49 PM
And... Still not happy with the new item page layout. Even with this new revision...

rev 732
(4 files, 8kb)

* <we:block> should have a .block class by default, not .windowbg... Will probably not work in this rev, because I have yet to commit the proper index.css file. (index.template.php)
* Moved media item details to the regular sidebar. Should add an option to choose where to show them... (Aeva-Gallery.php, Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on April 22nd, 2011, 09:06 PM
rev 733
(13 files +1-1, 17kb)

! Fixed gradient backgrounds in IE 6/7/8 when a single color was fed to them. (Class-CSS.php)
* Make sure execSubTemplate() ignores empty sub-template entries, which makes it easier for us to conditionally set extra sub-templates... (Load.php, Aeva-Gallery.php)
* IE 6/7 don't like display: table, so put the media item details in the sidebar automatically. (Aeva-Gallery.php, media.ie*.css)
* Stopped right-aligning media item details. It actually looks better when left-aligned with a small margin... (media.css)
! Media RSS feeds needed some fixin'. (Aeva-Foxy.php)
* 'Information', and more importantly 'info', is not clear English, AFAIK. And yes, 'AFAIK' is clear English. (Media.english.php)
- Removed loadingbar.png and replaced it with simple CSS. (loadingbar.png, index.css)
* Other minor details. (index.css, Subs.php, Help.language.php)
! Undefined variable. (Media.template.php)

:edit: This is my 500th commit! :eheh:
Title: Re: New revs
Post by: Nao on April 23rd, 2011, 01:45 AM
rev 734
(3 files, 5kb)

- Is there a reason why all websites say to use "-ms-filter" for IE8? It accepts the simpler "filter" perfectly well... (Class-CSS.php)
! Apparently, all used HTML5 tags should get their display type redefined, otherwise the layout's broken in IE8. (index.css)
- mgabs? What's that? Where's that? Probably an old leftover... (media.css)
Title: Re: New revs
Post by: Arantor on April 25th, 2011, 05:08 PM
Revision: 735
Author: arantor
Date: 16:08:07, 25 April 2011
Message:
! Sync to BB 2.1.13 (all to Security.php)
 ! Two new ranges that Google contains. (Which will reactivate once IPv6 support is complete.)
 ! The other change to BB in 2.1.13 was in how it exited tests after detecting a search engine; this does not appear to affect our implementation.

! Sync to SMF 10488
 ! r10474, r10476 Cleanup of Subs-Calendar actually using the values passed to functions rather than relying on $_REQUEST for them. (Subs-Calendar.php)
 ! r10478 Don't do anything with the view-query page if debug mode isn't enabled (regardless of being an admin or not) (ViewQuery.php)
 ! r10480 Spacinazi, minor template bug (Subs.php, Admin.template.php)
 ! r10481 When creating a new ban, tick the boxes by default (ManageBans.template.php)
 ! r10482 News link was incorrect in places. (I also took the liberty of putting the right URL in the comment in ManageNews.php, their's is wrong still) (Admin.php, ManageNews.php)
 ! r10483 A few id mentions in the URL at times needed to be removed for mod_security. Note that their patch doesn't bother to strip $_GET['id'] use from Themes.php while I did here. (Themes.php, script.js)
 ! r10485 Updated create_table function signature to 'ignore' by default, in line with what they've done. This will need to be fixed properly at some point though. (Class-DBPackages.php)
 ! r10486 Changes to Subs-Members for PostgreSQL's benefit, but we will be pulled up on using the old code otherwise unless we feel like rewriting this bit. Pointless change from our POV. (Subs-Members.php)
 ! r10487 bbc that's destined for package readme display should be preparsecode'd first. (Packages.php)
 ! r10488 Warning status was shown inappropriately at times (Display.php, PersonalMessage.php)

! Not synced
 ! r10473 Removing __ magic methods and certain types of call_user_func/_array from the DB backtrace; since we're using an actual class rather than a pseudo extended/overloaded class like SleePy was playing with, it should not affect us. In any case, our criteria in the backtrace is different (for good reason)
 ! r10475 MySQL 5.5 compatibility fixes for SMF 1.1.x.
 ! r10477 MySQL 5.5 compatibility fixes for upgrader from 1.0.
 ! r10479 ;id= removed from ManageAttachments.php (was already done)
 ! r10484 Scheduled tasks did not return with an image when an image was requested; we already implemented this, and did it more cleanly.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/scripts/script.js
Title: Re: New revs
Post by: Nao on April 25th, 2011, 05:40 PM
Please make sure the menu css changes work in your favorite browser! (Tested browser list is below.)

rev 736
(8 files, 10kb)

* Removed padding parameter from the main menu, and replaced it with a few CSS tweaks that should allow for it to work the same. Tested successfully in Opera 11.1, Firefox 3.6, Safari 5, Chrome 12, IE6, IE7 and IE8. I think. (Subs.php, index.template.php, index.css, index.ie6.css, index.ie7.css)
- Hover emulation in IE6 was slow. Removed emulation from form elements and the .css class to save time. (.css is never used once JavaScript is active anyway.) (ie6hover.js)
* Hey Nao, you know you can use jQuery in events, right? (Aeva-Foxy.php)
* Spacinazi. (Profile-View.php)
Title: Re: New revs
Post by: Nao on April 26th, 2011, 02:25 AM
rev 737
(5 files, 10kb)

! Fixed user menu not staying open[1]. Also restyled it a little, and added an opening animation. (topic.js, index.css)
! Fixed outdated fixes in IE6 menus. (index.ie6.css)
* Moved some JS from the Display template to topic.js, and a class to where it should be. (Display.template.php, topic.js, sections.css)
 1. Finally!!
Title: Re: New revs
Post by: Nao on April 26th, 2011, 03:23 PM
rev 738
(5 files, 11kb)

* Rewrote user menu to use as little JavaScript as possible in the HTML page. Everything we need is processed in topic.js, and strings are stored in a new object. Also removed current_user_menu global, as it wasn't needed. (Display.php, Display.template.php, topic.js)
* Improved user menu styling. (topic.js, index.css)
* Spacinazi. (Class-Editor.php)

(Pete, feel free to tell me what you think about the rewrite.)
Title: Re: New revs
Post by: Nao on April 26th, 2011, 11:55 PM
rev 739
(4 files, 6kb)

! Fixed undefined variables in various situations. (Buddy.php, Subs-Cache.php)
* Testing for getElementById? Seriously? (db_aeva.php)
* Made user menu code slightly clearer. (topic.js)
Title: Re: New revs
Post by: Nao on April 27th, 2011, 10:24 AM
rev 740 (useless markup commit.)
(5 files, 9kb)

* multiple attribute is valueless. (Admin.template.php, ManageMedia.template.php, Media.template.php)
* checked attribute is valueless. This was fixed long ago, but the latest SMF sync brought in a couple more. (ManageBans.template.php)
* <a name> is deprecated in favor of <a id>. Forgot to fix that when importing AeMe. (Media.template.php)
* Commenazi. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on April 27th, 2011, 11:55 AM
rev 741 (useless rename commit.)
(38 files -3, 37kb)

* Renamed Javascript to JavaScript, for case nazis. I'm not one, but... Oh right, maybe I am. (Class-JSMin.php, Load.php, ManageMembers.php, ManageRegistration.php, Aeva-Embed.php, Spellcheck.php, Subs-Cache.php, Subs.php, Subscriptions-PayPal.php, aeva/readme.txt, TEMPLATES: Display, index, ManageBoards, ManagePaid, ManagePermissions, MessageIndex, Post, Profile, LANGUAGES: Help, ManageMedia, ManageScheduledTasks, ManageSettings, Media, PersonalMessage)
* Renamed use_lightbox to use_zoom, and other lightbox variables to zoom or zoomedia. I think most people are unfamiliar with what a lightbox is -- and zoomedia is more self-descript. (db_aeva.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.english.php, ManageMedia.french.php, Media.english.php, Media.french.php, ManageMedia.template.php, Media.template.php)
- Removed Highslide JavaScript files and outlines folder. The hs folder will wait until I'm finished converting. (aeva/highslide*.js, aeva/hs/outlines)
Posted: April 27th, 2011, 11:32 AM

Note: if you have use_zoom problems when reloading, that's because you have to go to Admin > Media > Settings > Appearance, and enable (or disable) Zoomedia. The variable is supposedly always set in the DB so I won't bother to add empty() tests.
Title: Re: New revs
Post by: Nao on April 27th, 2011, 11:59 AM
rev 742 (useless color conversion commit.)
(48 files -1, 172kb)

* Converted all 32-bit PNGs in the aeva images folder to 32-color PNG-8s, moved originals to other/images. (other/images/aeva32, images/aeva/*.png)
! Undefined index error in media area. (Aeva-Subs-Vital.php)
- white-op85.png was never used in media area. (images/aeva/white-op85.png)
Title: Re: New revs
Post by: Nao on April 27th, 2011, 07:09 PM
rev 743 (useless function removal commit.)
(7 files, 9kb)

- Removed stylesheet parameter from loadTemplate(). Instead, use add_css_file('myfile', true) to load extra CSS. This was only ever used to load admin.css in Moderation and Package areas, so it's not a big loss. As a note, the fatal parameter isn't used either, so it could go just the same. (Admin.php, Load.php, ModerationCenter.php, PackageGet.php, Packages.php)
- Removed wedge_add_css just the same. Wedge is really better off with only the main CSS being cached in its own file. Contextual files need to be in their own files. Next step: merge wedge_cache_css with add_css_file. They're like twins! (Class-Editor.php, Subs-Cache.php)
Title: Re: New revs
Post by: Nao on April 28th, 2011, 03:39 PM
rev 744 (useless not-so-useless commit.)
(24 files, 52kb)

* Hopefully finished converting the Media template to validate HTML5. (Media.template.php, Media language, ManageMedia language)
- Removed debug mode for auto-embedding. It probably had a point back when it wasn't as efficient as it is nowadays... If your embedding is slow, just disable a bunch of sites. (Aeva-Embed.php, ManageMedia language, Media language)
! Renamed aeva_* variables to embed_* in everything related to auto-embedding. Hopefully should work. Also renamed $context['media_disable'] to $context['disable_media_tag']. (db_aeva.php, Aeva-Embed.php, ManageMedia.php, ManageMedia3.php, Subs-Media.php, ManageMedia language)
+ Added a .bbc_pre class to emulate <pre> mode in spans. Did some fixing on other occurrences of <pre>. (index.css, install.sql, Load.php, Subs-BBC.php)
- Removed support for pre_include hook. I don't think it's the 'right' way of doing it. Also removed WEDGE_HOOK_SETTINGS, since there's actually no point in providing support for a deprecated way of adding hooks... I must have been drunk when I did that in rev 252. (Load.php, Subs.php)
+ Added file parameter in add_hook(). You can now specify the required source file directly in that call. Skip the php extension and make sure it's a relative path based on the Sources folder. (Subs.php, Credits.php, ManageSettings.php)
! Fixed URL trimmer. It didn't actually work until now... (install.sql, Subs-BBC.php, ManagePosts.php, Admin language)
* Spacinazi. (db_aeva.php, Subs-Exif.php, captcha-ledicons_anim.php, Aeva-ModCP.php, Aeva-Subs-Vital.php)

@ Note: I renamed the aeva_ variables to fix issues with settings not being saved (they were expecting media_ vars so I changed everything to embed_). Maybe I should have simply told Wedge to expected aeva_ vars, but it's too late to change my mind now... Hopefully if there's any error in my change list, it'll be found soon enough. Or at least faster than it took me to realize trim_url wasn't working... :whistle:
Title: Re: New revs
Post by: Nao on April 28th, 2011, 06:58 PM
rev 745 (so useless I forgot to post it here)
(3 files, 8kb)

! Fixed a bug where after quick editing a post, you couldn't quick edit it again without either reloading the page or quick editing and cancelling another post. (topic.js)
! The hide_prefixes variables is a global, so it shouldn't be declared as local. (topic.js)
- Removed optimize section from topic.js, as I'm starting to dislike the systematic use of this feature on variable names. (topic.js)
* Tags can be in HTML5 format inside XML as long as they're inside CDATA tags... (Xml.template.php)
* The $xml variable in the CSS parser is misleading. It's not a XML document we're building, just some regular, arbitrary, crawlable HTML soup. Renamed it to $tree. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on April 28th, 2011, 10:39 PM
rev 746 (useless IE fixin')
(2 files, 5kb)

! I don't remember why (or when) I did that, but I think it seemed important at the time. Reverted the 'nowrap' white-space rule to 'pre' for .bbc_code and .php_code, as it didn't work in IE7 and IE8. (index.css)
! IE8 screws up short messages with smileys. (index.ie8.css)

@ Note: I really don't remember... >_< The first occurrence of the change is when I changed the default styling from Wuthering to Warm... But apparently, Warm wasn't already stored in the SVN at that point. So it kinda comes out of nowhere... Please test a multi-line code tag in Firefox, Chrome and Safari if you're interested in making sure it keeps working...!
Title: Re: New revs
Post by: Nao on April 29th, 2011, 12:34 AM
rev 747 (useless iPhone commit)
(1 file +1, 6kb)

+ Added a (temp?) iPhone icon and made sure to use the icon by default when posting from an iPhone or iPod Touch. (Post2.php, images/post/iphone.gif)

Note: tested on the demo site...
Title: Re: New revs
Post by: Nao on April 29th, 2011, 04:31 PM
rev 748 (useless commit except for Pete and others here :P)
(2 files +1, 9kb)

+ Added hook for plugins to automatically modify $browser right after it's been built. (Load.php)
+ Added 'tablet' entry to browser detection. It only detects the iPad for now. Hi Pete! (Load.php)
+ Added a tablet entry to the list of wireless devices that get their own icon in posts. (Post2.php, images/post/tablet.gif)
Title: Re: New revs
Post by: Arantor on April 30th, 2011, 01:25 AM
Revision: 749
Author: arantor
Date: 00:25:07, 30 April 2011
Message:
! Sync to SMF 10497
 ! r10489 Setting base_theme_dir caused undefined index errors in manage languages area. (ManageServer.php) [Bug 4634]
 ! r10490 Personal message preview did not display post errors. (PersonalMessages.php) [Bug 4653]
 ! r10491-2 Custom language strings were not loaded when editing theme settings. (Themes.php) [Bug 4658]
 ! r10493 modify_modifications hook should be triggered earlier in the code. (ManageSettings.php) [Bug 4638]
 ! r10494-5 menu_items hook was triggered too late in the code. (Subs.php) [Bug 4637,4670]
 ! r10496 (adapted) Undefined index errors when there were not any recent posts. (BoardIndexInfoCenter.template.php) [Bug 4650]
 ! r10497 CAPTCHA settings were linked to the incorrect area in admin search results. (Admin.php) [Bug 4707]

I'm not entirely happy with the changes in r10494/5, as per my comments originally in bug 4637; I do not entirely agree that the menu items hooked items should be cached like this unless you guarantee to flush the cache at any point when you will removing add-ons, or you have add-ons that do funky dynamic buttons. (Any add-ons should really be paying attention. It isn't that hard, either. But I can see the flip side of why it's been done, too, that it does simplify and make consistent additive item behaviour. So I've committed it, after some internal deliberation. It will be interesting to see how this stands up for add-ons that actually do this; I suspect no-one's actually been using the hooks for this other than Fel (for PortaMX), Live (for EP) and myself (SimpleDesk) anyway. Won't get into the debate here over whether a system author should listen to the needs of those who modify the system or not.)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Title: Re: New revs
Post by: Arantor on May 1st, 2011, 02:23 AM
Not a very exciting r750, but still...


Revision: 750
Author: arantor
Date: 01:23:17, 01 May 2011
Message:
! Centralised the setlocale calls instead of making them on every call to formatting some time, as well as centralising the locale definition in the language files (Load.php, Subs.php, Subs-Media.php, index.french.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Nao on May 1st, 2011, 08:50 AM
rev 751 (useless "it's not 750, dude!" commit)
(7 files +3, 29kb)

+ Added support for new CSS keywords (Class-CSS.php)
  + Cancel inheritance ('unextend' keyword, useful for inherited stylings)
  + Delete a property entirely ('@remove' command)
+ Added support for all possible unit types in math functions. Also removed the mismatched unit protection code, because I'm not sure whether it's best to keep it to not. I'd have to rewrite it anyway. (Class-CSS.php)
* Optimized grad700.png for size, moved original to the image backup folder, as well as the original iPhone and Tablet icons. (other/images/*, grad700.png)
* Updated credits. Project managers are Wedgeward (still us!), added tentative Consultant and Support teams to Wedge credits. Made page more readable. (Credits.php, sections.css)
+ Added support for browser-agnostic linear-gradient call. (Although older Safari versions and IE6/7/8/9 will choke on it.) Also simplified call to the CSS property fixer. (Subs-Cache.php)
* Replaced 'create_topic' hook with the more interesting 'create_post_before' and 'create_post_after'. (Subs-Post.php)
+ Added 'modify_post_before' and 'modify_post_after' hooks. Guess what they do. (Subs-Post.php)
+ Added dummy example for a CSS section in styling file. (Warm/settings.xml)
Title: Re: New revs
Post by: Nao on May 1st, 2011, 05:51 PM
rev 752
(4 files +1, 41kb)

+ Added support for CSS math functions max, min and rand. I should have done min and max from day one. (Class-CSS.php)
* Committing CSS preparser with 'reset' keyword in the WIP folder. Although I'm sure it'll never be used. (other/wip/Class-CSS (reset keyword).php)
! Non-main CSS files needed an extra dash in the URL. (Subs-Cache.php)
! Fixed JumpTo and optimized for speed and size. (script.js)
! Fixed Wuthering header. (Wuthering/index.css)
Title: Re: New revs
Post by: Nao on May 2nd, 2011, 11:58 AM
rev 753
(4 files, 7kb)

! In the case where multiple selectors were extended at the same time, Wedge didn't always apply inheritance to all of them. (Class-CSS.php)
! Fixed stray dash in CSS cache files when using the default styling (oops.) (Subs-Cache.php)
! Hopefully fixed post overflow issues by, ahem... Setting it to visible. Eh, what? (index.css, index.ie8.css)
+ Added $big_font and $post_font CSS variables. Trying to be more... Semantic, see? Something like that. (index.css)
Title: Re: New revs
Post by: Nao on May 2nd, 2011, 03:27 PM
rev 754
(7 files, 10kb)

! Fixed CSS/JS caching on Mobile Safari. (It appears the extension issue only occurs in the desktop version.) (Subs-Cache.php)
! Fixed Mobile Safari crash (why only this?) caused by incorrectly moved variable declaration. (topic.js)
! Webkit keyword wasn't removed from CSS URLs in the main file caching function. (Subs-Cache.php)
! Added missing device icons to stable_icons(). (Subs.php)
* IE always defined createTextRange, doesn't it? (Class-Editor.php)
* Added a meta tag for iPhone devices to increase image and text size. It doesn't look very good, but it's way more usable. (index.iphone.css, index.template.php)
* Overflow problems in polls. (sections.css)

@ Not too happy with the new iPhone look, but honestly... It can serve as a starting point, and usability is more important on a handheld device than looks.
Title: Re: New revs
Post by: Nao on May 2nd, 2011, 07:51 PM
rev 755
(1 file, 7kb)

+ Added ability to inherit CSS elements from multiple parents. Specify a comma-separated list of items in base: for this, or if you prefer the extends syntax like me, use double quotes around the list (.class extends ".class2, .class3"), otherwise Wedge will consider anything after the first comma to be outside the extend declaration (".class extends .class2", .class3). Not used in Wedge yet, but this can be very interesting in the long run for themers and us. (Class-CSS.php)
! If extending with the use of an ampersand alias, Wedge will now make sure there's only one parent. If there are more, it will only extend based on the first listed parent, to avoid any complications. (Class-CSS.php)

@ That last line -- I could have fixed it to apply to all elements in the list, but honestly at this point it's probably a logic error in the themer's file, and I don't want to waste CPU cycles applying verbatim a request that comes from someone who didn't get what "&" does exactly...
Title: Re: New revs
Post by: Arantor on May 3rd, 2011, 01:12 PM
Revision: 756
Author: arantor
Date: 12:12:01, 03 May 2011
Message:
! Sync to SMF 10503
 ! r10498 Fix the header bar in reports area to be category rather than title. (Reports.template.php) (SMF rev also changed Admin template, this was already done in Wedge)
 ! r10499 Fix to stop linktree anchors scrunching in IE6 and IE7. (index.css) [Bug 4651]

! Not including
 ! r10500 Making category titles not into links if they're not collapsible - in our case, the category header wasn't even a link to start with.
 ! r10501 CSS change for layout related bug on collapsed categories - bug doesn't affect us as far as I can tell or reproduce (see bug 4639)
 ! r10502 Renaming 'Packages' to 'Package Manager' just for consistency in the menu (this was a reported bug!)... well, they're not called packages here...
 ! r10503 Restructuring the size of dl items in the admin panel just because it throws scrollbars when using the existing sidebar on sub 1024 wide screens... no thanks. (The dl becomes 25% wide and the dt 71% wide...)

! Other
 ! Fix category links to point to #category_n instead of #cn because the category title anchor no longer exists. (Load.php, Recent.php, Search2.php, Unread.php, Unreadreplies.php, ModerationCenter.template.php) (Replaces SMF r10500 only done so much nicer)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/styles/index.css



You can guess who made these SMF revs, can't you?
Title: Re: New revs
Post by: Nao on May 3rd, 2011, 03:36 PM
I'd say Unknown committed these. It's so Unknown! :niark:

Soooo... One commit per minor bug fix, eh? Even with that trick, they still have barely done 430 commits since we started work on Wedge... And we certainly don't settle on a single change per commit :whistle:

rev 757
(12 files, 18kb)

* Reworked poll layout. Moved it below the topic title (to keep a sense of unity when switching between topics with the prev/next links), moved moderation buttons to the top, turned the box into a we:block, etc. (Display.template.php)
! Skip sidebar/top templating in Wireless. It's already done in a few areas to save CPU time, but should be systematic. (Load.php)
! Fixed wrong text string index. (Subs-Media.php)
! If a block specifies an empty parameter, it should be ignored entirely. (Subs.php)
+ Added an 'id' parameter to we:blocks. (index.template.php)
! Because of the sidebar, poll question inputs could overflow easily. (Poll.template.php)
* Reworked profile warning level system's layout. (Profile.template.php)
- ajax_indicator() is always defined. Don't bother testing for it. (topic.js)
! document.body isn't set up on all browsers, or so I've heard. (topic.js)
! User menus were closing unexpectedly in some situations. (topic.js, index.css, sections.css)
* Spacinazi. (Display.php, ManageSettings.php)
Title: Re: New revs
Post by: Nao on May 4th, 2011, 12:21 PM
rev 758
(19 files, 22kb)

+ Added 'e' parameter to all delayed events. You can now directly access the jQuery-normalized event object for any inline event using the 'e' variable. (Subs.php, example in Profile.template.php)
* Rewrote timing strings in footer to use sprintf, say '1 query' instead of '1 queries', and use a str_replace instead of a preg_replace. (Subs.php, index.template.php, index language)
+ Added language strings for Dynamic Replacements. (Subs.php, index language)
* Rewrote timing functions to use microtime(true) instead of the tricky microtime() for $time_start. You can now easily determine the amount of seconds spent in the page execution with "microtime(true) - $time_start". Also, SMF used time() in a few places to track time spent... Ah ah! No, it's not a joke actually. (index.php, SSI.php, ssi_examples.php, Class-DB.php, ManageAttachments.php, ManageMail.php, ManageMaintenance.php, Aeva-Gallery2.php, ManageMedia.php, Packages.php, RepairBoards.php, ScheduledTasks.php, Subs.php)
! Fixed user menu bug in FF4 and removed useless e.toElement calls, as e.relatedTarget is standardized in jQuery. (script.js, topic.js)
* Rewrote Issue Warning JS to actually work as the SMF code *wanted* it to work (drag'n'slide to change percentage), because yes, it didn't work. (Profile.template.php)
Title: Re: New revs
Post by: Nao on May 4th, 2011, 12:30 PM
rev 759
(11 files, 11kb)

* Fixed remaining microtime() calls. (tools/*, Feed.php, ManageScheduledTasks.php, Subs-BBC.php, Subs-Cache.php)
! $context['show_page_load'] was used in the index template - chose to restore it instead of removing it. (Subs.php, index.template.php)
Title: Re: New revs
Post by: Nao on May 5th, 2011, 08:50 PM
rev 760
(11 files, 12kb)

* Changed .attr() calls to be compatible with jQuery 1.6, as we'll probably move to it eventually. (ManageBoards.php, ManageNews.php, Subscriptions-PayPal.php, ManageMaintenance.template.php, ManagePermissions.template.php, ManageSmileys.template.php, Profile.template.php, Register.template.php, up.js)
! Oops, .titlebg was inheriting from the wrong selector. (index.css)
* Details. (post.js, script.js)

NB: Might want to consider optimizing .is() calls in a loop...?
Title: Re: New revs
Post by: Nao on May 6th, 2011, 12:08 AM
rev 761
(2 files, 7kb)

! It's show_load_time, not show_page_load... (Subs.php)
* Minor optimizations on the uploader JS. (up.js)
Title: Re: New revs
Post by: Nao on May 6th, 2011, 07:39 PM
rev 762
(1 file +1, 95kb)

* Now using jQuery 1.6 instead of 1.4.4. Keeping the old file in the SVN for now, we never know. (Load.php, jquery-1.6.js)

(What? I'll show the SMF guys I can do single-file commits, too! :niark:)
Title: Re: New revs
Post by: Nao on May 7th, 2011, 07:31 PM
rev 763
(8 files, 10kb)

! In some cases, the template footer wouldn't be called, and an error would be generated. (Subs.php)
! Why ask Wedge to do a simple addition on tag processing, when developers can do it once and for all? (Subs-BBC.php)
! Inline post edit could generate errors, and trigger yet another error when trying to announce it. (topic.js)
+ Added 'headline' class to the more tag, for themers to style post introductions. (Subs-BBC.php, index.css)
* Upgraded other jQuery 1.4.4 occurrences. (install.php, repair_settings.php, upgrade.php)
* ajax_in_progress box was too big. (index.css)
- Outdated documentation. (admin.js)
Title: Re: New revs
Post by: Nao on May 9th, 2011, 09:56 PM
rev 764
(4 files +1, 97kb)

* Updated credits with missing names. (Credits.php)
! Replaced main jQuery 1.6 calls with version 1.5.2 instead. Waiting for 1.6.1 with the fix to $.offset() (Load.php, jquery-1.5.2.js)
+ Added minor but nice animation to the menu system. It's just two lines... Can be reverted easily. (script.js)
* Post font spacing was one pixel too big for my taste. (index.css)
* Fixed menu border color and made them slightly less transparent. We got it, it's transparent, it's cool. It should be readable, too. (index.css)
Title: Re: New revs
Post by: Nao on May 10th, 2011, 12:38 PM
rev 765
(7 files, 27kb)

* Massive rewrite for Zoomedia. (zoomedia.js, zoom.css)
  * Starting position for zoom animation now matches exactly the origin thumbnail.
  * Slightly reduced border size, as it was a bit too much for my taste.
  * Descriptions no longer show up as overlays on the image. They also enlarge the zoomedia box if it's too narrow to hold the description.
  + Double-click the original thumbnail, or the opened preview, to enlarge it into the fullsize version. Includes annoying fix for IE 6/7/8.
  ! IE6 always showed the Loading label, even if the image was cached.
  ! Outside closing clicks were tested even with no zoomedia box opened. Ooops.
+ Added menu animation for low-level menu entries as well. (script.js)
- Removed useless 'added' parameter from sitelist. (ManageMedia3.php, Subs-Aeva-Sites.php)
- Removed hss() as full zoom handler. This is now done entirely by Zoomedia. (Aeva-Subs-Vital.php, Subs-Media.php)

Zoomedia tested under IE6, IE7, IE8 and Opera 11.50... Haven't tested in Chrome for a few days but it should work.
Title: Re: New revs
Post by: Nao on May 11th, 2011, 11:59 AM
rev 766
(13 files, 12kb)

! base64-encoding bypass technique failed when base64 encoding wasn't supported. (Class-CSS.php, Subs-Cache.php)
! The More tag could cause errors when parsed outside of a topic. (Subs-BBC.php)
! Some headers still had an icon next to the header text without any whitespace. (TEMPLATES: Login, Memberlist, Notify, PersonalMessage, Recent, Themes)
* Don't need strong tags in a header... Chances are it's already in bold. (Aeva-Foxy.php, ManagePermissions.template.php)
* $()[0].checked is faster than $().is(':checked'), so use that in loops. (ManagePermissions.template.php)
* Minor typos and such. (BoardIndex.php, Packages.template.php)
Title: Re: New revs
Post by: Nao on May 12th, 2011, 01:06 AM
rev 767
(16 files +1, 24kb)

+ Officially added outline types 'drop-shadow', 'white' and 'black', replacing the Highslide equivalents and adding black to the lot. (Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php, zoomedia.js)
* Replaced table-based layout with inline-blocks for media item lists. This allows for simpler handling of list layout, especially with different screen sizes. Opera, oddly, needed a trick to avoid generating scrollbars on hover. Took me hours to figure one out. (Subs-Media.php, media.css, media.ie6.css, media.ie7.css, media.opera.css)
- Removed num_items_per_line options, as they're a moot point with the new item lists. (db_aeva.php, ManageMedia.php, Subs-Media.php, ManageMedia.language.php, Media.template.php)
- AFAIK, media item hover boxes don't need to bother with a 'faux' trick... (Subs-Media.php, media.css)
- And jQuery can do without a 'px' mention when animating or setting CSS. (zoomedia.js)

@ Known issue: the zoomedia close button doesn't show consistently across all browsers, especially when resizing to full size. (zoomedia.js)
Title: Re: New revs
Post by: Nao on May 12th, 2011, 06:52 PM
rev 768
(7 files, 12kb)

! Guests could generate an internal error when updating the topic view count. (Display.php)
+ Added $new_topic to the list of params that can be read and rewritten in createPost. (Subs-Post.php)
! Unseen media area was using the wrong language strings and had misplaced buttons. (Media.template.php)
! Some of the media permissions still had the 'aeva_' name in them. Hopefully I've updated everything that needed it. (ManageMedia.php, ManageMedia.language.php, ManageMedia.template.php)

(Can't believe some of these bugs I never noticed until now... :P)
Posted: May 12th, 2011, 06:50 PM

(And yes, that's probably the reason why single-upload didn't work on the demo site...)
Title: Re: New revs
Post by: Nao on May 13th, 2011, 10:03 AM
rev 769
(8 files +1-1, 23kb)

* Renamed media-admin.js to mediadmin.js, to avoid possible confusion in filenames. There was no harm done, but as a general rule of thumb, we should avoid hyphens in JS/CSS filenames when one of the filename's elements is a common one, like... media, or admin. (Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php)
! Fixed a language string possibly not being loaded in the album manager. (Aeva-Gallery2.php)
! One of the PNG8 files didn't correctly set the alpha bit. (arrow_inout.png)
! admin_toggle() was broken due to the use of .has() instead of .is() (mediadmin.js)
! admin_toggle() only takes one parameter. (ManageMedia.template.php, Media.template.php, mediadmin.js)
! Media pruning area was broken. (ManageMedia2.php)
* Moved admin_prune_toggle() to the actual media pruning admin page -- it's only used there, and it's short. (ManageMedia.template.php)
* admin_toggle() will now open its flower only after its related icon has finished loading. Maybe better, maybe worse. (mediadmin.js)
* Alignazi. (Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on May 13th, 2011, 08:15 PM
rev 770
(10 files -1, 11kb)

* Parenazi. (Security.php)
* Bad whitespace! (Errors.template.php)
* Apparently, .attr('value') is frowned upon. (script.js, suggest.js, topic.js)
* Removed that silly white-space 'fix' devised by the SMF devs for linktrees, and replaced it with what I call a fix. (index.css, index.ie6.css, index.ie7.css)
! admin_toggle() shouldn't use expand/collapse icons, they're no longer provided. (mediadmin.js)
- Removing unneeded placeholder code in linktrees. (index.template.php)
- Removing jQuery 1.6, it sucked. (jquery-1.6.js)
Title: Re: New revs
Post by: Nao on May 13th, 2011, 08:28 PM
rev 771
(9 files, 18kb)

! Reverted allowedTo('media') to aeva_allowedTo(), because it's not the same. Really. And it fucked up permission profiles. Can I say 'fuck' in the changelog? No? Oops. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Subs-Media.php, Media templates)
! More expand/collapse fixes. (ManageMedia.template.php, Media.template.php)
* Cleaned up some variables, to be set in the Sources folder now, rather than in the Media template. (Aeva-Gallery.php, Media.template.php)
* Cleaned up table names. (ManageMedia.language.php)
Title: Re: New revs
Post by: Nao on May 15th, 2011, 04:06 PM
rev 772
(9 files, 13kb)

+ If Today/Yesterday date transformations are enabled, check for the year and remove it if it's the current one. (Subs.php)
! If pretty URLs were enabled, the jump box would redirect to the homepage because 'board' wasn't treated in the URL. (QueryString.php)
* Removed a few 'px' suffixes whenever jQuery could handle them by itself. (editor.js, script.js, suggest.js,
! Style fixes. (index.css, media.css)
* Indenazi. (Media.template.php)

@ The date thing was an idea I had and executed in a few minutes time only. I'm not SURE it's for the best, but I like it for now. The reason why it's in Today/Yesterday is to avoid an extra getdate() call, as well as avoid transforming whenever we want the full date (e.g. "Hello user, today is...")
Title: Re: New revs
Post by: Nao on May 17th, 2011, 10:18 AM
rev 773
(7 files, 12kb)

! Zoom outline options weren't passed to album pages. (Needs a fix in zoomedia.js as well, but I'm in the middle of rewriting it.) (Subs-Media.php)
* A few language strings were using longform XHTML tags. (ManageMedia.language.php, Media.language.php)
! French version recommended 6-char passwords or more, even when security settings force it to be at least 8 chars. (Profile.french.php)
* Spacinazi. (ManageMedia.template.php)
Title: Re: New revs
Post by: Nao on May 18th, 2011, 04:02 PM
rev 774
(13 files, 17kb)

! SMF bug: crash when providing several negative search terms (i.e. excluded terms) in a search. This was due to the inner_join array containing multiple occurrences of the same JOIN. (Search2.php)
* Renamed <strong class="highlight> to the more semantic and shorter <mark>, and renamed the highlight2 class to highlight, since it's no longer in use. (ManageServer.php, PersonalMessage.php, Search2.php, Profile.template.php, spellcheck.js, index.css, sections.css)
! Since we don't exactly know what HTML flavor SSI.php is being run with, make sure to use alt params in img tags. (SSI.php)
* Moved title from link to image in selectable language flags. And yes, I know, img title support in screen readers is pretty poor. Maybe we should add an alt for these. Uh. (index.template.php)
* Added <meta name="generator" content="Wedge">, both as a signature, and to stop HTML validation from pestering us with yet another change in the mandatory use of alt params in img tags. (index.template.php)
* Hopefully finished converting the admin area's media template to HTML5. (ManageMedia.template.php)
* Signatures shouldn't have the same color as post bodies. Chose a slightly less contrasted version. (sections.css)
* Shaving a few bytes off script.js. You know me... I can't stop myself. (script.js)
+ Added very preliminary support for paragraph headers inside blocks. (index.css)
* Too much vertical space wasted between thumbnails in album pages. (media.css)

@ Note: this changelog needs being discussed, I *think*...
Title: Re: New revs
Post by: Nao on May 19th, 2011, 11:00 AM
Okay, well, apparently rev 774 didn't need discussin'? :P
This new one is short but still required hours of testing. >_<

rev 775
(2 files, 7kb)

+ User menus will now extend to the width of the user name, even if it's very long. Well, probably not in IE6 but who cares. (topic.js)
+ Added some extra code to ensure the user name is still visible uncropped when hovering over the menu rather than the user name itself. (topic.js, sections.css)
Title: Re: New revs
Post by: Nao on May 19th, 2011, 03:00 PM
rev 776
(2 files, 6kb)

! The 'code' tag security check at registration time should be case-insensitive. I think. (Register.php)
* Modified user menu again to close it even when the mouse isn't moving. We just need to store all mouse events during the animation... (topic.js)
Title: Re: New revs
Post by: Nao on May 21st, 2011, 03:23 PM
rev 777
(8 files, 23kb)

* Rewrote most of Zoomedia to make it more solid across all browsers, especially when it comes to the double click behavior, and making sure any CSS changes to zoom box padding won't affect the JS code. (zoomedia.js, media.css, media.opera.css, zoom.css)
* CSS details. (other/wip/text-overflow.js, post.js, script.js)
* Saving a few bytes at compression time. (topic.js)

@ Left to fix: zoom box descriptions in small viewports. I don't really know how to fix... I was thinking of 'simply' resizing the box to make it fit *and* keep the description height the same (otherwise it will overflow), but come to think of it, it'd probably be smarter to actually hide the description because we could use that size, and simply show a "Details" link along with some indication that it has a description.

What do you think?
Title: Re: New revs
Post by: Arantor on May 21st, 2011, 07:17 PM
Revision: 778
Author: arantor
Date: 18:16:47, 21 May 2011
Message:
! Sync to SMF
 ! r10504 Validation error with collapsed boards. (And I got the indentation right.) (BoardIndex.template.php)
 ! r10505 Making a board child of itself crashed the forum. (Subs-Boards.php, Errors.english.php) [Bug 4710]
 ! r10506 Theme option changes was not loaded after profile changes in some cases. (This fix is slightly more thorough than the one posted before, it actually checks the input is an array before trying to use it as such, but otherwise it's the same fix.) (Profile-Modify.php) [Bug 4675]
 ! r10510 Member language selection was not reset upon a language deletion. (ManageServer.php) [Bug 4641] (And I fixed the comments, which they didn't.)
 * r10511 JavaScript quick topic modify did not work when quick moderation mode was 'icons'. (MessageIndex.template.php) [Bug 4715]
 ! r10512 It was possible to create permission profiles without names. (ManagePermissions.php) [Bug 4709]
 ! r10513 Additional group changes were not tracked properly. (Profile-Modify.php) [Bug 4718]
 ! r10514 Ignore boards options were ignored in MessageIndex. (Subs-BoardIndex.php) [Bug 4719]
 ! r10515-6 Remove Inactive Members maintenance removed members it should not. (ManageMaintenance.php) [Bug 4716]
 ! r10517-8, 10520 Reserved member name check failed with HTML entities. (Subs-Members.php) [Bug 4717]
 ! r10522 Minor break in PM replies fixed. (PersonalMessage.template.php) [Bug 4713] (Couldn't seem to replicate this in SMF, let alone Wedge, so have included it for now anyway)
 ! r10523 Fixed incorrect class on checkbox. Changed default removal selection to safest option.(ManageMaintenance.template.php) (The class was already gone, so that wasn't an issue, but I agreed with the change about the topic maintenance, instead of the default of 'any' being default under the purge-old area, the default is now 'moved notices')
 ! r10527 Installing, upgrading and uninstalling packages were not logged in admin log. (Packages.php, Modlog.english.php) [Bug 4469] (I actually made this one last spring as a mod, and handed it to the team on a plate to implement. They finally did!)
 * r10528 It was not possible to remove avatar when selecting avatar from gallery was disabled. (Profile-Modify.php, Profile template) [Bug 4636]
 ! r10529 Automated conversion of URLs to hyperlinks failed with URLs containing exclamation mark. (Subs-BBC.php) [Bug 4624]
 * r10530 Topic moderation using checkboxes did not function correctly for non-moderators. (topic.js) [Bug 4706] (This got jQuery-ified in the process. Hopefully this isn't too ugly now.)
 ! r10532 Profile updates did not load all previously saved data. (Profile.php, Profile-Modify.php) [Bug 4635]
 ! r10533 Login session data was cleared when it shouldn't have. [Bug 4644] And while we're at it, login by $_GET is not needed. (Login2.php, Subs-Login.php)
 ! r10537 Incorrect custom menu URL for unapproved posts moderation area. (ModerationCenter.php) [Bug 4728]
 ! r10538-9 Languages which doesn't support 12 hour time format had their 'am/pm's stripped. (Subs.php, index.english.php) [Bug 4720] (I've implemented this as is, but we may want to revert this in the time to come; there is likely a better way of doing it.)
 ! r10540 Incorrect error message when attempting to remove a non-existing post. (RemoveTopic.php) [Bug 4705]
 * Tabs and line endings within code tags were not parsed correctly for some browsers. (Packages.php, Packages.template.php) [Bug 4578] (I already attacked most of this previously, as it happens, only the package manager stuff wasn't done, and done differently - and likely better.)

! Not sync'd
 ! r10507 Bringing back the good, old welcome guest note along with activation link. [Bug 4703] (Apart from actually not doing what the changelog describes (it actually turns the 'Please login or register' into 'Welcome, Guest, please login or register')... that particular change is already better reflected in the sidebar.
 ! r10508 Upgrader fixes for MySQL 5.5 for upgrading from 1.0 and 1.1 [Bug 4698]
 ! r10509 Supposedly makes sure the MIME type gets fixed when upgrading from before 2.0, but I don't see how checking that smfVersion is identical to '2.0 a' is a viable trigger here... [Bug 4700]
 ! r10519 Replicating the change from 10517-8 into 1.1 branch
 ! r10521 More MySQL 5.5 fixes, this time for 1.0
 ! r10524 Fixed Webkit/Presto bug with sidebar menus enabled. Deleted superfluous code from webkit.css and rtl.css (index.css, rtl.css, webkit.css) (The main change in index.css isn't relevant to us anyway, the RTL changes ditto... and the Webkit changes, well, I think they should probably have left the clear:right in, the others don't apply...)
 ! r10526 Categories which could not be collapsed were still given collapse links. (Subs-BoardIndex.php) [Bug 4639] (We didn't give them collapse links directly like SMF do anyway, this was never an issue for us.)
 ! r10531 Sidebar fixes - Fixing class 'clear clear' from r10525, making #avatar_upload be overflow:auto (though I have no idea what's prompted that) and giving #creator dd the same overflow, again no idea why it's necessary... so I didn't include them. Oh, and resizing an input type=file...
 ! r10534-6 Converters stuff
 ! r10542 Like 10509, this adds a test for version being '2.0 a' into the theme upgrader code.

! Special stuff
 ! r10525 Lots of weird little layout 'fixes' "mostly for IE6". The individual changes are not documented in the changelog, nor anywhere else I can find.
  - Subs-BoardIndex.php, breaking the category links up so instead of a single a tag being the anchor for categories and the link for collapsing it, they separated it. We were already separate anyway after the last time they messed with this. (NOT ADDED)
  - Admin template, instances of hr tags all getting .clear added to them, not entirely sure why. Including one instance of hr that needed it so badly, it became class="hrcolor clear clear". Not entirely sure why they did this. (NOT ADDED)
  - admin.css, removing a resizing of dt and dd relative to each other inside the admin area (for narrower screens with sidebar). Code doesn't apply to us. (NOT ADDED)
  - ie6.css, they adjusted a height for the 'admin panel' from 655px to 100%, but the code doesn't apply to us. (NOT ADDED)
  - index.css: removing the weird -99em left margin for no-collapse titles (which we already noted was ridiculous at the time Ant added it, also removed from rtl.css), made the dd bigger in dl.settings (now occupies 56% instead of 48%) and also make it overflow auto to cope with smaller resolutions, they also adjusted #creator dd to float right, which is the right panel in the profile area... for no reason I can see. (ADDED, except the #creator change)
  - BoardIndex template, rejigging how the category title was output with the surrounding markup. Incidentally, it's now virtually what we already had, with the actual name being output last, relative to the collapse and unread links. (NOT ADDED)
  - ManageBans template, making one text field bigger than the DB field that holds it, plus resizing the different text boxes to line up; we're going to be ripping this out anyway. (NOT ADDED)
  - ManageBoards template, adding style="float:left; width:100%;" to the ul that forms the category contents of the main manage-boards screen, really no idea why. (NOT ADDED)
  - ManageMembers template, making some catbgs rounded when they weren't before. (ADDED)
  - ManagePermissions template, making one area handle oversize content better. (ADDED)
  - ManageSearch template, moving the save-search-weights button into the curved area and to the right, to be more consistent with everything else, and moving the save-search-method button to the right, again for consistency. (ADDED)
  - Packages template, making the textboxes all the same size. (ADDED)
  - Profile template, the instances of hr tags all got .clear added to them, like Admin template. (NOT ADDED)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/topic.js
Modified : /trunk/Themes/default/styles/index.css
Title: Re: New revs
Post by: Nao on May 22nd, 2011, 12:18 AM
rev 779
(17 files, 26kb)

! rev 778 didn't use westr::htmlspecialchars where needed. (Packages.php, Subs-Members.php)
! A $_POST was being tested after checking whether the corresponding $_REQUEST was set. (Subs-Login.php)
* French translation. (Errors.french.php, index.french.php, Modlog.french.php, Profile.french.php)
* I thought I'd optimized all of the labels... Apparently not. I'm just doing this one okay? (Profile.template.php)
! $.length() doesn't work. It's $.length, not a function. Also optimized code for compressed size. (topic.js)
! Button strips don't have child divs, they use unordered lists. Also, the default class for them is floatleft, not floatbottom. (topic.js)
! User box user names were being shown on top of zoom boxes. (sections.css, zoom.css)
! Removed useless right padding from stat months/days. Way better in small resolutions. (sections.css)
! It's add-on, not package. I think. (Modlog.english.php)
* Spacinazi. (ManageServer.php, Aeva-Gallery.php, Profile-Modify.php, index.language.php)
* Ugly CSS. (ManagePermissions.template.php)

Please read the changelog above and review the code fixes!
Title: Re: New revs
Post by: Nao on May 22nd, 2011, 08:17 AM
rev 780
(4 files, 10kb)

* Zoomedia now properly resizes a zoom box to the viewport height when needed, and gets rid of the description to save space. (zoomedia.js)

* The aelink class is no longer a class for links but for the link container in item descriptions. Cleaner this way. (Subs-Media.php, media.css)

* Avatar selection code was too big when it could be done in 5 lines. Uh. (Profile.template.php)

* Server-based avatar selection box was too large. Now it should be better integrated. (Profile.template.php)
Title: Re: New revs
Post by: Nao on May 22nd, 2011, 11:59 PM
rev 781
(1 file, 5kb)

! Safari and Chrome didn't reset the sidebar when resizing to a small viewport and then back to a normal viewport. Fixed by setting the 'hidden' sidebar state to a block instead of a table. Sounds easy but it took hours to debug. Hate it when it happens. (index.css)

(Just wanted to commit this ASAP because it really was a PITA. I'm surprised Pete didn't notice anything -- you're using Chrome right?)
Title: Re: New revs
Post by: Nao on May 24th, 2011, 12:34 AM
rev 782
(4 files, 9kb)

! Fixed various issues in several browsers when resizing a zoom box to fit the viewport height. Had to add a IE6/7 hack to make it barely work, though. Will try fixing it later. (zoomedia.js)

* Applied the Opera 'hack' to all browsers, because it actually works best when resizing the screen. (zoomedia.js, zoom.css, zoom.ie6.css, zoom.ie7.css)

* Optimized a few bytes by turning 'auto' into a variable. (zoomedia.js)

! Fixed zoom box padding when showing HTML. (zoom.css)

! Fixed potential JS error when cancelling a zoom before the image was actually loaded at all. (zoomedia.js)

PS: I committed my fixed zoomedia.js because it currently works in IE6/7/8, Chrome and Opera (didn't test other browsers.) But it could be better really... I'm super-pissed.
Title: Re: New revs
Post by: Nao on May 25th, 2011, 03:23 PM
rev 783
(4 files, 7kb)

* Rewrote the zoom box resizer to rely more on CSS and less on browser hacks... Only to fail miserably, because IE7 wouldn't cooperate. Oddly, IE6 fares much better here. So, I'm now using hacks only for IE7, including a very ugly one. Hardcoding a width value? Somebody do something! (zoomedia.js, zoom.css, zoom.ie6.css, zoom.ie7.css)

! Forgot a semi-colon to close a function variable. (zoom.css)

PS: if I have to spend ONE extra minute on this fucking resizer code, I'll kill a random cat!! So IE isn't pixel perfect on description paddings here, and I don't fucking care. It's the first time I'm getting it to work on ALL browsers I tested on...
Title: Re: New revs
Post by: Nao on May 25th, 2011, 03:24 PM
I'm committing in three small thematic batches -- if it's any more readable...

rev 784
(2 files, 7kb)

! Made sure that // comments in CSS files are stripped if they're at the beginning of a line, regardless what they're followed by. (Subs-Cache.php)

* Prevented jQuery from being re-minified. Saves processing time and gives better results. (Subs-Cache.php, jquery-1.5.2.js)
Title: Re: New revs
Post by: Nao on May 25th, 2011, 03:27 PM
rev 785
(3 files, 5kb)

+ Added two tentative new hooks in the topic display loop: display_prepare_post and display_post_done. (Display.php)

! Some of the user menu code was prepared even if no menu was to be displayed. (Display.php)

! Some browser still had issues with the sidebar transmorphing code. (index.css)

- I don't see any reasons to add a meta description that's exactly the same as the page title. Waste of bandwidth. (index.template.php)
Title: Re: New revs
Post by: Nao on May 26th, 2011, 11:50 AM
rev 786
(7 files, 11kb)

+ Added support for 'glass' outline type in Zoomedia. It's also enabled by default, at least for now. (Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php, zoom.css)

! Zoomedia didn't comply with the expand duration variable. Also made sure to change its default from 250 to 800ms. Let's enjoy these animations, shan't we? (Aeva-Gallery2.php, Aeva-Subs-Vital.php, zoomedia.js)

! Found the reason for the IE7 bug... 'overflow: hidden' triggers hasLayout and messes up with its width. Setting it to hidden after calculating the width does the trick. (zoomedia.js, zoom.css)

! Zoom out animation wasn't correctly resetting the overflow value either. (zoomedia.js)

- Removed a debug line. (zoomedia.js)

- Removed closeOnClick option (will never be used, seriously.) (zoomedia.js)

NB: the new trick is tested in IE6, IE7, IE8 and Firefox 5. Haven't tried in other browsers... Please do it for me? :angel:

NB²: do you like it if I separate the changelog lines with extra line breaks like on this page...? Is it more readable or just not worth it?
Title: Re: New revs
Post by: Nao on May 26th, 2011, 11:33 PM
rev 787
(1 file, 4kb) (actually just an if() test added...)

! Well, in the end, I STILL get to re-introduce an IE7 hack... Glitch otherwise happens when opening an item without resizing it, and showing a multi-line description. Stupid hasLayout! (zoomedia.js)
Posted: May 26th, 2011, 11:26 PM

rev 788
(1 file, 5kb) (just reverting the previous addition, and moving a line around...)

! I really must insist on removing these hacks, sir... Just hoping I'm not breaking Firefox 3.5.7 beta 2 for Ubuntu 1.03 alpha 7 by doing this. I've seen stranger things you know. (zoomedia.js)
Title: Re: New revs
Post by: Nao on May 27th, 2011, 10:17 PM
rev 789
(61 files, 44kb)

+ Added $context['session_query'] = $context['session_var'] . '=' . $context['session_id'], which should save some valuable CPU time concatenating these strings into URLs... There were over 300 occurrences to modify. (Load.php and all other files in this commit. Should allow for an easy mass-revert in case problems arise.)

(As per our discussion a few weeks ago!)
Title: Re: New revs
Post by: Nao on May 27th, 2011, 11:12 PM
rev 790
(1 file, 6kb)

! Don't animate menus if the mouse cursor exits the menu zone and immediately comes back to it through the same menu entry. (script.js)

* Some code optimization to help minification... Although, funny story, it fares worse in the gzipping stage. Yay. (script.js)
Title: Re: New revs
Post by: Nao on May 29th, 2011, 12:16 AM
rev 791
(12 files +1-1, 18kb)

* Changed windowbg colors a tiny bit to make them a bit more lively. (index.css)

* wrc-based intertitles now use the h6 tag. Hopefully it shouldn't carry too much weight and can be used any way you like. (index.css)

* Reworked the stats page layout. Both windowbg colors are now used. The first area gets its items reordered in a more logical way. Got rid of title2 blocks in favor of h6. (Stats.template.php, index.css, sections.css)

* Renamed $txt['parent_boards'] to $txt['sub_boards'], to reflect what it's actually used for... (I call that a SMF bug.) (BoardIndex.template.php, MessageIndex.template.php, Wireless.template.php, index.language.php)

* Updated some icons to use the same size as the others. (stats_posters.gif, stats_replies.gif)

- Forgot to delete jQuery 1.4 from the SVN. (jquery-1.4.4.js)

! Glass effect in Zoomedia didn't work in Safari. (zoom.css, zoom.webkit.css)

! Fixed validation error (divs in ths). (Stats.template.php)

* Indenazi. (zoomedia.js)
Posted: May 29th, 2011, 12:14 AM

(Note: rev 792 is a dummy/empty one, due to a wrong manipulation.)
Title: Re: New revs
Post by: Nao on May 31st, 2011, 10:57 AM
rev 793
(7 files, 10kb)

! Item upload page would consider empty quota lists as errors, instead of falling back to the overall default quota. (Aeva-Gallery.php)

! Error in the English version -- "add an item to this album" should just be "add an item", since the item uploader allows you to choose your target album... (Media.english.php)

* Readability nazi. (Subs-Media.php)

* Sidebar shouldn't have cat blocks. Using title2 in calendar. (Calendar.template.php)

* h6 intertitles have no reason to be linked to .wrc, since they're never used in other situations. (index.css)

* Zoomedia's glass effect was a tad too strong in some situations. (zoom.css, zoom.webkit.css)
Title: Re: New revs
Post by: Nao on June 1st, 2011, 08:04 PM
rev 794
(8 files, 17kb)

* Overhaul of the credits area. Still needs some work. (Credits.php, Who.language.php, sections.css, Who.template.php)

* Simplified the footer copyright, given that it'll be legal by the end of the week... (index.language.php)

* Reworked stats area to show long strings over the entire line instead of cutting it in half. Try resizing the window to see how it improves on the earlier behavior. (sections.css)

! Fixed a session bug (thanks TE). (Login2.php)

NOTE: this does NOT include the font family changes I made to Wedge...
Title: Re: New revs
Post by: Nao on June 3rd, 2011, 06:23 PM
rev 795
(8 files, 10kb)

* Credits update. Added nice little South Park avatars of the Wedgeward guys, sorted long lists in (an)alphabetic order, removed a consulting developer (who never committed to the actual repository), and moved the remaining one (that's me) to the developer list (since that's what I was, unofficially.) (Credits.php)

* Made sure the copyright list takes the entire width in the credits area. (Who.template.php)

! Poll questions are limited to 255 characters, just like poll options. (Poll.template.php)

- Removed some unused or useless font fallbacks. (media.css, report.css, sections.css, Warm/index.css, Wuthering/index.css)
Title: Re: New revs
Post by: Nao on June 4th, 2011, 06:16 PM
rev 796
(4 files, 7kb)

! Usernames with special characters were incorrectly processed in profile pretty URLs. (QueryString.php)

* Use a dfn tag rather than a custom span to show the help text for password changing. (Profile-Modify.php)

* Don't hide additional membergroups if there aren't enough to justify it. (Profile.template.php)

* Parenazi. (Subs.php)
Title: Re: New revs
Post by: Nao on June 5th, 2011, 11:42 PM
rev 797
(5 files, 30kb) (mainly because of binary changes.)

* The stats area in the board info center was way too crowded. Turned the area into an unordered list. (BoardIndexInfoCenter.template.php)

! The mini Wedge logo didn't have the strike-through line in 'we'. (other/images/minilogo.png, images/minilogo.png)

! The main menu icons for login and logout had disgracious corners. (other/images/sprite-menu-32bit.png, images/icons/sprite.png)
Title: Re: New revs
Post by: Arantor on June 7th, 2011, 05:12 PM
rev 798
(273 files, 304kb) (mainly because near enough every PHP file had to be touched)

This has taken me all day to do. (There were problems accessing the server recently...)

! Sync to SMF 10595
 ! r10547 The cookie shouldn't be reset. (Subs-Auth.php, Subs-Login.php) (In our case, we get to remove a chunk of code that they kept because we don't have to do PHP 4.3.2 specific tests...)

 ! r10548 Search strips so much it may end up with nothing! (Search2.php)

 ! r10549 Minor smiley misalignment fixed. (sections.css) [Bug 4727] (The img.smiley class may live better somewhere else, not sure.)

 ! r10553 "A few trivial fixes as per bug reports topics." (Profile.template.php, PersonalMessage.template.php)

 & r10557 Small clearer text. (Help.english.php)

 ! r10561 Updated [SiNaN]'s name as per SMF credits. (Credits.php)

 ! r10562 A necessary language file was not loaded when using read_tgz_data() function outside Packages area. (Subs-Package.php) [Bug 4732]

 ! r10564 Testing change for the wiki links and redirects. (Admin.php) (Plus I reinstated the change I broke from before.)

 ! r10565 Updates of readme files (readme_*.html) (We may want to keep these for the future, so I updated them with their new content and licence, but I left all the instances of SMF alone for now... I think I got everything.)

 ! r10566 This one didn't have a commit note but it ensures the board ordering for membergroup access is in the right order - it wasn't necessarily the case in either MySQL/InnoDB or PostgreSQL. (ManageMembergroups.php)

 ! r10569 I quote SVN: "Tweaked the install/upgrade/convert readme's for added grooviness." (readme_install.html, readme_update.html, readme_convert.html, readme_upgrade.html) (Not sure anyone even reads these though... the convert one was missed from the other changes, and the upgrade one was missed in this commit)

 ! r10570 Fixing the HTML5 validation link (index.template.php) [Bug 4740]

 ! r10571-2, r10574 Tweak how the URL is preprocessed to ensure it doesn't damage OpenID.

 ! r10573 Members only with manage membergroups permission could create groups that inherit from or based of off protected groups, and members having manage membergroups and moderate forum members could register members protected groups as their primary group. (ManageMembergroups.php, ManageRegistration.php, Subs-Members.php)

 ! r10576 Beginning the version bump saga. (index.php, install.php)

 ! r10580 All those headers changed in Sources/ and index/SSI/payment gateways (many files)

 ! r10582 Upgrader should now check for @version in index.php rather than the old file header (upgrader.php)

 ! r10583, r10585 Language files get version bumped, template files get version bumped, then they decided to add the new header... so two sets of big-ass commits. (Didn't version bump the language files new in Wedge)

 ! r10586 Make sure the right version is examined for 'view file versions' (Subs-Admin.php)

 ! r10588 Themes code should also be detecting the version format correctly too. (Themes.php)

 ! r10589 Templates don't have to be compared between their filename and their contents, we can use the version number listed inside now.

 ! r10591 More header cleanups, including a couple that I managed to miss. (Calendar.php, SplitTopics.php, Subs-Captcha.php, Subs-Graphics.php) (But still no Class-Graphics.php since I killed that.)

 ! r10593 Adding a missing die-if-not-declared test (Subs-MessageIndex.php, Subscriptions-*.php) (And they did some spacinazi changes, but I already fixed those anyway, plus I did it in all three payment gateways, rather than just the one.)

 ! r10595 Version bumps including for tests. (Search.php, Search2.php, SearchAPI-*.php, ssi_examples.php)



@ Not sync'd
 ! r10543 Tweak converter name (vbulletin 3)

 ! r10544 Copyright testing function changes, these had already been removed anyway and in any case functionality changed - they still figure out the version of SMF for SSI, we don't bother. (Oh, and removing $txt['am'] and $txt['pm'] again, probably due to unsync'd local copies)

 ! r10545 Fixing the previous break as well as adding &reg; to the trademark in the manual - which we don't have now.

 ! r10546 Credits updates that we're not keeping (non dev updates)

 ! r10550 Some minor style fixes that weren't relevant to us (mostly Core)

 ! r10551 Removal of the manage-copyright stuff, plus changing the footer - we've already done this to something we're happy with.

 ! r10552 PostgreSQL specific changes

 ! r10554-5 1.1 fixes and version bump, and patch

 ! r10556 Upgrader fixes for renaming old theme, and fixing known themes - but none of the code being changed even exists in our upgrade.sql, leads me to believe it's not relevant to us anyway.

 ! r10558 PostgreSQL specific changes to ManageSmileys.php

 ! r10559 Changing LLC to NPO in installer and upgrader scripts

 ! r10560 Mark Rose is also now credited as a consulting dev. Haven't seen a commit - but to be fair I have seen a fair amount of thoughts from him on improvement. Have not added to SMF cons. dev. yet but no objections to doing so.

 ! r10563 My name is already in our credits fully as opposed to just a pseudonym...

 ! r10567 PostgreSQL connections do allow spaces in usernames and passwords...

 ! r10575 Minor changes to news_readme.html that don't apply (version bump, moving the copyright)

 ! r10577 license.txt contains New BSD licence. Since we're not adopting that to start with...

 ! r10578 Spacinazi that we already did in a few files.

 ! r10579 Minor code cleanup in the converters only.

 ! r10581 Adding a space to their copyright in the installer footer... we already had it looking nice anyway.

 ! r10584 They changed the code I mentioned in r10544, so that SSI doesn't display a copyright at all as opposed to just using a versionless one like we do.

 ! r10587 We don't have to bump a ton of version numbers throughout the system to decache scripts and stylesheets.

 ! r10590 Changing the license.txt file in the theme directories to be BSD... but we never had those files in the first place.

 ! r10592 Tidy up the header in ssi_examples.php, but I already did that.

 ! r10594 Minor cleanup in headers (one file doesn't exist, the other was spacinazi I already fixed)



@ Did not add the new header to Wedge Media files, last time I played in there I broke things, so staying out of that for now.
 
@ Nao, please take a look at the change made in QueryString.php, urldecode not being called on URLs may have consequences for Pretty URLs I'm not currently aware of.

@ r10568 has not been included, and I'm not sure about including it. Basically it's the apparent "uberfix" for jumping edit boxes in IE, with the caveat that IE6/7 ends up with a funny width of some 600 odd px wide edit boxes. I don't think I can replicate it on Wedge so don't want to shove something like this in without good reason...
Title: Re: New revs
Post by: Nao on June 7th, 2011, 11:34 PM
These are some of my things from the last few days... Not committing everything because the Arial redesign isn't complete yet.

rev 799
(22 files, 28kb)

* Don't load media strings anymore when viewing the Who's Online page, and test for generic sub-actions before falling back to the 'unknown' action. Added RSS action to the list. (Subs-Media.php, Who.language.php, Media.language.php)

* Rewrote album listings for a cleaner look. (Subs-Media.php, media.css)

* My credit avatar needed some margin. Otherwise, in some situations it could end up glued next to Pete. We like each other, but not that way! (Credits.php)

* Retooled the footer to only use unordered lists. (index.template.php)

* Moved admin-only "RD" stat line in the footer, to its own list item, allowing to style it individually. (Subs.php)

* Spacinazi. (Class-JSMin.php, Display.php, Load.php, ManageMaintenance.php, Aeva-Sites-Custom-Example.php, module.audio-video.real.php, Subs-Aeva-Sites.php, Subs-Exif.php, MessageIndex.php, Profile-Modify.php)

! SMF bug: it should be class="new_win", not rel="new_win". (Display.template.php)

* Don't bother forcing a font size on buttons if they already have their own custom class, which we can style... (Display.template.php)

- W3C validator doesn't seem to like <link type="contents">, even though it says it doesn't mind. Whatever. (index.template.php)

* Turned $txt['hello_member_ndt'] into a sprintf'ed string, because some languages put the greeting after the name, not before it. (index.template.php, index.language.php)
Title: Re: New revs
Post by: Nao on June 8th, 2011, 11:58 AM
rev 800
(88 files +1-1, 72kb)

* Dull, boring and annoying update of many, many files just to fix/update their description in the header. Typos, British vs American spellings, confusing descriptions and anything needing some normalization was my target.

(index.php, Subscriptions-*.php, Admin.php, Ajax.php, BoardIndex.php, Class-DB.php, Credits.php, Groups.php, Jseditor.php, Jsoption.php, Lock.php, Login2.php, Logout.php, ManageMaintenance.php, ManageNews.php, ManageScheduledTasks.php, MoveTopic.php, PackageGet.php, PersonalMessage.php, Poll.php, PrettyUrls-Filters.php, Profile-Modify.php, Profile-View.php, Profile.php, Search.php, Security.php, Sticky.php, Subs-Auth.php, Subs-Boards.php, Subs-Editor.php, Subs-List.php, Subs-Login.php, Subs-Menu.php, Subs-PrettyUrls.php, Subs-Recent.php, Unread.php, Unreadreplies.php, ViewQuery.php, ViewSMFile.php, Who.php, subscriptions.php, TEMPLATES: Announce, Calendar, Display, Errors, Login, ManageAttachments, ManageMembers, PersonalMessage, Printpage, Recent, Search, Settings, Stats, Themes)

! Wedge didn't indicate the version number in the footer, even though it was supposed to. (index.french.php, index.english.php)

* Renamed XMLHttp action to Ajax, as it's more natural to most users. (index.php, Ajax.php, Load.php, QuoteFast.php, SplitTopics.php, Stats.php, script.js, topic.js)

- Removed CACHE_SUFFIX constant. This was a leftover from rev 290 which I never remembered to delete. (index.php)

- Removed version checking from Search features. This was only for compatibility with SMF2 betas... (SearchAPI-Sphinx.php, Search.php, Search2.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, SearchAPI-Standard.php)

* Modified $forum_version and WEDGE_VERSION to make them work as intended. (index.php, other/install.php, other/smfinfo.php, other/upgrade.php, Calendar.php, Feed.php, ManageServer.php, Aeva-Foxy.php, ManageMedia.php, Subs-Media.php, PackageGet.php, Packages.php, Subs-Package.php, ManageMedia.template.php)

* Missing HTML5 conversions, and typonazi. (other/readme_*.html, other/ssi_examples.shtml)

* Updated/fixed help language files. (Help.english.php, Help.french.php)
Title: Re: New revs
Post by: Nao on June 8th, 2011, 08:09 PM
rev 801
(32 files, 34kb)

! ManageMembergroups sync didn't convert $smcFunc to wesql. (ManageMembergroups.php)

* Reworked admin home page layout. (Admin.template.php, admin.js, admin.css)

* Started using the new header on a few more files. (other/.htaccess, other/Sphinx/*.php,

* Some more SMF to Wedge renaming. (Admin.language.php)

* Typonazi. (Suggest.php, EmailTemplates.english.php, ManageSettings.french.php)

* Spacinazi/indenazi. (media folder's index files, other/upgrade.php, Class-DB.php, ManageBans.php, ManagePermissions.php, ManageServer.php, ManageMedia2.php, Subs-OpenID.php, Subs-Package.php, Themes.php, Who.php, SSI.php, Admin.template.php, EmailTemplates.language.php, index.language.php, sha1.js)
Title: Re: New revs
Post by: Arantor on June 9th, 2011, 03:40 AM
Revision: 802
Author: arantor
Date: 02:39:49, 09 June 2011
Message:
! Several small bug fixes to the hooks code, notably that remove_hook couldn't ever remove a given hook because it actually requires the filename to be passed to it too, so it can be matched, plus the discrepancy of add_hook not explicitly checking for .php entries, plus handling some undefined variables. (Subs.php)

+ Addon Manager now understands a new XML entry in addon-info.xml files, specifically for managing hooks. (Packages.php, Subs-Package.php, Packages.english.php)

@ Documentation forthcoming in the New Revs - Comments thread, along with the one known bug at this time.
----
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Title: Re: New revs
Post by: Nao on June 9th, 2011, 09:11 PM
rev 803
(22 files -1, 24kb)

- Removed support for SMStats (remote logging of server stats at install time). We don't want to bother you with that, and we wouldn't be checking out the stats anyway... (index.php, install.php, upgrade.php, SMStats.php, Install.language.php)

* Renamed fetchSMFiles to fetchRemoteFiles, and other SMF to Wedge changes. (upgrade.php, upgrade.sql, ScheduledTasks.php, ManageScheduledTasks.language.php, ModerationCenter.language.php)

* Added some documentation to color functions in WeCSS. Just in case I forget later... And actually added 'WeCSS' to the header. (Class-CSS.php)

* Removed the hackish linear-gradient fix, as the new generic prefix system replaces it flawlessly. (Subs-Cache.php, zoom.css, zoom.webkit.css)

* That action list was getting long... Replaced it with an array. (Subs-Package.php)

! Add-on manager doesn't need to fully parse the file name for hooks, as remove_hook() does it by itself. (Subs-Package.php)

! $sourcedir wasn't in the globals, and remove_hook() didn't behave the same way as add_hook(). Now it's fixed. Also removed a line in add_hook(). I hate seeing a variable set up when it's not needed, eheh. (Subs.php)

* French translation. (Packages.french.php)

* SMF bug: using $txt['smf_stats_14'] (a leftover from SMF 1.0's era?) when the exact same text was available in the same file, as $txt['most_online']. Fixed that, but also changed the Stats template to use most_online_ever instead of most_online in a place where it made more sense. (Stats.language.php, Stats.template.php)

@ Note: the 'readme' action is not in the add-on manager's action list. That's because it's not repeated in the second area... I figured it's a special case.

(NB: the Note got logged into the changelog as well... I usually make sure this doesn't happen, sorry!)
Title: Re: New revs
Post by: Nao on June 10th, 2011, 05:25 PM
rev 804
(4 files, 7kb)

* Finished implementing the small changes to how the packman deals with hookfile. As is customary with me, this is totally untested. Mwaha. (Packages.php)

! Whoever thought enabling magic quotes through the .htaccess was a bloody idiot. (other/.htaccess)

* Typonazi, parenazi. (ManageSettings.php, Subs-Package.php)
Title: Re: New revs
Post by: Arantor on June 12th, 2011, 01:23 AM
! Sync to SMF 2.0 final. I really can't be arsed to do this commit by commit, so I won't.
 ! Fix of editor width in IE8, basically any time a relative width is applied to the editor, it goes funny. The fix is IE8 specific... and only after applying it did I wonder if it shouldn't just have been added to the IE8 specific markup and be done with it >_< It's there for now, can always change it later. (Themes.template.php, SendTopic.template.php, Profile.template.php, PersonalMessage.template.php, ModerationCenter.template.php, ManageNews.template.php, ManageMembergroups.template.php, ManageBoards.template.php, Display.template.php, Admin.template.php)

 ! Non-broken version of admin compare-versions function. I took the liberty of removing the switch-and-bait that changed 2.0 RC1-1 into 2.0 RC1.1. (admin.js)

 ! Fix of language guidance in permission string. (ManagePermissions.english.php)

 ! Non-broken version compare in package manager. In the end we're going to be ditching this because we should really use the proper PHP function instead. (Subs-Package.php)

 ! Search should also use the non-broken version of version compare. (Search2.php)

 ! Make sure to use the correct URL when just after we've uploaded an avatar and we go back to the profile (as on a custom folder it would be wrong) (Profile-Modify.php)

! Things not included
 ! Removal of comma in Who.template.php because 'name, name, and name' was wrong apparently. Our template's been gutted since then.
 ! Applying $context['theme_variant_url'] in the board index for expand/collapse images as not relevant to us.
 ! PostgreSQL fix to manage membergroups because PostgreSQL returns F for false instead of 0 like MySQL, and the code doesn't like it.



@ Important: While this represents the final change set until 2.0 final, I need to do one last sweep of the files to verify that we got everything we had to get and that anything we didn't, is dealt with appropriately. I'm pretty happy that it's a non-issue, but given what's been said before now, I have to be sure.
Title: Re: New revs
Post by: Nao on June 14th, 2011, 11:01 AM
rev 806 - the "hard drive & PC loss aftermath" commit (i.e. I actually re-used the installer for the first time this year...)
(7 files, 8kb)

! 'Last modified' in topic pages should use the on_* time format. (Display.php)
! Styling generation failed during install because the folder variable wasn't set. (install.php)
! Runtime error due to outdated insert_id call. (db_aeva.php)
! jQuery 1.6 was used in hardcoded areas, instead of the official Wedge version (1.5.2). (upgrade.php, install.php, repair_settings.php)
- Removed last remains of the SMF stats setting in the installer. (install.php)
* Strange '/' thing in the installer can be confusing. Replacing it with the word 'slash'. (Install.language.php)
Title: Re: New revs
Post by: Nao on June 15th, 2011, 10:06 AM
rev 807
(3 files +1-1, 10kb)

* Renamed media/generic_images to media/icons. Makes more sense... (media/icons)
- Cleaned up the Aeva installer, got rid of all compatibility code (SMF 1, non-MySQL, SMG...), in order to make it easier to merge into the main Wedge installer later. (db_aeva.php, install.sql)

@ Note to Thorsten: obviously, the importer will need to re-use code that I just deleted from the Aeva installer. I think you have the file...
Title: Re: New revs
Post by: Nao on June 16th, 2011, 10:07 AM
rev 808
(5 files, 7kb)

+ Added a $boarddomain variable in the installer (it's basically $boardurl without the http:// stuff), and fixed the first board's default pretty URL. (install.php, install.sql)
! Don't use dfn tags inside descriptions... They are for the description itself. (ManageBoards.template.php, Admin.language.php)
Title: Re: New revs
Post by: Nao on June 16th, 2011, 11:42 AM
rev 809
(13 files +1-1, 23kb)

! Forgot to re-order the action list after renaming the Ajax action. (index.php)

* Moved general settings from Aeva installer to regular installer. Also moved wedbPackages init code to where it should be. (db_aeva.php, install.sql)

! The installer said it was going to "install 0.1"... Added Wedge back into it. (install.php)

* Moved version_warning style to the actual CSS file. Also semicolonazi. (install.php, upgrade.php, install.css)

! Temp fix for Wedge crash during media database creation. (Subs.php)

! French translation was... drunk or something. Not my fault! (Install.french.php)

* Renamed ViewSMFile to ViewRemote. (ViewRemote.php, TEMPLATES: Admin, ManageSmileys, ModerationCenter, Packages, Themes)

! reqWin failed in Firefox 4, and opened a popup window instead. Yikes. Only drawback is that this fix doesn't work while installing (the 'success' test). (script.js)

@ Important: once we merge the installers together, we'll have to remove the SMF !== SSI test in Subs.php
@ Even more important: try to figure out why Firefox 4 fails on reqWin when installing.
Title: Re: New revs
Post by: Nao on June 16th, 2011, 11:44 PM
rev 810
(5 files, 7kb)

! Undid the reqWin fix. Better have a popup window than nothing at all. (script.js)

! Fixed the installer's Firefox bug in a different way, by setting window.event at the time the click event is triggered. Seriously, jQuery really should normalize that one... (Install.language.php)

! Forgot to commit the install.css file.

* Saving a couple of bytes. Hopefully. (admin.js)
Title: Re: New revs
Post by: Nao on June 18th, 2011, 07:44 PM
rev 811
(21 files, 20kb)

! Some version numbers weren't correctly updated. (current-version.php, detailed-version.php, Subs-Package.php)

* Renaming 'integrations' and 'integration hooks' to just 'hooks' once and for all. Also removed the last reference to the old 'hook constant'. (Activate.php, Class-Editor.php, Errors.php, Load.php, Login2.php, Profile-Actions.php, Profile-Modify.php, Subs-Login.php, Subs-Members.php, Subs-Post.php)

! Fixed a French string. (ManagePermissions.french.php)

* Minor Packer-aware optimizations. (admin.js)
Title: Re: New revs
Post by: Nao on June 21st, 2011, 07:50 PM
rev 812
(32 files +2-2, 46kb)

- Removed support for rel="index" meta tags, as it's no longer part of the HTML5 standard. Also moved meta tags below all link tags, to ensure any external files are loaded as soon as possible. (index.template.php)

- Trimmed down external latest news. (other/xml/latest-news.php)

* Changed button strips to use a 'class' element rather than an 'active' boolean, avoiding validation errors when trying to add custom CSS classes. (Aeva-Gallery.php, Aeva-ModCP.php, MessageIndex.php, TEMPLATES: index, Display, Media, Memberlist, PersonalMessage, Recent, Reports)

* Some of my uncommitted layout changes are starting to make their way into the code... Without the stylesheets. Meh. Coming soon! (BoardIndexInfoCenter.template.php, Display.template.php)

* I just don't like seeing 5 lines of code that could look cool and fit on a single line... (Subs-Login.php)

* The default feed format is now Atom rather than RSS 1, and support for SMF (custom) and Webslice feeds has been removed because they've never been commonly used anyway. Media feeds remain in RSS 2 format for now. (Feed.php, BoardIndexInfoCenter.template.php, index.template.php, index.language.php)

* Renamed 'RSS' to 'Atom' or 'feeds'. (index.php, db_aeva.php, rss.png, Feed.php, Load.php, Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php, Subs-Media.php, media.css, TEMPLATES: BoardIndex, BoardIndexInfoCenter, index, Media, LANGUAGES: Admin, Help, index, ManageMedia, Post, Stats, Who)

@ Note: I removed the mention about feeds in the Help file, because we're going to move it somewhere else... Let's just not forget to document it when it's done. ;)
Title: Re: New revs
Post by: Nao on June 22nd, 2011, 04:15 PM
rev 813
(13 files +1, 14kb)

* Bumped minimum PHP version from 5.1.2 to 5.2. Also removed a couple of replacements for PHP 5.2+ specific functions. (install.php, readme_*.html, webinstall.php, Load.php, ManageSettings.php, ManageMedia3.php, Subs-Cache.php)

! A language string wasn't properly updated in feeds. (Feed.php)

! IE9 doesn't support text-shadow. All other browsers have supported it for the last 125 years. Get real, IE. (index.ie9.css)

- Leftover from an early AeMe feature. (Aeva-Sites-Custom-Example.php)
Title: Re: New revs
Post by: Nao on June 24th, 2011, 07:43 PM
rev 814
(12 files, 16kb)

* Moved the pretty URL initialization code to the installer, removing the need to do it from the admin area. Also greatly simplified the code internally. (install.php, install.sql, ManageSettings.php, PrettyUrls-Filters.php, Subs-PrettyUrls.php, Subs.php, Admin.template.php, Admin.language.php)

* Saved a few bytes from CDATA parsing in feeds. Well, only in case a ]]> sign is used in posts. Which probably never happens. (Feed.php)

* Just changing text-align to right for the sidebar in Warm. Looks a bit better... Unsure though. (Warm/index.css)

! Fixed mismatched closing tag in Warm definition. (Warm/settings.xml)
Title: Re: New revs
Post by: Nao on June 24th, 2011, 11:37 PM
rev 815
(12 files, 13kb)

* Simplified pretty_filters setting a lot. Removed 'requires' and 'id' (never used), as well as 'priority' (real men use array_splice). The array is unserialized at startup. Specific hacks no longer test for the global pretty URL setting, and instead test for the filter type they're related to. Finally, pretty_enable_filters will only be set if at least one of the filters is enabled. (install.php, Display.php, Load.php, ManageBoards.php, ManageSettings.php, Aeva-Foxy.php, QueryString.php, Subs-PrettyUrls.php, Subs.php, ManageBoards.template.php)

- Leftover. (Admin.french.php)

NOTE: this release is totally, completely untested... I was trying to get confused by my own code changes so I decided to give myself a break :P Obviously if bugs are found, I'll fix them. But normally it should be more 'logical' than the previous incarnation of Pretty URLs.
Also, we definitely need to add a few hook points for PURLs. The determine_location hook is certainly not enough.
Title: Re: New revs
Post by: Nao on June 26th, 2011, 05:55 PM
rev 816
(8 files, 18kb)

! Given that IE9 still doesn't support CSS gradients, rewrote gradient_background() to add proper support for it, and redirect to the rgba version in case of a solid color. (Class-CSS.php, Subs-Cache.php)

* Moved 'column' div to the sidebar block definition (should help with hooking), and reworked sidebar indentation to match this and save a few bytes. (index.template.php, BoardIndexInfoCenter.template.php, Calendar.template.php, GenericMenu.template.php)

- Removed some hardcoded Pretty URL code that wasn't actually needed. Documented a function. (Subs-Boards.php, Subs-PrettyUrls.php)
Title: Re: New revs
Post by: Nao on June 26th, 2011, 08:20 PM
rev 817
(5 files +1, 9kb)

+ Added support for IE 10 in the PHP code, and used it to provide real gradients for it. (Class-CSS.php, Load.php, index.ie10.css)

! Pretty URLs were broken. Again. (ManageSettings.php, Subs.php, Admin.template.php)
Title: Re: New revs
Post by: Nao on June 28th, 2011, 11:58 AM
rev 818
(10 files, 14kb)

* Replaced zoomedia's "rel" hack with actual class names[1]. Still not used for now, but it'll be better in the long run anyway. (Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php) Media.template.php)

* Moved media details to the sidebar in case the browser is Safari Mobile. It can't cope with the width anyway. (Aeva-Gallery.php)

* Moved some media action bools to proper context variables. Added bonus: action bar won't show up at all if you can't do anything. (Aeva-Gallery.php, Media.template.php)

! Search was broken. (Search2.php)

! Hardcoded language string. (zoomedia.js)

* Some layout improvements in media homepage and media item pages. (Media.template.php)

- Removed shortcut keys from media strings, as they're no longer valid. (Media.language.php)

* Improved vertical alignment in error log. (Errors.template.php)

- No need for an id in auto-generated shims. (zoomedia.js)
 1. That's because they don't validate in the new html5 validator...
Title: Re: New revs
Post by: Nao on June 30th, 2011, 09:39 AM
rev 819
(5 files, 7kb)

! The WYSIWYG editor had a reverse color palette. Not exactly sure why... (editor.css)

! Guests could be attributed illogical (and illegal) permissions in the gallery, such as moderating it. (ManagePermissions.php)

* Modified the order of some media permissions to separate moderation-type permissions from regular ones. (ManagePermissions.php)

* Made it clearer that the 'Auto-approve albums' permission allows regular users creating their own albums. (ManagePermissions.language.php)

* Small code logic clarification. (Aeva-Gallery2.php)
Title: Re: New revs
Post by: Arantor on July 1st, 2011, 12:27 PM
Revision: 820
Author: arantor
Date: 11:22:11, 01 July 2011
Message:
! The IP address displayed in the reminder emails was not properly formatted.
----
Modified : /trunk/Sources/Reminder.php

Posted: July 1st, 2011, 12:22 PM

Revision: 821
Author: arantor
Date: 11:27:21, 01 July 2011
Message:
! Add the ability to specify a separate email address for 'from' in emails. I don't think I explained it that well, but basically this means you can trivially set a different outgoing address, preventing people who are too dumb to read properly from sending you emails when they should be using the forum instead.
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Title: Re: New revs
Post by: Nao on July 2nd, 2011, 01:00 AM
rev 822
(24 files, 26kb)

* Rewrote the 'More smileys' feature to show new smileys below the default smiley list, instead of opening an ugly popup. Also simplifies the JS code a lot. (Class-Editor.php, Post.language.php, post.js)

* Moved the 'Customize Smileys' option to the top of the smiley admin page, mostly to make it stand out, and clarified what it's for in the language strings. (ManageSmileys.php, ManageSmileys.language.php)

! The Re: prefix was broken in the French version. Somehow, somewhere, the nbsp entity is now converted to an ASCII character, so it wouldn't recognize prefixes in existing posts. Rather than fix the bug, I decided to simply use a breakable space. Older posts might need to be converted... (index.french.php)

+ Adding [Unknown] to the Consultant list in the credits area. (Credits.php)

* Updated header comments for all gallery-related files to match the new PHPDoc style and add credits to Dragooon where credit is due. (Sources/media/*.php, Media.template.php, ManageMedia.template.php, mediadmin.js, up.js)

- Media popups really didn't need the extra classes. I'd say. (Aeva-Gallery.php, Media.template.php)

@ Note: other JS files probably need their headers to be updated as well...
Title: Re: New revs
Post by: Nao on July 2nd, 2011, 01:12 PM
rev 823
(6 files, 13kb)

! The mail sending code uses $modSettings['mail_from'] while our admin code was $modSettings['from_email']. (ManageServer.php)

! Fixed Packer to allow for structures such as "for (var something in { object: true })", and added a comment with a link to my bug report and original fix. (Class-Packer.php)

* Rewrote the help text for mail_from. It may have been a bit unclear. At least to me. (Help.english.php)

* Translated new strings to French. (Admin.french.php, Help.french.php)

- Stray comment. (Subs-Post.php)
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 12:56 AM
Revision: 824
Author: arantor
Date: 23:56:29, 02 July 2011
Message:
! Remove 'Reports Generation' from Core Features. I mean, it was enabled already and all the Core Feature option does is show/hide the area, it's not like it actually prevents any ongoing performance problems, so there really wasn't much point actually making it optional in the first place. (install.sql, Admin.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 01:44 AM
Revision: 825
Author: arantor
Date: 00:44:09, 03 July 2011
Message:
! Moved the news and version info into the sidebar (and if the menu is in sidebar, it'll be under the menu though that's not going to be an issue for long), plus fixed the styling and language strings to match (Admin.php, Admin.template.php, Admin.english.php, admin.css, index.rtl.css)
! Removed the AdminSearchOM function. Not only do we not use it (because we don't have an online manual to search), the chances are if and when we do, we won't use the same method they had anyway, meaning that we don't really want it around. (Admin.php, Admin.template.php, Admin.english.php, Admin.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/styles/admin.css
Modified : /trunk/Themes/default/styles/index.rtl.css
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 02:16 AM
Revision: 826
Author: arantor
Date: 01:14:40, 03 July 2011
Message:
! The sidebar has more dependencies than I thought it did, need to make sure the list of admins is obtained and that the JavaScript is included where necessary. (Admin.php, Admin.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/Admin.template.php

Posted: July 3rd, 2011, 02:14 AM

Revision: 827
Author: arantor
Date: 01:16:14, 03 July 2011
Message:
! And oops, a missing global variable or two... (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Title: Re: New revs
Post by: Arantor on July 3rd, 2011, 02:31 AM
Revision: 828
Author: arantor
Date: 01:30:53, 03 July 2011
Message:
! Fixed some more oddities with the subtemplate not being called right. Also, split up AdminHome into two functions - there is no need for the admin front page to actually do everything needed for the credits as well, and vice versa. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Title: Re: New revs
Post by: Nao on July 3rd, 2011, 10:59 AM
rev 829
(10 files, 15kb)

* Every time I see a we:title where a we:cat should be, I really feel the need to change it. More to go, whatever. (Profile.template.php)

* Converted some of the media template into proper Wedge-like templates. Tables are good. But not systematically, eh. (Media.template.php)

- Removed windowbg/windowbg2 mentions from description areas, because description already sets its own background color... It's a big boy now. (Profile.template.php, PersonalMessage.template.php, Help.template.php, GenericMenu.template.php, ViewQuery.php, upgrade.php)

* Added more space in the Delete Account area. If you're going to delete your own account, you may want to get some gasping time. (Profile.template.php)

* Pointless optimizations. (suggest.js, editor.js, Aeva-Foxy.php)

@ It's a pointless commit overall but if you're gonna commit in smaller chunks, so shall I :P
Title: Re: New revs
Post by: Nao on July 3rd, 2011, 08:48 PM
rev 830
(2 files, 8kb)

* The permissions page's Simple mode shows empty headers for no reason whatsoever. Also reworked indentation. (ManagePermissions.template.php)

* Globals on two lines, uh? (Profile-Modify.php)
Posted: July 3rd, 2011, 11:54 AM

rev 831
(1 file, 5kb)

! An annoying bug in Packer makes some servers crash on long strings. Well, on my local server it does, but not on my remote one. I used a quick workaround. Hopefully I can fix the problem at the source in the future... (suggest.js)
Title: Re: New revs
Post by: Nao on July 3rd, 2011, 10:59 PM
rev 832
(4 files, 8kb)

! Is it me, or did the SMF team actually forget to fill the MySQL version number in the admin area...? (Admin.php)

! A forgotten semicolon would crash the admin homepage if Packer was enabled. (admin.js)

* Some improvements to the admin sidebar layout. (admin.css)

* Commenazi. (Admin.template.php)
Title: Re: New revs
Post by: Nao on July 4th, 2011, 12:20 AM
rev 833
(11 files, 29kb)

! Using the same format as SMF for version numbers. (detailed-version.php)

* Devised a method to provide day and month names in the user's current language when showing the latest news. (Somehow, I think it's a bit overkill for such a small detail....) (latest-news.php, Admin.php, admin.js)

* Admin homepage needed some extra space. (Admin.template.php)

* wedgeAnnouncements instead of smfAnnouncements. (ModerationCenter.template.php, latest-news.php, admin.js)

* Translation. (Admin.french.php)

- I'm sure there's a good reason to have $txt['months_titles'] that are exactly the same as $txt['months'], and to only use them in the calendar, but OTOH just using $txt['months'] in the calendar will teach it a lesson. Bad calendar! (Calendar.template.php, index.language.php)

- Removing some temp SMF code. (ViewRemote.php)
Posted: July 4th, 2011, 12:15 AM

rev 834
(1 file +1, 7kb)

+ Forgot to add new file admin.rtl.css, which at it says, is the RTL version of admin.css. We really should move as much code as possible from index.rtl.css to whatever.rtl.css, especially in the admin/moderation area. Oh, and that index.rtl file really needs to be overhauled. From top to bottom... (admin.rtl.css, index.rtl.css)
Title: Re: New revs
Post by: Arantor on July 4th, 2011, 03:31 PM
Revision: 835
Author: arantor
Date: 14:28:16, 04 July 2011
Message:
! The revised admin panel (lots of files, including new ones and getting rid of old ones)

The main thing that's different is the front page, and there's still some compatibility code in there from earlier drafts, this isn't finished at all - more icons are needed, as well as completing the move of some features. In the end, Core Features should ultimately be removed from the system, as the first step.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/admin/attach.png
Added : /trunk/Themes/default/images/admin/autoembed.png
Added : /trunk/Themes/default/images/admin/autoembed_off.png
Added : /trunk/Themes/default/images/admin/autoembed_on.png
Added : /trunk/Themes/default/images/admin/banlist.png
Added : /trunk/Themes/default/images/admin/calendar.png
Added : /trunk/Themes/default/images/admin/calendar_off.png
Added : /trunk/Themes/default/images/admin/calendar_on.png
Deleted : /trunk/Themes/default/images/admin/feature_cd.png
Deleted : /trunk/Themes/default/images/admin/feature_ps.png
Deleted : /trunk/Themes/default/images/admin/feature_rg.png
Added : /trunk/Themes/default/images/admin/languages.png
Added : /trunk/Themes/default/images/admin/logs.png
Added : /trunk/Themes/default/images/admin/mail_settings.png
Added : /trunk/Themes/default/images/admin/maintenance.png
Added : /trunk/Themes/default/images/admin/membergroups.png
Modified : /trunk/Themes/default/images/admin/members.png
Added : /trunk/Themes/default/images/admin/paid_subs.png
Added : /trunk/Themes/default/images/admin/paid_subs_off.png
Added : /trunk/Themes/default/images/admin/paid_subs_on.png
Modified : /trunk/Themes/default/images/admin/permissions.png
Added : /trunk/Themes/default/images/admin/registration.png
Added : /trunk/Themes/default/images/admin/reports.png
Added : /trunk/Themes/default/images/admin/scheduled_tasks.png
Added : /trunk/Themes/default/images/admin/search.png
Modified : /trunk/Themes/default/images/admin/support_and_credits.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/styles/admin.css
Title: Re: New revs
Post by: Nao on July 5th, 2011, 10:25 AM
rev 836
(5 files, 7kb)

* French translation updates and fixes. Sorry, couldn't bring myself to delete the admin intro, only commented it out. Also deleted the support_resources string since it's no longer showing anything (for now at least.) (Admin.template.php, Admin.language.php, ManageSettings.french.php, PersonalMessage.french.php)

- Removed support resources text, since it was no longer in the language files... (Admin.template.php, Admin.language.php)
Title: Re: New revs
Post by: Nao on July 6th, 2011, 12:16 AM
rev 837
(5 files, 7kb)

! Classic Permission headers looked odd. (ManagePermissions.template.php)

! Fixed bug in determineVersions(). (admin.js)

* Two lines become one. Very moving. (Subs-Admin.php)

* Current Wedge version is 0.1, not 1.0 Alpha. (Security.language.php)

(As always, most of my day's work isn't ready for a commit, being linked to changes in index.css and sections.css...)
Title: Re: New revs
Post by: Arantor on July 6th, 2011, 12:01 PM
Yay, a changelog that's probably bigger than its changes. But still, things that bugged me.


Revision: 838
Author: arantor
Date: 11:01:04, 06 July 2011
Message:
! The support block in the admin sidebar shouldn't be linked to anything now, especially not a page that doesn't exist any more. (Admin.template.php)
! Minor layout fix to the items in the admin area, it was bugging me how everything was misaligned. (Yes, the placeholder icons are *still* misaligned, but they're not my main problem!) (admin.css)
! The feed block in the sidebar should have more spacing than it did. (index.css)
----
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/styles/admin.css
Modified : /trunk/Themes/default/styles/index.css
Title: Re: New revs
Post by: Arantor on July 6th, 2011, 02:57 PM
Another relatively minor set of changes, but I'd rather keep changes like this encapsulated in case we revert them later.

Revision: 839
Author: arantor
Date: 13:57:37, 06 July 2011
Message:
! If the mail queue is disabled, don't provide the mail queue page. (ManageMail.php, Admin.php)
! Minor tweaks to the server settings page - widen the from-email box, and give a ? description to the webmaster email option. (ManageServer.php, Help.english.php)
! "Allow users to turn off word censoring" shouldn't be a theme setting, it makes no sense for it to be, so I relocated it to the Censored Words area. (Admin.english.php, Admin.french.php, Themes.english.php, Themes.french.php, Profile.template.php, Settings.template.php, Admin.template.php, Subs-BBC.php, ManagePosts.php, install.sql)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on July 7th, 2011, 12:46 AM
AAAAND... The big commit! Comment away! Compare with the demo site!

rev 840
(6 files, 22kb) (Wait, what... ONLY 22kb?!?! REFUND!!!)

* Changed menu animation to show it coming from below, rather than from above. (index.css, script.js)

* Many, MANY styling changes... Documenting them in order of appearance in the index file. Also please read the notes for suggestions. (index.css)

  * Main font was changed from Verdana to Arial.

  * Left and right borders are now black with a subtle gradient at the top. Main content padding was adjusted accordingly. (Also index.ie6.css)

  ! Fixed margin on first title header in sidebar.

  ! Fixed link color in sidebar for 'Unread posts' etc.

  ! Sidebar could be shown below other elements in some situations.

  ! Fixed details in the top section. (Also index.ie6.css, index.ie7.css)

  + Renamed $big_font to $head_font (font for bigger text like headers), and added $menu_font (menu font), for more flexibility.

  * $head_font is set to PT Sans by default.

  - No longer showing the Wedge logo in the upper header. The Wedge triangle in the footer is enough in my opinion.

  - Removed orange lines in the header and footer (leaving them in .cat), and replaced them with grayish lines that are the exactly median color between the wine shades and white.

  * Linktree color set to gray when not clickable, e.g. "Moderator" mention.

  * Changed footer link colors and layout.

  * An easter egg comment was actually wrong. Just rewatched this and fixed the quote. I think it's worth mentioning that I'm serious even about the stupid stuff.

  * A slightly more readable legend for fieldsets in the admin homepage. Note: IE6 screws up the background in all situations. Ah well.

  - Removed border from .wrc class, e.g. topic posts. Actually I just commented it out... Just in case.

  * Reset text color in windowbg to #444 instead of pure black. It doesn't hurt readability, and with ClearType it really renders more smoothly.

  * Changed windowbg color to light gray. Note: original was #f9f6f0. It MIGHT be better than the new one... Needs some testing.

  * Input buttons now get a forced height, to compensate (a bit) for cross-browser inconsistency.

  + Added a subtle gradient to input buttons.

  * Changed selected top menu items to be in the same rounded box than hover effects, instead of looking like they're connected to the bottom. This is due to inconsistencies in IE and Safari Mobile. And frankly it got old quickly anyway. Should be either made stronger, or removed entirely. Which I did.

  * Forcing a height on menu items, because, once again, of browser inconsistency...

  * Submenu are now vertically aligned with the top menu's gray bottom border. It's a detail but it's important.

  * Changed selected top menu item background from orange to dark greenish. Subtle is the new black.

  - No longer forcing smalltext classes to use the default font family.

  * Changed background color for quotes, and chose alternating colors to match their parent windowbg.

  * Moved post font definition to sections.css.

  - Couldn't find a reason for overflow:auto to be applied to dd tags at this point.

  * dfn tags now styled with default font.

  ! Renamed #rss to #feed. (Note: this is why it failed for you, Pete. I had yet to commit that.)

  * Category headers now use Arial on links. (In case you have PT Sans installed. Which is unlikely. Oh well.)

  * Extra padding for icons in category headers. I'm sure it'll fail in some browsers though... Been there done that.

  * More changes on text styling in headers.

  * Very subtle changes on mini-header styling (h6 tag) and button lists.

* Now going for the many changes in section.css, which is basically index.css for specific areas of Wedge. (sections.css)

  * Board names in board index now use $head_font.

  * Added proper padding around stats in the homepage sidebar. (Also index.ie6.css)

  * Moderator links now use the default font.

  * Restyled previous/next topic links. Still not happy though...

  * Restyled #top_subject. This totally breaks the usual $head_font setting though...

  * Ensure that topic titles (as reproduced in individual posts) get properly broken with a text ellipsis if the browser supports it.

  * Now using display: table on the title/date/actions header in individual posts. This is totally gonna break some browsers... (Also index.ie6.css, index.ie7.css, index.ie8.css)

  * Also using $head_font on user names now, in both posts and profiles.

  * Forcing Verdana on user menu items. Again, it breaks the self-imposed standard, but I've gotten used to that one... Uh. Can be changed, after all.

  * Moved Split Topic and Merge Posts buttons to the right of the action list. They should have been together from the beginning, even though they're not directly related. Also fixed horizontal icon alignments.

  * Setting a maximum height and overflow on the smiley box, as promised.
Title: Re: New revs
Post by: Arantor on July 7th, 2011, 01:21 AM
Revision: 841
Author: arantor
Date: 00:21:11, 07 July 2011
Message:
! Remove the option for 'enabling mark as read'. Not only does it really not need to be optional, it really really didn't need to be a theme option. (install.sql, upgrade.php, Display.php, MessageIndex.php, BoardIndex.template.php, Recent.template.php, Settings.template.php, Themes.english.php, Themes.french.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on July 7th, 2011, 02:03 PM
rev 842
(5 files, 7kb) -- and with this, ALL of my files are committed. Except for Subs.php though -- JSE rewrite is on hold.

! Variable name typo in installer. (install.sql)

+ Added a first-post class to the first post in a topic. (Display.template.php)

! Silly me... Forgot to commit the other changes to the Display page. (Display.template.php)

* French translation and minor English rewording. (Help.language.php)

- Removed some no-longer-used classes from the media area. (media.css)
Title: Re: New revs
Post by: Nao on July 7th, 2011, 07:45 PM
rev 843 - aka the "I didn't plan to work on that AT ALL today..." commit.
(13 files, 21kb)

* Rewrote quote, code and php BBCode to use HTML5 header and footer tags, harmonize their markup altogether and provide the ability to style the entire quote/code/php area, e.g. get the same width in headers and footers as in quote boxes. The code parser in install.sql is a bit hackish, but the original wasn't very clean to begin with. Oh, and it's untested in Warm and Wuthering. (install.sql, ssi_examples.php, bbc_test.php or whatever, Printpage.template.php, index.css, index.ie6.css, report.css, sections.css, Warm/index.css, Wuthering/index.css)

* Cleaner way of alternating quote colors. It doesn't work in IE6, but *who* exactly cares about alternating quotes in IE6? Get a life! (Subs-BBC.php, index.css)

* 'Last Modified' field is now shown in a much less obvious font color, by popular request (that is, one person. And me. Don't deny it, I'm popular. Chicks dig me.) (sections.css)

! 'on' was repeated twice in quote tags, because of the use of on_timeformat(). (install.sql)

! The French translation for 'Quote' in the quote boxes was 'Citer'... The actual verb. Reminds me of the $txt['reply'] bug report I made years ago, ahh... Good times. Well, time to fix that, innit? (install.sql, index.language.php)
Title: Re: New revs
Post by: Arantor on July 8th, 2011, 04:29 PM
Revision: 844
Author: arantor
Date: 15:28:23, 08 July 2011
Message:
! Remove RDF type feeds too. (Feed.php)
----
Modified : /trunk/Sources/Feed.php
Title: Re: New revs
Post by: Nao on July 9th, 2011, 01:14 AM
rev 845
(5 files, 7kb)

* Rewrote quote tag styles to something more... Err... Classy. (index.css)

+ Added missing files to the version list. (other/xml/detailed-version.php)

! Added a safety against endless loop if CSS variables are referencing each other. (Class-CSS.php)

! Media area was still using the deprecated loadClassFile() at one point. (Subs-Media.php)

! Cancel-type buttons now sport a gradient, just like other buttons. (index.css)

! Menu background was not actually using $menu_bg variable... Oopps. Still need to get back to using $main_bg, $head_bg, $footer_bg, $board_col and $sidebar-width, which were used in Warm but not in Wine. (index.css)

* Changed windowbg color to use the same background color as the sidebar. Looks pretty good. Maybe not definitive, though. (index.css)

@ Note: quote tag css isn't definitive, but it's 95% of what I was looking for (at least in my current state of mind.) Please tell me whether you like it or not!
Posted: July 9th, 2011, 12:55 AM

Important!

Forgot to mention this in the SVN changelog. So I'm adding it here:

- Removed 'Last post' mention from Recent posts. (Recent.template.php)

Years and years and years after this was implemented, SMF still has it. But what it's showing is the date of the post listed right below the date. it is NOT always the LAST message in the topic. So it really doesn't mean a THING! :^^;:
Title: Re: New revs
Post by: Nao on July 9th, 2011, 04:36 PM
rev 846
(3 files, 8kb)

- From last rev (forgot to document it): Removed 'Last post' mention from Recent posts. (Recent.template.php)

* Renamed custom CSS "gradient-background:" to just "gradient:", as it's unlikely to be mixed up with Safari's old "gradient()" function. And honestly, I was lost myself as to what the exact name of the rule was. (Class-CSS.php, index.css, media.css)

* If showing a top-down gradient through the gradient rule, don't bother printing 'top', as it's not required. (Class-CSS.php)

* Some slight changes to the quote box styling. Trying Lucida Sans as quote headers. (Class-CSS.php)

@ Note: I'm working on removing the SMF type of feed data. Also, looking into a workaround for the <author> tag in the RSS specification... Didn't even know they made it mandatory to use an e-mail address in these. A godsend for spammers ;)
Title: Re: New revs
Post by: Nao on July 10th, 2011, 08:22 PM
rev 847
(3 files, ??kb)

+ Added a $modSettings['feed_root'] variable, automatically set to $scripturl on the first use of a feed, which should serve as a 'permanent' root for Atom feed IDs even after a domain move. (Feed.php)

! Pretty URLs weren't used at all in feeds. Although <guid> would best be left alone, the old PURLs mod from SMF converted them, so for now we'll convert them as well... (Feed.php)

! Indenazi in the original dumpTags call and a comment. (Feed.php, Subs-Boards.php)

- Removed some extra code for the deprecated SMF feed type. A few lines left to delete. (Feed.php)

! Although this warrants further research regarding the usefulness of parsing an entity-encoded item, I cdata-parsed a few things that needed some harmonizing there. (Board names, author names, etc.) (Feed.php)

* Trebuchet MS is an acceptable fallback for quote box headers. (index.css)



rev 848
(1 file, 6kb)

! Fixed the category bug in feeds. Also made schemes non-required (and prettified if present), because it's hardly semantic in our case. (Feed.php)

* Don't bother cdata-parsing a string if it has no objectionable content. (Feed.php)

! category labels shouldn't be cdata-parsed, and instead protected against double quotes. (Feed.php)
Title: Re: New revs
Post by: Nao on July 11th, 2011, 12:15 AM
rev 849
(1 file, 6kb)

* Atom's id field now uses a UUID for id entries, calculated from the original URL of the item. It's actually a single md5 call so it's really a UUID, but FWIW feed readers won't notice the trick. (Feed.php)

- Deleted a few unused variables from the feed code: num_replies, id_first_member, first_subject, first_poster_name. (Feed.php)

- Removed even more SMF feed code. Put inside parenthesis the rest of the code to be removed. (Feed.php)

@ Pete, feel free to remove the remainder of the commented out code. The only reason I didn't finish this is because I'm falling asleep right now. I don't believe there's anything we need to keep -- or, on the contrary, we could concatenate all of the extra profile info into the description field in Atom and RSS feeds. Whatever you like best...
Title: Re: New revs
Post by: Arantor on July 11th, 2011, 12:58 PM
Revision: 850
Author: arantor
Date: 11:58:15, 11 July 2011
Message:
! Move the IM fields into custom field templates. While there are slight changes to formatting, it *should* work out OK; I tested using the newer links and still got the information I should have had... (ManageSettings.php, ManageSettings.english.php, Admin.template.php, facebook.png, steam.png, twitter.png)

@todo: Add a couple more fields (PSN, XBox Live), remove the existing fields.
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/facebook.png
Added : /trunk/Themes/default/images/steam.png
Added : /trunk/Themes/default/images/twitter.png
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on July 12th, 2011, 09:56 AM
Revision: 851
Author: arantor
Date: 08:56:12, 12 July 2011
Message:
! Add a time gate to registration. First visit to the registration screen should force a limit of 10 seconds on filling the main form out, if you have any errors, that limit should be reduced to 5 seconds on returning the form. There is, presently, no limit on accepting the registration agreement (should there be one?) (Register.php, Errors.english.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Title: Re: New revs
Post by: Nao on July 12th, 2011, 11:29 AM
rev 852
(3 files, ??kb)

- Right now, I don't believe custom CSS browser prefixes are disabled once the proper rule is implemented[1], so why not save a few bytes off the final files and prevent browsers from giving CSS errors? (Subs-Cache.php)

! Slightly incorrect way of handling $data in getXmlProfile(). (Feed.php)

! Code tags would get incorrect header styling when used within quote tags. Reordered styles to avoid that. (index.css)

* Changed code tag background to adapt itself to any windowbg colors, while retaining the blueish color. (index.css)

* Changed h6 tag (used notably as mini-headers in the credits page) to use the Corbel font on Windows 7 systems. Also increased letter spacing to, hmm... Give peace a chance. Probably gonna change my mind later. Seriously though, Corbel and Calibri are nice fonts, and they have a larger install base than PT Sans, so I should do something with them. (index.css)
 1. I actually spent some time trying to find details about that but found nothing online about it, so I guess they keep compatibility options on.
Title: Re: New revs
Post by: Arantor on July 12th, 2011, 11:35 AM
Revision: 853
Author: arantor
Date: 10:34:48, 12 July 2011
Message:
! All instances of setcookie should now be indicating to use httponly. (Since we're using PHP 5.2, there's not even the effort required to make a compatibility function.) (smf_api.php, Poll.php, Security.php, Subs-Auth.php, SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/other/tools/smf_api.php
Title: Re: New revs
Post by: Nao on July 12th, 2011, 02:33 PM
rev 854
(8 files, 13kb)

! Regexp error in the Facebook custom field array. (ManageSettings.php)

! Admin settings use windowbg2 as the default background. (Admin.template.php)

* Validation & indentation nazi. (Admin.template.php)

* Made it a bit clearer (uh, in my fashion...) that the registration error is due to you being a spambot. And also something that bothered me with the Facebook string (again.) (Errors.english.php, ManageSettings.english.php)

* French translation. (Errors.french.php, ManageSettings.french.php)

* Something I'm not sure about, waiting for feedback... Help popups will automatically attempt to retrieve the string they're about, and will reproduce it at the top of the popup. (script.js)

- Removing border color on fieldset legends with windowbg. Maybe it was a tad too much... Adding a border to help popups though. (index.css)

- Back to square one for the h6 tag. Worked well in the credits page, but not anywhere else. (index.css)
Title: Re: New revs
Post by: Nao on July 12th, 2011, 06:58 PM
rev 855
(4 files, 8kb)

* Moved the admin search box outside of the header, and re-introduced an admin welcome message next to it, this time focusing exclusively on navigational help, or whatever. (Admin.template.php, Admin.language.php, admin.css)

(Just a small feature, I'm adding it separately in case you want to revert it, Pete. Although I'm positive it makes the homepage look less busy.)
Title: Re: New revs
Post by: Arantor on July 12th, 2011, 11:59 PM
Revision: 856
Author: arantor
Date: 22:53:38, 12 July 2011
Message:
! Removed the ICQ/AIM/Y!IM/MSN fields from the core; they're now only available as custom profile fields. Really no big loss.

Did also rearrange the last of the strings and tied one up. Hopefully I got the French version right too.

Note that I've left the icons in because they're still usable for now but I'm going to clean them up too shortly. (install.php, install.sql, smf_api.php, Feed.php, Load.php, ManageMembers.php, ManageSettings.php, Memberlist.php, Profile-Modify.php, Register.php, Subs-Members.php, Display.template.php, Admin.english.php, Admin.french.php, Help.english.php, Help.french.php, index.english.php, index.french.php, ManageSettings.english.php, ManageSettings.french.php, Profile.english.php, Profile.french.php, ManageMembers.template.php, Memberlist.template.php, PersonalMessage.template.php, Profile.template.php, Who.template.php)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/smf_api.php
Title: Re: New revs
Post by: Arantor on July 13th, 2011, 02:13 AM
Revision: 857
Author: arantor
Date: 01:13:03, 13 July 2011
Message:
! Remove custom fields from being in core features, and have it just behave naturally as part of the system. Interestingly there is absolutely no performance change involved. (install.sql, Admin.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php, feature_cp.png)

! Random legacy $smcFunc call we missed (Search2.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Themes/default/images/admin/feature_cp.png
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on July 13th, 2011, 09:33 AM
Revision: 858
Author: arantor
Date: 08:32:41, 13 July 2011
Message:
! Move all the field icons into their own little folder. (ManageSettings.php, fields/*)
----
Modified : /trunk/Sources/ManageSettings.php
Deleted : /trunk/Themes/default/images/aim.gif
Deleted : /trunk/Themes/default/images/facebook.png
Added : /trunk/Themes/default/images/fields
Added : /trunk/Themes/default/images/fields/aim.gif
Added : /trunk/Themes/default/images/fields/facebook.png
Added : /trunk/Themes/default/images/fields/msntalk.gif
Added : /trunk/Themes/default/images/fields/steam.png
Added : /trunk/Themes/default/images/fields/twitter.png
Deleted : /trunk/Themes/default/images/msntalk.gif
Deleted : /trunk/Themes/default/images/steam.png
Deleted : /trunk/Themes/default/images/twitter.png
Title: Re: New revs
Post by: Nao on July 13th, 2011, 12:01 PM
rev 859
(19 files +4-4, 42kb)

* Renamed Stylings to Skins. Renamed Styles folders to Skins. Renamed settings.xml to skin.xml. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, TEMPLATES: index, ManageBoards, Themes, LANGUAGES: ManageBoards, Themes, SKINS: index.css)

* Moved moderatorbar inside the post area, to facilitate its styling. Err... Yes, what? I'm currently working on it. (Display.template.php)

! Who crapped into our source code? Fixed a weird bug in the version retrieval code. (Themes.php)

@ To svn readers: rename 'styling' to 'skin' in the member and board tables, go to the admin area > Themes and Layout > Manage and Install, and hit Save.
Title: Re: New revs
Post by: Arantor on July 13th, 2011, 01:38 PM
Revision: 860
Author: arantor
Date: 12:38:19, 13 July 2011
Message:
! More admin panel reorganisation: Maintenance is now Server & Maintenance, and Server Settings and Mail live in there (reducing their prominence as they're less commonly used settings), auto embedding is now under Forum, and Media's Maintenance is now also under the Server & Maint. area. Also, auto embedding is no longer in Core Features, but controlled by its own page (in line with the other stuff), which means pretty much going back to AeMe's own code in that respect. (Admin.php, Admin.template.php, Admin.english.php, ManageMedia.english.php, ManageSettings.english.php, ManageSettings.french.php, feature_e.png)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/media/ManageMedia3.php
Modified : /trunk/Themes/default/Admin.template.php
Deleted : /trunk/Themes/default/images/admin/feature_e.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on July 13th, 2011, 06:14 PM
rev 861
(8 files, 20kb)

+ Added separators to submenu items, slightly reordered a few entries, and fixed a logic issue in the menu cleanup code. (Admin.php, Subs-Menu.php, GenericMenu.template.php)

! Information box was too small. (ManagePaid.php)

* Added rounded corners to the admin homepage fieldsets, but it doesn't work well in Opera... Ah well, if it's an Opera bug, I'm not gonna prevent other browsers from showing these. (Admin.template.php)

* Refined Pretty URLs admin area. Made it clearer what the cache option is for (until now, it wasn't even obvious that disabling it would still keep PURLs enabled.) (Admin.template.php, Admin.language.php, admin.css)

* French translation fixes in the admin area. It had a tendency to use words like 'Réglages' a bit too much where 'Paramètres' made more sense. Also, the 'Forum' menu area is called 'layout' internally, so the French translation had 'Apparence'. Since Pete moved the Theme options to another menu area, it was time to reflect the change in the French version as well... (Admin.french.php)
Title: Re: New revs
Post by: Nao on July 13th, 2011, 07:20 PM
rev 862
(6 files, 9kb)

* Minor details and fixes for the separator code. (Admin.php, GenericMenu.template.php)

- Why are we adding a class for something that's not even useful? (Admin.template.php, admin.css)

! Just because I spent months on that silly translation already, doesn't mean I don't have to keep improving it. (Help.french.php, Profile.french.php)
Title: Re: New revs
Post by: Nao on July 14th, 2011, 12:57 AM
rev 863
(5 files, 11kb)

* Rewrote uuid code in Atom feeds to instead use a tag URI (RFC 4151), in the form "tag:domain.com,2011-07-01:msg-7". It may not be the definitive code, but it's better than a UUID. Also removed the last compatibility code block. Really no need for that... (Feed.php, QueryString.php)

! Typo. (Help.french.php)

* In a world where war rages on every day, I believe it's important to say 'Hello' rather than 'Hi'. Who is Wedge to say you want to say Hi when you may not even know who you're talking to? (ManageSettings.language.php)


@ Note: totally unrelated... It appears that not many people tested the automatic quote splitter :P It fails badly when pressing Enter after a self-closed tag such as more, media etc. Also fails horribly when splitting URL tags. Okay, is anyone ever testing my crappy code? :P
Title: Re: New revs
Post by: Nao on July 14th, 2011, 06:40 PM
rev 864 (another big one!)
(36 files, 37kb)

* Rewrote the post layout for topic views. Ohhhh yeah. Now using display: table and sporting more freedom. Will fix IE6 and IE7 later. If they're nice enough. Also, section.css could probably use some cleaning up. (Display.template.php, sections.css)

* Rewrote JavaScriptEscape() to avoid escaping tabs and newlines. Also gave up on escaping tag closers, as I couldn't find any single reason for doing so. And using shorter hacks for script, href and scripturl situations. (Subs.php)

* Renamed global smf_* Js variables to we_*, and smf_scripturl to we_script, as it's used more often, so might as well have it shorter. (various other/* files, editor.js, mediadmin.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js, Admin.php, TEMPLATES: index, ManageMembergroups, Packages, Post, SplitTopics, Themes)

* Moved registration center next to the member list in the admin menu, as semantically it's closer to that, than to the permission/ban stuff. (Admin.php)

! Avoid duplicates in closed tag list when doing the split quote thing. Needs a rewrite though. (Class-Editor.php)

* Indenazi, Pretty URL replace buffer cleanup and other useless changes. (Subs.php, ManageMedia.english.php, post.js, index.css)

! Event delayer was systematically doing a failed bind() for each and every event in the page. Oops, my bad. (Subs.php)

- sScriptUrl and sImagesUrl are never used (or never useful) in a couple of JS objects. (Display.template.php, Media.template.php, topic.js)

* Renamed admin menu entry 'Reports' to 'Detailed Reports'. I think it should help differentiate it from moderator reports. I always get confused by this. (Admin.language.php)

* Updated French translation. (Admin.french.php, ManageMedia.french.php)

! It's Rank images, not Stars. (ManageMembers.language.php, Reports.language.php)

! Fixed toggler in the email settings page. Note: we need to turn this into a PROPER Wedge toggler... (ManageNews.template.php)

* Various script.js changes that may or may not be reverted later: a semi-fix for reqWin title retrieval (doesn't actually work on text nodes, uh...), and a hack to prevent Firefox from fixing the reqWin event. (script.js)

! Apparently, Firefox 5 (and earlier?) doesn't like when jQuery creates a hidden input and adds a name param separately. Fixed by putting the name into the tag string itself. (suggest.js, topic.js)
Posted: July 14th, 2011, 05:09 PM

rev 865

! Typo crash. (Admin.php)
Title: Re: New revs
Post by: Nao on July 14th, 2011, 09:28 PM
rev 866 (another big commit... U mad bro?)
(16 files, 27kb)

* Moved user box template to its own function. (Display.template.php)

* Subtle changes to the post box to please Pete, err, to make it less crowded. (sections.css)

* Boldly attempting to remove the border around fieldsets in the admin homepage. Only there, eh. Makes the page less... crowded, you got it. (index.css)

! Media embedder still had a deprecated table align. Ouch. (Subs-Media.php)

! In some situations (namely Wedge rewriting the tab_data stuff with its own data to finetune tab positions), Wedge would fail noticing that it shouldn't be trying to show a context menu item. (GenericMenu.template.php)

- As far as I know, $txt['attachment_log'] is not used anywhere. (Admin.language.php)

* Ugly warning in Attachment/Avatar admin area. (ManageAttachments.php, Admin.language.php)

* Log pruning area has long descriptions in French, so I added bold tags around the actual names of the logs. (ManageSettings.french.php)

* Indenazi. (Subs-Menu.php)

* Large cleanup in the Log admin area. spider logs lost their plural, all log menu entries are now repeated (once for their in-context menu entry, once for the Log menu area, enabling to drop the 'log' part of the name and keep the context menu on a single line in French and other long languages), renamed pruning_title to log_pruning, etc. (Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin.language.php, Search.language.php, ManageSearch.template.php)
Title: Re: New revs
Post by: Nao on July 14th, 2011, 11:45 PM
rev 867
(6 files +1, 11kb)

* More changes to the topic view. Both Report to Moderator links are now in the user box, with the main one getting its own (temp) icon. And it no longer shows on user's own posts (which always baffled me because sometimes they'd use this as a way to draw attention on their own posts.) Also reworded 'Report to moderator' to 'Report this message to a moderator', because hover titles can be longer, right? (Display.template.php, report.gif, index.language.php, sections.css)

* Nothing interesting. (PersonalMessage.english.php, ManageNews.template.php)
Title: Re: New revs
Post by: Arantor on July 15th, 2011, 08:48 AM
Revision: 868
Author: arantor
Date: 07:48:22, 15 July 2011
Message:
! Some more icons for the admin panel. (Admin.php, *.png)
! Minor tag mismatch in the credits page. (Credits.php)
+ Added ability for icon copyrights to be displayed in the credits too. Feel free to edit or mash up if you don't like it, but we should be attributing where appropriate. (Credits.php, Who.english.php, Who.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Themes/default/Who.template.php
Added : /trunk/Themes/default/images/admin/about.png
Added : /trunk/Themes/default/images/admin/addon_manager.png
Added : /trunk/Themes/default/images/admin/addon_settings.png
Added : /trunk/Themes/default/images/admin/current_theme.png
Added : /trunk/Themes/default/images/admin/custom_fields.png
Added : /trunk/Themes/default/images/admin/media_maintenance.png
Added : /trunk/Themes/default/images/admin/mediasettings.png
Added : /trunk/Themes/default/images/admin/news_and_newsletters.png
Added : /trunk/Themes/default/images/admin/search_engines.png
Added : /trunk/Themes/default/images/admin/serversettings.png
Added : /trunk/Themes/default/images/admin/smileys.png
Modified : /trunk/Themes/default/images/admin/themes_and_layout.png
Modified : /trunk/Themes/default/languages/Who.english.php
Title: Re: New revs
Post by: Nao on July 15th, 2011, 09:31 AM
rev 869
(8 files +3-3, 18kb)

! Never noticed that before, but the main content was misaligned in floating sidebar mode. (index.css)

* Don't show « » in Last edit, and show it in italics only through CSS. (Display.template.php, sections.css)

* Say "Last edited" instead of "Last edit", since it's followed with "today", "yesterday" or "on Date". (index.english.php)

* Renamed some bigicons to keep underscore consistency. (ban_list.png, media_settings.png, server_settings.png, Admin.php)

* The admin area's placeholder icon should be at the same size as the rest... (Admin.template.php)

* Translation, or lack thereof. (Who.french.php)
Title: Re: New revs
Post by: Arantor on July 15th, 2011, 10:41 AM
Revision: 870
Author: arantor
Date: 09:41:22, 15 July 2011
Message:
! Added an alternative hostname resolver that should be faster on most systems with no noticeable change in quality of result (and won't hit timeouts the same way gethostbyaddr does if the address is non-existent) (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on July 15th, 2011, 05:01 PM
rev 871
(6 files, 14kb)

+ Added ability to position message user boxes to the right of the post, instead of the left. Defaults to the right for now (opposite the sidebar.) (Display.php, Display.template.php, sections.css)

* Improved AeMe image embedding styling. (media.css)

* Repositioned down arrows in the main menu a pixel further down, because it felt a bit misaligned. Only a bit really. Also saved a few bytes by not re-including menu.gif, which was already included for h4 tags. (index.css)

* Some profile options had finishing periods, when surrounding options didn't. (Profile.english.php)
Title: Re: New revs
Post by: Nao on July 15th, 2011, 11:39 PM
rev 872
(7 files, 32kb)

- AeMe code was still using reqWin(this.href). Although technically still all right, we don't need to specify the ".href" anymore... (Aeva-Gallery2.php, ManageMedia2.php, Media.template.php)

! Applied youtu.be fix to thumbnail retrieval. (Aeva-Embed.php)

* Rewrote title retrieval code for help popups. Now works on all of the help links I could think of. I'm not going to test them all, eh... Hopefully we'll rewrite this mess of an admin area later. (script.js)

* Serious update to the help popup language files. Hardcoded titles were removed. Quote entities changed to double quotes. Double spaces made single again. Updated SMF and simplemachines to Wedge where expected. Rewrote time_format and custom_mask help popups to be actually usable, and to fix many inconsistencies in the descriptions. Fixed some "users" to users' or user's. (Someone was having problems with their English grammar.) (Help.english.php, Help.french.php)
Title: Re: New revs
Post by: Nao on July 16th, 2011, 12:10 PM
rev 873
(8 files, 10kb)

* Turned media banning's findmember into an auto-suggest. More to come. (ManageMedia2.php)

! Media banning language string fixes. (Admin.language.php, ManageMedia.language.php, ManageMedia.template.php)

! Javascript trimmer was being incorrectly implemented, should have been $.trim($()), not $().trim(). Hey, what did you expect. (script.js)

* Moved .windowbg/2/3 background colors to $winddow_bg/2/3 variables. (index.css)
Title: Re: New revs
Post by: Nao on July 16th, 2011, 10:46 PM
rev 874
(31 files, 37kb)

* Renamed smf_prepareScriptUrl to we_prepareScriptUrl, and removed the parameter. It was systematically we_script anyway... BTW, I think I spotted a SMF bug in the multilingual readme selector for packages. (index.template.php, Packages.template.php, Post.template.php, SplitTopics.template.php, Themes.template.php, editor.js, mediadmin.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js)

* Rewrote Jump To box to use pretty URLs when they're enabled. (Ajax.php, Xml.template.php, script.js)

- Simplified Jump To parameters and removed lots of static vars. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php, script.js)

- Removed Jump To from the Search area. Did anyone actually notice there was one in there...? Yup, just what I thought. (Search2.php, Search.template.php)

* Renamed Jump To to Quick Access. UI stuff, you know. I'm not paid a million bucks a month for nothing. BTW, I'm still waiting for my first check. (index.english.php, index.french.php)

* Rewrote Jump To/Quick Access (okay, it's the last time I'm talking about this) to get rid of the "Go" button. To ensure one can still access the current board (which can be done through the linktree next to it anyway), Wedge no longer fills in the current board name separately. Instead, it emphasizes it with a different background color. The rewrite also allowed me to save nearly 300 bytes off the gzipped size of the script file. Yay for me. And I removed the IE hack because, well, it didn't work. Who cares about IE glitches. (script.js)

* Moved Legend icons to the sidebar in Unread Replies and Unread Topics. (Unread.php, Unreadreplies.php, Recent.template.php)

- Class quickbuttons already implied reset and smalltext. (PersonalMessage.template.php, Post.template.php, Profile.template.php, Recent.template.php, Search.template.php)

! Class quickbuttons (again) should only be a table cell in topic view, otherwise it doesn't render well in Recent Posts. (sections.css)

* Slightly modified design for the post title and jump to boxes in topic view. (sections.css)

! In the search box's ignored board list, if you didn't have many boards the layout was odd. (Search.template.php)

- Removed #topic_icons definitions, no longer used. (index.ie6.css, index.ie7.css, sections.css)
Title: Re: New revs
Post by: Nao on July 17th, 2011, 08:09 PM
rev 875
(7 files, 12kb)

* Instead of 'My Community', Wedge will now set a default non-generic name for your board at install time, based on the URL. For instance, installing it "http://wedge.org/forum/" will automatically name it "Wedge Forum". (install.php, Install.language.php)

! e.keyCode is not standard. jQuery has e.which. (MessageIndex.template.php)

! Found a more 'semantic' workaround for the reqWin event fixer. I still don't want to force recording the current event in delayed events. (script.js)

! Wrong variable name (event should be e). (topic.js)

* Changed menu background again to add the gradient effect back into it. This is now officially the most crowded design I've ever seen for a menu. I'll be right back after my seppuku. (index.css)
Title: Re: New revs
Post by: Nao on July 18th, 2011, 03:54 PM
rev 876
(12 files, 29kb)

+ Added support for separators in the main menu. (Subs.php, index.template.php)

* Merged the Admin and Moderate menus. Now admins will no longer have to deal with that silly Moderate button, everything is added to the admin menu below a separator. (Subs.php, sprite-menu-32bit.png, sprite.png, index.css)

* Shortened 'Unapproved posts and topics' to just 'Unapproved posts'. Really, it's the same... (index.language.php)

* Made the main menu background a bit more uniform. (index.css)

* Forgot to rename wedge_news in a few places. Also gave the 'we' prefix to admin objects. Also fixed JS errors in the moderation center. (latest-news.php, Admin.php, Admin.template.php, ModerationCenter.template.php, admin.js)
Title: Re: New revs
Post by: Nao on July 19th, 2011, 08:19 PM
rev 877
(7 files, 23kb)

+ Added an 'action menu' that is for individual posts what the user menu is for post authors. Moved 'report to moderator' to that menu. Work in progress (although it works fine as it is.) (Display.php, Display.template.php, index.language.php, topic.js, sections.css)

! Undefined $php_errormsg. (Load.php)

@ Sorry for the slightly hackish solutions in sections.css, Display.php and topic.js... These were the simplest ones I could devise. Also should point out that for design consistency, I reused the quickbuttons styling on the user menu -- i.e. it now uses uppercase Trebuchet MS instead of normal Verdana. Still unhappy with text alignments, but it's hard to do something 'clean' when you have to use background-image to add icons... :-/
Title: Re: New revs
Post by: Nao on July 20th, 2011, 01:03 AM
rev 878
(3 files, ??kb)

* Reordered internal array for action menus, added a placeholder for link hover titles, and turned the 'click' member into 'custom', as it could be used for anything really. (Display.php, topic.js)

! mouseleave event didn't work correctly on user menus with the 'right-side' class applied to them. (topic.js)

* Even more hacking to prevent right-aligned user menus from animating the links inside them. Using float:right instead of text-align:right does the trick, although it also forces us to use the overflow:hidden clearfix, as well as some careful reordering. Gotta love CSS in those moments... (sections.css)

@ I still don't know if you guys like this all... I mean do you think it's better with or without the action menu?
Title: Re: New revs
Post by: Nao on July 20th, 2011, 08:51 PM
rev 879
(3 files, 14kb)

* Merged the two mini-menu objects (user, action) into a single one, saving about 1.2KB in the process. Gets a tad confusing though... Should try and make the two menus more similar internally. (topic.js)

* Moved profile icons to their own function. (Display.template.php)

* Minor display template changes. (Display.template.php)

! Selector inheritance bug in mini-menu. (sections.css)
Title: Re: New revs
Post by: Nao on July 20th, 2011, 10:29 PM
rev 880
(3 files, 12kb)

* Converted user menus to use the same object structure as action menus. Saves about 300 bytes in the topic.js file, but it's mostly for the slight benefit of readability. (Display.php, Display.template.php, topic.js)

! Minor jQuery error with opacity animation. (topic.js)

@ I think I'm done with these menus... Might just wanna add icons to the user menu, now.
Title: Re: New revs
Post by: Nao on July 21st, 2011, 12:41 AM
rev 881
(8 files, 14kb)

+ Added icons to the user menu. Uh. Actually, only one really... But at the least code skeleton is here. Also swapped class contents between list items and anchors in mini menus. (Display.php, Display.template.php, sections.css)

- Couldn't find the reason why there were non-semantic span tags inside mini-menu calls. So I removed them, because that's who I am. (TEMPLATES: Display, PersonalMessage, Post, Profile, Recent)

! Fixed icon positions in mini-menu. (topic.js)
Title: Re: New revs
Post by: Nao on July 21st, 2011, 11:42 PM
rev 882
(1 file, 7kb)

* More size optimizations for mini-menus (an extra 100 bytes saved.) (topic.js)

* Also made a few things clearer. Overall it should now be easier to write a fallback for non-JS by writing all of the code through PHP instead. (topic.js)
Title: Re: New revs
Post by: Nao on July 22nd, 2011, 11:01 PM
rev 883
(6 files, 10kb)

+ Added buttons for all of the currently available user menu items. Some are temp. Someone please find something worthy for them... And possibly move some of these icons to index.member.css -- at the very least, 'Send PM' and 'Add to buddies'! (Display.php, sections.css)

! Website links didn't work in user menu, because of extra quotes in them. (Display.php)

! $user_info['url'] was incorrectly set up in boards and topics when pretty URLs were used. As a result, the quick language change link would always redirect to the upper level. (Load.php)

* Spacinazi. (Profile-Modify.php)

! Member titles in user boxes used the title header styling, because of the ambiguous class name (li class="title"). (Display.template.php)

- Main forum header doesn't need a font size class to be set, as it's overridden in CSS anyway. (index.template.php)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 11:01 AM
rev 884
(4 files, 12kb)

+ Added $message['has_buttons'], which can be modified in the per-post hook ('display_post_done'). Allows you to add action menu buttons without too much of a hassle. Well, eventually at least... (Display.php, Display.template.php)

! User and action menus were incorrectly viewed as never empty on non-guest posts, and thus failing some tests for guests or users without any permissions. (Display.php)

* Moved buddy and PM buttons to the member CSS, saving some bandwidth for guests. (index.member.css, sections.css)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 12:50 PM
rev 885
(3 files, 5kb)

! SMF bug when handling admin membergroup. Thanks live627! (ManageMembergroups.php)

* Signatures didn't have enough breathing room at the bottom. (sections.css)

* Linktree array was being counted once, plus once for each linktree entry. Reduced this to only once overall. (index.template.php)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 01:39 PM
rev 886 -- aka the 'is_last' commit. Easy to revert, just in case...
(6 files, 8kb)

- Removed 'is_last' element from contextual tabs. They were only used in SMF 1.x themes, dropped in SMF 2.0, and these can be re-introduced easily through hooks. If anyone needs them, at least... (ManageBans.php, ManageErrors.php, ManageMembers.php, GenericMenu.template.php)

- Removed 'is_last' element from generic menus. They weren't used either in Wedge, and were pretty buggy. (1) $first_sa was tested for emptiness at a point where it could never be empty. (2) Current, first and last entries were set twice -- once during the main loop, and once after the loop was finished. (3) First and last entries in a submenu were swapped if in RTL mode. Since when does RTL include 'bottom to top'...? (Subs-Menu.php)

- Removed 'is_last' element from the main menu. Pretty much the same reason... Also fixes another SMF bug: $last_button ($last_item in Wedge) is set but never used, and is_last is unset in some situations but never reset elsewhere. (Subs.php)

! The Media tab in the main menu shouldn't show a submenu if it's only going to show a repeat of the top link... (Subs.php)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 08:43 PM
rev 887
(23 files +2-1, 50kb)

* Renamed reporttm action to report, as the word 'report' itself wasn't taken... Also added a temp Report button. (index.php, unit test, Display.php, Report.php, Subs.php, Display.template.php, SendTopic.template.php, Errors.language.php, index.english.php, Who.language.php, sections.css, report.png)

* Started renaming the warning system in the French translation. I was always bothered by its lack of coherence. "Report" is now "Avertir" instead of "Signaler", while "Issue warning" becomes "Sanctionner" instead of "Avertir". Also improved/fixed translation.
(Errors.french.php, Help.language.php, index.french.php, ManagePermissions.french.php, ManageSettings.french.php, ModerationCenter.language.php, Modlog.french.php, Profile.french.php, Reports.french.php)

* Renamed a couple of credit categories. (Who.language.php)

! The Remove button in the action menu was pretty broken. (Display.php)

! Rev 880 typo introduced a bug in the user menu regarding user vs post IDs. Blame copy & paste. (Display.php, Display.template.php)

! The IP icon had a help icon behind it. Fixed by renaming its class to helpc (for 'help cursor'). Also a shameless plug for multiple inheritance, ah ah. (Display.template.php, index.css, sections.css)
Title: Re: New revs
Post by: Nao on July 23rd, 2011, 11:53 PM
rev 888
(4 files, 8kb -- an appropriate size, dare I say.)

! Apparently, the Atom feed implementation was written around the time Atom 0.3 was out. Version 1.0 changes the modified tag to updated, and tagline to subtitle. Updated Wedge to use them. Also switched from summary tags to content tags, because as the name implies, summary should be for post extracts, not entire bodies. (Feed.php)

! Fixed RSS implementation bug: language should be specified in the language tag, rather than xml:lang (RSS is not proper XML so it doesn't officially understand that.) (Feed.php)

* Added a comment about the fact that pubDate for items is for RSS 0.93 and RSS 2.0, thus it renders the RSS 0.92 feed invalid. (Not that I'm not planning to remove it anyway...) (Feed.php)

* Top-level submenus are now horizontally aligned on their parent's label, rather than their icon. I guess it's something that could warrant a discussion, but apparently it's not a fascinating subject, so I'll just leave it at that. I probably should rewrite the menu code to make it simpler at this point. (script.js)

! Updated Trophy icon (used in the stats area) to fit in the same dimensions as the other icons on the page. Approximately, at least. (stats_posters.gif)

! Report button had too much padding on the right. (sections.css)

@ When will the bug fixing end? :P
Title: Re: New revs
Post by: Arantor on July 25th, 2011, 04:22 PM
Revision: 889
Author: arantor
Date: 15:21:08, 25 July 2011
Message:
! IP address unformatted if logged as a failed-admin-login-attempt where the IP address was in the body of the error. (Subs-Auth.php)

! Moving numeric formatting strings to the language files rather than a single global variable that was even wrong by default (1234.00 is not the format normally used in the US) (install.sql, Load.php, ManageSettings.php, Subs.php, Help+index+ManageSettings language files)

! Removing the ban log as part of removing the ban system generally (install.sql, repair.php, Admin.php, Class-DBPackages.php, ManageBans.php, ManageMaintenance.php, ManageSettings.php, ScheduledTasks.php, Security.php, Subs-Members.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/repair.php


w00t one less table! More to disappear too, inevitably.
Title: Re: New revs
Post by: Arantor on July 25th, 2011, 05:29 PM
Revision: 890
Author: arantor
Date: 16:29:09, 25 July 2011
Message:
! Improve how timezones are handled, namely: 1) Don't try forcing use of Etc/ legacy timezones that are actually confusing by nature anyway, but actually attempt to query for proper timezone instead of estimating, 2) ensure an actual timezone will be set even if we don't have one in the DB for any reason as a fallback, 3) improve the selector in the admin panel to limit to only the regions of interest. (install.php, Load.php, ManageSettings.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
Title: Re: New revs
Post by: Nao on July 25th, 2011, 07:14 PM
rev 891
(13 files, 20kb)

- Don't call JSE on mini-menu strings that won't be shown in the first place. (Display.php, Display.template.php)

* Harmonized string names for mini-menus and added descriptions to all of them. Removed all related strings that weren't used anywhere else. (Display.php, index.language.php, topic.js)

! Fixed Close button not showing up on zoomed items when double-clicking them (happened only if no further zoom level was available.) (zoomedia.js)

! The number of new PMs was being tested twice per page. Removed it from the menu array, and kept the one in the menu builder. (Subs.php)

* New PM indicator was ugly (red text on dark background), replaced it with the usual 'New' icon. (Subs.php, index.css)

* Replaced New icons with versions that don't show white pixels around them on dark backgrounds. Uh. (new.gif)

* IE details. They're still heavily broken. I don't care for now. (index.ie6.css, index.ie7.css)

- Removed .postarea { margin: 0 0 0 15em }, as it's useless in display:table mode. This will, as you guessed correctly, break IE6 and IE7 even more. And again: I don't care for now. I'll fix that when I feel like it. (sections.css)
Title: Re: New revs
Post by: Arantor on July 25th, 2011, 09:29 PM
Revision: 892
Author: arantor
Date: 20:27:35, 25 July 2011
Message:
! First use of the proposed number_context function to aid in i18n of language strings. I've applied it to the board index and message index for the number of posts, topics and redirections for each board, with an appropriate 'No topics' type string for 0, which just looks nicer to me. (Subs.php, BoardIndex.template.php, MessageIndex.template.php, index.english.php)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/index.english.php


Yup. I finally implemented this sucker. It is a touch more elaborate than my original - because it also calls on comma_format while it's at it, meaning the language string has to have a %s in the right place for the numbers. But there are examples of this now!!
Title: Re: New revs
Post by: Nao on July 26th, 2011, 12:13 AM
rev 893
(7 files, 11kb)

* Cleaned up more DELETE FROM entries. Inspired by the latest commit. (ManagePermissions.php, ManageMedia2.php, Subs-Media.php, ScheduledTasks.php, Subs-Scheduled.php)

* French translation. Also, I believe our separator for floating point is a comma, not a period. (index.french.php)

* One-liner replacement for number_format. I'm sorry, I'm just like that. Please don't look at me that way. (Subs.php)
Title: Re: New revs
Post by: Nao on July 27th, 2011, 10:44 AM
rev 894
(13 files, 13kb)

* Modified error log's code previewer to show only 30 lines instead of 20[1] and use a monospaced font instead of the default. This ensures we get the entire preview without triggering a vertical scrollbar, improving usability. (ManageErrors.php, Errors.template.php, admin.css)

* Rename 'buddies' to 'contacts' in the English version, and other minor changes. To do: asymetrical contacts. (LANGUAGES: index, ManageSettings, Packages, PersonalMessage, Profile, Who, Wireless)

* Do not show "Age: N/A" in profiles if no age was specified. Just hide the line entirely. It's a waste of time, bandwidth and intelligence. (Profile.template.php)

! allow_no_censored should be tested through !empty(), as is often done. Not that it'll have any influence on a properly installed Wedge, but it's always been done this way with $modSettings, so we should harmonize it. Either add !empty() everywhere, or remove them everywhere. Considering updateSettings() is optimized for a systematical use of !empty(), it might also warrant a rewrite. (Profile.template.php)
 1. I meant '30 lines instead of 40'. Changelog error, sorry.
Title: Re: New revs
Post by: Nao on July 28th, 2011, 01:08 AM
rev 895
(8 files, 10kb)

! Whitespace trimmer in BBC parsing code was broken. (Subs-BBC.php)

* encodeURIComponent() has been supported as far back as IE 5.5, so there's no reason to use SMF's way of emulating it (string.php_tp8bit().php_urlencode()). (Packages.template.php, Post.template.php, editor.js, register.js, script.js, suggest.js, topic.js)

* php_strtr uses charAt when it could use [] instead. It's a bit faster, which is good in long loops. (script.js)

@ Note: there are two extra escape() calls in PM and Search templates, followed with unescapes. I'm letting them be for now because they're testing for %u in the URL, which only happens in escape()'d strings. I can probably just change the test to % alone... What do you think Pete? I haven't tested this.
Title: Re: New revs
Post by: Nao on July 28th, 2011, 12:42 PM
rev 896
(2 files, 9kb)

* Since php_strtr, php_strtolower and php_to8bit are only used in sha1.js, moved these functions to the correct file, saving 1.5kb (0.5kb gzipped) off the final cached file. If any mod wants to use them -- just include sha1.js in your stuff or copy the functions. I'm not forcing extra bandwidth use for logged in members. (script.js, sha1.js)

! The reason why charAt() is being used instead of [] is because IE6/IE7 don't support this. My bad, I thought they were decent browsers. Nah, just kidding, we all know they suck. Well, since php_strtr is only used in password encryption, it's not like it needed any optimization anyway. (sha1.js)

+ Added headers to the JS files. Well, at least we should start to do it. (script.js, sha1.js)
Title: Re: New revs
Post by: Nao on July 29th, 2011, 12:58 AM
rev 897 (a small one before going to bed...)
(4 files, 7kb)

* Replaced the very last escape/unescape calls with encodeURIComponent/decodeURIComponent. They're better suited for URL encoding. (PersonalMessage.template.php, Search.template.php)

* Removed {db_prefix}members:media and added {db_prefix}messages:id_parent. Both are unused, but id_parent can be used later for building a threaded view. (install.sql)

! If a timezone has no slash in it (such as 'UTC'), the timezone retrieval code will generate a warning. (ManageSettings.php)
Title: Re: New revs
Post by: Nao on July 29th, 2011, 08:21 PM
rev 898
(4 files, 7kb)

* More JavaScript function changes. Deleted php_addslashes (never used anywhere), moved easyReplace from script.js to post.js (it's only used by the smiley manager), turned _replaceEntities into an anonymous function (as it's only used by removeEntities). (post.js, script.js)

+ Added ability to call a regular popup window in reqWin, as opposed to an Ajax popup. (script.js)

! Fixed media button to call a popup window, as it's a two-step process and the second page wouldn't load in the Ajax popup. (Aeva-Gallery.php, editor.js)

@ Note: I wanted to use an iframe or something cooler than a popup window, but hey... Nobody ever complained about the AeMe popup in the first place, so why bother/waste time on this. As long as it works...
Title: Re: New revs
Post by: Nao on August 1st, 2011, 01:56 PM
rev 899
(11 files, 12kb)

* Upped the minimum PHP version to 5.2.3, so we can use the double_encode parameter on htmlspecialchars(). (install.php, readme_*.html, webinstall.php, upgrade.php, Class-String.php)

* Changed is_integer() to is_int() or a version that's approximately twice faster, (int) $number === $number. (smf_api.php, Class-String.php, Aeva-Subs-Vital.php)

* jQuerification of packman's file permission page. (Packages.template.php)

! Fixed folder icon alignment and padding in file permission page. (Packages.template.php)

@ NB: big commit today, so I'm splitting it in two. The next one will be there in a few.
Title: Re: New revs
Post by: Nao on August 1st, 2011, 02:00 PM
rev 900
(7 files, 14kb)

+ Added format_comma parameter to number_context(), allowing to disable comma formatting in specific cases. (Subs.php)

+ Optimized comma_format() to skip the (albeit very fast) number_format() call if the number is an integer (no decimal separator) and has less than 4 digits (no thousands separator). Performance is about 25% slower if the test fails, and 400% faster if it succeeds. (Subs.php)

! Searched PM messages didn't show the number of users in a replied PM, unlike other areas in Wedge. (PersonalMessage.php)

- Deleted wedge_checkReplied, as it was basically an early draft of number_context(). (PersonalMessage.php)

* Number of moderator reports now uses number_context(). (index.template.php, index.language.php)

* draftAutoPurge now uses number_context(), as originally intended. (PersonalMessage.template.php, Profile.template.php)
Title: Re: New revs
Post by: Arantor on August 1st, 2011, 02:49 PM
Revision: 901
Author: arantor
Date: 13:49:16, 01 August 2011
Message:
! First part of handling timezones from user perspective, there's no interface for it yet but it works from the database. (install.sql, Load.php, ManageSettings.php)

! The title derived from the current URL should not have a leading space. (install.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on August 1st, 2011, 05:55 PM
Revision: 902
Author: arantor
Date: 16:52:27, 01 August 2011
Message:
+ Provide the ability for people moving a topic to set how long the topic redirection notice stays in place for. (MoveTopic.php, MoveTopic.template.php, Subs-Scheduled.php, index.english.php)

! Miscellaneous layout bug in the move topic template, due to overwide dd forcing wrapping rather than floating. (sections.css)

! Miscellaneous bugs in the imperative scheduled system (Load.php, Subs-Scheduled.php)

! The recount-reports function is sometimes going to be run when permissions aren't loaded (namely during scheduled/imperative tasks), make sure the mod cache is loaded in that circumstance. (ModerationCenter.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/skins/sections.css



@ This isn't really finished, it's just at a convenient stopping place. The default is 1 day simply because it's at the top of the list, not because it's set that way - but that's actually an improvement in usability terms to the previous version IME. I haven't decided about allowing admins to set a default yet.

@ See also the discussion about dealing with redirections automatically; the way I solved it in the redirection topics mod I originally wrote was a separate table. Given the minimal approach I wanted to SMF modding at the time, this was the closest I could get, and it would only clean up once per day rather than actually as needed, so the individual table was useful then.
Title: Re: New revs
Post by: Nao on August 1st, 2011, 10:13 PM
rev 903
(9 files, 11kb)

* Don't show a submenu on mail settings (admin area) if the mail queue is disabled. (Admin.php)

! Fixed accidental revert from the last timezone commit. (ManageSettings.php)

* Changed 'Mail' label to 'Email Settings' in the Server & Maintenance admin menu. (Admin.language.php)

* I thought it would be amusing if the redirection topic strings actually used number_context()... (index.language.php, MoveTopic.template.php)

* Very minor fixes/changes. (ManageMedia.template.php, sections.css)

* French translation. (index.french.php)
Title: Re: New revs
Post by: Nao on August 2nd, 2011, 01:02 PM
rev 904
(6 files +2, 18kb)

* Changed wedge_type field name to board_type. At this point I'm unsure we'll keep the 'wedge' terminology for boards and blogs, so there's no point in adding more confusion. (install.sql, Load.php, RemoveTopic.php)

+ Re: my post 257238(http://wedge.org/pub/6538/plugin-hooks/msg257238/#msg257238) at the forum, implementing 'before', 'after' and 'override' generic hooks for all template functions. The total overhead is no more than a millisecond per page. Needs more work. (Load.php)

! Resetting global locale scope to LC_TIME instead of LC_ALL, to avoid issues in the CSS parser. Although we could have fixed that directly in the parser, we're never far away from meeting more issues, so for now we'd rather remain compatible with the SMF method. (Load.php)

+ Added index.php dummy files for a couple of folders that missed them. (images/fields, images/theme)

! Typonazi. (Install.french.php)
Title: Re: New revs
Post by: Arantor on August 4th, 2011, 03:05 AM
Revision: 905
Author: arantor
Date: 02:04:48, 04 August 2011
Message:
! Removed several settings that irritate me in the admin panel:
- Current theme / Show BBC buttons in PM and Post Pages; you'd control this from the BBC and smileys areas instead. (Class-Editor.php, Settings.template.php, Admin.*.php)

- Go up/down buttons (on by default instead now) (ManageSettings.php, ManageSettings.*.php, Help.*.php, Display.template.php, MessageIndex.template.php)

- Show current position as text in linktree (I cannot seriously imagine anyone actually using this. It sort of defeats the point of a *link* tree.) (upgrade.php, Settings.template.php, Themes.*.php)

----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on August 4th, 2011, 03:09 PM
rev 906
(10 files, 15kb)

+ Added ability to disable prev/next links in page index[1]. This is mostly useful in the message index. (MessageIndex.php, Subs.php)

! A couple of columns were wrongly colored in the admin member list. Also fixed comment typos and optimized styles/classes. (ManageMembers.php)

! Use $context['start'] instead of $_REQUEST['start'] in the message index. (MessageIndex.php)

- Deleted 'list_menu' and 'use_tabs' generic list features, as they're not used in Wedge. Or even in SMF, actually. (Subs-List.php, GenericList.template.php)

! Logic error in media admin JS, as well as a useless .each() call. (mediadmin.js)

- Removed another useless .each() call, this time for img.resized. (theme.js)

- Removed two unused footer classes and a useless ic_login. (index.css, index.rtl.css, sections.css)

+ Added a max-width for images. Should think of a better solution... (index.css)
 1. When calling the function, I mean. That is, it's internal to Wedge.
Title: Re: New revs
Post by: Nao on August 5th, 2011, 05:39 PM
rev 907
(7 files, 11kb) <-- much less than the time spent on it, comparatively :P

- Deleted stupid addLoadEvent() and rewrote the last couple of items that still used it to use better equivalents ($(window).load() and add_js). (install.php, upgrade.php, Subs.php, script.js, theme.js)

! When hovering out of a top-level menu entry with no submenus attached to it, it would remain highlighted for a second because the hover class was being removed from the wrong element. (script.js)

! Fixed one remaining occurrence of a wrong $.trim() implementation. (script.js)

* Simplified version retrieval at install time. (install.php)

* Changed the default minification process to Packer. I figure if modders can't make it work on a default install, they'll be more cautious about this whole semicolon issue, and I'd rather have to deal with modder issues than with user issues once they enable Packer. (install.sql)

- Removed outdated holidays from the calendar. (install.sql)

* Keep-alive timeout should be using a function name rather than a string. Same for the toggler object and menu_hide_me at one point. (script.js)

* Plenty of minor cleanup operations. (editor.js, script.js)
Title: Re: New revs
Post by: Nao on August 6th, 2011, 11:35 AM
rev 908
(9 files, 12kb)

- Removed site list's ability to self-update, as I don't see myself updating it outside of the main software's updates themselves. You can update manually from further Wedge updates, obviously. Also removed some outdated code that checked for new Aeva Media versions. (Aeva-Embed.php, ManageMedia.php, ManageMedia3.php, Subs-Media.php, ManageMedia.language.php, Media.language.php)

* Casenazi. (PersonalMessage.php)
Title: Re: New revs
Post by: Nao on August 7th, 2011, 09:54 AM
rev 909
(29 files +5-5, 104kb)

* Replaced $forum_version with WEDGE_VERSION constant. It was already defined, just not used. This eliminates the need to globalize $forum_version each time you need it. Version number also gets rid of the 'Wedge' element. We only want a number! (index.php, install.php, smfinfo.php, upgrade.php, current-version.php, detailed-version.php, Calendar.php, Class-DB.php, Credits.php + Who template collateral, Feed.php, ManageMaintenance.php, ManageMedia.php, ManageServer.php, PackageGet.php, ScheduledTasks.php, Subs-Package.php, Subs.php, index.language.php, Packages.template.php)

* More renaming of SMF to Wedge in versioning and things like that, like fixing and optimizing the JS for the detailed version page. It was all very messy to begin with and it's done across this commit and the next anyway. (Install.language.php, admin.js...)

* Renamed Findmember to FindMember, Jseditor to JSEditor, Jsoption to JSOption, Printpage to PrintPage and Unreadreplies to UnreadReplies. Both for function names and file names. The next commit will fix the filenames (due to a SVN limitation.) (index.php, temp.*.php)

* Simplified admin JS object, by shortening some ridiculously long variable names and hardcoding version compare DOM IDs. Who would change them anyway?! SMF2 has a tendency to encourage the multiplication of settings when it should instead be deciding whether or not something is likely to be changed in the future. (Admin.php, admin.js)

* list (), not list()... (upgrade.sql, current-version.php, latest-packages.php, latest-themes.php)
Title: Re: New revs
Post by: Nao on August 7th, 2011, 09:59 AM
rev 910
(10 files, 12kb)

! Fixed Safari 2.x not using readOnly on form submit (heck, I'm not even sure if this bug was valid to begin with?), and optimized invertAll. (script.js)

! Helper functions should use camelCase, thanks John. (PersonalMessage.php)

* Finished version renaming stuff. (Admin.template.php)

! What was 'Wedge (originally SMF) Add-on' language string supposed to mean in the Admin area's detailed version page? It's only giving us the main version... And if it's supposed to be the version of the package that made the upgrade... Isn't it supposed to be the same? (Admin.language.php)

- Removed more of the auto-update code for AeMe. (ManageMedia.template.php, Media.template.php)

* Updated some outdated file headers. (Subs-Aeva-Sites.php, Media.language.php)
Posted: August 7th, 2011, 09:57 AM

rev 911
(0 files +5-5)

! Grmpf... Was in a hurry to grab something to eat, and forgot to rename the files like I was supposed to in rev 910. (temp.*.php)
Title: Re: New revs
Post by: Nao on August 7th, 2011, 12:49 PM
rev 912
(27 files, 26kb)

* Renamed smfVersion to weVersion and smfVersions to weVersions (also changes the smfVersion setting name in the DB, FYI). Also renamed a few rarely used global JS variables in a similar fashion. (install.php, install.sql, smfinfo.php, upgrade.php, upgrade.sql, current-version.php, detailed-version.php, latest-*.php, mirrors.xml, Class-DB.php, Themes.php, admin.js, TEMPLATES: Admin, ManageSmileys, Packages, Themes)

* Renamed remaining typeof()s to just typeof. (smfinfo.php, latest-themes.php, Aeva-Foxy.php, MessageIndex.template.php, Packages.template.php, Profile.template.php, Themes.template.php, spellcheck.js)

* Normalized all remaining keyCode calls to $.which. (MessageIndex.template.php, zoomedia.js)

- There was no reason to call smf_codeFix since it's always called as needed in the default theme anyway... (Post.template.php)

* One more variable name optimization. (script.js)

@ Note: I'm not 100% sure about documenting all of the files where typeof was changed. Who cares...
Title: Re: New revs
Post by: Nao on August 7th, 2011, 01:35 PM
rev 913
(3 files, 19kb)

* Moved media table creation from db_aeva to the regular Wedge installer. db_aeva still needs to be run at this point, but it'll soon be a thing of the past. (db_aeva.php, install.sql)

* Forgot to save the editor, where I had another keyCode to which conversion. (editor.js)
Title: Re: New revs
Post by: Arantor on August 8th, 2011, 10:34 AM
Revision: 914
Author: arantor
Date: 09:33:24, 08 August 2011
Message:
! Remove the 'make emails visible' option, it's just not needed to present emails as-is for all members (even just to other members) as an option. (All files mentioned here are related to this change, namely cleaning out the old 'yes' branch)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Arantor on August 8th, 2011, 10:52 AM
Revision: 915
Author: arantor
Date: 09:48:56, 08 August 2011
Message:
! Made the warning system permanently on, seeing how we're going to be making more use of it. Most of this is simply removing two sets of is-enabled checks. (install.sql, Admin.php, Display.php, ManagePermissions.php, ModerationCenter.php, PersonalMessage.php, Profile-Actions.php, Profile-View.php, Profile.php, ScheduledTasks.php, ManageSettings.language.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql

Posted: August 8th, 2011, 10:49 AM

Revision: 916
Author: arantor
Date: 09:52:00, 08 August 2011
Message:
! Oops, forgot to remove the warning_enabled default setting from the installer. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on August 8th, 2011, 11:48 AM
rev 917
(8 files, 12kb)

* Renamed $txt['board_topics_*'] to $txt['topics_*'] to harmonize with posts and redirects, grouped them together, and fixed the few occurrences of $txt['board_topics'] that weren't converted yet. Also removed the ucfirst on processed Posts, Topics and Redirects, since they're guaranteed to have a number before them. (SSI.php, BoardIndex.template.php, MessageIndex.template.php, index.language.php)

! add_js() was using a wrong restarter CDATA, oops. (Subs-Cache.php)

* Some tweaks to the user box. (sections.css)

* First topic post now sports a slightly larger font to differentiate it from the rest. Best used in blog posts. (sections.css)

* Testing other fonts for topic posts. Readability is vital here, and Arial 14px, as cool as it is in the UI, may not be the most suitable for posts. (index.css)
Title: Re: New revs
Post by: Nao on August 8th, 2011, 06:37 PM
rev 918
(13 files, 16kb)

! Aeva auto-embedding should now be applied only to popular sites by default (until you fine-tune the admin settings). This saves about 0.1s per call to parse_bbc(). (Aeva-Embed.php, ManageMedia3.php)

! self:: doesn't seem to work on public static functions. Using the object name instead. (Class-String.php)

* Removed these websites from the Popular embed list (not actually that popular these days): Bebo, Imeem, Truveo. (Subs-Aeva-Sites.php)

* Moved these websites to the Popular embed list (according to Alexa ranks): Break, Hulu, Last.fm (Audio). (Subs-Aeva-Sites.php)

* Spacinazi. Ternary operators are always processed after == :) (Feed.php, Subs-Auth.php)

* Moved a long comment out of a function. (Security.php)

* Okay, I give up for now... Back to Verdana for posts for now. In terms of readability, it's hard to do better on an imported SMF forum, otherwise it's too much of a change. For now. (index.css, sections.css)

* Now calling number_context in board index and in-topic stats, for the number of replies and views. (Display.template.php, MessageIndex.template.php, index.language.php)

- Had a remaining board_topics call. (MessageIndex.template.php)

@ Note: I would really appreciate if someone could take some time and look into video site popularities. Or even test the current state of Aeva embedding -- do all sites work as expected, etc. I wonder if I really should have sites like MySpace Videos or video.msn.com in the popular list... Do people embed these often?
Title: Re: New revs
Post by: Nao on August 8th, 2011, 07:39 PM
rev 919
(3 files, 5kb)

! Error when no news lines were filled in. (Subs.php, index.template.php)

* Spacinazi. (Subs-BoardIndex.php)
Title: Re: New revs
Post by: Nao on August 9th, 2011, 04:16 PM
rev 920
(32 files, 45kb)

* Updated 'div ul.buttonlist' to 'ul.buttonlist'. Saves some space. (index.template.php, index.css, sections.css, topic.js, Media.template.php)

* Updated the button strip visuals to something a tad less gloomy. (sections.css, index.rtl.css, media.css)
* Harmonized and simplified approvebg, stickybg, lockedbg. Also cleaned up half a dozen unused classes. (index.css, sections.css, index.rtl.css, media.css, Wuthering/sections.css, Display.template.php, MessageIndex.template.php, Recent.template.php)

* Harmonized pagesection divs, and turned pagelinks into .pagesection nav. (Aeva-Foxy.php, Aeva-Gallery2.php, Media.language.php, TEMPLATES: Display, GenericList, ManageMedia, ManageMembergroups, Media, Memberlist, MessageIndex, ModerationCenter, PersonalMessage, Profile, Recent, Reminder, Search, SplitTopics, Who)

! Undefined $merge_safe variable in some situations. (Display.php)

! Fixed text colors in viewquery mode. (ViewQuery.php)

- Removed the default 'right' parameter from button strips when still used. (TEMPLATES: BoardIndex, Calendar, PersonalMessage, Recent, Reports)

- References to .align_* classes were left in. (Reminder.template.php)

! SMF bugs: if a topic is stickied and locked, the Search template won't generate the correct class. Also, the template never actually uses it... (Search.template.php)

* Spacinazi. (Profile.template.php, Xml.template.php)
Title: Re: New revs
Post by: Nao on August 10th, 2011, 06:15 PM
rev 921
(3 files, 6kb, not a very interesting commit I know...)

* Renamed cache keys to use Wedge instead of SMF. There are going to be a lot of minor renames like this overall... (Subs-Cache.php)

! Category headers could be pushed to the right (e.g. by the menu) when reducing the window width. (index.css)

* Approve button was a bit off, too. (sections.css)
Title: Re: New revs
Post by: Arantor on August 11th, 2011, 01:59 PM
Revision: 922
Author: arantor
Date: 12:58:49, 11 August 2011
Message:
! Mismatched tags in the who's viewing sidebar template in message index. (MessageIndex.template.php)

! Time to be controversial; removing meta keywords. Most forums have them turned off, the ones that don't have global keywords that don't help, and major search engines don't use them anyway, so it's actually work that isn't needed. (Subs.php, ManageSettings.php, index.template.php, ManageSettings and Help language files)

! Added general facility for meta description support, now to be used in the message index and more places in future. (index.template.php, MessageIndex.php)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on August 11th, 2011, 05:14 PM
rev 923
(5 files, 7kb)

+ Added ability to load a CSS file in the header even after that header has been filled, e.g. from within parse_bbc(). (Subs-Cache.php, Subs.php, index.template.php)

* Minor tweaks to the post button bar. (sections.css)

* Harmonized text color on button strips. (sections.css)

! Mismatched curly brace. (GenericList.template.php)
Title: Re: New revs
Post by: Nao on August 13th, 2011, 04:36 PM
rev 924 (and that's not even the big commit... :whistle:)
(15 files +1, 20kb)

- Replacing seldom used we_images_url JavaScript variable with we_theme_url + '/images'. (index.template.php, ManageMembergroups.template.php, Themes.template.php, suggest.js, register.js)

* Minor fixed to post page button layout. (sections.css)

* Spacinazi. Please note that 'input_attr' now expects an extra space. I'm not wasting CPU cycles on just two specific form entries. (Register.template.php, Profile.template.php, Profile-Modify.php)

! Harmonized descriptions for smileys and smiley-based topic icons. Also fixed bad French translations for these. (index.language.php, Install.language.php)

+ Added the Edit smiley to the Aaron smiley set. (edit.gif)

* Smileys that are not installed by default in the visible postbox area should be in the popup, rather than hidden. (install.sql)
Title: Re: New revs
Post by: Nao on August 13th, 2011, 07:42 PM
rev 925 (and there it is... now we're talking.)
(11 files, 47kb)

* Rewrote the smiley handling system. Parsed smileys now use a div enclosing the actual smiley code. Benefit #1: copying and pasting text will retain smileys as text code in all browsers (SMF limits it to Firefox). Benefit #2: the most used smileys can now be encoded into the CSS, resulting in very fast loading times. As a note, the WYSIWYG editor will still use image tags to show smileys, otherwise navigating smileys through keyboards wouldn't work as well. (Class-Editor.php, ManageSmileys.php, Subs-BBC.php, editor.js, post.js)

+ Added aforementioned cache for BBC tag images. Should work across different smiley sets and browsers, using the same settings as the regular CSS cache. (Subs-BBC.php, Subs-Cache.php)

* Micro-optimized the editor JS code to take less space in the page (replacing objects with arrays, etc.) Because the editor code is unlikely to be changed (much) by mods, and because we now tend to add it even in topic pages, it makes sense to compact it, especially for uncompressed HTML pages where we save over 3 kilobytes. The js files also saved a kilobyte, and about 200 bytes once gzipped. (Class-Editor.php, editor.js, post.js)

- Removed smf_smileys_url (no longer used.) (Class-Editor.php)

- Removed some code that assumed $modSettings['smileys_dir'] and smileys_url weren't set... Probably some SMF1 compatibility code, because it's always set in Wedge. (ManageSmileys.php)

* Removed $txt['icon_laugh'] as it's not a 'default' smiley per the editor code. Added $txt['icon_edit'] because it is. (Subs-BBC.php, Class-Editor.php, index.language.php)

* Rewrote clean_cache to accept any kinds of extensions, instead of their 3 last characters. (Subs-Cache.php)

! clean_cache was broken when specifying extensions, as it used the wrong variable name. (Subs-Cache.php)

* Harmonized JS code for "Object.prototype.function = function ()". Oops, I mean 'spacinazi'. (editor.js, pm.js, post.js, suggest.js, topic.js)

* Moved the Delete button in File attachments to the left, for feng-shui reasons. Also fixed bevel in the button, although I have a feeling it'll break in Safari again... Also, did anyone notice that the input form button is never disabled, even when kindly asked to do so..? (post.js)

@ Note to Pete: maybe the file input should be hidden, as opposed to disabled....?

:edit: I updated Safari to v5.1, and the bug I mentioned is finally gone. So it's all good now... Only problem is, smileys don't show up in the editor :lol: Another bug I'll have to fix...

:edit: 2 - Postbox smileys are buggy in IE (all versions including 9), and Safari. They work well in Chrome, Firefox and Opera, the 'good guys'.
Title: Re: New revs
Post by: Nao on August 14th, 2011, 06:26 PM
rev 926
(26 files -1, 36kb) (........yet another big commit.)

* The 'more' button in smiley rows should now be on the right, and clicking it will show the new smileys through a slide animation. (Class-Editor.php)

* Now generating the smiley cache for each different different, allowing for IE6 to skip base64-encoded smileys. Also skipping the bigger smileys (>4KB), because we're only here to save bandwidth, not play with base64. (Subs-BBC.php, Subs-Cache.php)

! SMF bug (with no impact on code logic though): $smileyPregSearch is a string, not an array! (Subs-BBC.php)

* Renamed 'smiley_*' to 'smiley *' and thus moved smiley CSS logic to the main CSS file, in order to save some data (approx. 200 bytes after compression, by default.) (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)

* Reintroduced code to disable smiley resizing in Firefox... Unfortunately, it doesn't work. Tried TinyMCE, CKEditor and a few others -- same issue, so I guess Firefox is to blame. Bad Firefox, baaad! (Class-Editor.php)

! Fixed a last-minute bug that prevented Wysiwyg smileys from being converted correctly. (Class-Editor.php)

! Fixed editor to still load the CSS for smileys, even if parsesmileys() is never called on the page. What a load of code just for that... (Class-Editor.php)

* More silly JS code simplification. What can I do, I'm a sucker for micro-optimizations... (Class-Editor.php)

* Commented out a function that isn't used for now in the Zoomedia code. Will need to convert it, really... (Aeva-Subs-Vital.php)

* Renamed smfRegister to weRegister. (Profile.template.php, Register.template.php, Reminder.template.php, register.js)

- Removed profile.js, as it was a bit too short to be justified at this point. (Profile.template.php, Register.template.php, profile.js)

+ Added proper Wedge headers to all JS files that didn't have it. (admin.js, captcha.js, editor.js, fader.js, pm.js, post.js, register.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, zoomedia.js)

! Fixed smiley padding in Wysiwyg editor. (editor.css)

* Generic buttons should have a more generic background color, if you ask me. (index.css)

! More robust image replacement technique for smileys. (sections.css, index.ie6.css, index.ie7.css)

! Fixed bug with code tag fixer in Firefox. (theme.js)

* Spacinazi. (ManageMedia.template.php)
Title: Re: New revs
Post by: Nao on August 15th, 2011, 01:07 AM
rev 927
(6 files, 15kb)

+ All of the default smileys are now accessible in the post editor by default. Heck, aren't they worth it? No? (Class-Editor.php)

! In some situations, the smileys wouldn't show up in the post editor smiley box, because of an incorrect link tag. (Class-Editor.php)

! Some css cache filenames were incomplete because I forgot to update an integer after renaming the css folder. (Subs-Cache.php)

! Validation error. Since when can't inputs be put inside paragraph tags, already...? (Post.template.php)

* Updated file list, for whatever it's worth. We won't be using that file anyway. (xml/detailed-version.php)

! Did some tweaking on Warm and Wuthering skins to give them more personality, notably by changing the font. (Warm/index.css, Wuthering/index.css)
Title: Re: New revs
Post by: Nao on August 15th, 2011, 10:09 PM
rev 928 (this one was committed by Pete, who forgot to post it here........ :whistle:)
(7 files, ??kb)

! Move some of the member specific stuff (general options, plus signatures and profile fields) into their own entry in Members area, instead of under Features and Options. I gave the new settings their own file because ManageSettings is enormous - even now it's still 800 lines, as opposed to 2000. (Admin.php, Admin.template.php, Admin.english.php, ManageMemberOptions.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php)

rev 929 (this one is mine...)
(8 files, ??kb)

! Fixed Warm: background color for hidden sidebar and user menu, removed bullets, right-floated the avatar, and removed a couple of extra empty lines from the main menu. (Warm/index.css)

! Don't bother to base64-encode smileys if gzip is not supported by the browser, as it'll take too much space. (Subs-Cache.php)

! Ensure the Actions pretty URL filter doesn't cannibalize the Profiles filter by being run before it. (ManageSettings.php)

* Unencoded smiley URLs should be relative, not absolute. (Subs-Cache.php)

* Nanosecond optimization. (PrettyUrls-Filters.php, Subs-PrettyUrls.php)

* Terminology (temp?) fix. (Admin.language.php)

* Commenazi. (Post2.php)

rev 930
(2 files, 6kb)

* Translation. (Admin.french.php, ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on August 16th, 2011, 04:08 PM
rev 931
(32 files, 35kb) (most of it automated really. With a double-check.)

! Fixed right alignment of sidebar feed links in Warm. (Warm/index.css)

* Preventing horizontal overflow for code boxes. Need to find something better... (index.css)

* Renamed smc_* to we_* (or we* depending on the object), project-wide. You should now use weEditor, weAutoSuggest, weSaveEntities, weButtonBox, etc. (30 files, not listing them all.)
Title: Re: New revs
Post by: Nao on August 16th, 2011, 11:55 PM
rev 932
(39 files, 32kb -- did all of these manually... ouch >_<)

* Got rid of most display:none's and replaced them with the 'hide' class. (install.sql, Class-Editor.php, Aeva-Foxy.php, Subs.php, TEMPLATES: Admin, BoardIndexInfoCenter, Calendar, index, ManageMaintenance/Media/Membergroups/ ManageNews/Paid/Permissions/Smileys, Media, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Recent, Register, Reminder, Search, SplitTopics, Themes)

* Started converting smf_ to wedge_ or we_, or at least preparing the code for the change. Renamed smfSelectText to weSelectText. (install.sql, readme_convert.html, ssi-examples.php, upgrade.php, latest-news.php, Credits.php, ManageMedia.language.php, Who.language.php, ManageMedia.template.php, script.js)

- detailed-version.js was attempting to be included twice. Wedge didn't let that happen, but might as well not try in the first place, right...? (Admin.template.php)

- Removed smf_session_id fallback -- it's a leftover from SMF 1.0 (emphasis on the zero.) (sha1.js)

+ Although it's a hidden setting, disable_smf_js should be used consistently, including in the moderation center. I'm still leaving it out of the detailed version page, though... It would make sense not to use it there. (ModerationCenter.template.php)

@ Tomorrow: the smf_ automated update :P (Checked them all, the 700+ occurrences, should be good... Except for variables that will get reset.)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 10:38 AM
rev 933
(18 files, 18kb)

* More manual name conversions, this time from _smf to _wedge and smf_ to wedge_. (readme_convert.html, smfinfo.php, latest-packages.php, Admin.php, ManageServer.php, THEMES: Admin, ManageSmileys, ModerationCenter, Packages, Themes, LANGUAGES: Admin, ManageSettings)

- Removed utf8 parameter from the language file manager, considering all language files are now UTF8... (ManageServer.php, Admin.template.php, ManageSettings.language.php)

- SMF bug: removed unused string $txt['identification_by_smf']. (Login.language.php)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 11:01 AM
rev 934
(166 files, 100kb)

* Changed the SMF constant to WEDGE, in pretty much all files outside of the theme (automatic replacements, manually checked.) Also started converting regular SMF string to Wedge or whatever the context requires. (index.php, readm... hey, I said pretty much ALL the files, do you honestly think I'm going to list them all?!)
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 12:08 PM
Revision: 935
Author: arantor
Date: 11:04:44, 17 August 2011
Message:
! Don't allow edits of posts to have drafts; if you're editing a post, you can just resave it in situ instead, no need to keep saving drafts of it. (Post.php, Subs-Post.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on August 17th, 2011, 12:51 PM
rev 936
(68 files +1-3, 91kb)

! Forgot to convert a smf_sess. Also removed the last remaining smf_session_id, and removed a useless test. (Load.php, script.js)

- Removed a couple of outdated files and renamed smf_api to wedge_api (although I doubt we'll ever use it, just like most of the tools.) (wedge_api.php, add_settings-1x.php, boardmod.mod)

* Removed the 'Demo' version type (I don't think we're ever going to release a 'demo'?), renamed CVS version type to SVN, and removed a few CVS filename handling tests (who uses that nowadays?). (current-version.php, Class-DB.php, Subs-Package.php, Themes.php)

* Renamed smfLanguage* and smfUpdate* variables to we*. (tools, admin.js)

* Renamed smf_editorArray to weEditors. (script.js, etc.)

* Renamed smf_oCurrentResizeEditor to weCurrentResizeEditor, and smf_execCommand to we*. (editor.js)

* Renamed smf_openid_* and smf_openID_* to we_openID_*. (index.php, Login2.php, Profile.php, Profile-Modify.php, Register.php, ScheduledTasks.php, Security.php, Subs-OpenID.php)

* Changed Aeva's lookup user agent to something more browsery and with a proper URL for server admins to check. (Aeva-Embed.php)

* And finally, renamed SMF (uppercase) to Wedge wherever it was used to qualify the current software (i.e. not older versions, or proper credit.) (Dozens of files...)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 01:25 PM
rev 937
(31 files, 30kb)

* Renamed every single remaining smf_ reference to either we_ or we. Too. Tired. Won't. List. Files. (About 30)

- Removed unused $txt['cannot_connect_doc_site'] variable. (Errors.language.php)
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 02:28 PM
More admin panel stuff. Yes, the typo is there in the original log entry too :P


Revision: 938
Author: arantor
Date: 13:26:47, 17 August 2011
Message:
! Convert the 'Log Pruning' page into a more general 'Log Settings' page, and move a couple of items to it, for controlling the error log. (Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin and ManageSettinsg language files, old unit test)

! Template eval is now disabled by default. (install.sql)

! Default password strength is medium, not low, by default. Means 8 character password, no reusing username, instead of 4 character minimum. (install.sql)

! Made 'Registration' into 'Registration and Login' since some of the settings apply to both login and registration instead of some random area of the admin panel, and moved a couple of settings into it. (ManageRegistration.php, ManageSettings.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 03:29 PM
Revision: 939
Author: arantor
Date: 14:25:54, 17 August 2011
Message:
! Removal of the last vestiges of 'do not show contact details to guests, they're just not shown to guests now. (ManageSettings.php, Security.php, SendTopic.php, Help and ManageSettings language files)

! Custom fields now have an option for visible to guests (only when the field would otherwise be available to regular users), which means the profile fields that are used for things like AIM can be hidden from guests, which was the remaining thing controlled by the above setting. (install.sql, Load.php, ManageMemberOptions.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql

Posted: August 17th, 2011, 03:26 PM

Revision: 940
Author: arantor
Date: 14:29:30, 17 August 2011
Message:
! Admin / Members / Member Options had the wrong default function, should have used the first tab not the last. (ManageMemberOptions.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Title: Re: New revs
Post by: Nao on August 17th, 2011, 03:38 PM
rev 941
(12 files, 12kb)

- The Settings files shouldn't have a version number in them, as they're not intended to be upgraded later. (Settings.php, Settings_bak.php)

* A few more contextual changes from Simple Machines to Wedge. (*/readme.html, ManageServer.php, ModerationCenter.php, Themes.php, Admin.language.php)

* French translation. (Admin.french.php, ManageSettings.french.php)

! Warm's windowbg classes shouldn't really use alpha transparency, as the class is used in so many different places. Maybe I should introduce a postbg and postbg2 or something to account for topics, and have them based automatically on windowbg...? (Warm/index.css)

@ Pete: what was the typo you mentioned in 938...?
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 03:39 PM
Revision: 942
Author: arantor
Date: 14:37:15, 17 August 2011
Message:
! Oops, forgot to ensure that guest access to fields was applied in profiles as well. (Profile.php)
----
Modified : /trunk/Sources/Profile.php



@Nao, the typo in r938 is in the changelog itself:
Quote
(Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin and ManageSettinsg language files, old unit test)
Title: Re: New revs
Post by: Nao on August 17th, 2011, 04:34 PM
rev 943 -- OMG, it's like we're racing to the top! Love that!
(5 files, 10kb)

* French translation - new items and fixes. (ManageSettings.french.php, Help.french.php, Admin.french.php)

! $txt['allow_hideOnline'] makes an odd reference (in both languages) to 'non-administrators'. It should be 'allow to hide from non-admins', not 'allow non-admins to hide'. Removed non-admins altogether because it's pretty obvious that admins have all rights over their server. (ManageSettings.language.php)

* Converted the custom profile JavaScript to jQuery (looks like I forgot to complete that one long ago!) (Admin.template.php)

! If #mask was hidden in the custom profile field form, a linebreak would be shown in its place. (Admin.template.php)

@ Pete> I'm not sure it's semantically all right to use a theme menu string in a member menu... ^^; I won't fix it because I'm against giving too many strings to translate to users, but I doubt both menu entries would translate identically in all languages... Also, duly noted for the changelog typo. It's not like I'm never doing that myself :lol:
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 05:44 PM
Revision: 944
Author: arantor
Date: 16:43:53, 17 August 2011
Message:
! Wedge now requires MySQL 5.1.0 (install.php, tools/*, upgrade.php)
! Juggle some language strings around for later, as we prepare to phase others. (Admin.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/webinstall.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Arantor on August 17th, 2011, 07:14 PM
Revision: 945
Author: arantor
Date: 18:12:54, 17 August 2011
Message:
! Remove the moderator/admin entry from Core Features, instead the logs are now controlled from the main Log Settings page (Admin :: Server & Maintenance :: Logs :: Log Settings, trust me it is easier to find than you might think!), and are controlled individually rather than collectively. (Admin.php, ManageMembers.php, ManageSettings.php, ModerationCenter.php, Profile-Modify.php, Profile-View.php, Profile.php, Subs-Membergroups.php, Subs-Members.php, Subs.php, Help and ManageSettings language files)

! Make only moderate and admin log enabled by default, don't really need profile edits log by default, at least while it only logs 60% or so of the fields that can be changed. (install.sql)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql


Also note that the logAction function is now a bit faster if the relevant log is disabled, since the is-enabled check now happens before any other checks occur.
Title: Re: New revs
Post by: Nao on August 17th, 2011, 08:02 PM
rev 946
(9 files, 11kb)

* Simplified upgrade script DB version check. Why are we updating the upgrader already...? Fixed what's likely to be a SMF bug ($db['version'] being considered in command-line as the current version instead of target version). Also, shouldn't that extra version check codeblock be removed? (upgrade.php)

* Simplified install script. By two lines. We don't need to eval the thing, as we'll run it every time... (install.php)

! Version number fixes. (install.sql, readme_*.html)

- $database_version is no longer used. (create_backup.php)

* French translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Arantor on August 18th, 2011, 11:36 AM
Revision: 947
Author: arantor
Date: 10:35:52, 18 August 2011
Message:
! Removing one of the fixes I supplied for SMF 2: the load balancing dialog warning when on Windows. Instead, I just removed the entire page because if it's on Windows, it's absolutely useless and might as well not bother being shown. (Admin.php, ManageServer.php, ManageSettings language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Arantor on August 18th, 2011, 11:53 AM
Revision: 948
Author: arantor
Date: 10:53:20, 18 August 2011
Message:
! New area under Server Settings: Debugging. Moved all the debugging stuff out of Server Settings/General into it, plus hoovered up another option from elsewhere in the admin panel that even had the comment "This is sort of like debugging", especially as it isn't really a layout option! (Admin.php, ManageServer.php, ManageSettings.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Title: Re: New revs
Post by: Nao on August 18th, 2011, 03:07 PM
rev 949
(67 files, 57kb)

* More smf/simplemachines/etc. conversions... Did a lot of cleaning work, too, such as fixing the DTD headers, removing AeMe version checks and removing a couple of eggs I found while doing the changes. The end is in sight. NOT TOO SOON!! (about 64 files...)

* Nearly done with integrating the AeMe installer into Wedge's. (db_aeva.php, install.sql)

* Added a couple more allowed keywords to the spell-checker. 'Wedge' is proper English, but it's a multilingual checker. (Spellcheck.php)
Title: Re: New revs
Post by: Arantor on August 18th, 2011, 03:10 PM
Revision: 950
Author: arantor
Date: 14:07:48, 18 August 2011
Message:
! Reporting PMs to admins is now enabled permanently. (ManageSettings.php, PersonalMessage.php, PersonalMessage.template.php, Help and ManageSettings language files)
! Online/offline icon is no longer optional. Note that it's still hidden if you can't send the person concerned a PM, maybe we should fix that so it isn't simultaneously a link to PM that person. (ManageSettings.php, PersonalMessage.template.php, Display.template.php, Help and ManageSettings language files)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php

Posted: August 18th, 2011, 03:08 PM

Revision: 951
Author: arantor
Date: 14:10:02, 18 August 2011
Message:
! And, slightly ridiculously, the online enable option is actually specified in the installer as off, not sure why that's entirely necessary, but there you go. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on August 18th, 2011, 03:21 PM
Wow, we committed in the same minute! Did you get a conflict? :P

rev 952
(3 files -1, 7kb)

* Finished AeMe install integration. :) (db_aeva.php, install.php, install.sql)

* Translation. (Admin.french.php)
Title: Re: New revs
Post by: Arantor on August 19th, 2011, 10:59 PM
Revision: 953
Author: arantor
Date: 13:18:52, 19 August 2011
Message:
! Fixed installer doing very strange things like never actually getting past the DB settings stuff. (install.php)
----
Modified : /trunk/other/install.php


(Bah, meant to post this earlier.)
Title: Re: New revs
Post by: Nao on August 20th, 2011, 12:09 AM
rev 954
(26 files +1, 35kb)

+ Add a copy of the SMF2 license file to the root folder. (license_smf.txt)

* As far I know, the name conversions are now FINISHED... Oh my. Except for the smfinfo.php file, but I don't even think we'll be distributed that one. (other/*)

* Just tweaking install to my liking... No surprise to anyone. (install.php)

* Renamed some sm* vars to we*. (JSEditor.php, QuoteFast.php, editor.js)

! Fixed menu backgrounds not showing up in IE. (index.css)

! Fixed screwed up quick buttons in IE8. (index.ie8.css)
Title: Re: New revs
Post by: Nao on August 20th, 2011, 12:30 AM
rev 955
(7 files, 12kb)

* Replaced $amSettings['disable_feed'] with its opposite, $modSettings['xmlnews_enabled']. While it's nice to know you can remove feed links from your media pages and still have them work, I doubt there's any good reason for doing so... (install.sql, ManageMedia.php, ManageMedia.language.php, Media.template.php)

* Spacinazi and version numbers change. (SSI.php, ssi_examples.php)
Title: Re: New revs
Post by: Nao on August 20th, 2011, 09:50 AM
rev 956
(1 file, 3kb)

! Typo in one of the disable_feed replacements. Note for later: have someone actually actively look for issues in our commits, especially late at night, so that we don't have to do it in the morning :P (Media.template.php)
Title: Re: New revs
Post by: Nao on August 20th, 2011, 02:08 PM
rev 957
(1 file, 5kb)

! Although newer Firefox versions seem to force resizing handles on smileys in Wysiwyg mode, we can *at least* convert these back to real smileys when saving, regardless of whatever dimensions are forced in. (Class-Editor.php)

@ Note: this doesn't seem to happen in SMF, so it was a bug in my earlier smiley rewrite.
Title: Re: New revs
Post by: Nao on August 20th, 2011, 05:53 PM
rev 958
(7 files, 12kb)

* Painstakingly rewrote the skin list function (in the Profile area) to fix a logic flaw. Add-type skins are now listed relative to their parent skin, and replace-type skins are listed on the top level, just like the root skin. (Themes.php, Themes.template.php)

* Tweaked language files to make a clearer statement about choosing the default skin when you choose a theme rather than a specific skin. (Themes.language.php)

- The skin list function was still avoiding the 'cache' folder, which was a remnant from the original skin system implementation... (Themes.php)

* Moved the menu toggler to the left of the menu -- where it makes a lot more sense having... (index.css, index.rtl.css)

* Number of theme users now uses number_context. (Themes.template.php, Themes.language.php)

* May not be necessary at all, but I ensured eAccelerator and other cache systems aren't detected if their 'put' function is detected but not callable. Consider it an extra safety. (ManageServer.php)

@ Minor issue with skins (as seen above): if the admin sets the guest skin (i.e. the default) to something else than the root skin, the thumbnail will still show the root skin. May have to change that, but there is only one default skin per website and there may be multiple themes... Dunno what's best. Any ideas...?
Title: Re: New revs
Post by: Nao on August 21st, 2011, 12:09 AM
rev 959
(4 files, 8kb)

* Tweaked theme selector to be a bit more user-friendly. The currently selected theme is now indicated as such ('Current theme'). The currently selected skin also gets its own class (should probably use a caption like for the theme), and doesn't show the Pick links. Child skins also get more left padding, to emphasize their nature as a child, and their thumbnails are resized to ensure they don't use up too much vertical space. (Themes.template.php, index.css)

* Commenazi. (latest-themes.php, Themes.php)
Title: Re: New revs
Post by: Nao on August 21st, 2011, 04:51 PM
rev 960
(7 files, 10kb)

* Changed some of the skin values to be set to an empty string by default, meaning it should use the theme's default skin, rather than always the theme's root skin. It's too hot in here to overthink it. (install.sql, Themes.php)

* Micro-optimization and translation tweak. (Admin.php, Themes.french.php)

! When picking a default theme for guests with the theme picker, the pick page was set as being from the profile area, rather than admin area. (Subs.php)

! Background issues on Warm menu in sucky browsers, including Safari Mobile. (Warm/index.css)

* Tweaked font size in main menu to help usability on iOS. (index.iphone.css)
Title: Re: New revs
Post by: Arantor on August 22nd, 2011, 01:35 PM
Revision: 961
Author: arantor
Date: 12:35:04, 22 August 2011
Message:
! If there's no menu item explicitly selected but we're in a place where we probably should have one because we subsections and we should highlight the first subsection, select it. (Subs-Menu.php)
----
Modified : /trunk/Sources/Subs-Menu.php
Title: Re: New revs
Post by: Nao on August 24th, 2011, 08:00 PM
rev 962 --- multipart commit.
(5 files, 12kb)

* Rewrote constructPageIndex() to be tighter -- smaller and better HTML, CSS and JavaScript. As a bonus, pretty URLs are also correctly rewritten in the process, hopefully without exceptions. (Subs.php, script.js, index.css)

* Started work on simplifying theme/skin combinations. id_theme=0 should have skin='' (meaning it's taken from theme_skin_guests), and skin='' on other id_themes means the root (skins folder). (Load.php)

* Although it technically works, it doesn't make sense to set the cursor type on 'a:hover', it should instead be directly on 'a'. (index.css)

! SMF bug: session errors when using new PHP5 feature that allows to set more hash bits for the valid session characters. Thanks live627 for the report and rawlogic for the ready-made fix! (wedge_api.php, Load.php)
Title: Re: New revs
Post by: Nao on August 24th, 2011, 08:07 PM
rev 963 --- the last part of the commit will take more time...
(13 files, 12kb)

* Tweaked member list to be more welcoming (more padding) and use less HTML (bandwidth nazi.) (Memberlist.template.php)

! Setting css('display', '') on an item doesn't work when its display is hidden through a class (like the hide class). I knew that, but I'd forgotten to fix that in a couple of instances. Modders, use toggle() instead, it's cooler anyway. (editor.js, topic.js)

! Help entry typo for pretty URLs. (Admin.language.php)

* Some breathing space for the main menu in iOS. (index.iphone.css)

* The usual code cleanup. (upgrade.php, ManageBoards.php, ManagePermissions.php, Subs-List.php, index.template.php, Login.template.php)

- We don't really need that 'skins' variable in the themes table... Also tweaked another 'skins' entry. (install.sql, ManageBoards.php)
Title: Re: New revs
Post by: Nao on August 24th, 2011, 10:50 PM
rev 964
(2 files, 6kb)

! Allow URLs with $ and % in them to be turned into pretty URLs, e.g. page index templates using a flexible start shortcut (board=1.0). (PrettyUrls-Filters.php)

* More 'skins' fixes. (Themes.php)
Title: Re: New revs
Post by: Nao on August 25th, 2011, 12:58 AM
rev 965
(1 file, 6kb)

- Cleaned up the pretty topic creation code, removing all code pertaining to finding duplicates in the database. Since Wedge only bothers with the topic ID, duplicate topic titles aren't a problem. (PrettyUrls-Filters.php)

* Did some performance tests on PURL transforms, and figured out that word boundaries don't impact it, unlike what I thought. So I'm now using them to ensure strange URLs like "action=mymod;deleteboard=1" won't get prettified by mistake. (PrettyUrls-Filters.php)

! Hopefully, fixed the last issue with PURLs in page index code. (PrettyUrls-Filters.php, again.)
Title: Re: New revs
Post by: Nao on August 25th, 2011, 07:44 PM
rev 966
(7 files, 18kb)

* Another Credit page overhaul. It's a work in progress, so it'll be finished later.

+ Added a 'website credits' section to list Administrators and Global Moderators, so that the page can actually live up to its 'Website credits' status. (Credits.php, Who.language.php, Who.template.php)

- Removed a few things, such as unused credit areas and the 'general' thank you message to beta testers and translators... Okay, if they're doing a priceless job, then they need to be thanked by name, don't they? Plus, translators get to credit themselves anyway... (Credits.php, Who.language.php, Who.template.php)

+ Added credits for FamFamFam Silk icons and Diagona, and removed them from the AeMe area. Other AeMe items will come later. (Credits.php, ManageMedia.php)

! Added special authorization for img tags to hold action=media items. Unsure whether I should specify the sub-actions that actually perform the downloading or showing of an item... (Subs-BBC.php)

* Tweaked credit page visuals. (sections.css, Who.template.php)

@ Pete, I made a dirty query to get the website team list, but maybe it's stored somewhere in a special variable or something...? Or maybe there's a faster way of retrieving these?
Title: Re: New revs
Post by: Nao on August 26th, 2011, 12:20 AM
rev 967
(8 files, 13kb)

* More credit page fine-tuning. Still upset that the extra white space in the English version. Added a couple of special thanks. Added link to our online license. Removed unused text strings. Replaced we:titles with we:blocks. Also added Ante's real name in the credits. It's credited in plain view at http://www.lewisonline.ca/?p=426 after all... (Credits.php, Who.english.php)

* Removed third-party tool credits from AeMe and moved them to the main credit page. (Credits.php, ManageMedia.php, ManageMedia.language.php, Who.language.php, ManageMedia.template.php, Who.template.php)
Title: Re: New revs
Post by: Nao on August 26th, 2011, 04:45 PM
rev 968
(5 files, 7kb)

* Hopefully finished implementing the 'theme_skin_guests' rewrite. Why do these things always have to be complicated...? Will require some thorough testing of the admin settings with a default install and an imported SMF install set with a default guest skin different from the root skin. (Subs-Boards.php, Subs-Cache.php, ManageBoards.template.php)

* The 'replace' type in the skins.xml file can be uppercase if you want. It's not going to kill performance anyway... (Subs-Cache.php)

* Fixed a couple of rtl.css occurrences to index.rtl.css. Hmm, what exactly does that copy function in Themes.php do...? Does it mean we have to copy all of the index.*.css files? I smell trouble! :P (Class-CSS.php, Themes.php)
Title: Re: New revs
Post by: Nao on August 28th, 2011, 11:47 PM
rev 969
(8 files, 11kb)

* Simplified copyright text and handling. (smfinfo.php, Credits.php, Subs.php, index.template.php, index.language.php, Printpage.template.php, Reports.template.php)
Title: Re: New revs
Post by: Arantor on August 30th, 2011, 12:03 AM
Revision: 970
Author: arantor
Date: 23:02:38, 29 August 2011
Message:
! theme_skin_guests will not probably be not defined during the installer, so instead of relying on $modSettings having the value, use the default value as a fallback. (Subs-Cache.php)

! Credits page should use the correct language string for its title. (Credits.php)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Subs-Cache.php

@ I like the way copyright is now implemented. :)
Title: Re: New revs
Post by: Arantor on August 30th, 2011, 12:14 AM
Revision: 971
Author: arantor
Date: 23:13:47, 29 August 2011
Message:
! Removal of the 'number of people in memberlist' option. I've never seen anyone change the default, but if someone really wants to, it's still in the database as a setting so it can be tweaked with a mod if necessary. (In theory it could be removed from the DB, simply because it is pre-initialised to default otherwise) (ManageSettings.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Arantor on August 30th, 2011, 12:40 AM
Revision: 972
Author: arantor
Date: 23:39:55, 29 August 2011
Message:
! Removed the 'disable administration security' user interface option. The internal setting has been preserved so it's not like it can't be set relatively easily with phpMyAdmin if needed. While this may be a slight inconvenience to long-experienced users who create test sites, for the majority of users it's one thing they can't accidentally shoot themselves in the foot with. (ManageSettings.php, Login.template.php, Help and ManageSettings language files)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on August 30th, 2011, 09:45 PM
rev 973 (everything I did while playing Xenoblade this week :P)
(12 files +1, 21kb)

! The smiley cache was always regenerated on each call, because of a last-minute change in parameter order. (Subs-BBC.php, Subs-Cache.php)

* Reprocessed copyright comments in JavaScript files to only cache the bare minimum, i.e. @copyright stuff, and avoid showing the version number and issue date. (Subs-Cache.php)

* The cache folder's htaccess should specify a Vary-Encoding header to make Page Speed happy and help with proxy caching or whatever. (cache/.htaccess)

* Shaved a few extra bytes off the main script file's cached version. I also sacrificed my plain view credit for the menu code for the good cause. It's still in the uncached version though, it's my thing, took me years to finetune it, nearly drove me crazy, I want the whole world to know that stupid script is mine. And that includes you, reading the changelog. (script.js, theme.js)

! Reverted rev 972's removal of the securityDisable_why text string, as it's unrelated to the availability of securityDisable itself. (Login.template.php, Help.language.php)

! Syntax error in PM template. Not sure where this one came from... (PersonalMessage.template.php)

* Tweaked current date's margin and we:block styling. (index.template.php, index.css)

* Spacinazi. (ManageBoards.php)
Title: Re: New revs
Post by: Nao on August 31st, 2011, 11:21 PM
rev 974
(4 files, 9kb)

* We're using jQuery for on* events, so the spoiler tag code could be simplified... (install.sql)

* Being bold, and disabling in-context video embedding by default. Will probably change my mind once we get lots of support requests... :P (install.sql)

- Removed copyright year from Settings.php. (Settings.php)

* There are only 4 valid metacharacters in a character class, so I figured I might as well clean up all of the useless escaping in the embedding code. (Aeva-Embed.php, Subs-Aeva-Sites.php)

! Fixed in-context video embedding. It seemed like center tags and similar were broken in this mode, so I decided to be a bit nicer and allow for most tags instead. (Aeva-Embed.php)

@ Pete and anyone else: I don't think it's very robust though, and should probably switch to an even nicer version where embedding is only disabled if the URL follows a space or some common punctuation like parenthesis. I'm starting to think it's best to make things simple here, and the whitespace/punctuation solution would be the way to go.
Title: Re: New revs
Post by: Nao on September 1st, 2011, 11:14 PM
rev 975
(2 files, 6kb)

! Fixed this annoying bug where Wedge wouldn't take non-numeric start variables into account when viewing a topic page. This was due to a conflict between board start and topic start, given that topic pages now also define $_REQUEST['board']. (QueryString.php)

- Removed support for .htm extensions in URLs -- don't remember ever seeing these used in SMF, probably a YaBB SE leftover. Keeping index.php/stuff URLs for compatibility with published URLs only. (QueryString.php)

! Parsing of hypothetical URLs like /do/viewjpeg (any pretty URL ending with 'jpeg') could have failed. (QueryString.php)

* Micro-optimization in loadSource(). (Load.php)
Title: Re: New revs
Post by: Nao on September 3rd, 2011, 11:34 AM
rev 976
(3 files, 12kb)

* If there is ONE single place in Wedge where micro-optimizations are going to make a difference, it's parse_bbc(). So that's what I did -- turned == into === where it made sense, cached strlen() when used several times, turned substr($str, $pos, 1) into $str[$pos], and so on... Probably only saves a couple of percents in the end, but guys, this is parse_bbc(). (Subs-BBC.php)

! Left and right bbc tags weren't using the proper classes. (install.sql)

* Curlynazi. (Display.php)
Posted: September 3rd, 2011, 11:06 AM

rev 977
(1 file, 1 line) <-- Now I'll try to just say the number of changed lines when there aren't more than a few...

! Oops. (Subs-BBC.php)
Title: Re: New revs
Post by: Nao on September 3rd, 2011, 04:17 PM
rev 978
(11 files, 13kb)

! Locked sticky topics would only show their status as locked. (MessageIndex.template.php, Recent.template.php)

! Another oops. Someone has to tell me why PHP won't let me do that, though... (Subs-BBC.php)

- Removed 'image' parameter from all button strips, as they're remnants of SMF 1.x themes and aren't used for now. Also removed 'lang', as it can easily be achieved via CSS and the $language variable. Note: calendarpe.gif still exists in the SVN, not used anywhere though. (MessageIndex.php, TEMPLATES: BoardIndex, Calendar, Display, Media, Memberlist, PersonalMessage, Recent, Reports)
Title: Re: New revs
Post by: Nao on September 4th, 2011, 08:22 PM
rev 979
(15 files, 20kb)

* Rewrote the skin selector to move it from an obscure profile page to the main menu's profile area. Introduced a 'skin' action in the process, and defaulted to the current user if no 'u' variable is set. (index.php, Profile-Modify.php, Profile.php, Subs.php, Themes.php, Profile.language.php, Themes.language.php, Profile.template.php, Themes.template.php)

* Renamed the 'theme' profile page to 'options', which probably makes more sense. Added a couple of workarounds for custom fields that were set to be in 'theme'. I'd rather we deal with these in the import tool, though... (ManageMemberOptions.php, Profile-Modify.php, Profile.php, Admin.template.php)

+ Added commented out language strings for Ignore Topics in the English version. Yes, I know it's not implemented yet... But it was already in the French version and I'd rather we implement that before 1.0 Gold... (Profile.language.php)
Posted: September 4th, 2011, 08:21 PM

rev 980
(5 files, 8kb)

! Fixed a minor bug with profile user IDs, introduced over 500 commits ago... Oops? Also avoided setting $_REQUEST early on, when it's going to be set in a batch a few lines later... (QueryString.php)

* Shortened declarations for the mandatory JS variables (we_default_theme_url, ajax_notification_*), because we can. Also optimized parent.clientWidth (called 3 times in the menu code) into a local var. (index.template.php, script.js)

! Safari Mobile for iOS didn't correctly position smileys. (index.iphone.css)

! Menu positioning issue in Wuthering skin. (Wuthering/index.css)
Title: Re: New revs
Post by: Nao on September 5th, 2011, 08:33 PM
rev 981 -- this freaking commit took me a week of work!! Just for one feature nobody uses :(
(2 files, 20kb)

* Rewrote the 'Enable embedding in sentences' feature for Aeva, because it really wasn't solid enough. Since the new method is a tad slower, I've optimized the embedding process to compensate. See below. (Aeva-Embed.php)

    ! Local site checks were being done for all sites, and on each parse_bbc() call. Waste of time...

    ! A lot of code was being tested regardless of case. URLs should be case-sensitive, including the protocol, so don't bother with it. Come to me if you're experiencing trouble with special URLs. Also, parsed links should be on a single line, no need for the 's' modifier. Note for later: add support for local embedding on the https protocol...?

    * Updated SWFObject version to 2.2... Yes, I know, if it ain't broke don't fix it. Also converted the JS embed code to postponed jQyery, saving us an extra buffer replacement operation (these are really expensive.)

    ! The express installer setting was inverted from the start. No one ever complained about it though, so it's probably not even worth using that...

    ! Don't force a font family on titles below videos. Only a font size.

    ! Oops, a count() was used in a for() loop...

    - Removed an extra strlen() test that was already pretty much done, and a http:// conversion that probably shouldn't even happen in the first place...

    * Merged the two aeva_protect_recursive*() functions together.

    * Don't call aeva_parse_bbc2() if no link was found. (also Subs-BBC.php)

PS: I re-numbered the 3 previous revisions. I had an extra 977 which was really 978 :P Sorry Pete!
Title: Re: New revs
Post by: Nao on September 5th, 2011, 09:40 PM
rev 982
(7 files, 17kb)

* Updated copyright header. (Aeva-Sites-Custom-Example.php)

* Simplified dozens of Aeva site list entries, mostly removed unused non-capturing groups. Gosh, I'm sure 90% of these sites are dead or changed their embed code, or are just completely ignored anyway... (Subs-Aeva-Sites.php)

! Streetfire embedding was broken. Well, maybe it still is, I haven't tested. But at least the regex is no longer broken. (Subs-Aeva-Sites.php)

* It's site list, not sitelist. (Admin.english.php)

! SMF bug? In the error log, sessions were output as such, without any 'Session' text. Even I wasn't sure what these characters were about... (Errors.template.php)

- Too much styling is too much. Removed dotted line between options in admin media settings. (Media.template.php)

- Too much styling is me going crazy. Got rid of button list's custom font. Ever since mini-menus were introduced, post button font became a moot point anyway. (sections.css)

- Removed today (US Labor day) from calendar_holidays. (install.sql)
Title: Re: New revs
Post by: Nao on September 6th, 2011, 12:24 PM
rev 983
(7 files, 12kb)

* Given that it makes more sense (to me) to use the Go Up and Go Down button to go to the actual beginning and end of a page, rewrote these links to actually do it, with a nice little animation. Thank you jQuery. (Display.template.php)

* Rewrote topic index and unread posts to link topics to the new posts, just like the New icon does. Of course, if a topic has no new posts, it'll link to its start page as usual. (MessageIndex.template.php, Recent.template.php)

* Renamed css_generic_files to css_suffixes for logical reasons. (install.php, Class-CSS.php, Load.php, Subs-Cache.php)

@ Note: re: up/down, I've read that doing an animation on $('html, body') wasn't a good idea because it did it twice in Opera. It works perfectly in Opera 12 so I decided not to bother... Opera users are early adopters so even if earlier versions had a problem, I'd rather not complicate the code. I've also read that animating $(window) would work, but not for me when I tested.
Title: Re: New revs
Post by: Nao on September 6th, 2011, 07:42 PM
rev 984
(2 files, 5kb)

* Small extra jQuery conversion. (ManageServer.php)

! Syntax error. (Aeva-Embed.php)

(It's not much, but I modified many files for the templating stuff and I'm trying to keep the 'other' files out of my way...)
Title: Re: New revs
Post by: Arantor on September 8th, 2011, 12:23 PM
Revision: 985
Author: arantor
Date: 11:22:43, 08 September 2011
Message:
! Allow the richedit component to style individual buttons if they so desire, not just the post button. (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php


@ Something out of WedgeDesk, really. Where we're styling buttons in various places, I have a richedit control that has both a save and a delete button, and wanted to style the delete button like all the others. Really not a big thing but something I wanted to do :)
Title: Re: New revs
Post by: Nao on September 8th, 2011, 04:07 PM
(Another 'cleaning up my local install' commit...)

rev 986
(7 files, 10kb)

! Not sure where (I'm busy!), but it looks like the editor class may be called at different points in time during rendering, making it necessary to use $context['header'] as well. Also micro-optimizations. (Class-Editor.php)

! Fixed syntax error in a comment... Well, it does suggest to uncomment it after all. (ssi_examples.php)

! A few lines of code needed to be turned into loadSubTemplate(). (unittest/index.php)

! Just because the theme hasn't finished loading doesn't mean the text strings aren't already loaded... Well, at least I met such a case during testing. (Errors.php)

* Commenazi and other boring changes. (ManageSmileys.php, Reports.php, index.english.php)
Title: Re: New revs
Post by: Nao on September 9th, 2011, 12:55 AM
rev 987 (the big layer rewrite.)
(27 files, 77kb 8-))

+ Rewrote the template layer/subtemplate system from scratch and implemented a new 'skeleton' system, where the theme defines the desired layer/subtemplate structure with pseudo-HTML, and skins can freely change the order of the blocks. Layer functions are no longer mandatory, as layers can now be used simply as easy ways to keep multiple subtemplates in the same place. (Load.php, Subs-Cache.php)

+ Added loadLayer() function, which handles adding layers to the skeleton. Two positioning options are allowed for now (parent and child), but more will come in time. I'm also listing various files affected by layer changes. (Load.php, ManageAttachments.php, ManageMedia.php, ManageMedia3.php, PersonalMessage.php, Profile.php, Security.php, SSI.php, ManageAttachments.template.php, Profile.template.php)

* As a note; the main layer is now next to the top layer, when it used to be the top layer's parent. A new layer was added on top of them, anyway. (Subs.php)

* Rewrote hideChrome() to the new system. Its parameter now accepts three variations: empty means that the template will handle everything, from HTML headers to content. 'html' means that we only want the HTML headers, the body tag and the content. Specifying another string will behave like 'html' but will add an extra layer right before the content. (Subs.php, unittest/index.php, Aeva-Gallery.php, ManageBans.php)

* Split the wedge_cache_css() function into two different functions, so that skin options can be retrieved early on, and actually CSS caching is still performed at the last minute. May actually be a bit faster, because Wedge will no longer try to load parent CSS when a child is a replace-type skin. (Subs-Cache.php)

* Changed the Warm layout through a skeleton override, to allow for the sidebar to be shown on the left side of the screen, rather than to the left side of the content area (below the header). (Warm/skin.xml, Warm/index.css)

* Always define WIRELESS_PROTOCOL to wap2 when WIRELESS is defined, because it's the only one we have. Unless we start implementing support for iMode again (ah ah), I'd suggest we rename all of these subtemplates to get rid of the prefix... (index.php)

- Deleted the theme_layers feature because, you guessed it, it's useless now we have the skeleton code. (upgrade.sql, JSOption.php, Load.php, Subs-Members.php, Themes.php)

* Saved a few bytes off the noi_resize() function. Does it look like I'm obfuscating it? (index.template.php)

! Syntax error. Another one of the 'last minute commits'. (Class-Editor.php)

! $modSettings wasn't globaled in a function, causing OpenID to always fail. (index.template.php)

! Media upload page wouldn't validate, because an <input file> had a size parameter, which is no longer valid in HTML5. (Media.template.php)

* Shortened the PHP code in files when using the filesystem cache. It only saves a few bytes, but I see no reason to waste these bytes when you're never going to read them. Also no longer calling die() when WEDGE is not defined: it just won't load the cached data. (Subs-Cache.php)

* Renamed theme_linktree() to template_linktree(), and on the contrary, template_header() to start_output(), and removed template_footer(), because we really should avoid using template_* for anything other than an actual template function, and theme_* for anything that is a real subtemplate. (SSI.php, Subs.php, Xml.template.php)

* Split start_output() into two functions. The first initializes the output as expected, and the second is called if we're going through the top layer rendering process, instead of the previous method (done when iterating the _above list). This is totally untested, unlike the rest of this huge commit. It'll probably be the first thing to break. Used the opportunity to add import.php to the list of security files. (Subs.php)
Title: Re: New revs
Post by: Nao on September 9th, 2011, 10:15 AM
Lol, I just realized that the post number (the thing next to the post date) is exactly the rev number, off by one... It wouldn't even be off by one if I hadn't recently merged two small commit changelogs together :P

So I'm posting this totally unrelated post to make them match exactly... :niark:
Title: Re: New revs
Post by: Nao on September 9th, 2011, 10:15 AM
rev 988
(12 files, ??kb -- not too big)

* Renamed template blocks to 'macros', i.e. from a generic term to a description of what they can actually do. (Load.php, Subs-Cache.php, Subs.php, index.template.php)

* If the quick reply box is collapsed by default, increase its textarea height to 150px. Because we can. (Display.php)

* Cleaned up a bit of the quick reply area: got rid of the empty anchor and moved it to the quickreplybox div (now renamed quickreply), shortened a few of the other IDs, removed a useless div... (Display.template.php, Media.template.php, index.ie6.css, sections.css, Warm/index.css)

* Tweaked and improved category title fonts. Or more specifically, removed the tweak that was only for the quick reply bar, and moved it over there. (index.css, Warm/index.css)

! Fixed a stupid bug where topic pages wouldn't display at all... Hmm, not exactly smart of me to name both the main layer and main sub-templates 'main', but it works for now... Until I get to improve this. (index.template.php, Warm/skin.xml)
Title: Re: New revs
Post by: Nao on September 9th, 2011, 11:25 AM
rev 989
(13 files, 15kb)

+ Added a semantic definition feature for skeletons. When defining a layer, you can specify a layer type next to it (position on the page, navigation role...), for instance <layer:side,left,top> means that this layer wants to receive data sent to ':side' (the main sidebar), ':left' (the left of the page) and ':top' (top of the page). Have a seen a greedier layer in your life? I haven't. Should I apply the same system to sub-templates? (Load.php, index.template.php, Warm/skin.xml)

* Turned 'sidebar' and 'top' into array(':side', 'sidebar') and array(':top', 'top') in loadSubTemplates calls. And no, you don't have to do the same, it's just that I'm trying to give a good example. (index.php, Admin.php, Calendar.php, Display.php, Aeva-Gallery.php, MessageIndex.php, Profile.php, Subs-Menu.php, Unread.php, UnreadReplies.php)
Title: Re: New revs
Post by: Nao on September 9th, 2011, 04:34 PM
rev 990
(22 files, 19kb)

* Took a chance and replaced all sSessionVar/sSessionId variables from the JS code with globals. Considering that just like in SMF, the session ID is already on every page (because of the header toggler), it won't make a difference security-wise, it'll just be shorter. Less bandwidth use means more love. (BoardIndex.php, Class-Editor.php, ManageMedia2.php, TEMPLATES: BoardIndex, Display, index, ManageBans, ManageBoards, ManageMaintenance, ManageMembergroups, ManageNews, ManagePaid, ManagePermissions, MessageIndex, PersonalMessage, Profile, SCRIPTS: editor, pm, post, script, suggest, topic)
Title: Re: New revs
Post by: Nao on September 9th, 2011, 11:06 PM
rev 991
(22 files +2, 28kb)

- Removed entities_convert option from Media area, and related code. We're UTF-only now, why would we use entities? (install.sql, Aeva-Subs-Vital.php, ManageMedia.php, ManageMedia.language.php, Media.language.php)

* Renamed aeva_utf2entities() function to aeva_string(), because even though we no longer convert entities, it still does some good things. For now. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php)

! Fixed 'unlinks' in message index and unread posts/replies. (MessageIndex.php, Unread.php, UnreadReplies.php, MessageIndex.template.php, Recent.template.php)

! Fixed message index always showing page 1 in pretty URL mode. (QueryString.php)

! Security file checks would show error messages twice. (Subs.php)

! Event delayer was incorrectly removed if empty (e.g. board index). (Subs.php)

! SMF bug: incorrect link in 'href' member of the topic array. (Unread.php, UnreadReplies.php)

! Long URLs would break the layout in the error log... Cut these strings after 80 chars. Maybe I should simply insert a soft hyphen... (Errors.template.php)

+ Added IE9 and IE10 workarounds to the Warm skin. With a funny story in the IE9 one... (Warm/index.ie9.css, Warm/index.ie10.css)

* Micro-optimizations. (ManageMaintenance.php, Subs-Members.php, Subs-Post.php, Subs-PrettyUrls.php)
Title: Re: New revs
Post by: Nao on September 10th, 2011, 06:41 PM
rev 992
(1 file, 8kb)

+ Implemented new possible positions for loadLayer(): 'before', 'after', 'replace', 'erase', 'firstchild' and 'lastchild'. Manipulating arrays through references is fun, I need to do that more often. Check out the comments in the source code for more details. (Load.php)
Title: Re: New revs
Post by: Nao on September 11th, 2011, 05:21 PM
rev 993
(93 files, how amusing -- 89kb)

* Renamed sub-templates to blocks, and all associated variables etc. Updated related documentation and comments. (93 files, not listing them all!)

- Removed a comment that looked like a failed keystroke, or a work in progress that got forgotten in the process. Since it's security related, I felt I should mention it... (Security.php)
Title: Re: New revs
Post by: Nao on September 12th, 2011, 12:18 AM
rev 994
(1 file, 9kb)

* Rewrote loadBlock() to allow for different options, not unlike loadLayer(): 'replace' (the original default), 'add' (what used to be the $overwrite parameter), and 'first' (insert at the beginning.) It doesn't take child layers into account yet, as I have yet to decide how I'll handle them. Maybe I should prevent adding blocks to a layer that has child layers... (Load.php)

@ Note: I actually wrote the code to handle replacing blocks in layers that hold a child layer, but it's pretty f*cked up that way... I think I need to sleep on it.
Title: Re: New revs
Post by: Nao on September 12th, 2011, 10:26 PM
rev 995
(6 files, 15kb)

+ Added proper support for 'replace' in loadBlock(). It's easy enough when a layer only has blocks in it, so the hard part was to keep layers in while deleting the rest. If you want to delete layers as well, just use the new 'erase' parameter instead. It will cancel the rescue mission for layers. (Load.php)

* Updated all loadBlock() calls that provided a boolean parameter, and replaced them with the 'add' param instead. (index.php, Aeva-Gallery.php, Subs-Menu.php)

* Updated documentation on blocks and added a 'left' hint to the Warm and Wine sidebars. (index.template.php, Warm/skin.xml)

* Ensured mods can't replace sidebar elements by mistake. Well, they can still delete the sidebar entirely, but then they know they're doing it wrong. (Load.php)

! Fixed support for multiple hints in skeleton. (Load.php)
Title: Re: New revs
Post by: Nao on September 12th, 2011, 10:47 PM
rev 996
(1 file, 8kb)

+ Added support for 'before' and 'after' in loadBlock(). That one was quick... It's because I just recycled code eheh. loadBlock('block', 'menu', 'after') will add a block called 'block' right after the main menu block. I'm not sure it's great to be able to specify a target block (instead of just a layer), but I'll think about it. (Load.php)
Title: Re: New revs
Post by: Nao on September 15th, 2011, 01:20 AM
rev 997
(6 files, 18kb)

! Fixed broken Wireless and XML handling. Basically, their skeletons were erased before it was even created, so Wedge was using default settings for them anyway. Also fixes an SMF bug, where a lot of init code was executed even when templating was already disabled or overridden. (Load.php, Subs.php)

* Renamed the 'main' layer to 'context', to avoid confusing it with the 'main' block. (Load.php, Profile.php, Security.php, Subs.php, index.template.php, Warm/skin.xml)

* Added a few safeguards and fallbacks for the skeleton handling code. Not that it was needed, again, but in some situations it avoids obscure error messages at virtually no cost. (Load.php, Subs.php)

! loadBlock(...'erase') should regenerate the layer list, because it might delete layers without even checking. (Load.php)

! Fixed hideChrome() to always insert a dummy layer at the top when resetting the skeleton array. This makes it possible to add layers before and after the only remaining one. If that's ever needed. (Subs.php)

* Reworked build_skeleton_indexes() to avoid having to use a parameter. Also pestering about the uselessness of array_walk_recursive(). (Load.php, Subs.php)

! skeleton_insert_layer() had an extra parameter that was forgotten from a prior commit, and would make the process fail. Also admitted failure when it comes to the layer update. Although in most cases a rebuild isn't needed, I've found a few places where it is. Rebuilding is thus a tad slower, but more robust. (Load.php)
Title: Re: New revs
Post by: Nao on September 15th, 2011, 02:13 PM
rev 998
(2 files, 7kb)

* Moved the PM draft saving code up in the code path, so that it doesn't waste time initializing the PM template and menus. The Subs-Menu change is not needed, but I'd like to see if it generates errors in the log. Let's call it an experiment. (PersonalMessage.php, Subs-Menu.php)

! The page index for PM drafts had an incorrect URL (area instead of sa). (PersonalMessage.php)

+ Started added placeholders for menu notices. Or warnings. Or notifications. Or whatever. (PersonalMessage.php)

@ Note: I'm starting a series of a few short commits because I changed files in various areas and I'm still trying to keep these in a logical order.
Title: Re: New revs
Post by: Nao on September 15th, 2011, 02:15 PM
rev Galaxy Express 999
(5 files, 8kb)

- No need for loadBlock('main')... Uh. That one wasn't in SMF, I don't know where it came from really. (Calendar.php)

! Was a bit too quick to remove $hard_limit from aeva_string() when it's actually used in westr::cut()... (Aeva-Subs-Vital.php)

! Fixed a CSS error generated by the menu JavaScript when hovering a top-level item in non-main menus. (script.js)

! French translation used the third person unlike the first person used in other strings. (Profile.french.php)

- A forgotten comment from a forgotten era. (Profile-Modify.php)
Title: Re: New revs
Post by: Nao on September 15th, 2011, 02:28 PM
rev T-1000
(4 files +3, 21kb)

* 1000 R.E.V. shalt be the year of the Apocalypse. Thou shalt brandish thy new logo and adore it. Unless it gets changed again, it goes without saying. What?

* Replacing minilogo.png with the new style logo. Still a work in progress...? (minilogo.png)

+ Added a minilogo with white text for darker backgrounds, notably in Wine. (minilogow.png, index.css)

* Warm makes use of the rarely used @remove tag to replace the minilogo and avoid including the other one in the CSS. I should probably rewrite it to make it easier to simply remove filtered *files* instead of filtered properties... (Warm/index.css)

+ Added media/avatars and media/files folders, for later use by the media code. Gotta start somewhere. (media/*)

- Removed an used $sc global. Should also remove it from dozens of other places... It's gonna be fun. Or not. (Admin.php)

@ FWIW, I was also the one who committed(http://www.simplemachines.org/community/index.php?topic=389750.msg2695959#msg2695959) rev 10.000 to the SMF SVN... I like collecting SVN milestones 8-)
Title: Re: New revs
Post by: Nao on September 15th, 2011, 07:05 PM
rev 1001
(11 files, 10kb)

- Removed $sc from globals when not actually used in the code. Please note that $context['session_id'] should have the same value in it anyway. (Load.php, ManageMemberOptions.php, ManageServer.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, Post.php, Subs-OpenID.php)

+ Added language strings for a fatal error in draft code. (Subs-Post.php, Post.language.php)
Title: Re: New revs
Post by: Nao on September 16th, 2011, 07:58 PM
rev 1002
(6 files, 12kb)

! The gradient rule in WeCSS only accepted rgb/rgba data, so added support for #hex values as well. (Class-CSS.php)

* Don't bother showing the favicon code if the forum is already at the root. I think it's the correct way to do it... (index.template.php)

+ Added basic support for CSS-driven notifications inside menus. Only for the main menu right now, though. IE support incoming (like anyone cares.) (Subs.php, index.template.php, index.css)

- Removed a test before loading media settings, that became useless a few weeks ago. (Subs.php)

* Spacinazi. (Subs-Boards.php, MessageIndex.template.php)


@ Now the PM menu will say 'NEW' and the Inbox sub-menu will say the actual number of posts, like in the Admin menu. Is it for the best? (i.e. 'NEW' may mean something to new users, but after a while they may be annoyed that they have to hover the menu before they know how menu new PMs they have...)
Title: Re: New revs
Post by: Nao on September 16th, 2011, 11:09 PM
rev 1003
(12 files, 12kb)

! Fixed SMF bug: fixed position of the #new anchor on topics where at least one message is unapproved. (Display.php)

! create_button() was missing a non-breakable space after the actual button when button captions is enabled. (Subs.php)

* Various micro-optimizations, mostly on the display query string and on substr($string, 0, 1) (there's really no reason not to use $string[0] as it's 3 times faster, except in special cases like using these as offsets for array addition -- PHP tends to crash on that. Didn't optimize the lesser called functions. Also, strpos() is faster than substr() on very short strings. (Display.php, Class-DB.php, Class-DBPackages.php, Class-Editor.php, Aeva-Foxy.php, Aeva-Subs-Vital.php, PersonalMessage.php, Profile-Modify.php, Profile-View.php, Subs-Admin.php, SSI.php)
Title: Re: New revs
Post by: Nao on September 17th, 2011, 10:45 AM
rev 1004
(11 files +1, 144kb) (only because of the file move.)

+ Moved all templating code from Subs and Load to a new file, Subs-Template.php. I wish I would have done it before I wrote the skeleton system... New file is 50KB+ and as a result, Subs.php is now less than 100KB and Load.php is not far away. Way better for readability. (Subs.php, Load.php, Subs-Template.php)

* Admins know better, so I got rid of the $txt['new'] notification in the admin area and replaced it directly with the error count. (Subs.php)

! Fixed pre-type tags (code/php) from breaking post layout when showing long lines. This was due to not specifying table-layout:fixed on posts, silly me. (sections.css)

! Another benefit of this change is that I was able to get rid of the max-width on code tags. (index.css)

! Fixed backgrounds in message index when topics have sticky/locked/etc icons. Best I can do without a heavier rewrite. (sections.css)

! Fixed gradient filter not showing up for IE8 and IE9 and sub-menus being broken in IE7. I have no idea why it fails when float is to none in IE8 and IE9, and when float is set to right in IE6 and IE7... Well, that's IE isn't it. Why should IE9 be any better. (index.ie*.css)

* Recent post list doesn't need 2-pixel separators between user name and message. Just one is enough. (sections.css)

* Tweaked margins in top menu notifications. (index.css)

* Updated mini-logo with the new logo. Kept the same Helvetica-based font for now... (minilogo.png, minilogow.png)

* Spacinazi. (Subs-PrettyUrls.php)
Title: Re: New revs
Post by: Nao on September 17th, 2011, 11:59 PM
rev 1005
(4 files, 12kb)

! Fixed topic page layout for IE6 and IE7 (which don't support display:table, and honestly I don't care much about these browsers.) There are various things that are still broken, such as the mini-menus. Will deal with that later. (index.ie6.css, index.ie7.css)

* Minor tweaks to menu notifications. (index.css)

* Spacinazi. (Subs-Charset.php)
Title: Re: New revs
Post by: Arantor on September 18th, 2011, 02:44 PM
(Added:6 Deleted:2 Modified:33, 119KB)

Revision: 1006
Author: arantor
Date: 13:41:10, 18 September 2011
Message:
+ First usable build of the add-on manager. This has many related changes:
+ Actually add the folder. Includes a default htaccess file to block archives from being downloaded from there but potentially all other files might be. (Addons/*)

+ Add the add-on manager. (ManageAddons.*, replacing switch_on.png and switch_off.png with smaller sized images)

! create_table can now add columns and indexes (but not unique or primary indexes) if the table already exists when passed to this function. It also has rudimentary support for new datatypes, namely the floating types (float, real, double) and SET and ENUM, but this isn't properly tested and is likely buggy. (Class-DBPackages.php)

! Attempt to detect if an add-on caused an error and set the error type accordingly. (Doesn't bother to attempt to change the label to just the mod's name or similar, just attempts to locate and update for now) (Errors.php)

! Menu changes for the add-on manager. Some of this is temporary code and it leaves the old package manager available for testing with a naughty non-language-string entry. As Wedge's add-on manager matures this won't be a problem. (Admin.php, Admin.english.php, PackageGet.php, Packages.php, index language file)

! Added a setting for setting the path and URL to the Addons area. (Settings.php, install.php, ManageServer.php, Admin language file)

! Removed Modifications language file (Modifications language file, index.php, SSI.php, Load.php)

! On startup, identify the add-ons currently enabled and add their hooks into the current process' stack, as well as making sure we have the paths and URLs to these for later. (Load.php)

! Language editor can now load the language strings of add-ons and access them directly, much as SD 2.0 does. (ManageServer.php, Admin.template.php)

! New hook loader purely for language files (Subs.php)

! New hooks. (Profile-View.php, Subs-BBC.php, Subs-BoardIndex.php, Who.php (lang only), SSI.php, index.php)

! Make sure that hooked files in loaders are loaded correctly. (Profile.php, ScheduledTasks.php, Subs-Template.php, Subs.php)

! Provide facilities for add-ons to declare CSS and JS to be cached through the caching subsystem. (Subs-Cache.php)

! If icons in menu items are full URLs, don't touch them, useful for add-ons. (Subs-Menu.php)

@ This isn't even complete, there are multiple known items still to do:
- The DB changer in the add-on area cannot add columns to existing non-add-on tables (e.g. new column in members table), nor can it add indexes. Also needs more testing anyway.
- The DB changer also does not run any enable-time scripts (nor disable-time scripts, for that matter)
- There's no ability to upload new add-ons, nor any ability to remove any existing ones (including clean-up)
- Dependency management isn't accounted for either.
- The exact process for updating a given add-on is also to be figured out and implemented. I'm thinking it would actually be a process of unpacking the new one into a new folder, disabling the old one, enabling the new one if possible, then removing the old one. Proper in-place updating is a road to madness.
- File edits need to be accounted for.
- Oh, and permission handling both in terms of permissions being required to enable an add-on (e.g. 'this add-on makes file edits, proceed?') and for when file edits are used, permissions on files, preferably ones that won't screw up a lot of servers.
----
Added : /trunk/Addons
Added : /trunk/Addons/.htaccess
Added : /trunk/Addons/index.php
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Added : /trunk/Sources/ManageAddons.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/ManageAddons.template.php
Modified : /trunk/Themes/default/images/admin/switch_off.png
Modified : /trunk/Themes/default/images/admin/switch_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Added : /trunk/Themes/default/languages/ManageAddons.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english.php
Deleted : /trunk/Themes/default/languages/Modifications.english.php
Deleted : /trunk/Themes/default/languages/Modifications.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/admin.css
Modified : /trunk/index.php
Modified : /trunk/other/Settings.php
Modified : /trunk/other/Settings_bak.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/wedge_api.php
Modified : /trunk/other/xml/detailed-version.php
Posted: September 18th, 2011, 02:43 PM

Forgot to add that there's also the loadAddon functions in Load.php now that are used for loading add-on source, template and language files as needed.
Posted: September 18th, 2011, 02:43 PM

Oh, and also note that the create_table version here also fixes an SMF bug whereby the default value of a column isn't determined correctly for a pre-existing table.
Title: Re: New revs
Post by: Nao on September 18th, 2011, 06:38 PM
rev 1007
(20 files +5-3, 63kb)

+ For the very first time in a year, we wrote and committed the very same feature on the same day, months after we last discussed implementing it. Fixed the conflicts in index.php, and the default index system now accepts a default value ($modSettings['default_index']) without going through hooks. Set it to the name of a source file ('Homepage' for instance) that you want to be the default homepage, or set it to 'boardX', where X is the number of a board, if you want a default board as your entry point. Added a Homepage file, as an example. (index.php, Homepage.php, Homepage.template.php)

* Renamed boardindex action to boards, and BoardIndexInfoCenter to just InfoCenter -- in case we want to use it elsewhere. Related commenazi, too. (index.php, unit test, detailed-version.php, Boards.php, Collapse.php, Display.php, PrintPage.php, Subs-BoardIndex.php, Subs-Calendar.php, Subs.php, Boards.template.php, InfoCenter.template.php, Wireless.template.php, Xml.template.php, ManagePermissions.english.php)

* JumpTo now uses action=boards for redirecting to category URLs. Added compatibility code for Pretty URLs. (Ajax.php, script.js, Xml.template.php)

! Don't attempt loading a block if its target layer doesn't exist. (Subs-Template.php)

! Reverted a small error in rev 1006. (Settings.php)

* Minor commenazi/spacinazi. (Admin.php, ManageMedia.php, Subs-Template.php, Who.php, SSI.php)

@ Note: I still need to convert all #category links to use action=boards... I could use the opportunity to limit the output to just the category we requested? What do you think?
Title: Re: New revs
Post by: Nao on September 18th, 2011, 07:40 PM
rev 1008
(15 files, 24kb)

+ Added info center to the Homepage sample, also demonstrating the usage of layer and block manipulation. (Homepage.php, Homepage.template.php)

! Make sure default_action hooks return a callable function, and disable $modSettings['default_index'] in Wireless mode (it's unlikely the admin will write a custom homepage just for Wap2, so their template would like look awful...) (index.php)

! loadBlock('', '', 'add') was being added to the beginning of the layer, rather than the end. Oops. (Subs-Template.php)

* Adding layers to the context layer was forbidden until now. The homepage code made me realize a good reason to allow them, so I did it. However, given the fact that a layer can easily be emulated through manually adding '_above' and '_below' blocks in this case, I'm still not sure whether it's best to allow them. (Subs-Template.php)

- Removed support for the ':side' hint. After some consideration, I think it may be confusing to themers and sidebars should only use the 'sidebar' layer, whatever the situation. Layer hints should represent something that can't be determined by Wedge itself, such as a position in the page. (index.php, Admin.php, Calendar.php, Display.php, Aeva-Gallery.php, MessageIndex.php, Subs-Menu.php, Subs-Template.php, Unread.php, UnreadReplies.php, index.template.php, Warm/skin.xml)

* Indenazi. (Boards.php)
Title: Re: New revs
Post by: Nao on September 18th, 2011, 11:13 PM
rev 1009
(11 files, 11kb)

+ Added the 'c' query string variable to action=boards, allowing to specify a single category that should be shown in the board list (à la Noisen). Considering changing it to '?cat=' later, for consistency, although it'll require updating pretty URLs as well. (Boards.php, Load.php, MessageIndex.php, Subs-BoardIndex.php, Recent.php, Search2.php, Unread.php, UnreadReplies.php, ModerationCenter.template.php, Xml.template.php)

* Category collapse action should redirect to the board list instead of reloading it silently from the collapse action URL. (Collapse.php)
Title: Re: New revs
Post by: Nao on September 18th, 2011, 11:55 PM
rev 1010
(20 files, 15kb)

* Replaced WIRELESS_PROTOCOL with the 'wap2' string. I don't see us supporting any other wireless protocol in the future. (index.php, Boards.php, Display.php, Errors.php, FindMember.php, Load.php, Login.php, Login2.php, ManageBans.php, MessageIndex.php, PersonalMessage.php, Post.php, Profile.php, Security.php, Post.php, Profile.php, Security.php, Subs.php, Unread.php, UnreadReplies.php)

! Fixed menu layout in IE6 and IE7. Still glitchy, but more usable. (GenericMenu.template.php, index.ie6/ie7.css)
Title: Re: New revs
Post by: Arantor on September 19th, 2011, 01:47 AM
(3 files, 10 KB)

Revision: 1011
Author: arantor
Date: 00:46:20, 19 September 2011
Message:
+ Add-on manager can now call for a script to execute when enabling or disabling an add-on. (ManageAddons.php, ManageAddons.english.php)

+ New hook in the help popup, lang_help, so that the help popup can make use of an add-on's language files without the add-on having to do anything too complicated like hijacking the help action, or having to load a file just to contain a single load call. (Help.php, ManageAddons.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/ManageAddons.php
Modified : /trunk/Themes/default/languages/ManageAddons.english.php
Title: Re: New revs
Post by: Nao on September 19th, 2011, 11:18 AM
rev 1012
(13 files, 16kb)

+ Added removeBlock() and removeLayer() shortcuts. removeLayer() protects all of the context's direct parents, so you can't remove the main layer through this. (Subs-Template.php)

! loadBlock shouldn't be replacing sidebar blocks, only adding to them. I still don't know if I should make it the default for non-context blocks, but it might confuse themers and modders... (Admin.php, Boards.php, Calendar.php, Display.php, Aeva-Gallery.php, MessageIndex.php, Profile.php, Unread.php, UnreadReplies.php)

! Don't set a block to use a layer that was removed, even if its hint is still there. (Subs-Template.php)

* Changed the way Wedge deals with non-existing target layers in loadBlock(). Mods will now have to specify a fallback layer (logically, 'context') if it's vital for their block to be shown, as 'context' is the only layer that's guaranteed to be shown. Unless some other mod played with unset($context['layers']['context']) like crazy, ah ah. Well, shoot them on sight. (Subs-Template.php)

* If the skeleton array doesn't have at least the context layer, launch a fatal error because an add-on is screwing up. (Subs-Template.php)

! I'm not exactly sure why I used to prevent layer functions (above and below) from being overloaded or overridden... This is fixed now. You can create your template_layer_above_after functions all you want. Well, I think. (Subs-Template.php)

! Menu removal code was still using the old layer system. (Subs-Menu.php)

* Random weak translation. (Help.french.php)

* Pete likes having space in his notifications. (index.css)


@ Need to write a multi-language error for the context layer error... Would you care to write it, Pete? I lack inspiration to do something that can be understood by normal users and not overly dramatic at the same time :P
Title: Re: New revs
Post by: Nao on September 19th, 2011, 11:54 PM
rev 1013
(18 files, 22kb)

* Category URLs now use "?category=", and also have their own pretty URL. (index.php, Boards.php, Load.php, PrettyUrls-Filters.php, QueryString.php, Recent.php, Search2.php, Subs-BoardIndex.php, Subs-Template.php, Unread.php, UnreadReplies.php, ModerationCenter.template.php)

! IE9 doesn't support -ms-border-radius, only the prefix-free version, and as a result it didn't show any rounded corners. So, fixed that. (Subs-Cache.php)

+ Added support for notifications in non-main menus. (Subs-Menu.php, GenericMenu.template.php)

! Fixed main menu layout breaking when menu was split into several lines, especially with notifications shown. (index.css)

* The Media menu item now uses menu notifications for its number of unseen items. (Subs.php)

* Code cleanup. (PrettyUrls-Filters.php)


@ Funny note: notifications in non-main menus work in IE6, 7 and 8... But not in IE9 or IE10! Ahah. Well, the layout is broken but it's still usable. Whatever.

@ Also, used 'category' instead of 'cat' because 'cat' is being reserved for blog categories, potentially. Well, it's a weak reason... Feel free to change it.
Title: Re: New revs
Post by: Nao on September 20th, 2011, 11:53 AM
rev 1014
(13 files, 19kb)

! Rewrote language code to always load $context['languages'] if userLanguage is enabled [1]. Also made folder traversing faster. This allows to fix language flags not always showing up in the header. (Load.php, ManageServer.php, Register.php, index.template.php)

* Renamed context layer to default layer, as I suspected I'd do. Probably makes more sense to themers. Also added translations for the default_layer_missing error, and removed the ':main' hint, because it's always going to be hardcoded to 'default' anyway. (Homepage.php, Profile.php, Security.php, Subs-Template.php, index.template.php, Errors.language.php, Warm/skin.xml)

! Fixed a small hideChrome bug. (PrintPage.php, Reports.php)
 1. Although I suppose it will fail if it's disabled but there are still multiple languages available and a board defines a non-default language. Need to look into that. Pete, do you remember anything about that?
Title: Re: New revs
Post by: Nao on September 20th, 2011, 05:30 PM
rev 1015
(16 files, 13kb)

* Turned (new Date).getTime() into +new Date(), which is shorter. So what? I like shorter. (install.php, restore_backup.php, upgrade.php, Profile.template.php, Register.template.php, Themes.template.php, script.js, suggest.js)

* Spacinazi, mainly empty lines with tabs. (ManageAddons.php, ManageMemberOptions.php, ManagePaid.php, Subs-Scheduled.php, Subs-Template.php, Subs.php, ManageAddons.template.php, index.css)
Title: Re: New revs
Post by: Arantor on September 21st, 2011, 02:41 AM
4 files, 12KB

Revision: 1016
Author: arantor
Date: 01:40:20, 21 September 2011
Message:
! Fix some bugs in the error detection in add-ons, namely fixing paths in Windows (as debug_backtrace reports filenames with forward slashes, regardless of DIRECTORY_SEPARATOR), fixing the DB column to actually be wide enough and to display it usefully. Note that, at present, the "using filter" part still uses the add-on's full id, as opposed to the part right of the :, but it does something similar with normal filtering, it doesn't use the nice description but basically the same as what you put in the URL. I'll fix that sometime, but for now, it's an improvement. (install.sql, Errors.php, Load.php, ManageErrors.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/other/install.sql


(Yes, this now actually works properly, it's sorting out WedgeDesk errors nicely.)
Title: Re: New revs
Post by: Arantor on September 21st, 2011, 12:20 PM
1 file, 4KB

Revision: 1017
Author: arantor
Date: 11:20:19, 21 September 2011
Message:
! The admin menu should be able to load add-on files too. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Title: Re: New revs
Post by: Arantor on September 21st, 2011, 12:36 PM
1 file, 4KB

Revision: 1018
Author: arantor
Date: 11:36:26, 21 September 2011
Message:
! Make sure the absolute path to add-on JavaScript files is passed to the cacher, not the relative path even when we had already figured out the absolute one. (Subs-Cache.php)
----
Modified : /trunk/Sources/Subs-Cache.php
Title: Re: New revs
Post by: Arantor on September 21st, 2011, 02:24 PM
1 file, 3KB

Revision: 1019
Author: arantor
Date: 13:24:24, 21 September 2011
Message:
! The language hook loader did not differentiate hooks properly, screwing up the path it was supposed to be using. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on September 21st, 2011, 02:43 PM
2 files, 5KB

Revision: 1020
Author: arantor
Date: 13:42:43, 21 September 2011
Message:
! Items in the generic show_settings template should have ids on their spans, in case we want to restyle them dynamically (e.g. if something is disabled and we can re-enable it by selecting a different setting/choice), and also convert the inline style for disabled items to a class style. (Admin.template.php, admin.css)
----
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/skins/admin.css
Title: Re: New revs
Post by: Nao on September 21st, 2011, 09:32 PM
rev 1021
(10 files, 19kb)

- Removed layer hints. They would probably have been a bit confusing to part-time themers and modders. Here's hoping themers will make sure their skeletons have all of the regular layers in them. (Aeva-Gallery.php, Profile.php, Subs-Menu.php, index.template.php, Warm/skin.xml)

! Fixed some logic errors when providing wrong values to the skeleton. (Subs-Template.php)

+ Added a skeleton_find_parent() function to get the parent layer's name for a given block or layer. (Subs-Template.php)

* Shortened a few JS functions. I'm particularly proud I managed to shorten my menu code by a few more lines. Nerd alert. (ManageMaintenance.template.php, mediadmin.js, post.js, script.js)
Title: Re: New revs
Post by: Nao on September 22nd, 2011, 06:47 PM
rev 1022
(7 files, 12kb)

+ Added ability to remove index.php from the URL in the Pretty URLs area. You no longer have to enable Pretty URLs just to remove index.php, for those who don't like them. (ManageSettings.php, QueryString.php, Admin.template.php, Admin.language.php)

- Don't repeat comments twice in the htaccess file. Don't repeat comments twice in the htaccess file. (other/.htaccess)

- Shortened the debug HTML code. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on September 22nd, 2011, 09:54 PM
rev 1023
(8 files, 13kb)

- Removed compactTopicPagesEnable setting. I've never seen a single SMF forum disable it anyway. (install.sql, Display.php, ManageSettings.php, Subs.php, Help.language.php, ManageSettings.language.php)

@ Note to SMF: if you keep the option, I'd just like you to know the help popup for it is completely screwed up... It looks like it's the help for compactTopicPagesContiguous, in fact (which is repeated below). Plus, the help never mentions it's for the page index.
Title: Re: New revs
Post by: Nao on September 23rd, 2011, 12:34 AM
rev 1024
(7 files +1, 23kb)

+ Re-introducing the top menu arrow. Holy cow, did I miss that one. Used a clever CSS trick to add it through JavaScript without even breaking validation. (menurow.gif, script.js, index.css, Warm/index.css)

+ Added support for average() color function. It returns a color that is the average of two colors passed to it. Note that this is the HSLA average, not RGBA, so it's more accurate. Also used the function on menu background for IE9, as an example. (Class-CSS.php, index.css)

* Updated minilogos to PT Sans. Hmm, I think Helvetica looks best at that size though... (minilogo.png, minilogow.png)

! Error when errors occur. But only if no add-ons are installed, if I'm not in error. (Errors.php)

! Fixed minor glitch on menu corners. (index.css)
Title: Re: New revs
Post by: Nao on September 23rd, 2011, 11:36 AM
rev 1025
(3 files, 7kb)

- Reverting a useless fix which was due to my setup not being up to date. (Errors.php)

! More menu CSS fixes for IE8 and IE9. Microsoft, please kill IE. Now. (index.ie*.css)
Title: Re: New revs
Post by: Arantor on September 23rd, 2011, 06:07 PM
Revision: 1026
Author: arantor
Date: 17:02:55, 23 September 2011
Message:
! (SMF bug, thanks Dragooon) When registering users through instant activation, make sure the right variable is passed to the activate hook. (Register.php)
----
Modified : /trunk/Sources/Register.php


@ I did a quick look back through the code history in SMF. It looks like prior to RC4, a different integration hook was called entirely (and arguably that's also broken), but that in RC4 it changed and the way it changed made it break.
Title: Re: New revs
Post by: Nao on September 23rd, 2011, 07:31 PM
rev 1027
(23 files -1 -1 folder, 31kb)

* Updated loadBlock() to set the default 'where' param to 'add' for non-default layers (still defaults to 'replace' in default.) You may also just use an empty string instead of specifying 'default' in loadBlock() and loadLayer(). Whatever makes you feel more comfortable. (index.php, Boards.php, Calendar.php, Display.php, Homepage.php, Aeva-Gallery.php, MessageIndex.php, Profile.php, Subs-Menu.php, Subs-Template.php, Unread.php, UnreadReplies.php, Warm/skin.xml)

* Moved constructPageIndex() to the index template, to make it easier to style for themers. (Subs.php, index.template.php)

* Turned the stat center into a proper layer. (Boards.php, Homepage.php, InfoCenter.template.php)

! Fixed menus and menu notices in plenty of browsers. IE9, I hate you with a passion now. It's the only browser that doesn't play nicely with floats... IE10 works, and even IE6 works here. Eh. (GenericMenu.template.php, script.js, index.css, index.ie6.css, index.ie7.css)

- Forgot to remove layer hint and extra CSS definitions. Also removed the hs folder, as we're no longer using Highslide. (Load.php, Subs-Cache.php, aeva/hs, smf2.css)
Title: Re: New revs
Post by: Arantor on September 24th, 2011, 02:13 PM
Revision: 1028
Author: arantor
Date: 13:13:12, 24 September 2011
Message:
! If the board or message index has a custom class/title specified for the left icon, make use of that. (Probably only of use to add-ons.) (Boards.template.php, MessageIndex.template.php)

! Limited ability to perform removal of add-ons and associated clean-up. It gets upset if it can't remove the files, though, because it doesn't have any ability to let you log in via FTP to fix them at present. (ManageAddons.php, ManageAddons.template.php, ManageAddons.english.php, addon_remove.png)

! Fix for undefined variable in addon-loader as reported by live627. (Load.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAddons.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManageAddons.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/admin/addon_remove.png
Modified : /trunk/Themes/default/languages/ManageAddons.english.php
Title: Re: New revs
Post by: Arantor on September 24th, 2011, 02:58 PM
Revision: 1029
Author: arantor
Date: 13:57:42, 24 September 2011
Message:
! Hopeful fix for the SET/ENUM issue and having the wrong default; if no default is set, don't create a phantom one in its place. (ManageAddons.php)
----
Modified : /trunk/Sources/ManageAddons.php
Title: Re: New revs
Post by: Arantor on September 24th, 2011, 03:18 PM
Revision: 1030
Author: arantor
Date: 14:17:56, 24 September 2011
Message:
! Make sure all the displayed strings are actually pushed through htmlspecialchars, simply because it's not good mojo if you provide XSS facilities in an add-on. (ManageAddons.php)
----
Modified : /trunk/Sources/ManageAddons.php
Title: Re: New revs
Post by: Nao on September 25th, 2011, 02:09 AM
rev 1031
(7 files, 12kb)

* Split the header contents into several blocks[1] (logo_toggler, search_box, language_selector and random_news), allowing to move individual components into other places like the sidebar, as demonstrated in Warm. (And yes, it will break indentation if you check the HTML code. I'm not going to fix it, it's too resource-intensive.) Also, removing logo_toggler will now cancel the oMainHeaderToggler object setup. (index.template.php, Warm/skin.xml)

! Fixed various glitches in Warm and Wuthering, and harmonized their main font: Warm is a PT Sans beast with Segoe UI and Trebuchet MS fallbacks, and Wuthering is a Segoe UI with an Arial fallback. (Warm/index.css, Wuthering/index.css)

- Don't bother setting we_iso_case_folding if it's never going to be used (i.e. set to false, or simply sha1.js is not loaded.) (ssi_examples.php, index.template.php, sha1.js)

* Forgot to remove an 'add' from a loadBlock. (Admin.php)
 1. One question... Is it TOO much? I'm assuming it's okay because these are important components, but I'll refrain from doing it everywhere...
Title: Re: New revs
Post by: Arantor on September 25th, 2011, 02:25 AM
Revision: 1032
Author: arantor
Date: 01:25:10, 25 September 2011
Message:
! Added code contributed by Dragooon for add-ons being able to detect their own hooks (i.e. providing a hook and simultaneously registering something against it), plus a fix to one of my bugs, plus what I suspect may be a bugfix to Dragooon's (but I might be wrong), plus a little tweak elsewhere to prevent phantom hooks being registered. (ManageAddons.php, Load.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAddons.php
Title: Re: New revs
Post by: Nao on September 26th, 2011, 11:43 PM
rev 1033
(14 files, 23kb)

+ Introducing pretty URL prefixes for actions and profiles. Basically, when enabling pretty actions or pretty profiles, you also get to choose between various URL styles for them. Supporting "/" and "/do/" for actions, and "/~" and "/profile/" for profiles. Defaults to the long versions. Need to add some documentation about this, and some code at board creation time to prevent them from having a name in the protected action list...[1] (install.sql, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, Admin.template.php, Admin.language.php, admin.css)

* Updated credits page to merge library copyrights with other copyrights. (Credits.php, Who.template.php, Who.language.php)

* Added Pretty URLs admin page to the internal admin search engine. Heck, we need to add many more sub-actions to that array... I'll let Pete handle this after he finishes reworking the admin area. (Admin.php)

* Spacinazi. (Subs-Cache.php)
 1. Feel free to add it to your to-do list, Pete... I'm so horribly busy these days. :(
Title: Re: New revs
Post by: Nao on September 27th, 2011, 06:09 PM
rev 1034
(8 files +3 -2, 39kb)

* Upped the maximum file count in media folders to 500 (from 150). (install.sql)

* Renamed Homepage custom page to Welcome, so that you can create your own Homepage. (Homepage.php, Homepage.template.php)

* Spacinazi, parenthenazi, typo and code cleanup. (ManageAddons.php, Subs-Media.php, Subs-Boards.php, Subs-Cache.php, Admin.template.php, ManageAddons.english.php)

* French translation. (Admin.french.php, ManageAddons.french.php)
Title: Re: New revs
Post by: Nao on September 28th, 2011, 02:20 PM
rev 1035
(7 files +2, 11kb)

+ Added a 'data' subfolder to the cache folder, to differentiate between data we might end up adding to the HTML (cached JS or CSS), from data that is solely for internal use (PHP cache). Also added an index.php handler, even if not needed, because we're never far away from a security issue. (cache/data/*)

+ Added a couple of media table keys that weren't correctly imported from the AeMe installer. (install.sql)

* Tweaked media CSS to allow for the item information column to be moved to the bottom if we don't have enough space on the right. (media.css)

! Fixed a few typos in the language files, and removed some outdated strings. (ManageAddons.language.php, ManageMedia.french.php, Media.language.php)
Title: Re: New revs
Post by: Nao on September 28th, 2011, 02:22 PM
rev 1036
(11 files, 21kb)

+ Added an add_css() function to make it easier to add inline CSS at the very end of the headers. (Aeva-Embed.php, Aeva-Foxy.php, Subs-Media.php, Subs-Cache.php, Register.template.php)

* Cache manager will now use the data subfolder, and when asked, will touch the (less likely to be opened) Collapse.php file instead of Load.php. Because if you're developing Wedge and testing it on a local install, believe me, it's annoying as hell to see Notepad2 complain just because you left Load.php opened and it noticed its file date changed. What do you mean, you don't care? Did your mom tell you how rude you can be sometimes? Do you really deserve Wedge? Well... We'll see about it after you apologize. (Subs-Cache.php)

* Removed 'last_minute_header' hack, and instead rewrote everything to use $context['header'] and show it at the last minute, instead of via the index template. Also made the dynamic replacement ten times faster by using substr_replace instead of a regex. (Class-Editor.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-ModCP.php, Subs-Media.php, Subs-BBC.php, Subs-Cache.php, Subs-Template.php, index.template.php)
Title: Re: New revs
Post by: Nao on September 28th, 2011, 06:03 PM
rev 1037
(3 files, 9kb)

+ Will now add the action list and 'do' to the forbidden board names when generating pretty URLs. (Subs-PrettyUrls.php)

! Reverted part of rev 362, where a bug in the auto-suggest code was fixed by introducing another one. Now, pressing Tab with no suggestion highlighted will still take the first valid match into account. I tried hard, but I wasn't able to reproduce the bug mentioned in rev 362, so... fingers crossed. (suggest.js)

! Fixed auto-suggest position after submitting an item (assuming we're going to submit more, obviously.) (suggest.js)

* Converted Foxy code to jQuery. (Aeva-Foxy.php)
Title: Re: New revs
Post by: Nao on September 28th, 2011, 11:41 PM
rev 1038
(39 files, 27kb)

! get_boardindex hook didn't work as expected when not in include_categories mode. (Subs-BoardIndex.php)

* For consistency reasons, now using the official PHP syntax for variable referencing, i.e. "=&" instead of "= &". (38 files... Not listing them all. Not committing getid3 because it's version 1.7.9 and I need to update it to 1.9.1...)

* Commenazi. (Class-DBPackages.php)
Title: Re: New revs
Post by: Nao on September 29th, 2011, 01:27 PM
rev 1039
(12 files, 18kb)

* Now caching the cache type for the lifetime of the PHP page. It also has the benefit of not doing strange things when a cache getter is enabled but a cache setter is disabled through php.ini, or things like that. Also optimized various areas of the cache. (Subs-Cache.php)

! This has got to be one of my best bugs in a long time. Last time I optimized the file cache code, I actually inverted a test, meaning that the caching logic was completely screwed up. Lulz!!1 (Load.php, Subs-Cache.php)

* Optimized getLanguages() to be a bit faster using glob() instead of scandir(), things like that. (Load.php)

* Always running getLanguages() for now. It takes a millisecond or so. Probably could use some optimization, but I'm going to be cool with that for now. Also centralized the test for isset($context['languages']) at the beginning of getLanguages(). (Load.php, ManageAddons.php, ManageBoards.php, ManageServer.php, Register.php)

- Removed $context['languages'][...]['selected'], as it's never used anywhere. (Load.php)

- Got rid of pointless features aeva_get_size() and max_dir_size. (Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.language.php)

* aeva_get_num_files() actually did a recursive search when it only needed to get the current folder's number of files. Optimized 18 lines into 2. (Aeva-Subs-Vital.php)

* Upped maximum number of files in an album folder to 1500, once again. The common FTP limit for viewable files is 2000, and 1500 should allow for at least 500 items per folder, for a minimum of 250k avatars and attachments in the future system. Until we get to add an extra level of depth to the folder structure, of course. (install.sql)
Title: Re: New revs
Post by: Nao on September 29th, 2011, 09:18 PM
rev 1040
(3 files, 6kb -- small one, but IE was its usual bitch with me.)

* Cache manager doesn't need to unset $val when it's not set in the first place... (Subs-Cache.php)

! Fixed mini-menus in both IE6 and IE7. IE6 requires hardcoding the width, so I chose 120px. Tough life. (index.ie6.css, index.ie7.css)
Title: Re: New revs
Post by: Nao on September 30th, 2011, 07:15 AM
rev 1041
(39 files +5-5, 107kb)

* Renamed add-ons to plugins, as per the latest discussion on the matter.

/trunk/Addons
/trunk/Plugins
/trunk/Plugins/.htaccess
/trunk/Plugins/index.php
/trunk/Sources/Admin.php
/trunk/Sources/Class-DBPackages.php
/trunk/Sources/Credits.php
/trunk/Sources/Errors.php
/trunk/Sources/Load.php
/trunk/Sources/ManageAddons.php
/trunk/Sources/ManagePlugins.php
/trunk/Sources/ManageServer.php
/trunk/Sources/ManageSettings.php
/trunk/Sources/PackageGet.php
/trunk/Sources/Packages.php
/trunk/Sources/Profile.php
/trunk/Sources/ScheduledTasks.php
/trunk/Sources/Subs-Cache.php
/trunk/Sources/Subs-Package.php
/trunk/Sources/Subs-Post.php
/trunk/Sources/Subs-Template.php
/trunk/Sources/Subs.php
/trunk/Themes/default/ManageAddons.template.php
/trunk/Themes/default/PersonalMessage.template.php
/trunk/Themes/default/images/admin/addon_manager.png
/trunk/Themes/default/images/admin/addon_remove.png
/trunk/Themes/default/images/admin/addon_settings.png
/trunk/Themes/default/images/admin/plugin_manager.png
/trunk/Themes/default/images/admin/plugin_remove.png
/trunk/Themes/default/images/admin/plugin_settings.png
/trunk/Themes/default/languages/Admin.english.php
/trunk/Themes/default/languages/Admin.french.php
/trunk/Themes/default/languages/Errors.english.php
/trunk/Themes/default/languages/Errors.french.php
/trunk/Themes/default/languages/Help.english.php
/trunk/Themes/default/languages/ManageAddons.english.php
/trunk/Themes/default/languages/ManageAddons.french.php
/trunk/Themes/default/languages/ManagePermissions.english.php
/trunk/Themes/default/languages/ManageSettings.english.php
/trunk/Themes/default/languages/Media.french.php
/trunk/Themes/default/languages/Modlog.english.php
/trunk/Themes/default/languages/Packages.english.php
/trunk/Themes/default/languages/Who.english.php
/trunk/Themes/default/languages/index.english.php
/trunk/Themes/default/languages/index.french.php
/trunk/index.php
/trunk/other/Settings.php
/trunk/other/Settings_bak.php
/trunk/other/install.php
Title: Re: New revs
Post by: Nao on September 30th, 2011, 08:07 AM
rev 1042
(10 files -5, 387kb)

* Updated getid3 from v1.7.9 to v1.9.1. Given the increase in size, compensated a bit by removing files that aren't playable from within browsers (FLAC, Wv, APE) because I doubt they'd be uploaded 'as is' instead of zipped up or something. Also removed ID tag files because we're not actually using any of this data in the media area... For now at least. (Source/media/getid3/*)
Title: Re: New revs
Post by: Nao on September 30th, 2011, 08:35 PM
rev 1043
(6 files +1, 129kb)

+ Forgot to add the Matroska parser for mkv and webm support in the media area. (module.audio-video.matroska.php)

! Turned language flag URLs into relative URLs, fixing a wrong attempt by Wedge to re-prettify pretty URLs with both 'action' and 'board' variables in them. Eh, also makes the URLs shorter... (index.template.php)

+ Added support for 'rem' unit size in WeCSS's math function. (Class-CSS.php)

+ Forgot to translate an old item. Hmm. (index.french.php)

* Commenazi. (Load.php, getid3/*)
Title: Re: New revs
Post by: Nao on September 30th, 2011, 11:25 PM
rev 1044
(7 files, 11kb)

+ At last, started implementing id_parent in messages for the future threaded view (whether as a plugin or in core). Currently works on Reply, Quote and new posts. Doesn't work on Quick Reply for now. (Post.php, Post2.php, Subs-Post.php, Post.template.php)

! Fixed and tweaked PM post layout -- straightened up the padding and margin, used on_timeformat() where it applies, made Delete button visible, etc. And my apologies for the minor hack in the PM layer's above(). (PersonalMessage.php, PersonalMessage.template.php, index.member.css)
Title: Re: New revs
Post by: Nao on October 1st, 2011, 12:29 PM
rev 1045
(8 files, 9kb)

- clean_cache('member_data') doesn't do anything. It didn't back in SMG days, it still doesn't. Might as well remove it... (Subs-Media.php)

! Default clean_cache type should be empty, and redirect to the data sub-folder. The type is only overridden for the smiley cache anyway. (Subs-Cache.php)

! Fixed padding for the quick reply textarea. (Class-Editor.php, editor.css, sections.css)

* Moved 'mark unread' link next to 'report to moderator' in PM template. (PersonalMessage.template.php)

* Quick reply opening speed was fast, but not fast enough for a 'quick' reply. Increased speed by 25%. (topic.js)

- Moderation notes? Thank you, Captain Obvious! (admin.css)
Title: Re: New revs
Post by: Nao on October 1st, 2011, 06:08 PM
rev 1046
(13 files +5-5, 45kb)

* clean_cache filter can now be a string anywhere inside the filename. (Subs-Cache.php)

+ Added a 'dynamic' plugin for WeCSS, where one may define a dynamic_function() anywhere (whatever the name), and then call it from within a CSS file via {%dynamic_function:params%}. Will have to look into potential security issues, though... (Class-CSS.php, Subs-Cache.php)

+ Added a dynamic function to cache language flags into index.css... Yay. This gets me one more percent on Google PageSpeed. (Subs-Cache.php, index.css, index.template.php)

! Forgot to update a few files with the Plugin rename. (other/*, ManagePlugins.language.php, ManagePlugins.template.php, admin.css)

! Fixed margin glitch when showing a .wrc div that only contains a single p (paragraph). (index.css)

! Fixed bug with is_replied_to in PM searches. (PersonalMessage.php)

- Saving one line of code. Beautiful. (Display.template.php)
Title: Re: New revs
Post by: Nao on October 1st, 2011, 07:40 PM
rev 1047
(4 files, 7kb)

* Swapped parameter order for clean_cache() to put the emphasis on the most used param. Also cleaned up related data. (ManageServer.php, ManageSmileys.php, Subs-Boards.php, Subs-Cache.php)

* Delete CSS cache when language files are modified. (Subs-Cache.php)
Title: Re: New revs
Post by: Arantor on October 2nd, 2011, 05:16 PM
Revision: 1048
Author: arantor
Date: 16:15:47, 02 October 2011
Message:
! Fix to installer failing to create correct key in database tables. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on October 2nd, 2011, 06:09 PM
rev 1049
(16 files +6, 33kb -- too tired to take time splitting into smaller commits.)

+ Because I was bothered by a lousy Google PageSpeed rating on admin menus, due to menu icons, I gathered them together and multiplied said rating by two. Known issue: if you modify the admin menu, you'll need to manually remove the cache file, or run clean_cache('css', 'admenu') through a hook or something. Needs discussing. (Admin.php, Subs-Cache.php, Subs-Menu.php, admenu.css)

+ Added cache control htaccess files to avatar and smiley folders. Smileys don't need this, unless they're too big to be cached by WeCSS. Also note that $admin_areas is now a global, so the admin menu hook doesn't need to specify it as a param. (avatars/.htaccess, Smileys/.htaccess)

+ Added three icons to the topic moderation menu. Only visible to members with the correct permissions. Asking for feedback on whether I should remove them or add icons to the rest. (index.member.css, sections.css)

* Modified CSS dynamic plugin to force requiring a dynamic_ prefix on the function name. Should make it safer to use. (Class-CSS.php, index.css)

* Got real when it comes to clean_cache(), and made it simpler to remove CSS and JS files with it. You just need to specify 'css' now, and Wedge will extend it to all extensions used for CSS files. (ManageServer.php, ManageSmileys.php, Subs-Cache.php)

! Error URLs were recently broken if using Pretty URLs. (Errors.php)

! Package functions don't need to declare admin.css, since it's already declared by that time. (PackageGet.php, Packages.php)

! jQuery was being used in an inline function. (Subscriptions-PayPal.php)

* Super-minor fixes. (avatars/xkcd/index.php, Load.php, ManageErrors.php)

NB: would appreciate feedback on this commit, thanks...
Title: Re: New revs
Post by: Arantor on October 3rd, 2011, 10:48 AM
Revision: 1050
Author: arantor
Date: 09:48:17, 03 October 2011
Message:
+ First version of RelaxNG schema for plugin-info.xml files. There's more to add yet, as I finalise the extra parts. Plus I need to author a couple more XML filetypes and their specifications yet, but this is a start. (plugin-info.rng)
----
Added : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on October 3rd, 2011, 11:37 AM
Revision: 1051
Author: arantor
Date: 10:37:15, 03 October 2011
Message:
! XMLReader/libxml2 is a bit more fussy than other parsers. (plugin-info.rng)
----
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on October 3rd, 2011, 12:05 PM
Revision: 1052
Author: arantor
Date: 11:05:19, 03 October 2011
Message:
! Add the definitions for file edits and the action extender to the RelaxNG schema. (plugin-info.rng)
----
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on October 3rd, 2011, 12:59 PM
(6 files, 12KB)

Revision: 1053
Author: arantor
Date: 11:58:38, 03 October 2011
Message:
! The filename attribute for plugin actions is not optional. (plugin-info.rng)
! New hook: info_center, designed for hooking into, well, the info centre. Since it's referenced by both Welcome and Boards... it's in both. (Boards.php, Welcome.php, ManagePlugins.php)
! Allow plugins to specify actions they want to add to the master action list. (ManagePlugins.php, Load.php, index.php)
----
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/index.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on October 3rd, 2011, 09:48 PM
rev 1054
(2 files, 10kb, 1 day of work >_<)

* Renamed *skeleton* functions to use the skeleton_ prefix. (Subs-Template.php, Load.php)

* loadBlock() and loadLayer() should now return the name of the layer or block they modified, or false if failed. (Subs-Template.php)

! Fixed loadBlock() not working when providing a block name and an 'after' or 'before' position, due to a recent addition that checked for a valid layer first. (Subs-Template.php)

! The layer removal code didn't work, due to how references work. Fixed some unsets and added a skeleton_remove_item() helper function to the ones you should be using (removeBlock and removeLayer). (Subs-Template.php)

! More reference errors in skeleton_insert_layer(). (Subs-Template.php)
Title: Re: New revs
Post by: Nao on October 4th, 2011, 07:22 PM
rev 1055 (janitor commit)
(10 files, 13kb)

+ Added "FileETag none" to the cache folder's htaccess, hopefully this should satisfy YSlow regarding cache optimization. (cache/.htaccess)

! An interesting SMF comment typo... Been in plain view in the single most important file for who knows how long. Finally gone... (index.php)

! Other, less amusing typos. (ManagePlugins.php)

* Added a short description for the dynamic plugin's functions. (Subs-Cache.php)

* Saving a couple of bytes off all HTML pages. Whatever... Also in the admin CSS. (index.template.php, admin.css)

! Spellcheck and Cancel buttons were broken in IE6 through IE8. (index.ie*.css)

- Removed another holiday. (other/install.sql)
Title: Re: New revs
Post by: Nao on October 4th, 2011, 11:45 PM
rev 1056 ("I should be gone... Sorry dear, I had this JS error to fix.")
(4 files, 6kb)

* Harmonized font names for monospace requests. Consolas looks better than the rest and it's a tad smaller. (index.css, admin.css)

! A recent revert in suggest.js made it fail validation when passed through Packer. (suggest.js)

* Parenthenazi. (RepairBoards.php)
Title: Re: New revs
Post by: Arantor on October 5th, 2011, 12:27 AM
Revision: 1057
Author: arantor
Date: 23:26:53, 04 October 2011
Message:
! Legacy variable being used in cache-cleaner. (Subs-Cache.php)
! Make sure the right area is used when a cross-selector is defined in a menu. (Subs-Menu.php)
----
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Menu.php
Title: Re: New revs
Post by: Arantor on October 5th, 2011, 04:34 PM
Revision: 1058
Author: arantor
Date: 15:34:05, 05 October 2011
Message:
! Split the FTP connection class into its own file, as it's the only bit of Class-Package I actually *want*, as xmlArray is going to be phased out over time. (Class-FTP.php, Class-Package.php, Subs-Media.php, PackageGet.php, Packages.php, Subs-Package.php)
! Converted modSetting enableVBStyleLogin into a more sensibly named theme setting and did a little light housekeeping with it. (install.sql, Load.php, ManageSettings.php, Subs.php, Help + ManageSettings + Themes language files, Settings.template.php)
! Removed the contiguous pages setting regarding page index (index.template.php, ManageSettings.php, Help and ManageSettings language files)
! Removed the rest of the Layout page from Features and Options now that it doesn't have anything in it, after moving the Today/Yesterday setting. (Admin.php, ManageSettings.php, Admin + ManageSettings + Help language files)
! Pretty URLs admin page should at least return something to the admin search, even if it's only the section's name, and not foul the search up. (ManageSettings.php)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Class-Package.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on October 5th, 2011, 05:34 PM
Revision: 1059
Author: arantor
Date: 16:34:18, 05 October 2011
Message:
! Don't include 'desc' type entries in the admin search, they're often not that relevant. (Admin.php)
! Move 'do admins have to approve account deletions' to the Members > Options area. (ManageMemberOptions.php, ManageSettings.php)
! Move 'require users to revalidate email on change' to Registration and split the registration options into two panes. (ManageRegistration.php, ManageSettings.php, ManageSettings language file)
! Remove the now-empty Security and Moderation > General page (Admin.php, ManageSettings.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on October 6th, 2011, 02:49 PM
rev 1060
(5 files, 8kb)

+ Temp query to update children's parent IDs when deleting a post. To do: also deal with topic splitting... (RemoveTopic.php)

* Updated top menu arrow with a version that's more in line with the current menu colors. (menurow.gif)

* Using :only-child instead of :first-child:last-child where possible. A better solution in this case would be to modify all templates to use 'centertext' in the owner div, and get rid of the p tags. If you don't understand, that's okay, just like I'm not asking you how to forge a +5 fire sword. To each their own. (index.css, index.ie8.css)

* French translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on October 6th, 2011, 07:33 PM
rev 1061
(2 files, 6kb)

! An admin maintenance page had broken HTML. (Admin.template.php)

+ Reintroduced $modSettings['compactTopicPagesContiguous'] to the page index code, but only for compatibility with SMF imports, i.e. new installs will never use it. (index.template.php)
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 11:14 AM
Revision: 1062
Author: arantor
Date: 10:14:16, 07 October 2011
Message:
! Really rearranged the display template pretty heavily. Each component is now its own subtemplate, and the list is called from Display. There's also a shift of some of the logic (like what buttons are available) being moved to the core rather than in each theme. I don't think I broke anything. (Display.php, Display.template.php)

! As a result of condensing the logic, there was really no need to have two separate hooks for the buttons, so flattened the hooks into a single generic hook at the end of general Display processing, which will have access to everything in app-wide scope. (Display.php, ManagePlugins.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/Display.template.php


@ Nao: Something in my brain told me not to make the title_upper and _lower parts (which are used for the page titles/go up+down areas) into a template layer but I'm not sure *why* my brain told me that. If you wanna change it, please go right ahead.
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 11:27 AM
Revision: 1063
Author: arantor
Date: 10:26:09, 07 October 2011
Message:
! Implemented one of the two changes from BB 2.1.14, to allow Google Web Preview requests. Haven't included the other change, which deprecates testing for # in requested URI since none of the clients that should be using Wedge should be generating that kind of URL as a referrer anyway. (Apparently some broken browsers do - though none of the ones we support, AFAIK, and certain client-side JS will, but again...) (Security.php)
----
Modified : /trunk/Sources/Security.php

@ They set it so you have to go into 'strict' mode to enable that test, but I see no reason why it needs to be deprecated for Wedge. If someone can show me a reproducible case where it's a problem, I'll deal with it.
Title: Re: New revs
Post by: Nao on October 7th, 2011, 11:39 AM
rev 1064
(5 files, 7kb)

* Always set is_ajax (whether true or not), and never set hide_chrome unless through actually calling hideChrome(). (ManageErrors.php, QueryString.php, Subs-Template.php, Help.template.php)

* Simplified errorlog viewer code which was needlessly adding headers. (Errors.template.php)
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 11:48 AM
Revision: 1065
Author: arantor
Date: 10:43:48, 07 October 2011
Message:
! Integrate the fixes from SMF 2.0.1 patch, specifically:
 ! Disable the mod center putting the session into everything. (ModerationCenter.php)
 ! Fix version detection in the package manager, in case I ever reuse that function in the plugin manager. (Subs-Package.php)
 ! Maintenance not dealing with $_POST vars properly (ManageMaintenance.php)
 ! Entity fixes, namely being sure to exclude 0x202D and 0x202E which are LTR/RTL override characters, and making sure certain characters are entitified. (Class-String.php, Subs-Members.php)
----
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Package.php
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 11:54 AM
Revision: 1066
Author: arantor
Date: 10:48:31, 07 October 2011
Message:
! Files flagged as not found in pretty URLs mode should indicate that fact when logging the error, rather than them being general errors. (Errors.php, QueryString.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 01:08 PM
Revision: 1067
Author: arantor
Date: 12:08:41, 07 October 2011
Message:
! Removed the database backup facility. It was a shade unreliable, especially in UTF-8 circumstances. There are better tools out there for this job, use them. (DumpDatabase.php, Class-DBExtra.php, ManageMaintenance.php, ManageMaintenance.template.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Class-DBExtra.php
Deleted : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 01:17 PM
Revision: 1068
Author: arantor
Date: 12:17:02, 07 October 2011
Message:
! Oops, more legacy code from the DB dumper that I forgot I didn't need. Mind you, it does give potential for more cleanup later of the Extra class. (Class-DBExtra.php)
----
Modified : /trunk/Sources/Class-DBExtra.php
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 01:32 PM
Revision: 1069
Author: arantor
Date: 12:31:48, 07 October 2011
Message:
! Any pages that use the default settings construct now display a 'Your settings have been saved' message at the top of the screen after pressing save. (ManageServer.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php


@ Of course, pages that don't use the standard settings context structure probably don't *need* this anyway because it should be fairly obvious as you head between different areas (e.g. from a summary to an edit page, back to summary) that something has been changed.
Title: Re: New revs
Post by: Nao on October 7th, 2011, 02:50 PM
rev 1070
(5 files +1, 11kb)

* Forgot to restore page title in non-Ajax errorlog file viewer. (ManageErrors.php)

* Moved Go Up and Go Down JavaScript code to an external script. (Display.template.php, topic.js)

- Moved sJumpToTemplate from JumpTo object to the HTML itself, saving us a few bytes and the need to escape the text string (which, incidentally, wasn't escaped in the first place.) (Display.template.php, MessageIndex.template.php, script.js)

@ Oops... I committed /images/.htaccess by mistake. Will remove it from the trunk in my next commit. I can't afford to have it committed until I've decided whether these files really should be cached forever...
Title: Re: New revs
Post by: Arantor on October 7th, 2011, 03:26 PM
Revision: 1071
Author: arantor
Date: 14:24:27, 07 October 2011
Message:
! Removed time/date format from being generally declared and instead made it per-language. Users can, of course, still set their own preference, but system-wide is almost invariably more dependent on language than on anything else. There is, for example, a different default for English vs French because English date/time tends to use 12 hour plus AM/PM, while French tends to use 24 hour, and this is reflected as such. I *think* I hit all the places necessary to make it work as expected, but it's possible things may be slightly buggy, I haven't had time to test everything fully for this. (install.sql, wedge_api.php, upgrade.php, Load.php, ManageNews.php, ManageSettings.php, ScheduledTasks.php, Subs.php, Profile.template.php, Language files: index, Install, ManageSettings, Profile)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/wedge_api.php
Modified : /trunk/other/upgrade.php


@ Incidentally I made sure to avoid an awkward situation that never actually caused a *problem* before but could have done. $txt['time_format'] was previously taken to be the language-dependent setting, but that very string is declared in the profile area. Fortunately, it was redeclared after $txt['time_format'] was used to determine date/time format, but as far as I'm concerned it shouldn't change both content and meaning during runtime like that, so I renamed the profile's string. (The help string has been left in because it is still used in the profile area)
Title: Re: New revs
Post by: Nao on October 7th, 2011, 05:16 PM
rev 1072
(2 files -1, 5kb)

- Reverted an accidental commit. (images/.htaccess)

! Syntax error in rev 1063. (Security.php)

! Template blocks were always ignored if not found. This is okay, except for the actual main function. I suspect this is something I did during my testing phase and I forgot to restore it... (Subs-Template.php)

* Indenazi. (Subs-Template.php)
Title: Re: New revs
Post by: Arantor on October 9th, 2011, 01:36 AM
(Oops meant to post this one earlier.)

Revision: 1073
Author: arantor
Date: 19:19:18, 08 October 2011
Message:
! Provide support for extending the visual verification system, including a hook for the relevant admin page. (ManagePlugins.php, ManageSettings.php, Subs-Editor.php, GenericControls.template.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
Title: Re: New revs
Post by: Arantor on October 9th, 2011, 01:42 AM
Revision: 1074
Author: arantor
Date: 00:35:55, 09 October 2011
Message:
! Fixing a long-standing, much irritating (to me) grammatical error. (Errors language file)

! Display what the user is doing in their profile, assuming who's online is enabled and you have permission to view it. (Profile-View.php, Profile.template.php, Profile language file)

! Some language cleanups, converting some fatal_error to fatal_lang_error calls, plus especially cleaning up some cases where strings were bolted together before being sent to fatal_error, with the side benefit that they're actually more translatable now as a result. (Activate.php, ManageMaintenance.php, ManageServer.php, Memberlist.php, ModerationCenter.php, Packages.php, Profile-Actions.php, Reminder.php, SplitTopics.php, Profile language file)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Title: Re: New revs
Post by: Arantor on October 9th, 2011, 02:05 AM
Revision: 1075
Author: arantor
Date: 01:04:43, 09 October 2011
Message:
! More cleanups of fatal_error to fatal_lang_error (including a few I broke last time in error) and cleaned up a language string or two, hopefully without getting the French translations totally wrong. Note that there's a couple of interesting fixes in there in the process. (Activate.php, Aeva-Gallery.php, Packages.php, Post2.php, Security.php, index and Post language files)

! Fix for strange error I made porting one of the last SMF patches. (Subs-Boards.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Arantor on October 9th, 2011, 03:04 AM
Revision: 1076
Author: arantor
Date: 02:04:03, 09 October 2011
Message:
! Allow spoiler=content format to set the text displayed in the button itself. Quoting should be optional, bbc should not be parsed at all in the button's text (mostly because it's not supported by browsers anyway) (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on October 9th, 2011, 11:00 AM
rev 1077
(7 files, 9kb)

! Potential empty delimiter error. (Errors.php)

! Another syntax error in fatal_lang_error. (Security.php)

* Don't show security warnings within Ajax pages. (Subs-Template.php)

* French translation. (Admin.language.php, index.french.php, ManageMaintenance.french.php)
Title: Re: New revs
Post by: Nao on October 9th, 2011, 03:06 PM
rev 1078
(25 files, 19kb)

* Telling users their latest posts are going to disappear isn't very smart, especially if you're not going to delete them in the first place. Replaced default maintenance mode string with a more... suitable default. (other/Settings.php, other/Settings_bak.php)

* French translation fixes and minor grammar. (ManageSmileys.french.php, Post.french.php, Profile.language.php, Themes.french.php)

* Moved $security_file into the relevant language string. (Subs-Template.php, index.language.php)

* Micro-optimized westr_entity. A bit. As far as I know. I think. (Class-String.php)

* Indenazi, commenazi. (other/plugin-info.rng, ManageMaintenance.php, ManagePlugins.php, ManageServer.php, ManageMedia.php, Reminder.php)

- A few backup-related strings weren't removed entirely. (other/readme_up*.html, Admin.language.php, Errors.language.php)

- And some unused language strings. (index.language.php)

! Syntax error. (Activate.php)
Title: Re: New revs
Post by: Nao on October 9th, 2011, 10:58 PM
rev 1079
(6 files, 10kb)

* Fixed/improved/tweaked main menu padding and notice handling in all browsers. (index.css, index.ie*.css)

* Not exactly sure why I used array_fill(0, count($blocks), true) instead of just $blocks... We don't care about the values in it, just about the number of items it has. (Subs-Template.php)
Title: Re: New revs
Post by: Arantor on October 10th, 2011, 02:12 AM
Revision: 1080
Author: arantor
Date: 01:12:38, 10 October 2011
Message:
! Generate the right URL if a URL is provided for admin item icons. (Subs-Menu.php)
----
Modified : /trunk/Sources/Subs-Menu.php
Title: Re: New revs
Post by: Arantor on October 10th, 2011, 02:22 AM
Revision: 1081
Author: arantor
Date: 01:22:05, 10 October 2011
Message:
! If a plugin can't be activated because of some requirement, make it more prominent (and consume slightly less space whilst not looking like rubbish) but also actually leave them the delete button in order to remove said plugin. (ManagePlugins.template.php)
----
Modified : /trunk/Themes/default/ManagePlugins.template.php
Title: Re: New revs
Post by: Arantor on October 10th, 2011, 01:24 PM
Revision: 1082
Author: arantor
Date: 12:24:25, 10 October 2011
Message:
! Allow a plugin to indicate that a given hook to be used is optional: that it should be registered as if to be called, but that it isn't a strict dependence, so if you know another plugin has a given hook, you can register for it but if the other plugin isn't installed, it'll just not do anything. And bonus: if you later install the other plugin, no extra work is required, it'll just work as expected. (plugin-info.rng, ManagePlugins.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on October 10th, 2011, 01:57 PM
rev 1083
(2 files, 4kb -- larger commit coming up.)

* Minor optimization with URL matching. (Subs-Media.php)

! Suspecting a typo here... (other/plugin-info.rng)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 02:01 PM
rev 1084
(16 files, 33kb)

* Created a 'wetem' (Wedge Template) object, where the entire skeleton system has been moved. Among the functions that will be of interest to modders, loadBlock() is renamed to wetem::load, loadLayer() to wetem::layer, removeLayer() and removeBlock() to wetem::remove, and hideChrome() to wetem::hide. (Subs-Template.php)

+ Testing for a layer or block's presence in the skeleton is now done through wetem::has_block() or wetem::has_layer(), or generally through wetem::has() which will return true if it finds a block of layer with that name. (Profile.php, Security.php, Subs-Template.php)

* Started fixing files to use the object. (index.php, Boards.php, Display.php, ManageAttachments.php, ManageMedia.php, ManageMedia3.php, PersonalMessage.php, Profile.php, Subs-Menu.php, Welcome.php, SSI.php)

* Moved post list to a layer. The code looks complicated for now, but with the next rewrite it will be much simpler. (Display.php, Display.template.php)

@ Note: Wedge will BREAK on many pages with this release, as I need to finish converting all files to use the template object, as well as reprocess the object to use a more general method to handle both blocks and layers. Please bear with me.
Title: Re: New revs
Post by: Nao on October 10th, 2011, 02:08 PM
rev 1085
(79 files, 55kb)

* Converted remaining loadBlock calls to wetem::load(). (other/unittest/index.php, skins/Warm/skin.xml, 77 source files)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 02:22 PM
rev 1086
(2 files, 5kb)

! Fixed crash that occurred when saving a PM draft with an unknown recipient. Because getPmRecipients was called without going through MessagePost2 first, the Subs-Auth file wasn't loaded in the first place. (PersonalMessage.php)

! Layout issue in Personal Message area when using wrc class on non-PM elements, i.e. anything outside the PM list. (index.member.css)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 05:50 PM
rev 1087
(4 files, 8kb)

* Sorted the wetem methods to put the public ones at the front. Turned wetem into a final class and converted variables to private. Until we find a good reason to make wetem inheritable, it should remain locked from view. (Subs-Template.php)

* Commenazi. (Errors.php, Themes.php, Subs-Template.php, index.template.php)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 05:54 PM
rev 1088
(35 files, 23kb)

* Commenazi - renamed all 'sub template' (without a dash) to 'block'. (SendTopic.template.php, Themes.template.php, and 33 source files.)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 09:23 PM
rev 1089
(4 files, 12kb)

+ wetem::load() can now process multidimensional arrays where sub-arrays are layers. New child layers should be properly indexed, too. (Boards.php, Display.php, Subs-Template.php, Welcome.php)

* Renamed a few ::layer options. 'replace' to 'rename' (because it's ultimately what it does), 'erase' to 'replace' (makes more sense), 'firstchild' to 'first' and 'lastchild' to 'add' (for consistency with ::load). Considering whether we should remove some of these options in favor of the use of ::load()... (Subs-Template.php)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 09:26 PM
rev 1090
(14 files, 11kb)

! Forgot to rename hideChrome() to wetem::hide(). (unittest/index.php, CoppaForm.php, Help.php, ManageBans.php, ManageErrors.php, ManagePlugins.php, Aeva-Gallery.php, ModerationCenter.php, Packages.php, PrintPage.php, Reports.php, Spellcheck.php, VerificationCode.php, ViewRemote.php)
Title: Re: New revs
Post by: Nao on October 10th, 2011, 10:54 PM
rev 1091
(17 files, 18kb)

* Layers used to have _above and _below functions. These have now been renamed to _before and _after, for simplicity. Please note that due to the peculiarity of layers, you can override or overload these two special functions, unlike the _before and _after that are attached to any block. See example in Welcome template. (Reports.php, Subs-Template.php, Welcome.php, TEMPLATES: Display, index, InfoCenter, ManageAttachments, ManageMedia, Media, PersonalMessage, PrintPage, Profile, Reports, Welcome, Wireless)

! Reports was using a layer with the same name as its contained block. Although technically it worked, it's bad practice. I should probably refuse adding blocks when a layer of the same name already exists... (Reports.php, Reports.template.php)

- A colon was stored in the language files when other strings on the same page stored it in the template itself. (Profile.language.php, Profile.template.php)

@ Note: I'm open to suggestions regarding a way to clarify the fact that template_layer_before() can be overloaded with template_layer_before_before() or _after(), while template_block_before() can't... :P
Title: Re: New revs
Post by: Arantor on October 11th, 2011, 10:14 AM
Revision: 1092
Author: arantor
Date: 09:13:48, 11 October 2011
Message:
! Plugin manager should now sort case-insensitively. It's still going to be off if there are mixed languages present, but there's no good way around that. (ManagePlugins.php)

! Provide filtering capability in the plugin manager, filtering by all/enabled/disabled/can't-be-enabled (aka incompatible) (ManagePlugins.php, ManagePlugins.template.php, ManagePlugins language file)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Title: Re: New revs
Post by: Arantor on October 11th, 2011, 11:20 AM
Revision: 1093
Author: arantor
Date: 10:18:57, 11 October 2011
Message:
! Clean up of the internal plugin manager code. No need to tell it to iterate every child and test the element name, we can do that with the foreach and have it filter for us automatically. (ManagePlugins.php)

! Remove the need for Class-Package in the language pack getter. One step closer to purging the xmlArray class! (ManageServer.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageServer.php


(The point of getting rid of the xmlArray class (Class-Package) is that it's 17KB of XML handling that we don't need when SimpleXML will do the job just as well, if not faster. The only uses left now for xmlArray are in the old package manager, which I'm working on phasing out.)
Title: Re: New revs
Post by: Arantor on October 11th, 2011, 01:08 PM
Revision: 1094
Author: arantor
Date: 12:00:34, 11 October 2011
Message:
! If a plugin is already enabled, disallow any other plugin using the same id from being enabled. Anyone upgrading a plugin will by definition need to disable the older one before enabling the new one. (The whole nature of hot-upgrade-in-place is fraught with danger. It depends how much initialisation you do on start-up, we don't do much for performance's sake, which means caches etc. MUST be cleared by next runtime on a plugin's run. By forcing that break, it makes everything a lot safer.) (ManagePlugins.php, ManagePlugins language file)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Title: Re: New revs
Post by: Arantor on October 11th, 2011, 01:14 PM
Revision: 1095
Author: arantor
Date: 12:08:05, 11 October 2011
Message:
! Performance optimisation that actually didn't work properly (ManagePlugins.php)

! Improved layout when there's an error in plugins. (ManagePlugins.template.php, admin.css)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/skins/admin.css
Title: Re: New revs
Post by: Arantor on October 11th, 2011, 02:00 PM
Revision: 1096
Author: arantor
Date: 12:59:57, 11 October 2011
Message:
! Cleaned up some language strings, less of this composite stuff and more unified strings that can be translated meaningfully. (Load.php, SSI.php, InfoCenter.template.php, index.english.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on October 11th, 2011, 03:40 PM
rev 1097
(6 files, forgot to check size)

* The PM area in the info center should use $txt['personal_messages'] rather than $txt['personal_message'] as its title. Also removed the odd duplicate, added whitespace and increased the font size for the previously smalltext details. (InfoCenter.template.php)

- Removed $txt['msg_alert_you_have'], $txt['msg_alert_messages'] and $txt['your_pms'], unused in Wedge. Or even SMF probably. (index.french.php)

- Removed support for Imeem from Aeva. That's three entries in the sitelist. Apparently they were bought out by MySpace two years ago and nobody bothered to tell me, eh eh. I suspect there are dozens more such dead websites in the list... Anyone willing to test them? (Subs-Aeva-Sites.php)

- Removed an unused parameter in setFocus(). (editor.js)

* French translation. (index.french.php, ManagePlugins.french.php)

! Undefined global in is_already_taken(). (Subs-PrettyUrls.php)
Title: Re: New revs
Post by: Arantor on October 11th, 2011, 05:08 PM
(44KB, 49 files)

Revision: 1098
Author: arantor
Date: 16:08:17, 11 October 2011
Message:
! More language clean-ups, mostly to purge variables from language files. It's not finished but I have things to do out here in RL, NB this has not been tested either :( (Sources: Feed, ManageAttachments, ManageMemberOptions, ManageNews, ManagePaid, ManageSettings, media/Aeva-Foxy, Profile-Actions, Reminder, ScheduledTasks, Subs-Post, Subs-Template, Who, Templates: Boards, Display, index, ManageNews, MessageIndex, ModerationCenter, PersonalMessage, Profile, Language files: Admin, Errors, index, ManageMembers, ManagePaid, ManageSettings, Media, ModerationCenter, Modlog, PersonalMessage, Post, Profile, Stats, Who)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.french.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/ManagePaid.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Media.english.php
Modified : /trunk/Themes/default/languages/Media.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/Stats.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Arantor on October 12th, 2011, 01:40 AM
Revision: 1099
Author: arantor
Date: 00:38:27, 12 October 2011
Message:
! Added probably-working support into the add-column code for ENUM/SET types. Not tested. Also cleaned up old parameters for the add/change/remove column functions because they're not needed for MySQL. (Class-DBPackages.php)
! Whoa, boy. Various bits of deduplication of code since we don't expressly have to call for children() when we only want one type of child node, plus factoring duplicate tests and code (some of which were actually ignored) into their own functions, and making sure that the DB cleanup stuff actually had access to the manifest file, meaning that DB changes are actually undone when the appropriate call is made. Oh, and hopefully added support for adding individual columns from the install (and appropriate cleanup), not yet tested having since found a bug elsewhere. (ManagePlugins.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManagePlugins.php


@ The bug in question is that my snazzy code for pruning folders on uninstall chokes on nested subdirectories. Which for all the ones I'd tested thus far, it wasn't a problem because they only had their own files in their own little world. All the ones I have in Plugins/ now have an .svn tree attached, which chokes it. (As does WedgeDesk but I'd never tested that since I added the remove folders code)
Title: Re: New revs
Post by: Arantor on October 12th, 2011, 01:53 AM
Revision: 1100
Author: arantor
Date: 00:52:57, 12 October 2011
Message:
! Another minor optimisation in plugins, and using the right function name. (ManagePlugins.php)
! Don't bother carrying on the package log from the DB changing functions. (Class-DBPackages.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManagePlugins.php
Title: Re: New revs
Post by: Arantor on October 12th, 2011, 02:09 AM
Revision: 1101
Author: arantor
Date: 01:09:28, 12 October 2011
Message:
! More of the variable removals from the language files. Still not tested. (CoppaForm.php, Profile-Modify.php, Who.php, and language files: Login, Media, Profile, Who)
----
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/Media.english.php
Modified : /trunk/Themes/default/languages/Media.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php


@ The outstanding items are EmailTemplates, Help and index. These have special needs compared to normal items, which doesn't help much.
Title: Re: New revs
Post by: Nao on October 12th, 2011, 09:27 PM
rev 1102
(11 files, 11kb)

! Long-standing SMF bug: finally got rid of these 'Last post by ... in ... on Today'. It's not proper English, it should use on_timeformat(). (MessageIndex.php, Subs-BoardIndex.php, index.language.php)

* More {string} optimizations. (Subs-Template.php, Subs.php, index.language.php, Help.language.php)

! Quick and temporary hack for fixing the default English time format when removing the year. (Subs.php)

- $_GET['in'] is already tested as valid, no need to re-test it. Also optimized the string modification. It's only used on two strings, is that really worth a_preg_replace...? (Help.php)

- Removed $txt['your_pms'] from the English version as well. (index.english.php)

! French version had an incorrect default time format. (index.french.php)

* Indenazi. (Boards.template.php, MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on October 12th, 2011, 10:34 PM
rev 1103
(8 files, 12kb)

* Replaced individual {scripturl} replacements with a page-wide buffer replacement. It only takes a few microseconds. (Load.php, ManageAttachments.php, Subs-Cache.php, Subs-Template.php, Who.php, index.template.php, ManageNews.template.php, ModerationCenter.template.php)
Title: Re: New revs
Post by: Arantor on October 13th, 2011, 02:13 AM
Revision: 1104
Author: arantor
Date: 01:13:01, 13 October 2011
Message:
! Removed globalisation of $helptxt variable in the Help language files, and just extended the two places it would actually make a difference in terms of making sure the variable was available. (Help language file, Subs.php, Subs-Template.php)
! Removed birthdays from the core code. Everything of use can either be retrieved from diffs, or I've already copied it over to the plugin. (install.sql, ssi_examples.php, SSI.php, skins/index.css; Sources: Boards, Calendar, Feed, ManageCalendar, ManageMail, ScheduledTasks, Subs-Calendar, Subs-Members, Subs-Template, Welcome; Templates: Calendar, InfoCenter; Languages: EmailTemplates, Help, index, ManageCalendar, ManageMail, ManagePermissions, ManageScheduledTasks)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageCalendar.english.php
Modified : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/Themes/default/languages/ManageMail.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.english.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/other/install.sql
Modified : /trunk/other/ssi_examples.php
Title: Re: New revs
Post by: Arantor on October 13th, 2011, 04:51 PM
Revision: 1105
Author: arantor
Date: 15:51:21, 13 October 2011
Message:
! Allow hooks to indicate a priority value. Hooked functions of equal priority will be assumed to be able to run in any given order without any issue. It defaults to 50, and runs on a scale of 1 to 100, with 100 being the highest priority. While there's nothing to stop authors just forcing everything to 100, the default should be perfectly adequate in the vast majority of cases, except if you know in advance that you have to run something before or after something else. In my case, I need to run birthdays after the calendar, so that birthdays know to hook into the calendar properly in the board index. Is complicated. (Load.php, ManagePlugins.php, plugin-info.rng)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on October 13th, 2011, 08:30 PM
rev 1106
(15 files, 21kb)

* Moved URL replacements to the very end, to avoid URLs not being transformed in some situations. (Subs-Template.php)

* Renamed {scripturl} to <we:scripturl> to avoid literal uses of {scripturl} in user posts to be converted on the fly. Also converted the quote tag entry and removed a few str_replace calls that were now useless. (other/install.sql, Subs-BBC.php, Subs-Template.php, SSI.php, index.template.php, Warm/skin.xml, LANGUAGES: Admin, index, ModerationCenter, Who)

! $context needed to be globalized. (Who.php)
Title: Re: New revs
Post by: Nao on October 13th, 2011, 09:21 PM
rev 1107
(8 files, 9kb)

- Removed a non-existent birthday function call. (other/ssi_examples.shtml)

! French translation fixes. (EmailTemplates.french.php, Help.french.php, index.french.php, ManagePermissions.french.php, Profile.french.php)

* Minor tidbits and unused strings. (index.english.php, Profile.english.php, Profile.french.php)
Title: Re: New revs
Post by: Nao on October 13th, 2011, 11:17 PM
rev 1108
(13 files, 18kb)

! Fixed a very odd skeleton bug where the skeleton would be emptied after reindexing it for the Nth time. I think my... solution to the problem is even weirder than the bug itself. (Subs-Template.php)

* Renamed <we:scripturl> to <URL>, because we can. And to fix a conflict with macros. (other/install.sql, Subs-Template.php, index.template.php, Warm/skin.xml, LANGUAGES: Admin, index, ModerationCenter, Who)

- Useless $scripturl. (Subs-BBC.php)
Title: Re: New revs
Post by: Arantor on October 14th, 2011, 12:42 PM
Revision: 1109
Author: arantor
Date: 11:41:34, 14 October 2011
Message:
! No need to update the calendar_updated variable if a user changes their DOB; this is done by the birthday plugin all on its own through the change_member_data hook. (Profile.php)
! Add a hook for deleting topics en masse. (Note that merely moving to the recycle bin, as it stands, will not trigger the hook - but then it's not supposed to. This hook is for clearing out any topic-related data on topic deletion.) (ManagePlugins.php, RemoveTopic.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/RemoveTopic.php
Title: Re: New revs
Post by: Arantor on October 14th, 2011, 02:07 PM
Revision: 1110
Author: arantor
Date: 13:06:48, 14 October 2011
Message:
! Rename the actions hook to action_list; there was a conflict with how the action handler was handled in the plugin cache, causing it to dump any references for the actions hook. (ManagePlugins.php, index.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Arantor on October 14th, 2011, 03:13 PM
Revision: 1111
Author: arantor
Date: 14:12:50, 14 October 2011
Message:
! When removing a plugin, don't just purge the entry from the scheduled tasks list, also make sure to purge the log of having carried them out. The log entries aren't available anyway because of the INNER JOIN. (ManagePlugins.php)
! Allow for - in language file names, e.g. Birthday-Admin.language.php. Stupid non-actual-bug. (ManageServer.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageServer.php
Title: Re: New revs
Post by: Nao on October 14th, 2011, 11:46 PM
rev 1112
(7 files, 11kb)

* Replaced a few dozen $scripturl calls with <URL>, just to get the hang of it... It doesn't impact performance (positively or negatively), and it still requires checking all occurrences one by one (can't use <URL> inside a JSE call for instance), so I doubt I'll be converting everything... (Display.template.php, PersonalMessage.template.php, Who.template.php)

* Moved profile link replacements for guests to below the scripturl replacement code, to make sure we can use <URL> in profile links. (Subs-Template.php)

* Renamed 'last_msg' to 'last' in Quote links, if only because the 'quote' variable doesn't have '_msg' in it either. And it's shorter. (Post.php, Post2.php, Display.template.php)

! Fix for signature header size in profiles... Whatever. (sections.css)
Title: Re: New revs
Post by: Arantor on October 16th, 2011, 03:21 AM
(removed 2, modified 42, 37KB)

Revision: 1113
Author: arantor
Date: 02:20:45, 16 October 2011
Message:
! Probably the most scary commit for me personally since working on Wedge: removing OpenID and all its tendrils into the system, because it's integrated into the login, registration, reminder etc. systems. I don't think I've broken anything, I've gone through and tested logging in and out, registration, reminders and changing password in profile and everything seems to be working as expected, even with throwing invalid passwords as it. It's being removed because it should really be a plugin but I'm not really planning on building a plugin out of this code, because it's OpenID 1.1 not 2.0, and honestly, there are number of implementation details that don't sit right anyway. (index.php, install.*, SSI.php, Class-UnitTest.php; Sources: Class-DBPackages, Load, Login2, Logout, ManageRegistration, Profile-Modify, Profile, QueryString, Register, Reminder, ScheduledTasks, Security, Subs-Login, Subs-Members, Subs-OpenID (removed); Templates: index, Login, Profile, Register, Wireless; CSS: index.guest, index.rtl, Wuthering/index.rtl; Languages: EmailTemplates, Errors, Help, index, Login, Profile, Who; also removed openid.gif)

! Random bug when changing the password in profile, if it had too few characters, the un-sprintf'd string was used. (Subs-Members.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Deleted : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Deleted : /trunk/Themes/default/images/openid.gif
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/Wuthering/index.rtl.css
Modified : /trunk/Themes/default/skins/index.guest.css
Modified : /trunk/Themes/default/skins/index.rtl.css
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest.php
Title: Re: New revs
Post by: Nao on October 16th, 2011, 10:36 AM
rev 1114
(x files, 10kb - And thank you Pete for taking the time to specify your commit sizes now :))

* SEO optimizations. Shh!

* Converted all $scripturl to <URL> in the index template. There can be only one! (index.template.php)

- A couple more deletions related to OpenID. I believe openid_uri should be removed as well, and reinstalled by the plugin... If someone wants to convert an SMF install to Wedge, they could install Wedge, enable the OpenID plugin (if it exists), and then do the importing. (install.sql, upgrade.sql, xml/detailed-version.php)
Title: Re: New revs
Post by: Nao on October 17th, 2011, 04:36 PM
rev 1115
(2 files, 6kb)

* Improved year trimming code in timeformat() to account for more possible time formats. (Subs.php)
- Removed another $txt['time_am/pm'] reference. (Subs.php)
- Removed another OpenID reference. (upgrade.sql)
Title: Re: New revs
Post by: Nao on October 17th, 2011, 04:52 PM
rev 1116
(8 files, 9kb)

+ Added membergroup color to user links. Logic dictates that this should be done. (And that's when you begin to realize that red isn't such a great color for the admin group...) (Load.php)

- Replaced $txt['profile_of'] with $txt['view_profile'] to avoid stupid repetitions. There's no such thing as free bandwidth. (Load.php, MessageIndex.php, Search2.php, Unread.php, UnreadReplies.php, Who.template.php, index.language.php)
Title: Re: New revs
Post by: Nao on October 17th, 2011, 09:34 PM
rev 1117
(8 files, 9kb)

+ Added a $txt['time_format_this_year'] string that contains the year-less time format string, for faster processing in timeformat(). (Subs.php, index.language.php)

- Removed the last remains of the OpenID code... Hopefully. (Class-UnitTest.php, Register.php, Subs-Members.php)

! It's AM/PM, not am/pm... As sad as it sounds. (Help.language.php)
Title: Re: New revs
Post by: Arantor on October 18th, 2011, 04:13 PM
(303KB[1], added 2, modified 4)

Revision: 1118
Author: arantor
Date: 15:10:30, 18 October 2011
Message:
! Fix for QueryString not urldecoding as it should (thanks TE) (QueryString.php)

! Missing hooks should have been declared in plugin manager (ManagePlugins.php)

! Part of the works for supporting file permission changes in the plugin manager. It's horribly unfinished right now but I want to commit it because even right now it's actually an improvement on where we were - for cases where FTP/SFTP is not required, it actually works properly in being able to recursively delete things, and it has been built in such a way that extending it to FTP/SFTP shouldn't be a slog; I've actually designed it around having file-changing classes that it should be able to interchangably use, Class-FileWritable for locally writable cases (though it doesn't use that as thoroughly as it should, it should be checking the entire permissions of every file/dir under consideration, not just the first level!), Class-FTP or Class-SFTP for where S/FTP connectivity is needed. Class-SFTP has not been tested since I made my changes to phpseclib, so it's probably broken too - or it might be, if I actually put in the relevant dialogue, which I haven't yet. Just wanted to get something committed where it actually works in a meaningful way compared to what it was before! This is, then, very much still a WIP. (Don't worry about reviewing Class-SFTP at this stage...) (ManagePlugins.php, Subs-Plugins.php, ManagePlugins language file, ManagePlugins.template.php, Class-FileWritable.php, Class-SFTP.php)
----
Added : /trunk/Sources/Class-FileWritable.php
Added : /trunk/Sources/Class-SFTP.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php

@ Yeah, this is probably a bit earlier than it should have been, but a few notes on the design of it. The idea is that getWritableObject() is essentially the same construct as create_chmod_control but without having to be so formal about it. Either it'll return you a usable object with which you can do file operations, or it'll take you to a dialogue to enter S/FTP connection details. Or it would if the dialogue was any more than a placeholder.

It is still incredibly raw but it's getting there.
 1. As noted in the changelog the vast bulk of this is Class-SFTP, which doesn't need reviewing at this time unless you're feeling very, very brave. It's probably slightly broken anyway.
Title: Re: New revs
Post by: Nao on October 18th, 2011, 05:57 PM
rev 1119
(7 files, 8kb)

* Microsecond optimization. I'm only doing this because it's in the cache code, and the cache is all about speed... (Subs-Cache.php)

* String concatenation optimization. As if. (Display.template.php)

* Typos. (ManagePlugins.english.php, ManagePlugins.php)

* Translation. (ManagePlugins.french.php)

! The two new files were missing the closing '?>'. I know it's not that bad, but if we should do it for one, we should do it for all of them ;) (Class-FileWritable.php, Class-SFTP.php)
Title: Re: New revs
Post by: Nao on October 18th, 2011, 06:34 PM
rev 1120
(11 files, 19kb)

+ Wedge will now happily use the membergroup's color when showing profile links -- all the time, instead of just in the Who's Online list and info center. (Subs-Template.php, Subs.php, ManageMembers.language.php)

* Changed default admin and global moderator membergroup colors to something neater that doesn't jump at you. Added a default color for the Hero group (i.e. members with over 500 posts.) (other/install.sql)

- Removed group color retrieval queries from Who's Online and Info Center, since this is being handled elsewhere now. (Subs-MembersOnline.php, Who.php, Who.template.php)

- Removed ability to sort online members by group color... Did anyone actually know this was possible? And what was the point, considering sorting by group name is also possible? (Subs-MembersOnline.php)

- SSI's ssi_recentTopics() never made use of membergroup colors either. (SSI.php)

* I like #c06002 as a color, but h4 (poster name in display template) will now be a virgin when it comes to default color. (sections.css)

+ Profile pages will now show the group/post-group color on the user name, even though it's not technically a profile link. (Profile.template.php)
Title: Re: New revs
Post by: Nao on October 19th, 2011, 10:55 AM
rev 1121
(16 files, 21kb)

* Updated mini-logos with the current stuff. (images/minilogo*.png)

* Allow show_group_key to show post-based groups instead of just regular groups. The reason? If you're setting a special color for high-level posters, wouldn't you want people to be able to browse them...? (Subs-Membergroups.php)

- Removed $txt['or'], which was only used when OpenID was enabled. I guess I'm good at spotting this kind of crap. Plus, we want to avoid generic word translations as much as possible. I never knew the generic Japanese word for that, come to think of it. Is that または? Hey, SVN supports complex languages, that's cool. Oh yeah, the changelog. (index.language.php)

* Renamed $txt['all'] to $txt['all_pages'], to prevent plugins from reusing it for other purposes. See, in French, 'all' is either 'tout', 'tous' or 'toutes', depending on the context. How are we supposed to act when the plugin provides no context? (index.language.php, Display.php, MessageIndex.php, Unread.php, UnreadReplies.php)

* Renamed $txt['unread_topics_all'] to $txt['unread_topics'], because we no longer have the alternative anyway. Also updated URLs to remove ';all' from them and related logic. (index.language.php, Unread.php, UnreadReplies.php, Recent.template.php)

- 'group_index' is a non-existent block... Good work, eh. (Groups.php)

- $footer_bg is used in Warm, not Wine. (index.css, Warm/index.css)

* Had some weird, dangerous fun with Warm... Okay, okay, I'm letting it go now. (Warm/index.css)

* Reordered field lists in loadMemberData's giant queries. Because it looks cooler. (Load.php)

* Info center needs more breathing space in Welcome. I think. (Welcome.template.php)

* Spacinazi. (ManageMembergroups.template.php)
Title: Re: New revs
Post by: Nao on October 19th, 2011, 04:31 PM
rev 1122
(6 files, 11kb)

+ Added support for external CSS file loading in skin files (<css include="">). (Subs-Cache.php)

+ Added an example in the form of Warm now using Droid Sans by default, retrieved from Google WebFonts. (Warm/index.css, Warm/skin.xml)

* File lists in JS and CSS includes inside skin files, now need to be separated by spaces, instead of a comma. True enough, commas may be used in URLs while spaces are always urlencoded... (Subs-Cache.php, Warm/skin.xml, Wuthering/skin.xml)

* Minor fixes. (Reports.php, index.css)
Title: Re: New revs
Post by: Arantor on October 20th, 2011, 02:59 AM
(42K, added 2, modified 10)

Revision: 1123
Author: arantor
Date: 01:56:49, 20 October 2011
Message:
! Replace fetch_web_data with Class-WebGet, which supports cURL, arbitrary ranges and headers. (Class-WebGet.php, upgrade.php, ManageServer.php, PackageGet.php, Profile-Modify.php, ScheduledTasks.php, Subs-Graphics.php, Subs-Package.php, Subs-Template.php, Themes.php)

! Replace the url_image_size routine with a newer one that doesn't require the whole file. It works nicely on GIF and PNG and the vast majority of JPEGs (at least in my testing) without having to go and download however big the file actually is, which should limit timeouts and stuff like that. (Subs.php)

! Subs-Plugins appears not to have been committed before for some reason (should have been in 1118) :/
----
Added : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Package.php
Added : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/other/upgrade.php

@ I have no idea why Subs-Plugins wasn't committed before but there's no reason why it shouldn't have been.

@ There is still a fetch_web_data function in the webinstaller, mostly because it comes with its own version, rather than using anything in the core (because that's the point)

@ Also, no idea why this commit is so big.
Title: Re: New revs
Post by: Arantor on October 20th, 2011, 03:05 AM
Revision: 1124
Author: arantor
Date: 02:05:35, 20 October 2011
Message:
! Stupid, stupid syntax error where I wasn't developing directly on the SVN files, and forgot to copy all the changes across properly. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on October 20th, 2011, 03:52 AM
Revision: 1125
Author: arantor
Date: 02:51:20, 20 October 2011
Message:
! Another stupid typo. (ManageServer.php)
! cURL is smart enough to decode chunked data, but when we use HTTP/1.1 requests manually, we need to unchunk it too, yay? (Class-WebGet.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/ManageServer.php


@ I didn't spot this one because the data I was using never got chunked, but it broke the admin request files stuff. I only wish I'd known this like this morning, rather than discovering it at almost 2am. Still, it's fixed now.
Title: Re: New revs
Post by: Arantor on October 20th, 2011, 11:31 PM
(1 file, missed the size but it's about 6 lines in total affected!)

Revision: 1126
Author: arantor
Date: 22:25:40, 20 October 2011
Message:
! Replaced browser specific styling hacks for splitting words with soft-hyphen entity. It really needed to be done! (Subs-BBC.php)

! Slight performance tweak in the BBC parser, avoiding extra string slicing once per tag. (Subs-BBC.php)
----
Modified : /trunk/Sources/Subs-BBC.php


Also note there is currently a fairly large bug in the preparser/parser where autolinked URLs are thoroughly mashed up.

Typing this in a post in a post, expecting it to be autolinked:
Code: [Select]
http://wedge.org/

Results in:
Code: [Select]
[url]http://[url]http://wedge.org/[/url][/url]
being generated in the physical post which is rendered as:

Code: [Select]
http://[url]http://wedge.org/[/url]

It is definitely a preparsing problem because it's stored like that. That said, something's distinctly odd about how it works because if I have the link written out twice on two separate lines (link / blank line / link), and it's done through the quick modify, neither are linked, but if I manually put URL bbcode around the second link, both are linked.

I think we've thoroughly broken the preparser and parser somewhere (but the above happens even with the r1125 version of Subs-BBC.php)


:edit: So, I'm waiting for r1127 to be posted here, committed what I thought was a fix in r1128 but it seems that the parser is still broken, more details when I post r1128.
Title: Re: New revs
Post by: Nao on October 21st, 2011, 12:05 AM
(lol, I was posting this one just to make sure we had at least one commit up for today... Seems you didn't need me :P)

rev 1127
(2 files, 7kb)

+ Added hidden variable ($modSettings['minify_html']) and my inline JS dynamic minification code. Well, it needs to be cached really, then maybe I'll consider adding a UI setting for it. Also threw in free indentation removal in the HTML source. (Subs-Template.php)

! Fixed some minor glitches in Warm. (Warm/index.css)

@ Note re: rev 1126, how do we find this one out..? Should we revert to a random rev until we find which rev broke it...? It's likely to take some time...

:edit: Sorry, I forgot to hit 'Submit' and was looking into your rev's code, and went into fixing other things etc... My bad!
Title: Re: New revs
Post by: Arantor on October 21st, 2011, 12:10 AM
(1 modified, again missed the size, sorry, but it's half a dozen lines again)

Revision: 1128
Author: arantor
Date: 22:42:02, 20 October 2011
Message:
! Under some circumstances two calls could be put into the embedder code which had the interesting side effect of mulching certain operations. Not calling it twice seems to rectify all issues observed while testing previous revision, without introducing any other issues into link parsing. (Post2.php)
----
Modified : /trunk/Sources/Post2.php


@ After more playing about I can still get it to break, though it is less broken than before. Specifically now, if a link is posted it will be handled correctly normally in both full and quick edit, but if the post is subsequently modified, it will be wrapped in url tags which are not handled correctly. It's really *really* irritating, seeing how there is a url tag with = parameter (i.e. [url=http://wedge.org]wedge[/url]) which has worked the entire time, and not been mulched with the above one bit. Also Aeva embedding works just fine even with this patch, both quick and full edit.

IOW: quick edit is always correct, full edit is not, yet they seem to use the same code path! The bbc parser itself seems to be handling what's given to it correctly, but that full edit is breaking the link handling.

Sure, we can go through every change in either Subs-BBC or Class-Editor back to r1 (including when they weren't originally in those files!) but I'd rather concentrate on finding where it does it and not making it do it again.

More specifically I want to know what the difference in code paths is between quick and full edit because quick edit seems to be consistently correct, and I don't know why. I thought the difference was the chunk I removed in r1128 (given its comment, it seemed likely) but it's more than that.
Title: Re: New revs
Post by: Arantor on October 21st, 2011, 02:19 PM
(8 modified, again forgot to notice the size :()

Revision: 1129
Author: arantor
Date: 13:18:44, 21 October 2011
Message:
! Some missing hooks from the plugin manager's known list. (ManagePlugins.php)

! The dialogue for uploading plugins (though not functional yet) and for managing (adding/editing/removing) plugin repositories, though not browsable yet. (install.sql, Admin.php, admin.css, ManagePlugins.php, ManagePlugins.template.php, Admin and Help and ManagePlugins language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Modified : /trunk/Themes/default/skins/admin.css
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on October 21st, 2011, 08:47 PM
rev 1130
(7 files, 21kb)

* Spacinazi and a typo. (ManagePlugins.php, Subs-Plugins.php, ManagePlugins.english.php)
* Translation. (Admin.french.php, Help.french.php, ManagePlugins.french.php)
* fixLongWords doesn't need to define a $breaker variable. (Subs-BBC.php)
Title: Re: New revs
Post by: Arantor on October 23rd, 2011, 11:50 PM
(1 modified, 1KB)

Revision: 1131
Author: arantor
Date: 22:46:12, 23 October 2011
Message:
! If using url_image_size, make sure that we send a valid Accept header. This won't make a huge difference in most cases but if the user is requesting an attachment that's going to be served through Wedge, the request will be killed otherwise. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on October 25th, 2011, 04:54 PM
(2 modified, 3KB)

Revision: 1132
Author: arantor
Date: 15:54:11, 25 October 2011
Message:
+ Admin panel settings pages, where they use inline permissions, the inline permission can now set - if it wants - per permission exclusions by group, so for instance you could put a general access and an admin level access permission in the same page if you wanted. (ManagePermissions.php, ManageServer.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageServer.php
Title: Re: New revs
Post by: Nao on October 25th, 2011, 09:54 PM
Can't believe I didn't commit anything for 4 days...

rev 1133
(4 files, 7kb)

* Wedge will now only show the meta charset on topic pages. The idea behind this is that the UTF8 format is already specified through the headers, and the only reason we'd want to have the charset specified in the HTML is if the page is going to be saved for offline browsing. It's unlikely to happen for anything that's not a topic page... (index.template.php)

* Search icon was off by a pixel. (Warm/index.css, Wuthering/index.css)

! Fixed on_timeformat() and on_date() to work on English strings (the new time format broke it). on_date() is currently not used in Wedge, so I might remove it in the future. (Subs.php)
Title: Re: New revs
Post by: Arantor on October 26th, 2011, 03:51 PM
(5 modified, 13KB)

Revision: 1134
Author: arantor
Date: 14:51:19, 26 October 2011
Message:
! A bit more of the plugin stuff for the repository handling. It's still not finished either but hey, might as well commit it anyway. Also, be sure to lock out the plugin upload/download if gzinflate is not available. (ManagePlugins.php, ManagePlugins.english.php)
! New hook for CAPTCHA handling, if a plugin wants to extend the existing CAPTCHA framework. (Subs-Captcha.php, ManagePlugins.php)
! New hook for deleting members in bulk. It doesn't replace delete_member, because depending on what you're doing, it may not make a lot of difference whether you get them one at a time or in bulk. But there is a benefit to having the bulk query - for if you do actually do big deletes that hit lots of people at once - and unlike delete_member, delete_member_multiple can also rewrite the delete list if needed (e.g. to protect against certain users being removed for whatever reason. Use with caution!) Also note the delete_member hook itself has changed, to provide both the user id and name, not just user id. (Subs-Members.php, ManagePlugins.php)
! New hooks for Who's Online. One extends the list of actions that have to have permission in order to be visible, the other provides the entire dataset to hooks. While it might be practical under some circumstances to offer per-entry items to a hook, if there's going to be a query to get data (e.g. much like there is with topics, you want to be sifting that out before querying) (Who.php, ManagePlugins.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Title: Re: New revs
Post by: Nao on October 26th, 2011, 07:34 PM
rev 1135
(6 files, 15kb)

! Most browsers didn't like my latest changes to menu paddings. Removed an old min-height: 0 hack that seemed to bother them... Yeah, don't ask me, it's kinda obscure to me too. Tested in Chrome, Opera 11.5/12, IE 7/8/9 and FF7. (index.css)

- Removed IE6 iframe shim support from menu code. The reasoning: IE6 users are noobs. They don't install forums. They wouldn't even notice if a menu item is behind a form element. While I'm okay providing shims for IE6 when it doesn't add code to *other* users, in this case IE6 represented a 25% overhead for the menu code, and 5% of the script file. For everyone. Now it's gone. Good riddance. (script.js, index.ie6.css)

* Made delimiters more generic for the false/true JS minification trick. Saves 7 bytes off the gzipped script file. What? A byte is a byte. (Subs-Cache.php)

* Positioned menus 3 pixels further down the top-level entries, to give more breathing space to the menu arrows. Feedback welcome for Wine. Works fine in other skins. (script.js, index.css)

* Droid Sans has no italics, so adding a small hack for that until I'm through with that font and switch back to something else. (Warm/index.css)

! Forgot to fix the additional JS file list for IE6 in Wine -- only Warm and Wuthering were done. (skin.xml)
Title: Re: New revs
Post by: Arantor on October 29th, 2011, 02:15 AM
(5 modified, 18KB)

Revision: 1136
Author: arantor
Date: 01:13:39, 29 October 2011
Message:
+ Converted Post structure to modular block/layer setup, and don't appear to have broken anything in the interim, though time will tell. (Post.php, Post.template.php)
! Added a few hooks to posting to be able to manipulate the process. This is a bit more malleable than others because the process is intensely complex. It may be that we change these hooks or do more with them. They're also untested. (ManagePlugins.php, Post.php, Post2.php, Subs-Post.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Post.template.php


@ This wasn't pretty, especially after I spent several minutes swearing at the dynamic inclusion, suspecting a bug in the template skeleton because I was only getting the 'poll' dialogue up until it dawned on me that I was already in a topic, and had hit Add Poll (as in add poll to topic) rather than creating an entirely new post+poll.

As indicated, the hooks may be enough, they may not. Post's handling is very complex and it does occur to me that maybe I should split it out into several functions like I did in SimpleDesk, but for now at least this gives us a starting point for plugins, and IIRC is the last remaining dependency for me to make the calendar a plugin.
Title: Re: New revs
Post by: Nao on October 29th, 2011, 02:30 PM
rev 1137
(19 files, 21kb)

* Separated windowbg/windowbg2/windowbg3 logic from posts, which will use postbg/postbg2 from now on. Started to convert templates. The idea is: user-generated content should use postbg, while Wedge/skin-generated content should use windowbg. (index.css, index.ie6.css, sections.css, Display.template.php, Media.template.php, ModerationCenter.template.php, PersonalMessage.template.php, Post.template.php, Profile.template.php)

! Sending PMs with just an embedded item would fail. (PersonalMessage.php)

! Shortened action URLs would fail if Wedge was installed in a sub-folder. (QueryString.php)

* Use on_timeformat in drafts and post lists for profiles. (Profile-View.php, Profile.template.php)

* More helpful error message when the MySQL server is outdated. I'll leave it to Pete to decide whether we should keep testing mysql_get_client_info(), or test it only against MySQL 5.0, or switch to MySQLi. Or whatever. (install.php, Install.language.php)

* Cosmetic rewrites and a typo, I believe. (Class-CSS.php, ManagePlugins.english.php)

* French translation. (ManagePlugins.french.php)

@ Note: okay, I seem to remember you discussed a problem with the skeleton system this week, but can't find where exactly... Was it an issue on your side?
Title: Re: New revs
Post by: Arantor on October 30th, 2011, 01:19 AM
(3 modified, 3KB)

Revision: 1138 (a certain cell number comes to mind!)
Author: arantor
Date: 00:19:07, 30 October 2011
Message:
! Fix a typo in the plugin manager, as advised by live627. (ManagePlugins.php)
! Provide a hook for extending the types of plugin validation, as suggested by TE. (ManagePlugins.php, Login2.php)
! Provide a hook for altering the list of posts to be retrieved, as suggested by live627. (ManagePlugins.php, Display.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePlugins.php
Title: Re: New revs
Post by: Nao on October 31st, 2011, 12:13 AM
rev 1139 (it's no THX, but it's close enough.)
(9 files, 13kb)

* Added $txt['template_block_error'] to use when a block isn't found, as opposed to the current error that mistakes the block for the entire template... (Subs-Template.php, index.language.php)

* Moved the array insertion code from within the wetem::load method to its own function, so it can be reused by other areas. Thanks John for the fair suggestion. (Subs-Template.php, Subs.php)

* Renamed $txt['modify_cancel'] to $txt['form_cancel'] and added $txt['form_submit']. Maybe I should remove all other language strings that say 'Submit', and convert $txt['save'] to $txt['form_save']? (Display.template.php, index.template.php, index.language.php)

+ Started adding support for the Noisen thought system. Only adding a few strings for now, the rest of the code is not exactly ready. (index.language.php)

! go_up() and go_down() were mixed up in r1070. Oops! (topic.js)

* Harmonizing translation. (Profile.french.php)

* Typonazi. (Class-Editor.php)
Title: Re: New revs
Post by: Arantor on October 31st, 2011, 12:14 PM
(1 modified, 4KB)

Revision: 1140
Author: arantor
Date: 11:14:19, 31 October 2011
Message:
! If the error was logged by the code itself rather than an actual error condition, identify the file it came from for the purposes of plugin detection but dump it after that to avoid clogging the DB. (Errors.php)
----
Modified : /trunk/Sources/Errors.php
Title: Re: New revs
Post by: Arantor on November 1st, 2011, 12:40 AM
(4 modified, 3KB)

Revision: 1141
Author: arantor
Date: 23:39:27, 31 October 2011
Message:
! Don't bother logging the session id of the user when an error is logged. Makes the table smaller, the log view smaller and means users don't get presented with something that almost never means anything to them anyway. (install.sql, Errors.php, ManageErrors.php, Errors.template.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/other/install.sql

@ C-c-c-combo breaker, the last 9 commits or so were absolute alternating ones :P
Title: Re: New revs
Post by: Arantor on November 1st, 2011, 11:38 AM
(2 modified, 1KB)

Revision: 1142
Author: arantor
Date: 10:37:35, 01 November 2011
Message:
! The board listing had an extra quote in it when using a custom class for a given board's icon. (Boards.template.php, MessageIndex.template.php)
----
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Nao on November 2nd, 2011, 06:53 PM
rev 1143 (while waiting for the thought system to be operational...)
(7 files, 9kb)

* Made array_insert() twice faster. Yay. And again: it's only for arrays with keys. Otherwise, use array_splice(). (Subs.php)

! IE9 and lower wouldn't like custom CSS rule "gradient: rgb(...), rgb(...)" because rgb() wasn't taken into account by the rgba2rgb regex. (Class-CSS.php)

- Couple of extra globals that shouldn't be there. I'm not sure it's worth checking them all though... (SSI.php)

- Removed session-related text strings for the error log page. Also, the report e-mail don't submit a session ID, AFAIK. (ManageMaintenance.language.php, SendTopic.template.php)

* $scripturl replacement. (Welcome.template.php)
Title: Re: New revs
Post by: Nao on November 3rd, 2011, 09:49 AM
rev 1144 (there are still something like 25+ files left to commit for the thought system so I'm trying to split it as much as possible...)
(5 files, 9kb)

! Error messages like double quotes better than HTML tags. Also added a few thought system strings for later (eh, didn't want to bother removing them just for that fix.) (index.language.php)

! Fixed broken array_insert in the template object, simplified array insertion in another area, and added strict test in the array_insert function itself. (Subs-Template.php, Subs.php)

- Can no longer set personal text from the profile area. This is because it'll be set through the sidebar starting in my next commit. (Profile-Modify.php)
Title: Re: New revs
Post by: Nao on November 3rd, 2011, 09:44 PM
And here it is... The thought system.

rev 1145
(26 files, 47kb) (now we're talking!)

+ Added the Thought system from Noisen.com/Wedge.org into Wedge. Oh yes. Needs a lot of work though, as it only barely works for now. (install.sql, Ajax.php, Load.php, Profile-View.php, Subs-Members.php, index.template.php, Profile.template.php, index.language.php, Profile.language.php, script.js)

+ Added a 'data' field to the members table, that will hold a serialized array of variables that are only used by the current user. Added updateMyData() function which will cater for it. (install.php, install.sql, wedge_api.php, Load.php, Register.php, Subs-Members.php, Subs.php)

+ Added silent support for specific categories when populating the JumpTo object. I use that on Noisen, but I doubt it'll be of any use to anyone else... But never say never. (Ajax.php)

- Removed default_personal_text, which never made sense to me anyway. It probably had some use, for some people... Not for us. (install.sql, wedge_api.php, upgrade.sql, ManageMemberOptions.php, Subs-Members.php, Help.language.php, ManageSettings.language.php)

* personal_text is now parsed for BBCode. To preserve performance, this is being done when writing said text. We could possibly force reparsing when doing changes to the BBCode but right now it seems all right for me to do it this way. I have a feeling this is going to come back and bite my ass... (Ajax.php, Load.php)

* Reordering classes in the main script file, so that they follow each other. (script.js)

* $context['user'] should hold more references to $user_info, instead of copies. (Load.php)

* Minor optimizations/layout changes/bug fixes/HTML5 tags not worth documenting. (Class-DB.php, Subs.php, Display.template.php, PersonalMessage.template.php, Post.language.php)

@ Note: Pete, the keys in the thoughts table probably need some fine-tuning... Also, many things are not implemented yet: re-tweeting thoughts (if we ever do that), importing tweets (same, obviously), properly re-attributing master/parent IDs when deleting members or thoughts, etc. We should also consider whether to delete the dummy 'data'=>'' definitions and really, *all* dummy empty strings when registering a member or things like that... Fields all have a default setting, no point in setting them IMO!
Title: Re: New revs
Post by: Nao on November 3rd, 2011, 10:23 PM
rev 1146
(1 file, 25kb) (because so many lines are slightly modified.)

* Use default, not DEFAULT, to harmonize the sql dump. (install.sql)

* Turned all numeric defaults in the installer to actual numbers. (install.sql)

* Turned a few numeric fields to use unsigned, such as one-char tinyints that wouldn't even accept a minus sign: attachments:id_folder/approved, categories:can_collapse, mail_queue:private, media_albums:featured/approved/hidden, media_items:approved/last_viewed, polls:voting_locked. (install.sql)
Title: Re: New revs
Post by: Nao on November 4th, 2011, 07:15 PM
rev 1147
(6 files, 16kb)

* Okay, that members table is really too confusing... Reordered all fields thematically (PM, login dates, group memberships...), which should at least save me from a seizure in the future. (install.sql)

* The thought system doesn't work better than last time, but at least some of its code now makes more sense. (Ajax.php, index.template.php, script.js)

! Fixed an Opera glitch where browsing with a small viewport would trigger the resize event as expected, but return wrong dimensions. It seems that it needed more time to calculate it, so I simply call the function twice. I'm not sure it's worth limiting the second call to Opera, as it could be helpful to other browsers too. (index.template.php)

! HTML validation error in the thought postbox. (index.template.php)

! Fixed sidebar link colors and floated the avatar to the right, to fix erratic behavior. (index.css)

* Indenazi. (Post.php)
Title: Re: New revs
Post by: Nao on November 4th, 2011, 11:14 PM
rev 1148
(1 file, 5kb)

* The thought system now works correctly. Yay! Click the current thought (or the Modify link) to update it. Click the New link to insert a new one. Next: start work on replying/editing replies... (Ajax.php)
Title: Re: New revs
Post by: Nao on November 5th, 2011, 06:17 PM
rev 1149 (desperately looking for a better icon now... -_- Even Fugue has nothing worthy.)
(5 files +2-1, 13kb)

+ Added an icon for thoughts. It's not very good though... But I can't get myself to make a better one. (index.template.php, icons/thought.png, index.member.css)

! Header links needed fixing, especially in the sidebar. (index.css, Warm/index.css)

* Replaced the feed icon with a smaller, and just as good, GIF version. (feed.gif, feed.png, sections.css)
Title: Re: New revs
Post by: Nao on November 6th, 2011, 07:33 PM
rev 1150
(7 files, 8kb)

- Removed a few variable assignations when it comes to simple MySQL queries that don't return any data (UPDATE, DELETE...) (ManageSettings.php, Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia2.php, Subs-Media.php, RemoveTopic.php, Subs-Boards.php)
Title: Re: New revs
Post by: Nao on November 6th, 2011, 10:40 PM
rev 1151
(11 files, 24kb)

+ Finished implementing 90% of the thought system. Correctly supporting privacy and deletion, added a privacy setting allowing the redistribution of your thought (as personal text, and possibly later published on a third-party website), (Ajax.php, Profile-View.php, index.template.php, index.language.php, script.js, index.member.css)

* Renamed ajax_indicator(true) to show_ajax(), and ajax_indicator(false) to hide_ajax(). It's shorter and hopefully easier to understand... (Packages.template.php, register.js, script.js, stats.js, topic.js)

@ Although I have yet to commit a working list of thoughts with edit/reply/delete links, it works on my local copy. Delete and Profile area need some refining, and we need to test the feature from beginning to end. Also in desperate need of a short string to replace the word 'Blurb' in the language file... And we need to add newly added replies to #new_thoughts. And maybe rename Thoughts to something else..? 'Words', maybe? I like the sound of it, probably because it starts with a W.

:edit: we also need to do something to ensure that reply input boxes are shown below the original thought, rather than replace it (like an edit.)
Title: Re: New revs
Post by: Nao on November 7th, 2011, 11:17 PM
rev 1152
(3 files, 14kb) (I hate it when a very long day of work ends up as a one-line changelog... >_<)

* Moved profile thoughts to their own sub-page, and implemented proper nesting. (Profile-View.php, Profile.php, Profile.template.php)
Title: Re: New revs
Post by: Nao on November 8th, 2011, 10:38 PM
rev 1153
(6 files, 9kb)

* Thought reply/edit/delete button are now generated through JavaScript, to save bandwidth. Well, on my local install it used to be done in the HTML... (index.template.php, script.js, index.member.css)

+ Forgot to add a cache flush for pretty URLs when moving topics. I'm not even sure it'll run, since I don't use the high-level cache and this is some awfully ugly raw code. Pete? (MoveTopic.php)

* Not even worth mentioning. (RemoveTopic.php, Subs-BBC.php)
Title: Re: New revs
Post by: Arantor on November 11th, 2011, 01:55 AM
(38KB, modified 51, deleted 11)

Revision: 1154
Author: arantor
Date: 00:55:08, 11 November 2011
Message:
- Removed the calendar. (Many files, more than I really want to list, everything in this commit is related; every place that has hooks added should also have calendar code removed in its stead.)
+ New hooks (ManagePlugins.php, Security.php, RepairBoards.php, Settings.template.php, Subs-Boards.php, SplitTopics.php, Post.php)

@ Not every trace of the calendar is gone. Notably, the 'which day to start the calendar' is still in the profile area, because there's no sane way to hook it at this time (because the profile options needs an overhaul), there's a couple of strings with calendar_ prefixes that are used elsewhere to the calendar, there's one place in the quick moderation that needs a hook attached, and lastly the menu icon is still part of the icons sprite. That needs to be split off and made accessible to the menu loader. But pretty much everything is. Everything seems to work with the calendar removed, and it's unknown whether the calendar as a plugin works, but we'll see when we get there...
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Deleted : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Display.php
Deleted : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Cache.php
Deleted : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Deleted : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Deleted : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Deleted : /trunk/Themes/default/images/admin/calendar.gif
Deleted : /trunk/Themes/default/images/admin/calendar.png
Deleted : /trunk/Themes/default/images/admin/calendar_off.png
Deleted : /trunk/Themes/default/images/admin/calendar_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Deleted : /trunk/Themes/default/languages/ManageCalendar.english.php
Deleted : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/xml/detailed-version.php
Title: Re: New revs
Post by: Arantor on November 11th, 2011, 02:02 AM
(2KB, 2 modified)

Revision: 1155
Author: arantor
Date: 01:01:49, 11 November 2011
Message:
! More language strings to be removed from the calendar. I don't think they're used anywhere else. (Errors language file)
----
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Title: Re: New revs
Post by: Arantor on November 11th, 2011, 09:29 AM
(2KB, 1 modified)

Revision: 1156
Author: arantor
Date: 08:29:20, 11 November 2011
Message:
! Removed old settings relating to the calendar from the installer, namely default permissions, a default theme option and default configuration. (install.sql)
----
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on November 11th, 2011, 11:51 PM
rev 1157
(15 files, 26kb)

* Updated the menu sprite with the calendar icon removed. (sprite-menu-32bit.png, sprite.png, index.css)

+ Added $txt['showThoughts'] entry to harmonize with other profile strings. (Profile.php, Profile-View.php, Profile.language.php, Profile.template.php)

+ Indicate the filename in the error log in case we have a 404. (QueryString.php)

- Removed some remaining references to calendar events. (Post2.php, Profile-View.php, index.css, index.rtl.css, sections.css)

- Removed specific color tags from parse_inline_bbc, as they're parsed by preparsecode(), not by parse_bbc(). Thanks Pete! (Subs-BBC.php)

* Typos, including one that caused issues with the JS Packer. (ManageBoards.english.php, script.js)
Title: Re: New revs
Post by: Nao on November 12th, 2011, 12:05 AM
rev 1158
(9 files, 11kb)

* More calendar/event stuff needed removing & updating. (ssi_examples.shtml, index.french.php, ManagePermissions.french.php, admin.css, index.css, index.ie7.css, index.rtl.css, sections.css, Wuthering/index.ie7.css, Wuthering/sections.css)
Title: Re: New revs
Post by: Arantor on November 13th, 2011, 01:01 AM
(3KB, 2 modified)

Revision: 1159
Author: arantor
Date: 00:00:51, 13 November 2011
Message:
! Provide a central facility for issuing the correct HTTP header. (Subs.php)
! When issuing a fatal error, allow for specifying a proper HTTP header for it, defaulting to 403 Forbidden. (It's a fatal error, and in general use, that shouldn't ever be anything other than a 403. However, this means we can convert other uses to issue more meaningful headers in the future, and as a side benefit, it means that if content is linked that is no longer accessible to search engines, e.g. deleted topic, they don't continue to reindex the error page, but get a header that tells them to stop.)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on November 13th, 2011, 01:06 AM
Revision: 1160
Author: arantor
Date: 00:06:23, 13 November 2011
Message:
! Strange bug in our BB implementation regarding the POST tests. (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Arantor on November 13th, 2011, 03:10 AM
(1KB, 1 file)

Revision: 1161
Author: arantor
Date: 02:09:50, 13 November 2011
Message:
! Plugin loader would disable plugins that couldn't be activated at runtime (due to missing files) but it wouldn't clean house and reset the list for later; that way if the plugin is reuploaded, it's still disabled rather than magically re-enabled again. (Load.php)
----
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Nao on November 13th, 2011, 06:16 AM
rev 1162
(I had a leftover in the fridge.)

! The error logger would create errors itself if the error happened before $user_info was filled in. (Errors.php)
Title: Re: New revs
Post by: Arantor on November 13th, 2011, 01:57 PM
(1KB, 1 file)

Revision: 1163
Author: arantor
Date: 12:56:37, 13 November 2011
Message:
! Make sure the complete Reply-To header is sent on mailing, not just a partial one that may not be honoured by all clients (notably GMail). (Subs-Post.php)
----
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Nao on November 13th, 2011, 08:55 PM
rev 1164
(7 files, 2kb)

! The thoughts page in profile areas was only visible by their owner. (Profile.php)

! Fixed sidebar behavior in iPad devices. (skin.xml, Warm/skin.xml, Wuthering/skin.xml)

+ Added a $txt['menu_new'] string to account for a short 'New' string to be shown in top-level menus. While it isn't a problem in English, it may be in other languages. (Subs.php, index.language.php)
Title: Re: New revs
Post by: Arantor on November 15th, 2011, 12:42 AM
(1KB, 1 modified)

Revision: 1165
Author: arantor
Date: 23:41:19, 14 November 2011
Message:
! Changes to Content-Disposition header. IE 9 didn't like the old code (because *they* changed it from how IE8 did it) and the newer code, well, it looks like other browsers hated it too, so I've come up with something that seems to work for everyone. I don't have (actual) IE8 or Safari to test it on but all signs suggest it should have resolved the problem. (Dlattach.php)
----
Modified : /trunk/Sources/Dlattach.php
Title: Re: New revs
Post by: Nao on November 16th, 2011, 07:34 PM
rev 1166
(4 files, 2kb)

* The message index's quickmod will now hide the board list if not in context, instead of simply disabling it. Also, the first entry now says 'moderate' instead of just an empty line. A good compromise for first-timer mods. (MessageIndex.template.php)

! Double quotes aren't standard in content attachment -- that's until I get around to writing a better version of that code. (Aeva-Gallery.php)

* Spacinazi, commenazi. (Dlattach.php, MessageIndex.php)
Title: Re: New revs
Post by: Nao on November 16th, 2011, 10:58 PM
rev 1167
(4 files, 3kb)

! Aeva Media's thumbnail filenames would oddly get a '.png.png' extension when the original file was in PNG format. (Subs-Media.php)

* Updated Aeva Media (Download and Mass Download links) to use the new attachment code as well. Tested in Safari 5.1, Firefox 8, Chrome 17 and Opera 11. (Aeva-Gallery.php, Aeva-Gallery2.php)

! Safari 5.1 didn't like the new attachment code. (Dlattach.php)

@ Hopefully it's all okay now... The dummy test filename was 聖闘士'seiya.png (note the single quote.)
Title: Re: New revs
Post by: Arantor on November 17th, 2011, 01:45 PM
(forgot to note the size, 13 modified, 1 removed)

Revision: 1168
Author: arantor
Date: 17 November 2011 12:45:03
Message:
! Remove the 'recent items' widget from the sidebar in the info center. It can be better supported in other ways, like being a plugin. And being a theme option, it also has tendrils elsewhere in the system, mostly to ensure that it isn't accidentally overridden by users who have their own preferences... Also, Subs-Recent.php appears to be solely for the purpose of getting last posts - but is only actually used there as far as can be determined, so it's removed. (install.sql, Boards.php, JSOption.php, Load.php, Profile-Modify.php, Subs-Members.php, Welcome.php, Subs-Recent.php, InfoCenter.template.php, Settings.template.php, language files: index, Themes)
----
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Members.php
Deleted : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on November 18th, 2011, 05:39 PM
rev 1169
(5 files +1, 3kb)

! Fixed IE6/7 and iOS codepaths generating JavaScript errors. Now, if only my stupid iPod could notify me on errors, that would have saved me an entire day of pointless debugging... (index.template.php)

! Fixed iOS support for Warm skin. Sometimes, this skeleton system is too powerful for its own good... (Warm/skin.xml, Warm/index.iphone.css)

* Shortened the copyright notice for jQuery 1.5.2, to match the one in version 1.7. (jquery-1.5.2.js)

* Other minor skin fixes for iOS. (index.iphone.css, skin.xml)

@ Note for Pete: we'll most certainly need to add an index.tablet.css file for your iPad. However, given that I still don't have one, I'd recommend that you add it yourself. Normally, it should only need the #sidebar and #main_content lines.
Title: Re: New revs
Post by: Nao on November 20th, 2011, 12:21 AM
rev 1170
(3 files, 9kb)

+ Added a welay object that can be used to do method chaining on template layers/blocks. Use wetem::get() to get the default layer, or ::get('something') to retrieve the 'something' layer or block. Then you can chain ->append('new_block')->wrap('new_layer') methods on it. (Subs-Template.php)

+ welay supports the following methods, which are all shortcuts to other wetem methods: parent() (will return the parent object), append() (add items to current), prepend() (add items at the beginning of the current), before/after/erase (add items before/after/in place of current), replace() (add items in place of current layer, but leave its sub-layers inatct), remove/rename() (remove/rename layer/block), and wrap()/inner() which will respectively add a layer around the current, or at the top level inside the current. (Subs-Template.php)

* Renamed 'replace' to 'erase' in the ::layer() function, because that was the equivalent in ::load(). (Subs-Template.php)

* ::find_parent() is now a public method. I don't think it's going to hurt anyone anyway... (Subs-Template.php)

- Removed reference to #ic_recentposts, now unused. (index.rtl.css)

* Simplified unextends code in CSS parser. Basically, 'unextend' was an accepted keyword and it was a bit confusing. Now, only 'unextends' will be accepted. Also using word boundaries to make the regexp simpler. (Class-CSS.php)

@ To Pete: much of this is untested, I'm afraid, although it works for the regular uses in Wedge itself... Please analyze the object (and diff) carefully and make sure to tell me if anything looks wrong!
Title: Re: New revs
Post by: Nao on November 20th, 2011, 11:00 PM
rev 1171
(4 files, 4kb)

* The Ajax code for sending thoughts will now return a parsed thought, so that it's correctly bbc-parsed when shown. (Ajax.php, Xml.template.php, script.js)

* Make sure the welay object defaults to the default layer. (Subs-Template.php)

* Wrapped the keep-alive code in its own anonymous function, to save a few bytes and avoid using a global var. (script.js)

- sendXMLDocument didn't need the extra {} in its code. (script.js)

- Changed ajaxRating to use an anonymous callback function, instead of polluting the namespace with ajaxRating2. (script.js)

@ Note: editing a thought will still incorrectly show a HTML version of it... It should be retrieved through Ajax, at least if some kind of HTML is found in it.
Title: Re: New revs
Post by: Nao on November 21st, 2011, 03:30 PM
rev 1172
(2 files, 1kb)

! Turned the file cache getter function's require() into an include(), because in some silly situations, it may be rejected even if the file is there. Because Wedge would automatically rebuild the cache in this situation, there's no reason in stopping page generation at this point. (Subs-Cache.php)

! Forgot a closing div for guests with no login bar. This would totally break the Warm skin in older versions of Firefox. Scary when you're not expecting it. (index.template.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2011, 07:37 AM
rev 1173
(2 files, 1kb - thought there'd be more stuff to separate from the upcoming commit...)

! Recent posts were missing their title. Reintroduced $txt['recent_posts'] that was removed in rev 1168. (index.language.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2011, 07:39 AM
rev 1174
(5 files, 7kb)

+ Implemented basic support for adding block/layer options in the skeleton, and related bits. (Load.php, Subs-Cache.php, Subs-Template.php)

+ Added support for custom indentation in blocks and layers. For instance, just add the indent="-1" keyword in a layer or block to remove an indentation tab off the layer and all its nested blocks/layers. Used to good effect in Warm to get rid of the silly indent glitches introduced by layer movements. (Subs-Template.php, Warm/skin.xml)

* Some indentation fixes that can be introduced thanks to the above. (index.template.php)
Title: Re: New revs
Post by: Nao on November 24th, 2011, 03:15 PM
rev 1175
(19 files, 19kb -- mostly in Subs-Template)

* An extensive rewrite of the wetem object adds support for static methods that were previously only in welay (now renamed to wetemItem), hopefully providing an easier to remember syntax. replace() is renamed to load(), erase() to replace(), find_parent() to parent(), wrap() to outer(), append/prepend() are back to add() and first(). Mostly because jQuery doesn't dictate our naming conventions, although I suppose we can add aliases. (Subs-Template.php)

* Updated Wedge codebase to use the new wetem methods. (index.php, Admin.php, Boards.php, Display.php, ManageAttachments.php, Aeva-Gallery.php, ManageMedia.php, ManageMedia3.php, MessageIndex.php, PersonalMessage.php, Post.php, Profile.php, Subs-Menu.php, Unread.php, UnreadReplies.php, Welcome.php, SSI.php, Warm/skin.xml)

! wetem::before (and its equivalent earlier incarnation) would actually act like ::after. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on November 24th, 2011, 04:09 PM
rev 1176
(12 files +1-1, 18kb)

! Overhauled the readme_*.html and ssi_examples.php files to actually look good instead of broken. Also updated Wedge logo to the latest... Until the next one, of course. (readme_*.html, wedgelogo.png)

- Removed the middletext class. The difference in size between normaltext and smalltext is already negligible enough, and it was barely used anyway... (install.php, readme_*.html, ssi_examples.php, upgrade.php, Display.template.php, index.css)

- Removed more unused CSS IDs (#postbuttons and a remaining #ic_recentposts). (sections.css)
Title: Re: New revs
Post by: Nao on November 24th, 2011, 08:37 PM
rev 1177
(4 files, 4kb)

+ Added proper retrieval of current thought (through Ajax) when editing a thought that has BBCode in it. (Ajax.php, script.js)

* Optimized getXMLDocument and sendXMLDocument for size. But it won't compensate for the few bytes added by the above... (script.js)

- The stats don't make use of oXmlRequestHandle. (stats.js)

! The auto-suggest does, though. Althought I'm not sure it works at this point, or is even needed, considering we're using jQuery and all that. (suggest.js)
Title: Re: New revs
Post by: Nao on November 25th, 2011, 10:02 PM
rev 1178
(3 files, 2kb)

! The wetem rewrite forgot to pass the result of wetem::op() onto the caller. (Subs-Template.php)

+ Also added a return value for most other wetem methods that users might wanna check. (Subs-Template.php)

! wetem::insert_layer() was testing for 'parent', instead of 'outer'. (Subs-Template.php)

! Fixed bad line heights for smalltext and normaltext CSS classes. (index.css)

* Commenazi. (Warm/skin.xml)

@ Should we bother testing for insert_layer and remove_layer return values in wetem::layer()..? I think that's the only place where we got missing return values, but OTOH it's very unlikely the functions will return false at this point...
Title: Re: New revs
Post by: Nao on November 27th, 2011, 05:50 PM
rev 1179
(7 files, 10kb)

* Finished implementing the thought system... Hopefully. The main thing here was to get Wedge to show your newly sent thoughts in the thought box if you're on the homepage. Can't believe it was so complicated just to do that... (Ajax.php, Post.language.php, script.js, index.member.css, Xml.template.php)

! Fixed thought action form's layout. (index.member.css)
Title: Re: New revs
Post by: Nao on November 29th, 2011, 10:48 AM
rev 1180
(3 files, 1kb) (I remember the good old days when TortoiseSVN would report 3KB for the same amount of changes... It doesn't look as impressive now, but at least it's more honest :P)

! Profile link deletions and color replacements were broken when user had no cookie set yet. Thanks Pete for the report. (Subs-Template.php)

* Replaced the div tag for smileys with a shorter i tag, which is semantically a bit better, and will still validate when shown in inline text. Plus, well, it's shorter. (Class-Editor.php, Subs-BBC.php,

! The <ins> tag is rendered by browsers as underline, so it should be turned to a 'u' BBCode at conversion time. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on November 29th, 2011, 02:36 PM
rev 1181
(3 files, 3kb)

* Hide new/edit/delete buttons when interacting with a thought. (script.js, index.member.css)

! Various fixes to the sidebar thought editor. And yeah, they're totally obscure... (Ajax.php, script.js, index.member.css)
Title: Re: New revs
Post by: Nao on November 29th, 2011, 03:00 PM
rev 1182
(4 files, 11kb)

+ Finally added the thought list to the welcome page. Fully working, hopefully... (Welcome.php, Welcome.template.php, index.member.css)

* Cleaned up profile area's thoughts page, if only because it's a bit complicated to fit edit/new links into that area... Will deal with that later for all Facebook-wannabe sites, although it's not a priority. I've spent wait too long on this feature, time to focus on other things... (Profile.template.php)
Title: Re: New revs
Post by: Arantor on November 30th, 2011, 03:25 PM
(1 file, 1KB)

Revision: 1183
Author: arantor
Date: 30 November 2011 14:25:03
Message:
! Missing ; would cause the resultant minified code to choke. For once IE9 came to the rescue, telling me what character the error was on, rather than just the line number... (script.js)
----
Modified : /trunk/Themes/default/scripts/script.js
Title: Re: New revs
Post by: Nao on December 2nd, 2011, 07:45 PM
rev 1184
(3 files, 7kb)

! Thoughts should be pre-parsed before saving. (Ajax.php)

* The homepage thought code wasn't using the MVC model... Ouch. (Welcome.php, Welcome.template.php)
Title: Re: New revs
Post by: Nao on December 4th, 2011, 11:42 PM
rev 1185
(6 files, 9kb) -- my work for the weekend... Good luck trying to understand any of it.

+ Added support for ISO to UTF8 conversions in the westr class. New functions: is_utf8(), force_utf8() and to_utf8(). New variables: $can_utf and $can_iconv. Made $can_* variables public because it's mostly harmless. (Class-String.php)

! The westr class wasn't being initialized at all, thus Subs-Charset was never loaded, and self::$can_mb wasn't set. (Load.php)

- There's no need to specify 'public' in front of public methods. It may be clearer, but it also takes space for nothing. (Class-String.php)

* Benchmarked these regex variations in westr and it turned out that the longer ones were faster... Uh. (Class-String.php)

* Scarcely used westr::safe() now is the equivalent of westr::htmlspecialchars, only the $force_utf8 and $double_enc param defaults are reversed. (Class-String.php)

! Fixed Aeva Media throwing out an 'empty post' error when all of these conditions were set: PHP < 5.4, title lookups enabled, and title had an entity that was decoded to an unsafe character (i.e. something that doesn't convert to the same byte sequence in UTF-8 and ISO-8859-1). Also fixed an unrelated call in the BBC parser that uses the same function. (Aeva-Embed.php, Subs-BBC.php)

* A few necessary rewrites for subject and post sanitation (sanitizing?), used the opportunity to be bitchy and play with fire by forcing ENT_NOQUOTES on the htmlspecialchars calls... Let's see how it goes. (Post2.php)

* Various &amp; fixes. Don't ask, it's complicated. (ManageBoards.php)
Title: Re: New revs
Post by: Nao on December 7th, 2011, 05:54 PM
rev 1186
(12 files, 14kb)

+ Added a new routine to the post code that will check for extra or missing tags and send an error instead of trying to fix, generally badly. The error message also indicates the number of expected and found tags. (Post.php, Post2.php, Errors.language.php)

! The Post() function's error handling code was pretty messed up to begin with. Rewrote it to use the same system as in Post2(), as well as avoid rebuilding the error list in case an error was found in Post2(). (Post.php)

- Why exactly does SMF/Wedge still show a hidden error box when there are no errors to show in the first place...? That's silly. (Post.template.php, sections.css)

! SMF bug (doesn't matter here, but just so they know if they're reading our changelogs...): $context['post_errors'] is set in Post(), instead of $context['post_error']. Fixing this will break Post2() error handling though... (Post.php)

* Harmonized other occurrences of $context['post_errors'] to $context['post_error']. Well, technically post_errors is better suited, but there are far more to fix if we start going that way... I have a life, too. (Profile-Actions.php, Profile.php, Report.php, Profile.template.php, SendTopic.template.php)

@ Note: I have yet to cache the BBC list for the mismatched tag check code. Actually, I'm not even sure it's worth caching it... It's a tiny table and the code is only run when posting a message... What do you think?
Title: Re: New revs
Post by: Nao on December 7th, 2011, 07:40 PM
rev 1187
(4 files, 3kb)

! Mismatched tag code wouldn't work when openers had parameters. (Post2.php)

* Rewrote mismatched tag logic to generate an error in, for instance, a situation where you'll have matching openers and closers but in the wrong order. (Post.php, Post2.php, Errors.language.php)
Title: Re: New revs
Post by: Nao on December 8th, 2011, 09:47 AM
rev 1188
(6 files, 5kb)

* Well, if it isn't magical... Rewrote the mismatch code again, and moved it to the wedit object. This time, it's shorter, it's easier to grasp and it actually yells at you if you do [tag1][tag2][/tag1][/tag2]. Give me another day and I'll have a full HTML5 parser for ya... Will that be all m'am? Maybe a pound of apples? (Post.php, Post2.php, Class-Editor.php, Errors.language.php, sections.css)

* Some regex simplifications. You've got to face it, a regex IS complex, whatever way you look at it. Making it longer won't make it any simpler. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on December 11th, 2011, 11:43 PM
rev 1189
(2 files, 18kb) (that one was pretty annoying... and I don't even get to commit it on an even number like 1190? :P)

* Moved mismatched tag fixer to preparsecode(), and added ability to either return an error message (when Wedge allows it), or fix the errors automatically. The automatic fixes are pretty solid, but it won't be able to rewrite your post if you enjoy mismatching plenty of tags in a row, forgetting openers and closers and doing strange things altogether. (Class-Editor.php, Post2.php)

* Hopefully a more solid code tag handler. If Wedge meets a code opener inside a code block, it will rewrite it to prevent further processing errors. (Class-Editor.php)

+ Wedge will now clearly indicate where the mismatch errors are located inside the post. (Class-Editor.php)

+ Added a check for posts opening a block-level tag when some non-block tags are still opened. Will attempt to fix automatically. (Class-Editor.php)

+ Wedge will also now attempt to turn block-level closers to openers if they're at the start of a new line *and* no matching opener was found before them. (Class-Editor.php)

* It will also no longer attempt to fix (or report) "errors" inside a code, html or nobbc block. (Class-Editor.php)


Note!!

The following lines require some testing: (i.e. I made last minute logic changes to them but didn't test them on my test suite)
2364: if ($found === false || !$really_found) (original had something like if (!$found || !$really_found))
2375: $text = substr_replace($text, '', $pos, strlen($full_tag)); (original had a 0 instead of the strlen...)
Title: Re: New revs
Post by: Nao on December 12th, 2011, 12:01 AM
rev 1190
(2 files, 1kb)

+ Added php tags to the list of special blocks. (Class-Editor.php)

! php tags should be block-level, while s tags shouldn't be. (install.sql)

! Fixed footnote tags breaking layout when used in code tags. Should also test for other tags... (Class-Editor.php)
Title: Re: New revs
Post by: Nao on December 12th, 2011, 11:33 PM
rev 1191
(3 files + 3, 13kb)

+ Added first working version of the select box replacement. Needs more work, as usual, but it works and it gzips to ~3KB. (Load.php, script.js, index.css, images/select_arrow*.gif)
Title: Re: New revs
Post by: Nao on December 13th, 2011, 11:42 AM
rev 1192
(2 files + 1, 33kb)

+ Added select box code. Forgot it in the last commit... The starting comment has /** instead of /*! because it's added to script.js so we don't need the duplicate copyright lines in the packed version. (sbox.js, Load.php)

* Use proper nesting on select box styling. Added some padding around the list box. (index.css)
Title: Re: New revs
Post by: Nao on December 13th, 2011, 03:12 PM
rev 1193
(1 file, 8kb)

* More size optimizations in the jQuery-Proto area. Sometimes, using local variables to stand for strings will actually increase the size, not after packing the file but after gzipping it. Also, accessing an object property by dot compresses better than by brackets. Also removed support for $.getObject() and function throttling, since we don't use these plugins. Removed 'above' class from drop-up list boxes (i.e. when it opens from the bottom), until I have a good reason to style that. Will probably re-introduce later. Gzipped size for sbox.js is now down to 2941 bytes[1]. (sbox.js)
 1. As a reminder, I started at 3579 bytes, and that's without removing any features -- only removed the ability to change some uninteresting features on the fly. Also, jquery.selectBox.js compresses at 2977 bytes so it's as if I'd started with this one, compressed it even more and added the extra features from the plugin I eventually chose...
Title: Re: New revs
Post by: Nao on December 13th, 2011, 07:13 PM
rev 1194
(1 file, 4kb)

* And again, optimizing the select box for size... obj.access is never used so it's gone, obj.init is always there so it's not tested, getDDCtx will now always return o.ctx (couldn't find a reason to support setting 'self' or a function on it), moved the init code to the top of the object (only saves 6 bytes but it's also cleaner), replaced a substring() with the [0] equivalent, hardcoded acTimeout (who needs to fine-tune the timeout between key presses when typing a string? I doubt people even know they can do that), hardcoded the space threshold to 50 pixels (and would probably benefit from being even smaller), and rewrote positionSB in a smarter and shorter way. Current gzipped size: 2827 bytes, down from 2941. Now we're talking... (sbox.js)

@ I doubt I can go below 2500 bytes, BTW... Even going below 2800 is going to be hard, at this point. The only thing I can see here is getting rid of $ddCtx but that would imply that skins are no longer able to set a margin on the body... OTOH, why would they do that? It's just that if someone doesn't think of adding an extra div, I'm just not sure I want to see them ask for support because suddenly their select boxes are broken...

@ Also, I just noticed a small bug in the plugin. If you select an item and close a SB, if you reopen it, sometimes the selected item will still have the hover class on it, even though the code correctly removes it... Oh, I don't feel like hunting that one... :-/
Title: Re: New revs
Post by: Nao on December 14th, 2011, 01:22 PM
rev 1195
(2 files, 5kb)

* Down from 2827 to 2751. It's harder to save space now... I won't save much if I don't disable more features, like ARIA, so I need a bit of reading on this. Changing .size() to .length is faster (no function call overhead), and compresses better. The optionFormat simplification saves a lot. optgroup handling wasted a local var. Also, flickerDisplay doesn't need its own function as it's called only once (plus, I couldn't see any issues in IE7 even when disabled.) And a newly created option tag doesn't need a default empty value because that's what it gets anyway. (sbox.js)

* Menu arrows were off by a pixel. (index.css)
Title: Re: New revs
Post by: Nao on December 14th, 2011, 06:19 PM
rev 1196
(1 file, 5kb) -- hey, this one actually has bug fixes and all! :P

* Down from 2751 to 2700. Removed the triggerHandler helper because it turned out closeAll() was never used, and thus there was only one actual use of it. Saved a few bytes by replacing some events and function calls (blurOrig, focusOrig, getEnabled, getSelected, positionSBIfOpen) with their actual contents. And finally, some local vars don't need to be set to null because they're set anyway as soon as the object is created. (sbox.js)

- Removed .options({...}) public method. I can't think of any good reason to actually change an option for a select box *after* it was created... (sbox.js)

! Fixed that annoying bug with hover states. It adds ~20 bytes to the gzipped file (the is_closed stuff) but it's better than a frigging bug! (sbox.js)

! Prevented consecutive select box clicks from selecting text around the select box (the mousedown stuff). Gzipping will always fascinate me: adding an extra line of code actually removed an extra byte from the final file... (sbox.js)
Title: Re: New revs
Post by: Nao on December 15th, 2011, 10:38 AM
rev 1197
(1 file, 1kb)

! Forgot to load Class-Editor before preparsing thoughts. Now this is where that auto-loader would have been useful eh... (Ajax.php)
Title: Re: New revs
Post by: Nao on December 15th, 2011, 12:22 PM
rev 1198
(5 files, 3kb)

+ Down from 2700 to 2696, but added support for per-option CSS (used in quick access). The next commits will probably see the size go a bit up, which is okay. I'm really only trying to keep it below 3000... (sbox.js)

! Fixed optgroup support (was broken by a careless edit), and apparently optionFormat doesn't even require to retrieve the label for optgroups, text() will figure it out for itself. (sbox.js)

! Fixed optgroup styling, too, and improved box shadow. (sbox.js, index.css)

* Moved message_index_jump_to's associated floatright to the ID itself, and fixed top padding. (MessageIndex.template.php, sections.css)

* Incomplete comment. (index.member.css)
Title: Re: New revs
Post by: Nao on December 15th, 2011, 06:50 PM
rev 1199
(9 files, 4kb) (another one coming up.)

! Fixed the 'extends' keyword appearing directly in compiled CSS files for IE6. (Class-CSS.php)

! Fixed submenu arrows and post backgrounds in IE6. Hey, first actual use of 'unextends' in my code! (index.ie6.css, skin.xml)

! Fixed menu arrow positions in all browsers, and a few color issues in Wuthering. (index.ie7.css, Warm/index.css, Wuthering/index.css, Wuthering/index.ie6.css)

! Syntax error (: instead of ::). (ManageMedia.php)

! $txt['who_index'] contains {forum_name}, yet was set in a code block that didn't through the {forum_name} replacement. (Who.php)
Title: Re: New revs
Post by: Nao on December 15th, 2011, 08:37 PM
rev 1200
(3 files, 1kb) (oh, come on... It's gotta be more than that! Especially the JumpTo rewrite!)

* Rewrote the JumpTo class into a single function. Categories are no longer selectable (what's the point anyway?), and they're shown, more logically, as option groups. As a result, the code is clearer and shorter. (script.js, Xml.template.php)

! Folding out years in the stats section would never register internally, because of a wrong method name. (script.js, stats.js)

- Got rid of the 'hoverable' menu code because rev 1024's clever hack was pretty much doing the same. (script.js)

* Boolean to integer is done just by adding a + before the var name, like +is_ie8down... I should do that more often. (script.js)
Title: Re: New revs
Post by: Nao on December 15th, 2011, 11:09 PM
rev 1201
(5 files, 6kb)

! WeCSS's custom 'gradient' property should now work properly in IE when using short-form RGB codes (#fff etc.) (Class-CSS.php, index.css)

* Bored with the italics... Replaced mini-logos with new ones. (minilogo.png, minilogow.png, index.css, Warm/index.css)
Title: Re: New revs
Post by: Nao on December 16th, 2011, 04:36 PM
rev 1202
(2 files, 8kb)

+ Restored support for custom styling of drop-up select boxes. (sbox.js, index.css)

* And yet, the script file is now even shorter... 2585 bytes -- was 2696. Every byte saved is a victory, at this point. I pretty much cut the Proto object in half and removed the ability to set or get variables, and anything that the select box object actually doesn't need at all. Now it's pretty simple: either .sb() is empty, meaning you create a default select box, or it has an object as a param (where you specify your custom options), or a string, meaning it's a function to execute after creating the object, eg .sb('refresh'). It doesn't get any simpler. No other features were removed -- just tested dozens of ways to optimize gzipping, including code permutations, and kept everything that worked. (sbox.js)

* Renamed the fixedWidth option to fixed. I told you, every single byte... (sbox.js)

@ Note: removing ARIA features would save about 130 bytes. I'm not sure it's worth it. Removing the hardcoded 'position' and 'visibility' styles, which I can't seem to find a browser that will make use of, would save another 50 bytes. Thus, I... think the 2500 byte limit can be reached, but it's pretty pointless, I suppose. Heck, I'm startin to wonder if I shouldn't take the 3KB alternative selectbox plugin and try to reduce it to 2KB or less... ;)
Title: Re: New revs
Post by: Nao on December 16th, 2011, 07:06 PM
rev 1203
(1 file, 2kb) (now that's not 2kb, it's barely 10 lines of code... I'd love to know what size this is supposed to represent.)

! I actually committed the 2530+ byte version of sbox.js, not the 2585 byte version with the extra-styling-that-I-don't-know-what-it's-for-yet. (sbox.js)

! Inverted two variables at the last minute... (sbox.js)
Title: Re: New revs
Post by: Nao on December 17th, 2011, 08:03 PM
rev 1204
(2 files, 4kb)

* I believe the local avatar selector should be a square select box, rather than a dropdown. It makes more sense. (Profile.template.php)

* And on the other hand, these non-dropdowns should NOT be turned into dropdowns by our SB plugin. Might as well do something to 'style' them in the future, too... But right now, it's a no-go. (sbox.js)

+ Starting to get serious... All select boxes will now be transformed automatically. I have a feeling this will require a lot of work in the coming days, to convert everything as expected. (sbox.js)

* More code size optimizations. The Proto area is now incredibly short! But because of the extra code from above, final gzipped size is 'only' 5 bytes shorter. (sbox.js)

@ I'm pretty impressed by how much this file is 'optimizable' really...
Title: Re: New revs
Post by: Nao on December 19th, 2011, 12:25 AM
rev 1205
(2 files, 7kb)

! Fixed copy-paste error in wetem::remove. Thanks Dragooon! (Subs-Template.php)

! Fixed a few very annoying bugs in the select box's keyboard handling. This was basically due to the events being registered multiple times. I'll be honest and just say I took the easy way out and unregistered the events manually before registering them. I should instead be looking into the source code to find out why the code is being called more times than needed. (sbox.js)

* Personal usability preference: using the up and down arrow keys in a select box will now loop to the other end of the list if you reach the beginning or the end. I always hated the fact that regular select boxes don't do that... (sbox.js)

* 2579 to 2386... Not bad (even went as far as 2372 at one point). Among many other things, removed a duplicate test for duplicate objects (poetic irony), and rewrote the keydown event to something more readable and IMHO actually more usable (see above.) Also, 'new object()' doesn't require the parenthesis. I learn stuff every day. (sbox.js)


@ Note: should disable submitting the form when hitting Return inside a select box... I think?! Should also remove the random ID assignments -- the original developer didn't document why he added them over at github, and I don't see any reason for doing it either. It seems to be a leftover from an older element that was removed anyway... Opinions?
Title: Re: New revs
Post by: Nao on December 20th, 2011, 03:31 PM
rev 1206 (the script.js optimization commit.)
(8 files, 9kb)

* Rewrote the menu system into a closure, and initMenu() into a jQuery pseudo-plugin with the syntax $('#menu').menu(), which is a bit cooler. And saves me from dealing with uncompressed variable/function names. (GenericMenu.template.php, index.template.php, script.js)

- Oh, and closures don't systematically need a jQuery reference... That's only if we're using another library that hijacks the $ sign. It's very unlikely, so off we go. (script.js)

- Removed isEmptyText() to save bandwidth, because it's not used in a lot of places and the code can actually be shortened by not using it. For instance, "isEmptyText(this) || this.value == 0" is equivalent to "$.trim(this.value) == 0". (ManageBoards.template.php, Poll.template.php, Post.template.php, script.js, suggest.js)

* Moved we_setThemeOption into the weToggle object, as it was called only once... And I'm sure if other plugins want to use it, they can perfectly write their own. It's two lines of code. (script.js)

- From the depths of SMF: weCookie declares this.opt and never uses it. Gone. (script.js)

- weToggle's bNow was a synonym of bInit. I don't remember why I introduced that. Gone. (script.js)

- Another one from the depths of SMF: there's no point in straightening out the bInit variable if it's undefined, because it's declared and that's the least JavaScript requires to go without complaining. (script.js)

! And a very, VERY important SMF bug to finish with -- hopefully they're listening: if you collapse any item and it's saved into the database, SMF will systematically re-insert the data into the database on each page load, even if you don't touch the item anymore. Major fail. The fix is very easy: just add a (!bInit) test before the oThemeOptions test. (script.js)

- Brackenazi. (Display.template.php)
Title: Re: New revs
Post by: Nao on December 20th, 2011, 07:04 PM
rev 1207
(1 file, 4kb)

! Fixed automatic quote splitter: tags like  wouldn't break correctly. (Thanks dorje for the report!) (post.js)
! Fixed automatic quote splitter: mixed case tags would sometimes fail to break. (post.js)
! Fixed automatic quote splitter, what else? Protected and closed tags would break in some situations, too. It's not perfect yet (except for closed tags), but it's close enough. If you type in broken code, it's your problem. (post.js)

@ The modified code is actually shorter than before :P Also, I commented it this time...
Title: Re: New revs
Post by: Nao on December 20th, 2011, 08:02 PM
rev 1208
(1 file, 2kb) (although it's about on par with last commit's size... Don't ask.)

+ Seriously improved keyboard usability. It's actually even better than the default select box, if you'll ask me. Press space to unfold the list box (I don't know of any keyboard shortcut to do that in a default), press Tab to switch to the next HTML element -- and yes, it works correctly in both opened and closed states, and press Backspace or Return to confirm a selected entry and close the current select box without submitting the form. If the box is already closed, pressing Return will submit the form.

* Replaced select box's random number with a unique ID that gets increased as required (inside lists). (sbox.js)

* Merged selectNextItemStartsWith and selectMatchingItem. They pretty much both did the same thing... It's still buggy though, but just so you know... The original code actually didn't work at all, so it's an improvement already. (sbox.js)

- Removed select box's destroy method. There's no need for that externally, is there? (sbox.js)

* Even with all of the keyboard shortcut additions, still managed to go from 2386 to 2351... I eat bytes for breakfast. (And if you're French: I said bytes, with a y.) (sbox.js)
Title: Re: New revs
Post by: Nao on December 21st, 2011, 09:18 AM
rev 1209
(1 file, 3kb)

@ And... Down to 2305 bytes. Ah ah. In order to lose the extra 46 bytes, I add to lose a few feat... Oh, sorry, I mean I fixed bugs and added stuff.

+ Custom option classes should now be correctly transferred to their HTML equivalent, in addition to their already transferred styles. (sbox.js)

! Fixed and simplified item navigation through letter typing: stroke an 'e' and it'll find the first item that starts with an e; hit 'e' again and it'll move onto the next item starting with an 'e', repeatedly until it resets to the first 'e' again. (sbox.js)
Title: Re: New revs
Post by: Nao on December 21st, 2011, 10:32 PM
rev 1210
(2 files, 7kb)

* Simplified and improved select box styling. Also updated general input styles to match. Unsure about the internal padding as it may look like an extra space in the inputs, though... (index.css)

* Simplified internal HTML code when dealing with optgroups. Instead of having nested lists, everything is on a single level. (sbox.js)

! Fixed a minor bug in the original select box plugin where aria-disabled wasn't set at all. (sbox.js)

! Select box selection titles needed to be un-htmlspecialchar'ed, or whatever. (sbox.js)

@ Unfortunately, these 'simplifications' and fixes increased the final size by 22 bytes. Ah, well.
Title: Re: New revs
Post by: Nao on December 22nd, 2011, 01:02 AM
rev 1211
(3 files, 3kb)

* Rewrote the way dropdowns are shown in select boxes. Instead of being attached to the body, they're now physically where they're supposed to be. In order to avoid the classic issue of an absolutely-positioned dropdown being cut off by an 'overflow: hidden' element, I've used the technique I used in the menu code, which is apparently little known: setting no relatively positioned parent, and setting the top margin instead of the top position. instead avoiding to set a position on the absolutely positioned element. The element will be naturally positioned below its owner. The drop-up code is a bit buggy but I have no time to fix it tonight. (sbox.js, index.css, sections.css)

- Removed the ctx option (because it's no longer useful), and the arrow option (because, well, WE won't change it anyway...) (sbox.js)

! Fixed an extra colon that broke JavaScript in IE7. (sbox.js)

@ As a result, the final gzipped sbox file is a whopping 110+ byte smaller than in the previous revision! :)
Title: Re: New revs
Post by: Nao on December 22nd, 2011, 10:49 AM
rev 1212
(1 file, 3kb)

! Fixed drop-up positioning, as promised last night. Phew... Seems to work perfectly. Tested in Opera 12, and some old browsers like Firefox 3.6 and IE 7/8. (sbox.js)

* Replaced a few addClass calls with a more proper toggleClass. Merged the two hover functions into one. Rewrote half of PositionSB() to make use of ternary operations instead of code blocks. Down to 2194 bytes! Woohoo! (sbox.js)
Title: Re: New revs
Post by: Nao on December 22nd, 2011, 04:26 PM
rev 1213
(1 file, 2kb)

! The close animation wasn't triggered when opening another select box. Used the opportunity to rewrite it to use both fading out and sliding up. If that isn't too much...?! (sbox.js)

! Fixed dirty area glitches in Opera when closing some select boxes. Still buggy in the sidebar but it's a different problem which I haven't been able to figure out for now. (sbox.js)

- Removed or simplified more sbox things... $sb's close event doesn't need a namespace (only $(document) does), the 'closing' bool was replaced by the .is('.open') test -- the trick was simply to remove that specific class *before* doing the closing animation, uh... Current file size: 2184. And I have a feeling I can actually go under 2000 now... Is it my new goal? Have I got a life? The answer next week! (sbox.js)

@ Note: at this point, I'm not even sure there'll be anything left of the original plugin in my code... :P
Title: Re: New revs
Post by: Nao on December 22nd, 2011, 11:29 PM
rev 1214 -- not my finest commit, but whatever... what matters is the commitment :P
(2 files, 2kb)

* And... Down to 2147 bytes. The $.fn.sb object is as small as it'll ever be. extraWidth and offsetFrom always get passed jQuery objects (since they're plugins, technically...), so they don't need to access $(this), just this. 'self' was no longer used, so there it goes. $orig and o are directly initialized by the Selectbox object function's arguments now. And that's enough to reduce the size by 40+ bytes, as you can see. (sbox.js)

+ Added support for IE6 in the select box plugin. Well, to be precise -- it's not that I want the full experience to be on IE6. It's just that I don't see why I should waste time on every browser testing for IE6 before I can create the select box object. Considering that the internal HTML structure no longer requires direct > selectors, IE6 actually behaves well in most cases. The only issue is that it doesn't support compound classes, but it's not a big deal in this case, and anyway I'll probably add some JavaScript to deal with that for it. Also fixed a related rendering glitch in profile options. (sbox.js, index.ie6.css)
Title: Re: New revs
Post by: Nao on December 23rd, 2011, 06:39 PM
rev 1215
(2 files, 6kb)

* Down to 2057 bytes, lost another 90![1] Done mainly by turning extraWidth() into a normal function, removing offsetFrom() entirely, moving some function calls around, moving named functions to unnamed status or simple code blocks (like clickSB, destroySB and delayPositionSB), and other things like that. (sbox.js)

+ Instead of using the space key, using the arrow keys on a closed but focused box will open it. It feels more natural somehow. (sbox.js)

! The display area's active class toggler didn't work properly. Hadn't for quite for time, actually... (sbox.js)

* Replaced untouched minilogo with the new one. (other/images/minilogo.png)

:edit: Currently at 2041 bytes... :^^;:
 1. It may be doable to go under 2000 just for fun, but... It's probably going to be quite hard if I want to keep all features in. Then again, until an hour ago I never noticed that some of the functions didn't need to be called at all...
Title: Re: New revs
Post by: Nao on December 24th, 2011, 12:30 AM
rev 1216
(3 files, 6kb)

* Down to 1996 bytes... I knew it could be done![1] Tricks involved: clearTimeout() on an undefined variable doesn't generate an exception, no need to preset it to null. Removed custom CSS class name, as planned some time ago. The new namespace is 'sbox'. Removed the IE7 glitch fixing code -- I tested it under IE7, obviously, and couldn't see any difference... Got rid of '.display.active' in favor of '.focused .display' (also implies a few CSS changes). Skipped adding the select box to the body -- went directly for after the original element.

! The original plugin had a minor bug in which it tested for the .focused class in $display instead of $sb. (sbox.js)

* Hopefully made the select box CSS a bit cleaner. (index.css)

+ Just added a small disclaimer in WeCSS's comments. Whatever. (Class-CSS.php)
 1. And I'm definitely putting an end to my research... From this point on, the size will go UPWARDS. I don't think I could have gone below 1900 bytes without removing support for ARIA.
Title: Re: New revs
Post by: Nao on December 24th, 2011, 12:39 PM
rev 1217
(3 files, 2kb)

! Hitting a function key with a select box opened would ignore it. (sbox.js)

! The change event for the original select box was never triggered. (sbox.js)

! Fixed bad positioning (again?!) when using drop-ups instead of drop-downs. (sbox.js)

- Set default maxHeight to 500, because after experimenting with a 600px one... It's just too imposing. (sbox.js)

! Syntax errors in board management JavaScript code. Thanks John for reporting it. (ManageBoards.template.php)

! template_permission_index() used a silly optgroup emulation in a long select box, instead of... well, optgroup tags?! (ManagePermissions.template.php)
Title: Re: New revs
Post by: Nao on December 24th, 2011, 03:55 PM
rev 1218
(3 files, 2kb)

! Fixed main menu's position relative to owner when JavaScript is disabled (becomes usable again.) (index.css)

+ Added a transparency effect to the select box background. This is best experienced on the PM View select box, which also demonstrates how a select box can be customized (in this case, size reduction.) (index.css)

* A few minor cleanups to the select box code. Still proudly under 2000 bytes. It won't last, though...! (sbox.js)

* Indenazi. (ManagePermissions.template.php)
Title: Re: New revs
Post by: Nao on December 25th, 2011, 12:31 PM
rev 1219
(2 files, 2kb)

+ Added support for additional lines of text in selectbox lists. These lines won't show up in the display area when selected, so it's the perfect place to give custom details like explaining what the option does, etc. It's also very easy to add them to the original text. Because it's likely to break the layout if JavaScript is disabled, I at least made sure that IE6 can support our custom select boxes, which is why I worked on IE6 support recently. (sbox.js, index.css)

- Removed all public methods for the select box, for simplicity. Now calling $(object).sb() will either create the custom select box, or simply refresh it based on any changes applied to the original select box. Also removed a superfluous call to .removeClass('above'). (sbox.js)

! Fixed this annoying bug where select boxes would be duplicated instead of refreshed. This was due to the associated DOM element being cleaned up a bit too thoroughly. (sbox.js)

@ Current size for sbox is 1995 bytes, the lowest yet. And that's taking into account the 30+ bytes needed for the 'details' feature described above. Oh, and Merry Christmas :)
Title: Re: New revs
Post by: Nao on December 25th, 2011, 12:32 PM
rev 1220
(1 file, 1kb)

! Oops, committed by mistake a few lines of code that aren't working for now. (sbox.js)

(They were commented out, but still... Faulty is faulty, even when not executed :P)
Title: Re: New revs
Post by: Nao on December 25th, 2011, 10:54 PM
rev 1221
(14 files +1 -1, 15kb -- my Christmas-weekend commit.)

! Fixed the label attribution code in the PM area to... well, actually work. Also converted it to use the new select box system. Made various optimizations or jQuery conversions in the PM template. (PersonalMessage.template.php, PersonalMessage.language.php, index.member.css)

! Fixed permission profile deletion code in the Media area. (mediadmin.js)

! Don't trigger the original select box's focus event if refreshing the item, to avoid an infinite loop. (sbox.js)

! Select box refreshing would get incorrect $sb.is(':open') values, that was quite obviously wrong of me. (sbox.js)

! Various select box styling glitches. Mostly avoiding a FOUC before the select box is transformed, by hiding all regular select boxes from view. (index.css, sections.css)

* Moved John's own take of the select box code to the wip folder (a good place to die. It's really too short and smart to kill it any other way.) (Unused-SelectBox.js, script.js)

* Renamed a wip file while I was at it. (Unused.php, Unused-imgBlank.php)

+ An example of the select box's 'details' feature. (ManageSettings.language.php)

* Unclear translation needed an extra comment, I reckon. (PersonalMessage.language.php)

* Spacinazi. (ManageMedia.language.php)
Title: Re: New revs
Post by: Nao on December 26th, 2011, 01:14 AM
rev 1222
(3 files +1, 2kb)

* If select box width is set to fixed, ensure the dropdown's width is set not to break individual items. (sbox.js)

! Fixed width of select box display area. Was a bit off due to my adding some padding... (sbox.js, index.css)

! Forgot that IE6/7 don't support string indexing like str[0], so I restored the .charAt(0) thingy. (script.js)

* Moved linkMagic function to the wip folder. (Unused-linkMagic.js, script.js)

@ Note: sbox.js is currently at 2028 bytes... And it's unlikely it'll go under 2000 bytes at this point. At least it's still under 2 kilobytes... :P
Title: Re: New revs
Post by: Nao on December 26th, 2011, 10:02 AM
rev 1223
(3 files +1, 5kb)

+ Added (or restored?) the ability to change options while refreshing the custom select boxes. It's just a few bytes... (sbox.js)

* Set the default 'fixed' param in select boxes to 'true', because... Well, I've tried it, improved it a bit and it's better. Plus, I'm going to go through all select boxes anyway so I'll quickly spot any box that needs fixing. (sbox.js)

* Did more proper calculation of maximum select box width in non-fixed mode, taking padding and margin into account. (sbox.js, index.css)

* Moved the testStyle function out of the script and into the wip folder. Turns out I hadn't been using can_borderradius or can_boxshadow for quite some time. If someone wants to use them, well... I guess I can distribute the file on the forum or something. (script.js, Unused-testStyle.js)
Title: Re: New revs
Post by: Nao on December 26th, 2011, 11:37 PM
rev 1224
(3 files, 3kb)

+ Added a very nice little animation to fixed select boxes when an item is clicked. Definitely adds to it! (sbox.js)

* Now with pixel-perfect positioning of select box arrow button next to display area. (sbox.js, index.css)

! Went through all main browsers to test the keyboard accessibility of the select box. Turns out only Opera, Firefox and IE9 (I think) were behaving nicely, so I had to fix it for IE 6-8 and Webkit by conditionally moving the event to keydown. Grmpf. (sbox.js)

! Icon selector in the Post template wasn't using a tabindex, and because other elements were using it, it wouldn't be selected when cycling through elements with the Tab key. (Post.template.php)
Title: Re: New revs
Post by: Nao on December 27th, 2011, 01:58 PM
rev 1225
(5 files, 4kb)

! Fixed Welcome page to show Modify/Reply buttons in thoughts area when clicking a thought (as opposed to simply clicking the thought's author link, which was totally counter-intuitive... Thank Apple for their strange handling of hovers.) (Welcome.php)

+ A custom select box's display area should now inherit all of its original's events, effectively dealing with onclick etc without us having to worry about them. This also forced me to add 16 bytes to the .data("eve") retrieval method on every page (because of an IE bug, who else?), although if there are more than 8 event calls on the page, which is quite likely, it'll actually make it shorter. (Subs-Template.php, sbox.js)

* Custom select boxes will no longer trigger their original's events willingly. This is to avoid triggering the select box behavior on my iPod, which although very usable, is also unable to cope with HTML and multi-line elements unlike Wedge's. (sbox.js)

* Optimized select box animation from last commit for size (a bit). Current gzipped minified size is 2074 bytes, which is still quite good! (sbox.js)

* Minor CSS cleanup, including fixing select boxes when inside cat/title headers. (index.css, sections.css)
Title: Re: New revs
Post by: Nao on December 28th, 2011, 12:08 PM
rev 1226
(2 files, 3kb)

+ Move jQuery and script.js to the *top* of the page if the user is logged in and was seen less than 10 minutes ago, making it likely their scripts are already cached and the page will actually finish loading faster. Needs some further benchmarking, but as of now this is one of those ideas that seem so incredibly simple, and yet no one seems to have ever considered it before, so it's probably the genius at work... (Or the village idiot, more likely.) (index.template.php)

! $dd was already part of $sb, no need to re-insert it at open time... Current size is thus 2071 bytes. Still working on the custom scrollbar and not making much progress... Yep, definitely village idiot material here. (sbox.js)
Title: Re: New revs
Post by: Nao on December 29th, 2011, 12:43 AM
rev 1227
(8 files, 8kb)

! Fixed select boxes in post editor. Focused style still sucks a bit. (post.js, sections.css)

+ Added previews of font face, font size and font color inside the post editor select boxes. Always wanted to do that... (post.js)

* Reordered colors in color selector in post editor. Ooooh, rainbow! (Class-Editor.php)

* Simplified $post_errors code by putting long_message errors into an array, like mismatched_tags. I hope I didn't screw anything up, as I did this quite in a hurry. John, I'm counting on you to check this out :) (Class-Editor.php, JSModify.php, PersonalMessage.php, Post.php, Post2.php)

! Always put scripts to the bottom if using IE6. It's too slow. (index.template.php)
Title: Re: New revs
Post by: Nao on December 29th, 2011, 10:16 PM
rev 1228
(4 files, 6kb)

* Rewrote select box navigation logic to match normal select boxes' behavior as much as possible. Basically, clicking outside of an opened select box or pressing the Space bar will revert the selection to the original's. Pressing Return will confirm it. Same for Tab, although in this case it's different from the original behavior (a personal preference.) Behavior is also buggy in conjunction with the post editor, because of conflicting events. Ahh well. Can't have everything... Current gzipped size: 2110 bytes. Still acceptable. (sbox.js)

* Added a small hack to the post editor to specify a tabindex on select boxes in such a way that they'll be seen in the order they appear, rather than after all elements have been tabbed through. (Class-Editor.php)

! Fixed a couple of issues due to select box animations not being properly completed and breaking subsequent actions. (sbox.js)

! Non-dropdown select boxes such as the local avatar selector were made invisible. Oops. (index.css)

! Fixed styling for post editor's select boxes. Should be good now... (sections.css)

@ Personal thought... I'm starting to regret implement the new select box system. Although I'm pretty much done with it, I'm not exactly eager to check all existing select boxes in Wedge and see if they behave as expected... :-/
Title: Re: New revs
Post by: Nao on December 29th, 2011, 10:46 PM
rev 1229
(3 files, 11kb) -- oops, once again committed my WIP for sbox... Reverting in the next commit.

* Rewrote mouse hover functions to behave as if the user was navigating with the keyboard. This allows for the same animations, and to avoid using two different background colors (selected and hover) in the list box. (sbox.js, index.css)

! Fixed invisible select boxes in 'Add Rules' page of PM area. (PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on December 29th, 2011, 10:55 PM
rev 1230
(1 file, 1kb)

- Once again committed my work-in-progress of sbox.js, most of which will soon go to the trashcan... Sorry, sorry! (sbox.js)
Title: Re: New revs
Post by: Nao on December 31st, 2011, 06:30 PM
rev 1231
(10 files, 12kb)

* Rewrote layout of post buttons/shortcuts in Post and PM pages. Moved all related CSS to editor.css. Will commit the PM template as soon as I'm done with its onfocus bugs. (Class-Editor.php, Post.template.php, editor.css, index.css, sections.css, post.js)

+ Added an Opera specific shortcut string (its behavior being different and all). (Post.language.php)

! Fixed missing focus loss in post editor when choosing an option through a select box. Also rewrote the editor JS a bit to fix some rare init bug I've had with jQuery. (editor.js, post.js, suggest.js)

* Rewrote smart tag closer (quote splitter) to require holding the Shift key when pressing Enter. This may be temporary, but as of now I'm not sure I'd rather have it enabled by default. (post.js, Post.language.php)

! Fixed font size on thought privacy select box. (index.css)

@ This commit may (or may not) be broken, because I'm splitting my work in half to do a final 2011 commit.

:edit: from January 1st -- LOL -- rev 1231, committed on 12/31. Totally coincidental!
Title: Re: New revs
Post by: Nao on January 1st, 2012, 08:16 PM
rev 1232
(4 files, 2kb)

! When changing minification option in the admin area, the cache purge would generate an error if one of cache's sub-folders had a name similar to what it would purge. Granted, it probably won't happen outside of a test environment... (ManageServer.php)

! Fixed undefined index in post editor. (Class-Editor.php)

- $txt['shortcuts'] and $txt['shortcuts_firefox'] are duplicated in the index language files. They're only used in a context where the Post language files are loaded... (index.language.php)
Title: Re: New revs
Post by: Nao on January 1st, 2012, 08:34 PM
rev 1233 (one, two, three... three?)
(4 files, 10kb)

+ Added a 'fixed' class that does the same as setting o.fixed to true. Also inverted the meaning of o.fixed, actually, because it didn't make any sense... Added the fixed class to a few select boxes in the PM area that looked bad when resized on the fly. (PersonalMessage.template.php, script.js, sbox.js)

+ Added a 'focus' option to .sb() when reloading an item. It feels a bit hackish, but I still haven't found a way to automatically discover the call is being made from the onfocus event, and Wedge only does this on two occasions so what the hell... This should be used each time a focus event wants to refresh a select box, to avoid an infinite loop because the reload process does trigger the original focus event again. (PersonalMessage.template.php, script.js, sbox.js)

* Now disabling current board's entry in Quick Access select box, instead of changing its background color. I'd say it feels more natural... (script.js)

- Removed maxWidth option from select boxes. It didn't work properly, and the same can be achieved with a 'max-width' setting on .sbox classes in CSS files, plus it's more flexible. (index.css, script.js, sbox.js)

* Many, MANY minor fixes related to selected items. Really, I don't know where to begin... (sbox.js)
  - Cleaned up some unneeded class additions/removals (focused and selected), and some duplicate calls like a double positionSB().
  * openSB's parameter is now focus-related, because we can perfectly determine if it needs an animation by testing whether it's already opened...
  * Display area's text can no longer be empty, it should at least be an unbreakable space (for styling reasons.)
  * Devised a hack to disable event handlers before triggering a native event (focusOriginal()). I'm actually amazed that it works. Heck, this should be made into a native jQuery function, too...
  * The current selection is now cached into $selected.

@ Forgot to log the current size for sbox.js: 2167 bytes. The native event trigger function is the main reason why it went up a bit, rather than dramatically down.
Title: Re: New revs
Post by: Nao on January 4th, 2012, 12:32 PM
rev 1-2-3-4 (could have waited for 12:34 for even more fun but... depends on your idea of fun...)
(8 files +2-2, 20kb)

@ The NIGHTMARE commit... Just because of a couple of onclick and onfocus events in the entire Wedge codebase. I should have removed them instead... Again, many many fixes to the select box system. Keyboard navigation should now properly trigger the click event when using arrows (which a regular select box would never do -- and yes, onclick is only used ONCE in all of Wedge but I'm like that.) Focus and click events had various glitches that I believe I managed to fix entirely. Well, I thought that MANY times and then discovered that it broke every other right click in Iceland when temperature is above 67°C, so I went for a rewrite every time and it would break something else. What fun. I don't want to touch events ever again.

- Removed original's class from $display and $items, because it feels more natural to style ".custom_class .items" than ".items.custom_class". Plus it's compatible with IE6... (sbox.js)

- Removed the .sb("focus") and focusOriginal() hacks. Should work okay without these now... (PersonalMessage.template.php, script.js, sbox.js)

* Ensuring that clicks on select box display area to close it will keep focus on it. (sbox.js)

* Ensuring that selected items are always valid (i.e. they still exist now and haven't been deleted by a refresh.) (sbox.js)

* Rewrote inline event attribution for select boxes by moving event declaration around in the template file, so that they're always available for the plugin to extract from. That way, we fix (okay, I fix) this insane bug where inline events aren't available on select boxes after a refresh. (sbox.js, index.template.php, Subs-Template.php)

+ Implemented or restored (can't exactly remember) instantOpen parameter on OpenSB(), for resizing purposes mainly. (sbox.js)

! Clicking the select box to close it should now properly cancel the current selection. (sbox.js)

! Fixed broken select box widths in IE6 where optgroups were being used. (index.ie6.css)

* Replaced .is(".class") with .hasClass("class"). Gzipped/minified takes 4 extra bytes, but it should be a tad faster to execute. And semantically correct. (sbox.js)

* Moved positioning code inside OpenSB(), since it's only used there. Saves about 20 bytes and compensates for hasClass... (sbox.js)

@ Total size is 2204 bytes (+37). There's only one remaining bug as far as I can tell, which wasn't there a few hours ago. Running a refresh from a focus() event will break the tabindex flow on it, meaning if you tab out, you'll switch to the first element on the page and will have to ctrl-tab backwards to where you want to go. Tested in various browsers, and this only happens in Opera so... I'll live with it for now. Considering the nightmare it was to make this commit work across all browsers and navigation types, I consider such a small glitch to be a victory.

[b)Non-select box changes:[/b]

! theme_base_js() and theme_base_css() were always called through an echo, and yet they insisted on echoing their contents themselves, resulting in misplaced code, opening the door to more bugs. Ouch. (Subs-Cache.php)

+ Added styling for footnotes on printable pages. (Printpage.template.php)

* Renamed other/wip to other/attic, as I consider these snippets to be 'things too interesting not to be committed somewhere', rather than 'things I'm planning to include in Wedge later'. (other/attic)

+ Added a very short snippet inspired by jQuery-tie, which overloads jQuery methods with a new event. I liked the concept, but I'd rather check for all select boxes individually and fix them as needed, rather than relying on a clever hack. (other/attic/Unused-tie.js)

+ Added another very short snippet showing how to import a DOM element's event data into another element. (other/attic/Unused-events.js)
Title: Re: New revs
Post by: Nao on January 4th, 2012, 07:21 PM
rev 1235
(3 files, 3kb)

* Made setSelected() a bit faster. And as a fine geek, I also added comments with performance comparisons. Don't mind me. (sbox.js)

! Fixed select box display area being too wide when the default selection has a details pane. (sbox.js)

! Fixed the $here bug where using it on a local Windows install would generate URLS like ..\Hello/world.png, which browsers don't like. It's a bit hackish but at least it's short and fast. And no, it doesn't seem to have anything to do with plugin directories... (Thanks John!) (Subs-Cache.php)

* All these quotes in PM headers looked odd to me. (PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on January 6th, 2012, 02:22 PM
rev 1236
(8 files, 3kb)

+ Added Ctrl-Enter combination to auto-split quotes in the editor, in addition to the (documented) Shift-Enter combination. And no, I don't have fat fingers... I just type too fast sometimes. (post.js)

- $txt['calendar_month'] and $txt['calendar_day'] are only used in the subscription interface, and don't need to clutter the index language files. (index.language.php, ManagePaid.language.php, ManagePaid.template.php)

+ Added an animation to subscription type switching. (ManagePaid.template.php)

! Adding a subscription for a user uses the 'Add subscription' language string, rather than 'Add user to subscription', in the visible headers. (ManagePaid.template.php)

! Per-user language selection requires password authentication. (Profile-Modify.php)

! Looks odd, but we don't need to put "new Image()" into a var before setting its src attribute... (Themes.template.php)
Title: Re: New revs
Post by: Nao on January 6th, 2012, 09:11 PM
rev 1237
(7 files, 16kb)

- Removed selectRadioByName, which is barely ever used in the Wedge codebase, and replaced it with shorter inline jQuery replacements. Fixed a couple of minor bugs in the process. (ManageBans.template.php, ManageSearch.template.php, Profile.template.php, script.js)

- Removed onBeforeUpdate callback from auto-suggest code. onfocus() does just as well, you know! (ManageBans.template.php, suggest.js)

- Removed the 'temporary fix' on Opera when using code tags. It's a very old fix now, and this bug doesn't show up in current versions, no need to bother users with that... (install.sql)

! Fixed search method layout. (admin.css)

+ Added basic JavaScript recognition of iPads (is_tablet). As in, "a device with a screen large enough, but that still relies on touch events." I don't know of any other tablet UAs anyway... (script.js)



* A massive overall rewrite of the main script file, resulting in a 4999-byte gzipped/minified script.js, a 10% improvement. And that 10% share is also the size of Wedge's script file compared with a stock copy of SMF's on a server with mod_deflate off. (script.js)

  - 'vers' is useless, just use $.browser.version directly. And it compresses better to just repeat that...

  * It's cleaner to have one is_* browser declaration per line, instead of several.

  - Removed removeEntities prototype -- only used in one place, and I doubt any plugin would use it. Well, if they do... They can always reproduce it.

  - Removed we_itemPos -- as indicated, it wasn't used anywhere. Plugin authors should use $(item).offset() instead.

  - Removed Thought.getText prototype, only used once in the code, moved it there directly.

  - Removed the "Safari 1.3 Beta" bug fix. Seriously, it was released back in 2005, when work on SMF 2.0 wasn't even started...

  * Replaced every single for () loop with an $.each() call. Saves an awful lot.

  * Replaced most 'something in container' tests, replaced with 'container.something' or something else depending on the context. While the 'in' solution is important in some specific cases, it isn't here. (Not sure about document.cookie, but apparently it's always there.)

  - Removed bIgnoreDisabled flag from invertAll. Only used once in Wedge -- and it's going away since it's in the Package code.

  - Removed bActOnElement flag from weSelectText. I couldn't find it used anywhere in Wedge (and probably in SMF, either.)

  - Used regular show_ajax/hide_ajax on ajaxRating, rather than the custom loader. Although it can be seen as a regression...

  - There's no need to declare a local variable if you're assigning directly to "new images().src". I know -- it's awkward!

  @ Good to know for later: sometimes, there's a chance that declaring local variables as fake parameters will save space. (See weSaveEntities and Thought.edit)

  * Replaced JumpTo's big object with a simple array. I just added the equivalent variable names in comments.

  * Converted weCookie, weToggle and Thought classes to use this.method in constructor, rather than prototypes. Since they're not usually called thousands of times per page, there's virtually no drawback to this, and it allows declaring local variables for everything instead of using the this keyword.
Title: Re: New revs
Post by: Nao on January 6th, 2012, 09:17 PM
rev 1238
(6 files, 2kb)

* Decided to update the entire sbox file to use single quotes instead of double quotes. This 'tiny' change ended up saving 50+ bytes at compression time. While I'm not ready to commit sbox yet, I've applied the same technique to all other JS files. Well, whatever I could find, at least. Well, that compensates my disappointment when I tried shortening "new Object()" calls to "new Object" and didn't notice any benefits -- sometimes it even made the file larger... (editor.js, post.js, sha1.js, spellcheck.js, topic.js, up.js)
Title: Re: New revs
Post by: Nao on January 7th, 2012, 12:01 AM
rev 1239
(2 files, 3kb)

+ And here's the big scrollbar commit... So, it's ugly (needs some CSS love!), it has bugs (double-clicking, clicking the scrollbar without dragging, etc.), but it works as expected. And although it also works on touch devices, it's so slow and user-unfriendly that I've disabled it. (sbox.js, index.css)

* As you can see, all single and double quotes are now swapped, and it does save 50+ bytes when concatenated with another files that uses single quotes everywhere, such as script.js. (sbox.js)

@ Current sbox size: 2946 bytes, so that's a 750+ byte increase due to the addition of the scrollbar code, but you may want to remove from that the 600+ bytes I saved in earlier commits today. So, the final gzipped, minified and concatenated file is only about 100 bytes larger than before. Then again -- if I remove the scrollbar code, we'll definitely save 750 bytes. What's best..?
Title: Re: New revs
Post by: Nao on January 7th, 2012, 12:37 PM
rev 1240
(1 file, 8kb)

* Hardcoded maximum select box height to 250 pixels instead of 500. Looks like a good compromise between usability and comfort. (sbox.js)

* sbox is down to 2734, over 200 bytes saved in an hour or two. (sbox.js)

  - Finally removed the options object, with the understanding that Wedge is better off with *consistent* styling, and shouldn't allow for different animation speeds or maximum heights across multiple boxes on a page.

  - Removed .sc() object and instead assigned a scrollbar object directly to the individual dropdowns.

  - Removed a few unused (or barely used) variables. Removed touch events, as hinted yesterday.

  * Added a "e.wheelDelta || -e.details" hack, which hopefully will work...

  * And cleaned up the creation process, which used two different variables for exactly the same object...


@ To do: merge the SelectBox and ScrollBar objects, and see if it helps with compression or makes it worse. I reckon it won't be any better, but I've seen more surprising things happen.
Title: Re: New revs
Post by: Nao on January 7th, 2012, 08:25 PM
rev 1241
(6 files +2, 9kb)

* Improved thumb styling in select box scrollbars. (index.css)

* More space optimizations... Reached 2707 bytes, another 27 bytes less. As you can imagine though -- it's going to be pretty much impossible to go below 2700 bytes at this point. But it's okay, the code looks great. (sbox.js)

! Fixed select box closing itself when clicking on the scrollbar outside the thumb (instead of actually moving the thumb to that position.) Note to self: that 'return false' in drag() was important, it just needed to be moved to another event type... (sbox.js)

! Fixed IE6's tendency to enlarge select boxes to full width. (index.ie6.css)

! Fixed broken button layout in IE6 and IE7. Copied the .inline-block method to the editor CSS files, since they can't inherit from index.css (not the same final cache file), and said method is solid enough. (editor.css, editor.ie6.css, editor.ie7.css, index.ie7.css)

@ Note: scrollbars are broken in IE6, most likely because of a bug when calculating the required height. Should I care about that...? I'm thinking not... Also, releasing the mouse button outside of a select box after dragging its thumb will close the select box in IE 6/7/8/9. Dunno why, but it seems to doesn't take the 'return false' into account (yeah, the one mentioned above), as it bubbles up the DOM tree.
Title: Re: New revs
Post by: Nao on January 8th, 2012, 12:47 PM
rev 1242
(2 files, 2kb)

* $(document).click() is now $(document).mousedown(), thus $display.click() no longer needs to return false. (sbox.js)

* Select box entries are now clickable through .mousedown() instead of .click(), which fixes a problem with IE 6/7 when dragging the scrollbar and releasing the mouse button outside of the select box (guess what, it would close it.) (sbox.js)

! ...And the fix above caused IE 6/7/8 to select the item text in some cases, so I added an onselectstart event that adds 12 bytes to the gzipped file, which I compensated in other areas to retain the exact same final size. I am absolutely mental. Please help me. (sbox.js)

- Got rid of setting maxHeight in dropdown CSS, to add support for scrollbars in IE6. It's ongoing though, so it still actually doesn't work in IE6 but it'll be done soon enough. (sbox.js)

- Select box 'text' class doesn't need to be an inline block, really. Also, 'items' class (unordered list) behaves better as inline. (index.css)

+ Added a hover effect on select box scrollbar thumbs. (index.css)
Title: Re: New revs
Post by: Nao on January 8th, 2012, 07:33 PM
rev 1243
(3 files, 2kb)

* Simplified the HTML markup for the scrollbar. Gone is the track div (the scrollbar div itself does the job perfectly), the thumb div loses its class, and viewport/scrollbar are now floated instead of absolutely-positioned (note to self: .viewport doesn't need to be floated, it just makes the file shorter), which makes for simpler code in the end, and this actually... (index.css)

! ...Fixed the scrollbar in IE6. Phew, at last. Tested final code on IE 6/7/8/9, Safari 5.1, Chrome 17, Firefox 9 and Opera 12. Works flawlessly everywhere (except for the odd margins on IE 6/7, probably due to an issue in styling unordered lists.) (sbox.js, index.css)

* The credits page needed a small update. (Credits.php)

@ 2669 bytes. Need I say more, ladies and gentlemen...? (sbox.js)
Title: Re: New revs
Post by: Nao on January 10th, 2012, 02:30 PM
rev 1244
(3 files, 4kb)

! Auto-suggest would gladly show the same name twice if you entered it again by mistake. I'm not exactly sure why. Ensuring this doesn't happen. (suggest.js)

- Removed unused hooks from auto-suggest code. (suggest.js)

! Fixed auto-suggest not working at all in PM mode. (pm.js, suggest.js)

* Also rewrote PM To/Bcc auto-suggest handling to use cleaner code. (PersonalMessage.template.php, pm.js)
Title: Re: New revs
Post by: Nao on January 11th, 2012, 08:58 AM
rev 1245
(2 files, 5kb)

! Fixed select box internal paddings in IE 6/7, while making the HTML, CSS and JavaScript code even shorter (33 bytes for JS). (sbox.js, index.css)

* Select boxes will now inherit their original's ID. This should make it easier to manipulate the new select box without having to resort to .sb(). See example in quick mod boxes. (sbox.js)

- Removed aria-labelledby. It was using too much code for something that's pretty useless, given that the label tag does everything on its own. Or doesn't it? My problem is that NVDA sucks when it comes to providing accessibility for our select boxes (we'll need to work on that), but at the very least it can draw its information from the label and doesn't need Aria for that. (sbox.js)

@ Current sbox size: 2577. There are still some bugs left to fix, though...
Title: Re: New revs
Post by: Nao on January 11th, 2012, 09:09 AM
rev 1246
(18 files, 5kb)

* Replaced these ugly ----- in select boxes with proper horizontal rules. I decided to go for a class, and instead of running extra JS on every single select box, I'm adding the class directly to the original HTML. Cleaner. (Groups.php, ManageMembers.php, ManageSmileys.php, ManageMaintenance.template.php, ManageMedia.template.php, ManageScheduledTasks.template.php, ModerationCenter.template.php, Profile.template.php, Search.template.php -- index.css already committed)

* Forgot to apply some jQuerification to the blog index. (MessageIndex.template.php)

! Generic form settings in Admin area would generate a label without associating it with the element. (Admin.template.php)

! Fixed button height and simplified CSS in select boxes in most instances. I wasn't sure that would even work... Turns out it works even in IE6. (editor.css, index.member.css -- index.css already committed)

* Spacinazi. (ManageMemberOptions.php, ModerationCenter.php, SplitTopics.php, GenericList.template.php)

! Translation error. (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on January 11th, 2012, 11:45 AM
rev 1247 -- just to be clear ;)
(2 files, 1kb)

! Undefined index error (thanks John). (Admin.template.php)

! The footer logo was incorrect in Wuthering. (Wuthering/index.css)
Title: Re: New revs
Post by: Nao on January 12th, 2012, 10:05 AM
rev 1248
(3 files +1, 6kb)

+ Added ability for users to add a Custom.template.php file to their theme, allowing them to override/add/prepend code to their index template without modifying it, which can be very useful if they want to customize any template in a minor way that doesn't require creating a new theme, and still be able to upgrade their copy of Wedge without re-editing the files every time. Heck, that's a long explanation for just one line of code...! (Load.php, attic/Custom.template.php)

* Repositioned select box styling in the WeCSS file to help with selector specificity and crap like that. (index.css)

* Just a minor if() rewrite for readability. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on January 13th, 2012, 12:10 AM
rev 1249
(2 files, 3kb)

! Fixed situation where de-focusing a select box by clicking somewhere else in the document, and then pressing a navigation keyboard shortcut, would actually trigger said shortcut in the blurred select box. Costs an extra byte at compression time. (sbox.js)

* Moved all drag'n'drop code inside the plugin itself, to avoid setting up a mousemove event on $(document) on all page loads, instead of when it's actually needed. I don't see any drawbacks to that...? And it saves half a dozen bytes. I like fixing bugs and shortening my gzipped files at the same time, if you didn't notice. You must be blind. And deaf. And if you really are, please tell me where you think I could improve accessibility. (script.js)
Title: Re: New revs
Post by: Nao on January 13th, 2012, 12:11 AM
rev 1250
(1 file, 4kb)

* Rewrote add_css_file() to merge it with wedge_cache_css(). Should make the whole code cleaner this way... To do: merge it with add_plugin_css_file() as well. For now, I simply rewrote its webkit regex to use \b. (Subs-Cache.php)

! Fixed inherited skins where non-main files, such as admin.css, wouldn't properly inherit their parents' contents. Can't believe I finished working on this a year ago and never noticed any problem with it... (Subs-Cache.php)
Title: Re: New revs
Post by: Arantor on January 13th, 2012, 02:52 AM
Revision: 1251
Author: arantor
Date: 13 January 2012 01:52:07
Message:
! Happy New Year: updated visible copyright dates. Not brave enough to update every file in distribution so left it purely at the publicly visible dates. (install.php, upgrade.php, Credits.php, Who language file)
! bbcode can be added through the plugin manager. Seems to cover everything that should be supported at this point as well as enforcing the rules around what data goes with what bbcode. (install.sql, plugin-info.rng, ManagePlugins.php)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/plugin-info.rng
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on January 13th, 2012, 09:50 AM
rev 1252
(6 files +2, 4kb)

* It feels better to use monospaced fonts for regex input fields. (Admin.template.php, admin.css)

! Selecting a profile field template like Facebook etc. wouldn't properly update the select box selections. (Admin.template.php)

! Fixed CSS caching process failing at install time, hopefully. (Subs-Cache.php)

! Fixed Wuthering header styling in IE 6-10. (Wuthering/index.ie*.css)
Title: Re: New revs
Post by: Nao on January 13th, 2012, 03:19 PM
rev 1253
(2 files, 2kb)

! Fixed select box glitch where long optgroups would sometimes generate an extra 15px whitespace on the right side. (sbox.js)

! Fixed select box glitch where the display area's width after selecting an item would be calculated incorrectly if display used different styles compared to the dropdown. (sbox.js)

! And a third select box bug fix I forgot to commit... Whatever that was, it was annoying. (index.css)

@ The first two fixes basically use the same technique (setting width to auto), and cost an extra 21 bytes. Well, at least it's still under 2600... Hello? Is anyone listening? Oh, I should have guessed... The rascals. Tomorrow's lottery numbers will be 3, 12, 21, 42 and... Oh, now everyone is listening uh? I'm telling you. Rascals.


@ Okay, I think I'm mostly done with select box fixes... Well, never say never. But it's all around very solid for now. And please, for the love of Carmack, don't try and modify sbox.js any longer!
Title: Re: New revs
Post by: Nao on January 14th, 2012, 11:24 AM
rev 1254
(3 files, 2kb)

! updateOnlineWithError() could be called before $user_info was set, thus generating silent errors. (Errors.php)

! sendmail() could be called before $context['server'] was set, thus generating silent errors. Thank you, copy and paste! (Subs-Post.php)

* Commenazi. (QueryString.php)
Title: Re: New revs
Post by: Nao on January 14th, 2012, 07:53 PM
rev 1255
(9 files -1 +13, 29kb) (mostly icons being moved around.)

* Rewrote input button styling to be more consistent across different browsers. As always, I started with Opera, and I fixed the CSS manually in Firefox 9, IE 8/9/10 (IE8 sucks because it renders text incorrectly), and Chrome 17. Won't bother with the rest. (index.css, index.firefox.css, index.ie*.css, index.webkit.css, other/images/buttons/*, images/buttons/*)

* Spacinazi. (theme.js)
Title: Re: New revs
Post by: Nao on January 14th, 2012, 08:01 PM
rev 1256
(5 files, 4kb)

! Warm was broken in complex pages, due to the indentation code being too heavy, even while using atomic grouping... Bugger. (Subs-Template.php)

* Modified thought editor to use an indexed array for privacy levels. Used the totally arbitrary following numbers: 1 for public, 5 for members, 8 for self. Removed a couple of entries that I have yet to implement in Wedge. (index.template.php, index.language.php)

* Moved all script_in_head code to template_body_after(), it should be cleaner this way. Scripts are now added at the end of the head tag instead of the beginning, which is the recommended position. Decided that IE7 and IE8 aren't fast enough to justify moving script tags either. (index.template.php)

* Commenazi. (QueryString.php)
Title: Re: New revs
Post by: Nao on January 15th, 2012, 01:08 AM
rev 1257
(2 files, 1kb)

! $context['skin_folders'] was filled in incorrectly when caching a replace-type skin. (Subs-Cache.php)

* Forgot to document the 'indent' parameter. (Warm/skin.xml)
Title: Re: New revs
Post by: Nao on January 15th, 2012, 10:15 AM
rev 1258
(258 files, 13kb)

* Updated copyright year to 2012 in file headers.

@ 258 files in rev 1258...? Another funny coincidence ;)
Title: Re: New revs
Post by: Nao on January 17th, 2012, 02:04 PM
rev 1259
(3 files, 4kb)

! It's more code than I'd have liked, but I fixed 'replace'-type skins so that skin authors don't have to import the entire list of files off the top-level skin. If you don't want to include admin.css for instance, so that you can safely get Wedge updates on that file without having to copy them manually, you no longer need to. Wedge will automatically import whatever it needs from the top-level folder. Documented in the Warm skin file, as usual. (Subs-Cache.php, Warm/skin.xml)

- Removed Andale Mono from possible editor font choices. The font is no longer shipped with modern Windows, and although it's still available in Mac OS X, there's really not much of a reason to use it over the tt tag, which in Wedge uses Consolas or Monaco, arguably better fonts for the same job. Plus, there's always Courier New in the list. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on January 17th, 2012, 11:18 PM
rev 1260
(2 files, 1kb)

! Fixed incorrect positioning inside select box dropdown during its opening animation, as well as when first using the mouse wheel if not positioned at the top. (sbox.js)

! Fixed select box animation glitches when using Opera and select box is within an inline box or something. Well, technically I've hidden the problem under the carpet rather than fixed it, but whatever. (sbox.js)

* Simplified some of the select box code. Scrollbar didn't need updating when re-opening dropdowns. There was no need for openSB to check for the .open class either (it's always done before the function is called), and scrollbar creation was doing some extra hiding/showing work on the dropdown, which was already done in its parent function. All in all, saved a total of 32 bytes :) (sbox.js)

- Not sure why the yesno HTML had an extra div... (Media.template.php)
Title: Re: New revs
Post by: Nao on January 18th, 2012, 04:04 PM
rev 1261
(3 files, 2kb)

! Browser test variables (is_*) were returning 'undefined' instead of 'false', causing an issue with opacity animation in the menus.[1] (script.js)

! Fixed Wedgeward credit not aligning correctly in old IE versions. (Credits.php)

* Translation fix. (Admin.french.php)
 1. I couldn't decide whether the opacity animation should actually stay or not, though. I like it in the main menu, but it's a bit overkill elsewhere.
Title: Re: New revs
Post by: Nao on January 20th, 2012, 04:52 PM
rev 1262
(4 files, 11kb)

* I'm going to go slowly with that editor rewrite mentioned on the forums... First, I'm committing things not related to removing (or keeping) the iframe. Then we'll see where it starts to go crazy. (editor.js)

  - Removed blur/focus functions for IE. They weren't in use anyway.
  - Removed unprotectText, integrated it in the only place where it was used.
  - Removed debug breadcrumb, probably of some use to the SMF devs back in the day. Not anymore.
  ! Do not test for the existence of pasteHTML on a Range object that could very well be set to null...
  ! Fixed BBC tags being added in reverse order if the cursor is at the start of a line (in Chrome and Opera at least.)
    @ As suggested in SMF's bug report #4071, but never applied to SMF itself.

* Moved surroundText and replaceText back into the editor object. I figured that they're too specific to be decently usable by plugins. They might as well write their own code (or just copy it from there, not an issue.) (post.js, editor.js)

* The Send PM page didn't have the right title. (PersonalMessage.php)

- Removed MegaVideo from Aeva's video site list. In case you didn't hear on the news, it would seem that they're gone for good... (Subs-Aeva-Sites.php)
Title: Re: New revs
Post by: Nao on January 20th, 2012, 05:28 PM
rev 1263
(1 file, 3kb)

* A few more incremental rewrites for the editor. (editor.js)

  * Renamed oTextHandle to oText, and made it a jQuery object. Rewrote related code to use jQuery as well.
  * Renamed oweEditorCurrentResize to oCurrentResize.
  * Renamed an onresize to onresizestart, to match the code in the PHP class.
  - Removed instanceRef variables, never used (known song.)
  - resizeTextArea() only takes one parameter. Removed all unrelated code, including that long function that calculated dimensions...
Title: Re: New revs
Post by: Nao on January 20th, 2012, 08:02 PM
rev 1264
(1 file, 1kb)

* Setting editor frame's body to maximum height, allowing Opera users to click anywhere in the frame to select it (other browsers don't seem to work as well here.) (editor.js)

! Firefox still needed the 'silly hack' to focus, even if not showing the blinking cursor. It's all about disabling the navigation keys... (editor.js)
Title: Re: New revs
Post by: Nao on January 21st, 2012, 11:36 PM
rev 1265
(2 files, 1kb)

* Simplified editor resizing code. document.mousemove() works perfectly across all browsers I tested, even if hovering the iframe. Which totally makes sense... Also, I didn't see why it should cancel the resizing process if trying to resize to zero height. Wedge will simply set a minimum height for the editor. And finally, removed the default resizers in Chrome and the latest Firefoxes, through CSS. (editor.js, editor.css)

- Removed rev 1264's iframe height hack, as it didn't actually work, even in Opera. A momentary lapse of reason. (editor.js)

- Removed a few unused variables and function names. (editor.js)
Title: Re: New revs
Post by: Nao on January 22nd, 2012, 09:40 AM
rev 1266
(2 files, 4kb)

* Dozens of size optimizations. Really, that's all there is to this commit... Still, it's a lot of changes and I need to commit them separately. (editor.js)

- Removed bRTL parameter from editor -- using document's HTML dir instead. (editor.js, Class-Editor.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2012, 10:50 AM
rev 1267
(9 files, 9kb)

+ Added a section tag around all sidebar blocks. Although it's not 'mandatory' per se, it'd be good practice to separate sidebar blocks semantically, in case it has to be shown horizontally.[1] (Admin.template.php, Display.template.php, GenericMenu.template.php, index.template.php, InfoCenter.template.php, Media.template.php, MessageIndex.template.php)

! Avoid generating confusing PHP 'undefined index' errors when doing improper CSS nesting. This really calls for a error handler to be implemented, but for now I think I'd rather have the skin author get a 'visual' hint that they made a mistake (i.e. incorrect styles) than a PHP error, which they're not always likely to notice. (Class-CSS.php)

! Forgot (it seems to be my most common mistake?) the semi-colons on the surroundText/replaceText method reintroductions. Also optimized more code. (editor.js)

! Wysiwyg editor no longer worked in IE6 and IE7. (editor.js)

@ Note: it STILL doesn't work properly, i.e. focus is broken, like my infamous iframe-less rewrite... Looks like this has been the case for some time, though, actually even before I started the rewrite.

@ Note: the thought editor seems to disappear in some situations. I'll get to that.
 1. Which, as you can guess, I've always wanted to do -- like on Wedge.org -- and am now doing quite properly in Worg...
Title: Re: New revs
Post by: Nao on January 23rd, 2012, 11:19 AM
rev 1268
(2 files, 1kb)

! Fixed the thought editor bug mentioned in the last commit. Code is also a bit tighter now... (script.js)

* 800ms is a tiny bit too much for gallery animations, I'd say... Yeah, I need to apply that to other areas too. (zoomedia.js)
Title: Re: New revs
Post by: Nao on January 24th, 2012, 10:11 AM
rev 1269
(4 files, 2kb)

* Quotenazi. (Class-Editor.php)

* PM rule descriptions should put more emphasis on the and/or switch, so I'm setting it to bold instead of italics. (PersonalMessage.language.php)

! Auto-suggest dropdown wasn't removed when using the Backspace key on an entry with three characters. This was due to an incorrect 'this' reference in the setTimeout call. (suggest.js)
Title: Re: New revs
Post by: Nao on January 25th, 2012, 11:38 PM
rev 1270
(5 files, 4kb)

! Fixed this most *annoying* IE 6-10 bug that took me over a week to find and neutralize, where the cursor position was reset to the message's beginning when clicking a smiley or button in Wysiwyg mode. Note for anyone at SMF tempted to use sprites for buttons in the editor: don't even think of getting rid of the img tag. Or at least, just having an empty div will break your stuff. Trust me, you don't wanna waste a week debugging this. (Class-Editor.php)

! Fixed another IE bug where it didn't correctly convert smileys from Wysiwyg to non-Wysiwyg mode. This is because it seems to reorder img tag parameters instead of using whatever was requested originally. Bad IE. (Class-Editor.php)

! Fixed installer's first page: CSS cache generation was broken (resulting in unstyled HTML), and the language select box wouldn't show up. (other/install.php, install.css)

* Moved New/Modify links in the Thought editor to inside the block, rather than in the block header. I'd say I should avoid putting links in short headers, because it can break the overall layout easily. (index.template.php)

* Forgot to document the 'include' keyword for code tags in skin files. (Warm/skin.xml)

:edit: - Removed Arial Black font from font list. Latest versions of Firefox, due to their font engine rewrite, will now ignore a simple "font-family: Arial Black" and instead expect "font-family: Arial; font-weight: 800" to show it. This is too complicated to implement with regards to the limited interest of that font face.
Title: Re: New revs
Post by: Nao on January 26th, 2012, 12:48 AM
rev 1271
(3 files, 14kb)

* Dozens of extra size optimizations on the Wysiwyg editor, most notably all for () loops were replaced with my beloved $.each() call. That was NOT easy, though, especially in post.js... Still, over one kilobyte saved on the gzipped minified file? Not something to complain about! (editor.js, post.js)

* I try to avoid code evaluation when possible, such as in setInterval calls. (post.js)

! Chrome didn't correctly retrieve the current font face when navigating the Wysywig editor. Seems to be working for all three font parameters in IE, Chrome, Firefox and Opera. Last time I checked, it wasn't the case... Let's not ask too many questions. (editor.js)

! updateEditorControls()'s breadcrumb builder would actually execute way too much code in one of its loops, as most of it only needed to be called once. (editor.js)

! Fixed a bug in rev 1270 where I wrote some JavaScript when I meant to be using PHP. Perhaps I was *too* thrilled I'd fixed that bug... (Class-Editor.php)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 10:46 AM
rev 1272
(3 files, 9kb)

* WYSIWYG: Rewrote a lot of the updateEditorControls code to work properly across all browsers I could test against. (editor.js)

+ WYSIWYG: Added an .insertStyle(object) function to the editor object, where you specify a key/value object similar to .css(object) to add specific styles to the selection. Note: if using styleWithCSS, we'd also have to match span[style*="xxx-large"]. Thankfully I removed that one. Also, it could be interesting to actually re-use this code to replace most of the complex insertions like insertCustomHTML... (editor.js)

! WYSIWYG: Only update select boxes if their contents were actually changed. It's not a free process, you know. (post.js)

! WYSIWYG: Ensure select boxes don't try to select an invalid value. (post.js)

* Harmonized editor's textarea and iframe to have the same sizes and appearances. (Well, internal iframe padding is off by a pixel in some browsers but it's the best I could do.) The main trick was to actually set their display to block, as odd as it may sound. (editor.js, editor.css)

:edit: Updated rev 1270's changelog with an item I forgot to document.
Title: Re: New revs
Post by: Nao on January 27th, 2012, 12:35 PM
1273
(5 files, 1kb)

- Removed a few unused global declarations of $user_settings. (ManageServer.php, PersonalMessage.php, Profile.php, Security.php, Subs-Auth.php)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 12:38 PM
rev 1274
(1 file, 2kb)

+ Added a transparency flag to attachments. Yep. You know what I'm gonna do. I just need a couple of hours to grab a snack and check my implementation's elegance. (install.sql)

! Turning BBC size 1-7 to use the equivalent point size instead of em's, to match whatever's in the Wysiwyg editor. (install.sql)

(Next commit will be a bit bigger.)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 03:04 PM
rev 1275
(3 files, 9kb)

+ Added support for transparency in attachments and avatars. Transparency is only calculated when showing an attachment in a topic (loadAttachmentContext), when showing an avatar in the sidebar (loadUserSettings, setupThemeContext), and when loading avatars for other members (loadMemberContext). Calculations are done using the code I wrote for Aeva Media 2.x. Non-transparent avatars get an 'opaque' class, while nothing special is done for attachments right now. Maybe we'll do something later, but I'm lacking inspiration. (Display.php, Load.php, Subs.php)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 04:45 PM
rev 1276
(5 files, 3kb)

+ Just like at Wedge.org, Wedge will now add a New icon next to the page index if there are more unread topic pages available to you. Although it's not as important as back in the day when SMF was buggy and marked an entire topic as read even with more pages unread, it's still nice to easily spot whether there are more pages to go through. (index.template.php)

+ Show a New icon next to the first unread post in topic pages. Wedge.org does it differently (it adds a New icon next to all unread posts), but I felt this might be a bit overwhelming in a generic forum system. (Display.php, Display.template.php)

* Optimized the 'new' icon's size. Didn't expect to save anything, but there you go, a few less bytes. (images/language/new.gif)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 04:56 PM
rev 1277
(25 files, 4kb)

* Renamed constructPageIndex() to template_page_index(), in keeping with the index template's naming guidelines. (index.template.php, 24 files in Sources)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 06:34 PM
rev 1278 -- another set of features I'd been meaning to add from day one!
(4 files, 5kb)

+ Added number of new posts available per topic in the Unread Topics and Unread Replies pages. Another proud feature from Noisen/Wedge.org! And yes, I know, it's a bit of a slow query... But I think it could be worse. And it never killed my forums, after years of use. (Unread.php, UnreadReplies.php, Recent.template.php)

* Remove the thoughts block if no thoughts are found at all. (Welcome.php)
Title: Re: New revs
Post by: Nao on January 27th, 2012, 09:07 PM
rev 1279
(10 files, 4kb)

* Harmonized block headers in the sidebar. Some were using we:title, others were using we:title2, now they're all using we:title. (Display.template.php, GenericMenu.template.php, MessageIndex.template.php)

* Started harmonizing font sizes in the sidebar. Right now it'll look ugly on a stock install, but that's because I'm doing the styling in the new skin, which has yet to be committed. Trust me, it's looking good. (GenericMenu.template.php, InfoCenter.template.php)

- Removed info center's toggler button, because it's of absolutely no use, and a waste of bandwidth. If you want it, you can always, I don't know, get a life. (Boards.php, Welcome.php, InfoCenter.template.php, Welcome.template.php, index.rtl.css, sections.css, Warm/index.css)
Title: Re: New revs
Post by: Nao on January 28th, 2012, 04:09 PM
rev 1280
(10 files, 4kb)

+ Implemented sidebar positioning through skin settings, i.e. <sidebar>. (Load.php, Aeva-Gallery.php, Subs-Cache.php, skin.xml, Warm/skin.xml)

* Replaced $context['post_position'] with $context['sidebar_position'] in topic pages, and inverted their logic obviously. (Display.php, Display.template.php)

* wetem::parent() is a much more elegant way of determining whether the current block is executed in the default layer or in the sidebar... (Media.template.php)

* Micro-styling. (admin.css, media.css)
Title: Re: New revs
Post by: Nao on January 28th, 2012, 05:04 PM
rev 1281
(5 files, 2kb)

* Simplified the final keyword's regex. (Class-CSS.php)

! The final keyword wasn't properly removed if followed with a colon, e.g. ".class final:before". Instead of just added that possibility, I decided to turn the str_replace into a preg_replace with word boundaries, which should be future-proof. (Subs-Cache.php)

! Media area's Home/Albums/Playlists header should be a title header, rather than a category header. (Aeva-Foxy.php, Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on January 29th, 2012, 05:56 PM
rev 1282
(3 files, 2kb)

* I was really, really bothered by the limitations on the 'content' tag in WeCSS. Added some reasonably fast code to protect it.[1] (Subs-Cache.php)

+ Added support for text-overflow on browsers using a prefix for it. (Subs-Cache.php)

- Removed new_win class from Print button, as it didn't exactly open a new window. (Display.php)

! Undefined variable. (Welcome.template.php)
 1. Wasted a couple of hours trying to rewrite Class-CSS and Subs-Cache in more 'efficient' ways, but it was buggy... In the end, the added code really isn't much trouble anyway.
Title: Re: New revs
Post by: Nao on January 30th, 2012, 04:29 PM
rev 1283
(5 files, 5kb)

* Optimized 'content' tag handling speed in WeCSS, and ensured entire lines would be saved. See, the content syntax is quite odd, allowing for multiple strings within quotes, so I might as well save them all. (Subs-Cache.php)

* Profile homepage was missing a closing div, and had improper styling. Hopefully that short inline style thing is just temporary... Also spacinazi. (Profile.template.php)

+ Added board url to the recentTopics() function, just in case. Also spacinazi. (SSI.php)

* Removed 'buttonstrip' class from button list links (you can target them simply with ".buttonlist a"), and moved the 'last' class to their parent li tag, to make it easier to style. (index.template.php)

* News box should be a bit taller. No need to make it so short really...? (admin.css)
Title: Re: New revs
Post by: Nao on January 31st, 2012, 06:01 PM
rev 1284 -- Gosh, I don't want to touch the select box code ever again!
(3 files, 2kb)

+ Added ability to hide a select box option by specifying 'data-hide' to its original option tag. This is effectively helpful for placeholder "defaults" like in the Quick Access box. Internally, it will behave as a hidden 'disabled' item, so that keyboard events don't reach it. (sbox.js)

! Setting a select box size to fixed will later set its width to zero if all its items are disabled or hidden. (sbox.js)

* Started adding a few data-hide properties here and there. (PersonalMessage.template.php, script.js)
Title: Re: New revs
Post by: Nao on January 31st, 2012, 10:05 PM
rev 1285
(60 -7 files, 30kb)

* Renamed the 'sticky topic' feature to 'pin/unpin'. It makes more sense, and semantically it's better to clearly differentiate between doing and undoing an action. The 'make_sticky' permission is renamed to 'pin_topic'. Plus, SMF is 'stuck' with 'stickied'. Meh! (index.php, install.sql and 5 other/* files, Display.php, JSModify.php, ManageAttachments/Permissions/Search/Settings.php, MessageIndex.php, Pin.php, Post.php, Post2.php, QuickMod.php, RemoveTopic.php, ScheduledTasks.php, Search2.php, Security.php, SplitTopics.php, Subs-Post.php, Unread.php, UnreadReplies.php, images/icons/quick_*.gif/small_pin.gif, LANGUAGES: EmailTemplates, Errors, Help, index, ManageMaintenance, ManagePermissions, Modlog, Post, Reports, Search, Who, Wireless, TEMPLATES: ManageMaintenance, ManageSearch, MessageIndex, Post, Recent, Search, Who, Wireless, SKINS: index.css, index.member.css, index.rtl.css, sections.css)

* I believe unpinning a topic should generate a notification just the same way pinning it would. (Pin.php)

- SMF bug: testing for a $sticky variable that is never set. (Display.php)

- SMF bug: show_sticky.gif is a leftover from the Core theme... (show_sticky.php)

- SMF bug: lockicon and stickyicon IDs are never defined. (MessageIndex.template.php)

! Translation error. (Help.french.php)
Title: Re: New revs
Post by: Nao on January 31st, 2012, 10:44 PM
rev 1286
(3 files, 2kb)

+ Wedge will now specify as the body id whether the current page is an action, board or topic. Might be very helpful for skinners and modders. (index.template.php)

! Don't select items in open select boxes if clicking them with the middle or right mouse button. (sbox.js)

! Chrome (and maybe others) wouldn't register function keys and other various keys when a select box was open. (sbox.js)

* Var-nazi. (topic.js)
Title: Re: New revs
Post by: Nao on February 1st, 2012, 02:50 PM
rev 1287
(14 files, 3kb)

* Renamed main_content div to just 'main'. I've double-checked, no single element in Wedge uses 'main' as its id, so why waste good bytes on a long name for this one...? (other/install.php and 6 other files, index.template.php, index.css, index.iphone.css, skin.xml, Warm/index.css, Wuthering/index.css, Wuthering/skin.xml)
Title: Re: New revs
Post by: Nao on February 2nd, 2012, 07:12 PM
rev 1288
(8 files, 8kb -- 88, like the rev number? Another boring coincidence.)

! Fixed weToggle object to actually remember the latest choice. It was broken in both cookie and database modes. (script.js)

* Simplified weToggle object. oCookieOptions only had one option (whether to use cookies or not), so it's now directly indicating the cookie name if it has to be used. The oThemeOptions object was simplified similarly. Removed sThemeId because it's only used in one place, and can be added to sAdditionalVars. Which I renamed to sExtra because, eh, it's shorter. And finally, only print a variable if it's to be set to true. (Boards.template.php, index.template.php, Post.template.php, script.js)

* Replaced many of the key/val placeholders in $.each with the this keyword. Did it everywhere it helped save more gzipped space. That's everywhere but two places. (script.js)

* Replaced the weCookie object with a cookie getter (still called weCookie, though), because the setter didn't make use of the object itself and the getter didn't get the updated cookie so I'd rather do the cookie parsing every time a cookie is requested. Plus, it saves space. For the record -- over 100 gzipped bytes in this commit alone. (script.js)

* sha1.js is always loaded alongside script.js, so don't bother printing the extra copyright info at compilation time. (sha1.js)

* Updated the New icon in both English (better looking W) and French (shortened 'Nouveau' to 'Nouv', because it's perfectly understandable, and takes less space.) (images/language/new.gif)
Title: Re: New revs
Post by: Nao on February 3rd, 2012, 03:12 PM
rev 1289
(7 files, 3kb)

+ Added align parameter to the img bbcode. Pete, please implement the UI for changing bbcodes, because it's a nightmare to do manually :P (install.sql, index.css)

! The sendpm() function was using $context['forum_name'] at one point, without globaling it. (Subs-Post.php)

* Renamed noi_resize() to weres(), and now using it to test whether the page is loaded, instead of window.eves which isn't available if the HTML code holds no inline events. (index.template.php, sbox.js)

- Why should we need to keep these weToggle objects into global variables, when they won't be used at all...? (Boards.template.php, index.template.php)

* Inline JS simplification. (Post.template.php)
Title: Re: New revs
Post by: Nao on February 3rd, 2012, 07:13 PM
rev 1290
(15 files, 5kb)

* Moved both Quick Access select boxes to the sidebar, where it'll sit forever and ever. At least until I add an option to turn it off... (index.php, Display.php, Display.template.php, index.template.php, MessageIndex.template.php, index.french.php, index.ie6.css, index.ie7.css, sections.css, Warm/index.css)

* Moved JumpTo array generation to script.js, even if currently we really only have one JumpTo -- the sidebar one -- but eventually we may start using JumpTo for quick mod as well, so I won't be removing the code. For now. (script.js)

- More weToggle variables removed, whenever they weren't used. (Admin.template.php, Display.template.php, ManagePermissions.template.php, Packages.template.php -- I know, we'll remove that file eventually, Post.template.php)
Title: Re: New revs
Post by: Nao on February 5th, 2012, 10:29 PM
rev 1291
(3 files, 3kb)

! Made sure that our Atom feeds would pass the W3 Unicorn validator. This was done by setting a global id tag (I'm afraid this also means an extra entry in the settings table...), and being stricter about whether we should use CDATA. Also removed the icon tags because they're supported on the feed level, not on the entry level. And added a few todo comments about the unused getXmlProfile function. (Feed.php)

+ Added a link to the Atom feed for latest members in the Member List page. Can't believe it was never done... (Memberlist.template.php)

* Tweaked the HTML indentation level in non-main menus, so that it's similar to the main menu's. (GenericMenu.template.php)
Title: Re: New revs
Post by: Nao on February 5th, 2012, 11:29 PM
rev 1292
(4 files, 3kb)

! Undefined index in WAP mode, due to a typo in the pin_topic permission. (Display.php)

! Undefined index in getXmlProfile... You know, the one I just said wasn't being used. (Feed.php)

! Verification question template's input boxes were too wide, breaking the layout. (Admin.template.php)

! Menu tabs weren't correctly generated if the menu itself was shown in the sidebar, and the sidebar was shown on the right (i.e. after the default layout). Had to move the tab list generation to the generic_tabs() function itself. Also, testing the area ID with a simple == could result in errors, had to go for a strict check. (GenericMenu.template.php)
Title: Re: New revs
Post by: Nao on February 7th, 2012, 11:16 AM
rev 1293
(4 files, 2kb)

! Fixed Quick Reply box showing two editor areas instead of just the one. (editor.js)

* The wireless template really needed some extra padding... I don't care about how phones deal with it. I have the say in how they should render it really. (wireless.css)

* More Image() optimizations. (Load.php)

* Language file typo. (Themes.french.php)

@ I have tons more things to commit... Gonna be a long day.
Title: Re: New revs
Post by: Nao on February 7th, 2012, 05:07 PM
rev 1294 -- ARGHHHhhh
(24 files, 15kb)

* Simplified JumpTo object -- a lot. Removed over 100 bytes of unneeded code. Basically, JumpTo accounts for multiple JumpTo boxes. Not only is this not the case right now -- only the sidebar has one -- but even if I added one to quick mod, it would still be unlikely that one would want to click one of the boxes, then cancel it, then click the other. (index.template.php, script.js)

* Simplified news fader object. Everything is now in a closure, saves about 60 bytes in the final gzipped file (which was short to begin with anyway). The calling code is also shorter, and there's no need for an Optimize section anymore. (Boards.template.php, fader.js)

* Search page will now offer two radio buttons (all boards/specific boards) instead of a single toggler with that confusing 'Check all' checkbox... The rest should behave exactly the same, it's just a UI thing. (Search.template.php, Search.languages.php)

* Per-page action ID is now moved to the html tag, rather than the body tag. (index.template.php)

* Removed global IDs from several files. They're now included directly in the html tag, so apart from a few renames, conversion is straightforward. (MoveTopic.template.php, PersonalMessage.template.php, Profile.template.php, SendTopic.template.php, Who.template.php, index.ie6.css, index.member.css, index.rtl.css, sections.css)

* Renamed quick_login_dec language entry to quick_login_desc. I suppose that's what was meant in the first place, right...? (index.template.php, index.language.php)

* Moved all delayed inline event handling code to script.js, because it didn't really make sense not to cache it... (index.template.php, script.js)

* Rewrote weres() function to remove the need for a global variable, and make it more logical to style responsive layouts. So, instead of the 'edge' div switching between 'edge' and 'edgehide' IDs, Wedge will now simply add a 'responsive' ID to the body tag. Plus, it's MUCH shorter. Starting from this revision, I think all pages are now about 200 bytes shorter. (index.template.php, index.css, index.gecko.css, index.iphone.css, Warm/index.css)

! Turns out that iOS still needs to bypass the weres() function in the original skins. Right now I have no plans to rewrite these skins' sidebar code to match the new skin's, so it'll have to stay this way. (index.template.php)

! Columns width were glitchy in IE6/7. (Who.template.php, index.css, index.ie6.css, index.ie7.css)

! The W3C HTML5 validator no longer validates HTML5+microdata pages, so I'm switching the validator link to validator.nu instead. Additionally, this new solution will validate pages for you even if you have an antivirus enabled. (index.template.php)

* Anything to save a couple of bytes in the gzipped JS files... (sbox.js, script.js)

* Indenazi. (index.template.php)
Title: Re: New revs
Post by: Nao on February 7th, 2012, 05:12 PM
rev 1295
(3 files +11, 98kb)

+ As annoying as it is, I'm committing the skin for Wedge.org, because I'd really like to benefit from SVN features you know... The skin has no name for now, so it'll go by the codename 'Worg'. Also, it's a work in progress, so it's full of commented out code and things like that... Obviously it'll be reworked later. (skins/Worg/*)

! Fixed crash on WAP2 pages, due to template_page_index not being available. (Wireless.template.php)

* Commenazi. (Search.php)
Title: Re: New revs
Post by: Arantor on February 8th, 2012, 03:24 PM
My first in a while. Life is a bitch like that.

(2 added, 3 removed, 15 modified, 30KB)

Revision: 1296
Author: arantor
Date: 08 February 2012 14:22:29
Message:

& Typo that really irritated me in the search engines page. (Search language file)

! Remove file edits from the master copy of the plugin info specification. It isn't implemented currently and isn't going to be in future, so no need to document its format. (plugin-info.rng)

! Attempt to issue headers that cut back on the crap that gets sent out every page. May or may not make a huge difference depending on configuration but it can't hurt to do so. (QueryString.php)

+ Debug output now includes peak memory usage. Not a major thing but can be useful. (Subs-Template.php, index language file)

! Housekeeping of core features images we don't use any more (feature_ml.png, feature_sp.png, feature_w.png)

! Another item kicked off of Core Features and into its own page: Search Engines (now relabeled Search Engine Tracking to better fit with what it does). This resulted in a bit of fixing around how the pages themselves worked, and to make sure that spider_mode was checked, rather than checking any of the other parameters (which previously, Core Features would have done for us). (Admin.php, Load.php, ManageSearchEngines.php, ManageSettings.php, Subs-MembersOnline.php, Who.php, search_engines_*.png, language files: Admin, ManageSettings)

----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Who.php
Deleted : /trunk/Themes/default/images/admin/feature_ml.png
Deleted : /trunk/Themes/default/images/admin/feature_sp.png
Deleted : /trunk/Themes/default/images/admin/feature_w.png
Added : /trunk/Themes/default/images/admin/search_engines_off.png
Added : /trunk/Themes/default/images/admin/search_engines_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on February 8th, 2012, 04:27 PM
(2 modified, 1KB)

Revision: 1297
Author: arantor
Date: 08 February 2012 15:26:54
Message:
! Fix for broken bbcode change in the installer. Remember: if you want a literal \ in the table, you have to escape it in SQL, heh. (install.sql)

! Minor thing that always annoyed me: it shouldn't be possible, even accidentally, to give guests permission to send announcements or edit site-wide news. (ManageNews.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 8th, 2012, 05:42 PM
(3 modified, 11KB)

Revision: 1298
Author: arantor
Date: 08 February 2012 16:41:27
Message:
! The 'show how many people are viewing this...' option is no longer a theme option but now a general option (since it should logically apply consistently to all themes) (Display.php, ManageSettings.php, MessageIndex.php, Subs.php, Display.template.php, MessageIndex.template.php, Settings.template.php, ManageSettings and Themes language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php

(For those wondering, it's in Features and Options with the other 'who's online' type options.)
Title: Re: New revs
Post by: Nao on February 8th, 2012, 05:59 PM
Yay, Pete is back... ;)

rev 1299
(16 files, forgot to watch the patch size, not much though.)

- Removed unused sSelf declarations and global JS variables. (Admin.php, Class-Editor.php, ManageMedia2.php, ManageBans/Boards/Maintenance/Membergroups/News/Paid.template.php, ModerationCenter.template.php, Profile.template.php)

* Replaced forum_index language string with board_index, and moved the forum name outside of it -- mostly so that one could use these strings without having to fill in the forum name. (Boards.php, index.language.php)

* Minor Worg tweaks. (Worg/index.css, Worg/sections.css)
Title: Re: New revs
Post by: Arantor on February 8th, 2012, 06:09 PM
(8 modified, 9KB)

Revision: 1300
Author: arantor
Date: 08 February 2012 17:08:47
Message:
! Move the 'enable collapsable post options' to post options, rather than in theme options. (install.sql, ManagePosts.php, Post.template.php, Settings.template.php, Admin and Themes language files)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on February 8th, 2012, 06:23 PM
rev 1301
(7 files, 3kb)

- While I was at it, I started removing unused globals ($settings, $options, $modSettings etc) from files, until I realized it required too much attention and was prone to errors, so I'm just going to leave it at that and commit whatever I've done... (ManageSettings.php, Subs.php, Display.template.php, ManageNews.template.php, ModerationCenter.template.php, Settings.template.php)
Title: Re: New revs
Post by: Nao on February 8th, 2012, 07:28 PM
rev 1302
(3 files, 3kb)

! Fixed an issue in the JumpTo rewrite where having many boards would make it slow to fill. My bad. (script.js)

* Rewrote XML file sent by the jumpto action, to use less bandwidth, especially when pretty URLs are disabled. (Xml.template.php)

* Not that anyone cares, but a few optimizations here and there allowed me to keep script.js at the same gzipped size, even after adding the extra code for the new XML format. Most notably, there's no need to test for selectedIndex because our jumpto select box has a data-hide on its first entry, so it can be selected in any way. (script.js)

* Just a detail. (Admin.french.php)
Title: Re: New revs
Post by: Nao on February 9th, 2012, 09:56 AM
rev 1303
(4 files, 2kb)

! Fixed JumpTo function when pretty URLs were disabled. It's also now one byte smaller... I'm mental. Don't go near me. (script.js)

! In some cases, at least on my local install, filesize() will sometimes fail even if file_exists() returns true. Added a @ to suppress the error. (Subs-Cache.php)

- Removed text-overflow from CSS exceptions. From what I could gather on caniuse.com, only older versions of Opera need a prefix, meaning it's a stabilized rule, so let's not waste time on this. I'm not exactly sure why I added it in the first place, so I may have to revert later. (Subs-Cache.php)

! Fixed icon positions in topic moderation bar. (Worg/index.member.css)

* Simplified button list styling. (Worg/sections.css)
Title: Re: New revs
Post by: Nao on February 9th, 2012, 11:11 AM
rev 1304
(12 files -1, 5kb)

* Moved Media area's master setting back to the Media admin settings page. This means that the only Core Feature left is Post Moderation (and the associated feature_pm.png), which Pete will probably remove soon. Also fixed Media menu to always show up -- but only show the main settings page, so that you can re-enable the media area easily. (Admin.php, ManageSettings.php, feature_m.png, ManageSettings.language.php, Media.language.php)

- Removed anything related to welcoming users to the Core Features page... (ManageSettings.php, ManageSettings.language.php, Admin.template.php)

- Removed force_disable_tabs, which is no longer used. I could have used that on the media area when enabling/disabling the master setting, but that would only help to disable extra entries when unneeded, not to restore them when needed. (Admin.template.php, GenericMenu.template.php)

! The orphan menu separator fix wasn't strong enough, it needed to be applied again at the end of the process. (Subs-Menu.php)

* Language tweak. (Admin.french.php)

* Admin layout tweak. (admin.css)
Title: Re: New revs
Post by: Nao on February 9th, 2012, 04:55 PM
rev 1305
(207 files, 231kb)

* The musical chairs commit. $theme (a local variable) becomes $th, while $settings becomes $theme and $modSettings is renamed to $settings. This is because $modSettings never made sense, as it didn't represent "modification settings", but instead Wedge/SMF's general settings. (207 files, not gonna list any. Pretty much all PHP files in Wedge.)

- Removed unused oNewsFader declaration. (Boards.template.php)
Title: Re: New revs
Post by: Nao on February 9th, 2012, 05:53 PM
rev 1306
(6 files, 4kb)

! Select box width and scrollbar position were incorrectly set on complex boxes. I have no idea why, but it was fixed 'simply' by moving the .width() outside of the command chain and into the following line, at a cost of zero byte. I suspect it's an issue with the wrapAll method. (sbox.js)

+ Added a data-self parameter to the thought list, allowing to determine whether Edit/Delete buttons should be shown next to a particular thought. Takes 12 more bytes but I saved another 5 by removing the whitespace on the thought HTML. It's not like I'm going to change it a lot anyway... (script.js)

* Moved the Aeva (auto-embedding) section just below the Smiley and Attachment/Avatar sections, because they're all about 'visual'. (Admin.php)

* Details. (media.css, Worg/index.member.css, Worg/sections.css)
Title: Re: New revs
Post by: Arantor on February 9th, 2012, 07:27 PM
(3 added, 5 deleted, 15 modified, 48KB)

Revision: 1307
Author: arantor
Date: 09 February 2012 18:26:21
Message:
! First draft of the moderation filters code. The UI is hardly done (the show page works, as does the actual rules engine, but that's it). There is - very temporarily, I'll note - a big scary text box without a label in Security and Moderation - Anti Spam. This textbox is simply a textbox pointing at $settings['postmod_rules'] where the actual rules are stored, just so that I have somewhere to view and edit them (and that doesn't involve phpMyAdmin and forcing a cache flush), and once the UI is working, I'll remove this textbox. This change also removes the core features page, the post moderation secondary page and most of the code relating to post moderation configuration, with the exception of the permissions, and anything related to attachment approvals. Mostly this commit is just so that I have it in SVN and can work on the rest reasonably incrementally. (All files in this commit are directly related to these things.)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Added : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Added : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Deleted : /trunk/Themes/default/images/admin/corefeatures.gif
Deleted : /trunk/Themes/default/images/admin/feature_pm.png
Deleted : /trunk/Themes/default/images/admin/post_moderation_allow.gif
Deleted : /trunk/Themes/default/images/admin/post_moderation_deny.gif
Deleted : /trunk/Themes/default/images/admin/post_moderation_moderate.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql


(Yes, Core Features is NOW GONE FROM SVN :D And note that this is still a WIP so things can and will change.)
Title: Re: New revs
Post by: Nao on February 9th, 2012, 08:00 PM
rev 1308
(13 files, 8kb)

* Translators are gonna hate me... While I was in the process of renaming all of  these variables, I decided I wanted to fix Aeva Media as well. Subtext entries were using different suffixes, such as _info, _sub, _subtxt, _subtext and _desc. Renamed them all to _desc, except for _info which isn't always for a subtext anyway. Also replaced all mg_subtext entries with the commonly used (in Wedge) dfn tag. It's important that the admin area looks the same everywhere. Now I just need to remove the alternating color stripes... Arg. Also, various tweaks here and there, nothing worthy of an individual mention though. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, ManageMedia.php, ManageMedia2.php, ManageMedia3.php, ManageMedia.template.php, Media.template.php, Media.language.php, ManageMedia.language.php, media.css)
Title: Re: New revs
Post by: Arantor on February 9th, 2012, 11:19 PM
(5 modified, 2KB)

Revision: 1309
Author: arantor
Date: 09 February 2012 22:19:29
Message:
! Stupid bug from a missed $modSettings change. (Post2.php)
+ Regexp match on body/subject filter is more capable now, instead of just blindly searching for regexp matches, it's possible to separate out (for UI purposes, mostly) whether to match based on start/end/contained-by/full-match, and do that in a case sensitive or insensitive fashion. But full regexp is still available for complex cases. (ManageModeration.php, Subs-Moderation.php, ManageModeration.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on February 9th, 2012, 11:59 PM
rev 1310
(9 files, 7kb)

+ Added the two new hooks to the known hooks list, and removed the old core features hook from it. I wasn't sure about the sections to file them in, so I did my best to make a guess. (ManagePlugins.php)
- Removed a few language entries that were left in. (Admin.language.php, ManageSettings.language.php)
+ French translation. The large block in ManageSettings is totally untested, hopefully I won't forget to actually test the feature, eh? (Admin.french.php, Errors.french.php, ManageSettings.french.php)
* Minor spacinazi and indenazi. (ManageModeration.php, ManagePlugins.php, Subs-Moderation.php, Who.php)

:edit: ManageSettings is missing more French entries, I did the work before rev 1309 was committed, so I guess I'll do it tomorrow, too tired now.
Posted: February 9th, 2012, 11:54 PM

:edit: 2 -- Subs-Membergroups.php:655 has a $GLOBALS on modSettings... Little bugger ;) I'll finish converting the rest of modSettings tomorrow.
Title: Re: New revs
Post by: Nao on February 10th, 2012, 12:01 PM
rev 1311
(1 file +1 -1, 3kb)

! Finally, finally fixed the Opera issues with select box animations. Well, I couldn't let it slip, it's still my favorite browser after all. After hours of debugging, I noticed that all bugs would go away if moving the inline-block declaration from .sbox to .display, which is what I just did. Because I seem to remember having had bugs in other browsers when doing that, I won't tempt the devil, and instead add an index.opera.css file that does the job in two lines. Right? The other good news is that this allows me to remove an Opera hack in sbox.js and save another 5 gzipped bytes. (sbox.js, Worg/index.opera.css)

- Also removed a custom.css file that wasn't supposed to be there. Harmless, but it defeated the whole point of custom.css -- being able to upload yours without fear of a Wedge upgrade replacing it. Please hit me if I forget to remove it again when Worg becomes the top-level skin... Okay? (Worg/custom.css)
Title: Re: New revs
Post by: Nao on February 10th, 2012, 03:51 PM
rev 1312
(3 files +1, 2kb)

+ Restored corefeatures.gif file, under the name settings.gif, because it was used by a couple other menu entries. (Admin.php, admin/settings.gif)

- Removed a couple of remaining CoreFeatures references. (Admin.php, ManageSettings.php)

* French translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Arantor on February 10th, 2012, 05:12 PM
(41 files, 5KB)

Revision: 1313
Author: arantor
Date: 10 February 2012 16:12:13
Message:
! Minor typo in the moderation rules for 'matches' type matches. (Subs-Moderation.php)
! Attachments are no longer moderated on their own, but inherit the approval of the post they're attached to. As Nao says, if you want to have attachment approval, use the gallery. I *think* I got everything relating to attachment approvals and everything seems to work as expected at this point in time. (All the rest of the files in this commit.)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Title: Re: New revs
Post by: Nao on February 10th, 2012, 05:57 PM
rev 1314
(1 file, 4kb)

* Rewrote CSS cache handler to fill an array of elements for the filename, instead of building a string directly. I don't know why I did it that way, what with the regex hacks I had to go through... Hopefully, this should also fix a few bugs. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on February 10th, 2012, 10:13 PM
rev 1315
(2 files, 1kb)

! A couple of last-minute changes to Subs-Cache actually broke it. That's what you get when you commit right before you have to leave... (Subs-Cache.php)

- Removed the final (hopefully?) remaining $modSettings, which was hidden because it's accessed through $GLOBALS. (Subs-Membergroups.php)
Title: Re: New revs
Post by: Nao on February 11th, 2012, 10:36 AM
rev 1316
(18 files, 8kb)

* Replaced the new_icon class (language-specific new.gif) with a 'note' class that will do the same as in main menu notifications. Renamed $txt['menu_new'] to $txt['new_short'] (better contextual name), it may even go away entirely later. (media/Subs-Media.php, Profile-Modify.php, Subs.php, SSI.php, TEMPLATES: Boards, Display, GenericMenu, index, MessageIndex, PersonalMessage, Post, Recent, LANGUAGES: index, SKINS: Worg/index.css, Worg/index.ie9.css, Worg/sections.css)

- Removed remaining calendar references from a file that's likely to never be used at all. That's me. (upgrade.sql)

- Removed remaining attachment approval references. (index.language.php)

+ Added add_thought and edit_thought language strings, because the thought editor is on every single page, and I'd rather have semantically 'correct' entries for it. (index.template.php, index.language.php)

- Removed preview_new language string -- a single 'new' string does the job just as well. (Post.template.php, index.language.php)
Title: Re: New revs
Post by: Nao on February 11th, 2012, 10:55 AM
rev 1317
(-2 folders, 1kb)

- Removed the english and french image folders. Since they're no longer used for now... Doing it as a separate commit to make it easier to revert later. (images/english, images/french)
Title: Re: New revs
Post by: Nao on February 11th, 2012, 11:45 AM
rev 1318
(2 files, 2kb)

* Rewrote CSS prefix handler to be a bit more specific on each rule. Most notably, the previous version didn't correctly set up box shadows on IE9, it should at least fix that. (Subs-Cache.php)

* Detail. (Worg/index.css)


(And yes, it means I gave up on my nicely done little function to interact with every single browser version number. Although I could always publish it in the attic...)
Title: Re: New revs
Post by: Nao on February 11th, 2012, 04:06 PM
rev 1319
(12 files, 3kb)

* Renamed modSettings cache key to settings, $txt['modSettings_title'] and $txt['modSettings_desc'] to 'settings_*', to avoid any possible confusion with the modsettings page (which will eventually go, since it's package-related.) Also removed the 'modSettings_info' text string, which AFAIK is not used anywhere, probably including SMF in. (upgrade.php, Admin.php, Load.php, ManageServer.php, ManageSettings.php, Subs.php, LANGUAGES: Admin, index, ManageSettings)
Title: Re: New revs
Post by: Nao on February 11th, 2012, 10:35 PM
rev 1320
(2 files +1, 10kb)

+ Rewrote CSS prefix handler to add support for: border-image, hyphens, multi-column, flexbox model, grid layout, animation and 2D/3D transforms. That's a lot, but most browsers still don't support most of these features without a prefix at all, so it's mostly for the convenience of not having to add prefixed and non-prefixed versions in your code. (Subs-Cache.php)

* Reverted CSS prefix handler a bit to restore both prefixed and unprefixed versions in case we don't know about current or future support. This is precisely to avoid issues with old cached files in newer browsers in the future -- in case they drop support for their own prefixed versions. Did you get what I mean? No? Don't worry, neither do I. (Subs-Cache.php)

+ Added an alternative version of the CSS prefix rewrite to the attic. It works well and has the advantage of being able to differentiate between browser versions, but Wedge doesn't record versions -- and probably never will, because that'd mean too many cache files. (attic/Unused-dynPrefixed.php)

! Fixed a bug in the CSS cache rewrite where the skin name wouldn't be properly included in the filename. (Subs-Cache.php)

* I gave Chrome a lot of time. Months ago, I noticed that it started behaving incorrectly on CSS3 opacity animations. I've finally decided to add a stylesheet for it to specifically remove these in main menus. Hey, it asked for it! (Worg/index.chrome.css)
Title: Re: New revs
Post by: Arantor on February 12th, 2012, 04:27 AM
(2 files, 1KB)

Revision: 1321
Author: arantor
Date: 12 February 2012 03:26:32
Message:
! Removed ins and del from being supported by the inbuilt 'basic HTML' support. Most people don't realise these tags even exist, let alone use them, and if we end up using them in markup it could get complex otherwise. (Subs-BBC.php)
! Quick reply was actually supposed to be open by default, not shown but closed by default. (install.sql)
----
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on February 12th, 2012, 02:28 PM
rev 1322
(6 files, 3kb)

+ Added support for @import and @charset in CSS files. Well, at least the generated CSS is okay now... (Class-CSS.php)

! Fixed CSS parser sometimes screwing up absolute URLs. (Class-CSS.php)

! Wedge's rewrite of ssi_recentTopics() wouldn't return posts in the correct order. (SSI.php)

! Plus, SMF's conservative use of minimum post IDs in these functions has never worked for me. Removed the min() thingy. (SSI.php)

* Layout details. (Worg/index.css, Worg/index.member.css, Worg/sections.css)

* Micro-optimizations. What's the greek root after micro, already? Pica? (Subs-Cache.php)
Title: Re: New revs
Post by: Arantor on February 12th, 2012, 02:56 PM
(13 modified, missed the size)

Revision: 1323
Author: arantor
Date: 12 February 2012 13:55:09
Message:
! Fixed undefined 'forum_index' on the forum front page. (Welcome.php)

! Tweaked default for quick reply for guests on the forum (install.sql)

! Removed the quick moderation option; it's now checkboxes all the way, baby! (MessageIndex.php, MessageIndex.template.php, Search2.php, Display.template.php, Profile.template.php, Recent.template.php, Search.template.php, Settings.template.php, Profile language file)

! Rewrote boardsAllowedTo to better support situations where you need to make multiple permissions calls in the same context (e.g. as in Search2 where you make 11 permissions calls in one go) (Search2.php, Security.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 12th, 2012, 03:02 PM
(1 file, 1KB)

Revision: 1324
Author: arantor
Date: 12 February 2012 13:58:04
Message:
! Made the quick moderation handler also use the improved boardsAllowedTo code. (QuickMod.php)
----
Modified : /trunk/Sources/QuickMod.php
Title: Re: New revs
Post by: Arantor on February 12th, 2012, 05:19 PM
(5 modified, 3KB)

Revision: 1325
Author: arantor
Date: 12 February 2012 16:19:27
Message:
! Store the user id of who modifies a post when it's modified. (JSModify.php, Post2.php, Subs-Post.php)
! If we have the user id of who modifies a post, link to it. Still need to fix the JS editing response doing this properly, however. (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Arantor on February 12th, 2012, 05:29 PM
(1 file, 1KB)

Revision: 1326
Author: arantor
Date: 12 February 2012 16:29:30
Message:
! Also have quick edit return the appropriate profile link when a post is being edited, so that it is a link, and is formatted correctly. (JSModify.php)
----
Modified : /trunk/Sources/JSModify.php
Title: Re: New revs
Post by: Nao on February 12th, 2012, 09:23 PM
rev 1327
(1 file +1, 14kb -- really, 1kb worth of changes + 6kb for the new file)

! Fixed Reply to Thought button incorrectly hiding the original text. (script.js)

! Fixed Thought system's ajax editing -- was broken by my recent change for ';' separators, when the code really only expects ampersands. (script.js)

+ Added a temp thumbnail for Worg. (Worg/thumbnail.jpg)
Title: Re: New revs
Post by: Nao on February 12th, 2012, 10:33 PM
rev 1328
(3 files -1, 2kb)

! A couple of pages wouldn't correctly update the selected item if canceling a change. (ManageMembergroups.template.php, Profile.template.php)

* As much as it hurts me, reverting my Opera fix for select boxes. It just doesn't work when select boxes are inline, such as the post editor and the thought system. I could have looked and added exceptions for every single inline box, but it's really not realistic. So it's an additional 11 bytes for sbox.js, sorry about that, and for Opera: a slightly less eye-candy opening/closing animation, minor width issues when selecting and a glitch in the last list entry when navigating boxes with the keyboard -- don't ask me why, I have no frigging idea. The rest should be okay, so it's an acceptable alternative. Until someone finds the reason for all these Opera bugs. There are limits to my Opera fanboyism, I guess. (sbox.js, Worg/index.opera.css)
Title: Re: New revs
Post by: Arantor on February 13th, 2012, 01:52 AM
(1 file, 2KB)

Revision: 1329
Author: arantor
Date: 13 February 2012 00:52:07
Message:
! Add the number of reported posts to the admin menu, for the reported posts item, and build a total count for the admin menu as a whole. We can probably remove it from the top of the sidebar at this point, where it is underappreciated, just like it is in SMF themes. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on February 13th, 2012, 02:17 AM
(2 files, 3KB)

Revision: 1330
Author: arantor
Date: 13 February 2012 01:16:46
Message:
! Add the number of unapproved members to the admin menu too (under reported posts) and add that into the count of items too, so that it raises prominence on it and admins can deal with it better. (Subs.php, index language file)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on February 13th, 2012, 11:24 AM
rev 1331
(9 files, 4kb)

* Replaced <div class="note"> with <a class="note">, as context permits, and as suggested by Aaron, who will pay for this, mwahahaha. Updated the note styling to be a bit closer to the original New icon. Requires the use of inline blocks, though. Plus, a couple of spans were used instead of divs to make them validate in the index template. (Profile-Modify.php, SSI.php, Boards.template.php, index.template.php, MessageIndex.template.php, Recent.template.php, index.css)

- Removed moderation report in sidebar, as suggested by Pete. (index.template.php, index.language.php)
Title: Re: New revs
Post by: Arantor on February 13th, 2012, 01:59 PM
(5 modified, 6KB)

Revision: 1332
Author: arantor
Date: 13 February 2012 12:58:38
Message:
! Add ability for 'multi_select' types in the standardised admin panel pages, in a style similar to that of the inline permissions dialogues. (ManageServer.php, Admin.template.php, Admin language file)
! Provide the admin with the ability to choose who receives notifications of new members, rather than everyone who is an admin, and/or global moderator. (ManageRegistration.php, Subs-Post.php)
----
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Title: Re: New revs
Post by: Arantor on February 13th, 2012, 02:43 PM
(2 modified, 5 added, 22KB - of which there's about 6 lines of changes total)

Revision: 1333
Author: arantor
Date: 13 February 2012 13:42:35
Message:
! Fixed misalignment of admin panel items; they're supposed to be vertically aligned consistently (i.e. to top) (admenu.css)
! Some more of the icons for the main ACP, yet more courtesy of Crystal Project (Admin.php, *.png)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Themes/default/images/admin/boards.png
Added : /trunk/Themes/default/images/admin/moderation_filters.png
Added : /trunk/Themes/default/images/admin/poststopics.png
Added : /trunk/Themes/default/images/admin/security.png
Added : /trunk/Themes/default/images/theme/grad40i.png
Modified : /trunk/Themes/default/skins/admenu.css
Title: Re: New revs
Post by: Arantor on February 13th, 2012, 03:07 PM
(1 modified, 4 added, 8KB)

Revision: 1334
Author: arantor
Date: 13 February 2012 14:06:59
Message:
! Everything other than 'Features and Options' now has its own icon, and there's nothing wrong with Features and Options' icon... (Admin.php, *.png)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Themes/default/images/admin/albums.png
Added : /trunk/Themes/default/images/admin/ftpimport.png
Added : /trunk/Themes/default/images/admin/memberoptions.png
Added : /trunk/Themes/default/images/admin/quotas.png
Title: Re: New revs
Post by: Arantor on February 13th, 2012, 03:31 PM
(1 modified, 1KB)

Revision: 1335
Author: arantor
Date: 13 February 2012 14:31:33
Message:
! Fix for stupid bug in Admin template caused by previous changes by me, today, with replacing select behaviour. (Admin.template.php)
----
Modified : /trunk/Themes/default/Admin.template.php
Title: Re: New revs
Post by: Nao on February 13th, 2012, 05:43 PM
rev 1336
(9 files, 3kb)

* Replaced a few select box horizontal rules with the newer data-hide technique. Left a few in, mostly out of laziness or because I'm unsure whether category names should allow for HTML tags. Will also need to look into adding hr's in the middle of long select boxes in the future. (Groups.php, ManageMembers.php, ManageSmileys.php, ManageMaintenance.template.php, ManageScheduledTasks.template.php, MessageIndex.template.php, ModerationCenter.template.php, Profile.template.php)

* The blog template really needs to be modeled closer to the forum template... (MessageIndex.template.php)

* Translation. (Admin.french.php)

@ Don't worry Pete, I'll leave you with famed revision 1337 'cuz I'm lost in my select box bugs right now... I probably already snapped it back in the Aeva Media days anyway, if we ever reached that number :lol:
Title: Re: New revs
Post by: Nao on February 14th, 2012, 12:48 PM
rev leet
(33 files -4, 12kb)

- Removed support for Wap2, i.e. the last remaining user of the Wireless template. The main point is preventing Googlebot Mobile from getting mixed up between its various indexes, but also to encourage the creation of lightweight themes. We'll introduce in the future new variations for smartphones, which are becoming the majority for mobile users. (index.php, features.txt, xml/detailed-version.php, Boards.php, Display.php, Errors.php, FindMember.php, Load.php, Lock.php, Login.php, Login2.php, ManageBans.php, MessageIndex.php, PersonalMessage.php, Pin.php, Post.php, Profile.php, Security.php, Subs-BBC.php, Subs-Editor.php, Subs-Menu.php, Subs-Template.php, Subs.php, Unread.php, UnreadReplies.php, SSI.php, GenericControls.template.php, index.template.php, Wireless.template.php, Errors.language.php, index.language.php, Wireless.language.php, index.css, wireless.css)

@ Need to remove FindMember code! It's only used in the media area by now... (it was for compatibility with SMF1 etc.)
Title: Re: New revs
Post by: Nao on February 14th, 2012, 05:57 PM
rev 1338
(3 files, 1kb) -- more coming later...

! Fixed validation error in button list code. Also, just noticed that the regular W3 validation tool is now accepting microdata again... Ah well, I'm leaving the link at validator.nu for now. (index.template.php)

* Translation tweaks. (Media.language.php)
Title: Re: New revs
Post by: Nao on February 14th, 2012, 11:47 PM
rev 1339
(12 files -1, 17kb)

* Rewrote, once again, a large portion of the auto-suggest component. It's a bit tighter, cleaner, accepts shorter parameters (especially in the aListItems area...), and basically, it works, unlike the previous version. (ManageBans.template.php, ManageBoards.template.php, ManageMembergroups.template.php, ManageNews.template.php, Media.template.php, PersonalMessage.template.php, pm.js, suggest.js, Worg/index.css)

* Because I'm weak and I listen to outside suggestions, I used the opportunity to restyle the auto-suggest to look like the select box dropdowns. I sure could have hoped for a smaller CSS code block though... (Worg/index.css)

* Media area's Search by Member and Allowed/Denied Read/Write lists of album users now use the auto-suggest component. The Search feature is totally untested. Any volunteers? (Aeva-Gallery2.php)

* Reworked Media search page layout a tiny bit.  Fixed subtabs but, honestly... These should go, shouldn't they?! Or at least use the proper contextmenu styling... @todo! (Media.template.php)

- Removed FindMember component (the ancestor to the auto-suggest). Finally got around to updating the last area that made use of it -- the media album creation page. (index.php, FindMember.php, Load.php, Aeva-Gallery2.php)

Please everyone test the areas where I made the most prominent changes! Media search, media album per-member permissions... I worked for 5-6 hours on this and am too upset to finish testing.
Title: Re: New revs
Post by: Arantor on February 14th, 2012, 11:54 PM
(15 modified, 25KB)

Revision: 1340
Author: arantor
Date: 14 February 2012 22:53:02
Message:
! Moved 'show quick login' to Reg/Login settings, because it's not really a theme setting any more. (install.sql, Load.php, ManageRegistration.php, Settings.template.php, Help + ManageSettings + Themes language files)

! Stupid bug with unapproved members in the menu area. (Subs.php)

! Partial commit of the add-rule interface for the moderation filters. You can go through the motions of adding rules - but only for groups and boards right now (and I'm not very happy with how the boards one looks), but the actual save button doesn't work at present. More will be added, I just wanted to get this committed at a convenient stopping place before my brain gave out. The code is not pretty, could almost certainly be reworked and improved, but this is mostly a first draft more to test the UI structure and design rather than being perfect code. (ManageModeration.php, ManageModeration.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql


@ This isn't particularly battle tested either, mostly because it's still so unfinished. But it took me all day to get to this point where I'm reasonably happy with it. Will look at testing all the things that have been changed in the last few commits, just not right now, because I'm a bit tired from doing this stuff, maybe tomorrow.
Title: Re: New revs
Post by: Nao on February 15th, 2012, 12:48 PM
rev 1341
(3 files, 9kb)

* Tweaked auto-suggest to show item lists inline instead of one per line. Added some padding to their right to ensure the Delete button's target is clear. (suggest.js)

* Translation. (ManageMedia.english.php, ManageSettings.french.php)

:edit: If you happen to look through my code and wonder about something (which I doubt, ah, ah.) Although undocumented, jQuery does support setting .html() to an array of jQuery elements, or whatever. It just tests whether it's a string, and if not, it does empty() and then append().
Title: Re: New revs
Post by: Arantor on February 15th, 2012, 03:18 PM
(2 files, 2KB)

Revision: 1342
Author: arantor
Date: 15 February 2012 14:18:12
Message:
! Post count is now part of the UI for moderation filters (still as before, the backend handler doesn't exist yet) but it's another on the list of things that are implemented. (ManageModeration.template.php, ManageSettings language file)
----
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on February 15th, 2012, 05:29 PM
rev 1343
(2 files, 2kb)

* Tweaked Manage Moderation template's JavaScript, CSS and HTML for efficiency. (ManageModeration.template.php, Worg/index.css)

* Replaced lefttext/righttext/centertext classes with left/right/center, to eliminate repetitive patterns. Use floatleft/etc if you need to center the container, rather than the contents. Also, quotes had too much padding around them, switching to pixel values instead. (Worg/index.css)
Title: Re: New revs
Post by: Nao on February 15th, 2012, 06:08 PM
rev 1344
(28 files, 5kb)

* Added a 'centered' class that will center a div horizontally. Obviously, it has to have a set width, otherwise it'll use up all of the space. Started renaming all text alignment classes. Hopefully I didn't break the left/right/center BBC tags in the process. Logic says I didn't. (install.php, install.sql, upgrade.sql, upgrade.php, 7 tools, Aeva-Embed.php, Aeva-Foxy.php, Subs-Media.php, Modlog.php, Profile-Modify.php, TEMPLATES: Admin, Display, Help, Login, ManageBans, ManageBoards, Notify, PersonalMessage, Profile, Register, Reminder)

+ Forgot to submit my bindEvents change. It will now accept a limited subset of DOM elements. (script.js)

* Translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on February 15th, 2012, 06:45 PM
rev 1345
(39 files, 6kb)

* Finished text alignment conversions. (ManageMemberOptions.php, ManageServer.php, ManageSettings.php, ManageSettings.language.php, TEMPLATES: Admin, Errors, ManageBoards, ManageMembergroups, ManageMembers, ManageModeration, ManageNews, ManagePaid, ManagePermissions, ManagePlugins, ManageScheduledTasks, Media, ModerationCenter, MoveTopic, Packages, PersonalMessage, Poll, Post, Printpage, Profile, Recent, Register, Reports, SendTopic, SplitTopics, Stats, Themes, SKINS: index.css, index.member.css, index.rtl.css, sections.css, Worg/index.member.css, Worg/sections.css, Wuthering/index.rtl.css)

* Slightly better presentation for Unread Posts/Replies page, when no posts are found. (Recent.template.php)

! Fixed unclosed div in the admin homepage. (Admin.template.php)
Title: Re: New revs
Post by: Nao on February 15th, 2012, 10:38 PM
rev 1346
(2 files, 1kb)

! The menu links for sendpm and banuser in profile pages were broken. (Profile.php)

* Translation update. (ManageMedia.french.php)
Title: Re: New revs
Post by: Arantor on February 16th, 2012, 10:33 AM
(2 files, 2KB)

Revision: 1347
Author: arantor
Date: 16 February 2012 09:32:38
Message:
! Warning level is now also in the moderation filters UI. (ManageModeration.template.php, ManageSettings.english.php)
----
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on February 16th, 2012, 11:16 AM
rev 1348
(10 files, 3kb)

+ Adding database tables for contact lists. That's all there is to it now... It's mostly there to discuss the required fields etc. (install.sql)

* Renamed some remaining 'buddies' to 'contacts', as well as the French equivalent 'amis'. Other translation tweaks. (index.language.php, ManagePermissions.french.php, ManageSettings.french.php, PersonalMessage.french.php, Profile.language.php, Reports.french.php, Who.french.php)
Title: Re: New revs
Post by: Arantor on February 16th, 2012, 11:46 AM
(2 files, 3KB)

Revision: 1349
Author: arantor
Date: 16 February 2012 10:45:56
Message:
! Moderation filters UI now also supports subject and body tag, though it doesn't know how to differentiate case sensitivity. I do believe it's properly protecting content before inserting into the DOM (and I know somewhere between Chrome and jQuery being "helpful" I got very annoyed with it, heh) (ManageModeration.template.php, ManageSettings.english.php)
----
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on February 16th, 2012, 11:59 AM
(2 files, 2KB)

Revision: 1350
Author: arantor
Date: 16 February 2012 10:59:30
Message:
! Add case-sensitive test to subject/body area in moderation filters UI. (ManageModeration.template.php, ManageSettings.english.php)
----
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on February 16th, 2012, 04:10 PM
(3 files, missed the KB size, sorry)

Revision: 1351
Author: arantor
Date: 16 February 2012 15:10:05
Message:
! First version of moderation filters UI able to actually save moderation rules. It cannot yet save any types other than the ones shown in the UI, but it seems to be able to save things well enough. The handlers for body/subject are going to need serious testing however, to make sure that things are properly escaped/unescaped if necessary, this hasn't even been tested yet so it's likely broken, but that's a minor enough matter right now! (ManageModeration.php, ManageModeration.template.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Nao on February 16th, 2012, 06:22 PM
Another quiet day on the forums... Eh?

rev 1352
(18 files, 11kb)

- Got rid of all #admincenter declarations. Use #admin instead, and #admin #main if you want to target the main content area. Also, indenazi here and there. (TEMPLATES: Admin, ManageMembergroups/Members/News/Paid/Permissions/ScheduledTasks/Search/Smileys, Packages, Register, Reports, Themes, SKINS: admin.css, admin.rtl.css, index.ie6.css, Worg/index.ie6.css)

* Doing a westr::safe, to be on the... safe side. (ManageSmileys.template.php)

* Translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on February 16th, 2012, 07:10 PM
rev 1353
(5 files, 3kb)

* Tweaked Subscription pages, for better layout mostly, as well as a miserable hack to avoid things like "Duration: 1 Years". Really should use our own numeric formatting function, but I can't bother to redo the text strings. (ManagePaid.php, ManagePaid.template.php, ManagePaid.french.php, sections.css)

* Indenazi. (GenericMenu.template.php)
Title: Re: New revs
Post by: Arantor on February 17th, 2012, 12:03 AM
(3 files, 10KB)

Revision: 1354
Author: arantor
Date: 16 February 2012 23:02:31
Message:
! Moderation UI now supports editing, though it's not quite finished yet. Specifically, it takes the existing rule, lets you shape it and resaves it as a new rule because I haven't quite got replace/delete working just yet, at least not without adding another dependency (the DOM library) but in the meantime the bulk of the editing UI is basically done for now. (ManageModeration.php, ManageModeration.template.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


@ This is the reason things have been slow today, getting this PITA down straight between the saving and editing stuff...
Title: Re: New revs
Post by: Arantor on February 17th, 2012, 10:37 AM
(4 files, 6KB)

Revision: 1355
Author: arantor
Date: 17 February 2012 09:35:56
Message:
! Moderation filters UI can now properly update (well, delete an existing one and append a new rule on the end, but has no net difference in reality) and delete entries, as well as cleaning up empty nodes before updating. Also removed the extra UI in Security and Moderation now it has no meaningful purpose. (ManageSettings.php, ManageModeration.php, ManageModeration.template.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


NB The UI is still not finished, not all types that can be handled through the system are actually in the interface, as user id and groups is still required to be implemented, but everything else is implemented and, so far, working.
Title: Re: New revs
Post by: Arantor on February 17th, 2012, 12:17 PM
(6 modified, 5KB)

Revision: 1356
Author: arantor
Date: 17 February 2012 11:17:11
Message:
! Typo fix in the credits (Who.english.php)

! Bug fixes from the generic list template (invalid markup under certain circumstances, not always validating existence of list) (GenericList.template.php)

! Rejigging the list of version numbers in Detailed Version Check (to move stuff there from Media/About) (ManageMaintenance.php, Subs-Admin.php, Admin.template.php, Admin.english.php)
----
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Who.english.php
Title: Re: New revs
Post by: Arantor on February 17th, 2012, 02:00 PM
(-2, +2, 3KB)

Revision: 1357
Author: arantor
Date: 17 February 2012 12:59:54
Message:
! Moving the SMF and AeMe changelogs to the attic. I'll fix the relevant AeMe code shortly. (all files)
----
Deleted : /trunk/Themes/default/aeva/changelog.txt
Deleted : /trunk/changelog.txt
Added : /trunk/other/attic/aeme_changelog.txt (Copy from path: /trunk/Themes/default/aeva/changelog.txt, Revision, 1354)
Added : /trunk/other/attic/smf_changelog.txt (Copy from path: /trunk/changelog.txt, Revision, 1354)
Title: Re: New revs
Post by: Arantor on February 17th, 2012, 02:11 PM
(2 added, 1 removed, 6 modified, 6KB)

Revision: 1358
Author: arantor
Date: 17 February 2012 13:10:51
Message:
! Moved the AeMe readme to the attic as well as the code that formats the changelog, and removed the readme/changelog from the relevant menus and areas. (all files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Deleted : /trunk/Themes/default/aeva/readme.txt
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Added : /trunk/other/attic/aeme_changelog_handler.php
Added : /trunk/other/attic/aeme_readme.txt (Copy from path: /trunk/Themes/default/aeva/readme.txt, Revision, 1354)
Title: Re: New revs
Post by: Arantor on February 17th, 2012, 03:21 PM
(11 modified, 7KB)

Revision: 1359
Author: arantor
Date: 17 February 2012 14:20:50
Message:
! Removal of almost all of the Aeva About page, leaving just the moderators and managers bit for now. So, a few credits got added to the credits page, a few tests got added to the version information page, and some stuff got pruned afterwards. (all files)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.french.php
Modified : /trunk/Themes/default/languages/Media.english.php
Modified : /trunk/Themes/default/languages/Media.french.php
Modified : /trunk/Themes/default/languages/Who.english.php


@ Observed in passing, media moderation area doesn't set a page title, and doesn't seem to be related to these edits.
Title: Re: New revs
Post by: Nao on February 17th, 2012, 05:32 PM
rev 1360
(7 files +1-9, 7kb)

* Created an 'unused' folder in the other/images folder, and moved some pics there, including the changelog bullets from AeMe. (other/images/*, images/aeva/bullet_*.png)

+ Added a link to php.net's Safe Mode page, just in case admins aren't aware of what it is. (Admin.language.php)

* Translation. I hope I didn't forget anything... (Admin.french.php, ManageSettings.french.php, Who.french.php)

! #admin #main trumps all other CSS styles, so I had to override the hr margin for inner menus. (admin.css)

- Removed changelog bullets. (media.css)
Title: Re: New revs
Post by: Nao on February 18th, 2012, 05:50 PM
rev 1361
(4 files, 4kb)

+ In topic pages, profile icons will now have a low opacity setting, with an animation to reset it on hover. It should make the icons less intrusive, whatever we decide to do with them. (Worg/sections.css)

* Rewrote a bit of the Change Skin page to show a fieldset-based layout[1], instead of regular headers. This should give a bit more space for long lists of skins. (Themes.template.php, Worg/index.css, Worg/sections.css)

* A few extra styling tweaks. (Worg/index.css)

! Debug info sometimes generates a minor error if called for guests. Yeah, I know, no one would normally enable debug info for guests. (ViewQuery.php)
 1. Yes, I know, it's NOT our default fieldset styling... That's because our fieldsets are not made for inclusion within a windowbg or windowbg2 item -- bummer.
Title: Re: New revs
Post by: Nao on February 18th, 2012, 10:23 PM
rev 1362
(all Skins files, 64kb)

* Moved Wine skin down a level (and Warm and Wuthering with it), and moved Worg up a level to replace it as the default skin. Hopefully I didn't screw it up too much[1]... Worg now has the codename 'Weaving'. Started work on adapting Wine to use Weaving's additions. (skins/*)
 1. Actually I moved Wine to its own folder, and then manually moved some of its files back to the root, while I should have SVN Moved them. Should be okay though.
Title: Re: New revs
Post by: Nao on February 18th, 2012, 11:46 PM
rev 1363
(6 files, 8kb)

! Fixed Wine & co to behave just like Weaving (new auto-suggest styling, new New notifications, etc), added a couple of files I forgot, and fixed a few errors in Weaving as well. (index.css, sections.css, Wine/.htaccess, Wine/index.css, Wine/index.php, Wine/sections.css)
Title: Re: New revs
Post by: Nao on February 19th, 2012, 01:29 PM
rev 1364
(7 files +1, 2kb)

* More fixes and tweaks to Weaving and Wine. Getting tricky eh? (skins/*, skin/Wine/*)
Title: Re: New revs
Post by: Nao on February 19th, 2012, 07:51 PM
rev 1365
(3 files, 6kb)

+ Added a new keyword for WeCSS. 'reset' will take the current select and remove it from earlier styles. It's different from '@remove' and 'unextends', and should be very helpful for inherited skins. This was a complicated implementation, too, one which could possibly be rewritten in a cleaner way if I parsed this before even building the CSS tree... I don't know what's best. Opinions?[1] (Class-CSS.php)

+ Added an unset_recursive function to quickly delete CSS selectors and their children. (Class-CSS.php)

* Made CSS tree parsing about 5 to 10% faster. (Class-CSS.php)

! Tahoma is not always installed on Linux. (index.css, Wine/index.css)
 1. Seriously, this is a feature I wanted to have from day one! Took me a whole day to get it right...
Title: Re: New revs
Post by: Nao on February 20th, 2012, 12:23 AM
rev 1366
(1 file, 1kb)

! Was a little too nice with Firefox and Safari... Firefox 12 still requires a prefix for box-sizing rules, and Safari did it until v5.0 (and iOS 4.3), which sort of warrants a de facto prefix for now. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on February 20th, 2012, 11:49 AM
rev 1367
(4 files, 3kb)

* Moved thought list-related styles back to members-only CSS. I'm not sure I remember why I canceled that in the first place... (index.css, index.member.css, Wine/index.css, Wine/index.member.css)

* Thought buttons should no longer get in the way of those who will recognize themselves ;p (index.member.css, Wine/index.member.css)

* Started doing some CSS resets. Eventually, Wine will be an inherited skin again. It's already the case on my local install. (Wine/index.css)
Title: Re: New revs
Post by: Nao on February 20th, 2012, 02:55 PM
rev 1368
(2 files, 2kb)

* WeCSS will now simply remove unsupported properties from old IE versions, because we can't expect them to add support for them in the future, so it's a waste of bandwidth... (Subs-Cache.php)

! Wedge wasn't correctly setting up attachment transparency, as I forgot to specify the path and filename. Oops. (Load.php)

:edit: A PHP+GD2 limitation is that due to lack of support for animated GIFs, these will always be treated as opaque. It's unfortunate, because Pete's avatar gets drop shadows around it. :(
Title: Re: New revs
Post by: Nao on February 20th, 2012, 05:35 PM
rev 1369
(4 files, 3kb)

! Sidebar positioning flag was incorrectly retrieved from the skin file by Wedge. (Subs-Cache.php)

! Forgot to commit a file for rev 1368's transparency fix. (Subs-Media.php)

* Made WeCSS's reset keyword a bit more productive by allowing it on selectors within a nested tree. (Class-CSS.php)

* Don't display the prev/next link container if it's empty to begin with. (Display.template.php)
Title: Re: New revs
Post by: Nao on February 20th, 2012, 05:38 PM
rev 1370
(10 files -2, 9kb)

* Converted Wine to a child skin of Weaving. Oh my, was harder than I hoped... Also tweaked the search box color in Wine, and fixed a few issues in both Weaving and Wine, such as user boxes being incorrectly positioned. (index.css, index.member.css, Wine/*)

! Changed thought list buttons to use absolute positioning instead of floating. This ensures that thought cells no longer get resized on the fly. (index.member.css)
Title: Re: New revs
Post by: Nao on February 20th, 2012, 05:55 PM
rev 1371
(2 files, 1kb)

* Cached CSS should give at least some breathing space to the copyright lines, they're supposed to be readable... (Subs-Cache.php)

! Fixed some minor glitches in auto-suggest object when suggestion list is empty and CSS adds some styling around a list, however empty it may be. (suggest.js)
Title: Re: New revs
Post by: Nao on February 21st, 2012, 06:27 PM
rev 1372
(6 files, 3kb)

* Now vertically centering the thought action buttons. Yay. (index.member.css)

! Fixed whatever glitch I could find remaining in Warm and Wuthering. I'm not exactly sure why I was using an !important on .catbase, hopefully it really was no longer needed. (index.css, Warm/index.css)

! Minor tidbits, like the Wedge select box no longer requiring non-breakable spaces on long lists to avoid hiding their right side. (Themes.php, ManageMedia.template.php, Profile.template.php)
Title: Re: New revs
Post by: Arantor on February 22nd, 2012, 02:04 AM
(2 files, 2KB)

Revision: 1373
Author: arantor
Date: 22 February 2012 01:03:33
Message:
! Board and topic access was entirely broken, due to incorrect testing on the privacy rules where a board has an owner (if a board had no owner, no checking was done for guests - and no boards have owners by default). Phased out the old $board_info['groups'] variable, and updated a function to accept the newer board permissions setup (sans board owner rules for now). ManageBoards still needs updating to work with the newer allow/deny stuff. (Announce.php, Load.php)
----
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Arantor on February 22nd, 2012, 02:19 AM
(1 file, 1KB)

Revision: 1374
Author: arantor
Date: 22 February 2012 01:19:01
Message:
! Forgot to remove some debugging code from Load.php (Load.php)
----
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Nao on February 22nd, 2012, 04:32 PM
rev 1375
(4 files, 11kb)

+ Started implementing this dreaded feature of mine -- topic privacy. Please note that (1) query_see_topic is not set in stone yet. For instance, it doesn't make use of mod_cache (yet), for better or for worse. Also, (2) database structure is still being discussed. I'm just taking the longer way until we decide whether we simplify it or not. (install.sql, Display.php, Load.php)
* Updated thought privacy feature to use the same terminology as topic privacy. (install.sql)
* Implemented the no_prevnext variable that's used to determine whether to show the previous/next topic box. (Display.php)
! ssi_topPoster() needed a $settings global. (SSI.php)
Title: Re: New revs
Post by: Nao on February 23rd, 2012, 09:54 AM
rev 1376
(7 files, 3kb)

+ Added support for mod_cache in query_see_topic, to be able to view topics from SSI or other non-board/non-topic-specific places. Hopefully it'll work. (Load.php)

- Removed $user_info['can_mod'], never used much. Replaced it with allowedTo('issue_warning') or allowedTo('access_mod_center') depending on what was required of it. (Display.php, Load.php, PersonalMessage.php, Security.php, Subs-Auth.php, Subs.php)

* This bq test for 0=1 is never executed, because it's caught a few lines before. (ModerationCenter.php)
Title: Re: New revs
Post by: Nao on February 23rd, 2012, 11:38 AM
rev 1377
(16 files, 7kb)

+ The totally untested, yet probably flawless query_see_topic commit[1]. Every single topic approval test is now replaced. (Feed.php, MessageIndex.php, Profile-Modify.php, Profile-View.php, Search.php, Search2.php, Stats.php, Unread.php, UnreadReplies.php, Who.php)

! SMF 'bug': setting an is_approved to 0 is totally wrong semantically in ManageMaintenance and SplitTopics. Renamed variable to is_unapproved. Also renamed a few other variables which, although semantic, didn't fit the is_approved/approved_state grammar. (ManageMaintenance.php, Aeva-Gallery2.php, Subs-Media.php, SplitTopics.php, Subs-Post.php)
 1. And yes, it means that technically, the feature is supposedly implemented. Surprisingly it's a lot less entries than I thought it'd require... Unless it means that SMF's approval state is unsafe :P
Title: Re: New revs
Post by: Nao on February 23rd, 2012, 11:56 AM
rev 1378
(7 files, 3kb)

! updateLastMessages() should be accepting only a default privacy state for topics that will definitely be shown to everyone... (Subs-Post.php)

- Removed setupTopicPrivacy() function and integrated into loadUserSettings -- I hadn't noticed it was always called in SSI.php anyway. (Load.php, SSI.php)

* More semantic approved states and other minor fixes. (Load.php, ManageModeration.php, MoveTopic.php, Subs-Post.php)

! Fixed Search page's search icon not showing up in Wine. (Wine/index.css)
Title: Re: New revs
Post by: Arantor on February 23rd, 2012, 01:47 PM
(7 files, 5KB)

Revision: 1379
Author: arantor
Date: 23 February 2012 12:46:21
Message:
! Subscriptions should be able to be configured for lifetime access. It's a surprising amount of work but I think I got everything straightened out, needs more testing of course. (ManagePaid.php, Profile-Actions.php, ScheduledTasks.php, subscriptions.php, Subscriptions-PayPal.php, ManagePaid.template.php, ManagePaid language file)

! slideToggle() doesn't work the same as toggle(), can't use it to set the final state. (ManagePaid.template.php)

! Encoding fix (just ManagePaid.english.php - French file is fine)
----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Nao on February 23rd, 2012, 06:40 PM
rev 1380
(2 files, 1kb)

* Just recording privacy and tags fields for template/later use... (Display.php)

! SMF bug: loadBoard should now properly send back an error if you're trying to directly access an unapproved topic that you can't read. (Load.php)

- $context['user']['is_mod'] is set as an alias twice, without any reason. Actually three times, but the third time I'm not sure is useless. (Load.php)
Title: Re: New revs
Post by: Nao on February 23rd, 2012, 06:43 PM
(Forgot a few files...)

rev 1381
(5 files, 2kb)

* Because I'm a maniac, and JavaScript can't be faster than CSS to hide something... Adding 'hide' classes to the various elements in the moderation filter wizard. (ManageModeration.template.php)

* Translation and typo fixes. (ManagePaid.french.php, ManageSettings.french.php)

! Fixed thought form buttons in IE7 and IE8. Can't make it work in IE6 for now. Screw it. (index.ie7.css, index.ie8.css)
Title: Re: New revs
Post by: Nao on February 24th, 2012, 05:21 PM
rev 1382
(7 files, 8kb)

* Moved sidebar to the right in Wuthering. It basically shows that if you don't reproduce the custom macros from its parents, an inherited skin will use the default macros (and skeleton, and code overrides). It may be argued that they should inherit them silently just like CSS files, but right now I'm not sure about that. (Wuthering/index.css)

* Which brings me to... Warm explicitly requiring the sidebar macro rewrite from its parent (Wine). (Warm/skin.xml)

* And, while I'm at it, Weaving wasn't using the proper skeleton settings, with the sidebar block being incorrectly positioned in the HTML. I'm not even sure why it worked... Everybody keep this quiet all right? (index.template.php, skin.xml)

* Button bevel is now a 300x42 PNG instead of 200x42, as I found at least one oversized button (Moderation Filters page, French version) that was over 200px in width. It adds about 6 or 7 bytes to the final gzipped file. Can live with that for now... (images/theme/bevel.png)

* Indenazi. (Admin.template.php)
Title: Re: New revs
Post by: Nao on February 25th, 2012, 06:13 PM
rev 1383
(1 file, 1kb)

+ Added support for a new WeCSS command, @replace. It acts pretty much the same way as @remove, except that it requires a third line for a replacement string, and it can accept partial strings such as url($images/something.png) (if you want to replace it with an image of your own), instead of a full line to remove. Tested on a few strings, works perfectly. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on February 26th, 2012, 01:26 PM
rev 1384
(5 files +1, 4kb)

* Moved thought.png to the image attic, and replaced it with a much smaller thought.gif. I challenge anyone to spot the difference at first sight. (thought.png, thought.gif, index.member.css)

+ Added query_see_topic to Feed, SendTopic and SplitTopics. (Feed.php, SendTopic.php, SendTopic.php -- didn't I just say that?)

! The CSS parser incorrectly added an extra slash to $root paths. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on February 26th, 2012, 01:40 PM
rev 1385
(3 files, 1kb)

* Replaced the one @remove with @replace in Warm, and moved it to the end, to make it more prominent as a simple example of CSS replacements. Did the same for Wuthering, and also moved the one remaining @remove to the end. (Warm/index.css, Wuthering/index.css)

* Turning that h6 header into my current font of choice -- if only to keep the number of different fonts used to a minimum. The fallback is still acceptable, although I had to settle for less weight. (index.css)
Title: Re: New revs
Post by: Arantor on February 26th, 2012, 03:30 PM
(7 files, 5KB)

Revision: 1386
Author: arantor
Date: 26 February 2012 14:30:13
Message:
! Fix undefined variable $uid in query_see_topic that was causing it to break for non admins. (Load.php)

! Allow admins to set a number of posts before signatures become visible - users under the post count can still view and edit it but it won't be displayed normally unless they're an admin (primary group only for performance) or they have enough posts, it will show in their profile if it's their profile or you're looking at someone else's profile and you have permission to edit their signature. It sounds more complex than it really is. (Load.php, ManageMemberOptions.php, Profile-Modify.php, Profile.template.php, Help/ManageSettings/Profile language files)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Title: Re: New revs
Post by: Arantor on February 26th, 2012, 05:44 PM
(9 modified, 8KB)

Revision: 1387
Author: arantor
Date: 26 February 2012 16:44:26
Message:
+ Personal messages settings are now in their own page, under Members. I haven't yet pulled everything in, but the most important stuff is there - and it should also disable PMs throughout the system otherwise. It also doesn't clean up things like profile settings, or disabling them through the main permissions area, but we'll get there. (index.php, install.sql, Admin.php, Load.php, ManageSettings.php, Subs.php, Welcome.template.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Welcome.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 26th, 2012, 05:50 PM
(2 added, 12KB - only because of the way it encodes binary content)

Revision: 1388
Author: arantor
Date: 26 February 2012 16:49:43
Message:
+ The missing images from the new personal messages page that I forgot to commit, oops. (personal_messages_off.png, personal_messages_on.png)
----
Added : /trunk/Themes/default/images/admin/personal_messages_off.png
Added : /trunk/Themes/default/images/admin/personal_messages_on.png
Title: Re: New revs
Post by: Arantor on February 26th, 2012, 06:04 PM
(3 modified, 2KB)

Revision: 1389
Author: arantor
Date: 26 February 2012 17:04:22
Message:
+ PM permissions should be hidden from the main permissions screen when PMs are disabled (ManagePermissions.php)

+ PM page now has the draft saving options+permissions in it. (ManageSettings.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on February 26th, 2012, 08:02 PM
(10 modified, 3KB)

Revision: 1390
Author: arantor
Date: 26 February 2012 19:02:05
Message:
! Newsfader is no longer configured from Current Theme but in the News and Newsletters section of the ACP. (install.sql, ManageNews.php, Boards.template.php, Settings.template.php, Admin+ManageSettings+Themes language files)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 27th, 2012, 02:55 AM
(7 modified, 20KB)

Revision: 1391
Author: arantor
Date: 27 February 2012 01:55:01
Message:
! Board access UI now works as expected, also fixed issue with respect to needing a disallow option (for cases where you wanted to allow one thing but disallow it without denying it) (install.sql, Load.php, ManageBoards.php, ManageBoards.template.php, Help and ManageBoards language files)

@ There is still stuff in the board loader that references board privacy but it's using the old groups structure. Not sure if we're supposed to be using that or not.
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on February 27th, 2012, 03:00 AM
(2 files, 1KB)

Revision: 1392
Author: arantor
Date: 27 February 2012 02:00:25
Message:
! Actually use a help string I'd written up, as well as format it a touch better. (ManageBoards.template.php, Help language file)
----
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Title: Re: New revs
Post by: Arantor on February 27th, 2012, 02:11 PM
(1 file, 1KB)

Revision: 1393
Author: arantor
Date: 27 February 2012 13:11:10
Message:
! CAPTCHA can occasionally fail with a fatal error. (Subs-Captcha.php)
----
Modified : /trunk/Sources/Subs-Captcha.php
Title: Re: New revs
Post by: Nao on February 27th, 2012, 03:13 PM
rev 1394
(2 files, 2kb)

* Added a fixed class to the profile page's gender select box. I think Pete wanted that ;) It required adding support for custom classes in the source file, so I did that. (Profile-Modify.php, Profile.template.php)
Title: Re: New revs
Post by: Nao on February 27th, 2012, 03:18 PM
rev 1395
(6 files, 4kb)

! Moved thought list styling to the member page (mainly because it's all about the action buttons, which don't work for guests), fixed thought list to show properly in Firefox (which behaves differently when it comes to positioning a table cell), and fixed opacity transitions everywhere (only Opera would work. Opera rocks. Like Phantom of the Paradise.) (index.css, index.firefox.css, index.ie6/7/8.css, index.member.css)

* Reordered some of the CSS to prevent having to use an !important hint at some point. The main drawback is that graphics may be loaded a bit later, but if it's gzipped, it's pretty much the same. (index.css)

! The category/header font wasn't supported by Firefox 10+. I love it when browsers decide to break websites overnight. (index.css)

! Fixed Save icon showing behind text in thought buttons under IE6. (index.ie6.css)
Title: Re: New revs
Post by: Arantor on February 27th, 2012, 03:45 PM
(3 files, 4KB)

Revision: 1396
Author: arantor
Date: 27 February 2012 14:45:00
Message:
+ Provide better support in the internal admin system for HTML5 types, such as a dedicated email field and being able to set min/max/step on numeric fields. Some of the fields, sadly, can't directly use the facilities for validation that are now present because they do implosion-of-multiple-items to a single text field. (ManageServer.php, ManageSettings.php, Admin.template.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Title: Re: New revs
Post by: Arantor on February 27th, 2012, 06:32 PM
(5 files, 21KB)

Revision: 1397
Author: arantor
Date: 27 February 2012 17:31:53
Message:
! Plugins now support the ability to specify a simple one-page options area directly from their plugin-info file, without the need to mess with hooks. This one-page admin area is also automatically added to the search subsystem and as such will turn up in searching the admin panel. (plugin-info.rng, Admin.php, ManagePlugins.php, ManageSettings.php)
! Pruning old code. (ManageBoards.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on February 28th, 2012, 12:02 AM
rev 1398
(6 files, 6kb)

! Fixed a logic error when PMs are disabled[1]. (Load.php)

- Comment typo and removing extra unneeded echo's. (ManageBoards.template.php)

* Translation. Hmm, is it me or $helptxt['need_deny_perm'] says something twice differently...? Well, maybe it's needed, for some people the feature may not make sense. ;) (Admin.french.php, Help.french.php, ManageBoards.french.php, ManageSettings.french.php)
 1. I think you forgot to commit that fix..?
Title: Re: New revs
Post by: Nao on February 28th, 2012, 12:27 AM
rev 1399
(2 files, 1kb)

* Forgot a translated file. (Profile.french.php)

* Updated Weaving to use a Segoe UI Light/Optima font stack instead of Bebas Neue, which requires font embedding. (index.css)
Title: Re: New revs
Post by: Arantor on February 28th, 2012, 10:45 PM
(2 modified, 1KB)

Revision: 1400
Author: arantor
Date: 28 February 2012 21:44:56
Message:
! Fixed bug whereby int fields' min/max values were not handled properly for settings-page items in plugins. (ManageSettings.php)
! Added ability to indicate an hr in settings-page items with new XML item hr. (ManageSettings.php, plugin-info.rng)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on February 28th, 2012, 11:30 PM
(7 modified, 2KB)

Revision: 1401
Author: arantor
Date: 28 February 2012 22:29:51
Message:
! Goodbye "modification settings" page, you're just not needed any more. (Admin.php, ManagePlugins.php, ManageSettings.php, Admin and ManageSettings language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 12:49 AM
(2 modified, 1KB)

Revision: 1402
Author: arantor
Date: 28 February 2012 23:47:49
Message:
! A hook's name was typo'd in the hook registry. (ManagePlugins.php)
! Adding a new column in the installer SQL ready for future use (to make migrating certain sites a little bit easier in time) (install.sql)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/other/install.sql

@ Specifically, this is something to save wedge.org hassle since it's one less schema change to worry about going forward (because it's a feature I will be adding shortly and it makes it easier to keep wedge.org updated if there's fewer DB changes to remember to sync)
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 01:09 AM
(3 modified, 3KB)

Revision: 1403
Author: arantor
Date: 29 February 2012 00:09:24
Message:
! Admin templates would throw undefined 'step' index if they used ints but did not come from the plugin handler. (Admin.template.php)
! Added date and datetime support to the database handler for plugins, mostly because the calendar needed it. (Class-DBPackages.php, ManagePlugins.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/Admin.template.php
Title: Re: New revs
Post by: Nao on February 29th, 2012, 10:40 AM
rev 1404
(7 files, forgot KB)

* Some postbg-related simplifications. Removed .wrc from topic posts. Because posts use postbg instead of windowbg, they can easily extend the class from wrc manually, which Wine will be doing for instance. Removed inheritance from .pm class, as it was already explicit in the HTML code. Removed .postbg styling for Split Topic page, as it was no longer used there anyway (it's a .windowbg with a .post child div). (PersonalMessage.template.php, index.member.css, Wine/sections.css)

* Indenazi for the Post page and Topic posts (this one will actually save quite a few bytes). Quick Reply editor indentation will still be broken, but slightly less. (Class-Editor.php, Display.template.php, Post.template.php)
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 11:19 AM
(4 files, 2KB)

Revision: 1405
Author: arantor
Date: 29 February 2012 10:17:29
Message:
! Fix for SMF bug 4743 (updating post count membergroups uses old cache data) (ManageMembergroups.php)

! More remnants of mod settings page vanished. (ManageServer.php, Help language file)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php

@ I'm certain my fix is different to SMF's for the same bug as mentioned here(http://www.simplemachines.org/community/index.php?topic=436394.msg3284172#msg3284172). If they're modifying Subs.php, either they're no longer using cached data, or they've overloaded updateStats() in some fashion to indicate that the cache shouldn't be used. Either way, that's tampering with something that's applied every post as it's made, as opposed to just flushing the cache when updating the relevant data in the admin panel as I'm doing.
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 12:11 PM
(4 files, 2KB)

Revision: 1406
Author: arantor
Date: 29 February 2012 11:10:33
Message:
! Cleaning up a language string in the admin. (ManagePlugins.template.php, Admin language file)

! SMF bug 4000/4730: Reattributing posts should also clean up the topics too. The query doesn't need to blindly reset every topic that the member owns, however, only the ones currently with a member id of 0. (Any that are actually otherwise wrong will be fixed by find/repair) (Subs-Members.php)
----
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 03:13 PM
(10 files, 2KB)

Revision: 1407
Author: arantor
Date: 29 February 2012 14:12:32
Message:
! Fix SMF bug 4959 (missing free_result calls in ManageNews.php) (ManageNews.php)

! Fix SMF bug 4882 (remove eAccelerator support) (smfinfo.php, status.php, Load.php, ManageMaintenance.php, ManageServer.php, Subs-Admin.php, Subs-Cache.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/tools/status.php
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 04:26 PM
(5 files, 2KB)

Revision: 1408
Author: arantor
Date: 29 February 2012 15:25:31
Message:
! Creating a new group put the wrong image into the table. (ManageMembergroups.php)

! Message index didn't handle drafts properly, due to old code from before I broke the template up. (MessageIndex.template.php)

! Fix SMF bug 4794, PM and search error boxes were in either the wrong place or using the wrong styling. (PersonalMessage.template.php, Search.template.php, sections.css)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/skins/sections.css
Title: Re: New revs
Post by: Arantor on February 29th, 2012, 05:37 PM
(1 file, 3KB)

Revision: 1409
Author: arantor
Date: 29 February 2012 16:36:40
Message:
! SMF bug: the manage attachments and avatars areas both define a series of numeric inputs using type 'text' which means non numeric variables can be stored in what are supposed to be numeric spaces. (ManageAttachments.php)

! Minor other improvements to manage attachments/avatars, such as setting min/max values on some of the ints, and removing guests from potentially having permission to have an avatar (even though of course they cannot have an avatar, they can theoretically receive permission in SMF!) (ManageAttachments.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Title: Re: New revs
Post by: Arantor on March 1st, 2012, 01:27 AM
(8 modified, 5KB)

Revision: 1410
Author: arantor
Date: 01 March 2012 00:27:01
Message:
! SMF bug 4865: hidden items in the permissions area would cause incorrect formatting. (ManagePermissions.template.php)

! Tweak pretty URLs, drafts and merge posts UI to fix a couple of layout bugs and make all three searchable through the admin search feature consistently. (Admin.php, ManagePosts.php, ManageSettings.php, SplitTopics.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Title: Re: New revs
Post by: Arantor on March 1st, 2012, 10:06 AM
(4 modified, 2KB)

Revision: 1411
Author: arantor
Date: 01 March 2012 09:05:49
Message:
! SMF bug 4868 (anti spam Q&A would not accept 0 as a valid answer) (Subs-Editor.php)

! SMF bug 4828 (editing an icon would fail if admin security was tripped) (ManageSmileys.php, ManageSmileys.template.php)

! Removing duplicate options for PMs from security pages, they fit much better in the PMs area anyway, and now they won't show up twice in searches. Also tweaked min values for a few settings. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Title: Re: New revs
Post by: Arantor on March 1st, 2012, 12:12 PM
(4 files, 7KB)

Revision: 1412
Author: arantor
Date: 01 March 2012 11:11:29
Message:
! Partial fix for SMF bug 3009 (duplicate title/meta info) - there are now page numbers appended to the page title on the first invocation of template_page_index; since it is called prior to the body_above template, as it is also used in certain ways to clean up incoming data, we don't have to mess around with much work to do this. Not the cleanest it could be, mind. (index.template.php, index language file)

! SMF bug 4388: when displaying the list of approvals, show the last login column for pending-deletion members, and date registered for all other cases. (ManageMembers.php, ManageMembers language file)

! Related to the above, the tabs in the manage members area were using old code, now brought up to date and working correctly. (ManageMembers.php)
----
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on March 1st, 2012, 01:54 PM
(5 files, 1KB)

Revision: 1413
Author: arantor
Date: 01 March 2012 12:54:10
Message:
! SMF bug 4936 (disabling certain bbc in signatures causes others to fail too) (Profile-Modify.php)

! SMF bug 4902 (SSI does not issue a header with charset) (SSI.php)

! SMF bug 4896 (~ backup files will break paid subs, search and in our case CAPTCHAs too) (ManagePaid.php, ManageSearch.php, Subs-Captcha.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Captcha.php
Title: Re: New revs
Post by: Arantor on March 1st, 2012, 03:53 PM
(16 files, 5KB)

Revision: 1414
Author: arantor
Date: 01 March 2012 14:53:19
Message:
! SMF bug 4836 (linktree_inline legacy items) (install.sql, Display.php, MoveTopic.php, Post.php, Themes language file)

! SMF bug 4755 (registration disabled but links still shown) (SSI.php, index.template.php, Login.template.php, index and Login language files)

! SMF bug 4742 (forum stats disabled but still accessible) (Stats.php, Errors language file)

! Minor improvement to maintenance manage-members template. (ManageMaintenance.template.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on March 1st, 2012, 05:48 PM
rev 1415
(6 files, 4kb)

+ Added topic_privacy and thought_privacy tables, for later use. Please note that the primary key is a combination of all existing keys, so it may not exactly be very useful as such... I'm not a MySQL guru. (install.sql)

* Optimized SSI's poll function. A tiny bit. I think. Did I say I wasn't a MySQL guru already...? (SSI.php)

* Translation. (Errors.french.php, index.french.php, Login.french.php, ManageMembers.french.php)
Title: Re: New revs
Post by: Nao on March 1st, 2012, 10:10 PM
rev 1416
(5 files, 3kb)

! MySQL doesn't need a client with version 5.1 (as evidenced by Wedge.org), only the server needs to be at least 5.1. Setting the minimum client version to 4.1. Or should it be 5.0? (install.php)

! Pretty URLs wouldn't accept the same URL on two different topics, even though the system no longer cares about their unique quality. (install.sql)

! Attachment loading code was failing calls to transparency tests. (Display.php)

! Me like big thumbnail. Me want big thumbnail. Me sad that thumbnail not big with rewrite. Me want big thumbnail. (ManageAttachments.php)

* GD2 likes to throw exceptions from time to time. Or maybe it's the filesystem, I don't know. Anyway -- making one of these functions a bit more conservative. (Subs-Media.php)
Title: Re: New revs
Post by: Arantor on March 2nd, 2012, 11:43 AM
(6 modified, 3KB)

Revision: 1417
Author: arantor
Date: 02 March 2012 10:42:30
Message:
! SMF bug 4783 (wrong language string in the paid subs area) (ManagePaid.php)

! SMF bug 4904 (dropping %20 from avatar URLs) (Profile-Modify.php)

! SMF bug 4840 (disabling search engine tracking could break who's online) (Who.php)

! Fixed length subs could not be saved properly due to two form items having the same name (and overriding one another) (ManagePaid.php, ManagePaid.template.php)

! Minor profile layout bug when an error is thrown (Profile.template.php)

! Wrong header type used in who's online (Who.template.php)

----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Who.template.php
Title: Re: New revs
Post by: Arantor on March 2nd, 2012, 12:10 PM
(3 files, 2KB)

Revision: 1418
Author: arantor
Date: 02 March 2012 11:09:59
Message:
! Improved attachment handling if the supplied URL is not valid for one reason or another. (Class-WebGet.php, Profile-Modify.php, Subs.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on March 2nd, 2012, 01:59 PM
(1 file, 1KB)

Revision: 1419
Author: arantor
Date: 02 March 2012 12:58:33
Message:
! SMF bug 4880 (admin search members doesn't paginate because dates are passed in a different format to received; adjusted so that both int and date format will be accepted and processed) (ManageMembers.php)
----
Modified : /trunk/Sources/ManageMembers.php
Title: Re: New revs
Post by: Nao on March 2nd, 2012, 06:20 PM
rev 1420
(4 files, 2kb)

! Wedge's 404 error handling should now also give you the proper URL where the error occurred, instead of specifying twice the file that wasn't found. Also addedd css and js extensions to the list of files to look out for. (Errors.php, QueryString.php)

! repair_settings.php was broken, due to wesql not being instanced. (repair_settings.php)

- wesql instantiation doesn't have access to query_see_topic, no need to declare it. (Class-DB.php)
Title: Re: New revs
Post by: Nao on March 2nd, 2012, 07:01 PM
rev 1421
(7 files -3, 2kb)

* Alphabetical table reordering for wedge_sessions. (install.sql)

- Removed a CSS file link that's never going to work anyway. (readme_update.html)

! Various CSS fixes for Weaving and Wine (and inherited skins), mainly for IE 6/7/10. Not exactly finished, though. (index.ie6.css, index.ie7.css, index.ie10.css, Wine/index.css...)
Title: Re: New revs
Post by: Nao on March 3rd, 2012, 02:49 PM
rev 1422
(2 files, 2kb)

! WeCSS: @replace wasn't implemented cleaned up after execution. (Class-CSS.php)

* WeCSS: because indentation is removed when building the tree, don't waste time searching for opening spaces. (Class-CSS.php)

+ WeCSS: added support for single-line resets. Previously, you had to add a dummy rule below the selector if you just wanted to forget a selector's earlier styling. (Class-CSS.php)

* Logic nazi. (Subs-Post.php)
Title: Re: New revs
Post by: Nao on March 3rd, 2012, 06:18 PM
rev 1423
(1 file, 2kb)

! Fixed another WeCSS bug that would occur when a variable sets something, and then is later overridden with a value that starts the same but adds something to it. (Class-CSS.php)

PS: I have another bug that happens with the reset keyword, dated prior to today's fixed... Unable to fix it for now, though.
Title: Re: New revs
Post by: Arantor on March 4th, 2012, 02:12 AM
(1 file, 1KB)

Revision: 1424
Author: arantor
Date: 04 March 2012 01:12:06
Message:
! The full request URI was only being evaluated for 'is it a 404 image' in the event that pretty URLs was enabled, failing that it would never evaluate the URI properly, so the 404-handler never kicked to log missing images. This is early enough in the process that it occurs before the log write occurs, which is awesome. Also, no need to update the online log with a 404 error. (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php
Title: Re: New revs
Post by: Arantor on March 4th, 2012, 03:12 AM
(17 modified, 2KB)

Revision: 1425
Author: arantor
Date: 04 March 2012 02:12:26
Message:
! SMF bug 4442 (name="submit" used in forms which can break onsubmit functionality) A lot of these can actually be pruned, a few left require *something*, so those use name="save" instead. Nothing seems to be broken as a result of this change. (all files)
! Unclosed form tag. (ManageMedia.template.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/other/tools/repair_settings.php
Title: Re: New revs
Post by: Arantor on March 4th, 2012, 03:20 PM
(6 modified, 3KB)

Revision: 1426
Author: arantor
Date: 04 March 2012 14:19:26
Message:
! SMF bug 4817 (unable to register if COPPA is enabled but no agreement is used) (all files)

! A little clean-up where some error strings were moved from Login to Errors because they're errors. (Register.php, Login + Errors language files)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Title: Re: New revs
Post by: Arantor on March 4th, 2012, 06:33 PM
(4 modified, 2KB)

Revision: 1427
Author: arantor
Date: 04 March 2012 17:33:17
Message:
! SMF bug 4757: allow deleting spider stats as well as logs. (ManageSearch.template.php, ManageSearch.template.php)

! Clean up of a language string. (Search.english.php)

! Other areas of manage-search-engines were not properly accessible. (ManageSearchEngines.php)

! Do not show spurious linktree entries when on the ACP front page. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/languages/Search.english.php
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 12:04 AM
(6 modified, 5KB)

Revision: 1428
Author: arantor
Date: 04 March 2012 23:03:54
Message:
! Move the webmaster email settings out of the server settings page and into email settings, which is simpler than it sounds like it should be. Incidentally, admin search will now pick these settings up where it wouldn't before (and likely more of that to follow) (ManageMail.php, ManageServer.php, Admin + ManageMail language files)
----
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/Themes/default/languages/ManageMail.french.php
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 12:58 AM
(7 modified, 4KB)

Revision: 1429
Author: arantor
Date: 04 March 2012 23:58:00
Message:
! SMF bug (untracked?): internal admin search needs to un_htmlspecialchars() the search term before trying to apply it. (Admin.php)

! Move various 'who's online' settings to their own page in Member Options. (Admin.php, ManageSettings.php, ManageMemberOptions.php, Admin + Help + ManagePermissions + ManageSettings language files)

! Make sure the admin search results page has the right linktree. (Admin.php)

! Make sure UTC is actually included in the timezone list as it is a valid timezone in its own right, and was previously excluded in the server list (ManageSettings.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 01:43 AM
(5 modified, 4KB)

Revision: 1430
Author: arantor
Date: 05 March 2012 00:43:13
Message:
! Move time offset and timezones to the server settings page, since they're really more server related than anything else. (ManageServer.php, ManageSettings.php)

! Perform a few little tweaks to make a few more ACP options searchable. (ManageServer.php, Admin language file)

! Rearrange a few more admin things: "Detailed Reports" into Members (seriously, why is this a 'server' thing, it's all about the people), "Search" into Server/Maint. (since it's all about configuring search) This isn't finalised of course and can always be changed back or to something different if desired. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 09:48 AM
(8 modified, 3KB)

Revision: 1431
Author: arantor
Date: 05 March 2012 08:47:27
Message:
! Removed 'Security Settings' as it was a touch misleading, and moved its settings into two new pages: Forum - Anti-Spam and Members - Warnings, which allows for customisation and expansions going forward (since Warnings will become Warnings & Bans and remove the current Ban List entry). Also moved Smileys and Message Icons along its line/menu, giving it less prominence than it had before. (all files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 10:02 AM
(1 modified, 1 added, 2KB)

Revision: 1432
Author: arantor
Date: 05 March 2012 09:02:12
Message:
+ Icon for warnings area. (warning.png, Admin.php)

! Fix to old search setting, exclude type=warning from admin panel searches, and change the strip-description from matching div/span with smalltext to the current dfn, so if an entry has dfn text it isn't part of the search results as part of the link. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Themes/default/images/admin/warning.png
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 10:12 AM
(1 modified, 1KB)

Revision: 1433
Author: arantor
Date: 05 March 2012 09:11:39
Message:
! If an admin setting indicates a help text itself, make sure we pick that up (usually if it has a different key in $helptxt to its setting name in $txt) (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Title: Re: New revs
Post by: Nao on March 5th, 2012, 05:41 PM
rev 1434
(9 files +4-4, 18kb)

* Rewrote stats bar to use a CSS gradient. This saves us over 700 bytes in the final gzipped CSS file, and makes HTML simpler as well. If you have a lousy browser, you'll just see a rectangle. I'm sure you can live with it. (bar_stats.png, Display.template.php, Profile.template.php, Stats.template.php, index.rtl.css, sections.css)

* Replaced topic icons with PNG versions. Tried GIF versions, they were barely smaller and slightly blurrier. Moved originals to the attic. (Display.template.php, MessageIndex.template.php, images/topic/*.gif)

* Rewrote poll template to use less bandwidth. Should also make it possible to show multiple polls in a page now. (Display.template.php, sections.css, bar_stats.png)

* Weaving will now use Segoe UI Light by default in its main header. Introduced a $big_font variable for that spot. (index.css)

* Some changes to note zones. As upsetting as it is for me, I'll be using a fixed size (7pt) instead of a relative one, until I find a workaround to make note padding work identically across all browsers in the main menu. (index.css)

* Other minor CSS changes, such as Weaving's background now sporting a full white (instead of Wine's quasi-white), or fixing the post font's temporary font stack. (index.css)

! WeCSS: fixed PHP warning that occurred when doing at least two resets, with the second one related to a selector already impacted by the first one (e.g. a child of it). (Class-CSS.php)

! Fixed responsive sidebar position in Wuthering. (Wuthering/index.css)

! Fixed broken poll layouts. (Display.template.php)

! Fixed background color in wehead class. (index.css)
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 05:50 PM
(15 modified, 11KB)

Revision: 1435
Author: arantor
Date: 05 March 2012 16:49:47
Message:
! Stripped some old legacy styling from the admin templates, from the old Core Features page. (admin.css, admin.rtl.css, index.ie6.css)

! Rejigged some of the profile/theme options to use the same $txt key as the setting they represent, no more of this $options['show_board_desc'] to $txt['board_desc_inline'] nonsense. (Settings.template.php, Profile.template.php, Profile language file)
! Made 'default forum language' searchable in the admin search. (ManageServer.php, Admin language file)

! Some of the preset defaults in the installer are actually incorrectly set up. (install.sql)

! Added part of the UI for editing member options without it being in the theme area, the UI does not yet save anything but I wanted to get what I had committed. The JS is rather rough, sorry. (Admin.php, ManageMemberOptions.php, admin.css, ManageMembers.template.php, Admin + ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/skins/admin.css
Modified : /trunk/Themes/default/skins/admin.rtl.css
Modified : /trunk/Themes/default/skins/index.ie6.css
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on March 5th, 2012, 06:04 PM
(13 files, 1KB)

Revision: 1436
Author: arantor
Date: 05 March 2012 17:04:04
Message:
! Remove unnecessary 'poll mode' setting. (All files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on March 5th, 2012, 11:55 PM
rev 1437
(12 files, 9kb)

* Forgot to commit a statbar-related change. (Display.php)

* Casenazi. (ManageSettings.php, Aeva-Gallery.php, ManageSettings.language.php)

* Indenazi. (ManageMembers.template.php)

* French translations. Hope I didn't forget anything... (LANGUAGES: Admin, Errors, Help, Login, ManagePermissions, ManageSettings, Search)
Title: Re: New revs
Post by: Nao on March 6th, 2012, 12:16 AM
rev 1438
(2 files +2, 20kb)

+ Added a couple of filler logos, so that Pete doesn't have to get 404 on them all the time ;) Removed wedgesymbol class -- you're big boys, you can style it yourself if needed, right? (wedgebot.png, wedgetop.png, index.css, Wine/index.css)
Title: Re: New revs
Post by: Arantor on March 6th, 2012, 04:41 PM
(3 files, 7KB)

Revision: 1439
Author: arantor
Date: 06 March 2012 15:41:05
Message:
! The save-member-preferences code seems to be complete and working. Not yet pruned the old settings area, just in case. But I know I'm going to end up pruning more code that I've created... resetting theme options' original code is so overcomplicated. (ManageMemberOptions.php, ManageMembers.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on March 6th, 2012, 06:02 PM
(5 files, 3KB)

Revision: 1440
Author: arantor
Date: 06 March 2012 17:01:49
Message:
! Stupid typo in member preferences saving; didn't actually affect behaviour though. (ManageMemberOptions.php)

! Certain member preferences should be disabled depending on admin options. (ManageMemberOptions.php)

! New menu item present if the user specifies a 'home page'. Needs an icon though. (Subs.php, ManageSettings.php, index+ManageSettings language files)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on March 7th, 2012, 12:47 AM
(8 files, 17KB)

Revision: 1441
Author: arantor
Date: 06 March 2012 23:47:23
Message:
! Rework the admin search slightly so instead of recognising two areas (sections and settings), it recognises three (sections, settings and preferences), and also makes the preferences searchable, at least the admin side. (Admin.php, Admin language file)

! SMF bug: when registering a user, don't just almost-always set their quick reply to 'show but off by default', actually don't set it at all, so that the admin's choice will be honoured. (Register.php)

! Update the hooks actually in play now. (ManagePlugins.php)

! Preferences now indicate where they expect to be shown, for use elsewhere. Maybe this might be used in the main UI itself, don't know yet. (ManageMemberOptions.php)

! The profile / look and layout area now uses the settings indicated by the master settings from the admin area. (Profile-Modify.php, Profile.template.php, Settings.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Title: Re: New revs
Post by: Arantor on March 7th, 2012, 01:09 AM
(8 files, 1KB - probably because it's not lots of changed lines, but decently sized chunks of just removed lines)

Revision: 1442
Author: arantor
Date: 07 March 2012 00:08:10
Message:
! Remove the old reset-options area from admin, now that it's just not needed. Surprising amount of code saved actually. (All files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Title: Re: New revs
Post by: Arantor on March 7th, 2012, 11:35 AM
(3 files, 1KB)

Revision: 1443
Author: arantor
Date: 07 March 2012 10:34:39
Message:
! No point showing the quick moderation bar in search results if there's no results to apply them to. (Search.template.php)

! Legacy code from profile changes. (Profile-Modify.php)

! Force the admin area not to offer the sidebar menu, it's either the nice icons or the dropdowns, there's no need for anything else. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/Search.template.php
Title: Re: New revs
Post by: Arantor on March 7th, 2012, 12:14 PM
(3 modified, 1KB)

Revision: 1444
Author: arantor
Date: 07 March 2012 11:13:47
Message:
! One of the smileys shown to users in the editor was using the wrong code. Harmonised that to use the correct code. (Subs-BBC.php)

! Password too short message wasn't appropriately loaded so not only would the sprintf fail, it would also drop an error. (Reminder.php, Subs-Members.php)
----
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Members.php
Title: Re: New revs
Post by: Arantor on March 7th, 2012, 02:33 PM
(7 files, 2KB)

Revision: 1445
Author: arantor
Date: 07 March 2012 13:32:18
Message:
! Convert 'don't show avatars' and 'don't show signatures' to 'show avatars' and 'show signatures'. Incidentally also fixed the fact the hide avatars option didn't actually work due to not having certain things in scope. I even attempted French translation, should be OK, at least Google Translate says it's OK. (install.sql, ManageMemberOptions.php, Display.template.php, PersonalMessage.template.php, Profile.template.php, Profile language file)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/other/install.sql

@ Spent more time chasing down the stupid bug as to why show_avatars didn't work than I spent on the rest of the changes in this commit, oops.

@ Oops also, I thought I'd updated Profile.template.php somewhere for one of these edits, but I didn't. Instead it's actually to fix a bug in the issue-warning screen where the selectbox wouldn't become enabled when selecting the send message checkbox.
Title: Re: New revs
Post by: Nao on March 7th, 2012, 06:25 PM
My turn :P This week's worth of changes on my side. Not much but I wasted plenty of time on bugs.

rev 1446
(12 files, 15kb)

* Cleaned up the Stats page. Shortened the HTML and CSS, fixed JavaScript no longer working, things like that. (script.js, stats.js, Stats.template.php, sections.css)

* Tweaked two-columns to be more useful by turning them into a single column when the screen is too narrow. To tell you the truth, I was considering hardcoding the width to have them automatically become a single column through the magic of floats, but it's probably better this way. (index.css)

+ Don't know if it's for the best (?), but added support for class, id and style parameters to title, title2 and cat blocks. (index.template.php)

! Fixed various skin issues introduced by the swapping between Wine and Weaving. Title font size should no longer be bigger than category fonts, and .cat/.title2 definitions should no longer be duplicated. Can't remove duplicates automatically though. See, a skin may want to unextend a parent class, but a skin below it (i.e. a grandchild) might want to re-extend it, so I'd have to test for extends, then duplicate extends, then test whether there are unextends between them... If someone's willing to write some code with decent speed, then I'm all ears. No one? That's what I thought. Then be careful when inheriting classes, it's all I'm asking for. ;) (Wine/index.css)

* Restored rounded corners on .wrc in Weaving. Really, I should be using them either most of the time or never at all, instead of the mix it was. (index.css, Wine/index.css)

* Details unworthy of... being detailed. (ManageMembers.template.php, index.french.php, ManageSettings.french.php, Class-CSS.php)
Title: Re: New revs
Post by: Nao on March 7th, 2012, 07:00 PM
rev 1447
(5 files, 1kb)

* Spacinazi. (ManageMemberOptions.php)

* Translation. (Admin.french.php, index.french.php, ManageSettings.french.php)

! IE6 needed a tweak for two-columns, like IE7. (index.ie6.css)
Title: Re: New revs
Post by: Arantor on March 8th, 2012, 04:32 PM
(9 files, 3KB)

Revision: 1448
Author: arantor
Date: 08 March 2012 15:32:03
Message:
! Converted 'don't warn me on new replies' to 'warn me on new replies' (on by default, of course) (install.sql, ManageMemberOptions.php, Post.php, Post2.php, Profile language file)

! Allow the list of fonts in the editor to be customisable with relative ease. (install.sql, Class-Editor.php, ManagePosts.php, Admin language file)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on March 8th, 2012, 06:21 PM
rev 1449
(5 files, 3kb)

* Moved editor's select box styling to a class. (Class-Editor.php, editor.css)

* Made sure not to show these select boxes' titles in the actual dropdowns. (post.js)

! Fixed a bug where select boxes would open centered on a random zone of the dropdown instead of the top, when the current selection is a data-hidden entry (i.e. the select box title, are you still following?) Adds an extra 8 bytes to the gzipped sbox file... Well, it's still at 2250 bytes or so. We still knock the competition out. Not that they care. Or that they consider us competition. (sbox.js)

* Translation. (Admin.french.php)
Title: Re: New revs
Post by: Nao on March 8th, 2012, 08:18 PM
rev 1450
(7 files +1, 16kb)

* A few fixes to Wine and Warm styling. Also updated mini-logos with the new Wedge logo style. Still haven't touched the logos in Weaving, though... (minilogo.png, minilogow.png, Wine/index.css, Warm/index.css, Wuthering/index.css)

* Optimized font gathering code for post editor. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on March 9th, 2012, 10:19 AM
rev 1451
(1 file, 1kb)

! Tweaked installer. It will now disable data compression while installing, and get rid of the uncompressed files after installation. You can now enable data compression by simply choosing the general install setting of compressing data to save bandwidth, which will control both default settings of enableCompressOutput and enableCompressData. You can fine-tune this after installation, of course. (install.php)

+ Added a proper browser language detector for the installer. I've added manually a list of all SMF language packs and their associated language ID, so theoretically you should be able to use an Install.language.php file from SMF into your language folder, and be able to install in your language. Well, this is all only for the glory of Pete, because I doubt we'll be bundling French into the default Wedge package, so the problem of installing Wedge and getting the French version by default is only going to happen in the SVN version... (install.php)

@ Obviously, I'd appreciate it if you guys could confirm that the installer will now default to English for you... ;) It does default to French for me.
Title: Re: New revs
Post by: Nao on March 9th, 2012, 06:57 PM
rev 1452
(3 files, 2kb)

* Modified $language variable for skins. Now it requires setting up a list of languages accounted for Wedge.org in the <language> tag of a skin.xml file, with the first in the list acting as fallback language. Documented in Warm's skin file as usual (even though I don't make use of it... Maybe I should put it inside comments?) (Subs-Cache.php, index.css, Warm/skin.xml)
Title: Re: New revs
Post by: Nao on March 9th, 2012, 07:23 PM
rev 1453
(2 files, 2kb)

+ Upon Pete's suggestion, added a few classes to poll results. All bars get a '.bar1', '.bar2' etc class, accessed through '.poll .barX' when styling, and every other bar gets an additional 'alt' class (access through .poll .alt, or just don't use it and use CSS3 to do that, but I suspect no one would). Heck, it's even shorter than the earlier HTML, because I removed the statsbar class which is no longer needed to style these. Also removed some stat styling leftovers from the RTL file. I never test that file anyway... (Display.template.php, index.rtl.css)
Title: Re: New revs
Post by: Nao on March 12th, 2012, 12:38 AM
rev 1454
(5 files, 3kb)

+ Added skin-controlled on-the-fly HTML replacements. Currently, the feature supports three types of search: a normal search, a regular expression search (accepts regex meta-characters and so on), and a regular search with a special addition: <we:nested:tag_name> will match against any HTML, and will end as soon as all of the nested tag_name tags are closed (if any). It may not sound exciting, but at least it's very fast (on a regular Wedge page, replacing all unordered list items with a recursive element will only take one millisecond.) Also needs documenting... (Subs-Cache.php, Subs-Template.php)

* A minor error in my own custom.css file made me add another bug to the CSS code this week... (sections.css)

* Indenazi. (index.template.php)
Title: Re: New revs
Post by: Arantor on March 13th, 2012, 01:07 AM
(4 files, 1KB)

Revision: 1455
Author: arantor
Date: 13 March 2012 00:06:56
Message:
! Tweaked the board layout markup a bit, removing the forced separator row and converting that to CSS, as well as breaking the single massive table into one table per category, with a div container around everything. This allows for styling everything as a single unit as was previously performed, as well as attaching styling for individual category units like I wanted to do with my Core revamp, as well as making markup more semantic. I don't think anything's broken, I fixed the style issues I found, which weren't many, though it's probably possible to rework the style code better than I did (Boards.template.php, *.css)
----
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/skins/Wine/sections.css
Modified : /trunk/Themes/default/skins/index.iphone.css
Modified : /trunk/Themes/default/skins/sections.css

@Sorry for the huge commit note for such a small change, but it was one I flagged up as being quite important in my little world...
Title: Re: New revs
Post by: Arantor on March 13th, 2012, 02:07 AM
(1 file, 1KB)

Revision: 1456
Author: arantor
Date: 13 March 2012 01:06:37
Message:
! Add support for subtexts in the settings-page integration, if you define a given 'item' as a setting, $txt['item'] will still be its main wording, but now $txt['item_subtext'] will be checked for, and if found will be used as a description under the main wording. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Title: Re: New revs
Post by: Arantor on March 13th, 2012, 11:32 AM
(13 files, 22KB)

Revision: 1457
Author: arantor
Date: 13 March 2012 10:31:19
Message:
! None of the settings should contain their footnotes as part of the main language strings now, where a subtext is defined it should be its own language string (so if we change markup from dfn in the future, we do it a fraction of the times we did before), which also means we get to remove a legacy piece of code while we're at it. (ManageAttachments.php, ManageMemberOptions.php, ManageNews.php, ManagePosts.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, Admin+ManageSettings+Search language files)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Title: Re: New revs
Post by: Nao on March 13th, 2012, 06:59 PM
rev 1458
(12 files, 5kb)

+ Added support for skin options. This is, basically, what the <sidebar> option was about: a setting that's only used at templating time, so it should naturally belong in a wider structure, which is now $context['skin_options']... You can add any options you like, as long as you test for them in your templates. Remember that you'll have to test for empty() as well, because Wedge won't fill in the option for you if it isn't set. (Load.php, Aeva-Gallery.php, Subs-Cache.php, Display.template.php, Wine/skin.xml, Wine/Warm/skin.xml)

* Note: I also documented the upcoming <mobile> option. (Wine/Warm/skin.xml)

* Spacinazi (leftover tabs.) (Class-Editor.php, Class-WebGet.php, ManageModeration.php, ManageServer.php, ManageBoards.template.php, ManagePaid.template.php)
Title: Re: New revs
Post by: Arantor on March 13th, 2012, 11:06 PM
(8 modified, 1 new, 21KB)

Revision: 1459
Author: arantor
Date: 13 March 2012 22:05:16
Message:
! Initial support for Liking posts, amongst other things. It's still woefully lacking, mind, but the very basic functionality (non AJAX like of posts) does work. (index.php, install.sql, Display.php, Like.php, Display.template.php, sections.css, index language file, *.png)
----
Modified : /trunk/Sources/Display.php
Added : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/images/theme/quickbuttons.png
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/index.php
Modified : /trunk/other/images/quickbuttons-32bit.png
Modified : /trunk/other/install.sql

@ I added the images to the 32-bit version first, then indexed it and saved it over the standard one to get it smaller again, but it's not as efficient as it could be, I think >_>
Title: Re: New revs
Post by: Nao on March 14th, 2012, 12:41 AM
rev 1460
(4 files, 12kb)

* Re-optimized quickbuttons.png, saved about 200 bytes. Increased gamma correction on like/unlike because the contrast was too high on bright backgrounds. (images/theme/quickbuttons.png, other/images/quickbuttons-32bit.png)

! Fixed skin option retrieval code, that's what happens to you when you focus on documenting a feature instead of testing it thoroughly... ;) (Subs-Cache.php)

! The theme selector is too restrictive when searching for skins. It should allow for skins that don't have an index.css file to begin with. (Themes.php)
Title: Re: New revs
Post by: Nao on March 14th, 2012, 12:52 AM
rev 1461
(7 files +3, 14kb)

+ Added <mobile> option for skins. What it does right now is modify the post layout to show the userbox above the post, rather than next to it. Also, the userbox in mobile mode is simplified to: avatar, user name, user rank, post date, and action buttons. More importantly, the Quote and Modify buttons get moved to the Action menu to save some space. (Display.php, and most of the other files.)

+ Added support for 'like', 'unlike', 'quote' and 'modify' to the Action menu. (Display.php, index.language.php)

+ Added a new skin, Wireless (see the pattern in official Wedge skin names, eh?), which simply enables mobile mode and provides userbox styling, so that we don't have to style it in Weaving under a specificity of '.mobile'... Yeah, whatever. (skins/Wireless/*)

! In some rare situations, Wedge would not close the opening UL tag for action buttons. Not that it would break anything else than validation, though... (Display.template.php)

! Post classes would break in all situations (except for topic messages), because of a padding reset. I'm pretty sure I reset it for a reason, so it's likely that something else will break... If it does, well, I'll fix it again. Differently. (sections.css)

- Replaced $txt['reply_quote'] with just $txt['quote']. We're adding so many new strings to the index language files, might as well remove anything that doesn't really serve a point... (PersonalMessage.template.php, Profile.template.php, index.language.php)
Title: Re: New revs
Post by: Arantor on March 14th, 2012, 02:03 PM
(7 modified, 4KB)

Revision: 1462
Author: arantor
Date: 14 March 2012 13:01:57
Message:
! OK, so my original plan of killing off Features and Options has been rethought to form General Options. The site's title is there now along with the site link (and a new magical option). (ManageServer.php, ManageSettings.php, index.english.php, Admin+index+ManageSettings language files)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/index.english.php

@ The 'magical' option isn't anything exciting, it just means that the forum title can now also be linked to the site URL given, should you want to do so. Another very common request foiled by 5 minutes of work in the core.
Title: Re: New revs
Post by: Nao on March 14th, 2012, 04:10 PM
rev 1463
(6 files, 3kb)

* Replaced the Help icon with a white logo from our usual 'provider', Yûsuke Kamiyamane (bless you). Better contrast makes the ? sign more readable, and the color palette is closer to what we'd expect from Weaving. Opinions may vary regarding Wine, but we can always reupload an alternative version for it. Cherry on top: filesize is twice smaller... (images/helptopics.gif, admin.css, sections.css)

* French translation and fixes. (Help.french.php, index.french.php, ManageSettings.french.php)

@ Hopefully you'll like the new help icon :)
Title: Re: New revs
Post by: Arantor on March 14th, 2012, 04:52 PM
(17 files, 3KB)

Revision: 1464
Author: arantor
Date: 14 March 2012 15:52:13
Message:
! Removed "Show open report count in forum header" from moderation center preferences, seeing how we don't use it and it's driven by the menu instead. Important: if you previously had moderation settings set, it's going to be broken, so make sure to either clean out mod_prefs in the members table, or at least strip the leading value from something like 1|npgrw|1 to npgrw|1. (ModerationCenter.php, Profile-Modify.php, Report.php, ScheduledTasks.php, Subs.php, ModerationCenter.template.php, ModerationCenter language file)

! Removed some duplicate settings pertaining to drafts and added a note to another area to indicate that there were related settings available. (ManagePosts.php, ManageSettings.php, ManageSettings language file)

! Language string clean up (ManagePosts.php, ManageSettings.php, ManageSmileys.php, Admin+ManageSettings+ManageSmileys language files)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Title: Re: New revs
Post by: Nao on March 14th, 2012, 07:49 PM
rev 1465
(4 files +1, 4kb)

! Inline events contained inside a link referring to <URL> were not being postponed. Also slightly optimized a preg_quote call. (Subs-Template.php)

* Updated Help icon again, this time in a reddish color that should work better across Weaving and Wine. (other/images/helptopics.png, images/helptopics.gif, Wine/sections.css)

* Translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on March 14th, 2012, 08:08 PM
rev 1466
(2 files, 1kb) -- not much, sorry! I just thought this needed committing...

! A few links to category IDs were pointing to somewhere else, thus not triggering the actual act of showing the category's board list... (Load.php, Subs-BoardIndex.php)

@ Made a mention that we need to fix the header logo bug... Anyone up for it? :P (Load.php)
Title: Re: New revs
Post by: Arantor on March 15th, 2012, 12:41 AM
(1 modified, 1KB)

Revision: 1467
Author: arantor
Date: 14 March 2012 23:41:25
Message:
! Sorry Nao, I don't think you'll like this regex change much. But we need to make sure that canonical URLs do not get passed through the PHPSESSID injector, since prior to this, they were - which means PHPSESSIDs galore throughout the web, even with canonical URLs. Yes, SMF has this bug but too many people keep denying its existence without actually bothering to check. (Subs-Template.php)
----
Modified : /trunk/Sources/Subs-Template.php
Title: Re: New revs
Post by: Nao on March 15th, 2012, 08:45 AM
rev 1468
(2 files, 10kb)

* Sorry Pete, I don't think you'll like this commit much. Replaced the Like and Unlike icons with Fugue versions, which are much better looking. Also fixed a few twisted pixels in the original and optimized quickbuttons sprite. New version is a few dozen bytes bigger, but it arguably looks better. (other/images/quickbuttons-32bit.png, images/theme/quickbuttons.png)
Title: Re: New revs
Post by: Nao on March 15th, 2012, 11:13 PM
Note: I have 26 files to commit right now. I did my best to split them into several thematic commits.

rev 1469
(6 files +2, 30kb) (sic)

! Changed the current thought privacy system to use membergroups instead of random numbers. Later updates should restore fine-tuning on member level. (install.sql, Ajax.php, Profile-View.php, index.template.php, Home.php)

! The thought list in profile pages wasn't being parsed for inline BBC. (Profile-View.php)

! Hopefully temporary hack to fix thought privacy dropdown showing items in a random order in Opera and Chrome. Also added temporary code for use on Wedge.org. (index.template.php, script.js)

+ Added a new virtual membergroup, 'Everyone', to everyone's list of groups. Should make it easier to target everyone including primary membergroups. (Load.php)

+ Added Home.php and Home template, these are *temporary* files for use on Wedge.org only. The code will be moved to the Welcome.php file once it's stable enough and cleaned up (proper MVC model and so on). (Home.php, Home.template.php)
Title: Re: New revs
Post by: Nao on March 15th, 2012, 11:15 PM
rev 1470
(6 files +2 -2, 9kb)

! Fixed posts getting wrong padding in non-Weaving skins. Can't believe no one reported that one... ;) (Wine/sections.css)

* Tweaked post backgrounds in Warm. Hmm, it's still no good at all. Warm is a skin that has the potential to be fantastic, but is hurt by my current lack of inspiration regarding non-pastel color palettes. Whatever. Also fixed sidebar's top padding, which was definitely too small. (Warm/index.css)

+ Replaced existing footer logos with two new logos that seem to prove popular. Also simplified footer CSS and removed two other recent logos which are unlikely to be used again. (webelow.png, webelowine.png, wedgetop.png, wedgebot.png, index.css, Wine/index.css, Warm/index.css, Wuthering/index.css)

* Tweaked styling for category headers in Weaving. I guess you can say I chickened out and decided to go for a more 'classical' styling. It still looks great though... Also commenazi. (index.css, sections.css)
Title: Re: New revs
Post by: Nao on March 15th, 2012, 11:18 PM
And the final batch...

rev 1471
(8 files, 7kb)

! The Like button was being shown both outside and inside the action menu at the same time. (Display.php, Display.template.php)

* Modified Primary Membergroups helper text to explain some peculiarities of the feature. (Profile.template.php, Help.language.php, Profile.language.php)

+ Added documentation for the <replace> command in skin files. Disabled current replacement examples, because, well, we don't need them, it's really for admins to use... (Warm/skin.xml)
Title: Re: New revs
Post by: Nao on March 15th, 2012, 11:52 PM
rev 1472
(2 files, 1kb)

! Install process was broken by minor changes on my side. And yes, I'm installing the public version of Wedge... Exciting eh? (install.php, install.sql)
Title: Re: New revs
Post by: Nao on March 16th, 2012, 01:07 PM
rev 1473
(2 files, 1kb)

! The Thoughts table wasn't using Wedge conventions (default values etc). (install.sql)

! Footer logo was cut off if page generation stats were disabled. (index.css)
Title: Re: New revs
Post by: Nao on March 16th, 2012, 01:17 PM
rev 1474
(5 files +1, 4kb)

* Updated blog layout to catch up with the board layout additions, and forced blog posts to show a neutral background instead of something reflecting the current post state. Readability, man. Anyone willing to turn that lonely style into a class? (MessageIndex.template.php)

* Fixed Wireless skin on iPhones. Should look good enough, now, and more importantly... Usable! I'll be on my iPod in half an hour, and gosh I'll be glad I wrote all of that crap. (Wireless/sections.css, Wireless/sections.iphone.css)

! Ironically, .smalltext class is sometimes bigger than regular text on the iPhone. Quick hack on that one... Probably needs more work. (index.iphone.css)

! ssi_recentTopics() wasn't returning the most recent topics, because of a silly optimization I shouldn't have made. (SSI.php)

! WebGet was using CURLOPT_HTMLHEADER instead of HTTPHEADER... Honestly, I don't know a thing about the WebGet file but I'm fixin' errors from my log ;) (Class-WebGet.php)
Title: Re: New revs
Post by: Nao on March 16th, 2012, 06:06 PM
rev 1475
(3 files, 1kb)

* Various minor improvements to Weaving, based on actual use at wedge.org. Yay. (index.css, sections.css)

+ Added another hardcoded element for wedge.org -- this time I'm adding a @worg prefix to indicate that this needs to be put into a plugin or something. This one adds the revision number in the footer, taken from a rev.txt file in the default theme root folder. Obviously, this requires manually updating the file so I won't commit it (consultants, don't forget to add an empty rev.txt file to your folder if you don't want to see any errors.) Oh, now I want to use $GlobalRev$... How do I do that, already..?! (index.template.php)
Title: Re: New revs
Post by: Nao on March 16th, 2012, 10:58 PM
The GOOD thing with the Wedge.org upgrade, is that now you guys can all follow whatever additions I made to Wedge, because they'll usually be reflected on Wedge.org... ;) Just check the revision number in the webpage footer to be sure.

rev 1476
(18 files, 8kb)

! The double-post merge button didn't show up in some situations... Scratch that, in *most* situations really, because of an inverted default value. Also updated subtext to mention the delay should be indicated in seconds. Eh, it might have been minutes, all right? (Display.php, Admin.language.php)

! Applying John's suggested hack to allow HTML inside macro options (like the logo param in the header macro.) Untested, but should work. (Load.php, Subs-Template.php)

! ssi_recentTopics() was always pointing to the last post, instead of the last unread post for members. (SSI.php)

* Tweaked Track IP page to allow for language strings to show the IP anywhere inside the string, rather than at the end. (Profile-View.php, Profile.template.php, Profile.language.php)

* I'm sure there's a reason why I added a line-break after the quick reply textarea. There must be. For that reason, I'm removing it to fix the current layout, and eagerly waiting the day I'll go 'doh!' and unfix it. (Display.template.php)

! Wrong hardcoded membergroup ID in the thought system. (index.template.php)

* Modified French version to use 'cookie' instead of 'témoin' most everywhere. I just fired up IE9 and noticed how Microsoft is saying cookie in French. Cookies are yummy, whatever country you're from. (Admin.french.php, Errors.french.php, ManageSettings.french.php)

* Now using Help icon instead of '?' character to link to help popups in the membergroup permission manager. (ManagePermissions.template.php)

- We don't need the 'Switch to Full Editor' button to be animated on page load... It's just a waste of energy. (topic.js)

! Ah, the joys of CSS specificity... A table cell with a left class should be left-aligned, even if its parent row has a center class or whatever. (index.css)

! Public thoughts could overflow when shown in Display userboxes. (sections.css)
Title: Re: New revs
Post by: Nao on March 17th, 2012, 01:18 PM
My! Forgot to post this one...

rev 1477
(6 files, 4kb)

! Add Media button was still showing up even with the Media gallery disabled. (Class-Editor.php)

! I don't know what this $firstIndex business was all about, but it didn't work on blogs. Rewrote it to simply use min($messages), which will retrieve the old message ID in the list. That's bound to be the first message to show up, innit...? (Display.php)

+ Added the proper board index to the homepage, below latest topics and latest thoughts. As I said - it's just ten lines of code and not template edits... Über-cool. (Home.php)

! Removing tapatalk from 404 error logs. Seriously, we don't need to see that. Also transforming ampersand entities to regular ampersands. Hopefully that'll be enough to make some referrers browsable without edits. (QueryString.php)

* Changed ssi_recentTopics() so that it uses the topic's title, rather than the last post's. Also removed a duplicate id_topic field retrieval. I don't even know how that never generated a MySQL error...! (SSI.php)

+ Adding a Save class to the Pretty URL admin page's submit button. (Admin.template.php)
Title: Re: New revs
Post by: Arantor on March 17th, 2012, 02:23 PM
(1 file, 3KB)

Revision: 1478
Author: arantor
Date: 17 March 2012 13:22:54
Message:
! Rewrite the IPv6 matching code, it should now work properly on addresses (as it actually predates the IPv6 implementation, it didn't actually match netblocks properly against the internal IPv6 encoding used.) (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on March 17th, 2012, 06:36 PM
(2 files, 1KB)

Revision: 1479
Author: arantor
Date: 17 March 2012 17:36:21
Message:
! If you select remove-draft, it should not be resaved automatically. If you want to save a draft after all, that's what the save draft button is for. (post.js)
! There should be a link tree displayed when you're inside a category at least... (Boards.php)
----
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Themes/default/scripts/post.js
Title: Re: New revs
Post by: Nao on March 17th, 2012, 08:06 PM
rev 1480
(10 files, 4kb)

+ Added a blog class to help style blog posts. Styling the original post is as easy as reaching ".blog .first-post"... So I did just that to remove the background color and increase the font size. (Display.template.php, InfoCenter.template.php, sections.css)

! Fixed a gradient function issue that caused some browsers to show the fallback background color in addition to the gradient itself. Hopefully this won't break anything else, seems unlikely at least. (Class-CSS.php)

* Committing my latest changes to the Wedge.org homepage, including removing the roundframe classes and quick board list, and moving the slogan section right before the main title, because in my case I'm floating both and need this to be done this way. That's what I like about skins. You can perfectly decide to change the order later because it's all in a macro. (Home.template.php, index.template.php)

- Wedge was always showing an 'Awaiting approval' message next to attachments in Post pages, because it couldn't find the approval field that was removed earlier. (Post.template.php)

! Fixed smart quote splitter. (editor.js, post.js)

! Fixed thought form margin when replying to a thought. (index.member.css)

! Quick hack to make #board_list and .board_list both stylable... (sections.css)

@ Taking a break, the missus being back from her ski holidays and everything... And she's not glad that I'm on my PC :whistle:
Title: Re: New revs
Post by: Nao on March 18th, 2012, 06:39 PM
rev 1481
(6 files, 6kb)

+ Added "Top liked posts" statistics to the Stats page. Yay. Nothing is cached for now, it's not out of complexity but because I'm not sure it's worth it. (Stats.php, Stats.template.php, Stats.language.php)

* Tweaked CSS for quickbuttons so that they can be used outside of ul tags. (sections.css)

! Shortcut BBCode like ! Fixed a Feed bug on requesting a Topic feed. I'm not sure where that one came from... (Feed.php)

* Spacinazi. (Class-UnitTest.php, Class-SFTP.php, Like.php)
Title: Re: New revs
Post by: Arantor on March 18th, 2012, 07:02 PM
(1 file, 1KB)

Revision: 1482
Author: arantor
Date: 18 March 2012 18:01:25
Message:
! PM drafts were not always handled correctly, where users had permission but permission was not checked properly and was kicking them back when it shouldn't have been. (Subs-Post.php)
----
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Arantor on March 19th, 2012, 10:10 AM
(1 file, 1KB)

Revision: 1483
Author: arantor
Date: 19 March 2012 09:09:38
Message:
! Warning template was using old JavaScript code, with some incorrect styling to boot. (Profile.template.php)
----
Modified : /trunk/Themes/default/Profile.template.php
Title: Re: New revs
Post by: Arantor on March 19th, 2012, 11:20 AM
(1 file, apparently so small a change, TSVN reckoned it was 0KB)

Revision: 1484
Author: arantor
Date: 19 March 2012 10:19:44
Message:
! Replies/views count could get misformatted in the message index. (MessageIndex.php)
----
Modified : /trunk/Sources/MessageIndex.php
Title: Re: New revs
Post by: Nao on March 19th, 2012, 12:49 PM
rev 1485
(4 files, 5kb)

+ Added "Top liked posts" statistics to the Stats page. Yay. Nothing is cached for now, it's not out of complexity but because I'm not sure it's worth it. (Stats.php, Stats.template.php, Stats.language.php)

@NOTE: this was announced in rev 1481 but I forgot to check the files... Also, the icon won't show at all because it's linked to a CSS file change I have yet to document and commit. Sorry.
Title: Re: New revs
Post by: Nao on March 19th, 2012, 01:06 PM
rev 1486
(3 files, 2kb)

! Fixed a few bugs in board modification with a Pretty URL set. There are still bugs left, but here are the fixes: Wedge was using id_cat instead of id_owner to determine the board owner (this was a leftover from the Noisen codebase), the URL generator was going through the topic generator codebase (meaning, mostly, that it accepted illegal characters), and board URLs containing an action name (such as /do or /admin) were being green-lit. (Subs-Boards.php, Subs-PrettyUrls.php)

! Don't accept any action in the board URL. Previously, it wouldn't accept direct action names, now it'll analyze any bit of the URL between potential slashes. (Subs-PrettyUrls.php)

* Added a safety to prevent people from creating a board URL that is a parent of a board owned by someone else, just like it currently prevents creating a child of these. Also, admins should be able to create whatever URL they want, regardless of board ownership. (Subs-PrettyUrls.php)

* Added space trimming in CSS selectors (dunno why I left these out?!), and slash trimming in board Pretty URLs. Y'never known. (Class-CSS.php, Subs-PrettyUrls.php)
Title: Re: New revs
Post by: Arantor on March 20th, 2012, 02:33 AM
(3 files, 1KB)

Revision: 1487
Author: arantor
Date: 20 March 2012 01:33:18
Message:
! Normally 'wrong password' errors are filed under 'user' but there's a bunch of other stuff that's also user errors which is really separate, so move 'failed password' errors to their own filter. (Errors.php, Login2.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Title: Re: New revs
Post by: Arantor on March 20th, 2012, 04:35 PM
(9 files, 14KB)

Revision: 1488
Author: arantor
Date: 20 March 2012 15:34:09
Message:
! Since we insist on a minimum of MySQL 5.1 on the server, we don't need 5.0.50/5.0.51 specific workarounds. (install.php, upgrade.php, Display.php, ScheduledTasks.php)
! Bit odd having a default of keeping error logs for 5 days but only clearing it out on a weekly basis. (ScheduledTasks.php)
! Mostly usable version of the BB log viewer. It's missing a few things but it works. It will also purge the BB log at the same time as purging the error log (and to a point I consider them both variations of 'error' anyway...) (Admin.php, ManageErrors.php, ScheduledTasks.php, Errors.template.php, Admin and ManageMaintenance language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/other/install.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on March 20th, 2012, 11:26 PM
rev 1489
(9 files +2 -2, 15kb)

+ Added privacy icons. Yayz. And a Facebook link in the bottom, which is like the antithesis to privacy. Don't ask. (icons/privacy.png, other/images/privacy.png, Home.template.php, index.template.php, script.js, index.member.css)

+ Added an is_touch variable in JavaScript, which returns true for all devices with a touchscreen. Updated the select box to use that instead of is_iphone and is_tablet. (script.js, sbox.js)

* Non-mobile skins shouldn't force a viewport width on touch devices. So, instead of the browser detector, I'll be relying on the skin's mobile flag to change the viewport. Also, modified viewport values to zoom in a bit more. Seriously, it makes the pages even more readable, and without making look them too ugly. (index.template.php)

- Removed some old logos from the depository. (wedgelogo.png, wedgesight.png)

* 'Last auto saved' mention below textareas was a bit too large. (editor.css)

! Considering that if you import your site into Wedge, you will likely lose some images/icons that we don't use in Wedge, I'm removing Google Cache referrers from the list of 404 errors that should be logged. We should probably add a setting to disable 404 loggings entirely, or based on file extensions... Peeeete? :P (QueryString.php)

! Fixed a BBC parsing warning error that could be triggered in some situations, like the print-friendly page. (Subs-BBC.php)

! Fixed signatures getting lost outside of the page layout. Also moved moderatorbar and quick edit button CSS to member CSS, because I don't see why guests would need to access these. Would they? (sections.css, index.member.css)

@ Still have plenty of files to changelog. Coming tomorrow I think...
Title: Re: New revs
Post by: Nao on March 21st, 2012, 10:33 AM
rev 1490
(2 files +3, 70kb) (including 69KB of image files ;))

! Google Cache and Tapatalk hits were being processed as PHP pages, instead of returning a 404 error and just being ignored in the log. (QueryString.php)

+ Added more exceptions to 404 error logging, mainly due to search bots spidering elements without revisiting HTML pages: cache folder files, and 'clear' avatar URLs. (QueryString.php)

+ Added protections to the Wireless skin folder. (Wireless/*)

+ Wuthering didn't have one of its fix files in the SVN. (Wuthering/index.member.css)

+ Added to the image attic what I believe are the original logos for webelow and webelowine. Also added webelow to the normal image folder. (other/images/webelow*.png, images/webelow.png)
Title: Re: New revs
Post by: Nao on March 21st, 2012, 11:07 AM
rev 1491
(5 files, 3kb)

* Replaced $txt['reply_noun'] (even though this was added to the SMF codebase as per one of my bug reports ;)), because it's only used in one area, and replaced it with a $txt['reply_number'] entry that should be easier to customize (I'm still having Japanese in mind... but other languages might benefit from this.) (Display.template.php, index.language.php)

* Harmonized a bit more the PM template with topic posts. User box should no longer overflow inside the PM body, and some optimizations are also imported. (PersonalMessage.template.php)

* Because of the table to div switch, the birthday cake is no longer properly aligned with the age. And sure enough, had to wait until it was my birthday to notice that... So I just moved the cake below the age. Wait, wait... It's not a cake... It's a WEDGE of cake! (Profile.template.php)
Title: Re: New revs
Post by: Nao on March 21st, 2012, 11:19 AM
rev 1492
(4 files +1, 5kb)

* The Quick Access select box can become crowded easily enough. Replaced the arrows by simple unbreakable spaces. Seriously, it's enough to differentiate between board levels... (script.js)

* French translation. (Admin.french.php, ManageMaintenance.french.php)

+ Yet another missing CSS file. (Wine/index.member.css)

! Forgot to commit updated Warm skin file, with the new name for the header macro ('banner', which makes more sense I think. We already have enough things called 'header' in Wedge.) (Warm/skin.xml)
Title: Re: New revs
Post by: Nao on March 21st, 2012, 03:02 PM
rev 1493
(7 files -1, 4kb)

! Fixed postbg/windowbg confusion in several pages. Until we're ready to create a mini-skeleton for posts, the 'regular' post template will use postbg as its class, while 'mini' posts will use 'windowbg wrc core_posts' (Gesundheit!), which should fix most, if not all of the padding problems encountered on wedge.org since the beginning. (ModerationCenter.template.php, PersonalMessage.template.php, Post.template.php, Profile.template.php, Recent.template.php)

! The PM search feature's post list, perhaps because it is seldom viewed (you have to select Advanced search and tick a specific box?!), was an absolute mess that I had nothing to do with, ahah. Now it should be using something closer to the 'mini' post template. (PersonalMessage.template.php)

- Removed strong tags from create_button HTML. Not that this function is destined to stay (because it's barely even used any longer in Wedge), but at least it should be styled similarly to the rest of the forum... (Subs.php)

- Removed Worg empty folder, which I forgot to do. (skins/Worg)

* Detail. (index.french.php)
Title: Re: New revs
Post by: Nao on March 21st, 2012, 08:03 PM
rev 1494
(9 files -1, 16kb)

! Fixed (hopefully!) no_board error that comes up in the error log when Bad Behavior catches someone trying to view a board. (Security.php)

* Changed my mind on main menu notifications. I figured that with the color code used, even a child would understand that the number is the amount of new items available. So, replaced $txt['new_short'] with numbers. (Subs.php)

* Saved a few bytes by optimizing select box background GIFs and replacing the arrow with a pure CSS triangle. (Interesting code to look at, I'd say.) It won't work in old IEs, and I don't care. (select_arrow_bg.gif, select_arrow_bg_hover.gif, select_arrow.gif, index.member.css)

* Updated Like buttons to make them narrower by one pixel. I'm a bit anal on these details. (quickbuttons-32bit.png, images/theme/quickbuttons.png)

! Reverted and fixed quick button icons. Used another method to access the Like icon for the Stats page. (sections.css)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 09:17 AM
rev 1495
(3 files, 1kb)

! If the Media area is disabled, the Media menu in profiles should be disabled entirely. (Profile.php)

! Added a $section['id'] check in sidebar menus, just like in dropdown menus. This fixes the Media area bug we met on Wedge.org, although the fix above is cleaner. (GenericMenu.template.php)

* Translation tweak. (index.french.php)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 11:59 AM
rev 1496
(1 file, 4kb)

+ Woohoo. Been wanting to do that one for a long time... Now, WeCSS will accept selector lists after the @remove command. Also accepts "@remove from ..." but you can skip the 'from', it's just for convenience. Will take comma-separated lists of selectors, surrounded by double quotes or not, or just a single selector, or even -- let's be crazy -- no selector at all, like before. Basically, if you don't specify a selector, the line will be removed everywhere it's found in the CSS files. If you specify a selector (or more), it will be removed everywhere the selector is declared, including places where the selector inherits or is inherited. Tested on a few items, works fine. I'm sure someone will find a way to break it soon enough, but give me some time to rejoice. Thank you. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 12:06 PM
rev 1497
(2 files, 3kb)

* Added another exception to 404 errors: iOS requesting for an apple-touch-icon file, to use as a big icon if you ever bookmark a website to your 'desktop'. Since I don't think many people are providing that, it's best to just ignore it... (QueryString.php)

! Clicking the menu position's Toggle button would sometimes generate an error if Pretty URLs are enabled. (Subs-Menu.php)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 12:51 PM
rev 1498
(10 files, 4kb) (that sounds small for such a large amount of changes to the CSS files...)

* Moved .two-columns and .upshrinks further up the CSS chain, so that it can safely be inherited. (index.css, sections.css)

* Slogan styling redone entirely. Instead of being shown on the right with some random font, it's now shown just after the website title, in the same font, slightly resized and recolored. Required quite a lot of CSS relative to what it does in the end, but it was required because #siteslogan was never really styled before in Wedge... Since I never used it. Oh, and inherited skins also use slightly different styles for slogans. Diversity is good. (index.css, Wine/index.css, Warm/index.css, Wuthering/index.css)

* Finally committing the CSS part of the select box arrow rewrite. As I said, it's pretty cool as it's a triangle. In CSS. (index.css)

* A few minor changes (at pixel level). (index.css)

* Changed windowbg colors in Warm because I always hated them. Reused those from Wine... (Warm/index.css)

* Wuthering looks best with the bright version of the logo. (Wuthering/index.css)

* Rewrote some variables. $menu_bg is renamed to $menu_gradient, IE 6/7/8 didn't need a fallback in the variable because long ago I restored it in the CSS itself to ensure the menu wouldn't be broken on obscure browsers. Cleaned up the variable list in Wine, because it was pretty much a duplicate of Weaving's... (index.css, Wine/index.css)

! Fixed margins when showing the auto-saved draft message. At least when you're using a larger resolution and can see the entire thing in a single line, it looks better now. (editor.css)

! Fixed .two-columns maximum width on IE 6/7/8/9. Can you spot the difference? Yeah, they all require different widths, ah ah... Gotta love IE. (index.ie*.css)

! Fixed thought list hovers in IE6. Hopefully. You want me to waste time checking that it works..?! (index.ie6.css)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 03:31 PM
rev 1499
(3 files, 2kb)

* Added a post_shortcuts block to the Post template, which holds the list of keyboard shortcuts, and moved the post_buttons block before the options block, allowing for it to be properly aligned, since it's right-floated. (Post.php, Post.template.php)
* The main menu's admin menu should point to the Plugins page, rather than the (soon to be gone) Packages page. (Subs.php)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 04:01 PM
rev 1500 (yay!)
(7 files, 3kb)

! Fixed Ajax rebuilding of thought list after submitting a new one. Now it should properly in iOS. (script.js)

* Added 4px to .cat's top margin. Don't worry about me, it will pass. (index.css)

* Media queries were being a bit too conservative with 1000px. 900px is still an okay width. (sections.css)

* IE's glow filter looks awful. Replaced it with shadow filters in Wine. Also fixed header background (again?)... (Wine/index.ie*.css)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 04:40 PM
rev 1501
(6 files, 3kb)

! Attempting to fix some of the recently discovered auto-saving draft bugs. Drafts should no longer be saved if the message is empty, and the auto-save flag is reset as soon as Wedge is done with it, instead of after the saving operation is completed successfully. (post.js)

! Here's my pretty lame attempt at fixing the anchor position bug in blog posts. I simply added an $excluding_first boolean that is applied to $counter in each post. I'm... pretty sure it's the reason for the issue, although I'd like to get confirmation. (Display.php)

- Removed some $context['page_info'] declarations. These were only useful for wap2 mode or anything that doesn't support JavaScript. Hey, welcome to the 21st century, right?! (Display.php, MessageIndex.php, PersonalMessage.php, Unread.php, UnreadReplies.php)
Title: Re: New revs
Post by: Nao on March 22nd, 2012, 07:40 PM
rev 1502
(3 files, 2kb)

! Fixed the draft saving fix. Should work everywhere as designed, now. The latest issue was that I was testing against 'message' instead of 'draftInfo.message'... (post.js)

! Fixed various problems with blog mod in Display pages. First of all, first_new_message was incorrectly set because it didn't take $include_first into account. Secondly, $counter would return -1 for the blog post. Fixed that. Also, doublepost merging was broken in blog mode. It tested for the first message retrieved the incorrect last message ID for the last page, and it got mixed up overall with the blog post. Finally, I'm optimizing the code a bit by not providing a last_msg_id when merging posts isn't available anyway (like, the previous post isn't yours...) (Display.php)

! Okay, sometimes I'm ahead of my time. Changing the maximum width for definition lists in the stats area proved to generate some amusing layout bugs. (sections.css)

@ Note that 'View most recent posts at the top' is horribly broken, such as not retrieving the latest post at all, and giving more incorrect anchor positions. Well, I never used the option before so I'm a bit lost with the inverted strategy and all.
Title: Re: New revs
Post by: Nao on March 23rd, 2012, 03:07 PM
rev 1503
(14 files +1, 7kb)

! Plugins would never load the non-default language strings. Hey, I think it's the first time I touch plugin-related code at all! :P (Load.php)

+ Added an aeva_showStars() function whose purpose is to simply show an img tag of stars for a corresponding rating between 0 and 5. Half points are taken into account, which wasn't the case before (especially not with a rating of 0.5/5 which would generate a 404 error!) (Aeva-Foxy.php, Aeva-Gallery2.php, Subs-Media.php, Media.template.php, images/aeva/star05.gif)

! If a subject had double quotes in it, replying would show a backslash instead of the first quote, and remove the rest of the subject. (Post.php)

! If $options['view_newest_first'] is set, show the page index's "New" post indicator at the beginning of the list, instead of the end. (index.template.php)

* The Flash language string was a bit confusing. (Admin.language.php)

! Fixed more translations. (Help.french.php)

! Fixed media comment layout. (Media.template.php)

! Fixed the rating select box disappearing after rating a media item. (script.js)

! Fixed overlapping main menu icons in the 'genuine' IE8 (thanks TE). Just to make it clear: this problem doesn't show up in IE9 + IE8 compatibility view, so a big thank you to Microsoft for making our lives a misery. (index.ie8.css)

! Fixed some colors when showing drop-shadow-type zooms with Zoomedia. (media.css, zoom.css)
Title: Re: New revs
Post by: Nao on March 23rd, 2012, 04:00 PM
rev 1504
(8 files, 2kb)

* If the admin_login template is shown (to confirm your password before you access an admin page), Wedge will now use a 'login' id in the html tag, rather than the original page's action id. (index.template.php)

+ ...Which allows me to finally vertically align that dreaded login box. Yay. (sections.css)

! Arhh. Even Firefox doesn't like a 49% width on two-columns! (index.firefox.css)

! Modify Topic Settings was set at an incorrect index in the contextual tabs. (ManagePosts.php)

* Minor tweak to media area styling. (media.css)

* Minor language/translation tweaks. (Admin.french.php, Help.language.php)
Title: Re: New revs
Post by: Nao on March 24th, 2012, 07:36 AM
rev 1505
(5 files +1, 6kb)

! Fixed Split Topics selector's Ajax code, which simply failed to work with the page index function being moved to the index template. (SplitTopics.php, SplitTopics.template.php, Xml.template.php)

! Fixed error in create_button(). (Subs.php)

+ Added a robots.txt with an exclusion rule for ?msg= links, which are aliases to topic pages that I'm sure Google can do without. Plus, it saves you the 404 error on that file. (other/robots.txt)

* Latest homepage tweaks. (Home.template.php)
Title: Re: New revs
Post by: Nao on March 24th, 2012, 02:27 PM
rev 1506
(4 files, 2kb)

! Thought parent links (@Username) didn't always work, because they were referring to the parent thought, instead of the master thought. (Home.php)

+ Profile thought lists will now highlight the parent thought you came for. (Profile.template.php, sections.css)

- If your forum is old enough (YaBB era) to still have threadid links pointing to it, then you're certainly skilled enough to do a regex redirection in your htaccess file, and you'll be happy to save a test for all other users. (QueryString.php)
Title: Re: New revs
Post by: Nao on March 24th, 2012, 07:33 PM
rev 1507
(5 files, 4kb)

! Now ensuring that westr::close_tags() doesn't close any self-closed tags. (Class-String.php)

! Show Newest Posts First would render the New icons incorrectly in topic pages. (Display.php)

! Fixed incorrect number of table cells per line in media album lists. (Subs-Media.php)

* Moderators should be able to merge double posts from guests. (Display.php)

* Moved moderator list to the sidebar, as in Noisen. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php)

* Spacinazi. (Display.php)
Title: Re: New revs
Post by: Nao on March 25th, 2012, 05:41 PM
rev 1508
(6 files, 4kb)

+ Wedge will now silently redirect outdated cached JS/CSS requests to their latest version (or at least any version that works.) Also, don't log errors 404 for completely missing cache files. (QueryString.php)

! Just some extra topic privacy protection in post merging... (SplitTopics.php)

! Ensure that the smart tag splitter won't mistake array members in plain view (like $something['variable']) for tags. (post.js)

+ Apparently, I forgot to commit the template for per-board moderators. (Display.template.php)

! Fixed invisible 'member' thoughts for members without a 'regular member' group. (Home.php)

* Hide the homepage's opening blurb on mobile skins. (Home.template.php)
Title: Re: New revs
Post by: Nao on March 26th, 2012, 10:58 AM
rev 1509
(3 files, 13kb)

! Fixed JS error when editing post in Wireless skin. (Always requires a placeholder for subject! Maybe I should add it through JS though..?) (Display.template.php)

* Optimized quick edit JS for size, saved 100 to 200 gzipped bytes, not much but it all adds up. Next step: optimize footer JS in topic pages. Note that the quick edit object no longer has prototypes. Basically, prototypes of original objects are only useful if you're going to have several instances of an object on the same page. Otherwise, it's just a waste of space. (Display.template.php, topic.js)

* QuoteFast should take topic privacy into account. (QuoteFast.php)
Title: Re: New revs
Post by: Nao on March 26th, 2012, 06:34 PM
rev 1510
(3 files, 3kb)

! A better fix for the dl.stats issue from rev 1502. (sections.css)

! Fixed timezone auto-detector in Profile area. The code is shorter, and should work this time. (Profile.template.php)

* Don't show topicseen in the URL if the topic is already seen. Only done for SSI, dunno if it's needed elsewhere. (SSI.php)
Title: Re: New revs
Post by: Nao on March 27th, 2012, 10:50 AM
rev 1511
(3 files, 3kb)

! The 'javascript' parameter in show_settings was adding an extra space here and there, resulting in unneeded spaces in the final HTML. Harmonized this. (ManagePaid.php, Admin.template.php)

! Rewrote the select box's handling of details (helper text below an option) because it wasn't working correctly in the current version. To do this, I also had to fix the fixed width code because it didn't behave any better. I fear it would make the script bigger, but in the end it's actually shorter by 21 gzipped bytes. Yaych. (sbox.js)
Title: Re: New revs
Post by: Nao on March 27th, 2012, 06:31 PM
rev 1512
(1 file, 6kb)

! Fixed Display.php screwing with post counters, anchor positions and blog/board differences. It took an AWFUL five days of work to fix it all. The code's a bit on the hackish side, some of it doesn't even make sense to me, but I'd rather commit buggy code that works, than leave untouched any buggy code that doesn't work. (Display.php)

! Fixed 'All pages' feature showing links to all pages apart from the [All] thingy. Well, it could be argued that you'd want to have clear links to individual pages in the page index even if you have all of the pages visible in the first place. But I'm saying that it's a waste of HTML, so have someone else fix it back for ya. (Display.php)

! Fixed Merge Double Posts flag being set incorrectly if $ascending was set to false. (Display.php)

- Removed support for topic=123.from456, which has never been used in SMF and Wedge AFAIK. So, just as I said last time, if your forum is old enough to support these links, then you're skilled enough to do a redirect rule in your htaccess or apache config file. (Display.php)

- Commenting out some portion of optimization-oriented code that I couldn't get to work properly with the new fixes. I'll restore it when I'm less tired. Seriously, you don't want to make me do that now. (Display.php)
Title: Re: New revs
Post by: Nao on March 27th, 2012, 06:58 PM
rev 1513
(2 files, 2kb)

! Fixed thought list on iOS. The action buttons don't look great, with no animation and all, but iOS doesn't support position: absolute (at least my version of it), and I decided against doing too many tricks. Usability is more important here. (index.iphone.css)

! Spacinazi. (index.template.php)
Title: Re: New revs
Post by: Nao on March 28th, 2012, 03:28 PM
rev 1514
(2 files, 2kb)

! Fixed non-Wysiwyg mode select boxes remaining in their selected state when they should be reset to the select box title. (editor.js)

! Fixed more select box bugs created by the latest 'fix'. And believe it or not -- it saves an additional 16 gzipped bytes. That's now 2210 gzipped bytes of pure goodness. Until of course someone tells me that their browser has an issue. Because not everyone can use Opera, can they? (sbox.js)
Title: Re: New revs
Post by: Nao on March 28th, 2012, 10:03 PM
rev 1515
(6 files, 3kb)

+ Added a ssi_recentTopicTitles function that does what it does: ssi_recentTopics, but *without* any preview, thus saving the server from having to parse plenty of posts when you don't plan to show their previews. (SSI.php, Home.template.php)

! Fixed Preview button forcing a full page reload because of broken JavaScript. (Post.template.php)

! Permissions admin page would show permission inheritance select boxes over two different lines, instead of just one per option. (admin.css, sections.css)

! Fixed long topic titles breaking layout in post headers. (sections.css)

* Spacinazi. (ManageSmileys.english.php)
Title: Re: New revs
Post by: Nao on March 28th, 2012, 10:47 PM
rev 1516
(2 files, 2kb)

! Fixed random tag closers being added at the end of a post by preparsecode() if a self-closed tag starting with the same characters was found in it. For instance, the  self-closed tag was thought of as a [me] tag by wedit::fixNesting(), and a closing [/me] was added. Fixed by adding a clear separator at the end of the list of tags to be tested. (Class-Editor.php)

! Fixed undefined variable errors in Who's Online page if someone was visiting a gallery item page. This is due to that particular case being accumulated into an array to be treated later, when $data[$k] should always be treated in the loop because of the final str_replace(). Fixed by setting up a blank $data[$k] to begin with, and forcing plugins and AeMe to simply use array_merge() instead of array concatenation... (Who.php)
Title: Re: New revs
Post by: Arantor on March 29th, 2012, 12:22 AM
(3 files, 1KB)

Revision: 1517
Author: arantor
Date: 28 March 2012 23:21:26
Message:
! When storing the contents of the BB log, reparse X-Forwarded-For to use proper IP address. (Security.php)
! Take the server time offset into account for the purposes of setting auto detect time, which should hopefully fix the reported bug. (Profile-Modify.php, Register.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Arantor on March 29th, 2012, 01:04 AM
(2 files, 1KB)

Revision: 1518
Author: arantor
Date: 29 March 2012 00:03:39
Message:
! $settings was not in appropriate scope. (Subs-Cache.php)
! Spacinazi. Fixes errant /me formatting too. (install.sql)
----
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on March 29th, 2012, 01:59 AM
(2 files, 1KB)

Revision: 1519
Author: arantor
Date: 29 March 2012 00:58:35
Message:
! Fix for the board ordering in the boards table. (install.sql)
! Thoughts were using the wrong permissions for 'any', no such permission as 'moderate', since there's either 'moderate_forum' or 'moderate_board', and nothing else magically defines 'moderate' on its own. (Ajax.php)
----
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Arantor on March 29th, 2012, 02:13 AM
(1 file, 1KB)

Revision: 1520
Author: arantor
Date: 29 March 2012 01:11:12
Message:
! There are times when the cached count of errors is not always updated (e.g. error generated then there's an immediate die() afterwards). For these cases, when re-entering the error log, check the current displayed count against the number found by the error log and update that cache appropriately. (ManageErrors.php)
----
Modified : /trunk/Sources/ManageErrors.php
Title: Re: New revs
Post by: Arantor on March 29th, 2012, 02:13 AM
(1 file, 1KB)

Revision: 1521
Author: arantor
Date: 29 March 2012 01:13:04
Message:
! Stupid mistake from previous commit that inverted the logic. (ManageErrors.php)
----
Modified : /trunk/Sources/ManageErrors.php
Title: Re: New revs
Post by: Nao on March 29th, 2012, 03:16 PM
rev 1522
(6 files, 3kb)

! There was a remaining allowedTo('moderate') test in the Ajax file. (Ajax.php)

! Was determining a default $data[$k] too early, which caused profile pages to report unknown actions for offline users. (Who.php)

! Membergroup edit page wouldn't show the allowed board list. (ManageMembergroups.template.php)

+ Added a small note in the membergroup edit page, regarding setting the number of rank images to 1 to use a badge instead of stars. (ManageMembergroups.template.php, ManageMembers.language.php)

* Language fixes. (ManagePermissions.french.php)
Title: Re: New revs
Post by: Nao on March 29th, 2012, 11:29 PM
rev 1523
(4 files, 1kb)

+ Added nofollow parameter to main menu entries, used for Login and Register links when the page is visited by a possible robot. (Subs.php, index.template.php)

+ Added no_index flags to the same pages. (Login.php, Register.php)

- Removed target parameter from main menu entries. I double-checked, and it's never been used anywhere. Which is quite a waste of time when you're testing for it in all sub-menu entries down to the third level... (index.template.php)
Title: Re: New revs
Post by: Arantor on March 30th, 2012, 12:13 AM
(5 modified, 6KB)

Revision: 1524
Author: arantor
Date: 29 March 2012 23:12:06
Message:
! Add extra key to categories table. (install.sql)

! date_offset_get() requires something to be passed to it. (Profile-Modify.php, Register.php)

! State the maximum sizes for avatars when uploading or using external avatars. (Profile.template.php, Profile language file)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on March 30th, 2012, 11:39 AM
rev 1525
(6 files, 5kb)

! Fixed (actually removed and simplified) a malformed rtrim call in pretty_generate_url() that would systematically return an empty string for board URLs. (Subs-PrettyUrls.php)

! Fixed Wedge breaking the entire forum (by redirecting it internally to an empty board) if said pretty_generate_url() returned an empty string, for instance by entering only dashes as the board name. Or something like that. Now it will correctly name it 'b123' where 123 is the board ID. You can always change the URL later... (Subs-Boards.php)

* Shortened posting icons code below board lists. (Boards.template.php, sections.css, index.rtl.css)

* Homepage blurb update. (As a reminder, that file won't be in Wedge, only a shortened version inspired by it. I'm only taking advantage of the SVN server here :P) (Home.template.php)
Title: Re: New revs
Post by: Arantor on March 30th, 2012, 01:56 PM
(5 files, 6KB)

Revision: 1526
Author: arantor
Date: 30 March 2012 12:55:20
Message:
! The Routine Maintenance page can now have extra items added to it, and the tasks are actually searchable now too. (Admin.php, ManageMaintenance.php, ManagePlugins.php, ManageMaintenance.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Title: Re: New revs
Post by: Nao on March 30th, 2012, 03:01 PM
rev 1527
(6 files, 7kb)

+ Added a new helper function, add_replacement($from, $to). This allows you to quickly add a replacement request for the output buffer processor. This is executed right after <URL> is transformed the second time. Probably should add more entry points for the replacement, but that's what I needed right now. I'm a selfish bastard. I'm French, very simply. (Subs-Template.php)

+ I was always bothered by the 'PM inbox' page title, which is shown even in convo mode. Using the new add_replacement function to replace the page title with the last non-empty subject in the conversation mode list. There are probably cleaner ways to do this, but I'm off to the theater premiere of Saint Seiya Omega episode 1, and no one, let me repeat, NO ONE, is gonna make me miss a SINGLE SECOND of that. Perhaps I'll regret it. Perhaps I won't. Perhaps I bet with a friend that I'd insert a reference to Saint Seiya in the Wedge changelog. Perhaps not. (PersonalMessage.php)

* Translation and tweaks. (Admin.french.php, PersonalMessage.language.php, Profile.french.php)
Title: Re: New revs
Post by: Arantor on March 30th, 2012, 03:11 PM
(4 files, apparently only 1KB)

Revision: 1528
Author: arantor
Date: 30 March 2012 14:09:59
Message:
! Some debugging code that should have been removed. (Admin.php)

! Profile area should now be using the timezone selector to handle dates. The old time offset is still internally set up but this is the main thing about rolling the UI out to people. Sorry it isn't very pretty, but it's the best I can do with this particular problem for now. (Load.php, Profile-Modify.php, index language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on March 31st, 2012, 07:08 PM
rev 1529
(2 files, 2kb)

! Intrusion log was showing logs in chronological order by default. (ManageErrors.php)

* Rewrote error log to use descending order by default, so we could avoid adding ;desc everywhere when even the alternative (now ;asc) was never offered in the UI. And yes, it also saves 5 bytes per page for admins, considering it's also in the main menu. What? (Admin.php, ManageErrors.php)
Title: Re: New revs
Post by: Nao on March 31st, 2012, 07:11 PM
rev 1530
(4 files, 1kb)

- Since we're not going to ship package support in Wedge, removed $context['uninstalling'] from related Aeva Media code. Also removed some duplicate code. (Aeva-Embed.php, Subs-BBC.php)

* Moved the footnote parser to its own function, it's cleaner that way and avoid creating a new lambda function for every call to parse_bbc(). (Subs-BBC.php)

- Forgot to commit the ;desc removal for error logs in a file. (Subs.php)

* French translation. (index.french.php)

@ One commit left to get our 300 for the quarter... :P I'm off for now.
Title: Re: New revs
Post by: Arantor on March 31st, 2012, 08:06 PM
(2 files, 665 bytes, that's what it told me anyway)

Revision: 1531
Author: arantor
Date: 31 March 2012 19:03:12
Message:
! Sync internal BB implementation to BB 2.2.2's ruleset (the ones we're actually using, anyway) (Security.php)
! Fix, hopefully once and for all, CIDR matching system. (Subs.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php

@This should fix latent issues we've had with MSN being blocked. Note that the code does accept IPv6 CIDR blocks, but won't accept subnets larger than 64 bits for matching purposes, which is how IPv6 is structured anyway, so something like ::ffff:0:0:0:0/96 won't work for matching (but it's not supposed to as far as I understand it, even though /128 is valid you'd never use it where CIDR matching occurs)
Title: Re: New revs
Post by: Nao on April 2nd, 2012, 05:13 PM
rev 1532
(3 files, 4kb)

! The auto tag splitter was broken. Again, oops. (post.js)

! Fixed the indenazi generator. Although it's technically okay to do auto-indenting in most places, some tags will behave differently like 'pre' and 'textarea'. So I decided to go for a preg_replace instead of a str_replace (thankfully it's barely twice slower, which means it's still ultra-fast), and making sure that only lines starting with a tag are indented. It may not help with pre, but it'll help with textarea. (Subs-Template.php)

* Saved about 350 gzipped bytes for guest page loads by optimizing the sha1 file. It has an awful lot of code that never gets used anywhere, mostly the base64 and string encoding functions. Also optimized some of it, while I was at it... (sha1.js)
Title: Re: New revs
Post by: Nao on April 2nd, 2012, 09:18 PM
rev 1533
(4 files, 3kb)

* There's probably a more efficient way to do it, but I rewrote the CSS variable parser to allow for the use of other variables in $alphamix, rather than a hardcoded color. It's also faster than the previous implementation, as it now does a single str_replace on the entire file, instead of at least two. (Class-CSS.php, index.css, Warm/index.css)

! The "View Results" button was still showing even if in viewresults mode (i.e. haven't voted yet, but clicked that button.) (Display.php)
Title: Re: New revs
Post by: Nao on April 3rd, 2012, 01:07 PM
rev 1534
(3 files -2, 2kb)

* Replaced grad40.png with a proper CSS gradient, as it's easy to make it compatible with IE. (grad40.png, grad40i.png, Wine/index.css)

! Fixed a small issue with plainbox classes. (index.css)

! Fixed hardcoded RSS URL. (Home.template.php)
Title: Re: New revs
Post by: Nao on April 3rd, 2012, 02:53 PM
rev 1535
(2 files, 1kb)

! Fixed new thoughts being created instead of old thoughts being edited when a moderator wanted to edit someone else's thoughts. (Ajax.php)

! Fixed current board not being shown disabled in Move Topic list (in fact, it wasn't shown at all). Note to SMF devs: there's a bug either way. The source file generates a list of boards without the current one, and the template file shows boards, including the current one in disabled state. I'd recommend doing it like I did -- it's best to have the current board in the list, in case the user wants to move the topic to a sub-board. (MoveTopic.php)
Title: Re: New revs
Post by: Nao on April 3rd, 2012, 10:45 PM
rev 1536
(3 files, 1kb)

* Minor optimizations to timeformat(). Most notably, logic dictates that the setlocale code block should only be executed when lang_capitalize_dates is set, because otherwise the 'tokens' are converted in the final strftime() anyway. This seems to make my call to timeformat() about twice faster overall. My guess is that the SMF team didn't realize that because the English version always goes through the loop anyway. (Subs.php)

+ Added yet another exception to the 404 error list. Any files starting with /Themes/default/images/ are probably remainders of an SMF install called by Google Cache or equivalent, and should be ignored. (QueryString.php)

! If a button's class is set but empty, a useless space will be added at the end of the class list... (index.template.php)
Title: Re: New revs
Post by: Nao on April 4th, 2012, 05:58 PM
rev 1537
(10 files -1, 5kb)

* Downloading or viewing files stored in Aeva Media would either be very quick (static thumbnails) or as slow as it could be (full site + media area loading). Ensured that Wedge/AeMe never load more than necessary, i.e. skip loading the menu items. (Aeva-Gallery.php)

+ Added a canonical URL to the main media areas: homepage, album page and item page. (Aeva-Gallery.php)

- Removed 'About' section from Aeva Media. The default landing page is now the settings page. (Admin.php, Aeva-Gallery.php, Aeva-ModCP.php, ManageMedia.php, about.png, Admin.language.php, ManageMedia.language.php, ManageMedia.template.php)

! Some media admin areas still used we:title instead of we:cat. (ManageMedia.template.php)

! Fixed an oversight that broke Today/Yesterday. (Subs.php)
Title: Re: New revs
Post by: Nao on April 5th, 2012, 12:32 PM
rev 1538
(4 files, 5kb)

! If the user chose to view PMs as conversations, their outbox would keep showing conversations instead of filtering their sent messages. (PersonalMessage.php)

! Fixed an odd undefined index in PMs, although I don't really know what could have caused it... (PersonalMessage.php)

! Harmonized help popups when opened as actual windows -- they were unreadable at this point. (Help.template.php)

* Simplifying is not always for the best. (PersonalMessage.french.php)

- A lone windowbg declaration. (Profile.template.php)
Title: Re: New revs
Post by: Nao on April 5th, 2012, 06:08 PM
rev 1539
(3 files, 33kb -- really not that much work.)

* Increased opening speed of action/user menus. They look good, sure, but that shouldn't be at the cost of usability. Found a better compromise. (topic.js)

* Considering how using prototypes isn't too great for optimizing bytesize, re-ordered the JS weEditor object to be a single function. I can't rename everything to local variables because plugins may want to use some functions, or access some properties. I'll try to keep optimizing, so this is a work in progress. About 200 gzipped bytes saved for now. (editor.js, Class-Editor.php)
Title: Re: New revs
Post by: Arantor on April 6th, 2012, 01:39 AM
(2 files, 2KB)

Revision: 1540
Author: arantor
Date: 06 April 2012 00:38:49
Message:
! If the user's password is too short when changing it from the profile area, do actually insert the minimum number of characters into the error. (Profile-Modify.php)

! Various IPv6 related fixes in the IP tracking area of the user profile. (Profile-View.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Title: Re: New revs
Post by: Arantor on April 6th, 2012, 03:49 PM
(1 file, 4KB)

Revision: 1541
Author: arantor
Date: 06 April 2012 14:48:55
Message:
! Merging posts should also merge their likes. (SplitTopics.php)
----
Modified : /trunk/Sources/SplitTopics.php
Title: Re: New revs
Post by: Nao on April 6th, 2012, 04:06 PM
rev 1542
(3 files, 8kb)

* Moved Spellcheck button before the Draft button. (Class-Editor.php)

* Optimized editor code even more. Removed the aEventWrappers array (the only thing it brings is 'this' harmonization. Just use 'that' in your events to target the JavaScript object, and 'this' to target the HTML object.) Turned a few public functions private (assuming that plugins won't want to use them), removed this.opt (it's not used outside of editor.js really), fixed a bug when RTF isn't possible, the usual stuff. Saved about 260 extra bytes... (editor.js)

! Fixed font size in WYSIWYG mode. (editor.css)
Title: Re: New revs
Post by: Nao on April 6th, 2012, 06:37 PM
rev 1543
(4 files, 6kb)

! Fixed spellchecker. To do this, I moved the main JavaScript file list building to a function of its own, weInitJS (seriously, feel free to rename it to something that looks like a standard...) This is because this code is skipped when the index template isn't loaded, which shouldn't ALWAYS happen -- e.g. the spellchecker. (Load.php, Post.template.php)

! Also fixed the 'Play again' link in Captcha, while I was at it. (Register.template.php)

* More editor size optimizations. Saved about 30 bytes or so by moving onComplete calls to their matching sendXMLDocument. (editor.js)
Title: Re: New revs
Post by: Arantor on April 6th, 2012, 08:43 PM
(1 file, 2KB)

Revision: 1544
Author: arantor
Date: 06 April 2012 19:42:53
Message:
! Log BB hits even for admins. Also make the POST logging slightly more sane in the process. (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Arantor on April 6th, 2012, 10:36 PM
(2 files, 1KB)

Revision: 1545
Author: arantor
Date: 06 April 2012 21:35:52
Message:
! Use the definitive Host header instead of any we may have manipulated. Should fix spurious errors with splitting topics and BB external form tests. (QueryString.php, Security.php)
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on April 7th, 2012, 11:59 PM
rev 1546
(3 files, 5kb) (yeah, definitely not my most impressive commit... For people who don't care about bytesize :P)

* Saved another 300 gzipped bytes, this time in topic.js, by doing a quasi-complete rewrite of InTopicModeration() (which also fixes a few minor issues). The Display template should also be slightly lighter. Hey, a saved byte is a byte saved. Or the other way around. (Display.template.php, topic.js)

* Spacinazi. (ManageErrors.php)
Title: Re: New revs
Post by: Nao on April 10th, 2012, 10:43 AM
rev 1547
(1 file, 3kb) (very old DB changes that I kept postponing...)

! Fixed spoiler tag adding extra double quotes on double-quoted strings. For instance, if you want to add a custom string in your Spoiler button, use [spoiler="Hello world"] (or just [spoiler=foobar] if there are no spaces), but this would generate extra double quotes in the final HTML. (install.sql)

! Added white-space trimming around quotes. Have yet to determine whether this actually works though... It's not like in the Noisen codebase where I was doing it manually with a couple of regexes, ah ah. (Why am I laughing?) (install.sql)

* Added a few new default settings: disable_rss (0) (media area should show feed links by default), and for other areas: max_urlLength (50) (any URLs longer than 50 chars should be cut off), and display_who_viewing (2) (Wedge should show user names viewing a topic by default since it's already shown in the stats area). (install.sql)

* Harmonized value insertion queries. (install.sql)
Title: Re: New revs
Post by: Nao on April 14th, 2012, 12:22 AM
rev 1548 (Too many things to finish before I can commit them...)
(5 files, 3kb)

+ Added a custom time format string, "%@", which you may use to add something after the day number, e.g. "31st", "3rd", etc, and using it by default in English and French. Used a custom array in $txt, translators should set $txt['day_suffix'] to array('n' => '%d') if they have no specific suffixes to add for their language. (Load.php, Subs.php, index.language.php)

! Fixed board ordering in category pages. (Subs-BoardIndex.php)
Title: Re: New revs
Post by: Nao on April 16th, 2012, 02:45 PM
rev 1549
(4 files, 4kb) (forgot to report it, did it this morning actually...)

+ Added enableError404Logging option (disabled by default), to determine whether the admin really wants to log all Error 404 messages. Probably needs some kind of help text but I'm not even sure my English for the option itself is proper... (ManageSettings.php, ManageSettings.language.php, QueryString.php)

* Some minor optimizations, and starter code for /board/do/action support (will still work as always in the current SVN, it just needs some extra code from the PURL filters which I can't commit until I'm done with the tons of things I've been working on this week... -_-) (QueryString.php)
Title: Re: New revs
Post by: Nao on April 16th, 2012, 07:53 PM
rev 1550
(7 files, 7kb -- and PLENTY of potential bugs for you guys to find :P)

* Extensively rewrote Pretty URLs to be easier to tweak (not that you can actually easily add new keywords to transform right now, but it will come...) Basically, you no longer need to provide two pattern strings, the search pattern will be reused for replacements as well. The regex is easier to grasp (even though it uses a lookahead assertion... Learn to love it.) There are WAY too many changes to document them all, just trust me that overall my optimizations made the entire process about twice faster. Your server will thank you (and me) for that. Hopefully didn't break any of the patterns with my rewrite. (Subs-Template.php, Subs.php, PrettyUrls-Filters.php, Ajax.php, Feed.php, Aeva-Foxy.php)

* A few speed optimizations for the topic filter, and general optimizations based on the use of references. I know, one is not supposed to use references for optimizations... Except when it makes it three times faster, right? (PrettyUrls-Filters.php)

* Moved session ID injection code a bit further down the output buffer rewriter, to catch as many URLs as possible. Untested. (Subs-Template.php)

* Moved category URL replacement to the board filter, rather than the action filter -- makes more sense. (PrettyUrls-Filters.php)

+ Added support for /do/action even inside a topic or board. (PrettyUrls-Filters.php)

! Feeds were sending session IDs to feed fetchers. Baaaaad! (Feed.php, Subs-Template.php)

! Last-minute typo in error 404 logging... A classic of mine. (QueryString.php)
Title: Re: New revs
Post by: Nao on April 19th, 2012, 08:26 PM
rev 1551
(5 files, 5kb)

! Split timezones into continent optgroups in the admin area. Added Africa back into the list... I've seen countless PHP samples about timezones, and over half of them forget Africa as well. Innnn...teresting. (ManageServer.php)

- Removed a hack that was no longer needed after my changes to the pretty URL system. (Display.php)

+ Added support for optgroups in admin-generated select boxes. (Admin.template.php)

* Rewrote the split topics feature to accept a topic parameter (instead of 'from'), so that we can prettify it alongside the other moderator links in topic pages. (Display.php, SplitTopics.php)

! Fixed maximum length for user titles. (Profile-Modify.php)

+ Added a Europe/Paris timezone in user profiles. Hey, what did you expect from me? (Profile-Modify.php)
Title: Re: New revs
Post by: Nao on April 19th, 2012, 08:28 PM
rev 1552
(4 files, 5kb)

* A tiny fix for French. Note to self and Pete: seriously, 30+KB is too large for the index language... It should only hold the most commonly used text strings, and certainly not things like a merge topic feature description... If anything, index.english.php should be short and easy to translate, so that we can have obscure translations that deal with at least the most common strings. (index.french.php)

- Removed script remover from pretty URL code -- as far as I know, it's no longer needed. Note to self: if anyone finds a bug related to this, just revert this revision of the file... :) (Subs-Template.php)

+ Added support for 'admin' and 'mod' suffixes in CSS files. For instance, index.admin.css is loaded on all pages for admins (as opposed to 'admin.css' which is loaded on admin pages for everyone). I'm sure it'll end up being useful at some point... (Load.php)

+ Added support for the 'local' suffix in CSS files (index.local.css is basically index.custom.css but it won't be included if a sub-skin is selected.) (Subs-Cache.php)

! Fixed cache hash support for slashes (/), and did some micro-tweaking to save a few cycles... I'm desperate for cycles. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on April 20th, 2012, 12:08 AM
rev 1553
(1 file, 2kb)

! Fixed broken page index system in topic merging. I'm not exactly sure why having a board ID in the URL automatically brings out the message index instead of the action page... We should look into this, but this fix is rather elegant anyway. (SplitTopics.php)

! Fixed incorrect topic count calculation in page index system... yeah, in topic merging, how did you guess? This is probably a SMF bug: the count also takes the current topic into account, even though it's never shown in the list, resulting in an empty last page in one case out of 15. (SplitTopics.php)
Title: Re: New revs
Post by: Arantor on April 20th, 2012, 04:35 PM
(5 files, 6KB)

Revision: 1554
Author: arantor
Date: 20 April 2012 15:34:33
Message:
! When viewing a category on its own, don't collapse it if it would be collapsed on the board index. (Subs-BoardIndex.php)

! Add 'the number of links in a post' as a moderation filters criteria, meaning you can moderate or refuse a post based on links in it (e.g. moderate if links is 1 or more and user has under 10 posts) (ManageModeration.php, Subs-Moderation.php, ManageModeration.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Title: Re: New revs
Post by: Arantor on April 20th, 2012, 09:59 PM
(6 modified, 2 added, 11KB)

Revision: 1555
Author: arantor
Date: 20 April 2012 20:58:49
Message:
! Moving some strings out of the main index file. (MoveTopic.php, SplitTopics.php, index and ManageTopics language files)
! Making one string out of two hybrids. (SSI.php, Boards.template.php, index language file)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Themes/default/Boards.template.php
Added : /trunk/Themes/default/languages/ManageTopics.english.php
Added : /trunk/Themes/default/languages/ManageTopics.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Nao on April 21st, 2012, 09:26 PM
rev 1556
(21 files, 12kb) (hopefully I didn't break anything...)

* Translation. (ManageSettings.french.php)

* Continued moving barely used strings from index to satellite language files, and removed outdated or deprecated entries such as 'message_lowercase' or 'search_end_results'. I'm surprised that 'no_matches' doesn't seem to be used anywhere though...! (Reminder.php, Subs-Auth.php, LANGUAGES: Admin, index, Login, ManageTopics, Profile)

* Made media permissions help text into a proper popup. (ManageMedia.template.php, LANGUAGES: Media, Help)

+ Added micro-documentation for the new %@ time format. (Help.language.php)

* French version doesn't use periods at the end of post options, so removed it from a couple of entries. Maybe this should be done for English too...? (Post.french.php)

- Removed a colon and a line-break that bothered me. (ManageMedia.php, Profile.template.php)
Title: Re: New revs
Post by: Nao on April 23rd, 2012, 02:14 PM
rev 1557
(26 files, 38kb) (huge commit... Hopefully everything still works. I'll keep an eye on the error log...)

* Moved more index language strings to satellite files. More to come later but I think the bulk is done. Original size was 33.6KB, current size if 27.3KB... Not bad, because this makes it more enticing for translators to start a 'basic' translation of Wedge by doing just the index file. Note that most debug strings are now a single long string (a tad slower to manage but should save time for non-admins.) (Class-DB.php, MoveTopic.php, Register.php, Report.php, SendTopic.php, Subs-Post.php, Subs-Template.php, SSI.php, LANGUAGES: Errors, index, Login, ManageTopics, Post, Profile)

* Rewrote loadLanguage to load an array of language files, rather than an exploded string of filenames, effectively harmonizing it with loadSource etc. (Admin.php, ManageErrors.php, ManagePermissions.php, Report.php, Subs-Post.php)

! Fixed loadLanguage not properly caching some files when some are loaded in batches. (Load.php)

! Fixed buffer hooks not executing. (Thanks live627!) (Subs-Template.php)

* Number of downloads/views per attachment is now a context number. (Display.template.php, index.language.php)

* Clean-up à la Nao. (SplitTopics.template.php)
Title: Re: New revs
Post by: Nao on April 23rd, 2012, 03:43 PM
rev 1558
(20 files, 14kb) (I think I'm done with most of my language overhaul...)

* More index language string moves. (ManageNews.php, LANGUAGES: index, Login, ManageTopics, Post)

* Rewrote number_context to use an array. This should make it easier for foreign languages to get rid of the English files' legacy. See 'day_suffix' and 'attach_downloaded' in index.french.php for smooth examples. (Load.php, Subs.php, LANGUAGES: index, ManageTopics, PersonalMessage, Profile, Themes, Who)

* Harmonized all number-context strings to use %s instead of %d or %1$d or whatever. The logic is that (1) this system is complicated as it is, no need to use numbered replacements when the system only supports one replacement per string anyway, (2) %d won't do because of potential comma formatting. I'd rather we use a standard here. (LANGUAGES: index, PersonalMessage, Profile, Themes)

* Disambiguated $txt['status']. (Memberlist.php, Profile.template.php, index.language.php)
Title: Re: New revs
Post by: Nao on April 23rd, 2012, 03:48 PM
rev 1559
(4 files, 2kb)

* Forgot to hit F5 and refresh my list of updated files... Hmm. Another classic of mine. All of these files are related to the number_context() changes. (Subs.php, Boards.template.php, Display.template.php, MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on April 23rd, 2012, 04:17 PM
rev 1560
(3 files, 2kb)

! Fixed attach_downloaded being parsed with the actual string rather than the $txt index. Maybe I should allow for a string to be sent directly, though...? It's just an extra isset()... (Display.template.php)

! Fixed autolinking triggering itself a bit too happily in non-quick-edit mode... Should I reuse the exact same code as in parse_bbc()? (Aeva-Embed.php)

! Applied SMF 2.1 fix 8d54b5b by Spuds for cleanXml (PCRE v8.3 no longer accepting range D800-DFFF in regexes.) I never look into their fixes but when it comes to regex I must have a radar of sorts... (Subs.php)
Title: Re: New revs
Post by: Nao on April 24th, 2012, 07:35 PM
rev 1561
(5 files, 14kb)

* Rewrote quick message icon modification popup. The gzipped code for this object is now only 321 bytes, as opposed to the original ~1100. This also saves over 20% off the total gzipped filesize of topic.js. All of the CSS is now moved to the skin, as it should have been from the start. Also optimized MiniMenu (turned it into a single object as well), and a few other objects. (Display.template.php, Xml.template.php, sections.css, topic.js)

- Wedge will no longer mark a post as 'modified' if the user only changes its icon. That field should be there to notify users something important may have changed -- and an icon isn't that important. (JSModify.php)

@ Note: icon box's hover site has issues compared to earlier version (I'll fix it if I don't forget), and I removed the timer that removed the popup if hovering out for a while -- mainly for accessibility reasons, as it's not exactly a very wide popup to begin with...
Title: Re: New revs
Post by: Nao on April 25th, 2012, 06:08 PM
rev 1562
(3 files, 2kb)

+ Added support for user-defined JavaScript files. I thought very hard for an original name, and came up with 'custom.js'. What do you think? Anyway, it's easier to create that file manually than adding a plugin to add a custom JS file to the main one... If you know what I mean. (Load.php, Subs-Cache.php)

- Removing 'sbox', 'custom' and 'theme' from the main JS file's cached filename. How 'bout saving a few bytes off every page, eh..? (Subs-Cache.php)

* Saved another 42 bytes off the gzipped topic script by getting rid of its prototypes. It may be controversial because the benefits aren't huge and the drawbacks are potentially bigger, so I may have to revert this in the future, but if no issues arise, why not save the space..? (topic.js)

! Fixed a bug in QuickReply where it was considering bUsingWysiwyg as part of the object, rather than its options. (topic.js)

! Fixed right positioning of mini-menus. (topic.js)
Title: Re: New revs
Post by: Arantor on April 25th, 2012, 11:52 PM
(4 files, 5KB)

Revision: 1563
Author: arantor
Date: 25 April 2012 22:52:06
Message:
! When moving a topic between boards, you can now also opt to send the topic starter a PM. It's not a particularly nice boilerplate wording but I haven't got anything better. It does also use a slight variation on the moved notice, in that it actually injects a link to the topic with the subject in it, rather than injecting the bare URL. (Currently uses an iurl as per the moved topic notice, but that's easily changeable.) (MoveTopic.php, MoveTopic.template.php, Errors and ManageTopics language files)
----
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Title: Re: New revs
Post by: Nao on April 26th, 2012, 04:09 PM
rev 1564
(5 files, 7kb)

! Fixed a last-minute warning message that showed up when not providing a custom.js file. I'd tested for this, but incorrectly it would seem... (Subs-Cache.php)

* Rewrote the topic title changer (in message index) to be entirely contained in topic.js (this saves us the extra JavaScript at the end of the HTML, as well as the onmouseout/onmouseover events.) Somehow, even adding more code resulted in saving 31 more bytes off the gzipped size... Yeah, I'm like that. (MessageIndex.template.php)

* Fixed the dollar fix. SMF bug, somehow: the comment says it's for IE compatibility, when it really happens on all browsers, because $ is a meta-character when used in the replacement string in a .replace() call. The solution is to simply convert it (once) to $$$$ (or just $$$, but it's close to a hack and doesn't save any gzipped space), and not bother with converting it back. Basically: a bug fix is good when it makes sense. This one didn't and I got stumped for months because I kept researching IE bug lists instead of JS regex flavors. (topic.js)

* Translation. (Errors.french.php, ManageTopics.french.php)
Title: Re: New revs
Post by: Arantor on April 27th, 2012, 06:49 PM
(5 files, 2KB)

Revision: 1565
Author: arantor
Date: 27 April 2012 17:48:31
Message:
! No need to check for GD when doing certain types of image work. (Subs-Graphics.php)

! Auto-removed topics do not need to go to recycling. (Subs-Scheduled.php)

! Minor formatting bug with a line break not being added when it should. (MoveTopic.template.php)

! Admin registration of users should notify the user of the relevant URL as well. (EmailTemplates.english.php)

! Drafts code made an assumption about the URL that wouldn't be true with latest PURLs code. (post.js)
----
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/scripts/post.js
Title: Re: New revs
Post by: Arantor on April 27th, 2012, 10:12 PM
(5 files, 14KB)

Revision: 1566
Author: arantor
Date: 27 April 2012 21:10:10
Message:
! Convert file cache to use file_put_contents instead of fwrite. It's something I meant to do ages ago but forgot about, but it should solve the cases where the file was only being partially written to the 8KB boundary. (SMF have also implemented it, though we both did it independently, I think) (Subs-Cache.php)

! There's now a timezone selector on the registration page too. It isn't pretty, it does no magic detection of timezone so it defaults to American Samoa time but at least we're on the way to solving things. Also, the bug in the profile page should be fixed where it was showing the wrong saved value. (Profile-Modify.php, Register.php, Register.template.php, Login language file)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Login.english.php

@ To answer the point about the file cache, the reason it was breaking at the 8KB boundary is because of the way fwrite caps at 8KB under certain circumstances but it isn't a problem because it's rare that more than 8KB is cached at once. However, we can use file_put_contents instead these days which is a bit faster and has no such issues.
Title: Re: New revs
Post by: Arantor on April 28th, 2012, 01:26 AM
(2 files, 1KB)

Revision: 1567
Author: arantor
Date: 28 April 2012 00:25:04
Message:
! Made the blog board template less rubbish. It still needs a lot of work but it's definitely an improvement IMO on what was there before. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php


Nao, please feel free to abuse this commit however you see it, it was just bugging me how the blog layout needed work.
Title: Re: New revs
Post by: Nao on April 28th, 2012, 12:12 PM
rev 1568
(22 files -1, 11kb) (bit in a hurry, hope I didn't screw up anything...)

* Tweaked mini-menu code to make the resulting HTML shorter and avoid outputting empty strings. Note for later: array_map() is super-slow, especially compared to foreach. (Display.php, topic.js)

* Renamed we_prepareScriptUrl to weUrl because I added support for more than just dealing with we_script ($scripturl), and optimized the function (a bit). Also removed aeva_prepareScriptUrl which was unused (probably a SMF1 compatibility leftover.) (index.template.php, Packages.template.php, Post.template.php, SplitTopics.template.php, Themes.template.php, editor.js, mediadmin.js, post.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js)

* I think that periods should be in language files, rather than in the template. Better support for exotic languages... (MoveTopic.template.php, ManageTopics.language.php)

* Removed AeMe feed icon and replaced it with the default one. (images/aeva/feed.png, Media.template.php)

* Saved a few bytes off the ajaxRating function, the wedgeAttachSelect object, the editor object, and various other JS areas. (Media.template.php, script.js, post.js, editor.js)

* Translation. (EmailTemplates.french.php, Login.french.php)

* Commenazi. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on April 29th, 2012, 12:39 AM
rev 1569
(4 files, 3kb)

! Fixed attachment handler not correctly disabling/re-enabling the file input after going over or below the maximum file limit. (post.js)

+ Added slide animations to adding and deleting attachment files in the post page. This adds 20 bytes of code but I saved over 50 with some optimizations in the same time... (post.js)

* Saving a few bytes, again... (editor.js)

* I don't like redeclaring a local var... Will need to move all that code to a JS file later anyway. (Post.template.php)

* Aligning icons vertically in blog posts. (MessageIndex.template.php)
Title: Re: New revs
Post by: Arantor on April 29th, 2012, 03:22 PM
(1 file, 1KB)

Revision: 1570
Author: arantor
Date: 29 April 2012 14:21:45
Message:
! Board position selectboxes were not updated properly. (ManageBoards.template.php)
----
Modified : /trunk/Themes/default/ManageBoards.template.php

(Would have done more but have chores to go do instead)
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 12:42 PM
rev 1571 (a huge scary commit... Even I have trouble navigating it >_< needs extra care from volunteer reviewers whom I'll love forever.)
(18 files -1, 18kb)

+ Added a new option to allow add_js_file() and add_css_file() to ignore some filenames when they build the actual filename for a cached file. In typical Nao fashion, the CSS version is totally untested and was written right... now. (Class-Editor.php, Load.php, Subs-Cache.php)

+ Added a .wereplace() custom function for Wedge JS. It behaves similarly to .easyReplace() in the editor, but is now in the main script file, and used in a few more places. (Subs-Post.php, Welcome.template.php, editor-func.js, script.js, suggest.js, topic.js)

! Fixed tag splitter (was broken after my recent rewrites.)  (Class-Editor.php, editor-func.js)

! Fixed 'local' suffix for CSS files -- it was internally considered as a main file name, instead of a potential suffix. Also added a 'global' suffix if you need to differentiate between the two, although basically, every single suffix will apply globally without the need to resort to using this one. (Load.php)

! Fixed bug in calling previewPost. Although I still don't know the point of having this check for the CTRL key... Anyone tried it? For me it 'simply' creates a new tab with the preview... Odd. (Post.php)

! Finally took time to just tell Wedge to shut up if a menu tab doesn't provide a description. (GenericMenu.template.php)

- Got rid of add_params for menus. Anyone ever used these...? (PostModeration.php, GenericMenu.template.php)

* Replaced the login time hack with a cleaner and more accurate session variable for determining the desired position of our script files in the HTML source. (index.template.php)

* Renamed post.js to editor-func.js (editor-related helper functions), and ignoring editor-func filename. (Class-Editor.php, editor-func.js, post.js)

@ Temp: renamed whatever remained of post.js to postpage.js, will rename it back in the next commit. (Class-Editor.php, post.js, postpage.js)

* Moved 99% of the Post template's inline JavaScript to the postpage.js file. And it still works. Polls need some polish. (Post.template.php, postpage.js)

* More size optimizations, some being even more logical than the original code, my favorites really. (editor.js, pm.js, script.js, spellcheck.js, suggest.js, topic.js)

* Commenazi, spacinazi. (QueryString.php, admin.js)
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 12:45 PM
rev 1572
(10 files, 16kb)

* A larger logical rewrite of AeMe. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Subs-Media.php, (GenericMenu.template.php), ManageMedia.template.php, Media.template.php, Media.language.php, mediadmin.js)

  . Category headers now use page titles (this should help with readability and, basically, common sense.)
  . $txt['media_album'] was probably unclear for i18n so I added $txt['media_album_is'] which is sprintf'd into a proper line.
  . A cache key for embedded media items could be too long and was shortened to two md5 hashes.
  . Fixed plenty of template glitches, such as showing the Mass Download button on empty albums, duh...
  . Some problems with the urlmore variable missing an extra semicolon.
  . Rewrote media admin toggler to fix it and add a nice little animation.
  . Added template_show_generic_tabs function to make them into *actual* generic tabs...
  . Spacinazi fiesta... Really.
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 01:04 PM
rev 1573
(4 files +1, 12kb)

+ Mobile mode will now hide some more areas in board/message index, such as topic stats. (Boards.template.php, MessageIndex.template.php)

+ Forgot to actually commit postpage... Well, now it's renamed back to post.js. (Class-Editor.php, post.js)

* Spacinazi. (stats.js)
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 05:01 PM
rev 1574
(3 files, 2kb)

! SMF bug: in signatures, only the first line-break was excluded from length calculation. These regexes were missing a global modifier... (Profile.template.php)

+ Implemented scrollbar for touch devices (iPhone etc), as written by Dragooon. It's a bit slow, but at least it works. (sbox.js)

* Optimized sha1.js for size. Some very weird changes allowed for an extra 50+ byte shrinking of the gzipped file. (sha1.js)
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 05:32 PM
rev 1575
(5 files +2, 28kb) (not as scary as it sounds, though...)

+ (Finally) committing my support for mobile mode. It's quite basic, in that it shouldn't be too complicated to understand or handle. Users visiting from a smartphone or whatever will get a separate default skin setting which can be set by the admin, and they themselves can change that skin to a non-mobile one in case they'd rather have a full experience. The skin is set per-session, meaning that you can navigate your forum with your desktop and mobile browsers at the same time with the same account, and two different skins. (install.sql, Class-MoDe.php, Load.php, Themes.php, Themes.language.php)

+ Added sha1.js v2.2 to the attic. This is the 'newer' 2009 version, but it compresses to 200+ bytes worse than the current one, and doesn't add anything to the original
implementation that needed to be fixed. (other/attic/sha1_2.2.js)

@ Need to implement: the 'pick' area of the skin selector will only set the default skin for your own current mode (mobile or desktop). Need to either make that clear, or add a variable to allow setting either of those... Any volunteers to share their preference or just implement the few lines needed to do that? :P
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 06:50 PM
rev 1576
(4 files, 5kb)

* As seen on wedge.org, Admin and PM top-level warnings will now be in red (.warn) and other warnings will be in orange (.note). (index.template.php, index.css)

* More CSS updates. Also removing Droid Sans from Warm. (index.css, Warm/skin.xml)

+ Forgot to commit the Themes template changes for mobile mode. (Themes.template.php)
Title: Re: New revs
Post by: Nao on May 2nd, 2012, 07:05 PM
rev 1577
(9 files, 4kb) -- a quick rename.

* Renamed the topicseen variable/query string to just 'seen'. There is another variable, boardseen, which is not as often used, and I don't think it's worth specifying the 'topic' is seen in the variable name... (Display.php, MessageIndex.php, QuickMod.php, Subs-Boards.php, Subs-Post.php, Unread.php, UnreadReplies.php, SSI.php, Search.template.php)
Title: Re: New revs
Post by: Nao on May 3rd, 2012, 12:43 PM
And yet another big commit...

rev 1578
(23 files +1-1, 10kb)

! First item in action/user menus would never show up. (topic.js)

* Got rid of $txt['on'] and $txt['search_on'], which were both confusing and used incorrectly. Replaced everything with $txt['on_date']. Renamed a few 'time' variables to 'on_time' to reflect the actual contents, need to finish them all. (Admin.php, Display.php, MessageIndex.php, ModerationCenter.php, PersonalMessage.php, Post.php, PostModeration.php, PrintPage.php, Profile-View.php, TEMPLATES: Display, MessageIndex, ModerationCenter, PersonalMessage, Post, PrintPage, Profile, Xml, LANGUAGES: index)

+ Clearly mark one's own PMs with a 'self' class in PM conversation mode. (PersonalMessage.template.php)

* Renamed Printpage template to PrintPage (see Sources). (PrintPage.php, PrintPage.template.php, other/xml/detailed-version.php)

* Spacinazi. (PostModeration.php)

* Some updates and fixes to the mini-menu code (that were already on wedge.org but not in the SVN.) (Display.template.php)

! Forgot to move a language string from index to Login. (Login.english.php)

! Profile drafts were showing the 'on' twice in 'on_date'. (Profile.template.php)

! showDrafts function was called viewDrafts, as opposed to what the file header said (and what convention implied.) (Profile.php, Profile-View.php)

* Moved the post page's dynamic new post template back into the post template, I don't know why, but I did that. Am I in trouble? (Post.template.php, post.js)
Title: Re: New revs
Post by: Nao on May 6th, 2012, 01:34 AM
rev 1579
(11 files, 6kb)

! AeMe caching for external embedded images was failing. (Aeva-Gallery.php)

- Got rid of unneeded code in the search results, and cleaned up the area a bit. (Search2.php, Xml.template.php)

* More 'time' to 'on_time' renames. Hopefully the last ones... Will probably generate warnings if you install from SVN, because it's missing some other files I'm still working on. I'm mostly committing whatever doesn't conflict with other work with progress. (Post.php, Profile-View.php, Recent.php, Search2.php, Subs-BoardIndex.php, Boards.template.php, InfoCenter.template.php, Profile.template.php, Search.template.php)
Title: Re: New revs
Post by: Nao on May 13th, 2012, 01:18 PM
rev 1580
(14 files, 6kb) -- some of the 'easy' commits I can do separately from the BIG ones... Phew...

! IE 6-8 doesn't like addEventListener, so I moved some data around (and, as always, saved a few bytes in the process.) (sbox.js)

- Rewrote help popup to no longer turn %1$s into $scripturl -- just use <URL> per our standards, or %2$s into the session var -- it works fine without that and wasn't used anywhere. (Help.php, Help.language.php)

! Fixed Aeva bug where embedding would spectacularly fail when at least two videos are embedded in a sentence and Embed in Sentences is disabled. (Aeva-Embed.php)

! Fixed Vimeo embeds to use their new iframe code. (Subs-Aeva-Sites.php)

! Fixed Merge Topics feature failing when selecting another target board (due to a recent rewrite.) (SplitTopics.php, SplitTopics.template.php)

* The error log shouldn't show table headers and error filters if there are no errors to show in the first place... (Errors.template.php)

* Fixed some typos were 'dependant' was use (it's the French spelling, not the English one, at least not for that meaning... I'm counting on everyone to make sure my changes are for the best :)) (ManageNews.php, MangePermissions.php, Modlog.php, SplitTopics.php, Help.english.php, ManagePaid.english.php, PersonalMessage.english.php)
Title: Re: New revs
Post by: Nao on May 13th, 2012, 05:14 PM
rev 1581
(20 files, 30kb -- and THAT's my big commit... Phew! Some files I could have committed separately, but don't push me too far please...)

* Rewrote mini-menus nearly from scratch. The JS code is now nearly twice shorter, and this saves 230+ bytes off the gzipped topic.js file (1200+ bytes uncompressed). It also fixes z-index issues on low-resolution displays, although as of now, it adds a new bug to iOS 4.x (maybe later as well), which I'll work on ASAP. (Display.template.php, topic.js, index.css, sections.css, index.ie6.css, index.ie7.css, sections.iphone.css, Warm/index.css)

* Rewrote large areas of the Display template as well. Most notably, the Action buttons and Likes saw many changes in both template and CSS... And it's still a work in progress. (Display.template.php, PersonalMessage.template.php, index.language.php, index.ie6.css, index.member.css, index.rtl.css, sections.css, index.ie6.css, index.ie7.css)

* Rewrote ignored posts to use shorter, sweeter and simpler markup. The footer gets a generic div around it to hide everything in one go, saving us the need to generate some id's for multiple divs that aren't used otherwise. I could have wrapped everything into the msg_xxx div, but I'm not sure it'd be for the best. Well, it's my "last-minute change" from this commit, so it may very well be breaking something else, and I'll make sure to fix it if this happens... Obviously. (Display.template.php, Post.template.php, index.member.css, index.language.php)

! Fixed ignored posts JavaScript (probably) not working in IE6 on Post pages. (Post.template.php, post.js)

+ Just FYI -- added a $main_font_size CSS variable to help you customize your starting font size in case the font's x-height is really incompatible with Arial. (index.css)

* Some stuff related to this commit or earlier ones (on_time notably), that needs to be applied here too. (MessageIndex.template.php, Post.template.php, Recent.template.php, Xml.template.php)

* Rewrote script.js to save over 50 bytes of data. Makes expandPages a tad slower, but it's still immediate even in IE6 with its lousy JS engine, so why bother? Removed selectText() which is an AeMe-only function (moved it to the Media template which I'll commit as soon as I'm done with its rewrite), etc. Also, the help pop-up feels a bit better now, but it's a matter of taste I guess. (script.js)

* My first use of the universal selector... *sob* I just wanted to say arrivederci to all of these LongWordsThatBreakYourLayoutBecauseYourUsersLikeToPlayWithYourMind. Forever. This won't work in Opera < 10.5, but Opera users are geeks, and they update their lot. (index.css, sections.css)

+ Added some clear visual reminder for your own PMs in Conversation mode. (index.member.css)

+ Added a notenice (will change name later) class to note/warn stuff, because it's not always a neutral or negative notice. (index.template.php, Display.template.php, index.css)

@ Note: it would seem that the main menu is currently buggy in IE8 -- menus pop up at the left, rather than below their parents. It works fine in IE6, IE7 and IE9 and I don't know how to look into this for now... Also, since I removed some of the 'display: table' hacks for topic posts, I need to hack into the hacks I hacked for IE6 to ignore the table hack. Hopefully I won't do a hack job of it...
Title: Re: New revs
Post by: Nao on May 14th, 2012, 10:06 AM
rev 1582
(17 files, 6kb)

* Renamed ul.quickbuttons to ul.actions -- shorter, and semantically it makes more sense as these were only used for action buttons anyway. Also harmonized all of the action buttons I could find, by adding an action bar where needed, and moving everything below the post bodies. Renamed quickbuttons.png to actions.png. The stuff in post.js is untested. (Display.template.php, PersonalMessage.template.php, Post.template.php, Search.template.php, post.js, index.ie6.css, index.ie7.css, index.member.css, index.rtl.css, Wireless/sections.css)

* #version_details didn't really need to be limited in height at this point... (admin.css)

- Removed a line-break from the admin login page, because there was already a hardcoded margin above the button... (Login.template.php)

! Fixed mini-menu CSS on Mobile Safari: forgot the z-index and ensured that user menus actually show up (although this one's a very odd bug and even weirder hack which I'm likely to reconsider later.) (sections.css, Warm/index.css, Wireless/sections.iphone.css)

@ Note: forgot to commit the actions.png rename... Please do it manually if you're updating to this rev, it'll be fixed in my next commit...
Title: Re: New revs
Post by: Arantor on May 16th, 2012, 04:29 AM
(3 files, 1KB)

Revision: 1583
Author: arantor
Date: 16 May 2012 03:28:51
Message:
! A variable doesn't suddenly change from being a string to a number... wrong variable perhaps? (Ajax.php)
! When liking or unliking something, send that information to a hook. (Like.php, ManagePlugins.php)
! When a thought is added, updated or deleted, send that to hooks. (Ajax.php, ManagePlugins.php)
----
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/ManagePlugins.php
Title: Re: New revs
Post by: Nao on May 17th, 2012, 10:56 PM
rev 1584
(14 files +1-1, 12kb)

* Turned mini-menu code into a jQuery plugin, so that templates can create them more easily. Also fixed aligment in various browsers, and made JS code shorter (about 50 bytes saved, or so.) (Display.template.php, topic.js, sections.css)

! Fixed user menus in iOS... At least iOS 4... If someone can tell me why the hell I had to use 'position: absolute' on the parent span, instead of 'position: relative' which works on all other browsers and even in iOS on action menus, then... Well, I'd be glad to hear from you. (index.iphone.css)

! Fixed main menus in IE8. Another epic fight which I've only half-won... Many problems were due to specifically setting opacity to 1 (jQuery will add an alpha filter even though it's unneeded, and this will cause layout issues), as well as #navi using an overflow: hidden to ensure the left-floated #main_menu was shown... Heck, I don't remember why I did that in the first place, when I could have done a clearfix (which, whatever you say, is less likely to cause problems), or... hem... removed the float. Which I did. I still don't know why I had to add a strange hack for menu margins in IE8, but don't ask too much of me... It's only IE. (index.css, index.ie8.css)

! Fixed Wireless in IE6, in case users wanna test-drive it... (Even though, if they're using IE6, it's probably because they're utterly incapable of test-driving anything else...) (Wireless/sections.css)

- Don't bother showing minutes or, in the worst cases, hours, in 'total time spent on this forum' statistics, depending on the number of days spent online. If you have 100+ days and counting, do you really care about minutes online? (Stats.php)

- Don't show the action bar if it's going to be empty anyway... (Display.template.php)

- Removed an extra br from the admin login template. (I think it's another thing I forgot from my earlier commit.) (Login.template.php)

- Removed my latest animation for popups. Didn't look good enough. Will try and use an animation similar to what I now have in mini-menus. (script.js)

+ Added a $post_font_size variable to make post font size (what else?) easier to customize... Whatever. (index.css)

* quickbuttons.png renamed to actions.png, as forgotten in the previous commit. (actions.png, quickbuttons.png)

* Most of the h6 (mini-header) occurrences were at the beginning of a block, so I removed the need to add a 'top' class, and only showing a top-margin if the tag has another one before it in the block. (ManagePlugins.php, script.js, Stats.template.php, Who.template.php)

* Translation. (index.french.php)
Title: Re: New revs
Post by: Nao on May 18th, 2012, 04:08 PM
rev 1585
(11 files +1, 13kb)

* Rewrote JS/CSS compilers to allow for plugins and themes to specify the list of filenames they'd like to ignore from the final filename. For instance, $context['javascript_files'][] = 'something' should now be $context['main_js_files']['something'] = true (or false to ignore). For consistency, renamed $context['javascript_files'] to 'main_js_files', 'remote_javascript_files' to 'remote_js_files' and 'css_main_files' to 'main_css_files'. (Load.php, Subs-Cache.php, Subs.php, index.template.php, Login.template.php)

+ Split we_avatarResize() into its own file, which is only loaded if the related feature is enabled. Which is unlikely, because it's not set by default, so why force everyone to load nearly 150 bytes for an unused function...? (avasize.js, script.js)

* Don't close the dropdown if a top-level menu item is clicked when it has no associated link, e.g. the profile menu. (script.js)

* A few size optimizations, and reorganized the thought object to allow for new thoughts to be associated with relevant action buttons. The rest will come later... (script.js)

* Renamed 'MiniMenu' plugin to 'mime', for consistency with .menu() and because everybody hates mimes and my number 2 goal in life is to annoy you. Also optimized both files for size. (Display.template.php, topic.js)

* Improved styling for the source code popup in the error log. (Errors.template.php)

* Moved the quick edit button by a few pixels to be on the same line as the rest as the action bar. (index.member.css)

- A leftover line of CSS... (sections.css)
Title: Re: New revs
Post by: Nao on May 19th, 2012, 05:22 PM
rev 1586
(2 files +1, 5kb)

* As usual, spending hours working on things that will only save a few bytes... That's me. I'll be here all week. Removed weCookie() which was only used once in the entire codebase, and replaced the call with a tighter, optimized regex. Rewrote some .css() calls to save another few bytes (this one is odd, but I tried all permutations, and the more normal ones can take up to 10 more gzipped bytes...) (script.js, attic/Unused-cookie.js)

* Made the poster area background a bit less obvious. I just wanted to tone it down... Sue me. (sections.css)
Title: Re: New revs
Post by: Nao on May 21st, 2012, 06:46 PM
rev 1587
(11 files, 19kb) -- hopefully didn't break anything, bit in a hurry... wedge.org is a bit broken though, will fix later.

* Rewrote and optimized the Display template (more precisely, per-post template) to remove duplicate message id's, and rewrote everything to instead request the post root's message ID and work with that. Seriously, with the machines we use today, jQuery can perfectly handle these. On a full sample page, I started with 65KB and ended up saving 1.5KB, or 300 gzipped bytes. It doesn't seem like much, but topic pages are the most visited (and most demanding) pages on any given forum, and with any byte saved, your server will thank you in the end. (Display.template.php, Post.template.php, post.js, topic.js)

* Quick editing a post will now sport a small sliding animation. (topic.js)

* Did some severe size optimizations for topic.js and (to a lesser extent) post.js while I was rewriting them -- saved about 100 gzipped bytes in topic.js, even after the extra features were added. About half of that in post.js. Also saved a few bytes off the Ajax data sent back to the client. Eh, a byte saved is a byte saved... (topic.js, post.js, Xml.template.php)

* Moved some inline styles to their proper CSS files. (Display.template.php, index.ie8.css, index.member.css)

* Renamed modifybutton to quick_edit, because that's what it is... A quick edit button. (Display.template.php, index.member.css, index.rtl.css)

+ Added a hardcoded copyright for Wireless. Oops. (Wireless/sections.css)

! Forgot to filter out editor-func and post from editor filenames, as well as 'index' for the main CSS filename. (Class-Editor.php, Load.php)
Title: Re: New revs
Post by: Nao on May 21st, 2012, 11:22 PM
rev 1588
(2 files, 5kb)

* Show the action bar (but hide anything but the Like button) for any ignored posts that received at least one like. Give peace a chance... (Display.template.php)

* Shortened modifytopicdone Ajax. I don't think the id is used anywhere. (Xml.template.php)

! SMF bug: a foreach() ended with a semicolon, meaning it only ran the block that followed on the very last entry in the array... Oops? Worst of all, I think, is that I was unable to find any difference between the buggy and the fixed implementations... Probably not a very important Xml block, eh. (Xml.template.php)
Title: Re: New revs
Post by: Nao on May 21st, 2012, 11:23 PM
rev 1589
(1 file, 2kb)

! Committed too much... The thought rewrite isn't ready for prime-time yet. (Xml.template.php)
Title: Re: New revs
Post by: Nao on May 22nd, 2012, 11:31 AM
rev 1590
(1 file, 1kb)

* Only animate quick-edit subject input box if the subject was empty to begin with, i.e. it wasn't shown to the user. This is something that's only useful in Wireless, and since it's unlikely mobile users can watch full-fledged animations, I'm actually tempted to get rid of that animation altogether. (topic.js)
Title: Re: New revs
Post by: Nao on May 22nd, 2012, 11:32 AM
rev 1591 (forget to tick a box... oops.)
(1 file, 1kb)

! weUrl() was recently broken for cookieless users. (script.js)
Title: Re: New revs
Post by: Nao on May 24th, 2012, 04:44 PM
rev 1592
(7 files, 8kb)

+ Thought replies finally get to be shown without this dreaded 'Reload to interact' warning. Need to apply this to the Welcome template, uh... (Ajax.php, Home.template.php, Post.language.php, script.js)

* Sort selector lists before generating the CSS files. This helps a bit with overall gzip compression rates. (Class-CSS.php)

! Member-only thoughts weren't shown to anyone in profile pages. (Profile-View.php)
Title: Re: New revs
Post by: Nao on May 24th, 2012, 05:05 PM
rev 1593
(9 files, 3kb)

* Simplified and shortened HTML for main and mini menus by moving the top arrow to a pseudo class, and doing some internal data analysis to avoid using an HTML id on mini-menus. Renamed .mimenuitem to .mimeitem for consistency. (Display.template.php, script.js, index.css, index.ie6.css, index.ie7.css, sections.css, Warm/index.css, Wireless/sections.iphone.css)

* Optimized a dozen more bytes out of the thought function... Oh well, you know how I am. (script.js)
Title: Re: New revs
Post by: Nao on May 24th, 2012, 06:35 PM
rev 1594
(5 files, 4kb)

! Partly reverted my latest optimization, because it sucked and was buggy. Well, so what? I still saved a few bytes. (script.js)

* Added a 'Thought deleted' mention in case a thought was in reply to a... well, a thought that was deleted. (Home.php, Welcome.php, Post.language.php)

@ The profile version needs a rewrite. I'm currently putting it into its own page, where a thread will have a specify ID not linked to the owner. Heck, much better that way...
Title: Re: New revs
Post by: Nao on May 25th, 2012, 11:35 AM
rev 1595
(12 files, 8kb)

* Rewrote some parts of the quick edit JS and HTML to simplify and shorten them. The HTML no longer needs to specify fallback templates. Error CSS is no longer hardcoded. Topic pages no longer need to specify the topic ID when calling a function -- the index template automatically specifies a we_topic variable when current_topic is set. Error message XML now specifies the target ID directly instead of asking JS to second-guess it. Etc. Overall, saved over 110 bytes in topic.js alone. (Display.template.php, index.template.php, topic.js, index.member.css)

* SMF bug: the topic ID is specified in both GET and POST when submitting a quick edit through Ajax. I can only confirm that it's fine not specifying the topic ID into the HTML form at all... (Display.template.php, topic.js)

* SMF bug: $context['message']['error_in_body'] was sent through cleanXml() even though it was just a boolean test... (Xml.template.php)

* SMF bug: modifytopicdone is never called when errors are found (it redirects to modifydone instead), so it doesn't need to test for errors. (Xml.template.php)

* Simplified various Aeva embedding methods. Flash will no longer show a codebase (it was the old Macromedia URL, and Adobe themselves don't seem to advocate for a codebase in the HTML), as well as WMP -- because it actually points to a 404! Well done, Microsoft... (Aeva-Embed.php)

* Renamed admin.css (admin area's CSS file) to mana.css, to avoid confusion with the 'admin' suffix for CSS files (used to keep a CSS file to administrators). 'Mana' is short for 'Manage', and it also justifies its use in the Moderation center, but it really is the RPG fan trying to justify the name change, ah ah. (Admin.php, ModerationCenter.php, admin.css, Packages.template.php -- when are we removing that file already, Pete? :P)
Title: Re: New revs
Post by: Nao on May 25th, 2012, 03:40 PM
rev 1596
(4 files +5-12, 21kb)

+ And it's time for this dreaded rewrite of the CSS caching code... It still needs some work (especially with the replace suffix), but it works for now, so let's get it over with. Basically, instead of checking whether files exist (index.mysuffix.css), Wedge will instead go through all of the files and decide whether they should be included, allowing you to use comma-separated lists of suffixes, which solves an AWFUL lot of problems. It was harder to implement as it sounds, if only because Wedge needs to sort all files at the end of the process, while the original implementation was naturally sorted. (Subs-Cache.php, editor.*.css, media.*.css, zoom.*.css, Wine/index.*.css, Warm/index.*.css)

+ As mentioned, added a 'replace' suffix to the list of accepted CSS suffixes. This will basically delete any prior file with the same radix (index, sections, mana...) found in the CSS file list, i.e. files from a parent skin, allowing you to create an add-type skin and still benefit from a complete rewrite of, say, sections.css. (Subs-Cache.php, Load.php)

+ Added support for m, b and c suffixes, followed by a number. 'm1' will restrict a CSS file to member #1, 'b1' to board #1 and 'c1' to category #1. And another many issues were instantly solved. (Load.php)

! Canonical URLs for category pages were pointing to the homepage. (Boards.php)

* Replaced quote tag's quote icon with dynamically generated CSS. It doesn't look exactly the same across all browsers, but it saves 150 bytes off the final gzipped CSS file. I'm all for that... (index.css, quote.png)
Title: Re: New revs
Post by: Nao on May 25th, 2012, 08:31 PM
rev 1597
(10 files +2, 20kb)

+ Implemented new pages for the thought system: a thread page and a rewrite of the profile page. This should at last make it more usable, even with thousands of thoughts around... (index.php, Home.php, Profile.php, Profile-View.php, Thoughts.php, Welcome.php, Profile.template.php, Thoughts.template.php)

! Fixed wrong days given in 'latest news' box in the admin area. (admin.js, xml/latest-news.php)

! Fixed improper number of lines in error popups. (ManageErrors.php)

* Styling detail. (index.member.css)
Title: Re: New revs
Post by: Nao on May 28th, 2012, 09:05 PM
rev 1598
(11 files, 13kb)

+ Added support for a 'custom.xml' skin file. Basically, you can quickly add a new setting to a skin without needing to create a sub-skin. For instance -- adding a css option for loading a Google web font that will be overriding another font through custom.css. You won't be able to say I didn't think of everything... (Subs-Cache.php)

* Optimized parse_bbc() in various areas, notably to use a new $tag['len'] variable from the database instead of calculating it every time through strlen(). It doesn't save a lot overall, but it's also a very cheap new database field -- you can set it through 'update bbcodes set len = length(tag)'... (Subs-BBC.php)

* Saved some time when preprocessing media tags -- php and nobbc tags already pre-protect the tags so there's no need to test for them. Merged all preg_replaces into one, which makes the call a bit faster if you mix code, noembed and/or html tags in one post. Okay, it's not like I'm saving more than a microsecond... So what? Also optimized the media tag parser itself, for similar speed improvements... Meh. I did the work, so I have to commit it. (Subs-Media.php)

! Fixed Google Maps embedding (due to them now using HTTPS...) Looks like the embed code fixer is broken, I'll have to look into it another time. (Subs-Aeva-Sites.php)

! SMF bug (minor): max_image_width and max_image_height were both expected to be set, even though the later code will still test for them independently. (Subs-BBC.php)

- Removed support for the fixLongWords option, as it's now systematically enabled through CSS. (install.sql, ManagePosts.php, Subs-BBC.php, Admin.language.php, Help.language.php)

- Removed a few footer tags from the bbcode list, whenever they weren't used at all in the final CSS/HTML. Fixed margins around and inside quotes. (install.sql, index.css)

@ Of recent memory, this rewrite of Subs-BBC.php is my biggest disappointment... I was really hoping to optimize it a lot, until I realized it really didn't need optimizing that much. What a waste of time! Is that 'len' field really worth it..?
Title: Re: New revs
Post by: Nao on May 29th, 2012, 05:25 PM
rev 1599
(6 files, 2kb)

* Minor fixes to errorbox items. Also introduced a $subject_font variable for user names and board titles. Well, that's what I'm using it for anyway... (Admin.template.php, index.french.php, PersonalMessage.template.php, index.css, index.rtl.css, sections.css)
Title: Re: New revs
Post by: Arantor on May 29th, 2012, 08:34 PM
(2 files, 1KB)

Revision: 1600
Author: arantor
Date: 29 May 2012 19:33:25
Message:
! Allow plugin-defined actions to call static class methods as well as regular functions. (index.php, Load.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on May 30th, 2012, 07:30 PM
rev 1601
(3 files, 2kb)

+ New WeCSS feature: ifnull($var, something) will output $var if it's defined, or something (which can be a var, a string or nested ifnull calls) if it isn't. That regex was painful to write, as it refused to process my perfectly formed negative lookbehind assertion. Bugger. Now it's using a lookahead preceded by a possessive quantifier, the likes of which I rarely use. So maybe it's even neater. Added a few examples with cat/title font sizes. (Class-CSS.php, index.css)

! Aeva embeds were never pre-processed correctly when quick editing a post. Bad me. (JSModify.php)

@ Note: ifnull() is named after the MySQL function, and is a prototype. Maybe in the future I'll want to do something like if(var1, var1, var2) but it's unlikely.
Title: Re: New revs
Post by: Nao on May 31st, 2012, 08:22 PM
rev 1602
(7 files, 4kb)

! Fixed ifnull() function (last-minute change that broke it... My nemesis.) (Class-CSS.php)

* Harmonized post buttons below textareas. (editor.css, index.rtl.css, Display.template.php, Media.template.php, PersonalMessage.template.php, Post.template.php)
Title: Re: New revs
Post by: Nao on May 31st, 2012, 11:50 PM
rev 1603
(4 files, 3kb)

! Although it worked, the regex for matching media tags was a bit odd; rewrote it to ensure closing brackets inside quotes won't break anything. (Subs-Media.php)

! Fixed word wrapping in code blocks, except for my iPod where it's muuuuuch nicer not to have to bother scrolling manually. Have you ever tried that? Well it sucks. (index.css, index.iphone.css)

! Fixed 'remove nested quotes' when quote depth level is higher than 1. This one should work in all situations, and be more reliable than any proper recursive regex. (Post.php)
Title: Re: New revs
Post by: Arantor on June 1st, 2012, 02:46 PM
(10 files, 24KB)

Revision: 1604
Author: arantor
Date: 01 June 2012 13:44:57
Message:
! Admin intro code that I've been threatening to commit, only this time all cleaned up and should even be hookable. (Admin.php, Admin.template.php, ManagePlugins.php, Admin language file)

! Scheduled tasks fixes. Thanks Dragooon! (ScheduledTasks.php, ManageScheduledTasks.php)

! Allow for overriding settings manually as per Dragooon's request (ManageServer.php)

! The big change: overhaul of the Q&A to allow multi-language, multi-answer questions. It hasn't been battle tested yet but it seems to work in my tests. (ManageSettings.php, Subs-Editor.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php

@Nao, feel free to go nuts with optimising the anti spam Q&A code, I deliberately didn't optimise it while writing it because it was done in stages, and if you want to fix the alignment of buttons, please do feel free.
Title: Re: New revs
Post by: Arantor on June 3rd, 2012, 04:04 AM
(3 files, 2KB)

Revision: 1605
Author: arantor
Date: 03 June 2012 03:03:54
Message:
! SMF bug: The anti-spam tests should be properly case-insensitive, not partially, i.e. should be UTF-8 aware when lower-casing. (Subs-Editor.php)
! Provide a more meaningful default for timezone than 'the first on the list' and if there's an error at registration actually remember the one the user picked when re-displaying the form. (Register.php, Register.template.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/Register.template.php
Title: Re: New revs
Post by: Nao on June 3rd, 2012, 11:15 PM
rev 1606
(12 files, 6kb)

* In the admin area, integer-type settings will now automatically have a 'min' value of 0 if nothing is set. (ManageAttachments.php, ManageNews.php, ManageSettings.php, Admin.template.php)

! scandir() could cause some errors when working with non-existent skins. It shouldn't happen, but in case someone bookmarked an old skin of yours that you deleted in the meantime, this could have been happening... (Subs-Cache.php)

! Fixed headers in help popups. (Errors.template.php, script.js)

! Fixed a mismatched anchor tag. Also translation. (Admin.language.php, ManageSettings.french.php)

* Code cleanup. (ManageMembers.php, Subs-Editor.php)
Title: Re: New revs
Post by: Nao on June 4th, 2012, 12:49 AM
rev 1607
(3 files, 2kb)

! Fixed and harmonized thought sending's Ajax return HTML. (Ajax.php, Xml.template.php)

! Fixed target styling in thought threads. (sections.css)
Title: Re: New revs
Post by: Nao on June 5th, 2012, 09:41 AM
rev 1608
(19 files, 2kb)

! SMF bug: a 'replace' DB query shouldn't use the 'order by null' optimization. Fixed by Pete! (Class-DB.php)

! IP logger should ignore duplicates on insertion (race condition). (QueryString.php)

* Harmonized wesql::insert('insert') to wesql::insert(''), like most calls. (install.php, Like.php, ManageMembergroups.php, ManagePaid.php, ManagePermissions.php, ManageSearchEngines.php, Poll.php, Post2.php, Profile-Modify.php, ScheduledTasks.php, Security.php, Subs-Boards.php, Subs-Members.php, Subs-Post.php, Subs-Scheduled.php, SSI.php)
Title: Re: New revs
Post by: Arantor on June 8th, 2012, 02:31 AM
(3 files, 3KB)

Revision: 1609
Author: arantor
Date: 08 June 2012 01:31:22
Message:
! Anti spam Q&A should be bbc parsed. (Subs-Editor.php)

! The logic for highlighting rows should not be entirely down to the template, in case plugins want to override it. This way the list of classes is set in the core but the skin is free to decide how to show it. *shrug* I needed this for a plugin, shoot me. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Nao on June 8th, 2012, 02:32 PM
rev 1610
(5 files, 4kb)

! A feed setting wasn't correctly set to integer. (ManageNews.php)

! References to deleted parent thoughts would link to a non-existent profile. (Thoughts.php)

! Fixed table width (which was incorrect when only short lines were found), in error log's source code popup. (Errors.template.php)

+ Implemented latest thoughts for all members (as opposed to the existing code for a specific member), and rewrote the homepage code to point to that instead. (Home.php, Thoughts.php, Thoughts.template.php)
Title: Re: New revs
Post by: Nao on June 10th, 2012, 12:39 PM
rev 1611
(7 files, 4kb)

+ Added default Wireless support for Samsung and HTC devices that don't provide a generic mobile string. HTC is very unlikely to fail on fail, so it's probably overkill. (Class-MoDe.php)

+ Added a new easing type for jQuery animations, 'out', which is basically a size-optimized version of easeOutExpo from jQuery UI/jQuery Easing. I like my code short and easy to compress, thank you very much. (script.js)

+ Re-implemented my popup animation for help icons, using the out easing. Yeah, that's really the only thing that satisfies me when animating large areas. Overall code adds 60 bytes but it can and should be used in other areas as well. (script.js) :edit: just 55 bytes, actually...

* Don't bother showing a page index in the thought list if no thought is available. (Thoughts.template.php)

! Forgot to redirect the profile thoughts page to the renamed function. (Profile.php)

! If a menu was destroyed before showing it (there's only one reason it should happen: area not found in the profile section -- uh, like the bug I just mentioned), Wedge would cause an error later. (GenericMenu.template.php)

! Chrome sometimes seems to ignore linebreaks with a clear class. Odd. Replaced that specific occurrence with a div that does the same. (Credits.php)

! Fixed padding in quick reply boxes. (sections.css)
Title: Re: New revs
Post by: Nao on June 12th, 2012, 12:11 AM
rev 1612
(3 files, 2kb)

! Fixed admin internal search when going through arrays (e.g. numbered strings). (Admin.php)

! Fixed some html_to_bbc calls that weren't using the wedit object. (Aeva-Gallery.php, Aeva-Gallery2.php)
Title: Re: New revs
Post by: Nao on June 12th, 2012, 02:39 PM
rev 1613
(9 files +4-2, 5kb)

* Replaced the new animation easing function (out) with a simpler one (sqr) which is also more realistic, while still putting the emphasis on the latter end of the animation. Saves a dozen bytes. Also made a funny-looking optimization to weToggle that saves a whopping one byte. I spent at least 10 minutes on that, so let me commit it. (script.js)

! As threatened earlier, I split the split code in two. SplitTopics.php is now Split.php and Merge.php, and same for the template. (index.php, xml/detailed-version.php, QuickMod.php, SplitTopics.php, Subs-Post.php, SplitTopics.template.php)

! Some 'pas si formidables' French translations. (Admin.french.php, ManageSettings.french.php)

! SMF 'bug': useless code. Was changed from SMF 1.1 and never updated in SMF 2.0 Final. (Search2.php)

* Spacinazi. (ManageMembers.template.php)
Title: Re: New revs
Post by: Nao on June 13th, 2012, 11:58 AM
rev 1614
(18 files, 33kb) (oddly, my last 'big' commit was exactly a month earlier, day to day.)

+ (Finally) added support for multiple group badges and ability for admins to determine (1) what group titles to show under user names (set it up in the Manage Membergroups area, Settings section), (2) what groups can show a badge and in what conditions (set it up in the individual membergroup settings pages, although as of now I have yet to write a proper UI for that one, but it works when done through the DB.) (install.sql, Display.php, Load.php, ManageMembergroups.php, PersonalMessage.php, Display.template.php, PersonalMessage.template.php, Help.language.php, ManageMembers.language.php, Themes.language.php)

+ Added permission for posting thoughts, and some related code. (install.sql, Load.php, ManagePermissions.php, index.template.php, ManagePermissions.language.php)

+ Added a 'userbox' custom loadMemberData set, used for topic pages. Also sorted the various sets to (more easily) spot the differences between them. Removed a few unused requests like group colors (done differently now.) (Display.php, Load.php)

+ Added hints for search engines in the language links (uses the country code and HTML5-sanctioned markup.) (Load.php, index.template.php)

* Don't bother saying "Hello, guest" when you don't even provide a login box in that section... (index.template.php)

* $context['first_new_message'] will now be used to link the anchor to the topic title if the topic is entirely unread, or the first unread post otherwise. (Display.php, Display.template.php)

! A missing function was causing AeMe to fail some maintenance tasks. (ManageMedia2.php)

* Commenazi. (Display.php)
Title: Re: New revs
Post by: Nao on June 13th, 2012, 12:30 PM
rev 1615
(5 files, 5kb) (didn't do these on purpose...)

+ Added support for viewing all posts made by a single guest when clicking their name in topic pages. (Profile-View.php, Profile.php, Profile.template.php)

+ Adopting the sqr animation easing type by default. If you need to use swing, just specify 'swing2' as the easing. Tweaked menu animations to remain visible, as sqr is quite nice for 'big' animations but makes smaller animations barely visible. Finally, optimized more code. Saves another few bytes all in all. (script.js)

! The contextual tab menu code provided for custom URLs being used, but the original code didn't actually provide it with these URLs in the first place... (GenericMenu.template.php)
Title: Re: New revs
Post by: Nao on June 14th, 2012, 09:42 PM
rev 1616
(6 files, 12kb)

* Some tweaks to the Wuthering layout and styling. Nothing biggy but... Oh, well, it's actually bigger than planned, with a few fixes along the way. (index.css, sections.css)

* Rewrote the WeCSS parser to accommodate for commas inside selectors, e.g. :not(.this, .or, .that) or input[title,lang]. Very happy with this much-needed rewrite... Yay, champagne. (Class-CSS.php)

! Fixed selector sorting as well. Now everything should be properly sorted. It's not going to save more than a couple of bytes in the final gzipped file, but at least it's cleaner. Also, this allowed me to finally get rid of duplicate selectors without the need to actually clean up CSS inheritance, e.g. having multiple inheritance from two classes that also inherit another common class won't duplicate your base class by as many classes as found. If you don't understand anything, it's all right, I'm just trying to sound smart. What did I say already? Oh, just look at .postbg2, I built my fix on that... (Class-CSS.php)

! Fixed @import grammar. As indicated in the comments, I still wouldn't recommend using these, as Wedge provides alternative solutions that don't force you to push your @import to the first file in the list. Maybe later I'll implement some mechanism to import local files directly inside a file, like Sass does. (Class-CSS.php)

! Fixed use of colons (:) inside url files, e.g. @import url(googlewebfontURL:400,700). Well, didn't I just say not to use @import?! Oh, me and my obsessions... (Class-CSS.php)

! Fixed undefined index error in profile thoughts. (Profile.php)

! Preventing the flow control 'replace' keyword from appearing in final CSS filenames. (Subs-Cache.php)

* Documented wedge_cache_css_files() params, and replaced the plugin-oriented param with a more generic variable array that can do the same and more. (Subs-Cache.php)

! Older Android webkit versions don't support box-sizing without a prefix. (Subs-Cache.php)

! The checkmark in the skin selector wouldn't always show up, so ensured it would always use a basic sans-serif font. This increases chances that it'll be available. (Themes.template.php)
Title: Re: New revs
Post by: Nao on June 15th, 2012, 01:44 PM
rev 1617
(15 files, 7kb)

! Fixed thought permission to use the security functions to disable itself for muted members, instead of doing it through a hack... (Load.php, Security.php, index.template.php)

* Replaced all remaining italic tags with emphasis tags. I'm trying to keep the i tag to the smiley code, really. (other/ssi_examples.php, Aeva-Gallery2.php, Who.php, Help.language.php, ManageMedia.language.php, Media.language.php, Who.english.php)

+ Added a hackish representation of the $actions array for moderators in the Who's Online page. I'd rather print out the full URL as visited, but it's not possible with the current structure of the log table. Noisen.com has a special field which stores just that -- would it be worth doing the same? (Who.php)

* Who's Online page showed (to admins) hidden members with a 'hidden' class, which was never defined. Since the homepage shows them with a hardcoded em tag, doing the same here instead. (Who.template.php)

* Spellcheck translation was too long in French, making for ugly buttons... Settled for 'Orthographe', which is understandable enough for me. (index.french.php)
Title: Re: New revs
Post by: Nao on June 15th, 2012, 02:17 PM
rev 1618
(3 files, 3kb)

+ Leave topic prefixes out of the links. Been in use for some time on wedge.org now, without any issues. I'm not convinced it's for the better (a page-wide preg_replace is not always very fast), but I'd rather have this out now, can be improved later. My uncommitted file list is getting too long. (Subs-Template.php)

! Don't show a user's current action in their profile if they're hidden... Admins will still see the action, but in italics to show that the user is hidden. (Profile-View.php)

! Moderators could get some errors in Who's Online when a user was getting an error in the media area. Instead of moving the error messages from the Media to Error language files, which is a long and annoying task, let's just ignore this... All right? Do you still like me? (Who.php)
Title: Re: New revs
Post by: Nao on June 15th, 2012, 02:58 PM
rev 1619
(9 files, 3kb)

! Replaced a few complex regexes applied to htmlspecialchars, with a simple westr::htmlspecialchars, which as it happens, does exactly the same thing internally... Hopefully this won't break anything (I'm looking at the login form mostly!) (Display.php, Login2.php, ManageAttachments.php, SSI.php)

! Fixed some double backslashes in regexes here and there. Well, they didn't do anything unexpected, but it's cleaner to avoid escaping stuff that doesn't need it. (install.php, Register.php, Subs-Auth.php, Subs-Members.php)

! Search results would break when meeting an entity in the body. Basically, westr::entity_fix shouldn't be called through an eval but a callback instead, ensuring it sends an array. But anyway, I replaced that ugly call with a simple call to westr::entity_clean which does the same... (Search2.php)
Title: Re: New revs
Post by: Nao on June 15th, 2012, 08:36 PM
rev 1620
(12 files, 5kb)

- Removed can_ajax -- if you really need this (it's so 2001), use $.support.ajax instead. It actually saves a whopping 29 bytes if gzipped script.js files, had I noticed earlier it'd be gone already... (upgrade.php, Class-Editor.php, Display.template.php, Post.language.php, Packages.template.php, Split.template.php, editor.js, register.js, script.js, suggest.js, topic.js)
Title: Re: New revs
Post by: Nao on June 17th, 2012, 05:26 PM
rev 1621
(10 files, 4kb)

* Rewrote skin list processing to provide a more realistic tree, removed $level parameter, etc. (Themes.php, ManageBoards.template.php, Themes.template.php)

! wetem::$has_layer was set wrongly when providing an empty layer. Also documented wetem::layer(), FWIW. (Subs-Template.php)

+ Added variables to allow setting up custom fonts for blog posts. (sections.css)

! Not really fixable, but at east muted the dns_get_record error that could happen when visiting a profile on some servers. (Subs.php)

! Credits page was missing a linktree. (Credits.php)

* Linktrees had a bit too much space below them, I'd say... (index.css)

- Forgot to remove a setting after rewriting the group title hiding code. (Settings.template.php)

- Commenazi. (Aeva-Subs-Vital.php)
Title: Re: New revs
Post by: Nao on June 19th, 2012, 06:48 PM
rev 1622
(8 files, 4kb)

! Fixed HTML error. (Display.template.php, PersonalMessage.template.php)

! nbsp isn't allowed in alert texts. Well, AFAIK. (Post.french.php)

- Removed iStart variable (no longer used.) Shortened related JS function by about 20 bytes. (Display.template.php, topic.js)

* Allow for multiple attachment selection... Although it's not implemented in core yet, adding it here is needed for the feature to work in Opera. Talk about a bug... (Post.template.php)

* Replaced appendTo with simple append calls. As odd as it may sounds, it saves about 10 bytes. (script.js)

* Simplified icon function. (post.js)

* Pixelnazi. (index.css)
Title: Re: New revs
Post by: Nao on June 20th, 2012, 01:15 PM
rev 1623
(5 files, 3kb)

* Still not done with the UI, but in the meantime enjoy this one: in profile pages > account settings, membergroup selection is now showing you the badges you're going to get. It only works for badges that always show up or badges that show up depending on their status (primary or additional). For instance, if the admin group has a badge but it's set to show only if used as a primary group, then the primary group list shows an admin badge, and the additional group list doesn't. (Profile-Modify.php, Profile.template.php)

* A couple of attic files had an extra line break at the end of the file. Which isn't cool. (attic/*)

* Another popup tweak.. Never completely happy with it eh? (script.js)
Title: Re: New revs
Post by: Nao on June 21st, 2012, 05:42 PM
rev 1624
(1 file, 1kb) <-- doesn't do justice to the time I spent on this :lol:

* Updated list of IP ranges per whois server for IP tracking. I s'pose no one's gonna go and check that I didn't do any mistakes, so I'll just say that the list will need to be updated as long as all ranges aren't assigned. (Profile-View.php)
Title: New revs
Post by: Arantor on June 24th, 2012, 01:00 AM
(I cannot presently post to the main New Revs thread, so putting it here)

(14 files, 20KB)

Revision: 1625
Author: arantor
Date: 23 June 2012 23:59:34
Message:
! Allow admins, admins+thread creator, logged in members, or everyone to see who voted in a poll, and make that controllable from the poll creation. Note that by design it should not be possible to change who can see this, as it might otherwise influence voting. (install.sql, Display.php, Poll.php, Display.template.php, Post.template.php, Poll.template.php, Language files: Help, index, Post)

! Added param for reqWin to prevent reqWin automatically grabbing a title. It's hackish, I'm sorry, but I couldn't think of a better way of doing it than this without altering every single case where reqWin was invoked. I didn't check how much larger it made script.js when compressed either. (script.js)

! Rearranged the likes display in posts to move the number to the right of the action itself, and to make that a link to the popup showing who liked a post. In order to do this some style juggling had to occur. If this can be improved, please please do so. (index.php, Like.php, Display.template.php, index.css, sections.css, Language files: index)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/index.php
Modified : /trunk/other/install.sql

@ As discussed, this is not an 'I'm ba-aaaaack' commit. It's one that I did because it needed to be done and was annoying me that it had not been done yet. I consider it a WIP but I don't really know how to do some of it better. It may well be better just to revert bits of it and be done with it, but that's not really my call to me. Those who have source access, check it out and let me know.

@ This looks like a lot, but we're really talking about 6 hours work across three days. Nothing to even stress me out over.
Title: Re: New revs
Post by: Nao on July 1st, 2012, 12:26 AM
rev 1626
(4 files, 4kb) -- getting back to work after a one-week holiday...

! Don't double-encode entities in safe page titles. Is that a good idea..? How to reproduce: go to an album page where the name of the album is a long word. 'Shy' should show up in the title... (Subs.php)

* French translation. (Help.french.php, index.french.php, Post.french.php)
Title: Re: New revs
Post by: Nao on July 4th, 2012, 05:19 PM
rev 1627 -- hoping for some feedback about the new reqWin ;)
(11 files, 12kb)

* Rewrote the reqWin popup code. The world wasn't ready for a bottom-right aligned thingy. The new one is simpler, shorter and, admittedly, better. Support for IE (position fixed), iOS (ditto) and generally low-res devices is better, too. Things like noDrag are no longer needed, as the scrollbar is always in an undraggable area. Also saves 200+ bytes of gzipped code compared to the previous version. But you're used to that by now... (Display.php, Like.php, ManageAttachments.php, Display.template.php, Help.template.php, Packages.template.php, script.js, index.css, index.ie6.css, mana.css)

! Fixed select boxes showing squares instead of arrows in IE6. (index.ie6.css)

! Fixed fixed positioning for popups in iOS. (Not that's not a typo.) (index.iphone.css)

- Removed support for bottom-right alignments in dragslide because it takes space for nothing (I don't think anyone would use that outside of the earlier reqWin.) (script.js)
Title: Re: New revs
Post by: Nao on July 5th, 2012, 02:26 PM
rev 1628 - a few more commits are coming up... I tried to split them by category.
(6 files, 5kb)

! Fixed error log's file viewer and made it use the Help template instead of a custom one. (ManageErrors.php, Errors.template.php)

! Fixed permission profile page in media area. Notably, empty values in option tags need to be replaced with data-hide. I think I should try harder and look at fixing these on the fly, really... (ManageMedia.php, ManageMedia.template.php)

+ Added an 'or' statement in the permission profile page to make it clear that you have a choice between two actions. (ManageMedia.php, ManageMedia.template.php, ManageMedia.language.php)
Title: Re: New revs
Post by: Nao on July 5th, 2012, 02:30 PM
rev 1629 - the 'short' one.
(4 files, 2kb)

+ Added ability to specify a default display string in select boxes that isn't listed in the select box dropdown. Use data-default="string" in your select tag. (sbox.js)

! Fixed reqWin popup vertical position in iOS devices. Thank you Apple... (script.js)

! Fixed select boxes no longer showing up in IE6 and IE7. (index.template.php)

* Minor tweaks to the popup visuals. Optimized for size, too. By a couple of bytes uh... (index.css)
Title: Re: New revs
Post by: Nao on July 5th, 2012, 02:32 PM
rev 1630 - the comfort commit.
(3 files, 2kb)

* The statistics page will now show days in reverse order, so that you can develop consecutive months and analyze daily stats in order without disruption. You know -- it's the kind of thing you never understand but use as is, and then one day you think, okay I'll just change that... (Stats.php)

* Ensuring that you can directly call add_js_file() for an external file without having to specify it's a direct URL -- this is because external files always have a :// in the URL. Well, I left the boolean in, just in case for some odd reason you need to call it with no protocol. (Subs-Cache.php)

* Switched membergroup name and badge positions in the profile account page. Cleaner this way. (Profile.template.php)
Title: Re: New revs
Post by: Nao on July 5th, 2012, 02:38 PM
rev 1631 - the sizenazi commit. Final commit for now, will be back later with some Foxy new changes.
(9 files, 4kb)

* Replaced a str_replace with a preg_replace in the dynamic replacement code -- it pains me, but it starts with a long unchanging string so it should be nearly as fast, and it allows me to optimize a few places I didn't think of with closing and reopening script tags. (Subs-Template.php)

* Size optimizations. Removing "> 0" tests (and replacing == 0 with !) when we know the variable is an integer, or close enough. Hope I didn't screw up the selectionStart thing. Also, stats.js was never fully optimized to begin with. (editor-func.js, editor.js, post.js, spellcheck.js, stats.js, suggest.js, topic.js, zoomedia.js)

* Turned Zoomedia into a closure. I like those, didn't you notice...? (zoomedia.js)
Title: Re: New revs
Post by: Nao on July 10th, 2012, 06:07 PM
I'm sorry for such a huge changelog, but today I'm not strong enough to separate my changes into thematic commits... At this point I'm only praying that I documented everything and didn't forget any features or files ;)

rev 1632
(23 files +2, 36kb)

* Rewrote reqWin even more, mostly to add background dimming behind the popup, and to simplify the code. For instance, because we no longer attach events to unrelated elements, there's no need to fix the event format or unbind some events. (script.js, index.css)

* Fade out the reqWin popup when closing it via the 'Close window' link as well. (Help.template.php)

! Fixed reqWin centering in iOS. (script.js)

! Fixed errors in media playlists, and made the player use Wedge caching. (Aeva-Foxy.php, player.js)

! Fixed swfobject embedding, and harmonized version to 2.2. (Aeva-Foxy.php, Aeva-Subs-Vital.php)

* Trying not to have too many actions in the index file, I moved displaylike to Like.php and used a sub-action for viewing likes. (index.php, Like.php, Display.template.php)

* Increased post box height from 175 to 250px. I was through resizing it by myself. I'm sure no one will mind and it may actually encourage posting more. (Post.php)

+ Added a polyfill for IE 6-8 to support media queries. It'll only support min-width and max-width which are the most common cases, but at least it'll be fast (and short) enough not to bother me too much. (Load.php, respond.js)

- No need to fill in a $no_resize variable when it's only useful once. Removing it does add some extra code to old IEs though, hopefully it won't make them go crazy. Yes, it's just a call to an empty function for resize(), but I've seen worse from them. (index.template.php)

- Label selects in PM pages actually don't need to be fixed. (PersonalMessage.template.php)

- According to my stats, Opera < 9.5 is used by less than 0.2% of web users. If I'm going to drop support for IE6 one day, and I sure will, I have to set an example even if it's my favorite browser... So, removed Wysiwyg detection for Opera < 9.5. Saves about 20 bytes overall. For everyone... (editor.js, script.js)

* In post pages, moved topic icons inside their select box, and moved topic title input box to the right of the icon select box. Makes more sense. (Post.template.php, post.js)

* More space-saving optimizations. Saves something like 70 gzipped bytes when added to script.js, yay. (sbox.js)

* Some space-saving on CSS as well. Unless I'm horribly mistaken, "margin: auto" is the same as "margin: auto". No need to use both. (index.css, index.ie6.css, sections.css)

* Shortened param code for weToggle. It actually saves a nice amount of bytes, and is still easy to understand. (TEMPLATES: Admin, Boards, Display, index, ManagePermissions, Packages, PersonalMessage, Post, SCRIPTS: post.js, script.js, stats.js)
Title: Re: New revs
Post by: Nao on July 11th, 2012, 11:45 AM
rev 1633 -- the Zoomedia commit. :)
(7 files, 9kb)

! Rewrote Zoomedia's initialization routine to improve handling of titles and descriptions. Seriously, it was horribly broken. Plus, the new version is shorter by 150+ gzipped bytes. It's all in a day's work for Byte Repair Man. (zoomedia.js, zoom.css)

* Harmonized/simplified Zoomedia call code. (Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php)

* All attachment resizing is now done through Zoomedia rather than a window popup or the expandThumbs function. (Display.php, Display.template.php)

! Give access to hidden/forbidden user albums to users who have explicit permission to post in them. (Aeva-Gallery.php)

! Fixed centering of media items. (Aeva-Subs-Vital.php, Subs-Media.php)
Title: Re: New revs
Post by: Nao on July 13th, 2012, 10:08 AM
rev 1634
(8 files, 4kb)

* Stripped tags from HTML-safe page titles. No longer generating this variable before it's really needed. (Subs-Template.php, Subs.php)

* Adjusting error log's code popup height. I'm not exactly sure why it didn't fit anymore... (ManageErrors.php)

* Adjusting height for PM post boxes as well. (PersonalMessage.php)

+ Added commas between voter names when polls allow to view them. (Display.template.php)

* Reverted the HTML validator to the good old URL, as they appear to have fixed their earlier issues. (index.template.php)

* Giving more breathing space to unordered lists. (index.css)

* Couple of bytes saved. (sbox.js)
Title: Re: New revs
Post by: Nao on July 13th, 2012, 10:09 AM
rev 1635 - the playlist commit
(4 files, 1kb) (must be buggy because the diff patch is 11KB! For rev 1634 it was 6KB...)

! Fixed playlists no longer working after the latest Foxy commit. (Aeva-Foxy.php)

! Fixed undefined variable when visiting a playlist page with at least one vote. (Aeva-Foxy.php)

! Fixed non-AeMe calls to Zoomedia generating undefined errors. (Aeva-Subs-Vital.php)

* Moved the rest of playlists' inline JavaScript to player.js. (Aeva-Foxy.php, player.js)

* Moved playlist and media item names to the category header. (Aeva-Foxy.php, Aeva-Gallery.php)
Title: Re: New revs
Post by: Nao on July 13th, 2012, 11:51 PM
rev 1636
(14 files, 5kb, diff patch is 11kb, I need to let go of what svn tells me when committing...)

! Fixed a potential undefined index when the client doesn't have any headers specifying the requested host name. This certainly means it's a mischievous bot, but it should already have been stopped by Bad Behavior at this point, so no need to generate a regular error as well... In case it's a 'proper' query, rebuilding the host name from the default one. (Load.php)

! Fixed another undefined index error that would trigger when visiting a Media admin page with an outdated session ID. (ManageMedia.php)

- Removing some unneeded tab_data elements. (Admin.php, ManageMail.php, ManagePaid.php, ManagePermissions.php, ManageScheduledTasks.php, ModerationCenter.php, PackageGet.php, RepairBoards.php)

* If a file was shortened after an error was generated in it, and the error was near the end, Wedge would show nothing in the file viewer popup. Replacing this with a warning about the user being out of bounds. (ManageErrors.php, ManageMaintenance.language.php)

* Don't bother specifying a height for file viewer popups. Really, most browsers will behave and choose the best possible height. Except for IE, but I don't give a damn. (ManageErrors.php)

* Changed default windowbg colors for Weaving. I like change from time to time... (index.css)

* Chrome doesn't cooperate with box-sizing stuff. As far as I know, 0.4% * 2 + 49% < 50%, but it still would insist on showing just one column per row, instead of two. Decreasing the width by 0.1% helps it behave better. Meh. (index.css)

@ And I just discovered that TortoiseSVN, or RepoHosting, now allow editing any changelog's body or author... :) Used to refuse to let me do it!
Title: Re: New revs
Post by: Nao on July 14th, 2012, 10:49 PM
rev 1637
(6 files, 3kb)

* Spacinazi and other details. (Class-Editor.php, index.css, sections.css)

+ Added an 'add_js_unique' helper function, which allows you to add a JS snippet multiple times while ensuring it's only printed once. Very useful for adding JS from a function we don't know how many times will be called. (Subs-Cache.php)

* Turned profile page's name back into a link. Although it's linking to the same page, at least we get the proper group color... (And I'm wary of re-introducing color fetching from the database. For now at least.) (Profile.template.php)

! Wrong color alignment in the stats page. (Stats.template.php)
Title: Re: New revs
Post by: Nao on July 14th, 2012, 10:50 PM
rev 1638
(2 files, 8kb)

- Removed code tag's hack code from theme.js because I did some testing and couldn't find a single browser that had problems with these. I'll restore it if someone can provide me with a clean test case. (theme.js)

* Moved img.resized JS code to the img tag parser, and got rid of theme.js contents in the process, saving about 200 gzipped bytes from the main script file. (install.sql, theme.js)

* Replaced CRLF codes with simple Linux linefeeds in bbcode PHP. This should be just fine this way. (install.sql)

* Ensuring that the install script declares all auto-incremented IDs as unsigned. I don't even know if it's possible to manually insert a negative ID in these... Probably possible, but pointless. (install.sql)

* Started harmonizing field sizes in the database. For instance, id_member is mediumint(8) unsigned (I don't think there's any case where an id_member is stored as negative, even for a pseudo-member), things like that. (install.sql)

+ Added an id_media field to topics, for future use. (Yeah, don't have to be Einstein to get that one...) (install.sql)
Title: Re: New revs
Post by: Nao on July 18th, 2012, 08:36 PM
rev 1639 (the bugfix commit)
(5 files, 2kb)

! Non-file cache systems (at least APC) were broken in Wedge because failed cached retrievals wouldn't be properly detected. (Subs-Cache.php)

! Navigating user posts would lead you to the wrong profile when visiting older pages. (Profile-View.php)

! Undefined index in voter visibility code (poll_votes_visible was used instead of poll_voters_visible.) (Poll.php)

! A couple of bugs with zlib.output_compression. (index.php, SSI.php)
Title: Re: New revs
Post by: Nao on July 19th, 2012, 12:53 AM
rev 1640
(6 files, 3kb)

+ Added a we_board variable to board pages. Although it's less often used than we_topic, it's still worth adding it, if only for future plugins. (Display.template.php, index.template.php, Post.template.php, post.js, topic.js)

* Moved delete and submit strings to the generic JS code (instead of just the thought code), so that guests can always see them without having to load them twice. (index.template.php, script.js)
Title: Re: New revs
Post by: Nao on July 20th, 2012, 10:32 PM
rev 1641 -- the Post commit. More to come... (Scary stuff.)
(2 files, 2kb)

! Post page didn't present current attachments in the right order. (Post.php)

! Post page ignored zero-byte attachments in some situations. (Post.php)

* Used the opportunity to simplify the current_attachments array and remove the deprecated 'approved' flag. At this point it's only an array because of the 'unchecked' boolean. (Post.php, Post.template.php)
Title: Re: New revs
Post by: Nao on July 20th, 2012, 11:21 PM
rev 1642
(6 files, 11kb)

! SMF bug: there was some code to preview external avatars as they were entered, but the avatar preview was shown on a different tab, and thus invisible... Also fixed the JS to ensure that the image would load entirely before attempting to get its dimensions. A classic. (Profile.template.php)

* Rewrote keep-alive JS code to only trigger on textareas and WYSIWYG editors. Moved it to editor-func.js because I don't really see a reason to bother when it's a textarea lost in some far away admin area or something. Saves nearly 50 gzipped bytes off the main script. Laugh all you want about my optimizations, but that script is now easily a kilobyte shorter than months ago. (script.js, editor-func.js)

! Fixed reqWin popup auto-height in IE10. Well, at least the old Win7 preview. Not my fault if Microsoft wants to force us to use their crappy Win8. Hopefully it doesn't break other browsers or specific situations. (script.js)

* Simplified get/sendXMLDocument() functions. They should look less cryptic now. Also optimized script for size, as always... (script.js)

! Fixed WYSIWYG editor throwing errors at IE9. Which didn't happen before. Anyway, using feature detection instead of is_ie (even though is_ie8down would fix that.) (editor.js)

- Removed on-the-fly minification of JavaScript through the minify_html hidden variable. It's still available for tab removal, but minification was both slow and buggy. (Subs-Template.php)

* Remove stats.js into a singleton to save over 80 gzipped bytes compared to the latest version. (stats.js)
Title: Re: New revs
Post by: Nao on July 20th, 2012, 11:44 PM
rev 1643
(52 files, 10kb) (more frightening than threatening, as the size implies.)

* Replaced these old "new Image().src" calls with $.get(). (upgrade.php, Load.php, ScheduledTasks.php, Subs-Scheduled.php, Admin.template.php, Themes.template.php)

* Moved blankGif() over to VerificationCode.php, as it was only used there at that point. (Subs.php, VerificationCode.php)

* It suddenly hit me that die() isn't an enticing function name, and I decided to replace them all with exit. Except for hacking attempts, because that's what they deserve. Or because I'm too lazy to change all of these for now. Next time I'll revert all of that to die() calls because it's "shorter", ah ah. Don't mind me. (index.php, install.php, a dozen of useless other/* files, smfinfo.php, upgrade.php, Ajax.php, Class-DB.php, Display.php, Dlattach.php, Errors.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Class-Media.php, Load.php, MessageIndex.php, QueryString.php, ScheduledTasks.php, Search2.php, Security.php, Spellcheck.php, Subs-Captcha.php, Subs-Scheduled.php, Subs-Sound.php, Subscriptions-PayPal.php, Themes.php, Unread.php, UnreadReplies.php, SSI.php, subscriptions.php)

* Some more minor JavaScript optimizations (mostly for size.) (install.php, a few more obscure other/* files, upgrade.php, Load.php, Display.template.php, Register.template.php, avasize.js)

* Spacinazi. Just the one line. (Stats.php, Subs-Media.php)
Title: New revs
Post by: Arantor on July 23rd, 2012, 02:34 AM
(8 files, 3KB)

Revision: 1644
Author: arantor
Date: 23 July 2012 01:32:49
Message:
! Couple of miscellaneous grammar fixes. One of them even seems to have been mine. (ManageSettings.english.php)

! Add a checkbox, on by default, to show the feed block in the sidebar. Of course it won't show if feeds are disabled, but at least now it's optional. (index.php, install.sql, ManageNews.php, ManageSettings language file)

! Make password error logging be optional. (install.sql, Login2.php, ManageSettings.php, ManageSettings language file)

! Don't log certain user account errors as errors. So what if users are trying to register with reserved names? They get stopped at the door, but there's really no need to log that fact too. (Subs-Members.php)

! Sync BB implementation to BB 2.2.7. (Security.php)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on July 24th, 2012, 12:41 PM
rev 1645
(9 files, 4kb)

* Simplified weUrl() function by making it always use we_script as the base URL. The param is still optional so it doesn't save any gzipped bytes, but it's still better IMHO. (script.js)

* Replaced Ajax draft call tests with is_ajax instead of xml, allowing for some shorter JS. And getting rid of an annoying line of code. (PersonalMessage.php, Post2.php, editor-func.js)

* More byte saving: some getXMLDocument to $.get, referring to 'window.location' as just 'location'... (script.js, stats.js, suggest.js, topic.js)

! IE9 doesn't support border-radius on elements with a filter. Removed filter from .note classes because the solid border radius looks better than a square gradient. (index.ie9.css)

* French translation. (ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on July 24th, 2012, 05:33 PM
rev 1646
(16 files +2, 53kb -- most of this is the new files)

+ It would appear that I forgot to upload a couple of new files from when I split the splitter... (Split.php, Merge.template.php)

! Hopefully fixed a theme JS function that was incorrectly handling the script URL. (Themes.template.php)

* Harmonized all weUrl() calls to use the new param format. (Load.php, Admin.template.php, index.template.php, Packages.template.php, Themes.template.php, editor-func.js, editor.js, mediadmin.js, player.js, post.js, register.js, stats.js, suggest.js, topic.js, up.js)
Title: Re: New revs
Post by: Nao on July 24th, 2012, 11:10 PM
rev 1647
(6 files +2-2, 9kb)

* Replaced boardstatus system with a single icon with different opacities according to the board type (on, off, redirect). This saves about a kilobyte off the main gzipped CSS file, and paves the way for custom board icons taken from the media area. Removed the legend because it sucked, and added titles to redirect board icons. Decided to get rid of the on/new differences because basically if a sub-board has new posts, a 'new' icon will show up for it anyway, no need to change the parent's status icon. (boardicon.png, boardstatus.png, boardstatus-ie6.png, Boards.template.php, MessageIndex.template.php, index.ie6.css, sections.css)

! Fixed a couple of bugs in the Groups page, which could cause a server crash and/or menu errors. Don't ask, I have no idea. (Groups.php, Subs.php)
Title: Re: New revs
Post by: Nao on July 28th, 2012, 11:49 AM
rev 1648
(5 files, 4kb)

+ Added an internal rgb2hex function in WeCSS. It makes it easier to return a #rgb value for CSS while compressing it if possible (#fc9 instead of #ffcc99). (Class-CSS.php)

! It is with great sadness that I'm hereby forced to allow selectors to start with a digit, while it conflicts with the basics of CSS. It's not my fault that they allow these for @-keyframes declarations. (Class-CSS.php)

+ Added support for the 'fr' value (fraction) in the math() function. I doubt anyone will ever need to use math(2fr * 3fr), but whatever! (Class-CSS.php)

! Partially reverted rev 1143's IE9 fixes for gradients. While it did fix gradients, it also completely deleted rgba() declarations from IE9 files. The new fix should be the best of both worlds... (Class-CSS.php)

* Renamed signature_minposts language string to signature_needs_posts, to avoid conflicts in the admin search. (Profile-Modify.php, Profile.language.php)

! Fixed title icon alignment in Recent page. (Recent.template.php)
Title: Re: New revs
Post by: Nao on July 28th, 2012, 05:12 PM
rev 1649
(6 files, 3kb)

* Cleaned up reqWin, removed desiredHeight and asWindow params which were no longer in common use. (Install.language.php, Packages.template.php, captcha.js, editor.js, script.js)

* Cleaned up weUrl() as well, removing the fallback for empty urls (if you need to get the URL with no param, just pass an empty string), and the extra test that made sure to add a semi-colon -- which, as far as my tests show, would never happen in any situation. (script.js)

* While doing a documentation search on something else, I noticed the $.now() function in jQuery. This compresses even better than '+new Date', which was my beloved trick for saving space compared to the ugly '(new Date()).getTime()' that jQuery also uses. Well, I can't rewrite jQuery (maybe I should!), so I'll have to use that, but if you don't use jQuery, try and remember to use '+new Date', because it rocks. (script.js)

@ BTW, the rgb2hex optimization from last rev saved nearly 20 gzipped bytes (about 60 non-gzipped), which was better than I hoped for. :)
Title: Re: New revs
Post by: Nao on July 29th, 2012, 12:53 PM
rev 1650
(12 files, 3kb)

! Hopefully fixed that annoying bug in Packer that forced me to split JavaScript strings over 255 bytes. It would seem that the regex for string parsing was simply too time-consuming. (Class-Packer.php, suggest.js)

* Finished replacing +new Date with $.now() where it made sense. (install.php, upgrade.php, restore_backup.php, Admin.template.php, Profile.template.php, Themes.template.php, editor-func.js, suggest.js)

- Mouse wheel events in the select box didn't seem to require an event fix after all... Tested in IE6 and I can't think of another browser that would have needed that. Hey, it saves bytes, so I'm all for it, gives me more room for my upcoming confirm() rewrite. (sbox.js)
Title: Re: New revs
Post by: Nao on August 1st, 2012, 11:46 PM
rev 1651
(12 files, 14kb)

* Converted all sendXMLDocument/getXMLDocument calls to $.post, $.get (and $.ajax when not possible otherwise). It's hard to determine how much space was saved this way (some files are a bit larger, others are much shorter), but it's more important to be using a more 'standard' way of doing Ajax (through jQuery), rather than obscure SMF functions. (unittest.js, upgrade.php, Aeva-Subs-Vital.php, Packages.template.php, Split.template.php, Themes.template.php, mediadmin.js, post.js, register.js, script.js, topic.js)

- toggleView doesn't seem to require a &#38 conversion... Could use some further testing. Perhaps the same can be done to other areas... (editor.js)
Title: Re: New revs
Post by: Nao on August 2nd, 2012, 08:40 PM
rev 1652
(10 files, 4kb)

* Added 'must confirm e-mail address before logging in' error type to the enableErrorPasswordLogging system. (Subs-Login.php)

! Fixed error handling for QuickModify object. Basically, $.ajax's callback is a success callback, not a complete callback, so I had to move the error handling to the Deferred object. Hopefully that works, because I couldn't test thoroughly... (topic.js)

! Restored the extra test in weUrl(), because Pretty URLs could fail to work without it. (script.js)

- Got rid of the .php_urlencode() function, because it was only barely used (most of its prior used were for URL encoding in Ajax calls, but $.ajax does it by itself already.) So, basically, use encodeURIComponent() if you ever need to encode stuff. (Packages.template.php, register.js, script.js, suggest.js)

- Removed is_gecko test in JS (it was never used anywhere), and replaced is_ff with a simpler $.browser.mozilla alias. (script.js)

* Simplified auto-suggest code. Saves many bytes. Oh well, that's just me... (suggest.js)

* Forgot to commit an obscure file with a getXMLDocument call. (other/unittest/templates/scripts/unittest.js)

* Whatever... Details. (ManageMedia.php, ManageMedia2.php, ManageMedia.template.php)
Title: Re: New revs
Post by: Nao on August 3rd, 2012, 12:18 AM
rev 1653
(30 files, 11kb)

+ Adding a custom confirm() rewrite using the reqWin system. This allows us to use HTML in confirm boxes, which is nice to begin with. This 'only' costs an extra 192 gzipped bytes, which is much shorter than the savings I did these last few days. Also added a we_ok string, y'never know... (Subs-Template.php, Help.template.php, index.template.php, script.js, LANGUAGES: Admin, index, ManageMaintenance, ManageMembers, ManagePermissions, ManageSmileys, ManageTopics, ModerationCenter, Packages, Post, Profile, Search, Themes)

@ I would REALLY appreciate if you guys looked into the language files (or at least through the patch...) and checked whether it's all okay. Sometimes it's confusing to me because some strings have to retain their \n because they're used in e-mails.
Ideally, I'd like to be able to remove the .replace(/\n/g, '<br>') in the confirm() rewrite...
Title: Re: New revs
Post by: Nao on August 9th, 2012, 02:34 PM
rev 1654 -- just a commit to ease my life on wedge.org... :P
(2 files, 3kb)

! Added a temporary fix for Opera 12.50 rev 1538. As you may know, Opera is my default browser and their latest alpha fixes the long-lived bug that I had to write a hack in SMF for, back in 2010. Unfortunately, that hack is no longer valid and all SMF installs are broken in that build, so I devised a slightly better way of handling line breaks. Used the opportunity to better compress that code block. My name is Nao and I like saving bytes. (editor.js)

! IE6 and IE7 don't like confirm() to be redefined without specifying its window namespace. Silly... (script.js)

+ Added reqWin support for alert(), although it's the same fight as confirm(): it can only be used successfully when within an event. I'll probably have to rename all calls to account for that... Thankfully there aren't a lot for alert(). (script.js)
Title: Re: New revs
Post by: Nao on August 16th, 2012, 05:44 PM
rev 1655
(3 files +1-4, 20kb)

@ This is a multi-part HUGE commit. It is, basically, due to my realizing that the current SVN was so much behind my CSS rewrites that it was more buggy than my local install.

+ Added support for the virtual keyword in WeCSS. It allows you to specify a CSS selector that is to be inherited by other rules, but that shouldn't appear itself in the final file. If no other selectors inherit it, then it'll be safely removed. (Class-CSS.php)

! Fixed an incredibly annoying bug that was fixed through a half-arsed attempt back in revision 562, where the generated CSS could sometimes be very different from what was expected, depending on the rule's position in the file. The problem lied in the fact that the sorting wasn't done correctly, and on top of that, WeCSS needed to do extra sorting on the target list. (Class-CSS.php)

- Got rid of the value list (deg, px, mm...) in the math plugin for WeCSS, because I realized that several new value types had been introduced since I last touched it, and I don't want to spend my life on this. So from now on, it'll only be checking for strings between 2 and 4 characters located right after a number. Seems to work well enough... (Class-CSS.php)

+ Added proper support for animation/transition/transform properties in CSS3. (Subs-Cache.php, Class-CSS.php)

+ Added support for unprefixed gradients. I'd recommend the use of angles to indicate the direction, because Wedge will automatically convert the angle between versions. (Class-CSS.php)

* Moved prefixer code from Subs-Cache to Class-CSS, because it's directly linked to the CSS preprocessor, rather than the cache system. (Subs-Cache.php, Class-CSS.php)

+ Added support for browser versions in macros, CSS filenames or CSS conditions (e.g. in skin.xml), and adapted IE to use the new system. The agent is now 'ie' rather than an exact version number, and CSS filenames should have index.ie[6].css instead of index.ie6.css for instance. The good news is, you can now easily say "IE7 or later" (ie[7-]), "IE7, IE8 or IE9" (ie[7-9]), "up to IE7" (ie[-7]) and just "IE" (ie, yep.) iOS devices will now use the iOS version as the browser version, rather than the browser version itself, because the information it gives away is more important. If you're wondering, the main reason for doing all of this was to allow for the prefixer plugin to determine precisely whether or not the current browser accepts a prefix. (Load.php, Subs-Cache.php)

+ Added an automatic cache purge function that gets called every month to remove files older than a month ago. This should allow for old browser versions to naturally disappear from the file list and avoid stressing the filesystem when accessing the cache folder. (Subs-Cache.php)

+ Added a 'hacks' file category (final name TBA) to the main CSS list, which is executed right after 'index' and 'sections', allowing skins to override an 'index' category file without having to use the 'sections' category name. If you know what I mean... If you don't, don't fret, just use 'hacks' instead of 'index' for skins if you want to be on the safe side. (Subs-Cache.php)

* Moved a couple of files around. (buttons.png, grad250.png, grad700.png)

@ Note on virtuals: this is still (very slightly) buggy, in that it seems to delete the entries in some situations, even if they're inherited. This should be easy enough to fix, as it's reproduceable on the .grad40 class. Not for now though...
Title: Re: New revs
Post by: Nao on August 16th, 2012, 05:53 PM
rev 1656
(7 files, 7kb)

* Converted default macros to use the hasBrowser() syntax. (index.template.php)

* Moved page ID hooking from the body tag to the frame div right below the content ID. This is to avoid applying page-specific styling to generic areas like the menu or the sidebar. Fixed after seeing it happen on the stats page... (index.template.php)

* Partially reverted the confirm rewrite. Although technically exciting, it wasn't solid enough and IE made it even more complicated, as always. Instead, I'm renaming the function to 'ask' and 'say' (respectively confirm and alert), and will rename manually every occurrence where it makes sense to have an improved confirm (or alert). Additionally, you can now provide a callback function, which makes sense within a non-event codeblock. (Subs-Template.php, script.js)

* Simplified JS code for error removal in error log. There was no reason to have the lastClicked variable around. Especially in Wedge with delayed events. (Errors.template.php)

* My select box now uses a proper unicode character to stand for the triangle, rather than the neat CSS triangle that still required a IE6 hack and had trouble getting aligned vertically. (sbox.js)

! Fixed a silly JS error introduced when converting to jQuery. (stats.js)

* Saved a few bytes off the weres() function calling process. (index.template.php)

! Forgot to complete a comment line in the ed
Title: Re: New revs
Post by: Nao on August 16th, 2012, 06:33 PM
rev 1657 -- the final CSS frontier.
(11 files +29-32, 46kb)

+ Added 'the' list of CSS virtuals. Nuff said, now you can safely use them in your own plugin files. (common.css, index.css)

- External files no longer need the extra inline-block mixin. (admenu.css, editor.*.css)

* Renamed all CSS index files to 'hacks' when they're actually intended to be listed *after* the 'sections.css' file category, mostly in sub-skins. (The category for the main file list are listed in that order: common, index, sections, hacks, custom.) (index.*.css, hacks.*.css)

! An AWFUL lot of fixes for Internet Explorer, mainly in sub-skins. Because I'm not spending my days testing these silly browsers, or even my sub-skins for that matter... Just gonna add: it's not perfect (mini-menus still don't work), but it's damn more than what its old versions deserve. (hacks.ie[*].css)

* And even more tweaks for all browsers, making Weaving (and sometimes sub-skins) look better overall. Things like backgrounds, reqWin popups, gradients have all been overhauled... And possibly broken in places. It's a major rewrite, and it's working for me. Good enough for a commit! (*.css)
Title: Re: New revs
Post by: Nao on August 16th, 2012, 11:12 PM
rev 1658
(4 files +2-2, 4kb)

* Admin homepage no longer needs to declare inline-block class on every item. Also added a plugin_from class to the plugin page to avoid using the class in HTML. (Admin.template.php, mana.css)

* Using a hardcoded style is bad... Well. Whatever. (Profile.template.php)

! Typonazi. (skins/Wireless/hacks.css)

! Fixed Wireless by renaming sections.* to hacks.*... I know, it's quite complicated. (skins/Wireless/hacks.*.css)
Title: Re: New revs
Post by: Nao on August 17th, 2012, 12:26 AM
rev 1659 -- back to short commits... Phew :) :)
(1 file, 1kb)

! Fixed mini-menus in IE6. (hacks.ie[6].css)
Title: Re: New revs
Post by: Nao on August 17th, 2012, 10:10 AM
rev 1660
(1 file +26-26, 24kb)

* Renamed 'hacks' CSS filename category to 'extra', which is probably more neutral and better suited to both sub-skin additions and browser hacks. (Subs-Cache.php, hacks.*.css, extra.*.css)
Title: Re: New revs
Post by: Nao on August 18th, 2012, 10:05 AM
rev 1661
(3 files, 3kb)

! Fixed handling of @keyframes in WeCSS. (Class-CSS.php)

! Fixed a bug in surroundText() that made it fail when called with an empty selection (e.g. smart quote splitter.) (editor.js)

! And fixed another bug in surroundText() that made the focus go to the end of the post because of a last-minute pre-commit optimization -- you know, my biggest flaw. At least I'm aware of it. (editor.js)

! Bytesizenazi. (editor-func.js)
Title: Re: New revs
Post by: Nao on August 20th, 2012, 06:43 PM
rev 1662 -- a couple more are coming up.
(1 file, 1kb)

! Undefined variable in keyframes fixer. Woops. (Class-CSS.php)

+ Added support for fallback conversion from standard to prefixed syntax in radial gradients, allowing you to provide only the 'at' syntax. (Class-CSS.php)

! CSS transitions are not limited to the 'transition' keyword. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on August 20th, 2012, 06:48 PM
rev 1663 -- and a couple more are coming, as always it's sorted thematically...
(5 files +10-10, 10kb)

* Removed fallback gradient from the index CSS file (as allowed by the previous commit), and optimized/fixed a couple of other gradients. (index.css)

* Renamed all *.ie[6].css (or other versions) to *.ie6.css, because on a philosophical level, the brackets should really only be used for providing ranges. (*.css, skin.xml)

! Fixed inverted gradient in Zoomedia. (zoom.css)
Title: Re: New revs
Post by: Nao on August 20th, 2012, 06:49 PM
rev 1664 (one left to commit -- the JavaScript stuff -- probably not coming immediately though.)
(2 files, 7kb)

* Simplified, strengthened and sped up the hasBrowser function, by a very decent factor! So, now you can use index.ie6,ie7.css if you want, or index.ie[6-7].css, or index.ie[-7].css. Or even index.ie6,firefox[-15],safari[5-].css or whatever you want, really. I'm not going to judge you. I have issues of my own. (Load.php, Subs-Cache.php)

* Reworked detectBrowser() in a similar fashion. Chromium always provides a Chrome version number so we don't need the Chromium detection. Chrome for iOS, however, provides CriOS instead of Version, so I'm now accounting for that. Version numbers are now simplified to the first significant sub-version. For instance, v2.01 would be recorded as '2', v2.1.7 as '2.1' and v2.50.3 as '2.5'. If browser makers don't start screwing up with version numbers, everybody should be happy. Especially me. (Load.php, Subs-Cache.php)
Title: New revs
Post by: Arantor on August 20th, 2012, 09:12 PM
(9 files, 4KB)

Revision: 1665
Author: arantor
Date: 20 August 2012 20:11:13
Message:
! [SMF bug] XSS vulnerability in moderation log (thanks Anonchair) (Modlog.php)

! Since we're no longer escaping quotes in topic subjects to save space, we do at least need to do it in the topic view, mostly for the benefit of quick reply where there are quotes in the subject. (Display.php)

! Very primitive/limited page in admin for configuring likes. It is the plan to add other stuff, like thoughts, into the same page. It allows for enabling/disabling likes and limiting people from liking their own posts. (install.sql, Admin.php, Display.php, Like.php, ManageSettings.php, Display.template.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql
Title: New revs
Post by: Arantor on August 20th, 2012, 10:59 PM
(5 files, 2KB)

Revision: 1666
Author: arantor
Date: 20 August 2012 21:58:28
Message:
! Updated BB implementation for 2.2.8 (or at least the bits I actually want) (Security.php)

! Don't limit the size of the mail queue items. It's possible that announcements/notifications could be larger than a text. (install.sql, Subs-Post.php)

! The subject should also be quote-protected in the split page area too. (Split.php)

! Merge topics dropdown was using old code. (Merge.template.php)

! Merge topics might also use the same dropdown style as other dropdowns, using optgroups for categories. (Merge.template.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Merge.template.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on August 22nd, 2012, 10:02 AM
rev 1667
(2 files, 3kb)

! Fixed some specific cases of cascaded selector inheritance (CSI?!) that simply failed. This was a purely logic error and one that took days to spot, and a few lines to fix. As usual with my bugs. The good news is, this should also speed up the extension code by a fair margin, as it reduces the size of the base list, and also drastically shortens the code path for deep inheritors. It's good now. Look at me I'm all weepy. (Class-CSS.php)

- Removed a few pass-by-reference optimizations that were only there for performance, when really with the copy-on-write mechanism it's more likely to make processing slower. By a nanosecond, of course. (Class-CSS.php)

- WeCSS no longer needs to look for prefixes in keyframes when it parses them. This is unrelated to the auto-prefix code itself. (Class-CSS.php)
! Forgot to commit my index CSS from a few commits ago. (index.css)
Title: Re: New revs
Post by: Nao on August 22nd, 2012, 10:54 AM
rev 1668
(9 files, 2kb)

! The Opera hack for keyboard handling in select boxes no longer works in v12.5 because they rewrote and fixed their keyboard event code. Meaning I have to hack even more into it, ah ah... (sbox.js)

* I'm not sure why I kept using .filter(':first') instead of .first() in some place... The latter is faster, simpler and cleaner. Same for .last() and even .children(':first') is better off as .children().first(), thank-you-very-much. (sbox.js)

* Fixed a couple of remaining list() calls into list (), because of its non-function nature. (Class-UnitTest.php, Like.php, getid3)

* Translation. (Admin.french.php, ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on August 22nd, 2012, 04:45 PM
rev 1669
(5 files, 2kb)

! IE10 didn't actually get the unprefixed version of gradiant CSS. Oops. (Class-CSS.php)

- Shortened quick topic edit code. Can anyone tell me if there's any reason to believe $topic's topic ID or first post ID could be empty or non-numeric..? (MessageIndex.template.php)

* Replaced a couple of ID searches with $(this) in case of events called from within a named form item. Well, I could also remove the ID as a result, but I'm not sure it'd be for the best. Or, in French, "I don't have time to test for that, anyone up for it?" (ManageBoards.template.php, Merge.template.php, Profile.template.php)
Title: Re: New revs
Post by: Nao on August 23rd, 2012, 12:21 AM
rev 1670
(5 files, 3kb)

* Converted the CSS variable code to accept the new hasBrowser system. I think it's all that was missing..? (Class-CSS.php)

! A bytesize optimization for IE resulted in select boxes being broken. Ah, where doeth my mind wander... (index.template.php)

! The .wrc class being so generic, should, I believe, or at least I should hope so, be setting its box-sizing to border-box so that its custom padding doesn't screw up any layout. Of course with my current luck, it'll probably end up breaking something else... As long as it's just a Ming vase, I'm fine with it. (index.css)

* Sometimes, I'll have a look at some code and think, 'what was that developer trying to do?'... And then I'll figure, 'okay, there's an easier way to do that...' One of these things happened today, with a bizarre substr test that could just be trimmed down to a '.indexOf(var) == 0'... SMF is like a gold mine. I always find something to dig into, and I'm ready to spend hours just to save a couple of gzipped bytes. My very own personal nuggets. (admin.js, script.js)
Title: Re: New revs
Post by: Nao on August 23rd, 2012, 09:46 AM
rev 1671 (keyboard shortcuts & post preview tweaks. Could have been split into two commits, had I been more careful...)
(10 files, 9kb)

+ Post pages now implement keyboard shortcuts while editing *for all browsers*: Alt+D (draft), Ctrl+B (bold), Ctrl+I (italics) and Ctrl+U (underline), along with the previous Alt+P (preview) and Alt+S (submit). Up until now, and that was also the case in SMF, they were only supported in non-Wysiwyg in Firefox, or everywhere in Wysiwyg but undocumented. It just needed a bit more work to make all shortcuts usable everywhere in non-Wysiwyg, the first action being to remove the is_ff test, ah ah. And of course, using proper jQuery-powered events. (editor-func.js, editor.js)

* Simplified the JS code for shortcuts and Ajax parsing in the editor. A LOT. Close to an unzipped kilobyte of code was happily stripped away from the file (which I reckon sounded better than 'over 150 bytes of gzipped code'.) Optimized post-Ajax code by using jQuery instead of getElementsByTagName. Event bubbling is handled in a single instruction by jQuery. Also, SMF seemed intent on doing a lot of stuff (it even mentions it in a comment) to simulate a Submit button click, when it could just have, ahem... called .click() on the button itself. Plus it's a mandatory method in HTML5, it handles onsubmit as well, and is available for all browsers in jQuery anyway. (editor.js)

* Updated language strings to reflect the current state of keyboard shortcuts. Removed the Opera and Firefox special cases, and stopped bothering with the accesskey stuff. I'm not removing the accesskey (you never know), but I'm not going to document them. (PersonalMessage.template.php, Post.template.php, Post.language.php, editor.css)

! Fixed post preview not working in IE 6/7 because of some bad CSS property targeting: just using 'border' could return 'undefined' if not set specifically, while 'border-color' always returns something. I could have gotten away with doing an implicit string conversion, but let's do it properly instead. (post.js)

* Improved post preview styling. (Post.template.php, editor.css, extra.ie*.css)
Title: Re: New revs
Post by: Nao on August 23rd, 2012, 07:30 PM
rev 1672
(3 files, 3kb)

+ The Skin Selector will now provide the number of users for each skin (in addition to the global number for their theme.) That wedge_get_skin function is short and sweet, but getting the reference return to work was a PITA... If someone could look into the logic of it and spot any superfluous ampersands, that would be swell... (Themes.php, Themes.template.php)

* Spacinazi. Just two bytes... For a file we'll end up removing. (upgrade.php)
Title: Re: New revs
Post by: Nao on August 23rd, 2012, 07:35 PM
rev 1673
(4 files, 5kb)

+ Added a new section to the stats page, 'most liked posters', which does what it says: it shows the authors who got the most 'likes' on their body of work. Now if this is going to be a controversial move, please tell us so. As of now, if seems rather harmless and may encourage quality posts. (Stats.php, Stats.template.php, Stats.language.php)
Title: Re: New revs
Post by: Nao on August 23rd, 2012, 07:48 PM
rev 1674
(2 files, 1kb)

* Modified board/message index behavior to only set the board icon to its 'new' state if it directly has new topics in it. Sub-boards already have their own 'new' badge anyway! Smallest commit in days. Size doesn't always matter. (Boards.template.php, MessageIndex.template.php)
Title: Re: New revs
Post by: Nao on August 24th, 2012, 04:54 PM
rev 1675
(7 files, 4kb)

! Wuthering was a bit broken in modern browsers by my IE fixes. I know, known song -- should try everything thoroughly before I commit... Decided to simplify the code and use the IE code everywhere instead. It looks just the same and is shorter. (Wuthering/extra.css, Wuthering/extra.ie[-9].css)

! Fixed blockquote backgrounds in Warm. (Warm/extra.css)

! Fixed background in topic lists in Wine, Warm and Wuthering. A disappointing little oversight that pretty much broke these pages entirely... Not sure why no one reported it in the first place. (Wine/extra.css)

* Don't waste time trying to analyze CSS suffixes when there's none in the first place! (Subs-Cache.php)

* Simplified variables in editor CSS. (editor.css)

* Added a todo note to myself... (Class-CSS.php)
Title: Re: New revs
Post by: Nao on August 25th, 2012, 12:03 AM
rev 1676
(1 file, 2kb)

* This is the annual fix list for Aeva, yay... Well, just kidding, I've only done some work on YouTube. Arguably the most important one... (media/Subs-Aeva-Sites.php)
  On today's menu:
  - Now using the iframe version of YouTube embeds (for single videos and playlists), which should at last allow smartphones to view videos.
  - Fixed support for YouTube playlists, including the new URL type.
  - Wedge will no longer attempt to load and show titles for YouTube and Vimeo -- YT started showing them in the thumbnail around the time the feature made its way into Aeva, and it was heartbreaking for me... But you've got to live with your time.
Title: Re: New revs
Post by: Nao on August 26th, 2012, 12:34 AM
rev 1677
(6 files +1-1, 3kb)

* YouTube Playlist embedding should be more forgiving of odd URLs. (Subs-Aeva-Sites.php)

* Now that all browsers can target a specific version in CSS, renamed extra.gecko.css to reflect the fact that the hack in question is for Firefox 2 and below! (extra.gecko.css, extra.firefox[-2].css)

! Fixed mini-menus in IE7 and iOS, like I did for IE6 last week. I just didn't realize the same issue was there... Also saved some space in IE6 CSS and Warm. (extra.ie*.css, extra.iphone.css, Warm/extra.css)

! Fixed code blocks being broken by a known bug in IE8. (extra.ie8.css)
Title: Re: New revs
Post by: Nao on August 29th, 2012, 04:18 PM
rev 1678
(3 files, 2kb)

! SSI was broken since a commit made a year ago... Interesting. Well, not that much broken, you just need to change your starter code to just this: require_once('SSI.php'); ssi_run();[1], where ssi_run() is the new (more telling) name of ssi_shutdown(). So, this is effectively easier, but you also need to wrap your actual page code inside a template_main() function. Also removed $ssi_layers as using the wetem object is more flexible. (SSI.php)

! Fixed a missing default 'checked' when creating a new poll. (Post.template.php)

- Minor class cleanup. (Wuthering/extra.ie[-9].css)
 1. For instance, the license page for Wedge has this...
Code: [Select]
<?php
error_reporting
(0);
require_once(
'SSI.php');
ssi_run();

function 
template_main() {
?>


Your HTML code...

<?php
}
?>
Title: Re: New revs
Post by: Nao on September 1st, 2012, 12:25 AM
rev 1679
(3 files +1-1, 9kb)

* Modified database structure to help future developments to custom boards and membergroups. id_board and id_group both went from smallint(5) to mediumint(8) (unsigned for boards, signed for groups.) Contact lists are now unsigned. Cleaned up more fields like UNIX timestamps that were often recorded as int(11) signed instead of int(10) unsigned. Added a few 'default 0' where needed. The media tables now get more realistic, with unsigned fields where needed, less int fields where not needed, etc. (install.sql)

+ Added default support for a few more file types in media documents: diff/patch (for developers), mht (generic cached HTML), torrent (it doesn't have to be illegal), and srt/ssa (for fansubbers etc.) I'm not adding ass to the list. People may think the forum admin is dirty. (install.sql)

+ Added default support for a few more file types in attachments: diff/patch, rtf, rar, 7z, docx, and removed mpg files (usually too large anyway.) (install.sql)

* As requested, replaced the classic YouTube embed link with the no-cookie version. Untested, though. (Subs-Aeva-Sites.php)

+ Added animations to MoveTopic pages. (MoveTopic.template.php)

* Renamed extra.gecko.css to extra.firefox[-3.6].css, to avoid processing an old CSS hack on recent Firefox versions. (extra.firefox[-3.6].css)
Title: Re: New revs
Post by: Nao on September 1st, 2012, 11:32 AM
rev 1680
(8 files, 7kb)

@ This commit adds my hacks and fixes to the BBC parser that pretty much makes quotes work better than anywhere else (provided you supply them with clean CSS and collapsible margins.)

* Rewrote more BBC parsing code. Optimized whitespace discovery in trim_wspace code. Optimized footnote handling (by a tiny bit.) And other minor fixes. (Subs-BBC.php)

* Rewrote loadSource() to add an extra layer of filename caching. This should be about twice faster than directly calling require_once, but only in critical situations. So, yeah, basically you could say that it's useless. Still, it should be faster than even a function_exists() call, so it helps here and there, too. (Load.php, PersonalMessage.php, Post2.php, Subs-BBC.php, Subs-Media.php, Subs-Template.php, Subs.php)

+ Added a quote handler hack to trim whitespace inside and around them. Reset database trim settings for them as well, as there's no need for them to go through more code. (install.sql, Subs-BBC.php)
Title: Re: New revs
Post by: Nao on September 4th, 2012, 02:49 PM
rev 1681
(14 files +2-3, 12kb)

* Rewrote window resizing code. Instead of JavaScript (which always added about 150 bytes per page), we'll now be relying entirely on media queries, which feel more natural in this case. Moved the responsive CSS from index.css to a new extra.css file (well, it's new for Weaving), although it's totally not needed so I may change that in the future. Doesn't work in IE6 for now, and sub-skins have yet to be committed (it's working, but it's not ready yet.) (index.template.php, index.css, sections.css)

@ There are a few caveats involved in media queries compared to my earlier #responsive implementation -- first of all, extending a class inside a media query is impossible, because you can't target it outside of a media query (@media keywords don't act like a selector themselves). Also, #responsive targets any changes in the main div's width, while @media will only see changes to the window/tab width, so you need to take sidebar width into account, and if for instance you change its width without changing the window size, the sidebar won't be moved. Finally, precedence order is no longer the same, as @media selectors don't change priority in source order, so you'll have to either be very careful with sub-skins, or use tricks like targeting an upper ID first inside the media query. This is what I'm doing right now, may change if it causes other issues: the media query targets 'body #edge' for instance, so if you override #edge later in your sub-skins, the media query won't get in your way. You will, however, have to target #wedge #edge as well if you need to rewrite #edge in a sub-skin's media query. As unlikely as it sounds.

* Due to the above, reverted the window.weres test in sbox.js to use window.eves instead, and made sure that eves is always set (i.e. if there are no delayed events, it's set to 1 regardless.) (Subs-Template.php, index.template.php, sbox.js)

* Deleted whitespace from all menu code. While it was 'nice' to have these properly indented, it's still my #1 goal to save bandwidth, especially at the beginning of a page. If a HTML page isn't gzipped, it can save up to 1.5KB on admin pages! Plus, it saves us a CSS hack akin to text-space-collapse, and it makes it easier to just skip to the proper content when you're examining the source code. (GenericMenu.template.php, index.template.php, index.css)

* Renamed latest-packages to latest-plugins. Even though the feature is disabled for now, it's no reason not to update the terminology... (other/xml/latest-plugins.php, Packages.template.php)

* Added support for newest version of the skin selector plugin. (Themes.php)

* Commented out the alert/confirm variations, as I'm not using them for now, and we might as well saved the compiled space... This will be for a future version, I'm afraid. (script.js)

* Changed extra.firefox[-2].css prefix to common.*, so that the inline-block fix is also applied to non-main CSS files. Eh. (*.firefox[-2].css)

! Fixed a couple of issues with the error log layout. (Errors.template.php, mana.css)

- Deleted duplicate hacks from IE6 and IE7 specific files. (extra.ie6.css, extra.ie7.css, editor.ie[-7].css)

* Commenazi. (Poll.php, index.css)
Title: Re: New revs
Post by: Arantor on September 4th, 2012, 08:59 PM
(7 files, 5KB)

Revision: 1682
Author: arantor
Date: 04 September 2012 19:58:45
Message:
! No need to check for the old installed-packages list being writable in the installer. (install.php)

! Can't have a default of -1 for an unsigned column, making it signed for the time being until we can establish whether -1 is a valid value for that column anyway. (install.sql)

! Allow custom fields to be displayed on the member list. Only one extra query, too. (ManageMemberOptions.php, Memberlist.php, Memberlist.template.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Title: Re: New revs
Post by: Nao on September 5th, 2012, 11:53 PM
rev 1683 -- seriously hoping I didn't commit anything unneeded or undocumented...
(12 files -2, 12kb)

* Replaced arrow images (in linktree and menus) with CSS content. This saves a few dozen bytes at compression time, and is much, MUCH better in terms of code logic. For instance, we no longer need to add extra padding. Plus, there are two new classes (.vertical-arrow and .horizontal-arrow) and yes, they're re-usable. As usual, support is only provided for Weaving for now. (index.template.php, common.css, index.css,

- The extra.firefox[-3.6].css file in Wine was no longer needed, as the sidebar is now pushed to the bottom... (extra.firefox[-3.6].css)

- Removed a few IE6/7 hacks related to the arrows. Basically: nope, arrows no longer show up in these browsers... But I don't think it's worth wasting time (and bandwidth) trying to support these old browsers. (extra.ie6.css, extra.ie7.css, Wuthering/extra.ie6.css)

+ Added a nice radial gradient to IE9 menus. Actually, it's the only browser that seems to perform well with intensive inset box-shadows, so, for once, IE9 is going to look better than any other browser... (extra.ie9.css)

* Updated documentation in the index.css header to add the latest suffixes supported. (index.css)

! Fixed wrong CSS being generated if two @media keywords were used in a row. Hopefully that doesn't break anything else... This feature needs some serious checking. (Class-CSS.php)

* Translation. (ManageSettings.french.php)

* Spacinazi. (Wireless/extra.iphone.css)
Title: Re: New revs
Post by: Nao on September 6th, 2012, 04:21 PM
rev 1684
(7 files, 9kb)

! Help popup titles were broken by the resizer code change. Don't ask -- don't tell. (Subs-Template.php)

! Fixed responsive mode on iOS. Yeah, contrary to popular belief, responsive isn't just for mobile... Otherwise it would be called mobile mode or something. (extra.iphone.css)

! Fixed responsive mode in sub-skins. (Warm/extra.css, Wuthering/extra.css)

* Overhauled parts of the menu CSS, mostly to simplify it. It worked. Also fixed anything in sub-skins due to the menu rewrite. (common.css, index.css, Warm/extra.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on September 7th, 2012, 12:18 AM
rev 1685
(5 files, 3kb)

+ Added WeCSS support for '!' character in selectors -- this is a new one from the CSS4 drafts, marking the subject (desired target) of the selector, our developer dreams come true (believe me.) (Class-CSS.php)

* Managed to harmonize the arrow size across all my test browsers (let's be clear: Opera, Firefox and some IE just to be sure), without increaing the filesize too much. (common.css, index.css)

! Magically found a workaround for menu text overlapping the arrows in IE9... Just needed to add overflow:hidden to the container. And it doesn't seem to break anything else. A little prayer maybe..? I'm sure that'll help. (index.css)

! Fixed plenty of problems with various IE versions in the Wuthering skin. Yeah, not my favorite skin, and not my favorite browser -- no wonder I didn't test that case thoroughly... (Wuthering/extra.css, Wuthering/extra.ie[-9].css)
Title: Re: New revs
Post by: Arantor on September 7th, 2012, 03:31 AM
(3 files, 4KB)

Revision: 1686
Author: arantor
Date: 07 September 2012 02:30:13
Message:
! There are certain permissions that guests and regular members should never have. (ManageMembergroups.php)

! Clean up the dropdown for quick moderation, now it's accessible through the main message index hook (can't yet extend behaviour, just the displayed dropdown), and saves a bit of code on the side. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Title: Re: New revs
Post by: Nao on September 16th, 2012, 06:57 PM
rev 1687 -- huge commit, splitting the changelog into three for your convenience!
(22 files +6-2, 39kb)

Cache changes:

+ After I decided to add version numbers to the CSS file URLs, I realized that in production, the number of variations was much higher than I expected, making for hundreds of files quite quickly. As retaliation, I decided to split the CSS files into multiple folders, and one thing led to another... Reverted /cache/data to /cache, and created new cache folders /css and /js. This is helpful in several ways: first of all, it saves a couple of bytes off each page header, it prevents users from seeing a URL with the name 'cache' in the HTML source, and it allows for better dispersion of files. The css folder, notably, can have sub-folders, allowing for nearly unlimited skins to be added. Also moved $cachedir validity tests directly to Settings.php. (cache/*, css/*, js/*, Subs-Cache.php, index.php, SSI.php, install.php, QueryString.php, Subs-BBC.php)

@ I don't know if $cssdir and $jsdir are really needed because I'm hardly going to have a matching $cssurl/$jsurl system, so I might as well force them to be at the root...?

! Cache folders weren't allowing index.php to be executed, causing their redirect code to be worthless... (cache/.htaccess)

Wess changes:

* Renamed WeCSS to Wess. What do you know, I wrote it, I can do whatever I want with it, ah ah. Next week I'll rename it to LlamaBurp, and next year it'll be TheCssPreprocessorFormerlyKnownAsDidYouHideMyRemote?IncludingTheQuestionMark. (Subs-Cache.php, Class-CSS.php, editor.css)

@ Rewrote clean_cache() function to support recursive calls (e.g. cleaning up all CSS sub-folders), and cleaning up by last modified date. (Subs-Cache.php, ManageServer.php)

+ In addition to 'mixin: mixin-name', you can now mix any selector into another, just like extending it would do. Please try and keep these selectors simple though, it could get messy otherwise. Now the only difference between using plain selectors and @mixin declarations is that the latter allows you to specify parameters, unlike classes and so on. Well, until I get to support them with a 'params' keyword or something...? Anyway -- just keep it low for now, I'm only doing this to easily mix .inline-block into media queries. What a mess. (Subs-Cache.php, Class-CSS.php, sections.css)

+ Added support for new keyword, 'mixes'. Which, guess what, behaves exactly for 'mixin:' as 'extends' does for 'base:'. Have fun. (Class-CSS.php)

+ Added new @is() function. The first parameter should be a browser, browser with version or quoted comma-separated list of browsers, the second parameter (usually between quotes) has the resulting content if the user is using that browser (or another function like RTL etc), and the third parameter has the content for failed matches, quite obviously. Also features of my most amusing regexes of recent times. So, basically, @is() is just like {}, except you're not limited to mixin and variable declarations. It's very likely that I'll remove the {} hack in the future. (Class-CSS.php)

! Fixed bug where the extends or unextends keywords could be ignored when inserted at the end of a file. (Class-CSS.php)

* Simplified smiley CSS files to only include something extra in the filename if the browser (i.e. IE < 8) doesn't support base64 encoding. (Subs-Cache.php, Class-Editor.php)

* Rewrote {%dynamic_function:paramlist%} to be cleaner. You should now use @dynamic dynamic_function(paramlist) instead. And you don't have to mess with $match in your params again if your dynamic function doesn't need parameters. (Class-CSS.php, admenu.css, index.css)

* Renamed ifnull() to @ifnull() because it's a conditional, like a media query. (Class-CSS.php, index.css)

Other changes:

* Replaced button bevel with a more convenient box shadow. (index.css, bevel.png)

* And generally rewrote buttons to use box shadows instead of gradients. Which has the added benefit of working in IE9. (index.css)

* Replaced hardcoded inline-block emulation for media queries with a mixin call to the .inline-block class... This is a smart way of emulating extends when within a media query that, by definition, doesn't accept any external influence and thus doesn't accept the 'extends/base' keyword. (sections.css)

* Opera 12.50 was renamed to 12.10, so updated Wess to reflect that. (Class-CSS.php, editor.js, index.css)

! [Semi SMF-bug] Fixed regression from revision 941 which made Settings.php stop executing before the end. That was due to a friggin' exit call at the end of a line that's still present in SMF 2.1, FWIW. Hence the tag. (Please push it to the next line to avoid any discomfort.) (Settings.php, ...)

! Some fixes for Wuthering. More fixes coming later -- the recent rewrites have again added more glitches to sub-skins. (Wuthering/extra.css, Wuthering/extra.ie[-9].css)

- Removed that nice little average() function call for IE9 menus... Now that it's using box shadows, it's no longer needed, and no longer used in Wedge, but I will always insist on keeping that function available to themers. (index.css)
Title: Re: New revs
Post by: Nao on September 16th, 2012, 09:17 PM
rev 1688
(3 files, 1kb)

! Fixed a couple of places where I forgot to update the URL for smileys. (Class-Editor.php, Subs-BBC.php)

! Fixed undefined index error in member list. Well, applied Pete's fix. (Memberlist.php)
Title: Re: New revs
Post by: Arantor on September 17th, 2012, 02:54 AM
(6 files, 22KB)

Revision: 1689
Author: arantor
Date: 17 September 2012 01:54:03
Message:
! Rewrite of quick moderation to 1) not be completely lame and 2) to be almost totally extensible. It's probably got some niggly bugs regarding own/any permissions, I haven't tested it that heavily. Also created a new hook for both extending the selectbox (seeing how it appears in search) and the main message index specifically and updated everything to go with it. (ManagePlugins.php, Merge.php, MessageIndex.php, QuickMod.php, Search2.php, Search.template.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Merge.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Themes/default/Search.template.php
Title: Re: New revs
Post by: Arantor on September 17th, 2012, 04:13 AM
(4 files, 6KB)

Revision: 1690
Author: arantor
Date: 17 September 2012 03:13:08
Message:
! Add new type to the configuration settings setup to allow plugins easy configuration to boards in bulk. It's also in the main plugin settings-page stuff, too. (ManageServer.php, ManageSettings.php, Admin.template.php, plugin-info.rng)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on September 17th, 2012, 02:13 PM
(3 files, 1KB)

Revision: 1691
Author: arantor
Date: 17 September 2012 13:12:42
Message:
! (SMF bug?) Missing " in Search template. (Search.template.php)

! Don't show the "send topic starter a PM" option when moving a topic if it's their own topic. (MoveTopic.php, MoveTopic.template.php)
----
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Search.template.php
Title: Re: New revs
Post by: Arantor on September 17th, 2012, 02:39 PM
(3 files, 1KB)

Revision: 1692
Author: arantor
Date: 17 September 2012 13:38:54
Message:
! Sometimes fields were demanded of users when not even shown to them. (Profile.php)

! Custom fields with a mask would in practice always be required even if set not to be, since a blank string wouldn't match the mask. (Register.php)

! Cruft related to old time offset. (Register.php, Register.template.php)
----
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php
Title: Re: New revs
Post by: Arantor on September 18th, 2012, 01:45 AM
(4 files, 2KB)

Revision: 1693
Author: arantor
Date: 18 September 2012 00:44:48
Message:
! New hook for extending the moderation log. (ManagePlugins.php, Modlog.php)

! Prettying up the merge topics screen by having boards actually indicate their depth. (Merge.php, Merge.template.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Merge.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Themes/default/Merge.template.php
Title: Re: New revs
Post by: Nao on September 18th, 2012, 03:43 AM
rev 1694
(10 files -1, 3kb)

* Upped minimum PHP version from 5.2.3 to 5.2.4... Everyone is using 5.3 or 5.2.17+ these days anyway... (install.php, readme_*.html, upgrade.php...)

* ...And all that, just so we can use \h instead of [\t ] in regexes. That's just Nao for you. (Class-CSS.php)

! Moved wess_if plugin closer to the beginning of the stack. Technically, an @is (browser) call should be done before mixins are processed, because the browser name and version is a global, never changes, and thus *when* it's executed has no influence over the outcome. (Subs-Cache.php)

* @is is cool... I think?! At least it allows me to remove some short files that only contain a couple of entries. (zoom.css, zoom.ie[-7].css)
Title: Re: New revs
Post by: Arantor on September 19th, 2012, 04:47 AM
(4 files, 9KB)

Revision: 1695
Author: arantor
Date: 19 September 2012 03:47:02
Message:
! Added permissions management directly from the plugin files. (plugin-info.rng, ManagePermissions.php, ManagePlugins.php, Reports.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on September 19th, 2012, 10:46 AM
rev 1696
(2 files, 4kb)

* There are times in life when it's time to say it's okay. So, it's okay to commit my Aeva changes, even if I can't for the life of me remember the logic behind them (I do remember, however, the need I had to fix autolink and protection bugs). So, it's a major simplification of the protection process, I don't know if it's going to create new bugs, but it's been in use at wedge.org for many months and I haven't seen anyone complain, so let's say it's all right. I'll deal with the aftermath later. Or just revert. (Aeva-Embed.php, Subs-BBC.php)
Title: Re: New revs
Post by: Arantor on September 19th, 2012, 03:27 PM
(2 files, 2KB)

Revision: 1697
Author: arantor
Date: 19 September 2012 14:27:28
Message:
! Stupid bug in permissions code when there aren't any enabled plugins. (ManagePermissions.php, Reports.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php
Title: Re: New revs
Post by: Nao on September 19th, 2012, 06:05 PM
rev 1698
(5 files -1, 5kb)

* hasBrowser() now supports any $browser['is_*'] variable, including the OS ones. You can also freely add spaces between the brackets. Finally, added a $browser['is_mobile'] that reflects $user_info['is_mobile']. Use it with care, especially in skin files! It's not a toy. (Load.php)

! In some situations, CSS cache files could start with a dash (most likely, a bot trying to access your forum). I felt an urge to have this heresy cleaned up. (Subs-Cache.php)

* Cleaned up IE 6/7 to add their short custom crap directly to common.css instead of an extra file. Actually, I think I already cleaned up these files before and forgot to update the main one... Anyway, something interesting: as @is is run before most of the other Wess plugins, you can include root-level classes in a test that's inside a non-root element... How cool is that? No? Please? (common.css)

* Restored use of average() for menu gradients, this time for IE 6-8 instead of IE 9... How silly. (index.css)

* Replaced selectbox buttons with box shadows in IE9. It's always better than a PNG image... (index.css)

* More minor cleanup. (extra.firefox.css, extra.ie10.css, extra.iphone.css)
Title: Re: New revs
Post by: Nao on September 20th, 2012, 07:23 PM
rev 1699
(6 files, 2kb)

* Another update that stayed in my local install for a long time... Overhauled the search page UI to go from 'quite ugly' to 'watchable'. Many changes, although in the end most of it is under the hood, I guess. (Search.php, Search.template.php, Search.language.php, index.french.php)

* Just adding an extra comment to the macro area in the index template... I believe it's needed to explain what it does in this case. (index.template.php)
Title: Re: New revs
Post by: Nao on September 21st, 2012, 06:02 PM
rev 1700
(9 files -2, 5kb)

* Wine now uses a minor hack to switch the sidebar position, removing the need to provide a new skeleton in the skin file, as well as updated macros. You can still view sample macros and skeletons in the Warm skin, which is pretty much there precisely for that reason... Also updated Warm and Wuthering to react correctly. If you look closely, you'll see that Wuthering redefines #sidebar but this is needed, as currently Wess will remove items from classes listed in @remove, regardless of whether there are other classes using them. Rewriting Wess any other way would make it way too complex. Finally, wanted to say that since Warm redefines the HTML layout it won't react to it properly anyway, it should be repositioned slightly differently. I've indicated how in an extra.css comment as well. (Wine/extra.css, Wine/skin.xml, Warm/extra.css, Warm/skin.xml, Wuthering/extra.css)

- Are IE6/7/8 users really worth showing a subtle gradient in select box buttons...? Would they even notice it? No, I don't think so. That saves us about 100 gzipped bytes per CSS file. (select_arrow_bg.gif, select_arrow_bg_hover.gif, extra.ie[-8].css)

! Shortened clearfix for IE 6/7. While not exactly critical here, I've still decided to write a proper version... And it's shorter than for other browsers, for once. Also, fixing clearfix additions that were badly handled -- for some reason, they were using spaces instead of tabs. (common.css, extra.ie6.css, extra.ie7.css)

* Now using box shadows instead of gradients for Wine headers. They're too small to have any strong impact on browser rendering performance, I'd say. Also fixing inline blocks in responsive layouts. (Wine/extra.css)
Title: Re: New revs
Post by: Nao on September 22nd, 2012, 03:39 PM
rev 1701 -- the cleanup rev, + @if at last! I'm seeing the end of the tunnel!
(4 files, 9kb)

+ Added @if function to Wess. The difference with @is is in the syntax: "@is (test, true, false)" can be done inline (so basically it's an @inlineif), while "@if test" is on its own line, and should be followed by an @endif on the same tab level, with a potential @else in between. This should allow for cleaner tests. And just like @is, they're nestable. Replaced a few @is calls with @if. (Class-CSS.php, common.css, index.css)

* Made more functions stricter when it comes to whitespace (i.e. not accept linebreaks within their declarations): rgb(a), hsl(a), gradient, @import, @charset, @mixin, mixes, properties, reset, virtual, unextends (extends was already done this way), final, @remove, @dynamic, @ifnull, @is and @if. Also on variable declarations, which made me realize that their regex is a bit flaxed, someone please remind me to rework it. (Class-CSS.php)

@ Note: I've compiled a before/after version and the result is the same, so it's probably bug-free.

+ Added more support for @is and @if to manage variables, but it's still not built in. The idea is to call the plugin twice: once before the mixins, to do the globals, and once after, to deal with local variables mostly. And no, this isn't ready yet. Dunno if it'll even be ready before the first release. (Class-CSS.php)

* Some cleaner code in the media quota edit page. (ManageMedia.php)
Title: Re: New revs
Post by: Arantor on September 22nd, 2012, 05:07 PM
(3 files, 7KB)

Revision: 1702
Author: arantor
Date: 22 September 2012 16:02:20
Message:
! Cleaner behaviour with respect to scheduled tasks in the event of a task being disabled, or if the installation moves folders/servers, by using the master folder listing rather than having the path in the DB. (ScheduledTasks.php, ManagePlugins.php)

! When disabling a plugin, check for any plugins that rely on the current plugin's hooks and refuse to disable it if any dependent plugins are found. (ManagePlugins.php, ManagePlugins language file)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php


For the first case, this should not be any problem for any current Wedge user. The only time there is an issue is if a plugin has declared a scheduled task - to the best of my knowledge, there are only two plugins that currently declare a scheduled task, and neither of them are in use anywhere (Birthdays, WedgeDesk). It does also mean that when declaring the filename in the plugin-info.xml file you no longer have to prefix it with $plugindir. I will commit the update to the Birthdays plugin for reference later.

For the second, there are still going to be fringe cases. If you were to enable, say, Dragooon's notification plugin and the notify-on-reply child plugin, you cannot safely disable notifications without disabling the child plugin. Now the manager will not let you disable the main plugin without disabling the child plugin first. You could, theoretically, still disable it by physically altering the folder, but to remedy that would require a vast extra overhead every single page, to check all plugins every page, which is unnecessary.
Title: Re: New revs
Post by: Arantor on September 22nd, 2012, 05:28 PM
(1 file, 1KB... it's literally one line)

Revision: 1703
Author: arantor
Date: 22 September 2012 16:11:32
Message:
! Oops, forgot to add the actual optional test. (ManagePlugins.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Title: Re: New revs
Post by: Arantor on September 23rd, 2012, 08:00 PM
(2 files, 3KB)

Revision: 1704
Author: arantor
Date: 23 September 2012 18:59:36
Message:
! Use proper note classes for the numbers within the PM menu area. Everywhere else does it, this should too. (PersonalMessage.php)

! The manage rules area needed some consistency attached to it, using buttons consistently rather than two links and a button. Some minor logic changes were needed to make it work but no biggie. (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/PersonalMessage.template.php

(Yes, a purely aesthetic commit from me. It doesn't happen often, either.)
Title: Re: New revs
Post by: Arantor on September 23rd, 2012, 09:15 PM
(6 files, 5KB)

Revision: 1705
Author: arantor
Date: 23 September 2012 20:14:49
Message:
! Spacinazi. (Profile-View.php, Register.template.php)

! Remove one of the remaining instances of string manipulation actually in a language file. (ManagePosts.php, Help language file)

! Update BB implementation to match 2.2.10 ruleset, notably updating MSN ranges and some extra URL checking that *shouldn't* cause any problems. (Security.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Title: Re: New revs
Post by: Arantor on September 24th, 2012, 01:45 AM
(13 files, 9KB)

Revision: 1706
Author: arantor
Date: 24 September 2012 00:45:00
Message:
! Removing yet another string concatenation that wasn't entirely necessary. (MoveTopic.php, ManageTopics language file)

! Not all instances of notice handler were styling things correctly. (GenericMenu.template.php)

! Converting pretend buttons into real buttons. (ManageBoards.template.php, ManageMembergroups.php, Admin.template.php)

! Juggling around the menu handling for manage members so that menu items are actually correct. This does generate a small side bug I will fix shortly in the admin search, well, more accurately it'll fix an edge case that's technically an SMF bug too. (Admin.php, ManageMembers.php, ManageMembers and Admin language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.french.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.french.php
Title: Re: New revs
Post by: Arantor on September 24th, 2012, 02:06 AM
(2 files, 2KB)

Revision: 1707
Author: arantor
Date: 24 September 2012 01:05:30
Message:
! SMF bug: if a subaction is declared in the admin menu and it is declared with a custom URL in the process, that will be ignored during the admin search processing all the menu contents. (Admin.php)

! Maintenance move boards in bulk had malformed tags, replaced the broken tags with the styling we're using elsewhere anyway. (ManageMaintenance.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Title: Re: New revs
Post by: Arantor on September 24th, 2012, 03:56 AM
(20 files, 2KB, simply removing lines is quite lean in SVN)

Revision: 1708
Author: arantor
Date: 24 September 2012 02:55:55
Message:
! Clean-up of duplicate strings in general. More to do, though. (ManageAttachments.php, ManageSmileys.php, Modlog.php, ManageBoards.template.php, ManagePaid.template.php, Packages.template.php, language files: Admin, ManageBoards, ManagePaid, ManageSmileys, Modlog, Packages, Profile)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/ManagePaid.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Title: Re: New revs
Post by: Nao on September 24th, 2012, 09:48 AM
rev 1709 -- easy to revert in case I change my mind for common.css... :)
(8 files, 2kb)

- Stopped including automatically common.css to all CSS cached files, just in case one would include a file in regular CSS format. (I'm committed to keep supporting these for plugins and custom themes, although I haven't tested this format in a long while...) You will now have to explicitly add 'common' to the array of files you're loading in case you want to use one of its virtuals (.inline-block, .clearfix etc.) Or just copy the virtuals into your own file, it's exactly the same to me... (Admin.php, Class-Editor.php, Packages.template.php -- yes, I know this one will end up being deleted...)

* Spacinazi. Thanks Pete for that reminder... (index.css)

* Translation. (ManagePlugins.french.php)
Title: Re: New revs
Post by: Nao on September 24th, 2012, 10:05 AM
rev 1710
(1 file, forgot to see the size)

* Reverted id_group database size to smallint(5) signed instead of mediumint(8) unsigned. This is mainly because I've decided to use contact lists for privacy, instead of custom membergroups, so in the end we should have no need for high IDs for membergroups. Probably to keep it in style with the SMF changelogs. (install.sql)

! Fixed member blurbs holding broken HTML by at least temporarily setting them to a size of 500 instead of 255. I know, it takes an extra byte in the database... But hey, I just saved one by reverting the id_group size, so don't complain too much! (install.sql)

* Renamed the (unused) thought_privacy table to privacy_thought, and added privacy_boards and privacy_topics tables as well. Their structure is only temporary -- privacy_id should probably be signed, and boards don't need a 'group' privacy type, but whatever... At least it's committed somewhere and it can be changed as long as it's not implemented, can't it..? (install.sql)

@ Starting from now, I'll be adding more whitespace to SVN logs, just like in the wedge.org topic... I'm not exactly sure why I kept it tight for so long.
Title: Re: New revs
Post by: Nao on September 24th, 2012, 10:12 AM
rev 1711 -- because I really should be committing smaller updates instead of mindlessly packing everything together...
(2 files, 1kb)

* id_post_group is always going to be unsigned... Make it clear in the DB. (install.sql)

* Added a comment for help icons. Just saying how to replace them with a clean HTML entity... Not that I'm going to ship it by default. By I'll consider it for my own sites. (sections.css)
Title: Re: New revs
Post by: Arantor on September 24th, 2012, 01:21 PM
(5 files, 3KB, just a quick one before other stuff happens that I need to go and do.)

Revision: 1712
Author: arantor
Date: 24 September 2012 12:20:43
Message:
! boardsAllowedTo wasn't returning arrays of things as expected. (Security.php)

! Disabled profile fields still visible in personal messages (thanks Emanuele) (PersonalMessage.php)

! Conversion of a few fopen/fwrite/fclose to file_put_contents. Smaller code, more readable, and doesn't necessarily have some of the nasty problems fwrite can have. (Class-GifAnimator.php, ManageRegistration.php, ManageServer.php)
----
Modified : /trunk/Sources/Class-GifAnimator.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on September 24th, 2012, 06:23 PM
rev 1713
(2 files, 1kb)

+ Added $head_font_style variable to enable skins to easily change the font style (or weight...) without changing anything else. Maybe I should do that everywhere uh...? (index.css)

* Minor improvements to Wuthering. (Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on September 24th, 2012, 06:24 PM
rev 1714
(2 files, 3kb)

+ Added support for @elseif in @if/@else/@endif statements in Wess. Basically, just like in any other high-level language, you can add any number of @elseif on the same tab level, but only one @else, and it has to be at the end (or not there at all). (Class-CSS.php)

! Because of the way 'content: "string"' was handled, having one inside an @if block could screw up the final outputted content. I'm afraid the fix is a bit slower than before, but I'd rather not take my chances. The same problem exists for protected comments, but there's absolutely no reason to have them inside @if blocks, so no time to waste on that. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on September 25th, 2012, 10:27 AM
rev 1715 -- variable tests!!
(5 files, 8kb)

+ Added support for variable tests. Surprisingly, I managed to implement variable tests into @is (inline ifs), in addition to my original target, @if. (Class-CSS.php, Subs-Cache.php)

@ Anyway -- this feature was a bit tricky to implement, and I'm not sure of its solidity although I spent many hours testing it. Don't try funny things with it, it just allows for basic boolean tests mostly for mixin use, so don't use quotes where not needed, and stick to ==, !=, <, >, and $var (true) and !$var (false) tests.

+ Allow for mixins to provide parameters without a default. It's the equivalent of setting it to '' (empty), really. (Class-CSS.php)

! Fixed multi-line mixins that were incorrectly indented when added through the 'mixes' keyword. (Class-CSS.php)

! Fixed passing parameters through the 'mixes' keyword, e.g. #id mixes mymixin ('hello, world!'). (Class-CSS.php)

* Updated the mixin sample to showcase the latest changes. (index.css)

* Minor CSS fixes/optimizations. (sections.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on September 25th, 2012, 10:46 AM
rev 1716
(2 files, 2kb)

! Fixed Wess functions width() and height(), and dynamic admin menu icons, to all accept direct URLs. (Class-CSS.php, Subs-Cache.php)

@ Tested on the Topic Solved plugin only... Hopefully works everywhere. Hey Pete, did you empty the error log recently here..? I thought it had 17 errors last I'd seen...
Title: Re: New revs
Post by: Arantor on September 26th, 2012, 01:46 AM
(1 file, 2KB)

Revision: 1717
Author: arantor
Date: 26 September 2012 00:44:35
Message:
! SMF bug: PayPal paid-subs module has HTTP/1.0 connection details if using fsockopen to handle the connection, but after Feb 1, 2013, PayPal will not accept them. I've taken the liberty of rewriting it using the WebGet class, too. However, I HAVE NOT TESTED IT. I see no reason why it shouldn't work, but treat it with the care it deserves. (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Subscriptions-PayPal.php

@ The main reason I haven't tested it is because while I have an account that is PayPal capable, I can't pay for a subscription myself with my own account and I refuse to expect others to pay to test it on a site of mine, if that makes sense.
Title: Re: New revs
Post by: Arantor on September 26th, 2012, 04:26 AM
(3 files, 2KB)

Revision: 1718
Author: arantor
Date: 26 September 2012 03:25:18
Message:
! Bodged together the 'is this recurring' checkbox back on to the paid subs confirmation screen. It's about as inelegant as before but at least it works now. (Subscriptions-PayPal.php, Profile-Actions.php, ManagePaid.template.php)

! Amended the PayPal URL to be secure. No reason for it not to be. (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Themes/default/ManagePaid.template.php

@ The changes to the subs modules today still mean it's broken for recurring. It's just slightly less broken in other ways now.
Title: Re: New revs
Post by: Nao on September 27th, 2012, 09:37 PM
rev 1719
(2 files, 3kb)

! Fixed broken install process. (install.php)

! Fixed broken satellite CSS files -- they were compiled incorrectly because they no longer automatically include virtuals. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on September 29th, 2012, 05:57 PM
rev 1720 -- JS language strings! Thankfully there's a Revert button in case things go wrong... :P
(6 files, 7kb)

+ Added support for language caching inside JS files. Which, as you're going to see, can save a lot of bandwidth. Currently only applying it to the index template... (Subs-Cache.php, Load.php, index.template.php, script.js)

@ So, basically: just add a "@language index;" line somewhere in your JS file (if you need a language string in index.language.php), and then just use regular $txt['string'] right within your JS code. The string will always be escaped, so you don't need to surround it with quotes. If you need more language files, use "@language index, otherfile, ..." or use multiple @language keywords, your choice.

@ You can include plugin language files with "@language Author:Plugin:LanguageFile". The cache won't be flushed when they're modified, though, so you'll need to manually empty the JS cache folder. This is going to stay like that until Pete implements his planned 'language delta' feature.

! Fixed a minor error that is more a PHP bug than a Wedge bug to me... If you do strpos($string, $number), you'll apparently always get false even if $string does contain a string representation of $number. Anyway, that made cache flushing problematic in Wedge. (Subs-Cache.php)

* Casenazi. (PersonalMessage.language.php)
Title: Re: New revs
Post by: Nao on September 30th, 2012, 12:42 AM
rev 1721
(2 files, 1kb)

* A bit of a risk I'm taking here, but I'm replacing the @media and @keyframes search code in Wess with a generic @[a-z]+ test, to support current and future @ blocks like the new @supports. Just making this part of a minor commit so I can easily revert if need be. (Class-CSS.php)

* Small tweak of the line-height in select boxes to ensure better vertical alignment in some browsers. (index.css)
Title: Re: New revs
Post by: Arantor on September 30th, 2012, 04:21 AM
(11 files, 3KB)

Revision: 1722
Author: arantor
Date: 30 September 2012 03:19:31
Message:
! Stupid boardsAllowedTo bug. (Security.php)

! The this-user-is-being-ignored text should have the right cursor. (index.member.css)

! Crude hack for the installer to prevent it trying to cache during installation. (install.php, Subs.php)

! Remove base_theme support, as far as I know nothing is broken. (JSOption.php, Load.php, ManageServer.php, Profile-Modify.php, ScheduledTasks.php, Subs-Members.php, Themes.php)
----
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/other/install.php

I'm open to suggestions about improving the installer hack stuff, by the way.
Title: Re: New revs
Post by: Nao on October 1st, 2012, 11:25 PM
rev 1723 -- a bigger one is coming up.. :)
(1 file, 1kb)

* <we:block> blocks already imply rounded corners, no need to all .wrc to their class list. Really. (Who.template.php)

! Fixed credit list padding hack that wasn't properly triggered. (Who.template.php)
Title: Re: New revs
Post by: Nao on October 1st, 2012, 11:28 PM
rev 1724
(4 files, 13kb)

* The homepage is now consistent between recent and random items. (Media.template.php, media.css)

* The homepage, album pages and item comments will now show sorting options in select boxes. It was a pain to rewrite, but hopefully it's worth it... -_- (Aeva-Gallery.php, Media.template.php)

* URLs should be better formed when sorting. (Aeva-Gallery.php, Subs-Media.php, Media.template.php)

* And more media tweaks I won't bother to list.
Title: Re: New revs
Post by: Nao on October 1st, 2012, 11:37 PM
rev 1725
(2 files, 1kb)

! The curse of the Last-Minute Tweak... Fixed padding and margins in media homepage. (Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on October 2nd, 2012, 12:04 AM
rev 1726
(2 files, 1kb)

! Shouldn't commit when I'm tired... Anyway -- restored some debug session changes and moved a hardcoded style to the media stylesheet. (Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on October 4th, 2012, 06:46 PM
rev 1727 -- the installer overhaul. Still got files left to commit, but nothing related to the installer I believe.
(9 files, 13kb)

! Fixed clean_cache() to properly handle sub-folders and delete them if they're emptied. (Subs-Cache.php)

! Fixed updateSettings()'s handling during install. (install.php, Load.php, Subs.php)

! Fixed database structure, got screwed up a bit last month. (install.sql)

! enableCompressedData was never set up at install time, despite all the related code. (install.php, install.sql)

! Settings.php file was being rewritten with superfluous linebreaks everywhere. (install.php)

! Fixed CSS cache file generation in install process, it was broken for multiple reasons. (install.php)

! Fixed 404 handling to support the new css and js cache folders. (QueryString.php)

* Overhauled installer design. It's looking quite a bit better now. (install.php, install.css)

* Moved language select box from header to first page's content area. Also fixed the JS to actually use sbox on it. (install.php)

* Improved the 'pass' test strings during install. (Install.language.php)
Title: Re: New revs
Post by: Nao on October 5th, 2012, 12:07 AM
rev 1728 -- more files left to commit -- but not too many actually! I'm getting close to a releasable alpha really...
(12 files, 2kb)

* Harmonized font-weight declarations to 400 and 700 instead of normal and bold. It's a tad shorter, and skinners really should learn to use weights by number rather than by name. It makes more sense in the end. Especially for the non-English population... I also updated section.css but need to clean it up first. (editor.js, install.css, extra.rtl.css, index.member.css, mana.css, media.css, report.css, up.css, zoom.css, Wine/extra.css, Warm/extra.css, Wuthering/extra.css)

:edit: Had got the commit number wrong...
Title: Re: New revs
Post by: Nao on October 5th, 2012, 04:36 PM
rev 1729
(3 files, 2kb)

* Tweaked default welcome page to look better with the current stylesheets.
  Ensured that InfoCenter wouldn't use any hardcoded styles because it wouldn't be too good on a generic template.
  Sidebar should have some bottom padding when it's at the bottom.
  Finished converting font weights.
  (InfoCenter.template.php, Welcome.template.php, sections.css)
Title: Re: New revs
Post by: Nao on October 5th, 2012, 09:54 PM
rev 1730
(12 files, 4kb)

* Moved $txt['quickmod_confirm'] declaration to script.js, renamed it to $txt['generic_confirm_request'], and replaced everything everywhere... This is for that kind of cool simplification that I implemented cacheable language strings. :) Also simplified InTopicModeration strings. (ManageMail.php, Aeva-Foxy.php, Display.template.php, ManageMedia.template.php, Media.template.php, MessageIndex.template.php, Search.template.php, index.language.php, mediadmin.js, script.js, topic.js)

+ Added a confirm box to the thought removal button... After (as an admin) deleting several thoughts from wedge.org accidentally in the last few months, it was long overdue... (script.js)
Title: Re: New revs
Post by: Nao on October 6th, 2012, 02:15 PM
rev 1731
(8 files, 7kb)

* Moved index.css's variables to common.css, so that they can be re-used in external files. I'll commit the slim version of index.css once I'm done with all the little tweaks. Also updated .postbg background declarations to use $post_bg and $post_bg2. Which I could have sworn I'd already done... (common.css, sections.css, Wine/extra.css)

* Moved oEditorStrings and ptxt to editor.js and post.js respectively... Now that's even cooler. Changed opt.message_ext_error_final to a local variable. (Class-Editor.php, Post.template.php, editor.js, post.js)

* .zoom-base should be a virtual, even its name implies it... (zoom.css)
Title: Re: New revs
Post by: Nao on October 6th, 2012, 03:01 PM
rev 1732
(4 files, 1kb)

! Forgot to declare the @language keywords... Maybe I should assume that 'index' is always loaded anyway, at that point in the script..? (editor.js, post.js, topic.js)

- Duplicate CSS declaration. (Wine/extra.css)
Title: Re: New revs
Post by: Arantor on October 7th, 2012, 04:14 PM
(2 files, 2KB)

Revision: 1733
Author: arantor
Date: 07 October 2012 15:13:26
Message:
! Certain navigation links were hidden if the user was a guest, even if guests had the permission to do what the navigation menu was pointing to. (MessageIndex.php)

! Fixed some validation errors, thanks live! (Post.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/Post.template.php
Title: Re: New revs
Post by: Arantor on October 7th, 2012, 05:45 PM
(3 files, 1KB)

Revision: 1734
Author: arantor
Date: 07 October 2012 16:45:02
Message:
! SMF bug 4870: incorrectly capitalised dates. In our case, if setlocale is used, trust the locale database as being correct (because it is likely to be correct). If setlocale is not used, trust the language strings we have for things. Interestingly, French already behaved this way anyway since the old option was already off in French. (Subs, index language file)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Arantor on October 7th, 2012, 07:07 PM
(1 file, 3KB)

Revision: 1735
Author: arantor
Date: 07 October 2012 18:06:27
Message:
! Hopefully fix my old bug related to DNS lookups, and introducing IPv6 support for it at the same time. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Arantor on October 7th, 2012, 07:17 PM
(1 file, 1KB, 1 line)

Revision: 1736
Author: arantor
Date: 07 October 2012 18:16:52
Message:
! Theoretically prevent mass duplication of language loading. Essentially when using a non-English language, by default there is a call to load English first so that missing strings don't cause errors. But in the admin search in particular, it calls multiple times - and since the previous load was not English, the subsequent call is for English. IOW, if the current call is a fallback call, don't bother if already loaded (since we would have hit English first anyway). This should not break anything else... (Load.php)
----
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Nao on October 9th, 2012, 02:25 PM
rev 1737
(4 files, 3kb)

+ Added support for simple variables in skeleton blocks. Used these to make the bottom linktree code cleaner, giving control to the skeleton rather than a random block not related to the linktree at all. Please note that while I'm declaring the top linktree as <linktree />, it can just as easily be declared as <linktree:top /> (like in the Warm skeleton), as the default value is set to 'top'. (Load.php, Subs-Template.php, index.template.php, Warm/skin.xml)

* Modified param order in RSS feed declaration, to match the other meta tags'. Also removed a few globals that weren't used at all, and $shown_linktree (same reason). (index.template.php)
Title: Re: New revs
Post by: Nao on October 11th, 2012, 10:47 PM
rev 1738
(8 files, 9kb)

+ Added wetem::move() method, which allows you to move a template block from one place to another. It had the usual target parameters: select a layer or block, and select a position relative to it (basically: add (equivalent of 'last'), first, before and after.) (Subs-Template.php)

+ Added <move> command to skin.xml files, where you can invoke the wetem::move with this setting: <move block="block_name" to="target_layer_or_block" where="after" />. You can use the params in any order you want, I should probably rewrite my other mini-parsers to do the same because it's more flexible... No? Regarding Load.php, I'm not too happy I had to postpone the move() call to it, but right now it's the only way it can be done. Maybe later if I rewrite the entire wetem object to manipulate the skeleton string instead of the skeleton array, it can be done nicely... (Load.php, Subs-Cache.php)

* Wine will now show the linktree above and below the sidebar, rather than next to it. Yes, that's the reason I wrote the above method... (Wine/skin.xml)

! Tons of little fixes/tweaks to the main CSS, such as the padding button on IE6/7 buttons, .bbc_img needing a max-width of 100% rather than 650px, and padding tweaks. (index.css)

* Also several tweaks to Wine, most notably in responsive mode, and linktree paddings. (Wine/extra.css)

! And another responsive fix for Warm this time... (Warm/extra.css)

! Fixed menu alignment, linktree styling and responsive sidebar styling in Wuthering. (Wuthering/extra.css)

@ Known issue: recent changes to the skin system have been bad for IE... Even IE9 doesn't like the new Wuthering (hasn't for some time). Responsive modes are pretty broken, too... I'll probably need to go for a negative margin hack for them.

@ Known issue: if you access the 'Current Theme' page in the admin area, if you're not using Weaving it will use a mix between Weaving and your skin... Which is odd. It's only on that page, though. We need to find a solution for this... Anyone, any idea? That's in Themes.php, function SetThemeSettings.
Title: Re: New revs
Post by: Nao on October 13th, 2012, 06:42 PM
rev 1739
(7 files +1, 7kb)

+ Added a $radius CSS variable to help change the overall page's border radius more easily. (common.css, index.css, Wuthering/extra.css)

* Warm layout was off by a couple of pixels in old IEs due to a lack of cellspacing param. (index.template.php, Warm/skin.xml)

* Several tweaks to Wuthering to make it cooler... In my opinion at least. What do I know. (Wuthering/extra.css, Wuthering/extra.ie[-9].css)

+ Added a funny styling for Wuthering linktrees. I don't know if you'll like it. I may even remove it in the future. But I worked on it for a day, tweaking it bit by bit, so at least it deserves even a temporary commit... (Wuthering/extra.css, images/theme/tria.gif)

- Debug code. (Wine/skin.xml)

@ Note: the extra linktree code adds less than 200 bytes to a gzipped css file... I think it's acceptable.
Title: Re: New revs
Post by: Nao on October 13th, 2012, 09:16 PM
rev 1740
(3 files -1, 2kb)

! Fixed the Like popup header. (Like.php)

* Considering that I started with a more complex arrow for the Wuthering linktree, and then reduced it to a simpler form, I just remembered that I really didn't need an image file for it... So, replacing it with one of my usual favorites, the border-color hack. (tria.gif, Wuthering/extra.css)

* Harmonazi. (extra.rtl.css)
Title: Re: New revs
Post by: Nao on October 16th, 2012, 12:23 AM
rev 1741
(2 files, 2kb)

+ Added labels for the permission page, allowing you to click permission names to check/uncheck them. (ManagePermissions.template.php)

* The Clean Cache maintenance task should also empty the CSS and JS cache folders... (ManageMaintenance.php)
Title: Re: New revs
Post by: Nao on October 16th, 2012, 12:24 AM
rev 1742
(5 files, 2kb)

- We don't need to repeat the schema.org breadcrumb definitions on the bottom linktree in topic pages. Which begs me to ask... Google, why aren't you taking my breadcrumbs into account? Wedge.org has been using then for over 6 months, and yet they're still shown the same way as before... :-/ (index.template.php)

! Minor overflow issue. I'm not sure it's for the best, but it's fixable at any time anyway... (Media.template.php)

* Added a small comment in add_css to remind people that it may fail if calling wetem::hide(). Duh. (Subs-Cache.php)

* Harmonized font size in Wuthering linktree, and linktree padding in Weaving. (index.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on October 18th, 2012, 10:44 AM
rev 1743
(4 files, 1kb)

* Admin homepage should now show arrows in the newbie box. I have a feeling it should have been done that way since day one... (Admin.template.php)

* I may come to regret this later, but I moved up the body padding reset code for low resolutions. So, instead of being applied to Wuthering, it's now applied to all skins (including Warm, which doesn't need it, but it won't hurt it either.) (sections.css, Wuthering/extra.css)

* Minor tweaks. (Warm/extra.css)
Title: Re: New revs
Post by: Nao on October 18th, 2012, 05:28 PM
rev 1744
(5 files, 3kb)

! Mismatched background in stats page. (Stats.template.php)

* Multiple minor CSS tweaks. They're all for the better. Changed windowbg/windowbg2 color in Wine and removed the gradient background (left it on postbg for now). I fear that too many gradients tend to kill the effect. Maybe I'll add them back later. Added a background border between cells in windowbg-alterning tables. Look for the 'final' keyword lost in the middle, it's fun. (common.css, sections.css, Wine/extra.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on October 18th, 2012, 05:29 PM
rev 1745 -- woot, plenty of Wess fixes...
(2 files, 5kb)

+ Added is_ios to browser variable. $browser['agent'] will now return 'ios' whether you're on iPod, iPhone or iPad, and whatever browser you're using, because Apple doesn't allow for other browsers to use their own engine. Except for Opera Mini, which should return 'opera', because I like to do things correctly. Also, because I don't have an iPad under the hand, I can't determine whether it's safe to rename extra.iphone.css to extra.ios.css. (Load.php)

+ Added prefix handling support for font-feature-settings and calc() to Wess. (Class-CSS.php)

! Redefining a CSS variable like "$post_bg2 = $window_bg2" could have unexpected results, due to a misplaced call to develop_var(). Well, maybe I'm adding even more bugs by moving it, ah ah. What do you know. Nah, should be good. (Class-CSS.php)

! Undefined variable $is9 in Wess... Not sure how it stayed that way for so long without generating an error... (Class-CSS.php)

! Fixed support for the old flexbox model, and added display: box to the list. Please note that it's recommended to use display: flex or inline-flex instead, these are the new official values, but their support is not as wide. It'll be at least a few years before it starts being useful really... Sob. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on October 19th, 2012, 11:58 PM
rev 1746
(2 files, 1kb)

! Fixed crash on iPad devices, due to Apple being a bunch of funny guys who enjoy changing their user agent without warning. (Load.php)

! Applied a band-aid on the IE6 non-anchor hover polyfill, because it needed it. More specifically, having a ":hover:after" in your CSS seems to trigger an error. That fix should simply ignore the error. Not that IE6 supports :after anyway, eh..? (ie6hover.js)
Title: Re: New revs
Post by: Nao on October 20th, 2012, 06:12 PM
rev 1747
(7 files + 8 folders, 9kb)

* Rewrote Wuthering linktree to use a shadowed half-circle rather than bland arrows. Adds about 200 bytes of CSS... That should compress correctly. You tell me if you don't like it. (Wuthering/extra.css)

! Fixed local ignores in the SVN server. (svn, attachments, cache, css, js, Plugins, Sources, Sources/media)

! Media deletion confirm box will now use a regular confirm() call -- until I'm ready to deploy ask() everywhere. (Media.template.php)

+ Added a nice little transition at window resize time. To think it's only one line of code... (index.css)

* Attempting to fix an Opera problem where rounded corners don't show up or disappear correctly. Hopefully I won't need to rework this for other platforms. (index.css, sections.css, Wine/extra.css)

- Removing some custom iOS JavaScript that was no longer needed... I think. (Wine/skin.xml, Warm/skin.xml)
Title: Re: New revs
Post by: Nao on October 27th, 2012, 11:19 AM
rev 1748
(5 files, 2kb)

! Fixed CSS bug that would occur when having a selector declared multiple times in a file and then used as a mixin. (Class-CSS.php)

! (SMF bug) Typo: can_view_receipient_email. (SendTopic.php, SendTopic.template.php)

* The trackIP function should be named TrackIP per index.php convention, or trackIP per Sources convention (as it's part of multiple sub-actions). I decided to go for trackIP everywhere. (Profile-View.php)

- Removed remnants of the rev 939 removal of guest_hideContacts. (other/install.sql, SendTopic.php, SendTopic.template.php)
Title: Re: New revs
Post by: Nao on October 27th, 2012, 11:06 PM
rev 1749 -- I'm saving the better stuff for a round number like the next one :P
(1 file, 1kb)

+ Mini-menus can now show the %id% and %special% variables in the link text in addition to the link URL. If you don't get it, don't bother. (topic.js)
Title: Re: New revs
Post by: Nao on October 27th, 2012, 11:14 PM
rev 1750
(6 files, 11kb)

* Renamed template_profile_icons to template_user_status, and moved it to the left of the user name. Basically, instead of showing profile icons with links in them, which is already dealt with by the new mini-menus, I'm replacing the Online status icon with four squares whose color codes indicate the user status: online/offline, has a website linked, is male/female, is a friend or not. (Display.php, Display.template.php, index.language.php, sections.css)

+ Added See IP / Track IP entries to the mini-menu. Still missing: an e-mail link. (Display.php, index.language.php)

* Replaced all calls to $scripturl with <URL> in the Display stuff. I think it's working... (Display.php)

* Minor CSS tweaks. The most notable change is that I increased the sidebar width by 20 pixels. I think it provides for a better balance, but it's not perfect yet. (common.css, sections.css)
Title: Re: New revs
Post by: Nao on October 28th, 2012, 06:05 PM
rev 1751
(3 files +2-2, 3kb)

* Renamed SendTopic to Mailer, because it's more about sending e-mails than sending topic by e-mail. (index.php, xml/detailed-version.php, Mailer.php, Report.php, Mailer.template.php)
Title: Re: New revs
Post by: Nao on October 30th, 2012, 10:01 PM
rev 1752
(28 files, 12kb)

* Restored ask() function and updated the thought system to use it instead of confirm(). Since the extra custom function adds quite a few bytes, I also optimized the embedded HTML code for better compression, and possibly better readability of the thought system code. So, all in all, the compressed JS is 15 bytes shorter. Good ol' days... (script.js, index.member.css)

+ First batch of ask() conversion. Most confirm(string) calls now use the ask(string, event) syntax. (script.js, ManageAttachments.php, ManageBans.php, ManageMail.php, ManageMembers.php, ManagePaid.php, ManageSearchEngines.php, ManageSmileys.php, MessageIndex.php, ModerationCenter.php, Aeva-Foxy.php, TEMPLATES: Admin, Display, Errors, ManageBoards, ManageMaintenance, ManageNews, ManagePlugins, ManageSmileys, Media, ModerationCenter, Packages, Profile, Recent, Themes)

! $deep_folder was incorrectly initialized, causing CSS files with a 'local' keyword to be ignored by Wess at parse time. (Subs-Cache.php)

* French grammar fix. (ManageTopics.french.php)
Title: Re: New revs
Post by: Nao on October 31st, 2012, 10:20 AM
rev 1753
(30 files, 11kb)

* Last batch of confirm() to ask() rewrites. I didn't think I could pull it off, but all of the confirm calls are now using ask(). Yay. (Class-Editor.php, Display.php, Groups.php, ManageAttachments.php, ManageBoards.php, ManageMembers.php, ManagePaid.php, ManageSmileys.php, mediadmin.js, topic.js, TEMPLATES: Admin, index, ManageAttachments, ManageBans, ManageMaintenance, ManageMedia, ManageMembergroups, ManageMembers, ManageNews, ManagePermissions, ManageSearch, Media, MessageIndex, ModerationCenter, MoveTopic, Packages, PersonalMessage, Profile, Search, Themes)

! SMF bug: there's a confirm box in template_modify_language_entries that actually doesn't do anything because of the lack of a return statement. (Admin.template.php)

* Shortened thought JS code. Not by much, but it's on every page for members... I like saving bandwidth. (index.template.php)

@ The ask() callback is only used once: in the PM popup code (index template). Is it worth keeping it..?

@ Simplified JS code in MembersAwaitingActivation. Would appreciate if beta testers could look into it and see whether the confirm box still works as expected. (ManageMembers.php)

NOTE: I'm hoping to be able to release the private alpha by tonight... Scary!! ;)
Title: Re: New revs
Post by: Nao on October 31st, 2012, 03:57 PM
rev 1754
(11 files, 6kb)

+ Implemented say() (replacement for alert()), and modified it to be closer in spirit to ask()... It'll do the same internally, just not showing the extra button. This allowed me to use it in Post pages when submitting a message that's going to be moderated. Also, post.js shows an example of a say() call that requires executing some code after it (in the callback), but has no need to give a boolean return (thus, no event handler is passed to it). (script.js)

* Converted all alerts to say(). Well, easier said than done... I've left one alone (in the spellchecker) because I can't be arsed to determine whether it would work. And I don't use the spellchecker anyway. Do you? (ManageBans.template.php, ManagePermissions.template.php, ManageSearch.template.php, Post.template.php, Profile.template.php, Register.template.php, editor.js, post.js, up.js)

- These JS-oriented strings no longer need HTML entities... Well, easier said than done: who's willing to have a look and change them all, while ensuring they won't be used in e-mails...? Nope? Okay, I'll just forget about them for now... (Post.french.php)
Title: Re: New revs
Post by: Nao on October 31st, 2012, 11:04 PM
rev 1755
(5 files, 3kb)

! Undefined gender would appear as female in the user status box. (Display.template.php)

! Fixed moderators not getting the proper IP tracking link in the user mini-menus. (Display.php)

! Wess is a bit lazy when it comes to parenthesis matching in math() formulas. So, something like (math(...)) would fail. I hacked a half-arsed solution by offering the ability to surround the function in quotes to remove the ambiguity, i.e. ("math(...)"), so if you ever get a parsing error, just add the damn quotes. Sorry about that... (Class-CSS.php)

! Preventing overflows around generic button strips. Well -- it happens, so I'm simply extending .clearfix into the containers. (sections.css, Reports.template.php)
Title: Re: New revs
Post by: Nao on November 1st, 2012, 12:51 AM
rev 1756 -- hopefully Private Alpha material!! :)
(7 files +2-4, 12kb)

* Now showing user status box instead of online button in PM user boxes. Wouldn't have been as easy without Wedge's skeleton system... :) (PersonalMessage.php, PersonalMessage.template.php)

* Many CSS tweaks.
  * Header font is now Segoe UI Light by default. What do you know. I just like it. To hell if it doesn't look great on older browsers. Use a nice one. (common.css)
  - Warm posts now use Tahoma by default, and Segoe UI in italic and bold modes (Tahoma only has the dull straight version). Also fixed padding above footer in responsive mode. (Warm/extra.css)
  - Removed unused ID from Wuthering, fixed popup alignment (due to the body being centered), fixed overflow issues. (Wuthering/extra.css)
  ! A few browser specific fixes. (Wine/extra.css)
  @ IE 6/7 are still broken in many areas... I think. They'll be fixed for the public alpha or something, I guess. Why do I no longer care these days..?

* Removed minilogo and minilogow (not used anywhere..?), replaced webelow and webelowine with wefoot1 and wefoot2 (slightly improved versions of the footer logos.) (images/*.png)

* Shortened PM popup code (in index template) by two bytes. Well, say() no longer needs an event object to be specified when you include a callback... (index.template.php)

* Tweaked index template to keep it from outputting wedge.org-specific data on non-worg websites. It's a hack, but you understand we're going to move that code over to a plugin anyway...? Eventually. Peeeete? Can you help? (index.template.php)
Title: Re: New revs
Post by: Nao on November 1st, 2012, 12:58 AM
rev 1757
(2 files, 1kb)

! Last-minute typo. © 2012 Nao/Gilles. (index.template.php)

* Forgot to commit common.css. (common.css, obviously.)
Title: Re: New revs
Post by: Nao on November 1st, 2012, 01:25 AM
rev 1758
(2 files, 1kb)

! Fixed ask() and say() not working correctly when providing just a callback function. (script.js)

! Doing an extra test on $_SERVER['REQUEST_URL']. It should NOT be needed... But I noticed an undefined index error in my log. Let's just say it's a free extra test anyway. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on November 1st, 2012, 08:43 AM
rev 1759
(1 file +11-10, 3kb)

* Moved all other/ files intended to be at the root, in a root/ folder. This should clear up some of the confusion... Hopefully. And help me release a private alpha in less than 20 minutes. (other/, root/*)

! Fixed linktree padding in Warm. (Warm/extra.css)

+ Initial changelog placeholder. (root/changelog.txt)
Title: Re: New revs
Post by: Nao on November 1st, 2012, 09:09 AM
rev 1760
(1 file, 1kb)

! Fixed thought system getting broken when using the keyboard. Note to self: using a type=submit and a return false in its handler is critical to correct keyboard implementations. (script.js)
Title: Re: New revs
Post by: Arantor on November 2nd, 2012, 09:34 PM
(4 files, 2KB)

Revision: 1761
Author: arantor
Date: 02 November 2012 20:33:18
Message:
! Certain things were inserted twice in the verification process, also there was an extra space. (GenericControls.template.php)

! Oops, stupid parameter missed from custom field creation. (ManageMemberOptions.php)

! Reserved names code was broken, mostly because I managed to remove the form variable back in r347. (ManageRegistration.php, Register.template.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/Register.template.php
Title: Re: New revs
Post by: Nao on November 2nd, 2012, 09:38 PM
rev 1762
(5 files -1, 4kb)

- Opera 12.10' latest RC finally fixed the selectionStart bug (http://my.opera.com/desktopteam/blog/2012/11/01/opera-12-10-rc1) I'd reported to them months ago. So the editor no longer requires my handy little workaround, and I can safely remove it. Although it means older versions will have the problem again, I'd rather not worry about these: most Opera users will usually stick to the latest version anyway. Power users, things like that. (editor.js)

! Fixed regression where member management wasn't correctly triggering moderation actions. (ManageMembers.php)

! ul.buttonlist was still not handled correctly. Needed an extra clearfix... Maybe it's a bit overkill though? (sections.css)

- Removed useless styling. (Wine/extra.css)

* Moved changelog from root/ to root (/) folder. I love it when I don't make sense... Anyway, the root/ folder is only meant for files that shouldn't overwrite root files on upgrade. Removed feature list because it's the SMF 1.1 version... We don't need that. (changelog.txt, features.txt)
Title: Re: New revs
Post by: Nao on November 3rd, 2012, 11:03 AM
rev 1763
(5 files, 3kb)

! Fixed terrible layout in admin's member search form. Also removed empty values, I'm not sure what they were there for. (ManageMembers.template.php, mana.css)

! Fixed homepage thought buttons (Modify/Delete/Reply) not working correctly for non-admins. At the cost of 4 extra gzipped bytes, although the code is a bit shorter... Don't ask too much of that magical tool. (script.js)

* Won't get fooled again... If someone steps up and writes a custom error message when you try to register a new member with the same name as a membergroup (rather than an existing member). Well, I don't have time for that, so here's just the !! reminder comment... (Subs-Members.php)

! Actually, that extra space was simply misplaced, rather than unneeded. (GenericControls.template.php)
Title: Re: New revs
Post by: Nao on November 3rd, 2012, 04:20 PM
rev 1764
(4 files, 5kb)

- Removed support for viewResults variable in polls, it was only for old SMF templates anyway. The variable is currently 'viewresults'. (Display.php)

! Fixed (again!) the viewresults button. In rev 1533, I fixed it to be hidden when actually showing results (a SMF bug). This time, I'm also ensuring that it doesn't show up at all if you don't have permission to view results in the first place (i.e. poll option is set to only show the results after voting.) Another SMF bug, if the devs over there want to fix it they can ask me for the modified line of code ;) (Display.php)

! Fixed guest showPosts when viewed by a guest. Because previously, Wedge would try to load the profile user info, fail, then load the current user info instead, then fail, and refuse to show anything. It's best to just skip most of the profile loading (including the menus) and instead focus on showing posts. Also, IIRC 'moderate_forum' as a permission implies access to all boards, so I'll be using that as a shortcut too. Maybe I should be using 'is_admin'..? (Display.php, Profile-View.php, Profile.php)

! Don't bother to show user status icons for guests... (Display.template.php)
Title: Re: New revs
Post by: Nao on November 3rd, 2012, 05:40 PM
rev 1765
(7 files, 3kb)

! Fixed help popup z-index regarding objects below it. (index.css)

* Added group colors to membergroup list in admin permission page. The data was retrieved, I'm not sure why it wasn't shown in the first place... (ManagePermissions.template.php)

* Moved most of the output buffer reset code to its own function, clean_output(), which takes only one parameter to force (=true) disabling the ob_sessrewrite buffer. Mainly doing this to simplify things for modders. (Feed.php, Like.php, ManageMedia.php, Subs-Template.php, ViewRemote.php)

! Fixed media permission profile page's album list link. It was broken due to incorrect Ajax handling. (ManageMedia.php)
Title: Re: New revs
Post by: Arantor on November 3rd, 2012, 09:06 PM
(6 files, 3KB)

Revision: 1766
Author: arantor
Date: 03 November 2012 20:05:50
Message:
! Temporary workaround for permissions bug as reported by Dr Deejay - anything that goes into ask/say can't have quotes in it. (ManagePermissions language file)

! Upgraded BB to 2.2.11. (Security.php)

! Add countdown for admin timeout. It's not exactly pretty but I'm happy with it for the moment. (Admin.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Title: Re: New revs
Post by: Nao on November 3rd, 2012, 10:55 PM
rev 1767
(7 files, 2kb)

! The event delayer doesn't like seeing double quotes and > signs. Because I'm a nice boy, I decided to let Wedge ignore > inside event strings (assuming they're either embedded HTML or just a comparison), and allow JavaScriptEscape to additionally escape double quotes. Now, if I can find a volunteer to do a project-wide regex search on on[a-z]+="[^"]*\JavaScriptEscape, and manually add a true param after it, that would be swell... What? Why are you looking at me all of a sudden..? (Subs-Template.php, Subs.php, ManagePermissions.language.php, ManagePermissions.template.php)

! Fixed admin area sending errors when using Warm (due to the difference in layer names). (Warm/skin.xml)

* French translation. (Admin.french.php)

PS: just because I decided to go for this solution doesn't mean it's the 'right' one. Please feel free to disprove me. Or even revert me... No problem.
Title: Re: New revs
Post by: Arantor on November 5th, 2012, 01:27 AM
(3 files, 1KB)

Revision: 1768
Author: arantor
Date: 05 November 2012 00:25:33
Message:
! The installer should initialise westr if it's going to load it - just in case. Most of the time, not a big deal. (install.php)

! glob() can return false instead of empty arrays sometimes. Check where this is important and skip the loops if it's empty. (Subs-Cache.php)

! Delete member PM rules when their account is deleted. (Subs-Members.php)
----
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/root/install.php
Title: Re: New revs
Post by: Arantor on November 5th, 2012, 04:51 AM
(5 files, 20KB)

Revision: 1769
Author: arantor
Date: 05 November 2012 03:49:40
Message:
! Some additional security for the manage boards code. It's not strictly necessary but better safe than sorry. (ManageBoards.php)

! Board group access was not revoked when groups were previously removed. (Subs-Membergroups.php)

! Should be possible to configure groups' access to boards from the groups configuration page - now uses the proper tables and everything. (ManageMembergroups.php, ManageMembergroups.template.php, ManageMembergroups language file)

@ Note that the groups/board configuration as it stands is not very pretty and while I've extended the queries to get categories, I have not yet made it display them. That's for next time. (But it'll be more spiffy when I get there.)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Title: Re: New revs
Post by: Arantor on November 5th, 2012, 05:27 AM
(4 files, 2KB)

Revision: 1770
Author: arantor
Date: 05 November 2012 04:26:34
Message:
! Use query_list_board rather than query_see_board for the board index, but if the board is not one of the ones we can get into, tell the user that. (Subs-BoardIndex.php, Boards.template.php, MessageIndex.template.php, index language file)
----
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on November 5th, 2012, 07:14 PM
rev 1771
(14 files, 5kb)

* Downgraded MySQL version requirements from 5.1 to 5.0.3. Although v5.1 itself is many years old, it seems like some popular hosts (such as 1&1) are still on v5.0, and since we don't really need 5.1, it's simply safe to just require the version we actually need. (other/*, root/install.php, root/install.sql, root/readme_install.html)

! Safeguard for app_error_count. (ManageErrors.php)

* I'm saying my version is semantically better... :P (Subs-Cache.php)

* Admin time reminder would take up all space in some skins. (Admin.template.php)

* Admin media toggles should be shown as foldable rather than folded, by default. (ManageMedia.template.php, Media.template.php)

! Admin media toggle didn't work when re-opening a report after folding it. (mediadmin.js)
Title: Re: New revs
Post by: Nao on November 6th, 2012, 11:11 PM
rev 1772
(4 files +1-1, 9kb)

* Committing a slightly modified version of the latest Wedge.org homepage. If you want to use it on your forum -- modify $settings['default_index'] to 'Home'. This fixes the thought system, most notably. (Home.template.php)

* A couple of modifications related to Alphas. (changelog.txt, root/favicon.ico)

* French translation. (index.french.php, ManageMembers.french.php)
Title: Re: New revs
Post by: Nao on November 10th, 2012, 05:02 PM
rev 1773 -- all of my recent bug fixes... I should really work on submitting them one by one!
(9 files, 13kb)

! Fixed blank page crashes on servers where shell_exec() is disabled and load averages are requested. (Load.php, ManageServer.php)

! MySQL's Truncate doesn't support multiple tables. (ManageMaintenance.php)

! Fixed line breaks being turned to HTML tags in album descriptions. Well, that was an unexpected bug... And the fix is even less expectable. Please test. (Aeva-Gallery.php)

! Fixed odd crash on PHP strict mode. Well, it's not so much the bug that's odd, rather the fix itself... (Class-CSS.php)

- Removed a few unused globals. (Class-DB.php, Class-String.php, Load.php)
Title: Re: New revs
Post by: Nao on November 10th, 2012, 05:55 PM
rev 1774
(1 file, 2kb)

- Committed a working copy by mistake. (index.css)

From rev 1773, forgot to mention it:

* Optimized space saving on !important and content rules in Wess. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on November 10th, 2012, 06:17 PM
rev 1775
(6 files -2, 2kb)

* Set show_gender to enabled by default. If for some reason you don't want to reveal your gender, you're absolutely free to set it to undefined in your profile... (install.sql)

! Have user_status's gender box follow the show_gender setting, removed gender icons, and the Gender profile line (instead it's all in the user status box now.) Should we keep the icon files for other themes to use..? Finally, simplified user context's gender variable to just hold the gender instead of an obscure array. (Load.php, Display.template.php, Female.gif, Male.gif, PersonalMessage.template.php, Profile.template.php)

@ Added reminder to self or Pete that we should work on some stuff... Or whatever. (ManageMembergroups.template.php)
Title: Re: New revs
Post by: Nao on November 10th, 2012, 08:07 PM
rev 1776
(2 files, 9kb)

* Rewrote the Homepage to categorize sections and allow admins to disable them one by one by setting related variables to false. All that's left to do is to move the latest topic code to Home.php instead of the template. (Home.php, Home.template.php)

@ As a reminder: $settings['default_index'] must be changed to 'Home' if you want to see the Wedge.org-like homepage on your site.
Title: Re: New revs
Post by: Nao on November 11th, 2012, 07:44 AM
rev 1777 - I think this one holds the record for highest number of changes that seem to fit into 1KB...
(7 files, 1kb)

! Various fixes to the stats page layout. Adding an extra div container is a bit of a cop-out, but there are few alternatives until we drop support for shitty old browsers like IE 6/7. (Stats.template.php, index.css, sections.css, extra.ie6/7/8/9.css)
Title: Re: New revs
Post by: Arantor on November 13th, 2012, 05:12 PM
(4 files, 1KB)

Revision: 1778
Author: arantor
Date: 13 November 2012 16:10:28
Message:
! Typo in paid subscriptions. (ManagePaid language file, possibly only English)

! Old calendar string left lurking. (Profile language file)

! The themes table must NOT have unsigned member ids, since we absolutely have to store -1 cases. No wonder member preferences and defaults are broken. (install.sql)
----
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Nao on November 16th, 2012, 03:25 PM
rev 1779
(2 files, 1kb)

! Fixed layout issue when viewing the maximum number of topics on the homepage. (Home.template.php)

! Fixed layout issue when posting a thought reply through a mobile skin. (Home.template.php)

! Fixed button lists in media albums. (media.css)
Title: Re: New revs
Post by: Arantor on November 18th, 2012, 04:42 PM
(7 files, 2KB)

Revision: 1780
Author: arantor
Date: 18 November 2012 15:41:37
Message:
! Missing likes image. (likes.png)

! The list of fields that should be called for entity-saving should be extensible in most cases now. (Class-Editor.php, PersonalMessage.php, Post.php, PersonalMessage.template.php, Post.template.php)

! Harmonised entity handling between quick reply and main reply. (Display.template.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Added : /trunk/Themes/default/images/admin/likes.png
Title: Re: New revs
Post by: Nao on November 25th, 2012, 10:33 PM
rev 1781 "Because I didn't want to have my first commit-less week..." :P
(5 files, 3kb)

! Worked around weird error that shows up when saving sessions in some specific setups. Seriously, I'm not 'fixing' what I'm sure is a PHP bug. (Load.php)

! Hopefully fixed bugs when trying to cache a non-existent CSS file. Needs some more work, I guess... (Subs-Cache.php)

* Grammar fix in French language JavaScript strings. (index, ManageMaintenance, ManageMembers)

(Pete, are you sure PHP 5.2 doesn't "always have json_decode"...? I mean, sure, people can disable it when recompiling PHP, but... Who does that? Who WOULD do that? Do you have any stats on this..?)
Title: Re: New revs
Post by: Arantor on November 26th, 2012, 03:48 AM
(7 files, 4KB)

Revision: 1782
Author: arantor
Date: 26 November 2012 02:47:42
Message:
! Add facility for stating an editor button's class when adding the button after instantiating wedit as suggested by Live. (Class-Editor.php)

! Add some extra options to cURL for secure connections. (Class-WebGet.php)

! Deleting a news item didn't flush the cache. (ManageNews.php)

! SMF bug: referer not checked when handling admin reverification. (Security.php)

! SMF bug: a few issues in the PayPal handler (Subscriptions-PayPal.php)

! SMF bug: who's online could be confused with session variables that are now wrong. Was fixed at some point post 2.0 but the fix was not migrated to Wedge. (Who.php)

! display_quick_reply not checked before use. (Media.template.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Media.template.php
Title: Re: New revs
Post by: Arantor on November 27th, 2012, 04:24 AM
(7 files, 14KB)

Revision: 1783
Author: arantor
Date: 27 November 2012 03:23:35
Message:
! Fixed bug in moderation filters that meant plugins couldn't use functions to handle custom rule descriptions. Thanks Live! (ManageModeration.template.php)

! Added ability to select 'everyone' in the boards area, as a shortcut to selecting all the groups. (ManageBoards.template.php, ManageBoards language file)

! Added ability to select 'everything' in the manage groups area, as a shortcut to selecting all the boards. Additionally, each category heading is also a shortcut now so it's possible to quickly select categories to hide/show from a given group. It's not entirely pretty but it does at least work as I originally intended it to, at least in Chrome. I make no allowances for the relative capabilities of other browserverses which I'm pretending to ignore at this stage. (ManageMembergroups.php, ManageMembergroups.template.php, ManageMembers language file, mana.css)

@ This took all damn evening. Laptop should, theoretically, be fixed tomorrow now the new fans are in. Better be fixed. They haven't seen me when I'm angry. I'm pretty sure they wouldn't like me when I'm angry.
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/skins/mana.css
Title: Re: New revs
Post by: Arantor on November 28th, 2012, 05:47 AM
(12 files, 6KB)

Revision: 1784
Author: arantor
Date: 28 November 2012 04:46:31
Message:
! Add type 'yesno' to the settings subsystem to retain some continuity with Aeva - functionally equivalent to 'check', but uses a dropdown. Depending on the outcome of my discussion on the subject, we might change its appearance. (ManageServer.php, ManageSettings.php, plugin-info.rng, Admin.template.php)

! Add facility whereby boards that are visible but not enterable can get a custom message to be shown to them. (install.sql, ManageBoards.php, Subs-BoardIndex.php, Subs-Boards.php, Boards.template.php, MessageIndex.template.php, ManageBoards.template.php, ManageBoards language file)

@ See also discussion in team board about this. There are consequences that I have not tackled in this commit.
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/plugin-info.rng
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Nao on December 2nd, 2012, 10:07 PM
rev 1785
(52 files, 9kb)

! Fixed strict mode error. (Class-MoDe.php)

* Lots of minor changes to unify CSS style definitions in HTML code, and other similarly non-important things. (About 50 files)

* French translation. (ManageBoards, ManageMembers)
Title: Re: New revs
Post by: Arantor on December 8th, 2012, 01:13 AM
(2 files, 4KB)

Revision: 1786
Author: arantor
Date: 08 December 2012 00:13:02
Message:
! Minor improvements to the manage moderation setup, should make it a little easier for typical plugins to extend it - at least the UI side of it. (ManageModeration.template.php)

! Likes are shown to guests, but the popup didn't work for guests. (Like.php)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Title: Re: New revs
Post by: Arantor on December 9th, 2012, 05:51 PM
(3 files, 1KB)

Revision: 1787
Author: arantor
Date: 09 December 2012 16:46:50
Message:
! Syntax error in post moderation. (PostModeration.php)

! Fix undefined errors and odd cases if a post was unliked but in the interim someone asked for the list of who viewed it. (Like.php)

! [SMF bug] queryPosts could be called with a variety of nasty consequences. (SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/PostModeration.php
Title: Re: New revs
Post by: Arantor on December 9th, 2012, 06:06 PM
(2 files, 9KB)

Revision: 1788
Author: arantor
Date: 09 December 2012 17:05:53
Message:
! Updated FTP class, features more debugging facilities, cleaner method for sending FTP messages over the primary channel (don't need to remember to follow each line with a newline, and the API handles debugging at the same time) plus the new GET and PUT methods over FTP, not fully battle tested. This is likely to expand in future, including multi-put and put from string, but not right now. (Class-FTP.php)

! weget should make use of FTP GET when downloading from FTP rather than getting it itself. (Class-WebGet.php)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Class-WebGet.php
Title: Re: New revs
Post by: Nao on December 10th, 2012, 04:50 PM
rev 1789 -- first time I'm letting an entire week pass between two commits... :(
(1 file, 1kb)

! Account for plugins passing a '.css' extension to add_plugin_css_file() when they shouldn't. (Subs-Cache.php)

! If a plugin's CSS file isn't found, we should gracefully fall back to a better solution. Or, at the very least, not crash everything. (Subs-Cache.php)

@ rev 1789 had to be given to the French guy... Even a bad flu won't prevent that!
Title: Re: New revs
Post by: Arantor on December 10th, 2012, 05:11 PM
(13 files, 22KB)

Revision: 1790
Author: arantor
Date: 10 December 2012 16:10:24
Message:
! Remove one of the wedge.org specific hacks in index.template.php. Still one to go, though. (index.template.php)

! Add something a halfway decent meta description for topic pages. (Display.php, Subs-Template.php)

! Providing users the ability to specify messages when a moderation filter will trigger to prevent or moderate a message. Aside from the UI for it, this also required extending how messages are displayed when they are moderated, though this is not much more than a WIP at this time. (install.sql, ManageModeration.php, Subs-Moderation.php, Post2.php, Display.php, ManageModeration.template.php, Display.template.php, mana.css, sections.css, Errors and ManageSettings language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/root/install.sql

@ The hack removed from index.template.php was ported to a plugin which is in the plugins repo.
Title: Re: New revs
Post by: Arantor on December 14th, 2012, 01:36 AM
(2 files, 1KB)

Revision: 1791
Author: arantor
Date: 14 December 2012 00:35:44
Message:
! When adding a new bbcode from a plugin, make sure to fill in the len cache. (ManagePlugins.php)

! Use the correct variable when passing the bbc buttons through the hook. (Class-Editor.php)

! When something that could be an image is passed as the 'image' parameter, treat it as a full URL. Detection is handled based on // rather than anything else because // is becoming a valid URL prefix to indicate schemeless requests (e.g. images requested with whatever the main page is using). (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManagePlugins.php
Title: Re: New revs
Post by: Arantor on December 15th, 2012, 12:49 AM
(1 file, 1KB, one line!)

Revision: 1792
Author: arantor
Date: 14 December 2012 23:49:16
Message:
! modfilter_msg_popup was not properly used. This isn't pretty but it's OK for now, we can make it prettier later when people who aren't us use the feature. (ManageModeration.php)
----
Modified : /trunk/Sources/ManageModeration.php
Title: Re: New revs
Post by: Arantor on December 15th, 2012, 10:01 PM
(1 file, 1KB)

Revision: 1793
Author: arantor
Date: 15 December 2012 21:00:24
Message:
! Fixed generic list not being able to handle timeformat or comma format properly, though I did actually harmonise them entirely with the other types, and fixed the only instance I could actually find of using that. Suggested ages ago by Live but at the time I never understood the benefits or practicalities of it. (Groups.php, Subs-List.php)
----
Modified : /trunk/Sources/Groups.php
Title: Re: New revs
Post by: Arantor on December 15th, 2012, 10:02 PM
(1 file, 1KB)

Revision: 1794
Author: arantor
Date: 15 December 2012 21:02:02
Message:
! Bah, forgot this one last time. (Subs-List.php)
----
Modified : /trunk/Sources/Subs-List.php
Title: Re: New revs
Post by: Arantor on December 16th, 2012, 06:02 AM
(4 files, 9KB)

Revision: 1795
Author: arantor
Date: 16 December 2012 05:01:48
Message:
! Added new type for settings in the admin panel: percent. Using much the same code as the profile/issue warning template, it's now possible to add a shiny draggable selector for settings. Also added a note to the profile to say that if it is changed, the admin equivalent should possibly be touched too. I would note this isn't really finished, but I wanted to get a 'working' version committed. It isn't pretty at all at the code level, but it does support multiple selectors per page, too. I totally didn't need this for my new ban system or anything. (plugin-info.rng, ManageServer.php, ManageSettings.php, Admin.template.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Arantor on December 16th, 2012, 06:16 AM
(2 files, 2KB)

Revision: 1796
Author: arantor
Date: 16 December 2012 05:15:08
Message:
! Stupid typo. I shouldn't commit this late at night. (ManageSettings.php)
! Forgot to actually commit the profile template I added a comment to. (Profile.template.php)
! Converted some settings that actually made sense to the new percent type. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Profile.template.php
Title: Re: New revs
Post by: Nao on December 16th, 2012, 02:21 PM
rev 1797
(40 files, 7kb)

* Harmonized all index.php files that were only there to prevent manual folder exploration. All files now use the same contents -- a single-line redirect to the upper level. Simpler, better. Could be done with an .htaccess file, but I believe it's better to rely on PHP here. The only thing I'm not sure about is whether I should forcibly add index.php to the redirect or leave it this way... There's still time to adapt. (40 occurrences of */index.php)
Title: Re: New revs
Post by: Arantor on December 16th, 2012, 03:06 PM
(2 modified, 1 new, 4KB)

Revision: 1798
Author: arantor
Date: 16 December 2012 14:05:23
Message:
! Bah, commit overlap. Moving all styling for the admin percent sliders to the management CSS which also has some stuff for the new ban page, which I might as well commit the styling for while I'm at it. This is all still not finished, mind. (Admin.template.php, mana.css, ban_items.png)
----
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/admin/ban_items.png
Modified : /trunk/Themes/default/skins/mana.css
Title: Re: New revs
Post by: Nao on December 16th, 2012, 03:34 PM
rev 1799 -- working on committing a larger rev right now.
(2 files, 3kb)

+ Saving a few bytes on CSS cached files where a path calculated through a global var like $here or $images could be longer than needed (like/this../../). (Subs-Cache.php)

! Take into account the user's OS when caching CSS files (re: an upcoming huge commit.) However, this is a bit buggy so I'm only committing this until I decide whether or not I should keep CSS file suffixes this way. Because of the difference in filename handling, it seems best to drop support for hasBrowser-based suffixes, and instead relying on @if/@is statements inside the files themselves. They're probably better off as tests inside the files only. (Subs-Cache.php)

* A quick note in BB rules for Pete to read mostly... Feel free to remove it if I'm mistaken. (Security.php)
Title: Re: New revs
Post by: Nao on December 16th, 2012, 03:43 PM
rev 1800
(15 files, 27kb)

@ This is the 'revolutionary' update I'd hoped to commit as r1789, ah ah, but it wasn't ready yet.

* Rewrote much of the detectBrowser() function. (Load.php, Home.php, Aeva-Gallery.php, Post2.php, Welcome.php, Xml.template.php, editor.js, script.js, index.css, Wuthering/skin.xml, attic/Unused-dynPrefixed.php)

  Wedge will no longer return 'iphone' and 'tablet' entries -- these should be addressed through media queries primarily, and/or analysis of the user agent string.
  Browser and OS are now stored in two different variables -- $context['browser']['agent'] and $context['browser']['os']
  Browser and OS versions are also stored in 'version' and 'os_version' variables. Minor updates like the '5' in '4.1.5' aren't stored, to save space.
  Likewise, old OS versions aren't stored (Windows < XP, iOS < 4, Android < 2).

* Rewrote much of the hasBrowser() function as well... (Load.php, Wine/extra.css)

  Added support for OS names, now a test against 'windows' will work. Supported: windows, ios, android, mobile.
  Added support for OS versions, e.g. 'windows[6.1-]'.
  Added support for negative statements, e.g. '!chrome' will return a positive if you're not using Chrome.
  Added support for logical AND & or && (whatever suits you best). 'windows, !android && firefox' means 'using Windows, or Firefox but not in Android.'

! Fixed ambiguity with browser/OS versions in Wess's prefix handler. $android should now only be set for the Android stock browser, $iphone is replaced with $ios, and $safari should no longer be set in iOS, for the purpose of these tests of course. (Class-CSS.php)

+ Non-Android, non-iOS mobile devices will now show a regular wireless icon. (Post2.php)

* French Translation. (Errors, ManageSettings)
Title: Re: New revs
Post by: Nao on December 17th, 2012, 03:10 PM
rev 1801
(11 files + 3 renames, 7kb)

* Renamed the Help template to GenericPopup, which makes more sense. Renamed $context['help_text'] to 'popup_contents'. Best way to hide a hack is to have it in plain view. Ha. (Help.php, Like.php, ManageErrors.php, ManageModeration.php, ManagePlugins.php, ViewQuery.php, GenericPopup.template.php, script.js, extra.ie6.css, extra.ios.css, index.css)

! Forgot to rename a few iphone CSS files to ios. Until I get to rewriting the feature... (extra.ios.css in Weaving, Warm and Wireless)
Title: Re: New revs
Post by: Nao on December 21st, 2012, 06:42 PM
rev 1802
(42 files, 36kb)

+ Implemented 'we' object, which is the system class containing the equivalent of $context['browser'], and soon $user_info or at least part of it.

(index.php, attic/*, Sphinx/sphinx_config.php, install.php, install.sql, Announce.php, Class-CSS.php, Class-Editor.php, Class-System.php, CoppaForm.php, Dlattach.php, Home.php, Load.php, Aeva-*.php, ManageMedia.php, Subs-Media.php, PersonalMessage.php, Post2.php, Subs-BBC.php, Subs-Cache.php, Subs-Template.php, Welcome.php, TEMPLATES: Admin, Display, GenericMenu, index, Mailer, ManageBoards, ManageMembergroups, ManageNews, ModerationCenter, Packages, PersonalMessage, Post, Profile, Register, Themes, Xml)
Title: Re: New revs
Post by: Nao on December 22nd, 2012, 05:17 PM
rev 1803
(87 files, 90kb) (sigh... most everything done by hand!)

+ Moved $user_info to the system object, so that you no longer have to declare it as a global. Still tons of entries to modify, will come later. From now on, use those instead of these:
  $user_info => we::$user
  $user_info['id'] => we::$id
  $user_info['is_guest'] => we::$is_guest
  $user_info['is_admin'] => we::$is_admin
  Alternatively, you can use we::is('admin') or we::is('guest') but it's 5 times slower (still lightning fast though, but not to use in a million loops.)
  (87 files, not listing them all.)

- Removed $context['user']['is_mod'], never used... As a prelude to removing $context['user'] entirely anyway.
Title: Re: New revs
Post by: Nao on December 22nd, 2012, 06:00 PM
rev 1804
(99 files, 2.75MB...)

* Finished replacing all $user_info occurrences with we::$user and removing all $user_info globals. Nice new little search & replace program I just found... Should we optimize setupMenuContent and setupThemeContext in Subs.php...? (99 files)

@ Okay, not such a nice program... It didn't allow me to save with Linux newlines. I'll just need an extra commit to get rid of those... F'n great.
Title: Re: New revs
Post by: Nao on December 22nd, 2012, 06:13 PM
rev 1805
(96 files, 2.64MB) (For some reason, some of the modified files weren't changed to CRLF: Subs-BBC, Subs-MessageIndex and the Home template.)

! Oops, CRLF fix. (96 files)
Title: Re: New revs
Post by: Arantor on December 22nd, 2012, 07:39 PM
(11 files, 2KB)

Revision: 1806
Author: arantor
Date: 22 December 2012 18:37:58
Message:
! Bits and pieces for the changes to banning. Just so that I have everything in sync with how it all works now and that I don't have *everything* to commit all at once. Remember: is_activated is going to be more than 20 for bans now, not more than 10. (wedge_api.php, Class-System.php, ManageMembers.php, Profile-Actions.php, Profile-View.php, Security.php, Subs-Auth.php, Subs-Login.php, Subs-Members.php, Subs-Post.php, Suggest.php)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/other/tools/wedge_api.php
Title: Re: New revs
Post by: Arantor on December 22nd, 2012, 10:21 PM
(4 files, 2KB)

Revision: 1807
Author: arantor
Date: 22 December 2012 21:21:07
Message:
! Actually declare functions to their correct scope, and we::analyze is called statically so indicate it is. (Class-System.php)

! No need for the loadUserSettings function any more, might as well just do it where it needs to be done. (Load.php, index.php, SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Arantor on December 24th, 2012, 12:00 AM
(5 files, 23KB)

Revision: 1808
Author: arantor
Date: 23 December 2012 22:59:36
Message:
! Yeah, so it's been annoying me that the mod buttons in topic didn't all have icons. Move topic still doesn't, because I haven't found a suitable icon, but merge does have an icon, so make a suitably sized version and use it. (index.member.css, small_merge.gif)

! Some more of the ban stuff, just to make it more digestible to manage, including the fairly complete language file for ban management. (mana.css, ban_items.png, ManageBans.english.php)
----
Modified : /trunk/Themes/default/images/admin/ban_items.png
Added : /trunk/Themes/default/images/small_merge.gif
Added : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/Themes/default/skins/mana.css
Title: Re: New revs
Post by: Arantor on December 24th, 2012, 04:33 PM
(3 files, 3KB)

Revision: 1809
Author: arantor
Date: 24 December 2012 15:32:28
Message:
! The installer *needs* the we object to *only* set up detect browser, not the entire user stuff, when for half the installer, the user won't even exist. (Class-System.php, install.php)

! Typo in one of the bbcodes. I really must make an editor for this. (install.sql)

! Some changes to the installer SQL, mostly that tie in to the ban changes. One new table, one new column in the members table, a couple of blank lines for consistency, and moving some of the settings into the new ban table as that's where the functionality will be driven from in due course. (install.php, install.sql)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/root/install.php
Modified : /trunk/root/install.sql

@ The new column is not related to the ban stuff but to a new feature I've talked about recently. Right now it's not a big deal, but it will be in the future, so best that we put it in now while we're doing other changes to the file.
Title: Re: New revs
Post by: Nao on December 24th, 2012, 06:24 PM
rev 1810
(12 files +1, 19kb)

+ Added browser version limiter on CSS filenames, to avoid having too many files for just a couple of guests. Opera v10 and earlier are less than 5% of Opera's share, so I set the minimum version to 11. Minimum versions for Chrome: 20, Safari: 4, IE: 6, and Firefox is a special case because v3-4 are still a bit popular, so I'm keeping v3.x, v4.x and v16 and above. (Class-System.php, Class-CSS.php)

* Various changes to the user object. Some functions are now protected. (Class-System.php)

* we::is('mobile') being a bit slower and being often called on pages, I'm changing that to we::$user['is_mobile']. Feel free to use we::is('mobile') in plugins or whatever, of course. (Load.php)

* Translation. Hmm... There's plenty of other files to clean up... I should have done that first, and re-used the original translations... Whatever. Also fixed English version typo. (ManageBans)

- Removed PREG_PATTERN_ORDER optional param from a few loose preg_match_all calls. (Class-Editor.php, Class-Packer.php, ManageMemberOptions.php, PersonalMessage.php, Profile-Modify.php, Search2.php, Subs-BBC.php, Subs-Template.php)

@ Woohoo, yet another commit conflict... I'm telling you Pete, I was far from done with the we object! Oh, and sorry for the install.php/sql bugs. And I fully agree for the editor :P

Merry Christmas everyone :)
Title: Re: New revs
Post by: Arantor on December 30th, 2012, 06:19 PM
(Trying not to leave it too long between commits.)

(4 file, 2KB)

Revision: 1811
Author: arantor
Date: 30 December 2012 17:18:29
Message:
! Silly typo in the installer was not consistent with how everything else worked. (install.php)

! Disallow the new bans table from being dropped. (Class-DBPackages.php)

+ FTP class now has an upload facility that directly accepts a string rather than just demanding a local file. (Class-FTP.php)

! More updates of the manage-bans language file ready for translation. It is still a WIP though... (ManageBans.english.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/root/install.php
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 01:18 AM
(1 file, 1KB)

Revision: 1812
Author: arantor
Date: 31 December 2012 00:18:09
Message:
! Stop the file cache from using a core Wedge file as the seed for cache hashes, use a separate file in the cache directory. This file should remain empty, but it means the *core* files are to be left alone. This means we can safely have a maintenance task or something to check file dates. (Subs-Cache.php)
----
Modified : /trunk/Sources/Subs-Cache.php
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 02:09 AM
(14 files, 42KB)

Revision: 1813
Author: arantor
Date: 31 December 2012 01:02:16
Message:
Doing something I don't normally do, commit something that's completely a WIP, but mostly because I'm fed up with it right now and want to do a few other things that this would conflict with.

! Spacinazi. (Admin.php)

! Strip the old reserved names code and use the new one. (Class-UnitTest_tidyhtml.php, Admin.php, ManageRegistration.php, Subs-Members.php, Who.php, Register.template.php, language files: Admin, Help, Who)

! Part of the new ban system. Enough to be able to display any bans in the system, and the ban system is quite happy to filter out reserved names now. (Admin.php, ManageBans.php, ManageBans.template.php, language files: Admin, Help)

@ The ban system isn't remotely usable yet. It also has the unfortunate side effect of breaking the ban-user dialog which also uses the same base system, another thing to be rewritten. I'm just fed up of trying to figure out this stuff right now and would rather get it committed so that I can do more fun stuff and then come back to it when I'm a little more fresh of mind.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 02:59 AM
(12 files, 6KB)

Revision: 1814
Author: arantor
Date: 31 December 2012 01:59:15
Message:
! Don't show IP addresses to anyone unless they can ban - not even a user's own one. There's really no need to show it anywhere. As far as I can tell this gets everything. (install.sql, Display.php, ManageErrors.php, ManageMembers.php, ManagePermissions.php, Modlog.php, Profile-View.php, Profile.php, Who.php, ManageMembers.template.php, language files: ManagePermissions)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 04:23 AM
(4 files, 3KB)

Revision: 1815
Author: arantor
Date: 31 December 2012 03:22:53
Message:
+ Add ability for admins to force-clean-up on topics with too many exclamations/question marks or too many capitals. (ManagePosts.php, Post2.php, language files: Admin, Help)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 06:06 AM
(8 files, 6KB)

Revision: 1816
Author: arantor
Date: 31 December 2012 05:05:25
Message:
! Stupid bug with posting whereby attachments would be saved in reverse order to what they were added by the user. (Post2.php)

! Silly bug in view members area related to IP addresses change. (ManageMembers.php)

! Now possible to select Email Activation then Admin Approval. I believe I've hit all the routes correctly. Needs more testing. (Activate.php, ManageRegistration.php, Register.php, Subs-Members.php, language files: EmailTemplates, Login)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/Login.english.php
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 07:15 PM
(4 files, 3KB)

Revision: 1817
Author: arantor
Date: 31 December 2012 18:14:47
Message:
! When displaying the date in threads in mobile view, the timezone adjustment was being applied twice. (Display.php)

! Auto-purge unapproved members after x days. Currently defaults to 0, configurable by admin. (ManageRegistration.php, ScheduledTasks.php, Login language file)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/Login.english.php
Title: Re: New revs
Post by: Arantor on December 31st, 2012, 07:19 PM
(1 file, 1KB)

Revision: 1818
Author: arantor
Date: 31 December 2012 18:18:07
Message:
! Stupid, stupid bug. is_activated should be 0 not 1 as 0 means unactivated. (ScheduledTasks.php)
----
Modified : /trunk/Sources/ScheduledTasks.php

@ Stupid mistake to make, but it's because I was thinking about registration_method which uses 0 for immediate registration, 1 for approval, while is_activated uses 0 for unapproved and 1 for approved.
Title: Re: New revs
Post by: Arantor on January 1st, 2013, 01:54 AM
First commit of 2013. Long may this activity continue.

(4 files, 5KB)

Revision: 1819
Author: arantor
Date: 01 January 2013 00:53:11
Message:
! Fix missing language strings in admin panel. They don't *do* anything yet, but they might shortly. (ManageMembers.english.php)

! Updated profile code to use correct function call rather than loadUserSettings... but I have the nasty feeling this isn't doing what it's supposed to be doing, since neither loadUserSettings calling we::anything or this is actually forcing a reload of the user's details. Maybe needs a new method to force reload? (Or deprotect init_user() maybe?) Either way there are times we need to be able to force reloading user data. (Profile-Modify.php)

! New DB column in the membergroups table, this time to allow for setting the display order of badges. The UI's not done, of course, but it is possible to force the order of groups for whatever reason. Even the primary group is not exempt. Also corrected one comment regarding show_when; primary group would not have a badge if show_when was set to 0 because the query simply excluded it from being loaded anyway. Now all we need is a spiffy UI for setting the order and whether they are to be displayed or not. (Load.php, install.sql)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on January 1st, 2013, 05:57 AM
4 files, 1 added, 221KB[1]

Revision: 1820
Author: arantor
Date: 01 January 2013 04:56:49
Message:
! UI for customising badge order and visibility. It's not perfect, it could use some UI loving in places (e.g. replacing the little handle square with something nicer), but it works and doesn't throw errors. As stated elsewhere, yes, it adds a complete copy of jQuery UI to the repo, but 1) this is only used in the admin area, not every page load, and 2) it means that if others do want to use it in their own plugins, it's available. (ManageMembergroups.php, ManageMembergroups.template.php, mana.css, jquery-ui-1.8.24.js, ManageMembers language file)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Added : /trunk/Themes/default/scripts/jquery-ui-1.8.24.js
Modified : /trunk/Themes/default/skins/mana.css
 1. This is almost entirely due to jQuery UI.
Title: Re: New revs
Post by: Arantor on January 1st, 2013, 06:25 PM
20 files, 4KB

Revision: 1821
Author: arantor
Date: 01 January 2013 17:23:05
Message:
! Clean-up of legacy code. (ManageBoards.php, ManageMembergroups.php, ManageNews.php, ManagePermissions.php, ManageSmileys.php)

! Add the membergroups settings to the admin search. (ManageMembergroups.php, Admin.php)

! Fix collision with jQuery UI and Wedge's menu by renaming Wedge's menu (so that other plugin authors can use jQuery UI without problems). (GenericMenu.template.php, index.template.php, script.js)

! Drop the old group key option from the theme settings, convert it to a normal setting and inherit the sorting from the other sources. (Settings.template.php, Boards.php, Home.php, ManageMembergroups.php, Welcome.php, SSI.php, Subs-Membergroups.php, InfoCenter.template.php, language files: Help, ManageMembers, Themes)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/scripts/script.js
Title: Re: New revs
Post by: Nao on January 2nd, 2013, 09:46 PM
rev 1822
(3 files, 2kb)

! Fixed class object instantiation not correctly initializing the browser array. (Class-System.php)

* Adding privacy tables to the list of protected tables. I think we should do a thorough check of all our table names before proceeding... (Class-DBPackages.php)

* Don't need to reset the permissions array at that point. (Still need to fix the fact that permissions can be tested against before 'we' is initialized...) (SSI.php)

@ Re: rev 1820, if we regularly update jQuery and jQuery UI, it'd probably be smarter to allow for plugin authors to link to an alias of these libraries, i.e. jquery.js and jquery-ui.js, which would then be redirected to the latest...? Or just rename the files.
Title: Re: New revs
Post by: Arantor on January 3rd, 2013, 03:54 AM
(90 files, 4KB)

Revision: 1823
Author: arantor
Date: 03 January 2013 02:52:40
Message:
! Lots of loose bytes saved. (many files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Buddy.php
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Merge.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs-Sound.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Thoughts.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/index.template.php

@ This is literally cleaning house after that big ol' find/replace operation. Whatever tool was being used, when it was told to use Unix format, it was using strict Unix format, which says there must be a blank line at the end of the file >_<
Title: Re: New revs
Post by: Arantor on January 3rd, 2013, 05:12 AM
(5 files, 2KB)

Revision: 1824
Author: arantor
Date: 03 January 2013 04:11:14
Message:
! Protect all the instances of calling plugin XML files against XXE. (Admin.php, ManagePermissions.php, ManagePlugins.php, ManageSettings.php, Reports.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Reports.php

@ If anyone asks me what XXE vulnerabilities are, I will explain. For now, just understand that it is a vector of vulnerability that SMF does not have because SMF doesn't use SimpleXML and we do; SMF, because of its history, rolled its own XML handling class while SXML is installed by default on PHP 5 and we can make use of it as such.
Title: Re: New revs
Post by: Nao on January 3rd, 2013, 05:35 PM
rev 1825
(4 files, 2kb)

! Noticed this typo in the latest scheduled tasks query. (ScheduledTasks.php)

* Clarifying a comment. (Security.php)

* Apparently, a singleton's __clone() function doesn't need to return false. (Class-System.php)

* Loading system object first, just in case. At least things like we::$is_admin will return null, and no error, if something is triggered too early. (index.php)
Title: Re: New revs
Post by: Arantor on January 5th, 2013, 02:20 AM
(5 files, 1 added, 43KB)

Revision: 1826
Author: arantor
Date: 05 January 2013 01:19:57
Message:
! Fixing an Englishism for Americanism as all the language files are "American" English. I couldn't immediately find any others. (Help language file)
! More of the plugin upload system including the magic new zip unpacking in place tour de force. This is part one of many, I should imagine a fair amount of it, including progression into the next step of installation, is broken but I want to commit where I am so I can rest a bit mentally. Bloody colds. (Class-ZipExtract.php, ManagePlugins.php, Subs-Plugins.php, ManagePlugins.template.php, ManagePlugins english)
----
Added : /trunk/Sources/Class-ZipExtract.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php

@ Remember the zip extract library is 18KB, not to mention the fact that the rest of the changes are not simple - there's a bunch of refactoring bits in there too.
Title: Re: New revs
Post by: Nao on January 6th, 2013, 12:19 PM
rev 1827
(12 files, 14kb)

+ Added add_jquery_ui() generic function. It will automatically load jQuery UI (only once per page), from your server or your CDN of choice, and it follows your jQuery Origin admin setting. (Subs-Cache.php, ManageMembergroups.php)

* Rewrote JavaScript code's is_* browser variables to avoid using $.browser, to ease transition into jQuery 1.9 once we do the jump. In the process, I saved a total of 2 gzipped bytes. Yes I did spend half an hour doing permutations just to see what was the shortest. Yes I did spend another half hour agonizing over the fact that I'm executing .toLowerCase() at least 6 times more than needed and wasting about a microsecond of your computer's CPU, just to save a total of 4 more bytes. But at least I got the little sucker and made it shorter than it was before. Don't look at me like that. Why are you looking at me. Get off my lawn. (script.js)

- The days of IE spoofing are over. In Opera's case, it stopped doing it by default at least 8 years ago. It's time to remove these odd hacks... (Class-System.php, script.js)

* Casenazi. Microsoft's CDN URLs are case-insensitive, so might as well use the lowercase version for better HTML gzipping... Ah ah. (Load.php)

* Spacinazi. I tend to like having a space after PHP flow control instructions, like if () or foreach (). catch () looks like a flow control instruction to me. But don't get me started on other instructions I might have overlooked... (Subs-Plugins.php)

* Minor system object reference simplifications. (Class-System.php, Load.php, Security.php, Subs-Login.php)

* Since the system object is now loaded (not initialized though) before all other file includes, it's always defined. (Errors.php, Security.php)

* Added 3 missing files to the file list for XML purposes. Not that we're ever gonna use that... (xml/detailed-version.php)

! Another bastardization that needed to be made. I feel for you, Pete. (Help.english.php)

! Fixed ISO to UTF8 in latest French file. (ManageBans.french.php)
Title: Re: New revs
Post by: Arantor on January 7th, 2013, 05:03 AM
(5 files, 4KB)

Revision: 1828
Author: arantor
Date: 07 January 2013 04:02:43
Message:
! Disallow zip and lock files from being served from the cache folder. (.htaccess)

! Clear up a factual inaccuracy. (Help.english.php)

! Add hooks as suggested by minimoo about handling registration errors a bit better, though taking into account the differences between as suggested and the way hooks are supposed to work. (ManagePlugins.php, Subs-Members.php)

! A minor optimisation based on learning a bit more about how the $reg_errors stuff actually worked; it supports pushing parameters as well. (Subs-Members.php)

! I forgot this: PHP in its wisdom will remove uploaded files at the end of execution if not moved or renamed. So I move it into the cache folder for now because it's somewhere that is writable in local space. However there is still plenty more to do, and I will need to add checks in to ensure that the files are purged periodically too. (Subs-Plugins.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/cache/.htaccess
Title: Re: New revs
Post by: Arantor on January 7th, 2013, 07:29 PM
(4 files, 3KB)

Revision: 1829
Author: arantor
Date: 07 January 2013 18:28:37
Message:
! SMF bug: error log could in some cases be the victim of a directory traversal bug, and/or showing the contents of files inappropriately. SMF devs have been notified. (ManageErrors.php)

! SMF bug: Some SSI functions still could be called from GET request, but not have the parameters to make this happen. I've added them to our list of functions that can't be called from GET, but I'm not sure this is something we need to keep as a feature, except for poll voting purposes anyway, and we might be better served by dropping all the other options for GETs. (SSI.php)

! Just 'correctness' in the drafts show code, everywhere else in that function uses the profile standard $memID rather than we::$id even though they should be the same. (Profile-View.php)

! Yes, Nao, I'll admit there was a bug in moderation filters! Stupid bug, don't know why I didn't catch this months ago when I first wrote it, calling the wrong function to update the UI. (ManageModeration.template.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Title: Re: New revs
Post by: Arantor on January 8th, 2013, 05:20 AM
(7 files, 15KB)

Revision: 1830
Author: arantor
Date: 08 January 2013 04:18:25
Message:
! Update the manage-mail area to use a proper button in place of a bare link, fixes a side issue with event-overridden links, but also looks more consistent. (ManageMail.php, ManageMail.template.php)

! The is-email-banned checks now should be querying the new bans system rather than the old, and it seems to work for both soft and hard bans (soft bans just prevent registration and guest posting using them, hard bans properly ban the session and leave a nice little banned cookie around), for all kinds of crazy things (exact match, wildcarded, entire domains, including handling GMail style dot removal and label use, and entire TLDs or parts thereof). Of course, the big work is done in Security.php, but the other places had their calls updated; we don't differentiate between 'cannot register' and 'cannot guest post' in terms of bans these days, it's really not needed. There is still work to do with the ban system; IP addresses need filtering out too, and then I need to replace updateBanMembers() with a version that works in the new banned world, but it's getting there. Then it needs MOAR testing. (Activate.php, Post2.php, Report.php, Security.php, Subs-Members.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManageMail.template.php


There is a lot left to do as I indicated, but most of the updateBanMembers calls were done in the admin panel where I can field it more easily; there's no need to call it when evaluating a ban for regular members as such - only need to evaluate the current user and fix their ban status.. ohcrap a typo I just realised.
Title: Re: New revs
Post by: Arantor on January 8th, 2013, 05:21 AM
(1 file, 1KB)

Revision: 1831
Author: arantor
Date: 08 January 2013 04:21:06
Message:
! Really not sure how I missed this one. The code isn't tested, that should be obvious, but mostly because to properly test it, I need to finish rewriting it >_> (Security.php)
----
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Nao on January 8th, 2013, 06:15 PM
rev 1832
(7 files, 5kb)

* Saved more precious gzipped bytes off both HTML pages and included script files, by: (script.js, sbox.js, index.template.php, GenericMenu.template.php, ManageModeration.template.php)

  - Moving $('select').sb() to a DOMContentLoaded event instead of having it both in sbox.js and the HTML.
  - Moving bindEvents() to that same event, instead of having a separate function, and fixing index and ManageModeration templates not to use it.
  - Turning $.fn.wmenu() into a _b function, and calling it along with the rest. It's all cleaner this way...

! Fixed anchor links not properly working if associated with an ask() function. Unfortunately, this fix, however short it is, negates many of the bytes saved above. Well, not all, thankfully... (script.js)

! Draft removal 'delete all' form was using an onclick, instead of onsubmit, effectively making the entire horizontal area clickable... (Profile.template.php)

* Modified minimum menu ID value to 0 instead of 1... Only saves one addition at one moment. But I really didn't like it. (Subs-Menu.php, GenericMenu.template.php)
Title: Re: New revs
Post by: Arantor on January 9th, 2013, 04:33 AM
(3 files, 1KB)

Revision: 1833
Author: arantor
Date: 09 January 2013 03:32:36
Message:
! Renamed the spam_settings hook to settings_spam because other pages are going to be hookable and they should really have a consistent naming structure. (ManagePlugins.php, ManageSettings.php)

! Speaking of which, ban settings are also hookable, through the settings_bans hook. (ManageBans.php, ManagePlugins.php)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Title: Re: New revs
Post by: Arantor on January 9th, 2013, 05:53 AM
(3 files, 2KB)

Revision: 1834
Author: arantor
Date: 09 January 2013 04:51:49
Message:
! Supporting testing of IP addresses in ban system. Still not finished, but this is the next bit. (Security.php)

! First soft ban support, disabling search if the user is soft banned. Yes, even for IP addresses. Yes, that's right, I actually gave in and allowed Annoy User support for IP addresses. There. (Search.php, Search2.php, Security.php)
----
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Security.php
Title: Re: New revs
Post by: Arantor on January 9th, 2013, 09:48 PM
(3 files, 2KB)

Revision: 1835
Author: arantor
Date: 09 January 2013 20:45:49
Message:
! More soft ban goodness. Softbanned IP addresses now can be exempt from registration, and the occasional (intentional) blank screen won't go amiss either. (ManageBans.php, Security.php, ManageBans language file)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php

@ I did warn you that Annoy User was back and coming to a Wedge near you :niark:
Title: Re: New revs
Post by: Nao on January 10th, 2013, 06:11 PM
rev 1836
(412 files, 20kb)

* Removed closing ?> from all files, this should calm down everyone who fears for their headers. Or whatever... (Hundreds of files.)

* Changed last copyright year to 2013. Do we even need to provide a 'latest' year..? (Hundreds of files.)

* Also fixed a few minor things, like a broken link, yeah, nothing fascinating... Oh, and a minor license change, to make it shorter. Have to finish discussing it with Pete though, but it's closer to the original SMF license. (A few files. Damn I don't even want to remember which ones.)
Title: Re: New revs
Post by: Nao on January 11th, 2013, 09:15 AM
rev 1837
(10 files, 20kb)

* French translation. Hopefully didn't forget anything or screw up the translation work itself. There was a lot to do... (Admin, EmailTemplates, Help, Login, ManageBans, ManageMembers, ManagePermissions)

! Typo in English version. Also reworked e-mail templates for breathing space. (Help.english.php, EmailTemplates.english.php)

* Commenazi. I believe that when a comment is a sentence (e.g. has a comma in it), it should end with a period. Anyway, not very important and I'm sure I missed hundreds before... I just felt like it. (Security.php)
Title: Re: New revs
Post by: Nao on January 11th, 2013, 07:29 PM
rev 1838
(22 files, 15kb)

* Turned $context['user']['is_logged'] into !we::$is_guest, $context['user'] into we::$user and optimized $context globaling on many files. (index.php, Subscriptions-Authorize.php, Subscriptions-twoCheckOut.php, smfinfo.php (uh?), Ajax.php (actually a comment that no longer makes much sense..), Class-System.php, Load.php, MessageIndex.php, Profile-Modify.php, Subs-Template.php, ViewQuery.php, SSI.php, TEMPLATES: Boards, index, ManagePermissions, MessageIndex, ModerationCenter, Profile)

* Converted a few more $scripturl calls to <URL>. (MessageIndex.template.php, Profile.template.php)

* Forgot to commit a couple of language files. French translation, but also another fix (a line that is no longer used AFAIK.) (Admin.english.php, Admin.french.php, ManagePlugins.french.php)

! Fixed Chrome and IE10 behaving oddly with the body transition when loading (IE10) or reloading (Chrome) pages. (index.css)

@ Only got started on $context['user'], as there are a lot, so please bear with me, I should fix Wedge, err... hopefully tonight. I'm watching the FF9 live speedrun for AGDQ at the same time... These are the limits of my multi-tasking abilities.
Title: Re: New revs
Post by: Arantor on January 12th, 2013, 12:29 AM
(17 modified, 2 deleted, 17KB)

Revision: 1839
Author: arantor
Date: 11 January 2013 23:28:24
Message:
! Typo in index template. (index.template.php)
! Removal of the crazy wesql::extend stuff. It should never have lingered. So, what was wedbExtra is now part of the packages stuff (which might be renamed yet), which makes sense as the packages stuff loaded it anyway. What was wedbSearch was just folded into the search code or flattened out, e.g. the test for 'supports fulltext'., and lastly, wedbPackages is no longer a singleton in the way it was set up. It made no sense to be, in hindsight, it's just a collection of static methods now. It's not had proper testing though so it might be all kinds of borked. (lots of files)
----
Modified : /trunk/Sources/Class-DB.php
Deleted : /trunk/Sources/Class-DBExtra.php
Modified : /trunk/Sources/Class-DBPackages.php
Deleted : /trunk/Sources/Class-DBSearch.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.php
Title: Re: New revs
Post by: Nao on January 12th, 2013, 12:54 AM
rev 1840
(27 files, 8kb)

* Finished converting $context['user'] to we::$user. Hopefully, it'll work without changes... (Display.php, Login.php, ManageMembergroups.php, PackageGet.php, PersonalMessage.php, Aeva-Gallery.php, ManageMedia2.php, Post.php, Profile.php, Profile-*.php, Register.php, Search2.php, Security.php, Subs-Cache.php, Subs-Template.php, ViewQuery.php, TEMPLATES: Admin, Boards, Display, index, InfoCenter, Login, Mailer, ManageMembergroups, MAnagePaid)

@ Note to Pete: lulz, commit conflict ;) I'd actually fixed the index template typo ready for this rev (hence the rev conflict), but it's good that you saw it as well!
Title: Re: New revs
Post by: Arantor on January 12th, 2013, 03:33 AM
(1 file, 1KB)

Revision: 1841
Author: arantor
Date: 12 January 2013 02:32:48
Message:
! There was a collision between what used to be $context['user']['avatar'] and $user_info['avatar']. Hopefully fixed now. Haven't found any other such collisions, but it's always possible. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on January 12th, 2013, 07:06 PM
rev 1842 -- heavy CSS work I had to commit for the last few months... Hopefully won't break anything, please test! -_-
(10 files -13, 9kb)

! Various Wuthering fixes, such as blog titles, fixing the sidebar, removing the gradient on the header (grew tired of it!), or rewriting the breadcrumb for better results and cross-browser compatibility. (Wuthering/extra.css)

* Moved plenty of browser hack CSS files into their parents, using @if and @is instructions. Not all children files were removed, I'm still trying to determine if it's worth it for big files like main IE hacks. (common.css, common.firefox[-2].css, extra.chrome.css, extra.firefox.css, extra.ie[-8].css, index.css, index.member.css, media.css, media.ie[-7].css, zoom.css, zoom.webkit.css, WINE: extra.css, extra.ie.css, extra.ie6.css, extra.ie8.css, WARM: extra.css, extra.ie[-9].css, extra.ios.css, WUTHERING: extra.css, extra.ie[-9].css, WIRELESS: extra.css, extra.ios.css)

- Removed a safety on Chrome. It didn't have the opacity animation on menus, perhaps it used to kill performance? Please report if you have any problems with this, seems to work fine in Chrome v26. (extra.chrome.css)

* Giving a max to a random input value somewhere, because its input size bothered me. You know me... (ManageSettings.php)
Title: Re: New revs
Post by: Arantor on January 13th, 2013, 04:18 AM
(1 file, 5KB)

Revision: 1843
Author: arantor
Date: 13 January 2013 03:17:25
Message:
! Added another interesting nasty that's crossed my radar to the block list. Seems to be an XRumer knock-off that's doing the rounds. (Security.php)

! Removal of the old ban trigger hit updater. We're not logging ban trigger hits any more, because it wasn't used much if at all by most users, and when you have users who are a pain, it's best to not spend any more time on them than you have to. (Security.php)

! Ban system can now apply bans to hostnames if hostname lookups are enabled. (Security.php)
----
Modified : /trunk/Sources/Security.php

@ I know it's all one file but they're thematically separate commits, just packaged for better value and Wedgey goodness. Think I might treat myself to a cupcake for this one.
Title: Re: New revs
Post by: Arantor on January 13th, 2013, 05:58 AM
(3 files, 2KB)

Revision: 1844
Author: arantor
Date: 13 January 2013 04:55:24
Message:
! OK, Nao, I'm sorry, but I couldn't let this one go on any more. Yes, it adds 140 bytes or thereabouts to the MAIN CSS file, but I couldn't figure out a shorter way of doing it (didn't bench it with gzip) and it does add 4 bytes per link affected (which is not ALL links, but only links with bare URLs). I was getting fed up of the side bugs this left behind with respect to URLs in posts being copy/pasted and subsequently broken, and the fact that email notifications of posts or PMs would be broken by the stripping of the tags, so now we shorten URLs with CSS3 instead. There is a minor optimisation of the parse loop and a little other reduced code. Personally I think it's worth it (especially as I actually prefer the way the layout puts the ellipsis at the end rather than in the middle) (install.sql, Subs-BBC.php, index.css)
----
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/root/install.sql

@ I don't *really* mind if this is reverted but I'd rather have CSS behaviour than hard-coded behaviour that is otherwise unalterable. Also note that iurl and url behaviours are now back in step (it would have been possible to post a long URL with iurl tags that wouldn't get shortened for display)
Title: Re: New revs
Post by: Arantor on January 13th, 2013, 09:01 PM
(7 files, 2KB)

Revision: 1845
Author: arantor
Date: 13 January 2013 20:01:09
Message:
! Removing the rest of the things I forgot to remove before regarding max_urlLength (install.sql, ManagePosts.php, Admin language file)

! Added softban being able to redirect users to another site. (ManageBans.php, Security.php, ManageBans language file)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on January 13th, 2013, 10:19 PM
(3 files, 2KB)

Revision: 1846
Author: arantor
Date: 13 January 2013 21:18:47
Message:
! More soft-banning magic: ability to set a random delay of up to 15 seconds for miscreants. (ManageBans.php, Security.php, ManageBans language file)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Title: Re: New revs
Post by: Nao on January 15th, 2013, 08:15 PM
rev 1847
(10 files -2, 7kb)

! Reduced minimum recorded version of Firefox from 16 to 15, to account for the (yet to be upgraded) Pale Moon fork. Hopefully they release v19 soon so I can restore the minimum requirement. (Class-System.php)

! Fixed OS version not being stored in Opera Mini for Android. Actually, they don't even show the Android version in the UA... Not that it's a big deal, as Opera Mini is supposed to look the same across all platforms. (Class-System.php)

! Fixed error log not being able to show source code in context for files outside of the Sources folder. (ManageErrors.php)

! In some rare situations (frankly it's probably down to the filesystem..?), wedge_cache_css_files seems to not be able to create new folders in time for the final recording of the cached file. Just @ignore the error for now... (Subs-Cache.php)

* Moved main CSS IE9 hacks to index.css file. Moved an Opera hack to media.css just the same. Simplified some stuff that seemed to be outdated and no longer needed. (extra.ie9.css, index.css, media.opera.css, media.css)

* Slight improvements to Wuthering header. Moved a single hack for IE6 and IE7 to main file, too. (extra.css, extra.ie6.css, extra.ie7.css)

* Translation. (ManageBans.french.php)

* Spacinazi. (ManageBans.english.php)
Title: Re: New revs
Post by: Arantor on January 16th, 2013, 05:27 AM
(6 files, 11KB)

Revision: 1848
Author: arantor
Date: 16 January 2013 04:26:33
Message:
+ New news UI, including privacy of news items and fun things like that. Doesn't include pulling from a board, haven't made my mind up about how that needs to work yet. Should have cleaned house on the template and language strings. (ManageNews.php, ManageNews.template.php, Admin language file)

! Spacinazi. (Home.php)
----
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Title: Re: New revs
Post by: Arantor on January 16th, 2013, 03:35 PM
(1 file, 1KB)

Revision: 1849
Author: arantor
Date: 16 January 2013 14:34:45
Message:
! Some fringe bugs relating to news items (admin permission not enforced properly, errors thrown in the event items were not visible to guests) (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Title: Re: New revs
Post by: Nao on January 17th, 2013, 09:43 AM
rev 1850
(2 files, 3kb)

! The mixin regex was using an incorrect back-reference (\3 instead of \1), resulting in mixed selectors only inserting their first property into parent selectors. Oops. This was unfixed until now because I'm only using the 'mixes' keyword for a single selector and it only needed the first property in most situations. (Class-CSS.php)

! The mixin regex also didn't accept blank lines in selector declarations. Considering that the tree parser (which is executed later) does accept them, it makes sense to include support for them. As a reminder, regular selectors that you want to use in 'mixes' keywords should be at the root of the file, i.e. don't indent them with tabs. (Class-CSS.php)

* Slight micro-optimization in a loop. (Class-CSS.php)

* Saved an extra declaration for Firefox 2 and below. I know, it doesn't represent a lot of users, but it's still what allowed me to discover the mixin bug, ah ah. As well as a dysfunctional Wuthering linktree, also in Firefox. (common.css)
Title: Re: New revs
Post by: Nao on January 17th, 2013, 11:10 PM
rev 1851
(8 files +1, 4kb)

- Replaced some JS substring() calls with substr(), which saves bytes everywhere because substr() was already used a lot. (script.js, editor-func.js, player.js, respond.js)

! Chrome was incorrectly setting the JS is_ff flag to true. Rewrote is_ff to basically mean 'has Mozilla flag, but isn't IE or WebKit.' Saves another 6 gzipped bytes, by the way... (script.js)

! Firefox needed an extra fix for Wuthering linktrees. (Wuthering/extra.css)

* Moved Wine's variable overrides to common.css; reason being that if a file such as editor.css wants to use one of those common variables, they'll first take the value from Weaving's common.css file, then fail to see an override anywhere, because the editor (for instance) doesn't have any interaction with the extra.css file. A bit complicated, I admit, but completely logical. (Wine/common.css, Wine/extra.css)

* Translation. (Admin.french.php)

@ Editor fixes coming later, or at least separately... I'm not 100% happy with them right now, and will take some time to review them.
Title: Re: New revs
Post by: Arantor on January 18th, 2013, 02:39 AM
(4 files, 2KB)

Revision: 1852
Author: arantor
Date: 18 January 2013 01:28:23
Message:
! SMF bug: disallow checking of email address for activation purposes if the account is not in a state where it should be approving such things. (Activate.php)

! Typo in Class-DBPackages, thanks Dragooon. (Class-DBPackages.php)

! SMF bug: force serializer to PHP's own for DB sessions, as there are other serializers out there that could cause trouble, e.g. igbinary. While I was hesitant to suggest it for SMF, it does fit with things we can do in future. (Load.php)

! SMF bug: XSS validation not performed in the admin panel for selecting a default language. (ManageServer.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Title: Re: New revs
Post by: Arantor on January 18th, 2013, 05:54 AM
(4 files, 2KB)

Revision: 1853
Author: arantor
Date: 18 January 2013 04:53:28
Message:
! A few more language tidy-ups to use number_context. Nothing major, just a little bit of housekeeping while the subject came up. Still more to do though. (PersonalMessage.php, ManageMaintenance.template.php, ManageMaintenance and PersonalMessage language files)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Title: Re: New revs
Post by: Nao on January 18th, 2013, 09:14 AM
rev 1854
(7 files, 4kb)

* Replaced CSS long URL shortener with a JavaScript one. It has the main advantage of allowing users to copy and paste complete URLs even if they don't show up as complete in the page. Also, it only adds about 60 gzipped bytes to the JS and removes 4 bytes per URL and saves 24 gzipped bytes from the CSS file, which is really nice. Finally, it shouldn't impair any forums, except maybe really slow ones at load time. The alternative solution would be to do this at PHP time, but I'm not sure it's worth the, albeit minor, extra server load, apart from saving the 60 bytes off JS. I'm keeping my options open about implementing it in PHP. (install.sql, script.js, index.css)

* Added $version variables to add_jquery_ui() and weInitJS(), to make it simpler to update the jQuery versions if patches are released for it. Note that currently, I'm still waiting for Google to update their CDN with jQuery 1.9, to which we'll make the jump then. Because jQuery 2.0 will be shorter than 1.5, it'll be beneficial to all non-IE browsers eventually. (Load.php, Subs-Cache.php)

! Half-assed hack to prevent errors from being generated by permission checks before permissions are loaded. Unfortunately, this doesn't fix the error in itself, but at least it doesn't prevent normal use of a forum, and this error won't be logged any more. (Security.php)

! Just because dns_get_record is callable doesn't mean it's not going to return errors. Meh. Another @ fix... I hate those. (Subs.php)
Title: Re: New revs
Post by: Nao on January 18th, 2013, 01:20 PM
rev 1855
(6 files, 4kb) (it seems I'm subscribed to 4kb commits these days...?!)

* Improved JS URL shortener: ampersands are now properly cut (through a php_unhtmlspecialchars call), increased maximum length to the usual default of 50 chars instead of 30 (it was really just for my tests), and if a container is too narrow to show even 50 chars, Wedge now inserts a wbr tag after the ellipsis, that allows for the URL to be shown over two lines. And it doesn't take any additional byte to add all of this, yay. (script.js)

! Fixed Wuthering linktree in IE7. It needs a mixin (rather than a base) because of the parent skin. Soon, I'll start working on moving Wuthering and Warm to the root. Should be simpler to manage in the end... Child skins really should be there only to change a few lines, not create completely new skins. Just because I could doesn't mean I should have. I need to see a doctor. (Wuthering/extra.css)

! Typo (number_content instead of number_context). (PersonalMessage.php)

* Translation. (ManageMaintenance.french.php, PersonalMessage.french.php)

* Saving a gzipped byte by reordering two lines. Really. I need a doctor. Now. (index.css)
Title: Re: New revs
Post by: Nao on January 18th, 2013, 05:50 PM
rev 1856
(16 files, 7kb)

+ Added HTTPS support for CDN-based jQuery includes. This will prevent IE (and some other browsers) from shouting at you if your $scripturl has https:// in it. (Load.php, Subs-Cache.php)

* So... I went to see my doctor, and he diagnosed a rare case of bytophobia. He said it can't be cured. He also added that .slice() is one byte shorter than .substr() and behaves similarly to .substring() but with support for negative indices, so he recommended that I'd focus on turning all of my substr calls to slice. This saved quite a lot of gzipped bytes in a few files. Although I'm starting to wonder if he really was an actual doctor... (captcha.js, editor-func.js, editor.js, ie6hover.js, mediadmin.js, player.js, post.js, respond.js, script.js, spellcheck.js, stats.js, suggest.js, topic.js, up.js)

@ For those interested, I also saved bytes by: (1) removing txlen1 and txlen2 variables from the editor (they were introduced as an Opera fix, which is no longer needed, and I forgot to remove them entirely), (2) removing an unneeded filename.length in post.js, (3) turning a very silly (also in SMF!) sText.substr(0, aResult.index).length) into just aResult.index, (4) turning a str.substr(x, 1) into str[x] in captcha.js, and (5) removing an unneeded file.name.length in up.js. I'm surprised that 'this' in $.fn.mime is correctly typed as a string instead of an array when calling .slice() on it. Eh, you never know... It still saves one byte doing that, so it's definitely worth the risk. Ah ah.

:edit: Fixed wrong HTML in this post.
Title: Re: New revs
Post by: Nao on January 18th, 2013, 10:34 PM
rev 1857
(14 files, 3kb)

* Finished converting all .substr() calls to .slice()... I'm surprised that none of the .substr() had any reason to stay, and overall we're saving bytes everywhere. (attic/Unused-testStyle.js, attic/text-overflow.js, create_backup.php, smfinfo.php, ManageSmileys.php, Aeva-Subs-Vital.php, TEMPLATES: Admin, Display, PersonalMessage, Poll, Profile, Split, Themes)

! Fixed URL shortener when the link contained an image. The rewrite is one gzipped byte shorter, and should be 100% safe. (script.js)

- Removed a very, very well hidden (and as expected totally useless) Easter egg. Someone in the SMF 1.0 dev team was definitely a Gwen Stefani fan. For those wondering, the egg is still in SMF 2.x, so I'm not the only one who missed it. (Profile.template.php)
Title: Re: New revs
Post by: Arantor on January 19th, 2013, 05:32 AM
(10 files, 19KB)

Revision: 1858
Author: arantor
Date: 19 January 2013 04:31:11
Message:
! A few more $scripturl removals. (MessageIndex.php)

! I didn't really want to commit this yet but other changes to Display.php forced my hand somewhat (I don't like partial commits of files or any such nonsense.) So here's the first code that sets up for Disemvowelling bad users' posts. It relies on a new parameter being available to the bbc parser, but one I've talked about doing before, it's just that now I'm actually doing it, though in a very slightly different manner to before. The vowel stripping is particularly nasty and I don't have a smarter way of doing it at this stage. (Display.php, Subs-BBC.php)

! Bug in previous/next topics not taking into account pinned topics, ordered or otherwise. (Display.php)

! Allow for reordering of pinned topics. Not all of this was necessarily in the best places, but it seems to make some kind of sense. (JSModify.php, MessageIndex.php, Pin.php, Post2.php, Post.template.php, language files: index, Post, Errors)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Pin.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on January 19th, 2013, 06:06 AM
(1 file, 1KB)

Revision: 1859
Author: arantor
Date: 19 January 2013 05:06:06
Message:
! A variable was getting cleared too early which could cause errors. (ManageBoards.php)
----
Modified : /trunk/Sources/ManageBoards.php
Title: Re: New revs
Post by: Nao on January 20th, 2013, 01:24 AM
rev 1860 -- fixing bugs, and again, and again! Plenty this time.
(5 files, 3kb)

! Finished a fix that was started last October and that I thought was already done... Hopefully it'll work fine now. This is about Wess's mixin feature. Some complex classes destined to be used as mixins would be broken when including them through a 'mixin:' property, rather than the 'mixes' keyword. (Class-CSS.php)

! Switching to Wysiwyg mode could have unwanted effects on whitespace inside quotes. (Subs-BBC.php)

! Changing one's language in the profile would generate an error due to a last remaining $context['user']. (Profile-Modify.php)

! IE7 in Wuthering STILL wasn't working properly... This was because of Microsoft (who else?). For a reason I ignore, when I try to view the page in IE10 using IE7 mode, it still gives me 'IE10 standards mode', instead of IE7 standards mode. And it just so happens that the 'filter' property isn't recognized in IE10 standards mode... (Wuthering/extra.css)

* Modified un_htmlspecialchars() to use htmlspecialchars_decode() for simplicity. (Subs.php)
Title: Re: New revs
Post by: Nao on January 20th, 2013, 07:38 PM
rev 1861 -- "a byte is a byte is a byte."
(3 files, 3kb)

+ Added two preg_replaces to the output buffer manager, that will remove the protocol and/or the domain name of any link that don't require it (i.e. they either share the same protocol as the current web page being viewed, or even its domain name.) It saves about 150 gzipped bytes on a regular full topic page (it all depends on the number of links), which is not much, but it also doesn't use more than a few milliseconds of CPU time, so it's a fair trade I'd say. Hasn't been 100% tested but should work. It can always be reversed later, or an admin setting can be set, too. Whatever. (Subs-Template.php)

! Fixed URL shortening when entities were found in them. This also saves an additional 5 gzipped bytes... Yeah, I know, it's boring innit? (script.js)

* Saved about 20 bytes in the editor by using php_unhtmlspecialchars() properly instead of a custom replacement, and removing a code block that did absolutely nothing. I'm annoyed by the useless var declarations in the spellcheck code by the way, but stripping them out actually adds 3 bytes. The joys of gzipping magic... (editor.js)
Title: Re: New revs
Post by: Arantor on January 21st, 2013, 01:34 AM
(5 files, 2KB)

Revision: 1862
Author: arantor
Date: 21 January 2013 00:31:54
Message:
! Use group colours in the manage boards area. (ManageBoards.php)

! News fader items shouldn't be bold by default. The user can stick bold in it if they want, plus the theme can set it, but it shouldn't be forced in the template. (Boards.template.php)

! A few sprinkles of plugin repo bug fixes: session checking, delete actually works, missing image fixed, nothing huge but makes it easier to get on with other plugin related stuff in the meanwhile. (ManagePlugins.php, ManagePlugins.template.php, mana.css)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/skins/mana.css
Title: Re: New revs
Post by: Arantor on January 21st, 2013, 01:23 PM
(6 files, 24KB)

Revision: 1863
Author: arantor
Date: 21 January 2013 12:22:11
Message:
! Bug in FTP clean-up when a connection wasn't possible. Not the cleanest, but the safest. (Class-FTP.php)

! Next stage of plugin uploading, getting and validating FTP details. Still WIP in every respect. (index.php, ManagePlugins.php, Subs-Plugins.php, ManagePlugins.template.php, ManagePlugins language file)
----
Modified : /trunk/Plugins/index.php
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Title: Re: New revs
Post by: Nao on January 21st, 2013, 11:53 PM
rev 1864 -- Wysiwyg gets some love!! Until Pete decides to ditch it :P
(18 files, 11kb)

+ Bringing proper Wysiwyg support for iOS and Android (stock and whatever), as long as they're not ancient versions. Only Firefox <3.5 and Opera Mini are not compatible. Also removed the fallback to contenteditable, because really, if you use a browser that's too old for that trick, you don't even know what 'Wysiwyg' means. You probably don't even know that you can register on forums and post messages, not just read them. (Class-Editor.php, editor.js)

! Fixed smiley and link insertion regression in Wysiwyg mode, due to an oversight (I didn't immediately see that iMoveCursorBack could have a value of zero. If you're not following, don't worry, it's intentional.) (Class-Editor.php)

* Simplified Wysiwyg processing. If your browser doesn't support it, you won't get an error message -- Wedge will simply no longer show the switcher icon. Also, if BBC is disabled, Wysiwyg is now disabled directly from within the editor code, rather than external files. (Class-Editor.php, PersonalMessage.php, Post.php, editor.js, LANGUAGE: index, Post)

* Rewrote Wysiwyg CSS handling. Finally, clicking at the bottom of the pseudo-textarea will properly move the cursor to the end of the text! Things like that... Also shortened and simplified many variable names, for logic reasons (isWysiwyg and canWysiwyg come to mind) and better compression overall. (Class-Editor.php, editor-func.js, editor.js, post.js, topic.js)

* Simplified editor CSS. Most notably, I replaced the browser-based variable declarations with @if's. It isn't any faster or more efficient or whatever -- it's just easier to understand. Originally I mostly used these variables to show that they can be used not only as values, but also as property-value pairs. (editor.css, extra.ie6.css, extra.ie7.css, extra.ie8.css, index.member.css)

* Language! (index.french.php, Post.french.php, Errors.french.php)

* Some breathing space. (Post.template.php)
Title: Re: New revs
Post by: Arantor on January 22nd, 2013, 01:42 AM
(2 files, 1KB)

Revision: 1865
Author: arantor
Date: 22 January 2013 00:41:19
Message:
! Only show the reorder pinned option when there's something to reorder. (MessageIndex.php)

! New method for FTP, to call for raw lists of information. (Class-FTP.php)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/MessageIndex.php
Title: Re: New revs
Post by: Arantor on January 22nd, 2013, 05:59 AM
(4 files, 12KB)

Revision: 1866
Author: arantor
Date: 22 January 2013 04:55:23
Message:
! Go up function for FTP. (Class-FTP.php)
! Some minor reorganisation and moving towards plugin uploads; there is a chunk of the code required to deactivate an existing plugin, delete it and prepare to upload a new one in its place. There is also sufficient code, in theory, to get through parsing and creating all the folders in the zip file,[1] but to quote Bachman Turner Overdrive, You Ain't Seen Nothin' Yet. (ManagePlugins.php, Subs-Plugins.php, ManagePlugins language file)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
 1. This is such an arse-pain because zip files don't enforce proper hierarchy. It's actually one long standing bug in SMF that certain zip file builders will leave out top level folders when preparing the file, e.g. it'll add /folder/file.txt but not create an entry for /folder/ as an actual folder entry in the directory header. Windows, I'm looking at you. So I have to manually parse every filename looking for folder names.
Title: Re: New revs
Post by: Arantor on January 23rd, 2013, 12:49 AM
(17 modified, 3 deleted, 5KB even though it's far more than a straight 5KB of changed code!)

Revision: 1867
Author: arantor
Date: 22 January 2013 23:47:45
Message:
! Removal of a lot of the old package server. There's some stuff relating to the file permissions and the downloading of plugins that might still be useful, but other than that, it can go. There may well be other legacy stuff that hasn't been excised yet, but that's mostly because this is a big and scary process and there's a lot of stuff with tendrils in the packman code. I did also take the liberty of hacking bits up in the old packman just while it's hanging around, so that I could remove other traces (e.g. converting lang string to normal inline strings so I could remove the actual language strings - any weirdness should be essentially ignored for now) (install.sql, Admin.php, ManageServer.php, PackageGet.php, Packages.php, Subs-Package.php, Packages.template.php, language files: Admin, Errors, Help, Modlog, Packages)
! Removed now legacy images. (package_ops.gif, package_installed.gif, package_old.gif)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Themes/default/Packages.template.php
Deleted : /trunk/Themes/default/images/admin/package_ops.gif
Deleted : /trunk/Themes/default/images/icons/package_installed.gif
Deleted : /trunk/Themes/default/images/icons/package_old.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Nao on January 23rd, 2013, 12:33 PM
rev 1868
(9 files, 6kb)

+ New linktree for Warm skin. This is located somewhere between the sobriety of Weaving and extravagance of Wuthering. Not 100% happy with it. I think that design is better suited to Weaving than Warm, but we're trying to keep Weaving simple. Suggestions welcome. (Warm/extra.css)

* Also decided to go for Open Sans font in Warm, instead of Tahoma. What do you know, it's a warmer font after all. Needs adjustments. (Warm/extra.css, Warm/skin.xml)

! Fixed a DOM validation error. (Search.template.php)

! Safari 5 doesn't seem to like text-indent. Found an alternative hack for it... If you find the reason why the original doesn't work, please contact me. (index.css)

* %1$s isn't a string that JavaScriptEscape needs to modify. :) (Boards.template.php)

* Cleaned up comments. (index.template.php, ManagePlugins.template.php, Warm/skin.xml)

* Gzinazi. That means I'm saving bytes. (Wuthering/extra.css)

* Translation. (ManagePlugins.french.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2013, 03:05 PM
rev 1869
(15 files, 21kb)

* Doing my share to help with the packman removal... So, removed log_packages-related code. Also silly comments. (readme_install.html, readme_update.html, readme_upgrade.html, sphinx_config.php, smfinfo.php, upgrade.php, upgrade.sql, install.sql, Class-DBPackages.php, PackageGet.php, Subs-Package.php, extra.rtl.css, mana.css)

+ Added Home language files and fixed Homepage to match what you're seeing on Wedge.org right now. This mostly allows me to keep the file out of its 'ignore' changelist, which is a bit confusing to me. (Home.template.php, Home.english.php, Home.french.php)
Title: Re: New revs
Post by: Nao on January 23rd, 2013, 03:25 PM
rev 1870
(2 files, 2kb)

! Forgot to upload the Homepage in last commit. (Home.template.php)

* Tweaked Android icon to be less squarey and easier to see. It uses 5 more bytes... Bite me. (android.gif)
Title: Re: New revs
Post by: Nao on January 24th, 2013, 06:12 PM
rev 1871
(7 files, 5kb)

! Wedge wasn't recording the OS name and version in CSS filenames, contrary to what it was supposed to do. This caused some issues, notably Safari for Windows stylesheets being shared with iPhone stylesheets... Not a good idea! (Subs-Cache.php)

! Fixed inconsistent padding around linktree elements. This was due to a classic: whitespace between them... Reminds me that it's best to remove whitespace when possible. It saves bytes in the end, and avoids silly issues like this one. Well, at least when an element is likely to have its display type changed to block or inline-block or inline depending on the skin... (index.template.php, Warm/extra.css)

! Various fixes for Warm, mostly due to Open Sans Bold not looking really good. It's best to just focus on using Open Sans in its regular weight... (Warm/extra.css)

- Removing Optima from fallback fonts -- it looks ugly in iOS. Also removing PT Sans from all stylesheets: I should tell you that I'd installed the font manually on my PC and I can't expect people to be happy with a design I'm not seeing (i.e. the fallback font I'm never seeing.) (common.css, Wine/common.css, Wine/extra.css)

* Home language file wasn't using UTF8. (Home.french.php)
Title: Re: New revs
Post by: Nao on January 24th, 2013, 10:57 PM
rev 1872 - the Aeva Media fix commit. Keep 'em coming!
(3 files, 3kb)

! Fixed that annoying little bugger of a bug that prevented documents (including compressed files) from being marked as read just by visiting their item page in the Media gallery. I'm afraid this bug is also in Aeva Media for SMF (all versions), and I promised myself never to update it, so it's a bit of a... bugger, again. Well, I guess I'll have to do it at some point. I'm starting to wonder if people are aware that I don't read the AeMe topic at sm.org and that if they want to report bugs, they should do it on wedge.org...?! (Subs-Media.php)

! Marking the last Unseen Media page as seen would redirect you to an empty page, instead of the last available page of unseen items. (Aeva-Gallery2.php)

* I don't like h4 being bold either. I probably should unbold all header tags while I'm at it... (Warm/extra.css)
Title: Re: New revs
Post by: Arantor on January 24th, 2013, 11:28 PM
(4 files, 8KB)

Revision: 1873
Author: arantor
Date: 24 January 2013 22:28:19
Message:
! Banned users could throw an error if they had made a post previously. (Display.template.php, index language file)

! More of the ban UI, it can now pull a ban in the DB into the editing form. Just saving to go, really. (ManageBans.php, ManageBans.template.php)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on January 26th, 2013, 05:56 PM
rev 1874 - iPad and JS lang fixes.
(5 files, 5kb)

! The language string integration for JS files was no longer working, not sure why... This relatively extensive rewrite of the feature should work. (Subs-Cache.php)

! iPads and Android tablets have a high enough resolution to handle any skin without going through the Wireless skin by default. So I'm removing them from the is_mobile test. Note that I could do a better job at searching for tablets... Right now it'll only find those Android tablets that follow Google's standards. (Class-System.php)

* iPads shouldn't go through the 'big font' path that is given to all iOS devices. (extra.ios.css)

! The gradient pseudo-rule in Wess wouldn't accept anything else than "top" and "left" as its third optional parameter, when it should have accepted any angles to "to left", etc... Fixed it to just mindlessly reproduce what you're putting in it. (Class-CSS.php)

* Translation. (index.french.php)
Title: Re: New revs
Post by: Nao on January 26th, 2013, 07:12 PM
rev 1875 -- ask() fixes.
(4 files, 3kb)

! These JS ask boxes look great... But they break stuff, from time to time. Confronted to a choice between an ugly confirm box for the 'Delete post' link, and rewriting the mini-menu code, I chose the latter. So, removed the 'custom' option to add onclick events. Because jQuery has a .live() function to attach events to objects that aren't created yet, I can simply associate the function to the requested class. The code is a tiny bit longer, but it's in the footer... Heck, who likes confirm() over ask(), I'm asking? Yeah, thought so! :P (Display.php, topic.js)

! Fixed icon alignment in Add Ban area. (mana.css)

! Commenazi. (ManageSearchEngines.php)
Title: Re: New revs
Post by: Nao on January 27th, 2013, 06:28 PM
rev 1876 -- I'm baaaad!
(2 files, 1kb)

! Fixed CSS @language parser... Again ;) (Subs-Cache.php)

! Typo resulting in a crash. Boo. (EmailTemplates.french.php)
Title: Re: New revs
Post by: Nao on January 28th, 2013, 11:53 AM
rev 1877 -- more CSS fixes and preparing for the future.
(7 files, 9kb)

* Moved the iOS media query out of its own file so that it can be applied to any mobile device. This will allow me to test wedge.org extensively from my Galaxy SIII, so please bear with me if it doesn't look great. Also started fixing the looks of a few places in low-width mode... (header text and menu icon positions.) (extra.ios.css, index.css)

+ Decided to consolidate Wess and moved all prefixing code to it as well. The -prefix keyword should also be safer to use now, e.g. it won't break CSS classes like ".menu-prefix-element", if you ever needed to have such a class name... (Class-CSS.php, Subs-Cache.php)

+ Added support for min or max-device-pixel-ratio prefixing, because of the Firefox hiccup (min--moz-device-pixel-ratio, REALLY?)

! Fixed a Chrome v26 bug (let me insist, it's a bug from Chrome, not from Wedge) where adding a border to :hover or :focus on a textarea or input box will prevent it the latter from accepting text entry. It's completely silly and as yet unexplained. Hopefully it'll be fixed later but I'd rather not take any chances and will probably leave that hack in for quite some time. (index.css)

! Fixed print media query. It was hanging to its old #headerarea which hasn't existed for years (lulz?), so I modified it to hide the header, menu and sidebar. (index.css)

- Removed the 'strong' tag from pinned topic lists. Useg CSS to style their span instead. (MessageIndex.template.php, index.css)

! $reddish was indicated as an unused var, but it was very much used and should (semantically?) be in the var declaration area. (common.css, index.css)
Title: Re: New revs
Post by: Nao on January 28th, 2013, 06:42 PM
rev 1878
(2 files, 2kb)

! Can't use $this inside a static method for the wess_prefixes rewrite... It slipped my mind for a minute. (Or half a day.) Considered moving everything to a static object, but seriously... Is it worth it? (Class-CSS.php)

* Minor updates to Warm... I'm afraid the most visible ones are the footer gradient (which is unlikely to stay forever), and the single extra pixel of padding in the linktree, which makes it look better IMHO... (Warm/extra.css)
Title: Re: New revs
Post by: Arantor on January 29th, 2013, 12:31 AM
(10 files, 4KB)

Revision: 1879
Author: arantor
Date: 28 January 2013 23:30:45
Message:
! SMF bug: DB could under some circumstances get into a very nasty infinite loop. (Class-DB.php)

! SMF issue: If we are doing a fatal error, clear any output buffers. I'm not any more convinced now than I was two years ago that it's strictly necessary but it can't *hurt* to have it. (Errors.php)

! SMF bug: There are some places where we do an MD5 comparison in an unsafe fashion. Not all of these *needed* to be patched, I'm just being over-thorough, and I think I did all the places it really matters. (upgrade.php, ManageServer.php, Security.php, Subs-Plugins.php)

! SMF bug: The number of password change tries was not always enforced properly. (Subs-Login.php)

! Missed changeover to cache lock file. (Subs-Cache.php)

! Don't use the Settings.php file for recording an error. On good systems this should be readonly anyway and not chmoddable from PHP without FTP help, so it won't even be writable. Instead use an error.lock file's mtime in the cache folder (which should be writable). This will also prevent any chance of the infamous race condition that causes Settings.php to be eaten. (Errors.php, Subs-Admin.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/other/upgrade.php
Title: Re: New revs
Post by: Nao on January 29th, 2013, 05:58 PM
rev 1880 -- anti-prefetching stuff.
(10 files, 3kb)

* Harmonized calls to ob_end_clean() to ensure they get rid of all output buffers. (Dlattach.php, Errors.php, Security.php)

* Moved all anti-prefetch code to a single function. Adding an ugly parameter to allow for Wedge to bypass the test and simply force a 403 error. (Load.php, MessageIndex.php, Search2.php, Security.php, Subs.php, Unread.php, UnreadReplies.php)

! Wess was doing a useless foreach() that never got used. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on January 29th, 2013, 11:19 PM
rev 1881 -- because I can :P
(7 files, 8kb)

* Moved all response_prefix cache getter/setter code to the Subs file, just like preventPrefetch(). This also fixes a minor issue where cache_get_data didn't indicate a TTL. Hopefully we'll remove all of this at some point and replace it with a better hack. Like, the robots.txt stuff maybe...? Dunno. (Display.php, JSModify.php, Merge.php, MoveTopic.php, PersonalMessage.php, Post.php, Subs.php)

* Renamed all $scripturl to <URL> in PersonalMessage.php. Left one in -- wasn't too sure whether it'd be properly converted, and I'm too tired to look into it. (PersonalMessage.php)

+ Added a, hopefully temporary, hidden $settings['allow_prefetching'] that should allow you to easily, errr... Do what its name says. Site-wide. If you like breaking your own sites... (Subs.php)

! Forgot to commit one of the preventPrefetch() calls... You were right, Pete. (Display.php)
Title: Re: New revs
Post by: Nao on January 31st, 2013, 04:12 PM
rev 1882 -- Google Closure implementation. Thanks for the headaches!
(11 files +1, 23kb)

* Improved handling of already minified files with the Wedge minification process. Instead of using that strange <wedge_jquery> keyword, I'll instead rely on the filename following the jQuery convention, i.e. '*.min.js', meaning you can now safely add your own minified files if you're crazy like me about providing the smallest possible file and testing it through UglifyJS, Google Closure and other minifiers. This also allows jQuery UI to be kept as is. Finally, ensuring that '.min' is not kept in the final filename. This is totally untested, but don't tell anyone! (Subs-Cache.php, Load.php, jquery-1.5.2.min.js, jquery-ui-1.8.24.min.js)

+ Speaking of Google Closure -- added support for its API to Wedge. You'll be able to use Google's remote minification service if you really want to, but it's extremely slow, as expected. The best compromise is still to use Packer, which is pretty much just as efficient as Closure, at least for the Wedge files. (ManageServer.php, Subs-Cache.php, LANGUAGES: Help, ManageSettings)

+ I actually wrote a convoluted regex to convert Closure's returned UTF characters (like accented chars) back to UTF, and realized that the final file was always a couple of bytes larger. So, it was a nice piece of code and I'm committing it just in case to the attic. Additionally, I added extra functions and code to allow for non-Closure packed language strings to be optimized the same way. The more accents, the better the compression is. (attic/Unused-convertU.php, Subs-Cache.php)

+ As mentioned above -- added new functions to the string object: entity_to_utf8(), utf8_to_entity() and entity_to_js_code(). There are plenty of areas that could benefit from them, but I've only done the change in one file, sorry. That's in mimespecialchars(). And it's not even tested. Well, that's what beta testers are for! Get to work, now! (Class-String.php, Subs-Cache.php, Subs-Post.php)
Title: Re: New revs
Post by: Nao on January 31st, 2013, 04:18 PM
rev 1883 -- the stuff I could afford to commit separately.
(5 files, 4kb)

! Fixed error log getting broken when showing very long lines. This was desperately in need of a word breaker... (mana.css)

! Fixed mini-menus to ensure they don't generate warnings in the JS console when being animated. This was due to jQuery not checking that a position is set to 'auto' and animating it as if it was a pixel value. So, yeah, 'NaNpx' and 'autopx', not too smart. It didn't crash anything though, which is why it took me so long to spot it. This adds 5 bytes to the gzipped file, which is okay considering I really wanted that fixed. (topic.js)

- The onComplete param was never used in Zoomedia. Thanks to Closure for pointing it out to me during my tests, I guess...! (zoomedia.js)

- Removing a temp code block that I committed by mistake in rev 1880, and which I'm not going to implement anyway. (Display.php)

* Quotenazi. Meaning, a dozen strings or so were using double quotes when they could use single quotes. It's not even gonna save a microsecond, but whatever works. (Security.php)
Title: Re: New revs
Post by: Arantor on January 31st, 2013, 06:30 PM
(10 files, 8KB)

Revision: 1884
Author: arantor
Date: 31 January 2013 17:26:56
Message:
+ Add ability to indicate maintenance mode will be required in plugins. (plugin-info.rng, ManagePlugins.php, ManagePlugins.template.php, Subs-Plugins.php, mana.css, ManagePlugins language file)
- Removed old sc/sesc legacy handling. There is no reason to accept a session id any other way. I haven't been able to break anything with doing this either. (wedge_api.php, Errors.php, ManageSearchEngines.php, Security.php, Subs.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/other/plugin-info.rng
Modified : /trunk/other/tools/wedge_api.php


@ I didn't strictly *need* to do the sc/sesc change but it bugged me as it meant we were doing a lot of work for little benefit. The reason to preserve it - legacy - is no longer a reason, so let's just drop it and only support the more secure method we were really trying to use.
Title: Re: New revs
Post by: Arantor on January 31st, 2013, 06:34 PM
(1 file, 1KB)

Revision: 1885
Author: arantor
Date: 31 January 2013 17:33:39
Message:
! I documented it but forgot to include it >_< (ManageSearchEngines.php)
----
Modified : /trunk/Sources/ManageSearchEngines.php
Title: Re: New revs
Post by: Nao on January 31st, 2013, 11:08 PM
rev 1886 -- why do they keep calling it 'exifer' when it's 'exifixer'?
(4 files, 75kb, 99% of which is not my own work.)

* Updated Exifixer library to an unknown version number. Apparently the guys in charge didn't notice they broke their official site, so I found it hidden in their github repo. Since there are so many changes in the library (it's grown by 30KB), I'll just consider they still maintain it, and thus update it. BTW the new version is totally untested. I don't think there should be a problem with the gettext() calls and all, but I'm ready to revert this file change at any time. (Subs-Exif.php)

! Fixed a minor JS error that came up when clicking an attached file to remove it. Good news is, the fix actually saves 5 gzipped bytes. I want more bugs like this one!!!!!!!!1 (post.js)

* Translation. (ManagePlugins.french.php)

* Spacinazi. (smfinfo.php)
Title: Re: New revs
Post by: Nao on January 31st, 2013, 11:33 PM
rev 1887
(3 files, 2kb)

* PMs viewed in conversation mode will now show a 'Reply to all' button next to the regular 'Reply' if there's more than one recipient. The problem with conversation mode is that it already adds a 'generic' Reply to all button at the top of the convo, but doesn't provide with a way to quote an actual PM and still forward it. I think it was an oversight on the SMF team's side... (PersonalMessage.template.php)

! Fixing a bug with Exifixer... Oops. Was too quick to commit. And nope, still haven't tested anything. Good times. (Subs-Exif.php)

- Segoe UI Light isn't good for a default font. Well, it's okay as a header font, but not for smaller headers. Given that a large percentage of users are still on Windows XP, and they don't have that font, I'd rather everyone have the same experience and see Franklin Gothic on a default Wedge install. Did you notice? I always come back to this one... (common.css)
Title: Re: New revs
Post by: Arantor on February 1st, 2013, 04:38 AM
(4 files, 13KB)

Revision: 1888
Author: arantor
Date: 01 February 2013 03:36:27
Message:
! An optimisation of sorts, replacing our regex for email validation with PHP's own facilities. (Subs.php)

! Ban UI. Not very thoroughly tested, may have various side bugs in it, but it does at least save bans now. Also fix a missing test case. (ManageBans.php, Security.php, ManageBans language file)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php

@ This could really use more testing. Much, much, much more testing. It tries to handle various insanities of non-Latinised domains just because I *can*. :wow:
Title: Re: New revs
Post by: Arantor on February 1st, 2013, 05:01 AM
(6 files, 2KB)

Revision: 1889
Author: arantor
Date: 01 February 2013 04:00:36
Message:
! Did I mention I hate the generic menu system and its strange handling of top level tabs? Well, this is what it took to fix the damn tabs in a fashion that makes sense. (Admin.php, ManageBans.php, language files: Admin, ManageBans)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/languages/ManageBans.french.php
Title: Re: New revs
Post by: Arantor on February 1st, 2013, 06:06 AM
(1 file, 7KB)

Revision: 1890
Author: arantor
Date: 01 February 2013 05:05:04
Message:
+ Ability to actually delete bans. This also entails the start of replacing updateBanMembers with a new version that figures out who is banned, who should be banned etc. and making all the changes. This is not finished yet. (ManageBans.php)
----
Modified : /trunk/Sources/ManageBans.php


@ It really isn't finished yet and needs to be before any alpha should ship with the updated ban system, simply because of the mess that will be made otherwise.
Title: Re: New revs
Post by: Arantor on February 2nd, 2013, 05:37 AM
(1 file, 7KB)

Revision: 1891
Author: arantor
Date: 02 February 2013 04:36:51
Message:
! Ban fixes. It can actually save the correct ban type now, and it should (in theory!!) check the state of bans when you change a ban so people who were hard banned, but should not be (for example) should then become unbanned. Needs infinitely more testing than I've given it thus far. (ManageBans.php)
----
Modified : /trunk/Sources/ManageBans.php
Title: Re: New revs
Post by: Arantor on February 3rd, 2013, 03:19 AM
10 files, 2KB[1]

Revision: 1892
Author: arantor
Date: 03 February 2013 02:19:04
Message:
! Removal of the old ban code. There's still the profile stuff to fix, but this is the old ban panel gone, including cleaning up the language strings as far as I can for now. (I think.) (ManageBans.php, ManageBans.template.php, language files: Admin, Errors, Help, ManageBans)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/languages/ManageBans.french.php
 1. Massive block delete is very small in SVN terns.
Title: Re: New revs
Post by: Arantor on February 3rd, 2013, 04:29 AM
(13 modified, 2KB)

Revision: 1893
Author: arantor
Date: 03 February 2013 03:27:05
Message:
! Did I mention that I love the @language embedding into script files? Set a default string from index, set it once and never have to explicitly set it again in any of the multiple places it is called (unless you *really* want to). All this for the 'delete item' help text on the auto suggest... it's the same everywhere, so just embed it in to the suggester as a default! It bugged me, mkay? (all files)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/ManageMedia2.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/scripts/suggest.js


@ And since it's now embedded in the suggest file, it will not only be gzipped and cached, it no longer has to be inlined into all the pages it's in, or declared in those pages where used. I would imagine that's actually a tidy little saving everywhere that uses the auto suggester, all in all. Every little helps.
Title: Re: New revs
Post by: Nao on February 3rd, 2013, 06:49 PM
rev 1894 - jQuery... Can't live with you, can't live without you!
(23 files +2 -1, 182kb -- including 171kb of jQuery code.)

+ Updated jQuery from v1.5.2 to a dual v1.9/2.0, where 1.9 is used for IE 6/7/8 while 2.0 is used for other browsers. Also added support for beta and RC versions of jQuery by redirecting Google and Microsoft CDNs to the jQuery CDN if a beta version is requested (like for the current 2.0 release.) In case you're wondering, we're mainly upgrading jQuery because v2.0 is actually (for the first time!) smaller and tighter than v1.5.2. Yay. (Load.php, jquery-1.5.2.min.js, jquery-1.9.0.min.js, jquery-2.0.0b1.min.js)

* Changed .bind(), .unbind() and .andSelf() respectively to .on(), .off() and .addBack(), recommended methods in jQuery. Saves a couple of bytes off each file. (attic/Unused-SelectBox.js, attic/Unused-events.js, attic/Unused-tie.js, Admin.template.php, ManageModeration.template.php, Profile.template.php, mediadmin.js, player.js, sbox.js, script.js, suggest.js, topic.js, zoomedia.js)

* Changed .live() and .die() to custom .on() and .off() versions which should be faster. One occurrence was instead replaced with a .one() sent at editor creation time (remember that seldom used function..?), which is way more efficient than a live() call anyway. (Display.php, editor.js, editor-func.js)

* Turning some leftover <whatever /> tags to <whatever> in help files. (Admin.english.php, Admin.french.php, Help.english.php, Help.french.php)

* French translation. (ManageBans)

@ Just realized I posted this at 18:49 French time... That's an anagram of rev 1894 :p
Title: Re: New revs
Post by: Nao on February 3rd, 2013, 10:56 PM
rev 1895 -- invented a new word! A day not wasted.
(9 files, 5kb)

+ Added a couple of menu separators in crowded submenus. (Admin.php)

* Updated jQuery UI to version 1.10, the latest available. (Subs-Cache.php)

* Rewrote sortable handler in Membergroup Badge and Order Pinned Topics pages to be more visible. Harmonized both sortable to use similar CSS. (Post.template.php, mana.css)

* Naoism: saving a microcycle. (Load.php)

* Naoism: comment typos. Also, Pete, you must have a 4K screen if you're able to read that MessageIndex comment without scrolling... ;) (MessageIndex.php, Pin.php)

* Naoism: slight changes to arrow color/size in menus and linktrees. Still not perfect, but it looks better than originally in Chrome. And since I'm no longer using Opera as my default browser these days (oh, how I miss you, good ol' Opera 9.2x days...), it's important to make them look perfect in the widest used browser. (What? IE? Never heard about that.) (common.css, index.css)

* Naoism: slightly less aggressive menu background color for IE9. I was about to use the same for Chrome, but I chickened out at the last minute. There's a barely noticeable delay in loading them... I'm wary of seeing older computers in pain. (index.css)

@ For those wondering, Naoism is the opposite of Taoism. It means that bickering about every little stupid detail is what life is really about.
Title: Re: New revs
Post by: Arantor on February 4th, 2013, 04:07 AM
(14 files, 6KB)

Revision: 1896
Author: arantor
Date: 04 February 2013 03:05:37
Message:
! Legacy code, missing check being called properly, stupid function not working as intended. (Security.php)

! One less variable injected inline. Potentially more could be done here but it's not pleasant. (Post.template.php, post.js)

! Profile now displays banned status properly, and some language cleanup as a result. (Profile-View.php, Profile.template.php, language files: index, Profile)

! Deleting accounts should clean up matching bans that would no longer apply. (Subs-Members.php)

! Newsletters shouldn't be touching the existing table, as such. If they're banned through username or their email, their account should be full banned anyway, no need to requery for that stuff, at least not there. (ManageNews.php)

! The old ban tables are now gone. Good bye. Good riddance. (install.sql, Class-DBPackages.php, ManageMaintenance.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/post.js
Modified : /trunk/root/install.sql


@ Yes, this is almost entirely ban related. But since each of the different bits is a small part of the whole I delineated it, more for my reference later. (Thumbs down for Caesarness: the tables were not to survive. They have been tossed to the lions, who found them a bit chewy.)
Title: Re: New revs
Post by: Nao on February 4th, 2013, 04:44 PM
rev 1897
(22 files, 6kb)

! Thank you very much jQuery, for being so obscure when it comes to the .attr()/.prop() change in v1.9. I'm not so stupid, but it was made very unclear that you reverted back to v1.6.0's behavior, and moreover it's totally erratical, e.g. doing .attr('disabled', true) still works. Nevertheless, I've taken the time to replace access to all of our boolean properties with a .prop() call or direct DOM access. This fixes a bug in the admin registration page, and most importantly a big one in the Select Box which was due to .attr('selected') not being taken into account. Here's hoping I didn't screw up anything else with my rewrites. (upgrade.php, install.php, ManageBoards.php, ManageMemberOptions.php, ManageNews.php, ManagePaid.php, ManageRegistration.php, ManageSearchEngines.php, ManageSettings.php, sbox.js, spellcheck.js, TEMPLATES: Admin, ManageBoards, ManageMaintenance, ManageMembergroups, ManagePaid, ManagePermissions, ManageSmileys, Packages, PersonalMessage, Profile, Register)

* Forgot to commit a portion of the sortable rewrite for membergroup badges. (ManageMembergroups.template.php)
Title: Re: New revs
Post by: Nao on February 4th, 2013, 04:45 PM
rev 1898
(3 files, 71kb)

! The jQuery CDN (code.jquery.com) doesn't support HTTPS, so don't bother using it when that particular CDN is selected. (Load.php, Subs-Cache.php)

* Committed by mistake a custom minified version of jQuery 2.0... While it was about 600 bytes smaller than the official one, it didn't compress as well. Beats me. (jquery-2.0.0b1.min.js)
Title: Re: New revs
Post by: Nao on February 4th, 2013, 11:25 PM
rev 1899
(3 files, 1kb)

! Fixed a jQuery 1.9-induced bug where editing a thought that had a smiley or a BBC tag would return an empty text string instead of the existing thought. Funny thing is, this fix actually removes 12 gzipped bytes from the script file... I'm the Wesley Crusher of gzipping. I pwn gzip, and people hate me for that. (script.js, Ajax.php)

* Just renamed a deprecated .error() to .fail()... Whatever. Looks like the jQuery team has a lot of time on their hands... ;) (topic.js)
Title: Re: New revs
Post by: Nao on February 4th, 2013, 11:39 PM
rev 1900
(4 files +2, 7kb)

+ Preliminary implementation of the skeleton rewrite. This involves separating skin.xml skeletons into their own files, and removing the template_skeleton function from the index template, to be replaced by a (simpler?) skeleton.xml file in the skins folder. Currently, the only drawback is that you can no longer override a skeleton just with the magic of custom.xml, but OTOH I don't really see a reason for doing that, you're better off use <move> commands in that file. Perhaps I should also add custom.xml commands to <add> or <remove> elements from a skeleton..? (Load.php, Subs-Cache.php, index.template.php, skins/skeleton.xml, Warm/skeleton.xml, Warm/skin.xml)
Title: Re: New revs
Post by: Arantor on February 5th, 2013, 12:11 AM
(4 files, 9KB)

Revision: 1901
Author: arantor
Date: 04 February 2013 23:10:51
Message:
+ You can now like thoughts. It may require some more testing and likely some visual tweaks (e.g. making the link smaller maybe) but aside from slight ugliness of the code, it seems to work as expected. (Display.php, Home.php, Like.php, Home.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Home.template.php
Title: Re: New revs
Post by: Nao on February 5th, 2013, 05:12 PM
Oh my, we need to do something about the like styling in thoughts... I guess it's going to force me to do my thought mini-menu earlier than hoped... :^^;:

rev 1902
(3 files +1, 35kb)

* Split Subs-Template's wetem object into its own file, Class-Skeleton. This was long overdue, especially considering it represented about a third of the more generic template code. (Class-Skeleton.php, Subs.php, Subs-Template.php)

* Moved <move> XML commands upstream, to avoid storing them in a variable for no reason other than legacy code. (Subs-Cache.php)

! oldIE has a very odd bug (who's surprised?), where it loads a CSS file twice if we linked to it without a protocol (i.e. //domain). Although it's unlikely you'd want to point to an external stylesheet in your code, it's still a possibility, so until further notice I'll be adding this extra regex to protect external stylesheets. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on February 7th, 2013, 10:37 PM
rev 1903 -- introducing weSkeleton, and fixing plenty of little bugs.
(7 files, 17kb)

+ Rewrote static 'wetem' class into dynamic class 'weSkeleton', allowing for multiple skeletons to be dealt with. wetem is now a separate (but still static) class dealing exclusively with the main skeleton, of course. So you can keep using wetem::load('block') or whatever. (Class-Skeleton.php, Load.php)

! Fixed IP address button (in profile mini-menus) not working at all, and actually even breaking JS entirely on the page. Took time to fix because the codepath wasn't triggered for admins... (Display.php)

! Fixed smileys regenerating their cache on... every... single... page... load. Thank... you... typos. (Subs-BBC.php)

! Fixed HTML validation for user status icons. Thanks... to... the HTML5 standard chickening out -- once again. (Display.template.php, sections.css)

! Fixed JavaScript not loading in Firefox 3.6 and below. This was due to jQuery 2.0 no longer being compatible with it... So we're now falling back to v1.9 for these, too. (Load.php)
Title: Re: New revs
Post by: Nao on February 7th, 2013, 10:44 PM
rev 1904 -- doing this update separately so it doesn't increase the KB count artificially.
(+1-1 file, 238kb)

* Updated jQuery UI local version to 1.10, just like the remote versions. I don't know, though, if it's really a good thing to provide a 222KB minified file for local use... (scripts/jquery-ui-*.min.js)
Title: Re: New revs
Post by: Nao on February 8th, 2013, 06:28 PM
rev 1905 -- Display is now a mini-skeleton! Also, celebrating page 2^7 of this topic :P
(5 files, 17kb)

+ Finally adding the mini-skeleton system we've been talking about for weeks. The Display template now relies on weSkeleton to show individual posts. You can reorder elements in posts as much as you like. Life is beautiful. (Class-Skeleton.php, Subs-Cache.php, Display.template.php, skeleton.xml)

+ Added ability to skip a block/layer only in the next render pass. Just call $your_skeleton->skip('your_block') before $your_skeleton->render(). (Class-Skeleton.php)

* Moved all of the skeleton parsing (and skin-dictated skeleton moves) to the skeleton class, rather than Subs-Cache... (Class-Skeleton.php, Load.php, Subs-Cache.php)

* Naoism: weSkeleton->build didn't really need a reference to the array. I probably did that in memory of the days I didn't know PHP did copy-on-write. (Class-Skeleton.php)

- $removableMessageIDs was not used since rev 1546, where I removed its raison d'être. I forgot to remove it, though... Bad me. Note to SMF/Elk devs: you can also remove it easily and do a search on a specific class name instead... It's always good to save bytes. Also, $alternate wasn't used either (being a duplicate). (Display.template.php)
Title: Re: New revs
Post by: Nao on February 8th, 2013, 11:19 PM
rev 1906 -- XML skeleton operations
(5 files +1, 30kb)

+ Added skeleton operations to skeleton.xml files: move, rename and remove blocks/layers within any skeleton. More to come..? Right now, skin.xml move operations will not work, I'm trying to determine what's the best file to put them in. Also, operations are now found through a more generic function, so eventually I should be able to allow for all regular skeleton operations to be used in the XML files. (Class-Skeleton.php, Load.php, Subs-Cache.php)

* Moved Msg skeleton template functions to their own template. Well, at least it's funny, it gave me the opportunity to confirm that Wedge can perfectly call loadTemplate twice in a row... (Display.php, Display.template.php, Msg.template.php)

- Forgot to remove a useless param. (Class-Skeleton.php)
Title: Re: New revs
Post by: Nao on February 9th, 2013, 04:42 PM
rev 1907
(1 file, 2kb) (for a day's worth of work, really? Not well paid :P)

! Choosing to merge jQuery with script files *and* not minify JS files would result in a JavaScript error. This was technically fixed in jQuery 1.9.1 (not 2.0b1 though), but it doesn't matter, I should have done that before. Also added a quick hack to remove // comments on a file's last line (which could generate that bug), even though it wasn't needed, I'm not going to take any chances. (Subs-Cache.php)

* Ensuring that if inheritance causes a skeleton's block to receive the same operation multiple times, the last one should override the previous ones. For instance, if you're going to rename it, the following occurrence might not know of the new name... I'd rather always prioritize the latest request. (Subs-Cache.php)

* Now allowing for custom.xml to be loaded even if no skin.xml is found in the folder, you can even override its type but that would be unwise. Also, it now supports skeleton.xml hacks. Likewise, don't abuse it! (Subs-Cache.php)

* Naoism: some double quotes were used in preg replacements, and they were not always needed. Especially that "$1/*" one... Seriously?! (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on February 9th, 2013, 04:43 PM
rev 1908
(1 file +1-1, 95kb)

* Updated jQuery 1.9 branch to v1.9.1, it saves 250+ gzipped bytes, me likey. It also adds the responseXML bug that I reported (and had fixed) in the upcoming v1.9.2, which isn't a problem because I fixed it on my side a few commits ago. (Load.php, jquery-1.9.*.min.js)
Title: Re: New revs
Post by: Arantor on February 9th, 2013, 06:21 PM
(6 files, 3KB)

Revision: 1909
Author: arantor
Date: 09 February 2013 17:19:56
Message:
! Stats shouldn't be including liked thoughts as part of top liked posts. (Stats.php)

! Legacy function call removal. (Post.template.php)

! The sessrewrite should be called a little more often, because there are times when PURLs won't be active but the rewriting buffer is still needed (i.e. for the scripturl injection) (Subs-Template.php)[1]

! Likes are now magically AJAXive. I apologise in advance for the number of new bytes in topic view. Testing would be appreciated. There's also probably a better way to do this in terms of finding the right selector, too. (Like.php, Msg.template.php, topic.js)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/scripts/topic.js
 1. It was breaking my likes code, because <URL> was getting into the AJAX response because although clean_output was called appropriately, the buffer rewrite was not happening because I roll with PURLs disabled. And that IS how I roll.
Title: Re: New revs
Post by: Nao on February 9th, 2013, 09:06 PM
rev 1910 -- nothing interesting for normal human beings, you can skip that one!
(7 files, 4kb)

* Naoism: Optimized (very slightly) the likePost function and saved about 15 bytes. Thanks to function reordering, the filesize is only increased by 30 bytes ;) (topic.js)

* Naoism: Got inspired by the above, and renamed both $.get calls to $.post in the main script file. Saved plenty of bytes, yay. Then I looked into the Ajax code and realized that it was outdated. The 'time' variable wasn't used anywhere anymore. As a result, saved a total of 17 bytes. (script.js, JSOption.php)

* Naoism: A few minor modifications to the homepage intro. (Home.template.php, Home.language.php)

* Naoism: the current convention in JS files is to only have objects be capitalized, rather than function names. (Msg.template.php, topic.js)

@PS to Pete: no need to apologize, optimizing is my hobby :P I love doing that. Also, implementing Ajax here was surprisingly easy, as I can see! And the magic of gzipping makes it that your .replaceWith() call is actually better optimized than rewriting with $(target).load() instead!
Title: Re: New revs
Post by: Nao on February 10th, 2013, 12:32 PM
rev 1911 -- the bytenazi strikes again.
(12 files, 5kb)

* Rewrote weToggle object to simplify it to death. altExpanded is replaced with the optional toggle-wide (rather than per-state and per-image) opt.title (which is actually never used... but you never know), and msgCollapsed/msgExpanded is completely removed (see below). Also updated upshrink_description to be more generic. (Admin.template.php, Boards.template.php, index.template.php, ManagePermissions.template.php, Packages.template.php, Post.template.php, script.js, stats.js, index.language.php)

* Rewrote Thought object to move all text strings to it. (:edit: script.js)

@ Sometimes, you spend time converting some JS to jQuery and save bytes, and that's all good. One day, you go through the code in a logical manner, and start wondering, why the hell is my HTML being rewritten? Then you realize you blindly ported some code when it could have been removed entirely. Saves something like 20 bytes AND as a freebie we get to integrate the upshrink_description text string, which means it saves an additional 20 bytes or so *per page load*. I nearly fainted.

@ Total overall cost of script.js's new features in this commit: 12 gzipped bytes. The 'click for new thought' string itself is 45 bytes... And HTML pages for members are now shorter by several dozen bytes (weToggler and Thought strings combined).

@ I need my pills.
Title: Re: New revs
Post by: Nao on February 10th, 2013, 04:17 PM
rev 1912 -- Bytenazi vs the world.
(10 files, 27kb)

+ Added support for @if/@else/@endif to JS files. No @elseif because there are only two possible states right now, guest and member. As you can imagine, this allows you to have your JS file only print whatever code is written for guests or members. For instance, removing the cookie code for members saved about 50 bytes, and removing objects related to non-guest permissions (Thought, auto-draft, quick edit...), saved over 800 bytes in script.js, over 400 bytes in editor-func.js, and over 1500 bytes in topic.js. And I'm talking about gzipped ones. Yaysir. (Subs-Cache.php, editor-func.js, script.js, topic.js)

@ Note that you don't have to indent code inside @if tags, it's just a personal preference of mine.

* In case I need it later -- and I will, believed me -- added a $supports_flexbox variable to the CSS commons, stating which exact browser versions can use the latest flexible box layout model. (common.css)

* Guests shouldn't be served any code that allows them to quick edit something... That doesn't make any sense. (Display.template.php)

* Merged sCookie with sOptionName into sOption. The idea is that there's no reason not to use the option name as the cookie name, as cookies support underscores and all... The only drawback is that it adds a couple of bytes to guest pages. But you're not going to blame me for that, are you...? Also, who decided that it would be a smart idea to test against guest status in an... admin page?! (Boards.template.php, index.template.php, ManagePermissions.template.php, :edit: script.js...)

* More mini-byte saving, such as: the eves array was indented by one tab too many (how come I never noticed..?!), and I removed the generator string, which the W3C no longer cares about. Also added a [] fallback to aSwapContainers. It's never needed, but because the other options do that, it actually saves a byte. (index.template.php, Subs-Template.php, script.js)

* I'm a naughty boy... And I've been doing something naughty. It's all in the name of saving trees, mind you. Well, at least if anyone's trying to print out the HTML source code of your forum. Which might happen. Don't deny it. (Subs-Template.php)
Title: Re: New revs
Post by: Arantor on February 10th, 2013, 07:10 PM
(2 files, 1KB, it needed to be done, couldn't find anything more useful in the time right now.)

Revision: 1913
Author: arantor
Date: 10 February 2013 18:09:50
Message:
! Fix for PMs loading the wrong template for skellingtons. (PersonalMessage.php)
! Use the correct URL when a manual override has been indicated. (Admin.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/Admin.template.php
Title: Re: New revs
Post by: Nao on February 11th, 2013, 01:23 PM
rev 1914 -- registration process optimization, no biggie.
(14 files, 15kb)

* Moved registration/reminder text strings to their JS file. Overhauled said file to be much shorter (by around 200 bytes), even after adding the strings. Not that it's gonna be noticeable on your bandwidth meter, but whatever... Every little helps. Plus, I was always put off by that unused index #3 in verification field arrays. Also... Why the heck did I leave these Optimize strings in the JS file, when Packer will always minify them anyway? (Register.template.php, Reminder.template.php, register.js)

* Moved draft removal text string to its JS file. (Class-Editor.php, editor-func.js)

* Rewrote captcha sound to use the generic popup. Also fixed the 'Play again' link to avoid jumping to the top of the page. (VerificationCode.php, Register.template.php, Login.language.php)

* Added placeholder text for e-mail input at registration time. You never know... (Register.template.php, Login.language.php)

! Adding to $context['footer_js'] directly is bad practice, and could even break the feature. Modified all instances to add to a local string and then call add_js with this string as a parameter. (Class-Editor.php, Aeva-Foxy.php, Aeva-Gallery2.php, Display.template.php, PersonalMessage.template.php)

! If a captcha was failed, the second instance wouldn't allow for the sound popup to be run. (Subs-Editor.php)

! Fixed minor typo in French translation. Eh, my bad... (index.french.php)
Title: Re: New revs
Post by: Nao on February 11th, 2013, 07:10 PM
rev 1915 -- mouse wheel fix, more love for the skin selector, and index language cleanup.
(16 files, 13kb)

! Fixed mouse wheel no longer working on select boxes. Thanks to jQuery 1.7.1 for that one, ahem... (sbox.js)

* Rewrote wedge_show_skins to return a string rather than echo it. Well, technically I should rename the function as well, but I couldn't care less... The resulting string probably won't be long enough to have any impact on performance, and this has the advantage of filling in a name array where I can then get any skin's name from its path, which surprisingly isn't available from the get go. I really should store skin details in the database or in some kind of cache... Probably will do at some point, unless Pete beats me to it first... Anyway, this was all to allow the skin selector plugin to show the default skin (if it's the one selected) without the Default flag in the select box. (It should only be shown in the dropdown.) Ah, yes, because I added a parameter that enables adding a 'Default' flag next to the default skins (desktop and mobile). Which is cool... Do what you want with it. Again, this is all tested with only ONE theme enabled, so it may break or behave inconsistently on multiple themes. (Themes.php, ManageBoards.template.php, Themes.template.php, index.language.php)

- Got rid of plenty of obsolete index language entries. Apparently, we didn't finish our review process for them..?! (index.language.php)

! Fixed syntax of meta viewport tag. Apparently, BlackBerry devices don't like the semi-colons. Not that I ever tested Wedge on a BlackBerry, mind you... I don't even know if it's spelled BlackBerry or Blackberry. (index.template.php)

* Moved debug language entries to Stats language. Technically, they're debug stats, the stat language files are very short to begin with, and these strings should only be loaded for those who have the rights to see them, i.e. not everyone... No need to spend time loading them for everyone, then. (index.language.php, Stats.language.php, Subs-Template.php)

* Moved (and renamed) totalTimeLogged strings to the two files they really belonged to: Profile and Stats. Also got rid of the first one, which was obsolete. (Profile-View.php, Stats.php, index.language.php, Profile.language.php, Stats.language.php)

* Moved some smiley strings to the Profile language files. (Themes.php, index.language.php, Profile.language.php)

* Memberlist search page needed a bit of extra love. (Memberlist.template.php, sections.css)
Title: Re: New revs
Post by: Arantor on February 12th, 2013, 06:15 AM
(4 files, 6KB)

Revision: 1916
Author: arantor
Date: 12 February 2013 05:14:01
Message:
! Installer needs to actually set permissions on news, not trim a character off it and make it admin only by accident. (install.sql)

! Enhanced passive mode support in FTP, proper response changing for type changes, and some extra debugging nonsense. (Class-FTP.php)

! Updated credit for Crystal icons, to the most accurate I can come up with for now.

! Theoretically better compliance with RFC2407, as well as pruning some old legacy pre UTF-8 code. Not tested, but seems harmless enough. (Subs-Post.php)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/root/install.sql


@ The FTP stuff is essentially IPv6 support for FTP servers. Yay. As if FTP didn't grind my gears enough already. The plugin uploader is definitely getting there!
Title: Re: New revs
Post by: Nao on February 12th, 2013, 07:03 PM
rev 1917 -- more JS fixes... including an 'amusing' one.
(12 files, 9kb)

! Fixed another bug in the ask() code -- Invisible groups option in Manage Membergroups and de-admin option in Profiles were broken. Let's get technical: we shouldn't call !ask() (emphasis on '!') without ensuring that it isn't being used to actually cancel something, instead we should use its callback feature in these situations. Also, checkbox magic means that some !ask calls can stay in, such as the one in mediadmin. Just sayin'. (ManageMembergroups.template.php, Profile.template.php)

! In-topic moderation was also impacted by the bug above. However, it had 3 more bugs (in such a short function, must be a new record!) that needed fixing: it generated the wrong action URL when pretty URLs were enabled, it tested for '.modrem' against the wrong element, and it took message IDs from the wrong element too. Instead, it needed my now infamous .closest('.root') trick. I still love that one, it saves us so many bytes... Well, in this case the topic JS file is now 28 bytes larger... Most of which is due to the PURL fix. I hate the recycle bin. When do we remove that thing?! (topic.js)

+ Another minor thing, but long coming: added a shortcut to the default skin/theme selection page in the admin page introduction. This is something that even I sometimes had trouble finding, so... Also made some words stand out in the intro text, to ensure you can see what you want at a glance. (Admin.php, Admin.template.php, Admin.language.php)

* Moved total_* stat strings to the Stats language file... Is this never gonna end? ;) (SSI.php, index.language.php, Stats.language.php)

! Harmonized background colors in membergroup manager, and fixed the Add new membergroup page, which didn't get the extra styling of the rewritten board permission form. (ManageMembergroups.template.php, mana.css)
Title: Re: New revs
Post by: Arantor on February 12th, 2013, 07:31 PM
2 files, 11KB

Revision: 1918
Author: arantor
Date: 12 February 2013 18:20:20
Message:
! Some more FTP fixes: response checking, a little cleanup, put-string actually works. (Class-FTP.php)

! I don't entirely believe it myself, but I'm going to check it in anyway. This version of the plugin handler still spews a bunch of debugging information for now, and a silly message on success but right now I don't care. It has other bugs too, but as of today I was able to upload a plugin successfully and have it all unpacked on the server and everything. WITH CORRECT PERMISSIONS AND NOT A 777 IN SIGHT. I'm finally on the end of a very long journey, and I'm happy with that. (Subs-Plugins.php)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Subs-Plugins.php


Yup, the plugin uploader is actually working. Big thanks to Liroy for letting me abuse his server in the testing of this part.
Title: Re: New revs
Post by: Arantor on February 12th, 2013, 08:51 PM
2 files, 1KB)

Revision: 1919
Author: arantor
Date: 12 February 2013 19:50:37
Message:
! Fixed handling of empty files. (Class-ZipExtract.php)

! Some bug fixes: corrected handling of folders to extract, plus proper saving/restoring of details. (Subs-Plugins.php)
----
Modified : /trunk/Sources/Class-ZipExtract.php
Modified : /trunk/Sources/Subs-Plugins.php
Title: Re: New revs
Post by: Arantor on February 12th, 2013, 11:04 PM
(2 files, 2KB)

Revision: 1920
Author: arantor
Date: 12 February 2013 22:04:02
Message:
! Fixed the less than pleasant message and replaced it with a less fun and more appropriate message. (Subs-Plugins.php, ManagePlugins.english.php)

! Removed some of the debug stuff. Less vomity goodness. (Subs-Plugins.php)
----
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Title: Re: New revs
Post by: Arantor on February 13th, 2013, 02:49 AM
(4 files, 4KB)

Revision: 1921
Author: arantor
Date: 13 February 2013 01:48:54
Message:
! Some minor fixes to plugins, getting them to reuse some code as well as genericising one of the forms that other stuff will want to use. (ManagePlugins.php, Subs-Plugins.php, ManagePlugins.template.php, ManagePlugins language)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Title: Re: New revs
Post by: Nao on February 13th, 2013, 12:56 PM
rev 1922 -- the index language files are my sacred sanctuaries.
(21 files, 13kb)

! If ever calling ask() or say() from within a callback function for another ask() or say() call, Wedge would simply ignore the new one. Costs a couple of extra bytes. Gotta do what you gotta do... (script.js)

* More heavy stuff lifted out of the index language file. This is 1.5KB of data (and 44 array entries) you won't have to load uselessly on every page. Many of these strings are removed because they were either leftovers from pre-SMF2 days (e-mail stuff for instance, it was all moved to EmailTemplates long ago and there were remainders in the Post files), or leftovers from early Wedge days. The rest was mostly moved to the Post language files, because they were mostly used in Post situations. There may be many more entries that can be moved to something else, but... I'm tired all right? And I did all of the 'big' ones I think. (Display.php, Memberlist.php, MessageIndex.php, PersonalMessage.php, Profile-Modify.php, Mailer.template.php, LANGUAGES: Admin, index, Login, ManageMembers, Post, Stats)

- Naoism: removed smiley descriptions out of the smiley cache. My smiley system doesn't allow for descriptions because, frankly, they take bandwidth for nothing (who reads them?), and apparently I forgot to remove them out of the cache. (Subs-BBC.php)

- Naoism: duplicate 'search_for' string. (Admin.language.php)

* Naoism: duplicated 'view_all_members' to both Admin and ManageMembers. Seriously, I'm not going to load a 10KB file just for a single use on all admin pages, or a 40KB file for a single use on Memberlist pages. I'm also not going to keep it in the index language because, well... nah. (Admin.language.php, ManageMembers.language.php, index.language.php)

@ Naoism: the Class-Editor file has no description for most of the popup smileys. Should we add them..? In the meantime, at least I cleaned them up. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on February 13th, 2013, 01:41 PM
rev 1923
(48 files, 13kb) (what is it with me and 13kb commits these days..? 2 in a row, 3 in 2 pages?)

* A huge load of crap. Or, in other words, inner works of the Naoist monk. Removing some unneeded spaces that hurt my eyes, or turned all //!! into // !! (our 'regular' way of doing a to-do or I'm-not-sure-about-that-piece-of-code), and //old-code into // !! old-code ?? (because I can, and because at least that's findable through regex.) (48 files, not even going to bother listing them all.)
Title: Re: New revs
Post by: Nao on February 13th, 2013, 10:59 PM
rev 1924
(40 files, 10kb)

* Rewrote ajax rating of media items. In case there's an error, it will now show in the rating box instead of silently crashing. Also, it now returns plain text instead of XML. I'm trying to stay away from XML if not needed, not because I hate XML or anything, but because there really isn't any reason to use XML in Ajax transitions, except to look smug and use more bandwidth for nothing. Plus, this slight rewrite saves me 10 bytes or so in the script file. Oh, and I removed show_ajax calls from thought removal as well... Never bother to call that when you're not actually waiting for any Ajax feedback... That doesn't make sense. (Aeva-Gallery.php, Media.template.php, script.js)

+ Added a returnAjax helper function that simply outputs a raw string, passes it through ob_sessrewrite (in case it's some HTML) and returns. Thanks to Pete for unknowingly inspiring this to me. Hopefully this will become somehow my standard way of doing this. Otherwise I'll just add more params or something... (Subs.php, Aeva-Gallery.php, Media.template.php)

- Removed @ from ini_get/ini_set, an old SMF practice that never seemed to do anything special (these functions don't generate errors in the first place, just return false in case something went awry), and God knows I hate useless bytes. (40 files or so.)
Title: Re: New revs
Post by: Nao on February 13th, 2013, 11:18 PM
rev 1925 -- just pushing a smaller one before bed time. All in all, a day filled with crappy cleanup commits :P
(12 files, 42kb) (because of reindenting. I suppose.)

* Translation. (ManagePlugins.french.php)

* Some cleanup of remaining ?> closers or missing file newlines. (Class-UnitTest*.php, latest-themes.php, mirrors.xml, Announce.php, module.audio-video.matroska.php, Profile-Modify.php, ManagePlugins.english.php)
Title: Re: New revs
Post by: Nao on February 14th, 2013, 02:10 PM
rev 1926 -- we::$is_ajax harmonization, and fixing a Wysiwyg bug. (My fault for this one.)
(37 files, 14kb)

* Renamed $context['is_ajax'] to we::$is_ajax, as it's more of a system variable than context one. It doesn't seem to be tested against before the system class is loaded, but I may be wrong. Also harmonized all $_REQUEST['xml'] requests to replace them with we::$is_ajax and remove 'xml' from Ajax URLs. Just plain and simple... Mass-upload was a special case, because it uses YUI, so I'll be forcing we::$is_ajax on this one. (unittest.js, Class-Editor.php, Class-Skeleton.php, Class-System.php, JSModify.php, Like.php, Load.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Aeva-Subs-Vital.php, Subs-Media.php, Packages.php (when do we remove that one?), PersonalMessage.php, Post.php, Post2.php, Profile-View.php, QueryString.php, Search.php, Search2.php, Security.php, Split.php, Stats.php, Subs-Menu.php, Subs-Post.php, Subs-Template.php, GenericPopup.template.php, ManageMedia.template.php, Packages.template.php, editor.js, script.js)

* Rewrote some Ajax calls in the editor code to save about, hmm... 30 bytes? Even years after I started my quest to reduce the size of all our JS files to a couple of bytes, I'm still amazed at how much I can save just by being a bit smart about something. (editor.js)

! Which hopefully compensates the silly bug I introduced a month ago, that actually broke switching from Wysiwyg to non-Wysiwyg. Interestingly, a jQuery bug is also associated with it, but because my 'fix' actually compresses better than what I'd written, I'm not even going to bother submitting a report for that one. (editor.js)

* Simplified draft ajax response. Just enough to be able to optimize the matching editor-func JS file... Surprised uh? No? Okay, no. It saves 10 bytes, so sue me. (Subs-Post.php, editor-func.js)

* Moved .xml->feed action compatibility code to the QueryString file, which seems more appropriate for that to me. Also ensured that the corresponding $_GET/$_REQUEST action is updated as well. (index.php, QueryString.php)

! Fixed Pretty URLs in media feeds. (Aeva-Foxy.php)

* Now using XML template codepath for Atom feeds... This seems to work. Needs some double checking. Also fixed some Aeva Media files that still requested the older feed format (.xml in the URL) -- boo. (Load.php, Aeva-Embed.php, Aeva-Subs-Vital.php, Subs-Media.php)

- Replaced a few remaining ISO header declarations to UTF. (upgrade.php, Aeva-ModCP.php)

* Forgot a newline at the end of a file. (ManagePlugins.french.php)

@ I'm (very) worried about start_output() now always returning a XML header for all Ajax responses. Because not all of them are XML-formatted... Do you think this will be okay? (Subs-Template.php)
Title: Re: New revs
Post by: Arantor on February 15th, 2013, 04:07 AM
(2 added, 10 modified, 24KB !)

Revision: 1927
Author: arantor
Date: 15 February 2013 03:05:55
Message:
! News would get very very upset if you didn't have any news. (ManageNews.php, ManageNews.template.php, Admin language file)

! Custom fields are now sortable with a slightly improved interface. I might put more stuff on it yet (like 'field is shown on registration' and 'field is shown on memberlist') but don't know. (install.sql, ManageMemberOptions.php, Memberlist.php, Profile.php, Register.php, Admin.template.php, mana.css, active.png, field_types.png, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Added : /trunk/Themes/default/images/admin/active.png
Added : /trunk/Themes/default/images/admin/field_types.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on February 18th, 2013, 04:40 AM
(5 modified, 1 added, 10KB)

Revision: 1928
Author: arantor
Date: 18 February 2013 03:39:30
Message:
! New table for language changes tracking. This is only the new DB structure. (install.sql)

! Installer should not bother checking for agreement.txt but it should ensure that certain other folders really are. More changes will likely emerge yet. (install.php)

! Settings files should not be checking for agreement.txt. (Settings.php, Settings_bak.php)

! In certain circumstances old code for updating DB last error could be used. (Class-DB.php)

! New agreement file. Note that I haven't yet removed the old agreement.txt file because there's still code that calls it. (Agreement language file)
----
Modified : /trunk/Sources/Class-DB.php
Added : /trunk/Themes/default/languages/Agreement.english.php
Modified : /trunk/root/Settings.php
Modified : /trunk/root/Settings_bak.php
Modified : /trunk/root/install.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on February 18th, 2013, 07:17 PM
(11 modified, 1 removed, 18KB)

Revision: 1929
Author: arantor
Date: 18 February 2013 18:15:56
Message:
! Updated installer SQL with correct primary key. (install.sql)

! Don't show the warning status about bans to a given user if they themselves are softbanned. (Load.php)

! Bug fix - after the debug strings were moved to Stats lang file, the query viewer got upset. (ViewQuery.php)

+ First commit of magic new language entry cache thingy. NOTE: Language files are cached now. If you change a language file remember to dump the relevant cache of it. This is only for developers; regular users will be able to use the admin panel in future to do this. (Load.php)

! Registration code now uses the proper language string entry. (Register.php)

+ Manage registration now has spiffy new interface that interacts with the DB to update things. Juggled a few things about, gave it proper editing facilities. (ManageRegistration.php, Register.template.php, Admin language file)

! Some subsidiary stuff: don't let the current language file editor touch the agreement file and strip remaining entries of agreement.txt. (ManageServer.php, Packages.php, upgrade.php)

- Don't need scratty old agreement file any more. (agreement.txt)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Deleted : /trunk/agreement.txt
Modified : /trunk/other/upgrade.php
Modified : /trunk/root/install.sql


@ I can attach files. Why shouldn't I? It might get people to look in this topic more often? ;)
Title: Re: New revs
Post by: Nao on February 18th, 2013, 10:08 PM
rev 1930 -- minor bug fixes. I'm doing what I can to avoid a HUGE commit coming up where I've rewritten so many things... Also, +1 for screenshots ;)
(7 files, forgot to look for the size... probably a couple of KBs.)

! In profile pages, password length error message always said '4 chars' even when set to 8 chars minimum, because of a missing global. (Profile-Modify.php)

! Typo broke gallery pages. Dunno why no one noticed... (Aeva-Gallery2.php)

* Pretty please, use my refactored comment structure for commented out code please, or remove code altogether ;) (Admin.template.php)

* Also use ternary operators where it's painfully obvious... Again please ;) (ManageNews.php)

* Translation. Also, some of the outdated French strings weren't removed in a recent rewrite... (Admin.french.php, ManageSettings.french.php)

* Made post textarea frame a bit less in-your-face... (editor.css)
Title: Re: New revs
Post by: Arantor on February 19th, 2013, 12:12 AM
(5 files, 42KB!)[1]

Revision: 1931
Author: arantor
Date: 18 February 2013 23:11:23
Message:
! Tell the user their changes have been saved when they have edited something. (ManageRegistration.php, Register.template.php)

! Reformat the email templates stuff into something saner. This seems to work as intended and as a side benefit will definitely allow for proper change setup (which means changing email templates from the admin panel cleanly). I have a lot of plans for this and they all rely upon the language caching system that now exists, heh. (Subs-Post.php, EmailTemplates language files, I did both of them)
----
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
 1. I have no idea why it's so big. But the changes are quite 'bitty' I guess.
Title: Re: New revs
Post by: Nao on February 19th, 2013, 06:46 PM
rev 1932 -- at last, mini-menus for thoughts! Anxious to get feedback on this...
(23 files, 30kb)

* A major rewrite of the mini-menu system. It is now more 'generic', i.e. it's included in the main script and it does its best to accomodate more styles.
  - The code is much tighter than before (as if it wasn't already before..!) Also, made a last-minute rewrite to create all mini-menus together at load time rather than invidually hover time. This only takes about 70ms on full topic pages in modern browsers, which is better than I thought. The reason is that I'm planning for something more... That might end up being interesting. Or not.
  - The arrow position on right-aligned elements should now be consistent with the left-aligned ones.
  - Related classes are now simplified in the CSS files.
  - New virtual class .vbtn allows you to use these buttons anywhere, not just in action bars. (sections.css)
 (Display.php, Home.php, Display.template.php, Home.template.php, images/theme/menurow.gif, index.template.php, Msg.template.php, Xml.template.php, index.language.php, script.js, topic.js, extra.ie6.css, extra.ie7.css, extra.ie8.css, extra.ios.css, extra.rtl.css, index.css, sections.css)

* Replaced thought action buttons with mini-menu. See above for file list...

+ Added Android compatibility to user mini-menus. Damn their hover system...! I hate iOS these days, but at least it got that one right, unlike Android and Windows 8... (script.js)

* Post textarea frame is now a bit less in-your-face. (index.css)

* In order to save more bytes (moving mini-menus to the script file originally cost over 400 bytes, now reduced to about 160), did a few things that I'm sometimes proud of, sometimes not at all... Renamed .dragslide() to .ds(), removed closer tags when jQuery can very quickly fix them by itself (e.g. $('<div></div>')), simplified jQuery plugin structure (not sure why jQuery insists on enclosing them in closures or whatever -- it works perfectly fine outside of these), dropped the chainable aspect of .ds (this is actually more consistent with what my other pseudo-plugins do... If we ever need to have these inserted inside a chain rather than at the end, I'll update all of the plugins to do it as well), the main menu is now a plugin again, renamed weToggle's hooks to onBefore and onCollapse and onExpand (this is all that was needed, really...), left in a pair of {}'s when they weren't needed (it added an extra gzipped byte if I removed them, the joys of gzip magic...). I think that's all... (script.js, stats.js, zoomedia.js)

- Removed .top_likes button code, as it saves over 40 gzipped bytes in the CSS, while adding a bit less to the stats page. Considering it's likely to be requested less often than a CSS file, it's a bargain! (Stats.template.php, sections.css)

@ New thought system on homepage causes posted replies to have improper HTML, and they don't get their own mini-menu. This is fixed with a simple page refresh, but will still need proper fixing... Probably won't be able to add the mini-menu, though. Would be too expensive. This is a big issue for me. Also, the Welcome template is probably broken, too...
Title: Re: New revs
Post by: Nao on February 19th, 2013, 10:58 PM
rev 1933 -- icon maintenance code. Gotta do whatcha gotta do...
(18 files + moves & deletions, 19kb)

* Renamed modify_button class to edit_button, because... Err... It's one byte shorter. Also removed modify_inline.gif from index CSS, because... Guess what? It was a duplicate... This saves about 200 bytes from the main CSS file. I almost choked on my food, but unfortunately I had no food under the hand. (Display.php, Home.php, Msg.template.php, extra.rtl.css, index.member.css, sections.css)

* Replaced login_sm.gif icon with online.gif -- it just looks better and means the same ("registered member"). (Login.template.php)

* Replaced assist.gif icon with field_invalid.gif... Why, oh why? Because. The assist icon is perfectly unreadable (and has been since the SMF 2.0 beta days), and it's only used once (legend block), and a relatively subtle warning icon is just as good -- and four times smaller in bytesize. Until we replace it with something else -- or nothing -- this is at least better. (MessageIndex.template.php)

- Removing a few remaining calendar-related lines/icons. Should be in the calendar plugin, I guess..? (upgrade.sql, QuickMod.php)

- Removed a language string that really didn't bring anything to the table... Even this commit line is more meaningful than it. And that's saying a lot. (Themes.template.php, Theme.language.php)

- Removed reply_all_button class... Seriously. It's only used once (in PMs), and was already a copy of reply_button, so I just renamed it to that... (PersonalMessage.template.php, extra.rtl.css, sections.css)

- Moved create_button function from Subs to moderation page, and removed the last (mostly wrongful) uses in the other pages. Basically, I tend to favor adding _button classes instead of using img tags. Only the merge.gif button remains as a 'real' linked button, dunno what to do with it. Also, most of these replacements are block-type classes set on an inline-type anchor, meaning the icon could get partially hidden from view, so this really warrants further inspection. See Profile template for an example... (Subs.php, Merge.template.php, ModerationCenter.template.php, PersonalMessage.template.php, Profile.template.php)

! Fixed edit_draft button, it should have been an edit button, not a reply button... (PersonalMessage.template.php)

* Moved plenty of unused icons to /other/images/buttons. Feels good... (12 files, removed another 4 entirely. I think.)
Title: Re: New revs
Post by: Arantor on February 20th, 2013, 01:00 AM
(17 files, 49KB!)

Revision: 1934
Author: arantor
Date: 19 February 2013 23:59:12
Message:
! Scary commit. Emails can now be edited from the admin panel easily. (ManageMail.php, ManageMail.template.php, Admin.php, language files: Admin, ManageMail, EmailTemplates)

! Admin notifications should be sent for users who require admin approval after email validation. (Activate.php)

! Bug fix relating to $helptxt and indeterminate initialisation state. (Load.php)

! Harmonisation of email variables. In theory everything should be working and not broken in any fashion since I should have maintained all the email templates properly in sync. (Groups.php, Mailer.php, ManageMembers.php, Reminder.php, ScheduledTasks.php, Subs-Admin.php, Subs-Auth.php, subscriptions.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Arantor on February 20th, 2013, 05:47 AM
(1 file, 1KB)

Revision: 1935
Author: arantor
Date: 20 February 2013 04:46:47
Message:
! A quick one before bed, consistent fixed handling of not-found language files. (Load.php)
----
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Arantor on February 21st, 2013, 02:17 AM
(19 modified, 1 deleted, 5KB)

Revision: 1936
Author: arantor
Date: 21 February 2013 01:16:57
Message:
! Big home for text is big. (install.sql, ManagePosts.php)

! Spacinazi. Yup, I got there first! (ManageNews.php)

! Commenazi. (ManageSmileys.php)

! Trim meta descriptions to 160 characters. (Display.php, MessageIndex.php)

! Remove likes when a message is permanently removed. (RemoveTopic.php)

! Remove the likes a member made when they are deleted. (Subs-Members.php)

! Missing parameter in clean-up query. (Subs-Members.php)

- Death to the weird-ass hidden parameter introduced in 2006 that outside of a bugfix, no-one appeared to *ever* have encountered in any form whatsoever. (Search2.php, Search.template.php)

- Death to teh fulltexts. (ManageMaintenance.php, ManageSearch.php, ManageSearch.template.php, detailed-version.php, SearchAPI-Fulltext.php, language files: Help, ManageMaintenance, Search)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on February 21st, 2013, 05:45 AM
(5 files, 2KB)

Revision: 1937
Author: arantor
Date: 21 February 2013 04:43:48
Message:
! SMF bug 4947 - improper validation of $reservedVars. (Profile-Modify.php)

! SMF bug 4811 - legacy function call not needed. (RepairBoards.php)

! For some reason my JavaScript for the anti spam Q&A page started doing template weirdness. (Admin.template.php)

! SMF bug 4974 - misleading advice for regexp validation on CPF. (Help language file)

! SMF bug 4968 - register hook should expose more useful variables. (Subs-Members.php)

----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english.php

@ It isn't often I check up on SMF bugs that need fixing, but I'm going to try and do it a bit more often. I do not check whether they are fixed in SMF or not, merely whether they are fixed in Wedge mainline.
Title: Re: New revs
Post by: Arantor on February 21st, 2013, 06:11 AM
(11 files, 3KB)

Revision: 1938
Author: arantor
Date: 21 February 2013 05:10:34
Message:
! Quick one from me. Not properly tested though I don't think I broke anything. Includes free harmonisation of forum_name to FORUMNAME and removing a duplicate language string from index + Post into EmailTemplates since there's the only time it's really used, most of the time it was already loaded and for the one time it wasn't, no biggie. (ManageMail.php, ManageNews.php, Profile-Actions.php, ScheduledTasks.php, Subs-Post.php, language files: index, Post, EmailTemplates)

! Scheduled emails looked like they were using very much the wrong language strings. Not tested but using a variable you did set up previously as opposed to a loop castoff has to be better. (Probably remains in SMF though.) (ScheduledTasks.php)
----
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Nao on February 21st, 2013, 04:51 PM
rev 1939 -- tough job. C'est la vie.
(2 files, 14kb)

+ Added French agreement... I suppose that's how it's done..? I just took the text from the original SMF file. (Agreement.french.php)

* Partial French translation for e-mail templates. Seriously, this is one of the worse translation sessions I've ever had to go through... I've always hated this file, and I always will! (EmailTemplates.french.php)
Title: Re: New revs
Post by: Nao on February 21st, 2013, 04:52 PM
rev 1940 -- more love for JSON, yay!
(5 files +2, 22kb)

+ Added support for JSON and XML strings to returnAjax() helper function... The JSON bit is interesting, because you really, really just need to supply an array or object to the function and it'll deal with it for you. Gotta like that. (Subs.php)

* More shameless script.js optimizations... Using .click() instead of .on(), while using a really odd structure, saves about 6 bytes. Changing is_opera init position and removing an unneeded 'false' init saves a byte or two (I'm unsure, gzip magic and all). Moving a semi-colon around ajaxUrl saves another byte. Removed a test for .thought_actions which I forgot to (saves 10 bytes!), and removed the strange .toLowerCase in the thought object -- while I suppose I did have a good reason to add this one, I'd rather save 5 bytes now and revert it later if I remember what it was for. Overall, saved close to 25 bytes while keeping the exact same functionality. (script.js)

* Rewrote JumpTo object to optimize it for performance and size. First, converted it to use a JSON object. This saves 26 bytes in JS, and a variable but noticeable number of bytes in the response. Then, err... Removed the name sanitizer, which was a leftover from SMF days, and saved an extra 25 bytes. The JSON thing took me an hour. This one took a second. Whatever. (script.js, Ajax.php, Xml.template.php)

+ Added a json_encode() fallback, called we_json_encode(). Just call it instead of the other. The original class was about 33KB, I reduced it to 6KB by stripping the decoder (which would only be used in the Google Closure codepath -- and I'm never going to recommend this one by default, so we're safe for now), all comments, cleaning up the code, and turning the class static. (Class-JSON.php, Subs.php)

+ Added an alternative json_encode() fallback to the attic. It's much shorter, much faster, and gave me similar results on test arrays, but I chose to go with the 'safe', PEAR-approved solution. (attic/Unused-json_decode.php)

! JSON_UNESCAPED_UNICODE is only for json_encode, so it was silly of me to use it in a json_decode call... Even if that call isn't actually in the Wedge codebase, ah ah. I scare myself. (attic/Unused-convertU.php)

@ Overall, saved 85 bytes in the gzipped script file since yesterday... And gave Wedge more power to boot ;)
Title: Re: New revs
Post by: Nao on February 21st, 2013, 05:15 PM
rev 1941 -- I wanted to make a joke about the importance of being earnest, but it only works for in French. Damn translations. And I couldn't think of a Spielberg joke, either.
(27 files, 5kb)

* Replaced we::$is_ajax with AJAX constant... It's shorter, easier to type, and performance tests suggest that reading a constant is faster than accessing a static object. Also moved the declaration back to QueryString, because it no longer needs the system object and I'd rather define that one ASAP. (SOURCES: Class-Editor, Class-Skeleton, Class-System, JSModify, Like, Load, Aeva-Embed, Aeva-Gallery, Aeva-Gallery2, Aeva-ModCP, Aeva-Subs-Vital, Subs-Media, Packages, PersonalMessage, Post, Post2, Profile-View, QueryString, Search, Search2, Security, Split, Stats, Subs-Menu, Subs-Template, TEMPLATE: GenericPopup.template.php)

* CSS/JS filenames will now only retain the last 6 digits of the latest date. I'm even tempted to keep only 4 or 5... This gives a greater chance of cache collision, but seriously: one in a million, literally. And even if a file collides with an earlier version, what are the odds that the file, being at least 11.5 days old, will still be in some user's cache? And finally, you can always reupload a JS/CSS file to regenerate its date ID if someone complains about a collision. (Subs-Cache.php)

- Removed ?> footer from regular cache files. I tried hard, but couldn't find any evidence that this impacts performance, so we might as well save these two bytes, shouldn't we..? (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on February 21st, 2013, 05:35 PM
rev 1942 -- just one file, but it allows us to close a few bug reports... And hopefully not create any new one ;)
(1 file, 4kb)

! Committing my select box fix for .sb() not correctly updating the scrollbar. To tell you the truth, I left it to rot for a while because I couldn't figure out an efficient way to allow the user to click outside of a select box *after* **another** select box was redrawn with .sb()... Then I sat down, thought again about it, and I only have one thing to say. Why the hell would some code redraw a select box *while* you're in another? I mean, if you didn't even click one of the options, there's no reason for Wedge to redraw another select box anyway, right...? It just goes to show how silly I am sometimes. Well, the good news is that I'm not paid for all of that, so my hypothetical boss couldn't complain about the waste of time. (sbox.js)

@ Please note that not only the code is cool (it won't close the select box if it's being updated as of now...), but it's also shorter by 22 bytes than before. And I don't think I'd save more bytes by getting rid of the ability to keep the box open when updating it.
Title: Re: New revs
Post by: Arantor on February 21st, 2013, 11:25 PM
(7 modified, 3KB)

Revision: 1943
Author: arantor
Date: 21 February 2013 22:23:56
Message:
! Minor profile enhancement, language dropdown now includes the language flag. (Profile-Modify.php)

! Language caching seems oddly disturbed by admin search - but only by ManageMaintenance. I have no idea why but it works perfectly like this. (Admin.php)

! Restructure language editing into its own files (Admin.php, ManageServer.php, ManageLanguages.php)

! When caching the language list as we do anyway, don't cache the file's name as the language's name, cache the language's actual name in the right language! Yes, everything now says English and Francais rather nicely! (Load.php, index language file, yes I did both)

! In the list of languages installed, show all the relevant information (dictionary, RTL state), this is a prelude to removing that configuration page. There is really no need to edit that stuff from the ACP, only translators ever need to do so, but it's useful to have for reference. (ManageServer.php, ManageSettings language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php


Not a very exciting commit, I know, but it is a nice one and covers something I've wanted to do for a while.
Title: Re: New revs
Post by: Arantor on February 22nd, 2013, 04:36 AM
(8 files, 1 added (this time), 51KB)

Revision: 1944
Author: arantor
Date: 22 February 2013 03:33:21
Message:
! ManageLanguages.php got forgotten about last time :( (ManageLanguages.php)

! Some errant optimisation was not finished. (ManageMail.php)

! PMs have an email template. Use the darn email templates system! (Subs-Post.php, ManageMail.php, language files: EmailTemplates, ManageMail, PersonalMessage)

! Bug in scheduled tasks queue where failed items were incorrectly pushed to the back of the queue. (ScheduledTasks.php)
----
Added : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php


@ I did as much of the French changes as I could, without resorting to Google Translate. There's two new strings in ManageMail and only one actual new string in the email templates.
Title: Re: New revs
Post by: Arantor on February 22nd, 2013, 07:46 PM
(2 files, 2KB)

Revision: 1945
Author: arantor
Date: 22 February 2013 18:42:53
Message:
! Some miscellaneous fixes to language loading, notably fixing issues relating to loading multiple files at once, which is the cause of the error log issues plus the cause of why I had to edit the admin search, which I'm reverting here too. There were several issues, including a flag not being cleared in multiple loads, plus errors occurring prior to the theme being loaded would cause an incorrect theme id to be used, creating spurious cache entries unnecessarily. (Admin.php, Load.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Title: Re: New revs
Post by: Arantor on February 23rd, 2013, 01:17 AM
(4 files, 2KB)

Revision: 1946
Author: arantor
Date: 23 February 2013 00:16:32
Message:
! Forgot global variable for language editing system. (ManageMail.php)
! Merging moving topic notices is... um... bad. It's totally 'crossing the streams' bad. Don't do it. (Display.php, Merge.php, Errors language file)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/Merge.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Title: Re: New revs
Post by: Arantor on February 23rd, 2013, 03:47 AM
(4 files, 2KB, not sure I like these little commits much.)

Revision: 1947
Author: arantor
Date: 23 February 2013 02:46:14
Message:
! Technically CAPTCHA was a section, not a setting. (Admin.php)

! SMF bug 4640: remove index not used in any queries from log_activity table. (install.sql)

! SMF bug 4929: global variable overwritten in a loop. (MessageIndex.php)

! Stupidly used the wrong variable in the language area. No biggie, just meant all languages appeared to be RTL (even though they're not) (ManageLanguages.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on February 23rd, 2013, 09:35 PM
(3 files, 1KB)

Revision: 1948
Author: arantor
Date: 23 February 2013 20:34:23
Message:
! {literal} parameter in queries now supported. (Class-DB.php)

! Example query using {literal} (Subs-Members.php)

! XML returns from drafts were broken in r1926. (Subs-Post.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Title: Re: New revs
Post by: Arantor on February 24th, 2013, 05:14 AM
(12 files, 1 deleted, 2KB)

Revision: 1949
Author: arantor
Date: 24 February 2013 04:13:43
Message:
- House cleaning. Nothing seems to be broken, and anything that is, is both non critical and inherently temporary and possibly even pending a commit in its own right on unrelated matters. (Admin.php, PackageGet.php, Packages.php, Subs-Package.php, Packages.template.php, language files: Admin, Errors, ManageSettings, Packages)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/PackageGet.php
Deleted : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Title: Re: New revs
Post by: Nao on February 24th, 2013, 05:46 AM
rev 1950 -- I'm hungry... Can't sleep... Browsing on my S3... Fixing stuff for it.
(2 files, 2kb)

! Fixed scrollbar no longer being reactive in Android. This was mostly due to the fact that I forgot the window object has a scrollTo method already. Costs an additional 2 bytes to fix. (sbox.js)

+ Implemented my own super-short Android compatibility hack into menus. It only does the basics, but you don't need more because AFAIK, all parent menus have an equivalent link in their children. And it's only 21 more bytes, eh eh. Likely in reaction to Ant's comment at Elk about how Superfish got bloated to add mobile support... ;) (script.js)
Title: Re: New revs
Post by: Nao on February 24th, 2013, 07:12 AM
rev 1951
(17 files, 9kb)

! Fixed -prefix replacements in Wess. Seriously, I'm ashamed of this one... Probably a last-minute change. (Class-CSS.php)

! Fixed @if not supporting member/guest flags in Wess. I really thought they were already accounted for... (Class-CSS.php)

* More literal love... Literally. Okay, that one's done... Okay, should we also use literal for constant numbers..? (upgrade.php, Subs-Media.php, Merge.php, ModerationCenter.php, Profile-Actions.php, Profile-Modify.php, RemoveTopic.php, Reports.php, Stats.php, Subs-Admin.php, Subs-Charset.php, Subs-Members.php, Subs-Post.php, Themes.php)

* Minor layout fix. Yes, with a language string change... Don't bother. (ManageBans.french.php)

* Another scripturl bites the dust. (Subs-Media.php)

! setlocale fix and harmonizing. (Subs-Media.php, Subs.php)

@ Not that I'm teaching anyone anything, but my regex to find potential literals is '([^']+)' => '\1' -- although it's (ahem) unlikely to find things like {string:icon} associated with 'icon' => 'xx', for instance...
Title: Re: New revs
Post by: Nao on February 25th, 2013, 12:29 PM
rev 1952 -- wanted to have a cooler update, but.. had to pull it at the last minute. Still -- enough content for a commit.
(14 files, 5kb)

! Fixed menu tabs in Android. (GenericMenu.template.php)

* More strings to literals. (Class-Editor.php, ManageBoards.php, ManageMembergroups.php, ManagePermissions.php, ManageSearch.php, Aeva-Gallery2.php, ManageMedia2.php)

* Commenazi. (ManageBans.php, ManageMail.php, ManageMemberOptions.php, ManagePaid.php, ManageSearch.php, ManageSettings.php)

* More partial French translation... Honestly, I think I'm lost in this ocean of translation work. I'll give it another try, and then... We'll see. (Help.french.php)
Title: Re: New revs
Post by: Nao on February 25th, 2013, 05:12 PM
rev 1953 -- fixing a mail bug. I think. I never touched that code before... Pure chance.
(5 files, 15kb) (argh, translations..?!)

! SMF bug (also in Elk and everything...): fixed a variable inversion bug that caused, I would venture to say, failed mails to be stored for further retries but said retries never undertaken. I'd say that's a big one... Which needs fixing everywhere else. I'll post the details somewhere if someone asks. (ScheduledTasks.php)

* Finished string to literal transitions. I think they're all done now, but I've probably missed hundreds of strings that aren't named the same as their literal value. (ManageLanguages.php, ScheduledTasks.php, Subs-BBC.php)

* Translation. The nightmare continues in... Translation II: Spell-checker. (ManageMail.french.php)

* Typoos. (ManageMail.english.php)
Title: Re: New revs
Post by: Nao on February 25th, 2013, 05:53 PM
rev 1954
(15 files, 6kb)

* Reviewed all {string:}'s in the source code (by this point, you already know I'm a bit crazy), and turned all relevant ones to literals. Also more naoisms not worthy of any mention. (ManageBoards.php, ManageErrors.php, ManageMaintenance.php, ManagePaid.php, Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php, Subs-Media.php, Memberlist.php, Reminder.php, Subs-Members.php, Subs-Post.php, Subs-PrettyUrls.php, Themes.php, UnreadReplies.php)
Title: Re: New revs
Post by: Nao on February 26th, 2013, 10:44 AM
rev 1955 -- we::is grouping, final flexbox prefixing support. :)
(3 files, 8kb)

+ Added grouping support for we::is browser tests. I'm going to elaborate because it needs some attention. This allows you to do for instance "chrome && (ios, android)" instead of "chrome && ios, chrome && android", and more interestingly, "chrome && !(ios, android)". Well, I think it's more interesting because, let's say you have a $browser_list variable... You can do @if $browser_list to test for it, but doing @if !$browser_list wouldn't work as expect (it would only do a negative test for the first browser in the list), so running @if !($browser_list) will do what you want. You're the boss now. Also, I *think* nested grouping should work, but I haven't tested it, and I'm not sure there are many use cases for that anyway. (Class-System.php)

+ Added partial support for flexbox model: automatic prefixing (as needed) of flex properties, and a common CSS variable to offer an @if block for browsers that support it. Yes, it's directly related to the above... As for where I'm going to use the flexbox... I'll commit it as soon as I fix some obscure edge case. (Class-CSS.php, common.css)

! Fixed Samsung tablets and HTC Flyer to return a negative on is_mobile. I haven't actually tested them, but I looked through my code and it seemed like they'd misbehave. Also removed detection of WAP (Wedge is not going to work on this, don't bother testing!), up.link (a 90's browser, come on!) and Bolt (which was discontinued 2 years ago and doesn't work anymore). (Class-System.php)
Title: Re: New revs
Post by: Nao on February 27th, 2013, 07:13 PM
rev 1956 -- woohoo, CSS love!
(3 files, 5kb)

+ Messages are now shown in a flexbox that, err... Well, you'll see by yourself. You probably won't notice if you don't read the actual CSS. I'm so happy with that. Took me the entire week to get it right. Non-supporting browsers will still get the CSS table version, or the HTML table one for IE 6-7. (sections.css)

! Fixed broken rounded corners on context menus. What..?! And the fix barely makes sense either... (index.css)

* Simplified CSS for mini-menu arrows. Arrows' horizontal positions should now be the same in either direction. Hey, it's my first use of the calc() keyword... Funny! There's a fallback, too. (index.css)

! A relatively recent update had .bbc_pre set to inline-block, and I forgot to document that in the changelog. Well, it turns out that it broke flex boxes, so I'm reverting this... And perhaps I'll find the reason why I changed it. ;) (index.css)

* Replaced brackets around page number with CSS-generated ones. Just as a prologue to whatever Pete wants to replace it with later... ;) (index.css)

* Moved two action icons to where their brothers were. This is the reason I implemented '@if member' in Wess, not that you would care, but it saves quite a few bytes. (index.member.css, sections.css)

- Removed right margin in .inner class... This dated back to the original Weaving commit (two years ago!), and I have no idea whether it was supposed to be 'cool' or just fixed something that no longer happens. (sections.css)

- Removed mini-menu overflow rules. I remember I had to keep them at some point, but was unable to reproduce an error when removing them this time. (sections.css)
Title: Re: New revs
Post by: Nao on February 27th, 2013, 07:15 PM
rev 1957 -- best of the rest.
(7 files, 3kb)

! Fixed weSkeleton->find not returning false (and instead triggering an error) when a block/layer couldn't be found. This bug was introduced in rev 1175, which was a major rewrite, so I think I'm allowed room for forgiveness here. ;) (Class-Skeleton.php)

+ Added support for @viewport for browsers that support them (Opera 11+ and IE 10+). Although it doesn't look like much, it allows me to remove the meta viewport tag from all HTML pages in Opera Mobile and Windows 8. Best of all, skins can thus determine their favorite zoom levels. Okay, now we just need to wait for WebKit to add support for this... All right? It's underway... And it's taking time. Boo. (Class-CSS.php, index.template.php, Wireless/extra.css)

* Got rid of the .live (well, '.on' since the jQuery version change) calls to mini-menu items. The recent mini-menu rewrite was partly done to allow for event-driven JS to be put back into the 'click' array entry, and I forgot to do that for the two entries that called for the rewrite... Amusing. Also, note the double JSE call. It's needed because the string will be inserted between single quotes later. (Display.php)

* More bytes saved... About 10. And select box generation should be a tad faster, too. Well, I haven't benchmarked myself but... (script.js, sbox.js)

* Ah, yes, still needed to commit the index template's @viewport modification... (index.template.php)
Title: Re: New revs
Post by: Nao on February 27th, 2013, 09:09 PM
rev 1958 -- just fixes.
(4 files, forgot to check size -- I'd say 2 or 3kb.)

! Fixed Aeva Media misbehaving on servers that misbehave themselves by disabling the exec function. Thanks Farjo! (Class-Media.php)

! Oops, $$$$ should be called on a .replace() function, but on a .join() it should be $$ instead... (Yeah, I know, nobody will get that one.) (script.js)

! Fixed Profile link in user mini-menus. At the cost of 3 bytes... But I saved one with the fix above, so that's just two. (script.js)

! Fixed Wireless in Chrome Beta for Android. This is a specific version because only this one supports the final flex model. (Wireless/extra.css)

* I think these language strings are closer to what's really happening, but I might be wrong. (EmailTemplates.english.php)
Title: Re: New revs
Post by: Arantor on February 28th, 2013, 12:26 AM
(3 modified, 7 deleted, 1KB)

Revision: 1959
Author: arantor
Date: 27 February 2013 23:25:04
Message:
! Some more house cleaning. (Packages language file)
! Use the correct string, it's not_applicable rather than na. (ManagePlugins.php)
! We don't use these fonts and even if we did, I'm not sure what the licensing terms are for them anyway - not even SMF knows whether they can redistribute the fonts under BSD licence. What's left is all we use and it may well be replaced pretty shortly anyway, I'm already experimenting with new fonts. (*.gdf, *.ttf)
----
Modified : /trunk/Sources/ManagePlugins.php
Deleted : /trunk/Themes/default/fonts/Candice.gdf
Deleted : /trunk/Themes/default/fonts/Forgottb.ttf
Deleted : /trunk/Themes/default/fonts/Hootie.gdf
Deleted : /trunk/Themes/default/fonts/Kimbalt.ttf
Deleted : /trunk/Themes/default/fonts/President.gdf
Deleted : /trunk/Themes/default/fonts/Venusris.ttf
Deleted : /trunk/Themes/default/fonts/Walshes.ttf
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php



Yikes, 3 days since my last commit!
Title: Re: New revs
Post by: Arantor on February 28th, 2013, 01:11 AM
(1 removed, 1 added, 5 modified, 5KB)

Revision: 1960
Author: arantor
Date: 28 February 2013 00:08:21
Message:
! Adding new CAPTCHA font. It only has the basic alphabet in it so it's *very* small for the base package. I might add more fonts yet, hence the name. (wecaptcha1.ttf, captcha-*.php)
! The old Larabie font is no longer used, and so it can disappear too. (Screenge.ttf)
----
Modified : /trunk/Sources/captcha/captcha-grid.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim.php
Modified : /trunk/Sources/captcha/captcha-silhouette.php
Modified : /trunk/Sources/captcha/captcha-simpleanim.php
Modified : /trunk/Sources/captcha/captcha-stripes.php
Deleted : /trunk/Themes/default/fonts/Screenge.ttf
Added : /trunk/Themes/default/fonts/wecaptcha1.ttf
Title: Re: New revs
Post by: Arantor on February 28th, 2013, 05:16 AM
(1 added, 4 modified, 17KB)

Revision: 1961
Author: arantor
Date: 28 February 2013 04:14:48
Message:
! This isn't finished but I'm fed up of having it on my local copy uncommitted. This is, then, the first part of the new language editor, except doesn't have the editory saving bit. There's also no way to delete languages at present but I'm not sure exactly what I want to do with that yet, I may just have it as being 'selectable' and 'nonselectable' and admins that really are bothered by such can delete the files themselves. Also note the search function doesn't work yet either. (ManageLanguages.php, ManageLanguages.template.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Title: Re: New revs
Post by: Nao on February 28th, 2013, 09:12 PM
rev 1962 -- can_flex, E_STRICT, Firefox OS basic support.
(7 files, 9kb)

! Wess can't actually hold a list of browser UAs in a variable and allow you to do a test on it. It's a technical limitation. I could overcome it, but I don't see many situations where it would be helpful other than testing for a particular feature repeatedly, so I decided to implement constants to do just that. 'can_flex' is the one you want for the latest flex box model support, it replaces '$supports_flex' and that's all I have to say... Also, this has the advantage of allowing you to just do '!can_flex', without bothering about brackets. I also added support for the older flex models, which I'm not using. Currently, these constants are case-sensitive, in order to save time. I don't know what's best. It's something I'm saying a lot, these days... (Class-CSS.php, common.css, sections.css)

* Since E_STRICT is a PHP 5 constant, it no longer needs to be tested against... There's another one in Errors.php but I'm not committing this one for now because I'm working on the cleanest solution for it. Basically, SMF/Wedge skips all strict errors unless a hidden setting is enabled. Also, the end of the function is quite folkloric, dare I say hilarious, at least it made me laugh, so it shall be deleted entirely. (Elk, if you're listening....) (index.php, SSI.php)

! Fixed strict error: wetem static method calls. I don't know why I insisted on extending wetem from weSkeleton, it really wasn't needed. (Class-Skeleton.php)

! Fixed strict error: weSkeleton->render_recursive() doesn't accept non-variables as parameters. I benchmarked against the alternative (removing the pass-by-ref), and performance was similar, but often a tad faster in pass-by-ref mode, so I left it that way and just assigned variables. Anyone interested in doing more benchmarks in a different environment..? I can't wait to find a reason to get rid of all my unused references. Finally, weSkeleton is back to being a final class... If you have any reason for it to be extendable, just discuss it with me! (Class-Skeleton.php)

+ Added support for Firefox OS. Tested with both the G2B Desktop Client and the simulator bundled as a Firefox add-on. The former won't work because currently it provides the host OS in its user agent, instead of their own. The latter will work fine, though, it uses the official UA. (Class-System.php)
Title: Re: New revs
Post by: Nao on February 28th, 2013, 10:28 PM
rev 1963
(10 files, 4kb)

! Fixed togglebar link in profiles redirecting to your profile, even if visiting another's. (Subs-Menu.php)

* I've decided to make skin options clearer in scope. Until now there have only been two skin options, namely sidebar and mobile, so now we're storing them as SKIN_SIDEBAR and SKIN_MOBILE constants. Hopefully this won't affect performance in template_msg_wrap_before. The advantages are multiple: much easier to type, the constants are always defined, and of course no globaling to do. Any other custom settings will be defined as well, e.g. <my_setting> should be defined as SKIN_MY_SETTING. (Aeva-Gallery.php, Subs-Cache.php, Boards.template.php, Display.template.php, Home.template.php, index.template.php, MessageIndex.template.php, Msg.template.php, PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on February 28th, 2013, 11:29 PM
rev 1964
(3 files, 5kb)

* French translations. Hopefully, only EmailTemplates remains to be completed... Phew. (Admin, Errors, ManageSettings)
Title: Re: New revs
Post by: Arantor on March 1st, 2013, 04:32 AM
I'm pretty sure I haven't broken anything, and on the contrary improved a few things. Even though it's only one set of functionality, I'm going to break it down because it has lots of itty bits.

(21 modified, 8KB)

Revision: 1965
Author: arantor
Date: 01 March 2013 03:30:39
Message:
- Search no longer needs its own menu item (Subs.php, index.css, index language file)
! There's no need for a silly toggle, especially now the option doesn't exist. (ManageSearch.php, install.sql, Help and Search language files)
! While I'm on the manage-search settings page, let's also drop a related setting into the mix, whether to display a CAPTCHA to guests doing searches. We already have the option, just making it more prominent. (ManageSearch.php)
! Link to the advanced search on the front page (index.template.php, index.css)
! Removing hidden parameter we don't need any more (index.template.php, SSI.php)
! Actually removing this simple/advanced nonsense. It made almost no difference anyway outside of the UI. (Search.php, Search2.php, PersonalMessage.php, Class-UnitTest_tidyhtml.php)
! Cleaned up and harmonised the searching templates, yes they actually look consistent now, check the advanced search vs PM search for yourself on the site before this commit is added to wedge.org if you don't believe me! (Search.template.php, PersonalMessage.template.php, sections.css)
! Turned over some of the PM search strings to the main search language file. Didn't go through everything but hit up the most obvious ones for now. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage language file)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/root/install.sql


! Also, I did NOT remove the image from the menu sprite, just the CSS declaration for it.
Title: Re: New revs
Post by: Nao on March 1st, 2013, 11:36 AM
rev 1966 -- maintenance.
(6 files, 2kb)

! Wrong variable name... Oops? (Class-CSS.php)

! Okay, I didn't realize I had so many $context['is_mobile'] calls last night, and I don't know why I stopped after a couple of these... Probably got distracted by another bug. Anyway, I'm leaving them as they were, but use SKIN_MOBILE as much as you like, even if that other variable is available. I just decided against adding a couple of milliseconds (microseconds??) to the execution time. (Display.template.php, Msg.template.php)

! Big error messages equal big error log crashes, most of the time. Limiting per-message bodies to 10KB (instead of 64KB), should be enough to deal with most cases. (ManageErrors.php)

- Well, one of the points of using <URL> is the pleasure of removing $scripturl from global calls... So, why don't we just do that..? ;) (ManageSearch.php)

- Removing a context variable we no longer need. (Load.php)
Title: Re: New revs
Post by: Nao on March 1st, 2013, 11:56 AM
rev 1967 -- commit of love.
(4 files, 16kb)

* I hope no one minds... I've replaced that ugly filter.gif magnifier icon from SMF (used in search boxes, admin error log, and a couple of areas no one has ever noticed), with a much better, similar-looking icon based on the main menu search icon we just got rid of (but which I liked better, so there you go). I'm not 100% happy with it (notably the extra 1px of height that breaks some perfect alignments, but who will notice but me?), but it's 50 bytes smaller, and I also moved the search input's version into the menu sprite, so instead of wasting 220+ bytes in the CSS file for that, we're instead saving 25 bytes. All in all, a good move... I'm not 100% happy with the icon, but I can always revisit it later. Finally, note that the sprite icon is slightly offset to the right. This is to avoid background overlapping in the input box. (images/filter.gif, images/icons/sprite.png, other/images/sprite-menu-32bit.png, index.css)

* Reduced line-height of submit inputs, I guess they were still set to the Opera 'optimum', but since Opera will be moving to WebKit anyway, might as well use the WebKit optimal height now... (index.css)
Title: Re: New revs
Post by: Nao on March 1st, 2013, 01:04 PM
rev 1968 -- ob-la-di, ob-la-da, life goes oooon...
(4 files, 2kb)

* Strict mode was complaining with Packer, too... Ahem. So, I had to add dummy variables here and there. And remove an entire function that was mistaken for the constructor. Well, technically, it's the author's fault in the first place, but it's okay, the function never was used anyway... (Class-Packer.php)

! Typos. (EmailTemplates.french.php)

! This translation needed to be viewed in context before it made sense to me, ah ah... (ManageSettings.french.php)

* Pathetic spacinazi. Someone hasn't taken their medication today... (JSEditor.php)
Title: Re: New revs
Post by: Nao on March 1st, 2013, 03:33 PM
rev 1969 - I'm stepping through the door, and I'm floating in a most peculiar way...[1]
(6 files, 3kb)

+ As promised, here's a dropdown for the 'Advanced Search' link in the search box... It uses the HTML and CSS for main menus, adding about 12 gzipped bytes of HTML, 19 of CSS and 4 of JavaScript. It looks... All right. Especially for the cheap price.[2] (index.template.php, index.css, script.js)

* Simplified and improved the board list/label list areas in search pages. (PersonalMessage.template.php, Search.template.php)

! Fixed search input background in some pages. (sections.css)
 1. Remember an old sig of mine? :P
 2. Very interested in opinions! Should I switch to a mini-menu style instead..? It'll probably be a bit more expensive. And what about an Ajax-called panel? I'm still interested in doing that.
Title: Re: New revs
Post by: Arantor on March 4th, 2013, 07:40 PM
(8 modified, 3KB)

Revision: 1970
Author: arantor
Date: 04 March 2013 18:39:37
Message:
! $scripturl removal stuff, just a little bit more. (Help.php, Home.php, Mailer.php, ManageBoards.php, Register.template.php)
! Separate mail errors into their own log category. (Errors.php, Subs-Post.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Title: Re: New revs
Post by: Arantor on March 4th, 2013, 08:00 PM
(20 files, 12KB)

Revision: 1971
Author: arantor
Date: 04 March 2013 18:57:32
Message:
+ Updating user agreement nonsense. There is no admin UI for it at present, mainly because there are some fun kinks I need to work out with it but in the meantime I want to get this all committed so it's recorded. (all files)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php


@ It may look as if I had forgotten to update active_state_change in a bunch of places. The point of so doing is to update it when it reached an *active* state change, i.e. some change that would make the account active. I think this all works, but it is not exactly tested yet. I also figured that an admin would be approving a user and ignore the need to reagree in the interim.
Title: Re: New revs
Post by: Arantor on March 4th, 2013, 10:01 PM
(30 modified, 6KB)

Revision: 1972
Author: arantor
Date: 04 March 2013 20:59:16
Message:
! More $scripturl removal. I was bored and not wanting to tackle much that was particularly brain troubling. (all files)
----
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Notify.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Stats.template.php
Title: Re: New revs
Post by: Nao on March 5th, 2013, 10:38 AM
rev 1973 - Open your eyes, it's full of surprise, everyone lies, like the fox on the rocks, and the musical box.[1]
(4 files, 83kb)

* Updated jQuery 2.0 to beta 2. (Load.php, jquery-2.0.0b1.min.js, jquery-2.0.0b2.min.js)

! Fixed spellchecking not firing up in Quick Edit mode. Until we get to actually remove the SC feature entirely... (Display.template.php)
 1. Too many great albums for 1972-1973, had to choose between dozens so I took my favorite part of my favorite song of October 1972... Well, Pete took rev 1972 and didn't use it for references, so I'm calling dibbs! :P
Title: Re: New revs
Post by: Nao on March 5th, 2013, 05:10 PM
rev 1974 - Dreamer, you know you are a dreamer...
(5 files +1-1, 85kb)

! Now that was an interesting commit... Reverting last one's update to jQuery 2.0 beta 2, because it has a nasty bug that causes all reqWin calls to break, and possibly more. While I could temporarily 'fix' this bug, I'd rather just downgrade because beta 1 was running fine. (Load.php, jquery-2.0.0b1.min.js, jquery-2.0.0b2.min.js)

* A few more Wess functions needed the static treatment. Not that it triggered any errors... I'm just trying to stick to strict standards (until I'm bored with it.) (Class-CSS.php)

* More strict fixes: array_shift(array_keys()) is better replaced with key(), at least on newly created arrays. Plus, it's strict. (ManageMemberOptions.php, ManagePlugins.php)

- Hmm, I didn't remember having left some ;xml strings in URLs here and there... Starting with the stats file. It works fine without them, of course. (stats.js)
Title: Re: New revs
Post by: Nao on March 5th, 2013, 07:39 PM
rev 1975 - Gallileo, Gallileo, Gallileo, Gallileo, Gallileo Figaro Magnifico[1]
(12 files, 8kb)

+ Replaced the Advanced Search pop-up link with a much better looking pop-up that comes up when you click the quick search input box (and pops out on click or tabbing outside of the form). It provides you with all of the advanced search options (except for the board list), and is loaded through Ajax so it doesn't add any bytes. Actually, it removes bytes from the HTML (although it also adds an extra line when inside a topic -- this needs more tweaking!). Adds more JS, of course, but what can I say... (script.js, Search.php, index.css, sections.css)

* Moved 'Advanced Search' and 'Search Results' language strings to Search language files. (Memberlist.php, index.language.php, Search.language.php)

+ Added a search scope select box. If you're within a topic, you can directly choose to search across the current board, or entire site. If you're in a board page, you can search across the entire site. (Search2.php, index.template.php, Search.template.php, Search.language.php, script.js)

! Oh, the agony... jQuery and IE8 don't cooperate when creating a new DOM node. While $('<div>') works perfectly everywhere, in IE7/8 it doesn't seem to close the element automatically, resulting in many issues. I'll only fix them one by one... Don't want to waste too many bytes because of that. (script.js)

* Should be doing my menu hack for all touch-enabled devices, rather than just Android. I'm sure iOS won't mind about it... (script.js) :edit: typo
 1. My fave 1975 albums are all instrumental... So I'm just going to pay homage to the cool guys who were born that year. 8-))
Title: Re: New revs
Post by: Nao on March 6th, 2013, 11:18 AM
rev 1976 - Tê Tê Tê, Têtêretê. Tê Tê, Têtêretê. Tê Tê, Têtêretê. Tê Tê
(7 files, 3kb)

* Simplified JumpTo function to avoid a test in all index template executions. (Ajax.php, index.template.php, script.js)

* More $scripturl killings. (Split.php, Stats.php, Subs-Menu.php)

- Unneeded global. (Display.template.php)
Title: Re: New revs
Post by: Nao on March 6th, 2013, 07:11 PM
rev 1977 - Nothing ever grows in this rotting old hole, Everything is stunted and lost, And nothing really rocks, And nothing really rolls, And nothing's ever worth the cost[1]
(8 files, 22kb)

+ Added mini-menus to All Thoughts page. Finally... Refactored some of the code, was hoping to be able to add them to thought contexts as well, but it'll be for another day. Hoping to harmonize it all some more, too. (Home.php, Thoughts.php, Home.template.php, Thoughts.template.php)

+ Added a 'Posterity' option to the thought mini-menu. This solves a problem of mine with thought privacy and personal texts. Originally, I made it so that any new public thought would become your personal text; however, I found myself posting private thoughts then changing them to public to circumvent this, in order to keep an older thought as my personal text. From now on, Wedge won't update automatically your personal text; you can set any thought of yours to be your personal text simply by selecting the Posterity option in its mini-menu. Of course, anyone feel free to rename the option and add an icon, such as a star or something... (Ajax.php, Thoughts.php, index.language.php, script.js)

* Translation. (index.french.php)
 1. This one's for Pete... After he suggested We will rock you and We are the champions, and then this, I thought it'd be funnier to say oldSMF's anthem rather than ours :niark:)
Title: Re: New revs
Post by: Nao on March 6th, 2013, 07:23 PM
rev 1978 - With a smile of joy and gladness, with a look of exultation, as of one who in a vision sees what is to be, but is not, stood and waited Hiawatha.
(5 files, 4kb)

! A couple of fixes for quick search in Wuthering. (Wuthering/extra.css)

* Replaced the last remaining window.location with just 'location'... Well, there's another in the Media template, but I've made too many changes to it and can't commit that file yet, so it'll wait for another day. (PersonalMessage.template.php)

* Translation. (Login.french.php, ManageMaintenance.french.php, Profile.french.php)
Title: Re: New revs
Post by: Arantor on March 6th, 2013, 10:30 PM
(36 modified, 2 deleted, 4KB)

Revision: 1979[1]
Author: arantor
Date: 06 March 2013 21:26:35
Message:
! No more of this 'save in outbox' nonsense. It's saved automatically, even forcing the default for sendpm to save (because plugins doing it should default unless they *know* they don't want to), except for the places it shouldn't, like warning notifications and announcements. (install.sql, ManageMemberOptions.php, ManageNews.php, PersonalMessage.php, Subs-Post.php, PersonalMessage.template.php, Profile.template.php, PersonalMessage and Profile language files)

- Spell checking support removed from the bulk of code. Support does remain but only in the search area and even that might go. (index.php, detailed-version.php, Class-Editor.php, Display.php, Load.php, ManagePosts.php, Profile-Modify.php, Search2.php, Spellcheck.php, Subs-Media.php, Display.template.php, index.css, editor.js[2], language files: Admin, Help, index, ManageSettings, Post, Who)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/editor.js
Deleted : /trunk/Themes/default/scripts/spellcheck.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.sql
 1. You got me runnin', goin out of my mind,
You got me thinkin' that I'm wastin' my time.
Don't bring me down, no, no, no, no, no!
I'll tell you once more before I get off the floor:
Don't bring me down!
 2. I forgot these in the actual SVN log
Title: Re: New revs
Post by: Nao on March 7th, 2013, 12:35 PM
rev 1980 - Me r'connaissez-vous ? C'est moi, le crisse de fou, qui marche au-d'sus d'la ville...[1] / Hire ttipitasun hortan, baretu ditzakek soslai itsuak hegalak, baina ura nahi badun draia, hobe duzu merengeetan gastatu, Altxor Altxor Ene altxor.[2]
(21 files, 5kb)

- Removed type="text" from input tags. It's the default type. Has been in both HTML 4 and HTML 5... D'you have a problem with that? It saves tons of bytes... More files coming, it's literally hundreds of replacements. Also, replaced a few of these with type="email", as needed. (install.php, Profile.php, SSI.php, TEMPLATES: Admin, Display, GenericControls, index, Login, Mailer, ManageBans, ManageMail, ManageMaintenance, ManageMembers, Poll, Post, Profile)

- Removed CDATA and HTML comments out of script tags. CDATA tags are only useful when the page is sent with a XML header, which never happens in HTML mode (or could happen in the case of a SSI call, but let's hold our horses shall we?), and HTML comments haven't been useful for the last 15 years or so. I think it's fair to remove them, ah ah. (Subs-Cache.php, Subs-Template.php, index.template.php)

- Removed method="get" from form tags, as it's the default method anyway. And it's not used in a lot of situations... (install.php, Admin.template.php)

! Stupid laptop keyboard... (index.english.php)

* French grammar. (Search.french.php)

! Fixed number input width in search popup. (sections.css)
 1. http://fox.noisen.com/4800/harmonium/
 2. http://fox.noisen.com/4845/itoiz/
These are two of my favorite songs, so bugger off :P I can't believe I managed to go through the 70's without referencing more than a couple of prog albums!
Title: Re: New revs
Post by: Nao on March 7th, 2013, 01:32 PM
rev 1981 - I met someone who looks a lot like you, she does the things you do, but she is an IBM.[1]
(36 files, 5kb)

* Turned remaining text inputs into generic inputs. (36 files, too many to bother listing.)
 1. This one's actually my ringtone.
Title: Re: New revs
Post by: Arantor on March 7th, 2013, 11:52 PM
(25 files, 13KB)

Revision: 1982 - Chippin' around - kick my brains around the floor / These are the days it never rains but it pours[1]
Author: arantor
Date: 07 March 2013 22:50:34
Message:
! $scripturl removal, yay. (all files except EmailTemplates.english.php)
! Spacinazi. (EmailTemplates.english.php, ManageLanguages.template.php)
----
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/Mailer.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
 1. Certainly apt given this commit and the fact it's only part of a larger beastie in getting rid of $scripturl.
Title: Re: New revs
Post by: Arantor on March 8th, 2013, 03:59 PM
(64 modified, 24KB)

Revision: 1983[1]
Author: arantor
Date: 08 March 2013 14:57:27
Message:
! Msg skeleton needs more bones. (Msg.template.php, skeleton.xml)
! Revert back to ENT_QUOTES on saving things. Up-side is that everything works again, but at the cost of some more bytes. But we don't mess about with security matters. (Display.php, Post2.php, JSModify.php, topic.js)
! Better formatting in language area and cleaning up old rubbish. (ManageLanguages.template.php, ManageLanguages.php, ManageSettings language file)
! Spacinazi. (Class-FTP.php, Security.php, Subs-Plugins.php)
! Groups display needs to include properly formatted IP. (Groups.php)
! MOAR DETH TO $scripturl. Nothing seems to be broken but that doesn't mean something isn't. Also note that redirectexit() doesn't need to be given a $scripturl to redirect to an internal URL. (smfinfo.php, UnitTest.template.php, install.php, Admin.php, Boards.php, Class-Editor.php, Dlattach.php, Groups.php, Load.php, ManageAttachments.php, ManageBans.php, ManageErrors.php, ManageLanguages.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMemberOptions.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePlugins.php, ManagePosts.php, ManageRegistration.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Aeva-Embed.php, Aeva-Foxy.php, Aeva-Gallery2.php, ManageMedia.php, ManageMedia2.php, ManageMedia3.php, Memberlist.php, ModerationCenter.php, Modlog.php, MoveTopic.php, PackageGet.php, Poll.php, Post.php, Post2.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, Subs-Auth.php, Subs-BoardIndex.php, Subs-Menu.php, Subs-Template.php, Themes.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/ManageMedia2.php
Modified : /trunk/Sources/media/ManageMedia3.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/scripts/topic.js
Modified : /trunk/Themes/default/skins/skeleton.xml
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/templates/UnitTest.template.php
Modified : /trunk/root/install.php
 1. What ho said the t'ing with the three 'bonce', do not meddle with things you don't understand... (I'm an Iron Maiden fan, deal with it.)
Title: Re: New revs
Post by: Nao on March 8th, 2013, 05:59 PM
rev 1984 - Tasogare, utsusu... Madobe e to, mai oriru... / Stonehenge! Where a man's a man. And the children dance to the Pipes of Pan.[1]
(11 files, 7kb)

! Some $scripturl fixes for the previous rev (and various related things)... In a rush, Pete? My fault I guess... ;) (Groups.php, ManageMembers.php)

* More $scripturl changes. (Admin.php, ModerationCenter.php, Recent.php, Unread.php, UnreadReplies.php, Xml.template.php -- yes, it works on it too.)

* Improved logic of board index linktree. (Boards.php)

- One last remaining, well hidden type="text" input... (Register.template.php)

- Wedge can't search through its online manual. Wedge doesn't have an online manual. Wedge will never have an online manual. Manuals are for pussies. Wedge isn't for pussies. Wedge is for real men. And women. And dogs. (Admin.template.php)
! Some $scripturl fixes for the previous rev (and various related things)... In a rush, Pete? My fault I guess... ;) (Groups.php, ManageMembers.php,

* More $scripturl changes. (Admin.php, ModerationCenter.php, Recent.php, Unread.php, UnreadReplies.php, Xml.template.php -- yes, it works on it too.)

* Improved logic of board index linktree. (Boards.php)

- One last remaining, well hidden type="text" input... (Register.template.php)

- Wedge can't search through its online manual. Wedge doesn't have an online manual. Wedge will never have an online manual. Manuals are for pussies. Wedge isn't for pussies. Wedge is for real men. And women. And dogs. (Admin.template.php)
 1. This one's for Pete... Although I'm sure he'd have prefered a Metallica or Iron Maiden quote, allegedly best artists of that year :P First one is from the Macross movie ending. I love it.
Title: Re: New revs
Post by: Nao on March 8th, 2013, 06:07 PM
rev 1985 - I never knew how much I cared, so I played vicious games, vicious games... / I like talking in my sleep, when people work so hard they need what they can't keep a choice that leaves them scarred...
(3 files, 2kb) (ONLY?!)

+ Added a more interesting rewrite of device-pixel-ratio, meaning you won't have to touch it anymore, you just need to use min/max-resolution with a dpi or dppx unit in your media query. (Class-CSS.php)

* Commenazi. (Class-CSS.php)

* A couple of changes to the English version of EmailTemplates. Feel free to revert them, I just felt some of it could be improved. (EmailTemplates.english.php)

* At last... My latest nemesis, the French translation of EmailTemplates descriptions, is dealt with. (EmailTemplates.french.php)
Title: Re: New revs
Post by: Nao on March 8th, 2013, 09:37 PM
rev 1986 - Dakishimeta, kokoro no kosumo... Atsuku, moyase, kiseki wo okose! Kizutsuita, mama ja inai to, kiseki atta haruka na ginga... / One dream, one soul, one prize, one goal, one golden glance of what should be...[1]
(12 files, 7kb)

* More $scripturl replacements. All templates are now officially converted. Hopefully everything's working... It's getting hard to navigate along items that really need $scripturl these days. I've double-checked, but I can't test everything in context, so basically, if something's broken because of that, we'll fix it. Because that's what we do. (Ajax.php, Aeva-Foxy.php, Merge.php, MessageIndex.php, ModerationCenter.php, Modlog.php, PostModeration.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Subs.php, ManageMedia.template.php)
 1. One is my favorite show's opening, the other is one of my childhood movies, plus Pete would want it here. :P
Title: Re: New revs
Post by: Nao on March 8th, 2013, 09:53 PM
rev 1987 - Look at me standing, here on my own again... Up straight in the sunshine... No need to run and hide, it's a wonderful, wonderful life.[1]
(6 files, 3kb)

* Oh bugger, it's becoming so hard... I'm spending 10 times more time reviewing and reverting files than actually changing $scripturl calls. This smells like the end to me... ;) I'm leaving the rest up to Pete for now! Or some more interesting commit, of course... (ManageMedia2.php, MessageIndex.php, Modlog.php, PostModeration.php, Profile-Modify.php, Profile-View.php)
 1. And that's my childhood's favorite song. Done for now -- I'm sure the world can live without my anime lyrics for the next 15 commits to come... :lol:
Title: Re: New revs
Post by: Nao on March 10th, 2013, 10:28 PM
rev 1988 - Nanimo iwazu dakishimeta, Anata no yasashisa wo... Wasureru hi wa nai no, You are my reason to be.[1]
(5 files, 7kb)

+ Initial implementation of the <if> test system for skeletons that Pete requested the other day. Please note that it's not been thoroughly tested. It also works on skin.xml files, meaning you can freely set a skin to <mobile> mode only for guests, or load a web font only for a specific board, whatever you want, in addition to being able to enable some skeleton blocks only for members, which was the original request. Ah, yes, I didn't implement any sort of <else> alternative, you'll have to do it the htaccess way, i.e. <if admin>...</if><if !admin>..alternative..</if>. And finally, I'm not offering support (yet) for skin constants, and <if mobile> isn't the same as <if SKIN_MOBILE>. The first tests for the user's device, while the second would (if implemented) test for mobile status of the current skin, e.g. are we inheriting from the Wireless skin or another skin that has the mobile flag on it? (Subs-Cache.php)

+ Added a few variables to the we::$user array. 'is_member' is the opposite of 'is_guest', 'is_m123' means 'is member #123', 'is_b1' means 'currently viewing board #1' and 'is_c1' is same for categories. Finally, 'is_rtl', which is initialized outside of Class-System but still ASAP, means the current language is right-to-left. Why all the variables..? Because they can now always be accessed in we::is() tests, meaning you should be able to test against them properly inside CSS files, skins or whatnot. (Class-System.php, Load.php)

! As per the above -- fixed @is (rtl) and @if (rtl) tests in CSS files, which didn't work at all (only the filename suffix system supported it). It goes to show how often I test RTL versions of my files... Yes, last time I did it, your mother wasn't even born. (Load.php)

! we::$user['name'] was always set to 'Guest' for guests, even for non-English versions, due to a missing global. Also removed another global, unneeded this time. (Class-System.php)

! Fixed a situation where sub-skins with an empty option set could generate minor errors. (Subs-Cache.php)

! Don't allow admins to choose someone else's thought for their own posterity... Oh, naughty admins! (Thoughts.php)

! Fixed typo in gallery area that caused a page crash. Also updated item page mini-sidebar to be hidden on all mobile devices, rather than just iOS stuff. (Aeva-Gallery.php)
 1. http://dossiers.cyna.fr/598.html -- I watched this movie well over 300 times between 1990 and 1995. If I bothered to keep track, then it obviously has its spot in here. :P
Title: Re: New revs
Post by: Arantor on March 11th, 2013, 09:44 PM
(20 modified, 1 added, 3 deleted, 9KB)

Revision: 1989[1]
Author: arantor
Date: 11 March 2013 20:39:40
Message:
! Consistent styling in newsletters area, leading to dropping an old language string. (ManageNews.template.php, Admin language files)

! String that as far as I could tell wasn't being used. There is a string with the same key in index, but that particular string is used in the bbcode. (Search language file)

! Replaced old sortselect styling with the more correct foldable styling - all the places it is used, it is used in a foldable context. (ManageLanguages.template.php, ManagePermissions.template.php, sections.css, sortselect.gif)

! Literal string use in the board permissions code. (Load.php)

! Replaced the old sort_down and sort_up images with a single sprited image, configurable in the CSS. It's a small detail but to me quite an important one. It's used in quite a few places, actually. (sort_up.gif, sort_down.gif, sort.gif, index.css, Aeva-Foxy.php, ManageMembergroups.template.php, Memberlist.template.php, MessageIndex.template.php, PersonalMessage.template.php, Profile.template.php, Recent.template.php, Who.template.php)[2]
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Who.template.php
Added : /trunk/Themes/default/images/sort.gif
Deleted : /trunk/Themes/default/images/sort_down.gif
Deleted : /trunk/Themes/default/images/sort_up.gif
Deleted : /trunk/Themes/default/images/sortselect.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/sections.css
 1. "I want to you to tell all your friends about me..."
"But what are you?"
"I'M BATMAN."

Either that, or "It ain't much I'm asking, I heard him say,
Gotta find me a future, move out of my way,
I want it all, I want it all, I want it all, and I want it now!
I want it all, I want it all, I want it all, and I want it now!"
 2. This is used in a bunch of places, and not all of them are members-only, so I felt justified in putting it into the main index file.
Title: Re: New revs
Post by: Nao on March 12th, 2013, 05:12 PM
rev 1990 - Don't forget to try in mind, ai wa Jewel yori, subete wo kagayakasu...[1]
(5 files, 11kb)

* Changed SKIN_SIDEBAR string constant to two boolean constants: SKIN_SIDEBAR_LEFT, and... SKIN_SIDEBAR_RIGHT. This will be useful for the feature below. (Subs-Cache.php, Msg.template.php, Warm/skin.xml)

+ Added ability to test against skin constants from anywhere that uses the generic we::is test function. For instance, in a CSS file, doing @if (mobile) determines whether the user is using a mobile device, while @if (SKIN_MOBILE) will determine whether the current skin is targeted to mobiles (i.e., currently, the Wireless skin.) (Subs-Cache.php)

+ Added support for <else> fallbacks in skin.xml/skeleton.xml conditional tests. For instance, <if SKIN_MOBILE><do_something><else><something_else></if>. Self-described. (Subs-Cache.php)

* Updated msg mini-skeleton to make use of the new <if> system. I don't know about you, but I think it looks more complicated than it used to... ;) Well, at least it's shorter. (Display.template.php, Msg.template.php, skeleton.xml)

* Cleaned up many unused globals in the Msg template. Not sure if they're all cleaned up by now... But they probably are. (Msg.template.php)

@ Still unsure whether we should remove all SKIN_MOBILE tests from the Msg template -- or not care too much, considering the number of occurrences is now low enough to make it a very minor performance hit.
 1. I think it's the only TV show where I had my name in the ending credits, for some reason. 8-)
Title: Re: New revs
Post by: Nao on March 12th, 2013, 06:19 PM
rev 1991 - Drive, driven... Gave, given... I gave myself away. / Ima, hatenai tabi ga hajimaru... Haruka na toki wo mitsumete.[1]
(23 files, 9kb)

* Renamed $context['current_action'] to just $context['action'] (it's not taken!) and replaced all awkward $_REQUEST['action'] tests with that. Also, the action is now exclusively retrieved from $_GET, rather than $_REQUEST. I don't think there's a reason to look into post data... Sub-actions are also stored in $context['subaction'], but there are more occurrences to replace, and I can't bother for now. Anyone..? (index.php, SSI.php, and two dozen files I won't bother listing.)

+ Added another (tentative) new hidden setting, $settings['default_action']. It's the equivalent of $settings['default_index'], and has priority over it. 'default_index' holds a filename (it has to contain a function with the same name), while 'default_action' holds an action name. This allows you to override the index page's default action, which is usually home or boards, and still set the $context['action'] variable correctly, something I'm afraid default_index doesn't provide for. It will be needed in some situations, such as Aeva Media being set at the default homepage: because it tests for empty actions, it could give unexpected results in the homepage. Would love to discuss the repercussions of this all! (index.php)

- Removed an empty($action) test that would never return true, because the test was already done earlier and resulted in a return. Pete..? (index.php)

* Reverted a <URL> which I'm not sure would be working. Well, it's just one, won't bother testing thoroughly. (Subs-Template.php)

* Moved respond.js inclusion for oldIE to avoid generating it for Ajax templates. (Load.php)

! Fixed animation of the search pop-up. Unfortunately, this adds about 20 bytes to our JS, but I couldn't find a tighter way to do it, otherwise I'd have done that. I even had to fight with what I suspect is a jQuery bug... (script.js)
 1. I'm running out of ideas... These are cool songs, but nowhere as good as my 70's favorites :P
Title: Re: New revs
Post by: Arantor on March 12th, 2013, 09:08 PM
(9 modified, 3 deleted, 4KB)

Revision: 1992[1]
Author: arantor
Date: 12 March 2013 20:05:09
Message:
- More images that I can't find any trace of being used, so let's get rid of them. (im_sm_newmsg.gif, im_sm_prefs.gif, loading.gif)

! If displaying a moved-topic notice, discourage search engines from indexing it. (Display.php)

! Twitter URL isn't the same as it used to be. (ManageMemberOptions.php)

! A little overhaul on the manage message icons code, namely consistency in the UI is good, unbreaking deleting message icons and disabling this nonsense of having to 'enable customized' icons, they're on and on for good. SSI is still questionable but that has a lot of consequences I don't want to get into just yet, and the UI needs more love but I haven't figured out what I want it to look like yet. (Admin.php, ManageSmileys.php, Subs-Editor.php, Admin and ManageSmileys language files)

----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Subs-Editor.php
Deleted : /trunk/Themes/default/images/im_sm_newmsg.gif
Deleted : /trunk/Themes/default/images/im_sm_prefs.gif
Deleted : /trunk/Themes/default/images/loading.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
 1. So never mind the darkness
We still can find a way
'Cause nothin' lasts forever
Even cold November rain
Title: Re: New revs
Post by: Nao on March 13th, 2013, 11:40 AM
rev 1993 - My dearest friend, if you don't mind... I'd like to join you by your side, where we can gaze into the stars, and sit together, now and forever... For it is plain as anyone can see, we're simply meant to be...[1]
(3 files, 2kb)

* Now that all strict errors seem to have been fixed, E_STRICT will also be recorded in database errors -- mostly to encourage plugin authors to write clean PHP. (Errors.php)

! Fixed missing global. (Class-System.php)

! Fixed wrong constant name. (Aeva-Gallery.php)
 1. Another of my long-lasting forum sigs! I went to see a subtitled copy of tNbC at a local art theater back then, and I was the only one in the room! After an hour, the projectionist actually came and joined me!
Title: Re: New revs
Post by: Nao on March 13th, 2013, 11:23 PM
rev 1994 - Yoake yo ima, boku wo sukue, ai ga hoshii, ai-shite hoshii...[1]
(12 files, 5kb)

* Wess mixins will now accept: mixin names with a '.' in them (seriously, if you prefer to use a pseudo-class name, I'm not going to blame you), and mixin bodies now accept empty lines, allowing for @if tests and comments to be added in them. This was long overdue. (Class-CSS.php)

* The reason why .inline-block was an extend-type class, is that I wasn't able to get mixins to close and reopen back in the day. Well, to make things short: I found a clever workaround for that, and here's how I'm turning .inline-block into a mixin. Gzipping is much more efficient when meeting plenty of 'display: inline-block' than when seeing two occurrences of many different classes/IDs in the whole file. Obviously. This saves over 100 bytes of code. And is just clean. (common.css, index.css, index.member.css, editor.css, mana.css, Wuthering/extra.css)

! Topic titles weren't aligned correctly in IE7. (extra.ie7.css, sections.css)

! I was just going to fix a missing semi-colon in this JS code (just for consistency), but ended up rewriting it, hmm... (ManageNews.template.php)

! Fixed search popup position. (index.css)

! Fixed per-post user-box list circles. (index.css)

* Renamed #ajax_in_progress to #ajax. Why? Well, #ajax was unused in our codebase, and it saves 10 bytes in the JS file, and a few bytes as well in CSS. Isn't that enough? (script.js, index.css, extra.ios.css -- hmm... Is this really necessary in iOS? I think iOS 5 fixed 'position: fixed', can someone double-check for me?)
 1. http://namida.cyna.fr/english/ls-mother.html -- not their best album, but I can't count on rev 1996 being free for me :P
Title: Re: New revs
Post by: Nao on March 14th, 2013, 12:29 PM
rev 1995 - Mesecina, mesecina, joj, joj! Joj, joj! Sunce sija ponoc bije, joj, joj! Joj, joj! Sa nebesa, zaproklija... Niko ne zna! Niko ne zna![1]
(8 files, 4kb)

! Yes, I know redirectexit() doesn't require <URL>, but if it's *forced* upon it, it would actually fail. So, fixed the function to accept <URL>, and dropped the test for 'about:', because I couldn't find any Wedge file that makes use of that, and can't think of any reason for a plugin to redirect to an internal browser page either. (Subs.php)

- Removed ;xml from a few remaining URLs. This is no longer needed, as all of our tests are done on the AJAX constant now. Or other variables (usernamecheck for instance). (post.js, register.js, suggest.js, topic.js)

* Saved over 50 bytes in topic.js by not giving a damn about oldIE. So, it no longer gets a hover effect in IconList..? Who cares? Have you ever seen a moderator/admin ever using IE6? Do you *want* them to be your own admin? Anyway... The location.hash trick is probably a leftover from dinosaurIE because it works in IE7 for me. Same for the width-forcing hack... IE7 doesn't need it. IE6, I probably won't bother to test anything anymore. (topic.js)

* Moved .iconbox and #iconlist selectors to the member file, as these elements are never available to guests. (sections.css, index.member.css)

* Minor cleanup. (Subs-Media.php)

:edit: Fixed a copy'n'paste disaster.
 1. It's a beautiful song from one of my favorite movies. I had, for a long time, a subdomain at cyna.net that was called 'mese'... For some reason ;)
Title: Re: New revs
Post by: Nao on March 15th, 2013, 12:17 AM
rev 1996 - Dakishimete itai, subete wo wasurete, kiken na kurai Ray, kimi wo...[1]
(1 file, 1kb -- had more to commit, but wasn't confident enough in their stability.)

* Slightly optimized Pretty URLs handling, using rtrim() everywhere it can be used, instead of just in a couple of lines. (Subs-Template.php)

! PM viewing mode was broken... And apparently had been for a while... Because the quick URLs ended with a '=', and PURLs would 'optimize' and remove them. So, I rewrote the lines to prevent removing these if they're at the end of a URL. I couldn't think of a single case where this would be a problem... Then again, nobody ever noticed this was broken in the first place, right..? (Subs-Template.php)
 1. Okay, apparently I got it :P It's Ray, by Luna Sea. Another fantastic rock song. I'd love to quote more instrumental albums, there are so many, but that's gonna be hard... Stay tuned for rev 1997, which will probably have my last 'cult' J-Rock album. Oh, and I skipped X Japan's 1993 Art of Life. Shouldn't have. Okay, time for bed. Or the psychiatric ward.
Title: Re: New revs
Post by: Nao on March 15th, 2013, 03:18 PM
rev 1997 - Around the world, around the world (bis repetita) / La vie est belle, le destin s’en écarte, personne ne joue avec les mêmes cartes / Rain down, rain down... Come on rain down on me, from a great height.. / Estuans interius, ira vehementi, estuans interius, ira vehementi, Sephiroth! Sephiroth! / Whatever I've done, I've been staring down the barrel of a gun... / Endless, timeless, faceless terror! To the isle of deadly shores! Sightless, countless, ageless torture! To behold the sight of Medusa's eyes / Baby I'll be good. Pray for me, Praying for the light...[1]
(8 files, 23kb)

! Fixed strict errors in post editor (add_button is a per-instance method, not a static one), and in captcha (both animated and sound). Rewrote create_led and paint_led to use the same parameters in both versions, but I'll let Pete decide whether to do a 'proper' rewrite of these -- maybe simply different function names..? (Class-Editor.php, Subs-Sound.php, captcha/captcha-ledicons.php, captcha/captcha-ledicons_anim.php)

! SFTP code had nearly 2 kilobytes of unneeded whitespace, and was missing newlines, or things like that. I think I fixed most of them, at least the ones that hurt the most... I'm going to have nightmares about this one for months. (Class-SFTP.php)

* Harmonized whitespace around $context['menu_separator'] and page index. (Display.template.php, index.template.php, PersonalMessage.template.php)
 1. And again, an excellent musical year... With plenty of great instrumental albums (Philip Glass's Kundun, Jean Michel Jarre's Oxygen 7-13...) and tons of others I loved. I should say that I listened exclusively to Japanese music between 1989 and early 1996, so in 1997 I really spent a lot of time 'catching up' with recent music. Okay, I'll be nice and tell you what I mentioned, since I decided to be more thorough (don't worry, 16 commits to go and I'll be back to my one-liner commit comments!)

Daft Punk's 1st album -- not the best but still;
IAM's best album (and also the best rap album I've ever listened to) "L'école du micro d'argent";
Paranoid Android, from Radiohead's best album and arguably one of the best and most influential pop albums ever released;
Final Fantasy VII's final boss song, need I say more??;
My favorite album from Depeche Mode;
Symphony X's The Divine Wings of Tragedy: one of my top 3 metal albums, the other 2 being released soon after... Maybe I'll mention them :P;
Craig Armstrong's first solo album was also fantastic, heck, even Yôko Kanno totally ripped him off over the years...
I wanted to quote Berserk's opening, but I'm not a big fan of it, I really prefer the instrumentals, which are gorgeous. Can't quote instrumentals, eh?
Title: Re: New revs
Post by: Nao on March 15th, 2013, 07:59 PM
rev 1998 - I'm coming to an end, I've realized what I could have been. I can't sleep so I take a breath and hide behind my bravest mask, I admit I've lost control. Lost control...[1] / Just you and I can find the answer. And then, we can run to the end of the world, we can run to the end of the world.[2] / Gin no shizuku wo nonda kara...[3] / Umaretara shinu nante, umaretara kieru nante, kurikaesu nante totemo fujouri...[4] / We will destroy all that you create, cause we are the trolls of invention.[5] / Aka kiiro himawaru. Daidai gunjou ajisai.[6]
(4 files, 2kb)

+ At a cost of only 16 bytes (thanks to some clever reordering, which should hopefully not break anything), Wedge's select boxes will no longer overflow out of your browser window if the box is too close to the right. Well, it does look like my to-do list for select boxes is finally completed... :) (sbox.js)

! Fixed admin menu icons, which no longer inherited .inline-block because, well, it's now a @mixin, so until I finally get to turns mixins into actual virtual classes, this will do. Well, it saves over 100 bytes doing it this way anyway... Can't believe I spent so little time testing mixin performance for widely used classes. (Subs-Cache.php)

! My <URL> fix for redirectexit() wasn't exactly too smart... And untested. Fixed that. (Subs.php)

* Tweaked media profile list layout. No biggie. (ManageMedia.template.php)
 1. Alternative 4 by Anathema... My second favorite symphonic metal album. I love it as much as 'Natural Disaster' from 2003.
 2. Xenogears. Best. Videogame. Ever.
 3. While this wasn't released in 1998, I have fond memories of listening to that song in loops while working on Kyodai Mahjongg. http://youtu.be/U8f3OBLUT1Q
 4. Missing Link, Utena final episode. Breath-taking song. Look it up!
 5. Next Time, by Yôko Kanno. So, I'm probably going to quote her songs a lot in future commits, I'm a devoted fan, and also one of the first to denounce her tendencies to plagiarize anything she can find, from Pink Floyd to obscure (in Japan) French artists. Still... Big fan, as I said. She's talented, she just doesn't have the faintest idea what copyright is, like Goran Bregovic. Another genius who upsets me from time to time. But I still quoted his Mesecina and went to see him live three times -- go figure.
 6. :edit: Added Gessekai by Buck-Tick. One of the best J-Rock songs. Also great: Sexy Stream Liner album (1997). And the subsequent live album.
Title: Re: New revs
Post by: Nao on March 15th, 2013, 10:45 PM
rev 1999 - Jeune homme doucement, commence à comprendre, qu'on est seul dans cette vie, qu'on est seul dans cette vie.[1] / Jag hörde, en nostalgisk sång, någonstans långt borta.[2] / So what would Brian Boitano do, If he were here today? I'm sure he'd kick an ass or two. / Taan les tai la la la, la la loo. Morie taan mi fai es volta...[3]
(4 files, 3kb)

* Various CSS tweaks. Rewrote <hr> tags separating topic posts to have a class of 'separator' instead of 'post_separator'. Menu separators share the same class, but in a <li> tag, so this should help with gzip compression. Moved to styling the .root class instead of .postbg, this is more readable. Prevented said class to have a 'display: table' in case the flexbox model is being used. Moved .postbg2 margin to hr tags instead, this is way cleaner, although requires a few tricks thanks to stupid oldIE. Removed .flow_hidden margin again: what?! Removed #author styling, quite obviously a leftover from a very old version. (index.css, extra.rtl.css, sections.css)

! Post separators are there to separate posts. Yes. So there shouldn't be a separator AFTER the last post in a page... (Msg.template.php)

* Tweaked oldIE (and to a lesser extent, other browsers) positioning of status icons next to author names. (sections.css)
 1. Raphaël's first album, a gem of French pop-rock, which nobody heard. This song in particular is a classic. After his second album, he became a star in France and started releasing commercial crap. <Sad face.>
 2. Legend of Mana, by Yôko Shimomura. My favorite video game composer... And one of her best soundtracks.
 3. Moon, from Turn-A Gundam, by Yôko Kanno. Who else..?
Title: Re: New revs
Post by: Nao on March 16th, 2013, 04:59 PM
rev 2000 - Ranym-rano, da po nad chistym nebom, Podnimalosya oj da krasno solntse... / Rise my minions, from within the deep abyss my disciples, thunder this necropolis[1]
(10 files, 8kb)

* Tweaked media template. Added an extra layer to ease later styling. Removed the last remaining <input type="text"> and window.location entries. Harmonized the action bar with other action bars in Wedge (including the HTML stuff). Moved it below the picture, next to the contextual sidebar. This is only a WIP, as I'm planning to use a flexbox for this as well very soon. I'm still unsure about the direction I should take for 'Report' etc. pop-ups. Will probably rewrite the code entirely. Plus, I need to fix the 'close' button... (Aeva-Gallery.php, Media.template.php, media.css)

- Unneeded echo call. (index.template.php)

* Moved the search popup width hack up a level, to also prevent non-advanced_search elements from overflowing. Incidentally, this also saves 8 bytes... Go figure. (script.js)

! Fixed topic title alignment. (sections.css)

! Fixed search button styling inside search popup in Wine and Wuthering. Same is ready for Warm, but it's being worked on. (Wine/extra.css, Wuthering/extra.css)

* A small tweak in merge icon alignment. I'm not even sure it's needed... (Wine/index.member.css)

* Commenazi. (Warm/skeleton.xml)

:edit: Forgot to mention the files / size :^^;:
 1. And that's it... Princess Arete, and my favorite metal album. The decade was off to a great start ;) Hopefully it'll be the same for Wedge! Oh, and I promise I'll keep my quotes to a minimum now. I had plenty other albums to quote, but I don't think anyone cares but me anyway :lol:
Title: Re: New revs
Post by: Nao on March 17th, 2013, 12:57 AM
rev 2001 - Ce parfum de nos années mortes, ceux qui peuvent frapper à ta porte, infinité de destins : on en pose un, qu'est-ce qu'on en retient ? Le vent l'emportera...[1] / The variations we will find in space are almost infinite...[2] / Maybe I'm wrong, dreaming of you, dreaming the lonely night through... If it's a crime, then I'm guilty, guilty of dreaming of you.[3] / Why should I suffer for things that I never saw ? And if you know which way to follow, my soul's emotions I'll give you...[4] / Que voy a hacer je ne sais pas, que voy a hacer je ne sais plus, que voy a hacer je suis perdu, que horas son mi corazón...[5]
(15 files, 5kb)

* From now on, Wess will always imply that common.css (and its children) are included by default in each and every CSS file compiled by it. Which in turn allows you to use all of the virtuals defined in commons without having to wonder whether to include an extra file or not. An example is given in media.css... (install.php, Admin.php, Class-Editor.php, Load.php, ModerationCenter.php, Subs-Cache.php, media.css)

+ Added new Wess color function: stronger(). It acts as an alias to darker() or lighter(), depending on the current color's brightness. This will help you craft a custom color that stands out compared to other elements, whatever the current skin's palette is (dark or light). (Class-CSS.php)

* Renamed Wess some color functions, many for logical and spelling reasons: darken to darker, lighten to lighter, saturize to saturated, desaturize to desaturated. Also finally found a use for desaturated, ah ah. (Class-CSS.php, common.css, index.css, sections.css, Wine/common.css, Wine/extra.css, Warm/extra.css, Wuthering/extra.css)

! Fixed sidebar's search box in Warm. (Warm/extra.css)
 1. Noir Désir
 2. Children of Space, Jean Michel Jarre + vocals by Arthur C. Clarke (yes, that was in 2001.)
 3. 'Guilty', Al Bowlly, in 'Amélie Poulain'
 4. On Thorns I lay, 'Angeldust'. Not their best album, but 1999/2000 were crowded in the metal area and I can't forgive myself for forgetting them ;)
 5. Me gustas tu, Manu Chao. The same guy who guest-played guitars on 'Le vent l'emportera', first song in this list...
Title: Re: New revs
Post by: Arantor on March 17th, 2013, 04:02 AM
(6 added, 6 modified, 79KB)

Revision: 2002 - "All of my songs can only be composed of the greatest of pains / Every single verse can only be born of the greatest of wishes / I wish I had one more night to live"[1]
Author: arantor
Date: 17 March 2013 02:49:21
Message:
+ Notification system courtesy of Dragooon's BSD code, thank you :) (all files)
----
Added : /trunk/Sources/Class-Notification.php
Added : /trunk/Sources/Class-Notifier.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Added : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/Profile.php
Added : /trunk/Themes/default/Notifications.template.php
Added : /trunk/Themes/default/languages/Notifications.english.php
Added : /trunk/Themes/default/scripts/notifications.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/root/install.sql
 1. Century Child was an epic album. Marco Hietala's first, and bringing up The Phantom of the Opera...? DAYUM. But this is from Beauty of the Beast, rather than Phantom. It seems to encapsulate a few things.
Title: Re: New revs
Post by: Arantor on March 17th, 2013, 05:10 AM
(5 files, 2KB)

Revision: 2003 - "And I know you feel the same / I've wondered all my life, if this moment comes / Would I know what to say? / Then you say nothing at all"[1]
Author: arantor
Date: 17 March 2013 04:06:03
Message:
! SQL doesn't like text columns having a default value. (install.sql)
! Notifications was using the wrong variable. (Notifications.php)
! Language page now has caching, just for Nao. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/root/install.sql
 1. And you said nothing at all, well I couldn't have said it better myself. Tonight the conversation takes the fall, just love me like you love nobody else. DAMN, Meat Loaf, just... Couldn't Have Said It Better. First ML show I went to see was this tour. Good times.
Title: Re: New revs
Post by: Arantor on March 17th, 2013, 06:15 AM
(38 files, 9KB)

Revision: 2004 - "A siren from the deep came to me / Sang my name, my longing / Still I write my songs about that dream of mine / Worth everything I may ever be"[1]
Author: arantor
Date: 17 March 2013 05:11:44
Message:
! Syntax error in the installer table, oops. (install.sql)

! There really is no reason to load $language as a global. There is absolutely no need that I can see for it being a global because even the error handling will fail to do anything differently whether it's available or not prior to $settings being loaded, so might as well. This does also make other things possible, like changing the default language without having to hack up Settings.php at all. I don't think anything broke - and there's a fallback in Load.php just in case of not-defined. I also tested the installer, which still fails to load JavaScript because of some error, but too tired to debug it properly now. But it does the tweaked language stuff right. (all files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/root/Settings.php
Modified : /trunk/root/Settings_bak.php
Modified : /trunk/root/install.php
Modified : /trunk/root/install.sql
 1. Holy hell. This song is the first Nightwish song I ever heard, and it still moves me, possibly more than anything else they've ever done. 2004's "Once" album has a long to answer for, hahahahaha. Though if pushed, I would probably argue Imaginaerum (the instrumental title track from their 2011 album) moves me almost as deeply.
Title: Re: New revs
Post by: Arantor on March 17th, 2013, 06:38 AM
(3 files, 2KB) Quick bug fixes before bed.

Revision: 2005 - "Do you know like we were sayin'? About the Earth revolving? It's like when you're a kid. The first time they tell you that the world's turning and you just can't quite believe it 'cause everything looks like it's standin' still. I can feel it. The turn of the Earth. The ground beneath our feet is spinnin' at 1,000 miles an hour and the entire planet is hurtling around the sun at 67,000 miles an hour, and I can feel it. We're fallin' through space, you and me, clinging to the skin of this tiny little world, and if we let go... That's who I am."[1]
Author: arantor
Date: 17 March 2013 05:32:19
Message:
! Another thing broken by my crazy language edit: default language can be set in two places. Haven't decided which I want to keep yet. (ManageLanguages.php)
! Comment was a touch out of date, heh. (Class-DB.php)
! Flags weren't shown; inline-block is a mixin not a direct extensible thing. (Subs-Cache.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Subs-Cache.php
 1. I couldn't find a good music reference but... IT'S DOCTOR WHO.
Title: Re: New revs
Post by: Nao on March 18th, 2013, 05:34 PM
rev 2006 - It hurts to feel, it hurts to hear, it hurts to face it, it hurts to hide... / Television rules the nation... (bis repetita.) / It was me on that road. But you couldn't see me, too many lights out, but nowhere near here. / In the whole of the soul of Count Olaf, there's no love. When you see Count Olaf count to zero, then screeeeam and run away. / Je nous vois tous assis devant. Mais le front baissé, les épaules en dedans. Avec dans les yeux toutes les larmes d'avant.[1]
(33 files, 36kb)

* Clean-up job. Removed extra spaces, unneeded string concatenations, turned 4-space tabs into proper tabs, fixed a couple of British strings in the language files, etc. Note to Dragooon: please ensure your text editor uses tabs, not spaces ;) (index.php, Class-JSON.php, Class-Notification.php, Class-Notifier.php, Load.php, Mailer.php, ManageMaintenance.php, Notifications.php, Notify.php, Split.php, Subs-Membergroups.php, SSI.php, Display.template.php, index.template.php, Media.template.php, Notifications.template.php, Thoughts.template.php)

* Optimized notifications JavaScript and HTML for size and elegance, the usual Nao way. (Notifications.php, Notifications.template.php, notifications.js)

* Renamed WeNotif to weNotif. Wedge classes are named 'wexxx', so I'll just allow for the second ucfirst, but not the first. Also fixed 'initialise' method to read 'initialize'. I love British English, but our codebase just is American English-based. (index.php, Class-Notification.php, Class-Notifier.php, Load.php, Notifications.php, Profile.php)

@ A message for anyone providing JS code to Wedge (in this case, Dragooon). Please follow our conventions :) Okay, my conventions! It'll save me time later ;)
  - Also, one convention I inaugurated in Wedge is to only use '$var' variable names for jQuery objects, not regular strings/ints/bools.
  - return false instead of e.preventDefault and e.stopPropagation,
  - use <URL> instead of $scripturl, where possible,
  - use weUrl() instead of we_script,
  - use $.now() instead of +new Date() or whatever variation.
  - 'document.location' is also an error, it's a property of the window object. Which implies one can just strip it down to 'location'.
  - Also, custom event data: that's a very neat feature, but my tests show that it doesn't help with compression, and more importantly, you don't need to save variables that are in the parent scope. They're still available in the event! So there's no need to store them, AFAIK.
  - I have to admit I haven't tested the results, but the resulting JS file is nearly half the size of its original commit's. Less than 700 bytes...
 1. Okay, in order: Archive, Daft Punk, Royksopp, Daniel Handler (aka Lemony Snicket), Yann Tiersen.
Title: Re: New revs
Post by: Arantor on March 19th, 2013, 05:22 AM
(3 files, 1KB)

Revision: 2007[1]
Author: arantor
Date: 19 March 2013 04:18:59
Message:
+ Language editing works. Doesn't work for plugins, but otherwise it works. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


@ It's not pretty but it works as far as I can tell. I have to admit I'm not very happy, nor very proud of this, it's kind of ugly. And it can't even sanitise content - because raw HTML does get used in some strings and there's not a lot we can do that about.
 1. Did you ever hear what I told you?
Did you ever read what I wrote you?
Did you ever listen to what we played?
Did you ever let in what the world said?
Did we get this far just to feel your hate?
Did we play to become only pawns in the game?
How blind can you be, don't you see?
You chose the long road, but we'll be waiting

Bye Bye Beautiful, from Dark Passion Play, 2007
Title: Re: New revs
Post by: Nao on March 19th, 2013, 09:19 AM
Woohoo above ^

rev 2008 - Yeahhhh, shall I cut you down... Yes 'twould be a last physical communion, I'll be gentle! I'll be gentle! I'll be gentle! I'll be gentle![1] / Komonangayo Bandeko Makila Mabe Oyo...[2] / Sublime... Pour moi, c'était sublime.[3] / Tududum, tududum.[4]
(33 files, 7kb)

* I don't know why I was putting up with regex replacements in Wess's comma protection, when I could have just gone for a str_replace... (Class-CSS.php)

* Changed all files to americanize British endings (optimise, sanitise, colour, etc.) I'm not touching WedgeDesk though, as it's 100% Pete's thing, and maybe he wants to wave the British flag with pride on it. Or something ;) An important change is that I renamed wedit::legalise_bbc to legalize_bbc, and I couldn't be certain that the word 'legalise' isn't commonly used in the US. (30 files -- do they need listing..?)

! Missing $settings global in $language rewrite. (Are there other..? I only fixed the one I found in my error log.) (Subs.php)

* Commenazi. (index.php)
 1. Comus, 'Drip Drip', 1972. I missed that year but they performed it live in 2008 and it was recorded on an album so I'm using the opportunity, eh eh. As for the lyrics, they're a parody, don't be scared, I just happen to love the way the guy sings it! :lol: http://fox.noisen.com/4841/comus/
 2. These lyrics are totally my guess, I don't speak a word of Congolese and lyrics can't be found online... It's from Shadow by Papa Wemba, in Peter Gabriel's "Big Blue Ball", my favorite album of his since one of my two all-time favorite soundtracks, "The Last Temptation of Christ", in 1988. Which I, oddly, forgot to mention back in rev 1988. My other favorite soundtrack, even more oddly, is Shinku no Shônen Densetsu, a Saint Seiya movie, which was... my choice for rev 1988. That was a pretty good year for instrumental music...!
 3. Christophe[1], 'It must be a sign', in his beautiful "Aimer ce que nous sommes" album. I must also mention that it was his last album until yesterday, when he released a new one. I must get it!
 1. Whom you may know from a song in Kill Bill... I guess not! It was only an instrumental.
 4. Well, have nothing better to offer for The Dark Knight!
Title: Re: New revs
Post by: Arantor on March 19th, 2013, 03:02 PM
(2 modified, 2 added, 15KB)

Revision: 2009[1]
Author: arantor
Date: 19 March 2013 14:01:46
Message:
+ English UK has landed. I will go through all the other files in time, to see what there is to be changed, but right now this is the only thing. Oh, and I don't even think the Info Centre string is used now anyway. (Flag.english-uk.png, index.english-uk.php)

! loadLanguage now bypasses the old switch-language callback and just loads English first before the other language, then caches the combined result. (Load.php)

! I don't like your accent, sir! (EmailTemplates.french.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Added : /trunk/Themes/default/languages/Flag.english-uk.png
Added : /trunk/Themes/default/languages/index.english-uk.php
 1. I have no pop culture references for 2009 :sob:

:edit: by Nao: which means I totally get to hijack your rev then!! :niark: I want to take you away with my feelings, and look you up till the highs of the Sun...[1] / Cast a revelation for the time of day, eventual panic attacks me. But I come back with a new determination. Knock wood, street solid rock, clock tick a time.[2] / I wanna go, go go, go right back again. I wanna give, give, give, give you everything.[3]
 1. This is was I managed to decypher, no lyrics available anywhere, and it has a lot of bass in it... Highs of the Sun, in "Institute of Joy", by A Mountain of One. Best pop-rock band of recent years -- and they split up since. :(
 2. Thought Conditioning, a great hip hop song from Archive's 2009 opus.
 3. And my favorite pop-rock song of that year... I can listen to it in loops. For hours. The last part is genius. It's "True to Life", by Royksopp.
Title: Re: New revs
Post by: Nao on March 19th, 2013, 06:29 PM
rev 2010 - I kept dreaming of a world I thought I'd never see. And then, one day... I got in.[1] / Jeo haneur wi nunmullo geurin baramui soksagim gubigubi ttaraga geu soge jamdeunda...[2] / (...)[3] / À la belle étoile... Quelques étoiles fuyantes, et toi la bonne étoile.[4]
(7 files, 6kb)

! Finally fixing that undefined index error in QuickMod... Never really knew why it occurred, but there are more important things in life. (QuickMod.php)

! Ah, the joys of automatic replacements eh, Pete...? ;) Fixed $settings['language'] (the entire variable) being globaled several times... (Subs-Post.php)

! Fixed indenazi function for lines starting with text. My original intent was to prevent <pre> code from being indented, but then I realized that Wedge adds spans to them instead of just showing tab characters, so... (Subs-Template.php)

! Fixed reqWin('url string') not working since the jQuery update. I wouldn't recommend doing that, though... Also removed a couple of workarounds that were no longer necessary. Saved 7 bytes all in all. (script.js)

* Translation. Partial for notifications, I stopped in the middle to fix the English version and, one thing led to another... I'll finish it next time. (ManageSettings.french.php, Notifications.language.php)

* Commenazi. (ManageLanguages.php)
 1. Daft Punk, 'Tron Legacy'.
 2. Jang NaRa, a beautiful song from 'Dong Yi', a Korean period drama. Same composer wrote 'Dae Jang Geum' back in 2003, my first (and favorite) Korean show. I wanted to quote him back then, but Pete took the spot :lol:
 3. Insert Sugizo song quote here. Damn, can't find lyrics... He released some damn good singles that year. He's the guitarist for Luna Sea and X Japan, my favorite J-Rock bands, their best composer as well, a very gifted arranger, he works with Origa (who sang the Russian songs in Princess Arete in 2000), and is also a member of Juno Reactor... What's not to like?
 4. La belle étoile, in 'Les saisons de passage' (Mathieu Chédid). Best live/rock album of the year for me... You should listen to some French music guys -- it rocques!! :D
Title: Re: New revs
Post by: Arantor on March 19th, 2013, 09:12 PM
(4 added, 2 modified, 4KB)

Revision: 2011[1]
Author: arantor
Date: 19 March 2013 20:07:45
Message:
! Spacinazi. (Agreement.english.php)
! Proper conjugation is *so* important, don't you think? (Errors.english.php)
! More English UK translations but that's enough for now. (Admin, Agreement, EmailTemplates, Errors language files)
----
Added : /trunk/Themes/default/languages/Admin.english-uk.php
Added : /trunk/Themes/default/languages/Agreement.english-uk.php
Modified : /trunk/Themes/default/languages/Agreement.english.php
Added : /trunk/Themes/default/languages/EmailTemplates.english-uk.php
Added : /trunk/Themes/default/languages/Errors.english-uk.php
Modified : /trunk/Themes/default/languages/Errors.english.php
 1. It's a long road down the river deep and wild,
Every twist and turn a wonder-dale,
It's a scary ride we'd give anything to take,
Let yourself bleed,
Leave a footprint on every island you see...

Ghost River - Nightwish's "Imaginaerum". Fantastic album.
Title: Re: New revs
Post by: Nao on March 20th, 2013, 07:05 PM
rev 2012 - D'you like this music?[1] / I'm breakin' a sweat, it's all right. I'm breakin' a sweat! Come on baby light my fire.[2] / Who are you Mr. Blue, Mr. Blue Mr. Blue? How do you do Mr. Blue, Mr. Blue Mr. Blue?[3]
(5 files, 1kb -- oh, come on..??!!)

! Notification hook was sending the wrong variable. (Class-Notification.php)

! afterNotify method expected Notification object, was sent an array of Notification objects. Changed the declaration to expect an array. (Class-Notifier.php)

* Renamed ;area= to ;sa= in notification action (these are really sub-actions, not areas...), and ;id= to ;in=, to avoid the infamous (but probably quite rare) security protection against these. (Notifications.php)

* Finished notification translation. FWIW. (Notifications.french.php)

* Another remaining location.href needed to be reduced. (install.php)
 1. That's pretty much the only lyric in that song, ah ah... It's from SQ Party #3's Live set by the Stealth Boys. A remix of Chrono Trigger and other Square soundtracks. If you like these, go check it out! http://www.youtube.com/watch?v=Qa7wYR3mUjg
 2. I didn't know of this guy till a few weeks ago... So, apparently everyone hates him and he's a boys band or something like that. Still, I love that lesser-known song which I heard by chance, "Breakn' a sweat", from Skrillex. Probably because it reminds me of SQ Party..?! From what I've read, the SQ Party albums have plenty of dubstep in them. So, for the first time in like 20 years, am I actually liking a *current musical trend*..? I'm finished!
 3. And that would be my favorite rap/funk album of 2012... Hopefully a nice new trend in France -- 70's-inspired funk albums with English vocals, anoother example being the excellent G'S WAY released in 2011. Also, Roberto Fonseco's "Yo" album has great funk songs.
Title: Re: New revs
Post by: Arantor on March 21st, 2013, 02:53 AM
(14 modified, 1 added, 30KB)

Revision: 2013[1]
Author: arantor
Date: 21 March 2013 01:50:45
Message:
! Minor accuracy fixes and a couple of legacy strings, including English UK translation. (Help language file)

! We don't want no raw >, thanks. (Help, Notifications language files)

! Profile / Show Posts (and Topics) now shows like count for displayed posts. (Profile-View.php, Profile.template.php)

! Profile areas will disregard board-access permissions when a user is viewing their own posts. There is no reason for a user not to be able to see their own posts - they wrote them, after all. But if possible, the posts will not be linked to, and the user shouldn't have permissions for those boards anyway. (Profile-View.php, Profile.template.php)

! Users can now select to ignore another user directly from thread view. Not AJAXively, sorry, but not bad. (Display.php, Profile-Modify.php, index language file)

! There is no good reason to embed the main site into a frame or iframe on another domain. SSI should not be included, of course, because cross-origin requests could conceivably be made there legitimately. (QueryString.php)

! phpinfo() displayed in admin panel. I'm inclined to think some of the superglobal values should be pruned because they are meaningless in that specific context (e.g. URL used to get to the page) (Admin.php, ManageServer.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Added : /trunk/Themes/default/languages/Help.english-uk.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Modified : /trunk/Themes/default/languages/index.english.php
 1. I got no lyrics for this year, haven't heard a 'new' song I like yet.
Title: Re: New revs
Post by: Arantor on March 21st, 2013, 08:05 PM
(12 added, 18 modified, 24KB)

Revision: 2014
Author: arantor
Date: 21 March 2013 19:04:12
Message:
! Missing static variable. (Display.php)
! Fallback measures weren't quite correct in language loading in the event of certain combinations of default language. (Load.php)

! Required custom fields on the registration page should include required field indication. (Profile.php)

! While we're on the subject, CAPTCHA and question fields should also be indicated as required to the browser. Yes: competent browsers won't even send the page off the first place until these are filled in, which might save some page requests. (GenericControls.template.php)

! No point indicating the rel="search" if the user can't see it. (index.template.php)

! Legacy strings go bye-bye. (Error, Login language files)

! Accuracy tweaks (Install, ManageMaintenance language files)

! Oops, missed some other things that should have been entitised. (Notifications language file)

! 'New posts while you were...' warnings should have been number-context strings. (Post.php, Post language file)

! More UK translation. Some of these are ugly placeholders, bah. (*.english-uk.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Added : /trunk/Themes/default/languages/Install.english-uk.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Added : /trunk/Themes/default/languages/Login.english-uk.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Added : /trunk/Themes/default/languages/ManageBans.english-uk.php
Added : /trunk/Themes/default/languages/ManageBoards.english-uk.php
Added : /trunk/Themes/default/languages/ManageMail.english-uk.php
Added : /trunk/Themes/default/languages/ManageMaintenance.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Added : /trunk/Themes/default/languages/Modlog.english-uk.php
Added : /trunk/Themes/default/languages/Notifications.english-uk.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Added : /trunk/Themes/default/languages/Post.english-uk.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Added : /trunk/Themes/default/languages/Settings.english-uk.php
Added : /trunk/Themes/default/languages/Stats.english-uk.php
Added : /trunk/Themes/default/languages/Who.english-uk.php
Title: Re: New revs
Post by: Arantor on March 21st, 2013, 11:48 PM
(6 modified, 18 added, 41KB)

Revision: 2015[1]
Author: arantor
Date: 21 March 2013 22:42:32
Message:
! I forgot that the installer doesn't normally load English as a fallback - but now it does, especially in case of other languages that don't have a complete language pack. On top of that, (crudely) display the flags to users when selecting their language, updating the mapping of Accept-Language to language packs, and fix the fact that the installer wanted jQuery 1.5.2 but that the selectbox needs a higher version, and just for fun, actually display the language's *name* rather than its internal code to users. (install.php)

! I have no idea why the expiry date is 1997 except for it's the date used on the PHP example page. Set it to something a little more... appropriate. (current-version.php, install.php, Errors.php, Subs-Template.php)

! Accuracy update. (ManagePlugins language file)

! Hopefully the rest of English UK (*.english-uk.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Subs-Template.php
Added : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Added : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Added : /trunk/Themes/default/languages/ManagePaid.english-uk.php
Added : /trunk/Themes/default/languages/ManagePermissions.english-uk.php
Added : /trunk/Themes/default/languages/ManagePlugins.english-uk.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Modified : /trunk/Themes/default/languages/ManagePlugins.french.php
Added : /trunk/Themes/default/languages/ManageScheduledTasks.english-uk.php
Added : /trunk/Themes/default/languages/ManageSettings.english-uk.php
Added : /trunk/Themes/default/languages/ManageSmileys.english-uk.php
Added : /trunk/Themes/default/languages/ManageTopics.english-uk.php
Added : /trunk/Themes/default/languages/Media.english-uk.php
Added : /trunk/Themes/default/languages/ModerationCenter.english-uk.php
Added : /trunk/Themes/default/languages/Packages.english-uk.php
Added : /trunk/Themes/default/languages/PersonalMessage.english-uk.php
Added : /trunk/Themes/default/languages/Profile.english-uk.php
Added : /trunk/Themes/default/languages/Reports.english-uk.php
Added : /trunk/Themes/default/languages/Search.english-uk.php
Added : /trunk/Themes/default/languages/Security.english-uk.php
Added : /trunk/Themes/default/languages/Themes.english-uk.php
Modified : /trunk/other/xml/current-version.php
Modified : /trunk/root/install.php
 1. The time-traveling is just too dangerous. Better that I devote myself to study the other great mystery of the universe: women! (I couldn't let 2015 go by without a BTTF reference!
Title: Re: New revs
Post by: Arantor on March 22nd, 2013, 04:41 AM
(4 files, 4KB)

Revision: 2016
Author: arantor
Date: 22 March 2013 03:40:59
Message:
! Ancient crusty bits in the styling. (ManagePlugins.template.php)

! Display likes in the recent-posts page too. (Recent.php, Recent.template.php)

! On the standard home page, link the board names to their boards for the 'recent posts' bit, it's bugged me for ages. (Home.template.php)

! Notifications should declare a page title where it needs one. (Notifications.php)
----
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Themes/default/Home.template.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/Recent.template.php
Title: Re: New revs
Post by: Arantor on March 23rd, 2013, 05:22 AM
(36 files, 17KB)

Revision: 2017
Author: arantor
Date: 23 March 2013 04:20:22
Message:
! Syntax error I added back in October 2011, complete with commit note of 'not tested'. And guess what, it still isn't tested, but I found a syntax error anyway that needed fixing! Yeah, shows you how often we test the COPPA form. (CoppaForm.php)
! PayPal language should be deferred back to the language files. (Subscriptions-PayPal.php, index language files)
! add_linktree use pretty much everywhere. (everything else)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Pin.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Themes/default/languages/index.english-uk.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Nao on March 24th, 2013, 04:02 PM
rev 2018 -- woohoo, no more references! :P Back to quick descriptions of my changes...
(12 files, 44kb, mostly spaces-to-tabs in install.sql)

* Updated notification code to use the data field in the members table. Thanks Dragooon! (install.sql, Class-System.php, Notifications.php,

! Notifications markAsRead wasn't using the proper $id_member variable. Thanks myself! (Class-Notification.php)

* Harmonized notifications to use returnAjax(), for consistency. And because that's shorter. ;) (Notifications.php)

* All sorts of Naoisms -- spacinazi, indenazi, commenazi, bytenazi, you name it. Also fixed $context['skeleton'] to be initialized as an array, as pointed out by John. (Class-UnitTest_tidyhtml.php, install.sql, Class-FTP.php, Load.php, Display.template.php, ManageLanguages.template.php, Who.template.php, respond.js, suggest.js)
Title: Re: New revs
Post by: Arantor on March 24th, 2013, 06:51 PM
(5 files, 12KB)

Revision: 2019
Author: arantor
Date: 24 March 2013 17:51:13
Message:
! Die, Simple Permissions, DIE. Yes, that's right, we have 'Classic Permissions'. Only it's just 'Permissions' now. There's more stuff to do but this is where it begins. (ManagePermissions.php, ManagePermissions.template.php, plugin-info.rng, ManagePermissions language files)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on March 25th, 2013, 08:12 PM
rev 2020 -- and I'd like to point out that if I'd committed rev 2019, I'd have made a reference to both Akira and Blade Runner, but alas it was not to be... :P
(8 files, 4kb)

! Fixed Wess parsing of calc() to actually add prefixes if needed... Also made the search process looser, as we don't really need to force a particular string end. (Class-CSS.php)

! Fixed a remaining reference to a removed field. (Class-Notification.php)

* Spacinazi. (ManageBans.php, ManageLanguages.php, Notifications.php, ScheduledTasks.php, Security.php, ManageLanguages.template.php)
Title: Re: New revs
Post by: Nao on March 26th, 2013, 12:19 AM
rev 2021
(3 files, 4kb)

! Last rev's fix was overwriting the $data parameter in the issue() method. (Class-Notification.php)

! Fixed another use of ;id= which, as I said, may sometimes be forbidden by mod_security. Or is that a thing of the past..? (Notifications.template.php)

! Fixed $member[$row['id_member']], should have been $members[$row['id_member']] instead... Notice the extra 's'. This probably prevented scheduled tasks from working... (Notifications.php)

! Notification e-mail template was calling weNotif::getNotifie instead of weNotif::getNotifiers... (Notifications.template.php)

* Small clean-up... No need to call loadSource() twice in a row, just provide an array of source filenames. Removed some extra $scripturl's. Avoid self-referencing a static object by using its full name, use 'self' instead. Renamed some variables to avoid further confusion (and potential reference overrun... If you know what I mean. Never re-use a variable that was set as a reference earlier. I learned it the hard way long ago.) (Notifications.php)

@ Also, err... Should this notification e-mail template REALLY spit out HTML code...?! (Notifications.template.php)
Title: Re: New revs
Post by: Arantor on March 27th, 2013, 03:10 AM
(14 modified, 1 added, 10KB)

Revision: 2022
Author: arantor
Date: 27 March 2013 02:09:16
Message:
! Break styling for contacts/hidden out of the old way and use icons by the name instead for online lists. You will likely want to shorten the naming, which is fine, heh. (Subs-MembersOnline.php, Display.template.php, InfoCenter.template.php, MessageIndex.template.php, sections.css) :edit: And hidden.png.

! Weekly maintenance should check for missing .htaccess and index.php files, and regenerate them if appropriate, related to SMF bug 4965. (ScheduledTasks.php)

! Globanazi: we're not using $sourcedir any more for cache flagging. (Subs-Cache.php)

! Sort order for spiders online is often wrong, related to SMF bug 4930. (Subs-MembersOnline.php)

! Stats couldn't still be accessed even if disabled, SMF bug 4742. (Stats.php)

! Pruning attachments without leaving a deleted message could have an SQL error, SMF bug 4818. (ManageAttachments.php)

! SMF bug 4902: subscriptions handler can provide output without proper content encoding. SSI should not be influencing headers however. (subscriptions.php)

! SMF bug 4857: unlocking a post from the additional options would not log it properly in the moderation log. (Post2.php)

! SMF bug 4555: censored word description didn't fit the behaviour on the page. Also fixed bare > in the template, which is even in 2.0.4 and AFAIK isn't legal XHTML *whistle* (Admin.template.php)

! SMF bug 4669: plugin enabling/disabling was not logged. (ManagePlugins.php, Modlog.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/hidden.png
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/subscriptions.php
Title: Re: New revs
Post by: Arantor on March 27th, 2013, 04:42 AM
(6 files, 4KB)

Revision: 2023
Author: arantor
Date: 27 March 2013 03:40:40
Message:
! Only update the notifications count if there are people to notify. (Class-Notification.php)
! Harmonise area vs sa in the URLs. (Notifications.template.php, notifications.js)
+ Support for notifying people about their posts being liked. I don't know how rugged it is, it feels a touch hacky to me, but I don't see how else to do it as a core feature at this time, without bootstrapping it as a plugin. (Like.php, Notifications.php, Notifications language file)
----
Modified : /trunk/Sources/Class-Notification.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Themes/default/Notifications.template.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/scripts/notifications.js

:heck: And I forgot to upload a file with this. Dumbass that I am.
Title: Re: New revs
Post by: Arantor on March 27th, 2013, 04:43 AM
(1 file, 4KB)

Revision: 2024
Author: arantor
Date: 27 March 2013 03:42:50
Message:
! Missing file from r2023. I clearly need more tea. (Class-NotifierLikes.php)
----
Added : /trunk/Sources/Class-NotifierLikes.php
Title: Re: New revs
Post by: Nao on March 27th, 2013, 10:10 AM
rev 2025 -- Wess bug fixes.
(1 file, 3kb)

! In some situations, calling @if/@endif in CSS code would crash Wedge. After a painful debugging session, I discovered that I could either force php.ini's pcre.recursion_limit to something sensible in Windows (which was compiled to have a very small recursion stack, unlike Linux versions) and then use preg_last_error() to catch recursion errors, or... I could simply use my Goddess of All Regex trick. That's the name I gave (in reference to one of Karl's expressions) to the atomic grouping hack that I cooked up something like 5 years ago, and that sealed my descent into the abyss of PHP programming and regex madness. That's it: turning a simple '(?:' into '(?>' was enough to make Wess behave. I considered using it in the @is handling code path as well, but it's probably useless because inline code is generally extremely short and doesn't suffer from backtracking issues. (Class-CSS.php)

! Opera 12.1+ supports the new flex model, but it's buggy. To be specific, sometimes divs will overflow out of their defined boundaries, and I couldn't find any workarounds for that, unlike Firefox and Chrome quirks I met during development. Because I'm now using a Chrome fork as my main browser, and my beloved Opera will switch to WebKit later this year, I don't think it's worth the hassle, so I'm removing Opera from the list of browsers aliases by the 'can_flex' constant. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on March 27th, 2013, 10:11 AM
rev 2026 -- short, thematic commits help me clear my head.
(1 file, 3kb)

! Fixed fallback layer/block selection in Wess. For those interested, here are some details... Doing something like wetem::before(array('sidebar', 'default'), 'my_block') would work because both items (sidebar and default) are layers. However, wetem::before(array('target_block', 'target_layer'), 'my_block') would always select the fallback layer even if target_block existed, because layers had priorities in my code. This is due to the refactoring I made to the skeleton code back in late 2011. At the time I wrote the find() function, the skeleton system just wasn't strong enough to accomodate for this. Now it is. And it allows me to remove that weird code block with all the iterator objects. Which are incredibly, horribly slow according to a quick benchmark. (Class-Skeleton.php)

* Optimized weSkeleton->has() for speed, if used on a layer. (Class-Skeleton.php)
Title: Re: New revs
Post by: Nao on March 27th, 2013, 10:22 AM
rev 2027 -- nearly 1000 revisions after I personally introduced that huge bug...
(7 files, 2kb)

! Fixed 'new posts' warning not triggering when replying from the full Post page. This annoying bug really annoyed/bugged the hell out of me for months, until I realized yesterday it was all my fault, so: sorry guys, I'm bad. I forgot to rename a few 'last_msg' occurrences to 'last'. (Display.php, Post.php, SSI.php, MessageIndex.template.php, Post.template.php, Xml.template.php, post.js)
Title: Re: New revs
Post by: Nao on March 27th, 2013, 10:28 AM
rev 2028 -- a selection of smaller fixes. Just because they're small doesn't mean they should be ignored. Especially the eye.
(5 files -1, 3kb)

! The language links were silly. They thought a language couldn't have dashes in it. English-uk just proved them wrong. They apologize for any inconvenience, as well as infinite ;language=...;language=... links. It was fun while it lasted. (index.template.php)

* Quotenazi. Will do more of these soon enough... (index.template.php)

* Spacinazi. Harmonized code to Wedge standards: we do "$ref =& $var", not "$ref = &$var", even though it's technically the same. Semantically, "=&" means to me "assign by reference", so it's more readable that way. Hence the standard. (Profile-Actions.php, Subs-Plugins.php)

* Typonazi. Or Commenazi. Whatever you like best. (Class-Notification.php)

* Optimized hidden.png file for size (saves nearly 200 bytes). I'm still not a big fan of this icon... I'm sure it's under my bed it's hiding. It watches me at night. With a grin. On its mouthless face. #MommyImScaredIDontWannaSleepAlone (hidden.png)

- Removed spell.png file... As far as I know, it's not in use anymore. Life is good. (Except when the hidden.png eye is watching, of course.) (spell.png)
Title: Re: New revs
Post by: Nao on March 27th, 2013, 11:48 AM
rev 2029
(4 files +1, 4kb)

+ All touch-enabled devices will now get automatic quote splitting for free. As they don't have a Shift or Ctrl key to use along with Enter, it only makes sense, especially given how hard it is to make quotes in mobile mode. Heck, this suddenly makes quoting messages possible in Android, iOS and whatever. Thanks Dragooon for the suggestion! (editor-func.js)

* Because the registration agreement is a special language string that's explicitly parse_bbc'd, I turned its HTML tags (double line-breaks) into actual line-breaks. This also makes them easier to use them as base for your own registration agreement. If you're never heard about text wrap mode, of course. (Agreement.language.php)

* Missing file. Note that Home files are not supposed to be in the final distro, and that I'm sure I'll forget all about it soon enough, but whatever... (Home.english-uk.php)
Title: Re: New revs
Post by: Arantor on March 27th, 2013, 09:45 PM
(2 files, 2KB)

Revision: 2030[1]
Author: arantor
Date: 27 March 2013 20:44:07
Message:
! Some missing and slightly inaccurate who's online strings. (Who language file)
! Injected error information would be overlooked. Most useful for bans. (Who.php)
! Pretty URLs don't save the user id into the URL for profiles, so viewing any other user's profile would always fail in who's online. (Who.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/languages/Who.english.php
 1. I can't help but feel we should have had a Terminator reference by now.
Title: Re: New revs
Post by: Arantor on March 28th, 2013, 04:53 AM
(7 files, 6KB)

Revision: 2031
Author: arantor
Date: 28 March 2013 03:52:37
Message:
! Missed English UK translation. It's entirely possible there will be more. (Reports.english-uk.php)
! Group styling is now handled with CSS classes, dynamically pulled into index.css. It's all very magical. If you're very good, I might even extend this to include bold and italics and stuff. But only if you're very well behaved. (ManageMembergroups.php, Profile-Modify.php, Subs-Cache.php, Subs-Membergroups.php, Subs-Template.php, index.css)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/languages/Reports.english-uk.php
Modified : /trunk/Themes/default/skins/index.css
Title: Re: New revs
Post by: Nao on March 28th, 2013, 07:42 PM
rev 2032 -- notification updates. And also the year where Bubblegum Crisis starts...[1]
(9 files, 13kb)

+ Split loadMemberContext() into another function, loadMemberAvatar(), which can load a user's avatar and only that, if you don't need anything else, including expansive things like signature. (Load.php)

* Moved notifications bar to the header, with fallbacks to the sidebar and the main layer. (Notifications.php)

+ Added loadMemberData() to all notifications prior to showing them. This allows you to show an avatar next to the notifications. This is only temp code, as from what I gathered, Dragooon offered a patch to add proper support for issuers, meaning this will probably require tweaks. (Notifications.php)

* Updated notification code to optimize template size. There is more to come... But it implies committing more files, and I need to draw a line. So, in case you're wondering: if it's buggy, I'm probably already aware of it... (Notifications.template.php, index.css, notifications.js)

* Notification popup will now use proper relative positioning, instead of JavaScript-driven positioning. The notification JS is thus probably unrecognizable by now... The magic of Naoisms. It's also much, much shorter. By something like 100 or 150 bytes. I'll add Wess support for user-select later. It's in my to-do. (index.css, notifications.js)

* Notification CSS is member-only. Saves bytes! Also fixed things like ':parent'... (index.css)

* Moved some CSS around for logic reasons. And yes, it saves bytes, too... (index.css, sections.css, index.member.css)

* Translation, spacinazi. (Notifications.language.php)
 1. If I couldn't reference Blade Runner and Akira's 2019 setting, then at least I can reference the best Blade Runner clone ever released, made around the same time as Akira... Lucky me ;)
Title: Re: New revs
Post by: Arantor on March 28th, 2013, 11:53 PM
(4 files, 8KB)

Revision: 2033
Author: arantor
Date: 28 March 2013 22:51:22
Message:
! Silly linktree bug of mine. Only occurred in rare circumstances. (Subs.php)
! Plugin permissions oddities from my removal of the simple view. (ManagePermissions.php)
! Poll display should be separated out a bit. (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Title: Re: New revs
Post by: Nao on March 29th, 2013, 12:06 AM
rev 2034 -- avatar and notification fixes from rev 2032. Hopefully didn't forget anything...
(4 files, 2kb)

! Fixed a wrong test that preventing avatars from being shown at all in topic pages. (Load.php)

! And, hum, another minor bug prevented avatars from being re-filled when first calling loadMemberAvatar and THEN loadMemberContext. Not that I think this would happen normally, but I'd rather not take any chances. (Load.php)

! JavaScript retrieval of notification updates would break because of a wrong variable name, effectively emptying the popup (that's for anyone wondering why this would happen.) (Notifications.php)

! Some quick temp hacks to fix notification popup styling. (Notifications.template.php, index.css)

* Made $avatar_width and $avatar_height static. (Load.php)
Title: Re: New revs
Post by: Nao on March 29th, 2013, 09:56 PM
rev 2035
(7 files -2, 11kb)

+ weSkeleton()->rename() was a layer-only function. From now on, it can also rename blocks. Don't abuse it! (Class-Skeleton.php)

! add_plugin_css_file() is a bit broken. Notably, its param list was always added to the filename, instead of the elements actually used in the file. Until we do something better, I'm removing most of the (relatively useless) suffixes, like 'mod' and board/category/member ID. (Subs-Cache.php)

* Topic icons were missing some padding in the message index. I don't think that was voluntary... (sections.css)

* Optimized a few images for size, saving several hundred bytes in the process, without losing image quality. (quick_lock.gif, quick_my.gif, quick_pin_my.gif)

- Removed a few unused images -- these were from the old quickmod system. (quick_move.gif, quick_remove.gif)

- Hmm... I think Pete forgot to remove a code block after rewriting $context['error_new_replies'] to use number_context(). At least, it generated an error for me, and the variable wasn't used anywhere... (Post.php)
Title: Re: New revs
Post by: Nao on March 30th, 2013, 01:47 AM
rev 2036 -- woohoo, message index icon fixes :)
(10 files +1-4, 10kb)

* Rewrote the topic status icons in the message index (pinned, locked, poll, my).
  - Fixed poll icon to (finally!) show up... (MessageIndex.php, quick_poll.gif)
  - Now using a JS-generated span system to show them. Fixes positioning issues and allows for solo manipulation. (MessageIndex.template.php, topic.js)
  - Removed composite icons. This saves over 1500 bytes in the main gzipped CSS! (quick_*_*.gif)
  - Improved legend styling the sidebar. (MessageIndex.template.php, sections.css)
  - Harmonized Unread Posts and Unread Replies styling with Message Index. Lots of things... (Recent.template.php, sections.css)
  - Just want to point out that yes, the crap rules repeated in icon_* classes saves bytes, too. (sections.css)

* Naoisms. (Unread.php, UnreadReplies.php)

! Unread Replies feature didn't actually set the participation icon. YES, we know that it's always set, as the page name implies... But still, not showing it when there's a legend next to the change is awkward. (UnreadReplies.php)

! Fixed h6 tag styling. Was broken due to incorrect nesting. (index.css)

! Fixed 'move selection to...' board select box showing up even when not selected. This was due to the .hide class being too close to the beginning of the CSS file, giving it lower priority. Hmm... (index.css, sections.css)

@ Quick note: there are three files only in the images/topic folder. Technically, they should be moved to images/icons... I'm too tired to deal with that.
Title: Re: New revs
Post by: Arantor on March 30th, 2013, 04:12 AM
(3 modified, 2 added, 4KB)

Revision: 2037
Author: arantor
Date: 30 March 2013 03:10:49
Message:
! Feeds should not include MOVED topic notices. (Feed.php)

! Another bug of mine in Who's Online. (Who.php)

! Finally putting in icons for all the buttons along the moderation-options in a topic. Been meaning to find icons for the last two, in the end I just resized two of the icons deleted today. small_move in particular is ugly because I suck at resizing images in GIMP. (index.member.css, small_delete.gif, small_move.gif)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Who.php
Added : /trunk/Themes/default/images/small_delete.gif
Added : /trunk/Themes/default/images/small_move.gif
Modified : /trunk/Themes/default/skins/index.member.css
Title: Re: New revs
Post by: Nao on March 30th, 2013, 02:28 PM
rev 2038
(4 files, 3kb)

! Fixed smiley caching... AGAIN. I noticed that clean_cache was overzealous, and would delete all variations of a file because of the special css codebath. Wedge now bypasses this by letting the extension start with a dot. Ah ah. Used the opportunity to shorten the filenames to use a 3-digit ID instead of a full timestamp. (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)

- Debug code. Oops! That never happens to me... (Class-Skeleton.php)
Title: Re: New revs
Post by: Nao on March 30th, 2013, 02:49 PM
rev 2039 - a byte is a byte is a byte.
(9 files -2, 3kb)

* Optimized moderation button CSS declarations for bytesize and better positioning. Renamed moderationbuttons to modbuttons (everyone gets what it means, right..?), and got rid of this odd moderationbuttons_strip, which is just as easily accessed by '#modbuttons ul'... Also simplified template_button_strip to accept an $extra param instead of an array of options. I've double-checked all calls to TBS, and couldn't find a single use of these options except for the moderationbuttons_strip ID setting I was talking about. I could remove the $extra as well, but figured some plugins might find it helpful (you can still do $extra = 'id="my_id"'). (Display.template.php, index.template.php, topic.js, index.member.css, sections.css, Wine/extra.css, Wine/index.member.css, Wuthering/extra.css, Wuthering/index.member.css)

* Shortened small_move.gif from 305 bytes to 125. I'd actually brought it down to 100 bytes, but it didn't compress as well (took 3 more bytes than the 125-byte version). Go figure! I knew I had to compare... ;) Mind you, I also tried the same on small_delete, but Pete somehow managed to crush the competition here. What tool did you use for that one..?! (small_move.gif)

* Added '@if member' to our post liking function, as guests can't use it anyway. (topic.js)
Title: Re: New revs
Post by: Arantor on March 30th, 2013, 06:39 PM
(13 files, 3KB)

Revision: 2040
Author: arantor
Date: 30 March 2013 17:38:46
Message:
! Overhauled how the do-not-log behaviour works, so it can properly be done. The old ways were a bit naive. (index.php, Ajax.php, Dlattach.php, Feed.php, JSEditor.php, JSOption.php, VerificationCode.php, ViewQuery.php, ViewRemote.php)
! Notifications action shouldn't be logged. (index.php, Who.english.php)
! New do-not-log for actions behaviour is also accessible for plugins when declaring their own actions, just add nolog="yes" to the <action> declaration. (index.php, Load.php, ManagePlugins.php, plugin-info.rng)
----
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/JSEditor.php
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewRemote.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/index.php
Modified : /trunk/other/plugin-info.rng
Title: Re: New revs
Post by: Nao on March 30th, 2013, 07:42 PM
rev 2041
(3 files, 2kb)

! My inden@zi vanity project was adding tabs to textareas, so I'm adding a skip for these. Sorry about that one. Also used the opportunity to protect <pre> tags, although there shouldn't be any -- but you never know. For the record, my protection code worked on first try, ah ah. I'm getting used to writing this kind of code I'm afraid... (Subs-Template.php)

! Fixed border in bottom linktree in Warm and Wuthering. Also minor fix to slogan positioning in Warm. (Warm/extra.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on March 31st, 2013, 03:35 AM
rev 2042 -- all the cool kids have it!
(6 files +1-1, 11kb)

+ Ah, what a complicated mess... But what I wouldn't do to save bytes!! The spinning wheel is replaced, on supporting browsers, with a fully CSS-animated equivalent. It looks much better, saves 900 bytes in the gzipped CSS, and it makes me look smart. What's not to like? (zoomedia.js, common.css, index.css, zoom.css)

* Replaced loader.gif spinning wheel with wheel.gif, which is the same image, but optimized for size. The palette is reduced to 7 colors (from 63!) without any noticeable difference, and it saves about 600 bytes. For oldIE & co. (loader.gif, wheel.gif)

! Fixed nested mixins. Previously, any 'mixin:' rules added to a mixin declaration would be ignored, which was bad... (Class-CSS.php)

! Ajax banner needed a box-sizing property, as it was setting both width: 100% and a padding rule, thus offsetting the spinning wheel by a few pixels. (index.css)

* Commenazi. (ScheduledTasks.php)

@ A quick note: I discovered that mixins within mixins accept the 'mixin:' rule, but not the 'mixes' symbol. Well, there's a limit to what these symbols can do, at least when it comes to the parser. I guess I won't rest until I find a solution for this.
Title: Re: New revs
Post by: Nao on April 1st, 2013, 12:40 AM
rev 2043 - "Je poste, donc je suis." (René-Gilles Descartes)
(10 files, 4kb)

* Playing catch up with translations! (Admin, Help, index, Install, ManageMaintenance, Modlog, Who)

* Updated $txt['error_new_reply_reading'] to make more sense in context. I think..? (Post.language.php)

- Removed a reference to an error entry that wasn't used anymore (new_reply). (Post.php)
Title: Re: New revs
Post by: Nao on April 3rd, 2013, 06:50 PM
rev 2044
(7 files, 3kb)

+ Added new Wess constant, 'can_animate', which aliases the long and complicated list of browsers that support CSS3 animations. Of course, you don't have to use it -- you only need it if you're planning to provide a, err... fallback. (Class-CSS.php, common.css)

! Fixed that annoying glitch in the error log, where filters would show with double-encoded entities. Note to self and anyone: westr::safe() rocks, use it more! (ManageErrors.php)

! Settings.language.php is a special file; creating an empty version of it will generate an error when someone switches skins while using said language. (Settings.english-uk.php)

* Finished British version of a file. If I ain't a good European citizen! (Who.english-uk.php)

- Removed 'gallery feed' action from Who's Online list. Just like regular Atom feeds, there's little reason to waste time logging these, as they're not real page loads. (Who.language.php)

- Old Opera and old Safari don't need to view CSS3 animations, as they don't support them at all. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on April 4th, 2013, 12:48 PM
rev 2045 -- this one is mainly for you to evaluate, Pete. Many changes in areas I'm not very comfortable.
(7 files, 6kb)

+ Added a 'feed' hook for plugins to insert their own feed sub-actions. (Feed.php, ManagePlugins.php)

* Moved 'determine_location' hook out of pretty URLs code, to make it a more generic URL manipulation hook. Also made $full_request subject to modifications. If I'm not mistaken..? (QueryString.php)

* Renamed action=media;sa=feed to action=feed;sa=media for consistency (and to prevent them from being logged in Who's Online). Added a hack to redirect them to Aeva-Foxy anyway, because... Well... It's complicated. (Feed.php, Media.template.php)

! $context['subaction'] should be built from $_GET specifically, not $_REQUEST. Not that we use that variable anyway, but... (index.php)

- Removed fallback URL for old SMF feed URLs and SMF Media Gallery URLs. I've built a plugin to account for these, if you're interested in supporting these URLs. Will probably be two plugins actually. One for SMF, one for SMG/AeMe. (QueryString.php, Aeva-Gallery.php)

- Removed two unused globals. (Errors.php, QueryString.php)
Title: Re: New revs
Post by: Nao on April 7th, 2013, 07:42 PM
rev 2046 -- my skeleton object rocks. It just needs to be tested from a plugin author's point of view. ;)
(4 files, 5kb)

! Fixed a situation in skeleton handling that I didn't consider. If we're using a target array with a fallback to 'default', and the skeleton is currently hidden (e.g. an XML template), Wedge would still force the layer to be shown in default, even though it's very unlikely to be the desired solution. For instance, my current code has the Notification block added to all XML templates by default because of said fallback, effectively breaking all Ajax responses due to malformed XML. Eh, silly me... Obviously, fixed by ensuring we skip the block if we're in that situation. (Class-Skeleton.php)

+ Added a new skeleton method, insert(), which is basically a generic operation function to add a layer/block. Instead of doing wetem::add(array('somewhere', 'default'), 'block'), you can now do wetem::insert(array('somewhere' => 'add', 'default' => 'first'), 'block'), meaning that if the 'somewhere' layer is available, 'block' will be added ('add') to it, and if it isn't there, it will be prepended ('first') to the 'default' layer. Is that clear enough...? It gives you greater flexibility if you're writing a plugin and want to have a variety of layers or blocks as fallback targets. Calling for opinions on the method name, as I want it to be as generic as possible, and 'insert' might not be. Maybe 'push', or 'put'..? (Class-Skeleton.php)

* Disable CSS/JS output compression by default at install time on non-Apache servers. Output compression may work, but only if you declare the proper MIME types manually in your configuration files. (install.php, install.sql)

* Made $full_board available for 'determine_location' hooks to modify. Not that it'll be very helpful, though... (QueryString.php)
Title: Re: New revs
Post by: Arantor on April 7th, 2013, 11:44 PM
(6 files, 2KB) - this is just a few bits and pieces I have kicking around that I can safely commit without affecting anything else.

Revision: 2047
Author: arantor
Date: 07 April 2013 22:42:43
Message:
! Managing membergroups could occasionally throw errors. (ManageMembergroups.php)

! Slightly nicer expandable groups in admin panel. At least I think so. (Admin.template.php, ManagePermissions.template.php)

! Corrected locale. (index.english-uk.php)

! Spacinazi. (Subs-Cache.php)

! Just a little something I've been using - I personally like to change the colour of disabled things to let people know they're disabled. (mana.css)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/languages/index.english-uk.php
Modified : /trunk/Themes/default/skins/mana.css
Title: Re: New revs
Post by: Nao on April 9th, 2013, 05:28 PM
rev 2048
(6 files, 3kb)

* Replaced the double quote hack in JavaScriptEscape with another kind of hack that doesn't require going through all of the calls in the file... It's been tested for a few weeks on my sites, but at commit time, I'm not sure it's that solid. So I'm splitting it from all my other changes, and committing it separately for easier fixes, if needed. (Subs-Cache.php, Subs-Template.php, Subs.php, index.template.php, ManagePermissions.template.php)

* Spacinazi. (Feed.php)
Title: Re: New revs
Post by: Nao on April 9th, 2013, 07:33 PM
rev 2049
(3 files, 3kb)

* Completely rewrote JavaScriptEscape. I'm like that. Now it's using str_replace instead of strtr, which is about 20% faster with many iterations. I've tested against the four possible quote/double-quote permutations (inside and outside the string), and figured out a cleaner way to escape quotes. This one really, really should be working... (Subs.php)

! Wedge could return errors when quick-editing a topic subject, but would never show said errors... This one's ugly, but what matters is the message... Right? (topic.js)

* I've always hated that a function was named Suggest_Search_Member. Renamed it all to lowercase. Also got rid of that silly type test that's been there for years... There's only one type of thing you can search for: members. Deal with it. When we add support for more, guess what? We'll refactor the code to account for that... (Suggest.php)
Title: Re: New revs
Post by: Nao on April 11th, 2013, 02:52 PM
rev 2050 -- about a couple of weeks' worth of work... Good luck going through it!
(17 files -1, 27kb)

@ Is that a huge commit or what..?!

* Fine-tuned tons more things in the notification system. (Seriously, pretty much all files in this commit. Also, index.css, index.template.php, and moved notifications.js to script.js; script size was increased significantly but adds several goodies, such as checking tab visibility to determine the polling delay.)

* Renamed returnAjax to return_raw (simple text strings), return_xml (XML structure) and return_json (arrays or pure JS objects), to allow for variable parameter length; thus, you can now do return_raw('Hello, ', 'World!') if you want. It's also, well, easier to convert existing echo's. (Ajax.php, JSEditor.php, JSModify.php, Aeva-Gallery.php, Notifications.php, QuoteFast.php, Subs.php, Suggest.php)

* Started getting rid of XML templates, and using proper return_xml calls instead. The idea is that if you modify anything in a XML template, you change the software behavior, rather than its appearance, so it shouldn't be outputted by the 'view' part of the MVC model. (JSEditor.php, JSModify.php, QuoteFast.php, Suggest.php, Xml.template.php)

+ Added getIcon and getUnread methods to notifications. These are generic functions to return what's most likely to be the issuer's avatar, and a notification's unread status. (Class-Notification.php, Notifications.php)

* Notifications will now return unread notifications only in the popup. I've added a placeholder for showing all notifications within the popup, but.. It's only a placeholder, all right? Can you see how many things I'm playing with at the same time? I'll implement this when I have more time... (Notifications.php, Notifications.language.php)

! Yes, display: table is needed in prev/next links, contrary to what I suspected. Otherwise the div may never expand completely horizontally, if the cells are too short. (sections.css)

! Wrong argument order in rewritten JavaScriptEscape would break inline JS code. I'm surprised no one reported that to me yet... (Subs.php)

! There is no 'access_denied' error language string. The proper string is 'no_access'. (Notifications.php)
Title: Re: New revs
Post by: Nao on April 11th, 2013, 04:16 PM
rev 2051 -- minor fixes, anything I could find that could quickly be isolated in a single commit.
(12 files + an attic file, 6kb)

+ Added support for user-select CSS. As Presto will soon be a thing of the past, I really should start changing all of my .mousedown(false) JS calls to proper CSS... Well, it's not that important. (Class-CSS.php)

! Forgot to add avatars to Like notifications. (Class-NotifierLikes.php)

! Also forgot to commit the rest of my chr(15) modifications, part of the JavaScriptEscape magic. (Subs-Cache.php, Subs-Template.php)

* Replaced menurow.gif with an optimized version, which is about twice smaller. This will soon be gone, too, replaced with pure CSS, but if I ever want to restore it, I know where it is now. (images/theme/menurow.gif)

* Renamed .separator class to .sep, which is also unused. It's very trivial, but this morning I needed to save as many bytes as possible, and came up with this... It actually saves 5 or 6 bytes per page load. I wouldn't usually bother, but there were already CSS comments in place that explain what the class stands for, so... Why not shorten its name..? (Unused-SelectBox.js, GenericMenu.template.php, index.template.php, Msg.template.php, extra.ie6.css, extra.ie7.css, sections.css)

- Removing a silly font-size setting that was overriding another override to the default, making no sense at all and wasting over 20 gzipped bytes... This is either me being crazy, or a hickup in team communication. Ship hattens. (sections.css)
Title: Re: New revs
Post by: Nao on April 12th, 2013, 07:32 PM
rev 2052
(7 files, 6kb)

* Three less XML templates, two to go. (Ajax.php, Register.php, Stats.php, Xml.template.php)

! The old Profile Notifications page is still there, but it wasn't showing up to do duplicate array entries. (Profile.php)

! Typo. (Class-CSS.php)

+ Added tt tag to list of inline BBCodes allowed within parse_bbc_inline. Also, because the parameter list doesn't match parse_bbc's, there's no point in shoving $short_list to the end after some params that are rarely used (such as the cache ID), so I'm moving it to right after the $message param. (Subs-BBC.php)
Title: Re: New revs
Post by: Arantor on April 14th, 2013, 12:21 AM
(3 files, 1KB)

Revision: 2053
Author: arantor
Date: 13 April 2013 23:20:07
Message:
! Stupid bug with a string being redeclared accidentally. (ManageBans.template.php, ManageBans language file)
----
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/languages/ManageBans.french.php
Title: Re: New revs
Post by: Nao on April 14th, 2013, 12:43 AM
rev 2054 -- just some quick ones, too...
(5 files, 3kb)

! Fixed links not being clickable in notifications popup, and added a shortcut to the user's settings page. (Notifications.template.php, Notifications.language.php, script.js)

* Some WebKit browsers, that aren't Chromium-based or Safari itself, don't seem to provide any meaningful version number, so I wrote a short function to match WebKit rev numbers to Safari versions; this is only an estimate, because forks sometimes remove or add features that are not in mainline. But it seems to work well, at least in Lunascape (at least it allows it to use Safari 5.1 features in Wess, instead of Safari 4-level.) (Class-System.php)
Title: Re: New revs
Post by: Nao on April 14th, 2013, 12:50 AM
rev 2055
(1 file +1-1, 84kb)

* Updated jQuery 2.0b1 to beta 3. Odd that they're changing their naming scheme, but whatever... As far as I could see, this beta has no issues, contrary to beta 2, so I hope I won't have to revert it later. It saves an additional 200 gzipped bytes compared to the first beta. Which is particularly nice. (Load.php, jquery-2.0.0-beta3.min.js)
Title: Re: New revs
Post by: Nao on April 14th, 2013, 04:25 PM
rev 2056 - I just killed XML! Yay!
(7 files -1, 7kb)

! Fixed Split Topics no longer working due to a template change. This has probably been around for a long, long time... (Split.php)

- Removed the last remaining XML templates. Everything is now done through return_xml() calls, and I recommend that you do the same. Again, XML data is not template material. (Ajax.php, Load.php, Post.php, Suggest.php, Xml.template.php)

* More uses of return_raw and return_xml throughout the rest of Wedge. More left to do, but first I need to determine whether I should add more helper functions for return values that don't require being passed through ob_sessrewrite... Minor headache. (Like.php, ManageMedia.php, Split.php)
Title: Re: New revs
Post by: Nao on April 15th, 2013, 11:40 AM
rev 2057 -- SSI and XML fixes. Or breaking more things, maybe ;)
(4 files, 2kb)

! ssi_examples was horribly broken... Well, maybe not horribly, but it needed fixin'. (root/ssi_examples.php)

- Forgot to remove a Xml template call. Seems harmless, but broke all thoughts and board selector... Oops. (Ajax.php)

* Search2 no longer replies to AJAX calls, AFAIK, so it was needlessly calling a template block for it. (Search2.php)

! ssi_quickSearch was broken due to a very, very old change. I'm using the opportunity to add our output buffer handler to SSI, which is probably going to be controversial, so I'm repeating in case it's unclear or we need to revert: from now on, any calls to SSI will call pretty URLs, <URL> and other things on your page. Understood..? (SSI.php)
Title: Re: New revs
Post by: Nao on April 15th, 2013, 11:48 AM
rev 2058
(3 files -1, 5kb)

* Simplified CSS button extends, removing per-button :hover declarations (replaced them with a similar but shorter and cooler solution), opting for a mixin instead of a base, and saving a hundred bytes in the process. Never underestimate the power of refactoring. (common.css, index.css)

* Moved all of extra.webkit.css's hacks to the main files. Yet another proof that while maintaining separate files is cleaner, sometimes it creates bugs due to oversights when removing features. (Plus, grouping items thematically compresses better, as always.) (extra.webkit.css, index.css, sections.css)
Title: Re: New revs
Post by: Nao on April 15th, 2013, 06:15 PM
rev 2059
(6 files, 10kb)

* Renamed 'custom_fields_above_signature' class to just 'custom_fields'. Unless I missed something, there's no reason to have such a long class name, and even worse, a name that gives away a position -- what happens if you want to move it around, eh...? Also harmonized border colors, and removed an odd repetition in border declarations. (Msg.template.php, PersonalMessage.template.php, Profile.template.php, sections.css, extra.rtl.css)

- Removed a couple of styles that were unneeded (one was my fault, the other was obviously a very old one). With the addition of the custom fields tweak, today I saved about 20 bytes in the gzipped CSS. And more is coming... (sections.css)

! Fixed two minor bugs in Recent template: the main page ID was repeated twice (id="recent"), and if you happened to view the Latest Posts page in guest mode and one of the posts had been liked, your HTML would be broken. Not in a way that breaks the page, but it did make the validator complain. Also indenazi, related to removing the unneeded id="recent" divs... (Recent.template.php)
Title: Re: New revs
Post by: Arantor on April 15th, 2013, 08:07 PM
(12 files, 4KB)

@ This is really just the stuff I can commit right now, just so I can brain-dump a little bit. There's so much more stuff outstanding and waiting to be committed, but this at least lets me focus on what's left without it seeming like quite so much of a Wall. (I still have 36 files + 4 additions to commit.)

Revision: 2060
Author: arantor
Date: 15 April 2013 19:04:03
Message:
! Use the nice notice feature for a menu in the gallery area. Only noticed it accidentally on wedge.org (Aeva-Gallery.php)

! A minor change that doesn't affect anything else: whether the 'warning status' is shown in the profile fields area as a 'disabled' field or not. It won't be controlled from there, so it's safe to remove it. (ManageMemberOptions.php)

! Style changes that the infractions system will use. Won't affect anything currently in play to my knowledge. (index.css, index.member.css)

! Don't cache the menu. (Subs.php)

! Don't need to decrement the warning count - we don't do it that way any more. No effect on wedge.org, there are no users with warnings at present. (ScheduledTasks.php)

! We don't need these old permissions any more. Again, since we're not using this on wedge.org, bye bye. The bits where these permissions are checked is pending because there's a bunch of related stuff in those files that needs fixing up. (ManagePermissions.php, ManagePermissions and Reports language files)

! (Forgot this in the actual changelog) Preset some variables for later. (Class-System.php)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css
Title: Re: New revs
Post by: Nao on April 18th, 2013, 06:20 PM
rev 2061 -- plenty of little bug fixes... As in r2060, I'm just cleaning up my stuff to make way for my upcoming CSS rewrites.
(7 files, 5kb)

! Missing global... Not that it really matters, as I'm not going to keep this image file around in the thought XML forever, eh... (Ajax.php)

! A recent Wess update slightly, but completely, broke support for multiple attribute selectors and the likes... Oops. (Class-CSS.php)

! The media admin page would give PHP strict warnings about a misused object. Used the opportunity to give more freedom to the admin page to resize its option descriptions. (ManageMedia.php, Media.template.php)

! Plugins that modified $txt strings would sometimes end up being ignored. Meh, it looks like I never actually committed the related fix I discussed in late January, and I even lost it at some point... (Subs.php)

! Validation error. Name attributes in anchors are deprecated... (MessageIndex.template.php)

* As discussed before, any class used in conjunction with .windowbg/.windowbg2 in the HTML itself, should use the 'final' keyword when its CSS uses these, as in '.windowbg.class-name'. This is because otherwise, all other classes that extends .windowbg will be added to the list... This saves over 50 gzipped bytes. Just with the extra keyword. (index.member.css)
Title: Re: New revs
Post by: Arantor on April 19th, 2013, 04:01 AM
(4 files, 15KB, though I really have no idea why it's so huge. Note I still have 36 modified, 4 new to commit.[1])

Revision: 2062
Author: arantor
Date: 19 April 2013 02:59:14
Message:
! Ooops, this one didn't get the $context['action'] treatment. (Groups.php)
! Should have fixed this in the menu code before. The rest of caching goes bye bye. The diff looks so much worse than it actually is. (Subs.php)
! New hook. (ManagePlugins.php)
! Another bit of style goodness. And before we go around the merry-go-around yet again, this is for the list of warnings on an account which could theoretically be seen by any registered member. (index.member.css)
----
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/skins/index.member.css
 1. Assuming I retain enough of my sanity with it to do so.
Title: Re: New revs
Post by: Nao on April 19th, 2013, 06:31 PM
rev 2063 -- thought system rewrite! Again!
(8 files, 8kb) -- BTW Pete, since you were wondering: re-indenting an entire block is seen as a full rewrite by SVN, hence your huge commit ;))

* Rewrote large parts of the thought system to improve its flexibility. Basically, every Ajax action will now refresh the entire thought list, which has a few advantages: no need to provide a hidden new_thought template, new thoughts from other users will also be shown in the refresh, and it should allow for thought menus in threaded view; which isn't implemented yet, but it'll come soon... The only drawback, of course, is the extra bandwidth use, but it's not like posting/editing thoughts is going to kill your server anyway... Or is it? Also of note, I moved the URL-breaking JavaScript code to its own function (breakLinks), so now you can call it from within your plugins if you ever do the same kind of manipulation. This adds 12 gzipped bytes, but since the thought rewrite shaved off exactly 58 bytes of JavaScript, this means we still save 46 bytes. Oh, and if you like breaking rules, check out the new code in Ajax.php, it's pretty... interesting. (Ajax.php, Thoughts.php, Thoughts.template.php, Welcome.template.php (it's only for the principle -- it needs a complete rewrite), index.member.css, and sections.css)

! Clicking the BCC link in PM pages would send you to the top of the page... (pm.js)

! Fixed a JS error that would show up when loading any SSI page, due to the notification check not finding the we_notifs variable declared anywhere. I'm a bit upset that it adds a couple of bytes to the filesize, but... I know, I know, I should find some help. (script.js)

! Fixed status icons being too tall in IE6. (sections.css)

! Fixed thought mini-menus overlapping one another in IE 6/7. This is due to an IE bug that I couldn't find any information about. I've documented everything over at wedge.org, but in the end I decided to 'simply' show these menus to the right of the button, rather than below, because we don't have menu arrows in oldIE anyway... Note that this is only a partial commit, and it might not work until I'm finished with the rest. (sections.css)
Title: Re: New revs
Post by: Nao on April 19th, 2013, 07:03 PM
rev 2064 -- the 'I can already smell someone reverting this...' commit :P
(3 files +1-1, 86kb)

* Updated jQuery to version 2.0 final. They managed to remove hundreds more bytes compared to the very recent beta 3... They're my heroes, definitely. (Load.php, jquery-2.0.0.min.js)

+ Added an optional $txt['lang_hreflang'] string, that can be set to 'force' a language's hreflang for SEO purposes. Not that it's very important, but I wanted to implement it in a clean way that didn't cause any harm to 'main' language files, so this is it... The string falls back to $txt['lang_dictionary'], i.e. the previous default. As of now, the 'code' array entry is no longer used anywhere, so  (Load.php, index.template.php, index.english-uk.php)
Title: Re: New revs
Post by: Nao on April 20th, 2013, 08:03 PM
rev 2065 -- I like nested stuff!
(7 files, 4kb)

+ Finally added support for mini-menus in thought threads ("In context" pages). Tough job... Also added privacy icons to them; I'm not sure why I forgot to show them in the first place... (Ajax.php, Thoughts.php, Thoughts.template.php, index.member.css, sections.css)

* Don't show a hard link to user's posts in their profile page if they never posted. Link remains available in the profile menu, but feel free to remove it as well. I don't mind either way... (Profile.template.php)

! Mini-menu would fail to position correctly when un-ignoring a post from an ignored user, and then attempting to open the 'More' link. (Display.template.php)

* Moved some inline styles to CSS. (Thoughts.template.php, sections.css)

* Multiple extends (extends ".class1, .class2") are cool, but not so much when .class2 doesn't do anything special... (sections.css)
Title: Re: New revs
Post by: Nao on April 21st, 2013, 11:32 AM
rev 2066 -- making Wedge less buggy, one file at a time.
(1 file, 3kb)

! Fixed member recount. Since Pete doesn't seem to be available to tell me what's best, I've done a tentative fix that seems to work. (ManageMaintenance.php)
  - Takes recycle board into account (and yes, I still want to remove that crap from Wedge...), since these boards still advertise themselves as wanting post counts, and we have to exclude them manually;
  - adds a GROUP BY clause to ensure we get all members in the final recount query. I'm surprised Pete's original commit from nearly 2000 revs ago already didn't have it...
  - updates post count as well for members that aren't found in the messages table anymore. At least, in the case of test boards, it can be useful.
Title: Re: New revs
Post by: Nao on April 23rd, 2013, 11:45 AM
rev 2067 -- everything I could find from sections.css, and some satellite files...
(13 files +4 -1, 24kb)

- Removed ability to ask for a topic notification from within places that do NOT show the entirety of the topic... It only makes sense to require someone to at least have a glance at a topic, before they can determine whether it's worth their attention at all... (Profile-View.php, Recent.php, Search2.php, Profile.template.php, Recent.template.php, Search.template.php)

* Push my button. Saved over 500 bytes from the final CSS filesize... Not bad, I guess..? (blank-button.png, warn.png, quickbuttons-32bit.png, approve.gif, restore.gif, actions.png, warn.gif, extra.rtl.css, sections.css)
  - Reworked the 'in context' button from a new blank-button I quickly cooked up, as well as warn.gif to make it more readable.
  - Removed notify.gif button, as it was only used in those places I removed.
  - Removed notify_sm.gif, I couldn't for the life of me find a place that uses it. Anyone else, maybe..?
  - Split approve and restore buttons out of the button sprite, as they're very, very unlikely to be ever seen, even by an admin...

! Better alignment for plugin icons in admin menu. (mana.css)

! Fixed top left margin in thought threads. (sections.css)

- Removed flex use from topic posts. You can still use @if can_flex in your CSS to provide a fallback for non-flex supporting browsers, but I'd advise against using nested flexboxes, as they're VERY, VERY buggy, and even browser authors recognize it... So, basically, doing rowspans and colspans in flex..? Not a very good idea of mine. The only ways to do that, are table tags, or the grid layout from IE10, which I'll try and implement, once it's available in Chrome, and perhaps in Firefox... But I wouldn't hold my breath. Sob. Also, upped the minimum versions of Chrome and Firefox to support flex, as earlier versions are even buggier... See the pattern, eh..? And finally, restored support for Opera 12.1+, as in the end, it's not buggier than other browsers, it just is... differently buggy, I guess... (Class-CSS.php, sections.css)
Title: Re: New revs
Post by: Nao on April 25th, 2013, 01:29 PM
rev 2068 -- better thoughts, again!
(11 files, 7kb)

* Rewrote though system to get rid of the sidebar area, and instead move the 'new thought' box to the thoughts area, wherever it is. (Homepage, Profile or All thoughts. Thought threads don't support it because it doesn't make sense, as the new thought won't, technically, be part of that thread, eh...) This saves a whopping 39 gzipped JS bytes, err... Well, I was hoping for more, but whatever... This also saves us from storing your latest thought in the database; while I thought it was nice to do, you can still see your latest thoughts from your profile, so why bother..? It was, probably, a minor waste of bytes. (Ajax.php, Like.php, Subs.php, Thoughts.php, Welcome.php, index.template.php, Thoughts.template.php, index.language.php, script.js, index.member.css)

+ Added a return_raw() helper function, very close to return_text() but it also bypasses gzipping and output buffering altogether. Which, I'd say, is quite welcome when you're returning only a couple of bytes... (Ajax.php, Subs.php)
Title: Re: New revs
Post by: Nao on April 25th, 2013, 04:41 PM
rev 2069 -- mostly maintenance.
(22 files, 23kb -- over half of it due to re-indenting in zoomedia.js)

+ Added a we::$is_member variable, which is simply the opposite of we::$is_guest... Not that it's going to be very useful, but I don't see the reason to force people to use !we::$is_guest when they could use the other. Also, Wess did an extra test for guests and members, when it should already be dealt with by we::is(), so I removed these... There are still dozens to fix, but we're in no hurry. It's just my usual pedantry... (index.php, Class-CSS.php, Class-System.php, Display.php, Feed.php, Load.php, Login2.php, Aeva-Gallery.php, Aeva-Gallery2.php, Subs-Media.php, MessageIndex.php, Security.php, Thoughts.php, Welcome.php, Subs.php, Subs-Post.php, index.template.php, Boards.template.php, Display.template.php, MessageIndex.template.php)

! Fixed Wedge insisting on calling you a 'guest' if you're not logged in, even if you're not in English mode. (Class-System.php, Load.php)

! Fixed broken image in sidebar when no avatar is set for oneself. (Class-System.php, Subs.php, index.template.php)

* Moved Zoomedia's language strings to the JS file. Commented most of them out, since they're not really used for now... Saves space, eh? (Aeva-Subs-Vital.php, zoomedia.js)

* draftXmlReturn wasn't using the return_xml() shortcut, sadly... (Subs-Post.php)
Title: Re: New revs
Post by: Arantor on April 25th, 2013, 05:07 PM
(15 files, 7KB)

Revision: 2070
Author: arantor
Date: 25 April 2013 16:05:22
Message:
@ Things I can commit without breaking anything else. And for the first time since I started on this hellish journey into the infractions/warnings/post moderation/post ban overhaul, conflicts. Two of them!

! English-UK fixes. (Help.english-uk.php, ManageMedia.english-uk.php, ManageMembers.english-uk.php, Themes.english-uk.php)

! Some otherwise unrelated changes for the benefit of the admin search. Note that the magic underlying logic is elsewhere and cannot be committed at this time due to other changes in the same file. (ManageAttachments.php, ManageMemberOptions.php, ManageNews.php, ManagePosts.php, ManageRegistration.php, ManageSearch.php, ManageSearchEngines.php, ManageSmileys.php, Admin.template.php)

! Use the we_ wrapper function for json_encode. (Admin.template.php)

! Language files with *just* new strings, for translation purposes. (ManageBoards.english.php, ManageMembers.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english-uk.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/Themes.english-uk.php
Title: Re: New revs
Post by: Nao on April 25th, 2013, 06:58 PM
rev 2071
(18 files, 4kb)

* Reordered smiley file cache. Not a big deal of a code addition, for a less than thrilling result (a dozen bytes saved), but as it's a free saving, and it took only minutes to implement, and it doesn't take more time to run, I'd say it's a good use of a few minutes... (Subs-Cache.php)

* Remembered that grepWin has a replace function, so I did the rest of the we::$is_member conversions... And checked them all manually, of course. (Login.php, Logout.php, MoveTopic.php, Poll.php, Post2.php, Profile.php, Register.php, RemoveTopic.php, Search2.php, Subs-Auth.php, Subs-Menu.php, Subs-Template.php, ViewQuery.php, SSI.php, Home.template.php)

* Minor CSS fixes. One looks complicated, and its only point is to save a couple of bytes and a console warning in Opera, hmm... (sections.css)

! Fixed thought template in mobile mode. (Thoughts.template.php)
Title: Re: New revs
Post by: Nao on April 25th, 2013, 08:09 PM
rev 2072 -- POP! POP! (© Magnitude)
(6 files, 10kb)

* Finalized (hopefully?) the notification popup, where you can now choose on-the-fly between 'All latest' and 'latest unread' notifications. There are style a few hardcoded styles here and there, but no biggie, and these are Ajax-loaded anyway. (Notifications.php, Notifications.template.php, script.js)

! Fixed notification popup animation to what it was supposed to do... You're going to like that. Or not. Well, I do, so tough luck. Wait until I'm bored. (index.css)

! Sometimes, user has several tabs opened, then logs out of one, and other tabs still attempt to load notifications, but have no proper session to provide, and are thus kicked out. These do NOT need to be logged in the error log, obviously..! (Notifications.php)

! Fixed warn class commas, and turned some extends to mixes (I do that when it saves bytes). (index.css)

* Translation. (ManageBoards.french.php, ManageMembers.french.php)
Title: Re: New revs
Post by: Arantor on April 25th, 2013, 08:48 PM
(7 files, 7KB)

Revision: 2073
Author: arantor
Date: 25 April 2013 19:47:35
Message:
! Backend for saving and editing plugin language data. The caching part is in Load.php and as such I can't commit it just yet. (ManageLanguages.php)

! Who's Online should be a bit more consistent with the online list in terms of formatting. is-contact is still not rectified but that's a much larger battle anyway. (Who.template.php)

! Like action shouldn't actually be in the online log. (index.php)

! Clean up the current user's sanction state, simplifies checks later on. (Class-System.php)

! A few ban changes... namely moving a few things around for the admin search, but also to flush certain caches that will be updated in future. (ManageBans.php)

! Style changes. These are mostly likely to be final from my perspective, but could change. Not really worth optimising these *just* yet. Also reverts about 1/3 of r2072, namely all the changes that were conflicted in that file. (index.css, index.member.css)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on April 25th, 2013, 10:57 PM
rev 2074 -- easy peasy!
(4 files, 2kb)

+ Ajaxified the Like button for thoughts. It's a bit hackish, with back-and-forth between Ajax.php and Like.php, but if you can do better in less than 30 lines and 20 minutes of work, you call me. (Ajax.php, Like.php, Thoughts.php, script.js)

! Fixed wrong language string index. (script.js)
Title: Re: New revs
Post by: Arantor on April 26th, 2013, 02:58 AM
(2 modified, 3 added, 9KB)

Revision: 2075
Author: arantor
Date: 26 April 2013 01:57:34
Message:
! After some fiddling around, I realised that I could save 5KB of admin language stuff from being loaded every admin page by breaking it off into its own file, I actually prefer this to all-in-one dumping grounds if it's feasible, so I did it for Forum > Posts and Topics. I have NOT removed it from the admin language file in this commit, because I don't want to commit and leave other stuff broken. But locally I have removed that so only what should be in the admin file is in there. There *is* a new feature indicated here and it is currently being implemented, this is just the UI for it, 1 translation required in ManagePosts.french.php (ManagePosts.php, ManagePosts language files)

! Tweaked layout in admin search results. (Admin.template.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/languages/ManagePosts.english-uk.php
Added : /trunk/Themes/default/languages/ManagePosts.english.php
Added : /trunk/Themes/default/languages/ManagePosts.french.php
Title: Re: New revs
Post by: Nao on April 26th, 2013, 11:08 AM
rev 2076 -- had these optimizations around for some time, figured it'd be okay to commit them...
(4 files +32 image manipulations, 58kb)

! New thoughts could be empty, which is wrong. This is due to the latest rewrites, in which I added the ability to delete one's existing thoughts by editing them to nothingness, rather than using the Delete button. (Ajax.php)

* Optimized some image file sizes. Some of them were integrated into the CSS files, saving close to 200 bytes. Others aren't integrated, but that shouldn't excuse some of the (sometimes already optimized) files from being 100 to 300 bytes larger than they could be. Also of note, warning_mute doesn't seem to be used anywhere, but I'm not removing it because it might be hidden in some variable like $context['warning_status'].gif or something. I'll leave it up to Pete. (16 files in the attic, 16 in /images, including board status icons, warning icons, and Wedge footer logos.)

* I'm not convinced that warning icons should be integrated into the CSS. The only 'visible' difference between integrated and non-integrated is the extra HTTP hit, and I'm not sure warnings are a feature that is supposed to seen on every page... Is it? So I'm adding the no-base64 keyword to them, but it can always be reverted. (index.member.css)

* Admin intro could use some extra margin, I think. (mana.css)

* Translation. Eh... Sounds like a cool new feature for Wedge... ;) (ManagePosts.french.php)
Title: Re: New revs
Post by: Nao on April 26th, 2013, 03:31 PM
rev 2077 -- another large commit with tons of changes made over the weeks... When is TortoiseSVN going to add cherry-picking, please..?
(6 file, 8kb) (very meager compared to the time I spent on these... :P)

@ By order of appearance in the index CSS file... (index.css)

! Fixed search popup width in IE6.

- Removed the Chrome hover/focus hack I added a few months ago, as the bug no longer seems to trigger in the latest versions. At least if it shows up again, this time I know where to look for a quick fix, eh...

* Moved .ie_button class to the IE6 file. We don't need to define it for other browsers, do we..? (Also, extra.ie6.css)

* Minor tweak to button styling in hover mode. Slightly better, I think...

* A NEARLY complete rewrite of the CSS and JS for main menus. The basic principle is the same, but I wanted to use a CSS-only image for menu arrows, instead of a GIF picture. This forced me to use alternate techniques, and add more bytes for IE compatibility, although I'm later planning to see if I can't just write a 'cleaner' version with more proper CSS, and have an oldIE-compatible version on the side, as an afterthought. Also, among the advantages of the rewrite: you'll no longer get 'stuck' menu arrows in menu animations, you can easily change the arrow color to match the menu's, the JS-free version actually behaves better (sub-menus are correctly located next to their parent entries, rather than at a fixed position next to them, which I always disliked), and the rewrite saves about 60 gzipped bytes of CSS and 90 gzipped bytes of JS, which is always nice... And more than compensates for the fixes and additions I made to the thought system in my last couple of commits. (Also, script.js)

@ And the other files...

! Fixed .pagesection showing scrollbars in IE6. (extra.ie6.css)

- Removed various IE6 and IE7 fixes for mini-menus and button backgrounds, as they were no longer needed due to the rewrite... Eh eh. (extra.ie6.css, extra.ie7.css)

* A few tweaks to Wine and Wuthering, to accomodate for the menu rewrite mostly, but also keep up with some other changes I made recently, and remove tweaks that were no longer in use. I don't always test these, maybe I should... (Wine/extra.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on April 26th, 2013, 06:55 PM
rev 2078
(2 files, 5kb)

+ Another one of my hobbies... I've had this running literally for weeks on my local install, with no discernable issues, so I'm assuming my regex and general code is flawless. Implemented :matches pseudo-selector in Wess, in a way that you don't have to do it yourself, instead it will group your elements as efficiently as it can (it's far from perfect, but really, it's better than nothing), and only on browsers that support it, meaning mostly Firefox and Chrome, as usual. This doesn't save a lot, I'm afraid... But still, it's something like 100 or 200 bytes on the main CSS file, gzipped, and it's basically free, except for the processing at cache time, so there you go. (Subs-Cache.php)

! Oops, committed some debug styles, it seems... (index.css)

@ And there we are, most of my code is now committed. There are still a few things here and there, but I've got only 12 outstanding files left to commit (mostly changes that will never make it because I'm not sure about them), which is very, very little by my standards. Yay, now I can have a look at my to-do list again, ah ah... It's never going to end, I think... ;)
Title: Re: New revs
Post by: Arantor on April 26th, 2013, 08:00 PM
(4 files, 7KB)

This is a collection of bits I wanted to get committed and out the way so I could stop procrastinating by adding new features finish the infraction system.

Revision: 2079[1]
Author: arantor
Date: 26 April 2013 18:57:05
Message:
! Admin search now includes the likes page, such as it is, and now includes the page title of where your results come from, assuming the settings pages have been set up to do so - most have not, but I will fix that in future commits. (Admin.php)

! $helptxt value could be ditched on conventional language-cache loading under some circumstances. (Load.php)
! Plugin language files should also be loading from cache. This patch does NOT include the changes to language hooks. (Load.php)

! Permissions settings were doing a weird thing to get their title across to the settings page. There is a proper variable for falling back, let's use it. Also makes it searchable. (ManagePermissions.php)

! Make sure the admin pages pull up the help text from plugins a bit more properly. (ManageServer.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageServer.php
 1. The year Judge Dredd graduated from law school.
Title: Re: New revs
Post by: Arantor on April 27th, 2013, 06:29 PM
(13 modified, 21KB)

More bits and pieces I have that can be committed without serious issues elsewhere.

Revision: 2080
Author: arantor
Date: 27 April 2013 17:20:45
Message:
! Sync security tests with those in BB 2.1.14 (only the relevant parts) (Security.php, Security.english.php)

! Hopefully all the error messages related to infractions. (Errors.english.php)

! Language strings for the moderation area on board index. (index.english.php)

! Dropping MSN/Live and adding Skype to the custom profiles templating stuff. (ManageMemberOptions.php, ManageSettings.english.php)

! Messages need a data column. (install.sql)

! Formatting options for membergroups. The text items were already added before. (install.sql, ManageMembergroups.php, ManageMembergroups.template.php, Subs-Cache.php, Subs-Membergroups.php, Subs-Template.php)

! Bolster the normal functions for adding to, editing and cleaning up the shiny new message data column. (Subs-Post.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on April 29th, 2013, 01:40 AM
(6 modified, 2 added, 19KB. I only dread to see the final commit for the rest of infractions system because of the many minute changes it makes.)

Revision: 2081
Author: arantor
Date: 29 April 2013 00:38:51
Message:
! Signature area needs the manage-posts language file. (ManageMemberOptions.php)

! Settings in Settings.php could sometimes disappear. (ManageServer.php)

! The original code assumed no clean-up would be applied on loading, but it is now. (Related code not yet committed. It's just one less than the mountain) (Subs-BBC.php)

! Imperative tasks' handler is slightly more useful. Also included an imperative task for later. This cannot be called in current trunk, nor would it work if it were, but the task might as well be committed now. (Subs-Scheduled.php)

! Moving of code out of the template and into the JS file that we already had. (Register.template.php, register.js)

! Mostly complete, if not fully complete, version of the infractions management language file. There will still be a ton for the profile area, but this is for the admin area and hopefully won't generate many/any more for the time being. Fingers crossed! (ManageInfractions.english.php, ManageInfractions.english-uk.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/Register.template.php
Added : /trunk/Themes/default/languages/ManageInfractions.english-uk.php
Added : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/Themes/default/scripts/register.js
Title: Re: New revs
Post by: Nao on April 29th, 2013, 02:18 PM
rev 2082 -- just for the French audience. Okay... Just for me, then.
(34 files, 30kb)

* French translation. (Errors, index, Security)

* Updated all French language files to replace &nbsp; (non-breaking spaces) with narrow versions (&#8239;), which I just realized even works in oldIE... So, why bother using nbsp? Except for the extra byte it takes, which I can live with... After all, we just added another kilobyte to the index language file... (Hopefully not forever, eheh.) For those wondering, thin spaces are supposed to be shown right before any punctuation sign with at least two strokes, which basically means [?!;:]. (34 files)
Title: Re: New revs
Post by: Arantor on April 30th, 2013, 01:39 AM
(2 files, 1KB)

Revision: 2083
Author: arantor
Date: 30 April 2013 00:38:43
Message:
! Board selection from generic settings template needed a little tweaking. (Admin.template.php)
! Better handling of empty values for generic settings and fix an edge case where an empty value could be ignored. (ManageServer.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php
Title: Re: New revs
Post by: Nao on April 30th, 2013, 12:16 PM
rev 2084
(3 files, 2kb)

! Fixed two woopsies in thought threads: likes not showing up (thanks to me not calling the template block for them), and mini-menus not working entirely, despite showing up (due to the Thought object not being initialized in that code path.) (Thoughts.php, Thoughts.template.php)

* Wedge doesn't need to go through obExit() to run ob_sessrewrite, as it's already added in the clean_output() process. So, no need to waste time running this, I'm sure the mail queue and track stats won't mind that Ajax calls don't trigger them... (Subs.php)

! Fixed return_raw() crashing, and thus failing to return thoughts and likes, due to an issue with ob_end_clean() and gzipping. Pete and I couldn't find the reason why it doesn't work there but works in other situations, such as file downloading, but it's all right, I can live with small Ajax returns being gzipped, I'm sure it has no influence over anything. (Subs.php)
Title: Re: New revs
Post by: Arantor on May 2nd, 2013, 03:31 PM
(3 files, 2KB)

Revision: 2085
Author: arantor
Date: 02 May 2013 14:26:16
Message:
! Daft as it sounds, you couldn't actually delete an individual ban from the ban's edit page, which is a shame if you're coming from the profile area which links to the specific bans currently applying to a user's account. (ManageBans.php, ManageBans.template.php, ManageBans.english.php
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Title: Re: New revs
Post by: Arantor on May 2nd, 2013, 03:37 PM
(4 files, 2KB)

Revision: 2086
Author: arantor
Date: 02 May 2013 14:36:56
Message:
Yay for thematic commits![1]

! The changes to the manage boards area for the moderation category as well as the new ignorable boards option. Of course, the support for the rest of this is not yet finished but every little bit I can commit helps, right? (Class-System.php, ManageBoards.php, ManageBoards language file)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
 1. I should have put that here rather than in the actual changelog >_<
Title: Re: New revs
Post by: Nao on May 4th, 2013, 10:19 AM
rev 2087 -- a few things before the oncoming storm...
(4 files, 3kb)

! Fixed JS not correctly updating the number of notifications in the header, when marking an item as read or receiving new notifications. (script.js)

! Fixed thought reply process hiding the parent thought, instead of showing the form next to it. (script.js)

! Fixed this annoying bug I used to get in the error log, with popups not showing up despite the screen being dimmed. This was apparently due to $(window).height() returning a huge value, probably the equivalent of the body height, and thus showing the popup below the visible viewport. I fixed this by using window.innerHeight instead, but it's less precise because it includes horizontal scrollbars (if there are any, which is unlikely, but meh.) Used screen.height as a limiter instead, so it should at least make the popup accessible, at worst by maximizing your window if it's not already maximized. Feedback welcome... (script.js)

* Only show Mark Read buttons on unread notifications, duh... (Notifications.template.php)

* French translation. (ManageBans, ManageBoards)

Note to Pete: perhaps you never noticed (it took me a while to see it, as it was a new TortoiseSVN feature in 1.7 or something), but you *can* edit your SVN changelogs now, even the old ones... :)
Title: Re: New revs
Post by: Nao on May 5th, 2013, 02:56 PM
rev 2088 -- and here we are... The Big Fix for CSS keywords.
(11 files, 22kb) (88, 11, 22... A pattern?!)

* And another huge overhaul of Wess and the system class... Basically, we::$browser['is_*'] is now we::$browser['*'], and all of the we::$user['is_*'] variables are moved to we::$is['*'], to make them clearer to differentiate from non-boolean $user variables, basically. Finally, we::$browser OS variables are moved to we::$os, including the we::$os['mobile'] boolean, which is an alias to we::$is['mobile'] anyway. Got it..? (Class-CSS.php, Class-System.php, Display.php, Load.php, Notifications.php, Post.php, Post2.php, Profile-View.php, RemoveTopic.php, Subs-Cache.php, Subs-Template.php)

* CSS suffix overhaul. I'm no longer initializing a css_suffixes array, and instead using the system class's properties directly. This saves nearly 2KB in Load.php, really... Also added support for all kind of tests within filename suffixes, so basically index.!(opera && windows).css is now a possibility... If you're crazy enough, of course. (Load.php, Subs-Cache.php)

* CSS file caching should now be working properly for board and category IDs tested against within the CSS file itself. I spent an awful lot of time on it, and I'm pretty sure not many people are going to find this of use anyway, but I wanted to harmonize the list of keywords available between filename suffixes and @if tests. Also saves about 700 bytes of code. (Class-System.php, Subs-Cache.php)

+ Added support for the | (logical OR) delimiter in CSS tests (not in filename suffixes though, as | is not a valid filename char). You can use a comma, or |, or ||, whatever you prefer, I'm not going to judge. (Class-System.php)

! The system class could never hold board information, because loadBoard is called after it... And not only that, but I was globaling $board instead of $board_info. Anyway, fixed and moved to loadBoard instead... (Class-System.php, Load.php)

@ Note... Support for the replace keyword was rewritten, and is untested. Might go away at some point. Same for fallback folders -- it wasn't rewritten though, just left to rot. Also, the local keyword still won't work inside CSS files. And finally, plugin CSS wasn't rewritten either, and instead I chose to remove support for filename suffixes for them; I have yet to see them used by someone else than me, and I'm fine with it.
Title: Re: New revs
Post by: Arantor on May 5th, 2013, 05:25 PM
3 modified, 2 added, 60KB[1]

Revision: 2089
Author: arantor
Date: 05 May 2013 16:24:19
Message:
! I think I'm happy enough to commit this now. It still can't be called, but it's one less set of things to forget. (ManageInfractions.php, ManageInfractions.template.php, install.sql)
! Revised wording, seems to flow better. (ManageInfractions.english.php)
! Moved this scary function. (Subs-Scheduled.php)
----
Added : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/Subs-Scheduled.php
Added : /trunk/Themes/default/ManageInfractions.template.php
Modified : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/root/install.sql
 1. You remember I said the warning system was big and scary and driving me crazy? This is why. And, frankly, this is still only a fraction of it. As per my other posts, this is why my temper is much shorter than usual.
Title: Re: New revs
Post by: Nao on May 5th, 2013, 06:12 PM
rev 2090 -- woot, need to check out your rev, Pete!
(3 files, 1kb)

! Undefined index error. (Class-CSS.php)

! Undefined variable error. (Subs-Cache.php)

! array_flip warning. Oops, definitely not my day... (Subs-Cache.php)

* More breathing space for the header in Wireless. (Wireless/extra.css)
Title: Re: New revs
Post by: Arantor on May 6th, 2013, 06:33 AM
43 modified, 1 added, 135KB[1]

Revision: 2091
Author: arantor
Date: 06 May 2013 05:32:14
Message:
! It's late, I'm tired and I think I finally finished this stuff into something I can at least commit, even if it is a modest distance from perfect, even it's not entirely finished or battle tested. I just want to be able to commit it and have a proper good night's sleep for the first time in a month. Yes, there are bugs, there are unfinished bits, but committing it will at least allow me to figure out what's next. There is, as far as I know, nothing actually outright broken here. Just things that don't work properly or at all (as opposed to error vomiting). And now I can go to bed and try and find some of my sanity again.

Amongst the warning system, there's various other oddments relating to the moderation centre, the plugin loader and some other stuff.

IMPORTANT: When this is deployed, you should disable all plugins PRIOR to uploading this, and then re-enable them AFTER uploading this. There are some important changes in the way plugin hooks are handled, to do with storing their paths properly. There's also overhauls to the hooks a little in here too which all seems to work properly for me and means language hooks reuse code nicely. Feel free to ask me when I wake up if there's anything you're not clear about. (Yes, I'm well aware that some stuff really is non functional, especially some of the stuff related to the mod centre overhaul. The full infraction log, for example, doesn't even exist yet. But right now I do not actually care. This has taken me a month to get done, along with the periodic commits along the way. I'm human; I have been weighed, I have been measured, and at times I found myself wanting.

If you want to play with it on a test installation before updating wedge.org that would probably be best.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Profile.english-uk.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/pm.js
Added : /trunk/Themes/default/scripts/profile.js
Modified : /trunk/root/install.sql
 1. I wasn't kidding when I said that was only a fraction of it.
Title: Re: New revs
Post by: Nao on May 6th, 2013, 04:30 PM
rev 2092 -- small fixes, and minor notification popup improvements. Anythin' to keep me from the work of going through rev 2091... :whistle:
(3 files, 7kb)

* Added a subtle hover highlight on the notification link. Main issue is that since I'm relying on CSS3 animations to show the popup, I can't do a proper parent hover because of this technicality when you start mov... err... Is anyone reading? Didn't think so. (script.js, index.css)

* Added another amusing little 3D effect on the notification popup. Just done with a box-shadow. Too much of a good thing probably, so it'll probably go away at some point, but in the meantime, have some fun with it, will you..? (index.css)

! Fixed skin.xml files not properly removing skin directives embedded within an <if> test. Sorry for not seeing this earlier -- this means that in the last few weeks, everyone visiting wedge.org was actually loading Open Sans from Google's font repo without it ever being used... Ah ah, silly me... (Subs-Cache.php)

! Fixed link breaker adding a '...' break effect on links that don't need to be broken, if user tries formatting their link from within the url tag, rather than outside of it. (script.js, index.css)
Title: Re: New revs
Post by: Arantor on May 6th, 2013, 04:32 PM
2 files, 2KB

Revision: 2093
Author: arantor
Date: 06 May 2013 15:30:51
Message:
! Don't notify the user themselves that they have been softbanned. Also, tidy up the punishments warning when injected so that it really does reflect the true state of play. (Profile-Actions.php)
! Moderation category could cause errors, and be shown inappropriately, under some conditions. (Subs-BoardIndex.php)

@ And so it begins, first bugfixes to the warnings commit.
----
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subs-BoardIndex.php


@Nao: You can certainly understand now why it's been messing with my head :^^;: Hopefully I should be a bit nicer in future :)
Title: Re: New revs
Post by: Nao on May 7th, 2013, 11:43 PM
Oh yes I do understand, Pete... ;)

rev 2094
(12 files +1, 32kb)

* French translation for infractions. ManageInfractions is only partial, I'll finish it eventually... Also, I have yet to test punishments, so I don't know if I should translate 'warnings' to 'sanctions' or just literally, 'warnings'... (Admin, Errors, Help, index, ManageInfractions, ManageSettings, ModerationCenter, Profile)

* Typonazi..? The Help one is for sure, but as for the other one, you tell me. I probably added some typos of my own to my French translation anyway, but shhh..! (Help.english.php, ManageInfractions.english.php)

! Notifications page wasn't taking into account your modifications. I'm talking about the page for the newest Notifs feature, not the old one, which we'll remove at some point... (Profile.template.php)

- JS function declarations don't need a closing semicolon, only anonymous functions require one. Also replaced all double quotes with single quotes. To be quick, any JS included within a HTML page should use double quotes for better compression, while single quotes compress better in stand-alone files. Only saves a few bytes, but that's a free change, so... (pm.js, profile.js)
Title: Re: New revs
Post by: Nao on May 8th, 2013, 12:29 PM
rev Yours Truly 2095 -- She has an IQ of 1001, she has a jumpsuit on, and she's also a telephone. ♫
(4 files, 2kb)

* Helping mobile devices a bit; removing the body padding by default (I'm sure they'll appreciate the gesture), and removing the extra box-shadow animation on the notifications popup, as it seems to slow it down even on my S3 to the point that the animation no longer shows at all, meaning it's probably going to be jerky for all mobile devices. Without the extra animation, it's still barely visible, but at least it's there. (index.css)

* Said notif popup came a bit out of nowhere; changed it to drop from the notif title instead, as expected (and in line with all other dropdown animations.) (index.css)

* Changed z-index for mini-menu animations, to ensure they always come on top of main menu animations. While usually not an issue, this would give odd behaviors on search and notif popup animations when hovering the main menu while the animations were being performed. (index.css)

! Oops, fixed the *wrong* bug yesterday with regards to saving notification settings... (Notifications.php, Profile.template.php)

! Fixed button icon position in buttons for IE8. This was due to a hack that was no longer needed since the recent button code rewrite. It just goes to show how much I test under IE8... (extra.ie8.css)
Title: Re: New revs
Post by: Arantor on May 8th, 2013, 02:21 PM
(3 files, 1KB)

Revision: 2096
Author: arantor
Date: 08 May 2013 13:18:58
Message:
! Don't show Profile > Posts > Attachments if Attachments are disabled. (Profile.php)
! Remove is-writable test from setting language default. (This page may still be changed yet.) (ManageLanguages.php)
! If only variables should be passed by reference, let's give it a variable. (Aeva-Gallery2.php)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Title: Re: New revs
Post by: Arantor on May 8th, 2013, 10:49 PM
(5 files, 12KB)

Revision: 2097
Author: arantor
Date: 08 May 2013 21:48:46
Message:
! Remove-infraction widget was not set up properly meaning that it would never complete successfully. (Profile-Actions.php)

! A little housecleaning. (MoveTopic.php)

! New feature: ability to specify a new board when splitting a topic. It applies if you could conceivably have moved it after the event (and honours the same restriction about moving *to* boards). There is one edge case whereby if you have permission to move your own topics but not any topics, it will ignore that and just refuse you the option, but that's intentional. There is no shiny 'cool story, bro, but I moved ur topic' dialogue yet. (Split.php, Split.template.php, ManageTopics.english.php)
----
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Themes/default/Split.template.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Title: Re: New revs
Post by: Arantor on May 9th, 2013, 04:38 AM
(11 files, 14KB)

Revision: 2098
Author: arantor
Date: 09 May 2013 03:37:39
Message:
! Some housekeeping is needed before this is called, depending on where it's called from. (ManageInfractions.php)

! Per row styling is now available for generic lists. Just declare in the master definition which column from results should be used for additional classes, or inline styling, and if that column is present in a given row return, use it. (Subs-List.php, GenericList.template.php)

! Better wording for users who are looking at their own infractions list. (Profile.english.php, Profile.template.php)

! Renaming area=userwatch to area=warnings in the moderation centre (ModerationCenter.php, ModerationCenter.template.php)

! Bug fix for moderation filters; seems that providing .val(0) to a select doesn't work if 0 isn't actually an option in the selectbox, though it used to work, but passing .val("") works fine. (ManageModeration.template.php)

! General infractions log now in the moderation centre. Other places that are relevant (e.g. revoking from the log brings you back ot the log) also updated. (ModerationCenter.php, ModerationCenter.english.php, Subs-BoardIndex.php, Profile-Actions.php, Profile.template.php)
----
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php


@ I will probably update the infractions area in the profile itself to use a generic list now that per-row styling is available, it's the only reason I didn't previously.
Title: Re: New revs
Post by: Arantor on May 9th, 2013, 05:37 AM
(6 modified, 4KB)

Revision: 2099
Author: arantor
Date: 09 May 2013 04:37:06
Message:
! Wrong error string. (Profile-Actions.php)

! Improved handling of redirection notices. Specifically: when a redirection notice is now issued, an option is given to the user to automatically redirect. If that option is used, well, it'll do the redirect. Additionally, if the message has been moved to a board the user can't see, instead of the 'no access' message, there's now a specific error: "This topic has been moved to a board that you cannot access." (this is why the board number is stored, it's also used to figure out that hey, we did a redirect, it's just a bonus in that respect) Some minor reorganisation of display workflow was necessary to defer skeleton initialisation to after this was processed, but this shouldn't cause problems. (Display.php, MoveTopic.php, MoveTopic.template.php, Errors and ManageTopics language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Title: Re: New revs
Post by: Nao on May 9th, 2013, 01:09 PM
rev 2100
(6 files, 7kb)

* Merged two isAllowedTo calls into one. (ManageErrors.php)

! Fixed issues related to http-equiv refresh calls. One was a typo dating back to old SMG days I think; the other was conceptual: if you have a semicolon in your URL (which is likely given you're using Wedge, right..?), you don't *need* to turn it into an ampersand, you just need to surround the URL with single quotes... Yup, that was all... (Aeva-Gallery2.php, ManageMedia.php)

* More French translations. Also fixed an issue with 'pre-set' vs 'ad-hoc' in French. (Admin, ManageInfractions, Profile)
Title: Re: New revs
Post by: Arantor on May 9th, 2013, 05:54 PM
(13 files, 4KB)

Revision: ALL YOUR REVISIONS BELONG TO US because in AD 2101...(http://www.youtube.com/watch?v=qE6emvdmg-M#)
Author: arantor
Date: 09 May 2013 16:52:53
Message:
! Calling functions statically that are not declared statically is bad. (Subs-Admin.php)

! The credits function is never called outside of being an action. (Credits.php)

! The old support and credits page has been gone for a while but for some reason the template was hanging around, uncallable. (Admin.template.php, Admin and Help language files)

! Spacinazi (ModerationCenter.php)

! Display the user's multiple badges in the profile. The profile template needs an overhaul sometime though. (Load.php, Profile.template.php)

! Minor tweaks to moderation centre/reported posts, providing information pulled from the DB but never displayed before, also improving i18n slightly. I did set up the French strings but I may not have done it properly :/ (ModerationCenter.template.php, ModerationCentre language file)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Title: Re: New revs
Post by: Nao on May 9th, 2013, 06:31 PM
Was waiting for Pete to use that rev number... :P

rev 2102
(8 files, 8kb)

! Popup height fix didn't work properly on Android devices with a HD screen, due to screen.height being a wrong value for compatibility purposes, or something. Gave up and replaced with window.innerHeight, and I don't care if it's off by a few pixels... It shouldn't be. (script.js)

! Fixed error log's file viewer sometimes giving you a login confirm box. Because the popup wasn't designed to hold these, I've rewritten the admin check code to determine whether it's called from Ajax (as in the file viewer), and if yes, silently redirect the user to a full page. Better than a broken form, really..! (Subs-Auth.php)

- Removed forced windowbg on help popups; this would cause some bad styling when the popup is shown as a full page. This breaks styling on IE7, which I don't care about, because it just goes to show how IE7 is buggy... I'll fix that later, yay. (GenericPopup.template.php)

* More French translations. Fixed mc_warned_users_points string, which wasn't in the original commits (good thing I checked the English version for once...) (Errors, ManageInfractions, ManageTopics, ModerationCenter, Profile)
Title: Re: New revs
Post by: Arantor on May 9th, 2013, 11:13 PM
(6 modified, 1 new folder, 10KB)

Revision: 2103
Author: arantor
Date: 09 May 2013 22:12:33
Message:
! Likes were broken if for any reason you tried to immediately follow up on an (un)like with a reverse of it because the return value was not passed through the buffers, so return_raw() is out, but because return_text flushes buffers first, we have to start a new buffer, capture the content, then pass it to return_text(). Either that or rewrite the template to return values and then output from wherever it's called from. I'm satisfied with what I've done for now though. (Like.php)
+ Contact list is now shown in the PM area, allowing you to send a PM to/bcc your contacts. As I intimated I'm not overly happy with the JS I've done here, it feels fragile and ugly and yet more organised than before. Feel free to rewrite/refactor/ignite. (PersonalMessage.template.php, PersonalMessage.template.php, pm.js, index.member.css, PersonalMessage language file)
! As discussed, a new folder for notifiers to be put into for organisation. The folder needs to exist before SVN will accept the move. (notifiers)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/PersonalMessage.php
Added : /trunk/Sources/notifiers
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/skins/index.member.css
Title: Re: New revs
Post by: Arantor on May 9th, 2013, 11:15 PM
(1 modified, 1 moved, 1KB)

Revision: 2104
Author: arantor
Date: 09 May 2013 22:14:54
Message:
! Move likes notifier to notifiers folder - we'll have more in future. (Notifications.php, Class-NotifierLikes.php)
----
Deleted : /trunk/Sources/Class-NotifierLikes.php
Modified : /trunk/Sources/Notifications.php
Added : /trunk/Sources/notifiers/Class-NotifierLikes.php (Copy from path: /trunk/Sources/Class-NotifierLikes.php, Revision, 2100)
Title: Re: New revs
Post by: Nao on May 9th, 2013, 11:41 PM
(What? Likes are broken?! I need to look into that code... Will have to do that tomorrow, though.)

rev 2105
(10 files, 6kb)

! Some fixes for popup dimming in oldIE, and removing support for responsive design in IE6/7, because it's just too messed up. Keeping it in IE8 because it's more sensible. Also fixed main menu position in IE8 (it still has a glitch, but I don't care at this point), and table-layout not being needed in IE 6/7. (Load.php, index.css, sections.css, Wine/extra.css)

! Had a hardcover responsive media query value left in... (extra.rtl.css)

! Some nbsp-related fixes. Basically, what happened is that I noticed in my Win XP virtual box that IE doesn't support Unicode 3.0 entities in there; the same in Windows 7 work fine. And any other browser in Win XP seems to work fine. So that's just that combination... I threw in mobile devices in the process, because I can't be sure whether they support it, as it's probably not too memory efficient, so whatever, it's just the pedantic French translator talking and making everyone else waste a CPU cycle with a str_replace that will wield no results. I'm odd. Pete, you have my authorization to add a language test before it, if you want, because it's unlikely any other translator will use my obscure entity... ;) (Subs-Template.php, Admin.english.php (sic), ManagePlugins.french.php, ManageSettings.french.php)

* More translations. And I'm far from finished, since I have ManageInfractions left to complete... Hmmmmmmmm. (ModerationCenter.french.php)
Title: Re: New revs
Post by: Nao on May 10th, 2013, 12:49 AM
rev 2106 -- just all my remaining fixes before going to bed.
(5 files, 2kb)

! In the end, IE7 *did* need that table layout rule... (index.css)

! And IE8 still had issues with its main menu. I finally figured that I needed to disable the filter for it to work. Uh... (extra.ie8.css)

* Translation. (PersonalMessage.french.php)

* Commenazi. (Security.php)

* Optimization of JS code. Saves 0 bytes. Happens even to me. (pm.js)
Title: Re: New revs
Post by: Nao on May 11th, 2013, 06:35 PM
rev 2107 -- with another one coming up in a few minutes.
(4 files, 2kb)

! Fixed a bug where URLs like /profile/?u=123 would ignore the u parameter (member ID), and instead redirect to your profile. (QueryString.php)

* No need to define that variable..? (ManageBans.php)

* Pedant optimizations. Really, I'm not even sure it saves time... But don't complain too much; I could have used a single-line call_user_func on that variable function, saving three lines but doubling execution time by, err... Half a micro-second per pretty URL filter. I told you, it's a pedant optimization. (Subs-Template.php)

* Commenazi. (PrettyUrls-Filters.php)
Title: Re: New revs
Post by: Nao on May 11th, 2013, 06:36 PM
rev 2108 -- okay, maybe not 'a few minutes' after all... More like a few seconds.
(5 files, 6kb)

+ Added a new return_* helper function, return_callback, which accepts a string representing a function name (usually a template), followed with an array of arguments (or nothing). This allows you to use the return_* system with a function that will echo its output, instead of returning it in a string. Replaced Like handling with this. (Like.php, Subs.php)

* Rewrote pm.js "my way", with Pete's blessing. This saves about 500 bytes, and 150 when gzipped. Not bad for something that does exactly the same... (pm.js)

! Minor auto-suggest bug. Item count shouldn't be increased if the hook called right after it decides to prevent adding an item... This wasn't found until now, because no hooks were called so far anyway... (suggest.js)

! And they wouldn't have worked anyway. Fixed a sorry bug where I was calling the hook with .call(function), instead of .call(this, function). And that was an old one..! (suggest.js)

! overflow-y: scroll always shows a scrollbar, even if you don't have many contacts. Fixed to overflow-y: auto. (index.member.css)
Title: Re: New revs
Post by: Nao on May 12th, 2013, 12:13 AM
rev 2109 -- before jumping to bed...
(5 files, 2kb)

* More pedantic optimizations. Despite everything you'll hear, strpos($str, $substr) === 0 is slower than $str[0] === $substr. Deal with it. (Class-Package.php, ManageErrors.php, QueryString.php, Security.php)

* Commenazi. This one's for Pete... ;) (Subs.php)
Title: Re: New revs
Post by: Nao on May 12th, 2013, 07:33 PM
rev 2110
(3 files, 3kb)

! Fixed JavaScript errors in Thought threads, when at least one of the thoughts in the thread was deleted. Wedge was showing an action menu for these... (Thoughts.template.php)

* Finished translation... Phew! I hope I didn't forget anything. Also fixed a typo in the English version. (ManageInfractions.english.php, ManageInfractions.french.php)
Title: Re: New revs
Post by: Arantor on May 13th, 2013, 01:02 AM
(51 files, 34KB)

Revision: 2111
Author: arantor
Date: 13 May 2013 00:02:22
Message:
! New user sanction: scrambling the letters of each word except the first/last letter. (ManageInfractions.php, Subs-BBC.php, ManageInfractions.english.php)
! New admin page for configuring the bbc editor. The plan is to have a drag 'n' drop thing to move the buttons around too but I haven't gotten to that yet. Apologies, Nao, code is a shade ugly :( (Admin.php, Class-Editor.php, ManagePosts.php, editor-func.js, editor.js, Admin and ManagePosts language file)
! Refactored parse_bbc semantics, as documented in Subs-BBC.php. This new setup allows us to expand upon things like not parsing embeds for signatures into things like not parsing embeds for feeds too. Just a thought. I don't think I broke anything, I checked for syntax errors everywhere (automatically) and checked the list of parse_types, should be all good. (all the other files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Thoughts.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-ModCP.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/Thoughts.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/Themes/default/languages/ManagePosts.english.php
Modified : /trunk/Themes/default/languages/ManagePosts.french.php
Modified : /trunk/Themes/default/scripts/editor-func.js
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Arantor on May 13th, 2013, 02:49 AM
(2 modified, 6KB)

Revision: 2112[1]
Author: arantor
Date: 13 May 2013 01:48:08
Message:
! Actually get the board index using the last report and last group request. I am aware the count is still wrong for requestable groups but that's mostly down to the current fundamental flaws in requestable groups. (ModerationCenter.php, Subs-BoardIndex.php)
! Don't show the group requests option in moderation centre if there aren't any requestable groups at present. (ModerationCenter.php)
----
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-BoardIndex.php
 1. I want my life back, Jeff Minter! Llamatron stole too many hours from me as well as Revenge of the Mutant Camels!
Title: Re: New revs
Post by: Nao on May 13th, 2013, 12:31 PM
rev 2113 -- a helpful commit with an unlucky rev name, ahh, shit happens :P
(7 files, 5kb)

! Disabled that annoying font boosting in Chrome for Android, which has been killing most, if not all, forum systems by making short posts tiny and long posts huge (wouldn't the *other way around* make more sense, really...?) I believe Wedge is the first to 'fix' it, but I wouldn't bet on it. The fix is actually documented if you search for long enough. I've adopted the shortest possible fix that worked on my S3, but will keep doing more tests. Need to test on my iPod as well... Haven't turned on that one in a loooong time... (index.css)

! Fixed notifications generating JS errors in oldIE when polling for new results. Also saves 2 bytes from the final file... (script.js)

* Given that personal_text is no longer directly linked to thoughts, I figured it should revert to its original title... Or not? (Profile.english.php, Profile.french.php)

* Translation. (Admin.french.php, ManageInfractions.french.php)

* Spacinazi. (Display.php)

@ I wrote the scramble code from rev 2111... It was a quick idea and only took a few minutes to implement a basic version, but I still want the credit, eheh :P
Title: Re: New revs
Post by: Arantor on May 14th, 2013, 06:24 PM
(83 files, 7KB)

Revision: 2114
Author: arantor
Date: 14 May 2013 17:23:27
Message:
! Removing the << toggle from the areas with generic menus. (Admin.php, Subs-Menu.php, GenericMenu.template.php)
! Getting rid of an old friend from the moderation centre, related to the old warning system. (ModerationCenter.php)
! Getting rid of what look like some unused global variables. I haven't been able to get errors out of anything with this. (all files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Pin.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/Aeva-Subs-Vital.php
Modified : /trunk/Sources/media/Class-Media.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/other/Sphinx/SearchAPI-Sphinx.php
Modified : /trunk/other/Sphinx/sphinx_config.php

(I have a feeling the Sphinx stuff will become a core feature at some point, just needs some updating and tweaking)
Title: Re: New revs
Post by: Nao on May 14th, 2013, 07:04 PM
rev 2115
(41 files, 15kb)

* Updated parse_bbc() params to look like this: message, then type, then options array. Among the options, 'parse_type' is thus removed, 'parse_tags' becomes 'tags', and 'owner' becomes 'user'. Both type and options are optional, the first will fall back to 'generic' (should it be 'post'..?), the second to the default options. (41 files)

! The Welcome parse_bbc calls had their user param set to 'id_member', rather than $row['id_member']. (Welcome.php)

* The Display parse_bbc, out of all parse_bbc calls, is one that 'missed' setting a 'post' type. Lulz. (Display.php)

! SSI had another missing type, as well as an incorrect option array (it just had a string, without a key.) (SSI.php)

! unparsed_equals handler didn't use the rewritten parse_bbc format. Hopefully I didn't mess it up. Wondering if it's worth transmitting the 'parent' parse type to children, but my guts say it is... (Subs-BBC.php)
Title: Re: New revs
Post by: Nao on May 15th, 2013, 05:42 PM
rev 2116 -- just a couple of fixes; I'm working on improving Wireless for actual mobile devices, but it's not ready yet...
(2 files, 2kb)

! A site-breaking typo. Oops. Twice. And I didn't even use copy and paste... (Thoughts.php)

! I'm not exactly great at optimizing SQL queries so I'll leave that one up to Pete, but I fixed the stats query that retrieved 'most liked authors' (and I'm still a distant second, so I'm *definitely* leaving it up to him eheh). To be specific, on wedge.org there was a third 'empty' entry with 178 likes; it was actually the total number of thought likes. I decided to allow for the query to also take thought likes into account, dunno if it will kill performance, but what matters for now is that it works... I don't even know if we'll keep that stat entry around forever. (Stats.php)
Title: Re: New revs
Post by: Arantor on May 16th, 2013, 08:19 PM
(19 files, 13KB)

Revision: 2117
Author: arantor
Date: 16 May 2013 19:18:38
Message:
! Forgot to commit this previously, more global variables not used in the templates. (ManagePaid.template.php)

! Oops, wrong variable. (ManageInfractions.php)

! Guests should never be shown infraction status of a user, no matter what. (Profile-View.php)

! Who's Online could return exciting and incorrect values for viewing in the profile. E.g. user 1 is viewing their own profile, user 2 is viewing user 1's profile, user 2 would see 'Viewing User 2's profile' because the user id is not otherwise available. (Profile-View.php, Who.php)

! No more of this 'enabling deny permissions'. They're always enabled now. $helptxt['permissions_deny'] might still be useful though, so leave it around for now. (wedge_api.php, Load.php, ManagePermissions.php, Reports.php, Subs-Post.php, ManagePermissions.template.php, ManagePermissions language file)

! Custom field data wasn't loaded for loadMemberData(...., 'userbox') but it's kind of important that it is. (Load.php)

! Custom fields now have controls for group visibility and editability. Note that the system is designed in a funky way in case people have funky needs like wanting to create a field that a user can edit but that won't be visible to them on their summary (owner + respective groups have "can edit", those who should be able to see it have "can see", so there's no magic greying out of textboxes) (install.sql, Load.php, ManageMemberOptions.php, Memberlist.php, Profile.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/tools/wedge_api.php
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Nao on May 16th, 2013, 11:37 PM
A reasonably big update, with the introduction of the topic privacy UI and improvements on thought privacy. Hopefully everything works fine. I won't update the site to this today, because it's too late for me, and I don't want to break too many things. Notes to Pete:
- please, please double-check this update. As thoroughly as possible. I triple-checked my commit and made many changes, I'm *extremely* wary of the idea of having introduced any security issues. Topic privacy is a serious thing...!
- if you edit a topic here, you'll get an error in the log... No biggie, it's just something I forgot to update. It won't happen locally.

rev 2118
(11 files, 12kb)

+ Finally implemented the UI for topic privacy...! I spent months postponing this because I thought I had to do the query_see_topic implementation as well. Turned out that it was done in late February 2012, over 700 revisions ago... So, yes, it STILL needs a lot of testing. But it wasn't too hard to implement topic privacy at Noisen.com back in 2007, so I don't see why it should be much of an issue for me in 2012, damn it! (Post.php, Post2.php, Subs-Post.php, Post.template.php, index.member.css)

@ To-do: allow quick edits to change topic privacy, move privacy icons out of member CSS if it's possible for a guest to create a new topic... (Pete, what do you think..? I don't even remember if it's possible, but I think it is...)

+ Added proper support for contact lists in thought privacy, instead of that hacked version targeted for Wedge.org. (Class-System.php, Thoughts.php, Thoughts.template.php)

! A missing query_see_topic..? There are probably tons more. While accessing the topics table doesn't automatically guarantee adding a query_see_topic to it, there are still over 250 access to it, and only over 50 query_see_topic calls, but all of the 'natural' ones were already there. (JSModify.php)

- As inspired by Pete, removed unneeded $db_prefix and $scripturl globals. :D (Aeva-Gallery.php, SSI.php)

* Spacinazi, indenazi. (JSModify.php, Load.php)
Title: Re: New revs
Post by: Nao on May 16th, 2013, 11:40 PM
rev 2119 -- oops.
(3 files, 3kb)

! Forgot to commit the Thoughts.template.php file mentioned in the last rev... (Thoughts.template.php)

! This also fixes a bug in thought threads, where the master thought doesn't have an action button. (Thoughts.template.php)

* Also committing index language updates for the privacy select box... Heck, I forgot to hit F5 before compiling my list of files to commit. (index.english.php, index.french.php)
Title: Re: New revs
Post by: Arantor on May 17th, 2013, 04:54 AM
(5 modified, 2KB)

Revision: 2120
Author: arantor
Date: 17 May 2013 03:54:02
Message:
! Indentinazi (ManageMemberOptions.php)

! Don't do the permissions check on custom field visibility on memberlist if you're an admin, because there's no need. (Memberlist.php)

! DIE OLD SIDEBAR CODE. (Subs-Menu.php, ManageMemberOptions.php, Profile language file)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Title: Re: New revs
Post by: Nao on May 18th, 2013, 05:11 PM
rev 21+21 = 42 -- am bored of not committing this old stuff... :P
(7 files, 6kb)

* A bit of allowedTo/isAllowedTo refactoring. Not much, really... Just wanted to make it clearer that isAllowedTo supports multiple permission requests; more importantly, rewrote allowedTo for multiple permissions, speeding it up by potentially hundreds of times... (Security.php)

* arraydefinitionazi. (Security.php)

+ Added a 'Privacy' title when applicable in Post page, and reworked layout to allow for the post title input to take all remaining width. Along with a media query for smaller widths... (Post.template.php, index.english.php, index.french.php, editor.css, extra.ie6.css, extra.rtl.css)
Title: Re: New revs
Post by: Nao on May 19th, 2013, 10:10 AM
rev 2122 -- minor commit, sorry...
(6 files, 2kb)

! Non-topic edits gave an undefined index error. (Post.template.php)

* Tweaked editor CSS to prevent the contact list from breaking its layout too easily. Also moved #contactlist code to editor.css, along with a member test. Makes more sense. (editor.css, index.member.css)

* Spacinazi. (ManageMemberOptions.php, Security.php, Subs-BBC.php)
Title: Re: New revs
Post by: Arantor on May 21st, 2013, 04:24 AM
(14 modified, 1 deleted, crap I forgot one as Packages-Get should have died too, I'm blaming the rum, 3KB)

Revision: 2123
Author: arantor
Date: 21 May 2013 03:23:14
Message:
! Unnecessary extra globals. (Subs-Cache.php, Subs-Captcha.php)

! There's no need for the admin inclusion when in short order we proceed to run a hook which can actually *do* something anyway. (Admin.php)

! We have loadSource, let's use it. And just for kicks, since a bunch of array('file', 'function') had the same things, I made it into just array('file'). Could even have gone really mad and made it a string but that seemed like one step too far, you know? After all, I only wanted to get shot of the use of $sourcedir, everything else just sort of 'happened'. (index.php)

! I finally realised that there really was no need to keep the random stuff around for the old package manager, if I wanted it, I had SVN but really there wasn't much I thought I might have found useful, so removed a bunch of stuff. There are still tendrils elsewhere that haven't been cleaned up yet, but I'm getting to it. (Admin.php, PackageGet.php, Security.php, Subs-Package.php, Packages.template.php, language files: Admin, Errors, Packages, Who)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Package.php
Deleted : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/index.php
Title: Re: New revs
Post by: Nao on May 21st, 2013, 05:42 PM
rev 2124 -- feel free to revert if not to your taste..? I just felt like doing that, and liked it enough to commit...
(11 files, 7kb)

* Refactored action array a bit more, inspired by Pete's work... Aligned all entries to make them more readable (well, if your tab size is 4 spaces, as should be...), converted all array('Function') to just 'Function' (it only takes an extra line to account for this, and is probably faster due to not having to create the array structures), shortened verificationcode action name to fit the tab rewrite, converted Boards and Logout actions to strings (they didn't need to be in an array in the first place), and renamed several functions to match their container file when it made sense. Phew... Saves nearly 500 bytes out of the total index file size, so it's all good. (index.php, Admin.php, Groups.php, Mailer.php, ManageSettings.php, ModerationCenter.php, PersonalMessage.php, PostModeration.php, Subs-Editor.php, Themes.php, VerificationCode.php)

! Commenazi -- fixed a file containing a comment an accent encoded in ISO-8859-1. (ManageSettings.php)
Title: Re: New revs
Post by: Nao on May 21st, 2013, 06:05 PM
rev 2125 -- all of the rest...
(8 files, 5kb)

* Made the Chrome for Mobile fix more generic, by applying it to the universal selector. All elements need it really, even though 99% of the issues stem from table cells (which is also why 99% of all problematic websites in Chrome 25+ are forums... Eh.) (index.css)

+ Added ability to easily restyle mini-menu fonts. (index.css)

! Fixed PM contact list box breaking layout in smaller screens. (editor.css)

* Refactored CSS filename generation, to something more acceptable. To me, at least... It basically calls array_filter twice instead of once (to deal with 0's, see below), and avoids doing a useless preg_replace. Plus, the code is shorter this way. (Subs-Cache.php)

! Fixed the odd '0-guest' CSS filenames generated when serving content to a bot, or any client that doesn't provide an actual browser or OS name. (Subs-Cache.php)

! Fixed hardcoded text in the custom profile area. And other things. (ManageMemberOptions.php, Admin.template.php, ManageSettings.language.php)

* Translation. Changed "entrée" to "saisie" as translation for "input", as it suddenly sounded better to me... (ManageSettings.french.php)

* No biggie, but I think that an strpos() is faster than a substr_count()... (Subs-Template.php)
Title: Re: New revs
Post by: Nao on May 21st, 2013, 09:05 PM
rev 2126
(6 files, 2kb)

* Considering that thoughts are the only thing in Wedge that currently use parse_bbc_inline, and I've wanted to use the long list for them for a long time, I've decided to disable $short_list by default. (Subs-BBC.php)

! The me tag has no reason (that I can think of) to be a block-type. Made it an inline object. (install.sql)

! Fixed an error that showed up when viewing a page from a mobile browser, a regression from last commit. (Subs-Cache.php)

* Tweaked layout for custom field management. No biggie... (Admin.template.php)

* Minor language tweaks. Plus, ahem, forgot to translate the very same string I added to ManageSettings... (Admin.language.php, ManageSettings.french.php)
Title: Re: New revs
Post by: Nao on May 21st, 2013, 10:01 PM
rev 2127 -- and that'll be all for tonight... I hope!!
(3 files, 2kb)

! Forgot to include Subs-Cache fix to last commit... Oops. (Subs-Cache.php)

! Fixed error when quick-editing a post during the grace period. In fact, parse_bbc() should always set posts as coming from the original author, rather than the one who edited it. Also rewrote something to make it shorter and execute faster. (JSModify.php)

* Did some more work to improve Wireless on Android. Unfortunately, this means I had to add a few odd fixes here and there, due to Android not actually showing stuff as expected. See the Recent Posts page... Brr. Well, better than nothing. I probably broke some other mobile browser in the process, but I can't test them all... (Wireless/extra.css)
Title: Re: New revs
Post by: Arantor on May 21st, 2013, 11:33 PM
(9 modified, 4 deleted, 3KB)

Revision: 2128
Author: arantor
Date: 21 May 2013 22:33:05
Message:
! Meant to commit this deletion yesterday. (PackageGet.php)

! Streamlined the language editing area, there's no need for the settings page when it's all on the main languages page, including now setting which languages are selectable by users. This will need to be set on wedge.org. (Admin.php, Load.php, ManageLanguages.php, Admin and Help language files)

! Removed the 'add language' area. Languages tend to be a one-time thing, so it's OK to not have a super friendly interface. Allows decluttering of a bunch of code that would have needed a total rewrite anyway. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings and Packages language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageLanguages.php
Deleted : /trunk/Sources/PackageGet.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Deleted : /trunk/Themes/default/languages/Packages.english-uk.php
Deleted : /trunk/Themes/default/languages/Packages.english.php
Deleted : /trunk/Themes/default/languages/Packages.french.php
Title: Re: New revs
Post by: Arantor on May 22nd, 2013, 04:06 AM
(2 files, 3KB)

Revision: 2129
Author: arantor
Date: 22 May 2013 03:06:15
Message:
! Moderation centre function needed to be updated to tie in with index.php changes. (ModerationCenter.php)

! Fixing the privacy checking code on custom fields. (Profile-Modify.php)
----
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Modify.php
Title: Re: New revs
Post by: Arantor on May 23rd, 2013, 04:11 AM
(4 modified, 6KB)

Revision: 2130
Author: arantor
Date: 23 May 2013 03:11:25
Message:
! Database error during newsletter sending. (ManageNews.php)

! Improved UI for sending newsletters, including removing ridiculous SMF logic of hiding post count groups if post count permissions are disabled. (ManageNews.php, ManageNews.template.php, mana.css, Admin language file)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/skins/mana.css
Title: Re: New revs
Post by: Arantor on May 23rd, 2013, 04:13 PM
(11 modified, 13KB)

Revision: 2131
Author: arantor
Date: 23 May 2013 15:11:28
Message:
! Indefinitely long infractions lasted very long indeed... right up until the next page load. (ManageInfractions.php)

! The user shouldn't be told they are post/PM banned if only one of those things is true. (Security.php, Subs-Template.php, index.english.php)

! Admins can now get people to re-agree to the reg agreement. There's also a few related changes that are needed to make this stuff work, since we don't want to quietly remove certain types of warning status when we shouldn't. At least, it seems to work for me... (CoppaForm.php, ManageRegistration.php, Profile-Actions.php, Reminder.php, Subs-Login.php, Register.template.php, Admin language file)
----
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on May 23rd, 2013, 10:57 PM
rev 2132
(6 files, 5kb)

* Had some room for improvement in wedge_get_css_filename... Rewrote to use array keys instead of values, so it's about twice faster now (we're talking about fractions of a milliseconds, so whatever... I like saving time, all right?), and also removes the 'member' keyword if a 'mID' keyword is already present (ID being your member ID). (Subs-Cache.php)

* Tweaked 'time remaining' box in the admin area to give breathing space to the menu below, hey, it's just three extra bytes... (Admin.template.php)

+ French translation. (Admin, Help, ManageSettings)
Title: Re: New revs
Post by: Nao on May 24th, 2013, 11:10 PM
rev 2133 -- I really, really wanted to commit all of this now... Even though I'm quite ashamed of how I implemented the first feature in the list... :(
(22 files, 7kb)

+ Added more flexibility to auto-suggest popups, by determining the minimum applicable characters depending upon the number of members of your forum. It may seem like nothing, but on smaller forums, when you're typing 'Nao' and it only suggests me after you type those three letters, it just seems silly... The number of members I determined is arbitrary, feel like to change it. Even the function name, and the way it's used in auto-suggests, can be changed to whatever one feels works best... Really, I'm not fussed. Feel free. Have a drink and tell me what you want. (ManageBans.php, Aeva-Gallery2.php, ManageMedia2.php, Subs.php, ManageBoards/Maintenance/Membergroups/News/Paid.template.php, Media.template.php, PersonalMessage.template.php, Profile.template.php, pm.js, suggest.js)

* Renamed wePersonalMessageSend() to weSendPM()... Seriously, I don't know how it managed to survive with that name for so long... And the object creation also had a left-over unused param. (PersonalMessage.template.php, pm.js)

* Renamed url-no-base64() to raw-url(). While no-base64 is easy to understand for developers, it might not be for themers, so I thought it best to just use plain regular English. Behavior is the same. (Class-CSS.php, Subs-Cache.php, common.css, index.css, index.member.css, mana.css, sections.css)

* Tweaked error box padding. Again. This time it's for the main post page... (sections.css)

* Translation. (index.french.php)
Title: Re: New revs
Post by: Arantor on May 26th, 2013, 11:39 PM
(9 files, 12KB)

Revision: 2134
Author: arantor
Date: 26 May 2013 22:38:23
Message:
! Improved maintenance: allow moving old topics based on number of days, picking source boards, that kind of thing. I even tried to get the translation right. (Oh, yes, I did also clean up the strings slightly to fix compounding issues.) (ManageMaintenance.php, ManageMaintenance.template.php, ManageMaintenance language file)

! Remove bulk topics: there are two kinds of locked topics, not accounted for in SMF either, also in our case it's possible that the remove topics function could be called, legitimately, for a topic that no longer exists. This should be able to be handled safely without an error (intentionally) (RemoveTopic.php)

! When approving posts, the last message id needs to be recalculated otherwise weird things can happen, like messages you can't actually mark as read. (Subs-Post.php)

! Post moderation status needs to be maintained more than before now there are other ways to get posts moderated that aren't related to the moderation filters. (Load.php, ManageModeration.php, Post2.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Title: Re: New revs
Post by: Nao on May 27th, 2013, 10:53 AM
rev 2135
(7 files, 8kb)

+ Added a hover preview of posts that triggered a notification. A good start! Still needs work, but it works for now. Also added a get_single_post() helper function which might need some love from Pete (security-wise maybe?) if we use it elsewhere... (Class-Notification.php, Notifications.php, notifiers/Likes.php, Subs.php, script.js, index.css)

* Renamed Class-NotifierLikes.php to just Likes.php (Notifications.php, notifiers/*)

* French tweaks. (ManagePermissions.french.php)
Title: Re: New revs
Post by: Nao on May 28th, 2013, 10:56 PM
rev 2136 -- first batch...
(5 files, 3kb)

! Fixed not being able to Like a thought when its privacy was set to 'Contacts'. And another similar bug in the Welcome area, but whatever. (Like.php, Welcome.php)

! Fixed JavaScript error in mobile devices when visiting forum in guest mode. I actually had to reinstall the Android SDK and do remote debugging to figure it out... Why doesn't Chrome have a friggin' error console..?! (Thoughts.template.php)

! Missing global. Probably broke thought threads in some situations; never experienced, though... (Thoughts.template.php)

! Fixed post options alignment on mobile... Blah blah. (editor.css)

! Fixed select boxes triggering the change() event even when on a disabled or hidden item, if by any chance you hit the Tab key -- for instance, click the quick access select box, then hit Tab... And there you go, a bug. (sbox.js)
Title: Re: New revs
Post by: Nao on May 28th, 2013, 11:09 PM
rev 2137 -- last batch.
(4 files, 3kb)

* Rewrote notification popup's way of showing previews. Instead of showing a side panel for the currently hovered notification, Wedge now expects you to click the notification item and it will show the preview below the item, making it possible to view previews in smaller screens. Relatively easy to revert, in case it's needed. (Notifications.template.php, script.js, index.css)

! Fixed smileys on mobile. It seems that Chrome for Android made some recent change to the way they handle a line-height of zero, thus hiding smileys entirely. This new technique is also faster to render, says Jeffrey Zeldman. Also applied the same fix to BBC links. (index.css, sections.css)

* Also updated select boxes to be shown, while still off-screen, now a bit less further away, ahem, a thousand times closer in fact... It should still be enough, and I have no other solution right now that still preserves change/focus events set directly on the select box. So, a thousand times closer it will be. (index.css)
Title: Re: New revs
Post by: Nao on May 29th, 2013, 11:02 AM
rev 2138
(6 files, 3kb)

! Fixed subjects and messages sometimes not allowing a single content of '0' (thanks John). Although it's unlikely you'll want to use that, it still should be allowed... Otherwise, why allow for '1'? Also of note, I removed a safety from the draft code in PersonalMessage.php, I don't think it was needed at all. Pete might wanna have a look though... Just to be sure, since it's his code. (Display.php, PersonalMessage.php, Post.php, Post2.php, Profile-View.php, Search2.php)
Title: Re: New revs
Post by: Nao on May 29th, 2013, 11:15 PM
rev 2139 -- yay, micro-optimizations..?
(6 files, 4kb)

+ Added support for rect() retro-compatibility to Wess. Specifically, IE 6/7 expect commas not to be used, so you're now free to use the standard commas, and IE 6/7 will remove them. Just, hmm, don't use silly unrelated comma-separated values inside your rect() function, but... There's no reason to, is there..? (Class-CSS.php)

* Increased execution speed for retro-compatibility code. Initially, I was doing a smart implode on all test strings, to run a single preg_replace_callback. After a couple of tests, I realized that doing them individually, whatever the number of tests, was 5 to 10 times faster. Okay, then... I guess sometimes, benchmarking isn't a waste of time. (Class-CSS.php)

* Theoretically, increased execution speed for CSS layout, as I definitely gave up on text-indent hacks to focus on clipping. Costs a few extra bytes, but it's safer, and seems to work just fine in all browsers I tested in. (index.css, sections.css)

- Profile statistics added some redundant HTML that was subsequently hidden by CSS. Yeah, sure. Removed said HTML and its related CSS hack. (Profile.template.php, sections.css)

- Moved profile statistics pie to external. Seriously, there never was a need to embed this one, as it's only seen on one obscure profile page, and it saves a whooping 1.5KB from the final CSS file. Hopefully, I didn't miss anything else... I guess..? (sections.css, extra.rtl.css)

! A quick and easy fix to hide the related notification preview, if opened, if you attempt to mark the notification as read. (script.js)
Title: Re: New revs
Post by: Arantor on May 30th, 2013, 03:56 AM
(9 modified, 16KB)

Revision: 2140
Author: arantor
Date: 30 May 2013 02:55:43
Message:
! Too many places need SimpleXML for it not to be a dependency at install-time, I'd say. (install.php, Install.english.php)
! number_context could get screwed up if the number being formatted would have had a comma in it but the array entry not. Which could be a problem... so better to not go there. (Subs.php)
! If in the moderation centre, highlight the right menu button, the moderate menu is under the admin menu... (Subs.php)
! Display the posts of a user that generated reports inside their profile. (Profile.php, Profile-View.php, Profile, Profile language file)

:edit: Forgot this on the changelog: ! Move the action hook earlier for those rare cases it does need to be done dynamically. (index.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Profile.english-uk.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/index.php
Modified : /trunk/root/install.php
Title: Re: New revs
Post by: Arantor on May 30th, 2013, 05:56 AM
(7 files, 8KB)

Revision: 2141
Author: arantor
Date: 30 May 2013 04:54:45
Message:
! Buffer hook couldn't load files properly, poor hook. (Thanks live!) (Subs-Template.php)

! Ability to merge current members. Seems to work for me. Does not handle drafts or PMs and probably some other stuff too. The destination account keeps its own profile settings etc., none of those are imported from the source account. Also includes a bonus hook for notifying plugins about reattribution in case plugins want to update their stuff too. (ManageMaintenance.php, ManagePlugins.php, Subs-Members.php, ManageMaintenance.template.php, ManageMaintenance and Modlog language files)

! Reattribution does actually bother to fix reported posts now. (ManageMaintenance.php)
----
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Title: Re: New revs
Post by: Nao on May 30th, 2013, 06:11 PM
rev 2142 -- What is twenty-one times two?
(6 questions, 4 answers)

! Create cache.lock file at install time, so we don't have to deal with it later. Also removed a few unused globals. (install.php)

! dynamic_group_colors function was using MySQL, which killed the install process when showing the HTML header. (Subs-Cache.php)

* Simplified cache_put_data/cache_get_data functions by moving their (similar) init code to a stand-alone function. Harmonized another function to use the same naming scheme. (Subs-Cache.php)

* French translation. (Install, ManageMaintenance, Modlog, Profile)
Title: Re: New revs
Post by: Nao on May 30th, 2013, 06:38 PM
rev 2143
(1 sin, 498 bytes) (I think it's the first time I'm getting a commit size in *bytes*, really...)

! Apparently, not fourty-two. Because I love doing meself some last-minute refactoring with an extra layer of bugs. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on June 1st, 2013, 12:26 AM
rev 2144 -- just to get this one out of the way, I guess...
(1 file +2-2, 178kb)

* Updated jQuery to versions 1.10 and 2.0.1, as Google is now hosting them. They're one week late! (Load.php, jquery-1.10.0.min.js, jquery-2.0.1.min.js)
Title: Re: New revs
Post by: Arantor on June 1st, 2013, 05:57 AM
(9 modified, 3 added, 10KB)

Revision: 2145
Author: arantor
Date: 01 June 2013 04:56:35
Message:
! Create a language files for boards as Nao suggested recently. (Subs-BoardIndex.php, index and Boards language files)

! Move a language string into the post file, it's only ever used in the editor. (index and Post language files)

! For the lists of reported posts, also show the board that the post is currently in. (ModerationCenter.php, Profile-View.php, ModerationCenter.template.php, Profile.template.php)
----
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Profile.template.php
Added : /trunk/Themes/default/languages/Boards.english-uk.php
Added : /trunk/Themes/default/languages/Boards.english.php
Added : /trunk/Themes/default/languages/Boards.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Title: Re: New revs
Post by: Nao on June 3rd, 2013, 10:02 PM
rev 2146 -- just to get these out of the way, 'mkay..?
(1 file +2-2, 179kb)

* Updated jQuery to newest versions (2.0.2/1.10.1), as this time Google was prompt enough to update them immediately, yay. (Load.php, jquery-*.min.js)
Title: Re: New revs
Post by: Nao on June 3rd, 2013, 10:07 PM
rev 2147 -- all of my current committable work -- and Dragooon's.
(5 files, 3kb)

* Committing a few changes to the structure of the contact list tables. They still aren't in use, but I wanted to have them in, just so Pete can protest/revert the changes, in case he finds them to be ineffective. (I'm never too sure about my work on MySQL performance, he's my god when it comes to that.) The idea is that list IDs should be linked to the owner ID, so that they don't get a list URL like action=profile;sa=contacts;in=12345, or something like that, but a shorter number instead, yeah, that totally deserves 4 lines of description in this commit, eh..? (install.sql)

* Applied Dragooon's patch that promotes my avatar code hack to a more generic status, yay again. (Class-Notifier.php)

* Applied Dragooon's patch that promotes my member_from code hack to a more gen... "Hey, haven't I done you before?" (Wowbagger, Class-Notification.php, Notifications.php, install.sql)

@ Fixed patch's cache flushing code, to use null instead of array(), as per Pete's suggestion, and use the proper TTL (86400), as per my own non-suggestion, but whatyagonnado. (Class-Notification.php)

! Looks like it's possible for a message to be emptied entirely by parse_bbc, as evidenced by an error in my log some time ago, so I'm adding a fail-safe that should cost no extra cycle. (Subs-BBC.php)
Title: Re: New revs
Post by: Nao on June 3rd, 2013, 11:49 PM
rev 2148 -- only a partial fix, as I have more errors to look into, but apparently limited to me, so I'm not in a hurry, ah ah...
(2 files, 1kb)

! Fixed a missing 'return' in the last patch, causing a cascade of errors in notifications. (Class-Notification.php)

! I also have my share of untested code, though: a missing $st variable in the latest Subs-Cache refactoring. Uh oh. Now that fix looks ugly... (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on June 4th, 2013, 08:05 PM
rev 2149
(2 files, 1kb)

! I actually swapped parameters when calling cache_prepare_key, which is the reason why admins were getting 'undefined s' errors in the log. A big oops. I take it that everyone trusts my code so much, they don't review it, right..? I should feel honored :P (Subs-Cache.php)

! Fixed typo from Dragooon's original notifications contribution, which made periodical e-mails fail entirely, as the DB table couldn't be found. (Notifications.php)
Title: Re: New revs
Post by: Arantor on June 5th, 2013, 01:59 AM
8 modified, 1 file forgotten in the commit, 3KB

Revision: 2150
Author: arantor
Date: 05 June 2013 00:58:23
Message:
! Wrong variable was used, causing spurious errors. (Class-Notification.php)
! Move topics now generates notifications, thanks live627 for your contribution! NB: I haven't set it up for bulk maintenance. Interestingly enough, move topics does the old notifications system (sendNotifications call), but it isn't done in mass maintenance, and for now I'm not doing our notifications there either. (MoveTopic.php, Notifications.php, QuickMod.php, Notifications.english.php)
! Since we're now doing it through notifications, bye bye sending a PM. (MoveTopic.php, MoveTopic.template.php, ManageTopics language file)
----
Modified : /trunk/Sources/Class-Notification.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.french.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Title: Re: New revs
Post by: Arantor on June 5th, 2013, 02:02 AM
2 added, 2KB

Revision: 2151
Author: arantor
Date: 05 June 2013 01:01:05
Message:
! The notifier file I forgot to commit just now. (Move.php)
! The current contributors list. It's not 100% accurate at this point in time since we haven't updated getID3 to the MPL licenced version yet but we will be doing so shortly.
----
Added : /trunk/Sources/notifiers/Move.php
Added : /trunk/root/contributors.txt[1]
 1. Even the ASCII art in this file has attribution. Credit where credit is due.
Title: Re: New revs
Post by: Arantor on June 5th, 2013, 06:08 AM
4 files, 21KB

Revision: 2152
Author: arantor
Date: 05 June 2013 05:07:36
Message:
! Whoops, forgot some clean-up. (MoveTopic.php)
! Ability to search the language files in the language editor. Doesn't do other themes yet. Might need some polish. But it seems to work. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


(Btw, did I mention I only started this tonight?)
Title: Re: New revs
Post by: Nao on June 5th, 2013, 01:24 PM
rev 2153
(8 files, 7kb)

! Got rid of a long-standing bug where, with Pretty URLs enabled, a name would occasionally drop out of the who's online list... Well, technically it's impossible to fix without being to reproduce, so I just added a fail-safe, and for the rest... Does it really matter? It happened once every six months, or something -- bot visits included. (Who.php)

* Restored personal_text modification to the profile area. Originally, I removed it to use thoughts instead, but since I decided to make it opt-in through the 'Posterity' feature, I might as well allow you to change it. And I might as well change my mind later. But I think once I've got privacy boxes set on this, it'll suddenly turn out to be all right to use it along with usertitle. Or something. Still, I think we really need to add some description of Personal Text and Personal Title below the options, because it can be confusing. I know it was to me, back in 2005 or something... (Profile-Modify.php)

* Translation. (ManageSettings.french.php, Notifications.french.php)

! Typos, including one in a variable name... 'Tis the season. ;) (ManageSettings.english.php, Notifications.english.php)

! Commenazi -- mostly a typo on the word 'readability', poetic irony. (Class-Notification.php)

* Vanity restyling of the language area search box. Don't bother. (ManageLanguages.template.php)

@ Note for Pete: feel free to revert the Who fix, if you're in a mood to spend a day trying to reproduce it, or something...
Title: Re: New revs
Post by: Nao on June 5th, 2013, 01:26 PM
rev 2154 -- getting rid of bad hosts, and fixing license files.
(5 files +3-3, 14kb)

* Ensured that PCRE_VERSION is at least 7.2, otherwise Wedge won't work. See, I'm a supporter of the \h alias in regex, and I'm certainly not going to forfeit it for crappy hosts™. We never got any problems before, because PCRE 7.2 is bundled by default with PHP 5.2.4 (which happens to be our minimum PHP version for now), but Pete managed to find one of those crappy hosts™ that has PCRE 6.6 along with a more recent PHP... When you purposedly keep a 7-year-old version of a library on your servers, you shouldn't be trusted with other people's data, really. (readme_install.html, install.php, Install.language.php)

* Tweaked contributors file: harmonized 3-clause BSD/BSD 3-clause to Modified BSD; changed line breaks to CRLF instead of LF (we need everyone to be able to read this kind of file, including users of notepad.exe); added a realist's note about JW Player (yes, I'm still planning to get rid of it someday, don't worry...); and, replaced the ASCII logo with one that keeps the correct dimensions. That ASCII generator, to say the least, doesn't care a bit about proportions. (contributors.txt)

* Moved some of the non-critical root files to the actual root folder. (changelog.txt, license.txt, license_smf.txt)

@ Note for Pete: the minimum/recommended requirement paragraphs are very different across readme_*.html files, so we might want to harmonize them... And quickly, I guess!
Title: Re: New revs
Post by: Nao on June 6th, 2013, 07:49 PM
rev 2155
(5 files, 2kb)

! Fixed wrong transparency values on avatars that are uploaded to a custom folder. Another waste of an afternoon... Why are there so many ways to use avatars, uh? (Class-System.php, Load.php)

- Removed unused getIcon() definitions. (notifiers/Likes.php, notifiers/Move.php)

* Small tweaks to notification avatar layout. (index.css)
Title: Re: New revs
Post by: Arantor on June 6th, 2013, 11:51 PM
3 modified, 4KB

Revision: 2156
Author: arantor
Date: 06 June 2013 22:51:11
Message:
! Allow admins to force send individual items from the mail queue. (ManageMail.php, ScheduledTasks.php, ManageMail.english.php)
----
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Title: Re: New revs
Post by: Arantor on June 7th, 2013, 02:10 AM
3 modified, 1KB

Revision: 2157
Author: arantor
Date: 07 June 2013 01:09:27
Message:
! Move notifier would throw undefined error to admins when displaying the move notification. (Move.php)
! Don't show likes by people you're ignoring. (Display.php, Like.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/notifiers/Move.php
Title: Re: New revs
Post by: Arantor on June 7th, 2013, 03:53 AM
7 files, 5KB

Revision: 2158
Author: arantor
Date: 07 June 2013 02:52:45
Message:
! All Thoughts did not get the correct thought's owner. (Thoughts.php)

! Admin can now choose whether to allow username/email, username only, email only logins. Might need to change the wording, as referred to in http://wedge.org/pub/feats/7243/username-does-not-exist-warning/ because it's also misleading in that now it might say username but refer to an email... but if we decide to nuke the difference between 'does not exist' and 'not correct' the problem mostly goes away. (Login2.php, ManageRegistration.php, Login.template.php, language files: Help, Index, ManageSettings)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Thoughts.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Arantor on June 7th, 2013, 10:21 PM
9 files, 18KB

Revision: 2159
Author: arantor
Date: 07 June 2013 21:21:01
Message:
! weget is going to need to support other methods in future. (Class-WebGet.php)

! Some refactoring fun of the search API ready for other search backends to be added in due course. (Load.php, ManageSearch.php, RemoveTopic.php, Search2.php, SearchAPI-Custom.php, SearchAPI-Standard.php, Subs-Post.php, ManageSearch.template.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Title: Re: New revs
Post by: Arantor on June 8th, 2013, 08:57 PM
(6 files, 9KB)

Revision: 2160
Author: arantor
Date: 08 June 2013 19:56:19
Message:
! ext/mysql is officially deprecated. It had to happen sometime, I guess. So, let's use ext/mysqli. It's not so pretty in some places, and has a nicer API in others. At least it only has one function for persistent connections now. (wedge_api.php, install.php, Class-DB.php, ManageMedia.php, QueryString.php, Subs-Template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/other/tools/wedge_api.php
Modified : /trunk/root/install.php


@ I double checked all the function handling because of the joys of mysqli_* having some functions with a different parameter order. I think it all works now. :angel:
Title: Re: New revs
Post by: Nao on June 8th, 2013, 11:14 PM
rev 2161 -- To infinity... AND BEYOND!!!
(6 files, 8kb)

+ Added Infinite Scrolling feature to topics. Just keep rolling your mouse wheel until it starts loading the next page! There are still a few bugs, such as video embedding not always working in newly loaded posts, and quick moderation being broken. It's not enough to justify not committing this nice feature, I think. (QueryString.php, Subs-Template.php, index.template.php, script.js, topic.js)

* Defined a new constant, INFINITE, which is set if the page was loaded through infinite mode. I may remove it later, but for now, I think it could be helpful. (QueryString.php)

! In some rare situations (for instance, pages with embedded videos), Wedge could have empty script tags. Dealing with these. (Subs-Template.php)

* Grouping block calls from mini-skeletons in the debug log; seriously, this saves admins from having huge logs in topic pages, although it might be argued that it makes debugging (slightly) harder, but whatever. (Subs-Template.php)

* Translation. I'm late with the other files, I know... (ManageMail.french.php)

@ I can't believe I fully commented my JavaScript for infinite scrolling... What happened to me? ;)

:edit: Forgot to mention script.js (which was committed) -- it adds a check related to infinite scrolling, too.
Title: Re: New revs
Post by: Arantor on June 10th, 2013, 03:38 PM
11 modified, 2 added, 12KB

Revision: 2162
Author: arantor
Date: 10 June 2013 14:37:58
Message:
! Profile area can now use static methods for actions. Thanks live! (Profile.php)

! Since the profile area can do this, notifications doesn't need the helper method. (Notifications.php)

! While we're on the subject, scheduled tasks need similar love (install.sql, ManageScheduledTasks.php, ScheduledTasks.php, Notifications.php, Notifications language files)

! OK, so I was wrong, a function not properly documented in the PHP manual does actually exist. (Class-DB.php)

! Additional styles for the new manage board code as well as the new button icons. @Nao, please feel free to move the change from index.css if you would prefer... I can't immediately name anywhere that input.modify might be useful outside the admin panel but that doesn't mean there isn't somewhere. Also feel free to adjust the yellow to a better blended tone or indeed any other colour you might have that isn't blue, just for the variety of colours, really. Made one change in the admin panel but there are a lot of modify links-which-aren't-buttons-but-semantically-should-be, bah. (index.css, mana.css, modify.png, permissions.png, Admin.template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/buttons/modify.png
Added : /trunk/Themes/default/images/buttons/permissions.png
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/root/install.sql
Title: Re: New revs
Post by: Nao on June 11th, 2013, 11:22 PM
rev 2163 -- Some boring maintenance...
(11 files +4-2, 16kb)

* Optimized the new buttons to PNG8, and made them raw-url; as permbutton isn't used anywhere (I suspect it's not as desired..?), it's even less important to embed it, while the modify button, per se, is only found in one place, so let's not clutter the index CSS with more bytes, I'd say... (other/images/buttons/*, images/buttons/*, index.css, mana.css)

* Since the admin area is less bandwidth-critical, I figured that it might not be a complete waste to add hover text over A/X/D radio buttons in the permissions area, clearly indicating what the button is for, without needing to resort to reading the header description again. I know, as I found myself wanting this. The result is about 5% larger, but once gzipped, is only about a hundred bytes larger. (ManagePermissions.template.php, ManagePermissions.language.php)

* URL cutter now uses the Safari 'codepath' for all browsers, as it's shorter, seems more solid and actually works everywhere I tested, so whatever. (index.css)

* Commenazi. (ManagePermissions.php)

* French translation. (Help, ManagePermissions, ManageSettings)

- Removed a now unused style from IE6/7. (extra.ie6.css, extra.ie7.css)
Title: Re: New revs
Post by: Nao on June 13th, 2013, 08:00 PM
rev 2164 -- the return of flexbox, can you believe it..?
(5 files, 4kb)

+ Implemented a new technique of my own, CSS-only, flexbox-based, to emulate proper rowspans in Chrome. I'm only targeting this browser, because really, it's the only one that supports my technique, but other than that, it should be flawless. I know, I know, Chrome always has the cool toys... But other browsers should think of getting their stuff to work, shouldn't they..? (sections.css)

! Fixed CSS transitions to auto-prefix 'transform' values (like Wess does on the 'transform' rule itself), as it is still a requirement in Chrome, as odd as it sounds... This is so 2012! (Class-CSS.php)

! Don't run MessageIndex JS code on Display pages, it's a (small) waste of time. Also some commenazi, whatever. (topic.js)

! Fixed AJAX loading icon not, err... loading, in the Zoomedia code. (zoom.css)

* Tweaked disabled buttons in the admin area, as it wasn't easy to notice that they were actually disabled, eh... (mana.css)
Title: Re: New revs
Post by: Arantor on June 14th, 2013, 03:09 AM
(2 files, 1KB)

Revision: 2165
Author: arantor
Date: 14 June 2013 02:09:11
Message:
! When saving a topic-move, the wrong variable was used to generate the notification leading to an incorrect message for non admins. (MoveTopic.php)

! Memberlist search wasn't updated to use the profile fields privacy changes, leading to a database error because of a field that isn't there any more. (Memberlist.php)
----
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MoveTopic.php
Title: Re: New revs
Post by: Nao on June 14th, 2013, 09:33 PM
rev 2166
(7 files +2, 28kb) (that big?!)

+ Added Dragooon's notification subscriptions code. I don't get what it does, and it's not working for me, but I need it in SVN so that we can fix it later... Also added French translation, fixed some HTML (self-closed tags aren't needed in HTML5, useless $scripturl, using w100 class instead of an inline style, etc.) fixed indentation (spaces used instead of tabs?!), woot. (install.sql, Class-NotifSubscriber.php, Class-NotifSubscription.php, ManagePlugins.php, Notifications.php, Profile.php, Notifications.template.php, Notifications.language.php)

* PHP 5.2.3+ supports is_callable('class::method') (or even the equivalent function_exists) instead of is_callable(array('class', 'method')), so I figured it's best to use the string format, as it's a bit faster to handle internally. (Profile.php)
Title: Re: New revs
Post by: Nao on June 15th, 2013, 07:27 PM
rev 2167
(2 files +1, 8kb)

* Moved my 'more' code to the attic. This is the super-short function that creates a 'More' entry in the main menu, on the fly, and populates it with entries that would make the menu span two lines or more. Since we're unlikely to use it anytime soon, might as well commit it there... (attic/Unused-menuMore.js)

* Updated Dailymotion embed code to their iframe-based latest. (Subs-Aeva-Sites.php)

- Removed a couple of video sites (5min, CarPix TV, ClipShack) that are obviously long dead, or at least not reliable enough. Will do more when I have time... (Subs-Aeva-Sites.php)

! Typo in notification code. (Class-Notification.php)
Title: Re: New revs
Post by: Nao on June 17th, 2013, 12:32 PM
rev 2168 -- the long-awaited Aeva update! What? No one cared? Okay, okay...
(2 files, 22kb)

! Fixed Aeva embedding to finally work... A year ago, I fixed a problem with URL tags being broken, and in the process I also broke the future embedding of any websites requiring a lookup to work. Added a short hack to completely bypass the need of a variable-length negative lookbehind. (Aeva-Embed.php)

@ I'm starting to think it would probably be better to turn Aeva into some kind of generic engine that allows for users to post embed code from a selection of websites, embed them as such, and just 'protect' them within an iframe.

- Reviewed all of the currently available embed sites, and removed all those that were dead, not responding, or at least no longer working in this setup, or whatever. (Subs-Aeva-Sites.php)

! Fixed Wat.tv embedding, and updated DotSub to actually show captions... Since it's pretty much the selling point of that site, right? (Subs-Aeva-Sites.php)

@ The list: Google Video (sic!), ClipLife, Clipser, Cold-Link, Dv.ouou, Excessif (ooh, that one hurts... Was a great site, added the embed code for myself...), ExposureRoom, Gloria, Glumbert, Grassroots, GrindTv, Guba, iJigg, Joost, JumpCut, MoFile, MotionBox, Mpora TV, Mp3tube, MSN Live (sic! YouTube really won the battle!), Multiply (I want to snag that domain name!), MyNet, MySoccerMedia, MyShows.cn, OnSmash (moved to YouTube hosting on another domain), Passionato (x2), PikNikTube, Putfile, RawVegas (YT hosting too), Revver, ScreenToaster, Seeqpod, ShareView, Sharkle, Slide (can you sell me that domain name, please..?), Space.tv.cctv.com, UOL VideoLog, UUME, vbox7, Vidiac, Vholdr, VidiLife, VSocial (x2), and Yahoo Video HK (they renamed to Yahoo! Screen, and I won't bother to look into this.)

@ Yes, that's nearly 50 dead video sites, accounting for the previous commit.

@ Have a nice trip, Pete!
Title: Re: New revs
Post by: Arantor on June 20th, 2013, 07:22 PM
(1 file, 2KB)

Revision: 2169
Author: arantor
Date: 20 June 2013 18:22:08
Message:
! Debugging information and error information could sometimes be overwritten in the post-process of Who's Online, making it hard to identify bots at times. (Who.php)
----
Modified : /trunk/Sources/Who.php
Title: Re: New revs
Post by: Nao on June 26th, 2013, 11:08 PM
rev 2170 -- committing whatever is committable in my local install, which is easier said than done right now, uh...
(6 files, 7kb)

* Refactored debug junk area at the bottom of all pages, for several reasons: I wanted it to be shorter (it's now on average 3 lines only), so that infinite scrolling works better for admins, and to be readable when queries were expanded, which wasn't the case until now, uh. (Subs-Template.php, Stats.language.php)

! Fixed potential wrong redirection when expanding/collapsing queries. (ViewQuery.php)

! Fixed plugin CSS caching. Thanks John! (Subs-Cache.php)

* Added another bot to BadBehavior. Per Arantor's suggestion. (Security.php)
Title: Re: New revs
Post by: Nao on July 3rd, 2013, 03:50 PM
rev 2171 -- finally got around to cherry-picking this N-th large overhaul of the notifications system...
(12 files, 21kb)

* Large overhaul of the notification system. Notifier is no longer an abstract class, and it provides default actions for all methods. It assumes that your notification is about a forum post, so if you want to notify about a topic, a thought, a media item or whatever else, you'll have to override some of the methods, but it's better than having to override it constantly. (Class-Notifier.php, Notifications.php, notifiers/*, ...)

* Notification::issue parameters were changed; notifier name now comes first (it makes more sense to me), and it expects a string, rather than a notifier object, so just remove weNotif::getNotifier() calls, it's much simpler this way. Also changed order in NotifSubscription::issue, although I have yet to see this function used, so it doesn't matter... (Class-Notification.php, Class-NotifSubscription.php, Like.php, MoveTopic.php, QuickMod.php)

* Notification previews are now prepared entirely within the getPreview method, making it easier for notifier objects to override the default behavior in case the notification isn't related to a topic, or something more complicated is needed. (Class-Notifier.php, Notifications.php, notifiers/Likes.php)

* Notification periodical e-mails should now be in plain text, as desired. (Notifications.template.php)

* Commenazi. (Class-Notification.php, Class-Notifier.php)

! Fixed missing header. (notifiers/Move.php)
Title: Re: New revs
Post by: Nao on July 3rd, 2013, 03:56 PM
rev 2172 -- trying to do smaller bits now, easier to deal with...
(2 files, 2kb)

! Semi-fixed a problem with IE10 Desktop Mode in Windows 8. Apparently, this stupid browser (perhaps helped by some external program) tends to drop $.post requests in that particular setup, so I simply ensured it doesn't generate an error when dealing with thoughts, but the only workaround, really, is to emulate IE9 mode, which I can't bring myself to force upon Wedge users, so... Well, whatever. Use Metro mode, or emulate IE9, I don't really care right now, and I'm certainly not going to rewrite all functions to use $.get instead, uh... (Ajax.php)

* Moved debug junk into the footer, rather than below it. I just think it looks best, so... I'm expecting all footers to have an unordered list in them, otherwise it'll break your themes. Okay..? (Subs-Template.php)
Title: Re: New revs
Post by: Nao on July 3rd, 2013, 04:05 PM
rev 2173 -- don't fret, I don't have much committable material after that one...
(2 files, 2kb)

! Was still using the min-device-pixel-ratio media query, when I should have been using min-resolution instead, which is fully supported by Wedge... (As in, 'it provides a fallback for it.') Also, IE8 has never supported that particular query, so I'm updating the target browser list. (index.css)

* Mixing .hide classes compresses better than extending them. Should have noticed I wasn't doing the right thing, but... (index.css)

* Moved random_news block to the main content area, right before the linktree. I simply thought that the header was crowded enough as it was, and people would be less likely to notice the extra news block in these conditions. I was so very tempted to remove the feature entirely, but I respect Pete's work on overhauling it! (index.css, skeleton.xml)
Title: Re: New revs
Post by: Nao on July 8th, 2013, 12:04 AM
rev 2174
(2 files, 1kb)

! Fixed notification issuing process (wrong method name), broken last week. (Class-Notification.php)

! Several fixes to likes, which were also broken by the same commit... Hmm, 'guess no one tested it..? (notifiers/Likes.php)
Title: Re: New revs
Post by: Nao on July 8th, 2013, 12:05 AM
rev 2175 -- both of my non-notification, non-sidebar ready-to-commit thingies.
(3 files, 4kb)

* E-mails should now properly prettify Wedge URLs. Also note the new helper function, prettify_urls()! (Subs-Post.php, Subs.php)

! Fixed inden@zi feature to force complete unindenting of all lines that have less space than the amount flagged for removal. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on July 10th, 2013, 04:04 PM
rev 2176 -- more non-biggie ones...
(5 files +1, 14kb)

* Moved unread posts calculator to its own helper function, which should help me use it on more pages in the future, I hope... Technically, all you need to send the function is an array of arrays, each containing at least 'is_new' (a boolean flag determining if the topic has new posts), and 'topic' (the topic ID). I could probably restrict the parameter to a simple array of topic IDs, but I wanted the function to be compatible with ssi_recentTopicTitles(), or whatever. (Subs.php, Home.template.php)

! Forgot to move the random_news block to the main content, for Warm. (Warm/skeleton.xml)

+ Added a variable that stores the main content's surrounding padding, which was needed by my (yet uncommitted) script for responsive sidebars. Plus, it's cleaner... I really, really need to add more minor variables like this one, for use in sub-skins. (common.css)

* Moved attic JS files to a new sub-folder, for clarity. (other/attic/scripts/*)

+ Added another JS file to the attic, with two features I wrote for the responsive sidebar and ended up ditching: finger swipe events, and preventing scroll events to bubble up the DOM once the end of the target element is reached, which sadly I couldn't get to work on mobile devices, hmm... (attic/scripts/Unused-swipe.js)

* Commenazi. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on July 11th, 2013, 08:54 AM
rev 2177 -- that time of the month, as Google updated their CDN...
(2 files +2-2, 181kb)

! The global I added in rev 1930 wasn't even the correct one... (I'm guessing the days where people tested new commits are long gone.) For those who forgot, this meant that changing a 8-char-required password to a less-than-8-char password from within the profile area would trigger "needs at least 4 chars". (Profile-Modify.php)

* Updated jQuery to 2.0.3 and 1.10.2. (Load.php, scripts/*)
Title: Re: New revs
Post by: Nao on July 11th, 2013, 11:59 AM
rev 2178 -- the dreaded moment... Will it work, or will it break...?
(6 files, 12kb)

+ Okay, I'm finally committing the responsive sidebar rewrite... So, instead of a visible sidebar at the end of the page, you'll be getting a menu button (fixed on mobile devices, or static in the header on desktop browsers), that you can click to show or hide the sidebar. (index.language.php, script.js, index.css, extra.ios.css, sections.css)

* Tweaked responsive mode topics to use all available horizontal space. Seriously, you don't want stupid margins when you're already in a narrow window... (sections.css)

@ Should I target specifically mobile devices (there's a flag for that) when doing the min-resolution media query..? It would save some bandwidth on other devices... (sections.css)

@ You can also dismiss the sidebar with a click/tap outside of it. And on desktop, you can also call the sidebar by clicking the mouse wheel (i.e. middle-clicking), and clicking it again to dismiss it. It won't interfere with proper uses of the middle button to open links in new tabs, but might be a problem otherwise, so I'll need to gather feedback on this...

@ Hardware acceleration is used when available, to show the sidebar. OldIE can't use it, and I'm also forcibly disabling it when the sidebar button HTML is contained within the area that gets scrolled, because the W3C standards call for a new stacking context to be created on a fixed position element, or something to that effect, effectively justifying Chrome's decision to turned fixed elements into absolute elements when their containers are being animated... So, whatever.

@ I had to add a hack for Firefox when it comes to the middle button, not my fault. It won't work perfectly on it, hopefully I can improve that later.

@ This is all barely optimized for size. It adds about 1.3KB unzipped (and even more CSS), and 400 bytes gzipped, which is bad by my standards, but I really couldn't do better for now... And it's already much better than my initial code, which had swipe events and all (see previous commit.)
Title: Re: New revs
Post by: Nao on July 11th, 2013, 12:24 PM
rev 2179 -- styling, styling, styling...
(6 files, 6kb)

+ Added a top_bar layer to more easily target this area for your plugins, and planning to add one for upper_section later. (index.template.php, skeleton.xml)

* Language flags are now shown in a #flags div, and the random_news block is shown above the linktree, in the main area. This is better for the top bar, as it gives it more breathing space, and makes the random news easier to spot. Finally, since these both are in a div, which should be easier to style. Generally, styling generic tags is a bad idea anyway. (index.template.php, index.css)

! Chrome recently started to fail correctly positioning sub-menu arrows in the main menu, so I rewrote the code to work better. Incidentally, this will also probably help with other browsers. (index.css)

* Tweaked the header text to be smaller on mobile, and try to show the slogan as well. Previously, I didn't even bother with it... (index.css, sections.css)

* Tweaked search box to prevent smaller screens from severely cutting off its associated popup. (index.css, sections.css)

* Language flags are now in a correctly styled #flags div... (index.css)

* Updated Wine and Wuthering to support the new responsive sidebar, still needs some work though. Warm will come later, as I have yet to decide whether I'll commit it entirely or partially (it was largely rewritten months ago.) (Wine/extra.css, Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on July 11th, 2013, 12:33 PM
rev 2180 -- owwww, it feels so good committing all of these leftovers...!!
(3 files, 3kb)

+ Rewrote the Ajax indicator, as used in the last few weeks on wedge.org, i.e. very similar to my earlier code for Zoomedia. Need to update Zoomedia to use it, actually... Nice animation and everything, I just can't live without this one anymore. (script.js, index.css, sections.css)

+ Prevent mobile browsers from zooming into input boxes and textareas when tapping them. I hate that, and most people hate it, too. I need to ensure the text size is readable in non-zoom situations though, so it'll probably need more tweaking later. Also, it doesn't seem to work on my iPod. Ah well, if anyone knows why... I personally couldn't care less right now, Android FTW. (script.js)

! A couple of much needed fixes to the notifications popup JS. Honestly, I can't remember what these fixes do, but they work. (script.js)
Title: Re: New revs
Post by: Nao on July 11th, 2013, 09:06 PM
rev 2181
(5 files, 4kb)

+ Added a 'like' icon next to the notification popup text for likes. This makes it easier to spot low-priority notifications like these. (Notifications.language.php, index.css)

! Fixed responsive sidebar not resetting correctly in IE + software mode. Oh, the ugly hacks... Well, at least they're not too long. (script.js)

* Finally committing the search popup animation rewrite, which I did months ago, but for some reason never came around to publishing... I mean, it looks better, it doesn't really take more space, perhaps I was simply hoping I'd improve it even more..? (script.js)

! Wedge didn't allow you to use the X link on notifications after they were previewed. That may have been a bit harsh, I think... (script.js)

! IE8 was broken in responsive mode. Yeah, yeah, the usual... (sections.css)
Title: Re: New revs
Post by: Nao on July 15th, 2013, 12:21 AM
rev 2182 -- skeleton operations.
(5 files, 4kb)

! The skins, they are a'fixing. It's still far from perfect, but then again, what is? (Wine/extra.css, Warm/extra.css, Wuthering/extra.css)

! Skeleton operations should be doable from within the skin.xml, and I swear I thought it was already possible, hmm... Hopefully, I'm not breaking something else in the process. (Subs-Cache.php)

* Noticed that I never committed a primordial change to the Wuthering skin, hmm... Moving linktrees out of the #edge area. Also demonstrates what skin operations are capable of. (Wuthering/skin.xml)
Title: Re: New revs
Post by: Nao on July 15th, 2013, 12:39 AM
rev 2183 -- responsive sidebar, reloaded!
(5 files, 5kb)

! Here's hoping I fixed all of the responsive sidebar issues for good... I ended up doing many steps back, and settling on a table layout even in responsive mode. You'll see-- it works fine. (script.js, sections.css)

+ When opening the sidebar in responsive mode, Wedge will attempt to position its content in the most convenient way for you. It's a kind of magic. (script.js)

+ Added left-to-right scrolling for responsive sidebar, when the sidebar is originally shown on the left. Hard-scroll is disabled in these cases, but it shouldn't be much of an issue. (script.js)

@ All of the feature changes above add 500 bytes of JS, but save about 200 bytes of CSS, so it's a fair compromise.

* Increased sidebar width by 20px, because I can. (common.css)

* A few tweaks to Weaving paddings, I'll apply them to other skins later. (index.css)

! Moved Warm's top_bar to its regular place, in an empty version. This should help force the menu button to be visible in Warm, which was not really a given in the first place. (Warm/skeleton.xml)
Title: Re: New revs
Post by: Nao on July 17th, 2013, 03:46 PM
rev 2184 -- responsive reload, sidebarred!
(6 files, 7kb)

* More rewrites for the responsive sidebar. (script.js)
  - Sidebar's counterpart should now be found more easily, you don't have to call it with id 'main' or 'offside' anymore.
  - You can now show the sidebar even when zooming in mobile devices, as this limitation was only due to the (removed) swipe gesture.
  - Sidebar showing up should no longer 'bump' the main content by a few pixels; this was due to an outdated use of innerHeight().
  - Hardware acceleration is now also enabled when the sidebar is shown from the left, which wasn't possible before (see the 'transform: none' tweak.)
  - Hardware acceleration detection is now done properly, rather than with browser sniffing. Basically, obscure browsers FTW.
  - Fixed a logic issue with non-hardware mode, but you don't want to know about it, so forget I said anything.
  - More comments around. Comments are good, they allow you to understand what's going on. I hope.

* More tweaks to the sidebar button. (script.js, index.css, sections.css, Wine/extra.css)
  - Added two extra divs to the sidebar button HTML, allowing to customize the bars without playing with border sizes.
  - Moved sidebar button to the beginning of top_bar, rather than the end, allowing for easier placement.
  - Tweaked sidebar button to always keep the same size in mobile devices, whatever the zoom level is.

* Sidebar layout tweaks for Wine and Wuthering. (Wine/extra.css, Wuthering/extra.css)

- Wine doesn't need to move the linktree around, really. (Wine/skin.xml)
Title: Re: New revs
Post by: Nao on July 18th, 2013, 09:31 AM
rev 2185 -- outing!
(3 files, 2kb)

! A faulty equation sign change broke the flood management code in late January, and thus people would be forever locked out of Wedge after failing to log in 5 times. How awkward. Thanks to Farjo for being the one to tell me first, and to myself for reproducing, and finally fixing some code I only touched once, long ago. I hate that. (Subs-Login.php)

! Fixed a couple of minor DOM logic issues with the infinite scroll code, although I have yet to determine whether I'm keeping it this way, or rewriting it from scratch, or not caring at all. (topic.js)

* Spacinazi. Long time uh..? (Login2.php)
Title: Re: New revs
Post by: Nao on July 22nd, 2013, 02:40 PM
rev 2186 -- the 37.2°C/98°F update[1].
(6 files, 3kb)

! Since it seems that some people at wedge.org still had a buddy_list entry in the form of ",id1,id2" (instead of "id1,id2"), I added a couple of fail-safe functions to force filtering empty users out of the list when being created/modified. Beats me, but at least it should have no influence on performance, on the contrary. array_filter() is probably better than the foreach that was there, hmm... And it's shorter, too. (Profile-Modify.php)

* More fixes to Wuthering. (Wuthering/extra.css)

* Added a margin to the header's upshrink button, so you can see it even in mobile mode. (sections.css)

* Better hack for cross-browser viewport-dependent lengths. (common.css, index.css, sections.css)

! After coming out of responsive mode (e.g. through a window resize), the sidebar contents' position wasn't reset, which it should have been. (script.js)
 1. Actually, I'm a bit of a cheat, most of these were done when it wasn't that hot... :P
Title: Re: New revs
Post by: Nao on July 22nd, 2013, 06:37 PM
rev 2187[1]
(2 files, 2kb)

! Forgot to reset $txt on every language test load in getLanguages(), thus making subsequent languages inherit their predecessor's lang_hreflang value if set. Woops... (Load.php)

! Still had some occasional '0' entries in the CSS filenames... This happened when a page was being visited by a bot that didn't declare a compatible browser name in its user agent string. Phew. (Subs-Cache.php)

* Safari 5.1.7 on Windows no longer exhibits the .css.gz/.js.gz issue I'd noticed long ago, but I never found any documentation on when exactly the problem was fixed, so I'll just assume the fix was applied in v5.1, maybe it was 5.0, but who cares. This browser sucks anyway. At least now, recent versions won't bother you as much. (Subs-Cache.php)
 1. Apparently, the heat didn't hit me enough, was able to fix more things...
Title: Re: New revs
Post by: Nao on July 22nd, 2013, 11:29 PM
rev 2188 -- 3 times in a day? When you're hot, you're HOT! (© Cat, Red Dwarf)
(5 files, 2kb)

* Admin time remaining's style was hardcoded; rewrote it properly. (Admin.template.php, mana.css)

! admin_time_remaining block is better placed in the top layer (which is its raison-d'être), rather than after the linktree. Seriously. (Admin.php)

! In the Current Theme admin page, some elements were always rendered through Weaving, rather than any skin you might have been using. Did a quick fix for this one, but it tends to demonstrate that if you install another theme, you're bound to have difficulties with their sub-skins. (Load.php)

! More fixes for Wuthering. I'll beat it, one day. I will. (Wuthering/extra.css)
Title: Re: New revs
Post by: Nao on July 26th, 2013, 04:18 PM
rev 2189
(6 files, 6kb)

* Rewrote upshrinks code to save space. Long time. This saves about 160 bytes in the final gzipped CSS, and I added a nice little animation for capable browsers. The upshrinks title is also moved to JS, saving this much from all HTML pages, and same for the JS that was originally hardcoded in HTML to call the toggler. Technically, the HTML thing was needed because it has the HTML IDs in it, but I figured that if someone really wants to rename their IDs in new themes, they can simply take the JS code, and add it through add_js() like it originally was, and we're done. Or they could just import the script.js file and rename the IDs in it, but I wouldn't recommend it, really. (index.template.php, script.js, sections.css, upshrinks.png, upshrinks-32bit.png)

! Typo. (Profile.french.php)
Title: Re: New revs
Post by: Nao on July 28th, 2013, 11:24 AM
rev 2190 -- macros rewrite, hopefully will help me with the upcoming soft-merge trick, hmm...
(5 files +2, 11kb)

* Tweaked the macro system. Default macros are *no longer* defined in index.template.php, and are instead declared in a new 'macros.xml' file in the skins folder, which you can augment with contents in custom.xml, or a sub-skin's macros.xml file. Just like for skeletons, a replace-type skin shouldn't ignore the root skin's macros, so if you want to cancel a parent macro, make sure to rewrite it entirely, otherwise it's here to stay. I think. The reason why I did this rewrite was to (1) completely clean up the index template, which is already complicated as it is with all of the blocks defined, and (2) make it easier for me to add new macros, as the xml definition style is, well, definitely better looking... Plus, the banner macro needed to be fixed with non-PHP code, so, two birds with one stone. (Load.php, Subs-Cache.php, index.template.php, macros.xml)

+ Started adding a few macros... (Msg.template.php, macros.xml)

- skin.xml no longer accepts macro redefinitions. Use macros.xml, sorry about that. (Warm/skin.xml, Warm/macros.xml)

- A couple of unused globals... (index.template.php)
Title: Re: New revs
Post by: Nao on July 29th, 2013, 10:55 PM
rev 2191
(1 file, 3kb)

* Updated CSS prefix handling. I still do tech watch really, always need to...! So, what's fixed on my side: iOS 6 should now show border-image, unprefixed, and use calc(), prefixed. What's new in the browser world: IE 11 supports border-image (unprefixed), Chrome 26 finally unprefixed gradients (didn't notice before), Chrome 29 unprefixed the final flexible box layout model, a bit late, but still... Safari 7 unprefixes gradients, transitions and calc(). iOS unprefixed transitions and calc() only. Hopefully, I didn't miss anything... The code is starting to get complicated, but it's still a bit early to drop all of the old browsers from the list; still, I'll eventually do it, at least for the evergreen ones, i.e. Chrome and Firefox. (Class-CSS.php)

+ I don't think it's of much interest, but I added prefixing support for 'backface-visibility', 'perspective' and 'perspective-origin'. Supposedly (I even read that again in the latest issue of WDM), you can force hardware acceleration with these, but I never got any issues without them either, so I'll have to wait for someone to tell me they have performance issues... Although, I might eventually apply backface-visibility: hidden to all 2D-only transforms, because, whatever. Maybe in a mixin, or somethin'. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on July 31st, 2013, 05:10 PM
rev 2192 -- soft-merging! Yay!
(5 files +1, 11kb)

+ Implemented soft-merging of posts. This is similar to regular double-post merging, except it's done at display time, rather than in the database, allowing for internal parent IDs not to get screwed, thus allowing for easier threaded mode, in case we eventually implement this. It's also done automatically, and is quite fast (1ms to merge all posts in a page together), the only drawback really is that it makes the msg skeleton structure a bit less flexible, but whatever... Also turned a few msg blocks into macros, yay. (Subs-Template.php, Msg.template.php, macros.xml, sections.css)

+ Added, for reference, the JavaScript prototype of soft-merging, to the attic. (attic/scripts/Unused-softMerge.js)

+ Macros can now use extra params even without specifying an <if> tag in their body. I should have dealt with that long ago, but, well, I didn't even notice the problem was there... (Subs-Template.php)

:edit:
* Chrome 29+ should support min-resolution CSS stuff now, so I'm changing the logic to save a few bytes.
Title: Re: New revs
Post by: Arantor on August 1st, 2013, 04:42 AM
9 modified, 1 deleted, 4KB

Revision: 2193
Author: arantor
Date: 01 August 2013 03:41:25
Message:
- Remnants of the old package manager. (detailed-version.php, Class-Package.php)

! Some of the /e modifier stuff. (Class-String.php, Class-System.php, Dlattach.php, ManageMaintenance.php, Subs-BBC.php, Subs-Post.php, Subs-PrettyUrls.php, Aeva-Embed.php)

@ Combo Breaker: these were bits I meant to post beforehand. I had meant to finish all the /e conversion stuff but that didn't happen due to time constraints. But since it's an active bug, here's what I have thus far. Do note it has NOT been battle tested and there are likely to be bugs at this stage. Please do testing, especially of pretty URLs before deployment. Note there is also one still lurking in Subs-PrettyUrls, where I haven't yet rewritten all of it, just the semantics around the first callback.
----
Deleted : /trunk/Sources/Class-Package.php
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/other/xml/detailed-version.php
Title: Re: New revs
Post by: Arantor on August 1st, 2013, 07:44 AM
6 modified, 4KB

Revision: 2194
Author: arantor
Date: 01 August 2013 06:44:07
Message:
! MySQL version not detected properly in installer (thanks Dragooon) (install.php)

! Fix to RIPE lookup (thanks Live) (Profile-View.php)

! Ability to search 'this board' or 'this board and all its sub-boards', feel free to find better wording, I just wanted to implement this quickly tonight. (Search2.php, Subs-Boards.php, Search.template.php, Search language file)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/root/install.php
Title: Re: New revs
Post by: Arantor on August 1st, 2013, 08:13 PM
4 files, 6KB

Revision: 2195
Author: arantor
Date: 01 August 2013 19:12:30
Message:
! More overhaul of the underlying search code. There's still plenty more to do but this is a bit of what had to be done to properly isolate custom indexes from, say, everything else. (ManageSearch.php, ManageSearch.template.php, SearchAPI-Custom.php, SearchAPI-Standard.php)
----
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Themes/default/ManageSearch.template.php

@ Just some background: pretty much all the code paths where searching ever touches treat custom indexes as a special case. The whole point, ultimately, is to not do that and push everything out to the search APIs as it should have been.
Title: Re: New revs
Post by: Nao on August 1st, 2013, 09:22 PM
rev 2196
(3 files, 2kb)

! Soft-merging broke un-ignore links on ignored posts. (Display.template.php)

! Fixed smileys showing as text in notification previews, when viewed from a page which had no smileys in the first place. Please help me find other situations where this could occur. (Notifications.php)

! ..Such as in new thoughts. (Thoughts.template.php)

! Also fixed smileys not showing up on thought threads' master thought, whether using Ajax or not... Really, it was just an unrelated bug. (Thoughts.php)
Title: Re: New revs
Post by: Nao on August 1st, 2013, 09:29 PM
rev 2197
(3 files, 1kb)

! Soft-merging broke un-ignore links on ignored posts. (Display.template.php)

! A matter of logic... The generic smiley CSS definition should be in the same file as the additional smiley definitions, as if the file fails loading, at least you won't get any awkward styling overrides. (Subs-Cache.php, sections.css)
Title: Re: New revs
Post by: Arantor on August 1st, 2013, 10:52 PM
6 modified, 1 added, 42KB

Revision: 2198
Author: arantor
Date: 01 August 2013 21:51:37
Message:
+ Drag and drop board rearrangement. It gets kind of funky when you have many boards and the scrollbars misbehave but that's more of an issue of the underlying jQuery UI Sortable and the nestedSortable components rather than strictly anything else. Seems to work for me other than that. (contributors.txt, ManageBoards.php, ManageBoards.template.php, mana.css, jquery.mjs.nestedSortable.js, ManageBoards language file)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
Added : /trunk/Themes/default/scripts/jquery.mjs.nestedSortable.js
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/root/contributors.txt
Title: Re: New revs
Post by: Arantor on August 2nd, 2013, 07:38 AM
2 files, 2KB

Revision: 2199
Author: arantor
Date: 02 August 2013 06:37:33
Message:
! Atom feeds shouldn't try to optimise links and also shouldn't really use content tags when summary would be more accurate. (Feed.php, Subs-Template.php)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Subs-Template.php
Title: Re: New revs
Post by: Nao on August 2nd, 2013, 04:18 PM
rev 2200 -- this is \x01 complicated commit, my <head> is about to explode().
(10 files, 7kb)

* Replaced a few single-char str_replace calls with faster strtr's and some chr() with equivalent \x codes, could do more, but I'm not bothering. (Class-CSS.php, Class-System.php, QueryString.php, Subs.php, Subs-Cache.php, Subs-Template.php)

* Replaced a few create_function calls with faster hardcoded functions, whatever. Also, if parse_bbc's replacement is a failure, show it in italics, to point out there's a problem with it; I think it's for the best. (Class-System, Aeva-Embed.php, Subs-BBC.php)

* strpad() is a strange name for a function that converts a string to its unicode number... Uh? (Class-String.php)

! Removed brackets from a preg_replace. I think that one was a bug... $matches[1] would reach the outer brackets, not the inner ones. (ManageMaintenance.php)

! Because I forgot to account for them, using a | or || inside brackets in a we::analyze string, while allowed by my specs, would result in crossing the streams. Never cross the streams, it's bad. Okay, now you can use them. I think. (Class-System.php)

* Transformed another couple of preg_replace evals into callbacks; there are plenty left to do, though, in the following files: Class-CSS, Class-Editor, Subs-Media, Modlog, Post, and Subs-Cache. (QueryString.php, Subs-PrettyUrls.php)

@ Well, just like Pete said... These things are pretty fragile, and they need further testing; I've triple-checked them when committing, though, so hopefully any problems will be down to syntax errors, rather than logic oversights.

@ Note to self: I fixed \x0f\x10 to return "' in Subs-Cache, rather than '', because it seemed to make more sense. However, it may be a workaround of mine rather than a bug, so we'll have to be careful whether this breaks $txt handling in JS files, or if the really nothing was broken before is that I never used any strings with problematic characters in them.
Title: Re: New revs
Post by: Nao on August 2nd, 2013, 04:40 PM
rev 2201 -- leftovers.
(5 files +1-1, 4kb)

! And of course, I forgot to commit Subs-Cache in the previous rev... Happens all the time, with my last-minute changes. (Subs-Cache.php)

* Translation. (Search.french.php)

* Renamed jquery.mjs.nestedSortable.js (gesundheit!) to nested-sortable.js. (ManageBoards.php, nested-sortable.js)

* Inline JS clean-up. (ManageBoards.template.php)

* Spacinazi. (ManageBoards.template.php)

* Commenazi. To be precise, the comment was saying the opposite of what it meant... Also, a personal note. The no_strip_domain context variable is equivalent to a hack I wrote months ago for the sendmail function, but never committed, and eventually rewrote with the new helper function prettify_url(). Technically speaking, whenever outputing raw XML or HTML that doesn't require any post-processing but pretty URLs, it's best to use prettify_url() and skip obExit() entirely, but it also means that macros aren't replaced, things like that, so... Maybe I'm just being too bitchy about this, and as a result I decided to keep no_strip_domain in place, and advienne que pourra, as we say on Mars. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on August 2nd, 2013, 10:16 PM
rev 2202 -- time for some bug fixing, man!
(2 files, 3kb)

! A beautiful bug in Wess... A year ago, rev 1667, I removed some pass-by-reference elements, and didn't realize that one of them needed to be there. As a result, it created situations where some selectors were mentioned twice. It probably wasn't very costly once gzipped, but it was still quite nasty, so here we go, a fix. (Class-CSS.php)

! Chrome 29+ would still add some prefixes to flexbox properties, even though I thought I'd unprefixed them. (Class-CSS.php)

! Cleaned up createPost topic creation query, and (hopefully) fixed a situation where it would reject the privacy value; a big woops. (Subs-Post.php)
Title: Re: New revs
Post by: Nao on August 3rd, 2013, 12:01 AM
rev 2203 -- a quick one for the night...
(1 file, 1kb -- no, it's not a one-liner! Close enough, though!)

! IconList was broken in soft-merge mode. Also optimized a few lines, always feels good to use that one() function whenever I can..! (topic.js)
Title: Re: New revs
Post by: Nao on August 3rd, 2013, 03:55 PM
rev 2204 -- scrollbar and notification fixes
(5 files, 4kb)

! Fix for a Chrome bug where scrollbars are glitchy when contained in a flex box. Unfortunately, the bug still happens in some situations. A minority, thankfully. (topic.js)

- Removed $email_data parameter from getEmail and other notifier functions; this wasn't used at all, and I don't even get what it's about, so... Let's just rewrite it if needed, alright Dragooon? (Class-Notification.php, Class-Notifier.php)

* A couple of 'new Notification' calls were done, instead of just 'new self', in the Notification class. (Class-Notification.php)

! Fixed template_notification_email, and saved some memory in the scheduled function. Thanks John for the suggestions! (Notifications.php, Notifications.template.php)
Title: Re: New revs
Post by: Nao on August 4th, 2013, 10:12 PM
rev 2205 -- signatures, mostly.
(5 files, 3kb)

! Fixed signatures not showing up in soft-merged posts. (Subs-Template.php)

! And, err... Fixed signatures not showing up, like, anywhere. Silly typo. (macros.xml)

* A few CSS tweaks: .bbc_img should have some margin around them, and left/right-aligned images should modify them accordingly. Needs testing, especially with img.center possibly conflicting with .bbc_img, but I don't think it will... Fixed letter-spacing in Chrome (latest versions seem to finally be using DirectWrite, so...), and improved background color of code blocks. (index.css)

- Since Firefox 2 hasn't been supported for a long time in Wedge, there's no need for hacks targeted to it, really. (common.css)

- Saving a few bytes of CSS in Chrome. (sections.css)
Title: Re: New revs
Post by: Nao on August 6th, 2013, 11:16 PM
rev 2206 -- moving slogan to main settings, and related changes.
(17 files, 4kb)

* Moved site slogan setting from theme area to main settings. This just makes more sense. (Load.php, ManageSettings.php, Settings.template.php, ManageSettings.language.php, Themes.language.php)

* Renamed #siteslogan to #slogan, and #wedgelogo to #logo. If these are in conflict with a parent site, well... Use creative CSS. Oh, and yes, Warm is still broken in SVN, please forgive me for not keeping it up to date there, but it is locally at least. (Load.php, index.template.php, extra.rtl.css, index.css, sections.css, skin.xml, Wine/extra.css, Warm/skin.xml, Wuthering/skin.xml)

* Minor tweak to the banner macro. (index.template.php, macros.xml)

* Minor CSS tweaks. (index.css)

! MySQLi no longer returns false when a query returns no rows. Instead, it returns null. Which is fun, because SMF/Wedge does a false test on this, not a null test. I found one in SSI.php, but there are probably dozens elsewhere. I'm going to rely on Pete to decide whether or not it's best rewriting fetch_assoc, or checking all requests individually, yay... (SSI.php)
Title: Re: New revs
Post by: Nao on August 8th, 2013, 04:15 PM
rev 2207 -- no biggies.
(6 files, 2kb)

+ Wess now allows nesting math() calls together. While it doesn't make sense to include a math() inside another (the contents can be directly parsed anyway), I realize that themers might want to assign a math() function to a variable, which itself might be used inside a math() function, causing endless troubles until now. Also, it's a nearly free fix, so, whatever. (Class-CSS.php)

* New optional variable $responsive_search_min_width should help you quickly redefine the minimum popup width for the search box. To be more specific, in Warm it's moved to the sidebar, and is thus too big to be used. This should fix it, once I'm done with the Warm update. (sections.css)

! Small fixes to Wine, Warm and Wuthering. (Wine/skin.xml, Warm/macros.xml, Wuthering/extra.css)

* Bytenazi. (index.template.php)
Title: Re: New revs
Post by: Nao on August 8th, 2013, 05:32 PM
rev 2208 -- even less of a biggie, at this point.
(1 file, 4kb)

* Warm really needed to be committed at this point, so I'm doing a half-commit, with all changes except for the new color set, which I'm not even sure I'll adopt anyway, so... There you go. This mainly fixes the sidebar button not showing up in responsive mode, and other problems related to the top bar being moved to the sidebar, overall. (Warm/extra.css)
Title: Re: New revs
Post by: Arantor on August 8th, 2013, 11:59 PM
2 modified, 2KB

Revision: 2209
Author: arantor
Date: 08 August 2013 22:58:55
Message:
! Merge in some fixes from SMF 2.0.5 patch (other issues already fixed, or require larger changes than this one commit):
 ! (XSS) $_REQUEST['sa'] could be used unsanitised. Clean up if not valid, and remove some other code we don't need any more. (PersonalMessage.php)
 ! (XSS) Email addresses were not validated when accepted for newsletters. (ManageNews.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/PersonalMessage.php
Title: Re: New revs
Post by: Nao on August 9th, 2013, 04:17 PM
rev 2210 -- I'm starting to hate preg_replace_callback......
(6 files, 7kb)

* Converted more of the eval preg_replaces into callbacks, and believe me, some of these were very, very ugly to do... I feel bad about them. Class-CSS has some global scope/private complications in the def replacer, and Subs-Cache has an even more awful interaction with a $context variable within the callback, ahh, don't say any more! Wess-related stuff was tested thoroughly (yeah sure..), the rest has yet to be tested, but I double-checked it. The only file left to convert is Class-Editor.php, and I'm not doing it right now because, guess what? It has too many of them for my stomach right now. (Class-CSS.php, Subs-Media.php, Modlog.php, Post.php, Subs-Cache.php)

* Spacinazi. (PersonalMessage.php)
Title: Re: New revs
Post by: Nao on August 9th, 2013, 11:55 PM
rev 2211 -- although, I also dislike evals, so... I guess it nearly balances out, doesn't it?
(1 file, 6kb)

* Converted the last 10 remaining preg_replace evals to preg_replace_callback. Phew. As earlier, I've ensured it doesn't crash or anything, but needs more testing, if anything. (Class-Editor.php)

! Fixed an odd little bug (another one of those that always escape my attention), where switching from Wysiwyg to normal editor would sometimes add an extra space after smileys, hmm. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on August 13th, 2013, 12:54 PM
rev 2212
(5 files[1])

+ Added support for IE 11. Mostly, fixed IE path for a few DOM elements that were removed, and forced Wedge to detect IE 11 it as 'ie11' instead of 'gecko0', as well as setting is_ie to true in JavaScript. See, 'gecko' browsers don't get lot of rights, only Firefox gets the gradients and all. Should I change this to give all CSS to unrecognizable browsers by default..? I don't know, honestly. (Class-Editor.php, Class-System.php, script.js, Theme.template.php)

! Used the opportunity to ensure a browser that can't be detected doesn't generate a version number of '0' in the CSS filenames... Just the browser name will be okay, at that point. (Subs-Cache.php)
 1. AND FRIGGIN' TORTOISESVN 1.8 NO LONGER INDICATES SIZES! CAN I EVEN DOWNGRADE?!
Title: Re: New revs
Post by: Nao on August 13th, 2013, 01:53 PM
rev 2213
(7 files, 3kb[1])

* Moved header_logo_url setting from Theme to Basic, as originally planned. I have yet to figure out how to rewrite this all... Maybe offer a 'header' select box with 3 possible pairs, forum name + logo / forum name + slogan / logo + slogan..? (Load.php, ManageSettings.php, Settings.template.php, LANGUAGES: ManageSettings, Themes)
 1. Aaahhhh... This is one of those rare cases, where it feels so much better to downgrade!
Title: Re: New revs
Post by: Nao on August 13th, 2013, 08:52 PM
rev 2214 -- removing some outdated HTML...
(24 files, 11kb)

- Got rid of all first_th/last_th classes, as they're forgotten remains of a time when :first-child was a web designer's dream. Seriously, since these are only used to do rounded borders, and IE 6 supports neither border-radius nor :first-child, the only reason we should care is that some layouts might not cause issues, so I tried to ensure rounded corners only show up in catbg and titlebg heads, but in any case, it's no big deal. Who cares about round borders in 2013, anyway? (Memberlist.php, Modlog.php, Profile-Modify.php, TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Paid / Permissions / Plugins, Merge, MessageIndex, Notifications, PersonalMessage, Profile, Recent, Who, index.css)

- Similarly, removed all scope="col" occurrences. I don't know where it originated from, but basically, in a table, all th tags automatically apply that scope if they're in the first row, so there's no need for these. (TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Plugins, Memberlist, Merge, MessageIndex, Notifications, Profile, Recent, Reports, Themes, Who)

* Anti-spam question tables were a bit too rigid, breaking easily in narrow widths. (Admin.template.php)

* Forced a vertical scrollbar on all pages, to avoid strange sidebar behavior on short pages. (index.css)

* Layout tweaks on ViewQuery MySQL queries. (ViewQuery.php)
Title: Re: New revs
Post by: Nao on August 15th, 2013, 01:50 PM
rev 2215 -- manage attachment area, reworked. This is frontend only, even though it's backend... It's complicated ;)
(5 files, 4kb)

! The (relatively old) alert/confirm rewrite broke the attachment manager, so after successfully rewriting the reqWin code to account for that, I realized that a single admin area wasn't worth the script's 100+ extra bytes, and removed the preview entirely. Instead, I'm showing a small thumbnail for all images, and it's much, much more usable now. Also removed the extra classes that made the attachment manager less sexy, in my opinion. (ManageAttachments.php)

* Added a 'nh' (no hit) parameter to attachment downloads, allowing to force the hit counter to keep quiet. This was needed for the thumbnails above, of course. (Dlattach.php, ManageAttachments.php)

! We need to determine whether windowbg or windowbg2 are the 'default' backgrounds when not alternating, really. (ManageAttachments.template.php)

! Typos and so on. (Admin.french.php)

! Forgot to commit a file in the last revision, oops. last_th stuff, if you'll remember. (Themes.template.php)
Title: Re: New revs
Post by: Nao on August 15th, 2013, 01:55 PM
rev 2216 -- crumbs.
(6 files, 3kb)

+ Added a .tinytext class that's even smaller than .smalltext (I used it in the last commit, but forgot to include it), and fixed some rules here and there. (PrintPage.template.php, extra.ios.css, index.css, report.css)

* Spacinazi. (Profile.template.php)

! Oh, and another file I forgot... Still last_th-related. (extra.rtl.css)
Title: Re: New revs
Post by: Nao on August 15th, 2013, 02:31 PM
rev 2217 -- most online, buh-bye.
(4 files, 3kb)

* Now hiding 'most online' statistics for non-moderators, as per our discussion at wedge.org, where it was established that this kind of data is only of interest to forum owners, and might be discouraging if a forum's peak activity is long gone, yet still has loyal activity. Anyone ever been slashdotted..? (Stats.php, InfoCenter.template.php, Stats.template.php)

+ Added support for border-top-left-radius and other directions, more specifically, adding prefixes to them if the user is on a very, very old browser that's not IE. Silly, eh..? Well, might as well account for everything, I say. (Class-CSS.php)

@ I think I addressed all areas, but I didn't test thoroughly, so please make sure to apply the same treatment to anything else you can find, really..!
Title: Re: New revs
Post by: Nao on August 17th, 2013, 11:17 PM
rev 2218 -- various mobile/layout related fixes or improvements, yay. This one deserves a Like, right..?
(4 files, 4kb)

* Found a better technique to fix the code tag's flex bug. Instead of setting overflow-y to scroll, I'm simply setting flex to none, which technically doesn't make it sense at all, because it's the default at this point, but it looks like Chrome insists on silently applying some non-default flex value on all flex children, which is a very bad idea, if you ask me. (topic.js)

+ Added support for the Android 'simulator' in Chrome, i.e. recognize their custom user agent as an Android device, even though it doesn't have any Android-specific element in it, e.g. 'mobile'. (Class-System.php)

* Mobile skins shouldn't show the entire topic title, in some situations. It often breaks layout, so... Shortened the message titles to 20 characters, and did the same to previous/next topic titles, which works better, for me at least. (Display.php)

- Do not soft-merge posts in mobile skins. It's not that it's not doable... It's mainly down to the fact that it's pointless, because there's nothing to remove, apart from the avatar and user name, which are optimized not to take any further space, so... No need to waste CPU cycles on this, I'd say. (Subs-Template.php)

@ Regarding topic titles, I actually pondered whether to use we::is('mobile') or SKIN_MOBILE. The first applies to mobile devices only but in all skins, while the second applies to all devices, but in mobile skins only (e.g. Wireless). In the end, I decided that since non-mobile skins usually render badly on mobile devices, it's not worth doing on these skins anyway. I'm very, very open to changing my mind, though.
Title: Re: New revs
Post by: Nao on August 19th, 2013, 08:38 PM
rev 2219
(2 files, 1kb)

+ Here's a rare thing: an attempt of mine at increasing security, which is usually Pete's thing. This is probably overkill (an isset test on all pages, to test for something that's admin-only, and probably never an actual risk anyway), but at the very least, I think it's worth discussing keeping it in or not. (index.template.php)

! A typo in a callback name generated errors when editing a post. (Class-Editor.php)
Title: Re: New revs
Post by: Arantor on August 22nd, 2013, 09:33 PM
5 modified, 5KB

Revision: 2220
Author: arantor
Date: 22 August 2013 20:33:13
Message:
! Simplified like tooltips as we talked about. Saves a query too. (Display.php, Like.php, Msg.template.php, Thoughts.template.php, index language file)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/Thoughts.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Title: Re: New revs
Post by: Nao on August 22nd, 2013, 10:02 PM
rev 2221 -- lulz, it's really becoming a running joke: long time without a commit, and then we both do one within the same hour ;)
(5 files, 3kb)

* Overhauled Msg template, to make it rely less on the skin's mobile status, and leave it up to the skeleton to decide what to do -- effectively making it much more readable, hopefully. Post header spans are now a <time> tag, something I've wanted to do for so long. A new macro was added, msg_author_avatar, which allows changing the tag type for the avatar container (li or div). The jury is still out on whether the new extra div inside .poster should be called 'column', it's an SMF convention, but that's a lot of bytes for something that could be handled with just '.poster>div'... Don't you think so..? Actually, most column definitions would fit that description, so... (Msg.template.php, sections.css, macros.xml, skeleton.xml)

* French translation. (index.french.php)
Title: Re: New revs
Post by: Nao on August 22nd, 2013, 10:14 PM
rev 2222 -- hopefully, Wireless is stable enough for prime time!
(5 files, 2kb -- but it feels more like 10KB... :P)

* Rewrote Wireless to take advantage of the new Msg skeleton. I thought it deserved its own commit, yeah... So, basically, the user box is now correctly shown in the post header, and I'm giving you back the info that was removed earlier, such as the post name (and last edit time). I reckoned that it was still very much useful in mobile mode, because often the topic title won't show up there, so it can be helpful to have it in the post. Also, it's a proper link, so you can copy and paste a post's permalink from there. (Wireless/extra.css)

* Finally found the reason why all of these Android browsers gave me different font sizes... Turns out, some of them force a scale of 1 on page load, even if it's set to 0.7, like it was. I decided that it was best to just do "like the rest" and set it to 1 (I'm even thinking of disabling zooming entirely), and then work on font sizes later. For now, it's very satisfying. (index.template.php, Wireless/extra.css)

! Fixed an undefined constant. I still really, really need to figure out why it can be undefined, but for now... It's cleaner to just test for defined(), and let it go. I can't win every time. (Subs-Template.php)

- Removed an inline style from select boxes. (Themes.php, index.css)
Title: Re: New revs
Post by: Nao on August 22nd, 2013, 10:23 PM
rev 2223 -- follow me!
(1 file, 5kb)

+ You wanted it, you have it! Here's the JS code to make user boxes follow you in topic pages. I've commented it thoroughly, in case you don't understand it on first sight. As with many other recent features in Wedge, it's something that could be plugin material, it's easy enough to insert a hook there and let the plugin do the job, so I'm committing this separately, to make it easier to spot the code and remove it, if needed. (topic.js)
Title: Re: New revs
Post by: Nao on August 23rd, 2013, 12:03 AM
rev 2224 -- GFY, IE8!
(16 files, 4kb)

- Got rid of postbg classes, replaced with :nth-of-type zebra striping. This isn't supported in IE 6-8, and I couldn't care less. We're talking about alternating colors or something, not dinner with the Queen. This should make everything a bit faster. Also, renamed the .root class (which was JS-oriented) with a more generic .msg class, which should also compress a bit better, FWIW. (attic/scripts/Unused-softMerge.js, Subs-Template.php, Msg.template.php, PersonalMessage.template.php, Post.template.php, post.js, script.js, topic.js, common.css, extra.ie6.css, extra.ie7.css, index.css, sections.css, Wine/extra.css, Warm/extra.css)

- Removed 'alternate' entry in the message array, since we're no longer using it... Feel free to restore it, if you can find another reason to use it, I guess! (Display.php)

@ Note to self: need to remove all references to .keyinfo, too.
Title: Re: New revs
Post by: Nao on August 23rd, 2013, 01:50 PM
rev 2225 -- didn't have much to commit, but I have a feeling it's still helpful to split these into chunks.
(4 files, 2kb)

! Correct me if I'm wrong, but Wedge disables template evals by default, not the other way around. So, these language strings needed to be updated... (Help language files)

* Gave labels to profile page checkboxes. Accessibility FTW. (Profile.template.php)
Title: Re: New revs
Post by: Arantor on August 23rd, 2013, 06:02 PM
9 files, 26KB[1]

Revision: 2226
Author: arantor
Date: 23 August 2013 17:01:57
Message:
! PM menu now elevated out of the main menu and put up with Notifications. There's quite a bit to this commit so let me cover it off.
 * When doing the regular poll for notifications, also supply the number of unread PMs too. We already have this number calculated, just have to send it. (Notifications.php)
 * Don't have the PM item in the main menu. I removed the m_pm declaration but the mail icons (including the one I don't think I've ever seen) are still in the sprite. (Subs.php, index.template.php, index.css)
 * Add the PM popup area next to the notifications area. (skeleton.xml, index.css, index.template.php)
 * The PM area itself handles the popup, both for the main popup as well as the preview. Previewing immediately marks something read and this must only touch is_read; is_new is used for a separate purpose in the bowels of the PM code. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage language file)
 * Lastly, the JS has to make it all play nicely. Sorry that it's basically a duplicate of the notifications code but there are a few subtle differences; firstly the PM count and notifications count are kept separate. The PM count is never used to update the page title, it doesn't have to do separate callbacks to mark any read, and there's no delete function directly from the popup (intentionally). This just felt right to me but I'd suggest we try it for real to see how people feel about it. There's also differences of URLs and the need for each popup to close the other. (script.js)
----
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/skeleton.xml

@ I *really* didn't know how to make the JS any leaner than it is :(
 1. Eek.
Title: Re: New revs
Post by: Nao on August 24th, 2013, 12:47 AM
rev 2227
(8 files, 19kb)

! Tweaked PM notifications to use different text strings, allowing for the French version (and any other complicated language) to fit into the smaller width, because we're worth it... Also restored the Settings icon. Dunno if it not being there was as desired, uh..? (PersonalMessage.template.php, Notifications.language.php, PersonalMessage.english.php)

! PM notification update code was incorrectly using the 'count' variable, instead of items[1]. Also reworked code flow to save a few bytes, e.g. pmload() is never used outside of script.js, and thus can be declared as a local function. (script.js)

- Removed the PM icons from the menu sprite. Saves 220+ bytes of CSS, yay. (index.css, images/sprite-menu-32bit.png, images/icons/sprite.png)
Title: Re: New revs
Post by: Nao on August 24th, 2013, 04:22 PM
rev 2228
(2 files, 1kb)

! The recent Wireless tweaks apparently broke the notification popup width. Hopefully this should fix it. (script.js, Wireless/extra.css)
Title: Re: New revs
Post by: Nao on August 26th, 2013, 06:24 PM
rev 2229 -- back to work after this, err... Interesting detour..?
(12 files, 4kb)

+ Added a new note class, notevoid, which is meant to be neutral, so it has a grey background. Used in notifications. (index.template.php, script.js, index.css)

* Moved notification block creation to the skeleton file itself. Effectively, this means that skins can choose to hide it, and while I don't see *why* they would want to, it's still okay to do it in my opinion. People aren't forced to use your skins. (Notifications.php, index.template.php, skeleton.xml, Warm/skeleton.xml)

* Just like CSS files, people shouldn't be able to view skin XML files from within their browser. (skins/.htaccess * 5)

! most_online param was inverted when it came to Ajax loading of monthly stats. (Stats.template.php)
Title: Re: New revs
Post by: Nao on August 28th, 2013, 09:53 AM
rev 2230
(8 files, 3kb)

* Using HTML5 instead of a div tag soup on spoiler tags.

(click to show/hide)
The main advantage is that it allows them to act like quote tags when it comes to keeping footnotes inside them[1].
 1. Ring any bell, Pete? ;)
(install.sql, index.css)

! border-box divs are nice, but adding a margin to these increases their width above 100% and kinda misses the original purpose... Doesn't it? (sections.css)

! Signatures need some extra horizontal padding in Wireless. (Wireless/extra.css)

- Removed two language strings that were no longer in use, and moved another to a more specific file. (index.language.php, PersonalMessage.language.php)

- Removing tags column from topics for now. These aren't used, and I might as well try and put them to a different table, it'd probably be better for performance. (install.sql)

* Added UptimeRobot to the bot list; it's probably a wedge.org thing only, but it's not like it's going to change anything if I add it or not, so might as well add it. (install.sql)

@ Note: forgot to add 'mixes .hide' to .spoiler blockquote, will do on next commit, do it yourself if needed ;) Did it here.
Title: Re: New revs
Post by: Nao on August 29th, 2013, 12:23 AM
rev 2231
(5 files, 2kb)

! PM blocking system wasn't working. Hopefully should work now... (Subs-Post.php)

! Stop forcing user boxes to 'position-fix' themselves if they're as tall as their parent message in the first place. Hmm, my math is a bit strange here... I think it works, though. (topic.js)

! Ouch, my eyes! An actual 'or' instead of '||', the folly! (MessageIndex.template.php)

! SPOILERS! Forgot to hide them. Which is the basic idea behind a spoiler box, right..? (index.css)

! PM preferences should load the PM language files, even if in the profile area. Cleaner. (Profile-Modify.php)
Title: Re: New revs
Post by: Nao on August 29th, 2013, 12:24 AM
rev 2232
(8 files, 3kb)

* Three more strings that weren't used in the index language files. (index.language.php, Post.language.php)

- Removed some duplicate PM strings. (PersonalMessage.language.php, Profile.language.php)
Title: Re: New revs
Post by: Nao on August 31st, 2013, 01:24 PM
rev 2233
(6 files, 2kb)

! Switching to between Wysiwyg modes generated an undefined index. (Class-Editor.php)

! Smileys were missing some left padding to compensate for the (very appropriate) internal fix I made recently. (editor.css)

! Search icon position was incorrect. (index.css)

- Spoiler input tag was over-styled. Yes, this happens once every blue moon, but I actually removed unneeded CSS. (index.css)

* Made Poll results more responsive, notably by using percentage widths. (Display.php, Wireless/extra.css)

* Spacinazi. (Display.template.php)
Title: Re: New revs
Post by: Nao on August 31st, 2013, 04:28 PM
rev 2234
(3 files, 1kb)

+ Added a skin_parser hook, which allows you to add custom parameter types to skins, and parse them. (ManagePlugins.php, Subs-Cache.php)

! Fixed a wrong CSS rule on unrecognized user agents. (Class-CSS.php)

! <css for="browser" include="file"> might have included the file in all browsers... (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on September 2nd, 2013, 04:04 PM
rev 2235
(5 files, 5kb)

+ Implemented support for template function overrides/befores/afters from within skin files. A simple example: <template name="linktree" params="$position = 'top', $force_show = false" where="override">echo $position;</template> will show 'top' instead of the first linktree, and 'bottom' instead of the second one. The default value for 'where' is 'override', you can also use 'before' or 'after' to create functions that will be executed next to the original, while still inherit the original's parameters. This effectively renders extra themes entirely moot, as you can now do pretty much anything you like with skins. And, dare I say..? Maybe even more. (Subs-Cache.php, Subs-Template.php)

* Changed the radial-gradient fixer to only deal with old WebKit versions. Really, Chrome < 26 is nowhere to be seen by now, so Safari < 6 is what I have in mind. This also suddenly makes the W3C's CSS validator say it's a valid website. Everything little bit helps, eh..? (Class-CSS.php)

* Turned a couple of entities back to UTF8 characters. Saves space... (Admin.template.php, Msg.template.php)

@ I'm working on rewriting skin setting parsing to allow more flexibility with param order...
Title: Re: New revs
Post by: Nao on September 4th, 2013, 08:44 PM
rev 2236 -- follooooooow me! (Amiga fans, anyone..?)
(5 files, 5kb)

* Improved the userbox follower to account for IE6 (which we don't really care about) and Firefox (which doesn't support position: relative on table cells, but I applied a workaround), run the code immediately after page load (rather than on the first scroll), and improve performance when the userbox is starting to shimmer into the horizon called the page top. Still needs some work, possibly even a minor rewrite... Also, minor fix in userbox CSS, mostly in IE 6-8. (topic.js, sections.css)

! Fixed a problem with language file paths in plugins. Fix was kindly donated by John/live627, as I currently suck as handling plugin code. Thanks! (ManageLanguages.php)

! Fixed a JS error on media pages when running with IE6. (zoomedia.js)

* Tweaked layout in media pages with IE6. That browser doesn't get any better ahah... (extra.ie6.css)
Title: Re: New revs
Post by: Nao on September 5th, 2013, 10:04 AM
rev 2237
(3 files, 2kb)

* Saved nearly 400 ungzipped bytes in JS and about 90 gzipped bytes in follow_me, by doing a near-complete rewrite. It was planned before my earlier commit, but I wanted to keep a SVN copy of the 'safe route', hence the commit. The Firefox hack is gone, as I'm no longer relying on position: relative (making for shorter CSS too), added an IE7 exception because it uses a floated div and I won't bother to calculate the post height rather than user box height just for it. Also, the inner div is no longer named (shorter HTML! I thought about adding it through JS too, but it may be good for skinners to keep it around)... This should be the 'perfect' version of the follow_me feature... (Until I get around to implementing it on horizontal layouts, and maybe add IE7 support, but don't hang onto that.) (Msg.template.php, topic.js, sections.css)
Title: Re: New revs
Post by: Nao on September 5th, 2013, 11:23 AM
rev 2238
(1 file, 9kb) (yes, lots of changes in the skin parser.)

+ Implemented a new helper function, wedge_parse_skin_tags, which gives greater flexibility to skin files: (1) the generic 'for' parameter (which skips a tag if it's intended for another platform) is now implemented everywhere. (2) You no longer need to re-use the same complex regex, just pass three parameters: the source string, the tag name, and an array of expected parameters (or a string if there's only one param, or nothing). (3) Return values are now in an associative array. Dealing with $match['value'] or $match['name'] is simpler than the fluctuating $match[1] or $match[3] values. (4) Parameters can now be specified in any order in the tag, and (5) whitespace handling is more forgiving. All of this for the cost of at most an extra millisecond of parsing per page load. Sounds like a good deal...! (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on September 6th, 2013, 04:59 PM
rev 2239 -- skin tags.
(5 files, 8kb)

* Rewrote the <css> parser, which was updated by mistake in the last commit (it was a WIP, really). It was tweaked to be closer in spirit to the <code> parser, and allow the inclusion of local CSS files. For instance, <css include="mana"> will load the skins/mana.css file on all your pages, and all its possible satellites. It now also allows multiple files, and does them correctly. Finally, the tag now allows empty content, in case you really only want to add an include. (Subs-Cache.php)

! Renamed <code> to <script>, as it probably makes more sense (I resisted the urge to rename to <js>, dunno why...), and ensured it would also correctly handle multiple includes. (Subs-Cache.php, skin.xml, Wine/skin.xml, Warm/skin.xml, Wuthering/skin.xml)

+ Documented the <template> skin tag in the Warm skin, and updated the rest of the documentation. (Warm/skin.xml)
Title: Re: New revs
Post by: Nao on September 7th, 2013, 08:43 AM
rev 2240 -- yay!!
(3 files, 2kb)

+ Finally added hardware acceleration to reqWin popups. This adds 264 (ungzipped) bytes to CSS but removes 269 from JS, so it's a fair trade, and most importantly, it really rocks to have full-page popups show up in a fluid way on my mobile device. It's a treat to see. Just try the media tag help popup on any media item page to see what I mean. Another drawback is that IE 6-9 will no longer show any animation on reqWin, but I just don't care about animations on IE these days; if I ever allow for js files to be compiled with an 'ie' suffix, I'll probably restore the animation code. Fair enough. (script.js, index.css)

! Fixed IE7 showing user boxes on the right by default... I'm not exactly sure why I did that to begin with, but it's true I don't test much with that browser... (extra.ie7.css)
Title: Re: New revs
Post by: Nao on September 7th, 2013, 05:13 PM
rev 2241
(4 files, 3kb)

! Blog bug: post date in message index was taken from the latest comment, rather than the blog post itself. (MessageIndex.php, MessageIndex.template.php)

* A few CSS tweaks... radial gradients don't need to specify 'farthest-corner' as it's the default; most browsers fully support HTML5 these days so I'm not wasting bytes re-defining the new block elements; IE6 has always been bad at handling word-wrap, so I'm attempting to disable it for it. (index.css)

* Parenazi. (sections.css)
Title: Re: New revs
Post by: Nao on September 9th, 2013, 07:28 PM
rev 2242 -- yeah, I'm nearly finished with HW acceleration...
(6 files, 8kb)

* Updated Zoomedia to use hardware acceleration. This adds 100 gzipped bytes to the CSS file, and 25 to the JS file. (zoomedia.js, zoom.css)

! Start animation for zooms is now pixel-perfect; previously, it wouldn't take the parent <img> tag's padding into account. Yes, that contributed to the JS size increase, too. (zoomedia.js)

- Removed (mostly due to aforementioned rewrite) the ability to set the animation speed in Zoomedia; just trust the author on this. I may restore it in the future, in case I start relying on AnimationEvent, but it's not supported before IE 10, and I can't be bothered to write more fallback code for now. (Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php)

* I was hoping to save bytes, but I had to rewrite many things due to how CSS animations are handled (most notably the description area, which still has a glitch when there's no description at all in some cases). jQuery certainly made my life simpler back in the day, but it's unable to do hardware stuff, so... Here we are. We also lose animations in oldIE, but the rest still works, and the 'preview to full' animation is still done with jQuery for now, so that animation remains. I'm doing all of this in a separate commit, in case I decide to revert later. The main issue is that performance is only increased moderately (10 to 50%, usually about 20%); transitions reached their limit here, so I'm halfway through rewriting to use compounded transforms, instead of a compounded transition. It's still buggy, so it'll come next.
Title: Re: New revs
Post by: Nao on September 12th, 2013, 11:28 AM
rev 2243 -- woohoo, 2242 got my first Like on the New Revs topic in weeks... :P
(4 files, 5kb)

! Fixed a Firefox bug where the $().offset() setter will take CSS scale() into account, instead of applying the transform on top of the object's default coordinates. It all seems very complicated, but the reality of it is that the Ajax loader was off by a dozen pixels instead of being centered on the requested element. (script.js, index.css)

! Fixed a bug of mine, still in the Ajax loader, where it was, again, off by a few pixels, this time because of internal padding. I never left the loader on long enough to notice, but it was there all the time. (script.js)

! The index CSS wasn't updated to use the can_animate pseudo-constant for keyframe definitions. Also simplified the constant. Well, just a bit. An unneeded part... (Class-CSS.php, index.css)

* Tweaked Ajax loader to get it closer to the Zoomedia spinner, so that I can remove the latter later (latter later?!). Also improved Ajax loader internal alignment on Chrome and Firefox; it's still far from perfect in IE, but I've spent enough time on IE this week... ¬_¬ (common.css, index.css)

* Restoring some documentation and code I committed in rev 2214 by mistake. Well, once again, looks like nobody ever checks my code... Although I have no idea how I came to cherry-pick these. I tend to be very careful these days, and keep my WIP to a minimum. (index.css)
Title: Re: New revs
Post by: Nao on September 12th, 2013, 11:54 AM
rev 2244 -- Zoomedia! The final rewrite! I'm not touching this again for a while, I'm telling you!
(4 files, 14kb)

* And here it is... The new Zoomedia! Fully hardware-accelerated, way faster than in the previous rev (60 FPS on mobile, when it used to be ~10 FPS before); it's damn close to pixel perfection, I killed all of the bugs I could find (and believe me, there were tons of them), and guess what-- it also restores the software animation on old browsers, and makes it much faster than before, too. I also documented some of my code, because I got lost in my own, and I only wrote it a few years back, so I added warnings here and there about why I did things that way and not another... Cross-browser compatibility *really* is a bitch, I'm telling you. I worked exclusively on that for two straight days. (zoomedia.js, zoom.css)

* Zoomedia items will now adapt to the current viewport, rather than screen size. Good if you're in zoom mode. (zoomedia.js)

* You can now freely set a custom Zoomedia animation speed in zoom.css (or, better, a custom file of yours); the JS will detect it. If HW isn't available, Zoomedia falls back to a 500ms regular animation. (zoomedia.js, zoom.css)

* Zoomedia now uses the default Ajax loader, and as such no longer needs some of the related stuff. (zoomedia.js, zoom.css, Media.language.php)

! Fixed thumbnail description showing up on top of the popup during its animation process. (zoomedia.js, zoom.css)

! Fixed popup centering when it's adapted to fit the screen size. (zoomedia.js)

- Removed the noScale option. Zoomedia isn't, and never planned to be, a perfect reproduction of Highslide. (Which, BTW, is now officially much slower than Zoomedia... :P) (zoomedia.js)

- Forgot to remove the previously deprecated 'duration' setting from the JS file itself. (zoomedia.js)

@ There was a strange bug in IE 6-9 that I never got to fix, where doing $zoom.height('auto') at one point would be randomly ignored (!), thus NOT removing the CSS height value. I really couldn't fix it, so instead I added a workaround by forcing the same operation again after the end of the subsequent animation; this effectively made things whole again.

@ My code to detect support for transitions and transforms is basically three lines. I'm totally proud of it. I could have shortened it even more by removing the parens, but it turned out that it doesn't even save a gzipped byte, so I figured it'd be best to keep it readable.

@ I added, commented out, my 'funny animation' code. I still haven't figured out whether it should be selectable. It's cool, but I'm not sure.
Title: Re: New revs
Post by: Nao on September 12th, 2013, 04:34 PM
rev 2245 -- the joys of CSS...
(5 files, 4kb)

! Fixed blog homepage (MessageIndex) when viewed in responsive mode. Fought on this for many days, until I realized a simple instruction would fix it, one I hadn't used in a couple of years I think... Anyway, it's always amusing that specifying for something to be 'fixed' will actually make it 'flexible', but you know how it is... ;) (sections.css)

! IE also needs two extra tweaks for Aeva embed responsiveness. Not Chrome, go figure. Didn't test elsewhere. (media.css)

! Zoomedia popups were incorrectly centered in desktop browsers. That's because window.innerWidth includes the scrollbar, which we don't want. Hopefully, just going for the minimum value between window.innerWidth and win_width should fix it all. (zoomedia.js)

! Fixed sidebar margins in Wuthering. (Wuthering/extra.css)

! Fixed last-minute inheritance bug in Zoomedia. (zoom.css)

* Spacinazi. Well, maybe one day I'll do it the other around and remove all of those extra linebreaks, whatever... Just lemme be misunderstood. (sections.css)
Title: Re: New revs
Post by: Nao on September 12th, 2013, 04:43 PM
rev 2246
(2 files, 1kb)

! Fixed invalid HTML on Aeva embeds (repeated style attribute). Sometimes, I'm at a loss in front of my old code... (Subs-Media.php)

! Fixed 'code' and 'html' tags being completely broken when within a post that also contains an embed; this was due to a wrong preg_replace_callback conversion last month. It didn't break one of the posts in the blog, I guess I'd forgotten to upload the modified file at the time, or something... (Subs-Media.php)

- Removed the Packages folder. I don't think anything else was using it, at that point... (Subs-Package.php, Packages/*)
Title: Re: New revs
Post by: Nao on September 12th, 2013, 04:43 PM
rev 2247
(1 folder, 1kb)

! For some reason, the Packages folder didn't get deleted at all. (Packages/*)
Title: Re: New revs
Post by: Nao on September 13th, 2013, 01:24 PM
rev 2248 -- plenty of nice little things. C'mon, like this one! :P
(10 files, 6kb)

+ The 'zoom' link on Zoomedia popups now behaves like a double-click on the image itself, i.e. it opens it on the same page. (zoomedia.js)

+ IE6 will now properly support all min-height rules in CSS files. It's actually very helpful, from what I can see. (Class-CSS.php)

* I've finally found the 'correct' way to properly align background-integrated icons with the text they're shown next to (as long as said text is not too small.) I don't see myself doing it on every single icon though, but I'll at least give it a try for feed icons. (Boards.template.php, Media.template.php, Memberlist.template.php, attic/Custom.template.php, sections.css, Wine/extra.css)

* Added flexbox layout to media item pages. Although it looks better than before ('on supporting browsers'), I'm starting to think that this layout is getting old, and should be replaced with something simpler, with just some floated elements. (Media.template.php, media.css)
Title: Re: New revs
Post by: Nao on September 13th, 2013, 10:05 PM
rev 2249
(2 files, 1kb)

! Fixed invalid HTML in blog homepages. (MessageIndex.template.php)

! Fixed message anchor targets being off by a few pixels. (Msg.template.php)
Title: Re: New revs
Post by: Nao on September 16th, 2013, 03:46 PM
rev 2250
(6 files, 3kb)

* Tweaked Zoomedia. The Close button is now drawn in pure CSS if possible (saving a whopping 2KB off the file and making it HD-friendly), removed the delay as I forgot I'd recently implemented it in the 'main' show_ajax function, saved oldIE from showing the double-click catcher (it just didn't work properly anyway), and fixed bottom padding in Glass mode (hopefully! Needs testing.) (zoomedia.js, zoom.css)

+ Zoomedia can now be shown when previewing posts in the Notifications area. Note that there's a trade-off: I specifically allowed Ajax calls to load Zoomedia, but it also means all Ajax calls need to account for $context['footer_js'] not being shown at all, and must do it manually. I'm already doing it in a few places, but not everywhere, so... These bugs will have to be fixed as they occur, basically, or I need to find a way to safely load footer_js systematically without screwing up the page. I'll get to that, eventually. That's all in a day's job for Ajax man. (Subs-Media.php, Notifications.php)

- Saving a buffer str_replace off English pages-- at least we know these don't use half-width unbreakable, uh... (Subs-Template.php)

! Ajax loader was incorrectly positioned when the parent element had padding. (script.js)

! A small typo of mine in the notification code. (script.js)
Title: Re: New revs
Post by: Nao on September 16th, 2013, 05:07 PM
rev 2251
(12 files -1, 278kb, 10 minutes of work.)

* Updated getID3 from v1.9.1 to 1.9.7. Has the new (MPL) license, good! Haven't tested it, though... (media/getID3/*)
Title: Re: New revs
Post by: Nao on September 16th, 2013, 11:08 PM
rev 2252
(295 files, 126kb)

* Updated credits, contributors, license, etc... Not only for anything related to Pete's departure from the project, but also cleaning up the credits and adding anything Pete might have forgotten to credit when he compiled the list. 'Wedgeward' is replaced with my full name until I figure out what's best. Also fixed John's last name. More things left to do... Will come, will come. (contributors.txt, license.txt)

* Updated and harmonized all file headers as much as I could; if anything bad's left, I'll fix it later. (295 files)

* Renamed nested-sortable.js to just nested.js, as there's just the one file... (ManageBoards.php, nested.js)

- Removed all @version tags. I'm not, repeat, I am NOT, going to add @version tags to all files every time I'm releasing a new version. I want to be able to upload a package with only the files since the last time. Really. It's easier to upload. Still need to complete the removal of associated features, though. (295 files or so.)

- Removed some code that relies on reading @version tags. Still some left, though. (smfinfo.php) (Yes, that's an odd filename, I know...)
Title: Re: New revs
Post by: Nao on September 17th, 2013, 12:31 PM
rev 2253
(2 files, 2kb)

! Finally-- follow_me is pixel-perfect. I took an hour of my time to reconsider the math of it all, and found 3 little bugs in my calculations; Neither the separator height not the fixed userbox top position were taken into account, and ended up doing strange things on very short posts. Also, there was some kind of a margin collapse trick that happened in the user name and made positioning more complicated; replace the margin with a padding, it works just the same. It's all in the past, now. I can finally devote my time to another cool feature. I wish. (topic.js, sections.css)
Title: Re: New revs
Post by: Nao on September 17th, 2013, 06:26 PM
rev 2254
(15 files, 6kb)

! A few files were incorrectly set to ISO-8859-1 when they should be UTF-8. These were the files whose copyright lines I modified manually, rather than automatically. Not that it matters much, though: I'll probably change the copyright data again soon, and they'll all be ISO again. Meh. (.htaccess, Settings.php, Settings_bak.php, ssi_examples.shtml, Home.template.php, Class-ZipExtract.php, Wuthering/extra.css, Wireless/extra.css, zoom.css)

! Forgot to credit Karl Benson for the early versions of Aeva in the contributor file. (contributors.txt)

* Renamed 'Consultants' to 'Contributors' in the Credits page (that's been pretty much the same thing so far...), and simplified the code. (Credits.php, Who.template.php, Who.language.php)

* Spacinazi. (Wine/extra.css)
Title: Re: New revs
Post by: Nao on September 18th, 2013, 04:29 PM
rev 2255
(5 files, 2kb)

* Licensing tweaks. Most importantly, I decided to try removing the copyright mention from all pages (except for the credits page, of course.) This saves the HTML and my ego from inflating too much, and still keeps my rights the same. If I can't live without my name in there, I'll restore it, but it's unlikely. (Class-ZipExtract.php, index.language.php)

! A final fix for half-width non-breakable spaces not showing up in mobile and oldIE. Basically, I needed more work in minified JavaScript, and in the debug junk, which is shown after doing the original conversion anyway. I'm trying not to be too bothersome with this one, it's just a space... Or a missing one. In French. (Subs-Cache.php, Stats.french.php)
Title: Re: New revs
Post by: Nao on September 18th, 2013, 11:22 PM
rev 2256
(2 files, 4kb)

* Solved a problem caused by follow_me, where quick editing a very long post would show a huge empty post and a tiny textarea. The textarea will now match exactly the size of its original post, making it more akin to a live editor. (topic.js)

* Insert a 'merged' div on the first post of a soft-merged series of posts, because users might want to style them all. I'm considering moving the merged class to their containing div (.postheader), but that would make it harder to style for IE6. I know, I know... 'Who cares?' (Subs-Template.php)

! Fixed quick edit of first post in a soft-merged blah blah. It used to request for a quick edit of all posts, at the same time. (topic.js)

! Blog posts can't be soft-merged with a regular comment. That would be silly... On pages 2 and later, obviously. (Subs-Template.php)
Title: Re: New revs
Post by: Nao on September 20th, 2013, 07:24 PM
rev 2257
(1 file +2-2, 186kb)

* Updated jQuery from 1.10.2/2.0.3 to 1.11/2.1 beta. They seem to be around the same size, only marginally heavier, no biggie, and supposedly they load faster, and I'm all for that. (Load.php, scripts/jquery-*.min.js)
Title: Re: New revs
Post by: Nao on September 20th, 2013, 07:36 PM
rev 2258 -- e-mail rewrite! You didn't think it was needed? Neither did I, until I found the bugs!
(3 files, 9kb)

+ Notification batches can now be sent as HTML, too. Although it's disabled by default, I can confirm that it works just fine. (Notifications.php, Notifications.template.php)

+ Rewrote sendmail() function: updated documentation (needed some work!), allowed for fine-tuning HTML e-mails by specifying the raw text fallback to send (it doesn't have to do that ugly tag stripping), shortened the body building part by not redoing everything twice, simplified the body boundary, added the boundary at the top of the message because it's the way it's done in RFC 2046, sped up mimespecialchars() a bit by not doing a preg_match_all, and fixed a bug where the raw text fallback was actually saying 'UTF-8' instead of the e-mail body itself, added in Arantor's earlier rewrite. Thank you Google for offering to read the 'raw contents' of an e-mail, because not every webmail provider does it, IIRC. (Subs-Post.php)

* Tweaked notification e-mails to look better. (Notifications.template.php)

@ Do we really have to provide TWO raw text fallbacks for HTML e-mails..?! Fighting spam, really? This code is at least 8 years old. Are we sure this isn't a fix for some completely outdated problem..?!
Title: Re: New revs
Post by: Nao on September 24th, 2013, 04:08 PM
rev 2259 -- whatever I can commit separately from my huge upcoming rewrite of the quick edit stuff, really...
(8 files, 5kb)

* Updated msg skeleton to add a new layer (and macro), msg_entry, which holds the exact content that should be kept in soft-merging situations, i.e. post header, body and action bar. The HTML counterpart is a new <article> tag, which is also semantically nice, and makes it a bit faster to soft-merge. (Subs-Template.php, Msg.template.php, macros.xml, skeleton.xml)

- Removing some WIP code that I thought I'd already removed before, but... Whatever. (Subs-Cache.php)

- Removing the footer tag from ignored posts; no need for it, in the end... Can't remember why I thought I'd need it, either. (Msg.template.php)

* Moved some credits out of language files, and into Credits.php, to avoid having to update language files every time something gets changed there. (Credits.php, Who.language.php)
Title: Re: New revs
Post by: Nao on September 26th, 2013, 04:33 PM
rev 2260
(1 file, 5kb)

+ IE 11 is now recognized as supporting flexbox by Wedge. I needed proof, you see... I won't test a lot on it, though, so if it breaks... Deal with it. (Class-CSS.php)

+ Added support for IE 10 flexbox model. Meaning you can now simply use @if can_flex and add your Final Flexbox model code, and it'll automatically run in IE 10 as well, even though it's using the 'Tween model internally. Oh, and yes, just like Firefox, IE 10 now uses flexbox for messages. Self high five! (Class-CSS.php)

+ As one would expect, Firefox, IE 10 and IE 11 now correctly support the flexbox path of the msg skeleton, i.e. tables will no longer killed for the making of a topic. Not that I care, but... Apparently, there's an SPCA branch devoted to tables. (Class-CSS.php)

- Removed indirect support for non-final flexbox models to eliminate some confusion, i.e. if you type 'display: box', it won't be renamed to 'display: -webkit-box' in older Safari, for instance. You'll have to provide the generic suffix. Why? Because I want to encourage the use of the final flexbox model, that is. Since Final and Tween models are now supported transparently in Wess, the only browsers that require manual adjustments are old IE (no support at all) and non-latest Safari/iOS. And if you're using these, you can always upgrade if you want flexbox coolness. (Class-CSS.php)

@ Note: flexbox still doesn't work correctly in the aforementioned browsers at this point, but that's because I'm saving the sections.css rewrite for a later commit. I've still got many things to sort through, before it's committable.
Title: Re: New revs
Post by: Nao on September 26th, 2013, 04:43 PM
rev 2261 -- looked harder -- and found some last files to commit, before the big one.
(7 files, 2kb)

* You can now (plugin, skin, whatever...) add your own credits to the bottom of each page, without having to hack into language files. Beware! If $context['custom_credits'] is abused, I'll add some code to prevent it from getting too large. Push your credits to the credits page, that's where they should be, really. (index.template.php)

* The reqWin animation was a bit too over-the-top when the popup grew in size. Made it a bit more... respectable, say. (index.css)

* On focus, a button should still show some recognizable outline. This week's contribution of mine to accessibility. (index.css)

- Removed a rogue period. Oh, my, now I absolutely need, want to restore it... What's happening to me?! (index.language.php)

- Removed wedge.org-specific code from the index template, at last. (index.template.php)

- Removed a duplicate declaration. Thanks John! (Post.php)

- Removed some hardcoded styles. If these things ever get in the way, well... I'll look into it. There's one remaining in the Display template, but it's scheduled for next commit... (MessageIndex.template.php, Recent.template.php)
Title: Re: New revs
Post by: Nao on September 27th, 2013, 12:52 AM
rev 2262 -- finally, the BIG one! I'm happy with it!
(6 files, 19kb)

+ Committing the changes that now allow Firefox, IE 10 and IE 11 to use the flexbox model to show posts in topics. This is way cool, but wait for the next item in this changelog... (sections.css)

+ A very, very thorough rewrite of the Quick Edit code. While most of it is internal stuff geared at making it cross-browser (and it required many subsequent rewrites over the week), here's what you definitely WILL notice when quick-editing a post:

    + The Cancel button shows up right on top of the Quick Edit button, meaning you can click it without moving the mouse if you quick edited by mistake. Mouse path optimization FTW..?! (topic.js, sections.css)

    + The textarea will no longer show scrollbars (unless it gets very long, in which case I added some code to make them reappear); instead, it will grow and shrink depending on the length of your text. (topic.js, sections.css)

    + Additionally, the window will stay focused on the bottom of your posts, moving to the bottom each time you create a new line; this helps you write an entire book without ever having to scroll. Well, maybe not a book... A novella, maybe. Okay, a short story. What, too long? Kids these days... Okay, you can write "LULZ" just like you used to, it's just the same to me. Nobody's reading these changelogs anyway. (topic.js)

    * Moved the quick edit template string to the topic.js file itself; considering moving the quick edit code to post.js entirely (I think it would be the best place for it, needs checking). This is good for bandwidth, as JS files are cached. (Display.template.php)

    * Simplified QuickModify object, now it only holds a tabindex option, and even then-- I think it'd be safe to remove it entirely. Renamed the object to QuickEdit, too, renamed qm_* classes and functions to qe_*, etc. (Display.template.php, topic.js, sections.css, index.member.css)

    * The Quick Edit button is no longer hardcoded in the HTML, but added through JS, which is easy since there was already a can-mod class per message. I don't really mind about people who disable JS on a daily basis, but they won't dictate how I code my software, uh. (Msg.template.php)

    * The edit area is now a layer that shows up independently of the post itself, fixing a lot of minor animation issues. (topic.js, sections.css)

    * The textarea now has a clear 64KB size limit. Well, I put in 65.500 chars, dunno if it's for the best -- but it's still better than 'infinite', if you catch my drift. (topic.js)

    * The error box is relocated to the lower left of the textarea, and is slightly better styled. (topic.js, index.member.css)

    * Size optimizations. Mostly needed by the fact that the rewrite increased the topic.js filesize by 10%... Which, itself, is mainly due to the inclusion of the QuickEdit template into the JS itself. (topic.js)

* Clearly disabling follow_me on touch devices. That's until I get around to adding some proper skin settings to determine whether you want follow_me to be enabled or not. (topic.js)

* follow_me should also be called on a window resize, in case the padding around user boxes is changed. Which, as it happens, is the case in Weaving, my default skin... (topic.js)

! Fixed follow_me in infinite scrolling mode. (topic.js)

* Ensuring that user boxes can be enlarged vertically through CSS. This was needed by the quick edit rewrite. (topic.js)

* Moved IconList init code to topic.js. Okay, it's just one line... (Display.template.php, topic.js)

* Prioretize (prioritize?) DOM layout fixes over script execution in infinite scrolling; in human words, this means you should no longer have broken CSS in newly loaded posts if a script failed to load/run correctly. (topic.js)

* Slightly changed the attachment area's HTML layout, to make it easier to style (one div per thumbnail, and one p tag per description.) Remove a Firefox hack that was, very certainly, a leftover from the Firefox 3.x era. (Msg.template.php, sections.css)

! Attachments weren't being hidden in ignored posts. (Display.template.php)

! The Restore button icon was missing. (sections.css)

@ If you're curious -- yes, I'm planning to backport my quick edit changes into the main post editor.
Title: Re: New revs
Post by: Nao on September 27th, 2013, 12:52 PM
rev 2263 -- the leftovers, and some language handling fixes. Oh, and I just found a bug with quick edit (the single quote entities)... Will have to work on that ASAP.
(8 files, 7kb)

! Post-moderation delete button was missing an icon. (index.member.css)

! #new anchors were eaten up by soft-merging. (Msg.template.php)

! Meh. Extra space, not needed, not wanted... (pm.js)

! Okay, I'm adding that silly IE 11 hack I mentioned in passing. Just in case it's also in there in the final release... And it's only a few more bytes, anyway. (topic.js)

! Since jQuery will use entities 'as is' in button values, I had to be more severe and convert named entities to \u strings as well. Works well. (Subs-Cache.php)

* Used the opportunity to convert numeric entities to UTF-8 at language caching time. Again-- it saves bandwidth altogether. (Load.php, Subs-Cache.php)

+ A small addition to loadLanguage, while I'm at it... Ability to force reloading all previously loaded language files, can be useful when doing a language change midway through page load. It's not being used anywhere for now, but it's nice having it around. (Load.php)

* Commenazi. (Class-String.php, Load.php, Subs-Cache.php, ManageLanguages.php)
Title: Re: New revs
Post by: Nao on September 27th, 2013, 04:46 PM
rev 2264 -- how long am I gonna keep posting bug fixes...? :P
(6 files, 5kb)

* Saved 150 bytes by simplifying the moderation strip code. Really. This JS was just too... Afraid of doing something wrong. (topic.js)

* More Quick Edit fixes/changes...

    ! Entities were being shown in plain view. This was due to the recent changes; used to have bodies injected into a string that was then turned into HTML, but I made it faster by first building the DOM object and then injecting the data into it, which jQuery shows verbatim. I needed to also remove entities at the source. (QuoteFast.php)

    ! If a post was longer than the space available to edit it in to begin with, it should already show scrollbars, not just when we reach the limit while editing. (topic.js)

    ! After sending your edit, the post header (subject and modified) wasn't updated at all. This was an old bug I'd say, not related to the recent changes. (topic.js)

    ! Also, the Modified string was incorrectly formatted, due to a structure change in $txt. Well, that's an old one, too... (JSModify.php)

    * Changed the textarea to keep showing the action bar. The jury's still out on this one. It's obviously better to hide it, because more space and everything, but (1) one might still want to immediately delete their post after first trying to edit it, and having to first cancel the edit is annoying, (2) I don't know, I feel it looks more professional that way, or something... (topic.js)

! Forgot to commit a change related to the UTF encoding tweaks from last rev. This also fixes a debug char bug. Not a debug codeblock. Just a character. Really. (Subs-Template.php)

* Harmonizing an underscore into a dash. Yawn. (Subs-Post.php)

* Commenazi. (Subs.php)
Title: Re: New revs
Post by: Nao on October 4th, 2013, 04:29 PM
rev 2265 -- the usual "pre-bigger-commit" bunch of small fixes/additions.
(10 files, 4kb)

* Making the footer JavaScript outputter available to hackers. It's needed for the next commit... (index.template.php)

! IE 10 supports flex value 'space-between', but it needs to be renamed to 'justify'. (Class-CSS.php)

! Static method call in a non-static class constructor? Oh well, at least it still worked... So, whatever. (Class-Skeleton.php)

! Always initialize the rtl variable (for @if tests), for clarity mainly. Although, I'll have to admit, I haven't tested RTL mode in quite a while... Also saved a few lines by replacing a list/each pair with a key/current pair. I'm like that. (Load.php)

! Wedge was leaving some blank lines in the HTML source after soft-merging posts. (Subs-Template.php)

! Topic list had too narrow a width in mobile skins. Hmm, I have a feeling that fix is in need of something more distinguished... (MessageIndex.template.php)

* Commenazi, and a reminder to self. (ManageMaintenance.php, Subs-Post.php, Subs-Members.php)

* Moved the JumpTo text from the basic HTML source to the script.js file, where at least it's cached. Only saves a few bytes per page, but why wouldn't I want to..? Plus, hey, it's a free fix for infinite scrolling... (index.template.php, script.js)
Title: Re: New revs
Post by: Nao on October 5th, 2013, 12:05 PM
rev 2266 -- turns out I had many more minor changes to be applied separately from the infinite scrolling rewrites; it's better for readability to do them separately, really...
(10 files, 13kb)

! Fixed AeMe embeds not always correctly working in infinitely loaded posts. Oh, yes, they'll still fail on most mobile browsers... No se preocupe. (Aeva-Embed.php, Aeva-Subs-Vital.php)

! The recent mass-conversion of files to use UTF-8 (rev 2252) broke aeva_getEncryptedFilename(), so I rewrote it to use hex-encoded values, instead of plain characters. This should work better (and it better do, I wrote the conversion manually!), but honestly, maybe I should just not bother either, because it's all about Linux filenames, and I'm sure they support UTF-8.. Right? (Aeva-Subs-Vital.php)

* Sped up the Go up/Go down features; an animation looks nice, but I never really wanted to spend one second flying over a topic page. (topic.js)

* Moved QuickInTopicModeration to QuickMod.php -- makes more sense, to me. (index.php, QuickMod.php, Display.php)

* Harmonized hr separators to always show at the end of a topic page, instead relying on CSS to hide the last one. This is better for infinite scrolling, basically. And John asked for it. (Msg.template.php, sections.css)

! While forced linebreaks are generally okay in a fixed layout, I should really stop enforcing these in responsive layouts. (index.language.php)

! Prevent quick_edit buttons from being duplicated when using infinite scrolling. (topic.js)

- Reverted the actionbar hack in quick edit. It's best to get as much real estate as possible for the textarea, even if it doesn't look as good. There are worse things to deal with, really. (topic.js)

- Removed a few unused styles. I'm sure there are more in there, I just need to find them, or someone else to find them for me... (sections.css)

@ Note: added an 'edited' string to language files, too... This will be used in the next commit.
Title: Re: New revs
Post by: Nao on October 5th, 2013, 12:13 PM
rev 2267 -- PHEW! And here it is... The infinite scrolling rewrite. Although, I think what's infinite here, is the rewrite, not the scrolling.
(6 files, 10kb)

* Changed the way 'Mark unread' works on topics. The original thinking was this (and it always confused the hell out of me): the unread position would be reset to what it was *before* the current topic page was loaded. Instead, I changed it to be reset to the page you're currently viewing. That is, if you've already read the topic, and you just want to sort of 'bookmark' a particular page, you can go to it, and press Mark unread. Next time you follow a 'new' link to the topic, you'll be taken to that page. I believe this is more natural. Another difference is with the last page. Previously, pressing Mark unread there would mark the entire topic as read. Now, doing it will simply mark this page as unread. If you need to mark the entire topic as unread, for some reason, you can just go back to page 1 and mark it unread there. (Display.php, Subs-Boards.php)

* Overhauled infinite scrolling to be closer to what one might except from it. Instead of requiring several mouse wheel rolls to load the next page and show it, Wedge will pre-fetch it in the background when you're getting close to the end of the page. It will then show it immediately as soon as you reach said end. The hardest part was to get 'mark read' to behave, and it should be good: an infinitely scrolled page is only marked as read when the next page is prefetched. On the last page, Wedge will not prefetch anything of course, but will send a Mark read request in the background if the page isn't already marked as read. (Display.php, subs-Boards, Display.template.php, index.css, topic.js)

* The Ajax version of topic pages (i.e. infinite scrolling) now return only what's needed, i.e. the posts themselves, and a new version of the page index. (Display.template.php, topic.js)

+ Added an 'edited' variable to topic post arrays. Basically, if set to true, it means "this post has been edited since the last time (last post) you read (in) this topic." Up till now, it wasn't possible to determine whether the first 'new' post in a topic was really an unread post, or a modified post. (Display.php, Msg.template.php, index.language.php)

* Side font size tweak. Needed wider testing, so I want it on wedge.org. (index.css)

@ The topic.js rewrite, despite all the additional improvements, saved about 300 bytes. Dunno how much when gzipped, though.

@ Note to self: need to support touch in infinite scrolling.
Title: Re: New revs
Post by: Nao on October 5th, 2013, 04:27 PM
rev 2268 -- I'll get it right! I promise!!
(5 files, 3kb)

+ Doing the touch version of infinite scrolling. Well, it's just a try. The first one didn't work, so... Trying again. (topic.js)

* Trying to increase infinite scrolling performance.

  - Attempting to limit the number of events infinite scrolling is tied to to just one (scroll for desktop, touchmove for mobile.) (topic.js)
  - No need to load topic.js again; I'm in charge of that file, so I'm responsible for calling its functions manually as needed. (Display.template.php)
  * The Mime and Zoomedia plugins now add a 'processed' class, and refuse to handle further calls to items marked with that class. (script.js, zoomedia.js)
  * Same for InTopicModeration calls. (topic.js)

! The Mark read request on last pages was sent on each page scroll... Oops! (topic.js)

! Fixed wrong language entry. (Who.french.php)
Title: Re: New revs
Post by: Nao on October 8th, 2013, 03:02 PM
rev 2269 -- back to some less headache-inducing commits, phew...
(3 files, 2kb)

+ Wess now allows for the use of wildcards instead of values in @remove operations. This can be useful, if you're not sure what the parent is doing at this point. (Class-CSS.php)

! Fixed error occurring on topics with no replies. (Display.php)

! Plugin language files should get their entities converted to UTF, just like regular language files. (Load.php)
Title: Re: New revs
Post by: Nao on October 9th, 2013, 10:58 AM
rev 2270 -- minor admin stuff. I usually don't set foot in there, but I have to now, don't I...?
(7 files, 3kb)

* Some tweaks to the admin search... Don't cut off item descriptions (really, any reason to do that in the first place..?!), better French text, and improve the layout a bit. (Admin.php, Admin.template.php, mana.css, Admin.french.php)

! Typo in the reattribute feature. Seems that Pete liked spelling 'cannon' instead of 'cannot' (same in Simple/WedgeDesk), there may be a hidden meaning behind that, but I don't know what. (ManageMaintenance.php)

* Added a few separators in the reattribute feature, because it wasn't made very clear that the last option was for merging members, rather than merging a member and a guest. It's very different, I'd say. (ManageMaintenance.template.php)
Title: Re: New revs
Post by: Nao on October 9th, 2013, 07:17 PM
rev 2271 -- small, but nice.
(2 files, 2kb)

+ Added ability for all skin tags to run on a specific URL. Use url-* for that, with * being your target $_GET variable, of course. <css url-action="profile" url-area="forumprofile">, for instance, will print CSS only on the ?action=profile;area=forumprofile page. That's a very, very good addition for themers. (Subs-Cache.php)

! Fixed broken layout on ViewQuery pages. (ViewQuery.php)
Title: Re: New revs
Post by: Nao on October 10th, 2013, 02:59 PM
rev 2272
(58 files, 6kb)

- $keys and $disable_trans are params only used in non-MySQL situations, and as Wedge isn't coming back to PGSQL and SQLite any time soon, there's no reason to complicate insertion queries for nothing, uh? Also updated all 200+ inserts to reflect that. (Class-DB.php, and 57 other files.)
Title: Re: New revs
Post by: Nao on October 10th, 2013, 03:17 PM
rev 2273 -- a small one.
(4 files +1-1, 3kb)

* Redid the Modify button icon; it was so long, it looked like a trident. Plus, the new version is twice smaller in size. (modify.png, modify.gif, index.css)

* Remove whitespace when linktrees are empty. (index.template.php, index.css)

! Don't prevent non-default events when middle-clicking an element to open the sidebar. In the real world, it means: if you middle-click a '+' button somewhere, the associated link will correctly open in a new tab. My only goal is to avoid that dreaded Windows 'auto-scroll' mode. Sorry, I hate that one so much, it's just unbelievable... (script.js)
Title: Re: New revs
Post by: Nao on October 15th, 2013, 04:41 PM
rev 2274
(3 files, 2kb)

* Rewrote message icon handler for clarity: split into multiple named methods, list is no longer a child of the body itself, body click handler is removed when list is closed, etc. It also saves a few bytes of JS and CSS, not many, but that's still a plus. (topic.js, index.member.css, sections.css)

! I'm not sure why I've been using $(document).find() instead of just $() in some code, as well as using .bind/.unbind when I switched to modern jQuery (and .on/.off) long ago, but... I guess it happens even to the best. (topic.js)

- Unused class no-flex. (sections.css)

:edit: ! Fixed code blocks in Firefox. Just like Chrome, Firefox doesn't like white-space: pre blocks when they only generate an horizontal scrollbar, but it doesn't cause the same glitch, and it can't be fixed the same way, so I'm disabling flex on these posts when such a situation occurs. It's very unlikely they'd benefit from flexbox anyway, as flex is mostly for very, very short posts. (topic.js)

(Sorry for forgetting to log the last one.)
Title: Re: New revs
Post by: Nao on October 15th, 2013, 05:32 PM
rev 2275 -- mostly small stuff.
(12 files, 7kb)

* Overhauled credits page again, to make it easier to grasp. Will shorten it again later. Using CSS columns instead of the two-columns variation, as it will scale much better. (Credits.php, Who.template.php, sections.css, Who.language.php)

+ Added support for IE 11 in Wess and we::is. (Class-CSS.php, Class-System.php)

+ Improved CSS column support: break-* rules are now supported. (Class-CSS.php)

! Fixed CSS column support in IE 11. (Class-CSS.php)

@ Minor fixes:
  ! Fixed typo in getLegacyAttachmentFilename. Managed to track it down to a years-old revision by Pete. Interestingly, or not, I did the exact same work a few days ago on another file, and didn't notice it. And without the typo. (Subs.php)
  - Removed individual developers from SMF credits; refer to SMF itself for a list. It was only there because, back in 2010, I insisted that I'd been a SMF developer, even if was never given the proper badge for it. In 2013? I'm just glad I never was officially in that team.
  * Commenazi. (Subs-Boards.php, Subscriptions-PayPal.php)
  * Centering a checkbox in the member list. (ManageMembers.php)
  * Simplified and harmonized a regex. By two bytes. Well worth the time spent on reading this, uh? (Aeva-Subs-Vital.php)
Title: Re: New revs
Post by: Nao on October 16th, 2013, 11:26 PM
rev 2276
(8 files, 4kb)

+ Skin option parameter url-* (url-action, url-board, etc.) can now take a wildcard value. i.e. url-board="*" will run the option only if you're within a board, any board. (Subs-Cache.php)

+ Added new skin option parameter: board-type="blog|board" will run the option only if we're within a blog or board. This was required by the fact that it isn't possible to determine the board type just from looking at the URL, eh. (Subs-Cache.php)

* Homepage will now systematically show the info center in the sidebar if you're on a desktop. Really, there's enough space in it for that, and it makes sense. The only situation where it's a problem is when there isn't enough space to show the sidebar itself, but then you just need to middle-click, so... Whatever? (Home.php)

* Renamed JS string is_ff to is_firefox, as apparently they want to be called Fx, and is_fx is misleading IMO. Might as well just waste a couple of bytes and use the full name, eh..? (editor.js, script.js, sha1.js, topic.js)

* Trying a new method for middle-clicking to trigger sidebar. More precisely, I'm now dismissing clicks if they're done over an item that has any events associated to it. Should work, but I want to be cautious here. Needs more testing. (script.js)

- Removed unused strings. (Who.language.php)
Title: Re: New revs
Post by: Nao on October 17th, 2013, 12:25 AM
rev 2277
(5 files, 6kb)

* The debug junk in the footer will now allow you to show either the block list or the SQL query log, or both. Just select 'no one' in the Debug admin area if you want to disable one of them. The reason I did it was after I realized that even after gzipping, the block list would still take 1 to 2KB of bandwidth when I never use it; I only want an easy link to the query log, and that only barely takes a few bytes to show. (ManageServer.php, Subs-Template.php, Admin.template.php, ManageSettings.language.php)

* Added a JS 'hint' that the db_show_debug checkbox is linked to the two dropdowns that follow it. (ManageServer.php)
Title: Re: New revs
Post by: Nao on October 19th, 2013, 10:38 PM
rev 2278 -- while waiting for someone to comment on my newest privacy/contact list topic... :P
(5 files, 3kb)

* Refactored credits page's multi-column to a generic class; this should make it easier to re-use through other code, and plugins. (Who.template.php, index.css, sections.css)

! SSI pages would show header and footer twice if rendering through ssi_run(). (Subs-Template.php)

! Fixed an undefined variable if current page didn't specify a title (e.g. SSI-run page.) (Subs-Template.php)

! Non-global @removes in Wess didn't accept wildcards, due to a last-minute test. Doh. (Class-CSS.php)

* Give more visibility to some profile homepage links. (sections.css)

- Removed some unneeded styling on flexbox-enabled browsers. (sections.css)
Title: Re: New revs
Post by: Nao on October 22nd, 2013, 11:41 PM
rev 2279 -- wait, it no longer works that way..... :P Well, until I figure out a clean way to add rev numbers, Reply numbers for this topic will stand for a rev number.
(1 file changed, 1 insertion(+), 1 deletion(-))

- Removed a reference to the old tag system.

@ First attempt at a git commit & push!
@ And it obviously worked... :)
Title: Re: New revs
Post by: Nao on October 24th, 2013, 01:00 PM
rev 2280 [master 1dd8825]
3 files changed, 35 insertions(+), 40 deletions(-)

+ Initial privacy rewrite. Some stuff is dependent upon my WIP contact list system, so it probably won't work perfectly until I'm done with it all. Still... I love looking at how simpler the privacy queries now are. (index.php, Class-System.php, install.sql)
Title: Re: New revs
Post by: Nao on October 24th, 2013, 09:15 PM
rev 2281 [master 33a803d]
 14 files changed, 550 insertions(+), 62 deletions(-)

+ Initial contact list code. There are still tons of things to do, so for now you can only create generic lists (including one type I'll probably end up dropping), and add/remove users from their profile pages. (install.sql, Class-System.php, Profile-Modify.php, Profile.php, Subs.php, Profile.template.php, index.language.php, Help.language.php, Profile.language.php, sections.css)
Title: Re: New revs
Post by: Nao on October 24th, 2013, 09:27 PM
rev 2282 [master 05be743]
 8 files changed, 48 insertions(+), 32 deletions(-)

+ Second batch of privacy rewrites. Thoughts should now support contact lists, and everything (or most everything) should use integer values now. Phew. (Ajax.php, Post.php, Subs-Post.php, Thoughts.php, Thoughts.template.php, script.js)

- Removed unused variables. (Like.php)

@ Todo comment. (Load.php)
Title: Re: New revs
Post by: Nao on October 24th, 2013, 09:31 PM
rev 2283 [master 955283b]
 5 files changed, 37 insertions(+), 15 deletions(-)

! Fixed 'file not found' errors not actually showing the filename. (ManageErrors.php)

! Ajax requests didn't return any parseable HTML when errors occurred. (Errors.php, Errors.template.php)

* Try to minimize gaps between membergroup IDs if deleting groups right after creating them. (Subs-Membergroups.php)

- Don't show your avatar in the sidebar if you're a guest. Duh. (index.css)

! Fixed (hopefully without introducing new issues on other browsers..?) a scrollbar problem on pages that were shorter than the window height. (index.css)
Title: Re: New revs
Post by: Nao on October 25th, 2013, 01:29 AM
rev 2284 [master 8477fec]
 2 files changed, 101 insertions(+), 37 deletions(-)

+ Implemented a converter for buddy lists to contact lists. Will only execute after you've made use of Thorsten's importer and thus gotten buddy lists from an earlier SMF install, for instance. (Load.php)

! Thoughts needed more work to work with the new privacy & contact list systems. It's not perfect yet, but it's getting there! (Thoughts.template.php)
Title: Re: New revs
Post by: Nao on October 25th, 2013, 02:45 PM
rev 2285
 5 files changed, 19 insertions(+), 14 deletions(-)

! Some Ajax requests still did skin-related testing, so let's just forget about being rigid about it, and initialize dummy versions of the most common skin variables, even in Ajax mode. (Load.php, Subs-Cache.php)

! Event detector in sidebar opener was actually broken, oops. (script.js)

- Old unused variable. (Class-CSS.php, install.php)
Title: Re: New revs
Post by: Nao on October 25th, 2013, 03:15 PM
rev 2286
 3 files changed, 8 insertions(+), 6 deletions(-)

! Wedge didn't even show the thought form if no thoughts were found in the database. Didn't make sense. Thanks Pandos for pointing it out. (Thoughts.template.php, index.language.php)
Title: Re: New revs
Post by: Nao on October 25th, 2013, 03:53 PM
rev 2287
 5 files changed, 12 insertions(+), 8 deletions(-)

! Privacy constants weren't defined in SSI mode. They're probably better off in the user class file, then... (index.php, Class-System.php)

! Fixed redefined constants, and simplified (a bit) the skin option parser. (Ajax.php, Load.php, Subs-Cache.php)
Title: Re: New revs
Post by: Nao on October 26th, 2013, 06:24 PM
rev 2288
 7 files changed, 34 insertions(+), 27 deletions(-)

+ Saved about 0.15s (25%-30% of total time) on index CSS cache regeneration by adding a simple lookbehind assertion in the very last regex. I can't believe that one single, ultra-simple regex to remove a few empty elements used to take as long as the entire process of nesting, which has dozen of complex regular expressions. And yes, I did tons of tests. Something is wrong here. Well, at least it's fixed now. (Subs-Cache.php)

+ Wess tests in the shape of @is() calls are now even more useful. Up till now, @is (test, if_true, if_false) would be a straightforward use, then @is (test, if_true) showed nothing if test was false; I've now added the simplest possible form, @is (test), which, instead of returning the desired string, returns true or false strings, making it possible to use @is tests inside variable declarations. (Class-CSS.php)

* And obviously, as a result, I've removed the simili-hack for can_flex/can_animate and replaced them with similarly named variables, $can_flex and $can_animate. Technically, I could already have done it long ago (and considered doing it), by just storing the list of browsers in the variables, but I didn't think it was worth cluttering the common CSS file. Since @is tests with no nested variables are executed before variables are parsed, it means Wess will only do the @is test once, instead of each time a can_flex/can_animate request was made before. This-- much better. Not much faster, but at least now I can safely use these as many times as I want. (Class-CSS.php, common.css, index.css, media.css, sections.css)

+ Also added aliases to 'true' and 'false', so that you can use them all alone in an @if/@is test, for debugging purposes (previously, you could only have them inside tests that has a variable in them, such as @if ($var && true)). Seriously, I should have done that one long ago. (Class-System.php)
Title: Re: New revs
Post by: Nao on October 27th, 2013, 01:08 AM
rev 2289 -- so, seriously, I've been the only poster today..?! :^^;:
 5 files changed, 19 insertions(+), 49 deletions(-)

+ Topic lists now show the number of unread posts per topic, just like unread posts/unread replies have been doing. (MessageIndex.php, MessageIndex.template.php)

* Added a parameter in the unread post number retrieval code, to allow passing a straight array of topic IDs to look up. I probably should set that param to true by default, but... Whatever. (Subs.php)

- Removed duplicate code. (Unread.php, UnreadReplies.php)
Title: Re: New revs
Post by: Nao on October 27th, 2013, 09:53 AM
rev 2290 -- still very quiet in here, hmm...
 5 files changed, 41 insertions(+), 22 deletions(-)

+ Restricted lists should now work. Needs testing, though. I can't believe I spent days wondering how to implement these efficiently, and it took less than 5 lines of code to actually do it. (Class-System.php)

+ Preliminary code for new ignore lists. Very very early, really. (Class-System.php)

* Renamed PRIVACY_JUSTME to PRIVACY_AUTHOR, for harmonization. (Class-System.php, Security.php)

* Moved get_privacy_type to Security; I should be using that file more, I'd say... (Security.php, Thoughts.template.php)

* More work on the topic privacy rewrite. It still won't work, mind you... (Post.php, Post.template.php)
Title: Re: New revs
Post by: Nao on October 28th, 2013, 12:11 PM
rev 2291 -- ♫ Blame Pete! ♫
 7 files changed, 53 insertions(+), 61 deletions(-)

- Removed more unused globals, and unused variables, such as $this_plugindir or $last_0. Blame Pete. (index.php, Load.php, ManagePlugins.php, QueryString.php, Security.php, SSI.php, Subs.php)

* Moved test_ip_host to Security file, as it's only used there. And still not working, BTW... Blame Pete. (Subs.php, Security.php)

! $SERVER was used instead of $_SERVER. Blame Pete. (QueryString.php)

! loadPluginLanguage didn't allow for $fatal to be set to false. Blame Pete. (Load.php)

! on_date(), which I have yet to use anywhere in Wedge, was using the wrong parameter. Blame me. (Subs.php)
Title: Re: New revs
Post by: Nao on October 28th, 2013, 11:57 PM
rev 2292
 3 files changed, 8 insertions(+), 5 deletions(-)

! Wess didn't correctly handle the webkit prefixes on flex-* properties for Safari 7. It only handled 'display: flex', which was pretty useless. (Class-CSS.php)

! While 'true' tests in Wess worked, I'm afraid 'false' didn't, at least not always. It's complicated. (Class-CSS.php)

! Fixed CSS file URLs showing an unneeded keyword. (Subs-Cache.php)

- Another unneeded global. (ssi_examples.php)
Title: Re: New revs
Post by: Nao on October 29th, 2013, 05:31 PM
rev 2293
3 files changed, 3 insertions(+), 3 deletions(-)

! The install files need a reminder that mysqli is now required. (readme_install.html, Install.language.php)
Title: Re: New revs
Post by: Nao on October 29th, 2013, 06:29 PM
rev 2294
 13 files changed, 16 insertions(+), 16 deletions(-), 1.71 KiB (yes, I missed using patch sizes... :P)

* More spacinazi. Fascinating... I'm leaving some of the libraries aside (SFTP, Exif etc), because they're not from my codebase anyway. (Load.php, ModerationCenter.php, Notifications.php, Profile-Actions.php, Profile-View.php, SearchAPI-Custom.php, Subs-BoardIndex.php, Subs-Post.php, ManageInfractions.template.php, ManageModeration.template.php, ManageSearch.template.php, profile.js, index.css)
Title: Re: New revs
Post by: Nao on October 29th, 2013, 11:22 PM
rev 2295
 6 files changed, 128 insertions(+), 111 deletions(-), 4.07 KiB (I'm assuming SVN would have given me twice that size :P)

* Several caching improvements, mostly around Memcached. I only needed to ensure that wedge.org could clean the user cache correctly for an upcoming site update, and I ended up rewriting plenty of things. Silly me... (ManageServer.php, Subs-Admin.php, Subs-Cache.php, ManageSettings.language.php)

  ! Fixed a dirty bug where Memcached just didn't work in Wedge (AFAIK it also won't work well in SMF).
  * Improved code for Memcached path (more specifically, the Memcache extension), by turning $memcached into a static.
  * Fall back to file-based cache if the Memcached server is currently down.
  * Added support for Zend shared-memory caching (zend_shm_*).
  * Calling clean_cache on the regular file cache will now attempt to clear the cache for APC, XCache, Memcached and Zend.
  * Admin page won't show the Memcached text input if it's not available in the first place.
  * Improved wording of admin page's help text. Seriously, it was messed up, especially when it came to Memcached.
  * More accurate detection of accelerators in admin page.
  * Various commenazi, and spacinazi.

@ Note: XCache documentation is non-existent, so it's possible this won't work for it. As for Zend, they don't have a (documented) way to clean their old cache system, and I don't have access to any of these cache APIs anyway (except APC which I need to test), so I don't know if it'll succeed removing Zend's key/value cache, but it's worth a try.

@ I'm too lazy to update smfinfo.php... I don't think it even has a chance of making its way into a final package, anyway. Also too lazy to look into the Memcached extension for now (right now, Wedge uses the Memcache extension, which does the same job, but is older or something.)
Title: Re: New revs
Post by: Nao on October 31st, 2013, 08:27 AM
rev 2296
 8 files changed, 78 insertions(+), 44 deletions(-), 11.20 KiB (okay, so that's totally unrelated to changes, or something...)

+ Added better membergroup support to privacy lists. Admins can use any group; members can use any groups they're in, as well as post-based groups they're in, or used to be in (i.e. less posts). Until now, they could only select from groups they were in. (Class-System.php)

+ Privacy selector is now more generic. Needs a bit more work, but I'm getting close... (script.js)

! Contact list privacy was not inclusive enough. (Class-System.php)

* Renamed some 'contacts' strings to 'list', to harmonize with 'group'. (Post.php, Security.php, index.language.php)

* More bits on the privacy system. (Thoughts.template.php, index.template.php)
Title: Re: New revs
Post by: Nao on October 31st, 2013, 03:01 PM
rev 2297
 6 files changed, 58 insertions(+), 14 deletions(-), 4.28 KiB

! Fixed another bug in the privacy/contact list system not being inclusive enough. Phew... (Class-System.php)

+ Added privacy list icons. This is a tentative version, but it's good enough for now. Adds 500+ bytes to the CSS file. Gotta live with it... (Profile.template.php, index.member.css, contacts.png * 2)

+ ...But I'm not the kind of guy who'll give up against adversity. Chrome and Safari 6+ support CSS filters (not the IE ones!), so for them, I've replaced the privacy icon sprite with a single icon which gets colorized on the fly, saving... Approximately 500 bytes. So, you get the privacy list icons for free. (index.member.css, privacy.gif)
Title: Re: New revs
Post by: Nao on November 1st, 2013, 09:52 PM
rev 2298
 6 files changed, 33 insertions(+), 37 deletions(-), 1.72KiB

- Duplicate text in profiles. (Profile.template.php)

* Tweaked debug junk to prevent styled non-links in ViewQuery, and incorrectly styled links in page bottoms. (Subs-Template.php, ViewQuery.php, index.css)

* Reverted html tag's height tweak from the 24 Oct commit, because it created other issues (as I expected), and instead modified sidebar animation to always restore overflow after animating. (script.js, index.css, sections.css)

! And another fix (hopefully the last one) for the sidebar opener code, preventing it to trigger when an HTML tag is located inside an anchor. (script.js)
Title: Re: New revs
Post by: Nao on November 2nd, 2013, 11:22 PM
rev 2299
 5 files changed, 32 insertions(+), 16 deletions(-), 1.95 KiB

+ Thought privacy now shows list type icons, instead of the generic list icon. (Security.php, script.js)

+ Ported the PrivacySelector code to PHP, so that it can also be hardcoded into the page HTML. Although I'm not sure I'll use that eventually (my plan is to go fully JS), it's still nice to have for now. (Security.php)

+ Topic privacy also gets list type icons, of course. (Post.template.php)

! Fixed thought privacy showing, in edit mode, the 'Admin' icon when selecting the 'Members' privacy type. (script.js)

! Translation error. (Login.french.php)

- Removed some unused code. (Post.php)
Title: Re: New revs
Post by: Nao on November 3rd, 2013, 05:53 PM
rev 2300
 8 files changed, 449 insertions(+), 9.08 KiB

+ Welcome to Wilde! The spiritual replacement to Wuthering (which will eventually fade away) takes everything I liked from it, restore some Weaving neutrality, and then adds a touch of silliness and an organic background. Still a work in progress, though! (skins/Wilde/*)
Title: Re: New revs
Post by: Nao on November 3rd, 2013, 11:10 PM
rev 2301
 5 files changed, 102 insertions(+), 68 deletions(-), 3.51 KiB

+ Support for >=, <= and !== in variable tests. The first two are really new, the latter is just a synonym of !=, since Wess always does loose matching anyway. (Class-System.php)

+ Finally added support for mixing variable and constant tests, e.g. you can do @if (admin || ($status == "admin")) && !ie; it is important to note this convention: if you're using a literal string that's the same as a Wedge system constant, you need to surround it in quotes (as in the example above). Otherwise, Wess will consider it to be the value of that constant, instead of the string itself. (Class-CSS.php, Class-System.php)

+ Added support for a few globals to Wess tests: $settings, $theme and $txt. I guess the latter is less useful, and I'm not going to add support for $txt like I did for JS files, but you could still want to use it for hacks (e.g. holding non-translation data in a variable). Also, $theme already has a similarly named variable, but it relies on logic: use $theme to get the theme's URL, and $theme&#91;'var'] to get a theme variable. (Subs-Cache.php)

+ Support for '@else if' in addition to @elseif in Wess. (Class-CSS.php)

! Fixed a couple of bugs with brackets use in Wess. Mostly, the line of CSS below failed, because Wess expected the first bracket to represent a surrounding bracket, rather than the first part in a long series of tests. As a result, it created an infinite loop, which I'll also be accounting for from now on (albeit in a crude way), because I don't want people to come with me with support requests because they forgot to close a bracket somewhere. (Class-CSS.php)

* Avoid redundant keywords in CSS filenames: between 'admin', 'member' and 'mUSERID', there can be only one. Thus, only the most specific of the three will remain. mID > admin > member. (Subs-Cache.php)

! Very, very bad commenazi. (index.css)

! Don't output #junk definitions if you can't see debug info in the first place. It saves about 5 lines of CSS, and it required two days of work and all the changes above. You can definitely say I'm an optimization freak. But seriously, the variable rewrite had been in my to-do list for too long. (index.css)

@ For the curious, the CSS line in question is:

$view_junk = $settings&#91;'db_show_debug_who_log']
@if $view_junk == "any" || (admin && $view_junk == "admin") || (member && ($view_junk == "regular" || $view_junk == "mod"))
...
Posted: November 3rd, 2013, 11:04 PM

And forgot to log this:

* Small color tweaks to make headers and linktree a bit brighter. (Wilde/extra.css)
Title: Re: New revs
Post by: Nao on November 4th, 2013, 06:45 PM
rev 2302
 53 files changed, 4 insertions(+), 31.98 KiB

+ Added, to the attic, my Cyna smiley set, originally designed for my Cyna and Noisen websites. Since it's a mash-up between my own roxxor skillz and other smiley sets, I won't be distributing it alongside Wedge, but still, it's nice to have a copy around. (other/images/cyna/*)
Title: Re: New revs
Post by: Nao on November 4th, 2013, 11:59 PM
rev 2303 -- this one's been in my commit list for weeks, waiting for the triple-check I mentioned below.
 10 files changed, 35 insertions(+), 25 deletions(-), 8.14 KiB

* Harmonized some board/topic permissions. (Display.php, Load.php, MessageIndex.php, Subs-MembersOnline.php, Display.template.php, MessageIndex.template.php)

  - The problem lies in how permissions are handled. 'moderate_forum' is actually a permission to manage members, while 'moderate_board' is set if the user can moderate the current board (depending on their permission profile).
   - I added a failsafe for board owners, they should now have moderate_board permissions on their boards, even if not allowed (but not if explicitly denied). While it's a feature that's not yet fully implemented, I have a weird belief that if you create a board, you should have complete power over it, its posts, comments, and whatever, regardless of your current group.
   - Board moderators can also now view hidden members reading their boards, and they can see IPs associated to posts in them. Previously, these two features were only for member managers.
   - Board owners can now modify their board settings directly from the topic list. Well, I need to actually allow for that in the admin area, but... Bear with me.

* Moved media permissions to the left of the permission manager page. It's not a great place thematically, but at this point, I care more about visual harmony. (ManagePermissions.php)

- Removed some unused code, some dating back to the oldSMF era. (Groups.php, Memberlist.php)

* Spacinazi. (ManagePermissions.template.php)

@ Note: if you're unhappy with my decisions regarding board permissions, please feel free to discuss it on the forum.
@ Also, this is totally untested, especially since I'm an admin on my test board. Go figure. But I've triple-checked the code, should be fine.
Title: Re: New revs
Post by: Nao on November 6th, 2013, 05:11 PM
rev 2304
 4 files changed, 32 insertions(+), 30 deletions(-), 1.73 KiB

+ Post date and post modified date are now both correctly machine-readable. I spent weeks pondering over the fact that it added many bytes to topic pages, but I've saved tons of HTML bytes overall, and it never increases the gzipped size by more than a hundred bytes or so anyway. Note: the readable date format can be shortened by using a string instead of a constant, if necessary. (JSModify.php, Msg.template.php, sections.css)

* I'm quite amused by my use of the 'ins' tag (inserted data, as opposed to deleted data) for the last modified date. Well, there's nowhere else I could have used that anyway, ah ah... (Msg.template.php, sections.css)

! Fixed some issues with the way Wedge was showing the last modified date, especially on quick edit. (JSModify.php)

- Another useless line. (Profile-Modify.php)
Title: Re: New revs
Post by: Nao on November 6th, 2013, 11:58 PM
rev 2305 -- part one of my CSS fixes and updates. Including the header font size fix, ah ah!
 10 files changed, 81 insertions(+), 65 deletions(-), 3.64 KiB

* Many changes to the color converter in Wess, to make it more predictable. (Class-CSS.php)

  - Renamed 'stronger' to 'strength', 'darker' and 'lighter' to just 'luma', and '(de)saturated' to just 'saturation'.
  - Added an alias to 'luma', i.e. 'brightness', if you find it easier to grasp.
  - Regarding the above (and 'channels'), you may now 'force' a destination value by not using a sign.
  - If you still want to apply a value relative to the existing one, add a + or - sign before the number.
  - So, basically, darker($color, 10%) is now luma($color, -10%), and saturated($color, 10%) is now saturation($color, +10%)
  - As always, luma($color, -.1) applied to a color with a luma of 50% (.5) results in .4; luma($color, -10%) gets you .45, of course.

* These changes were applied to... (common.css, index.css, index.member.css, sections.css, Wilde/extra.css, Warm/extra.css, Wuthering/extra.css, Wine/common.css, Wine/extra.css)

! Fixed header border radius. (Wilde/extra.css)

! Fixed header font size. A long requested one... (Wine/extra.css, Warm/extra.css, Wuthering/extra.css)

* Better header font. My goal was mainly to remove Georgia from the list, because the latest Chrome Mobile will now substitute a serif font for it, instead of falling back to sans-serif as requested. (Wilde/extra.css)
Title: Re: New revs
Post by: Nao on November 7th, 2013, 01:49 PM
rev 2306
 3 files changed, 3 insertions(+), 3 deletions(-), 1006 bytes

+ Wess can now also handle $context variables. Dunno why I forgot about this one, but... (Subs-Cache.php)

! Fixed a minor bug in quick edit causing an XML error popup to show up. (JSModify.php)

! Last nail in the header font size bug's coffin. Pretty much. It's not really a bug, you see, it's just a series of commits I'm always postponing, and the codebase ends up being desynchronized. (index.css)
Title: Re: New revs
Post by: Nao on November 8th, 2013, 03:37 PM
rev 2307
 2 files changed, 9 insertions(+), 10 deletions(-), , 1.05 KiB

* ! $context tests in Wess weren't ready yet. Well, now they are. (Subs-Cache.php)

! Variable tests in Wess would be added to a variable stored in the database settings. No need to pollute it with these, as well as the 'true' keyword, so I made sure to strip them off. Or out? What's the correct English word for that? Anyway, it also saves a couple of extra mandatory we::is tests per page load, even when everything is cached. (Subs-Cache.php)

! Tested Wedge in the latest Maxthon, using Chrome 26, and it still doesn't accept unprefixed CSS like gradients etc, so I thought a bit about it, and decided to simply up the minimum version for unprefixing to 27, to give forks some time to sort out their stuff. Or off. Nah, must be out. Not a big deal, since v26 is long past for mainline Chrome users anyway. The only thing that bothers me is that the comments are now incorrect, but whatever, I'm sure I'm the only one who checks out prefix usage at caniuse.com anyway. (Class-CSS.php)
Title: Re: New revs
Post by: Nao on November 8th, 2013, 04:05 PM
rev 2308
 1 file changed, 58 insertions(+), 40 deletions(-), 1.37 KiB

* Rewrote the we::is parser for sanity. (Class-System.php)

  + Adds support for operator-less variable testing (i.e. != "").
  * Deals with bracket grouping in a better and more readable way. Finally, I get to remove a dirty hack!
  ! Fixes problems with variable testing, notably with loose checks, and variables like 'admin' being parsed as the admin constant.
  ! Also fixes negative tests. Up until now, "!$var == true" was seen as "!($var == true)", now it's "(!$var) == true", which is 95% the same, but at least it's more logical.
Title: Re: New revs
Post by: Nao on November 8th, 2013, 04:12 PM
rev 2309
 3 files changed, 23 insertions(+), 14 deletions(-), 1.34 KiB (same size for much less code? Doesn't seem too trustworthy to me, then...)

+ News feature (Random news and newsfader) will now only output and cache their CSS if they're enabled in the first place, and yes, it's a nice thing to have, and even if it serves as an example of what plugins should be able to do in the future, I'm glad I can save these bytes, eh. (ManageNews.php, index.css, sections.css)

! The $view_junk variable definition needed double double quotes (not a typo!), in order for the test to understand its values as strings, not constants. Silly me. (index.css)
Title: Re: New revs
Post by: Nao on November 8th, 2013, 04:31 PM
rev 2310
 5 files changed, 30 insertions(+), 25 deletions(-), 1.66 KiB

! Page header was incorrectly sized in responsive mode (with 1.5 pixel density or higher, which I rarely test on desktop.) (sections.css)

! Post avatars were incorrectly aligned in responsive mode. (sections.css)

! ins tag styling fixes. (extra.rtl.css, sections.css)

* Pixel-perfect news in the admin sidebar. The jury's still out on whether I'll use that area at all, though... (mana.css)

* Intermediate work on font types. Seriously, more to come. I just need to see it in action on a live site. (common.css, index.css, sections.css)

:edit: Forgot to document (why is TortoiseGit missing the ability to edit the latest changelog, when even TortoiseSVN allows it..?!): disabled flexbox on iOS 6, because it's obviously not working between us.
Title: Re: New revs
Post by: Nao on November 8th, 2013, 10:10 PM
rev 2311
 7 files changed, 49 insertions(+), 40 deletions(-), 2.24 KiB

* As Wess doesn't do anything interesting with array variables, let's at least return the size of them, allowing you to test for empty (or non-existent) arrays. Should account for 90% of all use cases. Using that for language flags. (Subs-Cache.php, index.css)

* Like buttons in posts should have the same opacity effect as other action elements. (sections.css)

! Wrong font variable name. (index.css, sections.css, Wireless/extra.css)

! Overflow problem. Again. (Wireless/extra.css)

! Was this an unfinished language string? It certainly didn't mean anyth (Admin.language.php)

! When a post had an attachment, clicking its icon would result in a broken icon list. (topic.js)

! Hadn't committed my local changes to quick edit, regarding the new tags for last modified date. (topic.js)

! follow_me() fixes. (topic.js)

* Very minor rewrites. (topic.js)
Title: Re: New revs
Post by: Nao on November 9th, 2013, 12:47 AM
rev 2312
 2 files changed, 2 insertions(+), 2 deletions(-), 903 bytes

! Spoiler tags didn't accept spaces in their descriptions, and as an indirect cause, made quick edit fail through some complicated crap in strip_tags(). Definitely NOT a fun thing to debug, really. (install.sql)

! JavaScript doesn't like receiving malformed XML CDATA strings. In some rare situations (pasting some code, maybe?), it would simply freeze at parse time. (Subs.php)

@ Note for those who already have Wedge installed somewhere: either repopulate your bbcode table with the updated version, or ignore the fix, or edit it. You just need to add two double quotes, no biggie.
Title: Re: New revs
Post by: Nao on November 10th, 2013, 07:30 PM
rev 2313
 2 files changed, 6 insertions(+), 3 deletions(-), 762 bytes

! Fixed runtime CSS errors related to bad clean-ups after an unextends keyword. (Subs-Cache.php)

! Fixed an innocent bug that turned into a nasty JavaScript-show-stopper for guests on mobile devices. (Display.template.php)
Title: Re: New revs
Post by: Nao on November 10th, 2013, 08:50 PM
rev 2314
 8 files changed, 7 insertions(+), 39 deletions(-), 1.80 KiB

* Admin area is now much more mobile-friendly. Can you believe it..? Oh, and yes, I try to avoid using the !important keyword whenever possible, but sometimes, it's just not worth the hassle. (ManageBoards.template.php, sections.css)

- Wuthering (and thus, Wilde) still had leftovers from the pre-mobile sidebar system, and it conflicted with the sidebar toggle button, making it impossible to change the theme if you'd chosen any of these by default on a mobile device. Ouch! (Wilde/skin.xml, Wuthering/skin.xml)

- Removing oldIE leftover CSS. (extra.ie6.css, extra.ie7.css, extra.ie8.css, extra.rtl.css)

- Removing a topic list hack for mobile, which doesn't seem to be very efficient to me. Hopefully, the original bug fixed itself by magic. Needs more testing. (sections.css)

! Attachments and custom fields shouldn't be removable by soft-merging. (skeleton.xml)

(And that commit deserves a few Likes, I say :niark:)
Title: Re: New revs
Post by: Nao on November 11th, 2013, 04:29 PM
rev 2315
 4 files changed, 45 insertions(+), 5 deletions(-), 2.04 KiB

! Fixed a bug with no consequences, but nasty to figure out, because it implied the homepage was loaded on mobile in Ajax mode, which wasn't supposed to happen. (Yeah, whatever.) As a rule of thumb, really, please developers, avoid using redirectexit() in an Ajax page! It didn't strike me as 'obvious' that the page would be loaded this way, which is why it took me days to figure it out. It's tempting to add a failsafe in that function itself, but I don't think it's likely to happen often, and I'll probably remember it next time, eheh. (Notifications.php)

! Forgot to add the skeleton.xml file in the last commit. (skeleton.xml)

+ A tentative DCO file, for contributors to agree to when they sign-off their code. (DCO.txt)

- Unused class. (PersonalMessage.template.php)
Title: Re: New revs
Post by: Nao on November 11th, 2013, 08:36 PM
rev 2316
 4 files changed, 61 insertions(+), 55 deletions(-), 2.31 KiB

* Tweaked Wilde -- headers, and added flexboxing on the linktree, for mobile use mostly. (Wilde/extra.css)

* Updated Home template to be more... generic, really. It was tailored for wedge.org, and didn't have a reason to be that way in the repo. While the 'default' is still Welcome, I'd appreciate to get feedback from users -- which one should be the default? (If Home is, then Welcome will be completely removed.) (Home.template.php, Home.language.php)
Title: Re: New revs
Post by: Nao on November 12th, 2013, 01:35 AM
rev 2317 -- yeah, ultra-short one, but I couldn't stand having it unpushed.
 1 file changed, 1 insertions(+), 1 deletions(-), 503 bytes

! Repeat a 1000 times: do not commit any last-minute optimizations without testing them... This one made we::is('mobile') return true on desktop browsers, which was... Not so good. (Class-System.php)
Title: Re: New revs
Post by: Nao on November 12th, 2013, 01:08 PM
rev 2318
 6 files changed, 103 insertions(+), 36 deletions(-), 2.97 KiB

+ Added support for relative dates in topic pages. (topic.js, index.language.php)

@ Need to know: this isn't going to stay 'as is'. I'm only trying to clean up my uncommitted stuff, and this is an important part of it. Also, an issue: done always at runtime, so you might see the absolute date at load time, a second before it becomes relative. As I said-- won't stay like this.

* Forcing relative dates to be absolute after 2 years. (Msg.template.php)

+ Added a helper function, time_tag(), which will be helpful to add these tags outside of topic pages later. Also removed a couple of lines that didn't make sense in forum_time(). (Subs.php, Msg.template.php)

* Moved runtime code like code+flexbox fixing, follow_me() adjuster and relative dates, to a new function that will get re-called whenever necessary. (topic.js)
Title: Re: New revs
Post by: Nao on November 14th, 2013, 12:42 PM
rev 2319
 5 files changed, 10 insertions(+), 11 deletions(-), 1.37 KiB

! Fixed username positioning in topic pages on iOS browsers. Please -- don't ask. If you really must know, it was an old hack for iOS 4 (from rev 1584), that was fixed by Apple in iOS 5, without my knowledge. To hell with iOS 4, I'm removing the hack entirely. (extra.ios.css)

* Tweaked layout in userbox for mobile; should be properly aligned, now. (Wireless/extra.css)

- Duplicate code. (Wine/extra.css)

! Forgot some <ins> styling. (extra.rtl.css)

+ Some line needed clearing up. (contributors.txt)
Title: Re: New revs
Post by: Nao on November 14th, 2013, 01:09 PM
rev 2320 -- hopefully, my last commit before I start pushing theme changes.
 3 files changed, 6 insertions(+), 7 deletions(-), 1002 bytes

* Minor fixes on quote/code headers. Most notably, style was broken on quoted spoiler tags. (index.css)

- Don't remove overflow on an open sidebar. I know it will slightly break the skin selector or board selector on short pages, but it's better than mobile complications. (script.js)

* Trying an !important-free responsive admin area. Don't laugh, it's hard to get right. (sections.css)
Title: Re: New revs
Post by: Nao on November 14th, 2013, 02:30 PM
rev 2321 -- changed my mind. I'll get rid of as much as possible, before I start moving folders around.
 11 files changed, 13 insertions(+), 49 deletions(-), 4.32 KiB

* Moved Forum Width setting from themes to general settings. (ManageSettings.php, Settings.template.php, index.template.php, ManageSettings.language.php, Themes.language.php)

* Moved Random News setting from themes to News Settings. Renamed language string to 'enable_news'. (ManageNews.php, Settings.template.php, ManageSettings.language.php, Themes.language.php, install.sql)

- Removed Show Profile Buttons theme option. Seriously, I could understand that one wouldn't want to know their friends' online status, but... Nope, couldn't understand. (Msg.template.php, Settings.template.php, Themes.language.php, upgrade.php, install.sql)

- Removed Last Modification theme toggle. Again: no crazy reason for disabling that will work on me. If you really want to hide them, set 'ins' styling to display: none. (Msg.template.php, Settings.template.php, Themes.language.php, upgrade.php, install.sql)

- Removed deprecated language strings: enable_single_post, enable_multiple_posts (I have no idea what these are, but they're not used anywhere), inline_desc (this one was probably outdated 8 years ago) and member_list_bar. (Themes.language.php)

@ Yes, I know, I have no reason to keep updating upgrade.php. Don't mind me.
Title: Re: New revs
Post by: Nao on November 16th, 2013, 11:37 AM
rev 2322 -- first batch of small fixes to Wedge. Attention SMF developers: some minor bugs are mentioned in there that are also in SMF 2.1 as far as I could see. If you can't find the bugs I'm referring to, please open a topic somewhere in the SMF board here, and I'll try to help. At worst, I'll do a pull request, but right now I'm focusing on Wedge issues, so it'll have to wait until I have more time.
 24 files changed, 74 insertions(+), 91 deletions(-), 4.72 KiB

! weSkeleton->remove() was expected to return a success value. (Class-Skeleton.php)

! The new ban management code returned $row at one point, instead of $rowData. Blame Pete. (ManageBans.php)

! The 'do_empty_field' feature could never be disabled, due to a typo in the disabler code. Blame Pete. Still, nice feature, not sure why anyone would want to disable it. (Subs-Editor.php)

- pretty_synchronize_topic_urls doesn't provide a return value, no need to output it then... (ManageSettings.php)

! SMF 'bug': While session-related functions are not expected to return a value (it's undocumented, but the official examples provide values), I realized that the SMF implementation was flawed, such as providing a return value from an insert query, which is also undefined. Ahum. Cleaned it all up. (Load.php)

! SMF bug: $_COOKIE&#91;'guest_poll_vote'] has three bugs in one line: a 'count' ternary test that can perfectly be eliminated; an explode() used instead of implode() (!!), and the explode itself only has one parameter, since the comma was replaced with a period. (!!!) (Poll.php)

- SMF bug? Error lists in saveProfileFields and groupMembership2 parameters are never used. Also a typo in the documentation for these, hmm. (Profile.php, Profile-Modify.php)

- SMF bug: a beautiful unneeded line indeed... validateSession() never returns any value, and what do you think that test does anyway? (we::$is_member || validateSession()) -- if it's a member, it's true. If it's a guest, it calls the function, which then calls is_not_guest(), which generates an error. Thus skipping the line executed by that test, which... Generated an error. Well, yeah, sure, man, whatever you want. (Profile.php)

- SMF 'bug'? The first parameter in mergePosts() was optional, while the others weren't. (RemoveTopic.php)

! SMF bug: $entryname is used before it's declared. Wrong copy & paste, I guess. (Subs-Package.php)

! ...Which Pete then proceeded to reproduce in his plugin system. Along with an undeclared $path variable, a $dir variable missing its dollar sign (and thus considered as a constant), a $pluginsdir global renamed to '$plugins_dir', and another variable used before it's declared, $full_path, although in this case I think he meant to say $dir. Yeah, that one again... (Subs-Plugins.php)

! Nice one... A file_get_contents call using FILE_BINARY as a flag. Not only is it not necessary (file is considered binary by default), but it's a PHP 6-only flag. In code written at least 4 years ago. Real fun. (Class-Media.php)

* media_handler->resizeJpgImage() returned nothing, and that null return value was used and inverted to turn it into a true value. That's oh-so-badass. But it's also confusing, and fixed by simply forcibly return true. (Class-Media.php)

! show_prevnext() should have returned its output, rather than echoed it. Same for aeva_listFiles(), but as this one's more complicated, I'll just settle on echoing stuff, and then doing an explicit return ''. (Media.template.php)

- Unused function, getZippedfile(). Was buggy anyway. Debug code I'm sure. (Class-Zip.php)

! Undeclared global in aeva_moveAlbum(). It was only used if an error occurred, which I guess, never did happen. (Aeva-Gallery2.php)

- Unused globals. (install.php, Profile-Modify.php, Reports.php, Subs-Members.php)

- Duplicate globals. (ManageBoards.php, MoveTopic.php, Profile-Modify.php, Subs-Menu.php, Media.template.php)

! Missing global. Technically, it's a non-existing global, but it's also for a non-existing function, so who cares. (ManageMaintenance.php)

- Spacinazi, commenazi, etc. (PrettyUrls-Filters.php, Security.php)
Title: Re: New revs
Post by: Nao on November 16th, 2013, 12:12 PM
rev 2323 -- what's with the number 23 again?! I love this commit. It has so many fixes for details *important* to me.
 8 files changed, 44 insertions(+), 46 deletions(-), 3.12 KiB

! This is my tentative fix for the infamous "quick edit just marked my post as unread, you silly!" bug... I'm pretty sure it's due to a settings caching problem (as I believe it only happens when the post you're editing is the latest in the forum *and* you've finished editing it within a minute of posting it in the first place), but I tried to follow the 'workflow' and it seemed flawless to me, so I'll instead use the message ID as the log date if the maxMsgID value is outdated at that point. (Subs-Post.php)

+ Added support for outputting Secure HTTP links in Aeva embedding. Rendered videos will still be unsecure, but the point is only to prevent https protocols from breaking the whole process. (ManageMedia3.php)

! Select boxes will now take the page height into account if it's shorter than the window height. Meaning, they'll try to avoid showing their dropdowns below them if there's more room above them, than between their bottom and the actual bottom of the body tag (not the window height). I know, it's complicated, but it magically fixes the skin selector in short pages with a responsive sidebar. That one ate at me over a long time, you can't imagine. Uh, no, actually not that much. (sbox.js)

* Instead of having stat bars span from 4px to 104px in size, I'll have them span from 5px to 100px, that's more than enough thank you. (Stats.php, Stats.template.php)

! Macros weren't being parsed if the skin.xml file was missing, even though they're located in the macros.xml file. (Subs-Cache.php)

* Removed flexbox and display: table code paths for Wilde linktrees. Seriously, it was too complicated for its own good. It works better as an inline-block, especially in iPhones. As a fix for broken gradients on multi-line linktrees, I've simply decided to drop all linktree gradients in responsive mode. Looks 80% as good, and doesn't 'break' when over 2 lines or more. (Wilde/extra.css)

* Improved translation. (PersonalMessage.french.php)

@ Re: quick edit bug. Considering that Wedge is using pretty much the same workflow as SMF here, I'd like to invite SMF developers to look into doing the same. Same comment as before: if you're unsure, ask me to do a pull request. I'll wait until I can confirm this is definitely fixed, though.
Title: Re: New revs
Post by: Nao on November 16th, 2013, 10:51 PM
rev 2324 -- more quick edit bug squashing! Hopefully all working now, eh.
 3 files changed, 8 insertions(+), 17 deletions(-), 1.04 KiB

! Quick edit save was somehow broken by an earlier commit of Pete's, due to a wrongly placed parenthesis. I don't know if it had any influence over the contents of posts. Sorry if it did. (JSModify.php)

! And, Quick edit retrieval was also broken, this time by a recent commit of mine, where some [ signs were turned into their entity equivalent. I was under the impression that un_htmlspecialchars was enough, when I should have gone all the way through westr::entity_to_utf8. Let's not talk about that anymore. (QuoteFast.php)

@ Well, at least the Quick edit 'last post' bug fix from the last commit was proven to work. Yay. How strange that quick edit had so many bugs, and I didn't realize it until recently.

- Removed some remaining unused index params from wesql::insert calls. (ManageSmileys.php)
Title: Re: New revs
Post by: Nao on November 17th, 2013, 11:53 AM
rev 2325
 10 files changed, 36 insertions(+), 50 deletions(-), 2.16 KiB

! Unneeded or malformed params. (Aeva-Embed.php, Aeva-Foxy.php, ManageMedia2.php, Thoughts.php)

! Nao bug: AeMe didn't correctly get the inserted ID on playlists. (Aeva-Foxy.php)

! SMF bug: non-existent variable $type. Note: fixed in Elk, but not SMF 2.1. Also some bracketnazi. (Reports.php)

! Pete bug: search settings were broken by a hasty rewrite. (ManageSearch.php)

! Pete bug: yet another parenthesis problem, this one was in his very first commit for draft saving. Interesting. Just hoping this fix doesn't actually break the feature; in which case, at least I'll know what I need to remove. Also saving a few function calls if the draft is going to fail. (Subs-Post.php)

! Pete bug: $row['issued_by'], not $issued_by. (And yes, if you want to take your infraction code elsewhere, of course you don't have to bother about this bug fix.) (ModerationCenter.php)

! Pete bug: a single use of $db_connection instead of self::$_db_con since his very first commit of that class. I think the most amusing here is the irony of that bug being inside the function called serious_error. (Class-DB.php)

@ As in a few of the last commits, this changeset is mostly sponsored by hhvm-wrapper. A real life-saver, even if it took hours to get it to work...
Title: Re: New revs
Post by: Nao on November 19th, 2013, 12:20 PM
rev 2326 -- note: I had to do a push --force to prevent a dirty repo. This is because I made an --amend on the latest pull request merge, and forgot to immediately push force it, so... Apologies if you end up with a broken repo when you pull.
 11 files changed, 46 insertions(+), 213 deletions(-), 3.33 KiB

* Previous/next topic links will now jump to the latest post, rather than the latest post in their first page (what the..?!) (Display.php)

* Simplified or improved some Unread code. If topic has no replies, don't bother with the #new anchor or a msg variable. Got rid of msg anchors as much as possible. Removed href and link variables, as they're unused duplicates. (Unread.php, UnreadReplies.php)

* Merged Unread/UnreadReplies templates back together, with a template param to differentiate them. This also gives me an opportunity to show that it's easy to set a template param through wetem::load(). Note, though, that specifying 'unread:false' wouldn't work, as 'false' is a non-false string value. I know, it's kind of counter-productive, but you can still use 'unread:true' for readability, and fall back to 'unread' (if the param has a false default) or 'unread:0' to specify false. (Recent.template.php)

* Again, don't link to a #new anchor if topic has no replies. (MessageIndex.php)

- Unneeded globals. (Boards.php, Home.php, Welcome.php, Subs-Media.php)

- Unneeded $custom_table parameters in addData() and addSeparator(). They were never used, and I have no plans to extend reports any further. (Reports.php)

- Unneeded $context['topics'][$id]['newtime']. (MessageIndex.php)

- $theme['show_member_bar'] was never used. (Boards.php, Home.php, Welcome.php)

* Micro-optimizations. Don't bother. (Errors.php)
Title: Re: New revs
Post by: Nao on November 19th, 2013, 08:03 PM
rev 2327
 21 files changed, 50 insertions(+), 62 deletions(-), 2.47 KiB

- More unused globals. Since I just spent an hour manually checking these and fixing them (about 70 entries), and had no false positives at all, it's awfully tempting to write some code to remove these automatically before a manual check at commit time... (SOURCES: Like, ManageSmileys, Merge, Modlog, MoveTopic, PersonalMessage, Poll, Post, Post2, PrettyUrls-Filters, PrintPage, Profile-Actions, Profile-View, Profile, Subs, Suggest, ViewQuery, ViewRemote, Welcome, Aeva-Embed, Aeva-Foxy)
Title: Re: New revs
Post by: Nao on November 19th, 2013, 08:04 PM
rev 2328
 7 files changed, 48 insertions(+), 70 deletions(-), 10.47 KiB (definitely doesn't represent the real patch size; it's not that big.)

* Harmonized template_button_strip calls to always use the return value. (index.template.php, Media.template.php, Recent.template.php, Reports.template.php)

* Turns out that wesql::insert CAN return a success value, it was just a matter of checking out the PHP documentation, not MySQL's. (Class-DB.php, Load.php)

* Cleaned up installer code: removed unused globals, harmonized all required-version variables into constants, and all constants are defined at startup. (install.php)
Title: Re: New revs
Post by: Nao on November 20th, 2013, 01:23 PM
rev 2329 -- I would like to thank my humble unused-globals.php, and its newest feature, 'fix all files for me, duh.' Didn't save me the hassle of a manual check (in order to remove the couple of false positives I *did* find), but I still saved several hours overall.
 62 files changed, 162 insertions(+), 197 deletions(-), 12.90 KiB

- Last, and biggest, batch of unneeded globals. There are some that are going to stay in for now, because they're in files I'm not ready to commit yet. (62 files, not listing them all!)
Title: Re: New revs
Post by: Nao on November 23rd, 2013, 08:40 PM
rev 2330
 6 files changed, 77 insertions(+), 71 deletions(-), 2.53 KiB

* Rewrote math() module in Wess, which was solid for 'easy' operations, but didn't work when, for instance, global variables ($settings, $context...) were used in the lot. (Class-CSS.php)

  + This adds support for intval(), floatval() and boolval() functions. Apply to all global variables, or variable numbers that end with a unit.
  ! Parentheses were not handling multiple nesting levels very well. I've rewritten the regex to use proper recursivity, I think it's the first time I ever use sub-pattern recursivity, which is nice.

! Fixed Zoomedia close button on Wilde. (zoom.css)

! Help popups were broken in the last commit. (Subs-Template.php)

* Local variables shouldn't share their name with a global variable. (ManageMedia.php, ManageMedia3.php)

* Language tweak. (ManagePermissions.french.php)
Title: Re: New revs
Post by: Nao on November 23rd, 2013, 08:41 PM
rev 2331 -- first batch of admin rewrites. That is, by far, the easiest and shortest batch. You can imagine the rest, I guess...
 7 files changed, 193 insertions(+), 87 deletions(-), 2.78 KiB

* Renamed package_servers table to plugin_servers. Not that it can be used for now -- there's no server for these, really. (install.sql, ManageMaintenance.php, ManagePlugins.php)

* Moved Add Plugin to its own top menu item. (Admin.php, ManagePlugins.php, ManagePlugins.template.php, packages_add.gif)

! Potential security issue with plugin server credentials. (ManagePlugins.php, ManagePlugins.template.php)

- Disabled plugin server stuff for now anyway. I mean, Wedge.org has no facility for plugins, and I don't even know where to start... (ManagePlugins.php)

! 29 tables (!) were unprotected from removal. (Class-DBPackages.php)

@ Phew... Right in time before the Doctor Who 50th anniversary episode.
Title: Re: New revs
Post by: Nao on November 24th, 2013, 12:59 AM
rev 2332 -- phew -- here it is, the bigger part of the admin rewrite. There are still many things to commit, but the bulk is in here.
 27 files changed, 509 insertions(+), 687 deletions(-), 9.09 KiB[1]

* Admin overhaul. It's all in a day's job for... (Admin.php, ManageAttachments.php, ManageMail.php, ManageMemberOptions.php, ManagePlugins.php, ManageServer.php, ManageSettings.php, Admin.template.php, index.template.php, ManageMembers.template.php, Admin.language.php, ManageSettings.language.php, Profile.language.php, likes.png, contributors.txt)

  * Got rid of prepareServerSettingsContext, everything in the admin panel now uses the prepareDBSettingContext format.
  * Updated comment that serves as documentation for the DB setting format in ManageServer.
  * Moved Likes settings and generic Member settings to General Settings. Moved PM and Paid Subscriptions to the first menu. Moved Embeds back to Media (nostalgia!). Moved Search Engine options to Maintenance.
  * Various fixes/simplifications to internal search.
  - More unneeded globals.
  - Removed forum_width setting; it's easy enough to do in skins: create a custom.css anywhere, add a '#wedge' line, hit Return, Tab, then type 'max-width: 80%' for instance. Save. Upload via FTP. Done, and it doesn't add clutter to your HTML.
  + Added support for big icons in setting titles. Added icons for Member settings and Likes settings; replaced ugly Likes logo with a new one.
  * Member defaults page now develops all items from the start. I don't like the hover/click process, it's just too slow. Also emphasized Yes/No settings with color codes. Renamed that page from 'Member preferences' to 'Member options', although I'm also trying to stick the word 'defaults' into it, but, hmm...

* Simplified $db_show_debug handling. (Class-DB.php, Errors.php, Subs-Cache.php, Subs-Template.php, Subs.php, ViewQuery.php)

@ Note: have yet to commit files like Load.php, meaning that this commit will definitely break your Wedge. Just wait until I'm done!
 1. I need to stop posting patch sizes. They have obviously nothing to do with actual patch sizes. This one is over 10x bigger than rev 2328 which has a bigger file size.
Title: Re: New revs
Post by: Nao on November 24th, 2013, 06:35 PM
rev 2333
 15 files changed, 76 insertions(+), 64 deletions(-), 11.41 KiB

+ A nice little rewrite of the language flags system. Mostly, they're now shown in a select box, so that you can add support for as many languages as you want, without disrupting the layout. Also, I've tweaked the sidebar to allow moving the language selector over there in case you're using a mobile skin. (Subs-Cache.php, Profile-Modify.php, Admin.template.php, index.template.php, skeleton.xml)

* A tweak to the .inline-block mixin allows you to directly remove vertical-align (or change its value from the default "middle") by specifying an empty parameter (mixes .inline-block(""), basically.) (Subs-Cache.php, common.css)

* Added a few separators in the admin menu. (Admin.php)

* Minor tweaks, spacinazi, globalnazi, thoughtihadcommittedthatnazi. (JSOption.php, Load.php, ManageLanguages.php, ManageModeration.php, Profile-Modify.php, Subs-Members.php, MessageIndex.template.php, detailed-version.php)

! Fixed another quick edit bug. (This was fixed on wedge.org some time ago, just forgot to commit it.) (QuoteFast.php)
Title: Re: New revs
Post by: Nao on November 24th, 2013, 06:37 PM
rev 2334
 8 files changed, 5 insertions(+), 20 deletions(-), 1.33 KiB

* Trying a universal border-box. We'll see how it fares. I'm a bit pessimistic, but I'd be glad if it works. (editor.css, index.css, index.member.css, mana.css, media.css, sections.css, zoom.css, Wireless/extra.css)

* A couple of other, minor fixes. Hmm, what's the point in committing border-box separately if I can't just mindlessly revert it because of that? Well? Well, I'm sure there's a point. (sections.css)
Title: Re: New revs
Post by: Nao on November 25th, 2013, 12:04 AM
rev 2335 -- sorry for this boring 'maintenance' commit, I'm trying to reduce my number of uncommitted files.
 15 files changed, 22 insertions(+), 58 deletions(-), 2.33 KiB

* message_index_preview is a 'custom' setting set by themes, and as such, I think it should be in $context rather than $theme, which is 'automatically' built from the database. I also commented out that famous 'example' in the index template, because there's no need to grow internal arrays for nothing. (MessageIndex.php, Unread.php, UnreadReplies.php, index.template.php)

- Removed ability for 'themes' to set a default smiley set. Maybe I'll restore it later, but done differently. (JSOption.php, Load.php, Subs-Members.php, Themes.php, Profile.template.php, Admin.language.php)

- Some of the latest SQL changes were a bit too early in my workflow. I should probably postpone that until the code is actually ready... (install.sql)
Title: Re: New revs
Post by: Nao on November 27th, 2013, 05:18 PM
rev 2336
 7 files changed, 55 insertions(+), 88 deletions(-), 2.08 KiB

- Removing markAsRead for PM previews. I believe most PMs are made to be answered, and if a PM is marked read and you forget about it, well... Wedge needs to bother you about it; you can preview it to read it, but you'll still need to visit the page if you want it marked as read. (PersonalMessage.php, script.js)

! Firefox needed even stronger protection against flexbox+code bugs. Sigh. (topic.js)

! Draft permission entries weren't translated in reports. Also useless colons. (Reports.php, Reports.template.php)

! Fixed a couple of minor issues in JS strict mode. (script.js)

* Looks like jQuery switched their CDN provider, and they now support HTTPS, allowing me to remove some of my fallback code for them. (Load.php, Subs-Cache.php)

* Now allowing JS file links without a protocol, but with the protocol header hack (//), to be seen as direct links. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on November 29th, 2013, 11:00 PM
rev 2337 -- 1337, v2.0
 17 files changed, 45 insertions(+), 42 deletions(-), 2.84 KiB

* If the Wess analyzer finds an entry like '20px' without surrounding quotes, it will parse it as a number, as long as it starts with digits. (Class-System.php)

! This bit may be confusing (and/or controversial, feedback is welcome), but other variables will need to be surrounded with quotes, like the $vertical_align test in the inline-block mixin. I *could* force the addition of quotes at parse time, but I'm not sure it's worth the hassle. (common.css, index.css)

! Fixed select box height at selection time. (index.css)

* Renamed a confusing variable. (Class-CSS.php)

- Extra unneeded param. (repair_settings.php, not used anyway.)

* Spacinazi. (Class-System.php, Like.php, Load.php, ManageInfractions.php, ManageLanguages.php, ManageMail.php, ManagePlugins.php, ManageSearch.php, Pin.php, Profile-Actions.php, Reports.php, Subs-Plugins.php, Subs-Post.php)
Title: Re: New revs
Post by: Nao on December 1st, 2013, 02:02 PM
rev 2338 -- very minor. Just cleaning up my commit log.
 8 files changed, 16 insertions(+), 9 deletions(-), 5.47 KiB

+ Added support for $txt language arrays in JS caching (as opposed to just regular strings.) (Subs-Cache.php)

* Language flag positioning tweaks. (ManageInfractions.template.php, ManageMail.template.php, ManageModeration.template.php, Register.template.php)

* Minor tweaks. (GenericList.template.php, mana.css)

* Commenazi. (Class-Editor.php)
Title: Re: New revs
Post by: Nao on December 3rd, 2013, 08:57 PM
rev 2339 -- mostly CSS stuff. Next commit will be much, much cooler.
 5 files changed, 34 insertions(+), 54 deletions(-) 5 files changed, 34 insertions(+), 54 deletions(-)

- The install file still inserted some permissions that were deleted long ago. That's a Pete bug, I'm afraid... (install.sql)

! Also fixed a width bug in sidebar button, due to the border-box hack. Was visible in Firefox and mobile browsers, mostly. (index.css)

! Fixed select box internal heights, same reason. Boo, !important hack in reply to that? Not cool. But it works, so shut up and let me do the dirty work. (index.css)

! Firefox actionbar alignment issue, due to the (redacted) hack. Am I gonna fix related bugs forever? Nah.. Don't think so. Also removing some stats code, in preparation for the next commit, hopefully. (sections.css)

* Minor tweaks. (Wine/extra.css, Wilde/extra.css)
Title: Re: New revs
Post by: Nao on December 3rd, 2013, 10:18 PM
rev 2340 -- okay, next one then.
 3 files changed, 11 insertions(+), 7 deletions(-), 1.35 KiB

! Fixed HTML tags being shown in relative date titles. (topic.js)

! Fixed ajax loader height. Okay, this is getting annoying... (index.css)

! When re-opening a select box with the Space key, the current selection was not always in view. (sbox.js)

! Using arrow keys/home/end on a closed but focused select box used to re-open it. While it was a conscious decision of mine long ago, contradicting the established UI standards for select box development, I came to a point where I think the 'regular' way is just as good, if not better, as mine. So, doing it the regular way now. (sbox.js)

* Committing a long, very long standing (several years!) change to IE handling of keyboard bindings. Well, actually I'm not committing you. No kidding: I spent years having sbox.js in my 'changed' log every time I did a commit, having to uncheck it because I postponed further tests under IE for this fix. Turned out, the testing process itself took about 3 minutes, and the fix didn't have anything to fix. I'm feeling emotional right now. One less 'permanent' file in my changeset, is something to celebrate. (sbox.js)
Title: Re: New revs
Post by: Nao on December 4th, 2013, 03:34 PM
rev 2341 -- phew!! Biggest commit in a long time, really...
 7 files changed, 1456 insertions(+), 568 deletions(-)
 rewrite Themes/default/scripts/stats.js (95%), 15.29 KiB

+ And, welcome to the statistics rewrite... What used to be a long table of meaningless data is now a proper chart, powered by a cool script I heavily customized to my needs. And, it's all Ajaxified. Enjoy. (Stats.php, Stats.template.php, Stats.language.php, stats.js, wraph.js <-- that's the magical script.)

* If no user has entered their gender in their profile, show 'not applicable' in stats, rather than '0:1'. No, they're not all women...

@ Did my best to update the German file and fill in the blank with help from Google. It's probably very gross German, though.

@ Wraph doesn't work on oldIE (<=8), but really? Who cares, at this point..?
Title: Re: New revs
Post by: Nao on December 6th, 2013, 10:51 PM
rev 2342 -- this has been a bit of a nightmare, but the result is quite good.
 6 files changed, 595 insertions(+), 449 deletions(-), 7.04 KiB

* More work on the stat charts. (Stats.php, Stats.language.php, stats.js, wraph.js)

  + Added the ability to zoom into a specific area of a chart when it's got more data available (e.g. on the 'Lifetime' chart.) Just drag around the area you want to zoom into.
  + Added pseudo-separators, i.e. when the chart reaches a new month or year, it shows the label in bold. If this step is skipped, then the next available step will be bolded.
  ! Fixed hovering and clicking on mobile devices.
  + The range select box will be updated to show all ranges accessed within this page load.
  * Optimized speed of tooltip renderer. Shouldn't be noticeable, though, but still...
  * Tweaked number of steps to avoid being overwhelmed by useless details.
  * Tons of spacinazi and related changes to the Wraph library, to make it fit the Wedge coding guidelines.
  * Ajax indicator.

@ Need to implement a button to 'cancel' a zoom. I'm not sure about the UI for that, so it's postponed for now.
@ Known issue in mobile: tapping an empty area with a tooltip opened somewhere else will not hide the tooltip if you're on a daily chart. I know why it happens, just can't bother to add more code to 'fix' that.
Title: Re: New revs
Post by: Nao on December 8th, 2013, 09:36 AM
rev 2343
 7 files changed, 17 insertions(+), 7 deletions(-), 1.60 KiB

- Reverting the universal border-box. I was happy with the results, but then I remembered that IE6/IE7 didn't support it, and would be systematically broken. I won't add more hacks for these, and I still want to retain at least a bit of usability for these silly browsers, and reverting only adds a dozen bytes to the final gzipped file, so... What the hell. I'll look into this again in a few years, if it keeps bugging me. Border-box is an excellent universal selector to use, better than the content-box default if you're starting a new project. Fixing a large, complex older one..? Probably not so much. (editor.css, index.css, index.member.css, mana.css, media.css, sections.css, zoom.css, Wireless/extra.css)

@ Note: I committed too much of index.css, so I forced a reset of the remote and amended my commit to only have what it needed. (If I ever need to unrevert this... :lol:) --> so, if you updated your repo during these two minutes, it's now broken.
Title: Re: New revs
Post by: Nao on December 8th, 2013, 08:14 PM
rev 2344 -- FREE, AT LAST!!!
 39 files changed, 155 insertions(+), 269 deletions(-), 59.72 KiB
 delete mode 100644 Themes/default/Settings.template.php

@ Okay, so this one's a pretty big commit that consists of the bulk of my work on progressively removing $theme variables, and replacing them with either $settings or $options (mostly $settings), or just removing them. I tried listing all files related to respective changes, but honestly, there are so many, I tried twice and failed to gather everything, and I doubt anyone reads through my file lists anyway. Suffice to say, there are tons of stuff.

* Moved show_board_desc and show_children from user options to settings, and show_stats_index, show_latest_member, gender, avatars and blurbs from theme settings to regular settings. I can't think of a single board where I've seen these settings modified anyway, and worse, can't think of a single reason why I would have overridden them. No need to clutter user space with that. (ManageMemberOptions.php, ManageSettings.php, Boards.template.php, Display.template.php, InfoCenter.template.php, Admin.language.php, ManageSettings.language.php, Profile.language.php, install.sql, updgrade.php, upgrade.sql

- Removed setting for warning on new replies. It's on, by default, forever. Live with it. I know that people will ultimately be thankful their new posts aren't ignored by you. (ManageMemberOptions.php, Post.php, Post2.php..)

* Renamed $theme['require_theme_strings'] to $context. Still settable through plugins or templating. I don't remember adding support for extra language strings into skins, so that'll stay for now, but as soon as that is done, you're gone baby, gone. (Load.php)

* Started to merge $theme['default_theme/images*'] variables with the regular non-default ones. (Load.php, Subs-Template.php)

- Removed $context['show_login_bar'], which was an alias to two variable tests, except that all further uses of show_login_bar would systematically reproduce one of these tests, so that's one waste of a test. (Load.php, index.template.php)

- Removed $theme['use_image_buttons'] and $theme['use_buttons'], which were barely used anywhere anyway. (index.template.php, ManageMembergroups.template.php, Memberlist.template.php, ModerationCenter.template.php, Profile.template.php, Search.template.php, Who.template.php)

* $context['menu_separator'] was barely used. Renamed to 'page_separator', and allowing skins to override that. It's probably never going to be used, but at least you can use it to insert extra data in that place through a plugin... Whatever. (Load.php, Display.template.php, MessageIndex.template.php, PersonalMessage.template.php)

* Renaming German language to remove the two-letter code. Basically: if a language is seen as the de-facto 'default' variation, then it doesn't need the code. 'French' and 'German' are exempted. UK English is used by less people than US English, so it's hard to pick a de-facto default here, and thus they both get a code. (index.german.php)

! Wrong function name. (Profile-Modify.php)

- The rest of my uncommitted unnused globals cleanup. (Stats.php, Display.template.php, Msg.template.php, etc.)

* Oh, bugger... That border-box revert isn't going to be so smooth, I forgot one file in the list. (sections.css)

* Moved unread post count to a more proper place in blog homepages. (MessageIndex.template.php)

- Removed Cuil from the list of search engines. It died just two weeks after I started work on Wedge. How amusing. (install.sql)

- Removed unused theme variables, linktree_link and show_bbc. (install.sql)

@ I'll deal with the removal of Settings.template.php later, if you'll allow me.
Title: Re: New revs
Post by: Nao on December 15th, 2013, 11:12 PM
rev 2345 -- this huge commit is NOT pushed to master yet; I'm pushing it to the byebye-themes branch, mainly to test branching. I may rebase my stuff, although I'll try to avoid that.
 185 files changed, 1939 insertions(+), 2828 deletions(-), 169.14 KiB (record beaten! And unlikely to be beaten again :P The actual diff patch size is 717KB, and I'm going to go through it again, yay.)

 delete mode 100644 Themes/default/languages/Settings.english-uk.php
 delete mode 100644 Themes/default/languages/Settings.english.php
 delete mode 100644 Themes/default/languages/Settings.french.php
 delete mode 100644 Themes/default/languages/Settings.german.php

@ The previous commit, despite its size, was a joke compared to this one. Removing theme support (while keeping support for 99% of its features with intelligent skinning) saves a surprising amount of code. Most files get a few kilobytes shaved off their size. Everything done by hand (and triple-checked!), but I'm still expecting many things to be broken for a few days/weeks. I'll fix as bug reports come.

* Renamed all $theme variables to $settings equivalents. $theme, the equivalent of SMF's $settings, is gone. Forever. (There are 120 files or something in this commit, I'm not going to list them all.)

* Replaced $scripturl with SCRIPT and 'theme_url/theme_dir' with TEMPLATES/TEMPLATES_DIR everywhere. Lots of fun. Same with images_url/dir and ASSETS/ASSETS_DIR.

* And more importantly, renamed we::$id to MID most everywhere. This is about twice faster, and, I guess, easier to type and remember.

- Removed theme support from a lot of places. Again-- not listing these all. Basically, many areas will now consider there's only one theme, and that's all there is to say. They'll usually accept multiple skins, of course.

- Removed a suspicious $theme['smileys_url'] I couldn't find used anywhere. (Class-Editor.php)

- Removed theme settings page entirely, phew. (Admin.php Themes.php and Themes.template.php, ManageSettings.php, ManageSettings.language.php, and a few others.)

- Removed unused globals as found by the new version of my fix-globals script. (Class-Skeleton.php, Class-String.php, Notifications.php, and maybe a couple others.)

- This $theme['smileys_url'] alias hadn't been used for years. (Class-Editor.php)

- THEMEURL and DEFAULT_THEMEURL have never been used as variables in email templates. Time to go. (Subs-Post.php)

* Replaced $settings['images_aeva'] with just a hardlink to the /aeva assets folder.

* Renamed show_avatars and show_signatures user options to hide_* equivalents, as it used to be in SMF; this was partly motivated by the fact that most user options have a more sensible 'off' default (except for return to post and quick reply, where it makes more sense to enable these), but mostly because it was buggy and I had to fix it.

* Renamed reloadSettings() to loadSettings(). It's never called more than once... (index.php, Load.php)

* Renamed a few variables to use $context instead of a setting. For instance, if you want to play with templates to be loaded, you should now do it with $context['theme_templates']. Although this one will probably go at some point, too. Or be renamed. Or whatever. Also, $theme['output_buffers'] is now in $context. (Load.php, Subs-Template.php)

* Moved path settings from Server to basic settings. Seriously, this never had anything to do with 'database settings', why mix them up together..? (Admin.php, ManageServer.php, ManageSettings.php)

* Rewrote the $boardurl hack for url_parts(). Thus making $boardurl non-changing across the page lifetime. (Subs-Auth.php)

! News sender was incorrectly interpreting {$board_url} as the script URL, i.e. with 'index.php' in default situations. (ManageNews.php)

! Fixed query viewer not redirecting to the correct URL. (ViewQuery.php)

! Fixed thoughts being refreshed (after an Ajax post) in non-mobile mode even when posting from a mobile skin. (Ajax.php, Load.php, Subs-Cache.php)

! Fixed main menu showing error when the login process failed. (Subs.php)

! Fixed a Pete bug in loadEssentialThemeData stuff. Then removed all code related to the bug, including the fix. Because if you've been reading this changelog, I'm sure you won't mind reading an extra useless line. (ScheduledTasks.php)

* Harmonized member table column lists in loadMemberData; this saves something like 3KB, which is that less data the PHP parser has to load every page load. (Load.php)

* Slightly faster JS/CSS cache purging. (Subs-Cache.php)

Now, go ahead, Like like you've never liked a commit before!! Because that means I'm getting closer to a public release :P
Title: Re: New revs
Post by: Nao on December 16th, 2013, 10:41 AM
[byebye-themes fab1826] rev 2346 -- Okay, I need to stop posting rev numbers... If you want one, just look at the post number, since they've always matched, and always will (at least approximately.)

 11 files changed, 2 insertions(+), 2621 deletions(-)

! Fixed an occurrence of ROOT being called before being defined. (Subs-Cache.php)

- Removed unit tests. Never used, never will. (other/unittest/*)
Title: Re: New revs
Post by: Nao on December 17th, 2013, 04:17 PM
[php-cache 1b3bb92] -- done with rev numbers! <sad>
 10 files changed, 189 insertions(+), 87 deletions(-), 4.16 KiB
 rewrite cache/.htaccess (81%)
 create mode 100644 cache/php/.htaccess
 create mode 100644 cache/php/index.php

+ Added ability to minify and cache PHP source files. This saves about 0.01 to 0.02s per page load. (cache/php, index.php, Load.php, Subs-Template.php)

+ Moved loadSource to index.php, so that we can always call it, from the beginning. (SSI.php, Load.php, ScheduledTasks.php, Subs.php)

* Optimized htaccess for cache folder. (cache/.htaccess)

* Spacinazi. (Login.french.php)

@ While a dozen milliseconds isn't a spectacular speed gain (it's still a 20-30% improvement over regular file includes), it's also the first step towards enabling Wedge to do PHP editing for plugins, just like good old SMF, for situations where hooks aren't flexible enough, with a caveat: you can disable plugins (as opposed to uninstalling them) to easily find the ones that are breaking your site, and you can immediately restore a clean copy of your forum without any changes. Okay, this isn't done yet, and won't be done by the time Wedge goes public, but maybe someone will step up and help.

@ I also need to look into security implications of this change. Couldn't think of anything, but you never know. In any case, it's easy to disable PHP caching entirely, so it's enough to stop me from doing this.[/php]
Title: Re: New revs
Post by: Nao on December 18th, 2013, 02:25 PM
Hopefully, no longer giving rev numbers should encourage me to post one-liner fixes, and get into the 'git spirit' a little more... Uh?

[php-cache 7512df6]

! clean_cache() should also clean the PHP cache. (Subs-Cache.php)

 1 file changed, 3 insertions(+), 457 bytes
Title: Re: New revs
Post by: Nao on December 20th, 2013, 12:42 PM
[php-cache 69c200a] -- mostly unrelated to PHP caching, but whatever, better than committing to byebye-themes :P
 9 files changed, 34 insertions(+), 36 deletions(-), 2.34 KiB

- Not sure why calls to wesql::error_backtrace would insist on passing totally useless file names and line numbers, when the purpose of that function is to get the proper file/line. (Class-DB.php)

! If we can't load the index language file while processing an error (i.e. it was already loaded, and then erased from $txt, then another attempt was made to load it), then Wedge should insist a bit more. If it still fails, better show a raw page than a styled page full of error messages. (Class-DB.php)

- Removing the infamous 'your database may need upgrading' hint at the end of SQL errors. Seriously, when Wedge upgrades its database format, it'll do it without relying on a stupid upgrade script. (Class-DB.php, Errors.language.php)

! Since PHP caching tends to screw up line numbers in error messages, and preserving line numbers in minified files is possible (I did it in fix-globals last week) but still adds a few bytes I'd like to avoid, I'm disabling PHP cache on setups where debugging is enabled, so that you can keep, err... Debugging properly. (index.php)

! Fixed clean_cache() always removing index.php when using $force_folder outside of the recursive process (i.e. it's not a sub-folder we don't care about.) (Subs-Cache.php)

! Fixed a logic error in ViewFile. Funny thing is, it's not even the first one; but the previous bugs weren't mine. (ManageErrors.php)

! French grammar. (ManageSettings.french.php)

* Commenazi. (Profile-Actions.php)
Title: Re: New revs
Post by: Nao on December 23rd, 2013, 12:15 PM
[misc-fixes 434d117]
 9 files changed, 106 insertions(+), 115 deletions(-), 3.13 KiB

* Improved htaccess to automatically detect the best alternative for pretty URLs. In short: enable mod_dir and mod_version, and then you can disable mod_rewrite. (root/.htaccess)

! Fixed a PHP 5.4 warning in contact list generation. (Maybe it's 5.3, I dunno, I skipped that one.) (Class-System.php)

! Fixed a bug in the smiley parser that caused it to always regenerate the smiley cache. Wedge is so fast, I didn't even notice that this was slowing it down. (Subs-BBC.php)

! Prevent running the installer on an existing copy of Wedge. Also fixed that particular detection process, and the error message not disabling the Continue button. (install.php)

* It's certainly much unneeded (for now), but I'd rather make sure the installer only loads pristine copies of the files. I'll need to test later. (install.php)

- Removed some browser version tests that were too old and unneeded. (Class-CSS.php)

* Improved poll builder layout. (Poll.template.php)
Title: Re: New revs
Post by: Nao on December 23rd, 2013, 07:16 PM
[php-5.3 2fe90ec] -- how many branches can I live with before I start merging them...? :P
 12 files changed, 291 insertions(+), 339 deletions(-), 6.11 KiB

* Wedge now requires PHP 5.3+, which allows me to use closures instead of create_function or other ugly callbacks. I'm not going to use these everywhere (it's a manual conversion), but I'm definitely excited to use it everywhere I can from now on. Also, using const keywords where possible -- it should be faster over define() calls. (index.php, Class-CSS.php, Class-String.php, Class-System.php, Profile-Modify.php, QueryString.php, Profile.template.php)

* Overhauled the installer's readme file. I don't know if anyone's ever read it, but it needed more work. Eventually, I'll copy that file somwhere on wedge.org, don't fret. (readme_install.html)

- PCRE is always compiled from PHP 5.3 on, and its version is recent enough, so I can finally remove the PCRE test. Which means no one ever got to see it... Hmm. (install.php, Install.language.php)
Title: Re: New revs
Post by: Nao on December 24th, 2013, 12:14 PM
[php-5.3 8729bad]
 16 files changed, 129 insertions(+), 111 deletions(-), 3.99 KiB


+ Added wesql::fetch_all() and wesql::fetch_rows() functions, which are helper functions implementing PHP 5.3's mysqli_fetch_all. Still need to actually use it everywhere it makes sense, of course... (i.e. anywhere row retrieval is done all at once.) (Class-DB.php, Pin.php)

+ Wedge now supports a permanent cache status. Just use 'forever' as the TTL parameter. (Subs-Cache.php)

* Wedge now uses permanent caching for settings. Redoing that query every 90 seconds made no sense, as once settings are updated, the cache is always emptied anyway. I found a few areas where it wasn't true, so I fixed them as well. (Load.php, ManagePlugins.php, ManageSearch.php, ScheduledTasks.php, Subs-Post.php, Subs.php)

* Also switched smiley database cache to permanent status. I'd already partially accounted for that in my smiley rewrite years ago, and I'm not exactly sure why I didn't go all the way at the time. (Class-Editor.php, ManageSmileys.php, Subs-BBC.php)

* Wedge cache filenames cache (what an interesting name) is now permanent, too. (Subs-Cache.php)

@ No idea why $settings['settings_updated'] isn't updated in updateSettings() (what an interesting sentence); I have a feeling it's a dirty hack and it should be removed from Wedge ASAP.

- Unused array. (Subs-Cache.php)

- Unused setting. (install.sql)

- Removed an eval feature that was available for lists, but never used. In case plugins need that, I'll add a callback version, but don't ask me to use eval when not needed. (Subs-List.php)

* Renamed post_retri_eval to after_run in cache_quick_get(), and using lambda functions instead of eval(). $params are passed as your function params, as it just makes sense. AFAIK, this is only used in the calendar code, which is not even core in Wedge. (Subs-Cache.php)

* Turned a couple of string helper functions to closures. (Class-String.php)

! Missing global in list_getGroups(). Also got rid of the create_function calls, yay.  (Groups.php)
Title: Re: New revs
Post by: Nao on December 27th, 2013, 11:12 PM
[php-5.3 5129f7b]
 21 files changed, 515 insertions(+), 511 deletions(-), 20.03 KiB

* More create_function calls were utterly destroyed for the good of everyone. Nearly all of them are done, the rest are in WIP files. (Dlattach.php, ManageAttachments.php, ManageBans.php, ManageMaintenance.php, ManageMembergroups.php, ManageMemberOptions.php, ManageMembers.php, ManagePaid.php, ManageScheduledTasks.php, ManageSearchEngines.php, ManageSmileys.php, ModerationCenter.php, Modlog.php, RepairBoards.php, Subs-Members.php, install.php)

! Fixed incorrect handling of invalid database prefixes. Replaced a leftover language entry with this new error string. (install.php, Install.language.php)

! Fixed TTL on a settings cache call. (ManageServer.php)

* Saving a cache refresh. (ScheduledTasks.php)
Title: Re: New revs
Post by: Nao on December 29th, 2013, 03:41 PM
[php-5.3 8e8967e]
 253 files changed, 33939 deletions(-), 409 bytes

- Moving other/ folder into a different repo altogether, and deleting it from here. At one point, when I get to rewrite/clean up the Wedge history, I'll remove other/ from it entirely, and this commit will be gone, too, so, it's the ultimate opportunity to just say it, loud and clear: (REDACTED-BY-GIT)
Title: Re: New revs
Post by: Nao on December 31st, 2013, 11:51 AM
[byebye-themes-part-deux 7f58d5b]
 27 files changed, 383 insertions(+), 618 deletions(-)

- Started removing id_theme and we::$user['theme'] from Wedge, and turning theme previews into skin previews, things like that. The loadTheme function has a much simpler intro now, being 54 lines shorter. Still need to turn themes into skins entirely, notably all of the edit/copy/install code, but it's not as urgent, and I might remove them entirely and rely on FTP exclusively. (Most of the files in this commit are concerned by this, so I won't list them. I only need to list files when I need to quickly find a specific change I made in a large commit, really.)

* Rewrote the skin selector (both the plugin and Themes.php versions) to get rid of all theme code. Also used the opportunity to cache the results, so it'll save quite a bit of parsing on every page if you're using the SkinSelector plugin, really. Also, skin previews are no longer stored in the session variable, because if you can navigate your way through the skin selector in a preview state, then I'm sure you can make your decision immediately, without needing to browse the forum. I'm even considering removing the feature altogether, but as of now it's only using a couple of lines, so it's alright. (Load.php, Themes.php, Themes.template.php)

+ Proper support for choosing the 'default skin' from within the skin selectors, rather than just the currently default skin. e.g., choosing 'default skin' will reset your choice to what a guest would see, and if the admin changes the default skin, your skin will follow that choice. (Many files.)

! loadLanguage() no longer takes '+' separated strings as arguments. Oops. (Load.php)

- A very, very old bug: $file[3] was never used in loadLanguage(), meaning the last param was always declared for nothing. (Load.php)

- Removed id_theme from language_changes table. This is only half-done, I have yet to commit ManageLanguages with which I've been having problems. So, basically, the language editor won't work in the current commit. Sorry about that. (Load.php, install.sql)

* Moved issue_http_header() to Errors, the only place where it was used. (Subs.php, Errors.php)

* Note: $ssi_theme is now $ssi_skin, as could be expected. (SSI.php, Load.php)

@ Note: there's a bit of a hack in the skin code update. As of now, default skin = '', root skin = '/' and non-root skin = 'folder'. The slash in root skin doesn't match the non-root folder structure, but this is because I didn't want the extra slash to be stored in all non-root skin choices. That's probably a bad idea, but I'd still rather not have unneeded bytes in skin names, because of their varchar nature within database keys. If I can't live with that hack, I'll restore the starting slash on skin names.

@ Note: $context['skin'] is still being filled in, and represents the folder of your current skin, relative to the skin folder. The new $context['skin_actual'] is also interesting, as it holds your skin choice, which can include 'default', and is used internally in more places.

@ Note: listing here all database changes that need to be made by anyone who currently has Wedge installed. Remove boards:id_theme, add boards:skin_mobile based on boards:skin (haven't yet written this feature, though), remove language_changes:id_theme and update the associated keys, remove members:id_theme and members:id_theme_mobile, add a skin(20) key to members, and remove themes:id_theme. Also, you may want to go to your admin panel, and update the default skins, because the format has changed. You should also reset everyone's skins, for the same reason, or update them manually with phpMyAdmin.
Title: Re: New revs
Post by: Nao on December 31st, 2013, 11:56 AM
[byebye-themes-part-deux 79ff022]
 16 files changed, 32 insertions(+), 36 deletions(-), 30.67 KiB[1]

! Fixed a typo in a very ironic language string key (error_occured). (Errors.php, Login2.php, index.language.php)

! Pete bug: wrong variable name ($members, should be $member). (ScheduledTasks.php)

- Unneeded globals. (ManageMembergroups.php)

* cache_get_data() should be tested against null with a strict operator. (Class-Editor.php, Recent.php, Stats.php, Subs-BBC.php, Subs-Editor.php, Subs-Media.php, also files in previous commit.)

* Files weren't using the SMILEYS constant. Well, they should have. I should also update for SMILEYS_DIR, it'll come later. (ManageSmileys.php, ManageSmileys.template.php, Profile.template.php)
 1. Patch size for this push includes the previous commit, too.
Title: Re: New revs
Post by: Nao on December 31st, 2013, 01:05 PM
[byebye-themes-part-deux 0653c3a]
 10 files changed, 169 insertions(+), 8 deletions(-), 2.79 KiB

+ I haven't updated it in a while and it's still good enough, so it's probably committable material... So here it is, Wilderless. A silly pun on Wilde, Wireless and Wilderness. If I have to explain it, it's probably that it sucks. Suggestions for a better name are welcome. (Wilde/Wilderless/*, install.sql)

- More id_theme stuff. (ManageMail.php, ManageRegistration.php)

- theme_dir. (Aeva-Gallery.php)

- smileys_url. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on January 1st, 2014, 06:12 PM
[byebye-themes-part-deux 2711527]
 10 files changed, 564 insertions(+), 611 deletions(-), 5.14 KiB

* Replaced $helptxt['*'] with $txt['help_*'], which was unused across the entire codebase. It's an absolute waste of time and resources to use a different array for these, really... Especially when it came to caching. Another 50 lines saved in Load.php, it's now below 90KB, having lost nearly 10KB since the theme removal process was started. 10KB of PHP your server won't have to load on every page, and I mean it. (Admin.php, Help.php, Load.php, ManageServer.php, Subs-Template.php, Help.language.php)

* valid_filename() provides a better solution (IMHO) than md5() when it comes to handling the language cache filenames. If I find any issues with it later, it's only a matter of changing two lines. (Load.php, Subs.php)

@ There are more files related to this change, but they're planned for a later commit. I don't think not committing them now will break Wedge, though. Also, Help.language.php changes about 170 lines per file, but it's all about the variables being renamed, nothing else, so don't bother.
Title: Re: New revs
Post by: Nao on January 1st, 2014, 06:21 PM
[byebye-themes-part-deux c5d3e64] -- this one has the actual meat of my rewrite. And, themes are nearly all gone!
 8 files changed, 276 insertions(+), 367 deletions(-), 4.49 KiB

* Rewrote (quite extensively) the language editor to be usable in a theme-less context. Removed $themes[..]['theme_dir'] and $images_dir, which were unnused. (ManageLanguages.php, ManageLanguages.template.php)

* language_changes table changes: lang_var is gone (thanks to the $helptxt rewrite), and replaced with is_plugin, a boolean value that replaces the id_theme value from yore. From what I can see, it all works just fine, and that is_plugin thing is only here for convenience and speed. (install.sql)

! Pete bug: plugins with sub-folders would show up several times in the language file list. (ManageLanguages.php)

! Pete bug: the language editor didn't correctly support entities in language strings. Basically, westr::safe() behaves similarly to the modern version of htmlspecialchars, except it also turns entities into UTF-8 characters if possible. It's not *always* desirable, as in here. (ManageLanguages.template.php)

* Turned language file descriptions into something a bit more usable. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings.language.php)

- Removed the last remaining create_function calls. Those that are still here, are not doable with a lambda function. Also, removed an unneeded global. (ManageLanguages.php, ManageMail.php)

! JS error in custom fields code. (ManageMemberOptions.php)
Title: Re: New revs
Post by: Nao on January 2nd, 2014, 12:34 PM
[master 62c5304]
 455 files changed, 17 insertions(+), 37 deletions(-), 6.40 KiB

* With most of the theme removal completed, it's time to get to the meat of it... Moved these folders to /assets/. Ah, finally!!
  /Themes/default/images (to its root)
  /Themes/default/fonts (to fonts)
  /Themes/default/aeva (to aeva)
  /Smileys/ (to smileys)
  /avatars/ (to avatars)

* Updated code to match new URLs or simply remove support for per-theme image folders. Don't worry, I've got something in the works that will be ten times better than that crappy system anyway! (QueryString.php, Themes.php, Themes.language.php, install.php, install.sql)

- Removed a custom file I shouldn't have committed. Not a biggie, though, it had like 2 lines. (Wilderless/custom.css)

* Commenazi. (SSI.php, Subs-Template.php)
Title: Re: New revs
Post by: Nao on January 2nd, 2014, 01:34 PM
[master 0e0a700]
 15 files changed, 40 insertions(+), 45 deletions(-), 2.29 KiB

* Renamed $settings['avatar_directory'] to 'avatar_dir', for consistency with other variables. (ManageAttachments.php, Profile-Modify.php, Admin.language.php, install.sql)

* Renamed theme_id to source_id in some function, to avoid confusion. (ManageLanguages.php)

* Renamed $settings['avatar_url'] to AVATARS where possible. That's not a lot, but it doesn't really matter. (Load.php, Subs.php, Profile.template.php)

- Removed $context['avatar_url'], never used AFAIK. (Profile-Modify.php)

- Removed another file that didn't get deleted properly. (Smileys/.htaccess)

- Removed unused globals. (ManageLanguages.php, ManageSmileys.php, Aeva-Gallery.php, Subs-Media.php, Themes.template.php)
Title: Re: New revs
Post by: Nao on January 3rd, 2014, 01:59 PM
[master a226178] -- this is *all* I had left to commit apart from JS and CSS tweaks that I'm taking years to complete, hmm...
 12 files changed, 82 insertions(+), 51 deletions(-), 3.61 KiB

+ Added ability to choose your cache type, so, most likely, to force the file cache if another cache type is discovered. This is due to the fact that wedge.org's APC cache is much less efficient than the file cache. I could probably tweak some php.ini settings to fix that, but let's face it, the file cache is often just as efficient as any other cache type, so in addition to this, I've made file caching the default setting. Then you can enable debug mode to check your performance numbers, and cycle through the various caching options available to you, and decide which one is best for your server. (Class-System.php, ManageServer.php, ManageSettings.php, Settings.php, Settings_bak.php, ManageSettings.language.php)

* cache_get_data now accepts an extra callback parameter where you can put a cache generation lambda function that returns the data to be cached. (Subs-Cache.php)

! Fixed warning message for users without any contact lists. (Class-System.php)

! Settings.php data saving didn't allow for select-box-based variables. (ManageServer.php)

! wesql::fetch_all and fetch_rows needed some help in case the original request returned no results. (Class-DB.php)

* Commenazi, and details. (index.php, Credits.php)

@ Note: I'd originally started working on a session-based cache, and was thrilled by the performance improvement (about 10% compared to file-based), but: (1) it depends on whether your database is on your server or a dedicated server, and even whether that dedicated server is efficient (or you could just disable database sessions), (2) I don't think it's worth the hassle overall. While it's interesting to fetch and store all cache data within one single free database call, it also takes more time to unserialize. I'm still keeping the idea around (possibly in a new branch), but right now, I don't want to deal with the TTL and expiration issues this technique implied.
Title: Re: New revs
Post by: Nao on January 4th, 2014, 05:02 PM
[master 6872d91]
 16 files changed, 38 insertions(+), 38 deletions(-), 10.75 KiB (Seriously, these patch sizes are getting more and more disconnected from reality. I won't carry on with them once I automatize log posting.)

* Fixed code to consider /Themes/default moved up one level. The actual move will happen once I manage to do it, there are always files that cause problems, so I'll have to do it from a cleaner repo. (QueryString.php, Subs-Template.php, Themes.php, index.template.php, install.php, install.sql, readme_install.html)

! Fixed some asset URLs. (Class-Editor.php, Subs-Sound.php, ManageMembergroups.template.php, ManageSettings.language.php, editor.js, register.js, suggest.js, install.sql, readme_install.html, ssi_examples.php)
Title: Re: New revs
Post by: Nao on January 4th, 2014, 06:01 PM
[master 252c2b1]
 309 files changed, 4 deletions(-), 327 bytes

* Okay, moved folders up a level, as I said. Give me some time to prepare myself for a more radical move. (Themes/default/* -> Themes/)
Title: Re: New revs
Post by: Nao on January 4th, 2014, 06:43 PM
[master ed3e209]
 4 files changed, 7 insertions(+), 17 deletions(-), 1.02 KiB

! No need for reservedVars when these are no longer put into $theme. (Profile-Modify.php)

- Removed ability to access $theme folder in skins. This never had any use anyway. (Subs-Cache.php, index.css)

* Details. (Wilderless/extra.css)
Title: Re: New revs
Post by: Nao on January 4th, 2014, 08:11 PM
[master e7f4016]
 3 files changed, 13 insertions(+), 8 deletions(-), 859 bytes

! Avoid caching PHP files from external libraries. Namely, getid3 really. (index.php)

* westr::nl2br goes back to using nl2br($str, false) instead of a regex, and the whole world is better for it. I should probably remove westr::nl2br altogether, but have you ever heard of laziness..? Yes? Okay. (Class-DB.php, Class-String.php)
Title: Re: New revs
Post by: Nao on January 5th, 2014, 12:33 AM
[master ddd1ea9]
 1 file changed, 5 insertions(+), 2 deletions(-), 708 bytes

! A supposedly more accurate detection method for touch devices. (script.js)

! Fixed an odd issue with triggering popup animations in Chrome. (script.js)
Title: Re: New revs
Post by: Nao on January 5th, 2014, 12:38 AM
[master 576ef4f]
 3 files changed, 24 insertions(+), 17 deletions(-), 1.65 KiB

+ Introducing support for a 'hardware' version of follow_me. (topic.js, common.css, sections.css)

@ I'm using quotes because Chrome Mobile clearly emulates it through JavaScript (there's an unbearable delay when scrolling through a page), and thus forced me to disable it on it. So, I'm not sure whether other browsers use a JS layer to do this, and if it's faster than my own implementation. Also, recently Blink made some changes and started treating inactive stickies as static, so I had to 'fix' that. Also, it's all totally untested in iOS 6. I figured, okay, I've been postponing this for too long, let's commit it, otherwise I never will. If it breaks (again), it's just a single commit to revert.
Posted: January 5th, 2014, 12:35 AM

:edit: ! Aw, shucks. Forgot to remove that line. (topic.js)
Title: Re: New revs
Post by: Nao on January 5th, 2014, 09:58 PM
[master 7287e90]
 7 files changed, 37 insertions(+), 39 deletions(-), 3.06 KiB

* Tweaks to the phpinfo page. (ManageServer.php)

! Trying for a fix to an undefined index. Dunno if that'll help. (Profile-Modify.php)

! Wedge was still crashing if disabling the currently selected cache system. This small rewrite is now guaranteed to work. (Subs-Cache.php)

* Minor usability tweak for login page. (Login.template.php)

* Layout tweaks for reminder page. (Reminder.template.php)

* Commenazi. (common.css)

- Removing my fix for popup transitions, because I'm afraid it didn't work as well as I thought. This is all down to an actual Blink bug on which I've wasted my afternoon. I can't even determine how the bug is triggered. All I know is that it happens if you're loading a popup when the web page is at the top. If you scroll by at least 60 pixels down, everything starts working as expected. I'd be very, very grateful if someone could work it out for me. I managed to make it work at the top by adding a dummy 3D transform on top of the opacity one, but then it gets funny: sometimes, neither the transition nor the end point of the animation are triggered at all, meaning you don't get the 'dim' effect. I figured I preferred the original glitch to this new one, so here we are. Five lines of changelog to explain why I'm removing half a line from the codebase. (script.js)
Title: Re: New revs
Post by: Nao on January 5th, 2014, 10:10 PM
[master 57390d8]
 1 file changed, 1 insertion(+), 1 deletion(-), 428 bytes

! Nice bug... Was calling add_hook instead of call_hook. Thankfully, I never did that anywhere else. (Feed.php)
Title: Re: New revs
Post by: Nao on January 5th, 2014, 11:30 PM
! Fixed wrong assets URL in JavaScript. Oops. (index.template.php) <-- just one line, not reproducing everything.
Title: Re: New revs
Post by: Nao on January 6th, 2014, 10:19 PM
[master ae6147f]
 2 files changed, 2 insertions(+), 2 deletions(-), 668 bytes

! Profile options were broken due to a typo. (ManageMemberOptions.php)

! Stats page went into a bad infinite loop, but only if visiting it in January (yeah, yeah...) (stats.js)
Title: Re: New revs
Post by: Nao on January 7th, 2014, 07:55 PM
[master 9f36769]
 23 files changed, 123 insertions(+), 117 deletions(-), 6.73 KiB

* Rewrote the skin system to use a flat folder structure. While nested folders are good to help understand how it all works, and is globally a bit faster, they make it impossible to use sub-folders elegantly in skins (and I'm all about elegance), and they take more time to update manually. (Subs-Cache.php)

* Simplified wedge_get_skin_list. A lot. It no longer even does recursion to build the array. I never thought I'd manage to do that. (ManageBoards.php, Themes.php)

- Removed css_folder initialization from loadTheme(); it was redone later in the process anyway. (Load.php)

@ Note: I'm having trouble with moving Wilderless, so I'll just be moving it in this commit, and will commit the xml changes in the next one. Also, I refrained myself from using a lambda function in the CSS file builder, but only because these things are called from the installer, too. I should probably just abruptly exit from the installer if PHP 5.3 is not found, instead of going through the templating system. Adding that to my to-do list.
Title: Re: New revs
Post by: Nao on January 7th, 2014, 07:59 PM
* It's just one line, but it's good for my git history. (Wilderless/skin.xml)
Title: Re: New revs
Post by: Nao on January 8th, 2014, 12:09 AM
[master 509ea9b]
 2 files changed, 34 insertions(+), 32 deletions(-), 1.17 KiB

! Skin folder loading order is important, so I restored the original order. I also rewrote the code to use the skin list cache in order to determine the top-level skin for the current skin chain. (Subs-Cache.php, Themes.php)

- Debug code. (Themes.php)

@ Note to self: need to move the skin list cache code to Subs-Cache.
Title: Re: New revs
Post by: Nao on January 8th, 2014, 04:57 PM
[master 73ef974]
 12 files changed, 135 insertions(+), 51 deletions(-), 4.00 KiB

+ Added new cache system: session-based. This is very different from all other implementations, as it holds the entire cache in memory, but from my experience, it's never more than a couple dozen kilobytes. The cache is loaded on session read (any call to the cache before that, such as retrieving $settings, will use the file cache), and saved on session write, but only if it was actually modified. Wedge also handles cache expiration manually. This is superior to my prior attempt at implementing this last week, on which I'd given up. On my system, there's about a 5% performance improvement compared to the file-based cache, but it depends on many factors and may be slower for you. The fact is, install Wedge, then switch between all cache types, and decide which one is the best for your setup. (Load.php, ManageServer.php, Subs-Cache.php, ManageServer.language.php)

+ Added a new SQL insert method, 'update', which will attempt a regular UPDATE query first, and then fall back to the normal codepath for any data set that failed to update. It's only a basic update, the condition query is taken from the first data set entry, and thus is limited to 'variable = {type:variable}'. Still, it can be useful here and there. (Class-DB.php, Load.php)

+ Added auto-optimization of the session table. It's been historically the biggest space waster in the entire table list of SMF/Wedge, and even the auto-optimize weekly task is fairly inefficient on it. It needs to be triggered more often, so I thought this could be a welcomed addition. Only doing optimization on 10% of all session removals. Should be often enough, but I'll need some testing to ensure this is an ideal number. (Load.php)

* Merged both flat and nested versions of the skin list into the same cache entry. Well, it certainly can't hurt. (Themes.php)

+ Added a placeholder for skin enabling/disabling code. Still needs the actual UI for it, of course. (Themes.php)

* Details. (ManageMaintenance.php, ManageMedia2.php, Subs-Media.php, install.php)
Title: Re: New revs
Post by: Nao on January 8th, 2014, 05:09 PM
[master 2f7fb2c]
 16 files changed, 90 insertions(+), 90 deletions(-), 2.21 KiB

* Turning all normallist classes into the unused 'list' class. This will make life easier for me later on, if I do what I'm planning to do. (16 files, boring search & replace.)
Title: Re: New revs
Post by: Nao on January 10th, 2014, 02:24 PM
[master d3d6572]
 309 files changed, 0 insertions(+), 0 deletions(-)

* Okay... Step 1: rename Themes to core. The rest will follow, I don't want to screw it up.



[master d614364]
 187 files changed, 0 insertions(+), 0 deletions(-)

* Step 2: move Sources to core/sources. Phew...



[master e902490]
 2 files changed, 0 insertions(+), 0 deletions(-)

* Step 3: move Plugins to core/plugins.



[master 83b218c]
 92 files changed, 184 insertions(+), 174 deletions(-), 421.48 KiB (total for all commits in this push.)

* Started updating the program with the new folder structure. I'm totally sweating right now. Moved template files to templates subfolder. Introduced a CORE constant to make it easier to link to these subfolders. (Load.php, QueryString.php, Subs-Cache.php, Subs-Template.php, Themes.php, contributors.txt, install.php, install.sql, ManageBoards.template.php, ManagePlugins.template.php, maybe others.)

* Reverted core/plugins to plugins, to avoid the risk of having core/ URLs in the HTML. I could have ammended my last commit, but this allows me to change the folder to lowercase without any issues with git follow rename. (plugins/*)

* Details. (ManageServer.php, ScheduledTasks.php)

! Fixed SSI link. (Home.template.php)

! Fixed undefined variable in session reading. (Load.php)

- Removed what seems to be a buggy line in the plugin CSS cache code that was supposed to be replaced by a fix, but both lines remained in there. Hmm. QC anyone? (Subs-Cache.php)

- Getting rid of folder names for add_js_file calls to any files within the javascript folder. I'm also considering removing the js extension to match add_css_file calls, but I'm not sure yet. I like adding the js extension, for some reason. (37 files; Admin, Class-Editor, Load, ManageBans, ManageBoards, Profile, Subs-Cache, Subs-Editor, Subs, Aeva-Foxy, Aeva-Gallery2, Aeva-ModCP, Aeva-Subs-Vital, ManageMedia, ManageMedia2; TEMPLATES: Admin, Boards, Display, Login, ManageBoards, ManageMembergroups, ManageNews, ManagePaid, Media, MessageIndex, PersonalMessage, Profile, Recent, Register, Reminder, Stats, index; SKINS: skin.xml, Warm/skin.xml, Wilde/skin.xml, Wine/skin.xml, Wuthering/skin.xml)

NB - This is the quasi-final folder structure, but it may get tweaked depending on my needs, really. At this point, I accept the idea that I'll have an unclean portion of my git history (with many successive folder renames), but it's okay, as it won't hurt either Show Log or Blame in TortoiseGit.
Title: Re: New revs
Post by: Nao on January 16th, 2014, 06:39 PM
Got a bit behind, posting all of these revs at once, because I can...

a26b559 +1 -1 line

* ! Typo in announcement code was making this code not work. Doesn't matter much, as the feature needs a rewrite anyway, ahem... (Admin.php)



d094759d8c78c37b04fd9b09b54ba7a1728f2d64 +5 -5 lines

* ! Fixed an old missing language string. (Profile.template.php)



7e1134cd70b733a65fdb909934cacf89ffef791c +1 -1 line

* ! Fixed wrong JS filenames since the recent rewrite. The bug wasn't obvious, as the filename was still valid and JS still worked. (Subs-Cache.php)



b61078b2b4cbbe65ba09dc25456aef0e9199cba3 +1 -1 line

* ! Wess was using the user's preferred skin file, regardless of overrides. (Subs-Cache.php)

! Default skin was always Weaving. Oops. Okay, that was in the same line... (Subs-Cache.php)



[master 236f70c]
 2 files changed, 52 insertions(+), 79 deletions(-).

+ Language caching no longer requires any particular language to have a matching file. Just one of the folders (English, default forum language and user language) needs to have it. If not found, then it's an error as usual. (Load.php)

! Custom language files were always being searched for, if not found. Wedge will now properly cache a non-existent custom file, and if you ever add one, then just flush the language cache. (Load.php)

! Wess will no longer leave $txt variables in if it can't find a matching language string. It'll just replace them with an 'Error' string, which is way, way better than the script refusing to execute, innit..? (Subs-Cache.php)

- Removed integrate_theme_include feature. Never used in Wedge. If a plugin needs this, there's a hook just below it. If a skin needs it, there's an include feature in skins, and if you really want PHP includes, I can look into it. (Load.php)
Title: Re: New revs
Post by: Nao on January 16th, 2014, 07:42 PM
[master cebde06]
 4 files changed, 33 insertions(+), 30 deletions(-), 1.33 KiB

! Fixed installer. A lot of things were broken due to the theme removal process. I'm not sure it'll work perfectly everywhere, but it does for me. (install.php, Subs-PrettyUrls.php)

! Fixed incorrect margin on homepage top. (index.css)

* I thought I'd updated the homepage to be set to Home by default... Well, nope. So, I'm doing that now. I don't even know if I want to keep Welcome, at this point. (install.sql)
Title: Re: New revs
Post by: Nao on January 16th, 2014, 08:01 PM
[master 919e92f]
 1 file changed, 33 insertions(+), 33 deletions(-)

Improved installer script by making sure that source caching is disabled. Known issue: user isn't auto-logged in after install. Honestly, I don't know why, so it'll remain there until I'm less tired, or someone fixes it for me. (That'll probably come down to the latter, because I can't really bother. Much.) (install.php)
Title: Re: New revs
Post by: Nao on January 17th, 2014, 01:02 AM
[master df06599]
 1 file changed, 5 insertions(+), 1 deletion(-)

Can't serialize lambdas, so after_run pseudo-hook failed. Only concerned the calendar plugin, though. (Subs-Cache.php)

NB: this one was a bit fucked up... I did an amend by mistake on the previous commit (I was trying to amend the plugin repo, but targeted the wrong folder), so my tree diverged from the remote one after this commit, and TGit refused to push (thankfully.) So, I 'simply' did a reset soft to HEAD^^, then pulled from remote (!!), then committed my change again. Apparently, the tree is one again. Also, I did a reflog expire and a gc prune, just to ensure my tree wasn't polluting the remote, but I don't think orphan SHA's get pushed anyway. If you understood anything out of what I just said, will you marry me?
Title: Re: New revs
Post by: Nao on January 17th, 2014, 10:37 AM
[master 2b676c7]
 3 files changed, 42 insertions(+), 36 deletions(-)

Made calendar homepage a bit more bearable to the human eye. (Calendar.template.php, calendar.css)
Title: Re: New revs
Post by: Nao on January 17th, 2014, 10:40 AM
[master e1c0ca2]
 1 file changed, 3 insertions(+), 3 deletions(-)

Fixed plugin CSS cache code. It was nicely broken, and could additionally conflict with other plugins or even main files. Bad! (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on January 17th, 2014, 11:13 AM
[master 357cf0f]
 4 files changed, 31 insertions(+), 3 deletions(-)

Add an 'uncache' action to the Admin menu (yes, I think it's a funny name.) It allows admins to purge all cache (CSS, JS, PHP, etc.) all at once. I should have added that one long ago... Importantly, from now on we can be nicer on cache expiration dates, and thus on server load. Also obsoletes the Flush Lang Cache plugin, BTW. (index.php, Subs-Cache.php, Subs.php, index.english.php)
Title: Re: New revs
Post by: Nao on January 17th, 2014, 01:34 PM
[master 6f15e12]
 8 files changed, 78 insertions(+), 31 deletions(-)

* Applied SMF 2.0.6 security patches where needed. I rewrote the Register part to account for Wedge peculiarities and, well, be shorter. (index.php, Logout.php, Profile-Actions.php, Profile-Modify.php, Profile.php, Register.php, Subs-Members.php)

! Inverted profile variables when resizing a large avatar. Wasn't me! (Profile-Modify.php)

* Variable simplification. Should this be a Wedge constant rather than westr constant, though..? This has its uses in a few places. (Class-String.php)

@ I have a feeling these anti-XSS headers are a bit outdated...
Title: Re: New revs
Post by: Nao on January 17th, 2014, 03:17 PM
[master b2f3843]
 2 files changed, 13 insertions(+), 14 deletions(-)

! Fixed the one remaining mysqli_query() call in Wedge. Phew... (Subs-Template.php)

* Spacinazi. (ModerationCenter.php)
Title: Re: New revs
Post by: Nao on January 17th, 2014, 03:30 PM
[master cfe342b]
 8 files changed, 18 insertions(+), 18 deletions(-)

Replaced a few arrow entities with UTF8 equivalents. (MessageIndex.php, Unread.php, UnreadReplies.php, ModerationCenter.template.php, Post.template.php, Profile.template.php, Recent.template.php, Search.template.php)
Title: Re: New revs
Post by: Nao on January 17th, 2014, 08:21 PM
[master d50d2fa]
 11 files changed, 60 insertions(+), 35 deletions(-)

+ Added support for skin_mobile definition in boards. (Half a dozen files.)

* Renamed boards.override_theme to boards.override_skin, obviously. (Half a dozen files.)

! Fixed the last wesql::insert. Was too glad to be finished with it, I forgot to add the table name, ah ah... (Subs-Template.php)

! If a board was using the default skin, it would reset to something else in the board management page. (Themes.php, ManageBoards.template.php)
Title: Re: New revs
Post by: Nao on January 18th, 2014, 09:50 AM
[master f8c8552]
 11 files changed, 62 insertions(+), 30 deletions(-), 14.12 KiB

+ Finally implemented the UI to turn a board into a blog. Well, that was actually very easy, as expected. Most of the diff patch is filled with the (more tedious) replacement of 'board' to 'forum' (for logical reasons) in board_type choices.

PS: Yeah, can you believe it..?! Me doing tedious work for a release.
Title: Re: New revs
Post by: Nao on January 18th, 2014, 03:29 PM
[master 90e14f9]
 5 files changed, 20 insertions(+), 20 deletions(-)

+ Added support for skin templates. Just add a 'html' folder in your skin folder, and every file you'll put there will replace the default template, just like themes do in SMF. I only added this feature to ensure that theme functionality is 100% emulated in Wedge, but honestly I don't think it's a very good thing to do. I'd strongly recommend using function overriding inside your skin.xml files, or at least waiting until I decide whether both template files (default and skin's) should be loaded, in which case of course your template files will need to exclusively use overriders.

* Renamed $settings['template_dirs'] to $context['template_folders'], because it makes more sense to store in $context anything that's NOT stored in the database in the first place.

* Variablenamenazi. (Display.php)

@ Taking a huge leap of faith; am now parsing skin options before loading templates at all.
Title: Re: New revs
Post by: Nao on January 18th, 2014, 03:33 PM
[master 31e39ca]
 3 files changed, 4 insertions(+), 4 deletions(-)

! Fixed styling of viewquery pages. (ViewQuery.php)

! Fixed wrong variable name. (index.template.php)

- Disabling contact list pages until I find some time to actually rebuild them. (Profile.php)
Title: Re: New revs
Post by: Nao on January 18th, 2014, 08:41 PM
[master d917d5b]
 2 files changed, 7 insertions(+), 3 deletions(-)

! Marking a topic as unread if it had no replies would mark it as read instead. (Subs-Boards.php)

! If a JS file to be cached isn't found, abort the process instead of creating an empty JS file with a silly name. (Subs-Cache.php)
Title: Re: New revs
Post by: Nao on January 18th, 2014, 08:55 PM
[master bec9df2]
 1 file changed, 3 insertions(+), 3 deletions(-)

On topics with well over 50 pages, clicking the page index expander would result in the same list reappearing indefinitely. (script.js)

(Plus, shorter script, by a few bytes :P)
Title: Re: New revs
Post by: Nao on January 19th, 2014, 10:24 PM
[master c663d38]
 21 files changed, 75 insertions(+), 68 deletions(-)

* Renamed /cache to /gz (home of gzipped files), and moved its contents to /keys (key-value pairs). Renamed /cache/php to /cache/app for consistency. Moved cached language files to their own /gz/lang folder. Finally, moved /css and /js to /gz to clean up the root folder structure. Links will now appear as 'gz/...' in the HTML pages, but it's just going to add a couple of bytes to your gzipped pages. I could afford adding hundreds of bytes before Wedge becomes heavier than the competition, so, whatever. (cache/*, css/*, js/*, gz/*)

* Fixed various files with the updated hardcoded links. (Class-Editor.php, Load.php, QueryString.php, Subs-Admin.php, Subs-BBC.php, Subs-Cache.php, index.php, root/Settings.php, root/Settings_bak.php, root/install.php, root/readme_install.html)

* Saving a few bytes in CSS files by using absolute instead of relative paths on non-embedded URLs if it's worth doing it, i.e. the forum is not uploaded to the root folder. (Subs-Cache.php)

@ Note: if you're paranoid about hiding your PHP files from view, you're free to point $cachedir to something else, but keep /css and /js inside /jgz, because they're hardcoded. I know, it doesn't make sense to store their folder names in Settings.php if you can't change them anyway, uh..? Will have to work on that.
Title: Re: New revs
Post by: Nao on January 19th, 2014, 10:46 PM
[master 1ed8455]
 14 files changed, 43 insertions(+), 26 deletions(-)

! Why doesn't the board manager allow you to open multiple boards at once anyway..?! (ManageBans.template.php)

* Using this opportunity to remove specificity on input classes. This might cause new issues with other elements using the same generic class names, but so far I only found a use of the .delete class that's unrelated to buttons, and fortunately it doesn't conflict in a visible way. Still, I'll probably have to rethink this. (common.css, index.css, well, basically most files in skins/*)

! My definition lists don't work so well in medium-sized desktop windows. A shame. Making the trigger stricter, then. (sections.css)

! Forgot to commit the lang cache folder. (gz/lang/*)
Title: Re: New revs
Post by: Nao on January 19th, 2014, 11:19 PM
ABOVE IS AMENDED.
Because I still can commit, push, amend and re-push. From tomorrow on, I won't be able to do that. I'm sad.

[master 5bc16c9]
 5 files changed, 23 insertions(+), 7 deletions(-)

! Why doesn't the board manager allow you to open multiple boards at once anyway..?! I'm fine with not doing it for categories, but boards... You can have many of them. (ManageBans.template.php, mana.css)

! My definition lists don't work so well in medium-sized desktop windows. A shame. Making the trigger stricter, then. (sections.css)

! Forgot to commit the lang cache folder. (gz/lang/*)
Title: Re: New revs
Post by: Nao on January 20th, 2014, 06:59 PM
[master 21922d3]
 20 files changed, 123 insertions(+), 25 deletions(-), 14.97 KiB

! Fixed problem where topics were being flagged as unread by MessageIndex, then confirmed as read by get_unread_numbers(), causing a nuclear implosion on the molecular level. (It's always on the molecular level, but it feels smarter to say it.) Well, technically I didn't fix anything, I just took the easy way out by doing an isset(), but at least now I know why it should happen, and why I don't really care. (MessageIndex.template.php)

! Moved privacy constants to the first likely file to use them, i.e. the system class, and used the old syntax for defining them, just in case you're trying to install on an old version of PHP. (index.php, Class-System.php)

! Fixed another installer error. I hate it when a one-time problem turns into a permanent variable test, but you gotta do what you gotta do... (Subs-Cache.php)

* Renamed the /root folder to /install, and moved some of its files to the actual root. I figured that some of these files needed to be in every distribution, regardless of the install status: license files, contributor files, and changelogs.

* Updated the Wedge license to make it clearer that you can fork Wedge on github. This is, of course, according to the git terminology that a 'fork' is just a copy of the Wedge repository that sits in your public account, ready to share your improvements back to Wedge. (Anyone willing to bet it'll be months before I get my first pull request for a feature or plugin from someone not already well involved in Wedge? ;))

+ Added a CRLF-friendly README, GitHub-style, that should serve as a quick introduction to Wedge newbies. (README.md.txt)
Title: Re: New revs
Post by: Nao on January 21st, 2014, 01:09 PM
[master 79ff7de]
 2 files changed, 11 insertions(+), 11 deletions(-)

* Turned a few of the database's TINYINT(1) fields into BIT(1), which is new in MySQL 5. Please note that existing tables don't need to be updated if you can't bother -- BIT is the same as TINYINT, it just takes less space. Also, I didn't change everything, because there are some tinyints that actually accept more than a boolean value, and I don't want to screw these up, so I have to do all of these manually. If anyone wants to convert more, be my guest. (install.sql)

! Fixed writable folder locations. Thanks Pandos! (install.php)
Title: Re: New revs
Post by: Nao on January 21st, 2014, 04:18 PM
+4-4

* ! Minor typo in license file. (license.txt, readme.md.txt)
* GitHub isn't smart enough to guess that 'readme.md.txt' is the same as 'README.md', except on my terms.

(Kinda amusing/fitting that Wedge became public on its 2400th commit. Well, technically commits no longer have numbers, but here they still do...)
Title: Re: New revs
Post by: Nao on January 21st, 2014, 04:32 PM
[master 66876f5] The new language cache wasn't purged by uncache. (Subs-Cache.php)
 1 file changed, 2 insertions(+), 1 deletion(-)

Should I keep posting new revs here, when you can now just access the rev log here..?
https://github.com/Wedge/wedge/commits/
Title: Re: New revs
Post by: Nao on January 21st, 2014, 06:45 PM
[master 6b6ded5]
 2 files changed, 15 insertions(+), 15 deletions(-)

Apparently, MySQL doesn't like being asked the unsigned keyword on bit fields. It should have been smart enough to ignore them, but whatever... (install.sql)

While I'm at it, minor regex simplifications. (install.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2014, 12:46 AM
[master 9d8fdef]
 3 files changed, 2 insertions(+), 2 deletions(-)

Misc. fixes

- No need to loadLanguage('Settings') when this language file no longer exists, uh? (Themes.php)

! Pete bug: fix_accents was called through preg_replace, rather than preg_replace_callback. (Subs-PrettyUrls.php)

! The install file probably needs to make gz/app writable, too. (install.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2014, 01:28 AM
[master fcdb130] I'm a zombie... I'm already sleeping... And I'm committing big fixes.
 2 files changed, 4 insertions(+), 2 deletions(-)

Fixed icons not getting embedded, and thus making Wedge load less smoothly. This was due to this week's rewrite of... some stuff, the one where I wanted to save some... other things, and as such added more stuff. (Class-CSS.php)

Temporarily removing PHP minification. The time savings it brings to your server aren't exactly saving me time when it comes to providing support. (index.php)
Title: Re: New revs
Post by: Nao on January 22nd, 2014, 03:31 PM
[master e27fe6b]
 5 files changed, 20 insertions(+), 13 deletions(-)

+ Rewrote YouTube embed code to allow for a resizable, responsive iframe. I'd wanted to do that one for some time. (Aeva-Embed.php, Subs-Aeva-Sites.php, sections.css)

* Skins, not themes. If I do one at a time, I'll be done in 10 years. (Themes.english.php)

! Layout fix. (README.md)
Title: Re: New revs
Post by: Nao on January 23rd, 2014, 08:15 PM
[Commit revision d76cbef]
Author: Nao(https://github.com/Nao)
Date: Thu, 23 Jan 2014 20:14:48 +0100
Stats: 7 files changed; +45 (insertions), -42 (deletions)

Title: Re: New revs
Post by: Nao on January 24th, 2014, 04:43 PM
[Commit revision 2f88db6]
Author: Nao(https://github.com/Nao)
Date: Fri, 24 Jan 2014 16:15:53 +0100
Stats: 2 files changed; +5 (insertions), -15 (deletions)



[Commit revision 9201be5]
Author: Nao(https://github.com/Nao)
Date: Fri, 24 Jan 2014 16:42:33 +0100
Stats: 1 files changed; +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 24th, 2014, 05:56 PM
[Commit revision 3ff60b1]
Author: Nao(https://github.com/Nao)
Date: Fri, 24 Jan 2014 16:56:57 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)


[Commit revision 006d159]
Author: Nao(https://github.com/Nao)
Date: Fri, 24 Jan 2014 17:53:49 +0100
Stats: 2 files changed; +18 (insertions), -11 (deletions)


[Commit revision 14cc26c]
Author: Nao(https://github.com/Nao)
Date: Fri, 24 Jan 2014 17:55:38 +0100
Stats: 1 files changed; +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on January 24th, 2014, 09:17 PM
[Commit revision d9c6d22]
Author: Nao(https://github.com/Nao)
Date: Fri, 24 Jan 2014 21:09:56 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 25th, 2014, 06:54 PM
[Commit revision 37ddd6d]
Author: Nao(https://github.com/Nao)
Date: Sat, 25 Jan 2014 18:47:32 +0100
Stats: 5 files changed; +9 (insertions), -11 (deletions)

Title: Re: New revs
Post by: Nao on January 26th, 2014, 08:46 PM
[Commit revision 44de091]
Author: Nao(https://github.com/Nao)
Date: Sun, 26 Jan 2014 16:25:00 +0100
Stats: 28 files changed; +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on January 26th, 2014, 10:19 PM
[Commit revision 636c8b1]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 26 Jan 2014 22:18:40 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on January 27th, 2014, 10:03 AM
[Commit revision f9df14d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Jan 2014 10:00:06 +0100
Stats: 1 files changed; +4 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on January 27th, 2014, 09:19 PM
[Commit revision 934e2bf]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Jan 2014 13:00:28 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)


[Commit revision e1a2a1d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Jan 2014 21:19:10 +0100
Stats: 45 files changed; +111 (insertions), -425 (deletions)

Title: Re: New revs
Post by: Nao on January 27th, 2014, 10:41 PM
[Commit revision 2d894d6]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Jan 2014 22:41:07 +0100
Stats: 2 files changed; +229 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on January 27th, 2014, 11:16 PM
[Commit revision d1adbac]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Jan 2014 22:48:39 +0100
Stats: 1 files changed; +5 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 27th, 2014, 11:52 PM
[Commit revision 7eccc60]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Jan 2014 23:50:24 +0100
Stats: 1 files changed; +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 28th, 2014, 05:31 PM
[Commit revision 176edca]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 13:14:11 +0100
Stats: 2 files changed; +3 (insertions), -5 (deletions)


[Commit revision 915a2c4]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 13:15:09 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 29th, 2014, 10:52 AM
[Commit revision 7afbc8d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 19:38:30 +0100
Stats: 1 files changed; +1 (insertion), -2 (deletions)


[Commit revision 2577996]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 19:41:51 +0100
Stats: 2 files changed; +34 (insertions), -8 (deletions)


[Commit revision a832463]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 22:44:13 +0100
Stats: 1 files changed; +2 (insertions), -1 (deletion)


[Commit revision 88783ce]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 22:48:53 +0100
Stats: 3 files changed; +14 (insertions), -8 (deletions)


[Commit revision e168928]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 23:04:24 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)


[Commit revision 4aab401]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Jan 2014 23:05:28 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 29th, 2014, 12:57 PM
[Commit revision e974a13]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Jan 2014 12:41:06 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 29th, 2014, 07:55 PM
[Commit revision 5d04d52]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Jan 2014 19:54:58 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5d04d5271aefeb3eb4eaad8d334e6be404d29969); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on January 29th, 2014, 10:06 PM
[Commit revision 62e7344]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Jan 2014 21:32:03 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/62e7344291c79ecd32f08eb587ed0a5d359b68c5); +1 (insertion), -1 (deletion)


[Commit revision b9eeca8]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Jan 2014 21:35:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b9eeca81b876765984a38bf3e1b3ce043adbdfe5); +6 (insertions), -10 (deletions)


[Commit revision 9f60293]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Jan 2014 21:36:45 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9f602934b47f65c5fc4a0bedc90ac29c1204bb66); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 30th, 2014, 06:43 PM
[Commit revision 770f36d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 30 Jan 2014 18:39:42 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/770f36d043e551ecb6162e4b4729b4a1b2230888); +76 (insertions), -75 (deletions)


[Commit revision 87bbcd4]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 30 Jan 2014 18:43:03 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/87bbcd4696d2040a815d30e1ce23dc64040b18af); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on January 30th, 2014, 07:11 PM
[Commit revision 9add95e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 30 Jan 2014 19:10:54 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9add95ef5d6fbd9a21fdfe54378dc7df5f579f12); +4 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 31st, 2014, 04:10 PM
[Commit revision 9262e3f]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 31 Jan 2014 16:07:57 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9262e3f332394a04de2151aae42ff71fc2ecf697); +10 (insertions), -14 (deletions)

Title: Re: New revs
Post by: Nao on January 31st, 2014, 04:54 PM
[Commit revision 09c96d3]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 31 Jan 2014 16:49:40 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/09c96d395581cb5a27f58d87f85622cc89bdf679); +3 (insertions), -13 (deletions)

Title: Re: New revs
Post by: Nao on February 1st, 2014, 03:22 PM
[Commit revision 0d8dfe9]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 31 Jan 2014 23:10:16 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0d8dfe9e9bcc02dd8dffab23eca6115de48974d9); +1 (insertion), -1 (deletion)


[Commit revision 342172d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Feb 2014 15:10:16 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/342172d0f1a256f67f01ee5bb51aea943cc25220); +3 (insertions), -5 (deletions)


[Commit revision 9c69e45]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Feb 2014 15:11:26 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9c69e45f2259669cfa704f6fef133690b8139b3e); +1 (insertion), -1 (deletion)


[Commit revision 13e45e8]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Feb 2014 15:22:15 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/13e45e8f972236663f6b93efa2dbd757ee8458ba); +4 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on February 3rd, 2014, 04:07 PM
[Commit revision 7ed1e12]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Feb 2014 15:54:00 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7ed1e120006f14f241b178413e2d1728a406a7ed); +1 (insertion), -1 (deletion)


[Commit revision 4733f8f]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Feb 2014 18:57:16 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4733f8f7c44b9305f5d8a544fd287b8c060d3fc3); +1 (insertion), -1 (deletion)


[Commit revision 8c9a955]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Feb 2014 22:53:01 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/8c9a95532e110a203bc269951221f9419ed47418); +19 (insertions), -11 (deletions)


[Commit revision 679a511]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Feb 2014 19:04:44 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/679a511eb1d9c1f35cd1b86f8c909a6254b38b01); +5 (insertions), -6 (deletions)


[Commit revision 4b0255a]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Feb 2014 14:50:47 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/4b0255a04469faba7ae72656d3b4b9229219a3bd); +36 (insertions), -86 (deletions)


[Commit revision b85bdff]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Feb 2014 16:06:52 +0100
Stats: 8 files changed(https://github.com/Wedge/wedge/commit/b85bdff63d39130bee7157ddf876ccb4bd644283); +94 (insertions), -798 (deletions)

Title: Re: New revs
Post by: Nao on February 3rd, 2014, 07:28 PM
[Commit revision 35b0756]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Feb 2014 19:23:14 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/35b0756c33cdd0ded5c979de37d2d141b2ae4067); +40 (insertions), -46 (deletions)

Title: Re: New revs
Post by: Nao on February 3rd, 2014, 11:30 PM
[Commit revision ef08042]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Feb 2014 23:30:08 +0100
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/ef08042eddf0ef5f699f377e4eea80a2ed1f4956); +23 (insertions), -18 (deletions)

Title: Re: New revs
Post by: Nao on February 3rd, 2014, 11:58 PM
[Commit revision 13ce79c]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Feb 2014 23:58:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/13ce79c282d5973409defc15e6074141ddb8334f); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 4th, 2014, 03:49 PM
[Commit revision e044b10][1]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Feb 2014 15:44:00 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e044b10bc6964e8a7d9576fdb7ab80c151be8430); +1 (insertion), -1 (deletion)


[Commit revision 4bb13a6][2]
(https://gravatar.com/avatar/f430af96c0a59dfb2211a0062a137729?d=https%3A%2F%2Fidenticons.github.com%2F74ba307b3ca3779076f651c6a3deaabb.png&r=x)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Thu, 30 Jan 2014 09:33:39 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4bb13a6fbd01d2d6d9a5d20f6152c44c645b59a9); +1 (insertion), -1 (deletion)

 1. That was my 180th commit in a row, SVN-style. Obviously my record, but a very useless one! :lol:
 2. And Pandos's first commit to mainline Wedge ;)
Title: Re: New revs
Post by: Nao on February 4th, 2014, 04:25 PM
[Commit revision 017ece5]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Feb 2014 16:16:44 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/017ece509e6534cad3950387a2ec1fa6d7408524); +5 (insertions), -8 (deletions)

Title: Re: New revs
Post by: Nao on February 4th, 2014, 10:15 PM
[Commit revision f35e99e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Feb 2014 22:00:46 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f35e99ef266cd8e41134fa580d5be6b3c74e8d33); +28 (insertions), -24 (deletions)


[Commit revision 34210fe]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Feb 2014 22:10:50 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/34210fe0d4858de2036f1b85d7efa2a9235ba458); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on February 5th, 2014, 12:03 PM
[Commit revision dfd9b01]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 05 Feb 2014 12:01:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dfd9b0177cd0931694bdbd54880565baa80f8319); +8 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on February 5th, 2014, 03:14 PM
[Commit revision 3e0b227]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 05 Feb 2014 15:13:54 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/3e0b227e7390af48d51db589290a36051a9151af); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 6th, 2014, 12:41 AM
[Commit revision 7df6fcf]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 06 Feb 2014 00:40:58 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/7df6fcf320b33a0ffe981341ee9eb4dd675f48a8); +29 (insertions), -24 (deletions)

Title: Re: New revs
Post by: Nao on February 6th, 2014, 06:36 PM
[Commit revision 5ffe11d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 06 Feb 2014 16:01:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5ffe11d978435dad95adbc2d556ecbdea98b829b); +41 (insertions), -44 (deletions)


[Commit revision cf84467]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 06 Feb 2014 18:25:23 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/cf844671b45926784c60b84024b863d2d127e43e); +17 (insertions), -81 (deletions)


[Commit revision d0229b3]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 06 Feb 2014 18:36:02 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d0229b37f2c9efea5d1e717e2cbbaecf21cc251e); +5 (insertions), -15 (deletions)

Title: Re: New revs
Post by: Nao on February 7th, 2014, 12:23 AM
[Commit revision 3231132]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 06 Feb 2014 23:20:25 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/3231132f86aca5ae8ab321560d079aa57d025337); +56 (insertions), -16 (deletions)


Posted: February 6th, 2014, 11:20 PM

[Commit revision c0db789]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Feb 2014 00:08:19 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c0db789abbbd09ce0c120ab06a593463d5095b4b); +1 (insertion), -5 (deletions)


Posted: February 7th, 2014, 12:08 AM

[Commit revision a54e87f]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Feb 2014 00:14:22 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a54e87f4a6b8abd853b0ff1b5cba5b60bf7b3ade); +2 (insertions), -0 (deletion)


Posted: February 7th, 2014, 12:15 AM

[Commit revision de470ad]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Feb 2014 00:23:10 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/de470ad1979ede2efbcf3572d9b3053502bbcbf5); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on February 8th, 2014, 12:24 PM
[Commit revision b01e5dc]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Feb 2014 19:32:05 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b01e5dcf4823b338b6150625654e28f9fd1fd6f9); +5 (insertions), -13 (deletions)

Title: Re: New revs
Post by: Nao on February 8th, 2014, 10:51 PM
[Commit revision 580c48e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Feb 2014 18:29:03 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/580c48ef75ede2acd5e1bd20bf2d7f8388411601); +5 (insertions), -12 (deletions)


[Commit revision 12ef33c]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Feb 2014 18:29:18 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/12ef33c5df3bc0ca2cc2ed50948940c0625e7c7b); +1 (insertion), -2 (deletions)




Note: this is kinda annoying... I noticed that my latest push wasn't in the list. I'm guessing GitHub was met with a timeout when they pushed to my webhook, thus forcing me to go to the website, settings, and 'test hook' to re-submit the latest push. I have no idea how to deal with that, honestly... (??)
Perhaps I should, when pushed to, reply with a request to get all latest commits, and then keep a list of these commits in memory. That'd force me to re-create the DB table I'd happily removed recently when I turned my plugin into a webhook... :-/ :-/ Any opinions? (On another topic, of course. Sorry.)
Title: Re: New revs
Post by: Nao on February 9th, 2014, 04:30 PM
[Commit revision f1fa3e5]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Feb 2014 09:14:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f1fa3e543cf0209ae2e5337651051d7d4a916bd9); +66 (insertions), -403 (deletions)


[Commit revision 4308a39]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Feb 2014 13:47:26 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/4308a39a43a48e577ced7b19c43fc870cb86583b); +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 9th, 2014, 04:59 PM
[Commit revision 62d34d1]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Feb 2014 16:58:53 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/62d34d12569e6e2c8f677fb1c6b7bc5d2e4dab4c); +11 (insertions), -17 (deletions)

Title: Re: New revs
Post by: Nao on February 9th, 2014, 08:36 PM
[Commit revision 46f8f6e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Feb 2014 20:23:52 +0100
Stats: 174 files changed(https://github.com/Wedge/wedge/commit/46f8f6ea1d0ccb7b13e2823af523b63c1695c03a); +697 (insertions), -698 (deletions)


[Commit revision f88fee6]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Feb 2014 20:35:35 +0100
Stats: 66 files changed(https://github.com/Wedge/wedge/commit/f88fee65b4545206deb5b2173cd60677620eb3b8); +309 (insertions), -401 (deletions)

Title: Re: New revs
Post by: Nao on February 9th, 2014, 10:18 PM
[Commit revision 79e58f0]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Feb 2014 22:18:05 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/79e58f0e6db8962fa2cf22cf5584ad8c90add9b9); +42 (insertions), -43 (deletions)

Title: Re: New revs
Post by: Nao on February 10th, 2014, 07:44 AM
[Commit revision e68248d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 10 Feb 2014 07:44:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e68248d536a7d9f02771b7fc4abe77bba1ae60de); +0 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 10th, 2014, 11:51 AM
[Commit revision 2b8b676]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 10 Feb 2014 11:51:15 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2b8b676f9e27a3210cf16cd11a4e0d3f48060ecb); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 11th, 2014, 10:21 AM
[Commit revision 09007c2]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Feb 2014 10:20:47 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/09007c2082a6d6b5690aa9ff760dc9ced674f236); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 11th, 2014, 07:13 PM
[Commit revision ad44a98]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Feb 2014 10:22:10 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ad44a98b4754d3aec66033a8cc21e627d5b22b39); +5 (insertions), -3 (deletions)


[Commit revision 61b1aa4]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Feb 2014 19:13:01 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/61b1aa4c883c32a6e03c04cd139f828cff4aa3b9); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on February 12th, 2014, 10:35 AM
[Commit revision 40c1bdf]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Feb 2014 10:35:24 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/40c1bdfa685e3df6d7a9592ca7f5697003fc8719); +11 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on February 12th, 2014, 11:45 PM
[Commit revision 9de68b7]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Feb 2014 23:33:24 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/9de68b7fa0179d4b485fc9ef968bb689622d143c); +4 (insertions), -3 (deletions)


[Commit revision af2d910]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Feb 2014 23:45:04 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/af2d910d00e70cfe017fbda6ee480c5c6b26b666); +11 (insertions), -13 (deletions)

Title: Re: New revs
Post by: Nao on February 13th, 2014, 07:08 PM
[Commit revision 4d2a78a]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Feb 2014 14:54:53 +0100
Stats: 11 files changed(https://github.com/Wedge/wedge/commit/4d2a78ad15807a03a2c044696a349f40ca9a7791); +32 (insertions), -32 (deletions)


[Commit revision 77226ee]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Feb 2014 19:08:27 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/77226ee67f85e3055c5811782230c9d7b6cc5929); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 14th, 2014, 12:38 AM
[Commit revision a3602d9]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Feb 2014 00:38:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a3602d9cdac204ae73ddcb8d21fb2e72c1854311); +4 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on February 16th, 2014, 11:01 PM
[Commit revision 005ce99]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Feb 2014 22:51:11 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/005ce99ccff421a8dd2857358a074bf680f77389); +16 (insertions), -24 (deletions)


[Commit revision 543289e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Feb 2014 22:56:21 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/543289e383c6e19c5bf312b78a571b3c191564ed); +5 (insertions), -23 (deletions)

Title: Re: New revs
Post by: Nao on February 16th, 2014, 11:07 PM
[Commit revision c39fcc6]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Feb 2014 16:37:50 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c39fcc6ca8b2dbb339bc7f9014e247128f17b9f9); +30 (insertions), -33 (deletions)

:edit: This is a re-submitted older push. GitHub now allows me to get a list of the pushes that failed to communicate with the GitHub plugin, so until I get a more solid version of the plugin out, this will have to do!
Title: Re: New revs
Post by: Nao on February 16th, 2014, 11:09 PM
[Commit revision 2f5c4ca]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Feb 2014 16:48:48 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2f5c4caa20c064f83e4ca1d06dc8d8c8a7394e9f); +18 (insertions), -0 (deletion)


[Commit revision a0abedc]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Feb 2014 16:52:40 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a0abedcca68e4a7390936406850712bd61a484b8); +23 (insertions), -27 (deletions)


[Commit revision def73d3]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Feb 2014 22:13:44 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/def73d3e10f9380e59f47457a313233fb4d30a1f); +4 (insertions), -0 (deletion)

:edit: Another push that wasn't properly processed.
Title: Re: New revs
Post by: Nao on February 17th, 2014, 04:23 PM
[Commit revision d911448]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Feb 2014 16:13:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d911448a7815fd8466e5f385184d915e88f24930); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 17th, 2014, 11:32 PM
[Commit revision 52e4686]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Feb 2014 23:31:56 +0100
Stats: 10 files changed(https://github.com/Wedge/wedge/commit/52e468609361df10d1ac502ee012fb951faef1b6); +97 (insertions), -39 (deletions)

Title: Re: New revs
Post by: Nao on February 17th, 2014, 11:46 PM
[Commit revision d8f0e00]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Feb 2014 23:46:04 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d8f0e009d9bf8483b0936c4e98f22e989052178c); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 18th, 2014, 11:10 AM
[Commit revision cee9259]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Feb 2014 10:37:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cee9259c30b693e5795685b3290c74b1a735110e); +8 (insertions), -4 (deletions)


[Commit revision 2ec9842]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Feb 2014 11:10:19 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/2ec984261de4827bb356e2222038cbaca2e87005); +28 (insertions), -31 (deletions)

Title: Re: New revs
Post by: Nao on February 19th, 2014, 07:48 PM
[Commit revision baaa4e8]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Feb 2014 19:26:09 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/baaa4e8654f088e60783047063b4bdc56369ae83); +13 (insertions), -14 (deletions)


[Commit revision bb405ce]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Feb 2014 19:47:35 +0100
Stats: 16 files changed(https://github.com/Wedge/wedge/commit/bb405ce646c54e2ddd1728a2fff50373967d4b89); +200 (insertions), -142 (deletions)

Title: Re: New revs
Post by: Nao on February 19th, 2014, 08:50 PM
[Commit revision 50c6fca]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Feb 2014 20:50:32 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/50c6fca0d4a8bf6482de87ed0874a765847a8cbd); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 19th, 2014, 09:30 PM
[Commit revision 54a67a9]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Feb 2014 21:30:35 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/54a67a94f79c3c174b2cc6c0d7b489caff1a2d42); +4 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 19th, 2014, 11:04 PM
[Commit revision 78930ff]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Feb 2014 23:04:24 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/78930ff5362eb5ed4a8fa495cfb8835b00c41399); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 20th, 2014, 01:31 PM
[Commit revision 6fed32d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Feb 2014 11:13:50 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6fed32d3364530edd87d6be1cd03cf96db20bdc3); +40 (insertions), -39 (deletions)


[Commit revision 6207a43]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Feb 2014 11:31:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6207a43982299b5713cd1f9b0739de3f43aac99c); +1 (insertion), -1 (deletion)


[Commit revision 427c1a2]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Feb 2014 11:32:14 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/427c1a2359cb9a22f45431d7d5304433f8ea6091); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 20th, 2014, 11:17 PM
[Commit revision cf99d97]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Feb 2014 22:49:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cf99d97bcee14666a4f09d19867c6e23804fe269); +1 (insertion), -1 (deletion)


[Commit revision 7c35f7d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Feb 2014 22:50:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7c35f7d25709b21297b0b1e0d086e9b98d22784e); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 21st, 2014, 04:04 PM
[Commit revision 21457af]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Feb 2014 12:26:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/21457af3f04df2628b4afeab2e46cfd21137916d); +1 (insertion), -1 (deletion)


[Commit revision 2904574]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Feb 2014 16:03:39 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/2904574bb18593e18389dd8846bd937f279a51b4); +13 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on February 22nd, 2014, 08:58 AM
[Commit revision dae4508]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Feb 2014 08:58:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dae4508db1a8a2e722fff6e1e844160e73cf14cb); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 22nd, 2014, 06:58 PM
[Commit revision 8fe7997]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Feb 2014 18:37:44 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/8fe7997e4c50d6367801f66d329d44cd2d3f4434); +418 (insertions), -110 (deletions)


Posted: February 22nd, 2014, 06:38 PM

[Commit revision 0b47a00]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Feb 2014 18:58:04 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/0b47a009ca3ab8978670fe815c919604d163f15d); +6 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 23rd, 2014, 07:13 PM
[Commit revision 730d88b]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Feb 2014 19:13:47 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/730d88b5cec582f88d465ca4a2e9c3a228ad0ab6); +34 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on February 24th, 2014, 12:59 AM
[Commit revision 13ab30b]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Feb 2014 00:59:32 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/13ab30b44e3c3c0dd4be8573b6dff3eb1baed063); +3 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 25th, 2014, 11:14 AM
[Commit revision c690ad4]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Feb 2014 11:13:54 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c690ad4dfd4b84bf29d87ca683c4427a1dfd1822); +20 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on February 25th, 2014, 07:27 PM
[Commit revision 9859c51]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Feb 2014 18:41:46 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9859c517e4c6f471023e69b8160dafcf1b8a344a); +1 (insertion), -1 (deletion)


[Commit revision 523347b]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Feb 2014 18:43:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/523347b66858c2e65479cddeeeb5cd8120df9ca6); +9 (insertions), -8 (deletions)


[Commit revision 3b958f2]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Feb 2014 18:46:12 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3b958f2ceea0c19072e412699d5d3981388e1372); +3 (insertions), -2 (deletions)


[Commit revision 323f8b0]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Feb 2014 19:19:34 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/323f8b0e4474e5928351868f81caada955b0ced8); +11 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on February 25th, 2014, 07:47 PM
[Commit revision 7e84d56]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Feb 2014 19:47:36 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7e84d5631c4090972325a2ca63dcbaa85fdde649); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 26th, 2014, 05:43 PM
[Commit revision 6aa5451]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Feb 2014 17:42:51 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6aa54516ff89ce58e518787b0782c12dca32b42b); +21 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 26th, 2014, 11:50 PM
[Commit revision e1d820f]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Feb 2014 23:50:35 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e1d820f5965c8ef650aebebaead77c8924d30901); +34 (insertions), -33 (deletions)

Title: Re: New revs
Post by: Nao on February 27th, 2014, 12:04 AM
[Commit revision c0d39fe]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Feb 2014 00:04:32 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c0d39fedccb37b704a04d07f0f0ec6c52fd3c802); +6 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 27th, 2014, 10:12 AM
[Commit revision 7a91f08]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Feb 2014 10:12:33 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/7a91f083af0850ba86522393787ad2a9521574d3); +4 (insertions), -12 (deletions)

Title: Re: New revs
Post by: Nao on February 27th, 2014, 05:53 PM
[Commit revision 159f4bc]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Feb 2014 17:53:06 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/159f4bc886d20b108a96fabf7ce86475a1f5bc89); +21 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 27th, 2014, 06:07 PM
[Commit revision 4b1f623]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Feb 2014 18:07:21 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4b1f62333ab912300edf4d70d0fed4ecd126fa27); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 27th, 2014, 06:17 PM
[Commit revision 14d7adc]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Feb 2014 18:17:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/14d7adc5f48cce0e92c75f6fa77c5dbc1206a37f); +3 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on February 28th, 2014, 09:21 AM
[Commit revision 11bf076]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Feb 2014 09:20:28 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/11bf0767d22b13d28a1c45aab53f7ec61d7aab38); +5 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 28th, 2014, 10:47 PM
[Commit revision 770ffa1]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Feb 2014 16:00:26 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/770ffa12513e5ec1c2c3d265104c269dae693b21); +1 (insertion), -1 (deletion)


[Commit revision 8bb537d]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Feb 2014 22:47:39 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8bb537d38a2261c51b8d942cbe6d0a7caa59c313); +6 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 28th, 2014, 11:42 PM
[Commit revision d206d8c]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Feb 2014 23:42:07 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d206d8cb262d24d1ebcdf81123916bca8e499b37); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 1st, 2014, 02:28 PM
[Commit revision 8d7c216]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Mar 2014 14:04:30 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8d7c2167ed7511ea28d665be983e8af0c55c7d9b); +2 (insertions), -0 (deletion)


[Commit revision 7d5286f]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Sat, 01 Mar 2014 14:19:15 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7d5286f64a76d0e8f78dd7551898926322e4197f); +35 (insertions), -40 (deletions)

Title: Re: New revs
Post by: Nao on March 2nd, 2014, 12:31 AM
[Commit revision 14d54fd]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Mar 2014 00:31:20 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/14d54fd6ff54638d843b0e551503946224893540); +7 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 2nd, 2014, 11:52 AM
[Commit revision 9ed80bc]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Mar 2014 11:52:06 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9ed80bc6312d556445a757ff0f464b80bdbcaabf); +1 (insertion), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 2nd, 2014, 08:53 PM
[Commit revision 98c7434]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Mar 2014 20:52:40 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/98c743455316a190d2df597aa460acf9580ec3db); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 3rd, 2014, 03:48 PM
[Commit revision 77b2cd4]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Mar 2014 15:21:01 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/77b2cd4fd898e6b932926a3f5119b084d040a165); +14 (insertions), -10 (deletions)


[Commit revision 5eee68c]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Mar 2014 15:22:22 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5eee68cdf94c1e0cc95e8a92c1cf8d4ad5ada34d); +5 (insertions), -5 (deletions)


[Commit revision 43738fc]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Mar 2014 15:48:02 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/43738fc4743b90c792fba909f29e59ea2be38c32); +12 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on March 3rd, 2014, 11:01 PM
[Commit revision 244cb53]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Mar 2014 23:01:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/244cb5304552c676f783f9dd9d8bd83001bcc4e4); +0 (insertion), -16 (deletions)

Title: Re: New revs
Post by: Nao on March 4th, 2014, 12:01 AM
[Commit revision 832c0f1]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Mar 2014 00:00:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/832c0f1b3d8bf3bf773fa27bd96ed62d38c9830d); +0 (insertion), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 4th, 2014, 12:08 AM
[Commit revision e95a330]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Mar 2014 00:08:49 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e95a330c7fd6ddcdb14e290f04f7ff87f6bad7aa); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on March 4th, 2014, 12:27 AM
[Commit revision cae3ec9]
(https://avatars.githubusercontent.com/u/1857192)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Mar 2014 00:26:59 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cae3ec96e04e98bb07f2fcc318ee1b44a54ca24f); +0 (insertion), -4 (deletions)

Title: Re: New revs
Post by: Nao on March 4th, 2014, 05:03 PM
[Commit revision dd59b61]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 04 Mar 2014 17:03:14 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/dd59b6178f145a218447cdc8445fde100af319b6); +19 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on March 5th, 2014, 08:11 PM
[Commit revision ca3053c]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 05 Mar 2014 20:05:42 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ca3053cd090c4dc1c7d1d57e12cb1e9755e6a6d0); +6 (insertions), -4 (deletions)


[Commit revision 77f4d9e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 05 Mar 2014 20:11:04 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/77f4d9e6af9e3674d1643bbad6c369bfb23c3621); +9 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on March 7th, 2014, 12:03 AM
[Commit revision 8c58b91]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Mar 2014 00:03:02 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/8c58b9185d121178f0eb9de511d1fd4e8ee1eb6f); +36 (insertions), -65 (deletions)

Title: Re: New revs
Post by: Nao on March 8th, 2014, 12:48 AM
[Commit revision 383b950]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Mar 2014 23:31:50 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/383b950559491c2e0367d477a1c27e0fe2f0cfe9); +6 (insertions), -4 (deletions)


[Commit revision 8148c25]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Mar 2014 23:35:26 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8148c257e1e4471b9c4376c10a767b4d47eeb7d6); +1 (insertion), -1 (deletion)


[Commit revision 1fd0f89]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Mar 2014 00:48:00 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1fd0f899d495931766db8c77b06876792a2bcab7); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 8th, 2014, 06:56 PM
[Commit revision 984b767]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Mar 2014 18:48:54 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/984b76791ed36d061d969a207ebb8e3bfbe98076); +1 (insertion), -1 (deletion)


[Commit revision 787ef77]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Mar 2014 18:55:57 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/787ef77da016f1b5c312f54bb55ab3a8dddff2c0); +34 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on March 11th, 2014, 04:35 PM
[Commit revision 2b8ffa8]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 10 Mar 2014 20:12:36 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2b8ffa89b49e9287dfbdb362904f99c73b7009c8); +12 (insertions), -5 (deletions)


[Commit revision 0bce09e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 10 Mar 2014 21:47:47 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0bce09e6e3b986d86ed28702fa696ae93d560631); +1 (insertion), -1 (deletion)


[Commit revision ec1a335]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 14:24:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ec1a335cda151c0bb81144deea8e0c968a87a17b); +0 (insertion), -1 (deletion)


[Commit revision 9ac659a]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 14:27:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9ac659ac279f7f3edd68611b3d03cc0c329107eb); +2 (insertions), -2 (deletions)


[Commit revision 7732394]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 14:30:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7732394a9eb99800be92e1eac1b738da04f38a8d); +4 (insertions), -1 (deletion)


[Commit revision 56b79ca]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 14:36:43 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/56b79ca19e819f8744beb9b5549b5047eaad3c95); +13 (insertions), -16 (deletions)


[Commit revision a8d3e5a]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 16:02:39 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a8d3e5a8a1e39ef64d49768ff998b9fc18337c49); +7 (insertions), -6 (deletions)


[Commit revision 00ef483]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 16:22:46 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/00ef48364cd8405872892de81a9101478e33d2ae); +5 (insertions), -5 (deletions)


[Commit revision 8ac388d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 16:33:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8ac388d952cd9eb6ce8405b1343c16b3a3310ace); +18 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 11th, 2014, 07:47 PM
[Commit revision daa602b]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 18:53:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/daa602b9aa981464d76d08821df7f70a73639966); +11 (insertions), -11 (deletions)

Title: Re: New revs
Post by: Nao on March 11th, 2014, 11:33 PM
[Commit revision 3477140]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 22:15:46 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/34771404e3f3cd537388b19e6ebfb4d427eeb76a); +41 (insertions), -73 (deletions)


[Commit revision e1d608f]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Tue, 11 Mar 2014 23:33:15 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e1d608f2e37534ad2cc3f080864864f40f67b5f7); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 12th, 2014, 08:16 PM
[Commit revision 8f10d42]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Mar 2014 14:15:10 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8f10d42d3650841ea1c1b9582f0ecea21ae4ed69); +9 (insertions), -3 (deletions)


[Commit revision fa0eeeb]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Mar 2014 18:58:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fa0eeebd728444f24a0c510be0a46cd605a4c50a); +1 (insertion), -1 (deletion)


[Commit revision ccb9464]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Mar 2014 19:36:42 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ccb94646817934ac210f0d69b61224252a4ad849); +22 (insertions), -15 (deletions)

Title: Re: New revs
Post by: Nao on March 12th, 2014, 08:21 PM
[Commit revision 505a0f7]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Mar 2014 20:21:21 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/505a0f785471b564e069ed24d642a85460cbf687); +10 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on March 12th, 2014, 10:49 PM
[Commit revision bae934d]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Mar 2014 21:51:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bae934d3cfa5921a1eab4ec41b806470105cc4f3); +2 (insertions), -2 (deletions)


[Commit revision 088ef11]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Mar 2014 22:00:00 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/088ef11097e2916d09f95e77a2aba8a90f1fc6ac); +23 (insertions), -18 (deletions)

Title: Re: New revs
Post by: Nao on March 14th, 2014, 12:29 AM
[Commit revision 60af04f]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Mar 2014 12:33:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/60af04f37bce8de68eee630eac8f47aa27d675b0); +20 (insertions), -17 (deletions)


[Commit revision 3d324ed]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Mar 2014 15:52:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3d324edb84240a8c0b74602b76c370aba541e836); +2 (insertions), -2 (deletions)


[Commit revision b4fd8af]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Mar 2014 16:23:50 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b4fd8af67fe60c76c6012e6df57a0097117d44ee); +16 (insertions), -26 (deletions)


[Commit revision 42183ee]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Mar 2014 19:03:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/42183ee02707fa19a678ea1932d75ff2ffa02585); +1 (insertion), -0 (deletion)


[Commit revision 56874fd]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Thu, 13 Mar 2014 20:04:32 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/56874fdc3d3de55bee329772bdaac75c53724d65); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on March 14th, 2014, 12:31 AM
[Commit revision bbfbddb]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 00:30:55 +0100
Stats: 12 files changed(https://github.com/Wedge/wedge/commit/bbfbddbf27db31a9155c55269a20da56263250e1); +103 (insertions), -116 (deletions)

Title: Re: New revs
Post by: Nao on March 14th, 2014, 03:45 PM
[Commit revision ba2f5d8]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 11:01:03 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ba2f5d8264fc61be6ef921056c0781940c014426); +0 (insertion), -8 (deletions)


[Commit revision 7b5aeca]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 11:02:18 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7b5aeca8630fab5c1bb269d749b76d40078c28ac); +3 (insertions), -4 (deletions)


[Commit revision c421731]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 11:12:30 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c4217319d8f9bab7b764f9da0a013d21395ef430); +5 (insertions), -0 (deletion)


[Commit revision e79d0b1]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 15:19:46 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/e79d0b1ab9da175c22785935290d1edfb06df3ac); +7 (insertions), -12 (deletions)


[Commit revision 15630ef]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 15:44:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/15630ef01a2a88e02c7ab203ba8852b0e483fd20); +63 (insertions), -61 (deletions)


[Commit revision 8fe99a0]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 15:45:28 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8fe99a00b56875afb6bfa0540bedbfb73d063079); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 14th, 2014, 09:34 PM
[Commit revision 751384a]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Fri, 14 Mar 2014 21:34:00 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/751384ad305f38fa57f11b0e3decd05ff6d99d33); +5 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 15th, 2014, 10:16 AM
[Commit revision 4128eed]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 10:06:58 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4128eed7ed35e76307cd31e4653dc4ae058ea607); +1 (insertion), -1 (deletion)


[Commit revision e5d32ea]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 10:10:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e5d32ea81015bfbeb473094152110f3769365d56); +2 (insertions), -3 (deletions)


[Commit revision 8d76189]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 10:15:56 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/8d76189d9556ea81ed7580e5334efa406dbdb473); +24 (insertions), -11 (deletions)

Title: Re: New revs
Post by: Nao on March 15th, 2014, 06:16 PM
[Commit revision 59cb728]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 18:08:53 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/59cb7286348334c6e0e012f666bd867a39470986); +9 (insertions), -19 (deletions)


[Commit revision 00ddf19]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 18:11:18 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/00ddf19fd666855fcb5e0139ec1846197fe66e07); +4 (insertions), -4 (deletions)


[Commit revision 133e7d8]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 18:14:47 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/133e7d82c2f469e648c1d21337563a9c04757223); +6 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 16th, 2014, 12:20 AM
[Commit revision e27bd50]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sat, 15 Mar 2014 20:35:12 +0100
Stats: 14 files changed(https://github.com/Wedge/wedge/commit/e27bd502e98d6b0922b5ebe00b7ff4e3a611cdbe); +18 (insertions), -19 (deletions)


[Commit revision 53fcfe9]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 00:20:02 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/53fcfe97baca09daf29e7498adf3a3a238fc8441); +3 (insertions), -22 (deletions)

Title: Re: New revs
Post by: Nao on March 16th, 2014, 08:12 PM
[Commit revision 4f321a2]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 20:12:40 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/4f321a2f9a01cc2b3ec86e9b5df151db518b6c8c); +38 (insertions), -29 (deletions)

Title: Re: New revs
Post by: Nao on March 16th, 2014, 10:50 PM
[Commit revision e340092]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:10:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e340092298f918f22d190fb193e1804e9af6252d); +1 (insertion), -1 (deletion)


[Commit revision 0dd259e]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:24:54 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0dd259e19975158fa9f0f38c3ddfbdca2ea89657); +64 (insertions), -60 (deletions)


[Commit revision 303eba2]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:28:10 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/303eba2d36476cce88cc783be066b683778f6154); +3 (insertions), -3 (deletions)


[Commit revision 690f5b5]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:43:54 +0100
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/690f5b5745dbd2d68ea94e6d338990e09fcc67b1); +42 (insertions), -68 (deletions)


[Commit revision 232bf29]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:44:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/232bf2915a3daf794cd3c3020e9ed9f24a24584d); +1 (insertion), -1 (deletion)


[Commit revision ba10fd6]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:45:17 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ba10fd6a550ddb0ade5d6b090ef3baac3a7f187f); +0 (insertion), -3 (deletions)


[Commit revision cde49dd]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Mar 2014 22:46:16 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cde49ddceadfe1e9b964e9794a4cac969cff748b); +9 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on March 16th, 2014, 11:04 PM
Note: I've only committed about 2/3 of my current hard-coding rewrite, the rest needs more work but it works on my local install. However, since it's not 100% guaranteed to work and I'm too tired to finish my work tonight, I *DO NOT* recommend upgrading to the latest commits. Stick to 303eba2(https://github.com/Wedge/wedge/tree/303eba2d36476cce88cc783be066b683778f6154) (dated 22:08) if you want to be up to date.

Note 2: this is the first time in years I'm posting a message that's not a changelog... Don't be surprised, though -- ever since I switched to git, I've slowly started adopting the 'git flow' of committing often, and separating smaller commits into chunks rather than grouping them all thematically, like I used to do. You may like it better or less, it doesn't matter, it is how it is. :P
Title: Re: New revs
Post by: Nao on March 17th, 2014, 03:24 PM
[Commit revision 47061f5]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Mar 2014 15:24:09 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/47061f5fb32592f520add3106d4156016e248711); +11 (insertions), -8 (deletions)

Title: Re: New revs
Post by: Nao on March 17th, 2014, 05:45 PM
[Commit revision bb2f039]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Mar 2014 17:43:27 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bb2f0391066eaf96c775b6a26adf225b5ded90f3); +3 (insertions), -3 (deletions)


Posted: March 17th, 2014, 05:43 PM

[Commit revision 6993896]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Mar 2014 17:44:52 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/69938965e2e6b864e9204fce61127e0cedaaf43d); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 17th, 2014, 07:57 PM
[Commit revision ab4c495]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Mar 2014 19:56:55 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/ab4c495120771b44f94fc146eee653e9d10e8a69); +212 (insertions), -199 (deletions)

Title: Re: New revs
Post by: Nao on March 17th, 2014, 11:18 PM
[Commit revision bfb804f]
(https://gravatar.com/avatar/0879c588019800e5349fe171d69e1c28?d=https%3A%2F%2Fidenticons.github.com%2Fa77898357042a3151178ee5ac33742a6.png&r=x)Author: Nao(https://github.com/Nao)
Date: Mon, 17 Mar 2014 23:17:16 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bfb804f407ca48e4772121a178bf6409b4fb17ce); +2 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on March 18th, 2014, 08:06 PM
[Commit revision 577a103]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Mar 2014 13:00:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/577a10313530fed4f0969b7da42e25bafa222e5b); +7 (insertions), -1 (deletion)


[Commit revision 043f72c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Mar 2014 13:02:15 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/043f72c9400fcfe1270fd21a122bc0e4e67df043); +6 (insertions), -2 (deletions)


[Commit revision b19e3d9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Mar 2014 18:48:12 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b19e3d9454a85b6628e9a1aab2d007254312485b); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on March 19th, 2014, 07:37 PM
[Commit revision 98cd9cf]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 15:55:46 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/98cd9cff7633a305f0a6d99dfd3bef9607bdc071); +7 (insertions), -16 (deletions)


[Commit revision 4e06a33]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 15:59:59 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4e06a33d7421bc1e3f5eed85ecde02734265d133); +0 (insertion), -3 (deletions)


[Commit revision e6872cb]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 17:54:01 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/e6872cbff325c14eb59d99e03e2f64ff85f812cd); +8 (insertions), -24 (deletions)


[Commit revision d5e9c81]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 17:56:19 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d5e9c81d24e0fddcaa2f66e6b5bf95158f387716); +3 (insertions), -8 (deletions)


[Commit revision 1910c57]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 19:22:53 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/1910c577dc59fc4005be0f0217efaf476bf041cb); +18 (insertions), -13 (deletions)


[Commit revision 1015ede]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 19:33:55 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/1015edeefb0bbe04c08d0b859ac28f576c20b6d8); +36 (insertions), -42 (deletions)


[Commit revision 667669a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Mar 2014 19:37:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/667669adebc7fb4fdc4d4cf7f772051bbeac00be); +71 (insertions), -75 (deletions)

Title: Re: New revs
Post by: Nao on March 20th, 2014, 05:22 PM
[Commit revision b8ffdee]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Mar 2014 16:27:47 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b8ffdeec9528e0bca76b0141c950a3e942924adb); +4 (insertions), -4 (deletions)


[Commit revision 3969e46]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Mar 2014 17:22:40 +0100
Stats: 12 files changed(https://github.com/Wedge/wedge/commit/3969e465c039a6da5be426784230c805a9adb44e); +179 (insertions), -225 (deletions)

Title: Re: New revs
Post by: Nao on March 20th, 2014, 06:18 PM
[Commit revision fde20c5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Mar 2014 18:17:00 +0100
Stats: 10 files changed(https://github.com/Wedge/wedge/commit/fde20c530bab777e8d27830929d7ee33edc793dc); +8 (insertions), -79 (deletions)

Title: Re: New revs
Post by: Nao on March 21st, 2014, 12:03 AM
[Commit revision 40bd3a9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 00:01:56 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/40bd3a919410532929579fd5ea0f58cd24b8b77e); +2 (insertions), -2 (deletions)


[Commit revision f14bb09]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 00:02:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f14bb091ca4d218413cbd8b8319f7d86c57fa35e); +1 (insertion), -1 (deletion)


[Commit revision 449e8d2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 00:03:13 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/449e8d2d653b32f07c97722b2fe2e7d0fded3cd7); +3 (insertions), -18 (deletions)

Title: Re: New revs
Post by: Nao on March 21st, 2014, 11:23 AM
[Commit revision 317f05d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 11:22:59 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/317f05d33ace74591cc274f0b7a4d65c705eaa18); +1 (insertion), -7 (deletions)

Title: Re: New revs
Post by: Nao on March 21st, 2014, 06:39 PM
[Commit revision 67effb0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 14:33:45 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/67effb00a8319eef3eb39ddc70f71ca936baa72c); +5 (insertions), -10 (deletions)


[Commit revision 633dc11]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 14:54:32 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/633dc1141adaf4a398f21119aca1d48455b30aa0); +118 (insertions), -3 (deletions)


[Commit revision d9766ea]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 15:22:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d9766eabe55da5707a38a227081cf982905d8402); +25 (insertions), -46 (deletions)


[Commit revision 033c80b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 16:31:33 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/033c80b9181e2cb3fe7fbb90265922f866f947ad); +1 (insertion), -1 (deletion)


[Commit revision 406792e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 18:08:03 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/406792e99561cd604f7df04160fa7e5d97a18995); +5 (insertions), -17 (deletions)


[Commit revision 2fd73a1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 18:11:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2fd73a1493a543937dbe8b1e2709789a3948d267); +1 (insertion), -0 (deletion)


[Commit revision 6d9bc44]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 18:32:33 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6d9bc44550c4001ab3d8a9e1a3dd1b753035b1bf); +2 (insertions), -2 (deletions)


[Commit revision 5786abc]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 18:33:17 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5786abc07d4d66fdd380ccc21632a7e9ecf26dbf); +2 (insertions), -1 (deletion)


[Commit revision 8e1006b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 18:38:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8e1006b507727c7e6dec7c5ec3054f45b67391d6); +0 (insertion), -4 (deletions)

Title: Re: New revs
Post by: Nao on March 21st, 2014, 11:22 PM
[Commit revision 343b3b5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 18:40:48 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/343b3b5bf3a2bbdb25468a58b84dfaa7136bc000); +3 (insertions), -3 (deletions)


[Commit revision df03738]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 23:18:28 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/df037380f9e84657997c60f08e73eab6a254a6e7); +4 (insertions), -2 (deletions)


[Commit revision a41a40e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Mar 2014 23:22:02 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/a41a40e5a2b5cfeed374091545cf98b44781cf9c); +14 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on March 22nd, 2014, 11:57 PM
[Commit revision e9aa26f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Mar 2014 15:37:06 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e9aa26ff6a6eee9eea95a835ddfb4a83a35be06d); +153 (insertions), -148 (deletions)


[Commit revision dd5104e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Mar 2014 19:26:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dd5104e1dd348a4c3baa9d7bd95e494ce8c2a862); +1 (insertion), -1 (deletion)


[Commit revision 8da1e80]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Mar 2014 19:27:48 +0100
Stats: 14 files changed(https://github.com/Wedge/wedge/commit/8da1e8078ffc9345e4b5213945bc33215d20ef38); +64 (insertions), -76 (deletions)


[Commit revision 383b164]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Mar 2014 23:51:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/383b164e31f617f8a93c72ebfe4753ddbfd49bbc); +1 (insertion), -3 (deletions)


[Commit revision 72b65af]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Mar 2014 23:52:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/72b65afb8e15c77da7417b459f97a42a7a687263); +3 (insertions), -2 (deletions)


Posted: March 22nd, 2014, 11:53 PM

[Commit revision b79f3d6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Mar 2014 23:57:08 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b79f3d67db73dc4cb2c1ec7f04f7688a28575e67); +2 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on March 23rd, 2014, 08:24 PM
[Commit revision 7c3a6b3]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 16:21:49 +0100
Stats: 14 files changed(https://github.com/Wedge/wedge/commit/7c3a6b3a4835820a81cc9dd640c2d4d2455aa625); +67 (insertions), -79 (deletions)


[Commit revision 599afb6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 20:04:42 +0100
Stats: 16 files changed(https://github.com/Wedge/wedge/commit/599afb60689ac7a8eed0406e64e44bd39f984230); +66 (insertions), -70 (deletions)


[Commit revision d287660]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 20:24:04 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d2876609a0a68864272b6f38083759a68aab64e1); +24 (insertions), -53 (deletions)

Title: Re: New revs
Post by: Nao on March 23rd, 2014, 08:46 PM
[Commit revision da5af8c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 20:31:07 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/da5af8cacc64849735eac3c6eaf58f09aefe79b8); +2 (insertions), -116 (deletions)


[Commit revision 253119c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 20:32:37 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/253119c27a7908c371e335231522ad6f817f270d); +0 (insertion), -5 (deletions)


[Commit revision 36986c1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 20:46:14 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/36986c103c010fef6d689069c2c6c6ae0ca1fed1); +41 (insertions), -48 (deletions)

Title: Re: New revs
Post by: Nao on March 23rd, 2014, 08:56 PM
[Commit revision 85c6339]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Mar 2014 20:55:50 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/85c6339717260b1d22f4489eaf3b856e6fd7ae31); +19 (insertions), -24 (deletions)

Title: Re: New revs
Post by: Nao on March 24th, 2014, 06:41 PM
[Commit revision 9ac202a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Mar 2014 18:30:43 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9ac202aca8579ae8c2800281cb6bd095d1311064); +1 (insertion), -1 (deletion)


[Commit revision fc2ba13]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Mar 2014 18:35:07 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/fc2ba13d74df7f1f0f77e030090bdef44cf20255); +25 (insertions), -27 (deletions)


[Commit revision 65a4fcb]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Mar 2014 18:40:37 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/65a4fcbb9095aea53a529d7f9ccd5002688993d4); +4 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on March 24th, 2014, 07:41 PM
[Commit revision 0c03c5d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Mar 2014 19:39:37 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/0c03c5d0bec963a27bf587b893130fae68a35d8e); +5 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on March 25th, 2014, 10:16 AM
[Commit revision 962885b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Mar 2014 10:16:38 +0100
Stats: 18 files changed(https://github.com/Wedge/wedge/commit/962885bdb34e30ac0f8e7035e70b5e4543b29ef5); +63 (insertions), -66 (deletions)

Title: Re: New revs
Post by: Nao on March 25th, 2014, 07:50 PM
[Commit revision 0b5bc99]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Mar 2014 10:23:15 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/0b5bc9929f5556097cc3f37e8d14cf5456811941); +18 (insertions), -7 (deletions)


[Commit revision 61f16c8]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Mar 2014 17:40:22 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/61f16c8991bcd1ef6052585bf0a771bdc3f85260); +2 (insertions), -2 (deletions)


[Commit revision c38bfa9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Mar 2014 19:48:21 +0100
Stats: 12 files changed(https://github.com/Wedge/wedge/commit/c38bfa93b3e65b375e17bd9e884ca3d5fb588865); +41 (insertions), -53 (deletions)


[Commit revision 7b6c637]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Mar 2014 19:50:03 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7b6c637b07f01b44865b412d43b1cab87f7fab0b); +2 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 26th, 2014, 02:12 PM
[Commit revision ffe7887]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Mar 2014 23:23:23 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ffe7887fddda6eeb2199f6cc9481f60f1d99d425); +4 (insertions), -3 (deletions)


[Commit revision a0d9cf7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 13:57:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a0d9cf757af8111252144b0ec1cde49d4c765b47); +16 (insertions), -8 (deletions)


[Commit revision 8f5284f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 14:00:25 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/8f5284f58a1a845e88e2ae2f7327f41725e77776); +14 (insertions), -19 (deletions)


Posted: March 26th, 2014, 02:00 PM

[Commit revision 3b9c7ed]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 14:11:57 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/3b9c7edec0fefc881b6ba0e979eb547457c19cd1); +7 (insertions), -25 (deletions)

Title: Re: New revs
Post by: Nao on March 26th, 2014, 05:41 PM
[Commit revision d17fae9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 17:20:43 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/d17fae953b8839b181e9937e52e20aefeae62967); +40 (insertions), -34 (deletions)

Title: Re: New revs
Post by: Nao on March 26th, 2014, 07:51 PM
[Commit revision e74c00b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 19:48:26 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e74c00b9263cae83b02f009453bf744a66f85ca6); +45 (insertions), -1 (deletion)


[Commit revision e48c3ee]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 19:51:00 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e48c3ee682b35912a8ca20a437c4dcedb72f8f89); +15 (insertions), -54 (deletions)

Title: Re: New revs
Post by: Nao on March 26th, 2014, 10:42 PM
[Commit revision c704a26]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 22:29:40 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c704a263ba2b7980f62a79962f869d63c05851c6); +1 (insertion), -1 (deletion)


[Commit revision de050eb]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 22:33:26 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/de050eb2579b5919cc0e40734bab560f4bbb5ab1); +31 (insertions), -24 (deletions)


[Commit revision c1f38d8]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 22:40:38 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/c1f38d8fa7fe8b65aed2ae63737c40fae2bdf3b2); +56 (insertions), -56 (deletions)

Title: Re: New revs
Post by: Nao on March 26th, 2014, 11:27 PM
[Commit revision b46d62f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Mar 2014 23:26:57 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b46d62f6e33c3273bdc72d2f59dd41f73f9831b0); +2 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 27th, 2014, 11:38 AM
[Commit revision 928f869]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 11:38:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/928f8699708295ca02197de6ef744215c3fbb069); +5 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 27th, 2014, 04:41 PM
[Commit revision b1a1086]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 12:04:04 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b1a1086b706523e5305c2c76f6826d2d0684356a); +4 (insertions), -8 (deletions)


[Commit revision 70d4775]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 15:52:08 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/70d4775cc87fdb9f2edd4605278feeb15f358416); +7 (insertions), -7 (deletions)


[Commit revision bfecbba]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 16:35:07 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bfecbbaee3c1f62f0b8206a1e224d9c011613cbc); +6 (insertions), -0 (deletion)


[Commit revision 3f1acd5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 16:40:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3f1acd5e1ac8abb9323a364f9b639c60511ac944); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on March 27th, 2014, 06:30 PM
[Commit revision 0ad741a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 18:30:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0ad741a2a8be864d50e1a4bdcf349d0b82cf475a); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on March 27th, 2014, 08:16 PM
[Commit revision 93ae09c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 27 Mar 2014 20:16:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/93ae09c97e48f457ce0969921364a982c21263f0); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 28th, 2014, 09:59 AM
[Commit revision f609e91]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Mar 2014 09:55:16 +0100
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/f609e917dbd26a5f60dd1471397e9db8f4ae03c8); +17 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 28th, 2014, 11:06 PM
[Commit revision 7d8f681]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Mar 2014 18:27:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7d8f6816385eab2570fa93ec9111672ad006a2d3); +1 (insertion), -1 (deletion)


[Commit revision 3673754]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 28 Mar 2014 21:20:42 +0100
Stats: 11 files changed(https://github.com/Wedge/wedge/commit/36737548f107d51eba557faa0e9978342e4fb7ca); +26 (insertions), -118 (deletions)

Title: Re: New revs
Post by: Nao on March 30th, 2014, 12:41 AM
[Commit revision da98ab2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 29 Mar 2014 15:21:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/da98ab2a4112887685676fc1a1f35edba999b436); +1 (insertion), -1 (deletion)


[Commit revision 7c36c80]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 29 Mar 2014 19:37:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7c36c80c55ca2ba2474590377a5cf8fcff1d8f4a); +0 (insertion), -1 (deletion)


[Commit revision b7aa32d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 29 Mar 2014 20:23:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b7aa32d31246bbcfac6b2d021f93f3af488d661c); +19 (insertions), -45 (deletions)


[Commit revision 57328c4]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 29 Mar 2014 20:24:56 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/57328c406007f22c89efb4e17386682889d47993); +20 (insertions), -17 (deletions)


[Commit revision b0db1d0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 29 Mar 2014 20:31:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b0db1d096902c4494edd34425ecb37c3389e411c); +4 (insertions), -12 (deletions)

Title: Re: New revs
Post by: Nao on March 30th, 2014, 12:52 AM
[Commit revision da7e415]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 30 Mar 2014 00:43:09 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/da7e415bba70429e82d0bd65061103119f88f302); +3 (insertions), -7 (deletions)


[Commit revision 5ed43d4]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 30 Mar 2014 00:43:57 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5ed43d41d4801b1a4d4e0157c0ad09a2c8d1ad32); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 30th, 2014, 11:24 PM
[Commit revision bf04bdc]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 30 Mar 2014 23:24:11 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/bf04bdca336de69f8dcea1d158e882d0ac9b8f6f); +19 (insertions), -20 (deletions)

Title: Re: New revs
Post by: Nao on March 31st, 2014, 04:26 PM
[Commit revision 187bcbc]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 31 Mar 2014 15:58:34 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/187bcbc17f464e27b0512327f138d331588db53a); +47 (insertions), -31 (deletions)


Posted: March 31st, 2014, 03:58 PM

[Commit revision 200556a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 31 Mar 2014 16:26:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/200556ac20e392c8cc32960212a8b32bdf1757ba); +24 (insertions), -28 (deletions)

Title: Re: New revs
Post by: Nao on March 31st, 2014, 10:24 PM
[Commit revision 993d2f0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 31 Mar 2014 22:08:26 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/993d2f02baab7ebf2cd243e5c50b823e10ad86b6); +10 (insertions), -19 (deletions)


[Commit revision 6b1a53d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 31 Mar 2014 22:23:57 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6b1a53d4acba4d35f9747409f44d22a1107578d3); +27 (insertions), -25 (deletions)

Title: Re: New revs
Post by: Nao on April 1st, 2014, 08:04 PM
[Commit revision b24e313]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 31 Mar 2014 22:57:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b24e3131eb87268c3c526a916282405c23449a89); +31 (insertions), -22 (deletions)


[Commit revision 8989d5a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 01 Apr 2014 15:46:00 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8989d5add419735a7d5cc4ea765928daa0a83d4a); +5 (insertions), -5 (deletions)


[Commit revision eda89f6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 01 Apr 2014 15:57:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/eda89f63290ab2300fa9c9788f44dc4b258fdac7); +12 (insertions), -12 (deletions)


[Commit revision ca579ed]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 01 Apr 2014 18:48:38 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ca579ed20d41280b157b2c8a74ddd415f994b615); +7 (insertions), -3 (deletions)


[Commit revision bceb12e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 01 Apr 2014 19:47:13 +0200
Stats: 16 files changed(https://github.com/Wedge/wedge/commit/bceb12e24eb705465a509fe1314c76b41adfecf9); +82 (insertions), -257 (deletions)


Posted: April 1st, 2014, 07:48 PM

[Commit revision 8cb1a75]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 01 Apr 2014 20:03:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8cb1a759879e3f872f82db81e74ffe33ae4a0289); +0 (insertion), -4 (deletions)

Title: Re: New revs
Post by: Nao on April 2nd, 2014, 11:36 PM
[Commit revision 3d8ce55]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 02 Apr 2014 12:10:33 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3d8ce553c459e8db0b5d8e018b59b607bef07853); +7 (insertions), -2 (deletions)


[Commit revision d0fba41]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 02 Apr 2014 14:16:29 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d0fba41035329cb984b71213f8cef1a5eb1498f0); +6 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on April 2nd, 2014, 11:41 PM
[Commit revision bf33fa8]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 02 Apr 2014 23:40:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bf33fa8bf4a9346100d4299de09296e34801cf58); +8 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on April 3rd, 2014, 04:33 PM
[Commit revision 3ad1ee1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 03 Apr 2014 16:07:51 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/3ad1ee11d78b944939c3b20dedd77cec7d3f5c1e); +1 (insertion), -5 (deletions)


[Commit revision 32d8862]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 03 Apr 2014 16:10:04 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/32d88627e9e81bd845d25602fe8d5c74b6aadac4); +37 (insertions), -25 (deletions)

Title: Re: New revs
Post by: Nao on April 4th, 2014, 08:54 PM
[Commit revision 3b1c3ed]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 04 Apr 2014 19:52:16 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3b1c3ed70ab144846a2e1bd2d8a1e529411ad912); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on April 4th, 2014, 11:45 PM
[Commit revision ba2d42e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 04 Apr 2014 22:54:26 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ba2d42ee13c9606e216bec14638598472d1052d7); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on April 5th, 2014, 10:45 PM
[Commit revision 06b0b02]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Apr 2014 16:36:29 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/06b0b0217d663194bf0ec67b5579d2dc5c6d0b67); +11 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on April 6th, 2014, 12:02 AM
[Commit revision 03f7a7a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Apr 2014 23:15:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/03f7a7a5b83ec82bcfa7b76d1d79635b0b5b9968); +11 (insertions), -11 (deletions)


[Commit revision 02dd052]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Apr 2014 23:52:02 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/02dd0528d5d9020eb6feefcdda0ebf90759b824d); +28 (insertions), -45 (deletions)


Posted: April 5th, 2014, 11:52 PM

[Commit revision 2c1d301]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Apr 2014 23:56:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2c1d301fa66b1b7a5e7e350a9c744a33b4f8918a); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 8th, 2014, 01:04 PM
[Commit revision 7126453]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Apr 2014 13:03:41 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/71264531ff8d4c8f9785388de0a65c9e80f619c6); +32 (insertions), -15 (deletions)

Title: Re: New revs
Post by: Nao on April 8th, 2014, 08:53 PM
[Commit revision bf05128]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Apr 2014 13:10:24 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bf05128fe6269c67faa4ec6bd1d486a55ae2024f); +1 (insertion), -0 (deletion)


[Commit revision 82b70d0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Apr 2014 20:53:28 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/82b70d0a6895a37adf0177cc6025b345483b72eb); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 9th, 2014, 12:12 PM
[Commit revision ed0baed]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 09 Apr 2014 12:08:36 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ed0baeded6aeebbcc30a59b5752a59bad13e9687); +4 (insertions), -7 (deletions)


[Commit revision b3effe6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 09 Apr 2014 12:12:42 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b3effe6a9e70fb2508e480a1601bc158dbf33262); +10 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on April 12th, 2014, 12:17 AM
[Commit revision 9bf4a22]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 10 Apr 2014 16:10:53 +0200
Stats: 18 files changed(https://github.com/Wedge/wedge/commit/9bf4a224b64c8633eaa6dc99ac1c06d69117bbc3); +40 (insertions), -40 (deletions)


[Commit revision 0b9053c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 10 Apr 2014 19:50:16 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/0b9053c9c5fe9a06ecd6f7c5e284bdb36db0ef14); +15 (insertions), -16 (deletions)


[Commit revision 51fe74e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 12 Apr 2014 00:15:29 +0200
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/51fe74eac4dade8e37fab86c334898bcd025e0a1); +98 (insertions), -20 (deletions)

 1. Accessed from the Pretty URLs settings page.
Title: Re: New revs
Post by: Nao on April 14th, 2014, 01:19 PM
[Commit revision d33f13e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 14 Apr 2014 13:12:40 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/d33f13e5087c7239f78dfecb070e78dd48b066f4); +66 (insertions), -50 (deletions)


[Commit revision 4f9eed5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 14 Apr 2014 13:16:19 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/4f9eed5637b2e45c6bd4e23627cc8a9fffa8774b); +9 (insertions), -13 (deletions)

Title: Re: New revs
Post by: Nao on April 15th, 2014, 07:52 AM
[Commit revision f2e5083]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 14 Apr 2014 15:37:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f2e5083c796b1539238cd15b0019274f23f39d33); +0 (insertion), -3 (deletions)


[Commit revision c5cc16b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 14 Apr 2014 15:50:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c5cc16b48a91cc613f7489f2ccbef7495a7e3794); +1 (insertion), -1 (deletion)


[Commit revision 9a0acc7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 15 Apr 2014 07:51:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9a0acc770900be61e9deddf14bd0e9bc80e775a7); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on April 16th, 2014, 04:01 PM
[Commit revision 098baa6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 15 Apr 2014 16:57:06 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/098baa6e34a0370df89ef2e462684015d695ff3d); +2 (insertions), -2 (deletions)


[Commit revision c8c729a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 16 Apr 2014 15:14:03 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/c8c729a28a85b0c3e813895623b31926e3ebe623); +36 (insertions), -22 (deletions)


[Commit revision df71a73]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 16 Apr 2014 15:44:27 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/df71a73ca6e439e7f2e715f736f557cceeb9a7da); +15 (insertions), -14 (deletions)


[Commit revision ee725cb]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 16 Apr 2014 15:50:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ee725cbe0d146fd0f88a6a0bc0f4b4421665fc92); +16 (insertions), -7 (deletions)


[Commit revision 669bd34]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 16 Apr 2014 16:00:10 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/669bd346f2da8974053a0087177f273428870c5a); +6 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 16th, 2014, 10:48 PM
[Commit revision 65a3af1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 16 Apr 2014 22:47:18 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/65a3af1ffd59619d8194996266e6bae26fdf83f6); +35 (insertions), -45 (deletions)

Title: Re: New revs
Post by: Nao on April 16th, 2014, 11:24 PM
[Commit revision 2d719c5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 16 Apr 2014 23:24:05 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/2d719c5812054b51cc6d9e0d468e7aa4cc44a662); +5 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on April 17th, 2014, 11:28 AM
[Commit revision 41f2f76]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 09:24:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/41f2f7616a3a10da4e24ad69da9ce24a9d1af6b7); +10 (insertions), -4 (deletions)


[Commit revision ce02927]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 09:26:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ce02927728e059a63b5fbe9547296bd9ce5b8a9d); +2 (insertions), -1 (deletion)


[Commit revision 9a04e58]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 09:28:47 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9a04e58d07cf162d42cec14d6b4e92f44dc55cbd); +3 (insertions), -4 (deletions)


[Commit revision 69b712f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 09:48:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/69b712fc33f24e459a410225bf5f5f5f6b13e7ad); +1 (insertion), -1 (deletion)


[Commit revision 7908c13]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 11:28:12 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/7908c139900afb8c4d1106d4d59ac862cb651be9); +22 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on April 17th, 2014, 03:15 PM
[Commit revision cd033a7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 15:15:18 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cd033a767b447bf770f824a1934c9a2ec3434a25); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on April 17th, 2014, 11:22 PM
[Commit revision 91fcd11]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 17 Apr 2014 23:22:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/91fcd11d968dbb7184b88ab54d2a0088e02e3e72); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 20th, 2014, 09:06 AM
[Commit revision c8509e4]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 20 Apr 2014 09:06:34 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c8509e47d1eafa1a6f615f407320917fb9bad3a5); +24 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on April 21st, 2014, 01:41 PM
[Commit revision a1cf8ad]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 21 Apr 2014 13:28:46 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/a1cf8ad10df385be798caa0844aa4a227d6d0da1); +30 (insertions), -4 (deletions)


[Commit revision 810aaf4]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 21 Apr 2014 13:30:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/810aaf4672b56e5d4c5f647a6e9debfdf97a32ac); +11 (insertions), -0 (deletion)


[Commit revision 540a1d6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 21 Apr 2014 13:33:36 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/540a1d617d03ff33bf2a9cb65cf3d7044d242f34); +10 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on April 21st, 2014, 01:48 PM
[Commit revision fd1be2b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 21 Apr 2014 13:48:39 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fd1be2bfaace59fb889621409e78654623b4385e); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on April 27th, 2014, 12:40 AM
[Commit revision 92abd1e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 26 Apr 2014 22:31:37 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/92abd1e805785291e89a76387940fc0a8ba2e406); +14 (insertions), -14 (deletions)

Title: Re: New revs
Post by: Nao on April 27th, 2014, 09:43 PM
[Commit revision e7aba9a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 27 Apr 2014 21:26:41 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e7aba9a89a5e1017001675da9f5ca1ada203217c); +0 (insertion), -0 (deletion)


[Commit revision 9c9f2fb]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 27 Apr 2014 21:43:40 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/9c9f2fb6e7104d2d1b270588ae032da63d1041ed); +46 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on April 27th, 2014, 11:22 PM
[Commit revision 5716bc8]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 27 Apr 2014 23:21:10 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/5716bc88570f68aad8758d20ca35b79d96a9295a); +2 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on April 29th, 2014, 11:24 PM
[Commit revision 5882048]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 28 Apr 2014 22:55:00 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5882048007d987f3c0553a9316c86da2019a1e60); +3 (insertions), -2 (deletions)


[Commit revision 3e63b75]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 29 Apr 2014 23:23:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3e63b752d0cd15cdfb7cdf1aeab70746bb80ab0c); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on April 30th, 2014, 07:04 PM
[Commit revision 9965000]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 30 Apr 2014 19:03:21 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/99650008c9d0d08f97eb3e05b08fd73bcfca06ad); +2 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on May 1st, 2014, 10:36 PM
[Commit revision f85e1b2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 01 May 2014 22:11:37 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f85e1b263efbd1d223a06e9b72485c0b8b90cf22); +65 (insertions), -51 (deletions)

Title: Re: New revs
Post by: Nao on May 1st, 2014, 10:57 PM
[Commit revision a4a1400]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 01 May 2014 21:36:50 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a4a1400dcc5bb982085163a3dc64be48bc1a3877); +3 (insertions), -2 (deletions)


[Commit revision e739d0b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 01 May 2014 21:42:48 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e739d0bcfc4d9d47a134681aaedc87f02e1f47b8); +63 (insertions), -42 (deletions)

Title: Re: New revs
Post by: Nao on May 1st, 2014, 11:03 PM
Quote from Nao on April 30th, 2014, 07:04 PM
[Commit revision 9965000]
What are the odds that a github commit hash will have ONLY numbers in it, AND that the hash ends in three consecutive zeroes??!!
Amazing. About one chance out of 30.000, if I'm not mistaken! = 1/(((10/16)^7)/1000)
Title: Re: New revs
Post by: Nao on May 3rd, 2014, 10:12 AM
[Commit revision abc9cc7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 10:12:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/abc9cc7a18738472f37e118982ac83bf353a9bd4); +25 (insertions), -25 (deletions)

Title: Re: New revs
Post by: Nao on May 3rd, 2014, 10:40 PM
[Commit revision b3fc536]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 16:51:21 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b3fc53625f8c8c29b2600e4a898ac509bed1ea57); +1 (insertion), -1 (deletion)


[Commit revision 45842d7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 17:06:30 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/45842d79973a345762f818eaa01b08bc3d57a834); +0 (insertion), -6 (deletions)


[Commit revision 6825418]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:24:59 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/6825418d61784b8a9049228f36fafc5bc65dbfa6); +46 (insertions), -14 (deletions)


[Commit revision ddaddb7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:25:55 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ddaddb7e17605108c8c1ada8166b9026f527aa35); +6 (insertions), -0 (deletion)


[Commit revision 59677fe]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:27:46 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/59677fe66d390190eb3ad68527b90c32304f8835); +1 (insertion), -1 (deletion)


[Commit revision 8405861]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:28:41 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/84058613a2a81036d0adfaae7373fa6310c9ed47); +4 (insertions), -4 (deletions)


[Commit revision f2a8a51]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:29:30 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f2a8a51626a1d07bc9d06b01275f101ad61c5166); +1 (insertion), -1 (deletion)


[Commit revision 911e2de]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:30:18 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/911e2de865a8e5b38be76bbd64e5709d5bda0149); +1 (insertion), -1 (deletion)


[Commit revision 7184f6e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:31:29 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7184f6e0e0516dbb70d92e69769bdde832912001); +2 (insertions), -3 (deletions)


[Commit revision 4fec31c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:38:03 +0200
Stats: 9 files changed(https://github.com/Wedge/wedge/commit/4fec31c79c3bc31b7af604554063580dedbd66bf); +206 (insertions), -176 (deletions)


[Commit revision 3de1dfb]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 03 May 2014 22:39:17 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3de1dfb6911bcce0650cceb090a28dc770b4b170); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 6th, 2014, 12:10 PM
[Commit revision 39591f6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 12:10:03 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/39591f6d88e5db09a906210fc191b08c7f0c020c); +31 (insertions), -34 (deletions)

Title: Re: New revs
Post by: Nao on May 6th, 2014, 12:55 PM
[Commit revision 704e222]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 12:50:46 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/704e2227a8dc540dc82c9a856b8a0872125e3953); +14 (insertions), -3 (deletions)


[Commit revision 031469d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 12:53:58 +0200
Stats: 10 files changed(https://github.com/Wedge/wedge/commit/031469d87b96fc2b8ae1dc6fa576acd257ff9fef); +164 (insertions), -127 (deletions)


[Commit revision 8dec85f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 12:55:35 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8dec85f93ce70d82d7e3217a868182b9e4ec99f1); +1 (insertion), -6 (deletions)

Title: Re: New revs
Post by: Nao on May 6th, 2014, 06:47 PM
[Commit revision 1dea450]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 18:44:07 +0200
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/1dea450c6f4772eb31b7f3ba1fdfdcc592a3aa3f); +0 (insertion), -39 (deletions)


[Commit revision 4bc6b0b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 18:44:29 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/4bc6b0b1d8ad1aef03a0d058d781e885213da57c); +0 (insertion), -16 (deletions)


[Commit revision 6be62d4]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 18:45:16 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6be62d4089b1cd8a5b534a13064b0c63611734d1); +0 (insertion), -4 (deletions)


[Commit revision f007676]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 06 May 2014 18:47:30 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f007676bb2027a29c34170b21ef4361e081f6454); +43 (insertions), -39 (deletions)

Title: Re: New revs
Post by: Nao on May 8th, 2014, 05:49 PM
[Commit revision 9127ea1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 08 May 2014 14:34:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9127ea187b6e37edb8d7d131e0a633506c785b98); +6 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on May 9th, 2014, 02:56 PM
[Commit revision 58ec45a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 09 May 2014 14:35:02 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/58ec45a53da8c86a40e249f2ab6a59a466be8fbb); +101 (insertions), -102 (deletions)


[Commit revision b943c9f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 09 May 2014 14:53:07 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/b943c9fc9a3e40b9d8c3ed37a4a5bca59e14f1dc); +8 (insertions), -27 (deletions)

Title: Re: New revs
Post by: Nao on May 11th, 2014, 01:29 PM
[Commit revision 58d4943]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 11 May 2014 12:47:44 +0200
Stats: 13 files changed(https://github.com/Wedge/wedge/commit/58d4943a355c3f2d303fdea29a20fbb443074cb2); +8 (insertions), -17 (deletions)


[Commit revision 3d67dd2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 11 May 2014 13:20:19 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/3d67dd2d11e55638fbc114dd551b60576090fddc); +2 (insertions), -1 (deletion)


[Commit revision 2a1bdd2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 11 May 2014 13:20:44 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/2a1bdd27adc5ac874a980d610846c6a6f4531c72); +1 (insertion), -1 (deletion)


Posted: May 11th, 2014, 01:21 PM

[Commit revision 0be756d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 11 May 2014 13:28:55 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0be756d027a95ae6891b0ec44e5b9a29f11fb484); +0 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 11th, 2014, 01:35 PM
[Commit revision 38fd193]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 11 May 2014 13:35:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/38fd19312a395b908094bf3d28286ea3427e4bc6); +2 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on May 15th, 2014, 10:24 AM
[Commit revision 7013192]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 13 May 2014 19:24:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7013192fcd7391c4d6fa9c7055f76a23314ab31c); +0 (insertion), -0 (deletion)


[Commit revision e97ce35]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 14 May 2014 17:45:12 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e97ce350acefaad1cecc65f5f5d74dcdf5f73b23); +2 (insertions), -0 (deletion)


[Commit revision da08648]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 15 May 2014 10:24:03 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/da08648438f3f6649a8672955f42c634f2ee6727); +27 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 15th, 2014, 10:17 PM
[Commit revision 433d9d0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 15 May 2014 14:48:23 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/433d9d0800805faefdfeafdde78a7ca06d1a62fe); +2 (insertions), -2 (deletions)


[Commit revision 0e38b3f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 15 May 2014 22:14:15 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0e38b3f806c20b779b05a8d7fba489b0b6e74bc1); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on May 15th, 2014, 11:39 PM
[Commit revision 21e2320]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 15 May 2014 23:36:17 +0200
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/21e232041b1465d24bbc6b5af65de48ebe80da3c); +7 (insertions), -8 (deletions)


[Commit revision 29fdcaa]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 15 May 2014 23:37:41 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/29fdcaa6ad7b862678ff062aa3fa1a9e30326771); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on May 16th, 2014, 12:00 AM
[Commit revision b2cbcfc]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 16 May 2014 00:00:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b2cbcfc1e957a0d9a9aa54d9ec610788234a7d5d); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 17th, 2014, 05:40 PM
[Commit revision 9f58649]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 16 May 2014 07:58:17 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/9f58649d3a77557ceebcdabc2aaa8819d19f7aa8); +6 (insertions), -25 (deletions)


[Commit revision e8d1e4d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 16 May 2014 08:05:25 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e8d1e4dc50856d244b1905a380a2f3486c30417c); +6 (insertions), -0 (deletion)


[Commit revision fc1e181]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 16 May 2014 19:06:45 +0200
Stats: 16 files changed(https://github.com/Wedge/wedge/commit/fc1e181f6f5bad0c24d24fb857e3ba1a385e2ef3); +26 (insertions), -48 (deletions)


[Commit revision 756aeb1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 17 May 2014 16:20:15 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/756aeb1cec5d4aba9ad42ec93ebda726708ead4a); +24 (insertions), -24 (deletions)


[Commit revision 04596e5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 17 May 2014 17:40:12 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/04596e5dfefb515f161724ea9afb07a8bd939b8c); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 18th, 2014, 09:37 PM
[Commit revision 245019a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 17 May 2014 17:54:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/245019ab240f9a65f4a482f55581a6c8e2b10a1f); +2 (insertions), -2 (deletions)


[Commit revision d172d15]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 18 May 2014 21:24:18 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d172d152e418ff4b415d0ac5fa3509de084690c0); +5 (insertions), -6 (deletions)


[Commit revision bcd3d00]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 18 May 2014 21:25:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bcd3d003584921af172641c4f0a1864df6642283); +2 (insertions), -2 (deletions)


[Commit revision d96e014]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 18 May 2014 21:26:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d96e014a82ebd8a6da98b81d905b1eae2ef35e28); +3 (insertions), -6 (deletions)


[Commit revision 4a329ae]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 18 May 2014 21:35:20 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4a329ae9638f6062b123533247f3cf7aad45d2fa); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 19th, 2014, 02:15 PM
[Commit revision 6b37b73]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 19 May 2014 14:15:09 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6b37b732f3d4ccad43b51b861c8bc08e969a85fd); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on May 19th, 2014, 03:21 PM
[Commit revision d2368b1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 19 May 2014 15:21:29 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d2368b11a0f90641e10413fb6196d42a4a328c19); +20 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on May 19th, 2014, 11:42 PM
[Commit revision afcefe5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 19 May 2014 22:26:42 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/afcefe5e17db570eeeb6d157f30c17e34ecf673f); +4 (insertions), -4 (deletions)


[Commit revision 253f20f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 19 May 2014 22:30:20 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/253f20f048dab832b20e2455b736a358b80ffef6); +25 (insertions), -21 (deletions)


[Commit revision affdb8f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 19 May 2014 23:42:34 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/affdb8f48510c4e5dffa45c686cbe789e4f73901); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 20th, 2014, 10:04 PM
[Commit revision c9b9157]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 20 May 2014 21:50:32 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c9b915770f4bc4d4efdae93ec91a79a726f5e9c8); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 23rd, 2014, 11:29 PM
[Commit revision 1b455c2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 23 May 2014 23:28:47 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1b455c2b2ac3bd6f48ec41940b39796dbb69cb16); +39 (insertions), -40 (deletions)

Title: Re: New revs
Post by: Nao on May 24th, 2014, 01:11 AM
[Commit revision 5bb0f72]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 24 May 2014 01:05:14 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/5bb0f72120032b3e4df6d9f93440059ed5602cbe); +5 (insertions), -2 (deletions)


[Commit revision c683c5e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 24 May 2014 01:10:40 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c683c5e3778400cdb814bd8df38f7c83d9bdcafa); +4 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on May 24th, 2014, 01:12 AM
[Commit revision b1f5c83]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 24 May 2014 01:11:44 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b1f5c834c2151f95182b771e0fbc5cf7391308c8); +0 (insertion), -6 (deletions)

Title: Re: New revs
Post by: Nao on May 24th, 2014, 12:45 PM
[Commit revision 0677522]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 24 May 2014 12:44:15 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/067752234ce58baae0db44d42c34480d42696758); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 25th, 2014, 07:52 PM
[Commit revision aa9bb55]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 24 May 2014 15:27:40 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/aa9bb5591aa0d63f5feac0f7e206850c3adb6854); +2 (insertions), -2 (deletions)


[Commit revision f0f2230]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 25 May 2014 19:51:48 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/f0f22300dc319b709e038e0b44781d40473a3f09); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on May 26th, 2014, 10:45 PM
[Commit revision ebb1206]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 26 May 2014 22:10:38 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ebb1206804b4d8f3a91f30a7087e93a1a125d9a5); +3 (insertions), -2 (deletions)


[Commit revision 7b2a761]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 26 May 2014 22:14:02 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7b2a761ae9787bb7896d750324729fc413c6a459); +0 (insertion), -1 (deletion)


[Commit revision dabf14c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 26 May 2014 22:15:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dabf14c5463492b2fa8c8373ed26f3e49702fd19); +0 (insertion), -1 (deletion)


[Commit revision 7347839]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 26 May 2014 22:16:27 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/73478397f81e233ec4cec2eb465cba8147e26bcc); +11 (insertions), -4 (deletions)


[Commit revision 18527df]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 26 May 2014 22:16:56 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/18527df1c5581ef5f14d68e54a705fb9e3906cb3); +2 (insertions), -0 (deletion)


[Commit revision f4ae2a5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 26 May 2014 22:45:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f4ae2a58f8391f62292268d9f3f4379cd1a7b5a7); +8 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on May 27th, 2014, 12:15 AM
[Commit revision d592188]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 00:13:37 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d59218822c6a22feeeee4526e943ab25242bb780); +20 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on May 27th, 2014, 12:30 AM
[Commit revision e494b94]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 00:30:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e494b9471ccd11dfb6d1aff63899682a8ccc0242); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 27th, 2014, 12:46 AM
[Commit revision 9f8894d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 00:45:50 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9f8894da94481f000cfa6c44bade10330ecc31f9); +7 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on May 27th, 2014, 01:46 PM
[Commit revision 9a253a4]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 12:58:37 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/9a253a47cd049aac9960528753fa6ed2953f9093); +18 (insertions), -51 (deletions)


[Commit revision 99614a1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 13:45:56 +0200
Stats: 10 files changed(https://github.com/Wedge/wedge/commit/99614a10e65304c2e9b969919d76e473236d621f); +39 (insertions), -65 (deletions)

Title: Re: New revs
Post by: Nao on May 27th, 2014, 01:50 PM
[Commit revision fe64c8a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 13:50:11 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fe64c8ac8be21ed2ca2cae466d55e87fe2f4be0c); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 29th, 2014, 02:32 PM
[Commit revision 03a3393]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 28 May 2014 09:11:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/03a3393142740fa72592520f4e7c6fc18a1231a9); +1 (insertion), -0 (deletion)


[Commit revision 8b654af]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 28 May 2014 16:05:46 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/8b654afcc9e75d1b87661b2e290757f85f72beab); +33 (insertions), -34 (deletions)


[Commit revision dfa1bdf]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 29 May 2014 14:31:32 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/dfa1bdffa35693773fb1199fc108d1046336375c); +56 (insertions), -58 (deletions)


[Commit revision 9c6859b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 29 May 2014 14:32:11 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/9c6859b03de88a30f19a3c27930a46b11292980a); +14 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on May 29th, 2014, 05:04 PM
[Commit revision c55862b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 29 May 2014 17:03:40 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c55862b86be2cbb1f07e0a2e251e0eb2f30f15e0); +15 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on May 29th, 2014, 09:00 PM
[Commit revision 553d66e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 29 May 2014 21:00:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/553d66ea5b0ae3f58c1ac1f38e07f2a78c4ab59d); +0 (insertion), -2 (deletions)

Title: Re: New revs
Post by: Nao on May 29th, 2014, 11:55 PM
[Commit revision e4fbaa3]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 29 May 2014 23:55:10 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/e4fbaa3f017b79f5cff63397ed7db426e8dd536c); +23 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 30th, 2014, 12:28 AM
[Commit revision 9ab15f5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 30 May 2014 00:28:27 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9ab15f5765f78b99d7a073bad8dffec68fd5558d); +3 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 30th, 2014, 01:54 PM
[Commit revision d1085d7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 30 May 2014 13:54:33 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d1085d7d7a0fbe7ee94866ee468070eb3a9b2807); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 1st, 2014, 05:37 PM
[Commit revision e775f37]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 01 Jun 2014 17:37:37 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e775f3705de758253b2477db296d6c45a2900046); +21 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on June 2nd, 2014, 07:45 PM
[Commit revision a05be18]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 02 Jun 2014 19:45:10 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a05be1876cfa3abea06eebbfc3bcd3bab8fe85c6); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 3rd, 2014, 12:52 AM
[Commit revision 237996d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 03 Jun 2014 00:51:41 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/237996d334c4545201df08bb1a9c3409c37778e6); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on June 4th, 2014, 12:51 AM
[Commit revision b0e0c47]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 03 Jun 2014 19:24:15 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b0e0c475e4332e6664570e16b4121e205e599b4b); +6 (insertions), -5 (deletions)


[Commit revision 05e76c9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 03 Jun 2014 23:50:25 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/05e76c950a0a6a11dc99725efe6fb12943bee2d7); +4 (insertions), -3 (deletions)


[Commit revision 030011b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 00:03:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/030011b9785b55e6c526674d2b981b5831c86ae3); +1 (insertion), -1 (deletion)


[Commit revision 06daf04]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 00:05:10 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/06daf04bda95a6ce2f6a07dba90a05d93292cfc8); +1 (insertion), -1 (deletion)


[Commit revision 50a3205]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 00:50:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/50a3205aea4df287341e752d5e8adad96dab7e4a); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on June 4th, 2014, 05:24 PM
[Commit revision bdaf6e6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 16:50:27 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/bdaf6e6bbc4ac18a15c13d152829aaa2df99603e); +26 (insertions), -18 (deletions)


[Commit revision 4cbe1d5]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 16:54:12 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/4cbe1d51de84e26d41fa9bed3d83b39401aff705); +13 (insertions), -11 (deletions)


[Commit revision 9edbf47]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 16:58:28 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9edbf47a96fe718e3cf1ac6094c9339f1652565f); +9 (insertions), -6 (deletions)


[Commit revision 1e7da76]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:02:30 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1e7da7684fec6dd1d8bf4c8d2ac8eead69186dbe); +13 (insertions), -3 (deletions)


[Commit revision fe55139]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:05:52 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/fe5513905e8f6b032e5df001670dd7488bf3ec29); +9 (insertions), -16 (deletions)


[Commit revision 6bd39b6]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:07:11 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6bd39b6fe0c8b93c1a5c831525c0b5626959321e); +14 (insertions), -0 (deletion)


[Commit revision 20d0ddf]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:08:00 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/20d0ddf303b3b4f654766b9822f4567e65ee2c33); +4 (insertions), -4 (deletions)


[Commit revision a42fc9d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:22:11 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/a42fc9d532d724b17b8810bcbba25686d9870d8b); +10 (insertions), -5 (deletions)


[Commit revision bd0fb17]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:23:48 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bd0fb178f281d1a21178321e2e3827e8daa6f461); +14 (insertions), -18 (deletions)

Title: Re: New revs
Post by: Nao on June 5th, 2014, 12:41 AM
[Commit revision 193e65e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 05 Jun 2014 00:41:34 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/193e65e087ea7afb5370f2e3af3509e82a85e821); +6 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on June 6th, 2014, 12:37 AM
[Commit revision c5f9211]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 05 Jun 2014 15:57:18 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/c5f9211acb6d06ae57107de2595cd5750f1406c9); +0 (insertion), -7 (deletions)


[Commit revision c98b184]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 00:34:55 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c98b18467e485f080bc3ecd40c6e86f188e86149); +3 (insertions), -0 (deletion)


[Commit revision 8910be3]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 00:37:18 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/8910be30262d3fe15a1ae08ff5fc99dc9614e1fa); +7 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on June 6th, 2014, 12:50 AM
[Commit revision 46c63c9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 00:50:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/46c63c9a2b5651d586b1642efefc01ed294a728a); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on June 6th, 2014, 12:21 PM
[Commit revision 21c762b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 11:53:36 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/21c762b1a0da562a404555512c05b5dab14bd592); +2 (insertions), -2 (deletions)


[Commit revision 2244329]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 12:21:13 +0200
Stats: 8 files changed(https://github.com/Wedge/wedge/commit/22443299cbf36710ecf1028fe6db5e49c6fd2ebe); +59 (insertions), -39 (deletions)

Title: Re: New revs
Post by: Nao on June 6th, 2014, 12:58 PM
[Commit revision 4c1d33a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 12:58:16 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4c1d33a8bc8ee6d88b15c39d309bf3db0783f6fe); +0 (insertion), -12 (deletions)

Title: Re: New revs
Post by: Nao on June 6th, 2014, 01:17 PM
[Commit revision 5e8eb26]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 13:10:12 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/5e8eb26dab5d51f1bff6a736de7185d166245f98); +7 (insertions), -5 (deletions)


[Commit revision 6942de0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 13:17:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6942de099f56f40574d9f95ab0920146dc0b7c86); +8 (insertions), -8 (deletions)

Title: Re: New revs
Post by: Nao on June 8th, 2014, 12:50 AM
[Commit revision 569c18b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 07 Jun 2014 15:55:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/569c18b3ee825ba42c09577cff50fd1e2f9dc69b); +1 (insertion), -0 (deletion)


[Commit revision d804ea7]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 00:50:04 +0200
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/d804ea77c59e46cc644c701941b9f5aa729d7579); +238 (insertions), -97 (deletions)

Title: Re: New revs
Post by: Nao on June 8th, 2014, 01:00 AM
[Commit revision 2e72966]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 01:00:39 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/2e72966cf09e762fee883b2963bfd361f3853fcc); +2 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on June 8th, 2014, 01:14 AM
[Commit revision 6200ee1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 01:06:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6200ee1760c89639b02ec058f6b4007637df5ee1); +0 (insertion), -0 (deletion)


[Commit revision 78fcf71]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 01:11:40 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/78fcf711fed210e0cde5c86fc9792b145b084233); +6 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on June 8th, 2014, 11:49 AM
[Commit revision a01ec2a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 11:49:12 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/a01ec2a7196aedbd13bb51b0e06065e821de7d20); +6 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on June 8th, 2014, 01:46 PM
[Commit revision b2b5bbe]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 11:50:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b2b5bbecbf17231b75ac0de5d2446410320629ef); +2 (insertions), -2 (deletions)


[Commit revision bf43b0f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 11:51:45 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/bf43b0f5bc88a415f6b73536f3388d3e502039b6); +2 (insertions), -2 (deletions)


[Commit revision 6cb107e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 11:52:27 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6cb107ef58a0a9adf36a6f2eae03ed448a04c747); +1 (insertion), -1 (deletion)


[Commit revision 381259e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 12:03:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/381259e8f09a792b4404c89fbccb05c7c390502f); +6 (insertions), -3 (deletions)


[Commit revision 3a4c413]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 12:16:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3a4c41306f0499ebfa9b9ad43a5269843f743481); +18 (insertions), -28 (deletions)


[Commit revision dd008c0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 13:44:45 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dd008c00a13816f87156c30f53eba57d2f706405); +0 (insertion), -16 (deletions)

Title: Re: New revs
Post by: Nao on June 9th, 2014, 01:37 AM
[Commit revision 3b46326]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jun 2014 18:06:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3b4632632a203659a8af4c3e19e97af10343ed6f); +35 (insertions), -35 (deletions)

Title: Re: New revs
Post by: Nao on June 9th, 2014, 01:40 AM
[Commit revision 4baac54]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 09 Jun 2014 01:40:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4baac54a5733db283cb1513446351ea2c01cd83d); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 13th, 2014, 12:23 AM
[Commit revision cee2d6b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 09 Jun 2014 16:24:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cee2d6bf3842da97315719358980294049cbb3e3); +4 (insertions), -2 (deletions)


[Commit revision 5d3706f]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 13 Jun 2014 00:08:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5d3706fcfaf5c81058d9350de1ab4933df005bab); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 13th, 2014, 12:47 AM
[Commit revision cb8c223]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 13 Jun 2014 00:46:48 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/cb8c2235e3a68e9e19f7854c87f90668520a603c); +6 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on June 15th, 2014, 12:39 AM
[Commit revision 54a951e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 14 Jun 2014 17:14:06 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/54a951eaeba5f90f65426186f29858ad6fb2cc93); +13 (insertions), -2 (deletions)


[Commit revision 1bcccaf]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 14 Jun 2014 17:14:45 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/1bcccafa6ae9139f055f80f9edcaee4b279c543e); +6 (insertions), -6 (deletions)


[Commit revision 4f947b2]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 14 Jun 2014 17:15:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4f947b2f50af784db0622e3076099fa939769ba1); +1 (insertion), -1 (deletion)


[Commit revision a5613b3]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 14 Jun 2014 17:54:38 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a5613b333bc9111db55ea1d1013ea3a0ca646f5b); +1 (insertion), -2 (deletions)

Title: Re: New revs
Post by: Nao on June 15th, 2014, 01:50 AM
[Commit revision 7b506ea]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 15 Jun 2014 01:07:57 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7b506ea3087ab4238ff91838c13f6fe5caaf8c65); +0 (insertion), -1 (deletion)


[Commit revision b6a26ba]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 15 Jun 2014 01:49:56 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b6a26bafb6caca5d6e2da6f34215c3579355b5e7); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on June 17th, 2014, 12:40 AM
[Commit revision a15c895]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 17 Jun 2014 00:40:15 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a15c895840a11e62d92fed0ad0341061201409fb); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 18th, 2014, 03:37 PM
[Commit revision 2d3972e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Wed, 18 Jun 2014 15:37:06 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/2d3972e2d5811a0c2a024b4cc3204e84223ff584); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on June 19th, 2014, 12:12 AM
[Commit revision e4a72e0]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 19 Jun 2014 00:11:41 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e4a72e018b8e60bbb1b4ad51b45c5b65393b0fc2); +5 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on June 20th, 2014, 12:29 PM
[Commit revision 64b0fc9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 20 Jun 2014 12:28:39 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/64b0fc97a5ed3a3786cc40a2236650ac28f181c3); +7 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on June 21st, 2014, 01:02 AM
[Commit revision cf23d05]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 20 Jun 2014 13:05:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cf23d0591f5fe9f3dec16542c916f8c9725ee1cb); +1 (insertion), -7 (deletions)


[Commit revision 225151c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Jun 2014 01:02:02 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/225151c4879d2b0ba581c8e73b0b899c234d1533); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on June 21st, 2014, 08:39 PM
[Commit revision 46a408d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Jun 2014 20:32:04 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/46a408d054924b442ff5f4bd79fcd920caae5a04); +5 (insertions), -3 (deletions)


[Commit revision 4e72d52]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Jun 2014 20:38:28 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4e72d5270258a1804743c3cfdeb44530a172fb0f); +3 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on June 21st, 2014, 08:47 PM
[Commit revision 28125fa]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Jun 2014 20:46:48 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/28125faf99ebaa85a62d50484b0ce67236801613); +50 (insertions), -49 (deletions)

Title: Re: New revs
Post by: Nao on June 21st, 2014, 09:00 PM
[Commit revision 1df974d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Jun 2014 21:00:06 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1df974d2618e26182e430fff5598d8983a30de22); +1 (insertion), -1 (deletion)

 1. Except for a few areas, like the thought list, but I'll come back to that.
Title: Re: New revs
Post by: Nao on June 22nd, 2014, 07:56 PM
[Commit revision 49fcb38]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 22 Jun 2014 17:04:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/49fcb382fad69549531947717a24dc93fea96431); +24 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on June 22nd, 2014, 09:07 PM
[Commit revision 7f56622]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 22 Jun 2014 20:57:36 +0200
Stats: 21 files changed(https://github.com/Wedge/wedge/commit/7f566227d149c4976beac546791f0161da3fdc5a); +20 (insertions), -47 (deletions)


[Commit revision cacaf81]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 22 Jun 2014 20:58:53 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cacaf81da40a8caf49ad584df13e576c0abb0b8e); +1 (insertion), -0 (deletion)


[Commit revision ac18e94]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 22 Jun 2014 20:59:24 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ac18e941b2b226db933be8e79ce8acbeb8a7395d); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 24th, 2014, 01:36 AM
[Commit revision 8f34a6a]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jun 2014 01:36:15 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8f34a6aabc7727615a3faf0169ebe890a39abd3c); +17 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on June 24th, 2014, 11:45 PM
[Commit revision fbf25ff]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jun 2014 23:45:23 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/fbf25ff841a17a7cb4bb5a28c503439d2ef300f3); +10 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on June 26th, 2014, 08:26 PM
[Commit revision ef87256]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 26 Jun 2014 20:25:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ef8725637f771e7237970dceb16ea86515b731e7); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on June 28th, 2014, 02:25 PM
[Commit revision 59f2bb1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 28 Jun 2014 14:18:42 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/59f2bb11dc9f01b7d166a96a6c0f5df65b863a87); +14 (insertions), -0 (deletion)


[Commit revision 93302ec]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 28 Jun 2014 14:25:15 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/93302ecc578ce4dba828839e1c8c2cf7c0c07f40); +159 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on June 29th, 2014, 08:56 PM
[Commit revision 217c7ef]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 29 Jun 2014 20:56:04 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/217c7ef31819883025b0ed1375bb30eb162d6748); +21 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on June 29th, 2014, 10:36 PM
Note that I've decided to unlock this topic and allow comments related to new revisions. It's better than always having to dug up the New revs comment topic or create a new topic to comment, which rarely happens...
I'm also doing that because the github reposts have a clear look and you can choose to simply skip the posts that don't like them. Or follow new revs on github, whichever you prefer.

Please stay on topic. This isn't a support topic!
Title: Re: New revs
Post by: Nao on July 3rd, 2014, 12:25 AM
[Commit revision b0ec67b]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 03 Jul 2014 00:24:47 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b0ec67baa4142868356afd3f77766426486f8f2e); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on July 5th, 2014, 11:16 PM
[Commit revision 3e14729]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Fri, 04 Jul 2014 16:42:58 +0200
Stats: 8 files changed(https://github.com/Wedge/wedge/commit/3e1472944ec4669f7b584e034d9e04770124f313); +15 (insertions), -42 (deletions)


[Commit revision 73e2099]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Jul 2014 23:12:07 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/73e2099378b6f284ef02765ff0f22389bd1818f8); +18 (insertions), -0 (deletion)


[Commit revision 8f69758]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Jul 2014 23:16:10 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8f69758531bead54ac749066a431d9dbb8c3d8b1); +5 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on July 5th, 2014, 11:40 PM
[Commit revision e17a1a1]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Jul 2014 23:36:37 +0200
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/e17a1a1516ee739a65edefef7f1992d55da87a00); +307 (insertions), -100 (deletions)


[Commit revision 9247a50]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sat, 05 Jul 2014 23:39:48 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/9247a5094316f1850368d89666a25bf7995dc61b); +18 (insertions), -15 (deletions)

Title: Re: New revs
Post by: Nao on July 6th, 2014, 10:07 AM
[Commit revision 4152e82]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 06 Jul 2014 10:07:19 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4152e820be846129501e5c71a49eed5b6214f2da); +13 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on July 6th, 2014, 01:36 PM
[Commit revision 64aeb4c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 06 Jul 2014 13:35:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/64aeb4cbc2c174a6bb1381b3c35018ae7e75d38c); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on July 7th, 2014, 05:10 PM
[Commit revision e5446bf]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 07 Jul 2014 17:10:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e5446bf52fed154b33a84ccfbee6ab3f685bfaf9); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on July 7th, 2014, 11:00 PM
[Commit revision 5f4fe10]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 07 Jul 2014 23:00:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5f4fe10c24879150fa0c1d7619fdc9267b97659a); +11 (insertions), -26 (deletions)

Title: Re: New revs
Post by: Nao on July 7th, 2014, 11:58 PM
[Commit revision e2ee0d9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 07 Jul 2014 23:58:26 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e2ee0d91ea46f0a7cc1279f86335a4b2a0b7c8e9); +17 (insertions), -14 (deletions)

Title: Re: New revs
Post by: Nao on July 8th, 2014, 12:08 AM
[Commit revision 54bcada]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Jul 2014 00:08:47 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/54bcada76d7c2ddeef6388b254f10a50221873cd); +30 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on July 8th, 2014, 12:15 AM
[Commit revision 41149a9]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Jul 2014 00:12:29 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/41149a9a092abc15fa399730c6265d17026ade79); +4 (insertions), -4 (deletions)


[Commit revision 8e03f6d]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Jul 2014 00:15:34 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8e03f6dc1b6ae7f85f9b16445f3d2f1bdc918157); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on July 8th, 2014, 02:17 PM
[Commit revision 2a97066]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Jul 2014 14:17:33 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/2a97066b33376139e69d05b7d0ed077e92085881); +5 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on July 24th, 2014, 08:52 PM
[Commit revision 96fe4a8]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 24 Jul 2014 20:51:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/96fe4a86bf082709db8a26ae086ef5993a9baed8); +8 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on July 24th, 2014, 08:56 PM
[Commit revision 00f721c]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 24 Jul 2014 20:53:29 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/00f721cda7eb280571f76711b11d477baae2686b); +1 (insertion), -1 (deletion)


[Commit revision 9fe368e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Thu, 24 Jul 2014 20:55:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9fe368e81c37521b64b8940098499b16f3aaca94); +10 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on July 27th, 2014, 04:28 PM
[Commit revision b74df21]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 27 Jul 2014 16:28:02 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b74df217f003e940dbdf6c0613c22474908af646); +25 (insertions), -17 (deletions)

Title: Re: New revs
Post by: Nao on July 27th, 2014, 05:21 PM
[Commit revision 7805278]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Sun, 27 Jul 2014 17:21:35 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7805278b961458e605a4d83ef3d5e8bd0caf8568); +9 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on July 28th, 2014, 11:11 PM
[Commit revision 8dec48e]
(https://avatars.githubusercontent.com/u/1857192?)Author: Nao(https://github.com/Nao)
Date: Mon, 28 Jul 2014 03:08:48 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8dec48e5ee75d508475c7ac7a4a2713dee3b15e9); +12 (insertions), -12 (deletions)

Title: Re: New revs
Post by: Nao on August 7th, 2014, 11:34 AM
[Commit revision da777b6]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 05 Aug 2014 20:16:15 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/da777b64e43cd38cff16bb1f318141bf7b9c5d62); +1 (insertion), -1 (deletion)


[Commit revision f15766c]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 06 Aug 2014 19:52:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f15766c7a84c91198757ba4ac3cfea5db6350bbe); +10 (insertions), -11 (deletions)


[Commit revision 447bb4f]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 06 Aug 2014 20:00:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/447bb4fcba7cf075347f171c1ad307ba1b75f62d); +2 (insertions), -1 (deletion)


[Commit revision b1de422]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 06 Aug 2014 23:54:08 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b1de422fafd5fd4a45b0313c4be1b66f6e0d4e6a); +10 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on August 16th, 2014, 12:52 PM
[Commit revision 4064433]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Thu, 07 Aug 2014 12:34:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4064433689d4576111d72426c83d422a73637621); +2 (insertions), -40 (deletions)


[Commit revision 172b9a4]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 09 Aug 2014 13:20:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/172b9a4f7189ac60d6c959705c54f17776897bf9); +2 (insertions), -3 (deletions)


[Commit revision 298d4fc]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 09 Aug 2014 16:37:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/298d4fc5693d61c9605a03f49122b38d10e72d69); +21 (insertions), -22 (deletions)


[Commit revision 3f4cfeb]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 11 Aug 2014 18:47:19 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3f4cfeb8ec92f64741d426ce024215755e6c66f3); +13 (insertions), -4 (deletions)


[Commit revision 1ee42c5]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Thu, 14 Aug 2014 12:44:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1ee42c596fe18331fb540c50ea3b80b7fdbf96bc); +1 (insertion), -0 (deletion)


[Commit revision c7dde23]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Fri, 15 Aug 2014 19:25:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c7dde23dd271b6a1dbb650e510749ceeff81b160); +2 (insertions), -0 (deletion)


[Commit revision c3ba549]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 16 Aug 2014 12:42:14 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c3ba5498e40faff01612517395ed5705b90dd61e); +5 (insertions), -6 (deletions)


[Commit revision 837c46c]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 16 Aug 2014 12:51:33 +0200
Stats: 9 files changed(https://github.com/Wedge/wedge/commit/837c46c2c38840f9c304ab5d8c1c198941031e96); +7 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on August 17th, 2014, 12:47 AM
[Commit revision 405bed2]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 16 Aug 2014 23:39:50 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/405bed20121dcc0297c77f8b6cf4528bc512677e); +39 (insertions), -44 (deletions)


[Commit revision 588b05f]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 00:00:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/588b05f687c066fe3a66a217889cd099c8933eb7); +6 (insertions), -0 (deletion)


[Commit revision 96ea5ec]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 00:16:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/96ea5ec82d390eb971cc7fea4fa3f0719ddf882d); +5 (insertions), -1 (deletion)


[Commit revision 903402e]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 00:21:41 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/903402e144453f3cf5a4929b7ad91abb17bc0833); +90 (insertions), -53 (deletions)


[Commit revision 755ae02]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 00:34:54 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/755ae0214844783224e38e14386db30bcd08bf15); +55 (insertions), -25 (deletions)


[Commit revision 4ba1ebf]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 00:47:11 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/4ba1ebf6b63510193edd83171fe2b299a5833e86); +188 (insertions), -60 (deletions)

Title: Re: New revs
Post by: Nao on August 18th, 2014, 10:23 AM
[Commit revision 5097534]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 18:44:03 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/50975343418ed0500f07ac5ec17558a8c1fd8231); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on August 18th, 2014, 10:24 AM
[Commit revision d4cd7fb]
(https://avatars.githubusercontent.com/u/1673416?v=2)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Tue, 08 Jul 2014 12:03:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d4cd7fbcb5868e0e3a497fa27abd4c2702103290); +2 (insertions), -1 (deletion)


[Commit revision 91e6c76]
(https://avatars.githubusercontent.com/u/1673416?v=2)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Tue, 08 Jul 2014 16:24:09 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/91e6c76e8c8b84ee33cd2b5b81bbd0dd419b1274); +10 (insertions), -1 (deletion)


[Commit revision 355e403]
(https://avatars.githubusercontent.com/u/1673416?v=2)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Wed, 09 Jul 2014 09:50:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/355e4037048ebc0e7d06ba11d003b01d48fdf69f); +1 (insertion), -1 (deletion)


[Commit revision c26851b]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 18 Aug 2014 10:24:49 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/c26851b2f569693aeb44b7f9aa355d9a0f469df1); +12 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on August 18th, 2014, 11:25 PM
[Commit revision 1ab0d0d]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 18 Aug 2014 12:48:19 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1ab0d0d3243ddf6b98518db692e16d2c8447eede); +2 (insertions), -1 (deletion)


[Commit revision 92b02a5]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 18 Aug 2014 15:55:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/92b02a582a7c655fd9ba0aa39cbfa9ab88beaaed); +1 (insertion), -1 (deletion)


[Commit revision 6a38e88]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 18 Aug 2014 23:25:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6a38e8827ecb5736c484cc610131dd53965ec91e); +6 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on August 21st, 2014, 12:42 AM
[Commit revision 50d5d14]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Thu, 21 Aug 2014 00:42:06 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/50d5d14659dad71b1b7ae2940d9db93499e9929e); +16 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on August 21st, 2014, 12:47 AM
[Commit revision 1cdc8dd]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Thu, 21 Aug 2014 00:47:28 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1cdc8dd58a62ab77a4ed3a26a0bb8f67dd3b7a84); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on August 23rd, 2014, 12:46 AM
[Commit revision 3ff1484]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 23 Aug 2014 00:45:58 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/3ff14848c0d82c4c17b481a0510789f9134347cd); +29 (insertions), -29 (deletions)

Title: Re: New revs
Post by: Nao on August 23rd, 2014, 12:51 AM
[Commit revision 0de48d3]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 23 Aug 2014 00:50:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0de48d3d5ee8d28beef8f094954de0ae6f861168); +0 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on August 25th, 2014, 07:53 PM
[Commit revision 83b3775]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Aug 2014 18:22:24 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/83b377544fa34f36c7697a7c210c34c104e7b4a8); +2 (insertions), -2 (deletions)


[Commit revision fe2a7ca]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Aug 2014 18:22:55 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fe2a7caee9f78c3e8b03e0383a22e465de44d843); +1 (insertion), -1 (deletion)


[Commit revision b4aeac0]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Aug 2014 19:52:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b4aeac0f0989e7ffa32e2e647d313f9bbf159a74); +7 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on August 25th, 2014, 08:09 PM
[Commit revision e33bf38]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Aug 2014 20:09:01 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e33bf389d6e312a7cbca17df1bdae34663062fb3); +4 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on August 26th, 2014, 12:48 AM
[Commit revision 7f70b39]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 26 Aug 2014 00:48:17 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7f70b39e8a9d8c3efacc63ed3ced728265319fb0); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on September 12th, 2014, 12:42 AM
[Commit revision 7b016f4]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 30 Aug 2014 23:57:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7b016f47cb66e3ff8be02239d23697329d4d9982); +2 (insertions), -2 (deletions)


[Commit revision c04b446]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 08 Sep 2014 21:14:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c04b446b9f6d62a94723f9389708ba7772392ea5); +2 (insertions), -1 (deletion)


[Commit revision b867b56]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 09 Sep 2014 13:55:23 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b867b56e0a47cd84d87753ad35d822b54031295c); +2 (insertions), -35 (deletions)


[Commit revision 0caffa4]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 09 Sep 2014 14:01:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0caffa45d3f66b7704ffb3c7d3ffaee2e628840f); +1 (insertion), -1 (deletion)


[Commit revision caec3b3]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Fri, 12 Sep 2014 00:42:05 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/caec3b3e91485e035b191f9b451f2ad012593938); +7 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on September 12th, 2014, 01:41 AM
[Commit revision c7c0b6f]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Fri, 12 Sep 2014 01:41:16 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c7c0b6f6e9349dfc716383e6abef3274d193f543); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on September 12th, 2014, 01:08 PM
[Commit revision c763368]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Fri, 12 Sep 2014 13:07:27 +0200
Stats: 13 files changed(https://github.com/Wedge/wedge/commit/c7633688eb9b2a0ece3ada6b16a180d97065cc8f); +26 (insertions), -26 (deletions)

Title: Re: New revs
Post by: Nao on September 14th, 2014, 08:43 PM
[Commit revision eef8bbe]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 14 Sep 2014 10:33:25 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/eef8bbe8c4ff7bb9db0d206e6a57f83344bb60d7); +18 (insertions), -23 (deletions)

Title: Re: New revs
Post by: Nao on September 16th, 2014, 01:10 PM
[Commit revision c3c77a3]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 16 Sep 2014 13:10:07 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/c3c77a3b22223eedce97f18b7ad719437b3dc154); +9 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on September 18th, 2014, 09:33 AM
[Commit revision 6375a3f]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 16:19:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6375a3f10dcfdc901d693621b771dba48f16c4dc); +2 (insertions), -2 (deletions)


[Commit revision 98d6783]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 16:21:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/98d6783b59e7c22b71f5513fde6e1acb7cae045b); +3 (insertions), -2 (deletions)


[Commit revision a638f93]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 16:25:55 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a638f93b491f6a3265beba67c8570e0501cc0ce1); +2 (insertions), -0 (deletion)


[Commit revision 6bb1f10]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 16:48:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6bb1f10655c1bcbc4ccd824e5a147b256385fcf1); +1 (insertion), -2 (deletions)


[Commit revision 9e31847]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 16:49:14 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9e31847968b111fc779a526789432d0cfa6fa826); +1 (insertion), -1 (deletion)


[Commit revision 40b9961]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 17:43:14 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/40b996124f2f8f6373319fc24e4149d7532dae31); +7 (insertions), -5 (deletions)


[Commit revision e7143f3]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Sep 2014 17:49:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e7143f3ffb3c444352a296831e567aa63e4f1bf5); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on September 20th, 2014, 05:55 PM
[Commit revision 437382a]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 20 Sep 2014 00:02:16 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/437382a25b4c4d7a179674a26df732f331834a17); +25 (insertions), -14 (deletions)


[Commit revision eae8bcf]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 20 Sep 2014 00:02:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/eae8bcf8b50a3282895933c93f2d2ada8ec1f10c); +1 (insertion), -1 (deletion)


[Commit revision d49e096]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 20 Sep 2014 16:11:31 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d49e096db0e8c0dc25c91f1026de7ec9f3050658); +7 (insertions), -4 (deletions)


[Commit revision c6bcd2a]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 20 Sep 2014 16:12:32 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/c6bcd2ab3967aee25ef6158ec251b49c98c3bdc6); +2 (insertions), -6 (deletions)


[Commit revision 10a7860]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 20 Sep 2014 16:16:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/10a78603f724dc423c2b7c54e714392edc666049); +14 (insertions), -3 (deletions)


[Commit revision 0d03088]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 20 Sep 2014 17:44:22 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/0d03088aa0bea15ddc78b78f72c97001bc9ae8f0); +4 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on September 22nd, 2014, 05:23 PM
[Commit revision 52ad1bb]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 22 Sep 2014 17:23:09 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/52ad1bb1179eef383cfe6f709374b4db8c7c160d); +3 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on September 24th, 2014, 04:37 PM
[Commit revision 18d1ad6]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 24 Sep 2014 16:33:37 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/18d1ad6e3c93270133c2b9712a9309d1134276f5); +1 (insertion), -1 (deletion)


[Commit revision 86c2add]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 24 Sep 2014 16:36:47 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/86c2add0912354ff74e037132a316251f966d73e); +37 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Jurien on September 24th, 2014, 05:21 PM
View someone user's profile gives a database error,when not been logged in !!
Title: Re: New revs
Post by: Nao on September 24th, 2014, 05:21 PM
[Commit revision 0cd3a7b]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 24 Sep 2014 17:21:20 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0cd3a7be5264c5f38b5c37dc46f9552e8ccfc492); +5 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on September 24th, 2014, 06:05 PM
[Commit revision a1b0699]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 24 Sep 2014 18:05:24 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a1b06995595609eef2682ed603ee4b289a991ef6); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on September 26th, 2014, 01:08 AM
[Commit revision 5558dd8]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Fri, 26 Sep 2014 01:08:18 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5558dd8b92493b20a5247b4e8bf7b789dd0bf30b); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on September 27th, 2014, 12:22 AM
[Commit revision 4f6e1da]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Fri, 26 Sep 2014 16:24:30 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/4f6e1da57235b8b9c32c53980e30840d2a8fcfba); +5 (insertions), -1 (deletion)


[Commit revision a8644ca]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Sep 2014 00:21:10 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/a8644ca82d53ade8dfe992388c902e3e12e5a376); +4 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on September 27th, 2014, 12:52 AM
[Commit revision 98e6d91]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Sep 2014 00:49:03 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/98e6d918c7b8cb220c50dc6e31787031f10e9a05); +1 (insertion), -1 (deletion)


[Commit revision 41f3076]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Sep 2014 00:52:24 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/41f3076ab2635a944b06242c3b0d1f0dea768198); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on September 27th, 2014, 12:50 PM
[Commit revision bf985d8]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Sep 2014 12:50:06 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bf985d84c6988f7c762942e5841c8f5f89dcbbc8); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on September 27th, 2014, 10:49 PM
[Commit revision a0e044a]
(https://avatars.githubusercontent.com/u/4885967?v=2)Author: BurkeKnight(https://github.com/BurkeKnight)
Date: Sat, 27 Sep 2014 22:21:25 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a0e044a858afd9d202cff82eeb177f62be78674f); +1 (insertion), -1 (deletion)


[Commit revision e36c7d1]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Sep 2014 22:49:19 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e36c7d1d980d354b4463afefe9f9d8d22183abf5); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on September 29th, 2014, 09:57 PM
[Commit revision a230857]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 29 Sep 2014 21:53:55 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a2308578d8202d2be23a1c9dd944f9fce5b93cff); +4 (insertions), -4 (deletions)


[Commit revision 95d35e4]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 29 Sep 2014 21:56:16 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/95d35e461ec0028012877ac68c6203290b1b392d); +7 (insertions), -2 (deletions)


[Commit revision 3022c8a]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 29 Sep 2014 21:57:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3022c8a30d4578ef928f81211c9d61425b85ab59); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 1st, 2014, 03:55 PM
[Commit revision dd42929]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 01 Oct 2014 15:54:52 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/dd42929a31a2a8e2c4d88299cb49378d934d1479); +4 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on October 2nd, 2014, 01:03 AM
[Commit revision 49279a9]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 01 Oct 2014 20:30:19 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/49279a9ad50d3ddf6eac1f9f63058e49340898b4); +0 (insertion), -1 (deletion)


[Commit revision 3def5d7]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Thu, 02 Oct 2014 01:03:20 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/3def5d753c379ec962154ca62f4d480e34c360d5); +7 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on October 6th, 2014, 12:41 AM
[Commit revision 0303ffc]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Oct 2014 16:08:56 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0303ffcbcd835cf273f56c0f579102b59c6801b4); +1 (insertion), -1 (deletion)


[Commit revision 4bd583c]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Oct 2014 16:09:42 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4bd583c0852ba602fc8e6babd08ec346ed8f55b5); +2 (insertions), -2 (deletions)


[Commit revision 261d5a3]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Oct 2014 16:10:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/261d5a36bd3ba9fce9b4968882679dc38790300a); +6 (insertions), -4 (deletions)


[Commit revision 9f4c805]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Mon, 06 Oct 2014 00:41:11 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9f4c805c6c7f029dc601eb0e131bc3e9e5cbf7e4); +41 (insertions), -39 (deletions)

Title: Re: New revs
Post by: Nao on October 18th, 2014, 08:27 PM
[Commit revision c64ce87]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 18 Oct 2014 20:19:53 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c64ce87d473f67b5a29cfc7ec3cef75e8daa0e73); +1 (insertion), -1 (deletion)


[Commit revision ae18f6c]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Sat, 18 Oct 2014 20:26:46 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ae18f6c7b6cfaddfd519d27b75996af546c59a9f); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 22nd, 2014, 12:09 AM
[Commit revision f7822f7]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 21 Oct 2014 20:37:21 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/f7822f7ada71b26850417ef16b523c3e7d2c33df); +9 (insertions), -9 (deletions)


[Commit revision 15bb50b]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 21 Oct 2014 23:32:13 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/15bb50b5f5e032eaaf72456a417052a19161db04); +3 (insertions), -0 (deletion)


[Commit revision 3f28ad0]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Oct 2014 00:08:34 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3f28ad0d7df91a425c391d0612431265111b0a88); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 22nd, 2014, 12:14 AM
[Commit revision 4d3680a]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Oct 2014 00:14:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4d3680a524dbb4e4ee7bdeb1abb0a78a3d73b68f); +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on October 22nd, 2014, 11:10 PM
[Commit revision 74ccafb]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Oct 2014 22:17:35 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/74ccafb9699044fbb38b460d11bdd3677927b32b); +3 (insertions), -5 (deletions)


[Commit revision 9d716a9]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Oct 2014 23:05:11 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9d716a9527156713fab4c1e7d06f4cf5124380aa); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on October 22nd, 2014, 11:10 PM
[Commit revision 704756b]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Oct 2014 22:30:02 +0200
Stats: 11 files changed(https://github.com/Wedge/wedge/commit/704756b4aa3420dd5b8f11ec27a92304227ed061); +112 (insertions), -74 (deletions)

Title: Re: New revs
Post by: Nao on October 28th, 2014, 09:10 PM
[Commit revision 86a67d1]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Oct 2014 20:20:37 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/86a67d1722f1b5983b595c82fa38a752af49db53); +1 (insertion), -0 (deletion)


[Commit revision 0acaa37]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Oct 2014 21:03:36 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0acaa3741042044bdfa9d5094322b9077bac36d7); +2 (insertions), -0 (deletion)


[Commit revision 772cafd]
(https://avatars.githubusercontent.com/u/1857192?v=2)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Oct 2014 21:10:06 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/772cafdbfbdd8e9b6f907b4f1ceedff5d82a36a0); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on November 8th, 2014, 12:36 PM
[Commit revision 8f85c88]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Nov 2014 12:36:17 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8f85c88638500f46a1f2dde4f76bef3bb7518ff4); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on November 12th, 2014, 11:19 PM
[Commit revision 5ab1c8c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Nov 2014 23:17:53 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5ab1c8c421f7da3662f4d065d98d5fd4466f9e74); +13 (insertions), -1 (deletion)


[Commit revision d424bb0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Nov 2014 23:18:54 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d424bb0d8b4583df25ba8cec2305f08370c19c52); +30 (insertions), -33 (deletions)

Title: Re: New revs
Post by: Nao on November 12th, 2014, 11:28 PM
[Commit revision 1e70f28]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Nov 2014 23:28:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1e70f2800a50f9a2d5d6a23f358726ace634b848); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on November 12th, 2014, 11:31 PM
[Commit revision 010e52b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Nov 2014 23:31:07 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/010e52b83bbab37cff735a5d06a30510eb5ec19c); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on November 12th, 2014, 11:42 PM
[Commit revision 7769f80]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 12 Nov 2014 23:42:45 +0100
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/7769f80b0e78ed54bb79a60bd353b462fb4878d0); +10 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on November 16th, 2014, 09:17 PM
[Commit revision ee77aaf]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Nov 2014 21:15:43 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ee77aafb2984925607682733b3ff17fc909a3123); +31 (insertions), -23 (deletions)


[Commit revision 8f04071]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Nov 2014 21:17:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8f040711c09c1ba0d3ac929f9348d74b3b59a13b); +3 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on December 10th, 2014, 03:57 PM
[Commit revision 16b5014]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 10 Dec 2014 15:46:40 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/16b50145902a07768d65947246cd1dd49e0f570e); +129 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on December 10th, 2014, 10:26 PM
[Commit revision edb14af]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 10 Dec 2014 22:26:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/edb14afdf7945b8bbe533f7a08e02264a3306a45); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on December 21st, 2014, 08:57 PM
[Commit revision 921070e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 21 Dec 2014 20:54:56 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/921070e72119b01f6e2a9cc57431ce2ff72c8621); +0 (insertion), -5 (deletions)

Title: Re: New revs
Post by: Nao on December 21st, 2014, 09:51 PM
[Commit revision d1657f6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 21 Dec 2014 21:51:00 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/d1657f6dabe324c8c8ace38ce1a464ada435a594); +45 (insertions), -24 (deletions)

Title: Re: New revs
Post by: Nao on December 22nd, 2014, 01:00 AM
[Commit revision f73826a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 22 Dec 2014 00:59:22 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/f73826a7de58f28149be88968a6aa773df6844f0); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on December 23rd, 2014, 11:14 PM
[Commit revision 779c7c0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 23 Dec 2014 23:14:10 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/779c7c0db43c905d146ca4072b0034034478b14f); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on December 24th, 2014, 12:34 AM
[Commit revision 5483d62]
(http://)Author: (http://)
Date: Tue, 23 Dec 2014 23:19:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5483d6291ea16aac7ffaf88653b2cc0b2e2f78dc); +6 (insertions), -3 (deletions)


[Commit revision 9d5de43]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 24 Dec 2014 00:34:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9d5de435f4a76b0b27f6e0d09e01c3a1e218833c); +6 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on December 29th, 2014, 08:43 PM
[Commit revision 76d76c0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 29 Dec 2014 12:54:44 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/76d76c0c4da94529253a98134559933fe89d3279); +1 (insertion), -3 (deletions)


[Commit revision 1b5c546]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 29 Dec 2014 20:42:50 +0100
Stats: 10 files changed(https://github.com/Wedge/wedge/commit/1b5c546c917dd0a99cb321ef809faeaa1979e7db); +150 (insertions), -141 (deletions)

Title: Re: New revs
Post by: Jurien on December 30th, 2014, 12:34 PM
On my test forum something went wrong

Fatal error: require_once() [function.require]: Failed opening required '/home/onkecjfr/domains/phdforum.nl/public_html/mymug/wedge-master/core/app/Subs-MinifyPHP.php' (include_path='.:/usr/local/lib/php') in /home/onkecjfr/domains/phdforum.nl/public_html/mymug/wedge-master/gz/app/Subs-Template.php on line 1129

Code: [Select]
$cache = $no_caching ? $filename : ROOT_DIR . '/gz/html/' . str_replace(array(ROOT_DIR . '/', '/', '..'), array('', '_', 'UP'), $filename);
$settings['current_include_filename'] = $cache; // For debugging purposes...
$file_found = file_exists($cache);

if (!$no_caching && (!$file_found || filemtime($cache) < filemtime($filename)))
{
if (!file_exists($filename))
{
loadSource('ManageErrors');
handleTemplateErrors($filename);
}
require_once(APP_DIR . '/Subs-MinifyPHP.php');
apply_plugin_mods($filename, $cache);
minify_php($cache);
Title: Re: New revs
Post by: CerealGuy on December 30th, 2014, 12:47 PM
@Freñiçh
Use the commit before or change 'Subs-MinifyPHP.php' to 'Subs-CachePHP.php'. Also you can delete the Subs-MinifyPHP.php file.
Title: Re: New revs
Post by: Nao on December 30th, 2014, 02:27 PM
Sorry, forgot to commit my file. That's because it has custom changes to disable auto-merging for testing purposes, and I tend to disable it before committing stuff. If only git could allow for ignoring specific changes in a file, rather than an entire file... Their way of doing it is wrong.

As for the my_plugins error, I'll look into it. Busy right now... Baby stuff.

PS... Having comments in this topic is odd. Yet I allowed for it because it gives the topic more... Life?
Title: Re: New revs
Post by: CerealGuy on December 30th, 2014, 03:22 PM
Perhaps you should permit people to reply on this topic. I dont think that it needs "life", its only to keep track of new commits. In my opinion bugs should be discussed in an own topic.
Title: Re: New revs
Post by: Nao on December 30th, 2014, 03:50 PM
[Commit revision b44db28]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 30 Dec 2014 15:12:50 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b44db28d5c8359fc0c43dd243632a1072317c261); +1 (insertion), -1 (deletion)


[Commit revision 05bdbfd]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 30 Dec 2014 15:36:22 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/05bdbfdc5cdd0121b826afc27fc83c483b861a9c); +25 (insertions), -23 (deletions)

Title: Re: New revs
Post by: Nao on December 30th, 2014, 04:55 PM
[Commit revision 7f69520]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 30 Dec 2014 16:55:21 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7f695203398e25cfddd7ade90ca8341e775a7a36); +4 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Jurien on December 30th, 2014, 05:26 PM
Well done
Title: Re: New revs
Post by: Nao on December 30th, 2014, 07:54 PM
[Commit revision 6f172c0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 30 Dec 2014 19:54:14 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6f172c01fcae1504e612ef5e211de51e52245070); +8 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on January 5th, 2015, 04:18 PM
[Commit revision eedf086]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 03 Jan 2015 23:40:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/eedf086bf70a7e62333224cf4c7a2512461ee08c); +4 (insertions), -4 (deletions)


[Commit revision 0b351e7]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 05 Jan 2015 16:18:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0b351e7fb1cbe098381daddd4ff20e21e506a779); +2 (insertions), -1 (deletion)


[Commit revision f11a6c2]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 05 Jan 2015 16:18:10 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f11a6c251f1d2956ae5a0a6c52c214839e08af07); +12 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on January 6th, 2015, 11:49 AM
[Commit revision 36035ec]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 06 Jan 2015 11:49:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/36035ececf287dca8e17212512bba920ca7766f2); +7 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on January 6th, 2015, 11:50 AM
[Commit revision e300c92]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 06 Jan 2015 11:50:04 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e300c924a9eaad917649cb3c224c82bf51d81958); +6 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 7th, 2015, 12:52 AM
[Commit revision 4ec075e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 07 Jan 2015 00:50:42 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4ec075eb2e586eab4ebcb3113f200591797d3719); +10 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on January 7th, 2015, 01:35 AM
Quote from CerealGuy on December 30th, 2014, 03:22 PM
Perhaps you should permit people to reply on this topic. I dont think that it needs "life", its only to keep track of new commits. In my opinion bugs should be discussed in an own topic.
It was locked since 2010 but I unlocked it last year because people were complaining they couldn't find a generic topic to discuss new commits.
Title: Re: New revs
Post by: Nao on January 7th, 2015, 05:23 PM
[Commit revision ef8bb14]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 07 Jan 2015 13:11:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ef8bb142220ff78fb21713f36674e5029fff00fc); +2 (insertions), -1 (deletion)


[Commit revision e1d338a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 07 Jan 2015 17:17:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e1d338a9767c727ba78bc7f32ba3d435a7e447d1); +0 (insertion), -1 (deletion)


Posted: January 7th, 2015, 05:18 PM

[Commit revision c71b8f4]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 07 Jan 2015 17:23:07 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c71b8f44e48fb4c901d020ced9c6ac5ab1717283); +3 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on January 7th, 2015, 10:09 PM
[Commit revision a04af74]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 07 Jan 2015 22:09:03 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/a04af741b627a814abc76203f6943646d201db9c); +4 (insertions), -8 (deletions)

Title: Re: New revs
Post by: Nao on January 11th, 2015, 01:02 AM
[Commit revision 39a3e11]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 11 Jan 2015 01:02:18 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/39a3e1119e617b6e1a06f36084fa9817cd547f8b); +31 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on January 16th, 2015, 12:54 AM
[Commit revision 147bc0f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 16 Jan 2015 00:53:37 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/147bc0fb99c26fc3e1e33b70045ac734605c9448); +37 (insertions), -69 (deletions)

Title: Re: New revs
Post by: Nao on January 17th, 2015, 01:43 AM
[Commit revision b7892c8]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 17 Jan 2015 01:43:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b7892c8ed63602cd33e53bebf25531b7694f666e); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 17th, 2015, 04:24 PM
[Commit revision 2391679]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 17 Jan 2015 16:24:14 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2391679524278e2d1b87171ee8f10aa7c50a4067); +9 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 21st, 2015, 06:50 PM
[Commit revision efa980e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 10:08:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/efa980e693251be0611390f1a598bb711e2d9e38); +1 (insertion), -1 (deletion)


[Commit revision 35c89bc]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 10:18:48 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/35c89bcc9f6b4e2a96ddbca230c608038a540188); +4 (insertions), -3 (deletions)


[Commit revision 7b5a702]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 15:14:43 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7b5a7029251cb4d67b70bb6560d694f7f9c1c47c); +1 (insertion), -1 (deletion)


[Commit revision fe4d11c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 15:16:17 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fe4d11c19cf8853263f00f6333922b70fbca6e48); +0 (insertion), -3 (deletions)


[Commit revision d686f19]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 15:28:59 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d686f19dacaef6390b1dedc3ca748e8f5476feed); +1 (insertion), -1 (deletion)


[Commit revision d555ceb]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 18:50:06 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d555ceb055350013eba76f70978f6a8a272445b0); +54 (insertions), -45 (deletions)

Title: Re: New revs
Post by: Nao on January 21st, 2015, 06:51 PM
[Commit revision 915e2fa]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 18:51:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/915e2fac8b998dbb3e837c08469c1321069c5e79); +8 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on January 21st, 2015, 08:41 PM
[Commit revision 2878033]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 20:13:15 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/2878033c86317b13cfd5380adfeaa7f9278a28a9); +66 (insertions), -76 (deletions)


[Commit revision da84ae5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 20:41:16 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/da84ae53b62c7fbf21f769bcdc47a3a8d8b6a20a); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 21st, 2015, 09:00 PM
[Commit revision cadbe86]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 20:59:55 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cadbe86b18b01f0d0e7aa7dd34582de56704f5c1); +4 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 21st, 2015, 11:50 PM
[Commit revision 4e7563c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 21 Jan 2015 23:50:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4e7563cca58670bf3d01b6914896ec27eeeb083a); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 22nd, 2015, 06:46 PM
[Commit revision 0f3cd29]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 22 Jan 2015 18:42:24 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0f3cd29f533b5a30d3d6f50580b26252deda839b); +5 (insertions), -13 (deletions)


[Commit revision 7a94d2f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 22 Jan 2015 18:46:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7a94d2f76477761c7afb4842b5b4be1a1a2bf90d); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 26th, 2015, 01:48 PM
[Commit revision 8681fee]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 23 Jan 2015 10:12:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8681feedb4b06481d5a7a6ce188c97e08a317a2e); +3 (insertions), -0 (deletion)


[Commit revision fb25a63]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 24 Jan 2015 12:21:01 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fb25a63bba2d07cec84d0f0e7eb1c258950c5bd5); +1 (insertion), -1 (deletion)


[Commit revision 7681f71]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Jan 2015 17:14:24 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7681f71038bd167aac53e35ef9f510faf6a63e38); +1 (insertion), -1 (deletion)


[Commit revision 543742a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Jan 2015 17:20:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/543742a241efcd82b9000d8d426bf80045fc7531); +2 (insertions), -2 (deletions)


[Commit revision 4be39a9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 26 Jan 2015 13:48:14 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4be39a9a3a9edb98f7c02f268eaa4ffdd0a1ef92); +16 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on February 3rd, 2015, 11:12 AM
[Commit revision 80dd2d3]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 02 Feb 2015 22:52:44 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/80dd2d3030a98ccbfa7202e593d6ac4cd1151f60); +2 (insertions), -1 (deletion)


[Commit revision 207f7e8]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 02 Feb 2015 23:37:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/207f7e856d4926b5cb3d8856aeca0d9dec8a2be3); +11 (insertions), -2 (deletions)


[Commit revision 0d03042]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 03 Feb 2015 11:12:18 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0d0304240e03a1efa316cc43781b0bd02f1051ce); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 3rd, 2015, 01:14 PM
[Commit revision 88287e9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 03 Feb 2015 13:14:06 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/88287e9df603bde54c3c5b0060471784102f28e8); +11 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on February 5th, 2015, 12:22 AM
[Commit revision 83975d2]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 05 Feb 2015 00:22:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/83975d216a8c29a0a590f5d2b36c57d52a3ba4f2); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 6th, 2015, 06:27 PM
[Commit revision 29fb45d]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 05 Feb 2015 10:33:06 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/29fb45dc12312f304068c4fbb3fe6a0dd854bc3b); +1 (insertion), -0 (deletion)


[Commit revision bd994ca]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 05 Feb 2015 18:34:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bd994caeece264b3615a2cc7106b5d8608366043); +5 (insertions), -4 (deletions)


[Commit revision 3e6a78b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Feb 2015 18:26:45 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3e6a78bd17f6690607b07959791d50a681575b97); +8 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on February 6th, 2015, 06:30 PM
[Commit revision 42a9772]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Feb 2015 18:30:37 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/42a977287acc58e4221e25a05017b353d7a7c1f7); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 12th, 2015, 04:53 PM
[Commit revision 39b639b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 10 Feb 2015 17:02:40 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/39b639b132c68bb48d350cbf4305170e801d7624); +1 (insertion), -1 (deletion)


[Commit revision b6ffd20]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 12 Feb 2015 16:53:27 +0100
Stats: 8 files changed(https://github.com/Wedge/wedge/commit/b6ffd20085bbf0f56c929d50b7a590d8722e27bf); +170 (insertions), -119 (deletions)

Title: Re: New revs
Post by: Nao on February 12th, 2015, 05:11 PM
[Commit revision 30d7978]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 12 Feb 2015 17:11:37 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/30d797882e7b10e1186e52b5ddb0e13eb6bf2fc5); +0 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on February 12th, 2015, 11:32 PM
[Commit revision 55e6fc6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 12 Feb 2015 23:32:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/55e6fc679fb685184374489ebba8bef429b22204); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 14th, 2015, 10:21 AM
[Commit revision 6708e26]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 14 Feb 2015 10:21:25 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/6708e26f65b2b7ec0c7104dbc9ee9e29936fd66c); +21 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on February 20th, 2015, 12:25 PM
[Commit revision bc4a740]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 20 Feb 2015 12:24:47 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/bc4a7400ea0491dfbcce70cd0c0881d2035d34fc); +4 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 21st, 2015, 12:35 AM
[Commit revision 3625523]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 20 Feb 2015 14:58:19 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3625523ceb342e2919f6e8315dde62107adc4e59); +8 (insertions), -0 (deletion)


[Commit revision 8e3f28a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Feb 2015 00:35:40 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/8e3f28abab050cdde019e902fef56dd76dc5c246); +11 (insertions), -57 (deletions)

Title: Re: New revs
Post by: Nao on February 25th, 2015, 04:52 PM
[Commit revision ea7438e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 25 Feb 2015 16:17:23 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/ea7438efaf8520d060350dd63ba2e7e71f73ef4d); +12 (insertions), -5 (deletions)


[Commit revision 7dd4d09]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 25 Feb 2015 16:21:18 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7dd4d095539e15f1917687bcac5bd4b4285b45d7); +2 (insertions), -2 (deletions)


[Commit revision 4d65a29]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 25 Feb 2015 16:52:28 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4d65a299dbb29aea8faf05c9383841efdd9ba2d1); +9 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 3rd, 2015, 12:05 PM
[Commit revision 303b49d]
(https://avatars.githubusercontent.com/u/1673416?v=3)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Tue, 03 Mar 2015 09:27:43 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/303b49d5bf8bb68d295c8133cf048824eaf5a40b); +1 (insertion), -1 (deletion)


[Commit revision 103ee4f]
(https://avatars.githubusercontent.com/u/1673416?v=3)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Tue, 03 Mar 2015 10:25:17 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/103ee4f28b6a76d855f072feeb0fbd0d83f47d30); +2 (insertions), -2 (deletions)


[Commit revision 6e662c0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 03 Mar 2015 12:05:20 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6e662c06f9111aa10dcaee387549f328bd5e9ad4); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 17th, 2015, 07:58 PM
[Commit revision 4484e0d]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 27 Feb 2015 16:20:26 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4484e0d09ca34e77992e3fcffb9801291616e1a3); +10 (insertions), -2 (deletions)


[Commit revision b819085]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 01 Mar 2015 13:04:09 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b819085eeed3d69ba542c15124e53ec643489647); +1 (insertion), -1 (deletion)


[Commit revision 40ed7a7]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 17 Mar 2015 19:57:17 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/40ed7a7935a1aebdc6e673c78510ef6ea67255bf); +2 (insertions), -1 (deletion)


[Commit revision 9f1aed2]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 17 Mar 2015 19:57:40 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9f1aed24b47c2dffc34ee87e4212dc3bae2b397e); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 18th, 2015, 08:32 PM
[Commit revision 6294c91]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 18 Mar 2015 20:32:17 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6294c9139d172d67e87a0e31574932bf34d0ba72); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on April 3rd, 2015, 05:52 PM
[Commit revision 61584fd]
(https://avatars.githubusercontent.com/u/1673416?v=3)Author: Pandos(https://github.com/Pandos) (Signed-off)
Date: Fri, 06 Mar 2015 08:19:33 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/61584fd9786e75d9f8098663bf9f8584f9e14019); +54 (insertions), -12 (deletions)


[Commit revision c267f8c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 03 Apr 2015 17:52:11 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/c267f8c78e35f005e6c64484c26e0b3737d1f5e0); +54 (insertions), -12 (deletions)

Title: Re: New revs
Post by: Nao on April 3rd, 2015, 05:52 PM
[Commit revision 3e4d49b]
(http://)Author: (http://)
Date: Thu, 19 Mar 2015 18:06:12 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3e4d49b8bf7499c58f204261146dd56c8b2db0cb); +6 (insertions), -3 (deletions)


[Commit revision 2c4be67]
(http://)Author: (http://)
Date: Wed, 01 Apr 2015 01:25:45 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2c4be67340bb626608edefb5e575f113d503176e); +2 (insertions), -2 (deletions)


[Commit revision e2cf9ae]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 03 Apr 2015 17:52:22 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/e2cf9aeae86d60f6f08b109c4f979d873df6651d); +8 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on April 3rd, 2015, 06:04 PM
[Commit revision 5eee7c6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 03 Apr 2015 17:57:16 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5eee7c6c2d9e26e84073f7c0bf6faf48cc3e1a0c); +14 (insertions), -14 (deletions)

Title: Re: New revs
Post by: Nao on April 4th, 2015, 05:34 PM
[Commit revision c72697a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 04 Apr 2015 16:11:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c72697adc77c9677f9c5f5a2863b45414d85afff); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 24th, 2015, 07:33 PM
[Commit revision 562973b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 24 Apr 2015 19:33:46 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/562973b370de74f9c3aef00987e073b975d8079d); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on May 5th, 2015, 10:55 AM
[Commit revision ce57cf6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 05 May 2015 10:54:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ce57cf6c2d3d5db41c263335bcf934c33248c7b0); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 5th, 2015, 11:15 AM
[Commit revision 3697429]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 05 May 2015 11:15:29 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3697429459dafd7702376c3250f4139cb8801adb); +3 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on May 6th, 2015, 10:53 AM
[Commit revision b7be718]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 06 May 2015 10:53:17 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/b7be71838aa66ecb2b3287407869ed7656c271aa); +10 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on May 13th, 2015, 03:54 PM
[Commit revision 8dd375d]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 13 May 2015 15:48:13 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8dd375d12d905f0e5eb93ce224ba89450926bc21); +4 (insertions), -4 (deletions)


Posted: May 13th, 2015, 03:48 PM

Okay, maybe not BILLIONS of embeds, since it's only for websites that do some tinkering with their API before reposting links, but you know what I mean. They could just as easily have redirected the old v2 URLs to the v3 equivalents, it's so sloppy on their part...
Title: Re: New revs
Post by: Nao on May 24th, 2015, 09:48 AM
[Commit revision 149cdd6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 24 May 2015 09:48:30 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/149cdd61af937ed45182add80e2fd19fe3732831); +0 (insertion), -12 (deletions)

Title: Re: New revs
Post by: Nao on July 19th, 2015, 02:05 AM
[Commit revision cb215ad]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Sun, 19 Jul 2015 02:04:03 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/cb215ad5721340f9f89a009c0c5e71b0c3f80036); +3 (insertions), -3 (deletions)


PS: apparently, I just beat my record for longest time without a commit... 56 days! It's all on Witcher 3 :P
Title: Re: New revs
Post by: Nao on August 20th, 2015, 03:03 PM
[Commit revision 7f06d9b]
(http://)Author: (http://)
Date: Fri, 12 Jun 2015 00:16:12 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/7f06d9b12c09cb125ca9b2bafcf71cc662d4cfa8); +17 (insertions), -8 (deletions)


[Commit revision f6a4b02]
(http://)Author: (http://)
Date: Fri, 12 Jun 2015 00:20:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f6a4b027d565529afea45d40cec39fa5b7a3700c); +3 (insertions), -3 (deletions)


[Commit revision a7ea272]
(http://)Author: (http://)
Date: Sat, 04 Jul 2015 13:48:05 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/a7ea272d70484681a56db2a53c008ea81c802d3f); +17 (insertions), -14 (deletions)


[Commit revision 87bf4c5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Aug 2015 15:03:18 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/87bf4c52323a7d7d4b3f5fa74914820539435c6c); +23 (insertions), -11 (deletions)

Title: Re: New revs
Post by: Nao on August 21st, 2015, 01:07 PM
[Commit revision df4d8fa]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 20 Aug 2015 15:06:25 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/df4d8faf2a62e7d04c7c21436cf5643f2eb7bb7f); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on September 8th, 2015, 09:31 AM
[Commit revision 058f163]
(http://)Author: (http://)
Date: Wed, 15 Jul 2015 15:21:14 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/058f1639d1ca118f38de5121635adcbcd252f44d); +6 (insertions), -3 (deletions)


[Commit revision 529c041]
(http://)Author: (http://)
Date: Wed, 15 Jul 2015 15:55:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/529c0413859f8538d1a260f8d71eb3a2ab51caec); +2 (insertions), -1 (deletion)


[Commit revision f278947]
(http://)Author: (http://)
Date: Tue, 28 Jul 2015 00:52:30 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/f278947d38bfe5ac6f2ea0ec3678861bd4d5f9ad); +3 (insertions), -3 (deletions)


[Commit revision a274925]
(http://)Author: (http://)
Date: Sun, 16 Aug 2015 14:31:26 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a27492581d5295b9e2eea76933e100755ab0da78); +2 (insertions), -1 (deletion)


[Commit revision b60ebf0]
(http://)Author: (http://)
Date: Sun, 16 Aug 2015 14:33:45 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b60ebf0a69ca3361cb8b2bf7f9ccc7942de77bf0); +0 (insertion), -1 (deletion)


[Commit revision 5875683]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Sep 2015 09:31:11 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/5875683a465ceb873da26bb6e6461bf552f487b0); +7 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on September 8th, 2015, 09:34 AM
[Commit revision 3c844de]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 08 Sep 2015 09:33:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3c844de7e10fd00573b5aa62b75c3b731ec9f182); +2 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on September 13th, 2015, 02:58 PM
[Commit revision d6833e4]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 13 Sep 2015 14:58:20 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d6833e49d1a9ca8f8d59c5cb1ea6ef1c360c3003); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on September 13th, 2015, 03:20 PM
[Commit revision 0cd9107]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 13 Sep 2015 15:20:33 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/0cd910721ca98c591928f284d5bd785c59142434); +7 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on July 16th, 2016, 03:28 PM
[Commit revision d840d94]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 00:11:04 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d840d941f8140540ab6dfb64dc9e3e4f258f4405); +25 (insertions), -20 (deletions)


[Commit revision f4d68ce]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 00:21:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f4d68ce3675c1bba975202d493873dda9ac0f0fe); +20 (insertions), -25 (deletions)


[Commit revision 1f644a9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 27 May 2014 00:21:49 +0200
Stats: 22 files changed(https://github.com/Wedge/wedge/commit/1f644a9941af56071cf7b8e51d0da4708374e934); +147 (insertions), -121 (deletions)


[Commit revision 6eb2d5b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 01 Jun 2014 23:50:19 +0200
Stats: 25 files changed(https://github.com/Wedge/wedge/commit/6eb2d5b2048fa6f073cc8c8cdde8666c6d0454a7); +217 (insertions), -235 (deletions)


[Commit revision 6c4e6ab]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jun 2014 17:25:15 +0200
Stats: 21 files changed(https://github.com/Wedge/wedge/commit/6c4e6aba0bbd0fa77d8495d93b57a0cb3e6fb317); +128 (insertions), -94 (deletions)


[Commit revision 360b9ef]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 05 Jun 2014 00:42:21 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/360b9ef75eab0c934ee997b9b39d5cde2914ae4d); +6 (insertions), -2 (deletions)


[Commit revision 3383030]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 12:21:49 +0200
Stats: 13 files changed(https://github.com/Wedge/wedge/commit/33830302d3aab7b166819f1ce005851343473a2b); +73 (insertions), -57 (deletions)


[Commit revision c655903]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 06 Jun 2014 13:17:33 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/c6559032ffd228285ede891fd2903fb9ae8f065e); +15 (insertions), -25 (deletions)


[Commit revision 7dc2a87]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 17 Jun 2014 00:24:00 +0200
Stats: 26 files changed(https://github.com/Wedge/wedge/commit/7dc2a8787208beec617dfebb19d77c5c8881d9fb); +344 (insertions), -207 (deletions)


[Commit revision 5f680fb]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jun 2014 00:32:06 +0200
Stats: 39 files changed(https://github.com/Wedge/wedge/commit/5f680fbdc76a983971c507480d051fd699ad042d); +125 (insertions), -131 (deletions)


[Commit revision 7bff692]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 06 Jul 2014 00:09:35 +0200
Stats: 30 files changed(https://github.com/Wedge/wedge/commit/7bff692b803b31d617618d237952b41e18fc2e0b); +536 (insertions), -136 (deletions)


[Commit revision 688f1ad]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 24 Jul 2014 21:02:28 +0200
Stats: 12 files changed(https://github.com/Wedge/wedge/commit/688f1adcfe38bd4cdab27998a7063a57a5f8988a); +101 (insertions), -59 (deletions)


[Commit revision 4e79611]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 27 Jul 2014 16:39:18 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/4e79611694dc63797c2b6092c8a22c82a559c1da); +25 (insertions), -17 (deletions)


[Commit revision ba7c543]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 17 Aug 2014 00:51:56 +0200
Stats: 24 files changed(https://github.com/Wedge/wedge/commit/ba7c543ca6a9104ad1e7b5ebc4e85659b0f421ff); +462 (insertions), -285 (deletions)


[Commit revision 433f734]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 23 Aug 2014 00:47:45 +0200
Stats: 16 files changed(https://github.com/Wedge/wedge/commit/433f7344a04b455a4fe3ee767ff5e9ef780fe135); +68 (insertions), -43 (deletions)


[Commit revision 8ff88a5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 23 Aug 2014 00:51:06 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8ff88a5b7390f1e97baa5adcb608e780b8d6e103); +0 (insertion), -0 (deletion)


[Commit revision 07821ed]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Aug 2014 20:11:56 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/07821ed719bf5b9899363edee76d2d6f182fea1a); +14 (insertions), -12 (deletions)


[Commit revision 378613b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 11 Sep 2014 21:32:46 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/378613b19d701f1d1fcaa77d584ee0207bffb612); +2 (insertions), -2 (deletions)


[Commit revision 2b4eb99]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Oct 2014 11:06:26 +0100
Stats: 49 files changed(https://github.com/Wedge/wedge/commit/2b4eb99f7e7cc4cab2f9affa4b6a3bb912f9384c); +289 (insertions), -251 (deletions)


[Commit revision 27d3d51]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 10 Jan 2015 09:40:20 +0100
Stats: 37 files changed(https://github.com/Wedge/wedge/commit/27d3d514fc48910ad73574547cfdcb276fbc3441); +602 (insertions), -409 (deletions)


[Commit revision 6f07c9a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 11 Jan 2015 01:05:27 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6f07c9a35c9f1ad835b1ba76ff4c275859baebb7); +31 (insertions), -16 (deletions)


[Commit revision 6825e07]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 22 Jan 2015 18:12:16 +0100
Stats: 15 files changed(https://github.com/Wedge/wedge/commit/6825e079d20394aea033be5a610e09d8c7fa59a4); +182 (insertions), -216 (deletions)


[Commit revision 6e92893]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 23 Jan 2015 10:12:35 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/6e928934aca057468e087aff7d8fddd833e75756); +6 (insertions), -14 (deletions)


[Commit revision 9845438]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 13 Feb 2015 18:05:46 +0100
Stats: 22 files changed(https://github.com/Wedge/wedge/commit/9845438906990817a7872be9cd50d172fe779918); +235 (insertions), -176 (deletions)


[Commit revision dfba765]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 20 Feb 2015 09:59:41 +0100
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/dfba765f6bd817347d66d058b2332de496249b3d); +21 (insertions), -19 (deletions)


[Commit revision 968e1d5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 17 Mar 2015 19:58:46 +0100
Stats: 12 files changed(https://github.com/Wedge/wedge/commit/968e1d5e3ab38984ee2fa582f957cf9b74af5ca1); +61 (insertions), -75 (deletions)


[Commit revision f3b2018]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 04 Apr 2015 17:33:15 +0200
Stats: 8 files changed(https://github.com/Wedge/wedge/commit/f3b20188fcec25be8adc0d3524359234224a0b86); +81 (insertions), -36 (deletions)


[Commit revision 8b0fad1]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 04 Apr 2015 17:34:21 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8b0fad16e414a66df39e6686393ff56d06ffb8d5); +1 (insertion), -1 (deletion)


[Commit revision bcc4a61]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 13 Sep 2015 15:38:51 +0200
Stats: 17 files changed(https://github.com/Wedge/wedge/commit/bcc4a612c66154119573f3c2c154e836236bfae9); +53 (insertions), -51 (deletions)


[Commit revision f5e65c0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Sat, 16 Jul 2016 15:27:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f5e65c0322bb6daadee042efa7244fab65a946cc); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on July 16th, 2016, 11:22 PM
[Commit revision 6d9eb6a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Sat, 16 Jul 2016 23:21:21 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6d9eb6acec39c924149b7388bb45d5287b241bef); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on July 18th, 2016, 11:11 PM
[Commit revision d71cdbe]
(https://avatars.githubusercontent.com/u/470357?v=3)Author: nsgomez(https://github.com/nsgomez)
Date: Mon, 18 Jul 2016 23:11:08 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/d71cdbe9438a53354866493fd18e63f1a74d228e); +1 (insertion), -2 (deletions)

Title: Re: New revs
Post by: Nao on July 19th, 2016, 10:16 AM
[Commit revision 7d3956e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Tue, 19 Jul 2016 10:15:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7d3956e6138d186f1bba5d9266e1bbcec32c1c21); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on July 19th, 2016, 10:16 AM
(Feels so weird to see this topic alive...... ;))
Title: Re: New revs
Post by: Jurien on July 19th, 2016, 08:41 PM
Quote from Nao on July 18th, 2016, 11:11 PM
  • width of 0 should be less hacky. Thanks @nsgomez
width of 0 in section.css
.postarea
        width
0
padding0 15px
@if 
$can_flex
displayflex
flex-directioncolumn
flex1 0 1em
Breaks up postarea in skin Wilde
(http://i.imgur.com/MbKfhqH.png)
Title: Re: New revs
Post by: nsgomez on July 20th, 2016, 03:25 PM
@Freñiçh Weird, I can't reproduce this. What browser is that?
Title: Re: New revs
Post by: Jurien on July 20th, 2016, 07:58 PM
Quote from nsgomez on July 20th, 2016, 03:25 PM
What browser is that?
Firefox Version 47.0
Title: Re: New revs
Post by: nsgomez on July 21st, 2016, 07:43 PM
Quote from Freñiçh on July 20th, 2016, 07:58 PM
Quote from nsgomez on July 20th, 2016, 03:25 PM
What browser is that?
Firefox Version 47.0
Very odd, I just tried Firefox 47 on Linux on a Wedge forum I run with these revisions and I can't reproduce it.
Title: Re: New revs
Post by: Jurien on July 21st, 2016, 08:43 PM
Well when i add that line into section.css it breaks immediately postrarea,it doesn't matter which skin i choose or even purge cache,so it's no option for me to use width of 0.
Title: Re: New revs
Post by: CerealGuy on July 21st, 2016, 11:30 PM
@Freñiçh did you try using the file from github and not modifying it on your own?
The CSS preprocessing of wedge is quite resistant to failure, but you never know? Can't reproduce it with Mozilla Firefox 47.0.1. Do you have this problem on wedge.org too?
And did you try using a different browser?


  (https://i.imgur.com/8uKgxW5.png)
(http://i.imgur.com/8uKgxW5.png)

@Nao can we split this off-topic discussion? Or is it fine that the New revs topic is alive? :P
Title: Re: New revs
Post by: Jurien on July 22nd, 2016, 07:39 AM
Quote from CerealGuy on July 21st, 2016, 11:30 PM
@Freñiçh did you try using the file from github and not modifying it on your own? The CSS preprocessing of wedge is quite resistant to failure, but you never know?
That's a good one,have manually modify and edited this file,upload the file via FTP and it works.did not realize it would have such an impact!!

Edit:
Quote from CerealGuy
Do you have this problem on wedge.org too?
No not the problem that postarea breaks up.
However this is still not looking good on Wedge.org.
Reply#8(http://wedge.org/pub/support/8817/why-i-get-error-500-and-have-alot-proplems/msg297300/#msg297300)





Title: Re: New revs
Post by: CerealGuy on July 22nd, 2016, 12:56 PM
Quote from Freñiçh on July 22nd, 2016, 07:39 AM
Edit:
Quote from CerealGuy
Do you have this problem on wedge.org too?
No not the problem that postarea breaks up.
However this is still not looking good on Wedge.org.
Reply#8(http://wedge.org/pub/support/8817/why-i-get-error-500-and-have-alot-proplems/msg297300/#msg297300)
Can you provide a screenshot? Don't see anything wrong there.
Title: Re: New revs
Post by: Jurien on July 23rd, 2016, 01:09 AM
screenshot reply#8(http://imgur.com/a/T8c8J)
Title: Re: New revs
Post by: CerealGuy on July 23rd, 2016, 01:20 AM
Hmm which firefox version are you using exactly? What happens if you play around with the width setting of .postarea in your browser (with the dev tools). Try changing it to inherit or 75%.
Title: Re: New revs
Post by: Jurien on July 23rd, 2016, 10:29 AM
Quote from CerealGuy on July 23rd, 2016, 01:20 AM
Hmm which firefox version are you using exactly? What happens if you play around with the width setting of .postarea in your browser (with the dev tools). Try changing it to inherit or 75%.
Firefox 47.0 Mozilla Firefox,and FireJail 47.0 both for Linux Mint (perhaps that's the problem ??)
changing width setting browser makes no difference
Title: Re: New revs
Post by: CerealGuy on July 24th, 2016, 10:33 PM
Quote from Freñiçh on July 23rd, 2016, 10:29 AM
Firefox 47.0 Mozilla Firefox,and FireJail 47.0 both for Linux Mint (perhaps that's the problem ??)
changing width setting browser makes no difference
Don't think that Mint is the problem. I'm using arch on my own. Would it be possible that you try it with a newer version of firefox and chromium/chrome?
Title: Re: New revs
Post by: Nao on July 25th, 2016, 02:49 PM
[Commit revision d14868c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Jul 2016 14:49:30 +0200
Stats: 8 files changed(https://github.com/Wedge/wedge/commit/d14868c55f8e6386ea49e54359d9cba0650fae50); +9 (insertions), -9 (deletions)


[Commit revision 7d44367]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Jul 2016 14:49:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7d44367cc3f801dfe5960b90266e1e9f7fded000); +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on July 25th, 2016, 07:03 PM
[Commit revision c5277ec]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 25 Jul 2016 19:03:22 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/c5277ec607c15cad7551e341de35523355d29dec); +8 (insertions), -8 (deletions)

Title: Re: New revs
Post by: Nao on August 2nd, 2016, 02:54 PM
[Commit revision 489446f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 02 Aug 2016 14:54:14 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/489446f1f197eb4fa2af1acc8de7dceb15bbb436); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on August 3rd, 2016, 10:08 PM
Quote from CerealGuy on July 24th, 2016, 10:33 PM
Don't think that Mint is the problem. I'm using arch on my own. Would it be possible that you try it with a newer version of firefox and chromium/chrome?
I can always switch to the alternative solution for him to test, if you want... (And if he's still around!)
Title: Re: New revs
Post by: Nao on August 17th, 2016, 03:44 PM
[Commit revision 16e1651]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Wed, 17 Aug 2016 15:44:48 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/16e16510e108ad1b15d8686e1509a9a77d52d873); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on August 17th, 2016, 03:55 PM
[Commit revision 38f7604]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 02 Aug 2016 22:26:42 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/38f76040ac8f17fd706abc067903f218a9b425c3); +1 (insertion), -1 (deletion)


[Commit revision b23f38e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 02 Aug 2016 22:54:45 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b23f38e7b4214b21e0caa74823d3948c3be782df); +1 (insertion), -1 (deletion)


[Commit revision afbe3fe]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Aug 2016 15:45:19 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/afbe3fee59869fc73534a310e155587491917fa2); +1 (insertion), -1 (deletion)


[Commit revision 276273c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Wed, 17 Aug 2016 15:50:28 +0200
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/276273c800a3e0515e249c58dcec8cf6f3d5f895); +15 (insertions), -19 (deletions)


[Commit revision de9c189]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Wed, 17 Aug 2016 15:50:40 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/de9c18975890e7597d2f012db89e7680a62d1247); +1 (insertion), -1 (deletion)


[Commit revision 4ac6905]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 17 Aug 2016 15:54:57 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4ac6905f2a2276447f756259cb2b81b4f6baf586); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on August 19th, 2016, 10:44 AM
[Commit revision bdfb3ea]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 19 Aug 2016 10:44:26 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/bdfb3ea20e2b3516c1cd98872bc01cd0e4bb24e4); +1 (insertion), -5 (deletions)

Title: Re: New revs
Post by: Nao on August 27th, 2016, 12:57 AM
[Commit revision 241b8c5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Aug 2016 00:09:11 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/241b8c50ef28e2953fd6436eb55cf13c76c72419); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on September 16th, 2016, 11:14 AM
[Commit revision 14c4ea6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Fri, 16 Sep 2016 11:09:58 +0200
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/14c4ea60a02c04787834ad73ccaa86e793b3cc18); +72 (insertions), -59 (deletions)


[Commit revision 71594a8]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Fri, 16 Sep 2016 11:14:30 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/71594a84705aa38a98f3efe798d7377b95604439); +6 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on September 16th, 2016, 11:30 AM
[Commit revision 2e507da]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao) (Signed-off)
Date: Fri, 16 Sep 2016 11:30:00 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2e507da3959ab096f666be1176f83f1d87fe0cd6); +2 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on September 16th, 2016, 12:55 PM
[Commit revision 1e5c171]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 16 Sep 2016 12:36:08 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1e5c171ae5c9a47c7372e5b8b744d74d33bfe182); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on September 25th, 2016, 03:38 PM
[Commit revision 18dee46]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Sep 2016 15:29:13 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/18dee46dec80c57df728064e633e2eb6b721a433); +15 (insertions), -1 (deletion)


[Commit revision ad3a277]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Sep 2016 15:30:57 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ad3a277b9b518774d23fc24cb0798022521f39e9); +18 (insertions), -28 (deletions)


[Commit revision a6ab3dd]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Sep 2016 15:32:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a6ab3dd4bf3989bccfd73a5c1f414c75a775db4e); +9 (insertions), -0 (deletion)


[Commit revision e22ec54]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Sep 2016 15:36:26 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e22ec546a876aaa71314db075cb62cb52f1dcf90); +4 (insertions), -2 (deletions)


[Commit revision d41f147]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 25 Sep 2016 15:38:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d41f147d2edc5661e44a31335fe63828219aae8d); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on September 27th, 2016, 02:32 PM
[Commit revision 9f59d42]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 27 Sep 2016 14:30:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9f59d4284378079b4840623185a3c87b763a21c6); +7 (insertions), -7 (deletions)


[Commit revision 4633689]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 27 Sep 2016 14:31:50 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/463368976daf3110de1be23fda3b1a475c786d4b); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on October 1st, 2016, 07:39 PM
[Commit revision 3758508]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Sat, 01 Oct 2016 19:39:44 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/37585082c047a72605883031fbcaf11b73c512e6); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on October 2nd, 2016, 02:57 PM
[Commit revision f3d603f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Oct 2016 14:56:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f3d603f8ed4ae773619a429ffab5fc6ae307ecae); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 2nd, 2016, 11:26 PM
[Commit revision 904a392]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Oct 2016 15:41:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/904a39201c6fc85c1d1989c6dd2fa48e6fbdf5e5); +1 (insertion), -1 (deletion)


[Commit revision 23cb8a3]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 02 Oct 2016 23:25:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/23cb8a34c4b5e965c7b80fcc7d1940e798362c75); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 8th, 2016, 01:56 PM
[Commit revision 810186f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 08 Oct 2016 13:56:14 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/810186fcc0d13c81d2c29a2e4d1682924dcd4eaf); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on October 9th, 2016, 11:54 PM
[Commit revision 660aa41]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Oct 2016 23:53:23 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/660aa41b500fd5e2135897de54f767624f5f7a2d); +8 (insertions), -1 (deletion)


[Commit revision e8cb752]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 09 Oct 2016 23:53:42 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/e8cb7526a0d66c8399a13156825ade8d47978e10); +12 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on October 16th, 2016, 12:41 PM
[Commit revision c8b6c4a]
(http://)Author: (http://)
Date: Sun, 16 Oct 2016 12:23:44 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c8b6c4af1185bf3c9fe1a516b9999c091822db13); +4 (insertions), -4 (deletions)


[Commit revision 41fb853]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Oct 2016 12:41:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/41fb85366f5f244074c59b19494f86e0f1f8e23c); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on October 19th, 2016, 03:12 PM
[Commit revision 238b833]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Oct 2016 15:06:40 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/238b8332d7fbde27144d61c5f16d8774049bf3c1); +5 (insertions), -0 (deletion)


[Commit revision cb7412f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Oct 2016 15:09:49 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cb7412facc077379364ecc31d55f0022680340b7); +14 (insertions), -2 (deletions)


[Commit revision b51f7d0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Oct 2016 15:11:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b51f7d0850fc2d2d12c2811be1fcfcf68689ad36); +1 (insertion), -1 (deletion)


[Commit revision b8ae0a2]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Oct 2016 15:12:02 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b8ae0a24ee0b1b00e0b8e74606999dc66a48fba1); +8 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on October 19th, 2016, 03:59 PM
(I don't think the avatar fix is complete; it's complete on my other site but I couldn't find more data to move over. Needs some testing, then!)
Title: Re: New revs
Post by: Nao on October 21st, 2016, 03:13 PM
[Commit revision 6de24f9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Oct 2016 13:45:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6de24f9a6bb8b2377ed3c2711a70c0846cb81b5d); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 23rd, 2016, 03:55 PM
[Commit revision 608035c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Oct 2016 15:55:21 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/608035c53ef40ba576b5cbaa27447222229d7af6); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 23rd, 2016, 04:03 PM
[Commit revision 60d3de9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 23 Oct 2016 16:02:45 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/60d3de9b64aac352d561f8afdf10d1e1f233c1ca); +113 (insertions), -112 (deletions)

Title: Re: New revs
Post by: Nao on October 24th, 2016, 01:08 AM
[Commit revision 316a6c6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Oct 2016 01:08:06 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/316a6c6b91a8e681325ea6555928cf8c67c62daf); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on October 24th, 2016, 01:16 AM
[Commit revision 119f001]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 24 Oct 2016 01:16:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/119f0010e9eac0592294fdd1addd48479beb8f4f); +4 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on October 24th, 2016, 09:32 AM
Quote from Nao on October 24th, 2016, 01:08 AM
(2) parse_str() actually does an implicit urldecode() on the query string, so if $_GET was getting a value of '%2B', it would first be turned into '+' by the first urldecode(), then into a space by the second implicit one.
Interesting note--
http://dev.simplemachines.org/mantis/view.php?id=2669

I actually made a commit in 2010 to the SMF codebase (that was later reverted in 2011) adding the urldecode(), so it was partly me ahah. But this was only to help Thorsten who apparently had webmail problems that were fixed with that. Basically: these webmails would turn semicolons into their url-encoded versions, so they wouldn't be spotted by SMF/Wedge at the time of analyzing the query string. So, the real culprits were:
- the original PHP authors, for putting an implicit (and illogical) urldecode() into parse_str()
- the PHP.net documentation writers, for not mentioning it...
- the original SMF writers, for not noticing it (I couldn't blame them for that!)
- German webmails (?) that didn't correctly apply encoding standards on URLs. (In my view, these are the worse offenders...)
- and SMF developers (mostly Thorsten, Norv and I, since we all looked into this), for relying on double-urldecoding to fix that, without ever considering that it could break strings that were urlencoded for a reason on the sender's side.

So yeah, it's a shared blame I guess. Due to this mess, SMF was broken for a while due to improperly decoded $_GET strings... And this probably had *many* consequences on the codebase for the years that came, e.g. creating bugs that weren't spotted in that place but 'hastily fixed' in another, and that hopefully this revert won't re-trigger. Just incredible.
Title: Re: New revs
Post by: Nao on November 10th, 2016, 05:12 PM
[Commit revision a9ce176]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 10 Nov 2016 17:04:17 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/a9ce1762ad85aeb14320bbc8667c4560b4891ee1); +2 (insertions), -2 (deletions)


[Commit revision d7369ba]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 10 Nov 2016 17:11:37 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d7369ba8aadabbb3fdcc2bfb0416a4fe1dcd3378); +25 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on November 11th, 2016, 12:45 AM
[Commit revision 9e65369]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 11 Nov 2016 00:45:12 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9e65369b7e84227afb2eba92632af32364af701c); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on November 11th, 2016, 12:50 AM
[Commit revision c8e81fa]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 11 Nov 2016 00:50:15 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c8e81fab459b4f7a069c596292bf78eb1286673e); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on December 14th, 2016, 10:15 AM
[Commit revision 17de122]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 14 Dec 2016 10:15:09 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/17de1225483278bcbcad8cba091cb9750d360655); +9 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on December 19th, 2016, 04:47 PM
[Commit revision ff49935]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 19 Dec 2016 16:47:06 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/ff4993519f166d2c2bc55dbf624bc4b507ccdad5); +6 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on January 4th, 2017, 09:06 PM
[Commit revision 3802cca]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 04 Jan 2017 21:06:42 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3802cca0ba3a6d527ac28614a1918feeb4a44bb1); +7 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on January 8th, 2017, 09:33 PM
[Commit revision 4137fe0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 08 Jan 2017 21:33:00 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4137fe0c8f6c7c03f47c191e2ca79917816fe3c0); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 16th, 2017, 11:45 PM
[Commit revision 3acb8b9]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Mon, 16 Jan 2017 13:36:42 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3acb8b9f6accf408baf5d296affbd12918d885eb); +15 (insertions), -5 (deletions)


[Commit revision 8a8596b]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Jan 2017 23:45:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8a8596b76267a1f541fad1f9b98c473e8582a527); +15 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on January 16th, 2017, 11:46 PM
[Commit revision f2f0a94]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Sun, 15 Jan 2017 14:21:52 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f2f0a94b5eefce369885f547c58f0a8555e9bd1b); +1 (insertion), -0 (deletion)


[Commit revision f84a913]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Jan 2017 23:46:27 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f84a913ce8534a2f305632a806cd04a1f5f77900); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on January 16th, 2017, 11:48 PM
[Commit revision fd22890]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Jan 2017 23:48:14 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/fd228908a3ff3a891a11f53cd410e8a32372391a); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 16th, 2017, 11:51 PM
[Commit revision 9b2ce98]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Sat, 14 Jan 2017 12:36:08 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9b2ce988fec12a9dc12d800fab553c86896db520); +13 (insertions), -6 (deletions)


[Commit revision 5c40f54]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Jan 2017 23:51:45 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5c40f549853200662137417db037413a50599ce9); +13 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on January 16th, 2017, 11:55 PM
[Commit revision f1557f9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Jan 2017 23:55:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f1557f9f07728195edbf9496e591f8035ab3fdad); +1 (insertion), -1 (deletion)


[Commit revision 323986d]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Jan 2017 23:55:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/323986d85352fe55248f446c16ec50ecc0d3327d); +13 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on January 19th, 2017, 11:57 AM
[Commit revision c3dda12]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Wed, 18 Jan 2017 21:41:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c3dda129d239966f8e7692f952c3370bf66c3e2c); +1 (insertion), -1 (deletion)


[Commit revision 5522202]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 19 Jan 2017 11:57:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5522202ef916a5e22ecb61b296a8a5a80c7b3664); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 20th, 2017, 06:55 PM
[Commit revision d0fe5c4]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 20 Jan 2017 18:55:04 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d0fe5c4061d164ad6a745aaff7864ace871a2321); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 24th, 2017, 11:58 PM
[Commit revision f1bbb2a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 21 Jan 2017 23:48:29 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/f1bbb2aae4e5ddbf51e0ff1a69d2270b48734f26); +2 (insertions), -6 (deletions)


[Commit revision 7ae7331]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jan 2017 23:38:27 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7ae7331463597e3012644dcfe5703840400e2373); +9 (insertions), -1 (deletion)


[Commit revision fa107a7]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jan 2017 23:42:23 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fa107a799b5b38e3b5a8d45da435d148f93d2f42); +1 (insertion), -0 (deletion)


[Commit revision 7bd17c2]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jan 2017 23:45:16 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7bd17c24209a3d353d3547c386557ee660396bd5); +1 (insertion), -1 (deletion)


[Commit revision 933a87e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jan 2017 23:50:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/933a87e7d967306e487028f4924a799df7eaa32c); +8 (insertions), -3 (deletions)


[Commit revision ed2e23e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jan 2017 23:51:42 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ed2e23ecf22322e18f4c5e68e2e73230ea2ecb90); +1 (insertion), -1 (deletion)


[Commit revision 174ad41]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Jan 2017 23:57:48 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/174ad412bc7bb8fddb3f0074d0b469bf4499de12); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on January 25th, 2017, 11:24 PM
[Commit revision 3b7dbd4]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 25 Jan 2017 23:20:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3b7dbd45b88ce5accf7cd1ef409cd025002921de); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 25th, 2017, 11:26 PM
[Commit revision e108c9a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 25 Jan 2017 23:25:56 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e108c9a1bc2a225c1d2a7ce9ca56972e9e8fff8b); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on January 26th, 2017, 11:48 PM
[Commit revision 34c8223]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Sun, 15 Jan 2017 13:10:09 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/34c822333cb7efd7e0db2a90621ce7ceec5adbd5); +3 (insertions), -3 (deletions)


[Commit revision dca5de1]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 26 Jan 2017 23:48:39 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dca5de138fb28737bd695bab82f62a910b675f03); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on January 27th, 2017, 11:55 PM
[Commit revision db87766]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 26 Jan 2017 11:07:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/db877666b969911ef1efad6856068eb31d7b7122); +1 (insertion), -1 (deletion)


[Commit revision c988813]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 26 Jan 2017 23:48:50 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c98881370fdb359343ad2dbecd7ef76db772c431); +3 (insertions), -3 (deletions)


[Commit revision 14f9311]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 27 Jan 2017 23:17:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/14f9311c46f241d41498b5860d032b4b8ea72bbb); +1 (insertion), -1 (deletion)


[Commit revision 8e86565]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 27 Jan 2017 23:55:13 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/8e8656549b8411d7f104b2bc02cb59643e100339); +47 (insertions), -44 (deletions)

Title: Re: New revs
Post by: Nao on February 5th, 2017, 03:45 AM
[Commit revision 4ccaed6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 03:45:06 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/4ccaed6a614b4e2572d796200b420b82d0f3e414); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on February 5th, 2017, 08:33 PM
[Commit revision 435c54a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 20:20:36 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/435c54a583855d541ef233b4717bbe0a49fb0daa); +1 (insertion), -1 (deletion)


[Commit revision 0e3578e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 20:22:13 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0e3578ea6291df07197a3b60f0b45624f89dca03); +3 (insertions), -5 (deletions)


[Commit revision b1dd9cc]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 20:23:36 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b1dd9cc37305592850448ffbafd90bbe0f7a62fc); +2 (insertions), -4 (deletions)


[Commit revision e7c5413]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 20:25:38 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/e7c541300772b07c9c1b82cfa61b84515cc44452); +3 (insertions), -3 (deletions)


[Commit revision 73538f9]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 20:27:04 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/73538f9eba874512945b18207073cfc1eae242e7); +2 (insertions), -2 (deletions)


[Commit revision 143e827]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Feb 2017 20:33:23 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/143e8272a9817080981652f7e12da278ee4a8f49); +40 (insertions), -37 (deletions)

Title: Re: New revs
Post by: Nao on February 6th, 2017, 10:45 AM
[Commit revision 9bc6cba]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 06 Feb 2017 10:45:41 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/9bc6cbaa2ec0579322323e24fcf93245f4eade8d); +10 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on February 7th, 2017, 12:33 AM
[Commit revision de8a0d3]
(https://avatars.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Mon, 06 Feb 2017 22:47:59 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/de8a0d3da04b9eb884c2b85b00fc03a35ba13762); +4 (insertions), -2 (deletions)


[Commit revision 57f28d6]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 07 Feb 2017 00:33:45 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/57f28d6952386b6eba0d5d1a5310111fd7ef8655); +4 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 7th, 2017, 12:52 AM
[Commit revision d47934c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 07 Feb 2017 00:52:01 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d47934c0ba2b3a31d302b202455a550b6a41304e); +4 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on February 7th, 2017, 09:50 AM
[Commit revision 58af872]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 07 Feb 2017 01:06:39 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/58af8723a22a5babb701aca7fff94f6a24ea9b9c); +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 11th, 2017, 04:00 PM
[Commit revision 4584563]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 11 Feb 2017 15:57:59 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/45845631d66c00130b9704536ea2696b29ba4942); +1 (insertion), -1 (deletion)


[Commit revision 213537f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 11 Feb 2017 16:00:27 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/213537f6239ddb90685a701746012ca97778f711); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 11th, 2017, 04:06 PM
[Commit revision fe4f2b8]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 11 Feb 2017 16:06:04 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/fe4f2b83adee9b7b2ef9ace0452069c0b5455c27); +10 (insertions), -14 (deletions)

Title: Re: New revs
Post by: Nao on February 11th, 2017, 07:49 PM
Quote from Nao on February 11th, 2017, 04:00 PM
A departure from SMF-based forums: redirectexit() will no longer add the session variable to the URL if it's already in a cookie. I'll be honest with you, I never noticed that variable before, but it's started showing up everywhere in my new server. If you know why, feel free to share! Other than that, this update is very logical, so for those like me who have the problem, there you go. (Subs.php)
Okay, I may have found out why this happened...
https://bugs.php.net/bug.php?id=72940
Apparently, there was a bug between PHP 7.0 and 7.0.10 where the SID constant was defined even when a session cookie was set.
I'm using PHP 7.0.8, so that could be the reason.
At least I wasn't mad... :^^;:
I'm likely to keep that code in place, it's not like it's gonna cause issues after PHP 7.0.10.
Title: Re: New revs
Post by: Nao on February 19th, 2017, 02:55 PM
[Commit revision 82b795f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 19 Feb 2017 14:55:20 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/82b795fe0cc99b7a3bb6ef492687c801aec5050a); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 19th, 2017, 04:34 PM
[Commit revision 871993e]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 19 Feb 2017 16:34:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/871993e8c2c2e9117db5d00983ba1378782f5e09); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on February 20th, 2017, 08:00 PM
[Commit revision d926432]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 09:35:36 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d926432503bea5b5b1d9240b5939bd038a7e10ac); +2 (insertions), -4 (deletions)


[Commit revision 2bcbf20]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:47:42 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/2bcbf201ddd08e80ebb40940b84b187d3c87d833); +6 (insertions), -20 (deletions)


[Commit revision 12bbb33]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:52:10 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/12bbb3317eeac57c52e9a8ecb2c2f48b4919af67); +1 (insertion), -3 (deletions)


[Commit revision 342308c]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:53:18 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/342308c7d716fa93e09dece3f65ef15875fbec73); +18 (insertions), -20 (deletions)


[Commit revision 30f1c99]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:53:56 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/30f1c99573344912f1a1e736f1b97f056ca44bc3); +2 (insertions), -2 (deletions)


[Commit revision 0f35c9a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:54:53 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0f35c9aad020eed4c590090018f8f0a6d397583e); +3 (insertions), -0 (deletion)


[Commit revision 2f6ef2a]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:55:46 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2f6ef2a4964530b686a6d8118c67072ad91bad31); +1 (insertion), -1 (deletion)


[Commit revision 82c2ba5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:57:26 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/82c2ba504bbbf94ef4165e032aae715c22870750); +9 (insertions), -4 (deletions)


[Commit revision 13ec5ff]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:58:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/13ec5fffd0cdbb8837f3fab81f813fd56159f82a); +1 (insertion), -1 (deletion)


[Commit revision a70a7cf]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Feb 2017 18:58:56 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a70a7cf9333b7a0a4c73db5e0bc4305ef9532d47); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 21st, 2017, 07:12 AM
[Commit revision 46195a1]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 21 Feb 2017 07:12:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/46195a1e663bdfd825aaa180b89995373f4f191f); +9 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on February 21st, 2017, 10:32 AM
[Commit revision 7720979]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 21 Feb 2017 10:32:32 +0100
Stats: 10 files changed(https://github.com/Wedge/wedge/commit/7720979fa420348c1fa1ab31c5b2110dd1e529f9); +13 (insertions), -30 (deletions)

Title: Re: New revs
Post by: Nao on February 21st, 2017, 11:24 AM
[Commit revision 5e742b0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 21 Feb 2017 10:35:25 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5e742b0823d53e8d169ad26e8de913c4d25c9adb); +1 (insertion), -2 (deletions)


[Commit revision 78b0f70]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 21 Feb 2017 11:24:01 +0100
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/78b0f70cec91337ee2dfa0958f6bc7121acefbc6); +14 (insertions), -24 (deletions)

Title: Re: New revs
Post by: Nao on February 22nd, 2017, 11:44 PM
[Commit revision 9080368]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Feb 2017 23:43:08 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/90803685f399247e3bfb1b8387b1a12d48d63519); +1 (insertion), -4 (deletions)

Title: Re: New revs
Post by: Nao on February 22nd, 2017, 11:48 PM
[Commit revision a449ef5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 22 Feb 2017 23:48:29 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a449ef52d86f9f186abf85a837fa4d63a9040b43); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on February 27th, 2017, 12:12 AM
[Commit revision 005abec]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Feb 2017 00:01:02 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/005abec7154e90150234a5f5cc93509a427b4df5); +12 (insertions), -10 (deletions)


[Commit revision dc13cf0]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Feb 2017 00:01:53 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/dc13cf058c6e290cb174f29499c62986fdca0864); +1 (insertion), -1 (deletion)


[Commit revision 47060c5]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Feb 2017 00:02:28 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/47060c5e47c810f0d5de4789bc0fc7b95917715e); +6 (insertions), -8 (deletions)


[Commit revision 9affd1f]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Feb 2017 00:10:24 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9affd1f39b7ee122d051f546d1138ffdaf172f97); +11 (insertions), -0 (deletion)


[Commit revision c2bee20]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Feb 2017 00:12:08 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/c2bee209da594f01d9a88640cb5652a2fdb096ee); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on February 27th, 2017, 12:00 PM
[Commit revision ec62771]
(https://avatars.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 27 Feb 2017 12:00:12 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ec62771d9b1afac57615b304282c2997ca9cdcc4); +25 (insertions), -28 (deletions)

Title: Re: New revs
Post by: Nao on March 2nd, 2017, 12:45 PM
[Commit revision 1d5d214]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Thu, 02 Mar 2017 12:45:44 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1d5d214e44a63b463cae8c83cbd43809bcba2c9d); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 4th, 2017, 12:37 AM
[Commit revision 168f199]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 04 Mar 2017 00:33:12 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/168f199606a96905ee392d4258bebb65bb777391); +8 (insertions), -7 (deletions)


[Commit revision 7ea895d]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 04 Mar 2017 00:35:34 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7ea895d365b16c40cfcf043ea896389b393689d9); +1 (insertion), -0 (deletion)


[Commit revision 0902d9b]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 04 Mar 2017 00:36:31 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0902d9b3de6abe11daf7ef8fb1fc3f46e9a56261); +4 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 5th, 2017, 11:54 PM
[Commit revision 40c60b2]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 05 Mar 2017 23:54:26 +0100
Stats: 7 files changed(https://github.com/Wedge/wedge/commit/40c60b2c2f63151ee47a20e75adb6aacf92c89d8); +41 (insertions), -16 (deletions)

Title: Re: New revs
Post by: Nao on March 6th, 2017, 12:07 AM
[Commit revision f978581]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 06 Mar 2017 00:07:41 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f97858143840a95daadf564bfaf19b4ba8cb6696); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 6th, 2017, 10:40 PM
[Commit revision 3c2eb2f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 06 Mar 2017 22:40:06 +0100
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/3c2eb2f1b066194c46ea932c23a31e279e1291b6); +7 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on March 11th, 2017, 11:32 AM
[Commit revision 1fcd685]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 11 Mar 2017 11:22:15 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/1fcd685692b3cbbda2207e9d1db740b68c7376ac); +5 (insertions), -5 (deletions)


[Commit revision ded9e47]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 11 Mar 2017 11:32:23 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ded9e47dae0ab1e6f1658008c2f5f9285e999c05); +14 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on March 13th, 2017, 10:27 PM
[Commit revision 113d4e4]
(https://avatars3.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Sat, 11 Mar 2017 16:59:35 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/113d4e4ffac4fcc79e5b85bc491f700c5a6f830c); +17 (insertions), -10 (deletions)


[Commit revision 2999165]
(https://avatars3.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Sun, 12 Mar 2017 17:04:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/29991654f6d548e1e18edafd6402d0bf912aa419); +1 (insertion), -1 (deletion)


[Commit revision dc72afe]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 13 Mar 2017 22:27:11 +0100
Stats: 6 files changed(https://github.com/Wedge/wedge/commit/dc72afe1c23cf6f20bd9d4e2e3259a9a3444c4d3); +17 (insertions), -10 (deletions)

Title: Re: New revs
Post by: Nao on March 13th, 2017, 10:41 PM
[Commit revision 38d17d4]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 13 Mar 2017 22:40:48 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/38d17d47e9cba584c263ccb96739a7d396ac2267); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on March 18th, 2017, 11:27 AM
Quote from Nao on March 13th, 2017, 10:41 PM
Updated a date and position. ;)
Yeah CG, thought you'd appreciate that ;)
Least I could do, really! I'd just forgotten about that file...
Title: Re: New revs
Post by: Nao on March 18th, 2017, 11:44 AM
[Commit revision 4b63508]
(https://avatars3.githubusercontent.com/u/6577095?v=3)Author: C3realGuy(https://github.com/C3realGuy)
Date: Thu, 09 Feb 2017 12:46:03 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4b63508455f4f82f0ba1b2b6a0ca3f2b551425b6); +857 (insertions), -63 (deletions)


[Commit revision 5c077e8]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 18 Mar 2017 11:44:36 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5c077e889fc526af14cb44dc777ae636b326af7f); +857 (insertions), -63 (deletions)

Title: Re: New revs
Post by: Nao on March 18th, 2017, 12:45 PM
[Commit revision df6398f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 18 Mar 2017 12:45:04 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/df6398f17477a4ec2155b3ea5c081c2245df65b7); +674 (insertions), -725 (deletions)

Title: Re: New revs
Post by: Nao on March 18th, 2017, 12:55 PM
Quote from Nao on March 18th, 2017, 12:45 PM
IMPORTANT: this commit and the previous one only work on PHP 7+.
Actually, PHP 5.4+.
Title: Re: New revs
Post by: Nao on March 19th, 2017, 12:22 AM
[Commit revision f2ba207]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 19 Mar 2017 00:22:20 +0100
Stats: 13 files changed(https://github.com/Wedge/wedge/commit/f2ba20756b9b5bb331006dac0bcbf2645bcfdb78); +18 (insertions), -90 (deletions)

Title: Re: New revs
Post by: Nao on March 19th, 2017, 11:48 AM
[Commit revision 0d9d3e4]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 19 Mar 2017 11:47:30 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0d9d3e48f6018177f89b88367a3682c2b56d455d); +9 (insertions), -29 (deletions)

Title: Re: New revs
Post by: Nao on March 20th, 2017, 12:28 AM
[Commit revision e5868b1]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Mar 2017 00:28:38 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e5868b146e883c01f7c81132e1b9e9349a4bb9c5); +77 (insertions), -77 (deletions)

Title: Re: New revs
Post by: Nao on March 20th, 2017, 03:40 PM
[Commit revision d9f6873]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Mar 2017 15:40:19 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d9f68737bd2964362f563c64781249640d8a0dd6); +12 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on March 20th, 2017, 04:28 PM
[Commit revision 7fdc0bd]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 20 Mar 2017 16:28:03 +0100
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/7fdc0bd2fbeda4d4eca500d0765cb4a13d46cf87); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on March 29th, 2017, 12:18 PM
[Commit revision 26810ca]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Mar 2017 19:37:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/26810ca69f8f6eda2003cc09432e8c97ac9dc7e2); +1 (insertion), -1 (deletion)


[Commit revision f02dd70]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Mar 2017 19:39:16 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/f02dd70a67ab94fc46c11fe06eb500f36aba2288); +3 (insertions), -1 (deletion)


[Commit revision fe47054]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 28 Mar 2017 19:42:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fe47054b96d5432f66d57a591b31bdc112aed1eb); +0 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 29th, 2017, 12:18 PM
[Commit revision b42ffae]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Mar 2017 12:03:12 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/b42ffae815bc96b71c32f2da732ed3701d331add); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on March 29th, 2017, 12:46 PM
[Commit revision 2f082c8]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Mar 2017 12:45:48 +0200
Stats: 5 files changed(https://github.com/Wedge/wedge/commit/2f082c889b4324a1cdf5fe2d114a54ac3d276e3a); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on March 29th, 2017, 11:12 PM
[Commit revision 7196a1f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Mar 2017 23:10:05 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/7196a1fd274f5cb909b82a13a6ccbb47cb25e0ad); +4 (insertions), -3 (deletions)


[Commit revision 2e9a0be]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Mar 2017 23:12:36 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2e9a0be042be5df93c17d94e065e1f3bb69db83c); +36 (insertions), -19 (deletions)

Title: Re: New revs
Post by: Nao on April 3rd, 2017, 10:45 PM
[Commit revision 81d0842]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:30:42 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/81d0842a07a7ebc8eef79d5fd3e1f7b8b000b7ed); +49 (insertions), -36 (deletions)


[Commit revision 823b176]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:32:17 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/823b17675b8659caa8ffece5c124c04c75d008bb); +36 (insertions), -40 (deletions)


[Commit revision 931e43e]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:34:48 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/931e43ef8de69049fb7c619cb1ebc548fe8e4442); +2 (insertions), -2 (deletions)


[Commit revision 5a9a005]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:37:57 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5a9a005bd973bf60ed40a926639b09d80b9389c6); +10 (insertions), -15 (deletions)


[Commit revision 137e34e]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:39:26 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/137e34ee11a89a193ef1ba0ae6b2c12665878866); +8 (insertions), -4 (deletions)


[Commit revision 3fd433f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:40:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3fd433faf830b8634a19e7e557e3738d8c83944f); +2 (insertions), -0 (deletion)


[Commit revision e6200f6]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:42:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e6200f67bc7e389c6abe9d46318ad8ea8c5f6c7b); +10 (insertions), -27 (deletions)


[Commit revision 14558bd]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:45:21 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/14558bd01e38e9c32824212775b6efa073e6174a); +5 (insertions), -7 (deletions)

Title: Re: New revs
Post by: Nao on April 3rd, 2017, 10:56 PM
[Commit revision 12911e5]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Mon, 03 Apr 2017 22:56:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/12911e512e2063c7ae7cc2f333a61334c7404eef); +5 (insertions), -13 (deletions)

Title: Re: New revs
Post by: Nao on April 7th, 2017, 03:51 PM
[Commit revision 9184d00]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Apr 2017 15:51:32 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/9184d00935250b4139950f2933a197c0504a5d5e); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on April 7th, 2017, 03:52 PM
[Commit revision f89d6d6]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Apr 2017 15:52:34 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f89d6d6544d70e864259dc421f30032c8e7ce42c); +6 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 7th, 2017, 03:55 PM
[Commit revision e850d4a]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 07 Apr 2017 15:54:52 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e850d4a4aefe00d0b3c6ca927599a212977e564b); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 16th, 2017, 02:40 PM
[Commit revision 57b05c2]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Apr 2017 14:31:50 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/57b05c26e4e629b9e66e95916c8e5a51f47d5ef3); +0 (insertion), -544 (deletions)


[Commit revision 8d8f49f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 16 Apr 2017 14:33:51 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8d8f49f89ad82e9ce5a459cc7d588470c5149824); +6 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on April 18th, 2017, 01:27 AM
[Commit revision e80acb5]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Apr 2017 01:27:11 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e80acb5ab6f12d38e08743122e94990cabba1163); +12 (insertions), -20 (deletions)

Title: Re: New revs
Post by: Nao on April 18th, 2017, 01:42 PM
[Commit revision 5973dac]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Apr 2017 13:42:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/5973daccdc177d9b51867e205c9e83fd73b84702); +12 (insertions), -9 (deletions)

Title: Re: New revs
Post by: Nao on April 21st, 2017, 07:37 PM
[Commit revision 26be97f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Tue, 18 Apr 2017 17:57:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/26be97fa32c2ff9e05e9fe4e7185cc03db702435); +2 (insertions), -2 (deletions)


[Commit revision 132545d]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Apr 2017 19:36:30 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/132545db3301fce8198b46965ee21db6dc97f255); +1 (insertion), -1 (deletion)


[Commit revision 7c269a1]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Fri, 21 Apr 2017 19:37:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7c269a1a7ff6ab539eb6d15072acc717df7aa034); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on April 22nd, 2017, 02:31 PM
[Commit revision ef31bf6]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Apr 2017 14:31:26 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/ef31bf692b08dd5d3c6f1d8008ef5d90068834fa); +3 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on April 30th, 2017, 02:47 PM
[Commit revision d45056f]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 30 Apr 2017 14:33:38 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/d45056fbc36bff8005b18a5d4f7db3b240082b84); +6 (insertions), -8 (deletions)


[Commit revision f52ad02]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 30 Apr 2017 14:37:26 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/f52ad02a92a505f626f288abbac18235970a1941); +5 (insertions), -4 (deletions)


[Commit revision 10494ab]
(https://avatars2.githubusercontent.com/u/1857192?v=3)Author: Nao(https://github.com/Nao)
Date: Sun, 30 Apr 2017 14:46:53 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/10494ab711b24a0a024a888be4a1a86be828cfaa); +2 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on July 19th, 2017, 04:33 PM
[Commit revision fb42680]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 19 Jul 2017 16:33:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fb42680643b6c9bac33471ea3beccfefa5354a88); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on July 22nd, 2017, 11:41 AM
[Commit revision 389ed36]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 10:28:59 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/389ed367dfe2a3c16303917907ddf0c1aae9d1f3); +0 (insertion), -0 (deletion)


[Commit revision d060d06]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:08:01 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/d060d06e515c5168a51d6a53f146306870b78a0c); +96 (insertions), -99 (deletions)


[Commit revision 0c3cd07]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:10:20 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0c3cd079de7edeea32687df59906330c7c359233); +14 (insertions), -7 (deletions)


[Commit revision bcb61a6]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:12:20 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/bcb61a67d308f65d4e68f715e06f346ddfdf2d51); +2 (insertions), -2 (deletions)


[Commit revision 8d4d155]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:14:36 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/8d4d15540ac5769b0375d27e59227a5307de7314); +5 (insertions), -2 (deletions)


[Commit revision cee6d78]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:17:20 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/cee6d784f35058730de28f4e92563c38e245acf0); +4 (insertions), -4 (deletions)


[Commit revision ec916e4]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:18:25 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/ec916e430a8e7763ce9debc91b16e2835c27726a); +2 (insertions), -2 (deletions)


[Commit revision 1937057]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:20:23 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/1937057ffbde8411931d6dfc39e66c1be09afac0); +6 (insertions), -13 (deletions)


[Commit revision 3349b81]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:25:34 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3349b810adfd56374a137480b6285c18688b5943); +1 (insertion), -96 (deletions)


[Commit revision fa1b720]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:28:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/fa1b72074b57ede2a594931f98d340b69c137b68); +30 (insertions), -30 (deletions)


[Commit revision 878793c]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:28:43 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/878793c056a0ebce90299a11932665ac6e008e84); +5 (insertions), -5 (deletions)


[Commit revision c43f32d]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:30:27 +0200
Stats: 4 files changed(https://github.com/Wedge/wedge/commit/c43f32d71ce5731cfe9659d559542ce51cebeff8); +12 (insertions), -12 (deletions)


[Commit revision aabdd5f]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:33:32 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/aabdd5f0b1b54bf6dff2bdd887136b5914169444); +8 (insertions), -8 (deletions)


[Commit revision 7f9ec53]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:36:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/7f9ec53490a3ab02bc49d9979c4f7a5d988d0c58); +18 (insertions), -16 (deletions)


[Commit revision 14d6a15]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 22 Jul 2017 11:41:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/14d6a152dec3a7ec7f69d164c613b5545bfcec49); +32 (insertions), -20 (deletions)

Title: Re: New revs
Post by: Nao on July 25th, 2017, 05:32 PM
[Commit revision 6ec1c96]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Jul 2017 17:32:01 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6ec1c96e037c91580add1a2b2a466653b19a2ad5); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on July 25th, 2017, 05:40 PM
[Commit revision 0992946]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Jul 2017 17:39:50 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/0992946207a8bc479dca2f877c3c9bf55fc074ea); +3 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on July 25th, 2017, 06:35 PM
[Commit revision 195825e]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Jul 2017 18:33:45 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/195825ee5d66bde9354bc45ec9e3ff7f55b84318); +3 (insertions), -1 (deletion)


[Commit revision ccc21c6]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 25 Jul 2017 18:35:22 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ccc21c6dec0d8dca85d3d7d63e194b3b73163f63); +3 (insertions), -0 (deletion)

Title: Re: New revs
Post by: Nao on August 11th, 2017, 02:02 PM
[Commit revision a446f57]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Fri, 11 Aug 2017 14:02:18 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/a446f57774875be5522430fad2e8d1bdab9eeb14); +6 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on September 8th, 2017, 11:56 AM
[Commit revision 932fdf8]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Fri, 08 Sep 2017 11:56:41 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/932fdf8bcbe498df188119e643da95a1e3bab556); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on September 8th, 2017, 03:16 PM
[Commit revision 6d382ae]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Fri, 08 Sep 2017 15:16:34 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/6d382ae376d514b0c4a510374f9ad080c1f22767); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on September 30th, 2017, 02:16 PM
[Commit revision e80743d]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 30 Sep 2017 14:15:59 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/e80743d355912a463a30e267e9a1b26ab48b6625); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on October 16th, 2017, 11:42 AM
[Commit revision 1b84312]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Oct 2017 11:41:26 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1b84312763944a85194c630d1e5de957a44f152e); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 16th, 2017, 11:46 AM
[Commit revision 3d56349]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Oct 2017 11:44:07 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/3d563496ccceb5e343461948e485b57240ed5ba2); +27 (insertions), -19 (deletions)


[Commit revision 91655f3]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Oct 2017 11:45:22 +0200
Stats: 0 file changed(https://github.com/Wedge/wedge/commit/91655f31aa9c441ba4893209c3a52b44a3b6f9ba); +0 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Nao on October 16th, 2017, 11:49 AM
(Sorry about the mess in the history log; I committed as planned, but pushed by mistake and then tried to cancel it partway through uploading, got an error message, panicked and made it worse. Git can sometimes be convoluted.)

(Not that ANYONE will care, of course...)
Title: Re: New revs
Post by: Nao on October 16th, 2017, 11:54 AM
[Commit revision 18fd99a]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 16 Oct 2017 11:54:08 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/18fd99aae9f0462ee81238f39bb1fdd802ebde66); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on October 18th, 2017, 10:10 PM
[Commit revision 9678675]
(https://avatars3.githubusercontent.com/u/3099270?v=4)Author: French77(https://github.com/French77)
Date: Wed, 18 Oct 2017 22:10:12 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9678675832b81e7b1339c1bde4cabc327b2879a0); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on October 24th, 2017, 03:33 PM
[Commit revision 2ebdde8]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Oct 2017 15:26:42 +0200
Stats: 3 files changed(https://github.com/Wedge/wedge/commit/2ebdde896079aee06076eba3a915ea46099f7472); +5 (insertions), -19 (deletions)


[Commit revision ad4eada]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 24 Oct 2017 15:26:58 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/ad4eadac23492cad2e9f6f3a816a49c5e3e205ea); +6 (insertions), -6 (deletions)

Title: Re: New revs
Post by: Nao on November 29th, 2017, 12:10 AM
[Commit revision f096a75]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Nov 2017 00:10:11 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f096a752dcf72659d446ebf77392e01e98a74124); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on November 29th, 2017, 12:14 AM
[Commit revision faa8f5b]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Nov 2017 00:14:09 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/faa8f5b57a505adebdfca2e583bcafbe2eb9038f); +2 (insertions), -1 (deletion)

Title: Re: New revs
Post by: Nao on November 29th, 2017, 12:20 AM
[Commit revision d530819]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 29 Nov 2017 00:20:08 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/d530819e6d8feef9b89c609c6d184d2eec8b2520); +4 (insertions), -4 (deletions)

Title: Re: New revs
Post by: Nao on December 8th, 2017, 11:02 AM
[Commit revision 3897716]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Fri, 08 Dec 2017 11:02:09 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/3897716fa9a9bb4e1c41fc26d2007799121614ae); +1 (insertion), -0 (deletion)

Title: Re: New revs
Post by: Jurien on December 9th, 2017, 08:47 AM
Quote from Nao on December 8th, 2017, 11:02 AM
[Commit revision 3897716]
  • Last privacy fix was generating database errors for non-admins. (Load.php)
commented on 3897716 (https://github.com/Wedge/wedge/commit/3897716fa9a9bb4e1c41fc26d2007799121614ae)
Title: Re: New revs
Post by: Nao on December 11th, 2017, 11:25 AM
[Commit revision 65f1859]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 11 Dec 2017 11:25:08 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/65f18591b949adeb5a4d44568ee1df144035c0cc); +3 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on December 12th, 2017, 11:03 PM
[Commit revision 947ae79]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 12 Dec 2017 23:03:23 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/947ae798638b4fcf888a40cc577eb5151a32fd17); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on December 18th, 2017, 10:38 PM
[Commit revision 5713082]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 18 Dec 2017 22:38:26 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/571308257f628dad4b56716914244c18193d8ece); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 8th, 2018, 01:59 AM
I just realized it'll soon be 6 months since my last commit to the Wedge codebase...
Weird.

Does this mean it's... Complete?
Or that I simply wasn't in the mood?
(A lot of things changed in my life right after that last commit, actually.)
Title: Re: New revs
Post by: Nao on May 23rd, 2018, 02:10 PM
[Commit revision 1ecc209]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:40:23 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/1ecc2093c8fb5bb3f90221622926b6696494fdaa); +5 (insertions), -2 (deletions)


[Commit revision 18c6ad0]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:41:05 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/18c6ad06a4d1f10e96519740eb5811ca6aafa606); +13 (insertions), -3 (deletions)


[Commit revision 7f83673]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:41:55 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/7f83673beaef8c800238916875eacd0c18894d2f); +27 (insertions), -14 (deletions)


[Commit revision 31e2141]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:45:13 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/31e2141385b321b4c041664af301e4cc3eed712a); +3 (insertions), -3 (deletions)


[Commit revision 35ed2bf]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:46:21 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/35ed2bf9336b0b94fc7b534d9d948e9ce2774e38); +7 (insertions), -6 (deletions)


[Commit revision 2652bcc]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:47:24 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/2652bcc6a07fb24bd4a494e6b11224e272c92597); +2 (insertions), -1 (deletion)


[Commit revision 55bab3f]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:48:07 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/55bab3f17d48975b89d486bdb3ee02be8b57bdfa); +7 (insertions), -27 (deletions)


[Commit revision f30b7ef]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:49:02 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f30b7ef31a144e3ebd6bf4440619223b3e50b363); +8 (insertions), -3 (deletions)


[Commit revision 9cd3b98]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:50:37 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9cd3b98c5305a9cbbe86a950070b8efd092822d4); +7 (insertions), -7 (deletions)


[Commit revision 805a359]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:51:12 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/805a3593d247848ba74d78f226d0a31cf4d741f0); +1 (insertion), -1 (deletion)


[Commit revision 1e2eaf9]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 23 May 2018 13:53:14 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/1e2eaf9f43ca4e2370e301de85a398096235f879); +11 (insertions), -11 (deletions)

Title: Re: New revs
Post by: Nao on May 7th, 2019, 04:10 PM
[Commit revision b3396c7]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 07 May 2019 16:10:27 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/b3396c7dddb48ad2522423ff593c41fad58d309a); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on May 11th, 2019, 01:29 PM
[Commit revision 9de5de8]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 11 May 2019 13:28:50 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9de5de86f62d9d6f40a42f77ba44486c24c5d711); +9 (insertions), -3 (deletions)

Title: Re: New revs
Post by: Nao on May 11th, 2019, 01:45 PM
[Commit revision 9fd7470]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 11 May 2019 13:45:27 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/9fd7470563c10574cb153195742f8dee246881b7); +1 (insertion), -1 (deletion)

Title: Re: New revs
Post by: Nao on May 11th, 2019, 07:00 PM
[Commit revision 294d044]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 11 May 2019 19:00:02 +0200
Stats: 2 files changed(https://github.com/Wedge/wedge/commit/294d044b4f19fac22cb1a36eb8beb5afc9c4e771); +5 (insertions), -5 (deletions)

Title: Re: New revs
Post by: Nao on May 13th, 2019, 08:50 PM
[Commit revision a51158f]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 13 May 2019 20:50:43 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a51158f3ad6e51454abb77c0debd65080d964d53); +2 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on May 14th, 2019, 01:39 PM
Quote from Nao on May 13th, 2019, 08:50 PM
  • Fixed calc() recursive pattern: it was trying to match against the whole pattern, instead of the second group of brackets. Also simplified the rest of the pattern. (Class-CSS.php)
Not that it matters, but the reason I didn't notice the bug earlier was that usually, calc() calls don't include nested brackets, so I didn't test against a stronger string like 'calc(100% + (7px / 1em))', and even then, it probably would have worked in your browser even if not matched.
Title: Re: New revs
Post by: Nao on June 26th, 2019, 11:27 AM
[Commit revision a0fe1de]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Jun 2019 11:27:04 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/a0fe1decd5b6c180e53b1e2eb93ebcf38e9d3665); +20 (insertions), -15 (deletions)

Title: Re: New revs
Post by: Nao on June 26th, 2019, 02:43 PM
[Commit revision 8b92ee8]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Wed, 26 Jun 2019 14:42:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/8b92ee855787b9d5b3513f224cc50f2123c8ffe0); +8 (insertions), -26 (deletions)

Title: Re: New revs
Post by: Nao on July 2nd, 2019, 11:10 PM
[Commit revision 4b83267]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 02 Jul 2019 23:10:14 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/4b83267768fe881856200653c8969c3d5752b374); +8 (insertions), -8 (deletions)

Title: Re: New revs
Post by: Nao on October 7th, 2019, 08:04 PM
[Commit revision f6c20a4]
(https://avatars1.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Mon, 07 Oct 2019 20:03:54 +0200
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/f6c20a4a524f6fc3b4ce92cdd3c3f5a084ed07bc); +5 (insertions), -2 (deletions)

Title: Re: New revs
Post by: Nao on March 23rd, 2021, 03:14 PM
[Commit revision eb0d124]
(https://avatars.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Tue, 23 Mar 2021 14:34:35 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/eb0d124a0ba30f5a71706c1579e98593d818bbfe); +1 (insertion), -3 (deletions)

Title: Re: New revs
Post by: Nao on March 23rd, 2021, 03:20 PM
So, apparently there were some changes internally at github and they deleted the webhook for Wedge. I reinstalled it, and it didn't work. I had to rewrite some parts of the code to allow it to go through. I don't know if anyone's interested in getting the updated code? If no one is, there isn't much of a reason for me to commit the changes (for some reason, my local plugin repo was deleted.)

So, I'm adding manually the two commits that were not posted here, they're both mine and dated from earlier today:

https://github.com/Wedge/wedge/commit/d802a61d455ca56e27fc839e7f92f23c57c988ae (minor AeMe bug I never bothered to fix on the repo before),
https://github.com/Wedge/wedge/commit/b37452eaaa4233ba361b71fc936c4fca28515ce7 (fix for Firefox breaking some CSS due to how :matches is implemented over there, thankfully they have :where now, which works fine everywhere.)

Sadly, I never committed anything in 2020.
Damn year!
Title: Re: New revs
Post by: Nao on March 27th, 2021, 06:36 PM
Well, regarding the :where, it threw problems at me. Specifically, notifications stopped working on my other website because I have an extra class that uses the .notifs base, and it just shows that the standard isn't really ready for automation.

Code: [Select]
.notifs .mimenu { opacity: 0 }
.otherclass .open, .notifs .open { opacity: 1 } // This will work
:is(.otherclass, .notifs) .open { opacity: 1 } // This will work
:where(.otherclass, .notifs) .open { opacity: 1 } // This will NOT work!

I could modify my .mimenu declaration to not be 'final', so that .otherclass also reuses it, and then it'd probably work. Or I could specifically prevent that class that being converted into a :where() or whatver. But this just proves to me that there is currently no sure way to make it work at execution time. So I'm disabling it temporarily. Feel free to tell me if you can figure out a way! I loved :where(), but as it is, I'd rather have it work and waste a few bytes in my gzipped file. (Really, it's just that-- a few bytes. Doesn't matter as much in 2021 as it did in the early 2010's when I worked on this feature...)
Title: Re: New revs
Post by: Nao on March 27th, 2021, 06:40 PM
[Commit revision 750c3a6]
(https://avatars.githubusercontent.com/u/1857192?v=4)Author: Nao(https://github.com/Nao)
Date: Sat, 27 Mar 2021 18:40:17 +0100
Stats: 1 file changed(https://github.com/Wedge/wedge/commit/750c3a672cb6ea9ee8441e9fca02e0cf0592027c); +4 (insertions), -1 (deletion)

Title: Re: New revs
Post by: live627 on August 30th, 2023, 05:42 PM
Quote from Nao on March 23rd, 2021, 03:20 PM
So, apparently there were some changes internally at github and they deleted the webhook for Wedge. I reinstalled it, and it didn't work. I had to rewrite some parts of the code to allow it to go through. I don't know if anyone's interested in getting the updated code? If no one is, there isn't much of a reason for me to commit the changes (for some reason, my local plugin repo was deleted.)
perhaps you and I could compare code

https://gist.github.com/live627/68345dfb22756a9d16dc81aa800780a1
Title: Optimal Сasual Dating - Authentic Damsels
Post by: mandatUsariGF on February 7th, 2024, 07:41 AM
Elevate your dating game with the top site for hassle-free connections.
Verified Ladies
Optimal Сasual Dating(http://meettomy.site)