New revs

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2490, on March 3rd, 2014, 11:01 PM »
[Commit revision 244cb53]
Author: Nao
Date: Mon, 03 Mar 2014 23:01:20 +0100
Stats: 1 file changed; +0 (insertion), -16 (deletions)

  • Hopefully I'm not breaking anything else by this, but I'm fixing profile options, that were broken a few months ago and were no longer changed when setting them. (Profile-Modify.php)
Re: New revs
« Reply #2491, on March 4th, 2014, 12:01 AM »
[Commit revision 832c0f1]
Author: Nao
Date: Tue, 04 Mar 2014 00:00:55 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)

  • Removed a Pete bug from Wedge's first month of existence, which erased your message contents when quick replying to something, and switching to full editor mode. This only happened if Wysiwyg mode was enabled by default for you, which I never do because I hate Wysiwyg. In the end, I have no idea what these two lines of code were doing in there. I guess we'll never know. (topic.js)
Re: New revs
« Reply #2492, on March 4th, 2014, 12:08 AM »
[Commit revision e95a330]
Author: Nao
Date: Tue, 04 Mar 2014 00:08:49 +0100
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • Just a detail... Grouped registration date together with last online date in profile pages. This makes it easier to see how long someone has been there. (Profile.template.php)
Re: New revs
« Reply #2493, on March 4th, 2014, 12:27 AM »
[Commit revision cae3ec9]
Author: Nao
Date: Tue, 04 Mar 2014 00:26:59 +0100
Stats: 1 file changed; +0 (insertion), -4 (deletions)

  • Removed the Apache server test in the original folder creator. The reasoning was that a non-Apache server wouldn't know what to do with htaccess files, but what if you're switching from another server *to* Apache..? You wouldn't have any way to restore these files. (OriginalFiles.php)
Re: New revs
« Reply #2494, on March 4th, 2014, 05:03 PM »
[Commit revision dd59b61]
Author: Nao
Date: Tue, 04 Mar 2014 17:03:14 +0100
Stats: 3 files changed; +19 (insertions), -0 (deletion)

  • In preparation for the removal of oldIE support, which will be coming soon, I'm hereby adding a very visible (that's the goal!) error box for IE6/IE7 users, in the hope that it will encourage them to at least switch to another browser while they're visiting your forum. (Load.php, Errors.template.php, Errors.english.php)
Re: New revs
« Reply #2495, on March 5th, 2014, 08:11 PM »
[Commit revision ca3053c]
Author: Nao
Date: Wed, 05 Mar 2014 20:05:42 +0100
Stats: 1 file changed; +6 (insertions), -4 (deletions)

  • If spider checks are enabled, we'll still want to apply a generic test to we::$user['possibly_robot'], to catch any possible unnamed bots. (Class-System.php)

[Commit revision 77f4d9e]
Author: Nao
Date: Wed, 05 Mar 2014 20:11:04 +0100
Stats: 2 files changed; +9 (insertions), -7 (deletions)

  • A couple of CSS tweaks that I don't have time to elaborate on. (index.css, sections.css)
Re: New revs
« Reply #2496, on March 7th, 2014, 12:03 AM »
[Commit revision 8c58b91]
Author: Nao
Date: Fri, 07 Mar 2014 00:03:02 +0100
Stats: 2 files changed; +36 (insertions), -65 (deletions)

  • Rewrote the main menu system to use hardware-accelerated CSS3 animations instead of jQuery to open menus and animate them. It still works the same in oldIE and other crappy browsers, without the animations of course. It's faster on all other devices, usability is MUCH better (transitions are way more natural delayers than JavaScript timers!), and in exchange for 250 extra bytes of CSS, it saves 100 lines of code for a whopping 1.2KB of JS. It's like early birthday present for me. (script.js, index.css)
Re: New revs
« Reply #2497, on March 8th, 2014, 12:48 AM »
[Commit revision 383b950]
Author: Nao
Date: Fri, 07 Mar 2014 23:31:50 +0100
Stats: 2 files changed; +6 (insertions), -4 (deletions)

  • Tweaked positions and transition timings to get a result closer to what used to be in CSS menus. (index.css)
  • CSS menu rewrite was breaking sub-menus on mobile devices. (script.js)

[Commit revision 8148c25]
Author: Nao
Date: Fri, 07 Mar 2014 23:35:26 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Added $type variable to the post_parse_bbc hook, if you need to know what kind of mess you're in. Made it rewritable, but it's not used later, so it's just for the principle. (Subs-BBC.php)

[Commit revision 1fd0f89]
Author: Nao
Date: Sat, 08 Mar 2014 00:48:00 +0100
Stats: 1 file changed; +3 (insertions), -3 (deletions)

  • Poll layout was slightly broken when a poll was closed in the last 2 days, because of the use of strong tags for the date. The solution for macro parameters is to use the 'htmlsafe::' prefix in your parameter, and then follow it by a call to westr::safe() on the string to be shown. It sounds a bit esoteric, sorry about that. (Display.template.php)
Re: New revs
« Reply #2498, on March 8th, 2014, 06:56 PM »
[Commit revision 984b767]
Author: Nao
Date: Sat, 08 Mar 2014 18:48:54 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Don't show IE6/IE7 deprecation warnings to known bots. They might actually cache them... (Load.php)

[Commit revision 787ef77]
Author: Nao
Date: Sat, 08 Mar 2014 18:55:57 +0100
Stats: 2 files changed; +34 (insertions), -16 (deletions)

  • Updated Bad Behavior filters to version 2.2.15. It's just an extra test. Also updated credit URLs to remove the www subdomain. (Security.php, Security.english.php)
  • Went through all existing filters and compared them to the latest Bad Behavior, which was painful because they weren't in the same order. As a result:
    • Fixed 'PMAfind' into 'PMAFind', which is what BB uses. (Pete bug.)
    • Added a mention about an entry that was removed by BB without warning, but seems harmful enough to keep.
    • Removed 'Mozilla ', which according to BB is used by the Google AdSense bot, which we don't want to cross...

  • Added back some entries that Pete decided not to import from BB 2.2.8 (see August 20, 2012 commit):
    • Restored 'Mozilla/0', probably an oversight.
    • Ensured that '<sc' is tested against everywhere in the string, not just at the start. If BB does it that way, it probably has a reason to. Opening space, maybe..?
    • Windows 3.x, 9x, ME, as well as IE 1.0 and Mozilla Firebird (pre-Firefox) have no reason to be used by anyone in 2014, so they should be banned because they're probably bots (I can concur.)

  • If needed, you can re-allow old OSes and old browsers via a new hidden setting. Just set $settings['allow_jurassic_crap'] to 1. Yeah, I make up funny variable names.
  • Note: this commit is mostly about me taking ownership of one of Pete's old jobs.. But I don't know if the job was about implementing BB, or saying one knows better than BB. Because I really can't say that.
Re: New revs
« Reply #2499, on March 11th, 2014, 04:35 PM »
[Commit revision 2b8ffa8]
Author: Nao
Date: Mon, 10 Mar 2014 20:12:36 +0100
Stats: 1 file changed; +12 (insertions), -5 (deletions)

  • A bit of love for iOS. Well, really, I don't like it anymore, but that's no reason not to commit the iOS-specific font stack I'd been using locally before I switched to a proper mobile OS. (common.css)
  • Also gathered big font definitions under a common font stack. Don't bother. (common.css)
  • Re-adding support for flexbox for Opera 12.1. Whoever's still using it will be glad. Vive la Résistance ! Technically, the only 'difference' is that I checked my code again under the browser, and it worked just fine, so I'm assuming a recent change fixed it. (common.css)
  • Re-adding support for flexbox for iOS 7+, but since I'm unable to test it, I'm doing this in the blind. Technically, though, it doesn't matter because touch-friendly devices all default to a mobile skin by default, and mobile skins don't really make use of flexboxes, so... (common.css)

[Commit revision 0bce09e]
Author: Nao
Date: Mon, 10 Mar 2014 21:47:47 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Making the IE6/IE7 warning message a bit less intrusive, in case the guest user really has no way to upgrade. (Errors.template.php)

[Commit revision ec1a335]
Author: Nao
Date: Tue, 11 Mar 2014 14:24:29 +0100
Stats: 1 file changed; +0 (insertion), -1 (deletion)

  • Commenazi. (common.css)

[Commit revision 9ac659a]
Author: Nao
Date: Tue, 11 Mar 2014 14:27:01 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Shorter opacity animation times in menus, should help make them closer in spirit to the old code. (index.css)

[Commit revision 7732394]
Author: Nao
Date: Tue, 11 Mar 2014 14:30:11 +0100
Stats: 1 file changed; +4 (insertions), -1 (deletion)

  • Fixing height problems on img tags when only a height was set. Well, it's complicated... It won't solve situations where you'd want to resize an image and not respect its aspect ratio, but... Why would you want to do that, exactly..? (index.css)

[Commit revision 56b79ca]
Author: Nao
Date: Tue, 11 Mar 2014 14:36:43 +0100
Stats: 1 file changed; +13 (insertions), -16 (deletions)

  • Separated all category classes (cat, title and title2) into classes all derived from catbase, instead of title2 extending on title extending on cat extending on catbase. This should make it MUCH easier to rewrite either of these, without having to rely on unextends or reset tricks. (index.css)

[Commit revision a8d3e5a]
Author: Nao
Date: Tue, 11 Mar 2014 16:02:39 +0100
Stats: 1 file changed; +7 (insertions), -6 (deletions)

  • And now for a, hopefully, more responsive footer... The logo never should get in the way again if you don't have screen estate to spare. (index.css)

[Commit revision 00ef483]
Author: Nao
Date: Tue, 11 Mar 2014 16:22:46 +0100
Stats: 1 file changed; +5 (insertions), -5 (deletions)

  • Trying to zoom into a chart from the right of its last available date would show 'undefined' date ranges instead of the last date. (wraph.js)
  • Err... Why did I put a Math.max between 0 and a number I know will be positive..? (wraph.js)

[Commit revision 8ac388d]
Author: Nao
Date: Tue, 11 Mar 2014 16:33:02 +0100
Stats: 1 file changed; +18 (insertions), -3 (deletions)

  • Adding styling for the homepage's topic list. Can you imagine I didn't notice this was in my custom.css file until now, and therefore not committed..? (sections.css)
Re: New revs
« Reply #2500, on March 11th, 2014, 07:47 PM »
[Commit revision daa602b]
Author: Nao
Date: Tue, 11 Mar 2014 18:53:29 +0100
Stats: 1 file changed; +11 (insertions), -11 (deletions)

  • Updated footer to match the new CSS. Notably, I moved page load stats to the bottom, so that the credits list item is shown next to the logo. Makes more sense to me... And it's shorter, and avoids a couple of hacks in the HTML. (index.template.php)
  • Mobile viewports are user-scalable by default, no need to specify it. (index.template.php)
Re: New revs
« Reply #2501, on March 11th, 2014, 11:33 PM »
[Commit revision 3477140]
Author: Nao
Date: Tue, 11 Mar 2014 22:15:46 +0100
Stats: 5 files changed; +41 (insertions), -73 (deletions)

  • And... The main menu is now entirely CSS driven! I can't believe I managed to do it. The main issue I had for all these years was solved with a simple CSS precedence tweak. Saves about 150 bytes of CSS, at no extra CSS cost (it's pretty much the same.) Will need to clean up more things, though, but it'll come soon. (script.js, index.css)
  • The only browsers that have problems with the new systems are IE. No kidding! IE6 breaks it entirely (I'm not too thrilled about attempting to fix it...), IE7 and IE8 don't show all hovers (who cares, it works perfectly otherwise), and IE9 and IE10 have a bug in top-level menus, which not many people will notice I'm sure. Still, I've disabled the top-level animation for them, because it makes it even harder to notice said issue.
  • Fixed a new bug where menus could close if hovering next to the top-level menu arrows. I'm not exactly sure why I never had the problem before, but... Whatever. (index.css)
  • Basic fixes for IE6/7 and RTL. IE6 disables menus entirely (only the #navi row is visible), and IE7 needed extra help, notably with #context_menus being renamed to .context.menus loooong ago. Not sure why I forgot to update it... Oh yeah, because I hate IE. (extra.ie*.css, extra.rtl.css)

[Commit revision e1d608f]
Author: Nao
Date: Tue, 11 Mar 2014 23:33:15 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • And that'll be all for tonight, with an unimportant CSS tweak. (mana.css)
Re: New revs
« Reply #2502, on March 12th, 2014, 08:16 PM »
[Commit revision 8f10d42]
Author: Nao
Date: Wed, 12 Mar 2014 14:15:10 +0100
Stats: 1 file changed; +9 (insertions), -3 (deletions)

  • I'm on a roll... Rewrote select box to enable hardware acceleration on mobile (touch) devices. The idea is that it's pretty much horrible to use a regular select box on touch, so I removed the custom scrollbar and used stock overflows instead. This makes scrolling smoother and you still get a nice scrollbar, the default one. Well, it's looking nice in iOS 5 and Android 4.1+, dunno about the rest. (sbox.js)
  • Select box dropdowns taking the entire screen width should drop 5 pixels on each side, it's better on my eyes. (sbox.js)

[Commit revision fa0eeeb]
Author: Nao
Date: Wed, 12 Mar 2014 18:58:13 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • IE6 generates errors on empty selectors in Wess, so I'm replacing the 'extends' hack with a dummy class. Don't bother. It's one of my last IE6 fixes... I promise. (Class-CSS.php)

[Commit revision ccb9464]
Author: Nao
Date: Wed, 12 Mar 2014 19:36:42 +0100
Stats: 1 file changed; +22 (insertions), -15 (deletions)

  • Partially reverted the sbox rewrite, because I wasn't happy with the scrolling effect propagating to the main page when the start of end of the div was reached. This is something that my custom method dealt with elegantly, so I'm moving the hardware acceleration code over there. Also limiting that path to Chrome and Firefox Mobile, because they're the only ones I can test, and I don't want to break anything. (sbox.js)
Re: New revs
« Reply #2503, on March 12th, 2014, 08:21 PM »
[Commit revision 505a0f7]
Author: Nao
Date: Wed, 12 Mar 2014 20:21:21 +0100
Stats: 1 file changed; +10 (insertions), -10 (deletions)

  • Fixing menus to actually close when clicked. This is the last remaining bit of JavaScript in the code, and of course it's not even required to run it. (script.js)
Re: New revs
« Reply #2504, on March 12th, 2014, 10:49 PM »
[Commit revision bae934d]
Author: Nao
Date: Wed, 12 Mar 2014 21:51:55 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Oh bugger, Firefox Mobile doesn't actually like hardware acceleration... Well, too bad for it. (sbox.js)

[Commit revision 088ef11]
Author: Nao
Date: Wed, 12 Mar 2014 22:00:00 +0100
Stats: 2 files changed; +23 (insertions), -18 (deletions)

  • Committing the Wilde tweaks I've been testing for a few days on wedge.org... (Wilde/extra.css)
  • IE 10+ and Opera 11+ weren't using the @viewport keyword in Wireless, even though it was added to Wilderless. (Wuthering/extra.css)