New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2145, on June 1st, 2013, 05:57 AM »
(9 modified, 3 added, 10KB)

Revision: 2145
Author: arantor
Date: 01 June 2013 04:56:35
Message:
! Create a language files for boards as Nao suggested recently. (Subs-BoardIndex.php, index and Boards language files)

! Move a language string into the post file, it's only ever used in the editor. (index and Post language files)

! For the lists of reported posts, also show the board that the post is currently in. (ModerationCenter.php, Profile-View.php, ModerationCenter.template.php, Profile.template.php)
----
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Profile.template.php
Added : /trunk/Themes/default/languages/Boards.english-uk.php
Added : /trunk/Themes/default/languages/Boards.english.php
Added : /trunk/Themes/default/languages/Boards.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #2146, on June 3rd, 2013, 10:02 PM »
rev 2146 -- just to get these out of the way, 'mkay..?
(1 file +2-2, 179kb)

* Updated jQuery to newest versions (2.0.2/1.10.1), as this time Google was prompt enough to update them immediately, yay. (Load.php, jquery-*.min.js)
Re: New revs
« Reply #2147, on June 3rd, 2013, 10:07 PM »
rev 2147 -- all of my current committable work -- and Dragooon's.
(5 files, 3kb)

* Committing a few changes to the structure of the contact list tables. They still aren't in use, but I wanted to have them in, just so Pete can protest/revert the changes, in case he finds them to be ineffective. (I'm never too sure about my work on MySQL performance, he's my god when it comes to that.) The idea is that list IDs should be linked to the owner ID, so that they don't get a list URL like action=profile;sa=contacts;in=12345, or something like that, but a shorter number instead, yeah, that totally deserves 4 lines of description in this commit, eh..? (install.sql)

* Applied Dragooon's patch that promotes my avatar code hack to a more generic status, yay again. (Class-Notifier.php)

* Applied Dragooon's patch that promotes my member_from code hack to a more gen... "Hey, haven't I done you before?" (Wowbagger, Class-Notification.php, Notifications.php, install.sql)

@ Fixed patch's cache flushing code, to use null instead of array(), as per Pete's suggestion, and use the proper TTL (86400), as per my own non-suggestion, but whatyagonnado. (Class-Notification.php)

! Looks like it's possible for a message to be emptied entirely by parse_bbc, as evidenced by an error in my log some time ago, so I'm adding a fail-safe that should cost no extra cycle. (Subs-BBC.php)
Re: New revs
« Reply #2148, on June 3rd, 2013, 11:49 PM »
rev 2148 -- only a partial fix, as I have more errors to look into, but apparently limited to me, so I'm not in a hurry, ah ah...
(2 files, 1kb)

! Fixed a missing 'return' in the last patch, causing a cascade of errors in notifications. (Class-Notification.php)

! I also have my share of untested code, though: a missing $st variable in the latest Subs-Cache refactoring. Uh oh. Now that fix looks ugly... (Subs-Cache.php)
Re: New revs
« Reply #2149, on June 4th, 2013, 08:05 PM »
rev 2149
(2 files, 1kb)

! I actually swapped parameters when calling cache_prepare_key, which is the reason why admins were getting 'undefined s' errors in the log. A big oops. I take it that everyone trusts my code so much, they don't review it, right..? I should feel honored :P (Subs-Cache.php)

! Fixed typo from Dragooon's original notifications contribution, which made periodical e-mails fail entirely, as the DB table couldn't be found. (Notifications.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2150, on June 5th, 2013, 01:59 AM »
8 modified, 1 file forgotten in the commit, 3KB

Revision: 2150
Author: arantor
Date: 05 June 2013 00:58:23
Message:
! Wrong variable was used, causing spurious errors. (Class-Notification.php)
! Move topics now generates notifications, thanks live627 for your contribution! NB: I haven't set it up for bulk maintenance. Interestingly enough, move topics does the old notifications system (sendNotifications call), but it isn't done in mass maintenance, and for now I'm not doing our notifications there either. (MoveTopic.php, Notifications.php, QuickMod.php, Notifications.english.php)
! Since we're now doing it through notifications, bye bye sending a PM. (MoveTopic.php, MoveTopic.template.php, ManageTopics language file)
----
Modified : /trunk/Sources/Class-Notification.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.french.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Re: New revs
« Reply #2151, on June 5th, 2013, 02:02 AM »
2 added, 2KB

Revision: 2151
Author: arantor
Date: 05 June 2013 01:01:05
Message:
! The notifier file I forgot to commit just now. (Move.php)
! The current contributors list. It's not 100% accurate at this point in time since we haven't updated getID3 to the MPL licenced version yet but we will be doing so shortly.
----
Added : /trunk/Sources/notifiers/Move.php
Added : /trunk/root/contributors.txt[1]
 1. Even the ASCII art in this file has attribution. Credit where credit is due.
Re: New revs
« Reply #2152, on June 5th, 2013, 06:08 AM »
4 files, 21KB

Revision: 2152
Author: arantor
Date: 05 June 2013 05:07:36
Message:
! Whoops, forgot some clean-up. (MoveTopic.php)
! Ability to search the language files in the language editor. Doesn't do other themes yet. Might need some polish. But it seems to work. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


(Btw, did I mention I only started this tonight?)

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #2153, on June 5th, 2013, 01:24 PM »
rev 2153
(8 files, 7kb)

! Got rid of a long-standing bug where, with Pretty URLs enabled, a name would occasionally drop out of the who's online list... Well, technically it's impossible to fix without being to reproduce, so I just added a fail-safe, and for the rest... Does it really matter? It happened once every six months, or something -- bot visits included. (Who.php)

* Restored personal_text modification to the profile area. Originally, I removed it to use thoughts instead, but since I decided to make it opt-in through the 'Posterity' feature, I might as well allow you to change it. And I might as well change my mind later. But I think once I've got privacy boxes set on this, it'll suddenly turn out to be all right to use it along with usertitle. Or something. Still, I think we really need to add some description of Personal Text and Personal Title below the options, because it can be confusing. I know it was to me, back in 2005 or something... (Profile-Modify.php)

* Translation. (ManageSettings.french.php, Notifications.french.php)

! Typos, including one in a variable name... 'Tis the season. ;) (ManageSettings.english.php, Notifications.english.php)

! Commenazi -- mostly a typo on the word 'readability', poetic irony. (Class-Notification.php)

* Vanity restyling of the language area search box. Don't bother. (ManageLanguages.template.php)

@ Note for Pete: feel free to revert the Who fix, if you're in a mood to spend a day trying to reproduce it, or something...
Re: New revs
« Reply #2154, on June 5th, 2013, 01:26 PM »
rev 2154 -- getting rid of bad hosts, and fixing license files.
(5 files +3-3, 14kb)

* Ensured that PCRE_VERSION is at least 7.2, otherwise Wedge won't work. See, I'm a supporter of the \h alias in regex, and I'm certainly not going to forfeit it for crappy hosts™. We never got any problems before, because PCRE 7.2 is bundled by default with PHP 5.2.4 (which happens to be our minimum PHP version for now), but Pete managed to find one of those crappy hosts™ that has PCRE 6.6 along with a more recent PHP... When you purposedly keep a 7-year-old version of a library on your servers, you shouldn't be trusted with other people's data, really. (readme_install.html, install.php, Install.language.php)

* Tweaked contributors file: harmonized 3-clause BSD/BSD 3-clause to Modified BSD; changed line breaks to CRLF instead of LF (we need everyone to be able to read this kind of file, including users of notepad.exe); added a realist's note about JW Player (yes, I'm still planning to get rid of it someday, don't worry...); and, replaced the ASCII logo with one that keeps the correct dimensions. That ASCII generator, to say the least, doesn't care a bit about proportions. (contributors.txt)

* Moved some of the non-critical root files to the actual root folder. (changelog.txt, license.txt, license_smf.txt)

@ Note for Pete: the minimum/recommended requirement paragraphs are very different across readme_*.html files, so we might want to harmonize them... And quickly, I guess!
Re: New revs
« Reply #2155, on June 6th, 2013, 07:49 PM »
rev 2155
(5 files, 2kb)

! Fixed wrong transparency values on avatars that are uploaded to a custom folder. Another waste of an afternoon... Why are there so many ways to use avatars, uh? (Class-System.php, Load.php)

- Removed unused getIcon() definitions. (notifiers/Likes.php, notifiers/Move.php)

* Small tweaks to notification avatar layout. (index.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2156, on June 6th, 2013, 11:51 PM »
3 modified, 4KB

Revision: 2156
Author: arantor
Date: 06 June 2013 22:51:11
Message:
! Allow admins to force send individual items from the mail queue. (ManageMail.php, ScheduledTasks.php, ManageMail.english.php)
----
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Re: New revs
« Reply #2157, on June 7th, 2013, 02:10 AM »
3 modified, 1KB

Revision: 2157
Author: arantor
Date: 07 June 2013 01:09:27
Message:
! Move notifier would throw undefined error to admins when displaying the move notification. (Move.php)
! Don't show likes by people you're ignoring. (Display.php, Like.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/notifiers/Move.php
Re: New revs
« Reply #2158, on June 7th, 2013, 03:53 AM »
7 files, 5KB

Revision: 2158
Author: arantor
Date: 07 June 2013 02:52:45
Message:
! All Thoughts did not get the correct thought's owner. (Thoughts.php)

! Admin can now choose whether to allow username/email, username only, email only logins. Might need to change the wording, as referred to in http://wedge.org/pub/feats/7243/username-does-not-exist-warning/ because it's also misleading in that now it might say username but refer to an email... but if we decide to nuke the difference between 'does not exist' and 'not correct' the problem mostly goes away. (Login2.php, ManageRegistration.php, Login.template.php, language files: Help, Index, ManageSettings)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Thoughts.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Re: New revs
« Reply #2159, on June 7th, 2013, 10:21 PM »
9 files, 18KB

Revision: 2159
Author: arantor
Date: 07 June 2013 21:21:01
Message:
! weget is going to need to support other methods in future. (Class-WebGet.php)

! Some refactoring fun of the search API ready for other search backends to be added in due course. (Load.php, ManageSearch.php, RemoveTopic.php, Search2.php, SearchAPI-Custom.php, SearchAPI-Standard.php, Subs-Post.php, ManageSearch.template.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/ManageSearch.template.php