New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1965, on March 1st, 2013, 04:32 AM »
I'm pretty sure I haven't broken anything, and on the contrary improved a few things. Even though it's only one set of functionality, I'm going to break it down because it has lots of itty bits.

(21 modified, 8KB)

Revision: 1965
Author: arantor
Date: 01 March 2013 03:30:39
Message:
- Search no longer needs its own menu item (Subs.php, index.css, index language file)
! There's no need for a silly toggle, especially now the option doesn't exist. (ManageSearch.php, install.sql, Help and Search language files)
! While I'm on the manage-search settings page, let's also drop a related setting into the mix, whether to display a CAPTCHA to guests doing searches. We already have the option, just making it more prominent. (ManageSearch.php)
! Link to the advanced search on the front page (index.template.php, index.css)
! Removing hidden parameter we don't need any more (index.template.php, SSI.php)
! Actually removing this simple/advanced nonsense. It made almost no difference anyway outside of the UI. (Search.php, Search2.php, PersonalMessage.php, Class-UnitTest_tidyhtml.php)
! Cleaned up and harmonised the searching templates, yes they actually look consistent now, check the advanced search vs PM search for yourself on the site before this commit is added to wedge.org if you don't believe me! (Search.template.php, PersonalMessage.template.php, sections.css)
! Turned over some of the PM search strings to the main search language file. Didn't go through everything but hit up the most obvious ones for now. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage language file)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/root/install.sql


! Also, I did NOT remove the image from the menu sprite, just the CSS declaration for it.

 search_overhaul1.png - 55.02 kB, 600x452, viewed 216 times.

 search_overhaul2.png - 30.22 kB, 600x277, viewed 237 times.

When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #1966, on March 1st, 2013, 11:36 AM »
rev 1966 -- maintenance.
(6 files, 2kb)

! Wrong variable name... Oops? (Class-CSS.php)

! Okay, I didn't realize I had so many $context['is_mobile'] calls last night, and I don't know why I stopped after a couple of these... Probably got distracted by another bug. Anyway, I'm leaving them as they were, but use SKIN_MOBILE as much as you like, even if that other variable is available. I just decided against adding a couple of milliseconds (microseconds??) to the execution time. (Display.template.php, Msg.template.php)

! Big error messages equal big error log crashes, most of the time. Limiting per-message bodies to 10KB (instead of 64KB), should be enough to deal with most cases. (ManageErrors.php)

- Well, one of the points of using <URL> is the pleasure of removing $scripturl from global calls... So, why don't we just do that..? ;) (ManageSearch.php)

- Removing a context variable we no longer need. (Load.php)
Re: New revs
« Reply #1967, on March 1st, 2013, 11:56 AM »
rev 1967 -- commit of love.
(4 files, 16kb)

* I hope no one minds... I've replaced that ugly filter.gif magnifier icon from SMF (used in search boxes, admin error log, and a couple of areas no one has ever noticed), with a much better, similar-looking icon based on the main menu search icon we just got rid of (but which I liked better, so there you go). I'm not 100% happy with it (notably the extra 1px of height that breaks some perfect alignments, but who will notice but me?), but it's 50 bytes smaller, and I also moved the search input's version into the menu sprite, so instead of wasting 220+ bytes in the CSS file for that, we're instead saving 25 bytes. All in all, a good move... I'm not 100% happy with the icon, but I can always revisit it later. Finally, note that the sprite icon is slightly offset to the right. This is to avoid background overlapping in the input box. (images/filter.gif, images/icons/sprite.png, other/images/sprite-menu-32bit.png, index.css)

* Reduced line-height of submit inputs, I guess they were still set to the Opera 'optimum', but since Opera will be moving to WebKit anyway, might as well use the WebKit optimal height now... (index.css)
Re: New revs
« Reply #1968, on March 1st, 2013, 01:04 PM »
rev 1968 -- ob-la-di, ob-la-da, life goes oooon...
(4 files, 2kb)

* Strict mode was complaining with Packer, too... Ahem. So, I had to add dummy variables here and there. And remove an entire function that was mistaken for the constructor. Well, technically, it's the author's fault in the first place, but it's okay, the function never was used anyway... (Class-Packer.php)

! Typos. (EmailTemplates.french.php)

! This translation needed to be viewed in context before it made sense to me, ah ah... (ManageSettings.french.php)

* Pathetic spacinazi. Someone hasn't taken their medication today... (JSEditor.php)
Re: New revs
« Reply #1969, on March 1st, 2013, 03:33 PM »
rev 1969 - I'm stepping through the door, and I'm floating in a most peculiar way...[1]
(6 files, 3kb)

+ As promised, here's a dropdown for the 'Advanced Search' link in the search box... It uses the HTML and CSS for main menus, adding about 12 gzipped bytes of HTML, 19 of CSS and 4 of JavaScript. It looks... All right. Especially for the cheap price.[2] (index.template.php, index.css, script.js)

* Simplified and improved the board list/label list areas in search pages. (PersonalMessage.template.php, Search.template.php)

! Fixed search input background in some pages. (sections.css)
 1. Remember an old sig of mine? :P
 2. Very interested in opinions! Should I switch to a mini-menu style instead..? It'll probably be a bit more expensive. And what about an Ajax-called panel? I'm still interested in doing that.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1970, on March 4th, 2013, 07:40 PM »
(8 modified, 3KB)

Revision: 1970
Author: arantor
Date: 04 March 2013 18:39:37
Message:
! $scripturl removal stuff, just a little bit more. (Help.php, Home.php, Mailer.php, ManageBoards.php, Register.template.php)
! Separate mail errors into their own log category. (Errors.php, Subs-Post.php, ManageMaintenance language file)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Re: New revs
« Reply #1971, on March 4th, 2013, 08:00 PM »
(20 files, 12KB)

Revision: 1971
Author: arantor
Date: 04 March 2013 18:57:32
Message:
+ Updating user agreement nonsense. There is no admin UI for it at present, mainly because there are some fun kinks I need to work out with it but in the meantime I want to get this all committed so it's recorded. (all files)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php


@ It may look as if I had forgotten to update active_state_change in a bunch of places. The point of so doing is to update it when it reached an *active* state change, i.e. some change that would make the account active. I think this all works, but it is not exactly tested yet. I also figured that an admin would be approving a user and ignore the need to reagree in the interim.
Re: New revs
« Reply #1972, on March 4th, 2013, 10:01 PM »
(30 modified, 6KB)

Revision: 1972
Author: arantor
Date: 04 March 2013 20:59:16
Message:
! More $scripturl removal. I was bored and not wanting to tackle much that was particularly brain troubling. (all files)
----
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Notify.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Stats.template.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #1973, on March 5th, 2013, 10:38 AM »
rev 1973 - Open your eyes, it's full of surprise, everyone lies, like the fox on the rocks, and the musical box.[1]
(4 files, 83kb)

* Updated jQuery 2.0 to beta 2. (Load.php, jquery-2.0.0b1.min.js, jquery-2.0.0b2.min.js)

! Fixed spellchecking not firing up in Quick Edit mode. Until we get to actually remove the SC feature entirely... (Display.template.php)
 1. Too many great albums for 1972-1973, had to choose between dozens so I took my favorite part of my favorite song of October 1972... Well, Pete took rev 1972 and didn't use it for references, so I'm calling dibbs! :P
Re: New revs
« Reply #1974, on March 5th, 2013, 05:10 PM »
rev 1974 - Dreamer, you know you are a dreamer...
(5 files +1-1, 85kb)

! Now that was an interesting commit... Reverting last one's update to jQuery 2.0 beta 2, because it has a nasty bug that causes all reqWin calls to break, and possibly more. While I could temporarily 'fix' this bug, I'd rather just downgrade because beta 1 was running fine. (Load.php, jquery-2.0.0b1.min.js, jquery-2.0.0b2.min.js)

* A few more Wess functions needed the static treatment. Not that it triggered any errors... I'm just trying to stick to strict standards (until I'm bored with it.) (Class-CSS.php)

* More strict fixes: array_shift(array_keys()) is better replaced with key(), at least on newly created arrays. Plus, it's strict. (ManageMemberOptions.php, ManagePlugins.php)

- Hmm, I didn't remember having left some ;xml strings in URLs here and there... Starting with the stats file. It works fine without them, of course. (stats.js)
Re: New revs
« Reply #1975, on March 5th, 2013, 07:39 PM »Last edited on March 8th, 2013, 03:30 PM
rev 1975 - Gallileo, Gallileo, Gallileo, Gallileo, Gallileo Figaro Magnifico[1]
(12 files, 8kb)

+ Replaced the Advanced Search pop-up link with a much better looking pop-up that comes up when you click the quick search input box (and pops out on click or tabbing outside of the form). It provides you with all of the advanced search options (except for the board list), and is loaded through Ajax so it doesn't add any bytes. Actually, it removes bytes from the HTML (although it also adds an extra line when inside a topic -- this needs more tweaking!). Adds more JS, of course, but what can I say... (script.js, Search.php, index.css, sections.css)

* Moved 'Advanced Search' and 'Search Results' language strings to Search language files. (Memberlist.php, index.language.php, Search.language.php)

+ Added a search scope select box. If you're within a topic, you can directly choose to search across the current board, or entire site. If you're in a board page, you can search across the entire site. (Search2.php, index.template.php, Search.template.php, Search.language.php, script.js)

! Oh, the agony... jQuery and IE8 don't cooperate when creating a new DOM node. While $('<div>') works perfectly everywhere, in IE7/8 it doesn't seem to close the element automatically, resulting in many issues. I'll only fix them one by one... Don't want to waste too many bytes because of that. (script.js)

* Should be doing my menu hack for all touch-enabled devices, rather than just Android. I'm sure iOS won't mind about it... (script.js) :edit: typo
 1. My fave 1975 albums are all instrumental... So I'm just going to pay homage to the cool guys who were born that year. 8-))
Re: New revs
« Reply #1976, on March 6th, 2013, 11:18 AM »
rev 1976 - Tê Tê Tê, Têtêretê. Tê Tê, Têtêretê. Tê Tê, Têtêretê. Tê Tê
(7 files, 3kb)

* Simplified JumpTo function to avoid a test in all index template executions. (Ajax.php, index.template.php, script.js)

* More $scripturl killings. (Split.php, Stats.php, Subs-Menu.php)

- Unneeded global. (Display.template.php)
Re: New revs
« Reply #1977, on March 6th, 2013, 07:11 PM »
rev 1977 - Nothing ever grows in this rotting old hole, Everything is stunted and lost, And nothing really rocks, And nothing really rolls, And nothing's ever worth the cost[1]
(8 files, 22kb)

+ Added mini-menus to All Thoughts page. Finally... Refactored some of the code, was hoping to be able to add them to thought contexts as well, but it'll be for another day. Hoping to harmonize it all some more, too. (Home.php, Thoughts.php, Home.template.php, Thoughts.template.php)

+ Added a 'Posterity' option to the thought mini-menu. This solves a problem of mine with thought privacy and personal texts. Originally, I made it so that any new public thought would become your personal text; however, I found myself posting private thoughts then changing them to public to circumvent this, in order to keep an older thought as my personal text. From now on, Wedge won't update automatically your personal text; you can set any thought of yours to be your personal text simply by selecting the Posterity option in its mini-menu. Of course, anyone feel free to rename the option and add an icon, such as a star or something... (Ajax.php, Thoughts.php, index.language.php, script.js)

* Translation. (index.french.php)
 1. This one's for Pete... After he suggested We will rock you and We are the champions, and then this, I thought it'd be funnier to say oldSMF's anthem rather than ours :niark:)
Re: New revs
« Reply #1978, on March 6th, 2013, 07:23 PM »
rev 1978 - With a smile of joy and gladness, with a look of exultation, as of one who in a vision sees what is to be, but is not, stood and waited Hiawatha.
(5 files, 4kb)

! A couple of fixes for quick search in Wuthering. (Wuthering/extra.css)

* Replaced the last remaining window.location with just 'location'... Well, there's another in the Media template, but I've made too many changes to it and can't commit that file yet, so it'll wait for another day. (PersonalMessage.template.php)

* Translation. (Login.french.php, ManageMaintenance.french.php, Profile.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1979, on March 6th, 2013, 10:30 PM »
(36 modified, 2 deleted, 4KB)

Revision: 1979[1]
Author: arantor
Date: 06 March 2013 21:26:35
Message:
! No more of this 'save in outbox' nonsense. It's saved automatically, even forcing the default for sendpm to save (because plugins doing it should default unless they *know* they don't want to), except for the places it shouldn't, like warning notifications and announcements. (install.sql, ManageMemberOptions.php, ManageNews.php, PersonalMessage.php, Subs-Post.php, PersonalMessage.template.php, Profile.template.php, PersonalMessage and Profile language files)

- Spell checking support removed from the bulk of code. Support does remain but only in the search area and even that might go. (index.php, detailed-version.php, Class-Editor.php, Display.php, Load.php, ManagePosts.php, Profile-Modify.php, Search2.php, Spellcheck.php, Subs-Media.php, Display.template.php, index.css, editor.js[2], language files: Admin, Help, index, ManageSettings, Post, Who)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/editor.js
Deleted : /trunk/Themes/default/scripts/spellcheck.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.sql
 1. You got me runnin', goin out of my mind,
You got me thinkin' that I'm wastin' my time.
Don't bring me down, no, no, no, no, no!
I'll tell you once more before I get off the floor:
Don't bring me down!
 2. I forgot these in the actual SVN log