(7 files, 15KB)
Revision: 1830
Author: arantor
Date: 08 January 2013 04:18:25
Message:
! Update the manage-mail area to use a proper button in place of a bare link, fixes a side issue with event-overridden links, but also looks more consistent. (ManageMail.php, ManageMail.template.php)
! The is-email-banned checks now should be querying the new bans system rather than the old, and it seems to work for both soft and hard bans (soft bans just prevent registration and guest posting using them, hard bans properly ban the session and leave a nice little banned cookie around), for all kinds of crazy things (exact match, wildcarded, entire domains, including handling GMail style dot removal and label use, and entire TLDs or parts thereof). Of course, the big work is done in Security.php, but the other places had their calls updated; we don't differentiate between 'cannot register' and 'cannot guest post' in terms of bans these days, it's really not needed. There is still work to do with the ban system; IP addresses need filtering out too, and then I need to replace updateBanMembers() with a version that works in the new banned world, but it's getting there. Then it needs MOAR testing. (Activate.php, Post2.php, Report.php, Security.php, Subs-Members.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManageMail.template.php
There is a lot left to do as I indicated, but most of the updateBanMembers calls were done in the admin panel where I can field it more easily; there's no need to call it when evaluating a ban for regular members as such - only need to evaluate the current user and fix their ban status.. ohcrap a typo I just realised.
Revision: 1830
Author: arantor
Date: 08 January 2013 04:18:25
Message:
! Update the manage-mail area to use a proper button in place of a bare link, fixes a side issue with event-overridden links, but also looks more consistent. (ManageMail.php, ManageMail.template.php)
! The is-email-banned checks now should be querying the new bans system rather than the old, and it seems to work for both soft and hard bans (soft bans just prevent registration and guest posting using them, hard bans properly ban the session and leave a nice little banned cookie around), for all kinds of crazy things (exact match, wildcarded, entire domains, including handling GMail style dot removal and label use, and entire TLDs or parts thereof). Of course, the big work is done in Security.php, but the other places had their calls updated; we don't differentiate between 'cannot register' and 'cannot guest post' in terms of bans these days, it's really not needed. There is still work to do with the ban system; IP addresses need filtering out too, and then I need to replace updateBanMembers() with a version that works in the new banned world, but it's getting there. Then it needs MOAR testing. (Activate.php, Post2.php, Report.php, Security.php, Subs-Members.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/ManageMail.template.php
There is a lot left to do as I indicated, but most of the updateBanMembers calls were done in the admin panel where I can field it more easily; there's no need to call it when evaluating a ban for regular members as such - only need to evaluate the current user and fix their ban status.. ohcrap a typo I just realised.