New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2640, on June 17th, 2014, 12:40 AM »
[Commit revision a15c895]
Author: Nao
Date: Tue, 17 Jun 2014 00:40:15 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Possible undefined index + array_diff error. (Load.php)
Re: New revs
« Reply #2641, on June 18th, 2014, 03:37 PM »
[Commit revision 2d3972e]
Author: Nao
Date: Wed, 18 Jun 2014 15:37:06 +0200
Stats: 2 files changed; +3 (insertions), -3 (deletions)
  • Unused globals. (ManageSettings.php, Home.template.php)
Re: New revs
« Reply #2642, on June 19th, 2014, 12:12 AM »
[Commit revision e4a72e0]
Author: Nao
Date: Thu, 19 Jun 2014 00:11:41 +0200
Stats: 1 file changed; +5 (insertions), -6 (deletions)
  • Don't show my Aeva Media credit if neither the gallery nor the embed engine are enabled. Makes sense, I gotta earn that one! (Credits.php)
Re: New revs
« Reply #2643, on June 20th, 2014, 12:29 PM »
[Commit revision 64b0fc9]
Author: Nao
Date: Fri, 20 Jun 2014 12:28:39 +0200
Stats: 3 files changed; +7 (insertions), -7 (deletions)
  • Profile redirects following a save operation should take sub-actions into account... I think? (Profile.php)
  • Fixed post-notification-save redirects. (Profile-Modify.php, Profile.template.php)
Re: New revs
« Reply #2644, on June 21st, 2014, 01:02 AM »
[Commit revision cf23d05]
Author: Nao
Date: Fri, 20 Jun 2014 13:05:31 +0200
Stats: 1 file changed; +1 (insertion), -7 (deletions)
  • One could say I'm slightly bored with some of the Wilde effects... (Wilde/extra.css)
[Commit revision 225151c]
Author: Nao
Date: Sat, 21 Jun 2014 01:02:02 +0200
Stats: 1 file changed; +3 (insertions), -3 (deletions)
  • @viewport being a peculiar command, Wess didn't actually support it properly, breaking everything in responsive IE10 and old Opera Classic. This is now fixed. Odd that no one actually ever reported this bug... (Class-CSS.php)
Re: New revs
« Reply #2645, on June 21st, 2014, 08:39 PM »
[Commit revision 46a408d]
Author: Nao
Date: Sat, 21 Jun 2014 20:32:04 +0200
Stats: 1 file changed; +5 (insertions), -3 (deletions)
  • Don't show homepage blurb titles if the associated blurb isn't available... (Home.template.php)
[Commit revision 4e72d52]
Author: Nao
Date: Sat, 21 Jun 2014 20:38:28 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)
  • In media item pages, images could overflow to the sidebar when shrinking the viewport width. (media.css)
Re: New revs
« Reply #2646, on June 21st, 2014, 08:47 PM »
[Commit revision 28125fa]
Author: Nao
Date: Sat, 21 Jun 2014 20:46:48 +0200
Stats: 5 files changed; +50 (insertions), -49 (deletions)
  • Oh, a big commit... Long time! This one shares a similar theme, namely theming. Well, what do you want.
  • Fixed crazy bug in Android 4.1's stock browser (couldn't test in 4.2 so I'm assuming it was still there), where board lists were hidden from view. It seems that the browser actually sees *:empty as always true, at least on table cells when they're rewired to a block display. Don't ask me, I have no idea why this was happening, but I fixed it by moving the :empty rule to a more specific area, and adding an @if test to further strengthen the fix, as well as serve as a reminder NOT to move that fix around. (sections.css)
  • Moving @viewport changes to the root skin, so that you don't have to add these everytime you're building a responsive layout... (sections.css, Wilderless/extra.css, Wireless/extra.css, Wuthering/extra.css... Why was this even in Wuthering, anyway..?!)
  • Bored with sidebar backgrounds... Really bored, and not responsive-friendly, it was basically an unsolvable problem. Removing them everywhere I can think of for now. (Wine/extra.css, Wuthering/extra.css)
  • In keeping with my spirit of making Wuthering more SMFesque, some extra tweaks. I won't reset cat/title headers to look more like SMF though, because I've always thought it looked amateurish. (Wuthering/extra.css)
  • Fixes to the experimental blog comment arrows. Only known issue for now is that they break on messages whose authors don't have an avatar. I don't know if I should force a default avatar to fix this, or just get rid of that funny little thing... (sections.css)
  • A couple of other minor tweaks to the root skin. Dunno if I should bestow that much power onto .wide, but as its name implies... (sections.css)
Re: New revs
« Reply #2647, on June 21st, 2014, 09:00 PM »
[Commit revision 1df974d]
Author: Nao
Date: Sat, 21 Jun 2014 21:00:06 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • I made so many changes to my skins over the course of Wedge's existence, and I recently came to realize that they were all mobile-friendly[1]. So I'm taking the (not so) bold step of acknowledging this, and adding this (relatively short) meta viewport HTML to all browsers, except for those who already have the @viewport at-rule in their CSS. (Why, Chrome, why, Firefox, why, Safari, aren't you adding proper support for this..? It SAVES BYTES!) (index.template.php)
 1. Except for a few areas, like the thought list, but I'll come back to that.
Re: New revs
« Reply #2648, on June 22nd, 2014, 07:56 PM »
[Commit revision 49fcb38]
Author: Nao
Date: Sun, 22 Jun 2014 17:04:01 +0200
Stats: 1 file changed; +24 (insertions), -3 (deletions)
  • Applying SMF 2.0.8 patch for member search. (Memberlist.php)
  • Note: of course, I'm not including the typo in that patch ($serach, REALLY??).
  • Note: if index.php looks for set_magic_quotes_*'s existence, why shouldn't this one occurrence do the same..? So I'm doing it.
  • Note: I'm not even sure there's a point in checking for slashes here anyway, since this field isn't being reused later. Leaving it in only because I have limited time to spend on this.
Re: New revs
« Reply #2649, on June 22nd, 2014, 09:07 PM »
[Commit revision 7f56622]
Author: Nao
Date: Sun, 22 Jun 2014 20:57:36 +0200
Stats: 21 files changed; +20 (insertions), -47 (deletions)
  • Rest of the 2.0.8 patch... memory_limit harmonization, and adding explicit ORDER BY b.board_order where requested. (Admin.php, Class-DB.php, ManageBoards.php, ManageMaintenance.php, MoveTopic.php, Profile-Modify.php, Profile-View.php, RepairBoards.php, Reports.php, Search.php, Split.php, Subs-Captcha.php, Subs-Graphics.php, Subs-Members.php, Subs-MessageIndex.php, ViewRemote.php, media/Aeva-Embed.php, media/Aeva-Gallery2.php, media/Class-Media.php, media/ManageMedia.php, media/ManageMedia3.php)
  • Note: I'm definitely not porting the hack removal in editor.js, because AFAIK it's still needed in Firefox and old Opera. Also, not removing ALTER TABLE ORDER BY queries for now, because (1) InnoDB doesn't mind about them, it just pretty much ignores them, and (2) it's really best for MyISAM to keep them around!
[Commit revision cacaf81]
Author: Nao
Date: Sun, 22 Jun 2014 20:58:53 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)
  • Just ensuring people who update manually notice the index.php is being updated with the memory_limit fix. (index.php)
[Commit revision ac18e94]
Author: Nao
Date: Sun, 22 Jun 2014 20:59:24 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Oh, and also the readme, but who reads these anyway..? (install/readme_install.html)
Re: New revs
« Reply #2650, on June 24th, 2014, 01:36 AM »
[Commit revision 8f34a6a]
Author: Nao
Date: Tue, 24 Jun 2014 01:36:15 +0200
Stats: 1 file changed; +17 (insertions), -0 (deletion)
  • Untested, but this should ensure contact lists aren't cluttered with deleted members, or deleted owners. (Subs-Members.php)
Re: New revs
« Reply #2651, on June 24th, 2014, 11:45 PM »
[Commit revision fbf25ff]
Author: Nao
Date: Tue, 24 Jun 2014 23:45:23 +0200
Stats: 4 files changed; +10 (insertions), -10 (deletions)
  • The HTML5 validator link will now be shown only to people with $db_show_debug permissions. Seriously, when it was cool for SMF to be XHTML-valid back in the 00's and boast about it, being HTML5-valid doesn't mean much these days, as HTML5 is so forgiving. It's just a geek thing, and will only be shown for debugging purposes if your HTML edits seem to break your pages. (Subs-Template.php, index.template.php, Stats.english.php, index.english.php)
Re: New revs
« Reply #2652, on June 26th, 2014, 08:26 PM »
[Commit revision ef87256]
Author: Nao
Date: Thu, 26 Jun 2014 20:25:43 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Can you believe this..? Ever since I added avatar caching in October 2010, the feature was broken, and no one ever noticed. It had to be me, hadn't it..? (OriginalFiles.php)
  • Only problem is, I'm still getting requests for these files on page reloads. They return code 304 (Not Modified) as expected, but what I'm trying to do is avoid the extra hits... Or maybe it's just Chrome ignoring caching in its dev tools, I don't know.
Re: New revs
« Reply #2653, on June 28th, 2014, 02:25 PM »
[Commit revision 59f2bb1]
Author: Nao
Date: Sat, 28 Jun 2014 14:18:42 +0200
Stats: 1 file changed; +14 (insertions), -0 (deletion)
  • Since loadMemberData accepts arrays of users, why shouldn't loadMemberContext and loadMemberAvatar do the same..? It's just a small shortcut for convenience. (Load.php)
[Commit revision 93302ec]
Author: Nao
Date: Sat, 28 Jun 2014 14:25:15 +0200
Stats: 2 files changed; +159 (insertions), -9 (deletions)
  • First basic implementation of the contact list editor. It's still disabled by default (you can enable it by changing the 'false' to 'true' in Profile.php's menu list, if you know what I mean), and the page only currently allows you to: view contacts with their avatars, remove them (as previously possible in user profile pages of course), and hide or unhide them. (Profile-Modify.php)
  • Hiding a contact won't do anything for now, since contacts are not shown to anyone anyway. But eventually, you'll be able to have people in your contact lists and have no one else know about it. Basically -- silent permissions.
Re: New revs
« Reply #2654, on June 29th, 2014, 08:56 PM »
[Commit revision 217c7ef]
Author: Nao
Date: Sun, 29 Jun 2014 20:56:04 +0200
Stats: 3 files changed; +21 (insertions), -5 (deletions)
  • Hooks now allow you to render a layer/block. This should allow (me? and plugins) to add hooks within existing templates and make it easier to extend them. The upcoming Flitter plugin rewrite showcases how to do this. Just you wait for a few minutes and check out the plugins repo. (Class-Skeleton.php, Subs.php)
  • Added a first_post_done hook to first posts on the page. This currently includes forum posts on pages 2 and beyond, which sucks, and I'm considering only triggering it for the actual first post in a topic. (Display.template.php)
Plugin revs »