New revs

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: New revs
« Reply #2610, on May 27th, 2014, 01:46 PM »
[Commit revision 9a253a4]
Author: Nao
Date: Tue, 27 May 2014 12:58:37 +0200
Stats: 4 files changed; +18 (insertions), -51 (deletions)

  • Remove $context['aeva_header'] and associated oddities. It was only there for compatibility with SMF 1.1, and... Well, we're in Wedge. (Aeva-Gallery.php, Aeva-ModCP.php, ManageMedia.template.php, Media.template.php)
  • Fixed weird media moderation page layout. (ManageMedia.template.php)

[Commit revision 99614a1]
Author: Nao
Date: Tue, 27 May 2014 13:45:56 +0200
Stats: 10 files changed; +39 (insertions), -65 (deletions)

  • Harmonized (some) pagesection divs. They smell a lot like code blocks that weren't being updated by the same people at the same time... (Display.template.php, GenericList.template.php, MessageIndex.template.php, index.template.php, extra.rtl.css index.css, index.member.css, sections.css)
  • The go up/go down JS code wasn't being used in topic lists, so I did that and used the opportunity to push more of that code to the JS file. (MessageIndex.template.php, topic.js)
  • template_button_strip no longer accepts a $direction but takes a $class directly instead. Makes more sense to me... Just add 'float' to your class name if need be. Also, buttonlist is now right-floated by default. (index.template.php, *.css)
  • I need more work to harmonize page sections. To be specific, I'm not thrilled with the whole floating thing, and would rather use some table cells or, better, flexboxes internally. We shall see...
Re: New revs
« Reply #2611, on May 27th, 2014, 01:50 PM »
[Commit revision fe64c8a]
Author: Nao
Date: Tue, 27 May 2014 13:50:11 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • My bad. (sections.css)
Re: New revs
« Reply #2612, on May 29th, 2014, 02:32 PM »
[Commit revision 03a3393]
Author: Nao
Date: Wed, 28 May 2014 09:11:03 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • Bad aspect ratio in Wilderless avatars. (extra.css)

[Commit revision 8b654af]
Author: Nao
Date: Wed, 28 May 2014 16:05:46 +0200
Stats: 3 files changed; +33 (insertions), -34 (deletions)

  • Went for a better styling of the board list. It's shorter code, gets us rid of eight !important hacks, looks better in all situations, and I used the opportunity to move the board icon to a variable, so that you can change it without having to update sizes and margins at the same time. (Boards.template.php, common.css, sections.css)

[Commit revision dfa1bdf]
Author: Nao
Date: Thu, 29 May 2014 14:31:32 +0200
Stats: 2 files changed; +56 (insertions), -58 (deletions)

  • Moved get_preferred_language to a we:: method, as it's only used there anyway... (Class-System.php, Subs.php)
  • Browser-preferred language map is no longer built manually, but rather from the list of installed packs. Much, much better... (Class-System.php)
  • This should also fix a few language bugs that were reported before (needs more testing). Thanks to CerealGuy for prompting me to do this rewrite!

[Commit revision 9c6859b]
Author: Nao
Date: Thu, 29 May 2014 14:32:11 +0200
Stats: 3 files changed; +14 (insertions), -2 (deletions)

  • Minor tweaks to make Warm, Wireless and Wilderless more tolerable. (*/extra.css)
Re: New revs
« Reply #2613, on May 29th, 2014, 05:04 PM »
[Commit revision c55862b]
Author: Nao
Date: Thu, 29 May 2014 17:03:40 +0200
Stats: 1 file changed; +15 (insertions), -10 (deletions)

  • Fixed a Pete bug from exactly a year ago: if the cache entry for $context['languages'] had expired, the newly cached version would return (for this page load) the full list of languages, not just the available ones. As a result, purging the entire cache tended to cache unused language icons, which was a really bad thing until recently when I optimized their sizes. Anyway, that one's finally fixed... (Load.php)
Re: New revs
« Reply #2614, on May 29th, 2014, 09:00 PM »
[Commit revision 553d66e]
Author: Nao
Date: Thu, 29 May 2014 21:00:05 +0200
Stats: 1 file changed; +0 (insertion), -2 (deletions)

  • Transifex thinks that commented-out strings are still translatable, so until I determine whether we'll use that for distributed translations, I'm removing the only commented out string I could find. (Profile.english.php)
Re: New revs
« Reply #2615, on May 29th, 2014, 11:55 PM »
[Commit revision e4fbaa3]
Author: Nao
Date: Thu, 29 May 2014 23:55:10 +0200
Stats: 3 files changed; +23 (insertions), -1 (deletion)

  • Having some wicked fun with blog comment styling, adding a bubble speech effect next to the avatar. I used the 'traditional' triangle technique for this, because it's easier to position it precisely. Also disabled it on mobile-friendly skins, because it wouldn't make sense in there. (Wilderless/extra.css, Wireless/extra.css, sections.css)
  • I'll remove the effect if it's rejected by the community. I just thought it would be fun for a change, plus it shows that you can easily remove the effect through a .blog reset command.
Re: New revs
« Reply #2616, on May 30th, 2014, 12:28 AM »
[Commit revision 9ab15f5]
Author: Nao
Date: Fri, 30 May 2014 00:28:27 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)

  • One of those inheritance thingies... (Wine/extra.css)
Re: New revs
« Reply #2617, on May 30th, 2014, 01:54 PM »
[Commit revision d1085d7]
Author: Nao
Date: Fri, 30 May 2014 13:54:33 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Enabling cache level >= 2 would generate 'query_see_topic' errors for guests visiting board indexes. (Load.php)
Re: New revs
« Reply #2618, on June 1st, 2014, 05:37 PM »
[Commit revision e775f37]
Author: Nao
Date: Sun, 01 Jun 2014 17:37:37 +0200
Stats: 2 files changed; +21 (insertions), -16 (deletions)

  • Fixing installer crash, hopefully elegantly. (install.php, Class-System.php)
  • If a language was stored in the session variable, disabling that language from the admin area would cause problems. (Class-System.php)
  • Testing requested!
Re: New revs
« Reply #2619, on June 2nd, 2014, 07:45 PM »
[Commit revision a05be18]
Author: Nao
Date: Mon, 02 Jun 2014 19:45:10 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Last minute change caused installer not to try and recognize browser language preferences. (install.php)
Re: New revs
« Reply #2620, on June 3rd, 2014, 12:52 AM »
[Commit revision 237996d]
Author: Nao
Date: Tue, 03 Jun 2014 00:51:41 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Fixed the ability to access a forum flawlessly through its IP address. (Needs testing with Pretty URLs enabled.) (QueryString.php)
Re: New revs
« Reply #2621, on June 4th, 2014, 12:51 AM »
[Commit revision b0e0c47]
Author: Nao
Date: Tue, 03 Jun 2014 19:24:15 +0200
Stats: 1 file changed; +6 (insertions), -5 (deletions)

  • Wess didn't allow @if tests to evaluate lone variables as boolean if they were set to an empty string (e.g. $window_bg = '', @if $window_bg background: $window_bg @endif didn't work), while 'false' and '0' values worked fine. I like single-byte fixes. (Class-CSS.php)
  • Still in Wess, non-math() functions were only allowed to use unit-less parameters, e.g. with $var = 6px, math($var / 3) was allowed, but round(math($var / 3)) wouldn't work because it was parsed to round(2px). It should now properly return '2px'. (Class-CSS.php)

[Commit revision 05e76c9]
Author: Nao
Date: Tue, 03 Jun 2014 23:50:25 +0200
Stats: 1 file changed; +4 (insertions), -3 (deletions)

  • Also applied previous emptiness fix to @elseif commands. (Class-CSS.php)
  • Empty @elseif commands were internally seen as empty strings and explicitly seen as 'true', when I should have set them to 'true' directly, and ensured that an empty string is a no-go. This is more logical. (Class-CSS.php)
  • Wess will now automatically dismiss properties with empty contents. For instance, "background: $bg" no longer needs to be enclosed in an "@if $bg" test to ensure skinners can disable the background. Please note that @if $bg would still be necessary in situations where the property uses the variable but adds something else to it, for instance "background: $bg, $bg2" or something like that. (Class-CSS.php)
  • I've updated my CSS files to reflect this change, but they're not ready for commit right now, so it'll have to wait more.

[Commit revision 030011b]
Author: Nao
Date: Wed, 04 Jun 2014 00:03:52 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Wrong language string. (ModerationCenter.template.php)

[Commit revision 06daf04]
Author: Nao
Date: Wed, 04 Jun 2014 00:05:10 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Wow, a CSS typo! Woot! (mana.css)

[Commit revision 50a3205]
Author: Nao
Date: Wed, 04 Jun 2014 00:50:59 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • Moved topic notifications weren't outputting the proper URL in e-mails. (notifiers/Move.php)
Re: New revs
« Reply #2622, on June 4th, 2014, 05:24 PM »
[Commit revision bdaf6e6]
Author: Nao
Date: Wed, 04 Jun 2014 16:50:27 +0200
Stats: 4 files changed; +26 (insertions), -18 (deletions)

  • Moved the credits page's Special Thanks area to the contributors file, shortened the Aeva Media copyright information, all for a shorter forum credits section. (contributors.txt, Credits.php, Who.english.php)
  • The site team section on that page now shows avatars. Wanted to do that for a long time, but... (Credits.php, Who.template.php)

[Commit revision 4cbe1d5]
Author: Nao
Date: Wed, 04 Jun 2014 16:54:12 +0200
Stats: 3 files changed; +13 (insertions), -11 (deletions)

  • Moved title icons to the right of titles in the default homepage. I thought it looks better. (Boards.template.php, Home.template.php, Thoughts.template.php)

[Commit revision 9edbf47]
Author: Nao
Date: Wed, 04 Jun 2014 16:58:28 +0200
Stats: 2 files changed; +9 (insertions), -6 (deletions)

  • Fixes for the menu. The recent rewrite made it impossible to click an area without text, just like in the good old IE days, and I failed to notice it immediately. New method is better anyway, as sub-menu icons are now clickable... (index.template.php, index.css)

[Commit revision 1e7da76]
Author: Nao
Date: Wed, 04 Jun 2014 17:02:30 +0200
Stats: 1 file changed; +13 (insertions), -3 (deletions)

  • A few tweaks for easier handling of $main_bg and $head_bg variables, or lack thereof. (index.css)
  • I miss the brackets around page numbers... Sue me. I only changed them to use normal weights. (index.css)

[Commit revision fe55139]
Author: Nao
Date: Wed, 04 Jun 2014 17:05:52 +0200
Stats: 2 files changed; +9 (insertions), -16 (deletions)

  • I'm not sure this'll work everywhere (it does for me), but I'm trying a fix for menus not reopening when coming back to a previous page. It's also shorter than the previous code, so... Good. (script.js, index.css)

[Commit revision 6bd39b6]
Author: Nao
Date: Wed, 04 Jun 2014 17:07:11 +0200
Stats: 1 file changed; +14 (insertions), -0 (deletion)

  • Added basic documentation for skin.xml-based skeleton operations. I thought I'd already done that, sorry... (Warm/skin.xml)

[Commit revision 20d0ddf]
Author: Nao
Date: Wed, 04 Jun 2014 17:08:00 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • Improvements to the responsive board list layout. This time, it should be close to perfection... (sections.css)

[Commit revision a42fc9d]
Author: Nao
Date: Wed, 04 Jun 2014 17:22:11 +0200
Stats: 2 files changed; +10 (insertions), -5 (deletions)

  • Wuthering board list gets a bit more simplemachinesque. Also fixed menu height. (Wuthering/extra.css)
  • Fixed multi-line linktrees in Wilde. Also fixed menu height. (Wilde/extra.css)

[Commit revision bd0fb17]
Author: Nao
Date: Wed, 04 Jun 2014 17:23:48 +0200
Stats: 1 file changed; +14 (insertions), -18 (deletions)

  • Pete bug: moderation filters were broken when specifying a 'contains this regex' rule. Hopefully this fixes it. (Subs-Moderation.php)
Re: New revs
« Reply #2623, on June 5th, 2014, 12:41 AM »
[Commit revision 193e65e]
Author: Nao
Date: Thu, 05 Jun 2014 00:41:34 +0200
Stats: 2 files changed; +6 (insertions), -2 (deletions)

  • Fixed CSS variables again. This time, variables inside @if/@is tests will automatically be surrounded by double quotes, saving you the need to add them. I'll be honest with you, though: (1) @is is untested, (2) this contradicts my latest changes to the system, wherein an @if test could hold an empty parameter, (3) this implies that all variable tests are loosely typed. But it should also, and that's what I've been looking for, allow you to do @if $non_boolean_var tests without trouble. I apologize for the mess, but I have other things on my mind these days, like my baby coming up. (Class-CSS.php)
  • As per the previous tweak, $view_junk no longer requires double quotes. (index.css)
  • Ah, the joys of CSS precedence... #wedge > div would always trump #header, not the other way around... (index.css)
  • I'd appreciate if someone else could test these changes thoroughly for me. It'll benefit everyone in the long term.
Re: New revs
« Reply #2624, on June 6th, 2014, 12:37 AM »
[Commit revision c5f9211]
Author: Nao
Date: Thu, 05 Jun 2014 15:57:18 +0200
Stats: 3 files changed; +0 (insertion), -7 (deletions)

  • #greeting doesn't really need styling... I'm leaving the ID in, but removing its styles. (index.member.css, Wilderless/extra.css, Wireless/extra.css)

[Commit revision c98b184]
Author: Nao
Date: Fri, 06 Jun 2014 00:34:55 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)

  • Fixed margin between site news and linktree in Wilderless. (Wilderless/extra.css)

[Commit revision 8910be3]
Author: Nao
Date: Fri, 06 Jun 2014 00:37:18 +0200
Stats: 2 files changed; +7 (insertions), -9 (deletions)

  • Added $wehead_bg and $wefoot_bg variables to make it easier to change background colors for .wehead and .wefoot, as the name says. (Wine/extra.css, common.css)
  • Minor tweaks. (common.css)