New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1110, on October 14th, 2011, 02:07 PM »
Revision: 1110
Author: arantor
Date: 13:06:48, 14 October 2011
Message:
! Rename the actions hook to action_list; there was a conflict with how the action handler was handled in the plugin cache, causing it to dump any references for the actions hook. (ManagePlugins.php, index.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/index.php
Re: New revs
« Reply #1111, on October 14th, 2011, 03:13 PM »
Revision: 1111
Author: arantor
Date: 14:12:50, 14 October 2011
Message:
! When removing a plugin, don't just purge the entry from the scheduled tasks list, also make sure to purge the log of having carried them out. The log entries aren't available anyway because of the INNER JOIN. (ManagePlugins.php)
! Allow for - in language file names, e.g. Birthday-Admin.language.php. Stupid non-actual-bug. (ManageServer.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageServer.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #1112, on October 14th, 2011, 11:46 PM »
rev 1112
(7 files, 11kb)

* Replaced a few dozen $scripturl calls with <URL>, just to get the hang of it... It doesn't impact performance (positively or negatively), and it still requires checking all occurrences one by one (can't use <URL> inside a JSE call for instance), so I doubt I'll be converting everything... (Display.template.php, PersonalMessage.template.php, Who.template.php)

* Moved profile link replacements for guests to below the scripturl replacement code, to make sure we can use <URL> in profile links. (Subs-Template.php)

* Renamed 'last_msg' to 'last' in Quote links, if only because the 'quote' variable doesn't have '_msg' in it either. And it's shorter. (Post.php, Post2.php, Display.template.php)

! Fix for signature header size in profiles... Whatever. (sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1113, on October 16th, 2011, 03:21 AM »
(removed 2, modified 42, 37KB)

Revision: 1113
Author: arantor
Date: 02:20:45, 16 October 2011
Message:
! Probably the most scary commit for me personally since working on Wedge: removing OpenID and all its tendrils into the system, because it's integrated into the login, registration, reminder etc. systems. I don't think I've broken anything, I've gone through and tested logging in and out, registration, reminders and changing password in profile and everything seems to be working as expected, even with throwing invalid passwords as it. It's being removed because it should really be a plugin but I'm not really planning on building a plugin out of this code, because it's OpenID 1.1 not 2.0, and honestly, there are number of implementation details that don't sit right anyway. (index.php, install.*, SSI.php, Class-UnitTest.php; Sources: Class-DBPackages, Load, Login2, Logout, ManageRegistration, Profile-Modify, Profile, QueryString, Register, Reminder, ScheduledTasks, Security, Subs-Login, Subs-Members, Subs-OpenID (removed); Templates: index, Login, Profile, Register, Wireless; CSS: index.guest, index.rtl, Wuthering/index.rtl; Languages: EmailTemplates, Errors, Help, index, Login, Profile, Who; also removed openid.gif)

! Random bug when changing the password in profile, if it had too few characters, the un-sprintf'd string was used. (Subs-Members.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Deleted : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Deleted : /trunk/Themes/default/images/openid.gif
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/Wuthering/index.rtl.css
Modified : /trunk/Themes/default/skins/index.guest.css
Modified : /trunk/Themes/default/skins/index.rtl.css
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest.php

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #1114, on October 16th, 2011, 10:36 AM »Last edited on October 16th, 2011, 10:46 AM by Nao
rev 1114
(x files, 10kb - And thank you Pete for taking the time to specify your commit sizes now :))

* SEO optimizations. Shh!

* Converted all $scripturl to <URL> in the index template. There can be only one! (index.template.php)

- A couple more deletions related to OpenID. I believe openid_uri should be removed as well, and reinstalled by the plugin... If someone wants to convert an SMF install to Wedge, they could install Wedge, enable the OpenID plugin (if it exists), and then do the importing. (install.sql, upgrade.sql, xml/detailed-version.php)
Re: New revs
« Reply #1115, on October 17th, 2011, 04:36 PM »
rev 1115
(2 files, 6kb)

* Improved year trimming code in timeformat() to account for more possible time formats. (Subs.php)
- Removed another $txt['time_am/pm'] reference. (Subs.php)
- Removed another OpenID reference. (upgrade.sql)
Re: New revs
« Reply #1116, on October 17th, 2011, 04:52 PM »
rev 1116
(8 files, 9kb)

+ Added membergroup color to user links. Logic dictates that this should be done. (And that's when you begin to realize that red isn't such a great color for the admin group...) (Load.php)

- Replaced $txt['profile_of'] with $txt['view_profile'] to avoid stupid repetitions. There's no such thing as free bandwidth. (Load.php, MessageIndex.php, Search2.php, Unread.php, UnreadReplies.php, Who.template.php, index.language.php)
Re: New revs
« Reply #1117, on October 17th, 2011, 09:34 PM »
rev 1117
(8 files, 9kb)

+ Added a $txt['time_format_this_year'] string that contains the year-less time format string, for faster processing in timeformat(). (Subs.php, index.language.php)

- Removed the last remains of the OpenID code... Hopefully. (Class-UnitTest.php, Register.php, Subs-Members.php)

! It's AM/PM, not am/pm... As sad as it sounds. (Help.language.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1118, on October 18th, 2011, 04:13 PM »
(303KB[1], added 2, modified 4)

Revision: 1118
Author: arantor
Date: 15:10:30, 18 October 2011
Message:
! Fix for QueryString not urldecoding as it should (thanks TE) (QueryString.php)

! Missing hooks should have been declared in plugin manager (ManagePlugins.php)

! Part of the works for supporting file permission changes in the plugin manager. It's horribly unfinished right now but I want to commit it because even right now it's actually an improvement on where we were - for cases where FTP/SFTP is not required, it actually works properly in being able to recursively delete things, and it has been built in such a way that extending it to FTP/SFTP shouldn't be a slog; I've actually designed it around having file-changing classes that it should be able to interchangably use, Class-FileWritable for locally writable cases (though it doesn't use that as thoroughly as it should, it should be checking the entire permissions of every file/dir under consideration, not just the first level!), Class-FTP or Class-SFTP for where S/FTP connectivity is needed. Class-SFTP has not been tested since I made my changes to phpseclib, so it's probably broken too - or it might be, if I actually put in the relevant dialogue, which I haven't yet. Just wanted to get something committed where it actually works in a meaningful way compared to what it was before! This is, then, very much still a WIP. (Don't worry about reviewing Class-SFTP at this stage...) (ManagePlugins.php, Subs-Plugins.php, ManagePlugins language file, ManagePlugins.template.php, Class-FileWritable.php, Class-SFTP.php)
----
Added : /trunk/Sources/Class-FileWritable.php
Added : /trunk/Sources/Class-SFTP.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php

@ Yeah, this is probably a bit earlier than it should have been, but a few notes on the design of it. The idea is that getWritableObject() is essentially the same construct as create_chmod_control but without having to be so formal about it. Either it'll return you a usable object with which you can do file operations, or it'll take you to a dialogue to enter S/FTP connection details. Or it would if the dialogue was any more than a placeholder.

It is still incredibly raw but it's getting there.
 1. As noted in the changelog the vast bulk of this is Class-SFTP, which doesn't need reviewing at this time unless you're feeling very, very brave. It's probably slightly broken anyway.

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #1119, on October 18th, 2011, 05:57 PM »
rev 1119
(7 files, 8kb)

* Microsecond optimization. I'm only doing this because it's in the cache code, and the cache is all about speed... (Subs-Cache.php)

* String concatenation optimization. As if. (Display.template.php)

* Typos. (ManagePlugins.english.php, ManagePlugins.php)

* Translation. (ManagePlugins.french.php)

! The two new files were missing the closing '?>'. I know it's not that bad, but if we should do it for one, we should do it for all of them ;) (Class-FileWritable.php, Class-SFTP.php)
Re: New revs
« Reply #1120, on October 18th, 2011, 06:34 PM »
rev 1120
(11 files, 19kb)

+ Wedge will now happily use the membergroup's color when showing profile links -- all the time, instead of just in the Who's Online list and info center. (Subs-Template.php, Subs.php, ManageMembers.language.php)

* Changed default admin and global moderator membergroup colors to something neater that doesn't jump at you. Added a default color for the Hero group (i.e. members with over 500 posts.) (other/install.sql)

- Removed group color retrieval queries from Who's Online and Info Center, since this is being handled elsewhere now. (Subs-MembersOnline.php, Who.php, Who.template.php)

- Removed ability to sort online members by group color... Did anyone actually know this was possible? And what was the point, considering sorting by group name is also possible? (Subs-MembersOnline.php)

- SSI's ssi_recentTopics() never made use of membergroup colors either. (SSI.php)

* I like #c06002 as a color, but h4 (poster name in display template) will now be a virgin when it comes to default color. (sections.css)

+ Profile pages will now show the group/post-group color on the user name, even though it's not technically a profile link. (Profile.template.php)
Re: New revs
« Reply #1121, on October 19th, 2011, 10:55 AM »
rev 1121
(16 files, 21kb)

* Updated mini-logos with the current stuff. (images/minilogo*.png)

* Allow show_group_key to show post-based groups instead of just regular groups. The reason? If you're setting a special color for high-level posters, wouldn't you want people to be able to browse them...? (Subs-Membergroups.php)

- Removed $txt['or'], which was only used when OpenID was enabled. I guess I'm good at spotting this kind of crap. Plus, we want to avoid generic word translations as much as possible. I never knew the generic Japanese word for that, come to think of it. Is that または? Hey, SVN supports complex languages, that's cool. Oh yeah, the changelog. (index.language.php)

* Renamed $txt['all'] to $txt['all_pages'], to prevent plugins from reusing it for other purposes. See, in French, 'all' is either 'tout', 'tous' or 'toutes', depending on the context. How are we supposed to act when the plugin provides no context? (index.language.php, Display.php, MessageIndex.php, Unread.php, UnreadReplies.php)

* Renamed $txt['unread_topics_all'] to $txt['unread_topics'], because we no longer have the alternative anyway. Also updated URLs to remove ';all' from them and related logic. (index.language.php, Unread.php, UnreadReplies.php, Recent.template.php)

- 'group_index' is a non-existent block... Good work, eh. (Groups.php)

- $footer_bg is used in Warm, not Wine. (index.css, Warm/index.css)

* Had some weird, dangerous fun with Warm... Okay, okay, I'm letting it go now. (Warm/index.css)

* Reordered field lists in loadMemberData's giant queries. Because it looks cooler. (Load.php)

* Info center needs more breathing space in Welcome. I think. (Welcome.template.php)

* Spacinazi. (ManageMembergroups.template.php)
Re: New revs
« Reply #1122, on October 19th, 2011, 04:31 PM »
rev 1122
(6 files, 11kb)

+ Added support for external CSS file loading in skin files (<css include="">). (Subs-Cache.php)

+ Added an example in the form of Warm now using Droid Sans by default, retrieved from Google WebFonts. (Warm/index.css, Warm/skin.xml)

* File lists in JS and CSS includes inside skin files, now need to be separated by spaces, instead of a comma. True enough, commas may be used in URLs while spaces are always urlencoded... (Subs-Cache.php, Warm/skin.xml, Wuthering/skin.xml)

* Minor fixes. (Reports.php, index.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1123, on October 20th, 2011, 02:59 AM »
(42K, added 2, modified 10)

Revision: 1123
Author: arantor
Date: 01:56:49, 20 October 2011
Message:
! Replace fetch_web_data with Class-WebGet, which supports cURL, arbitrary ranges and headers. (Class-WebGet.php, upgrade.php, ManageServer.php, PackageGet.php, Profile-Modify.php, ScheduledTasks.php, Subs-Graphics.php, Subs-Package.php, Subs-Template.php, Themes.php)

! Replace the url_image_size routine with a newer one that doesn't require the whole file. It works nicely on GIF and PNG and the vast majority of JPEGs (at least in my testing) without having to go and download however big the file actually is, which should limit timeouts and stuff like that. (Subs.php)

! Subs-Plugins appears not to have been committed before for some reason (should have been in 1118) :/
----
Added : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Package.php
Added : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/other/upgrade.php

@ I have no idea why Subs-Plugins wasn't committed before but there's no reason why it shouldn't have been.

@ There is still a fetch_web_data function in the webinstaller, mostly because it comes with its own version, rather than using anything in the core (because that's the point)

@ Also, no idea why this commit is so big.
Re: New revs
« Reply #1124, on October 20th, 2011, 03:05 AM »
Revision: 1124
Author: arantor
Date: 02:05:35, 20 October 2011
Message:
! Stupid, stupid syntax error where I wasn't developing directly on the SVN files, and forgot to copy all the changes across properly. (Subs.php)
----
Modified : /trunk/Sources/Subs.php